{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBiological.jl/issues/42","repository_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBiological.jl","labels_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBiological.jl/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBiological.jl/issues/42/comments","events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBiological.jl/issues/42/events","html_url":"https://github.com/JuliaDiffEq/DiffEqBiological.jl/issues/42","id":310830249,"number":42,"title":"Add RegularJumps","user":{"login":"Gaussia","id":18099310,"avatar_url":"https://avatars2.githubusercontent.com/u/18099310?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaussia","html_url":"https://github.com/Gaussia","followers_url":"https://api.github.com/users/Gaussia/followers","following_url":"https://api.github.com/users/Gaussia/following{/other_user}","gists_url":"https://api.github.com/users/Gaussia/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaussia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaussia/subscriptions","organizations_url":"https://api.github.com/users/Gaussia/orgs","repos_url":"https://api.github.com/users/Gaussia/repos","events_url":"https://api.github.com/users/Gaussia/events{/privacy}","received_events_url":"https://api.github.com/users/Gaussia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-03T13:10:39Z","updated_at":"2018-04-08T22:30:51Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Right now we create a set of `ConstantRateJump`s, possibly including a few `VariableRateJump`s.\r\n\r\nHowever recently `RegularRateJumps` have been added. We could add this to the `reaction_network` DSL as well. Looking at the syntax the difference is that for a `RegularRateJumps` you put everything into only one function each for rate and affect, it should be no problem doing the same in `reaction_network`. \r\n\r\nWe would have to decide which type of `JumpProblem` should be generated by default though."},"comment":{"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBiological.jl/issues/comments/379588110","html_url":"https://github.com/JuliaDiffEq/DiffEqBiological.jl/issues/42#issuecomment-379588110","issue_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBiological.jl/issues/42","id":379588110,"user":{"login":"isaacsas","id":9385167,"avatar_url":"https://avatars0.githubusercontent.com/u/9385167?v=4","gravatar_id":"","url":"https://api.github.com/users/isaacsas","html_url":"https://github.com/isaacsas","followers_url":"https://api.github.com/users/isaacsas/followers","following_url":"https://api.github.com/users/isaacsas/following{/other_user}","gists_url":"https://api.github.com/users/isaacsas/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacsas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacsas/subscriptions","organizations_url":"https://api.github.com/users/isaacsas/orgs","repos_url":"https://api.github.com/users/isaacsas/repos","events_url":"https://api.github.com/users/isaacsas/events{/privacy}","received_events_url":"https://api.github.com/users/isaacsas/received_events","type":"User","site_admin":false},"created_at":"2018-04-08T22:30:51Z","updated_at":"2018-04-08T22:30:51Z","author_association":"CONTRIBUTOR","body":"Just to clarify; any `ConstantRateJump` that can be represented as a normal mass action reaction can be represented as a `MassActionJump`. Things like Hill functions would still need to be `ConstantRateJumps`.\r\n\r\n\r\nGaussia, since you already handle the scaling you can just pass the `MassActionJump` constructor the optional `scale_rates=false` flag. That will turn off the scaling so it isn't applied twice."}}
{"actor":{"display_login":"isaacsas"}}