{"action":"created","issue":{"url":"https://api.github.com/repos/NModbus/NModbus/issues/20","repository_url":"https://api.github.com/repos/NModbus/NModbus","labels_url":"https://api.github.com/repos/NModbus/NModbus/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/NModbus/NModbus/issues/20/comments","events_url":"https://api.github.com/repos/NModbus/NModbus/issues/20/events","html_url":"https://github.com/NModbus/NModbus/issues/20","id":320707247,"node_id":"MDU6SXNzdWUzMjA3MDcyNDc=","number":20,"title":"ReadWriteMultipleRegisters datapacket incorrect","user":{"login":"artkat","id":3071447,"node_id":"MDQ6VXNlcjMwNzE0NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/3071447?v=4","gravatar_id":"","url":"https://api.github.com/users/artkat","html_url":"https://github.com/artkat","followers_url":"https://api.github.com/users/artkat/followers","following_url":"https://api.github.com/users/artkat/following{/other_user}","gists_url":"https://api.github.com/users/artkat/gists{/gist_id}","starred_url":"https://api.github.com/users/artkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artkat/subscriptions","organizations_url":"https://api.github.com/users/artkat/orgs","repos_url":"https://api.github.com/users/artkat/repos","events_url":"https://api.github.com/users/artkat/events{/privacy}","received_events_url":"https://api.github.com/users/artkat/received_events","type":"User","site_admin":false},"labels":[{"id":585622669,"node_id":"MDU6TGFiZWw1ODU2MjI2Njk=","url":"https://api.github.com/repos/NModbus/NModbus/labels/bug","name":"bug","color":"ee0701","default":true},{"id":585622672,"node_id":"MDU6TGFiZWw1ODU2MjI2NzI=","url":"https://api.github.com/repos/NModbus/NModbus/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-07T07:50:18Z","updated_at":"2018-06-07T20:33:11Z","closed_at":null,"author_association":"NONE","body":"The ReadWriteMultipleRegisters (Function code 23) only sends the address, function code and checksum. The data etc is missing.\r\n\r\nExample:\r\nmaster.ReadWriteMultipleRegistersAsync(0x99, 0x11, 3, 0x22, new ushort[] { 0xaabb, 0xccdd });\r\nonly sends (ASCII)  :991750\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NModbus/NModbus/issues/comments/395555432","html_url":"https://github.com/NModbus/NModbus/issues/20#issuecomment-395555432","issue_url":"https://api.github.com/repos/NModbus/NModbus/issues/20","id":395555432,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTU1NTQzMg==","user":{"login":"Fuchks","id":3790581,"node_id":"MDQ6VXNlcjM3OTA1ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3790581?v=4","gravatar_id":"","url":"https://api.github.com/users/Fuchks","html_url":"https://github.com/Fuchks","followers_url":"https://api.github.com/users/Fuchks/followers","following_url":"https://api.github.com/users/Fuchks/following{/other_user}","gists_url":"https://api.github.com/users/Fuchks/gists{/gist_id}","starred_url":"https://api.github.com/users/Fuchks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fuchks/subscriptions","organizations_url":"https://api.github.com/users/Fuchks/orgs","repos_url":"https://api.github.com/users/Fuchks/repos","events_url":"https://api.github.com/users/Fuchks/events{/privacy}","received_events_url":"https://api.github.com/users/Fuchks/received_events","type":"User","site_admin":false},"created_at":"2018-06-07T20:33:11Z","updated_at":"2018-06-07T20:33:11Z","author_association":"NONE","body":"Can confirm this behaviour, on TCP it works just fine (Tested with [Ananas](http://www.tuomio.fi/ananas/)).\r\n\r\nAs I do not have any ascii client at hand, I tested it with a fake implementation of SerialPort and SerialPortAdapter that gives access to the stream that would be sent over serial line.\r\n\r\nReadWriteMultipleRegisters does an aggregation of ReadHoldingRegisters and WriteMultipleRegisters in code for the request, both individual perform as expected.\r\n\r\nI would assume that the problem is located in ReadWriteMultipleRegistersRequest at the part of aggregation, but as debugging of nuget packages is a pain, I currently cannot dive deeper into it.\r\n\r\n\r\nOn request I would provide the fake implementation of SerialPort and SerialPortAdapter, but they are quick & dirty ;-)"}}
{"actor":{"display_login":"Fuchks"}}