{"action":"created","issue":{"url":"https://api.github.com/repos/larshp/abapGit/issues/2127","repository_url":"https://api.github.com/repos/larshp/abapGit","labels_url":"https://api.github.com/repos/larshp/abapGit/issues/2127/labels{/name}","comments_url":"https://api.github.com/repos/larshp/abapGit/issues/2127/comments","events_url":"https://api.github.com/repos/larshp/abapGit/issues/2127/events","html_url":"https://github.com/larshp/abapGit/issues/2127","id":383311901,"node_id":"MDU6SXNzdWUzODMzMTE5MDE=","number":2127,"title":"Refactor: make repo classes more focused","user":{"login":"sbcgua","id":15635498,"node_id":"MDQ6VXNlcjE1NjM1NDk4","avatar_url":"https://avatars1.githubusercontent.com/u/15635498?v=4","gravatar_id":"","url":"https://api.github.com/users/sbcgua","html_url":"https://github.com/sbcgua","followers_url":"https://api.github.com/users/sbcgua/followers","following_url":"https://api.github.com/users/sbcgua/following{/other_user}","gists_url":"https://api.github.com/users/sbcgua/gists{/gist_id}","starred_url":"https://api.github.com/users/sbcgua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbcgua/subscriptions","organizations_url":"https://api.github.com/users/sbcgua/orgs","repos_url":"https://api.github.com/users/sbcgua/repos","events_url":"https://api.github.com/users/sbcgua/events{/privacy}","received_events_url":"https://api.github.com/users/sbcgua/received_events","type":"User","site_admin":false},"labels":[{"id":524129630,"node_id":"MDU6TGFiZWw1MjQxMjk2MzA=","url":"https://api.github.com/repos/larshp/abapGit/labels/refactoring","name":"refactoring","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-21T22:22:04Z","updated_at":"2018-11-23T21:31:22Z","closed_at":null,"author_association":"COLLABORATOR","body":"Follows discussion in #2096\r\n\r\nOpinion: repo_base knows too much about other code and should be abstracted from external logic like: \r\n- UI (and progress indication)\r\n- persistence\r\n- code_inspector\r\n- repo deletion\r\n- and repo_srv\r\n\r\nMore concrete proposals\r\n\r\n- (A) `GET_FILES_LOCAL` shows progress -> implement as an event and show the progress elsewhere in UI classes\r\n- (B) persistence: remove direct persistent calls from `set`. This is more complex. Maybe also an event `on_config_change` handled by repo serv\r\n- (C) repo deletion -> move to repo srv (repo server is the manager of repos so it adds/deletes/etc)\r\n- (D) remove global friends with `zcl_abapgit_repo_srv`\r\n- (E) `RUN_CODE_INSPECTOR` - move to services. Also probably implement as an action in router and not direct call in `ZCL_ABAPGIT_GUI_PAGE_CODE_INSP`\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/larshp/abapGit/issues/comments/441320196","html_url":"https://github.com/larshp/abapGit/issues/2127#issuecomment-441320196","issue_url":"https://api.github.com/repos/larshp/abapGit/issues/2127","id":441320196,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTMyMDE5Ng==","user":{"login":"sbcgua","id":15635498,"node_id":"MDQ6VXNlcjE1NjM1NDk4","avatar_url":"https://avatars1.githubusercontent.com/u/15635498?v=4","gravatar_id":"","url":"https://api.github.com/users/sbcgua","html_url":"https://github.com/sbcgua","followers_url":"https://api.github.com/users/sbcgua/followers","following_url":"https://api.github.com/users/sbcgua/following{/other_user}","gists_url":"https://api.github.com/users/sbcgua/gists{/gist_id}","starred_url":"https://api.github.com/users/sbcgua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbcgua/subscriptions","organizations_url":"https://api.github.com/users/sbcgua/orgs","repos_url":"https://api.github.com/users/sbcgua/repos","events_url":"https://api.github.com/users/sbcgua/events{/privacy}","received_events_url":"https://api.github.com/users/sbcgua/received_events","type":"User","site_admin":false},"created_at":"2018-11-23T21:31:22Z","updated_at":"2018-11-23T21:31:22Z","author_association":"COLLABORATOR","body":"BTW, speaking about B, does `SET HANDLER ... FOR ALL` saves an object from garbage collector ?"}}
{"actor":{"display_login":"sbcgua"}}