{"action":"closed","number":238,"pull_request":{"url":"https://api.github.com/repos/hjalmers/angular-generic-table/pulls/238","id":184984978,"html_url":"https://github.com/hjalmers/angular-generic-table/pull/238","diff_url":"https://github.com/hjalmers/angular-generic-table/pull/238.diff","patch_url":"https://github.com/hjalmers/angular-generic-table/pull/238.patch","issue_url":"https://api.github.com/repos/hjalmers/angular-generic-table/issues/238","number":238,"state":"closed","locked":false,"title":"Fix editorconfig settings","user":{"login":"mklein994","id":3069239,"avatar_url":"https://avatars1.githubusercontent.com/u/3069239?v=4","gravatar_id":"","url":"https://api.github.com/users/mklein994","html_url":"https://github.com/mklein994","followers_url":"https://api.github.com/users/mklein994/followers","following_url":"https://api.github.com/users/mklein994/following{/other_user}","gists_url":"https://api.github.com/users/mklein994/gists{/gist_id}","starred_url":"https://api.github.com/users/mklein994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklein994/subscriptions","organizations_url":"https://api.github.com/users/mklein994/orgs","repos_url":"https://api.github.com/users/mklein994/repos","events_url":"https://api.github.com/users/mklein994/events{/privacy}","received_events_url":"https://api.github.com/users/mklein994/received_events","type":"User","site_admin":false},"body":"Json, yaml, and html files are indented with 2 spaces, the rest are indented with tabs.\r\n\r\nThe glob pattern wasn't expanding correctly when I [added the `.editorconfig` file](https://github.com/hjalmers/angular-generic-table/commit/a26af97516e0d08c7bd02dfb2f9defac894c9752); I forgot some braces.\r\n\r\nUsing 2 spaces makes it simpler in general, since a lot of these files are managed externally (`npm`, VSCode, etc.).\r\n\r\n@hjalmers you can use this commit, or change it to suit your needs; just note that currently `.editorconfig` is broken. This doesn't conflict with `prettier` or `tslint`.","created_at":"2018-04-30T15:19:06Z","updated_at":"2018-04-30T16:47:37Z","closed_at":"2018-04-30T16:47:37Z","merged_at":"2018-04-30T16:47:37Z","merge_commit_sha":"b824fa618c2afd41211654a7e47a32a9124a655c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hjalmers/angular-generic-table/pulls/238/commits","review_comments_url":"https://api.github.com/repos/hjalmers/angular-generic-table/pulls/238/comments","review_comment_url":"https://api.github.com/repos/hjalmers/angular-generic-table/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hjalmers/angular-generic-table/issues/238/comments","statuses_url":"https://api.github.com/repos/hjalmers/angular-generic-table/statuses/38a9a1d39b501f7d1b9e6216647088c9d0d899c2","head":{"label":"mklein994:fix-editorconfig","ref":"fix-editorconfig","sha":"38a9a1d39b501f7d1b9e6216647088c9d0d899c2","user":{"login":"mklein994","id":3069239,"avatar_url":"https://avatars1.githubusercontent.com/u/3069239?v=4","gravatar_id":"","url":"https://api.github.com/users/mklein994","html_url":"https://github.com/mklein994","followers_url":"https://api.github.com/users/mklein994/followers","following_url":"https://api.github.com/users/mklein994/following{/other_user}","gists_url":"https://api.github.com/users/mklein994/gists{/gist_id}","starred_url":"https://api.github.com/users/mklein994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklein994/subscriptions","organizations_url":"https://api.github.com/users/mklein994/orgs","repos_url":"https://api.github.com/users/mklein994/repos","events_url":"https://api.github.com/users/mklein994/events{/privacy}","received_events_url":"https://api.github.com/users/mklein994/received_events","type":"User","site_admin":false},"repo":{"id":128953133,"name":"angular-generic-table","full_name":"mklein994/angular-generic-table","owner":{"login":"mklein994","id":3069239,"avatar_url":"https://avatars1.githubusercontent.com/u/3069239?v=4","gravatar_id":"","url":"https://api.github.com/users/mklein994","html_url":"https://github.com/mklein994","followers_url":"https://api.github.com/users/mklein994/followers","following_url":"https://api.github.com/users/mklein994/following{/other_user}","gists_url":"https://api.github.com/users/mklein994/gists{/gist_id}","starred_url":"https://api.github.com/users/mklein994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklein994/subscriptions","organizations_url":"https://api.github.com/users/mklein994/orgs","repos_url":"https://api.github.com/users/mklein994/repos","events_url":"https://api.github.com/users/mklein994/events{/privacy}","received_events_url":"https://api.github.com/users/mklein994/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mklein994/angular-generic-table","description":"A generic table for Angular 2+. Generic table uses standard markup for tables ie. table, tr and td elements etc. and has support for expanding rows, global search, filters, sorting, pagination, export to CSV, column clicks, custom column rendering, custom export values.","fork":true,"url":"https://api.github.com/repos/mklein994/angular-generic-table","forks_url":"https://api.github.com/repos/mklein994/angular-generic-table/forks","keys_url":"https://api.github.com/repos/mklein994/angular-generic-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mklein994/angular-generic-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mklein994/angular-generic-table/teams","hooks_url":"https://api.github.com/repos/mklein994/angular-generic-table/hooks","issue_events_url":"https://api.github.com/repos/mklein994/angular-generic-table/issues/events{/number}","events_url":"https://api.github.com/repos/mklein994/angular-generic-table/events","assignees_url":"https://api.github.com/repos/mklein994/angular-generic-table/assignees{/user}","branches_url":"https://api.github.com/repos/mklein994/angular-generic-table/branches{/branch}","tags_url":"https://api.github.com/repos/mklein994/angular-generic-table/tags","blobs_url":"https://api.github.com/repos/mklein994/angular-generic-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mklein994/angular-generic-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mklein994/angular-generic-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/mklein994/angular-generic-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mklein994/angular-generic-table/statuses/{sha}","languages_url":"https://api.github.com/repos/mklein994/angular-generic-table/languages","stargazers_url":"https://api.github.com/repos/mklein994/angular-generic-table/stargazers","contributors_url":"https://api.github.com/repos/mklein994/angular-generic-table/contributors","subscribers_url":"https://api.github.com/repos/mklein994/angular-generic-table/subscribers","subscription_url":"https://api.github.com/repos/mklein994/angular-generic-table/subscription","commits_url":"https://api.github.com/repos/mklein994/angular-generic-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/mklein994/angular-generic-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/mklein994/angular-generic-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/mklein994/angular-generic-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/mklein994/angular-generic-table/contents/{+path}","compare_url":"https://api.github.com/repos/mklein994/angular-generic-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mklein994/angular-generic-table/merges","archive_url":"https://api.github.com/repos/mklein994/angular-generic-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mklein994/angular-generic-table/downloads","issues_url":"https://api.github.com/repos/mklein994/angular-generic-table/issues{/number}","pulls_url":"https://api.github.com/repos/mklein994/angular-generic-table/pulls{/number}","milestones_url":"https://api.github.com/repos/mklein994/angular-generic-table/milestones{/number}","notifications_url":"https://api.github.com/repos/mklein994/angular-generic-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mklein994/angular-generic-table/labels{/name}","releases_url":"https://api.github.com/repos/mklein994/angular-generic-table/releases{/id}","deployments_url":"https://api.github.com/repos/mklein994/angular-generic-table/deployments","created_at":"2018-04-10T15:14:53Z","updated_at":"2018-04-30T14:11:34Z","pushed_at":"2018-04-30T16:39:17Z","git_url":"git://github.com/mklein994/angular-generic-table.git","ssh_url":"git@github.com:mklein994/angular-generic-table.git","clone_url":"https://github.com/mklein994/angular-generic-table.git","svn_url":"https://github.com/mklein994/angular-generic-table","homepage":"https://hjalmers.github.io/angular-generic-table/","size":16988,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hjalmers:master","ref":"master","sha":"c14fa5c611f9f1c362fb3389449d8213c7bb7a2c","user":{"login":"hjalmers","id":1632755,"avatar_url":"https://avatars1.githubusercontent.com/u/1632755?v=4","gravatar_id":"","url":"https://api.github.com/users/hjalmers","html_url":"https://github.com/hjalmers","followers_url":"https://api.github.com/users/hjalmers/followers","following_url":"https://api.github.com/users/hjalmers/following{/other_user}","gists_url":"https://api.github.com/users/hjalmers/gists{/gist_id}","starred_url":"https://api.github.com/users/hjalmers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjalmers/subscriptions","organizations_url":"https://api.github.com/users/hjalmers/orgs","repos_url":"https://api.github.com/users/hjalmers/repos","events_url":"https://api.github.com/users/hjalmers/events{/privacy}","received_events_url":"https://api.github.com/users/hjalmers/received_events","type":"User","site_admin":false},"repo":{"id":68919374,"name":"angular-generic-table","full_name":"hjalmers/angular-generic-table","owner":{"login":"hjalmers","id":1632755,"avatar_url":"https://avatars1.githubusercontent.com/u/1632755?v=4","gravatar_id":"","url":"https://api.github.com/users/hjalmers","html_url":"https://github.com/hjalmers","followers_url":"https://api.github.com/users/hjalmers/followers","following_url":"https://api.github.com/users/hjalmers/following{/other_user}","gists_url":"https://api.github.com/users/hjalmers/gists{/gist_id}","starred_url":"https://api.github.com/users/hjalmers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjalmers/subscriptions","organizations_url":"https://api.github.com/users/hjalmers/orgs","repos_url":"https://api.github.com/users/hjalmers/repos","events_url":"https://api.github.com/users/hjalmers/events{/privacy}","received_events_url":"https://api.github.com/users/hjalmers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hjalmers/angular-generic-table","description":"A generic table for Angular 2+. Generic table uses standard markup for tables ie. table, tr and td elements etc. and has support for expanding rows, global search, filters, sorting, pagination, export to CSV, column clicks, custom column rendering, custom export values.","fork":false,"url":"https://api.github.com/repos/hjalmers/angular-generic-table","forks_url":"https://api.github.com/repos/hjalmers/angular-generic-table/forks","keys_url":"https://api.github.com/repos/hjalmers/angular-generic-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hjalmers/angular-generic-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hjalmers/angular-generic-table/teams","hooks_url":"https://api.github.com/repos/hjalmers/angular-generic-table/hooks","issue_events_url":"https://api.github.com/repos/hjalmers/angular-generic-table/issues/events{/number}","events_url":"https://api.github.com/repos/hjalmers/angular-generic-table/events","assignees_url":"https://api.github.com/repos/hjalmers/angular-generic-table/assignees{/user}","branches_url":"https://api.github.com/repos/hjalmers/angular-generic-table/branches{/branch}","tags_url":"https://api.github.com/repos/hjalmers/angular-generic-table/tags","blobs_url":"https://api.github.com/repos/hjalmers/angular-generic-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hjalmers/angular-generic-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hjalmers/angular-generic-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/hjalmers/angular-generic-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hjalmers/angular-generic-table/statuses/{sha}","languages_url":"https://api.github.com/repos/hjalmers/angular-generic-table/languages","stargazers_url":"https://api.github.com/repos/hjalmers/angular-generic-table/stargazers","contributors_url":"https://api.github.com/repos/hjalmers/angular-generic-table/contributors","subscribers_url":"https://api.github.com/repos/hjalmers/angular-generic-table/subscribers","subscription_url":"https://api.github.com/repos/hjalmers/angular-generic-table/subscription","commits_url":"https://api.github.com/repos/hjalmers/angular-generic-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/hjalmers/angular-generic-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/hjalmers/angular-generic-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/hjalmers/angular-generic-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/hjalmers/angular-generic-table/contents/{+path}","compare_url":"https://api.github.com/repos/hjalmers/angular-generic-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hjalmers/angular-generic-table/merges","archive_url":"https://api.github.com/repos/hjalmers/angular-generic-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hjalmers/angular-generic-table/downloads","issues_url":"https://api.github.com/repos/hjalmers/angular-generic-table/issues{/number}","pulls_url":"https://api.github.com/repos/hjalmers/angular-generic-table/pulls{/number}","milestones_url":"https://api.github.com/repos/hjalmers/angular-generic-table/milestones{/number}","notifications_url":"https://api.github.com/repos/hjalmers/angular-generic-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hjalmers/angular-generic-table/labels{/name}","releases_url":"https://api.github.com/repos/hjalmers/angular-generic-table/releases{/id}","deployments_url":"https://api.github.com/repos/hjalmers/angular-generic-table/deployments","created_at":"2016-09-22T12:33:03Z","updated_at":"2018-04-30T16:47:24Z","pushed_at":"2018-04-30T16:47:37Z","git_url":"git://github.com/hjalmers/angular-generic-table.git","ssh_url":"git@github.com:hjalmers/angular-generic-table.git","clone_url":"https://github.com/hjalmers/angular-generic-table.git","svn_url":"https://github.com/hjalmers/angular-generic-table","homepage":"https://hjalmers.github.io/angular-generic-table/","size":16960,"stargazers_count":63,"watchers_count":63,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":33,"open_issues":55,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hjalmers/angular-generic-table/pulls/238"},"html":{"href":"https://github.com/hjalmers/angular-generic-table/pull/238"},"issue":{"href":"https://api.github.com/repos/hjalmers/angular-generic-table/issues/238"},"comments":{"href":"https://api.github.com/repos/hjalmers/angular-generic-table/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/hjalmers/angular-generic-table/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/hjalmers/angular-generic-table/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hjalmers/angular-generic-table/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/hjalmers/angular-generic-table/statuses/38a9a1d39b501f7d1b9e6216647088c9d0d899c2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hjalmers","id":1632755,"avatar_url":"https://avatars1.githubusercontent.com/u/1632755?v=4","gravatar_id":"","url":"https://api.github.com/users/hjalmers","html_url":"https://github.com/hjalmers","followers_url":"https://api.github.com/users/hjalmers/followers","following_url":"https://api.github.com/users/hjalmers/following{/other_user}","gists_url":"https://api.github.com/users/hjalmers/gists{/gist_id}","starred_url":"https://api.github.com/users/hjalmers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjalmers/subscriptions","organizations_url":"https://api.github.com/users/hjalmers/orgs","repos_url":"https://api.github.com/users/hjalmers/repos","events_url":"https://api.github.com/users/hjalmers/events{/privacy}","received_events_url":"https://api.github.com/users/hjalmers/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"hjalmers"}}