{"action":"created","issue":{"url":"https://api.github.com/repos/publiclab/plots2/issues/2380","repository_url":"https://api.github.com/repos/publiclab/plots2","labels_url":"https://api.github.com/repos/publiclab/plots2/issues/2380/labels{/name}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/2380/comments","events_url":"https://api.github.com/repos/publiclab/plots2/issues/2380/events","html_url":"https://github.com/publiclab/plots2/pull/2380","id":299187003,"number":2380,"title":"Replace spaces with hyphens (list of suggested tags and query submitted in the form)","user":{"login":"milaaraujo","id":4355017,"avatar_url":"https://avatars0.githubusercontent.com/u/4355017?v=4","gravatar_id":"","url":"https://api.github.com/users/milaaraujo","html_url":"https://github.com/milaaraujo","followers_url":"https://api.github.com/users/milaaraujo/followers","following_url":"https://api.github.com/users/milaaraujo/following{/other_user}","gists_url":"https://api.github.com/users/milaaraujo/gists{/gist_id}","starred_url":"https://api.github.com/users/milaaraujo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milaaraujo/subscriptions","organizations_url":"https://api.github.com/users/milaaraujo/orgs","repos_url":"https://api.github.com/users/milaaraujo/repos","events_url":"https://api.github.com/users/milaaraujo/events{/privacy}","received_events_url":"https://api.github.com/users/milaaraujo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-02-22T01:06:14Z","updated_at":"2018-02-28T19:08:00Z","closed_at":"2018-02-26T23:47:02Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/2380","html_url":"https://github.com/publiclab/plots2/pull/2380","diff_url":"https://github.com/publiclab/plots2/pull/2380.diff","patch_url":"https://github.com/publiclab/plots2/pull/2380.patch"},"body":"fixes #2335, replacing spaces with hyphens as people type.\r\n\r\nMake sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!\r\n\r\n* [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with `rake test`\r\n* [x] code is in uniquely-named feature branch and has no merge conflicts\r\n* [x] PR is descriptively titled\r\n* [x] PR body includes `fixes #0000`-style reference to original issue #\r\n* [x] ask `@publiclab/reviewers` for help, in a comment below\r\n\r\n> We're happy to help you get this ready -- don't be afraid to ask for help, and **don't be discouraged** if your tests fail at first!\r\n\r\nIf tests do fail, click on the red `X` to learn why by reading the logs.\r\n\r\nPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software\r\n\r\nWe have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. \r\n\r\nThanks!\r\n"},"comment":{"url":"https://api.github.com/repos/publiclab/plots2/issues/comments/369347791","html_url":"https://github.com/publiclab/plots2/pull/2380#issuecomment-369347791","issue_url":"https://api.github.com/repos/publiclab/plots2/issues/2380","id":369347791,"user":{"login":"milaaraujo","id":4355017,"avatar_url":"https://avatars0.githubusercontent.com/u/4355017?v=4","gravatar_id":"","url":"https://api.github.com/users/milaaraujo","html_url":"https://github.com/milaaraujo","followers_url":"https://api.github.com/users/milaaraujo/followers","following_url":"https://api.github.com/users/milaaraujo/following{/other_user}","gists_url":"https://api.github.com/users/milaaraujo/gists{/gist_id}","starred_url":"https://api.github.com/users/milaaraujo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milaaraujo/subscriptions","organizations_url":"https://api.github.com/users/milaaraujo/orgs","repos_url":"https://api.github.com/users/milaaraujo/repos","events_url":"https://api.github.com/users/milaaraujo/events{/privacy}","received_events_url":"https://api.github.com/users/milaaraujo/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T19:07:01Z","updated_at":"2018-02-28T19:07:01Z","author_association":"CONTRIBUTOR","body":"Yes, @seafr! Now I'm running the code with the `query.replace(/\\s/g, '-')` on line 17. I think the replacement is occurring correctly, because when I search for 'test test test' on the terminal I see that `Parameters: {\"id\" => \"test-test-test\"}`.\r\n\r\n![captura de tela 2018-02-28 as 10 50 08](https://user-images.githubusercontent.com/4355017/36807043-bb481010-1c76-11e8-8b7d-fe775a6d58fa.png)\r\n\r\nI see exactly the same result (SQL) when I type 'test-test-test' and the window with the suggested tags appears... The problem is that when I type the words with spaces the dropdown window with the suggestions do not appear, even with the replacement apparently working well.\r\n\r\n\r\n"}}
{"actor":{"display_login":"milaaraujo"}}