{"action":"created","issue":{"url":"https://api.github.com/repos/OP-DSL/OPS/issues/93","repository_url":"https://api.github.com/repos/OP-DSL/OPS","labels_url":"https://api.github.com/repos/OP-DSL/OPS/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/OP-DSL/OPS/issues/93/comments","events_url":"https://api.github.com/repos/OP-DSL/OPS/issues/93/events","html_url":"https://github.com/OP-DSL/OPS/pull/93","id":335800379,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDA4MDc2","number":93,"title":"Feature/makefiles","user":{"login":"reguly","id":1272533,"node_id":"MDQ6VXNlcjEyNzI1MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1272533?v=4","gravatar_id":"","url":"https://api.github.com/users/reguly","html_url":"https://github.com/reguly","followers_url":"https://api.github.com/users/reguly/followers","following_url":"https://api.github.com/users/reguly/following{/other_user}","gists_url":"https://api.github.com/users/reguly/gists{/gist_id}","starred_url":"https://api.github.com/users/reguly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reguly/subscriptions","organizations_url":"https://api.github.com/users/reguly/orgs","repos_url":"https://api.github.com/users/reguly/repos","events_url":"https://api.github.com/users/reguly/events{/privacy}","received_events_url":"https://api.github.com/users/reguly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2018-06-26T12:40:14Z","updated_at":"2018-07-31T06:58:55Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/OP-DSL/OPS/pulls/93","html_url":"https://github.com/OP-DSL/OPS/pull/93","diff_url":"https://github.com/OP-DSL/OPS/pull/93.diff","patch_url":"https://github.com/OP-DSL/OPS/pull/93.patch"},"body":"Cleans up the makefiles for backends and apps, providing a template. Can set IEEE=1 or FAST=1 to set additional optimisation flags. Should be tested with all the compilers."},"comment":{"url":"https://api.github.com/repos/OP-DSL/OPS/issues/comments/409116287","html_url":"https://github.com/OP-DSL/OPS/pull/93#issuecomment-409116287","issue_url":"https://api.github.com/repos/OP-DSL/OPS/issues/93","id":409116287,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTExNjI4Nw==","user":{"login":"reguly","id":1272533,"node_id":"MDQ6VXNlcjEyNzI1MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1272533?v=4","gravatar_id":"","url":"https://api.github.com/users/reguly","html_url":"https://github.com/reguly","followers_url":"https://api.github.com/users/reguly/followers","following_url":"https://api.github.com/users/reguly/following{/other_user}","gists_url":"https://api.github.com/users/reguly/gists{/gist_id}","starred_url":"https://api.github.com/users/reguly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reguly/subscriptions","organizations_url":"https://api.github.com/users/reguly/orgs","repos_url":"https://api.github.com/users/reguly/repos","events_url":"https://api.github.com/users/reguly/events{/privacy}","received_events_url":"https://api.github.com/users/reguly/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T06:58:55Z","updated_at":"2018-07-31T06:58:55Z","author_association":"COLLABORATOR","body":"This has never worked - it has just never been tested. We are missing the multidim reduction support in the code generator. I suggest we fix this separately.\n\n> On 2018. Jul 31., at 1:05, Gihan R. Mudalige <notifications@github.com> wrote:\n> \n> I believe almost all the tests work now. Some final issue in compiling the OpenACC version in Fortran (multidim and multidim3D) : (this is using PGI 16.9)\n> \n> pgfortran -O3 -fast -gopt -module /home/mgiles/mudalige/OPS-GIT/OPS/ops/fortran/mod/pgi/openacc -L/home/mgiles/mudalige/OPS-GIT/OPS/ops/fortran/lib -pgc++libs -acc -Minline -ta=nvidia,cc35 -Mcuda=cc35 \n> constants.F90 MPI_OpenACC/*.F90 multidim_ops.F90 -o multidim_openacc -lops_for_cuda\n> constants.F90:\n> MPI_OpenACC/multidim_copy_kernel_openacc_kernel.F90:\n> MPI_OpenACC/multidim_kernel_openacc_kernel.F90:\n> MPI_OpenACC/multidim_print_kernel_openacc_kernel.F90:\n> MPI_OpenACC/multidim_reduce_kernel_openacc_kernel.F90:\n> PGF90-W-0189-Argument number 2 to multidim_reduce_kernel: association of scalar actual argument to array dummy argument (MPI_OpenACC/multidim_reduce_kernel_openacc_kernel.F90: 53)\n> 0 inform, 1 warnings, 0 severes, 0 fatal for multidim_reduce_kernel_wrap\n> multidim_ops.F90:\n> constants.F90:\n> MPI_OpenACC/multidim_copy_kernel_openacc_kernel.F90:\n> MPI_OpenACC/multidim_kernel_openacc_kernel.F90:\n> MPI_OpenACC/multidim_print_kernel_openacc_kernel.F90:\n> MPI_OpenACC/multidim_reduce_kernel_openacc_kernel.F90:\n> PGF90-W-0189-Argument number 2 to multidim_reduce_kernel: association of scalar actual argument to array dummy argument (MPI_OpenACC/multidim_reduce_kernel_openacc_kernel.F90: 53)\n> 0 inform, 1 warnings, 0 severes, 0 fatal for multidim_reduce_kernel_wrap\n> PGF90-S-0155-Procedures called in a compute region must have acc routine information: multidim_reduce_kernel (MPI_OpenACC/multidim_reduce_kernel_openacc_kernel.F90: 53)\n> PGF90-S-0155-Accelerator region ignored; see -Minfo messages (MPI_OpenACC/multidim_reduce_kernel_openacc_kernel.F90: 48)\n> 0 inform, 0 warnings, 2 severes, 0 fatal for multidim_reduce_kernel_wrap\n> multidim_ops.F90:\n> make: *** [multidim_openacc] Error 2\n> \n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n"}}
{"actor":{"display_login":"reguly"}}