{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/237234845","pull_request_review_id":179484749,"id":237234845,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzIzNDg0NQ==","diff_hunk":"@@ -142,10 +142,10 @@ data:\n           valueFrom:\n             fieldRef:\n               fieldPath: status.podIP\n-        - name: ISTIO_META_POD_NAME","path":"install/kubernetes/helm/istio-remote/templates/sidecar-injector-configmap.yaml","position":4,"original_position":4,"commit_id":"d449cfbfdbbb4ab7b44a65e4bc82f5cabe49b23f","original_commit_id":"d449cfbfdbbb4ab7b44a65e4bc82f5cabe49b23f","user":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"body":"Why ? It's backward incompatible and people may use it ( pilot is not the only consumer ).\r\n\r\nThe POD_NAME is important for other purposes, we still plan to move away from IP-as-key.","created_at":"2018-11-28T19:47:07Z","updated_at":"2018-11-28T19:47:07Z","html_url":"https://github.com/istio/istio/pull/10170#discussion_r237234845","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/10170","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/237234845"},"html":{"href":"https://github.com/istio/istio/pull/10170#discussion_r237234845"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/10170"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/10170","id":234364659,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzY0NjU5","html_url":"https://github.com/istio/istio/pull/10170","diff_url":"https://github.com/istio/istio/pull/10170.diff","patch_url":"https://github.com/istio/istio/pull/10170.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/10170","number":10170,"state":"open","locked":false,"title":"Prep for network scopes","user":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"1. remove unused ISTIO_META_POD_NAME and add ISTIO_META_NAMESPACE\n2. Set the model.Proxy.ConfigNamespace based on the metadata above\n3. Added the proxy parameter to all resource calls (Services, Gateways, VirtualServices, DestinationRules, etc.)\n   so that we can use the proxy.ConfigNamespace with NetworkScopes to return the appropriate values to the caller.\n4. Fix the namespace attribute for a service entry (from hardcoded default to the configMeta.namespace)\n\n\nWith these changes in place, when we add NetworkScope, we should not need to change *any* code\nin pilot/pkg/networking/. The only implementation should be in push_context.go to scope the resources provided\nbased on the proxy's namespace and the NetworkScope configuration resource (or the global network scope setting).\nIf this pattern is followed religiously, any new bugs that come up after addign NetworkScope can be quickly \nspotted and fixed (in push_context.go).\n\nSigned-off-by: Shriram Rajagopalan <shriramr@vmware.com>","created_at":"2018-11-28T17:33:02Z","updated_at":"2018-11-28T19:47:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"240f40287b460034126a2a6ad15e1ed0eeaed5ef","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hzxuzhonghu","id":13374016,"node_id":"MDQ6VXNlcjEzMzc0MDE2","avatar_url":"https://avatars3.githubusercontent.com/u/13374016?v=4","gravatar_id":"","url":"https://api.github.com/users/hzxuzhonghu","html_url":"https://github.com/hzxuzhonghu","followers_url":"https://api.github.com/users/hzxuzhonghu/followers","following_url":"https://api.github.com/users/hzxuzhonghu/following{/other_user}","gists_url":"https://api.github.com/users/hzxuzhonghu/gists{/gist_id}","starred_url":"https://api.github.com/users/hzxuzhonghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzxuzhonghu/subscriptions","organizations_url":"https://api.github.com/users/hzxuzhonghu/orgs","repos_url":"https://api.github.com/users/hzxuzhonghu/repos","events_url":"https://api.github.com/users/hzxuzhonghu/events{/privacy}","received_events_url":"https://api.github.com/users/hzxuzhonghu/received_events","type":"User","site_admin":false},{"login":"GregHanson","id":19473391,"node_id":"MDQ6VXNlcjE5NDczMzkx","avatar_url":"https://avatars3.githubusercontent.com/u/19473391?v=4","gravatar_id":"","url":"https://api.github.com/users/GregHanson","html_url":"https://github.com/GregHanson","followers_url":"https://api.github.com/users/GregHanson/followers","following_url":"https://api.github.com/users/GregHanson/following{/other_user}","gists_url":"https://api.github.com/users/GregHanson/gists{/gist_id}","starred_url":"https://api.github.com/users/GregHanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregHanson/subscriptions","organizations_url":"https://api.github.com/users/GregHanson/orgs","repos_url":"https://api.github.com/users/GregHanson/repos","events_url":"https://api.github.com/users/GregHanson/events{/privacy}","received_events_url":"https://api.github.com/users/GregHanson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/10170/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/10170/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/10170/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/d449cfbfdbbb4ab7b44a65e4bc82f5cabe49b23f","head":{"label":"rshriram:config_namespacing","ref":"config_namespacing","sha":"d449cfbfdbbb4ab7b44a65e4bc82f5cabe49b23f","user":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"repo":{"id":110001289,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwMDEyODk=","name":"istio","full_name":"rshriram/istio","private":false,"owner":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rshriram/istio","description":"Istio service mesh for polyglot microservice applications","fork":true,"url":"https://api.github.com/repos/rshriram/istio","forks_url":"https://api.github.com/repos/rshriram/istio/forks","keys_url":"https://api.github.com/repos/rshriram/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rshriram/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rshriram/istio/teams","hooks_url":"https://api.github.com/repos/rshriram/istio/hooks","issue_events_url":"https://api.github.com/repos/rshriram/istio/issues/events{/number}","events_url":"https://api.github.com/repos/rshriram/istio/events","assignees_url":"https://api.github.com/repos/rshriram/istio/assignees{/user}","branches_url":"https://api.github.com/repos/rshriram/istio/branches{/branch}","tags_url":"https://api.github.com/repos/rshriram/istio/tags","blobs_url":"https://api.github.com/repos/rshriram/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rshriram/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rshriram/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/rshriram/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rshriram/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/rshriram/istio/languages","stargazers_url":"https://api.github.com/repos/rshriram/istio/stargazers","contributors_url":"https://api.github.com/repos/rshriram/istio/contributors","subscribers_url":"https://api.github.com/repos/rshriram/istio/subscribers","subscription_url":"https://api.github.com/repos/rshriram/istio/subscription","commits_url":"https://api.github.com/repos/rshriram/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/rshriram/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/rshriram/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/rshriram/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/rshriram/istio/contents/{+path}","compare_url":"https://api.github.com/repos/rshriram/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rshriram/istio/merges","archive_url":"https://api.github.com/repos/rshriram/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rshriram/istio/downloads","issues_url":"https://api.github.com/repos/rshriram/istio/issues{/number}","pulls_url":"https://api.github.com/repos/rshriram/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/rshriram/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/rshriram/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rshriram/istio/labels{/name}","releases_url":"https://api.github.com/repos/rshriram/istio/releases{/id}","deployments_url":"https://api.github.com/repos/rshriram/istio/deployments","created_at":"2017-11-08T16:29:34Z","updated_at":"2018-10-24T23:27:24Z","pushed_at":"2018-11-28T17:42:24Z","git_url":"git://github.com/rshriram/istio.git","ssh_url":"git@github.com:rshriram/istio.git","clone_url":"https://github.com/rshriram/istio.git","svn_url":"https://github.com/rshriram/istio","homepage":"https://istio.io","size":55342,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-1.1","ref":"release-1.1","sha":"60f9c35f040af1ed41160b71218d0057e97a9448","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-11-28T19:24:30Z","pushed_at":"2018-11-28T19:35:32Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":54995,"stargazers_count":13403,"watchers_count":13403,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2039,"mirror_url":null,"archived":false,"open_issues_count":1032,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2039,"open_issues":1032,"watchers":13403,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/10170"},"html":{"href":"https://github.com/istio/istio/pull/10170"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/10170"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/10170/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/10170/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/10170/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/d449cfbfdbbb4ab7b44a65e4bc82f5cabe49b23f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"costinm"}}