{"action":"created","comment":{"url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/comments/236122035","pull_request_review_id":178133811,"id":236122035,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjEyMjAzNQ==","diff_hunk":"@@ -1,4 +1,4 @@\n-// Licensed to the .NET Foundation under one or more agreements.\n+    // Licensed to the .NET Foundation under one or more agreements.","path":"Microsoft.Toolkit.Uwp.UI.Controls.DataGrid/DataGrid/DataGridDataConnection.cs","position":2,"original_position":2,"commit_id":"af7e3a8a54a791e596b26b77cf0f15bf02ee05fe","original_commit_id":"af7e3a8a54a791e596b26b77cf0f15bf02ee05fe","user":{"login":"filipwa84","id":35419905,"node_id":"MDQ6VXNlcjM1NDE5OTA1","avatar_url":"https://avatars3.githubusercontent.com/u/35419905?v=4","gravatar_id":"","url":"https://api.github.com/users/filipwa84","html_url":"https://github.com/filipwa84","followers_url":"https://api.github.com/users/filipwa84/followers","following_url":"https://api.github.com/users/filipwa84/following{/other_user}","gists_url":"https://api.github.com/users/filipwa84/gists{/gist_id}","starred_url":"https://api.github.com/users/filipwa84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipwa84/subscriptions","organizations_url":"https://api.github.com/users/filipwa84/orgs","repos_url":"https://api.github.com/users/filipwa84/repos","events_url":"https://api.github.com/users/filipwa84/events{/privacy}","received_events_url":"https://api.github.com/users/filipwa84/received_events","type":"User","site_admin":false},"body":"@RBrid This is weird as the line is still there in the file I committed and pushed","created_at":"2018-11-26T04:58:44Z","updated_at":"2018-11-26T04:58:44Z","html_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2536#discussion_r236122035","pull_request_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2536","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/comments/236122035"},"html":{"href":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2536#discussion_r236122035"},"pull_request":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2536"}},"in_reply_to_id":234289069},"pull_request":{"url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2536","id":221109162,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTA5MTYy","html_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2536","diff_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2536.diff","patch_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2536.patch","issue_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2536","number":2536,"state":"open","locked":false,"title":"Added Support for Incremental Loading in the DataGrid","user":{"login":"filipwa84","id":35419905,"node_id":"MDQ6VXNlcjM1NDE5OTA1","avatar_url":"https://avatars3.githubusercontent.com/u/35419905?v=4","gravatar_id":"","url":"https://api.github.com/users/filipwa84","html_url":"https://github.com/filipwa84","followers_url":"https://api.github.com/users/filipwa84/followers","following_url":"https://api.github.com/users/filipwa84/following{/other_user}","gists_url":"https://api.github.com/users/filipwa84/gists{/gist_id}","starred_url":"https://api.github.com/users/filipwa84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipwa84/subscriptions","organizations_url":"https://api.github.com/users/filipwa84/orgs","repos_url":"https://api.github.com/users/filipwa84/repos","events_url":"https://api.github.com/users/filipwa84/events{/privacy}","received_events_url":"https://api.github.com/users/filipwa84/received_events","type":"User","site_admin":false},"body":"Issue: #2120\r\n<!-- Link to relevant issue. All PRs should be asociated with an issue -->\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n<!-- Please uncomment one ore more that apply to this PR -->\r\n\r\n\r\n- Feature \r\n\r\n\r\n\r\n## What is the current behavior?\r\nCurrently no support for loading more data from collections implementing ISupportIncrementalLoading. \r\n\r\n\r\n## What is the new behavior?\r\nAdded support for collections implementing ISupportIncrementalLoading. The user is able to specify the IncrementalThreshold as a \"percentage of scroll\" for when to load more data.\r\n\r\n## PR Checklist\r\n\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] Tested code with current [supported SDKs](../readme.md#supported)\r\n- [ ] Docs have been added/updated which fit [documentation template](https://github.com/Microsoft/UWPCommunityToolkit/blob/master/docs/.template.md). (for bug fixes / features)\r\n- [ ] Sample in sample app has been added / updated (for bug fixes / features)\r\n    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/Microsoft/UWPCommunityToolkit-design-assets)\r\n- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)\r\n- [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*)\r\n- [x] Contains **NO** breaking changes\r\n\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. \r\n     Please note that breaking changes are likely to be rejected -->\r\n\r\n\r\n## Other information\r\n","created_at":"2018-10-08T13:03:02Z","updated_at":"2018-11-26T04:58:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bec8c845a10501911bc56e99e6c194409d2fb2f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":936600972,"node_id":"MDU6TGFiZWw5MzY2MDA5NzI=","url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/labels/DataGrid","name":"DataGrid","color":"2f17b7","default":false},{"id":415293891,"node_id":"MDU6TGFiZWw0MTUyOTM4OTE=","url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/labels/controls","name":"controls","color":"fef2c0","default":false},{"id":446241994,"node_id":"MDU6TGFiZWw0NDYyNDE5OTQ=","url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/labels/reviewers%20wanted","name":"reviewers wanted","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2536/commits","review_comments_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2536/comments","review_comment_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2536/comments","statuses_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/statuses/af7e3a8a54a791e596b26b77cf0f15bf02ee05fe","head":{"label":"filipwa84:incremental-loading","ref":"incremental-loading","sha":"af7e3a8a54a791e596b26b77cf0f15bf02ee05fe","user":{"login":"filipwa84","id":35419905,"node_id":"MDQ6VXNlcjM1NDE5OTA1","avatar_url":"https://avatars3.githubusercontent.com/u/35419905?v=4","gravatar_id":"","url":"https://api.github.com/users/filipwa84","html_url":"https://github.com/filipwa84","followers_url":"https://api.github.com/users/filipwa84/followers","following_url":"https://api.github.com/users/filipwa84/following{/other_user}","gists_url":"https://api.github.com/users/filipwa84/gists{/gist_id}","starred_url":"https://api.github.com/users/filipwa84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipwa84/subscriptions","organizations_url":"https://api.github.com/users/filipwa84/orgs","repos_url":"https://api.github.com/users/filipwa84/repos","events_url":"https://api.github.com/users/filipwa84/events{/privacy}","received_events_url":"https://api.github.com/users/filipwa84/received_events","type":"User","site_admin":false},"repo":{"id":149328519,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzMjg1MTk=","name":"WindowsCommunityToolkit","full_name":"filipwa84/WindowsCommunityToolkit","private":false,"owner":{"login":"filipwa84","id":35419905,"node_id":"MDQ6VXNlcjM1NDE5OTA1","avatar_url":"https://avatars3.githubusercontent.com/u/35419905?v=4","gravatar_id":"","url":"https://api.github.com/users/filipwa84","html_url":"https://github.com/filipwa84","followers_url":"https://api.github.com/users/filipwa84/followers","following_url":"https://api.github.com/users/filipwa84/following{/other_user}","gists_url":"https://api.github.com/users/filipwa84/gists{/gist_id}","starred_url":"https://api.github.com/users/filipwa84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipwa84/subscriptions","organizations_url":"https://api.github.com/users/filipwa84/orgs","repos_url":"https://api.github.com/users/filipwa84/repos","events_url":"https://api.github.com/users/filipwa84/events{/privacy}","received_events_url":"https://api.github.com/users/filipwa84/received_events","type":"User","site_admin":false},"html_url":"https://github.com/filipwa84/WindowsCommunityToolkit","description":"The Windows Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10. The toolkit is part of the .NET Foundation.","fork":true,"url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit","forks_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/forks","keys_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/teams","hooks_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/hooks","issue_events_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/issues/events{/number}","events_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/events","assignees_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/assignees{/user}","branches_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/branches{/branch}","tags_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/tags","blobs_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/languages","stargazers_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/stargazers","contributors_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/contributors","subscribers_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/subscribers","subscription_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/subscription","commits_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/contents/{+path}","compare_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/merges","archive_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/downloads","issues_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/issues{/number}","pulls_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/labels{/name}","releases_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/releases{/id}","deployments_url":"https://api.github.com/repos/filipwa84/WindowsCommunityToolkit/deployments","created_at":"2018-09-18T17:40:09Z","updated_at":"2018-11-15T06:21:35Z","pushed_at":"2018-11-15T06:20:41Z","git_url":"git://github.com/filipwa84/WindowsCommunityToolkit.git","ssh_url":"git@github.com:filipwa84/WindowsCommunityToolkit.git","clone_url":"https://github.com/filipwa84/WindowsCommunityToolkit.git","svn_url":"https://github.com/filipwa84/WindowsCommunityToolkit","homepage":"https://docs.microsoft.com/windows/uwpcommunitytoolkit/","size":421123,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"windows-toolkit:master","ref":"master","sha":"be6169027415f89ee80d5b19cf828f32e2c46a00","user":{"login":"windows-toolkit","id":41346473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMzQ2NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/41346473?v=4","gravatar_id":"","url":"https://api.github.com/users/windows-toolkit","html_url":"https://github.com/windows-toolkit","followers_url":"https://api.github.com/users/windows-toolkit/followers","following_url":"https://api.github.com/users/windows-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/windows-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/windows-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windows-toolkit/subscriptions","organizations_url":"https://api.github.com/users/windows-toolkit/orgs","repos_url":"https://api.github.com/users/windows-toolkit/repos","events_url":"https://api.github.com/users/windows-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/windows-toolkit/received_events","type":"Organization","site_admin":false},"repo":{"id":61403402,"node_id":"MDEwOlJlcG9zaXRvcnk2MTQwMzQwMg==","name":"WindowsCommunityToolkit","full_name":"windows-toolkit/WindowsCommunityToolkit","private":false,"owner":{"login":"windows-toolkit","id":41346473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMzQ2NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/41346473?v=4","gravatar_id":"","url":"https://api.github.com/users/windows-toolkit","html_url":"https://github.com/windows-toolkit","followers_url":"https://api.github.com/users/windows-toolkit/followers","following_url":"https://api.github.com/users/windows-toolkit/following{/other_user}","gists_url":"https://api.github.com/users/windows-toolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/windows-toolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windows-toolkit/subscriptions","organizations_url":"https://api.github.com/users/windows-toolkit/orgs","repos_url":"https://api.github.com/users/windows-toolkit/repos","events_url":"https://api.github.com/users/windows-toolkit/events{/privacy}","received_events_url":"https://api.github.com/users/windows-toolkit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit","description":"The Windows Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10. The toolkit is part of the .NET Foundation.","fork":false,"url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit","forks_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/forks","keys_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/teams","hooks_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/hooks","issue_events_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/events{/number}","events_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/events","assignees_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/assignees{/user}","branches_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/branches{/branch}","tags_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/tags","blobs_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/languages","stargazers_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/stargazers","contributors_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/contributors","subscribers_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/subscribers","subscription_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/subscription","commits_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/contents/{+path}","compare_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/merges","archive_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/downloads","issues_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues{/number}","pulls_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/labels{/name}","releases_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/releases{/id}","deployments_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/deployments","created_at":"2016-06-17T21:29:46Z","updated_at":"2018-11-25T15:00:06Z","pushed_at":"2018-11-21T22:10:23Z","git_url":"git://github.com/windows-toolkit/WindowsCommunityToolkit.git","ssh_url":"git@github.com:windows-toolkit/WindowsCommunityToolkit.git","clone_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit.git","svn_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit","homepage":"https://docs.microsoft.com/windows/communitytoolkit/","size":421283,"stargazers_count":2773,"watchers_count":2773,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":771,"mirror_url":null,"archived":false,"open_issues_count":230,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":771,"open_issues":230,"watchers":2773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2536"},"html":{"href":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2536"},"issue":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2536"},"comments":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2536/comments"},"review_comments":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2536/comments"},"review_comment":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2536/commits"},"statuses":{"href":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/statuses/af7e3a8a54a791e596b26b77cf0f15bf02ee05fe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"filipwa84"}}