{"action":"created","comment":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/comments/232472104","pull_request_review_id":173681757,"id":232472104,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQ3MjEwNA==","diff_hunk":"@@ -7112,11 +7112,28 @@ LOC: Config.visibleHostname\n DEFAULT: none\n DEFAULT_DOC: Automatically detect the system host name\n DOC_START\n-\tIf you want to present a special hostname in error messages, etc,\n-\tdefine this.  Otherwise, the return value of gethostname()\n-\twill be used. If you have multiple caches in a cluster and\n-\tget errors about IP-forwarding you must set them to have individual\n-\tnames with this setting.\n+\tThe hostname of this proxy.\n+\n+\tHosts connected to the Internet or handling messages which travel\n+\tover the Internet are required by RFC 1123 to have a name which\n+\tcan be resolved in DNS (an FQDN).\n+\n+\tIf not set, auto-detection of the system host name will be performed\n+\tbased on the following details (in this order):\n+\t\t- rDNS name for the first listening port address\n+\t\t- the name returned by gethostname(2)\n+\t\t- the name \"localhost\"\n+\n+\tThis name will be used in generated responses sent to clients","path":"src/cf.data.pre","position":21,"original_position":21,"commit_id":"f89eaedd7065065950d5d6f81d10b57b4f6863ff","original_commit_id":"699e2ff9b277dd0fe0932c9333706987d209237f","user":{"login":"yadij","id":9123754,"node_id":"MDQ6VXNlcjkxMjM3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"body":"You want all of the past present and future codes to be listed as well as all the non-errorpage uses? error pages naming the proxy is just the most obvious and best-known example.","created_at":"2018-11-11T01:56:35Z","updated_at":"2018-11-11T01:56:35Z","html_url":"https://github.com/squid-cache/squid/pull/302#discussion_r232472104","pull_request_url":"https://api.github.com/repos/squid-cache/squid/pulls/302","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments/232472104"},"html":{"href":"https://github.com/squid-cache/squid/pull/302#discussion_r232472104"},"pull_request":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/302"}},"in_reply_to_id":232004049},"pull_request":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/302","id":221885335,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODg1MzM1","html_url":"https://github.com/squid-cache/squid/pull/302","diff_url":"https://github.com/squid-cache/squid/pull/302.diff","patch_url":"https://github.com/squid-cache/squid/pull/302.patch","issue_url":"https://api.github.com/repos/squid-cache/squid/issues/302","number":302,"state":"open","locked":false,"title":"Docs: update description of visible_hostname","user":{"login":"yadij","id":9123754,"node_id":"MDQ6VXNlcjkxMjM3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"body":"Bring the documentation back into line with what the code\r\nactually does.\r\n\r\nAlso, mention that this is an domain/FQDN not just a host name.","created_at":"2018-10-10T18:16:21Z","updated_at":"2018-11-11T01:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1347fd3d1c8338c0fb749fa8091007619d8dcd41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/squid-cache/squid/pulls/302/commits","review_comments_url":"https://api.github.com/repos/squid-cache/squid/pulls/302/comments","review_comment_url":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squid-cache/squid/issues/302/comments","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/f89eaedd7065065950d5d6f81d10b57b4f6863ff","head":{"label":"yadij:v5-doc-visible_hostname","ref":"v5-doc-visible_hostname","sha":"f89eaedd7065065950d5d6f81d10b57b4f6863ff","user":{"login":"yadij","id":9123754,"node_id":"MDQ6VXNlcjkxMjM3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"repo":{"id":97826891,"node_id":"MDEwOlJlcG9zaXRvcnk5NzgyNjg5MQ==","name":"squid","full_name":"yadij/squid","private":false,"owner":{"login":"yadij","id":9123754,"node_id":"MDQ6VXNlcjkxMjM3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yadij/squid","description":"Squid Web Proxy Cache","fork":true,"url":"https://api.github.com/repos/yadij/squid","forks_url":"https://api.github.com/repos/yadij/squid/forks","keys_url":"https://api.github.com/repos/yadij/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yadij/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yadij/squid/teams","hooks_url":"https://api.github.com/repos/yadij/squid/hooks","issue_events_url":"https://api.github.com/repos/yadij/squid/issues/events{/number}","events_url":"https://api.github.com/repos/yadij/squid/events","assignees_url":"https://api.github.com/repos/yadij/squid/assignees{/user}","branches_url":"https://api.github.com/repos/yadij/squid/branches{/branch}","tags_url":"https://api.github.com/repos/yadij/squid/tags","blobs_url":"https://api.github.com/repos/yadij/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yadij/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yadij/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/yadij/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yadij/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/yadij/squid/languages","stargazers_url":"https://api.github.com/repos/yadij/squid/stargazers","contributors_url":"https://api.github.com/repos/yadij/squid/contributors","subscribers_url":"https://api.github.com/repos/yadij/squid/subscribers","subscription_url":"https://api.github.com/repos/yadij/squid/subscription","commits_url":"https://api.github.com/repos/yadij/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/yadij/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/yadij/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/yadij/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/yadij/squid/contents/{+path}","compare_url":"https://api.github.com/repos/yadij/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yadij/squid/merges","archive_url":"https://api.github.com/repos/yadij/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yadij/squid/downloads","issues_url":"https://api.github.com/repos/yadij/squid/issues{/number}","pulls_url":"https://api.github.com/repos/yadij/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/yadij/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/yadij/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yadij/squid/labels{/name}","releases_url":"https://api.github.com/repos/yadij/squid/releases{/id}","deployments_url":"https://api.github.com/repos/yadij/squid/deployments","created_at":"2017-07-20T11:20:53Z","updated_at":"2018-11-04T06:43:38Z","pushed_at":"2018-11-11T01:28:51Z","git_url":"git://github.com/yadij/squid.git","ssh_url":"git@github.com:yadij/squid.git","clone_url":"https://github.com/yadij/squid.git","svn_url":"https://github.com/yadij/squid","homepage":"http://www.squid-cache.org/","size":137608,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"squid-cache:master","ref":"master","sha":"c002f0e785ea18df2594c841a9ee408725c502fe","user":{"login":"squid-cache","id":363029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"repo":{"id":24519987,"node_id":"MDEwOlJlcG9zaXRvcnkyNDUxOTk4Nw==","name":"squid","full_name":"squid-cache/squid","private":false,"owner":{"login":"squid-cache","id":363029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/squid-cache/squid","description":"Squid Web Proxy Cache","fork":false,"url":"https://api.github.com/repos/squid-cache/squid","forks_url":"https://api.github.com/repos/squid-cache/squid/forks","keys_url":"https://api.github.com/repos/squid-cache/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squid-cache/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squid-cache/squid/teams","hooks_url":"https://api.github.com/repos/squid-cache/squid/hooks","issue_events_url":"https://api.github.com/repos/squid-cache/squid/issues/events{/number}","events_url":"https://api.github.com/repos/squid-cache/squid/events","assignees_url":"https://api.github.com/repos/squid-cache/squid/assignees{/user}","branches_url":"https://api.github.com/repos/squid-cache/squid/branches{/branch}","tags_url":"https://api.github.com/repos/squid-cache/squid/tags","blobs_url":"https://api.github.com/repos/squid-cache/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squid-cache/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squid-cache/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/squid-cache/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/squid-cache/squid/languages","stargazers_url":"https://api.github.com/repos/squid-cache/squid/stargazers","contributors_url":"https://api.github.com/repos/squid-cache/squid/contributors","subscribers_url":"https://api.github.com/repos/squid-cache/squid/subscribers","subscription_url":"https://api.github.com/repos/squid-cache/squid/subscription","commits_url":"https://api.github.com/repos/squid-cache/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/squid-cache/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/squid-cache/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/squid-cache/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/squid-cache/squid/contents/{+path}","compare_url":"https://api.github.com/repos/squid-cache/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squid-cache/squid/merges","archive_url":"https://api.github.com/repos/squid-cache/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squid-cache/squid/downloads","issues_url":"https://api.github.com/repos/squid-cache/squid/issues{/number}","pulls_url":"https://api.github.com/repos/squid-cache/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/squid-cache/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/squid-cache/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squid-cache/squid/labels{/name}","releases_url":"https://api.github.com/repos/squid-cache/squid/releases{/id}","deployments_url":"https://api.github.com/repos/squid-cache/squid/deployments","created_at":"2014-09-27T00:59:40Z","updated_at":"2018-11-09T02:13:35Z","pushed_at":"2018-11-11T01:28:53Z","git_url":"git://github.com/squid-cache/squid.git","ssh_url":"git@github.com:squid-cache/squid.git","clone_url":"https://github.com/squid-cache/squid.git","svn_url":"https://github.com/squid-cache/squid","homepage":"http://www.squid-cache.org/","size":162195,"stargazers_count":415,"watchers_count":415,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":168,"open_issues":29,"watchers":415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/302"},"html":{"href":"https://github.com/squid-cache/squid/pull/302"},"issue":{"href":"https://api.github.com/repos/squid-cache/squid/issues/302"},"comments":{"href":"https://api.github.com/repos/squid-cache/squid/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/squid-cache/squid/statuses/f89eaedd7065065950d5d6f81d10b57b4f6863ff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yadij"}}