{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/199951678","pull_request_review_id":134168281,"id":199951678,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTk1MTY3OA==","diff_hunk":"@@ -0,0 +1,103 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!--\n+ /**\n+ * Copyright (c) Codice Foundation\n+ *\n+ * This is free software: you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation, either\n+ * version 3 of the License, or any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\n+ * See the GNU Lesser General Public License for more details. A copy of the GNU Lesser General Public License is distributed along with this program and can be found at\n+ * <http://www.gnu.org/licenses/lgpl.html>.\n+ *\n+ **/\n+ -->\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\"\n+         xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+         xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n+\n+    <parent>\n+        <groupId>ddf.platform.security</groupId>\n+        <artifactId>security</artifactId>\n+        <version>2.13.0-SNAPSHOT</version>\n+    </parent>\n+\n+    <modelVersion>4.0.0</modelVersion>\n+    <artifactId>session-management-endpoint</artifactId>","path":"platform/security/session-management-endpoint/pom.xml","position":26,"original_position":26,"commit_id":"2ec1d501d03e0fda34f1ac6db0364ebc664782b5","original_commit_id":"2ec1d501d03e0fda34f1ac6db0364ebc664782b5","user":{"login":"SmithJosh","id":3878142,"node_id":"MDQ6VXNlcjM4NzgxNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3878142?v=4","gravatar_id":"","url":"https://api.github.com/users/SmithJosh","html_url":"https://github.com/SmithJosh","followers_url":"https://api.github.com/users/SmithJosh/followers","following_url":"https://api.github.com/users/SmithJosh/following{/other_user}","gists_url":"https://api.github.com/users/SmithJosh/gists{/gist_id}","starred_url":"https://api.github.com/users/SmithJosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmithJosh/subscriptions","organizations_url":"https://api.github.com/users/SmithJosh/orgs","repos_url":"https://api.github.com/users/SmithJosh/repos","events_url":"https://api.github.com/users/SmithJosh/events{/privacy}","received_events_url":"https://api.github.com/users/SmithJosh/received_events","type":"User","site_admin":false},"body":"✏️ I think the naming of this bundle is a bit confusing because it's not an endpoint. Something like `session-manager-api` and `session-manager-impl` for the two new bundles might be more intuitive. Just a thought","created_at":"2018-07-03T21:13:56Z","updated_at":"2018-07-03T21:18:13Z","html_url":"https://github.com/codice/ddf/pull/3382#discussion_r199951678","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/3382","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/199951678"},"html":{"href":"https://github.com/codice/ddf/pull/3382#discussion_r199951678"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/3382"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3382","id":198788624,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Nzg4NjI0","html_url":"https://github.com/codice/ddf/pull/3382","diff_url":"https://github.com/codice/ddf/pull/3382.diff","patch_url":"https://github.com/codice/ddf/pull/3382.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/3382","number":3382,"state":"open","locked":false,"title":"DDF-3941 - Moved intrigue from using the SessionManagementService Endpoint under /services","user":{"login":"blen-desta","id":29550062,"node_id":"MDQ6VXNlcjI5NTUwMDYy","avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n**This is PR 3/6**\r\n- Extracted Session management implementation into a service\r\n- Changed current Session management to use extracted service\r\n- Added new endpoint under /search/catalog/internal\r\n- Changed code under `catalog-search-ui` to use new endpoint\r\n\r\n#### Who is reviewing it? \r\n@brjeter @SmithJosh  \r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here. If you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n@clockard\r\n@rzwiefel\r\n\r\n#### How should this be tested? (List steps with links to updated documentation)\r\nMake sure that session renewal, expiry and invalidation works from both intrigue and the admin console.\r\n\r\n#### What are the relevant tickets?\r\n[DDF-3941](https://codice.atlassian.net/browse/DDF-3941)\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-07-02T21:02:10Z","updated_at":"2018-07-03T21:18:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87b5cb086829fc7566e2bb6bc2afdee14fc5ed29","assignee":null,"assignees":[],"requested_reviewers":[{"login":"stustison","id":4391679,"node_id":"MDQ6VXNlcjQzOTE2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false},{"login":"rzwiefel","id":9013416,"node_id":"MDQ6VXNlcjkwMTM0MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9013416?v=4","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false},{"login":"andrewkfiedler","id":11984853,"node_id":"MDQ6VXNlcjExOTg0ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/3382/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/3382/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3382/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/2ec1d501d03e0fda34f1ac6db0364ebc664782b5","head":{"label":"blen-desta:DDF-3941-session","ref":"DDF-3941-session","sha":"2ec1d501d03e0fda34f1ac6db0364ebc664782b5","user":{"login":"blen-desta","id":29550062,"node_id":"MDQ6VXNlcjI5NTUwMDYy","avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"repo":{"id":94943263,"node_id":"MDEwOlJlcG9zaXRvcnk5NDk0MzI2Mw==","name":"ddf","full_name":"blen-desta/ddf","owner":{"login":"blen-desta","id":29550062,"node_id":"MDQ6VXNlcjI5NTUwMDYy","avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blen-desta/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":true,"url":"https://api.github.com/repos/blen-desta/ddf","forks_url":"https://api.github.com/repos/blen-desta/ddf/forks","keys_url":"https://api.github.com/repos/blen-desta/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blen-desta/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blen-desta/ddf/teams","hooks_url":"https://api.github.com/repos/blen-desta/ddf/hooks","issue_events_url":"https://api.github.com/repos/blen-desta/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/blen-desta/ddf/events","assignees_url":"https://api.github.com/repos/blen-desta/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/blen-desta/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/blen-desta/ddf/tags","blobs_url":"https://api.github.com/repos/blen-desta/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blen-desta/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blen-desta/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/blen-desta/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blen-desta/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/blen-desta/ddf/languages","stargazers_url":"https://api.github.com/repos/blen-desta/ddf/stargazers","contributors_url":"https://api.github.com/repos/blen-desta/ddf/contributors","subscribers_url":"https://api.github.com/repos/blen-desta/ddf/subscribers","subscription_url":"https://api.github.com/repos/blen-desta/ddf/subscription","commits_url":"https://api.github.com/repos/blen-desta/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/blen-desta/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/blen-desta/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/blen-desta/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/blen-desta/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/blen-desta/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blen-desta/ddf/merges","archive_url":"https://api.github.com/repos/blen-desta/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blen-desta/ddf/downloads","issues_url":"https://api.github.com/repos/blen-desta/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/blen-desta/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/blen-desta/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/blen-desta/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blen-desta/ddf/labels{/name}","releases_url":"https://api.github.com/repos/blen-desta/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/blen-desta/ddf/deployments","created_at":"2017-06-20T23:23:58Z","updated_at":"2017-06-20T23:24:16Z","pushed_at":"2018-07-02T21:42:42Z","git_url":"git://github.com/blen-desta/ddf.git","ssh_url":"git@github.com:blen-desta/ddf.git","clone_url":"https://github.com/blen-desta/ddf.git","svn_url":"https://github.com/blen-desta/ddf","homepage":"http://ddf.codice.org","size":354127,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"ea023af63ff11b9e734c95031ca3959d81b836bc","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzU2Mw==","name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-07-03T18:51:16Z","pushed_at":"2018-07-03T21:01:39Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":392941,"stargazers_count":83,"watchers_count":83,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":148,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":148,"open_issues":48,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/3382"},"html":{"href":"https://github.com/codice/ddf/pull/3382"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/3382"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/3382/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/3382/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/3382/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/2ec1d501d03e0fda34f1ac6db0364ebc664782b5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SmithJosh"}}