{"action":"created","comment":{"url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments/203475974","pull_request_review_id":138372880,"id":203475974,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQ3NTk3NA==","diff_hunk":"@@ -150,22 +133,19 @@ class IFile final : public ServiceFramework<IFile> {\n             return;\n         }\n \n-        // Write the data to the Storage backend\n         std::vector<u8> data = ctx.ReadBuffer();\n-        ResultVal<size_t> res = backend->Write(offset, length, true, data.data());\n-        if (res.Failed()) {\n-            IPC::ResponseBuilder rb{ctx, 2};\n-            rb.Push(res.Code());\n-            return;\n-        }\n+        data.resize(length);\n+        // Write the data to the Storage backend\n+        auto res = MakeResult<size_t>(backend->WriteBytes(data, offset));\n \n         IPC::ResponseBuilder rb{ctx, 2};\n-        rb.Push(RESULT_SUCCESS);\n+        rb.Push(res.Code());","path":"src/core/hle/service/filesystem/fsp_srv.cpp","position":115,"original_position":115,"commit_id":"7f68a2fa1294a2fb7e6208b6e927a1f2ca66816f","original_commit_id":"7f68a2fa1294a2fb7e6208b6e927a1f2ca66816f","user":{"login":"Subv","id":357072,"node_id":"MDQ6VXNlcjM1NzA3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/357072?v=4","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"body":"keep the old line","created_at":"2018-07-18T18:03:48Z","updated_at":"2018-07-18T18:07:54Z","html_url":"https://github.com/yuzu-emu/yuzu/pull/676#discussion_r203475974","pull_request_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/676","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments/203475974"},"html":{"href":"https://github.com/yuzu-emu/yuzu/pull/676#discussion_r203475974"},"pull_request":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/676"}}},"pull_request":{"url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/676","id":202082863,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDgyODYz","html_url":"https://github.com/yuzu-emu/yuzu/pull/676","diff_url":"https://github.com/yuzu-emu/yuzu/pull/676.diff","patch_url":"https://github.com/yuzu-emu/yuzu/pull/676.patch","issue_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/676","number":676,"state":"open","locked":false,"title":"Virtual Filesystem 2: Electric Boogaloo","user":{"login":"DarkLordZach","id":5064800,"node_id":"MDQ6VXNlcjUwNjQ4MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5064800?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkLordZach","html_url":"https://github.com/DarkLordZach","followers_url":"https://api.github.com/users/DarkLordZach/followers","following_url":"https://api.github.com/users/DarkLordZach/following{/other_user}","gists_url":"https://api.github.com/users/DarkLordZach/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkLordZach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkLordZach/subscriptions","organizations_url":"https://api.github.com/users/DarkLordZach/orgs","repos_url":"https://api.github.com/users/DarkLordZach/repos","events_url":"https://api.github.com/users/DarkLordZach/events{/privacy}","received_events_url":"https://api.github.com/users/DarkLordZach/received_events","type":"User","site_admin":false},"body":"Now including:\n- Fully-virtualized filesystem allowing for fancy fs-related stuff to be easier (Updates, DLC, new formats, encryption, et cetera. Keep your eyes peeled)\n- `VirtualFile` and `VirtualDir` typedefs to reprent files and dirs respectively\n- Basic implementations: `RealVfsFile`/`RealVfsDirectory` for files on the user's computer, `OffsetVfsFile` for a file at specified offset and size in another, `ReadOnlyVfsDirectory` a partial implementation that defaults all methods that only make sense for writable dirs.\n- Move NCA implementation to its own file `content_archive.[h|cpp]`\n- A fix for NCA file loading (they now boot -- it was an issue with the romfs offset)\n- Cleanup in the `core/file_sys` directory/namespace\n- Documentation is in `vfs.h`\n- `VfsDirectoryServiceWrapper` covers relevant VfsDirectory methods in ones that return `ResultCode`/`ResultVal` for easier interoperability with the Switch's FS services.\n- Fixes random save-data corruption issues (confirmed found in Binding of Isaac)\n- Remove unused path implementation from citra","created_at":"2018-07-17T21:46:41Z","updated_at":"2018-07-18T18:07:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4802000c4f2f1f18c2430550f384d5576037d803","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/676/commits","review_comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/676/comments","review_comment_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/676/comments","statuses_url":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/7f68a2fa1294a2fb7e6208b6e927a1f2ca66816f","head":{"label":"DarkLordZach:vfs2","ref":"vfs2","sha":"7f68a2fa1294a2fb7e6208b6e927a1f2ca66816f","user":{"login":"DarkLordZach","id":5064800,"node_id":"MDQ6VXNlcjUwNjQ4MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5064800?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkLordZach","html_url":"https://github.com/DarkLordZach","followers_url":"https://api.github.com/users/DarkLordZach/followers","following_url":"https://api.github.com/users/DarkLordZach/following{/other_user}","gists_url":"https://api.github.com/users/DarkLordZach/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkLordZach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkLordZach/subscriptions","organizations_url":"https://api.github.com/users/DarkLordZach/orgs","repos_url":"https://api.github.com/users/DarkLordZach/repos","events_url":"https://api.github.com/users/DarkLordZach/events{/privacy}","received_events_url":"https://api.github.com/users/DarkLordZach/received_events","type":"User","site_admin":false},"repo":{"id":137008966,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwMDg5NjY=","name":"yuzu","full_name":"DarkLordZach/yuzu","owner":{"login":"DarkLordZach","id":5064800,"node_id":"MDQ6VXNlcjUwNjQ4MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5064800?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkLordZach","html_url":"https://github.com/DarkLordZach","followers_url":"https://api.github.com/users/DarkLordZach/followers","following_url":"https://api.github.com/users/DarkLordZach/following{/other_user}","gists_url":"https://api.github.com/users/DarkLordZach/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkLordZach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkLordZach/subscriptions","organizations_url":"https://api.github.com/users/DarkLordZach/orgs","repos_url":"https://api.github.com/users/DarkLordZach/repos","events_url":"https://api.github.com/users/DarkLordZach/events{/privacy}","received_events_url":"https://api.github.com/users/DarkLordZach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DarkLordZach/yuzu","description":"Nintendo Switch Emulator","fork":true,"url":"https://api.github.com/repos/DarkLordZach/yuzu","forks_url":"https://api.github.com/repos/DarkLordZach/yuzu/forks","keys_url":"https://api.github.com/repos/DarkLordZach/yuzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DarkLordZach/yuzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DarkLordZach/yuzu/teams","hooks_url":"https://api.github.com/repos/DarkLordZach/yuzu/hooks","issue_events_url":"https://api.github.com/repos/DarkLordZach/yuzu/issues/events{/number}","events_url":"https://api.github.com/repos/DarkLordZach/yuzu/events","assignees_url":"https://api.github.com/repos/DarkLordZach/yuzu/assignees{/user}","branches_url":"https://api.github.com/repos/DarkLordZach/yuzu/branches{/branch}","tags_url":"https://api.github.com/repos/DarkLordZach/yuzu/tags","blobs_url":"https://api.github.com/repos/DarkLordZach/yuzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DarkLordZach/yuzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DarkLordZach/yuzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/DarkLordZach/yuzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DarkLordZach/yuzu/statuses/{sha}","languages_url":"https://api.github.com/repos/DarkLordZach/yuzu/languages","stargazers_url":"https://api.github.com/repos/DarkLordZach/yuzu/stargazers","contributors_url":"https://api.github.com/repos/DarkLordZach/yuzu/contributors","subscribers_url":"https://api.github.com/repos/DarkLordZach/yuzu/subscribers","subscription_url":"https://api.github.com/repos/DarkLordZach/yuzu/subscription","commits_url":"https://api.github.com/repos/DarkLordZach/yuzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/DarkLordZach/yuzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/DarkLordZach/yuzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/DarkLordZach/yuzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/DarkLordZach/yuzu/contents/{+path}","compare_url":"https://api.github.com/repos/DarkLordZach/yuzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DarkLordZach/yuzu/merges","archive_url":"https://api.github.com/repos/DarkLordZach/yuzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DarkLordZach/yuzu/downloads","issues_url":"https://api.github.com/repos/DarkLordZach/yuzu/issues{/number}","pulls_url":"https://api.github.com/repos/DarkLordZach/yuzu/pulls{/number}","milestones_url":"https://api.github.com/repos/DarkLordZach/yuzu/milestones{/number}","notifications_url":"https://api.github.com/repos/DarkLordZach/yuzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DarkLordZach/yuzu/labels{/name}","releases_url":"https://api.github.com/repos/DarkLordZach/yuzu/releases{/id}","deployments_url":"https://api.github.com/repos/DarkLordZach/yuzu/deployments","created_at":"2018-06-12T02:55:08Z","updated_at":"2018-07-18T17:19:46Z","pushed_at":"2018-07-18T18:07:08Z","git_url":"git://github.com/DarkLordZach/yuzu.git","ssh_url":"git@github.com:DarkLordZach/yuzu.git","clone_url":"https://github.com/DarkLordZach/yuzu.git","svn_url":"https://github.com/DarkLordZach/yuzu","homepage":"","size":19440,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yuzu-emu:master","ref":"master","sha":"69bfe075b5c3f6b17ce269950d1f8c9aab18e2de","user":{"login":"yuzu-emu","id":35075882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDc1ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/35075882?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzu-emu","html_url":"https://github.com/yuzu-emu","followers_url":"https://api.github.com/users/yuzu-emu/followers","following_url":"https://api.github.com/users/yuzu-emu/following{/other_user}","gists_url":"https://api.github.com/users/yuzu-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzu-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzu-emu/subscriptions","organizations_url":"https://api.github.com/users/yuzu-emu/orgs","repos_url":"https://api.github.com/users/yuzu-emu/repos","events_url":"https://api.github.com/users/yuzu-emu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzu-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":116167731,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjc3MzE=","name":"yuzu","full_name":"yuzu-emu/yuzu","owner":{"login":"yuzu-emu","id":35075882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDc1ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/35075882?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzu-emu","html_url":"https://github.com/yuzu-emu","followers_url":"https://api.github.com/users/yuzu-emu/followers","following_url":"https://api.github.com/users/yuzu-emu/following{/other_user}","gists_url":"https://api.github.com/users/yuzu-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzu-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzu-emu/subscriptions","organizations_url":"https://api.github.com/users/yuzu-emu/orgs","repos_url":"https://api.github.com/users/yuzu-emu/repos","events_url":"https://api.github.com/users/yuzu-emu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzu-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yuzu-emu/yuzu","description":"Nintendo Switch Emulator","fork":false,"url":"https://api.github.com/repos/yuzu-emu/yuzu","forks_url":"https://api.github.com/repos/yuzu-emu/yuzu/forks","keys_url":"https://api.github.com/repos/yuzu-emu/yuzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuzu-emu/yuzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuzu-emu/yuzu/teams","hooks_url":"https://api.github.com/repos/yuzu-emu/yuzu/hooks","issue_events_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/events{/number}","events_url":"https://api.github.com/repos/yuzu-emu/yuzu/events","assignees_url":"https://api.github.com/repos/yuzu-emu/yuzu/assignees{/user}","branches_url":"https://api.github.com/repos/yuzu-emu/yuzu/branches{/branch}","tags_url":"https://api.github.com/repos/yuzu-emu/yuzu/tags","blobs_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/{sha}","languages_url":"https://api.github.com/repos/yuzu-emu/yuzu/languages","stargazers_url":"https://api.github.com/repos/yuzu-emu/yuzu/stargazers","contributors_url":"https://api.github.com/repos/yuzu-emu/yuzu/contributors","subscribers_url":"https://api.github.com/repos/yuzu-emu/yuzu/subscribers","subscription_url":"https://api.github.com/repos/yuzu-emu/yuzu/subscription","commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuzu-emu/yuzu/contents/{+path}","compare_url":"https://api.github.com/repos/yuzu-emu/yuzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuzu-emu/yuzu/merges","archive_url":"https://api.github.com/repos/yuzu-emu/yuzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuzu-emu/yuzu/downloads","issues_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues{/number}","pulls_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls{/number}","milestones_url":"https://api.github.com/repos/yuzu-emu/yuzu/milestones{/number}","notifications_url":"https://api.github.com/repos/yuzu-emu/yuzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuzu-emu/yuzu/labels{/name}","releases_url":"https://api.github.com/repos/yuzu-emu/yuzu/releases{/id}","deployments_url":"https://api.github.com/repos/yuzu-emu/yuzu/deployments","created_at":"2018-01-03T18:13:57Z","updated_at":"2018-07-18T17:03:02Z","pushed_at":"2018-07-18T18:07:14Z","git_url":"git://github.com/yuzu-emu/yuzu.git","ssh_url":"git@github.com:yuzu-emu/yuzu.git","clone_url":"https://github.com/yuzu-emu/yuzu.git","svn_url":"https://github.com/yuzu-emu/yuzu","homepage":"","size":19316,"stargazers_count":4750,"watchers_count":4750,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":235,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":235,"open_issues":27,"watchers":4750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/676"},"html":{"href":"https://github.com/yuzu-emu/yuzu/pull/676"},"issue":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/issues/676"},"comments":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/issues/676/comments"},"review_comments":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/676/comments"},"review_comment":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/676/commits"},"statuses":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/7f68a2fa1294a2fb7e6208b6e927a1f2ca66816f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Subv"}}