{"action":"closed","issue":{"url":"https://api.github.com/repos/johanhaleby/kubetail/issues/52","repository_url":"https://api.github.com/repos/johanhaleby/kubetail","labels_url":"https://api.github.com/repos/johanhaleby/kubetail/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/johanhaleby/kubetail/issues/52/comments","events_url":"https://api.github.com/repos/johanhaleby/kubetail/issues/52/events","html_url":"https://github.com/johanhaleby/kubetail/issues/52","id":327362010,"node_id":"MDU6SXNzdWUzMjczNjIwMTA=","number":52,"title":"kubetail should fail if its subprocesses fail","user":{"login":"wallrj","id":978965,"node_id":"MDQ6VXNlcjk3ODk2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/978965?v=4","gravatar_id":"","url":"https://api.github.com/users/wallrj","html_url":"https://github.com/wallrj","followers_url":"https://api.github.com/users/wallrj/followers","following_url":"https://api.github.com/users/wallrj/following{/other_user}","gists_url":"https://api.github.com/users/wallrj/gists{/gist_id}","starred_url":"https://api.github.com/users/wallrj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallrj/subscriptions","organizations_url":"https://api.github.com/users/wallrj/orgs","repos_url":"https://api.github.com/users/wallrj/repos","events_url":"https://api.github.com/users/wallrj/events{/privacy}","received_events_url":"https://api.github.com/users/wallrj/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-29T15:03:41Z","updated_at":"2018-09-26T18:16:33Z","closed_at":"2018-09-26T18:16:33Z","author_association":"NONE","body":"I was trying `kubetail`  (5a238f8e9f5d8f63e5e87bcd15a409f784b5cc8e) and finding that it leaves behind orphan sub-processes after it exits  (#49).\r\n\r\nInitially I could see that it spawns a `kubectl logs` sub-process for each target Pod.\r\nAfter a while, I noticed that it had fewer `kubectl` sub-process.\r\n\r\nI attempted to run the `kubectl logs` command manually and noted the following error message:\r\n\r\n```\r\nkubectl logs fluentd-gcp-v2.0.17-hdrqq fluentd-gcp -f --since=10s --tail=-1 --namespace=kube-system\r\n...\r\nfailed to create fsnotify watcher: too many open files\r\n```\r\nAnd exit code 1.\r\n\r\nThis seems to be caused by https://github.com/kubernetes/kubernetes/issues/64315\r\n\r\n`kubetail` was masking this error.\r\n\r\nI think the `kubetail` ought to exit with a non-zero code and an error message if its sub-processes exit with a non-zero exit code."}}
{"actor":{"display_login":"johanhaleby"}}