{"action":"closed","number":1042,"pull_request":{"url":"https://api.github.com/repos/mimblewimble/grin/pulls/1042","id":186229258,"html_url":"https://github.com/mimblewimble/grin/pull/1042","diff_url":"https://github.com/mimblewimble/grin/pull/1042.diff","patch_url":"https://github.com/mimblewimble/grin/pull/1042.patch","issue_url":"https://api.github.com/repos/mimblewimble/grin/issues/1042","number":1042,"state":"closed","locked":false,"title":"[bin/grin] Make peer IP/port mandatory for ban/unban commands","user":{"login":"casey","id":1945,"avatar_url":"https://avatars2.githubusercontent.com/u/1945?v=4","gravatar_id":"","url":"https://api.github.com/users/casey","html_url":"https://github.com/casey","followers_url":"https://api.github.com/users/casey/followers","following_url":"https://api.github.com/users/casey/following{/other_user}","gists_url":"https://api.github.com/users/casey/gists{/gist_id}","starred_url":"https://api.github.com/users/casey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casey/subscriptions","organizations_url":"https://api.github.com/users/casey/orgs","repos_url":"https://api.github.com/users/casey/repos","events_url":"https://api.github.com/users/casey/events{/privacy}","received_events_url":"https://api.github.com/users/casey/received_events","type":"User","site_admin":false},"body":"By default, clap args are optional. Make them required, since otherwise the commands can't do anything.\r\n\r\nLots of whitespace churn, since there were some soft-tabs in there.","created_at":"2018-05-06T22:12:41Z","updated_at":"2018-05-08T14:27:05Z","closed_at":"2018-05-08T14:27:05Z","merged_at":"2018-05-08T14:27:05Z","merge_commit_sha":"9a8a0479d03c7ac5fd1493a31989190fd1201393","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mimblewimble/grin/pulls/1042/commits","review_comments_url":"https://api.github.com/repos/mimblewimble/grin/pulls/1042/comments","review_comment_url":"https://api.github.com/repos/mimblewimble/grin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mimblewimble/grin/issues/1042/comments","statuses_url":"https://api.github.com/repos/mimblewimble/grin/statuses/e20585fd36718da152c240a148c0251ddb35164e","head":{"label":"casey:mandatory-peer-address","ref":"mandatory-peer-address","sha":"e20585fd36718da152c240a148c0251ddb35164e","user":{"login":"casey","id":1945,"avatar_url":"https://avatars2.githubusercontent.com/u/1945?v=4","gravatar_id":"","url":"https://api.github.com/users/casey","html_url":"https://github.com/casey","followers_url":"https://api.github.com/users/casey/followers","following_url":"https://api.github.com/users/casey/following{/other_user}","gists_url":"https://api.github.com/users/casey/gists{/gist_id}","starred_url":"https://api.github.com/users/casey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casey/subscriptions","organizations_url":"https://api.github.com/users/casey/orgs","repos_url":"https://api.github.com/users/casey/repos","events_url":"https://api.github.com/users/casey/events{/privacy}","received_events_url":"https://api.github.com/users/casey/received_events","type":"User","site_admin":false},"repo":{"id":106127471,"name":"grin","full_name":"casey/grin","owner":{"login":"casey","id":1945,"avatar_url":"https://avatars2.githubusercontent.com/u/1945?v=4","gravatar_id":"","url":"https://api.github.com/users/casey","html_url":"https://github.com/casey","followers_url":"https://api.github.com/users/casey/followers","following_url":"https://api.github.com/users/casey/following{/other_user}","gists_url":"https://api.github.com/users/casey/gists{/gist_id}","starred_url":"https://api.github.com/users/casey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casey/subscriptions","organizations_url":"https://api.github.com/users/casey/orgs","repos_url":"https://api.github.com/users/casey/repos","events_url":"https://api.github.com/users/casey/events{/privacy}","received_events_url":"https://api.github.com/users/casey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/casey/grin","description":"Minimal implementation of the MimbleWimble protocol.","fork":true,"url":"https://api.github.com/repos/casey/grin","forks_url":"https://api.github.com/repos/casey/grin/forks","keys_url":"https://api.github.com/repos/casey/grin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/casey/grin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/casey/grin/teams","hooks_url":"https://api.github.com/repos/casey/grin/hooks","issue_events_url":"https://api.github.com/repos/casey/grin/issues/events{/number}","events_url":"https://api.github.com/repos/casey/grin/events","assignees_url":"https://api.github.com/repos/casey/grin/assignees{/user}","branches_url":"https://api.github.com/repos/casey/grin/branches{/branch}","tags_url":"https://api.github.com/repos/casey/grin/tags","blobs_url":"https://api.github.com/repos/casey/grin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/casey/grin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/casey/grin/git/refs{/sha}","trees_url":"https://api.github.com/repos/casey/grin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/casey/grin/statuses/{sha}","languages_url":"https://api.github.com/repos/casey/grin/languages","stargazers_url":"https://api.github.com/repos/casey/grin/stargazers","contributors_url":"https://api.github.com/repos/casey/grin/contributors","subscribers_url":"https://api.github.com/repos/casey/grin/subscribers","subscription_url":"https://api.github.com/repos/casey/grin/subscription","commits_url":"https://api.github.com/repos/casey/grin/commits{/sha}","git_commits_url":"https://api.github.com/repos/casey/grin/git/commits{/sha}","comments_url":"https://api.github.com/repos/casey/grin/comments{/number}","issue_comment_url":"https://api.github.com/repos/casey/grin/issues/comments{/number}","contents_url":"https://api.github.com/repos/casey/grin/contents/{+path}","compare_url":"https://api.github.com/repos/casey/grin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/casey/grin/merges","archive_url":"https://api.github.com/repos/casey/grin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/casey/grin/downloads","issues_url":"https://api.github.com/repos/casey/grin/issues{/number}","pulls_url":"https://api.github.com/repos/casey/grin/pulls{/number}","milestones_url":"https://api.github.com/repos/casey/grin/milestones{/number}","notifications_url":"https://api.github.com/repos/casey/grin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/casey/grin/labels{/name}","releases_url":"https://api.github.com/repos/casey/grin/releases{/id}","deployments_url":"https://api.github.com/repos/casey/grin/deployments","created_at":"2017-10-07T20:13:41Z","updated_at":"2018-03-14T03:26:21Z","pushed_at":"2018-05-07T21:31:46Z","git_url":"git://github.com/casey/grin.git","ssh_url":"git@github.com:casey/grin.git","clone_url":"https://github.com/casey/grin.git","svn_url":"https://github.com/casey/grin","homepage":"http://grin-tech.org/","size":6083,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mimblewimble:master","ref":"master","sha":"ad6e7814de279d6428f351ae0cca4c7648ab45bb","user":{"login":"mimblewimble","id":23646132,"avatar_url":"https://avatars0.githubusercontent.com/u/23646132?v=4","gravatar_id":"","url":"https://api.github.com/users/mimblewimble","html_url":"https://github.com/mimblewimble","followers_url":"https://api.github.com/users/mimblewimble/followers","following_url":"https://api.github.com/users/mimblewimble/following{/other_user}","gists_url":"https://api.github.com/users/mimblewimble/gists{/gist_id}","starred_url":"https://api.github.com/users/mimblewimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mimblewimble/subscriptions","organizations_url":"https://api.github.com/users/mimblewimble/orgs","repos_url":"https://api.github.com/users/mimblewimble/repos","events_url":"https://api.github.com/users/mimblewimble/events{/privacy}","received_events_url":"https://api.github.com/users/mimblewimble/received_events","type":"Organization","site_admin":false},"repo":{"id":71514072,"name":"grin","full_name":"mimblewimble/grin","owner":{"login":"mimblewimble","id":23646132,"avatar_url":"https://avatars0.githubusercontent.com/u/23646132?v=4","gravatar_id":"","url":"https://api.github.com/users/mimblewimble","html_url":"https://github.com/mimblewimble","followers_url":"https://api.github.com/users/mimblewimble/followers","following_url":"https://api.github.com/users/mimblewimble/following{/other_user}","gists_url":"https://api.github.com/users/mimblewimble/gists{/gist_id}","starred_url":"https://api.github.com/users/mimblewimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mimblewimble/subscriptions","organizations_url":"https://api.github.com/users/mimblewimble/orgs","repos_url":"https://api.github.com/users/mimblewimble/repos","events_url":"https://api.github.com/users/mimblewimble/events{/privacy}","received_events_url":"https://api.github.com/users/mimblewimble/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mimblewimble/grin","description":"Minimal implementation of the MimbleWimble protocol.","fork":false,"url":"https://api.github.com/repos/mimblewimble/grin","forks_url":"https://api.github.com/repos/mimblewimble/grin/forks","keys_url":"https://api.github.com/repos/mimblewimble/grin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mimblewimble/grin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mimblewimble/grin/teams","hooks_url":"https://api.github.com/repos/mimblewimble/grin/hooks","issue_events_url":"https://api.github.com/repos/mimblewimble/grin/issues/events{/number}","events_url":"https://api.github.com/repos/mimblewimble/grin/events","assignees_url":"https://api.github.com/repos/mimblewimble/grin/assignees{/user}","branches_url":"https://api.github.com/repos/mimblewimble/grin/branches{/branch}","tags_url":"https://api.github.com/repos/mimblewimble/grin/tags","blobs_url":"https://api.github.com/repos/mimblewimble/grin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mimblewimble/grin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mimblewimble/grin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mimblewimble/grin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mimblewimble/grin/statuses/{sha}","languages_url":"https://api.github.com/repos/mimblewimble/grin/languages","stargazers_url":"https://api.github.com/repos/mimblewimble/grin/stargazers","contributors_url":"https://api.github.com/repos/mimblewimble/grin/contributors","subscribers_url":"https://api.github.com/repos/mimblewimble/grin/subscribers","subscription_url":"https://api.github.com/repos/mimblewimble/grin/subscription","commits_url":"https://api.github.com/repos/mimblewimble/grin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mimblewimble/grin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mimblewimble/grin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mimblewimble/grin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mimblewimble/grin/contents/{+path}","compare_url":"https://api.github.com/repos/mimblewimble/grin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mimblewimble/grin/merges","archive_url":"https://api.github.com/repos/mimblewimble/grin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mimblewimble/grin/downloads","issues_url":"https://api.github.com/repos/mimblewimble/grin/issues{/number}","pulls_url":"https://api.github.com/repos/mimblewimble/grin/pulls{/number}","milestones_url":"https://api.github.com/repos/mimblewimble/grin/milestones{/number}","notifications_url":"https://api.github.com/repos/mimblewimble/grin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mimblewimble/grin/labels{/name}","releases_url":"https://api.github.com/repos/mimblewimble/grin/releases{/id}","deployments_url":"https://api.github.com/repos/mimblewimble/grin/deployments","created_at":"2016-10-21T00:02:23Z","updated_at":"2018-05-08T14:23:38Z","pushed_at":"2018-05-08T14:27:05Z","git_url":"git://github.com/mimblewimble/grin.git","ssh_url":"git@github.com:mimblewimble/grin.git","clone_url":"https://github.com/mimblewimble/grin.git","svn_url":"https://github.com/mimblewimble/grin","homepage":"http://grin-tech.org/","size":6332,"stargazers_count":1103,"watchers_count":1103,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":200,"open_issues":108,"watchers":1103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mimblewimble/grin/pulls/1042"},"html":{"href":"https://github.com/mimblewimble/grin/pull/1042"},"issue":{"href":"https://api.github.com/repos/mimblewimble/grin/issues/1042"},"comments":{"href":"https://api.github.com/repos/mimblewimble/grin/issues/1042/comments"},"review_comments":{"href":"https://api.github.com/repos/mimblewimble/grin/pulls/1042/comments"},"review_comment":{"href":"https://api.github.com/repos/mimblewimble/grin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mimblewimble/grin/pulls/1042/commits"},"statuses":{"href":"https://api.github.com/repos/mimblewimble/grin/statuses/e20585fd36718da152c240a148c0251ddb35164e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"quentinlesceller","id":11842328,"avatar_url":"https://avatars1.githubusercontent.com/u/11842328?v=4","gravatar_id":"","url":"https://api.github.com/users/quentinlesceller","html_url":"https://github.com/quentinlesceller","followers_url":"https://api.github.com/users/quentinlesceller/followers","following_url":"https://api.github.com/users/quentinlesceller/following{/other_user}","gists_url":"https://api.github.com/users/quentinlesceller/gists{/gist_id}","starred_url":"https://api.github.com/users/quentinlesceller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quentinlesceller/subscriptions","organizations_url":"https://api.github.com/users/quentinlesceller/orgs","repos_url":"https://api.github.com/users/quentinlesceller/repos","events_url":"https://api.github.com/users/quentinlesceller/events{/privacy}","received_events_url":"https://api.github.com/users/quentinlesceller/received_events","type":"User","site_admin":false},"comments":3,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"quentinlesceller"}}