{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/365","repository_url":"https://api.github.com/repos/kubernetes/ingress-gce","labels_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/365/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/365/comments","events_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/365/events","html_url":"https://github.com/kubernetes/ingress-gce/pull/365","id":335603526,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjYzMDk5","number":365,"title":"Fix the issue where Shutdown doesn't shutdown taskqueue","user":{"login":"anfernee","id":174200,"node_id":"MDQ6VXNlcjE3NDIwMA==","avatar_url":"https://avatars3.githubusercontent.com/u/174200?v=4","gravatar_id":"","url":"https://api.github.com/users/anfernee","html_url":"https://github.com/anfernee","followers_url":"https://api.github.com/users/anfernee/followers","following_url":"https://api.github.com/users/anfernee/following{/other_user}","gists_url":"https://api.github.com/users/anfernee/gists{/gist_id}","starred_url":"https://api.github.com/users/anfernee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anfernee/subscriptions","organizations_url":"https://api.github.com/users/anfernee/orgs","repos_url":"https://api.github.com/users/anfernee/repos","events_url":"https://api.github.com/users/anfernee/events{/privacy}","received_events_url":"https://api.github.com/users/anfernee/received_events","type":"User","site_admin":false},"labels":[{"id":764098218,"node_id":"MDU6TGFiZWw3NjQwOTgyMTg=","url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":712525210,"node_id":"MDU6TGFiZWw3MTI1MjUyMTA=","url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":712537038,"node_id":"MDU6TGFiZWw3MTI1MzcwMzg=","url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":778118702,"node_id":"MDU6TGFiZWw3NzgxMTg3MDI=","url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/lifecycle/stale","name":"lifecycle/stale","color":"795548","default":false},{"id":715110851,"node_id":"MDU6TGFiZWw3MTUxMTA4NTE=","url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"bowei","id":837034,"node_id":"MDQ6VXNlcjgzNzAzNA==","avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},"assignees":[{"login":"bowei","id":837034,"node_id":"MDQ6VXNlcjgzNzAzNA==","avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},{"login":"rramkumar1","id":20979322,"node_id":"MDQ6VXNlcjIwOTc5MzIy","avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-06-25T23:28:37Z","updated_at":"2018-10-30T16:00:33Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/365","html_url":"https://github.com/kubernetes/ingress-gce/pull/365","diff_url":"https://github.com/kubernetes/ingress-gce/pull/365.diff","patch_url":"https://github.com/kubernetes/ingress-gce/pull/365.patch"},"body":"Originally, PeriodicTaskQueue has 2 loops:\r\n- wait.Until managed by stopCh\r\n- for loop in worker() managed by workqueue\r\n\r\nShutdown only exits the second loop. Failing to close stopCh before\r\ncalling Shutdown will cause panic because of double close workDone\r\nchannel."},"comment":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/comments/434361062","html_url":"https://github.com/kubernetes/ingress-gce/pull/365#issuecomment-434361062","issue_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/365","id":434361062,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDM2MTA2Mg==","user":{"login":"rramkumar1","id":20979322,"node_id":"MDQ6VXNlcjIwOTc5MzIy","avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T16:00:33Z","updated_at":"2018-10-30T16:00:33Z","author_association":"MEMBER","body":"/retest"}}
{"actor":{"display_login":"rramkumar1"}}