{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1602","repository_url":"https://api.github.com/repos/ARMmbed/mbedtls","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1602/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1602/comments","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1602/events","html_url":"https://github.com/ARMmbed/mbedtls/pull/1602","id":318957871,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg1MDA2NjIy","number":1602,"title":"Add AES-XTS","user":{"login":"Patater","id":410816,"node_id":"MDQ6VXNlcjQxMDgxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/410816?v=4","gravatar_id":"","url":"https://api.github.com/users/Patater","html_url":"https://github.com/Patater","followers_url":"https://api.github.com/users/Patater/followers","following_url":"https://api.github.com/users/Patater/following{/other_user}","gists_url":"https://api.github.com/users/Patater/gists{/gist_id}","starred_url":"https://api.github.com/users/Patater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patater/subscriptions","organizations_url":"https://api.github.com/users/Patater/orgs","repos_url":"https://api.github.com/users/Patater/repos","events_url":"https://api.github.com/users/Patater/events{/privacy}","received_events_url":"https://api.github.com/users/Patater/received_events","type":"User","site_admin":false},"labels":[{"id":817445289,"node_id":"MDU6TGFiZWw4MTc0NDUyODk=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/approved%20for%20design","name":"approved for design","color":"66cc00","default":false},{"id":937148743,"node_id":"MDU6TGFiZWw5MzcxNDg3NDM=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/component:%20Crypto","name":"component: Crypto","color":"F5F6CE","default":false},{"id":19280386,"node_id":"MDU6TGFiZWwxOTI4MDM4Ng==","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":408190313,"node_id":"MDU6TGFiZWw0MDgxOTAzMTM=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/mbed%20TLS%20team","name":"mbed TLS team","color":"66e0ff","default":false},{"id":705358813,"node_id":"MDU6TGFiZWw3MDUzNTg4MTM=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs%20review","name":"needs review","color":"fbca04","default":false},{"id":435765575,"node_id":"MDU6TGFiZWw0MzU3NjU1NzU=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs%20work","name":"needs work","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-04-30T16:47:22Z","updated_at":"2018-06-12T10:36:56Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1602","html_url":"https://github.com/ARMmbed/mbedtls/pull/1602","diff_url":"https://github.com/ARMmbed/mbedtls/pull/1602.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/1602.patch"},"body":"Add the XTS block cipher mode to the library. Continued from #414.\r\n\r\nTODO\r\n- ~~Decide if we want a new public API for multiply by _x_ GF(128), or turn this into a static function inside aes.c (the only place that currently uses it)~~ Turned into a static function inside aes.c\r\n- ~~Resolve test issues for \"too large\" sectors.~~ The test still fails with a segfault on NULL access (not garbage), so we aren't letting bugs slip through. Error reporting could be improved here, though (maybe later).\r\n- ~~Refactor `aes_encrypt_xts` and `aes_decrypt_xts` test functions (in `tests/suites/test_suite_aes.function`) to avoid duplicate code, either by combining the functions or adding a shared helper function.~~ We just live with duplicated code in our tests."},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments/396544810","html_url":"https://github.com/ARMmbed/mbedtls/pull/1602#issuecomment-396544810","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1602","id":396544810,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjU0NDgxMA==","user":{"login":"Patater","id":410816,"node_id":"MDQ6VXNlcjQxMDgxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/410816?v=4","gravatar_id":"","url":"https://api.github.com/users/Patater","html_url":"https://github.com/Patater","followers_url":"https://api.github.com/users/Patater/followers","following_url":"https://api.github.com/users/Patater/following{/other_user}","gists_url":"https://api.github.com/users/Patater/gists{/gist_id}","starred_url":"https://api.github.com/users/Patater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patater/subscriptions","organizations_url":"https://api.github.com/users/Patater/orgs","repos_url":"https://api.github.com/users/Patater/repos","events_url":"https://api.github.com/users/Patater/events{/privacy}","received_events_url":"https://api.github.com/users/Patater/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T10:36:56Z","updated_at":"2018-06-12T10:36:56Z","author_association":"COLLABORATOR","body":"Fixes now included in this PR.\r\n\r\nOld branch https://github.com/Patater/mbedtls/tree/dev/patater/xts-r6\r\nNew branch https://github.com/Patater/mbedtls/tree/dev/patater/xts\r\n\r\nDiff (adds XTS to aria cipher info structs) https://gist.github.com/Patater/653ff4d3cdf94a0caff0dba875dd6c7c\r\n\r\nNote that OFB is expected to merge first and may conflict with this PR in a non-trivial way, so we may need yet another rebase."}}
{"actor":{"display_login":"Patater"}}