{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/alauda/kubernetes/pulls/25","id":209315949,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzE1OTQ5","html_url":"https://github.com/alauda/kubernetes/pull/25","diff_url":"https://github.com/alauda/kubernetes/pull/25.diff","patch_url":"https://github.com/alauda/kubernetes/pull/25.patch","issue_url":"https://api.github.com/repos/alauda/kubernetes/issues/25","number":25,"state":"closed","locked":false,"title":"Fix for duplicate revisions created by StatefulSet","user":{"login":"tossmilestone","id":1621082,"node_id":"MDQ6VXNlcjE2MjEwODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1621082?v=4","gravatar_id":"","url":"https://api.github.com/users/tossmilestone","html_url":"https://github.com/tossmilestone","followers_url":"https://api.github.com/users/tossmilestone/followers","following_url":"https://api.github.com/users/tossmilestone/following{/other_user}","gists_url":"https://api.github.com/users/tossmilestone/gists{/gist_id}","starred_url":"https://api.github.com/users/tossmilestone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tossmilestone/subscriptions","organizations_url":"https://api.github.com/users/tossmilestone/orgs","repos_url":"https://api.github.com/users/tossmilestone/repos","events_url":"https://api.github.com/users/tossmilestone/events{/privacy}","received_events_url":"https://api.github.com/users/tossmilestone/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThis PR replaces PR #65038 as a fix to issue #55159. The statefulset controller can in some situations create more controller revisions than necessary and this change makes sure the controller checks with the API server and only create new revision if the raw data is different.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #55159\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nid creating new controller revisions for statefulsets when cache is stale\r\n```\r\n","created_at":"2018-08-18T15:06:05Z","updated_at":"2018-08-18T15:06:13Z","closed_at":"2018-08-18T15:06:13Z","merged_at":"2018-08-18T15:06:13Z","merge_commit_sha":"123bcf4bcf5e6a14c82457f3d8a96a5a85c01397","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alauda/kubernetes/pulls/25/commits","review_comments_url":"https://api.github.com/repos/alauda/kubernetes/pulls/25/comments","review_comment_url":"https://api.github.com/repos/alauda/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alauda/kubernetes/issues/25/comments","statuses_url":"https://api.github.com/repos/alauda/kubernetes/statuses/f97f23917a03e8d13654bd61780a0f6d82452f09","head":{"label":"tossmilestone:AvoidDuplicateRevisionsForStatefulSet","ref":"AvoidDuplicateRevisionsForStatefulSet","sha":"f97f23917a03e8d13654bd61780a0f6d82452f09","user":{"login":"tossmilestone","id":1621082,"node_id":"MDQ6VXNlcjE2MjEwODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1621082?v=4","gravatar_id":"","url":"https://api.github.com/users/tossmilestone","html_url":"https://github.com/tossmilestone","followers_url":"https://api.github.com/users/tossmilestone/followers","following_url":"https://api.github.com/users/tossmilestone/following{/other_user}","gists_url":"https://api.github.com/users/tossmilestone/gists{/gist_id}","starred_url":"https://api.github.com/users/tossmilestone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tossmilestone/subscriptions","organizations_url":"https://api.github.com/users/tossmilestone/orgs","repos_url":"https://api.github.com/users/tossmilestone/repos","events_url":"https://api.github.com/users/tossmilestone/events{/privacy}","received_events_url":"https://api.github.com/users/tossmilestone/received_events","type":"User","site_admin":false},"repo":{"id":117482039,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc0ODIwMzk=","name":"kubernetes","full_name":"tossmilestone/kubernetes","owner":{"login":"tossmilestone","id":1621082,"node_id":"MDQ6VXNlcjE2MjEwODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1621082?v=4","gravatar_id":"","url":"https://api.github.com/users/tossmilestone","html_url":"https://github.com/tossmilestone","followers_url":"https://api.github.com/users/tossmilestone/followers","following_url":"https://api.github.com/users/tossmilestone/following{/other_user}","gists_url":"https://api.github.com/users/tossmilestone/gists{/gist_id}","starred_url":"https://api.github.com/users/tossmilestone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tossmilestone/subscriptions","organizations_url":"https://api.github.com/users/tossmilestone/orgs","repos_url":"https://api.github.com/users/tossmilestone/repos","events_url":"https://api.github.com/users/tossmilestone/events{/privacy}","received_events_url":"https://api.github.com/users/tossmilestone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tossmilestone/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/tossmilestone/kubernetes","forks_url":"https://api.github.com/repos/tossmilestone/kubernetes/forks","keys_url":"https://api.github.com/repos/tossmilestone/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tossmilestone/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tossmilestone/kubernetes/teams","hooks_url":"https://api.github.com/repos/tossmilestone/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/tossmilestone/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/tossmilestone/kubernetes/events","assignees_url":"https://api.github.com/repos/tossmilestone/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/tossmilestone/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/tossmilestone/kubernetes/tags","blobs_url":"https://api.github.com/repos/tossmilestone/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tossmilestone/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tossmilestone/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/tossmilestone/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tossmilestone/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/tossmilestone/kubernetes/languages","stargazers_url":"https://api.github.com/repos/tossmilestone/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/tossmilestone/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/tossmilestone/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/tossmilestone/kubernetes/subscription","commits_url":"https://api.github.com/repos/tossmilestone/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/tossmilestone/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/tossmilestone/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/tossmilestone/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/tossmilestone/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/tossmilestone/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tossmilestone/kubernetes/merges","archive_url":"https://api.github.com/repos/tossmilestone/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tossmilestone/kubernetes/downloads","issues_url":"https://api.github.com/repos/tossmilestone/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/tossmilestone/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/tossmilestone/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/tossmilestone/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tossmilestone/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/tossmilestone/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/tossmilestone/kubernetes/deployments","created_at":"2018-01-15T01:23:39Z","updated_at":"2018-01-15T01:24:15Z","pushed_at":"2018-08-18T14:54:43Z","git_url":"git://github.com/tossmilestone/kubernetes.git","ssh_url":"git@github.com:tossmilestone/kubernetes.git","clone_url":"https://github.com/tossmilestone/kubernetes.git","svn_url":"https://github.com/tossmilestone/kubernetes","homepage":"http://kubernetes.io","size":556413,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alauda:release-1.9.10","ref":"release-1.9.10","sha":"5f2b2feb616c399bbce1ec30a145190f0b349013","user":{"login":"alauda","id":22073292,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDczMjky","avatar_url":"https://avatars1.githubusercontent.com/u/22073292?v=4","gravatar_id":"","url":"https://api.github.com/users/alauda","html_url":"https://github.com/alauda","followers_url":"https://api.github.com/users/alauda/followers","following_url":"https://api.github.com/users/alauda/following{/other_user}","gists_url":"https://api.github.com/users/alauda/gists{/gist_id}","starred_url":"https://api.github.com/users/alauda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alauda/subscriptions","organizations_url":"https://api.github.com/users/alauda/orgs","repos_url":"https://api.github.com/users/alauda/repos","events_url":"https://api.github.com/users/alauda/events{/privacy}","received_events_url":"https://api.github.com/users/alauda/received_events","type":"Organization","site_admin":false},"repo":{"id":138244454,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyNDQ0NTQ=","name":"kubernetes","full_name":"alauda/kubernetes","owner":{"login":"alauda","id":22073292,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDczMjky","avatar_url":"https://avatars1.githubusercontent.com/u/22073292?v=4","gravatar_id":"","url":"https://api.github.com/users/alauda","html_url":"https://github.com/alauda","followers_url":"https://api.github.com/users/alauda/followers","following_url":"https://api.github.com/users/alauda/following{/other_user}","gists_url":"https://api.github.com/users/alauda/gists{/gist_id}","starred_url":"https://api.github.com/users/alauda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alauda/subscriptions","organizations_url":"https://api.github.com/users/alauda/orgs","repos_url":"https://api.github.com/users/alauda/repos","events_url":"https://api.github.com/users/alauda/events{/privacy}","received_events_url":"https://api.github.com/users/alauda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alauda/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/alauda/kubernetes","forks_url":"https://api.github.com/repos/alauda/kubernetes/forks","keys_url":"https://api.github.com/repos/alauda/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alauda/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alauda/kubernetes/teams","hooks_url":"https://api.github.com/repos/alauda/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/alauda/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/alauda/kubernetes/events","assignees_url":"https://api.github.com/repos/alauda/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/alauda/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/alauda/kubernetes/tags","blobs_url":"https://api.github.com/repos/alauda/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alauda/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alauda/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/alauda/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alauda/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/alauda/kubernetes/languages","stargazers_url":"https://api.github.com/repos/alauda/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/alauda/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/alauda/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/alauda/kubernetes/subscription","commits_url":"https://api.github.com/repos/alauda/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/alauda/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/alauda/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/alauda/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/alauda/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/alauda/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alauda/kubernetes/merges","archive_url":"https://api.github.com/repos/alauda/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alauda/kubernetes/downloads","issues_url":"https://api.github.com/repos/alauda/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/alauda/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/alauda/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/alauda/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alauda/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/alauda/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/alauda/kubernetes/deployments","created_at":"2018-06-22T02:22:57Z","updated_at":"2018-07-16T02:40:26Z","pushed_at":"2018-08-18T15:06:12Z","git_url":"git://github.com/alauda/kubernetes.git","ssh_url":"git@github.com:alauda/kubernetes.git","clone_url":"https://github.com/alauda/kubernetes.git","svn_url":"https://github.com/alauda/kubernetes","homepage":"http://kubernetes.io","size":568989,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alauda/kubernetes/pulls/25"},"html":{"href":"https://github.com/alauda/kubernetes/pull/25"},"issue":{"href":"https://api.github.com/repos/alauda/kubernetes/issues/25"},"comments":{"href":"https://api.github.com/repos/alauda/kubernetes/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/alauda/kubernetes/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/alauda/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alauda/kubernetes/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/alauda/kubernetes/statuses/f97f23917a03e8d13654bd61780a0f6d82452f09"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tossmilestone","id":1621082,"node_id":"MDQ6VXNlcjE2MjEwODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1621082?v=4","gravatar_id":"","url":"https://api.github.com/users/tossmilestone","html_url":"https://github.com/tossmilestone","followers_url":"https://api.github.com/users/tossmilestone/followers","following_url":"https://api.github.com/users/tossmilestone/following{/other_user}","gists_url":"https://api.github.com/users/tossmilestone/gists{/gist_id}","starred_url":"https://api.github.com/users/tossmilestone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tossmilestone/subscriptions","organizations_url":"https://api.github.com/users/tossmilestone/orgs","repos_url":"https://api.github.com/users/tossmilestone/repos","events_url":"https://api.github.com/users/tossmilestone/events{/privacy}","received_events_url":"https://api.github.com/users/tossmilestone/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":24,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"tossmilestone"}}