{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/opam-repository/pulls/comments/213236789","pull_request_review_id":150029135,"id":213236789,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzIzNjc4OQ==","diff_hunk":"@@ -0,0 +1,31 @@\n+diff --git a/src/dune b/src/dune\n+index be85e03..05d61a4 100644\n+--- a/src/dune\n++++ b/src/dune\n+@@ -9,6 +9,7 @@\n+  (flags -w -27)\n+  (c_names otc_wrapper)\n+  (c_flags -O2 -I 3rd-party/tokyocabinet)\n++ (modes native)","path":"packages/camltc/camltc.0.9.8/files/osx.patch","position":9,"original_position":9,"commit_id":"0965123071cd04d6ef30c40feb9af32af854fa27","original_commit_id":"9e6910f39eca933b484d2fd6aff37acd965ecb5f","user":{"login":"andersfugmann","id":647024,"node_id":"MDQ6VXNlcjY0NzAyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/647024?v=4","gravatar_id":"","url":"https://api.github.com/users/andersfugmann","html_url":"https://github.com/andersfugmann","followers_url":"https://api.github.com/users/andersfugmann/followers","following_url":"https://api.github.com/users/andersfugmann/following{/other_user}","gists_url":"https://api.github.com/users/andersfugmann/gists{/gist_id}","starred_url":"https://api.github.com/users/andersfugmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersfugmann/subscriptions","organizations_url":"https://api.github.com/users/andersfugmann/orgs","repos_url":"https://api.github.com/users/andersfugmann/repos","events_url":"https://api.github.com/users/andersfugmann/events{/privacy}","received_events_url":"https://api.github.com/users/andersfugmann/received_events","type":"User","site_admin":false},"body":"just to elaborate a bit: Under linux, If I remove the rule to generate the 'dlltc_stubs.so', the build will fail. Adding `(modes native)` to the library camltc.tc make is complete, and I assume the same goes for the osx build. \r\nI would agree that the `(modes native)` is slightly redundant for the camltc library, as I assume its inferred from camltc.tc lib, but is causes no harm. \r\n","created_at":"2018-08-28T09:07:24Z","updated_at":"2018-08-28T09:07:24Z","html_url":"https://github.com/ocaml/opam-repository/pull/12520#discussion_r213236789","pull_request_url":"https://api.github.com/repos/ocaml/opam-repository/pulls/12520","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/comments/213236789"},"html":{"href":"https://github.com/ocaml/opam-repository/pull/12520#discussion_r213236789"},"pull_request":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/12520"}},"in_reply_to_id":213232379},"pull_request":{"url":"https://api.github.com/repos/ocaml/opam-repository/pulls/12520","id":211092471,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMDkyNDcx","html_url":"https://github.com/ocaml/opam-repository/pull/12520","diff_url":"https://github.com/ocaml/opam-repository/pull/12520.diff","patch_url":"https://github.com/ocaml/opam-repository/pull/12520.patch","issue_url":"https://api.github.com/repos/ocaml/opam-repository/issues/12520","number":12520,"state":"open","locked":false,"title":"camltc.0.9.8","user":{"login":"andersfugmann","id":647024,"node_id":"MDQ6VXNlcjY0NzAyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/647024?v=4","gravatar_id":"","url":"https://api.github.com/users/andersfugmann","html_url":"https://github.com/andersfugmann","followers_url":"https://api.github.com/users/andersfugmann/followers","following_url":"https://api.github.com/users/andersfugmann/following{/other_user}","gists_url":"https://api.github.com/users/andersfugmann/gists{/gist_id}","starred_url":"https://api.github.com/users/andersfugmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersfugmann/subscriptions","organizations_url":"https://api.github.com/users/andersfugmann/orgs","repos_url":"https://api.github.com/users/andersfugmann/repos","events_url":"https://api.github.com/users/andersfugmann/events{/privacy}","received_events_url":"https://api.github.com/users/andersfugmann/received_events","type":"User","site_admin":false},"body":"Switch to dune","created_at":"2018-08-27T12:20:15Z","updated_at":"2018-08-28T09:07:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43ab1a3c8dc469c5ee08f2567f2483c29ea2374a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/opam-repository/pulls/12520/commits","review_comments_url":"https://api.github.com/repos/ocaml/opam-repository/pulls/12520/comments","review_comment_url":"https://api.github.com/repos/ocaml/opam-repository/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/opam-repository/issues/12520/comments","statuses_url":"https://api.github.com/repos/ocaml/opam-repository/statuses/0965123071cd04d6ef30c40feb9af32af854fa27","head":{"label":"andersfugmann:camltc.0.9.8","ref":"camltc.0.9.8","sha":"0965123071cd04d6ef30c40feb9af32af854fa27","user":{"login":"andersfugmann","id":647024,"node_id":"MDQ6VXNlcjY0NzAyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/647024?v=4","gravatar_id":"","url":"https://api.github.com/users/andersfugmann","html_url":"https://github.com/andersfugmann","followers_url":"https://api.github.com/users/andersfugmann/followers","following_url":"https://api.github.com/users/andersfugmann/following{/other_user}","gists_url":"https://api.github.com/users/andersfugmann/gists{/gist_id}","starred_url":"https://api.github.com/users/andersfugmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersfugmann/subscriptions","organizations_url":"https://api.github.com/users/andersfugmann/orgs","repos_url":"https://api.github.com/users/andersfugmann/repos","events_url":"https://api.github.com/users/andersfugmann/events{/privacy}","received_events_url":"https://api.github.com/users/andersfugmann/received_events","type":"User","site_admin":false},"repo":{"id":18667323,"node_id":"MDEwOlJlcG9zaXRvcnkxODY2NzMyMw==","name":"opam-repository","full_name":"andersfugmann/opam-repository","owner":{"login":"andersfugmann","id":647024,"node_id":"MDQ6VXNlcjY0NzAyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/647024?v=4","gravatar_id":"","url":"https://api.github.com/users/andersfugmann","html_url":"https://github.com/andersfugmann","followers_url":"https://api.github.com/users/andersfugmann/followers","following_url":"https://api.github.com/users/andersfugmann/following{/other_user}","gists_url":"https://api.github.com/users/andersfugmann/gists{/gist_id}","starred_url":"https://api.github.com/users/andersfugmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersfugmann/subscriptions","organizations_url":"https://api.github.com/users/andersfugmann/orgs","repos_url":"https://api.github.com/users/andersfugmann/repos","events_url":"https://api.github.com/users/andersfugmann/events{/privacy}","received_events_url":"https://api.github.com/users/andersfugmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andersfugmann/opam-repository","description":"Main public package repository for OPAM, the source package manager of OCaml.","fork":true,"url":"https://api.github.com/repos/andersfugmann/opam-repository","forks_url":"https://api.github.com/repos/andersfugmann/opam-repository/forks","keys_url":"https://api.github.com/repos/andersfugmann/opam-repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andersfugmann/opam-repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andersfugmann/opam-repository/teams","hooks_url":"https://api.github.com/repos/andersfugmann/opam-repository/hooks","issue_events_url":"https://api.github.com/repos/andersfugmann/opam-repository/issues/events{/number}","events_url":"https://api.github.com/repos/andersfugmann/opam-repository/events","assignees_url":"https://api.github.com/repos/andersfugmann/opam-repository/assignees{/user}","branches_url":"https://api.github.com/repos/andersfugmann/opam-repository/branches{/branch}","tags_url":"https://api.github.com/repos/andersfugmann/opam-repository/tags","blobs_url":"https://api.github.com/repos/andersfugmann/opam-repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andersfugmann/opam-repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andersfugmann/opam-repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/andersfugmann/opam-repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andersfugmann/opam-repository/statuses/{sha}","languages_url":"https://api.github.com/repos/andersfugmann/opam-repository/languages","stargazers_url":"https://api.github.com/repos/andersfugmann/opam-repository/stargazers","contributors_url":"https://api.github.com/repos/andersfugmann/opam-repository/contributors","subscribers_url":"https://api.github.com/repos/andersfugmann/opam-repository/subscribers","subscription_url":"https://api.github.com/repos/andersfugmann/opam-repository/subscription","commits_url":"https://api.github.com/repos/andersfugmann/opam-repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/andersfugmann/opam-repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/andersfugmann/opam-repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/andersfugmann/opam-repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/andersfugmann/opam-repository/contents/{+path}","compare_url":"https://api.github.com/repos/andersfugmann/opam-repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andersfugmann/opam-repository/merges","archive_url":"https://api.github.com/repos/andersfugmann/opam-repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andersfugmann/opam-repository/downloads","issues_url":"https://api.github.com/repos/andersfugmann/opam-repository/issues{/number}","pulls_url":"https://api.github.com/repos/andersfugmann/opam-repository/pulls{/number}","milestones_url":"https://api.github.com/repos/andersfugmann/opam-repository/milestones{/number}","notifications_url":"https://api.github.com/repos/andersfugmann/opam-repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andersfugmann/opam-repository/labels{/name}","releases_url":"https://api.github.com/repos/andersfugmann/opam-repository/releases{/id}","deployments_url":"https://api.github.com/repos/andersfugmann/opam-repository/deployments","created_at":"2014-04-11T08:20:57Z","updated_at":"2018-08-27T20:21:21Z","pushed_at":"2018-08-28T09:01:36Z","git_url":"git://github.com/andersfugmann/opam-repository.git","ssh_url":"git@github.com:andersfugmann/opam-repository.git","clone_url":"https://github.com/andersfugmann/opam-repository.git","svn_url":"https://github.com/andersfugmann/opam-repository","homepage":"opam.ocaml.org","size":43870,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ocaml:master","ref":"master","sha":"833396ae6dfd24c4b9b728feac3ecf2faf271b07","user":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":4508653,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA4NjUz","name":"opam-repository","full_name":"ocaml/opam-repository","owner":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/opam-repository","description":"Main public package repository for OPAM, the source package manager of OCaml.","fork":false,"url":"https://api.github.com/repos/ocaml/opam-repository","forks_url":"https://api.github.com/repos/ocaml/opam-repository/forks","keys_url":"https://api.github.com/repos/ocaml/opam-repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/opam-repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/opam-repository/teams","hooks_url":"https://api.github.com/repos/ocaml/opam-repository/hooks","issue_events_url":"https://api.github.com/repos/ocaml/opam-repository/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/opam-repository/events","assignees_url":"https://api.github.com/repos/ocaml/opam-repository/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/opam-repository/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/opam-repository/tags","blobs_url":"https://api.github.com/repos/ocaml/opam-repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/opam-repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/opam-repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/opam-repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/opam-repository/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/opam-repository/languages","stargazers_url":"https://api.github.com/repos/ocaml/opam-repository/stargazers","contributors_url":"https://api.github.com/repos/ocaml/opam-repository/contributors","subscribers_url":"https://api.github.com/repos/ocaml/opam-repository/subscribers","subscription_url":"https://api.github.com/repos/ocaml/opam-repository/subscription","commits_url":"https://api.github.com/repos/ocaml/opam-repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/opam-repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/opam-repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/opam-repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/opam-repository/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/opam-repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/opam-repository/merges","archive_url":"https://api.github.com/repos/ocaml/opam-repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/opam-repository/downloads","issues_url":"https://api.github.com/repos/ocaml/opam-repository/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/opam-repository/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/opam-repository/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/opam-repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/opam-repository/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/opam-repository/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/opam-repository/deployments","created_at":"2012-05-31T14:25:57Z","updated_at":"2018-08-27T17:19:51Z","pushed_at":"2018-08-28T09:01:38Z","git_url":"git://github.com/ocaml/opam-repository.git","ssh_url":"git@github.com:ocaml/opam-repository.git","clone_url":"https://github.com/ocaml/opam-repository.git","svn_url":"https://github.com/ocaml/opam-repository","homepage":"https://opam.ocaml.org","size":52973,"stargazers_count":249,"watchers_count":249,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":552,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":552,"open_issues":68,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/12520"},"html":{"href":"https://github.com/ocaml/opam-repository/pull/12520"},"issue":{"href":"https://api.github.com/repos/ocaml/opam-repository/issues/12520"},"comments":{"href":"https://api.github.com/repos/ocaml/opam-repository/issues/12520/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/12520/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/12520/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/opam-repository/statuses/0965123071cd04d6ef30c40feb9af32af854fa27"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andersfugmann"}}