{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/dialog/issues/356","repository_url":"https://api.github.com/repos/aurelia/dialog","labels_url":"https://api.github.com/repos/aurelia/dialog/issues/356/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/dialog/issues/356/comments","events_url":"https://api.github.com/repos/aurelia/dialog/issues/356/events","html_url":"https://github.com/aurelia/dialog/issues/356","id":347716386,"node_id":"MDU6SXNzdWUzNDc3MTYzODY=","number":356,"title":"Error when building","user":{"login":"ormasoftchile","id":1750109,"node_id":"MDQ6VXNlcjE3NTAxMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1750109?v=4","gravatar_id":"","url":"https://api.github.com/users/ormasoftchile","html_url":"https://github.com/ormasoftchile","followers_url":"https://api.github.com/users/ormasoftchile/followers","following_url":"https://api.github.com/users/ormasoftchile/following{/other_user}","gists_url":"https://api.github.com/users/ormasoftchile/gists{/gist_id}","starred_url":"https://api.github.com/users/ormasoftchile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ormasoftchile/subscriptions","organizations_url":"https://api.github.com/users/ormasoftchile/orgs","repos_url":"https://api.github.com/users/ormasoftchile/repos","events_url":"https://api.github.com/users/ormasoftchile/events{/privacy}","received_events_url":"https://api.github.com/users/ormasoftchile/received_events","type":"User","site_admin":false},"labels":[{"id":233548418,"node_id":"MDU6TGFiZWwyMzM1NDg0MTg=","url":"https://api.github.com/repos/aurelia/dialog/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"StrahilKazlachev","id":5302492,"node_id":"MDQ6VXNlcjUzMDI0OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5302492?v=4","gravatar_id":"","url":"https://api.github.com/users/StrahilKazlachev","html_url":"https://github.com/StrahilKazlachev","followers_url":"https://api.github.com/users/StrahilKazlachev/followers","following_url":"https://api.github.com/users/StrahilKazlachev/following{/other_user}","gists_url":"https://api.github.com/users/StrahilKazlachev/gists{/gist_id}","starred_url":"https://api.github.com/users/StrahilKazlachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrahilKazlachev/subscriptions","organizations_url":"https://api.github.com/users/StrahilKazlachev/orgs","repos_url":"https://api.github.com/users/StrahilKazlachev/repos","events_url":"https://api.github.com/users/StrahilKazlachev/events{/privacy}","received_events_url":"https://api.github.com/users/StrahilKazlachev/received_events","type":"User","site_admin":false},"assignees":[{"login":"StrahilKazlachev","id":5302492,"node_id":"MDQ6VXNlcjUzMDI0OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5302492?v=4","gravatar_id":"","url":"https://api.github.com/users/StrahilKazlachev","html_url":"https://github.com/StrahilKazlachev","followers_url":"https://api.github.com/users/StrahilKazlachev/followers","following_url":"https://api.github.com/users/StrahilKazlachev/following{/other_user}","gists_url":"https://api.github.com/users/StrahilKazlachev/gists{/gist_id}","starred_url":"https://api.github.com/users/StrahilKazlachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrahilKazlachev/subscriptions","organizations_url":"https://api.github.com/users/StrahilKazlachev/orgs","repos_url":"https://api.github.com/users/StrahilKazlachev/repos","events_url":"https://api.github.com/users/StrahilKazlachev/events{/privacy}","received_events_url":"https://api.github.com/users/StrahilKazlachev/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-05T17:30:34Z","updated_at":"2018-08-18T09:31:21Z","closed_at":"2018-08-18T09:31:21Z","author_association":"NONE","body":"<!--\r\nBUGS: Please use this template.\r\n\r\n**PLEASE SEE BELOW FOR STEPS ON CREATING A REPRO TO AID IN SHOWING OFF THE ERROR, THIS WILL GET YOUR ISSUE PRIORITIZED**\r\n\r\nSUPPORT REQUESTS/QUESTIONS: If you have a support request or question please\r\nsubmit them to StackOverflow using the tags aurelia and aurelia-framework\r\nhttp://stackoverflow.com/questions/tagged/aurelia\r\nor the Aurelia Gitter https://gitter.im/aurelia/discuss\r\n\r\nBlue Spire offers paid support agreements. Further information regarding paid support\r\nmay be obtained by emailing support@bluespire.com\r\n\r\nFuture support requests submitted here will be closed.\r\n\r\nThe HTML comments below are for your reference, and are not displayed\r\nwhen your issue is submitted, feel free to leave them.\r\n\r\nChoose one of the two headings, delete the other.\r\n-->\r\n**I'm submitting a bug report**\r\n\r\n* **Library Version:**\r\n1.0.0-rc.2.0.0\r\n\r\n\r\n**Please tell us about your environment:**\r\n* **Operating System:**\r\nOSX 10.13.6\r\n\r\n* **Node Version:**\r\nv9.11.1\r\n\r\n* **NPM Version:**\r\n6.0.0\r\n\r\n* **Browser:**\r\nall\r\n\r\n* **Language:**\r\nTypeScript X.X\r\n\r\n\r\n**Current behavior:**\r\n\r\nWhen cloning the master branch, and after npm i, when building, I get this error:\r\n\r\n> npm run build\r\n\r\n [3] src/dialog-composition-engine.ts(27,7): error TS2322: Type '{ animateView(): void; add(): void; insert(): void; move(): void; remove(): void; removeAt(): any...' is not assignable to type 'ViewSlot'.\r\n[3]   Types of property 'remove' are incompatible.\r\n[3]     Type '() => void' is not assignable to type '(view: View, returnToCache?: boolean | undefined, skipAnimation?: boolean | undefined) => View | ...'.\r\n[3]       Type 'void' is not assignable to type 'View | Promise<View>'.\r\n\r\nIn the Aurelia-templating.d.ts file, the ViewSlot class has the remove() method which is declared as returning a View.\r\n\r\nUsage in dialog-composition-engine declares it as void, which causes the error.\r\nIf I modify ViewSlot.remove to return void|View, the error disappears.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/aurelia/dialog/issues/comments/414045121","html_url":"https://github.com/aurelia/dialog/issues/356#issuecomment-414045121","issue_url":"https://api.github.com/repos/aurelia/dialog/issues/356","id":414045121,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDA0NTEyMQ==","user":{"login":"StrahilKazlachev","id":5302492,"node_id":"MDQ6VXNlcjUzMDI0OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5302492?v=4","gravatar_id":"","url":"https://api.github.com/users/StrahilKazlachev","html_url":"https://github.com/StrahilKazlachev","followers_url":"https://api.github.com/users/StrahilKazlachev/followers","following_url":"https://api.github.com/users/StrahilKazlachev/following{/other_user}","gists_url":"https://api.github.com/users/StrahilKazlachev/gists{/gist_id}","starred_url":"https://api.github.com/users/StrahilKazlachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrahilKazlachev/subscriptions","organizations_url":"https://api.github.com/users/StrahilKazlachev/orgs","repos_url":"https://api.github.com/users/StrahilKazlachev/repos","events_url":"https://api.github.com/users/StrahilKazlachev/events{/privacy}","received_events_url":"https://api.github.com/users/StrahilKazlachev/received_events","type":"User","site_admin":false},"created_at":"2018-08-18T09:31:21Z","updated_at":"2018-08-18T09:31:21Z","author_association":"CONTRIBUTOR","body":"The `aurelia-templating` typings got a fix, but I forgot the usage here, fixed."}}
{"actor":{"display_login":"StrahilKazlachev"}}