{"push_id":2671330297,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"75cbc781e371279f4403045be93b07fd8fe7fde5","before":"1021d1cb1214771711c61117ba0923c73a3ff431","commits":[{"sha":"b7a08269ca53323c5fe190370da281358dfee6b2","author":{"name":"Pedro Alves","email":"c495fe4dba026c81f120733ccce155c132d5c6ba@redhat.com"},"message":"gdb: Fix build on several hosts/ports\n\nCommit 00431a78b28f (\"Use thread_info and inferior pointers more\nthroughout\") missed updating some callers, like e.g.,:\n\n gdb/remote-sim.c: In member function 'virtual void gdbsim_target::mourn_inferior()':\n gdb/remote-sim.c:1198:50: error: cannot convert 'ptid_t' to 'thread_info*' for argument '1' to 'void delete_thread_silent(thread_info*)'\n   delete_thread_silent (sim_data->remote_sim_ptid);\n\n gdb/mygit/src/gdb/procfs.c: In member function ‘virtual void procfs_target::detach(inferior*, int)’:\n gdb/mygit/src/gdb/procfs.c:1931:23: error: invalid conversion from ‘int’ to ‘inferior*’ [-fpermissive]\n    detach_inferior (pid);\n\t\t\t ^\n In file included from gdb/mygit/src/gdb/procfs.c:24:0:\n gdb/mygit/src/gdb/inferior.h:476:13: note:   initializing argument 1 of ‘void detach_inferior(inferior*)’\n\n etc.\n\nThis fixes it.\n\nThe delete_thread_silent calls in both go32-nat.c and remote-sim.c are\nunnecessary because generic_mourn_inferior calls exit_inferior, which\ndeletes the inferior's threads.\n\ngdb/ChangeLog:\n2018-06-25  Pedro Alves  <palves@redhat.com>\n\n\t* windows-nat.c (windows_delete_thread): Use find_thread_ptid and\n\tpass thread_info pointer to delete_thread.\n\t(windows_nat_target::detach): Pass inferior pointer to\n\tdetach_inferior.\n\t* aix-thread.c (sync_threadlists): Pass thread_info pointer to\n\tdelete_thread.\n\t* bsd-kvm.c (bsd_kvm_target::close): Use discard_all_inferiors.\n\t* darwin-nat.c (darwin_check_new_threads): Use find_thread_ptid\n\tand pass a thread_info pointer to delete_thread.\n\t* fbsd-nat.c (fbsd_nat_target::wait): Use find_thread_ptid and\n\tpass thread_info pointer to delete_thread.\n\t* go32-nat.c (go32_nat_target::mourn_inferior): Remove\n\tdelete_thread_silent call.\n\t* procfs.c (procfs_target::detach): Pass inferior pointer to\n\tdetach_inferior.\n\t(procfs_target::wait): Pass thread_info pointer to delete_thread.\n\t* remote-sim.c (gdbsim_target::mourn_inferior): Remove\n\tdelete_thread_silent call.\n\t* windows-nat.c (windows_delete_thread): Use find_thread_ptid and\n\tpass thread_info pointer to delete_thread.\n\t(windows_nat_target::detach): Pass inferior pointer to\n\tdelete_inferior.","distinct":true,"url":"https://api.github.com/repos/wallento/binutils-gdb/commits/b7a08269ca53323c5fe190370da281358dfee6b2"},{"sha":"75cbc781e371279f4403045be93b07fd8fe7fde5","author":{"name":"Pedro Alves","email":"c495fe4dba026c81f120733ccce155c132d5c6ba@redhat.com"},"message":"gdb: For macOS, s/thread_info/struct thread_info/\n\nThe macOS build currently fails with several instances of this problem:\n\n  In file included from ../../src/gdb/darwin-nat.h:22:0,\n\t\t   from ../../src/gdb/i386-darwin-nat.c:37:\n  ../../src/gdb/gdbthread.h:376:59: error: type/value mismatch at argument 1 in template parameter list for 'template<class T, class Policy> class gdb::ref_ptr'\n     = gdb::ref_ptr<thread_info, refcounted_object_ref_policy>;\n\t\t\t\t\t\t\t     ^\n  ../../src/gdb/gdbthread.h:376:59: note:   expected a type, got 'thread_info'\n  ../../src/gdb/gdbthread.h:396:28: error: variable or field 'delete_thread' declared void\n   extern void delete_thread (thread_info *thread);\n\t\t\t      ^\n(...)\n\nThis is because there's a thread_info function in the Darwin/XNU/mach API:\n\n http://web.mit.edu/darwin/src/modules/xnu/osfmk/man/thread_info.html\n\nFix this in the same way it had been fixed in commit 7aabaf9d4ad5\n(\"Create private_thread_info hierarchy\"), by adding an explicit\n\"struct\" keyword.\n\ngdb/ChangeLog:\n2018-06-25  Pedro Alves  <palves@redhat.com>\n\n\t* gdbthread.h (thread_info_ref, delete_thread)\n\t(delete_thread_silent, first_thread_of_inferior)\n\t(any_thread_of_inferior, switch_to_thread)\n\t(enable_thread_stack_temporaries)\n\t(thread_stack_temporaries_enabled_p, push_thread_stack_temporary)\n\t(get_last_thread_stack_temporary)\n\t(value_in_thread_stack_temporaries, can_access_registers_thread):\n\tSpell out \"struct thread_info\" instead of just \"thread_info\".\n\t* inferior.h (notice_new_inferior): Likewise.","distinct":true,"url":"https://api.github.com/repos/wallento/binutils-gdb/commits/75cbc781e371279f4403045be93b07fd8fe7fde5"}]}
{"actor":{"display_login":"wallento"}}