{"action":"created","issue":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/9132","repository_url":"https://api.github.com/repos/ArduPilot/ardupilot","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/9132/labels{/name}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/9132/comments","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/9132/events","html_url":"https://github.com/ArduPilot/ardupilot/pull/9132","id":348117176,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTQ0MDU4","number":9132,"title":"AC_PrecLand: Add LANDING_TARGET_TYPE and LANDING_TARGET.type support","user":{"login":"fnoop","id":8210968,"node_id":"MDQ6VXNlcjgyMTA5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/8210968?v=4","gravatar_id":"","url":"https://api.github.com/users/fnoop","html_url":"https://github.com/fnoop","followers_url":"https://api.github.com/users/fnoop/followers","following_url":"https://api.github.com/users/fnoop/following{/other_user}","gists_url":"https://api.github.com/users/fnoop/gists{/gist_id}","starred_url":"https://api.github.com/users/fnoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnoop/subscriptions","organizations_url":"https://api.github.com/users/fnoop/orgs","repos_url":"https://api.github.com/users/fnoop/repos","events_url":"https://api.github.com/users/fnoop/events{/privacy}","received_events_url":"https://api.github.com/users/fnoop/received_events","type":"User","site_admin":false},"labels":[{"id":136051782,"node_id":"MDU6TGFiZWwxMzYwNTE3ODI=","url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/Library","name":"Library","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-06T23:41:22Z","updated_at":"2018-08-08T01:42:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/9132","html_url":"https://github.com/ArduPilot/ardupilot/pull/9132","diff_url":"https://github.com/ArduPilot/ardupilot/pull/9132.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/9132.patch"},"body":"Add preliminary support for LANDING_TARGET.type field.  This type field represents the target type, defined in LANDING_TARGET_TYPE:\r\n```\r\nField Name | Description\r\n-- | --\r\n0 | LANDING_TARGET_TYPE_LIGHT_BEACON | Landing target signaled by light beacon (ex: IR-LOCK)\r\n1 | LANDING_TARGET_TYPE_RADIO_BEACON | Landing target signaled by radio beacon (ex: ILS, NDB)\r\n2 | LANDING_TARGET_TYPE_VISION_FIDUCIAL | Landing target represented by a fiducial marker (ex: ARTag)\r\n3 | LANDING_TARGET_TYPE_VISION_OTHER | Landing target represented by a pre-defined visual shape/feature (ex: X-marker, H-marker, square)\r\n```\r\nThis PR doesn't do anything yet, other than add target_type to AC_PrecLand, AC_PrecLand_Backend, and to return 0 (Light Beacon) for IRLock backend, and take the value from Mavlink LANDING_TARGET.type field for Companion backend."},"comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments/411256242","html_url":"https://github.com/ArduPilot/ardupilot/pull/9132#issuecomment-411256242","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/9132","id":411256242,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTI1NjI0Mg==","user":{"login":"rmackay9","id":1498098,"node_id":"MDQ6VXNlcjE0OTgwOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1498098?v=4","gravatar_id":"","url":"https://api.github.com/users/rmackay9","html_url":"https://github.com/rmackay9","followers_url":"https://api.github.com/users/rmackay9/followers","following_url":"https://api.github.com/users/rmackay9/following{/other_user}","gists_url":"https://api.github.com/users/rmackay9/gists{/gist_id}","starred_url":"https://api.github.com/users/rmackay9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmackay9/subscriptions","organizations_url":"https://api.github.com/users/rmackay9/orgs","repos_url":"https://api.github.com/users/rmackay9/repos","events_url":"https://api.github.com/users/rmackay9/events{/privacy}","received_events_url":"https://api.github.com/users/rmackay9/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T01:42:38Z","updated_at":"2018-08-08T01:42:38Z","author_association":"CONTRIBUTOR","body":".. but for the companion computer case, I guess the CC will be sending in these landing-target messages to ArduPilot so we could just store the values coming in from the CC to a local variable, no need to have a parameter.  TBH, I'm not really sure why the GCS would care about what type of sensor is used for the precision landing but getting it right in the message to the GCS can't be bad.  Adding another parameter for it though doesn't seem super useful to me though.."}}
{"actor":{"display_login":"rmackay9"}}