{"action":"created","comment":{"url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments/205946068","pull_request_review_id":141319788,"id":205946068,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk0NjA2OA==","diff_hunk":"@@ -1,116 +1,60 @@\n-\"\"\"\n-This module handles all the operations regarding locating all the\n-available access points\n-\"\"\"\n-\n-from __future__ import division\n-import threading\n-import time\n-import logging\n+\"\"\"his module handles all access point the operations.\"\"\"\n+\n+from __future__ import (absolute_import, division, print_function)\n+from threading import Thread\n+from time import (strftime, sleep)\n+from logging import getLogger\n import scapy.layers.dot11 as dot11\n-import wifiphisher.common.constants as constants\n+from wifiphisher.common.constants import (NON_CLIENT_ADDRESSES,\n+                                          ALL_2G_CHANNELS, LOCS_DIR)","path":"wifiphisher/common/recon.py","position":19,"original_position":19,"commit_id":"c23ce753c30a295e8df02ea9fd337c453ff07c70","original_commit_id":"c23ce753c30a295e8df02ea9fd337c453ff07c70","user":{"login":"sophron","id":554314,"node_id":"MDQ6VXNlcjU1NDMxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/554314?v=4","gravatar_id":"","url":"https://api.github.com/users/sophron","html_url":"https://github.com/sophron","followers_url":"https://api.github.com/users/sophron/followers","following_url":"https://api.github.com/users/sophron/following{/other_user}","gists_url":"https://api.github.com/users/sophron/gists{/gist_id}","starred_url":"https://api.github.com/users/sophron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophron/subscriptions","organizations_url":"https://api.github.com/users/sophron/orgs","repos_url":"https://api.github.com/users/sophron/repos","events_url":"https://api.github.com/users/sophron/events{/privacy}","received_events_url":"https://api.github.com/users/sophron/received_events","type":"User","site_admin":false},"body":"I remember agreeing a year (or two) back that we should import constants as constants. Something changed?","created_at":"2018-07-28T15:32:06Z","updated_at":"2018-07-28T15:33:12Z","html_url":"https://github.com/wifiphisher/wifiphisher/pull/976#discussion_r205946068","pull_request_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/976","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments/205946068"},"html":{"href":"https://github.com/wifiphisher/wifiphisher/pull/976#discussion_r205946068"},"pull_request":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/976"}}},"pull_request":{"url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/976","id":202361970,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzYxOTcw","html_url":"https://github.com/wifiphisher/wifiphisher/pull/976","diff_url":"https://github.com/wifiphisher/wifiphisher/pull/976.diff","patch_url":"https://github.com/wifiphisher/wifiphisher/pull/976.patch","issue_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/976","number":976,"state":"open","locked":false,"title":"refactor: recon module","user":{"login":"blackHatMonkey","id":25112506,"node_id":"MDQ6VXNlcjI1MTEyNTA2","avatar_url":"https://avatars2.githubusercontent.com/u/25112506?v=4","gravatar_id":"","url":"https://api.github.com/users/blackHatMonkey","html_url":"https://github.com/blackHatMonkey","followers_url":"https://api.github.com/users/blackHatMonkey/followers","following_url":"https://api.github.com/users/blackHatMonkey/following{/other_user}","gists_url":"https://api.github.com/users/blackHatMonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/blackHatMonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackHatMonkey/subscriptions","organizations_url":"https://api.github.com/users/blackHatMonkey/orgs","repos_url":"https://api.github.com/users/blackHatMonkey/repos","events_url":"https://api.github.com/users/blackHatMonkey/events{/privacy}","received_events_url":"https://api.github.com/users/blackHatMonkey/received_events","type":"User","site_admin":false},"body":"* add function type annotations\r\n* remove extras","created_at":"2018-07-18T19:54:24Z","updated_at":"2018-07-28T15:33:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9382c29aaa02af883102b443faffd2583d1f02d8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anakin1028","id":6182530,"node_id":"MDQ6VXNlcjYxODI1MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6182530?v=4","gravatar_id":"","url":"https://api.github.com/users/anakin1028","html_url":"https://github.com/anakin1028","followers_url":"https://api.github.com/users/anakin1028/followers","following_url":"https://api.github.com/users/anakin1028/following{/other_user}","gists_url":"https://api.github.com/users/anakin1028/gists{/gist_id}","starred_url":"https://api.github.com/users/anakin1028/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anakin1028/subscriptions","organizations_url":"https://api.github.com/users/anakin1028/orgs","repos_url":"https://api.github.com/users/anakin1028/repos","events_url":"https://api.github.com/users/anakin1028/events{/privacy}","received_events_url":"https://api.github.com/users/anakin1028/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/976/commits","review_comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/976/comments","review_comment_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/976/comments","statuses_url":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/c23ce753c30a295e8df02ea9fd337c453ff07c70","head":{"label":"wifiphisher:recon_refactor","ref":"recon_refactor","sha":"c23ce753c30a295e8df02ea9fd337c453ff07c70","user":{"login":"wifiphisher","id":25661467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNDY3","avatar_url":"https://avatars0.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"repo":{"id":24499174,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQ5OTE3NA==","name":"wifiphisher","full_name":"wifiphisher/wifiphisher","owner":{"login":"wifiphisher","id":25661467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNDY3","avatar_url":"https://avatars0.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wifiphisher/wifiphisher","description":"The Rogue Access Point Framework","fork":false,"url":"https://api.github.com/repos/wifiphisher/wifiphisher","forks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/forks","keys_url":"https://api.github.com/repos/wifiphisher/wifiphisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wifiphisher/wifiphisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wifiphisher/wifiphisher/teams","hooks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/hooks","issue_events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/events{/number}","events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/events","assignees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/assignees{/user}","branches_url":"https://api.github.com/repos/wifiphisher/wifiphisher/branches{/branch}","tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/tags","blobs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/{sha}","languages_url":"https://api.github.com/repos/wifiphisher/wifiphisher/languages","stargazers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/stargazers","contributors_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contributors","subscribers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscribers","subscription_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscription","commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contents/{+path}","compare_url":"https://api.github.com/repos/wifiphisher/wifiphisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wifiphisher/wifiphisher/merges","archive_url":"https://api.github.com/repos/wifiphisher/wifiphisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wifiphisher/wifiphisher/downloads","issues_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues{/number}","pulls_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls{/number}","milestones_url":"https://api.github.com/repos/wifiphisher/wifiphisher/milestones{/number}","notifications_url":"https://api.github.com/repos/wifiphisher/wifiphisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wifiphisher/wifiphisher/labels{/name}","releases_url":"https://api.github.com/repos/wifiphisher/wifiphisher/releases{/id}","deployments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/deployments","created_at":"2014-09-26T12:47:28Z","updated_at":"2018-07-27T15:35:52Z","pushed_at":"2018-07-26T20:05:07Z","git_url":"git://github.com/wifiphisher/wifiphisher.git","ssh_url":"git@github.com:wifiphisher/wifiphisher.git","clone_url":"https://github.com/wifiphisher/wifiphisher.git","svn_url":"https://github.com/wifiphisher/wifiphisher","homepage":"https://wifiphisher.org","size":11376,"stargazers_count":6554,"watchers_count":6554,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1523,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1523,"open_issues":83,"watchers":6554,"default_branch":"master"}},"base":{"label":"wifiphisher:master","ref":"master","sha":"6a5b06233bfb1ef21061bb221b5bee83e66855d0","user":{"login":"wifiphisher","id":25661467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNDY3","avatar_url":"https://avatars0.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"repo":{"id":24499174,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQ5OTE3NA==","name":"wifiphisher","full_name":"wifiphisher/wifiphisher","owner":{"login":"wifiphisher","id":25661467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxNDY3","avatar_url":"https://avatars0.githubusercontent.com/u/25661467?v=4","gravatar_id":"","url":"https://api.github.com/users/wifiphisher","html_url":"https://github.com/wifiphisher","followers_url":"https://api.github.com/users/wifiphisher/followers","following_url":"https://api.github.com/users/wifiphisher/following{/other_user}","gists_url":"https://api.github.com/users/wifiphisher/gists{/gist_id}","starred_url":"https://api.github.com/users/wifiphisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wifiphisher/subscriptions","organizations_url":"https://api.github.com/users/wifiphisher/orgs","repos_url":"https://api.github.com/users/wifiphisher/repos","events_url":"https://api.github.com/users/wifiphisher/events{/privacy}","received_events_url":"https://api.github.com/users/wifiphisher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wifiphisher/wifiphisher","description":"The Rogue Access Point Framework","fork":false,"url":"https://api.github.com/repos/wifiphisher/wifiphisher","forks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/forks","keys_url":"https://api.github.com/repos/wifiphisher/wifiphisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wifiphisher/wifiphisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wifiphisher/wifiphisher/teams","hooks_url":"https://api.github.com/repos/wifiphisher/wifiphisher/hooks","issue_events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/events{/number}","events_url":"https://api.github.com/repos/wifiphisher/wifiphisher/events","assignees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/assignees{/user}","branches_url":"https://api.github.com/repos/wifiphisher/wifiphisher/branches{/branch}","tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/tags","blobs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/{sha}","languages_url":"https://api.github.com/repos/wifiphisher/wifiphisher/languages","stargazers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/stargazers","contributors_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contributors","subscribers_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscribers","subscription_url":"https://api.github.com/repos/wifiphisher/wifiphisher/subscription","commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/wifiphisher/wifiphisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/wifiphisher/wifiphisher/contents/{+path}","compare_url":"https://api.github.com/repos/wifiphisher/wifiphisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wifiphisher/wifiphisher/merges","archive_url":"https://api.github.com/repos/wifiphisher/wifiphisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wifiphisher/wifiphisher/downloads","issues_url":"https://api.github.com/repos/wifiphisher/wifiphisher/issues{/number}","pulls_url":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls{/number}","milestones_url":"https://api.github.com/repos/wifiphisher/wifiphisher/milestones{/number}","notifications_url":"https://api.github.com/repos/wifiphisher/wifiphisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wifiphisher/wifiphisher/labels{/name}","releases_url":"https://api.github.com/repos/wifiphisher/wifiphisher/releases{/id}","deployments_url":"https://api.github.com/repos/wifiphisher/wifiphisher/deployments","created_at":"2014-09-26T12:47:28Z","updated_at":"2018-07-27T15:35:52Z","pushed_at":"2018-07-26T20:05:07Z","git_url":"git://github.com/wifiphisher/wifiphisher.git","ssh_url":"git@github.com:wifiphisher/wifiphisher.git","clone_url":"https://github.com/wifiphisher/wifiphisher.git","svn_url":"https://github.com/wifiphisher/wifiphisher","homepage":"https://wifiphisher.org","size":11376,"stargazers_count":6554,"watchers_count":6554,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1523,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1523,"open_issues":83,"watchers":6554,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/976"},"html":{"href":"https://github.com/wifiphisher/wifiphisher/pull/976"},"issue":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/976"},"comments":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/issues/976/comments"},"review_comments":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/976/comments"},"review_comment":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/pulls/976/commits"},"statuses":{"href":"https://api.github.com/repos/wifiphisher/wifiphisher/statuses/c23ce753c30a295e8df02ea9fd337c453ff07c70"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sophron"}}