{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/7803","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/7803/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/7803/comments","events_url":"https://api.github.com/repos/istio/istio/issues/7803/events","html_url":"https://github.com/istio/istio/pull/7803","id":349455978,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTY3MDI2","number":7803,"title":"Add namespace to serviceCluster parameter used by Envoy as the servic…","user":{"login":"objectiser","id":164562,"node_id":"MDQ6VXNlcjE2NDU2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-10T10:12:09Z","updated_at":"2018-08-15T13:16:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/7803","html_url":"https://github.com/istio/istio/pull/7803","diff_url":"https://github.com/istio/istio/pull/7803.diff","patch_url":"https://github.com/istio/istio/pull/7803.patch"},"body":"…e name for span data\r\n\r\nCurrently span data reported by the istio proxy/envoy uses the \"app\" value as the service name.\r\n\r\nThe problem is that it is possible the same \"app\" name could be used in multiple namespaces, and therefore it is not clear which app is actually reporting the data.\r\n\r\nOne solution would be to report the namespace as a tag on the span data, to enable it to be distinguished. However the benefit of including the namespace as part of the service name is that it is clear that the apps are different - for example on a dependency graph.\r\n\r\nThe following images show how the service name (using \"app:namespace\" format) looks in the jaeger trace view and dependency graph (bookinfo deployed in `test` namespace):\r\n\r\n![istio-jaeger-namespace-test-trace](https://user-images.githubusercontent.com/164562/43952431-dc2e5a04-9c8d-11e8-9774-1e556ca624f3.png)\r\n![istio-jaeger-namespace-test-dag](https://user-images.githubusercontent.com/164562/43952445-e12887a0-9c8d-11e8-9147-c09b0075a7cf.png)\r\n"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/413194183","html_url":"https://github.com/istio/istio/pull/7803#issuecomment-413194183","issue_url":"https://api.github.com/repos/istio/istio/issues/7803","id":413194183,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzE5NDE4Mw==","user":{"login":"objectiser","id":164562,"node_id":"MDQ6VXNlcjE2NDU2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T13:16:49Z","updated_at":"2018-08-15T13:16:49Z","author_association":"CONTRIBUTOR","body":"/test e2e-simple\r\n"}}
{"actor":{"display_login":"objectiser"}}