{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/application-services/issues/99","repository_url":"https://api.github.com/repos/mozilla/application-services","labels_url":"https://api.github.com/repos/mozilla/application-services/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/application-services/issues/99/comments","events_url":"https://api.github.com/repos/mozilla/application-services/issues/99/events","html_url":"https://github.com/mozilla/application-services/pull/99","id":339633568,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMjQwMjQx","number":99,"title":"Protect FirefoxAccount with a mutex in the FFI","user":{"login":"thomcc","id":860665,"node_id":"MDQ6VXNlcjg2MDY2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/860665?v=4","gravatar_id":"","url":"https://api.github.com/users/thomcc","html_url":"https://github.com/thomcc","followers_url":"https://api.github.com/users/thomcc/followers","following_url":"https://api.github.com/users/thomcc/following{/other_user}","gists_url":"https://api.github.com/users/thomcc/gists{/gist_id}","starred_url":"https://api.github.com/users/thomcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomcc/subscriptions","organizations_url":"https://api.github.com/users/thomcc/orgs","repos_url":"https://api.github.com/users/thomcc/repos","events_url":"https://api.github.com/users/thomcc/events{/privacy}","received_events_url":"https://api.github.com/users/thomcc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-09T22:49:53Z","updated_at":"2018-07-10T18:23:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mozilla/application-services/pulls/99","html_url":"https://github.com/mozilla/application-services/pull/99","diff_url":"https://github.com/mozilla/application-services/pull/99.diff","patch_url":"https://github.com/mozilla/application-services/pull/99.patch"},"body":"Something like this would be enough to make me not worried about the persist patch, provided it follows the same pattern.\r\n\r\nThis is actually still subpar since it's not completely clear it's actually safe to share cjose types across threads (they don't implement Send, which means Mutex<T> is not Sync), but since that will be fixed by #95, it's probably not worth worrying about before then.\r\n\r\nIf #95 lands first it would be a good idea to add a test that just ensures that ExternFxAccount is Sync, though."},"comment":{"url":"https://api.github.com/repos/mozilla/application-services/issues/comments/403920189","html_url":"https://github.com/mozilla/application-services/pull/99#issuecomment-403920189","issue_url":"https://api.github.com/repos/mozilla/application-services/issues/99","id":403920189,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzkyMDE4OQ==","user":{"login":"thomcc","id":860665,"node_id":"MDQ6VXNlcjg2MDY2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/860665?v=4","gravatar_id":"","url":"https://api.github.com/users/thomcc","html_url":"https://github.com/thomcc","followers_url":"https://api.github.com/users/thomcc/followers","following_url":"https://api.github.com/users/thomcc/following{/other_user}","gists_url":"https://api.github.com/users/thomcc/gists{/gist_id}","starred_url":"https://api.github.com/users/thomcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomcc/subscriptions","organizations_url":"https://api.github.com/users/thomcc/orgs","repos_url":"https://api.github.com/users/thomcc/repos","events_url":"https://api.github.com/users/thomcc/events{/privacy}","received_events_url":"https://api.github.com/users/thomcc/received_events","type":"User","site_admin":false},"created_at":"2018-07-10T18:23:32Z","updated_at":"2018-07-10T18:23:32Z","author_association":"CONTRIBUTOR","body":"Ah shit, this doesn't synchronize access to the destructor which is absolutely a potential source of problems..."}}
{"actor":{"display_login":"thomcc"}}