{"action":"created","comment":{"url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/comments/211758410","pull_request_review_id":148248357,"id":211758410,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTc1ODQxMA==","diff_hunk":"@@ -44,8 +44,11 @@ class ThemeStateProvider extends React.Component<ThemeStateProps> {\n   }\n }\n \n-class ThemeStateManager extends React.Component<ThemeStateProps & { context: ThemeStateValue }, ThemeStateValue> {\n-  static getDerivedStateFromProps(props, state) {\n+class ThemeStateManager extends React.Component<\n+  ThemeStateProps & { context: ThemeStateValue | null },\n+  ThemeStateValue\n+> {\n+  static getDerivedStateFromProps(props: ThemeStateProps & { context: ThemeStateValue }, state: ThemeStateValue) {","path":"src/client/src/rt-theme/ThemeState.tsx","position":36,"original_position":36,"commit_id":"dd7f08884551285ebf5c2f92887d0eb81144ef15","original_commit_id":"dd7f08884551285ebf5c2f92887d0eb81144ef15","user":{"login":"keshaldesai","id":32776407,"node_id":"MDQ6VXNlcjMyNzc2NDA3","avatar_url":"https://avatars1.githubusercontent.com/u/32776407?v=4","gravatar_id":"","url":"https://api.github.com/users/keshaldesai","html_url":"https://github.com/keshaldesai","followers_url":"https://api.github.com/users/keshaldesai/followers","following_url":"https://api.github.com/users/keshaldesai/following{/other_user}","gists_url":"https://api.github.com/users/keshaldesai/gists{/gist_id}","starred_url":"https://api.github.com/users/keshaldesai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keshaldesai/subscriptions","organizations_url":"https://api.github.com/users/keshaldesai/orgs","repos_url":"https://api.github.com/users/keshaldesai/repos","events_url":"https://api.github.com/users/keshaldesai/events{/privacy}","received_events_url":"https://api.github.com/users/keshaldesai/received_events","type":"User","site_admin":false},"body":"Use the same interface here as well","created_at":"2018-08-21T21:00:17Z","updated_at":"2018-08-21T21:14:23Z","html_url":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud/pull/801#discussion_r211758410","pull_request_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/801","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/comments/211758410"},"html":{"href":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud/pull/801#discussion_r211758410"},"pull_request":{"href":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/801"}}},"pull_request":{"url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/801","id":209872292,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODcyMjky","html_url":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud/pull/801","diff_url":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud/pull/801.diff","patch_url":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud/pull/801.patch","issue_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/issues/801","number":801,"state":"open","locked":false,"title":"no any typing for all app","user":{"login":"bhavesh-desai-scratch","id":15194540,"node_id":"MDQ6VXNlcjE1MTk0NTQw","avatar_url":"https://avatars3.githubusercontent.com/u/15194540?v=4","gravatar_id":"","url":"https://api.github.com/users/bhavesh-desai-scratch","html_url":"https://github.com/bhavesh-desai-scratch","followers_url":"https://api.github.com/users/bhavesh-desai-scratch/followers","following_url":"https://api.github.com/users/bhavesh-desai-scratch/following{/other_user}","gists_url":"https://api.github.com/users/bhavesh-desai-scratch/gists{/gist_id}","starred_url":"https://api.github.com/users/bhavesh-desai-scratch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhavesh-desai-scratch/subscriptions","organizations_url":"https://api.github.com/users/bhavesh-desai-scratch/orgs","repos_url":"https://api.github.com/users/bhavesh-desai-scratch/repos","events_url":"https://api.github.com/users/bhavesh-desai-scratch/events{/privacy}","received_events_url":"https://api.github.com/users/bhavesh-desai-scratch/received_events","type":"User","site_admin":false},"body":"Theming now typed apart from tools.ts @evanrs I will leave typing that lovely file to you :)\r\n\r\nAnalytics needs some love and care. Will get the grads to type it.","created_at":"2018-08-21T15:45:54Z","updated_at":"2018-08-21T21:14:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4723853b988be3cdff1f0a4ecbbf39635c9368e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/801/commits","review_comments_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/801/comments","review_comment_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/issues/801/comments","statuses_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/statuses/dd7f08884551285ebf5c2f92887d0eb81144ef15","head":{"label":"AdaptiveConsulting:chore/no-implicit-any","ref":"chore/no-implicit-any","sha":"dd7f08884551285ebf5c2f92887d0eb81144ef15","user":{"login":"AdaptiveConsulting","id":3510823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTA4MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/3510823?v=4","gravatar_id":"","url":"https://api.github.com/users/AdaptiveConsulting","html_url":"https://github.com/AdaptiveConsulting","followers_url":"https://api.github.com/users/AdaptiveConsulting/followers","following_url":"https://api.github.com/users/AdaptiveConsulting/following{/other_user}","gists_url":"https://api.github.com/users/AdaptiveConsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/AdaptiveConsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdaptiveConsulting/subscriptions","organizations_url":"https://api.github.com/users/AdaptiveConsulting/orgs","repos_url":"https://api.github.com/users/AdaptiveConsulting/repos","events_url":"https://api.github.com/users/AdaptiveConsulting/events{/privacy}","received_events_url":"https://api.github.com/users/AdaptiveConsulting/received_events","type":"Organization","site_admin":false},"repo":{"id":46142401,"node_id":"MDEwOlJlcG9zaXRvcnk0NjE0MjQwMQ==","name":"ReactiveTraderCloud","full_name":"AdaptiveConsulting/ReactiveTraderCloud","owner":{"login":"AdaptiveConsulting","id":3510823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTA4MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/3510823?v=4","gravatar_id":"","url":"https://api.github.com/users/AdaptiveConsulting","html_url":"https://github.com/AdaptiveConsulting","followers_url":"https://api.github.com/users/AdaptiveConsulting/followers","following_url":"https://api.github.com/users/AdaptiveConsulting/following{/other_user}","gists_url":"https://api.github.com/users/AdaptiveConsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/AdaptiveConsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdaptiveConsulting/subscriptions","organizations_url":"https://api.github.com/users/AdaptiveConsulting/orgs","repos_url":"https://api.github.com/users/AdaptiveConsulting/repos","events_url":"https://api.github.com/users/AdaptiveConsulting/events{/privacy}","received_events_url":"https://api.github.com/users/AdaptiveConsulting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud","description":"Real-time trading platform demo showcasing reactive programming principles applied across the full application stack.","fork":false,"url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud","forks_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/forks","keys_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/teams","hooks_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/hooks","issue_events_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/issues/events{/number}","events_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/events","assignees_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/assignees{/user}","branches_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/branches{/branch}","tags_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/tags","blobs_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/statuses/{sha}","languages_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/languages","stargazers_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/stargazers","contributors_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/contributors","subscribers_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/subscribers","subscription_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/subscription","commits_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/contents/{+path}","compare_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/merges","archive_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/downloads","issues_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/issues{/number}","pulls_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls{/number}","milestones_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/milestones{/number}","notifications_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/labels{/name}","releases_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/releases{/id}","deployments_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/deployments","created_at":"2015-11-13T19:24:11Z","updated_at":"2018-08-21T07:17:18Z","pushed_at":"2018-08-21T20:21:31Z","git_url":"git://github.com/AdaptiveConsulting/ReactiveTraderCloud.git","ssh_url":"git@github.com:AdaptiveConsulting/ReactiveTraderCloud.git","clone_url":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud.git","svn_url":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud","homepage":"","size":17216,"stargazers_count":952,"watchers_count":952,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":277,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":277,"open_issues":34,"watchers":952,"default_branch":"master"}},"base":{"label":"AdaptiveConsulting:story/theming","ref":"story/theming","sha":"eb2a4d145088a9442b3011266eb84f1345dab019","user":{"login":"AdaptiveConsulting","id":3510823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTA4MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/3510823?v=4","gravatar_id":"","url":"https://api.github.com/users/AdaptiveConsulting","html_url":"https://github.com/AdaptiveConsulting","followers_url":"https://api.github.com/users/AdaptiveConsulting/followers","following_url":"https://api.github.com/users/AdaptiveConsulting/following{/other_user}","gists_url":"https://api.github.com/users/AdaptiveConsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/AdaptiveConsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdaptiveConsulting/subscriptions","organizations_url":"https://api.github.com/users/AdaptiveConsulting/orgs","repos_url":"https://api.github.com/users/AdaptiveConsulting/repos","events_url":"https://api.github.com/users/AdaptiveConsulting/events{/privacy}","received_events_url":"https://api.github.com/users/AdaptiveConsulting/received_events","type":"Organization","site_admin":false},"repo":{"id":46142401,"node_id":"MDEwOlJlcG9zaXRvcnk0NjE0MjQwMQ==","name":"ReactiveTraderCloud","full_name":"AdaptiveConsulting/ReactiveTraderCloud","owner":{"login":"AdaptiveConsulting","id":3510823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTA4MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/3510823?v=4","gravatar_id":"","url":"https://api.github.com/users/AdaptiveConsulting","html_url":"https://github.com/AdaptiveConsulting","followers_url":"https://api.github.com/users/AdaptiveConsulting/followers","following_url":"https://api.github.com/users/AdaptiveConsulting/following{/other_user}","gists_url":"https://api.github.com/users/AdaptiveConsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/AdaptiveConsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdaptiveConsulting/subscriptions","organizations_url":"https://api.github.com/users/AdaptiveConsulting/orgs","repos_url":"https://api.github.com/users/AdaptiveConsulting/repos","events_url":"https://api.github.com/users/AdaptiveConsulting/events{/privacy}","received_events_url":"https://api.github.com/users/AdaptiveConsulting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud","description":"Real-time trading platform demo showcasing reactive programming principles applied across the full application stack.","fork":false,"url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud","forks_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/forks","keys_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/teams","hooks_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/hooks","issue_events_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/issues/events{/number}","events_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/events","assignees_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/assignees{/user}","branches_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/branches{/branch}","tags_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/tags","blobs_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/statuses/{sha}","languages_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/languages","stargazers_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/stargazers","contributors_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/contributors","subscribers_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/subscribers","subscription_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/subscription","commits_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/contents/{+path}","compare_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/merges","archive_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/downloads","issues_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/issues{/number}","pulls_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls{/number}","milestones_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/milestones{/number}","notifications_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/labels{/name}","releases_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/releases{/id}","deployments_url":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/deployments","created_at":"2015-11-13T19:24:11Z","updated_at":"2018-08-21T07:17:18Z","pushed_at":"2018-08-21T20:21:31Z","git_url":"git://github.com/AdaptiveConsulting/ReactiveTraderCloud.git","ssh_url":"git@github.com:AdaptiveConsulting/ReactiveTraderCloud.git","clone_url":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud.git","svn_url":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud","homepage":"","size":17216,"stargazers_count":952,"watchers_count":952,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":277,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":277,"open_issues":34,"watchers":952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/801"},"html":{"href":"https://github.com/AdaptiveConsulting/ReactiveTraderCloud/pull/801"},"issue":{"href":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/issues/801"},"comments":{"href":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/issues/801/comments"},"review_comments":{"href":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/801/comments"},"review_comment":{"href":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/pulls/801/commits"},"statuses":{"href":"https://api.github.com/repos/AdaptiveConsulting/ReactiveTraderCloud/statuses/dd7f08884551285ebf5c2f92887d0eb81144ef15"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"keshaldesai"}}