{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/201936848","pull_request_review_id":136529020,"id":201936848,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTkzNjg0OA==","diff_hunk":"@@ -4370,7 +4405,7 @@ int mbedtls_ssl_parse_certificate( mbedtls_ssl_context *ssl )\n     int ret = MBEDTLS_ERR_SSL_FEATURE_UNAVAILABLE;\n     size_t i, n;\n     const mbedtls_ssl_ciphersuite_t *ciphersuite_info = ssl->transform_negotiate->ciphersuite_info;\n-    int authmode = ssl->conf->authmode;\n+    int authmode;","path":"library/ssl_tls.c","position":69,"original_position":69,"commit_id":"ed99ad3e7096413a63eb74b148df9b8a297c8505","original_commit_id":"ed99ad3e7096413a63eb74b148df9b8a297c8505","user":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"body":"return assignment, and use `authmode` in checks","created_at":"2018-07-12T07:40:58Z","updated_at":"2018-07-12T07:55:23Z","html_url":"https://github.com/ARMmbed/mbedtls/pull/1813#discussion_r201936848","pull_request_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1813","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/201936848"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1813#discussion_r201936848"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1813"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1813","id":197998636,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTk4NjM2","html_url":"https://github.com/ARMmbed/mbedtls/pull/1813","diff_url":"https://github.com/ARMmbed/mbedtls/pull/1813.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/1813.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1813","number":1813,"state":"open","locked":false,"title":"Dtls srtp support","user":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR supersedes PR #361 by @jeannotlapin, with additional mki support, some rework, and rebased on current development branch\r\nSupersedes #1540 \r\n\r\n**Open question:**\r\nHow will the server decide whether to accept the MKI value from the client, in the `use_srtp` extension?  Should there be a callback function? Should the server user set the MKI in advance and the server send it if it matches? Should the server just accept the MKI from the client and use it as its MKI ( basically making `mbedtls_ssl_dtls_srtp_set_mki_value()` a client only function)?\r\n\r\n## Status\r\n**IN DEVELOPMENT**\r\n\r\n## Requires Backporting\r\nNO  \r\n\r\n\r\n## Additional comments\r\nMissing still:\r\n~~tests~~\r\n~~interop tests~~\r\n\r\n## Todos\r\n- [x] Tests\r\n- [ ] Documentation\r\n- [x] Changelog updated\r\n- [ ] Backported\r\n\r\n\r\n## Steps to test or reproduce\r\nrun `ssl-opt.sh -f SRTP`\r\n","created_at":"2018-06-28T11:26:07Z","updated_at":"2018-07-12T07:55:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3e7b6ed5c0572bbe37a1b6c50b240b06dd714c0","assignee":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"assignees":[{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":278176777,"node_id":"MDU6TGFiZWwyNzgxNzY3Nzc=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/CLA%20valid","name":"CLA valid","color":"bfdadc","default":false},{"id":19280386,"node_id":"MDU6TGFiZWwxOTI4MDM4Ng==","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":408190313,"node_id":"MDU6TGFiZWw0MDgxOTAzMTM=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/mbed%20TLS%20team","name":"mbed TLS team","color":"66e0ff","default":false},{"id":685773676,"node_id":"MDU6TGFiZWw2ODU3NzM2NzY=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs%20design%20approval","name":"needs design approval","color":"5319e7","default":false},{"id":435765575,"node_id":"MDU6TGFiZWw0MzU3NjU1NzU=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs%20work","name":"needs work","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1813/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1813/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1813/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/ed99ad3e7096413a63eb74b148df9b8a297c8505","head":{"label":"RonEld:dtls_srtp_support","ref":"dtls_srtp_support","sha":"ed99ad3e7096413a63eb74b148df9b8a297c8505","user":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"repo":{"id":76245223,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI0NTIyMw==","name":"mbedtls","full_name":"RonEld/mbedtls","owner":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RonEld/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":true,"url":"https://api.github.com/repos/RonEld/mbedtls","forks_url":"https://api.github.com/repos/RonEld/mbedtls/forks","keys_url":"https://api.github.com/repos/RonEld/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RonEld/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RonEld/mbedtls/teams","hooks_url":"https://api.github.com/repos/RonEld/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/RonEld/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/RonEld/mbedtls/events","assignees_url":"https://api.github.com/repos/RonEld/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/RonEld/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/RonEld/mbedtls/tags","blobs_url":"https://api.github.com/repos/RonEld/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RonEld/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RonEld/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/RonEld/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RonEld/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/RonEld/mbedtls/languages","stargazers_url":"https://api.github.com/repos/RonEld/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/RonEld/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/RonEld/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/RonEld/mbedtls/subscription","commits_url":"https://api.github.com/repos/RonEld/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/RonEld/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/RonEld/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/RonEld/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/RonEld/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/RonEld/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RonEld/mbedtls/merges","archive_url":"https://api.github.com/repos/RonEld/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RonEld/mbedtls/downloads","issues_url":"https://api.github.com/repos/RonEld/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/RonEld/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/RonEld/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/RonEld/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RonEld/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/RonEld/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/RonEld/mbedtls/deployments","created_at":"2016-12-12T10:14:13Z","updated_at":"2018-07-12T07:45:33Z","pushed_at":"2018-07-12T07:45:53Z","git_url":"git://github.com/RonEld/mbedtls.git","ssh_url":"git@github.com:RonEld/mbedtls.git","clone_url":"https://github.com/RonEld/mbedtls.git","svn_url":"https://github.com/RonEld/mbedtls","homepage":"https://tls.mbed.org","size":28799,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ARMmbed:development","ref":"development","sha":"6665b67ddf56069550363ebe3203b03a5c5fb8c7","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":6687936,"node_id":"MDEwOlJlcG9zaXRvcnk2Njg3OTM2","name":"mbedtls","full_name":"ARMmbed/mbedtls","owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbedtls","forks_url":"https://api.github.com/repos/ARMmbed/mbedtls/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbedtls/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbedtls/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbedtls/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbedtls/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbedtls/deployments","created_at":"2012-11-14T13:13:13Z","updated_at":"2018-07-12T02:29:02Z","pushed_at":"2018-07-12T07:46:01Z","git_url":"git://github.com/ARMmbed/mbedtls.git","ssh_url":"git@github.com:ARMmbed/mbedtls.git","clone_url":"https://github.com/ARMmbed/mbedtls.git","svn_url":"https://github.com/ARMmbed/mbedtls","homepage":"https://tls.mbed.org","size":29061,"stargazers_count":1448,"watchers_count":1448,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":889,"mirror_url":null,"archived":false,"open_issues_count":500,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":889,"open_issues":500,"watchers":1448,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1813"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1813"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1813"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1813/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1813/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1813/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/ed99ad3e7096413a63eb74b148df9b8a297c8505"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RonEld"}}