{"action":"created","comment":{"url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/comments/187374995","pull_request_review_id":119143086,"id":187374995,"diff_hunk":"@@ -200,8 +203,41 @@ func sgCollectPaths() (sgPath, sgCollectPath string) {\n \t// Make sure sgcollect_info exists\n \t_, err = os.Stat(sgCollectPath)\n \tif err != nil {\n-\t\tbase.Warnf(base.KeyAll, \"Unable to find sgcollect_info executable\")\n+\t\tbase.Warnf(base.KeyAll, \"Unable to find sgcollect_info executable. sgcollect_info cannot be run from the admin API.\")\n \t}\n \n \treturn sgPath, sgCollectPath\n }\n+\n+// sgcollectFilename returns a Windows-safe filename for sgcollect_info zip files.\n+func sgcollectFilename() string {\n+\n+\t// get timestamp\n+\ttimestamp := time.Now().UTC().Format(\"2006-01-02t150405\")\n+\n+\t// Use a shortened product name as username.\n+\t// This may change, so the unit test for sgcollectFilename explicitly checks one of these is set.\n+\tname := \"ProductName\"","path":"rest/sgcollect.go","position":null,"original_position":35,"commit_id":"5fc3ef1a2f48d56da0fa367ec4566fa656a32811","original_commit_id":"2f88ffbd50bb84009d9ffbd7d0408545552b9634","user":{"login":"bbrks","id":1525809,"avatar_url":"https://avatars3.githubusercontent.com/u/1525809?v=4","gravatar_id":"","url":"https://api.github.com/users/bbrks","html_url":"https://github.com/bbrks","followers_url":"https://api.github.com/users/bbrks/followers","following_url":"https://api.github.com/users/bbrks/following{/other_user}","gists_url":"https://api.github.com/users/bbrks/gists{/gist_id}","starred_url":"https://api.github.com/users/bbrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbrks/subscriptions","organizations_url":"https://api.github.com/users/bbrks/orgs","repos_url":"https://api.github.com/users/bbrks/repos","events_url":"https://api.github.com/users/bbrks/events{/privacy}","received_events_url":"https://api.github.com/users/bbrks/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-05-10T15:56:59Z","updated_at":"2018-05-10T15:56:59Z","html_url":"https://github.com/couchbase/sync_gateway/pull/3550#discussion_r187374995","pull_request_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/3550","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/comments/187374995"},"html":{"href":"https://github.com/couchbase/sync_gateway/pull/3550#discussion_r187374995"},"pull_request":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/3550"}},"in_reply_to_id":187368019},"pull_request":{"url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/3550","id":187168958,"html_url":"https://github.com/couchbase/sync_gateway/pull/3550","diff_url":"https://github.com/couchbase/sync_gateway/pull/3550.diff","patch_url":"https://github.com/couchbase/sync_gateway/pull/3550.patch","issue_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/3550","number":3550,"state":"open","locked":false,"title":"#3549 Change _sgcollect_info endpoint zip filename format for Windows compatibility","user":{"login":"bbrks","id":1525809,"avatar_url":"https://avatars3.githubusercontent.com/u/1525809?v=4","gravatar_id":"","url":"https://api.github.com/users/bbrks","html_url":"https://github.com/bbrks","followers_url":"https://api.github.com/users/bbrks/followers","following_url":"https://api.github.com/users/bbrks/following{/other_user}","gists_url":"https://api.github.com/users/bbrks/gists{/gist_id}","starred_url":"https://api.github.com/users/bbrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbrks/subscriptions","organizations_url":"https://api.github.com/users/bbrks/orgs","repos_url":"https://api.github.com/users/bbrks/repos","events_url":"https://api.github.com/users/bbrks/events{/privacy}","received_events_url":"https://api.github.com/users/bbrks/received_events","type":"User","site_admin":false},"body":"Fixes #3549 \r\n\r\nChange filename output of `_sgcollect_info` endpoint for Windows compatibility. Aligns with server's cbcollect_info filename format of `sgcollectinfo-2018-05-10t133456-sg@203.0.113.123.zip`\r\n","created_at":"2018-05-10T11:32:30Z","updated_at":"2018-05-10T15:56:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e120d30a5b59e54d65ead46218a1db9f9bc4f55","assignee":{"login":"adamcfraser","id":8866453,"avatar_url":"https://avatars3.githubusercontent.com/u/8866453?v=4","gravatar_id":"","url":"https://api.github.com/users/adamcfraser","html_url":"https://github.com/adamcfraser","followers_url":"https://api.github.com/users/adamcfraser/followers","following_url":"https://api.github.com/users/adamcfraser/following{/other_user}","gists_url":"https://api.github.com/users/adamcfraser/gists{/gist_id}","starred_url":"https://api.github.com/users/adamcfraser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamcfraser/subscriptions","organizations_url":"https://api.github.com/users/adamcfraser/orgs","repos_url":"https://api.github.com/users/adamcfraser/repos","events_url":"https://api.github.com/users/adamcfraser/events{/privacy}","received_events_url":"https://api.github.com/users/adamcfraser/received_events","type":"User","site_admin":false},"assignees":[{"login":"adamcfraser","id":8866453,"avatar_url":"https://avatars3.githubusercontent.com/u/8866453?v=4","gravatar_id":"","url":"https://api.github.com/users/adamcfraser","html_url":"https://github.com/adamcfraser","followers_url":"https://api.github.com/users/adamcfraser/followers","following_url":"https://api.github.com/users/adamcfraser/following{/other_user}","gists_url":"https://api.github.com/users/adamcfraser/gists{/gist_id}","starred_url":"https://api.github.com/users/adamcfraser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamcfraser/subscriptions","organizations_url":"https://api.github.com/users/adamcfraser/orgs","repos_url":"https://api.github.com/users/adamcfraser/repos","events_url":"https://api.github.com/users/adamcfraser/events{/privacy}","received_events_url":"https://api.github.com/users/adamcfraser/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":107354377,"url":"https://api.github.com/repos/couchbase/sync_gateway/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":109316238,"url":"https://api.github.com/repos/couchbase/sync_gateway/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/3550/commits","review_comments_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/3550/comments","review_comment_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/3550/comments","statuses_url":"https://api.github.com/repos/couchbase/sync_gateway/statuses/5fc3ef1a2f48d56da0fa367ec4566fa656a32811","head":{"label":"couchbase:feature/issue_3549_change_sgcollect_info_filename_format","ref":"feature/issue_3549_change_sgcollect_info_filename_format","sha":"5fc3ef1a2f48d56da0fa367ec4566fa656a32811","user":{"login":"couchbase","id":605755,"avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"repo":{"id":6082996,"name":"sync_gateway","full_name":"couchbase/sync_gateway","owner":{"login":"couchbase","id":605755,"avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/couchbase/sync_gateway","description":"Connects Couchbase Lite to Couchbase Server","fork":false,"url":"https://api.github.com/repos/couchbase/sync_gateway","forks_url":"https://api.github.com/repos/couchbase/sync_gateway/forks","keys_url":"https://api.github.com/repos/couchbase/sync_gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/couchbase/sync_gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/couchbase/sync_gateway/teams","hooks_url":"https://api.github.com/repos/couchbase/sync_gateway/hooks","issue_events_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/events{/number}","events_url":"https://api.github.com/repos/couchbase/sync_gateway/events","assignees_url":"https://api.github.com/repos/couchbase/sync_gateway/assignees{/user}","branches_url":"https://api.github.com/repos/couchbase/sync_gateway/branches{/branch}","tags_url":"https://api.github.com/repos/couchbase/sync_gateway/tags","blobs_url":"https://api.github.com/repos/couchbase/sync_gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/couchbase/sync_gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/couchbase/sync_gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/couchbase/sync_gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/couchbase/sync_gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/couchbase/sync_gateway/languages","stargazers_url":"https://api.github.com/repos/couchbase/sync_gateway/stargazers","contributors_url":"https://api.github.com/repos/couchbase/sync_gateway/contributors","subscribers_url":"https://api.github.com/repos/couchbase/sync_gateway/subscribers","subscription_url":"https://api.github.com/repos/couchbase/sync_gateway/subscription","commits_url":"https://api.github.com/repos/couchbase/sync_gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/couchbase/sync_gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/couchbase/sync_gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/couchbase/sync_gateway/contents/{+path}","compare_url":"https://api.github.com/repos/couchbase/sync_gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/couchbase/sync_gateway/merges","archive_url":"https://api.github.com/repos/couchbase/sync_gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/couchbase/sync_gateway/downloads","issues_url":"https://api.github.com/repos/couchbase/sync_gateway/issues{/number}","pulls_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/couchbase/sync_gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/couchbase/sync_gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/couchbase/sync_gateway/labels{/name}","releases_url":"https://api.github.com/repos/couchbase/sync_gateway/releases{/id}","deployments_url":"https://api.github.com/repos/couchbase/sync_gateway/deployments","created_at":"2012-10-04T22:25:43Z","updated_at":"2018-05-10T15:17:24Z","pushed_at":"2018-05-10T15:56:50Z","git_url":"git://github.com/couchbase/sync_gateway.git","ssh_url":"git@github.com:couchbase/sync_gateway.git","clone_url":"https://github.com/couchbase/sync_gateway.git","svn_url":"https://github.com/couchbase/sync_gateway","homepage":"","size":29324,"stargazers_count":371,"watchers_count":371,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":382,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":119,"open_issues":382,"watchers":371,"default_branch":"master"}},"base":{"label":"couchbase:master","ref":"master","sha":"0a05db35fc5a6338c9de4e5af313a6da632bef35","user":{"login":"couchbase","id":605755,"avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"repo":{"id":6082996,"name":"sync_gateway","full_name":"couchbase/sync_gateway","owner":{"login":"couchbase","id":605755,"avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/couchbase/sync_gateway","description":"Connects Couchbase Lite to Couchbase Server","fork":false,"url":"https://api.github.com/repos/couchbase/sync_gateway","forks_url":"https://api.github.com/repos/couchbase/sync_gateway/forks","keys_url":"https://api.github.com/repos/couchbase/sync_gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/couchbase/sync_gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/couchbase/sync_gateway/teams","hooks_url":"https://api.github.com/repos/couchbase/sync_gateway/hooks","issue_events_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/events{/number}","events_url":"https://api.github.com/repos/couchbase/sync_gateway/events","assignees_url":"https://api.github.com/repos/couchbase/sync_gateway/assignees{/user}","branches_url":"https://api.github.com/repos/couchbase/sync_gateway/branches{/branch}","tags_url":"https://api.github.com/repos/couchbase/sync_gateway/tags","blobs_url":"https://api.github.com/repos/couchbase/sync_gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/couchbase/sync_gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/couchbase/sync_gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/couchbase/sync_gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/couchbase/sync_gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/couchbase/sync_gateway/languages","stargazers_url":"https://api.github.com/repos/couchbase/sync_gateway/stargazers","contributors_url":"https://api.github.com/repos/couchbase/sync_gateway/contributors","subscribers_url":"https://api.github.com/repos/couchbase/sync_gateway/subscribers","subscription_url":"https://api.github.com/repos/couchbase/sync_gateway/subscription","commits_url":"https://api.github.com/repos/couchbase/sync_gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/couchbase/sync_gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/couchbase/sync_gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/couchbase/sync_gateway/contents/{+path}","compare_url":"https://api.github.com/repos/couchbase/sync_gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/couchbase/sync_gateway/merges","archive_url":"https://api.github.com/repos/couchbase/sync_gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/couchbase/sync_gateway/downloads","issues_url":"https://api.github.com/repos/couchbase/sync_gateway/issues{/number}","pulls_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/couchbase/sync_gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/couchbase/sync_gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/couchbase/sync_gateway/labels{/name}","releases_url":"https://api.github.com/repos/couchbase/sync_gateway/releases{/id}","deployments_url":"https://api.github.com/repos/couchbase/sync_gateway/deployments","created_at":"2012-10-04T22:25:43Z","updated_at":"2018-05-10T15:17:24Z","pushed_at":"2018-05-10T15:56:50Z","git_url":"git://github.com/couchbase/sync_gateway.git","ssh_url":"git@github.com:couchbase/sync_gateway.git","clone_url":"https://github.com/couchbase/sync_gateway.git","svn_url":"https://github.com/couchbase/sync_gateway","homepage":"","size":29324,"stargazers_count":371,"watchers_count":371,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":382,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":119,"open_issues":382,"watchers":371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/3550"},"html":{"href":"https://github.com/couchbase/sync_gateway/pull/3550"},"issue":{"href":"https://api.github.com/repos/couchbase/sync_gateway/issues/3550"},"comments":{"href":"https://api.github.com/repos/couchbase/sync_gateway/issues/3550/comments"},"review_comments":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/3550/comments"},"review_comment":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/3550/commits"},"statuses":{"href":"https://api.github.com/repos/couchbase/sync_gateway/statuses/5fc3ef1a2f48d56da0fa367ec4566fa656a32811"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bbrks"}}