{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/27262","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/27262/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/27262/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/27262/events","html_url":"https://github.com/symfony/symfony/issues/27262","id":322871041,"number":27262,"title":"[RFC][Profiler] Enhance the performances panel & time collector","user":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars0.githubusercontent.com/u/2211145?v=4","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"labels":[{"id":83934034,"url":"https://api.github.com/repos/symfony/symfony/labels/RFC","name":"RFC","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-14T15:37:37Z","updated_at":"2018-05-14T15:46:42Z","closed_at":null,"author_association":"MEMBER","body":"**Description**\r\n<!-- A clear and concise description of the new feature. -->\r\n\r\nI feel like this panel could benefits from some improvements.\r\nSome of these are actionable right now, but there are some that could be discussed before sending PRs.\r\n\r\nFor instance:\r\n\r\n- [ ] **1.** The panel currently shows a set of categories hard-coded in the `time.html.twig` template, even if no stopwatch event for these occurred (e.g: `propel`). The `event_listener_loading` one isn't even used since 2.3:\r\n    ![capture d ecran 2018-05-14 a 17 05 21](https://user-images.githubusercontent.com/2211145/40005762-181d3a10-5799-11e8-93d7-c72c3213f285.png)\r\n    The time collector could provide the list of categories actually used during the request, so the template would only show them.\r\n\r\n- [ ] **2.** https://github.com/symfony/symfony/pull/26833 traces controller argument resolvers since 4.1. But this is not easily identifiable in the panel. We could add a category for it:\r\n   ![capture d ecran 2018-05-14 a 17 05 39](https://user-images.githubusercontent.com/2211145/40005763-18520d30-5799-11e8-971a-5c74647185a9.png)\r\n   This PR also let me think we could add some other relevant categories. For now, I've in mind two other components for which these kind of metrics would be useful:\r\n     - Serializer normalizers\r\n     - Messenger middleware\r\n\r\n- [ ] **3.** Disabling some categories by clicking on it would be useful:\r\n      ![capture d ecran 2018-05-14 a 17 09 35](https://user-images.githubusercontent.com/2211145/40006660-39f4f400-579b-11e8-8398-47fff2ff6c66.png)\r\n\r\n- [ ] **4.** Rendering the graph using a canvas has some drawbacks:\r\n     - No interactivity allowed\r\n     - No text selection allowed\r\n     - We can't use the browser search input to quickly jump to an event\r\n     - the graph has a fixed size, which sometimes leads to truncated events (when the event is a long FQCNs like the resolvers ones for instance)\r\n  \r\n  Perhaps we could switch to a SVG version to solve these limitations.\r\n\r\nDo you think these kind of improvements are worth it? Do you have some others in mind?"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/388865265","html_url":"https://github.com/symfony/symfony/issues/27262#issuecomment-388865265","issue_url":"https://api.github.com/repos/symfony/symfony/issues/27262","id":388865265,"user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars3.githubusercontent.com/u/47313?v=4","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T15:46:41Z","updated_at":"2018-05-14T15:46:41Z","author_association":"OWNER","body":"Quick note: \"propel\" can be removed permanently."}}
{"actor":{"display_login":"fabpot"}}