{"action":"opened","number":4158,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/4158","id":172141226,"html_url":"https://github.com/grpc/grpc-java/pull/4158","diff_url":"https://github.com/grpc/grpc-java/pull/4158.diff","patch_url":"https://github.com/grpc/grpc-java/pull/4158.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/4158","number":4158,"state":"open","locked":false,"title":"core: rm unnecessary InternalNameResolverProvider","user":{"login":"dapengzhang0","id":4779759,"avatar_url":"https://avatars2.githubusercontent.com/u/4779759?v=4","gravatar_id":"","url":"https://api.github.com/users/dapengzhang0","html_url":"https://github.com/dapengzhang0","followers_url":"https://api.github.com/users/dapengzhang0/followers","following_url":"https://api.github.com/users/dapengzhang0/following{/other_user}","gists_url":"https://api.github.com/users/dapengzhang0/gists{/gist_id}","starred_url":"https://api.github.com/users/dapengzhang0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dapengzhang0/subscriptions","organizations_url":"https://api.github.com/users/dapengzhang0/orgs","repos_url":"https://api.github.com/users/dapengzhang0/repos","events_url":"https://api.github.com/users/dapengzhang0/events{/privacy}","received_events_url":"https://api.github.com/users/dapengzhang0/received_events","type":"User","site_admin":false},"body":"`io.grpc.internal.DnsNameResolverProvider.class` as a class object is already being tested in `io.grpc.NameResolverProviderTest`. Keep the tests in `io.grpc.NameResolverProviderTest` instead of in `io.grpc.internal.DnsNameResolverProviderTest` so that we don't need an internal accessor.","created_at":"2018-03-01T04:35:03Z","updated_at":"2018-03-01T04:35:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4158/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4158/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/4158/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/3614f1b93aab3fe7ec52f0e3aaf8bbbbc87b4ccf","head":{"label":"dapengzhang0:rminternalnameresolverprovider","ref":"rminternalnameresolverprovider","sha":"3614f1b93aab3fe7ec52f0e3aaf8bbbbc87b4ccf","user":{"login":"dapengzhang0","id":4779759,"avatar_url":"https://avatars2.githubusercontent.com/u/4779759?v=4","gravatar_id":"","url":"https://api.github.com/users/dapengzhang0","html_url":"https://github.com/dapengzhang0","followers_url":"https://api.github.com/users/dapengzhang0/followers","following_url":"https://api.github.com/users/dapengzhang0/following{/other_user}","gists_url":"https://api.github.com/users/dapengzhang0/gists{/gist_id}","starred_url":"https://api.github.com/users/dapengzhang0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dapengzhang0/subscriptions","organizations_url":"https://api.github.com/users/dapengzhang0/orgs","repos_url":"https://api.github.com/users/dapengzhang0/repos","events_url":"https://api.github.com/users/dapengzhang0/events{/privacy}","received_events_url":"https://api.github.com/users/dapengzhang0/received_events","type":"User","site_admin":false},"repo":{"id":57351322,"name":"grpc-java","full_name":"dapengzhang0/grpc-java","owner":{"login":"dapengzhang0","id":4779759,"avatar_url":"https://avatars2.githubusercontent.com/u/4779759?v=4","gravatar_id":"","url":"https://api.github.com/users/dapengzhang0","html_url":"https://github.com/dapengzhang0","followers_url":"https://api.github.com/users/dapengzhang0/followers","following_url":"https://api.github.com/users/dapengzhang0/following{/other_user}","gists_url":"https://api.github.com/users/dapengzhang0/gists{/gist_id}","starred_url":"https://api.github.com/users/dapengzhang0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dapengzhang0/subscriptions","organizations_url":"https://api.github.com/users/dapengzhang0/orgs","repos_url":"https://api.github.com/users/dapengzhang0/repos","events_url":"https://api.github.com/users/dapengzhang0/events{/privacy}","received_events_url":"https://api.github.com/users/dapengzhang0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dapengzhang0/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/dapengzhang0/grpc-java","forks_url":"https://api.github.com/repos/dapengzhang0/grpc-java/forks","keys_url":"https://api.github.com/repos/dapengzhang0/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dapengzhang0/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dapengzhang0/grpc-java/teams","hooks_url":"https://api.github.com/repos/dapengzhang0/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/dapengzhang0/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/dapengzhang0/grpc-java/events","assignees_url":"https://api.github.com/repos/dapengzhang0/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/dapengzhang0/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/dapengzhang0/grpc-java/tags","blobs_url":"https://api.github.com/repos/dapengzhang0/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dapengzhang0/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dapengzhang0/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/dapengzhang0/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dapengzhang0/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/dapengzhang0/grpc-java/languages","stargazers_url":"https://api.github.com/repos/dapengzhang0/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/dapengzhang0/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/dapengzhang0/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/dapengzhang0/grpc-java/subscription","commits_url":"https://api.github.com/repos/dapengzhang0/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/dapengzhang0/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/dapengzhang0/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/dapengzhang0/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/dapengzhang0/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/dapengzhang0/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dapengzhang0/grpc-java/merges","archive_url":"https://api.github.com/repos/dapengzhang0/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dapengzhang0/grpc-java/downloads","issues_url":"https://api.github.com/repos/dapengzhang0/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/dapengzhang0/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/dapengzhang0/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/dapengzhang0/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dapengzhang0/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/dapengzhang0/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/dapengzhang0/grpc-java/deployments","created_at":"2016-04-29T03:18:59Z","updated_at":"2016-04-29T03:19:01Z","pushed_at":"2018-03-01T04:28:55Z","git_url":"git://github.com/dapengzhang0/grpc-java.git","ssh_url":"git@github.com:dapengzhang0/grpc-java.git","clone_url":"https://github.com/dapengzhang0/grpc-java.git","svn_url":"https://github.com/dapengzhang0/grpc-java","homepage":"http://grpc.io","size":17267,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"1e9bd9a84e05e3d0b6d2da706207aa703a318918","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2018-03-01T03:47:50Z","pushed_at":"2018-03-01T00:49:39Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"https://grpc.io","size":22130,"stargazers_count":3821,"watchers_count":3821,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1222,"mirror_url":null,"archived":false,"open_issues_count":369,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1222,"open_issues":369,"watchers":3821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4158"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4158"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4158"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4158/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4158/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4158/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/3614f1b93aab3fe7ec52f0e3aaf8bbbbc87b4ccf"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":23,"deletions":52,"changed_files":3}}
{"actor":{"display_login":"dapengzhang0"}}