{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/225041323","pull_request_review_id":164553551,"id":225041323,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTA0MTMyMw==","diff_hunk":"@@ -183,22 +183,23 @@ def event_date(hass, event, now=None):\n                 return sunrise_time\n             return sunset_time\n \n-        with patch('homeassistant.util.dt.now', return_value=test_time):\n-            with patch('homeassistant.helpers.sun.get_astral_event_date',\n-                       side_effect=event_date):\n-                assert setup_component(self.hass, switch.DOMAIN, {\n-                    switch.DOMAIN: {\n-                        'platform': 'flux',\n-                        'name': 'flux',\n-                        'lights': [dev1.entity_id]\n-                    }\n-                })\n-                turn_on_calls = mock_service(\n-                    self.hass, light.DOMAIN, SERVICE_TURN_ON)\n-                common.turn_on(self.hass, 'switch.flux')\n-                self.hass.block_till_done()\n-                fire_time_changed(self.hass, test_time)\n-                self.hass.block_till_done()\n+        with patch('homeassistant.components.switch.flux.dt_now',\n+                  return_value=test_time), \\","path":"tests/components/switch/test_flux.py","position":21,"original_position":21,"commit_id":"207031e1f4cc5d5259aa150b10bac34f3a7baa84","original_commit_id":"207031e1f4cc5d5259aa150b10bac34f3a7baa84","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"continuation line under-indented for visual indent","created_at":"2018-10-15T05:30:13Z","updated_at":"2018-10-15T05:30:13Z","html_url":"https://github.com/home-assistant/home-assistant/pull/17458#discussion_r225041323","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17458","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/225041323"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/17458#discussion_r225041323"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17458"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17458","id":222740812,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzQwODEy","html_url":"https://github.com/home-assistant/home-assistant/pull/17458","diff_url":"https://github.com/home-assistant/home-assistant/pull/17458.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/17458.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17458","number":17458,"state":"open","locked":false,"title":"Fix flux switch update interval","user":{"login":"amelchio","id":26174915,"node_id":"MDQ6VXNlcjI2MTc0OTE1","avatar_url":"https://avatars3.githubusercontent.com/u/26174915?v=4","gravatar_id":"","url":"https://api.github.com/users/amelchio","html_url":"https://github.com/amelchio","followers_url":"https://api.github.com/users/amelchio/followers","following_url":"https://api.github.com/users/amelchio/following{/other_user}","gists_url":"https://api.github.com/users/amelchio/gists{/gist_id}","starred_url":"https://api.github.com/users/amelchio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amelchio/subscriptions","organizations_url":"https://api.github.com/users/amelchio/orgs","repos_url":"https://api.github.com/users/amelchio/repos","events_url":"https://api.github.com/users/amelchio/events{/privacy}","received_events_url":"https://api.github.com/users/amelchio/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nThe previous implementation only worked as advertised for the `interval` default value of 30.\r\n\r\nThis change revealed an issue in the tests where time moved backwards. Since that does not work with `track_time_interval()`, the tests were updated with an extra `patch` for current time as seen by the switch.\r\n\r\n**Related issue (if applicable):** fixes #17368\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\n  - platform: flux\r\n    lights: light.chandelier, light.living_wall_lamps\r\n    name: Fluxer Living Room\r\n    mode: mired\r\n    start_colortemp: 5000\r\n    sunset_colortemp: 4000\r\n    stop_colortemp: 3000\r\n    disable_brightness_adjust: True\r\n    interval: 3000\r\n```\r\n\r\n## Checklist:\r\n  - [X] The code change is tested and works locally.\r\n  - [X] Local tests pass with `tox`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Tests have been added to verify that the new code works.\r\n","created_at":"2018-10-14T20:26:47Z","updated_at":"2018-10-15T05:30:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fedb7553db9cc16e79215a26677db37559400d0d","assignee":{"login":"amelchio","id":26174915,"node_id":"MDQ6VXNlcjI2MTc0OTE1","avatar_url":"https://avatars3.githubusercontent.com/u/26174915?v=4","gravatar_id":"","url":"https://api.github.com/users/amelchio","html_url":"https://github.com/amelchio","followers_url":"https://api.github.com/users/amelchio/followers","following_url":"https://api.github.com/users/amelchio/following{/other_user}","gists_url":"https://api.github.com/users/amelchio/gists{/gist_id}","starred_url":"https://api.github.com/users/amelchio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amelchio/subscriptions","organizations_url":"https://api.github.com/users/amelchio/orgs","repos_url":"https://api.github.com/users/amelchio/repos","events_url":"https://api.github.com/users/amelchio/events{/privacy}","received_events_url":"https://api.github.com/users/amelchio/received_events","type":"User","site_admin":false},"assignees":[{"login":"amelchio","id":26174915,"node_id":"MDQ6VXNlcjI2MTc0OTE1","avatar_url":"https://avatars3.githubusercontent.com/u/26174915?v=4","gravatar_id":"","url":"https://api.github.com/users/amelchio","html_url":"https://github.com/amelchio","followers_url":"https://api.github.com/users/amelchio/followers","following_url":"https://api.github.com/users/amelchio/following{/other_user}","gists_url":"https://api.github.com/users/amelchio/gists{/gist_id}","starred_url":"https://api.github.com/users/amelchio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amelchio/subscriptions","organizations_url":"https://api.github.com/users/amelchio/orgs","repos_url":"https://api.github.com/users/amelchio/repos","events_url":"https://api.github.com/users/amelchio/events{/privacy}","received_events_url":"https://api.github.com/users/amelchio/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":450787042,"node_id":"MDU6TGFiZWw0NTA3ODcwNDI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/Hacktoberfest","name":"Hacktoberfest","color":"fbca04","default":false},{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":550212189,"node_id":"MDU6TGFiZWw1NTAyMTIxODk=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20switch.flux","name":"platform: switch.flux","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17458/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17458/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17458/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/207031e1f4cc5d5259aa150b10bac34f3a7baa84","head":{"label":"amelchio:flux-interval","ref":"flux-interval","sha":"207031e1f4cc5d5259aa150b10bac34f3a7baa84","user":{"login":"amelchio","id":26174915,"node_id":"MDQ6VXNlcjI2MTc0OTE1","avatar_url":"https://avatars3.githubusercontent.com/u/26174915?v=4","gravatar_id":"","url":"https://api.github.com/users/amelchio","html_url":"https://github.com/amelchio","followers_url":"https://api.github.com/users/amelchio/followers","following_url":"https://api.github.com/users/amelchio/following{/other_user}","gists_url":"https://api.github.com/users/amelchio/gists{/gist_id}","starred_url":"https://api.github.com/users/amelchio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amelchio/subscriptions","organizations_url":"https://api.github.com/users/amelchio/orgs","repos_url":"https://api.github.com/users/amelchio/repos","events_url":"https://api.github.com/users/amelchio/events{/privacy}","received_events_url":"https://api.github.com/users/amelchio/received_events","type":"User","site_admin":false},"repo":{"id":83846619,"node_id":"MDEwOlJlcG9zaXRvcnk4Mzg0NjYxOQ==","name":"home-assistant","full_name":"amelchio/home-assistant","private":false,"owner":{"login":"amelchio","id":26174915,"node_id":"MDQ6VXNlcjI2MTc0OTE1","avatar_url":"https://avatars3.githubusercontent.com/u/26174915?v=4","gravatar_id":"","url":"https://api.github.com/users/amelchio","html_url":"https://github.com/amelchio","followers_url":"https://api.github.com/users/amelchio/followers","following_url":"https://api.github.com/users/amelchio/following{/other_user}","gists_url":"https://api.github.com/users/amelchio/gists{/gist_id}","starred_url":"https://api.github.com/users/amelchio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amelchio/subscriptions","organizations_url":"https://api.github.com/users/amelchio/orgs","repos_url":"https://api.github.com/users/amelchio/repos","events_url":"https://api.github.com/users/amelchio/events{/privacy}","received_events_url":"https://api.github.com/users/amelchio/received_events","type":"User","site_admin":false},"html_url":"https://github.com/amelchio/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/amelchio/home-assistant","forks_url":"https://api.github.com/repos/amelchio/home-assistant/forks","keys_url":"https://api.github.com/repos/amelchio/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amelchio/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amelchio/home-assistant/teams","hooks_url":"https://api.github.com/repos/amelchio/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/amelchio/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/amelchio/home-assistant/events","assignees_url":"https://api.github.com/repos/amelchio/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/amelchio/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/amelchio/home-assistant/tags","blobs_url":"https://api.github.com/repos/amelchio/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amelchio/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amelchio/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/amelchio/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amelchio/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/amelchio/home-assistant/languages","stargazers_url":"https://api.github.com/repos/amelchio/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/amelchio/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/amelchio/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/amelchio/home-assistant/subscription","commits_url":"https://api.github.com/repos/amelchio/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/amelchio/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/amelchio/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/amelchio/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/amelchio/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/amelchio/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amelchio/home-assistant/merges","archive_url":"https://api.github.com/repos/amelchio/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amelchio/home-assistant/downloads","issues_url":"https://api.github.com/repos/amelchio/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/amelchio/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/amelchio/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/amelchio/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amelchio/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/amelchio/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/amelchio/home-assistant/deployments","created_at":"2017-03-03T22:19:44Z","updated_at":"2018-10-02T11:48:54Z","pushed_at":"2018-10-15T05:29:58Z","git_url":"git://github.com/amelchio/home-assistant.git","ssh_url":"git@github.com:amelchio/home-assistant.git","clone_url":"https://github.com/amelchio/home-assistant.git","svn_url":"https://github.com/amelchio/home-assistant","homepage":"https://home-assistant.io","size":91112,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"b022dde622cb18853694314950ee35639a14225c","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","private":false,"owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-10-15T04:53:44Z","pushed_at":"2018-10-15T05:30:01Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://www.home-assistant.io","size":90766,"stargazers_count":17398,"watchers_count":17398,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5113,"mirror_url":null,"archived":false,"open_issues_count":984,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5113,"open_issues":984,"watchers":17398,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17458"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/17458"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/17458"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/17458/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17458/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17458/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/207031e1f4cc5d5259aa150b10bac34f3a7baa84"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}