{"action":"created","comment":{"url":"https://api.github.com/repos/kiali/kiali/pulls/comments/194373408","pull_request_review_id":127531198,"id":194373408,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDM3MzQwOA==","diff_hunk":"@@ -0,0 +1,35 @@\n+package hostname\n+\n+import \"strings\"\n+\n+// Match retruns true when the hostname specify the service passed by param.","path":"util/hostname/match.go","position":5,"original_position":5,"commit_id":"54dd1bf9ddb585d9608eee813cb46a47e1d89d68","original_commit_id":"54dd1bf9ddb585d9608eee813cb46a47e1d89d68","user":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"typo \"retruns\"","created_at":"2018-06-11T11:37:27Z","updated_at":"2018-06-11T11:37:28Z","html_url":"https://github.com/kiali/kiali/pull/257#discussion_r194373408","pull_request_url":"https://api.github.com/repos/kiali/kiali/pulls/257","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali/pulls/comments/194373408"},"html":{"href":"https://github.com/kiali/kiali/pull/257#discussion_r194373408"},"pull_request":{"href":"https://api.github.com/repos/kiali/kiali/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/kiali/kiali/pulls/257","id":193943860,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzOTQzODYw","html_url":"https://github.com/kiali/kiali/pull/257","diff_url":"https://github.com/kiali/kiali/pull/257.diff","patch_url":"https://github.com/kiali/kiali/pull/257.patch","issue_url":"https://api.github.com/repos/kiali/kiali/issues/257","number":257,"state":"open","locked":false,"title":"Kiali 893 DestinatioRule is using host field","user":{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false},"body":"Due to a change of Destination Rule specification in Istio 0.8,  those resources are bound to a hostname instead of a service name.\r\n\r\nIn this PR all API calls that fetch Destination Rules are adapted to this change.","created_at":"2018-06-11T10:54:01Z","updated_at":"2018-06-11T11:37:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad7d1702ecb9af30aae118139571a291754589d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":828917230,"node_id":"MDU6TGFiZWw4Mjg5MTcyMzA=","url":"https://api.github.com/repos/kiali/kiali/labels/do%20not%20merge","name":"do not merge","color":"fc9492","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali/pulls/257/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali/pulls/257/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali/issues/257/comments","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/54dd1bf9ddb585d9608eee813cb46a47e1d89d68","head":{"label":"xeviknal:KIALI-893","ref":"KIALI-893","sha":"54dd1bf9ddb585d9608eee813cb46a47e1d89d68","user":{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false},"repo":{"id":120455008,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA0NTUwMDg=","name":"swscore","full_name":"xeviknal/swscore","owner":{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xeviknal/swscore","description":null,"fork":true,"url":"https://api.github.com/repos/xeviknal/swscore","forks_url":"https://api.github.com/repos/xeviknal/swscore/forks","keys_url":"https://api.github.com/repos/xeviknal/swscore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xeviknal/swscore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xeviknal/swscore/teams","hooks_url":"https://api.github.com/repos/xeviknal/swscore/hooks","issue_events_url":"https://api.github.com/repos/xeviknal/swscore/issues/events{/number}","events_url":"https://api.github.com/repos/xeviknal/swscore/events","assignees_url":"https://api.github.com/repos/xeviknal/swscore/assignees{/user}","branches_url":"https://api.github.com/repos/xeviknal/swscore/branches{/branch}","tags_url":"https://api.github.com/repos/xeviknal/swscore/tags","blobs_url":"https://api.github.com/repos/xeviknal/swscore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xeviknal/swscore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xeviknal/swscore/git/refs{/sha}","trees_url":"https://api.github.com/repos/xeviknal/swscore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xeviknal/swscore/statuses/{sha}","languages_url":"https://api.github.com/repos/xeviknal/swscore/languages","stargazers_url":"https://api.github.com/repos/xeviknal/swscore/stargazers","contributors_url":"https://api.github.com/repos/xeviknal/swscore/contributors","subscribers_url":"https://api.github.com/repos/xeviknal/swscore/subscribers","subscription_url":"https://api.github.com/repos/xeviknal/swscore/subscription","commits_url":"https://api.github.com/repos/xeviknal/swscore/commits{/sha}","git_commits_url":"https://api.github.com/repos/xeviknal/swscore/git/commits{/sha}","comments_url":"https://api.github.com/repos/xeviknal/swscore/comments{/number}","issue_comment_url":"https://api.github.com/repos/xeviknal/swscore/issues/comments{/number}","contents_url":"https://api.github.com/repos/xeviknal/swscore/contents/{+path}","compare_url":"https://api.github.com/repos/xeviknal/swscore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xeviknal/swscore/merges","archive_url":"https://api.github.com/repos/xeviknal/swscore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xeviknal/swscore/downloads","issues_url":"https://api.github.com/repos/xeviknal/swscore/issues{/number}","pulls_url":"https://api.github.com/repos/xeviknal/swscore/pulls{/number}","milestones_url":"https://api.github.com/repos/xeviknal/swscore/milestones{/number}","notifications_url":"https://api.github.com/repos/xeviknal/swscore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xeviknal/swscore/labels{/name}","releases_url":"https://api.github.com/repos/xeviknal/swscore/releases{/id}","deployments_url":"https://api.github.com/repos/xeviknal/swscore/deployments","created_at":"2018-02-06T12:44:52Z","updated_at":"2018-04-05T10:05:23Z","pushed_at":"2018-06-11T10:49:00Z","git_url":"git://github.com/xeviknal/swscore.git","ssh_url":"git@github.com:xeviknal/swscore.git","clone_url":"https://github.com/xeviknal/swscore.git","svn_url":"https://github.com/xeviknal/swscore","homepage":null,"size":10900,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"d90b2cbf01f61417c7a28160990b2918e45f2129","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120181748,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAxODE3NDg=","name":"kiali","full_name":"kiali/kiali","owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiali/kiali","description":"Kiali project, observability for the Istio service mesh","fork":false,"url":"https://api.github.com/repos/kiali/kiali","forks_url":"https://api.github.com/repos/kiali/kiali/forks","keys_url":"https://api.github.com/repos/kiali/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali/teams","hooks_url":"https://api.github.com/repos/kiali/kiali/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali/events","assignees_url":"https://api.github.com/repos/kiali/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali/tags","blobs_url":"https://api.github.com/repos/kiali/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali/subscription","commits_url":"https://api.github.com/repos/kiali/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali/merges","archive_url":"https://api.github.com/repos/kiali/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali/downloads","issues_url":"https://api.github.com/repos/kiali/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali/deployments","created_at":"2018-02-04T12:11:57Z","updated_at":"2018-06-11T05:45:38Z","pushed_at":"2018-06-11T10:54:02Z","git_url":"git://github.com/kiali/kiali.git","ssh_url":"git@github.com:kiali/kiali.git","clone_url":"https://github.com/kiali/kiali.git","svn_url":"https://github.com/kiali/kiali","homepage":"https://kiali.org/","size":10892,"stargazers_count":59,"watchers_count":59,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":16,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali/pulls/257"},"html":{"href":"https://github.com/kiali/kiali/pull/257"},"issue":{"href":"https://api.github.com/repos/kiali/kiali/issues/257"},"comments":{"href":"https://api.github.com/repos/kiali/kiali/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali/statuses/54dd1bf9ddb585d9608eee813cb46a47e1d89d68"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lucasponce"}}