{"action":"created","issue":{"url":"https://api.github.com/repos/mbeddr/mbeddr.core/issues/2016","repository_url":"https://api.github.com/repos/mbeddr/mbeddr.core","labels_url":"https://api.github.com/repos/mbeddr/mbeddr.core/issues/2016/labels{/name}","comments_url":"https://api.github.com/repos/mbeddr/mbeddr.core/issues/2016/comments","events_url":"https://api.github.com/repos/mbeddr/mbeddr.core/issues/2016/events","html_url":"https://github.com/mbeddr/mbeddr.core/pull/2016","id":383137332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjc4NzY0","number":2016,"title":"com.mbeddr.doc: refactored image handling","user":{"login":"joao-silveira","id":11679144,"node_id":"MDQ6VXNlcjExNjc5MTQ0","avatar_url":"https://avatars0.githubusercontent.com/u/11679144?v=4","gravatar_id":"","url":"https://api.github.com/users/joao-silveira","html_url":"https://github.com/joao-silveira","followers_url":"https://api.github.com/users/joao-silveira/followers","following_url":"https://api.github.com/users/joao-silveira/following{/other_user}","gists_url":"https://api.github.com/users/joao-silveira/gists{/gist_id}","starred_url":"https://api.github.com/users/joao-silveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joao-silveira/subscriptions","organizations_url":"https://api.github.com/users/joao-silveira/orgs","repos_url":"https://api.github.com/users/joao-silveira/repos","events_url":"https://api.github.com/users/joao-silveira/events{/privacy}","received_events_url":"https://api.github.com/users/joao-silveira/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-21T14:15:19Z","updated_at":"2018-11-21T15:18:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mbeddr/mbeddr.core/pulls/2016","html_url":"https://github.com/mbeddr/mbeddr.core/pull/2016","diff_url":"https://github.com/mbeddr/mbeddr.core/pull/2016.diff","patch_url":"https://github.com/mbeddr/mbeddr.core/pull/2016.patch"},"body":"Image handling was broken, namely:\r\n-Default image path didn't show up in the scope of the path for resources (such as for ImageParagraph)\r\n-When using ImageParagraph, the images would never end up in the doc_gen output folder and so we always had broken links\r\n\r\nSo I did the following refactorings:\r\n-Now it is mandatory to configure the default image path\r\n-Default image path folder is copied in the doc_gen output folder\r\n-Screen shots also end up in the copied image path in the doc_gen folder\r\n-Deprecated DefaultImagePath as this seemed a half baked idea. Provided a migration to replace it with a regular PathDefinition\r\n\r\nFrom now on default image path in the documentation config must always be properly configured, and this resource should always be used as resource for ImageParagraphs.\r\n\r\nAlso I wanted to create a new facet, that would run after placeGeneratedFiles for copying the default image path folder into the doc_gen folder, but failed to to so. Therefore I included it in placeGeneratedFiles itself. If you feel like it is still a good idea to move it in a new facet we can try again."},"comment":{"url":"https://api.github.com/repos/mbeddr/mbeddr.core/issues/comments/440701806","html_url":"https://github.com/mbeddr/mbeddr.core/pull/2016#issuecomment-440701806","issue_url":"https://api.github.com/repos/mbeddr/mbeddr.core/issues/2016","id":440701806,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDcwMTgwNg==","user":{"login":"joao-silveira","id":11679144,"node_id":"MDQ6VXNlcjExNjc5MTQ0","avatar_url":"https://avatars0.githubusercontent.com/u/11679144?v=4","gravatar_id":"","url":"https://api.github.com/users/joao-silveira","html_url":"https://github.com/joao-silveira","followers_url":"https://api.github.com/users/joao-silveira/followers","following_url":"https://api.github.com/users/joao-silveira/following{/other_user}","gists_url":"https://api.github.com/users/joao-silveira/gists{/gist_id}","starred_url":"https://api.github.com/users/joao-silveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joao-silveira/subscriptions","organizations_url":"https://api.github.com/users/joao-silveira/orgs","repos_url":"https://api.github.com/users/joao-silveira/repos","events_url":"https://api.github.com/users/joao-silveira/events{/privacy}","received_events_url":"https://api.github.com/users/joao-silveira/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T15:18:53Z","updated_at":"2018-11-21T15:18:53Z","author_association":"CONTRIBUTOR","body":"I wasn't sure if I should:\r\n1. Place the screen shots in the original image folder and then let it be copied with all the other files to the doc gen\r\n2. Place them directly in the doc_gen folder\r\n\r\nFor now i've chosen the latest one, not sure though if this is what the user would expect."}}
{"actor":{"display_login":"joao-silveira"}}