{"action":"created","comment":{"url":"https://api.github.com/repos/p4lang/p4c/pulls/comments/196945314","pull_request_review_id":130592115,"id":196945314,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Njk0NTMxNA==","diff_hunk":"@@ -276,6 +294,22 @@ def main(argv):\n             else:\n                 options.compilerOptions += argv[1].split();\n                 argv = argv[1:]\n+        elif argv[0] == \"--sa\":\n+            if len(argv) == 0:\n+                reportError(\"Missing argument for --sa option\")\n+                usage(options)\n+                sys.exit(FAILURE)\n+            else:\n+                options.switchOptions += argv[1].split();\n+                argv = argv[1:]\n+        elif argv[0] == \"--stsa\":","path":"backends/bmv2/run-bmv2-test.py","position":61,"original_position":61,"commit_id":"1e9e0336f3b66e9e58a6f7520ecf5e73fa8934f1","original_commit_id":"1e9e0336f3b66e9e58a6f7520ecf5e73fa8934f1","user":{"login":"hanw","id":125978,"node_id":"MDQ6VXNlcjEyNTk3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/125978?v=4","gravatar_id":"","url":"https://api.github.com/users/hanw","html_url":"https://github.com/hanw","followers_url":"https://api.github.com/users/hanw/followers","following_url":"https://api.github.com/users/hanw/following{/other_user}","gists_url":"https://api.github.com/users/hanw/gists{/gist_id}","starred_url":"https://api.github.com/users/hanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanw/subscriptions","organizations_url":"https://api.github.com/users/hanw/orgs","repos_url":"https://api.github.com/users/hanw/repos","events_url":"https://api.github.com/users/hanw/events{/privacy}","received_events_url":"https://api.github.com/users/hanw/received_events","type":"User","site_admin":false},"body":"The `--stsa` acronym is difficult to understand, can you spell it out please?","created_at":"2018-06-20T21:16:13Z","updated_at":"2018-06-20T21:16:26Z","html_url":"https://github.com/p4lang/p4c/pull/1289#discussion_r196945314","pull_request_url":"https://api.github.com/repos/p4lang/p4c/pulls/1289","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/comments/196945314"},"html":{"href":"https://github.com/p4lang/p4c/pull/1289#discussion_r196945314"},"pull_request":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/1289"}}},"pull_request":{"url":"https://api.github.com/repos/p4lang/p4c/pulls/1289","id":189293722,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MjkzNzIy","html_url":"https://github.com/p4lang/p4c/pull/1289","diff_url":"https://github.com/p4lang/p4c/pull/1289.diff","patch_url":"https://github.com/p4lang/p4c/pull/1289.patch","issue_url":"https://api.github.com/repos/p4lang/p4c/issues/1289","number":1289,"state":"open","locked":false,"title":"Emit extern functions with --emit-externs","user":{"login":"omeranson","id":6899356,"node_id":"MDQ6VXNlcjY4OTkzNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/6899356?v=4","gravatar_id":"","url":"https://api.github.com/users/omeranson","html_url":"https://github.com/omeranson","followers_url":"https://api.github.com/users/omeranson/followers","following_url":"https://api.github.com/users/omeranson/following{/other_user}","gists_url":"https://api.github.com/users/omeranson/gists{/gist_id}","starred_url":"https://api.github.com/users/omeranson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omeranson/subscriptions","organizations_url":"https://api.github.com/users/omeranson/orgs","repos_url":"https://api.github.com/users/omeranson/repos","events_url":"https://api.github.com/users/omeranson/events{/privacy}","received_events_url":"https://api.github.com/users/omeranson/received_events","type":"User","site_admin":false},"body":"This change builds on top of pull request #1217 to also support emitting\r\nextern functions (in addition to objects and methods).\r\n\r\nIt assumes extern functions have the __extern_ prefix, to avoid name\r\ncollision.","created_at":"2018-05-21T06:31:14Z","updated_at":"2018-06-20T21:16:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b701f3164e9f2af4b94a5265d26b0584bfb0c5b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/p4lang/p4c/pulls/1289/commits","review_comments_url":"https://api.github.com/repos/p4lang/p4c/pulls/1289/comments","review_comment_url":"https://api.github.com/repos/p4lang/p4c/pulls/comments{/number}","comments_url":"https://api.github.com/repos/p4lang/p4c/issues/1289/comments","statuses_url":"https://api.github.com/repos/p4lang/p4c/statuses/1e9e0336f3b66e9e58a6f7520ecf5e73fa8934f1","head":{"label":"omeranson:emit-externs","ref":"emit-externs","sha":"1e9e0336f3b66e9e58a6f7520ecf5e73fa8934f1","user":{"login":"omeranson","id":6899356,"node_id":"MDQ6VXNlcjY4OTkzNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/6899356?v=4","gravatar_id":"","url":"https://api.github.com/users/omeranson","html_url":"https://github.com/omeranson","followers_url":"https://api.github.com/users/omeranson/followers","following_url":"https://api.github.com/users/omeranson/following{/other_user}","gists_url":"https://api.github.com/users/omeranson/gists{/gist_id}","starred_url":"https://api.github.com/users/omeranson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omeranson/subscriptions","organizations_url":"https://api.github.com/users/omeranson/orgs","repos_url":"https://api.github.com/users/omeranson/repos","events_url":"https://api.github.com/users/omeranson/events{/privacy}","received_events_url":"https://api.github.com/users/omeranson/received_events","type":"User","site_admin":false},"repo":{"id":134227341,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQyMjczNDE=","name":"p4c","full_name":"omeranson/p4c","owner":{"login":"omeranson","id":6899356,"node_id":"MDQ6VXNlcjY4OTkzNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/6899356?v=4","gravatar_id":"","url":"https://api.github.com/users/omeranson","html_url":"https://github.com/omeranson","followers_url":"https://api.github.com/users/omeranson/followers","following_url":"https://api.github.com/users/omeranson/following{/other_user}","gists_url":"https://api.github.com/users/omeranson/gists{/gist_id}","starred_url":"https://api.github.com/users/omeranson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omeranson/subscriptions","organizations_url":"https://api.github.com/users/omeranson/orgs","repos_url":"https://api.github.com/users/omeranson/repos","events_url":"https://api.github.com/users/omeranson/events{/privacy}","received_events_url":"https://api.github.com/users/omeranson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omeranson/p4c","description":"P4_16 prototype compiler","fork":true,"url":"https://api.github.com/repos/omeranson/p4c","forks_url":"https://api.github.com/repos/omeranson/p4c/forks","keys_url":"https://api.github.com/repos/omeranson/p4c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omeranson/p4c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omeranson/p4c/teams","hooks_url":"https://api.github.com/repos/omeranson/p4c/hooks","issue_events_url":"https://api.github.com/repos/omeranson/p4c/issues/events{/number}","events_url":"https://api.github.com/repos/omeranson/p4c/events","assignees_url":"https://api.github.com/repos/omeranson/p4c/assignees{/user}","branches_url":"https://api.github.com/repos/omeranson/p4c/branches{/branch}","tags_url":"https://api.github.com/repos/omeranson/p4c/tags","blobs_url":"https://api.github.com/repos/omeranson/p4c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omeranson/p4c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omeranson/p4c/git/refs{/sha}","trees_url":"https://api.github.com/repos/omeranson/p4c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omeranson/p4c/statuses/{sha}","languages_url":"https://api.github.com/repos/omeranson/p4c/languages","stargazers_url":"https://api.github.com/repos/omeranson/p4c/stargazers","contributors_url":"https://api.github.com/repos/omeranson/p4c/contributors","subscribers_url":"https://api.github.com/repos/omeranson/p4c/subscribers","subscription_url":"https://api.github.com/repos/omeranson/p4c/subscription","commits_url":"https://api.github.com/repos/omeranson/p4c/commits{/sha}","git_commits_url":"https://api.github.com/repos/omeranson/p4c/git/commits{/sha}","comments_url":"https://api.github.com/repos/omeranson/p4c/comments{/number}","issue_comment_url":"https://api.github.com/repos/omeranson/p4c/issues/comments{/number}","contents_url":"https://api.github.com/repos/omeranson/p4c/contents/{+path}","compare_url":"https://api.github.com/repos/omeranson/p4c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omeranson/p4c/merges","archive_url":"https://api.github.com/repos/omeranson/p4c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omeranson/p4c/downloads","issues_url":"https://api.github.com/repos/omeranson/p4c/issues{/number}","pulls_url":"https://api.github.com/repos/omeranson/p4c/pulls{/number}","milestones_url":"https://api.github.com/repos/omeranson/p4c/milestones{/number}","notifications_url":"https://api.github.com/repos/omeranson/p4c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omeranson/p4c/labels{/name}","releases_url":"https://api.github.com/repos/omeranson/p4c/releases{/id}","deployments_url":"https://api.github.com/repos/omeranson/p4c/deployments","created_at":"2018-05-21T06:25:32Z","updated_at":"2018-05-21T06:25:39Z","pushed_at":"2018-06-11T14:59:47Z","git_url":"git://github.com/omeranson/p4c.git","ssh_url":"git@github.com:omeranson/p4c.git","clone_url":"https://github.com/omeranson/p4c.git","svn_url":"https://github.com/omeranson/p4c","homepage":"","size":63940,"stargazers_count":0,"watchers_count":0,"language":"P4","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"p4lang:master","ref":"master","sha":"33217fa54609271ae4feff98963a1e79762c81af","user":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"repo":{"id":55433859,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQzMzg1OQ==","name":"p4c","full_name":"p4lang/p4c","owner":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/p4lang/p4c","description":"P4_16 prototype compiler","fork":false,"url":"https://api.github.com/repos/p4lang/p4c","forks_url":"https://api.github.com/repos/p4lang/p4c/forks","keys_url":"https://api.github.com/repos/p4lang/p4c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p4lang/p4c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p4lang/p4c/teams","hooks_url":"https://api.github.com/repos/p4lang/p4c/hooks","issue_events_url":"https://api.github.com/repos/p4lang/p4c/issues/events{/number}","events_url":"https://api.github.com/repos/p4lang/p4c/events","assignees_url":"https://api.github.com/repos/p4lang/p4c/assignees{/user}","branches_url":"https://api.github.com/repos/p4lang/p4c/branches{/branch}","tags_url":"https://api.github.com/repos/p4lang/p4c/tags","blobs_url":"https://api.github.com/repos/p4lang/p4c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p4lang/p4c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p4lang/p4c/git/refs{/sha}","trees_url":"https://api.github.com/repos/p4lang/p4c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p4lang/p4c/statuses/{sha}","languages_url":"https://api.github.com/repos/p4lang/p4c/languages","stargazers_url":"https://api.github.com/repos/p4lang/p4c/stargazers","contributors_url":"https://api.github.com/repos/p4lang/p4c/contributors","subscribers_url":"https://api.github.com/repos/p4lang/p4c/subscribers","subscription_url":"https://api.github.com/repos/p4lang/p4c/subscription","commits_url":"https://api.github.com/repos/p4lang/p4c/commits{/sha}","git_commits_url":"https://api.github.com/repos/p4lang/p4c/git/commits{/sha}","comments_url":"https://api.github.com/repos/p4lang/p4c/comments{/number}","issue_comment_url":"https://api.github.com/repos/p4lang/p4c/issues/comments{/number}","contents_url":"https://api.github.com/repos/p4lang/p4c/contents/{+path}","compare_url":"https://api.github.com/repos/p4lang/p4c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p4lang/p4c/merges","archive_url":"https://api.github.com/repos/p4lang/p4c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p4lang/p4c/downloads","issues_url":"https://api.github.com/repos/p4lang/p4c/issues{/number}","pulls_url":"https://api.github.com/repos/p4lang/p4c/pulls{/number}","milestones_url":"https://api.github.com/repos/p4lang/p4c/milestones{/number}","notifications_url":"https://api.github.com/repos/p4lang/p4c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p4lang/p4c/labels{/name}","releases_url":"https://api.github.com/repos/p4lang/p4c/releases{/id}","deployments_url":"https://api.github.com/repos/p4lang/p4c/deployments","created_at":"2016-04-04T18:12:32Z","updated_at":"2018-06-20T06:19:15Z","pushed_at":"2018-06-20T20:21:29Z","git_url":"git://github.com/p4lang/p4c.git","ssh_url":"git@github.com:p4lang/p4c.git","clone_url":"https://github.com/p4lang/p4c.git","svn_url":"https://github.com/p4lang/p4c","homepage":"","size":64091,"stargazers_count":115,"watchers_count":115,"language":"P4","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":75,"open_issues":81,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/1289"},"html":{"href":"https://github.com/p4lang/p4c/pull/1289"},"issue":{"href":"https://api.github.com/repos/p4lang/p4c/issues/1289"},"comments":{"href":"https://api.github.com/repos/p4lang/p4c/issues/1289/comments"},"review_comments":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/1289/comments"},"review_comment":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/1289/commits"},"statuses":{"href":"https://api.github.com/repos/p4lang/p4c/statuses/1e9e0336f3b66e9e58a6f7520ecf5e73fa8934f1"}},"author_association":"NONE"}}
{"actor":{"display_login":"hanw"}}