{"action":"created","comment":{"url":"https://api.github.com/repos/knative/serving/pulls/comments/230930066","pull_request_review_id":171781782,"id":230930066,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDkzMDA2Ng==","diff_hunk":"@@ -18,19 +18,39 @@\n \n source $(dirname $0)/../vendor/github.com/knative/test-infra/scripts/e2e-tests.sh\n \n-# Location of istio for the test cluster\n-readonly ISTIO_YAML=./third_party/istio-1.0.2/istio.yaml\n+CLUSTER_SH_CREATED_MANIFESTS=0\n \n-function create_istio() {\n-  echo \">> Bringing up Istio\"\n-  kubectl apply -f ${ISTIO_YAML}\n+# Create all manifests required to install Knative Serving.\n+function create_manifests() {\n+  # Don't generate twice.\n+  (( CLUSTER_SH_CREATED_MANIFESTS )) && return 0\n+  local YAML_LIST=\"$(mktemp)\"\n+  # Generate manifests, capture environment variables pointing to the YAML files.\n+  local FULL_OUTPUT=\"$( \\\n+      source $(dirname $0)/../hack/generate-yamls.sh ${REPO_ROOT_DIR} ${YAML_LIST} ; \\","path":"test/cluster.sh","position":18,"original_position":18,"commit_id":"5bc9d5d10896eee1a675eef4637ba1db6a7f9c1e","original_commit_id":"5bc9d5d10896eee1a675eef4637ba1db6a7f9c1e","user":{"login":"jonjohnsonjr","id":17863526,"node_id":"MDQ6VXNlcjE3ODYzNTI2","avatar_url":"https://avatars1.githubusercontent.com/u/17863526?v=4","gravatar_id":"","url":"https://api.github.com/users/jonjohnsonjr","html_url":"https://github.com/jonjohnsonjr","followers_url":"https://api.github.com/users/jonjohnsonjr/followers","following_url":"https://api.github.com/users/jonjohnsonjr/following{/other_user}","gists_url":"https://api.github.com/users/jonjohnsonjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jonjohnsonjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonjohnsonjr/subscriptions","organizations_url":"https://api.github.com/users/jonjohnsonjr/orgs","repos_url":"https://api.github.com/users/jonjohnsonjr/repos","events_url":"https://api.github.com/users/jonjohnsonjr/events{/privacy}","received_events_url":"https://api.github.com/users/jonjohnsonjr/received_events","type":"User","site_admin":false},"body":"Trying to use this, it fails if I first call `initialize`:\r\n\r\n```\r\n./cluster.sh: line 31: ./../hack/generate-yamls.sh: No such file or directory\r\nERROR: Error generating manifests\r\n```\r\n\r\nIf I `pwd` before this line, it's `/usr/local/google/home/jonjohnson/go/src/github.com/knative/serving`\r\n\r\nI'm confused though, maybe I don't understand how `dirname` works since it seems like this should work..","created_at":"2018-11-05T22:02:30Z","updated_at":"2018-11-05T22:02:30Z","html_url":"https://github.com/knative/serving/pull/2382#discussion_r230930066","pull_request_url":"https://api.github.com/repos/knative/serving/pulls/2382","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/comments/230930066"},"html":{"href":"https://github.com/knative/serving/pull/2382#discussion_r230930066"},"pull_request":{"href":"https://api.github.com/repos/knative/serving/pulls/2382"}}},"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2382","id":227735158,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzM1MTU4","html_url":"https://github.com/knative/serving/pull/2382","diff_url":"https://github.com/knative/serving/pull/2382.diff","patch_url":"https://github.com/knative/serving/pull/2382.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/2382","number":2382,"state":"open","locked":false,"title":"Use a single approach for building Serving for test and release","user":{"login":"adrcunha","id":35786489,"node_id":"MDQ6VXNlcjM1Nzg2NDg5","avatar_url":"https://avatars3.githubusercontent.com/u/35786489?v=4","gravatar_id":"","url":"https://api.github.com/users/adrcunha","html_url":"https://github.com/adrcunha","followers_url":"https://api.github.com/users/adrcunha/followers","following_url":"https://api.github.com/users/adrcunha/following{/other_user}","gists_url":"https://api.github.com/users/adrcunha/gists{/gist_id}","starred_url":"https://api.github.com/users/adrcunha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrcunha/subscriptions","organizations_url":"https://api.github.com/users/adrcunha/orgs","repos_url":"https://api.github.com/users/adrcunha/repos","events_url":"https://api.github.com/users/adrcunha/events{/privacy}","received_events_url":"https://api.github.com/users/adrcunha/received_events","type":"User","site_admin":false},"body":"Now `cluster.sh` will use the same artifacts generated by `release.sh` to test Knative Serving. This will avoid surprises in the future due to having slightly different manifests for Serving when testing or releasing.\r\n\r\nAlso fixes #2354.","created_at":"2018-11-01T19:39:13Z","updated_at":"2018-11-05T22:02:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c28ffc1227b9c725103bee3984b4f768fd6679d","assignee":{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},"assignees":[{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},{"login":"jessiezcc","id":37942702,"node_id":"MDQ6VXNlcjM3OTQyNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/37942702?v=4","gravatar_id":"","url":"https://api.github.com/users/jessiezcc","html_url":"https://github.com/jessiezcc","followers_url":"https://api.github.com/users/jessiezcc/followers","following_url":"https://api.github.com/users/jessiezcc/following{/other_user}","gists_url":"https://api.github.com/users/jessiezcc/gists{/gist_id}","starred_url":"https://api.github.com/users/jessiezcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessiezcc/subscriptions","organizations_url":"https://api.github.com/users/jessiezcc/orgs","repos_url":"https://api.github.com/users/jessiezcc/repos","events_url":"https://api.github.com/users/jessiezcc/events{/privacy}","received_events_url":"https://api.github.com/users/jessiezcc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":864751607,"node_id":"MDU6TGFiZWw4NjQ3NTE2MDc=","url":"https://api.github.com/repos/knative/serving/labels/lgtm","name":"lgtm","color":"ededed","default":false},{"id":862145007,"node_id":"MDU6TGFiZWw4NjIxNDUwMDc=","url":"https://api.github.com/repos/knative/serving/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/2382/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/2382/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/2382/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/5bc9d5d10896eee1a675eef4637ba1db6a7f9c1e","head":{"label":"adrcunha:unify-build","ref":"unify-build","sha":"5bc9d5d10896eee1a675eef4637ba1db6a7f9c1e","user":{"login":"adrcunha","id":35786489,"node_id":"MDQ6VXNlcjM1Nzg2NDg5","avatar_url":"https://avatars3.githubusercontent.com/u/35786489?v=4","gravatar_id":"","url":"https://api.github.com/users/adrcunha","html_url":"https://github.com/adrcunha","followers_url":"https://api.github.com/users/adrcunha/followers","following_url":"https://api.github.com/users/adrcunha/following{/other_user}","gists_url":"https://api.github.com/users/adrcunha/gists{/gist_id}","starred_url":"https://api.github.com/users/adrcunha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrcunha/subscriptions","organizations_url":"https://api.github.com/users/adrcunha/orgs","repos_url":"https://api.github.com/users/adrcunha/repos","events_url":"https://api.github.com/users/adrcunha/events{/privacy}","received_events_url":"https://api.github.com/users/adrcunha/received_events","type":"User","site_admin":false},"repo":{"id":148223951,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyMjM5NTE=","name":"serving","full_name":"adrcunha/serving","private":false,"owner":{"login":"adrcunha","id":35786489,"node_id":"MDQ6VXNlcjM1Nzg2NDg5","avatar_url":"https://avatars3.githubusercontent.com/u/35786489?v=4","gravatar_id":"","url":"https://api.github.com/users/adrcunha","html_url":"https://github.com/adrcunha","followers_url":"https://api.github.com/users/adrcunha/followers","following_url":"https://api.github.com/users/adrcunha/following{/other_user}","gists_url":"https://api.github.com/users/adrcunha/gists{/gist_id}","starred_url":"https://api.github.com/users/adrcunha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrcunha/subscriptions","organizations_url":"https://api.github.com/users/adrcunha/orgs","repos_url":"https://api.github.com/users/adrcunha/repos","events_url":"https://api.github.com/users/adrcunha/events{/privacy}","received_events_url":"https://api.github.com/users/adrcunha/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adrcunha/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/adrcunha/serving","forks_url":"https://api.github.com/repos/adrcunha/serving/forks","keys_url":"https://api.github.com/repos/adrcunha/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrcunha/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrcunha/serving/teams","hooks_url":"https://api.github.com/repos/adrcunha/serving/hooks","issue_events_url":"https://api.github.com/repos/adrcunha/serving/issues/events{/number}","events_url":"https://api.github.com/repos/adrcunha/serving/events","assignees_url":"https://api.github.com/repos/adrcunha/serving/assignees{/user}","branches_url":"https://api.github.com/repos/adrcunha/serving/branches{/branch}","tags_url":"https://api.github.com/repos/adrcunha/serving/tags","blobs_url":"https://api.github.com/repos/adrcunha/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrcunha/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrcunha/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrcunha/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrcunha/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/adrcunha/serving/languages","stargazers_url":"https://api.github.com/repos/adrcunha/serving/stargazers","contributors_url":"https://api.github.com/repos/adrcunha/serving/contributors","subscribers_url":"https://api.github.com/repos/adrcunha/serving/subscribers","subscription_url":"https://api.github.com/repos/adrcunha/serving/subscription","commits_url":"https://api.github.com/repos/adrcunha/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrcunha/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrcunha/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrcunha/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrcunha/serving/contents/{+path}","compare_url":"https://api.github.com/repos/adrcunha/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrcunha/serving/merges","archive_url":"https://api.github.com/repos/adrcunha/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrcunha/serving/downloads","issues_url":"https://api.github.com/repos/adrcunha/serving/issues{/number}","pulls_url":"https://api.github.com/repos/adrcunha/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/adrcunha/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/adrcunha/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrcunha/serving/labels{/name}","releases_url":"https://api.github.com/repos/adrcunha/serving/releases{/id}","deployments_url":"https://api.github.com/repos/adrcunha/serving/deployments","created_at":"2018-09-10T21:54:41Z","updated_at":"2018-10-31T16:43:36Z","pushed_at":"2018-11-01T21:25:01Z","git_url":"git://github.com/adrcunha/serving.git","ssh_url":"git@github.com:adrcunha/serving.git","clone_url":"https://github.com/adrcunha/serving.git","svn_url":"https://github.com/adrcunha/serving","homepage":"","size":23432,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"c01a523cf0681a1f49e6bfa40bec0a5df9160bb5","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2018-11-05T21:42:44Z","pushed_at":"2018-11-05T21:42:37Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"","size":23492,"stargazers_count":825,"watchers_count":825,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"archived":false,"open_issues_count":320,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":162,"open_issues":320,"watchers":825,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/2382"},"html":{"href":"https://github.com/knative/serving/pull/2382"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/2382"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/2382/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/2382/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/2382/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/5bc9d5d10896eee1a675eef4637ba1db6a7f9c1e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jonjohnsonjr"}}