{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonar-php/pulls/comments/205361025","pull_request_review_id":140613371,"id":205361025,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTM2MTAyNQ==","diff_hunk":"@@ -38,6 +38,7 @@\n public class HashFunctionCheck extends PHPVisitorCheck {\n \n   private static final String MESSAGE = \"Use an unpredictable salt value.\";\n+  private static final String MESSAGE_MISSING_SALT = \"Provide cryptographically strong salt parameter.\";","path":"php-checks/src/main/java/org/sonar/php/checks/HashFunctionCheck.java","position":null,"original_position":4,"commit_id":"5bebd8c7c8eb8645097856da1f00960e94eb4f10","original_commit_id":"117fed0077a16ceedf0deb53fcb0c77e1cc2b3b8","user":{"login":"andrei-epure-sonarsource","id":38876598,"node_id":"MDQ6VXNlcjM4ODc2NTk4","avatar_url":"https://avatars1.githubusercontent.com/u/38876598?v=4","gravatar_id":"","url":"https://api.github.com/users/andrei-epure-sonarsource","html_url":"https://github.com/andrei-epure-sonarsource","followers_url":"https://api.github.com/users/andrei-epure-sonarsource/followers","following_url":"https://api.github.com/users/andrei-epure-sonarsource/following{/other_user}","gists_url":"https://api.github.com/users/andrei-epure-sonarsource/gists{/gist_id}","starred_url":"https://api.github.com/users/andrei-epure-sonarsource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrei-epure-sonarsource/subscriptions","organizations_url":"https://api.github.com/users/andrei-epure-sonarsource/orgs","repos_url":"https://api.github.com/users/andrei-epure-sonarsource/repos","events_url":"https://api.github.com/users/andrei-epure-sonarsource/events{/privacy}","received_events_url":"https://api.github.com/users/andrei-epure-sonarsource/received_events","type":"User","site_admin":false},"body":"nitpick: should have the indefinite article \"Provide *a* cryptographically...\"","created_at":"2018-07-26T07:50:56Z","updated_at":"2018-07-26T07:50:56Z","html_url":"https://github.com/SonarSource/sonar-php/pull/316#discussion_r205361025","pull_request_url":"https://api.github.com/repos/SonarSource/sonar-php/pulls/316","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-php/pulls/comments/205361025"},"html":{"href":"https://github.com/SonarSource/sonar-php/pull/316#discussion_r205361025"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonar-php/pulls/316"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-php/pulls/316","id":203610546,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjEwNTQ2","html_url":"https://github.com/SonarSource/sonar-php/pull/316","diff_url":"https://github.com/SonarSource/sonar-php/pull/316.diff","patch_url":"https://github.com/SonarSource/sonar-php/pull/316.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-php/issues/316","number":316,"state":"open","locked":false,"title":"SONARPHP-801 Rule S2053: Hashes of sensitive values should include an…","user":{"login":"saberduck","id":680437,"node_id":"MDQ6VXNlcjY4MDQzNw==","avatar_url":"https://avatars1.githubusercontent.com/u/680437?v=4","gravatar_id":"","url":"https://api.github.com/users/saberduck","html_url":"https://github.com/saberduck","followers_url":"https://api.github.com/users/saberduck/followers","following_url":"https://api.github.com/users/saberduck/following{/other_user}","gists_url":"https://api.github.com/users/saberduck/gists{/gist_id}","starred_url":"https://api.github.com/users/saberduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saberduck/subscriptions","organizations_url":"https://api.github.com/users/saberduck/orgs","repos_url":"https://api.github.com/users/saberduck/repos","events_url":"https://api.github.com/users/saberduck/events{/privacy}","received_events_url":"https://api.github.com/users/saberduck/received_events","type":"User","site_admin":false},"body":"… unpredictable salt","created_at":"2018-07-24T18:09:35Z","updated_at":"2018-07-26T07:50:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14f95d0982ea1ffc82fdf2203a8d368cf4ae98c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-php/pulls/316/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-php/pulls/316/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-php/issues/316/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-php/statuses/5bebd8c7c8eb8645097856da1f00960e94eb4f10","head":{"label":"SonarSource:SONARPHP-801","ref":"SONARPHP-801","sha":"5bebd8c7c8eb8645097856da1f00960e94eb4f10","user":{"login":"SonarSource","id":545988,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NTk4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":4544982,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQ0OTgy","name":"sonar-php","full_name":"SonarSource/sonar-php","owner":{"login":"SonarSource","id":545988,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NTk4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-php","description":" :elephant: SonarPHP: PHP static analyzer for SonarQube & SonarLint","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-php","forks_url":"https://api.github.com/repos/SonarSource/sonar-php/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-php/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-php/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-php/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-php/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-php/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-php/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-php/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-php/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-php/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-php/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-php/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-php/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-php/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-php/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-php/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-php/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-php/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-php/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-php/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-php/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-php/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonar-php/deployments","created_at":"2012-06-04T08:36:12Z","updated_at":"2018-07-25T15:43:07Z","pushed_at":"2018-07-25T17:38:22Z","git_url":"git://github.com/SonarSource/sonar-php.git","ssh_url":"git@github.com:SonarSource/sonar-php.git","clone_url":"https://github.com/SonarSource/sonar-php.git","svn_url":"https://github.com/SonarSource/sonar-php","homepage":"","size":13056,"stargazers_count":133,"watchers_count":133,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":54,"open_issues":3,"watchers":133,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"ae8b346c9751775e58c98f3d14e5752c9f816ded","user":{"login":"SonarSource","id":545988,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NTk4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":4544982,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQ0OTgy","name":"sonar-php","full_name":"SonarSource/sonar-php","owner":{"login":"SonarSource","id":545988,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NTk4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-php","description":" :elephant: SonarPHP: PHP static analyzer for SonarQube & SonarLint","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-php","forks_url":"https://api.github.com/repos/SonarSource/sonar-php/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-php/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-php/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-php/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-php/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-php/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-php/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-php/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-php/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-php/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-php/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-php/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-php/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-php/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-php/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-php/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-php/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-php/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-php/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-php/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-php/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-php/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonar-php/deployments","created_at":"2012-06-04T08:36:12Z","updated_at":"2018-07-25T15:43:07Z","pushed_at":"2018-07-25T17:38:22Z","git_url":"git://github.com/SonarSource/sonar-php.git","ssh_url":"git@github.com:SonarSource/sonar-php.git","clone_url":"https://github.com/SonarSource/sonar-php.git","svn_url":"https://github.com/SonarSource/sonar-php","homepage":"","size":13056,"stargazers_count":133,"watchers_count":133,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":54,"open_issues":3,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-php/pulls/316"},"html":{"href":"https://github.com/SonarSource/sonar-php/pull/316"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-php/issues/316"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-php/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-php/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-php/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-php/statuses/5bebd8c7c8eb8645097856da1f00960e94eb4f10"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andrei-epure-sonarsource"}}