{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/217803381","pull_request_review_id":155611512,"id":217803381,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzgwMzM4MQ==","diff_hunk":"@@ -125,6 +118,9 @@ This is a proposal for what the public API may look like:\n \n             // All project nodes in the graph.\n             IReadOnlyCollection<ProjectGraphNode> ProjectNodes { get; }\n+\n+            // Build the graph with the given target, if any\n+            BuildResult Build(string target = null);","path":"documentation/specs/static-graph.md","position":57,"original_position":57,"commit_id":"37eff970aa4354b1fc19ba07580dc6e154fcaca2","original_commit_id":"37eff970aa4354b1fc19ba07580dc6e154fcaca2","user":{"login":"dfederm","id":6445614,"node_id":"MDQ6VXNlcjY0NDU2MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6445614?v=4","gravatar_id":"","url":"https://api.github.com/users/dfederm","html_url":"https://github.com/dfederm","followers_url":"https://api.github.com/users/dfederm/followers","following_url":"https://api.github.com/users/dfederm/following{/other_user}","gists_url":"https://api.github.com/users/dfederm/gists{/gist_id}","starred_url":"https://api.github.com/users/dfederm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfederm/subscriptions","organizations_url":"https://api.github.com/users/dfederm/orgs","repos_url":"https://api.github.com/users/dfederm/repos","events_url":"https://api.github.com/users/dfederm/events{/privacy}","received_events_url":"https://api.github.com/users/dfederm/received_events","type":"User","site_admin":false},"body":"Good point. There are probably a ton of convenience overloads we should add in general. Probably towards the end through when we're polishing :)","created_at":"2018-09-14T18:28:27Z","updated_at":"2018-09-14T18:28:27Z","html_url":"https://github.com/Microsoft/msbuild/pull/3743#discussion_r217803381","pull_request_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3743","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/217803381"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/3743#discussion_r217803381"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3743"}},"in_reply_to_id":217590800},"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3743","id":215455077,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDU1MDc3","html_url":"https://github.com/Microsoft/msbuild/pull/3743","diff_url":"https://github.com/Microsoft/msbuild/pull/3743.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/3743.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/3743","number":3743,"state":"open","locked":false,"title":"Update static-graph spec","user":{"login":"cdmihai","id":2255729,"node_id":"MDQ6VXNlcjIyNTU3Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2255729?v=4","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"body":"We're replacing export targets with the more generic mechanism of explicit project reference protocols. There were a couple of problems with export targets:\r\n- required the child projects to know about all the possible targets that any parent can call them with.\r\n- some export targets could have bad effects when run together (e.g. Build and Clean)\r\n- inefficient to run all export targets when only a small subset is actually needed\r\n\r\n\r\n","created_at":"2018-09-14T01:01:31Z","updated_at":"2018-09-14T18:28:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eea4a7a4d4f8652a1eb4d33268a5e475aaee3ee6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yash256","id":2836929,"node_id":"MDQ6VXNlcjI4MzY5Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/2836929?v=4","gravatar_id":"","url":"https://api.github.com/users/yash256","html_url":"https://github.com/yash256","followers_url":"https://api.github.com/users/yash256/followers","following_url":"https://api.github.com/users/yash256/following{/other_user}","gists_url":"https://api.github.com/users/yash256/gists{/gist_id}","starred_url":"https://api.github.com/users/yash256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yash256/subscriptions","organizations_url":"https://api.github.com/users/yash256/orgs","repos_url":"https://api.github.com/users/yash256/repos","events_url":"https://api.github.com/users/yash256/events{/privacy}","received_events_url":"https://api.github.com/users/yash256/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3743/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3743/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/3743/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/37eff970aa4354b1fc19ba07580dc6e154fcaca2","head":{"label":"cdmihai:graphSpec","ref":"graphSpec","sha":"37eff970aa4354b1fc19ba07580dc6e154fcaca2","user":{"login":"cdmihai","id":2255729,"node_id":"MDQ6VXNlcjIyNTU3Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2255729?v=4","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"repo":{"id":43783196,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc4MzE5Ng==","name":"msbuild","full_name":"cdmihai/msbuild","owner":{"login":"cdmihai","id":2255729,"node_id":"MDQ6VXNlcjIyNTU3Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2255729?v=4","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdmihai/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/cdmihai/msbuild","forks_url":"https://api.github.com/repos/cdmihai/msbuild/forks","keys_url":"https://api.github.com/repos/cdmihai/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdmihai/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdmihai/msbuild/teams","hooks_url":"https://api.github.com/repos/cdmihai/msbuild/hooks","issue_events_url":"https://api.github.com/repos/cdmihai/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/cdmihai/msbuild/events","assignees_url":"https://api.github.com/repos/cdmihai/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/cdmihai/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/cdmihai/msbuild/tags","blobs_url":"https://api.github.com/repos/cdmihai/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdmihai/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdmihai/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdmihai/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdmihai/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/cdmihai/msbuild/languages","stargazers_url":"https://api.github.com/repos/cdmihai/msbuild/stargazers","contributors_url":"https://api.github.com/repos/cdmihai/msbuild/contributors","subscribers_url":"https://api.github.com/repos/cdmihai/msbuild/subscribers","subscription_url":"https://api.github.com/repos/cdmihai/msbuild/subscription","commits_url":"https://api.github.com/repos/cdmihai/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdmihai/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdmihai/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdmihai/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdmihai/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/cdmihai/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdmihai/msbuild/merges","archive_url":"https://api.github.com/repos/cdmihai/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdmihai/msbuild/downloads","issues_url":"https://api.github.com/repos/cdmihai/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/cdmihai/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/cdmihai/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/cdmihai/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdmihai/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/cdmihai/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/cdmihai/msbuild/deployments","created_at":"2015-10-06T22:47:50Z","updated_at":"2018-09-13T18:22:44Z","pushed_at":"2018-09-14T01:14:59Z","git_url":"git://github.com/cdmihai/msbuild.git","ssh_url":"git@github.com:cdmihai/msbuild.git","clone_url":"https://github.com/cdmihai/msbuild.git","svn_url":"https://github.com/cdmihai/msbuild","homepage":null,"size":32566,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"3b3c3ea645cc529120c762cf2a8504ff960f7fb2","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"node_id":"MDEwOlJlcG9zaXRvcnkzMjA1MTg5MA==","name":"msbuild","full_name":"Microsoft/msbuild","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2018-09-14T13:55:58Z","pushed_at":"2018-09-14T17:40:03Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":32017,"stargazers_count":3607,"watchers_count":3607,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":810,"mirror_url":null,"archived":false,"open_issues_count":927,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":810,"open_issues":927,"watchers":3607,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3743"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/3743"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/3743"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/3743/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3743/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3743/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/37eff970aa4354b1fc19ba07580dc6e154fcaca2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dfederm"}}