{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3cluster/pulls/comments/173490242","pull_request_review_id":102695303,"id":173490242,"diff_hunk":"@@ -414,12 +414,11 @@ type Options interface {\n type ShardStateType int","path":"placement/types.go","position":null,"original_position":1,"commit_id":"c5651760e157c719db09f744c3fe470cb01f46c1","original_commit_id":"c5651760e157c719db09f744c3fe470cb01f46c1","user":{"login":"cw9","id":6710599,"avatar_url":"https://avatars0.githubusercontent.com/u/6710599?v=4","gravatar_id":"","url":"https://api.github.com/users/cw9","html_url":"https://github.com/cw9","followers_url":"https://api.github.com/users/cw9/followers","following_url":"https://api.github.com/users/cw9/following{/other_user}","gists_url":"https://api.github.com/users/cw9/gists{/gist_id}","starred_url":"https://api.github.com/users/cw9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw9/subscriptions","organizations_url":"https://api.github.com/users/cw9/orgs","repos_url":"https://api.github.com/users/cw9/repos","events_url":"https://api.github.com/users/cw9/events{/privacy}","received_events_url":"https://api.github.com/users/cw9/received_events","type":"User","site_admin":false},"body":"I think PlacementMode sounds better, also we can do StableShardStateOnly and AllowTransitionalShardStates for the enums","created_at":"2018-03-09T15:59:15Z","updated_at":"2018-03-09T15:59:15Z","html_url":"https://github.com/m3db/m3cluster/pull/205#discussion_r173490242","pull_request_url":"https://api.github.com/repos/m3db/m3cluster/pulls/205","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/comments/173490242"},"html":{"href":"https://github.com/m3db/m3cluster/pull/205#discussion_r173490242"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/205"}},"in_reply_to_id":173488832},"pull_request":{"url":"https://api.github.com/repos/m3db/m3cluster/pulls/205","id":173573048,"html_url":"https://github.com/m3db/m3cluster/pull/205","diff_url":"https://github.com/m3db/m3cluster/pull/205.diff","patch_url":"https://github.com/m3db/m3cluster/pull/205.patch","issue_url":"https://api.github.com/repos/m3db/m3cluster/issues/205","number":205,"state":"open","locked":false,"title":"Add an option to control the shard states in the placement","user":{"login":"cw9","id":6710599,"avatar_url":"https://avatars0.githubusercontent.com/u/6710599?v=4","gravatar_id":"","url":"https://api.github.com/users/cw9","html_url":"https://github.com/cw9","followers_url":"https://api.github.com/users/cw9/followers","following_url":"https://api.github.com/users/cw9/following{/other_user}","gists_url":"https://api.github.com/users/cw9/gists{/gist_id}","starred_url":"https://api.github.com/users/cw9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw9/subscriptions","organizations_url":"https://api.github.com/users/cw9/orgs","repos_url":"https://api.github.com/users/cw9/repos","events_url":"https://api.github.com/users/cw9/events{/privacy}","received_events_url":"https://api.github.com/users/cw9/received_events","type":"User","site_admin":false},"body":"1, Added ShardStateType in placement/types.go: \r\n- By default we will use TransitionShardState, which includes Initializing, Available, Leaving states, for M3DB and M3Agg\r\n- SimpleShardState will only have shards in Available state, can be used by the cache or indexer\r\n\r\n2, Algo will pick up the new option in tryCleanupShardState()\r\n\r\n@xichen2020 @robskillington ","created_at":"2018-03-07T21:05:26Z","updated_at":"2018-03-09T15:59:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44f3c7a250988d2113ed96aab50fb2332f9c1596","assignee":null,"assignees":[],"requested_reviewers":[{"login":"robskillington","id":339615,"avatar_url":"https://avatars1.githubusercontent.com/u/339615?v=4","gravatar_id":"","url":"https://api.github.com/users/robskillington","html_url":"https://github.com/robskillington","followers_url":"https://api.github.com/users/robskillington/followers","following_url":"https://api.github.com/users/robskillington/following{/other_user}","gists_url":"https://api.github.com/users/robskillington/gists{/gist_id}","starred_url":"https://api.github.com/users/robskillington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robskillington/subscriptions","organizations_url":"https://api.github.com/users/robskillington/orgs","repos_url":"https://api.github.com/users/robskillington/repos","events_url":"https://api.github.com/users/robskillington/events{/privacy}","received_events_url":"https://api.github.com/users/robskillington/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3cluster/pulls/205/commits","review_comments_url":"https://api.github.com/repos/m3db/m3cluster/pulls/205/comments","review_comment_url":"https://api.github.com/repos/m3db/m3cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3cluster/issues/205/comments","statuses_url":"https://api.github.com/repos/m3db/m3cluster/statuses/c5651760e157c719db09f744c3fe470cb01f46c1","head":{"label":"m3db:chao-only-available","ref":"chao-only-available","sha":"c5651760e157c719db09f744c3fe470cb01f46c1","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":64314919,"name":"m3cluster","full_name":"m3db/m3cluster","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3cluster","description":"Cluster management (service discovery, runtime config distribution) supporting pluggable backends","fork":false,"url":"https://api.github.com/repos/m3db/m3cluster","forks_url":"https://api.github.com/repos/m3db/m3cluster/forks","keys_url":"https://api.github.com/repos/m3db/m3cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3cluster/teams","hooks_url":"https://api.github.com/repos/m3db/m3cluster/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3cluster/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3cluster/events","assignees_url":"https://api.github.com/repos/m3db/m3cluster/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3cluster/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3cluster/tags","blobs_url":"https://api.github.com/repos/m3db/m3cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3cluster/languages","stargazers_url":"https://api.github.com/repos/m3db/m3cluster/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3cluster/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3cluster/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3cluster/subscription","commits_url":"https://api.github.com/repos/m3db/m3cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3cluster/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3cluster/merges","archive_url":"https://api.github.com/repos/m3db/m3cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3cluster/downloads","issues_url":"https://api.github.com/repos/m3db/m3cluster/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3cluster/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3cluster/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3cluster/deployments","created_at":"2016-07-27T14:22:38Z","updated_at":"2017-12-24T00:28:36Z","pushed_at":"2018-03-09T05:29:45Z","git_url":"git://github.com/m3db/m3cluster.git","ssh_url":"git@github.com:m3db/m3cluster.git","clone_url":"https://github.com/m3db/m3cluster.git","svn_url":"https://github.com/m3db/m3cluster","homepage":"","size":806,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":10,"watchers":10,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"ad2a30b9cd393847178bf55b46819ac211316f87","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":64314919,"name":"m3cluster","full_name":"m3db/m3cluster","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3cluster","description":"Cluster management (service discovery, runtime config distribution) supporting pluggable backends","fork":false,"url":"https://api.github.com/repos/m3db/m3cluster","forks_url":"https://api.github.com/repos/m3db/m3cluster/forks","keys_url":"https://api.github.com/repos/m3db/m3cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3cluster/teams","hooks_url":"https://api.github.com/repos/m3db/m3cluster/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3cluster/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3cluster/events","assignees_url":"https://api.github.com/repos/m3db/m3cluster/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3cluster/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3cluster/tags","blobs_url":"https://api.github.com/repos/m3db/m3cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3cluster/languages","stargazers_url":"https://api.github.com/repos/m3db/m3cluster/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3cluster/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3cluster/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3cluster/subscription","commits_url":"https://api.github.com/repos/m3db/m3cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3cluster/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3cluster/merges","archive_url":"https://api.github.com/repos/m3db/m3cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3cluster/downloads","issues_url":"https://api.github.com/repos/m3db/m3cluster/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3cluster/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3cluster/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3cluster/deployments","created_at":"2016-07-27T14:22:38Z","updated_at":"2017-12-24T00:28:36Z","pushed_at":"2018-03-09T05:29:45Z","git_url":"git://github.com/m3db/m3cluster.git","ssh_url":"git@github.com:m3db/m3cluster.git","clone_url":"https://github.com/m3db/m3cluster.git","svn_url":"https://github.com/m3db/m3cluster","homepage":"","size":806,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":10,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/205"},"html":{"href":"https://github.com/m3db/m3cluster/pull/205"},"issue":{"href":"https://api.github.com/repos/m3db/m3cluster/issues/205"},"comments":{"href":"https://api.github.com/repos/m3db/m3cluster/issues/205/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/205/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/205/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3cluster/statuses/c5651760e157c719db09f744c3fe470cb01f46c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cw9"}}