{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8590","repository_url":"https://api.github.com/repos/openshift/openshift-ansible","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8590/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8590/comments","events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8590/events","html_url":"https://github.com/openshift/openshift-ansible/pull/8590","id":328298534,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODc0OTAx","number":8590,"title":"Support setting dns_domain in inventory","user":{"login":"reneklootwijk","id":915437,"node_id":"MDQ6VXNlcjkxNTQzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/915437?v=4","gravatar_id":"","url":"https://api.github.com/users/reneklootwijk","html_url":"https://github.com/reneklootwijk","followers_url":"https://api.github.com/users/reneklootwijk/followers","following_url":"https://api.github.com/users/reneklootwijk/following{/other_user}","gists_url":"https://api.github.com/users/reneklootwijk/gists{/gist_id}","starred_url":"https://api.github.com/users/reneklootwijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reneklootwijk/subscriptions","organizations_url":"https://api.github.com/users/reneklootwijk/orgs","repos_url":"https://api.github.com/users/reneklootwijk/repos","events_url":"https://api.github.com/users/reneklootwijk/events{/privacy}","received_events_url":"https://api.github.com/users/reneklootwijk/received_events","type":"User","site_admin":false},"labels":[{"id":681633081,"node_id":"MDU6TGFiZWw2ODE2MzMwODE=","url":"https://api.github.com/repos/openshift/openshift-ansible/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"reneklootwijk","id":915437,"node_id":"MDQ6VXNlcjkxNTQzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/915437?v=4","gravatar_id":"","url":"https://api.github.com/users/reneklootwijk","html_url":"https://github.com/reneklootwijk","followers_url":"https://api.github.com/users/reneklootwijk/followers","following_url":"https://api.github.com/users/reneklootwijk/following{/other_user}","gists_url":"https://api.github.com/users/reneklootwijk/gists{/gist_id}","starred_url":"https://api.github.com/users/reneklootwijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reneklootwijk/subscriptions","organizations_url":"https://api.github.com/users/reneklootwijk/orgs","repos_url":"https://api.github.com/users/reneklootwijk/repos","events_url":"https://api.github.com/users/reneklootwijk/events{/privacy}","received_events_url":"https://api.github.com/users/reneklootwijk/received_events","type":"User","site_admin":false},"assignees":[{"login":"reneklootwijk","id":915437,"node_id":"MDQ6VXNlcjkxNTQzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/915437?v=4","gravatar_id":"","url":"https://api.github.com/users/reneklootwijk","html_url":"https://github.com/reneklootwijk","followers_url":"https://api.github.com/users/reneklootwijk/followers","following_url":"https://api.github.com/users/reneklootwijk/following{/other_user}","gists_url":"https://api.github.com/users/reneklootwijk/gists{/gist_id}","starred_url":"https://api.github.com/users/reneklootwijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reneklootwijk/subscriptions","organizations_url":"https://api.github.com/users/reneklootwijk/orgs","repos_url":"https://api.github.com/users/reneklootwijk/repos","events_url":"https://api.github.com/users/reneklootwijk/events{/privacy}","received_events_url":"https://api.github.com/users/reneklootwijk/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-05-31T21:10:36Z","updated_at":"2018-06-11T18:34:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/8590","html_url":"https://github.com/openshift/openshift-ansible/pull/8590","diff_url":"https://github.com/openshift/openshift-ansible/pull/8590.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/8590.patch"},"body":"This pull requests makes the changes required to be able to change the cluster domain of a local installation from the default cluster.local to something you specify in the Ansible inventory file using the dns_domain parameter.\r\n\r\nThe pull request consists of two changes:\r\n1. Added setting the local fact openshift.common.dns_domain based on the dns_domain variable in the inventory OSEv3:vars section.\r\n2. Changed the network manager configuration task from copying a configuration file to creating a configuration file based on a template. This will eventually create a /etc/resolv.conf containing the correct search domain instead of using hardcoded cluster.local"},"comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments/396342276","html_url":"https://github.com/openshift/openshift-ansible/pull/8590#issuecomment-396342276","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8590","id":396342276,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjM0MjI3Ng==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T18:34:43Z","updated_at":"2018-06-11T18:34:43Z","author_association":"NONE","body":"@reneklootwijk: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/openshift-jenkins/gcp | 215086e3a9e192dd31a98b9962e3d6905ad8b588 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/8590/test_pull_request_openshift_ansible_extended_conformance_gce_39/368/) | `/test gcp`\nci/openshift-jenkins/logging | 215086e3a9e192dd31a98b9962e3d6905ad8b588 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/8590/test_pull_request_openshift_ansible_logging_39/403/) | `/test logging`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/openshift_openshift-ansible/8590). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/reneklootwijk). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/openshift-ansible/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}