{"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments/165821986","pull_request_review_id":93823974,"id":165821986,"diff_hunk":"@@ -25,6 +25,48 @@ class StitchCoreTests: XCTestCase {\n     }\n \n \n+    func testMultipleClientStorage() throws {\n+        let exp = expectation(description: \"multiple clients should store separately\")\n+\n+        let creators = [StitchClientFactory.create(appId: \"test1\"),\n+                        StitchClientFactory.create(appId: \"test2\")]\n+\n+        when(resolved: creators).done { (results: [Result<StitchClient>]) in\n+            guard case .fulfilled(let sc1) = results[0],\n+                  case .fulfilled(let sc2) = results[1] else {\n+                XCTFail(\"multiple clients could not be created\")\n+                exp.fulfill()\n+                return\n+            }\n+\n+            sc1.storage.set(\"foo\", forKey: \"fizz\")\n+            sc2.storage.set(\"bar\", forKey: \"fizz\")\n+\n+            XCTAssertEqual(sc1.storage.value(forKey: \"fizz\") as? String, \"foo\")\n+            XCTAssertEqual(sc2.storage.value(forKey: \"fizz\") as? String, \"bar\")\n+            exp.fulfill()\n+        }\n+\n+        wait(for: [exp], timeout: 10)\n+    }\n+\n+    func testMigrationLogic() throws {\n+        let exp = expectation(description: \"multiple clients should store separately\")","path":"StitchCore/StitchCoreTests/StitchCoreTests.swift","position":30,"original_position":30,"commit_id":"337605a9ee1c3b88345612eb9b6f17343fb51086","original_commit_id":"337605a9ee1c3b88345612eb9b6f17343fb51086","user":{"login":"jsflax","id":4356928,"avatar_url":"https://avatars3.githubusercontent.com/u/4356928?v=4","gravatar_id":"","url":"https://api.github.com/users/jsflax","html_url":"https://github.com/jsflax","followers_url":"https://api.github.com/users/jsflax/followers","following_url":"https://api.github.com/users/jsflax/following{/other_user}","gists_url":"https://api.github.com/users/jsflax/gists{/gist_id}","starred_url":"https://api.github.com/users/jsflax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsflax/subscriptions","organizations_url":"https://api.github.com/users/jsflax/orgs","repos_url":"https://api.github.com/users/jsflax/repos","events_url":"https://api.github.com/users/jsflax/events{/privacy}","received_events_url":"https://api.github.com/users/jsflax/received_events","type":"User","site_admin":false},"body":"Good catch.","created_at":"2018-02-03T18:45:33Z","updated_at":"2018-02-03T18:45:33Z","html_url":"https://github.com/mongodb/stitch-ios-sdk/pull/29#discussion_r165821986","pull_request_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/29","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments/165821986"},"html":{"href":"https://github.com/mongodb/stitch-ios-sdk/pull/29#discussion_r165821986"},"pull_request":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/29"}},"in_reply_to_id":165688295},"pull_request":{"url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/29","id":163784360,"html_url":"https://github.com/mongodb/stitch-ios-sdk/pull/29","diff_url":"https://github.com/mongodb/stitch-ios-sdk/pull/29.diff","patch_url":"https://github.com/mongodb/stitch-ios-sdk/pull/29.patch","issue_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/29","number":29,"state":"open","locked":false,"title":"iOS SDK: Namespace local storage of auth info by client app ID","user":{"login":"jsflax","id":4356928,"avatar_url":"https://avatars3.githubusercontent.com/u/4356928?v=4","gravatar_id":"","url":"https://api.github.com/users/jsflax","html_url":"https://github.com/jsflax","followers_url":"https://api.github.com/users/jsflax/followers","following_url":"https://api.github.com/users/jsflax/following{/other_user}","gists_url":"https://api.github.com/users/jsflax/gists{/gist_id}","starred_url":"https://api.github.com/users/jsflax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsflax/subscriptions","organizations_url":"https://api.github.com/users/jsflax/orgs","repos_url":"https://api.github.com/users/jsflax/repos","events_url":"https://api.github.com/users/jsflax/events{/privacy}","received_events_url":"https://api.github.com/users/jsflax/received_events","type":"User","site_admin":false},"body":"Note: This does not include the migration. If we wish to include the migration, please update the JIRA ticket.","created_at":"2018-01-18T18:13:07Z","updated_at":"2018-02-03T18:45:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"202ce9ece8d94a1cf8a842f1a30a669a9fac4de2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/29/commits","review_comments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/29/comments","review_comment_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/29/comments","statuses_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/statuses/337605a9ee1c3b88345612eb9b6f17343fb51086","head":{"label":"jsflax:STITCH-1038","ref":"STITCH-1038","sha":"337605a9ee1c3b88345612eb9b6f17343fb51086","user":{"login":"jsflax","id":4356928,"avatar_url":"https://avatars3.githubusercontent.com/u/4356928?v=4","gravatar_id":"","url":"https://api.github.com/users/jsflax","html_url":"https://github.com/jsflax","followers_url":"https://api.github.com/users/jsflax/followers","following_url":"https://api.github.com/users/jsflax/following{/other_user}","gists_url":"https://api.github.com/users/jsflax/gists{/gist_id}","starred_url":"https://api.github.com/users/jsflax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsflax/subscriptions","organizations_url":"https://api.github.com/users/jsflax/orgs","repos_url":"https://api.github.com/users/jsflax/repos","events_url":"https://api.github.com/users/jsflax/events{/privacy}","received_events_url":"https://api.github.com/users/jsflax/received_events","type":"User","site_admin":false},"repo":{"id":110735788,"name":"stitch-ios-sdk","full_name":"jsflax/stitch-ios-sdk","owner":{"login":"jsflax","id":4356928,"avatar_url":"https://avatars3.githubusercontent.com/u/4356928?v=4","gravatar_id":"","url":"https://api.github.com/users/jsflax","html_url":"https://github.com/jsflax","followers_url":"https://api.github.com/users/jsflax/followers","following_url":"https://api.github.com/users/jsflax/following{/other_user}","gists_url":"https://api.github.com/users/jsflax/gists{/gist_id}","starred_url":"https://api.github.com/users/jsflax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsflax/subscriptions","organizations_url":"https://api.github.com/users/jsflax/orgs","repos_url":"https://api.github.com/users/jsflax/repos","events_url":"https://api.github.com/users/jsflax/events{/privacy}","received_events_url":"https://api.github.com/users/jsflax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsflax/stitch-ios-sdk","description":null,"fork":true,"url":"https://api.github.com/repos/jsflax/stitch-ios-sdk","forks_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/forks","keys_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/teams","hooks_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/events","assignees_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/tags","blobs_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/subscription","commits_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/merges","archive_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/downloads","issues_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/deployments","created_at":"2017-11-14T19:35:26Z","updated_at":"2017-11-14T19:35:28Z","pushed_at":"2018-02-01T21:31:36Z","git_url":"git://github.com/jsflax/stitch-ios-sdk.git","ssh_url":"git@github.com:jsflax/stitch-ios-sdk.git","clone_url":"https://github.com/jsflax/stitch-ios-sdk.git","svn_url":"https://github.com/jsflax/stitch-ios-sdk","homepage":null,"size":31002,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mongodb:master","ref":"master","sha":"37a5f7d1dec608cb12c036bf028fd3027cbe98b8","user":{"login":"mongodb","id":45120,"avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":93444591,"name":"stitch-ios-sdk","full_name":"mongodb/stitch-ios-sdk","owner":{"login":"mongodb","id":45120,"avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mongodb/stitch-ios-sdk","description":null,"fork":false,"url":"https://api.github.com/repos/mongodb/stitch-ios-sdk","forks_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/forks","keys_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/teams","hooks_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/events","assignees_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/tags","blobs_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/subscription","commits_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/merges","archive_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/downloads","issues_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/deployments","created_at":"2017-06-05T20:37:29Z","updated_at":"2018-01-25T22:17:51Z","pushed_at":"2018-02-02T18:09:21Z","git_url":"git://github.com/mongodb/stitch-ios-sdk.git","ssh_url":"git@github.com:mongodb/stitch-ios-sdk.git","clone_url":"https://github.com/mongodb/stitch-ios-sdk.git","svn_url":"https://github.com/mongodb/stitch-ios-sdk","homepage":null,"size":26669,"stargazers_count":6,"watchers_count":6,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/29"},"html":{"href":"https://github.com/mongodb/stitch-ios-sdk/pull/29"},"issue":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/29"},"comments":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/statuses/337605a9ee1c3b88345612eb9b6f17343fb51086"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jsflax"}}