{"action":"created","comment":{"url":"https://api.github.com/repos/m-kuhn/QGIS/pulls/comments/219803442","pull_request_review_id":158062206,"id":219803442,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTgwMzQ0Mg==","diff_hunk":"@@ -62,6 +62,27 @@ class QgsGeometryCheckFactoryT : public QgsGeometryCheckFactory\n     {\n       return new T( context, geometryCheckConfiguration );\n     }\n+\n+    QString name() const override\n+    {\n+      return static_cast<T>( 0 ).errorDescription();","path":"src/analysis/vector/geometry_checker/qgsgeometrycheckfactory.h","position":25,"original_position":25,"commit_id":"73c89aee8c2f5ca6d2ce5a621b1ffad9f08bba02","original_commit_id":"73c89aee8c2f5ca6d2ce5a621b1ffad9f08bba02","user":{"login":"3nids","id":127259,"node_id":"MDQ6VXNlcjEyNzI1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/127259?v=4","gravatar_id":"","url":"https://api.github.com/users/3nids","html_url":"https://github.com/3nids","followers_url":"https://api.github.com/users/3nids/followers","following_url":"https://api.github.com/users/3nids/following{/other_user}","gists_url":"https://api.github.com/users/3nids/gists{/gist_id}","starred_url":"https://api.github.com/users/3nids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3nids/subscriptions","organizations_url":"https://api.github.com/users/3nids/orgs","repos_url":"https://api.github.com/users/3nids/repos","events_url":"https://api.github.com/users/3nids/events{/privacy}","received_events_url":"https://api.github.com/users/3nids/received_events","type":"User","site_admin":false},"body":"well you're the computer guy ;)\r\nThe pointer was failiing with reinterpret_cast but I think I did not try with static_cast.\r\n","created_at":"2018-09-24T11:30:04Z","updated_at":"2018-09-24T11:30:04Z","html_url":"https://github.com/m-kuhn/QGIS/pull/53#discussion_r219803442","pull_request_url":"https://api.github.com/repos/m-kuhn/QGIS/pulls/53","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/m-kuhn/QGIS/pulls/comments/219803442"},"html":{"href":"https://github.com/m-kuhn/QGIS/pull/53#discussion_r219803442"},"pull_request":{"href":"https://api.github.com/repos/m-kuhn/QGIS/pulls/53"}},"in_reply_to_id":219773394},"pull_request":{"url":"https://api.github.com/repos/m-kuhn/QGIS/pulls/53","id":217320847,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzIwODQ3","html_url":"https://github.com/m-kuhn/QGIS/pull/53","diff_url":"https://github.com/m-kuhn/QGIS/pull/53.diff","patch_url":"https://github.com/m-kuhn/QGIS/pull/53.patch","issue_url":"https://api.github.com/repos/m-kuhn/QGIS/issues/53","number":53,"state":"open","locked":false,"title":"Geometry validator code","user":{"login":"3nids","id":127259,"node_id":"MDQ6VXNlcjEyNzI1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/127259?v=4","gravatar_id":"","url":"https://api.github.com/users/3nids","html_url":"https://github.com/3nids","followers_url":"https://api.github.com/users/3nids/followers","following_url":"https://api.github.com/users/3nids/following{/other_user}","gists_url":"https://api.github.com/users/3nids/gists{/gist_id}","starred_url":"https://api.github.com/users/3nids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3nids/subscriptions","organizations_url":"https://api.github.com/users/3nids/orgs","repos_url":"https://api.github.com/users/3nids/repos","events_url":"https://api.github.com/users/3nids/events{/privacy}","received_events_url":"https://api.github.com/users/3nids/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-21T15:27:31Z","updated_at":"2018-09-24T11:30:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dbf331186f97715df92703c7a4133a29b9237e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m-kuhn/QGIS/pulls/53/commits","review_comments_url":"https://api.github.com/repos/m-kuhn/QGIS/pulls/53/comments","review_comment_url":"https://api.github.com/repos/m-kuhn/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m-kuhn/QGIS/issues/53/comments","statuses_url":"https://api.github.com/repos/m-kuhn/QGIS/statuses/73c89aee8c2f5ca6d2ce5a621b1ffad9f08bba02","head":{"label":"3nids:geometryValidatorCode","ref":"geometryValidatorCode","sha":"73c89aee8c2f5ca6d2ce5a621b1ffad9f08bba02","user":{"login":"3nids","id":127259,"node_id":"MDQ6VXNlcjEyNzI1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/127259?v=4","gravatar_id":"","url":"https://api.github.com/users/3nids","html_url":"https://github.com/3nids","followers_url":"https://api.github.com/users/3nids/followers","following_url":"https://api.github.com/users/3nids/following{/other_user}","gists_url":"https://api.github.com/users/3nids/gists{/gist_id}","starred_url":"https://api.github.com/users/3nids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3nids/subscriptions","organizations_url":"https://api.github.com/users/3nids/orgs","repos_url":"https://api.github.com/users/3nids/repos","events_url":"https://api.github.com/users/3nids/events{/privacy}","received_events_url":"https://api.github.com/users/3nids/received_events","type":"User","site_admin":false},"repo":{"id":7640359,"node_id":"MDEwOlJlcG9zaXRvcnk3NjQwMzU5","name":"QGIS","full_name":"3nids/QGIS","private":false,"owner":{"login":"3nids","id":127259,"node_id":"MDQ6VXNlcjEyNzI1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/127259?v=4","gravatar_id":"","url":"https://api.github.com/users/3nids","html_url":"https://github.com/3nids","followers_url":"https://api.github.com/users/3nids/followers","following_url":"https://api.github.com/users/3nids/following{/other_user}","gists_url":"https://api.github.com/users/3nids/gists{/gist_id}","starred_url":"https://api.github.com/users/3nids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3nids/subscriptions","organizations_url":"https://api.github.com/users/3nids/orgs","repos_url":"https://api.github.com/users/3nids/repos","events_url":"https://api.github.com/users/3nids/events{/privacy}","received_events_url":"https://api.github.com/users/3nids/received_events","type":"User","site_admin":false},"html_url":"https://github.com/3nids/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/3nids/QGIS","forks_url":"https://api.github.com/repos/3nids/QGIS/forks","keys_url":"https://api.github.com/repos/3nids/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3nids/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3nids/QGIS/teams","hooks_url":"https://api.github.com/repos/3nids/QGIS/hooks","issue_events_url":"https://api.github.com/repos/3nids/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/3nids/QGIS/events","assignees_url":"https://api.github.com/repos/3nids/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/3nids/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/3nids/QGIS/tags","blobs_url":"https://api.github.com/repos/3nids/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3nids/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3nids/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/3nids/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3nids/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/3nids/QGIS/languages","stargazers_url":"https://api.github.com/repos/3nids/QGIS/stargazers","contributors_url":"https://api.github.com/repos/3nids/QGIS/contributors","subscribers_url":"https://api.github.com/repos/3nids/QGIS/subscribers","subscription_url":"https://api.github.com/repos/3nids/QGIS/subscription","commits_url":"https://api.github.com/repos/3nids/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/3nids/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/3nids/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/3nids/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/3nids/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/3nids/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3nids/QGIS/merges","archive_url":"https://api.github.com/repos/3nids/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3nids/QGIS/downloads","issues_url":"https://api.github.com/repos/3nids/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/3nids/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/3nids/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/3nids/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3nids/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/3nids/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/3nids/QGIS/deployments","created_at":"2013-01-16T06:16:23Z","updated_at":"2018-09-07T15:17:53Z","pushed_at":"2018-09-21T15:25:13Z","git_url":"git://github.com/3nids/QGIS.git","ssh_url":"git@github.com:3nids/QGIS.git","clone_url":"https://github.com/3nids/QGIS.git","svn_url":"https://github.com/3nids/QGIS","homepage":"http://qgis.org","size":1314130,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"m-kuhn:geometryValidatorCode","ref":"geometryValidatorCode","sha":"b27e52df9fe44197b9f8b6230f22daf997dd4b80","user":{"login":"m-kuhn","id":588407,"node_id":"MDQ6VXNlcjU4ODQwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/588407?v=4","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"repo":{"id":5270567,"node_id":"MDEwOlJlcG9zaXRvcnk1MjcwNTY3","name":"QGIS","full_name":"m-kuhn/QGIS","private":false,"owner":{"login":"m-kuhn","id":588407,"node_id":"MDQ6VXNlcjU4ODQwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/588407?v=4","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/m-kuhn/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/m-kuhn/QGIS","forks_url":"https://api.github.com/repos/m-kuhn/QGIS/forks","keys_url":"https://api.github.com/repos/m-kuhn/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-kuhn/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-kuhn/QGIS/teams","hooks_url":"https://api.github.com/repos/m-kuhn/QGIS/hooks","issue_events_url":"https://api.github.com/repos/m-kuhn/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/m-kuhn/QGIS/events","assignees_url":"https://api.github.com/repos/m-kuhn/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/m-kuhn/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/m-kuhn/QGIS/tags","blobs_url":"https://api.github.com/repos/m-kuhn/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-kuhn/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-kuhn/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-kuhn/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-kuhn/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/m-kuhn/QGIS/languages","stargazers_url":"https://api.github.com/repos/m-kuhn/QGIS/stargazers","contributors_url":"https://api.github.com/repos/m-kuhn/QGIS/contributors","subscribers_url":"https://api.github.com/repos/m-kuhn/QGIS/subscribers","subscription_url":"https://api.github.com/repos/m-kuhn/QGIS/subscription","commits_url":"https://api.github.com/repos/m-kuhn/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-kuhn/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-kuhn/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-kuhn/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-kuhn/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/m-kuhn/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-kuhn/QGIS/merges","archive_url":"https://api.github.com/repos/m-kuhn/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-kuhn/QGIS/downloads","issues_url":"https://api.github.com/repos/m-kuhn/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/m-kuhn/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/m-kuhn/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/m-kuhn/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-kuhn/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/m-kuhn/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/m-kuhn/QGIS/deployments","created_at":"2012-08-02T09:19:28Z","updated_at":"2018-06-21T10:11:36Z","pushed_at":"2018-09-24T05:44:29Z","git_url":"git://github.com/m-kuhn/QGIS.git","ssh_url":"git@github.com:m-kuhn/QGIS.git","clone_url":"https://github.com/m-kuhn/QGIS.git","svn_url":"https://github.com/m-kuhn/QGIS","homepage":"http://qgis.org","size":1390115,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":23,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m-kuhn/QGIS/pulls/53"},"html":{"href":"https://github.com/m-kuhn/QGIS/pull/53"},"issue":{"href":"https://api.github.com/repos/m-kuhn/QGIS/issues/53"},"comments":{"href":"https://api.github.com/repos/m-kuhn/QGIS/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/m-kuhn/QGIS/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/m-kuhn/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m-kuhn/QGIS/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/m-kuhn/QGIS/statuses/73c89aee8c2f5ca6d2ce5a621b1ffad9f08bba02"}},"author_association":"NONE"}}
{"actor":{"display_login":"3nids"}}