{"action":"created","comment":{"url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/comments/232107287","pull_request_review_id":173230854,"id":232107287,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjEwNzI4Nw==","diff_hunk":"@@ -152,10 +152,8 @@ def GetDscLibrarys (self, BuildPkgName = \"BootLoaderCorePkg\"):\n \t\t\t'ShellExtensionLib|Platform/$(BOARD_PKG_NAME)/Library/ShellExtensionLib/ShellExtensionLib.inf',\n \t\t\t'BootMediaLib|Silicon/ApollolakePkg/Library/BootMediaLib/BootMediaLib.inf',\n \t\t\t'FlashDescriptorLib|Silicon/ApollolakePkg/Library/FlashDescriptorLib/FlashDescriptorLib.inf',\n+\t\t\t'VTdLib|Silicon/$(SILICON_PKG_NAME)/Library/VTdLib/VTdLib.inf'","path":"Platform/ApollolakeBoardPkg/BoardConfig.py","position":13,"original_position":13,"commit_id":"84129b739c5320c0f8a8efa55b260f7fc216eb7b","original_commit_id":"84129b739c5320c0f8a8efa55b260f7fc216eb7b","user":{"login":"huang-jin-intel","id":39599800,"node_id":"MDQ6VXNlcjM5NTk5ODAw","avatar_url":"https://avatars2.githubusercontent.com/u/39599800?v=4","gravatar_id":"","url":"https://api.github.com/users/huang-jin-intel","html_url":"https://github.com/huang-jin-intel","followers_url":"https://api.github.com/users/huang-jin-intel/followers","following_url":"https://api.github.com/users/huang-jin-intel/following{/other_user}","gists_url":"https://api.github.com/users/huang-jin-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/huang-jin-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huang-jin-intel/subscriptions","organizations_url":"https://api.github.com/users/huang-jin-intel/orgs","repos_url":"https://api.github.com/users/huang-jin-intel/repos","events_url":"https://api.github.com/users/huang-jin-intel/events{/privacy}","received_events_url":"https://api.github.com/users/huang-jin-intel/received_events","type":"User","site_admin":false},"body":"The camel case really not very expressive but I understand now.","created_at":"2018-11-09T00:18:31Z","updated_at":"2018-11-09T00:18:31Z","html_url":"https://github.com/slimbootloader/slimbootloader/pull/40#discussion_r232107287","pull_request_url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/40","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/comments/232107287"},"html":{"href":"https://github.com/slimbootloader/slimbootloader/pull/40#discussion_r232107287"},"pull_request":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/40"}},"in_reply_to_id":232098902},"pull_request":{"url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/40","id":229536695,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTM2Njk1","html_url":"https://github.com/slimbootloader/slimbootloader/pull/40","diff_url":"https://github.com/slimbootloader/slimbootloader/pull/40.diff","patch_url":"https://github.com/slimbootloader/slimbootloader/pull/40.patch","issue_url":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/40","number":40,"state":"open","locked":false,"title":"Fix a compile error when VTD is disabled on APL","user":{"login":"myguitar","id":11640135,"node_id":"MDQ6VXNlcjExNjQwMTM1","avatar_url":"https://avatars2.githubusercontent.com/u/11640135?v=4","gravatar_id":"","url":"https://api.github.com/users/myguitar","html_url":"https://github.com/myguitar","followers_url":"https://api.github.com/users/myguitar/followers","following_url":"https://api.github.com/users/myguitar/following{/other_user}","gists_url":"https://api.github.com/users/myguitar/gists{/gist_id}","starred_url":"https://api.github.com/users/myguitar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myguitar/subscriptions","organizations_url":"https://api.github.com/users/myguitar/orgs","repos_url":"https://api.github.com/users/myguitar/repos","events_url":"https://api.github.com/users/myguitar/events{/privacy}","received_events_url":"https://api.github.com/users/myguitar/received_events","type":"User","site_admin":false},"body":"When VTD_ENABLE sets to '0', a compile error occurs because some .inf\r\nfiles refer to VtdLib. Therefore, VtdLib is included to default\r\nlibraries - dsc_libs['IA32'].\r\n\r\nAdditionaly,\r\n- Rename VTD_ENABLED to ENABLE_VTD to make feature enabling name\r\n  consistent\r\n- Remove hard-coded UART2 BAR for ACRN\r\n\r\nChange-Id: I22969c0e4509ab0a0dc21d50e6afbdfb893f25a8\r\nSigned-off-by: Aiden Park <aiden.park@intel.com>","created_at":"2018-11-08T23:00:31Z","updated_at":"2018-11-09T00:18:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f151fcdfa95b020998b5235543c078080c435a2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/40/commits","review_comments_url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/40/comments","review_comment_url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/40/comments","statuses_url":"https://api.github.com/repos/slimbootloader/slimbootloader/statuses/84129b739c5320c0f8a8efa55b260f7fc216eb7b","head":{"label":"myguitar:fix_compile_error_with_disabled_vtd","ref":"fix_compile_error_with_disabled_vtd","sha":"84129b739c5320c0f8a8efa55b260f7fc216eb7b","user":{"login":"myguitar","id":11640135,"node_id":"MDQ6VXNlcjExNjQwMTM1","avatar_url":"https://avatars2.githubusercontent.com/u/11640135?v=4","gravatar_id":"","url":"https://api.github.com/users/myguitar","html_url":"https://github.com/myguitar","followers_url":"https://api.github.com/users/myguitar/followers","following_url":"https://api.github.com/users/myguitar/following{/other_user}","gists_url":"https://api.github.com/users/myguitar/gists{/gist_id}","starred_url":"https://api.github.com/users/myguitar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myguitar/subscriptions","organizations_url":"https://api.github.com/users/myguitar/orgs","repos_url":"https://api.github.com/users/myguitar/repos","events_url":"https://api.github.com/users/myguitar/events{/privacy}","received_events_url":"https://api.github.com/users/myguitar/received_events","type":"User","site_admin":false},"repo":{"id":151525113,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1MjUxMTM=","name":"slimbootloader","full_name":"myguitar/slimbootloader","private":false,"owner":{"login":"myguitar","id":11640135,"node_id":"MDQ6VXNlcjExNjQwMTM1","avatar_url":"https://avatars2.githubusercontent.com/u/11640135?v=4","gravatar_id":"","url":"https://api.github.com/users/myguitar","html_url":"https://github.com/myguitar","followers_url":"https://api.github.com/users/myguitar/followers","following_url":"https://api.github.com/users/myguitar/following{/other_user}","gists_url":"https://api.github.com/users/myguitar/gists{/gist_id}","starred_url":"https://api.github.com/users/myguitar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myguitar/subscriptions","organizations_url":"https://api.github.com/users/myguitar/orgs","repos_url":"https://api.github.com/users/myguitar/repos","events_url":"https://api.github.com/users/myguitar/events{/privacy}","received_events_url":"https://api.github.com/users/myguitar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/myguitar/slimbootloader","description":"Visit http://slimbootloader.github.io for documentation","fork":true,"url":"https://api.github.com/repos/myguitar/slimbootloader","forks_url":"https://api.github.com/repos/myguitar/slimbootloader/forks","keys_url":"https://api.github.com/repos/myguitar/slimbootloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/myguitar/slimbootloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/myguitar/slimbootloader/teams","hooks_url":"https://api.github.com/repos/myguitar/slimbootloader/hooks","issue_events_url":"https://api.github.com/repos/myguitar/slimbootloader/issues/events{/number}","events_url":"https://api.github.com/repos/myguitar/slimbootloader/events","assignees_url":"https://api.github.com/repos/myguitar/slimbootloader/assignees{/user}","branches_url":"https://api.github.com/repos/myguitar/slimbootloader/branches{/branch}","tags_url":"https://api.github.com/repos/myguitar/slimbootloader/tags","blobs_url":"https://api.github.com/repos/myguitar/slimbootloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/myguitar/slimbootloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/myguitar/slimbootloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/myguitar/slimbootloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/myguitar/slimbootloader/statuses/{sha}","languages_url":"https://api.github.com/repos/myguitar/slimbootloader/languages","stargazers_url":"https://api.github.com/repos/myguitar/slimbootloader/stargazers","contributors_url":"https://api.github.com/repos/myguitar/slimbootloader/contributors","subscribers_url":"https://api.github.com/repos/myguitar/slimbootloader/subscribers","subscription_url":"https://api.github.com/repos/myguitar/slimbootloader/subscription","commits_url":"https://api.github.com/repos/myguitar/slimbootloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/myguitar/slimbootloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/myguitar/slimbootloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/myguitar/slimbootloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/myguitar/slimbootloader/contents/{+path}","compare_url":"https://api.github.com/repos/myguitar/slimbootloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/myguitar/slimbootloader/merges","archive_url":"https://api.github.com/repos/myguitar/slimbootloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/myguitar/slimbootloader/downloads","issues_url":"https://api.github.com/repos/myguitar/slimbootloader/issues{/number}","pulls_url":"https://api.github.com/repos/myguitar/slimbootloader/pulls{/number}","milestones_url":"https://api.github.com/repos/myguitar/slimbootloader/milestones{/number}","notifications_url":"https://api.github.com/repos/myguitar/slimbootloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/myguitar/slimbootloader/labels{/name}","releases_url":"https://api.github.com/repos/myguitar/slimbootloader/releases{/id}","deployments_url":"https://api.github.com/repos/myguitar/slimbootloader/deployments","created_at":"2018-10-04T05:55:51Z","updated_at":"2018-11-05T19:06:40Z","pushed_at":"2018-11-08T22:59:33Z","git_url":"git://github.com/myguitar/slimbootloader.git","ssh_url":"git@github.com:myguitar/slimbootloader.git","clone_url":"https://github.com/myguitar/slimbootloader.git","svn_url":"https://github.com/myguitar/slimbootloader","homepage":"","size":5668,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slimbootloader:master","ref":"master","sha":"2f2fb8802ecc178dc228c1440ac4773042559de5","user":{"login":"slimbootloader","id":42816226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyODE2MjI2","avatar_url":"https://avatars0.githubusercontent.com/u/42816226?v=4","gravatar_id":"","url":"https://api.github.com/users/slimbootloader","html_url":"https://github.com/slimbootloader","followers_url":"https://api.github.com/users/slimbootloader/followers","following_url":"https://api.github.com/users/slimbootloader/following{/other_user}","gists_url":"https://api.github.com/users/slimbootloader/gists{/gist_id}","starred_url":"https://api.github.com/users/slimbootloader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimbootloader/subscriptions","organizations_url":"https://api.github.com/users/slimbootloader/orgs","repos_url":"https://api.github.com/users/slimbootloader/repos","events_url":"https://api.github.com/users/slimbootloader/events{/privacy}","received_events_url":"https://api.github.com/users/slimbootloader/received_events","type":"Organization","site_admin":false},"repo":{"id":148708107,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3MDgxMDc=","name":"slimbootloader","full_name":"slimbootloader/slimbootloader","private":false,"owner":{"login":"slimbootloader","id":42816226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyODE2MjI2","avatar_url":"https://avatars0.githubusercontent.com/u/42816226?v=4","gravatar_id":"","url":"https://api.github.com/users/slimbootloader","html_url":"https://github.com/slimbootloader","followers_url":"https://api.github.com/users/slimbootloader/followers","following_url":"https://api.github.com/users/slimbootloader/following{/other_user}","gists_url":"https://api.github.com/users/slimbootloader/gists{/gist_id}","starred_url":"https://api.github.com/users/slimbootloader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimbootloader/subscriptions","organizations_url":"https://api.github.com/users/slimbootloader/orgs","repos_url":"https://api.github.com/users/slimbootloader/repos","events_url":"https://api.github.com/users/slimbootloader/events{/privacy}","received_events_url":"https://api.github.com/users/slimbootloader/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/slimbootloader/slimbootloader","description":"Visit http://slimbootloader.github.io for documentation","fork":false,"url":"https://api.github.com/repos/slimbootloader/slimbootloader","forks_url":"https://api.github.com/repos/slimbootloader/slimbootloader/forks","keys_url":"https://api.github.com/repos/slimbootloader/slimbootloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slimbootloader/slimbootloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slimbootloader/slimbootloader/teams","hooks_url":"https://api.github.com/repos/slimbootloader/slimbootloader/hooks","issue_events_url":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/events{/number}","events_url":"https://api.github.com/repos/slimbootloader/slimbootloader/events","assignees_url":"https://api.github.com/repos/slimbootloader/slimbootloader/assignees{/user}","branches_url":"https://api.github.com/repos/slimbootloader/slimbootloader/branches{/branch}","tags_url":"https://api.github.com/repos/slimbootloader/slimbootloader/tags","blobs_url":"https://api.github.com/repos/slimbootloader/slimbootloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slimbootloader/slimbootloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slimbootloader/slimbootloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/slimbootloader/slimbootloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slimbootloader/slimbootloader/statuses/{sha}","languages_url":"https://api.github.com/repos/slimbootloader/slimbootloader/languages","stargazers_url":"https://api.github.com/repos/slimbootloader/slimbootloader/stargazers","contributors_url":"https://api.github.com/repos/slimbootloader/slimbootloader/contributors","subscribers_url":"https://api.github.com/repos/slimbootloader/slimbootloader/subscribers","subscription_url":"https://api.github.com/repos/slimbootloader/slimbootloader/subscription","commits_url":"https://api.github.com/repos/slimbootloader/slimbootloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/slimbootloader/slimbootloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/slimbootloader/slimbootloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/slimbootloader/slimbootloader/contents/{+path}","compare_url":"https://api.github.com/repos/slimbootloader/slimbootloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slimbootloader/slimbootloader/merges","archive_url":"https://api.github.com/repos/slimbootloader/slimbootloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slimbootloader/slimbootloader/downloads","issues_url":"https://api.github.com/repos/slimbootloader/slimbootloader/issues{/number}","pulls_url":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls{/number}","milestones_url":"https://api.github.com/repos/slimbootloader/slimbootloader/milestones{/number}","notifications_url":"https://api.github.com/repos/slimbootloader/slimbootloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slimbootloader/slimbootloader/labels{/name}","releases_url":"https://api.github.com/repos/slimbootloader/slimbootloader/releases{/id}","deployments_url":"https://api.github.com/repos/slimbootloader/slimbootloader/deployments","created_at":"2018-09-13T23:07:33Z","updated_at":"2018-11-07T13:18:35Z","pushed_at":"2018-11-08T23:00:32Z","git_url":"git://github.com/slimbootloader/slimbootloader.git","ssh_url":"git@github.com:slimbootloader/slimbootloader.git","clone_url":"https://github.com/slimbootloader/slimbootloader.git","svn_url":"https://github.com/slimbootloader/slimbootloader","homepage":"","size":5724,"stargazers_count":93,"watchers_count":93,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":27,"open_issues":3,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/40"},"html":{"href":"https://github.com/slimbootloader/slimbootloader/pull/40"},"issue":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/40"},"comments":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/slimbootloader/slimbootloader/statuses/84129b739c5320c0f8a8efa55b260f7fc216eb7b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"huang-jin-intel"}}