{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/24607","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/24607/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24607/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/24607/events","html_url":"https://github.com/nodejs/node/pull/24607","id":383967979,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzA2NDIx","number":24607,"title":"test: fixed the arguments order in `assert.strictEqual`","user":{"login":"sota1235","id":2968860,"node_id":"MDQ6VXNlcjI5Njg4NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2968860?v=4","gravatar_id":"","url":"https://api.github.com/users/sota1235","html_url":"https://github.com/sota1235","followers_url":"https://api.github.com/users/sota1235/followers","following_url":"https://api.github.com/users/sota1235/following{/other_user}","gists_url":"https://api.github.com/users/sota1235/gists{/gist_id}","starred_url":"https://api.github.com/users/sota1235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sota1235/subscriptions","organizations_url":"https://api.github.com/users/sota1235/orgs","repos_url":"https://api.github.com/users/sota1235/repos","events_url":"https://api.github.com/users/sota1235/events{/privacy}","received_events_url":"https://api.github.com/users/sota1235/received_events","type":"User","site_admin":false},"labels":[{"id":492471325,"node_id":"MDU6TGFiZWw0OTI0NzEzMjU=","url":"https://api.github.com/repos/nodejs/node/labels/code-and-learn","name":"code-and-learn","color":"bfd4f2","default":false},{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-24T07:44:06Z","updated_at":"2018-11-28T14:32:14Z","closed_at":"2018-11-28T14:09:14Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24607","html_url":"https://github.com/nodejs/node/pull/24607","diff_url":"https://github.com/nodejs/node/pull/24607.diff","patch_url":"https://github.com/nodejs/node/pull/24607.patch"},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/442466828","html_url":"https://github.com/nodejs/node/pull/24607#issuecomment-442466828","issue_url":"https://api.github.com/repos/nodejs/node/issues/24607","id":442466828,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjQ2NjgyOA==","user":{"login":"Trott","id":718899,"node_id":"MDQ6VXNlcjcxODg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T14:32:14Z","updated_at":"2018-11-28T14:32:14Z","author_association":"MEMBER","body":"> only failure in windows-fanned test_threadsafe_function is known - #23621\r\n\r\nPer [the Collaborators Guide](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#testing-and-ci), we may not land without a green or yellow CI. Please don't disregard failures, including known failures. (If they are to be disregarded, they need to be marked in the status file, which will result in a yellow CI when they fail.) Thanks.\r\n\r\n"}}
{"actor":{"display_login":"Trott"}}