{"action":"created","comment":{"url":"https://api.github.com/repos/micromdm/micromdm/pulls/comments/191832577","pull_request_review_id":124484058,"id":191832577,"diff_hunk":"@@ -10,11 +11,12 @@ import (\n )\n \n type CheckinEvent struct {\n-\tID      string\n-\tTime    time.Time\n-\tCommand CheckinCommand\n-\tParams  map[string]string\n-\tRaw     []byte\n+\tID         string\n+\tTime       time.Time\n+\tCommand    CheckinCommand\n+\tParams     map[string]string\n+\tRaw        []byte\n+\tDeviceCert *x509.Certificate","path":"mdm/checkin_event.go","position":22,"original_position":22,"commit_id":"97ad4deecb32b9d4642e9dac6100b91a02f447b8","original_commit_id":"97ad4deecb32b9d4642e9dac6100b91a02f447b8","user":{"login":"groob","id":1526945,"avatar_url":"https://avatars3.githubusercontent.com/u/1526945?v=4","gravatar_id":"","url":"https://api.github.com/users/groob","html_url":"https://github.com/groob","followers_url":"https://api.github.com/users/groob/followers","following_url":"https://api.github.com/users/groob/following{/other_user}","gists_url":"https://api.github.com/users/groob/gists{/gist_id}","starred_url":"https://api.github.com/users/groob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groob/subscriptions","organizations_url":"https://api.github.com/users/groob/orgs","repos_url":"https://api.github.com/users/groob/repos","events_url":"https://api.github.com/users/groob/events{/privacy}","received_events_url":"https://api.github.com/users/groob/received_events","type":"User","site_admin":false},"body":"can this be `[]byte`? It will be easier if it doesn't have to be decoded/parsed every time. ","created_at":"2018-05-30T16:19:31Z","updated_at":"2018-05-30T16:32:42Z","html_url":"https://github.com/micromdm/micromdm/pull/428#discussion_r191832577","pull_request_url":"https://api.github.com/repos/micromdm/micromdm/pulls/428","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/micromdm/micromdm/pulls/comments/191832577"},"html":{"href":"https://github.com/micromdm/micromdm/pull/428#discussion_r191832577"},"pull_request":{"href":"https://api.github.com/repos/micromdm/micromdm/pulls/428"}}},"pull_request":{"url":"https://api.github.com/repos/micromdm/micromdm/pulls/428","id":191340101,"html_url":"https://github.com/micromdm/micromdm/pull/428","diff_url":"https://github.com/micromdm/micromdm/pull/428.diff","patch_url":"https://github.com/micromdm/micromdm/pull/428.patch","issue_url":"https://api.github.com/repos/micromdm/micromdm/issues/428","number":428,"state":"open","locked":false,"title":"UDID/device certificate matching","user":{"login":"jessepeterson","id":694298,"avatar_url":"https://avatars1.githubusercontent.com/u/694298?v=4","gravatar_id":"","url":"https://api.github.com/users/jessepeterson","html_url":"https://github.com/jessepeterson","followers_url":"https://api.github.com/users/jessepeterson/followers","following_url":"https://api.github.com/users/jessepeterson/following{/other_user}","gists_url":"https://api.github.com/users/jessepeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/jessepeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessepeterson/subscriptions","organizations_url":"https://api.github.com/users/jessepeterson/orgs","repos_url":"https://api.github.com/users/jessepeterson/repos","events_url":"https://api.github.com/users/jessepeterson/events{/privacy}","received_events_url":"https://api.github.com/users/jessepeterson/received_events","type":"User","site_admin":false},"body":"Overview:\r\n\r\n* When verifying the MDM signature, returns the device certificate now\r\n* Includes the device certificate in the Checkin event\r\n* Reads & writes this device cert to the device database (could be just a hash per below TODO)\r\n* Implements Middleware to do actual UDID/cert matching against device database\r\n\r\nResolves #358.\r\n\r\nTODO:\r\n\r\n- [ ] Extend certificate checking to Acknowledge service middleware method.\r\n- [ ] Merge with refactored device service (#427)\r\n- [ ] Return something better than a 500 error. Perhaps a 401?\r\n- [ ] Consider only saving a (SHA256?) hash of the certificate instead of the whole DER. Or maybe the same attributes used to determine OCSP status.\r\n\r\nLooking for feedback!","created_at":"2018-05-30T05:47:31Z","updated_at":"2018-05-30T16:32:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac95c2b58d1e309385f2760717a65fd0b2009a91","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":459800675,"url":"https://api.github.com/repos/micromdm/micromdm/labels/in-progress","name":"in-progress","color":"fbca04","default":false},{"id":564573824,"url":"https://api.github.com/repos/micromdm/micromdm/labels/security","name":"security","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/micromdm/micromdm/pulls/428/commits","review_comments_url":"https://api.github.com/repos/micromdm/micromdm/pulls/428/comments","review_comment_url":"https://api.github.com/repos/micromdm/micromdm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micromdm/micromdm/issues/428/comments","statuses_url":"https://api.github.com/repos/micromdm/micromdm/statuses/97ad4deecb32b9d4642e9dac6100b91a02f447b8","head":{"label":"jessepeterson:udidauth","ref":"udidauth","sha":"97ad4deecb32b9d4642e9dac6100b91a02f447b8","user":{"login":"jessepeterson","id":694298,"avatar_url":"https://avatars1.githubusercontent.com/u/694298?v=4","gravatar_id":"","url":"https://api.github.com/users/jessepeterson","html_url":"https://github.com/jessepeterson","followers_url":"https://api.github.com/users/jessepeterson/followers","following_url":"https://api.github.com/users/jessepeterson/following{/other_user}","gists_url":"https://api.github.com/users/jessepeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/jessepeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessepeterson/subscriptions","organizations_url":"https://api.github.com/users/jessepeterson/orgs","repos_url":"https://api.github.com/users/jessepeterson/repos","events_url":"https://api.github.com/users/jessepeterson/events{/privacy}","received_events_url":"https://api.github.com/users/jessepeterson/received_events","type":"User","site_admin":false},"repo":{"id":85520406,"name":"micromdm","full_name":"jessepeterson/micromdm","owner":{"login":"jessepeterson","id":694298,"avatar_url":"https://avatars1.githubusercontent.com/u/694298?v=4","gravatar_id":"","url":"https://api.github.com/users/jessepeterson","html_url":"https://github.com/jessepeterson","followers_url":"https://api.github.com/users/jessepeterson/followers","following_url":"https://api.github.com/users/jessepeterson/following{/other_user}","gists_url":"https://api.github.com/users/jessepeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/jessepeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessepeterson/subscriptions","organizations_url":"https://api.github.com/users/jessepeterson/orgs","repos_url":"https://api.github.com/users/jessepeterson/repos","events_url":"https://api.github.com/users/jessepeterson/events{/privacy}","received_events_url":"https://api.github.com/users/jessepeterson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jessepeterson/micromdm","description":"Mobile Device Management server","fork":true,"url":"https://api.github.com/repos/jessepeterson/micromdm","forks_url":"https://api.github.com/repos/jessepeterson/micromdm/forks","keys_url":"https://api.github.com/repos/jessepeterson/micromdm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jessepeterson/micromdm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jessepeterson/micromdm/teams","hooks_url":"https://api.github.com/repos/jessepeterson/micromdm/hooks","issue_events_url":"https://api.github.com/repos/jessepeterson/micromdm/issues/events{/number}","events_url":"https://api.github.com/repos/jessepeterson/micromdm/events","assignees_url":"https://api.github.com/repos/jessepeterson/micromdm/assignees{/user}","branches_url":"https://api.github.com/repos/jessepeterson/micromdm/branches{/branch}","tags_url":"https://api.github.com/repos/jessepeterson/micromdm/tags","blobs_url":"https://api.github.com/repos/jessepeterson/micromdm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jessepeterson/micromdm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jessepeterson/micromdm/git/refs{/sha}","trees_url":"https://api.github.com/repos/jessepeterson/micromdm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jessepeterson/micromdm/statuses/{sha}","languages_url":"https://api.github.com/repos/jessepeterson/micromdm/languages","stargazers_url":"https://api.github.com/repos/jessepeterson/micromdm/stargazers","contributors_url":"https://api.github.com/repos/jessepeterson/micromdm/contributors","subscribers_url":"https://api.github.com/repos/jessepeterson/micromdm/subscribers","subscription_url":"https://api.github.com/repos/jessepeterson/micromdm/subscription","commits_url":"https://api.github.com/repos/jessepeterson/micromdm/commits{/sha}","git_commits_url":"https://api.github.com/repos/jessepeterson/micromdm/git/commits{/sha}","comments_url":"https://api.github.com/repos/jessepeterson/micromdm/comments{/number}","issue_comment_url":"https://api.github.com/repos/jessepeterson/micromdm/issues/comments{/number}","contents_url":"https://api.github.com/repos/jessepeterson/micromdm/contents/{+path}","compare_url":"https://api.github.com/repos/jessepeterson/micromdm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jessepeterson/micromdm/merges","archive_url":"https://api.github.com/repos/jessepeterson/micromdm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jessepeterson/micromdm/downloads","issues_url":"https://api.github.com/repos/jessepeterson/micromdm/issues{/number}","pulls_url":"https://api.github.com/repos/jessepeterson/micromdm/pulls{/number}","milestones_url":"https://api.github.com/repos/jessepeterson/micromdm/milestones{/number}","notifications_url":"https://api.github.com/repos/jessepeterson/micromdm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jessepeterson/micromdm/labels{/name}","releases_url":"https://api.github.com/repos/jessepeterson/micromdm/releases{/id}","deployments_url":"https://api.github.com/repos/jessepeterson/micromdm/deployments","created_at":"2017-03-20T00:49:41Z","updated_at":"2018-05-29T16:46:32Z","pushed_at":"2018-05-30T05:40:44Z","git_url":"git://github.com/jessepeterson/micromdm.git","ssh_url":"git@github.com:jessepeterson/micromdm.git","clone_url":"https://github.com/jessepeterson/micromdm.git","svn_url":"https://github.com/jessepeterson/micromdm","homepage":"https://micromdm.io","size":7640,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"micromdm:master","ref":"master","sha":"1916f2a2f5c48ccaa884bf7fb6ed6d896edededf","user":{"login":"micromdm","id":16374763,"avatar_url":"https://avatars3.githubusercontent.com/u/16374763?v=4","gravatar_id":"","url":"https://api.github.com/users/micromdm","html_url":"https://github.com/micromdm","followers_url":"https://api.github.com/users/micromdm/followers","following_url":"https://api.github.com/users/micromdm/following{/other_user}","gists_url":"https://api.github.com/users/micromdm/gists{/gist_id}","starred_url":"https://api.github.com/users/micromdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micromdm/subscriptions","organizations_url":"https://api.github.com/users/micromdm/orgs","repos_url":"https://api.github.com/users/micromdm/repos","events_url":"https://api.github.com/users/micromdm/events{/privacy}","received_events_url":"https://api.github.com/users/micromdm/received_events","type":"Organization","site_admin":false},"repo":{"id":54160117,"name":"micromdm","full_name":"micromdm/micromdm","owner":{"login":"micromdm","id":16374763,"avatar_url":"https://avatars3.githubusercontent.com/u/16374763?v=4","gravatar_id":"","url":"https://api.github.com/users/micromdm","html_url":"https://github.com/micromdm","followers_url":"https://api.github.com/users/micromdm/followers","following_url":"https://api.github.com/users/micromdm/following{/other_user}","gists_url":"https://api.github.com/users/micromdm/gists{/gist_id}","starred_url":"https://api.github.com/users/micromdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micromdm/subscriptions","organizations_url":"https://api.github.com/users/micromdm/orgs","repos_url":"https://api.github.com/users/micromdm/repos","events_url":"https://api.github.com/users/micromdm/events{/privacy}","received_events_url":"https://api.github.com/users/micromdm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micromdm/micromdm","description":"Mobile Device Management server","fork":false,"url":"https://api.github.com/repos/micromdm/micromdm","forks_url":"https://api.github.com/repos/micromdm/micromdm/forks","keys_url":"https://api.github.com/repos/micromdm/micromdm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micromdm/micromdm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micromdm/micromdm/teams","hooks_url":"https://api.github.com/repos/micromdm/micromdm/hooks","issue_events_url":"https://api.github.com/repos/micromdm/micromdm/issues/events{/number}","events_url":"https://api.github.com/repos/micromdm/micromdm/events","assignees_url":"https://api.github.com/repos/micromdm/micromdm/assignees{/user}","branches_url":"https://api.github.com/repos/micromdm/micromdm/branches{/branch}","tags_url":"https://api.github.com/repos/micromdm/micromdm/tags","blobs_url":"https://api.github.com/repos/micromdm/micromdm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micromdm/micromdm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micromdm/micromdm/git/refs{/sha}","trees_url":"https://api.github.com/repos/micromdm/micromdm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micromdm/micromdm/statuses/{sha}","languages_url":"https://api.github.com/repos/micromdm/micromdm/languages","stargazers_url":"https://api.github.com/repos/micromdm/micromdm/stargazers","contributors_url":"https://api.github.com/repos/micromdm/micromdm/contributors","subscribers_url":"https://api.github.com/repos/micromdm/micromdm/subscribers","subscription_url":"https://api.github.com/repos/micromdm/micromdm/subscription","commits_url":"https://api.github.com/repos/micromdm/micromdm/commits{/sha}","git_commits_url":"https://api.github.com/repos/micromdm/micromdm/git/commits{/sha}","comments_url":"https://api.github.com/repos/micromdm/micromdm/comments{/number}","issue_comment_url":"https://api.github.com/repos/micromdm/micromdm/issues/comments{/number}","contents_url":"https://api.github.com/repos/micromdm/micromdm/contents/{+path}","compare_url":"https://api.github.com/repos/micromdm/micromdm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micromdm/micromdm/merges","archive_url":"https://api.github.com/repos/micromdm/micromdm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micromdm/micromdm/downloads","issues_url":"https://api.github.com/repos/micromdm/micromdm/issues{/number}","pulls_url":"https://api.github.com/repos/micromdm/micromdm/pulls{/number}","milestones_url":"https://api.github.com/repos/micromdm/micromdm/milestones{/number}","notifications_url":"https://api.github.com/repos/micromdm/micromdm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micromdm/micromdm/labels{/name}","releases_url":"https://api.github.com/repos/micromdm/micromdm/releases{/id}","deployments_url":"https://api.github.com/repos/micromdm/micromdm/deployments","created_at":"2016-03-18T00:17:44Z","updated_at":"2018-05-30T16:18:07Z","pushed_at":"2018-05-30T16:18:05Z","git_url":"git://github.com/micromdm/micromdm.git","ssh_url":"git@github.com:micromdm/micromdm.git","clone_url":"https://github.com/micromdm/micromdm.git","svn_url":"https://github.com/micromdm/micromdm","homepage":"https://micromdm.io","size":7642,"stargazers_count":354,"watchers_count":354,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":61,"open_issues":71,"watchers":354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micromdm/micromdm/pulls/428"},"html":{"href":"https://github.com/micromdm/micromdm/pull/428"},"issue":{"href":"https://api.github.com/repos/micromdm/micromdm/issues/428"},"comments":{"href":"https://api.github.com/repos/micromdm/micromdm/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/micromdm/micromdm/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/micromdm/micromdm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micromdm/micromdm/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/micromdm/micromdm/statuses/97ad4deecb32b9d4642e9dac6100b91a02f447b8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"groob"}}