{"action":"opened","number":143,"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/143","id":191206699,"html_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/143","diff_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/143.diff","patch_url":"https://github.com/ministryofjustice/analytics-platform-ops/pull/143.patch","issue_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/143","number":143,"state":"open","locked":false,"title":"Lambda Module environment variables","user":{"login":"djsd123","id":8365097,"avatar_url":"https://avatars3.githubusercontent.com/u/8365097?v=4","gravatar_id":"","url":"https://api.github.com/users/djsd123","html_url":"https://github.com/djsd123","followers_url":"https://api.github.com/users/djsd123/followers","following_url":"https://api.github.com/users/djsd123/following{/other_user}","gists_url":"https://api.github.com/users/djsd123/gists{/gist_id}","starred_url":"https://api.github.com/users/djsd123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djsd123/subscriptions","organizations_url":"https://api.github.com/users/djsd123/orgs","repos_url":"https://api.github.com/users/djsd123/repos","events_url":"https://api.github.com/users/djsd123/events{/privacy}","received_events_url":"https://api.github.com/users/djsd123/received_events","type":"User","site_admin":false},"body":"Forgot to push these changes with the last merge.  \r\n\r\nDefining the terraform variables block at invocation allows the module to be more generic as\r\nterraform cannot interpolate terraform variables as keys to environment variables.\r\n\r\nThe module has an empty map passed to the environment block which is expecting a map.\r\n\r\nThe map will then be populated when the module is invoked elsewhere with there own custom environment variables.  See the \r\n\r\nThis has already been deployed and works.","created_at":"2018-05-29T16:42:54Z","updated_at":"2018-05-29T16:42:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/143/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/143/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/143/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/statuses/e36f76bbf00dc5bb6a469a72dcaa1b7b4a0ab8ed","head":{"label":"ministryofjustice:lambda-module-variables","ref":"lambda-module-variables","sha":"e36f76bbf00dc5bb6a469a72dcaa1b7b4a0ab8ed","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":77397761,"name":"analytics-platform-ops","full_name":"ministryofjustice/analytics-platform-ops","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/analytics-platform-ops","description":"Ops and deployment resources for MOJ Analytics platform","fork":false,"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops","forks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/forks","keys_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/events","assignees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/merges","archive_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/deployments","created_at":"2016-12-26T17:27:30Z","updated_at":"2018-05-29T11:00:09Z","pushed_at":"2018-05-29T16:35:51Z","git_url":"git://github.com/ministryofjustice/analytics-platform-ops.git","ssh_url":"git@github.com:ministryofjustice/analytics-platform-ops.git","clone_url":"https://github.com/ministryofjustice/analytics-platform-ops.git","svn_url":"https://github.com/ministryofjustice/analytics-platform-ops","homepage":"","size":1904,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":4,"watchers":9,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"873217bfcfbcf977d794d0a01feecf756c742286","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":77397761,"name":"analytics-platform-ops","full_name":"ministryofjustice/analytics-platform-ops","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/analytics-platform-ops","description":"Ops and deployment resources for MOJ Analytics platform","fork":false,"url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops","forks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/forks","keys_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/events","assignees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/merges","archive_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/deployments","created_at":"2016-12-26T17:27:30Z","updated_at":"2018-05-29T11:00:09Z","pushed_at":"2018-05-29T16:35:51Z","git_url":"git://github.com/ministryofjustice/analytics-platform-ops.git","ssh_url":"git@github.com:ministryofjustice/analytics-platform-ops.git","clone_url":"https://github.com/ministryofjustice/analytics-platform-ops.git","svn_url":"https://github.com/ministryofjustice/analytics-platform-ops","homepage":"","size":1904,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/143"},"html":{"href":"https://github.com/ministryofjustice/analytics-platform-ops/pull/143"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/143"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/analytics-platform-ops/statuses/e36f76bbf00dc5bb6a469a72dcaa1b7b4a0ab8ed"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":36,"changed_files":3}}
{"actor":{"display_login":"djsd123"}}