{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/220594062","pull_request_review_id":159036280,"id":220594062,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDU5NDA2Mg==","diff_hunk":"@@ -13,6 +13,10 @@\n  */\n package org.codice.ddf.sync.installer.api;\n \n+/**\n+ * <b> This code is experimental. While this interface is functional and tested, it may change or be","path":"platform/sync-installer/sync-installer-api/src/main/java/org/codice/ddf/sync/installer/api/SynchronizedInstallerException.java","position":17,"original_position":5,"commit_id":"a48c10007e63712aeebab81a19dc08513b44aec0","original_commit_id":"a48c10007e63712aeebab81a19dc08513b44aec0","user":{"login":"paouelle","id":10549555,"node_id":"MDQ6VXNlcjEwNTQ5NTU1","avatar_url":"https://avatars0.githubusercontent.com/u/10549555?v=4","gravatar_id":"","url":"https://api.github.com/users/paouelle","html_url":"https://github.com/paouelle","followers_url":"https://api.github.com/users/paouelle/followers","following_url":"https://api.github.com/users/paouelle/following{/other_user}","gists_url":"https://api.github.com/users/paouelle/gists{/gist_id}","starred_url":"https://api.github.com/users/paouelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paouelle/subscriptions","organizations_url":"https://api.github.com/users/paouelle/orgs","repos_url":"https://api.github.com/users/paouelle/repos","events_url":"https://api.github.com/users/paouelle/events{/privacy}","received_events_url":"https://api.github.com/users/paouelle/received_events","type":"User","site_admin":false},"body":"Class description","created_at":"2018-09-26T14:45:26Z","updated_at":"2018-09-26T14:45:27Z","html_url":"https://github.com/codice/ddf/pull/3778#discussion_r220594062","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/3778","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/220594062"},"html":{"href":"https://github.com/codice/ddf/pull/3778#discussion_r220594062"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/3778"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3778","id":217110552,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTEwNTUy","html_url":"https://github.com/codice/ddf/pull/3778","diff_url":"https://github.com/codice/ddf/pull/3778.diff","patch_url":"https://github.com/codice/ddf/pull/3778.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/3778","number":3778,"state":"open","locked":false,"title":"DDF-4163: Make WaitForReady a karaf command ","user":{"login":"tbatie","id":9013620,"node_id":"MDQ6VXNlcjkwMTM2MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9013620?v=4","gravatar_id":"","url":"https://api.github.com/users/tbatie","html_url":"https://github.com/tbatie","followers_url":"https://api.github.com/users/tbatie/followers","following_url":"https://api.github.com/users/tbatie/following{/other_user}","gists_url":"https://api.github.com/users/tbatie/gists{/gist_id}","starred_url":"https://api.github.com/users/tbatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbatie/subscriptions","organizations_url":"https://api.github.com/users/tbatie/orgs","repos_url":"https://api.github.com/users/tbatie/repos","events_url":"https://api.github.com/users/tbatie/events{/privacy}","received_events_url":"https://api.github.com/users/tbatie/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n- Created a SynchronisedInstaller to wait on different portions of the system to be ready\r\n- Updated the installer to use the SynchronisedInstaller, resolves a race condition where the installer would continue through setup when not all the bundles were in an Active state\r\n- Makes WaitForReady a karaf command instead of being in the start script\r\n- Updates a portion of the itests to use the SynchronisedInstaller\r\n- Disabled solr for itests that do not need it\r\n- Made the solr port dynamic for a portion of the itests\r\n\r\n#### Who is reviewing it? \r\n@figliold\r\n@ethantmanns \r\n@jhunzik \r\n@rzwiefel \r\n\r\n#### Select relevant component teams: \r\nhttps://github.com/orgs/codice/teams\r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n@clockard\r\n@coyotesqrl\r\n\r\n#### How should this be tested?\r\n- Start up the distribution several times and ensure the wfr is waiting for all the bundles to reach an Active state.\r\n- Go through the installer several times and ensure all the bundles reach an active state before the installer continues\r\n- Review the logs of the SynchronisedInstaller and ensure they are accurately reflecting the state of the system\r\n\r\n#### Any background context you want to provide?\r\n\r\n#### What are the relevant tickets?\r\nhttps://codice.atlassian.net/browse/DDF-2182\r\nhttps://codice.atlassian.net/browse/DDF-3483\r\n\r\n#### Checklist:\r\n- [In progress ] Documentation Updated\r\n- [In progress] Update / Add Unit Tests\r\n- [x ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-09-20T21:20:55Z","updated_at":"2018-09-26T14:45:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9318ff2a61b12426c99a716cc72fe59c65c3ed08","assignee":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"assignees":[{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},{"login":"clockard","id":5248090,"node_id":"MDQ6VXNlcjUyNDgwOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5248090?v=4","gravatar_id":"","url":"https://api.github.com/users/clockard","html_url":"https://github.com/clockard","followers_url":"https://api.github.com/users/clockard/followers","following_url":"https://api.github.com/users/clockard/following{/other_user}","gists_url":"https://api.github.com/users/clockard/gists{/gist_id}","starred_url":"https://api.github.com/users/clockard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockard/subscriptions","organizations_url":"https://api.github.com/users/clockard/orgs","repos_url":"https://api.github.com/users/clockard/repos","events_url":"https://api.github.com/users/clockard/events{/privacy}","received_events_url":"https://api.github.com/users/clockard/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"stustison","id":4391679,"node_id":"MDQ6VXNlcjQzOTE2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/3778/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/3778/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3778/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/a48c10007e63712aeebab81a19dc08513b44aec0","head":{"label":"tbatie:wait-for-ready","ref":"wait-for-ready","sha":"a48c10007e63712aeebab81a19dc08513b44aec0","user":{"login":"tbatie","id":9013620,"node_id":"MDQ6VXNlcjkwMTM2MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9013620?v=4","gravatar_id":"","url":"https://api.github.com/users/tbatie","html_url":"https://github.com/tbatie","followers_url":"https://api.github.com/users/tbatie/followers","following_url":"https://api.github.com/users/tbatie/following{/other_user}","gists_url":"https://api.github.com/users/tbatie/gists{/gist_id}","starred_url":"https://api.github.com/users/tbatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbatie/subscriptions","organizations_url":"https://api.github.com/users/tbatie/orgs","repos_url":"https://api.github.com/users/tbatie/repos","events_url":"https://api.github.com/users/tbatie/events{/privacy}","received_events_url":"https://api.github.com/users/tbatie/received_events","type":"User","site_admin":false},"repo":{"id":38900987,"node_id":"MDEwOlJlcG9zaXRvcnkzODkwMDk4Nw==","name":"ddf","full_name":"tbatie/ddf","private":false,"owner":{"login":"tbatie","id":9013620,"node_id":"MDQ6VXNlcjkwMTM2MjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9013620?v=4","gravatar_id":"","url":"https://api.github.com/users/tbatie","html_url":"https://github.com/tbatie","followers_url":"https://api.github.com/users/tbatie/followers","following_url":"https://api.github.com/users/tbatie/following{/other_user}","gists_url":"https://api.github.com/users/tbatie/gists{/gist_id}","starred_url":"https://api.github.com/users/tbatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbatie/subscriptions","organizations_url":"https://api.github.com/users/tbatie/orgs","repos_url":"https://api.github.com/users/tbatie/repos","events_url":"https://api.github.com/users/tbatie/events{/privacy}","received_events_url":"https://api.github.com/users/tbatie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tbatie/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/tbatie/ddf","forks_url":"https://api.github.com/repos/tbatie/ddf/forks","keys_url":"https://api.github.com/repos/tbatie/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbatie/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbatie/ddf/teams","hooks_url":"https://api.github.com/repos/tbatie/ddf/hooks","issue_events_url":"https://api.github.com/repos/tbatie/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/tbatie/ddf/events","assignees_url":"https://api.github.com/repos/tbatie/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/tbatie/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/tbatie/ddf/tags","blobs_url":"https://api.github.com/repos/tbatie/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbatie/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbatie/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbatie/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbatie/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/tbatie/ddf/languages","stargazers_url":"https://api.github.com/repos/tbatie/ddf/stargazers","contributors_url":"https://api.github.com/repos/tbatie/ddf/contributors","subscribers_url":"https://api.github.com/repos/tbatie/ddf/subscribers","subscription_url":"https://api.github.com/repos/tbatie/ddf/subscription","commits_url":"https://api.github.com/repos/tbatie/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbatie/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbatie/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbatie/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbatie/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/tbatie/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbatie/ddf/merges","archive_url":"https://api.github.com/repos/tbatie/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbatie/ddf/downloads","issues_url":"https://api.github.com/repos/tbatie/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/tbatie/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/tbatie/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/tbatie/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbatie/ddf/labels{/name}","releases_url":"https://api.github.com/repos/tbatie/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/tbatie/ddf/deployments","created_at":"2015-07-10T20:36:35Z","updated_at":"2016-04-06T16:24:17Z","pushed_at":"2018-09-26T06:46:09Z","git_url":"git://github.com/tbatie/ddf.git","ssh_url":"git@github.com:tbatie/ddf.git","clone_url":"https://github.com/tbatie/ddf.git","svn_url":"https://github.com/tbatie/ddf","homepage":"","size":209251,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"8c982450cba9d8b7c12bc7c348c9ce7145acdcf5","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzU2Mw==","name":"ddf","full_name":"codice/ddf","private":false,"owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-09-25T22:59:33Z","pushed_at":"2018-09-26T13:22:01Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":404823,"stargazers_count":89,"watchers_count":89,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":153,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":153,"open_issues":43,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/3778"},"html":{"href":"https://github.com/codice/ddf/pull/3778"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/3778"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/3778/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/3778/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/3778/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/a48c10007e63712aeebab81a19dc08513b44aec0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"paouelle"}}