{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments/209807287","pull_request_review_id":145892145,"id":209807287,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTgwNzI4Nw==","diff_hunk":"@@ -56,7 +63,7 @@ public boolean matches(final ClassLoader loader) {\n             // Don't reference-check helper classes.\n             // They will be injected by the instrumentation's HelperInjector.\n             if (!helperClassNames.contains(reference.getClassName())) {","path":"dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/ReferenceMatcher.java","position":25,"original_position":25,"commit_id":"50ed54c41ae50af7b15e1a878ab7c7c879b34c68","original_commit_id":"50ed54c41ae50af7b15e1a878ab7c7c879b34c68","user":{"login":"realark","id":31153155,"node_id":"MDQ6VXNlcjMxMTUzMTU1","avatar_url":"https://avatars1.githubusercontent.com/u/31153155?v=4","gravatar_id":"","url":"https://api.github.com/users/realark","html_url":"https://github.com/realark","followers_url":"https://api.github.com/users/realark/followers","following_url":"https://api.github.com/users/realark/following{/other_user}","gists_url":"https://api.github.com/users/realark/gists{/gist_id}","starred_url":"https://api.github.com/users/realark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realark/subscriptions","organizations_url":"https://api.github.com/users/realark/orgs","repos_url":"https://api.github.com/users/realark/repos","events_url":"https://api.github.com/users/realark/events{/privacy}","received_events_url":"https://api.github.com/users/realark/received_events","type":"User","site_admin":false},"body":"No, just the helper class itself won't be checked. Any reference created by the helper will be checked.","created_at":"2018-08-14T01:35:56Z","updated_at":"2018-08-14T01:35:56Z","html_url":"https://github.com/DataDog/dd-trace-java/pull/422#discussion_r209807287","pull_request_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/422","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments/209807287"},"html":{"href":"https://github.com/DataDog/dd-trace-java/pull/422#discussion_r209807287"},"pull_request":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/422"}},"in_reply_to_id":207963108},"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/422","id":205482403,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDgyNDAz","html_url":"https://github.com/DataDog/dd-trace-java/pull/422","diff_url":"https://github.com/DataDog/dd-trace-java/pull/422.diff","patch_url":"https://github.com/DataDog/dd-trace-java/pull/422.patch","issue_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/422","number":422,"state":"open","locked":false,"title":"muzzle field and method matching","user":{"login":"realark","id":31153155,"node_id":"MDQ6VXNlcjMxMTUzMTU1","avatar_url":"https://avatars1.githubusercontent.com/u/31153155?v=4","gravatar_id":"","url":"https://api.github.com/users/realark","html_url":"https://github.com/realark","followers_url":"https://api.github.com/users/realark/followers","following_url":"https://api.github.com/users/realark/following{/other_user}","gists_url":"https://api.github.com/users/realark/gists{/gist_id}","starred_url":"https://api.github.com/users/realark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realark/subscriptions","organizations_url":"https://api.github.com/users/realark/orgs","repos_url":"https://api.github.com/users/realark/repos","events_url":"https://api.github.com/users/realark/events{/privacy}","received_events_url":"https://api.github.com/users/realark/received_events","type":"User","site_admin":false},"body":"Merging to integration branch.\r\n\r\nAdd new muzzle checks:\r\n* Class access flags\r\n* Methods on class and access flags\r\n* Fields on class and access flags\r\n* Fixed a bug in the PatchLogger caught by muzzle.\r\n* Use a caching type pool strategy to reduce calls to getting classloader resources\r\n\r\nWith these changes muzzle can now check everything `classLoaderHasClasses` can check. There's still work to be done to hook up the version scan plugin, update the version ranges, and remove classLoaderHas* checks. That work will go into a later PR against the same integration branch.","created_at":"2018-08-01T16:28:53Z","updated_at":"2018-08-14T01:35:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8acfbb181551d2acb02bb75d6b2432690deb479","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":663629735,"node_id":"MDU6TGFiZWw2NjM2Mjk3MzU=","url":"https://api.github.com/repos/DataDog/dd-trace-java/labels/core","name":"core","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/422/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/422/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/422/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/50ed54c41ae50af7b15e1a878ab7c7c879b34c68","head":{"label":"DataDog:ark/muzzle-fields-and-methods","ref":"ark/muzzle-fields-and-methods","sha":"50ed54c41ae50af7b15e1a878ab7c7c879b34c68","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":89221572,"node_id":"MDEwOlJlcG9zaXRvcnk4OTIyMTU3Mg==","name":"dd-trace-java","full_name":"DataDog/dd-trace-java","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-trace-java","description":"Datadog APM client for Java","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-java","forks_url":"https://api.github.com/repos/DataDog/dd-trace-java/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-java/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-java/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-java/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-java/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-java/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-java/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-java/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-java/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-java/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-java/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-java/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-java/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-java/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-java/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-java/deployments","created_at":"2017-04-24T09:24:40Z","updated_at":"2018-08-13T07:29:06Z","pushed_at":"2018-08-13T07:29:06Z","git_url":"git://github.com/DataDog/dd-trace-java.git","ssh_url":"git@github.com:DataDog/dd-trace-java.git","clone_url":"https://github.com/DataDog/dd-trace-java.git","svn_url":"https://github.com/DataDog/dd-trace-java","homepage":"https://docs.datadoghq.com/tracing/languages/java","size":100007,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":19,"watchers":49,"default_branch":"master"}},"base":{"label":"DataDog:ark/muzzle-integration-branch","ref":"ark/muzzle-integration-branch","sha":"911ad5f2318deb0c64e2455de435bfa8176448d0","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":89221572,"node_id":"MDEwOlJlcG9zaXRvcnk4OTIyMTU3Mg==","name":"dd-trace-java","full_name":"DataDog/dd-trace-java","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-trace-java","description":"Datadog APM client for Java","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-java","forks_url":"https://api.github.com/repos/DataDog/dd-trace-java/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-java/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-java/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-java/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-java/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-java/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-java/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-java/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-java/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-java/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-java/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-java/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-java/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-java/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-java/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-java/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-java/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-java/deployments","created_at":"2017-04-24T09:24:40Z","updated_at":"2018-08-13T07:29:06Z","pushed_at":"2018-08-13T07:29:06Z","git_url":"git://github.com/DataDog/dd-trace-java.git","ssh_url":"git@github.com:DataDog/dd-trace-java.git","clone_url":"https://github.com/DataDog/dd-trace-java.git","svn_url":"https://github.com/DataDog/dd-trace-java","homepage":"https://docs.datadoghq.com/tracing/languages/java","size":100007,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":19,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/422"},"html":{"href":"https://github.com/DataDog/dd-trace-java/pull/422"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/issues/422"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-trace-java/statuses/50ed54c41ae50af7b15e1a878ab7c7c879b34c68"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"realark"}}