{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/208972570","pull_request_review_id":144894323,"id":208972570,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODk3MjU3MA==","diff_hunk":"@@ -2352,7 +2352,7 @@ public void ChainAdvancesAfterACheckpoint_NewChainIsPresentedWithForkPoint_Chain\n \n                 cht.BlockDataDownloaded(currentChainTip, block);\n                 cht.PartialValidationSucceeded(currentChainTip, out bool fullValidationRequired);\n-                ctx.FinalizedBlockMock.Setup(m => m.GetFinalizedBlockHashAndHeight()).Returns(new HashHeightPair(uint256.One, currentChainTip.Height - maxReorg));\n+                ctx.FinalizedBlockMock.Setup(m => m.GetFinalizedBlockInfo()).Returns(new HashHeightPair(uint256.One, currentChainTip.Height - maxReorg));","path":"src/Stratis.Bitcoin.Tests/Consensus/ChainedHeaderTreeTest.cs","position":null,"original_position":41,"commit_id":"3c5087ecaf8a16a37ba12430748f702430414da0","original_commit_id":"3c5087ecaf8a16a37ba12430748f702430414da0","user":{"login":"noescape00","id":10259355,"node_id":"MDQ6VXNlcjEwMjU5MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/10259355?v=4","gravatar_id":"","url":"https://api.github.com/users/noescape00","html_url":"https://github.com/noescape00","followers_url":"https://api.github.com/users/noescape00/followers","following_url":"https://api.github.com/users/noescape00/following{/other_user}","gists_url":"https://api.github.com/users/noescape00/gists{/gist_id}","starred_url":"https://api.github.com/users/noescape00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noescape00/subscriptions","organizations_url":"https://api.github.com/users/noescape00/orgs","repos_url":"https://api.github.com/users/noescape00/repos","events_url":"https://api.github.com/users/noescape00/events{/privacy}","received_events_url":"https://api.github.com/users/noescape00/received_events","type":"User","site_admin":false},"body":"no. tests check only heights","created_at":"2018-08-09T15:22:29Z","updated_at":"2018-08-09T15:22:30Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1882#discussion_r208972570","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1882","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/208972570"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1882#discussion_r208972570"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1882"}},"in_reply_to_id":208972261},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1882","id":207195769,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTk1NzY5","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1882","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1882.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1882.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1882","number":1882,"state":"open","locked":false,"title":"[Activation] save hash and height for block store and finalized block","user":{"login":"noescape00","id":10259355,"node_id":"MDQ6VXNlcjEwMjU5MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/10259355?v=4","gravatar_id":"","url":"https://api.github.com/users/noescape00","html_url":"https://github.com/noescape00","followers_url":"https://api.github.com/users/noescape00/followers","following_url":"https://api.github.com/users/noescape00/following{/other_user}","gists_url":"https://api.github.com/users/noescape00/gists{/gist_id}","starred_url":"https://api.github.com/users/noescape00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noescape00/subscriptions","organizations_url":"https://api.github.com/users/noescape00/orgs","repos_url":"https://api.github.com/users/noescape00/repos","events_url":"https://api.github.com/users/noescape00/events{/privacy}","received_events_url":"https://api.github.com/users/noescape00/received_events","type":"User","site_admin":false},"body":"#1877 part 1 of step 4","created_at":"2018-08-09T04:11:03Z","updated_at":"2018-08-09T15:22:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79f11619ee6763feee4070bd4ed6035bab4dff21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1882/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1882/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1882/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/3c5087ecaf8a16a37ba12430748f702430414da0","head":{"label":"noescape00:saveHeights","ref":"saveHeights","sha":"3c5087ecaf8a16a37ba12430748f702430414da0","user":{"login":"noescape00","id":10259355,"node_id":"MDQ6VXNlcjEwMjU5MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/10259355?v=4","gravatar_id":"","url":"https://api.github.com/users/noescape00","html_url":"https://github.com/noescape00","followers_url":"https://api.github.com/users/noescape00/followers","following_url":"https://api.github.com/users/noescape00/following{/other_user}","gists_url":"https://api.github.com/users/noescape00/gists{/gist_id}","starred_url":"https://api.github.com/users/noescape00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noescape00/subscriptions","organizations_url":"https://api.github.com/users/noescape00/orgs","repos_url":"https://api.github.com/users/noescape00/repos","events_url":"https://api.github.com/users/noescape00/events{/privacy}","received_events_url":"https://api.github.com/users/noescape00/received_events","type":"User","site_admin":false},"repo":{"id":109851531,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk4NTE1MzE=","name":"StratisBitcoinFullNode","full_name":"noescape00/StratisBitcoinFullNode","owner":{"login":"noescape00","id":10259355,"node_id":"MDQ6VXNlcjEwMjU5MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/10259355?v=4","gravatar_id":"","url":"https://api.github.com/users/noescape00","html_url":"https://github.com/noescape00","followers_url":"https://api.github.com/users/noescape00/followers","following_url":"https://api.github.com/users/noescape00/following{/other_user}","gists_url":"https://api.github.com/users/noescape00/gists{/gist_id}","starred_url":"https://api.github.com/users/noescape00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noescape00/subscriptions","organizations_url":"https://api.github.com/users/noescape00/orgs","repos_url":"https://api.github.com/users/noescape00/repos","events_url":"https://api.github.com/users/noescape00/events{/privacy}","received_events_url":"https://api.github.com/users/noescape00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noescape00/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/deployments","created_at":"2017-11-07T15:09:59Z","updated_at":"2018-08-08T08:55:57Z","pushed_at":"2018-08-09T15:16:53Z","git_url":"git://github.com/noescape00/StratisBitcoinFullNode.git","ssh_url":"git@github.com:noescape00/StratisBitcoinFullNode.git","clone_url":"https://github.com/noescape00/StratisBitcoinFullNode.git","svn_url":"https://github.com/noescape00/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":31623,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:core-way-activation","ref":"core-way-activation","sha":"16f0e861705b11564c146e8c14815e7992983c4a","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-08-09T02:29:37Z","pushed_at":"2018-08-09T15:12:11Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":33017,"stargazers_count":529,"watchers_count":529,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"open_issues_count":153,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":243,"open_issues":153,"watchers":529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1882"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1882"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1882"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1882/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1882/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1882/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/3c5087ecaf8a16a37ba12430748f702430414da0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"noescape00"}}