{"action":"created","comment":{"url":"https://api.github.com/repos/linq2db/linq2db/pulls/comments/176950035","pull_request_review_id":106739601,"id":176950035,"diff_hunk":"@@ -81,5 +83,37 @@ protected override bool SupportsParametersInSource\n \t\t\telse\n \t\t\t\tbase.AddSourceValue(valueConverter, column, columnType, value, isFirstRow);\n \t\t}\n+\n+\t\tprotected override void BuildMatch()\n+\t\t{\n+\t\t\tvar old = FirebirdConfiguration.DisableConvertInnerJoinsToLeftJoins.Value;\n+\n+\t\t\ttry\n+\t\t\t{\n+\t\t\t\tFirebirdConfiguration.DisableConvertInnerJoinsToLeftJoins.Value = true;","path":"Source/LinqToDB/DataProvider/Firebird/FirebirdMergeBuilder.cs","position":21,"original_position":21,"commit_id":"b1588bb17a39b9332cb39d13ff4d7b2ac949d092","original_commit_id":"b1588bb17a39b9332cb39d13ff4d7b2ac949d092","user":{"login":"sdanyliv","id":783759,"avatar_url":"https://avatars1.githubusercontent.com/u/783759?v=4","gravatar_id":"","url":"https://api.github.com/users/sdanyliv","html_url":"https://github.com/sdanyliv","followers_url":"https://api.github.com/users/sdanyliv/followers","following_url":"https://api.github.com/users/sdanyliv/following{/other_user}","gists_url":"https://api.github.com/users/sdanyliv/gists{/gist_id}","starred_url":"https://api.github.com/users/sdanyliv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdanyliv/subscriptions","organizations_url":"https://api.github.com/users/sdanyliv/orgs","repos_url":"https://api.github.com/users/sdanyliv/repos","events_url":"https://api.github.com/users/sdanyliv/events{/privacy}","received_events_url":"https://api.github.com/users/sdanyliv/received_events","type":"User","site_admin":false},"body":"What is it? Looks like a hack.","created_at":"2018-03-25T18:53:49Z","updated_at":"2018-03-25T18:53:49Z","html_url":"https://github.com/linq2db/linq2db/pull/1000#discussion_r176950035","pull_request_url":"https://api.github.com/repos/linq2db/linq2db/pulls/1000","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/linq2db/linq2db/pulls/comments/176950035"},"html":{"href":"https://github.com/linq2db/linq2db/pull/1000#discussion_r176950035"},"pull_request":{"href":"https://api.github.com/repos/linq2db/linq2db/pulls/1000"}}},"pull_request":{"url":"https://api.github.com/repos/linq2db/linq2db/pulls/1000","id":167748767,"html_url":"https://github.com/linq2db/linq2db/pull/1000","diff_url":"https://github.com/linq2db/linq2db/pull/1000.diff","patch_url":"https://github.com/linq2db/linq2db/pull/1000.patch","issue_url":"https://api.github.com/repos/linq2db/linq2db/issues/1000","number":1000,"state":"open","locked":false,"title":"Implemented automatic INNER Join to LEFT Join converter for Firebird.","user":{"login":"sdanyliv","id":783759,"avatar_url":"https://avatars1.githubusercontent.com/u/783759?v=4","gravatar_id":"","url":"https://api.github.com/users/sdanyliv","html_url":"https://github.com/sdanyliv","followers_url":"https://api.github.com/users/sdanyliv/followers","following_url":"https://api.github.com/users/sdanyliv/following{/other_user}","gists_url":"https://api.github.com/users/sdanyliv/gists{/gist_id}","starred_url":"https://api.github.com/users/sdanyliv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdanyliv/subscriptions","organizations_url":"https://api.github.com/users/sdanyliv/orgs","repos_url":"https://api.github.com/users/sdanyliv/repos","events_url":"https://api.github.com/users/sdanyliv/events{/privacy}","received_events_url":"https://api.github.com/users/sdanyliv/received_events","type":"User","site_admin":false},"body":"Fixes #982","created_at":"2018-02-07T16:52:10Z","updated_at":"2018-03-25T18:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f9101e4c9aed87cb0bc7a65a1c0e59d7354271c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/linq2db/linq2db/milestones/3","html_url":"https://github.com/linq2db/linq2db/milestone/3","labels_url":"https://api.github.com/repos/linq2db/linq2db/milestones/3/labels","id":2578654,"number":3,"title":"2.0.0","description":"Next major release","creator":{"login":"MaceWindu","id":1099238,"avatar_url":"https://avatars1.githubusercontent.com/u/1099238?v=4","gravatar_id":"","url":"https://api.github.com/users/MaceWindu","html_url":"https://github.com/MaceWindu","followers_url":"https://api.github.com/users/MaceWindu/followers","following_url":"https://api.github.com/users/MaceWindu/following{/other_user}","gists_url":"https://api.github.com/users/MaceWindu/gists{/gist_id}","starred_url":"https://api.github.com/users/MaceWindu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaceWindu/subscriptions","organizations_url":"https://api.github.com/users/MaceWindu/orgs","repos_url":"https://api.github.com/users/MaceWindu/repos","events_url":"https://api.github.com/users/MaceWindu/events{/privacy}","received_events_url":"https://api.github.com/users/MaceWindu/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":48,"state":"open","created_at":"2017-06-12T18:58:15Z","updated_at":"2018-03-25T17:15:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/linq2db/linq2db/pulls/1000/commits","review_comments_url":"https://api.github.com/repos/linq2db/linq2db/pulls/1000/comments","review_comment_url":"https://api.github.com/repos/linq2db/linq2db/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linq2db/linq2db/issues/1000/comments","statuses_url":"https://api.github.com/repos/linq2db/linq2db/statuses/b1588bb17a39b9332cb39d13ff4d7b2ac949d092","head":{"label":"linq2db:issue_982","ref":"issue_982","sha":"b1588bb17a39b9332cb39d13ff4d7b2ac949d092","user":{"login":"linq2db","id":865669,"avatar_url":"https://avatars3.githubusercontent.com/u/865669?v=4","gravatar_id":"","url":"https://api.github.com/users/linq2db","html_url":"https://github.com/linq2db","followers_url":"https://api.github.com/users/linq2db/followers","following_url":"https://api.github.com/users/linq2db/following{/other_user}","gists_url":"https://api.github.com/users/linq2db/gists{/gist_id}","starred_url":"https://api.github.com/users/linq2db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linq2db/subscriptions","organizations_url":"https://api.github.com/users/linq2db/orgs","repos_url":"https://api.github.com/users/linq2db/repos","events_url":"https://api.github.com/users/linq2db/events{/privacy}","received_events_url":"https://api.github.com/users/linq2db/received_events","type":"Organization","site_admin":false},"repo":{"id":1916228,"name":"linq2db","full_name":"linq2db/linq2db","owner":{"login":"linq2db","id":865669,"avatar_url":"https://avatars3.githubusercontent.com/u/865669?v=4","gravatar_id":"","url":"https://api.github.com/users/linq2db","html_url":"https://github.com/linq2db","followers_url":"https://api.github.com/users/linq2db/followers","following_url":"https://api.github.com/users/linq2db/following{/other_user}","gists_url":"https://api.github.com/users/linq2db/gists{/gist_id}","starred_url":"https://api.github.com/users/linq2db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linq2db/subscriptions","organizations_url":"https://api.github.com/users/linq2db/orgs","repos_url":"https://api.github.com/users/linq2db/repos","events_url":"https://api.github.com/users/linq2db/events{/privacy}","received_events_url":"https://api.github.com/users/linq2db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linq2db/linq2db","description":"Linq to database provider.","fork":false,"url":"https://api.github.com/repos/linq2db/linq2db","forks_url":"https://api.github.com/repos/linq2db/linq2db/forks","keys_url":"https://api.github.com/repos/linq2db/linq2db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linq2db/linq2db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linq2db/linq2db/teams","hooks_url":"https://api.github.com/repos/linq2db/linq2db/hooks","issue_events_url":"https://api.github.com/repos/linq2db/linq2db/issues/events{/number}","events_url":"https://api.github.com/repos/linq2db/linq2db/events","assignees_url":"https://api.github.com/repos/linq2db/linq2db/assignees{/user}","branches_url":"https://api.github.com/repos/linq2db/linq2db/branches{/branch}","tags_url":"https://api.github.com/repos/linq2db/linq2db/tags","blobs_url":"https://api.github.com/repos/linq2db/linq2db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linq2db/linq2db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linq2db/linq2db/git/refs{/sha}","trees_url":"https://api.github.com/repos/linq2db/linq2db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linq2db/linq2db/statuses/{sha}","languages_url":"https://api.github.com/repos/linq2db/linq2db/languages","stargazers_url":"https://api.github.com/repos/linq2db/linq2db/stargazers","contributors_url":"https://api.github.com/repos/linq2db/linq2db/contributors","subscribers_url":"https://api.github.com/repos/linq2db/linq2db/subscribers","subscription_url":"https://api.github.com/repos/linq2db/linq2db/subscription","commits_url":"https://api.github.com/repos/linq2db/linq2db/commits{/sha}","git_commits_url":"https://api.github.com/repos/linq2db/linq2db/git/commits{/sha}","comments_url":"https://api.github.com/repos/linq2db/linq2db/comments{/number}","issue_comment_url":"https://api.github.com/repos/linq2db/linq2db/issues/comments{/number}","contents_url":"https://api.github.com/repos/linq2db/linq2db/contents/{+path}","compare_url":"https://api.github.com/repos/linq2db/linq2db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linq2db/linq2db/merges","archive_url":"https://api.github.com/repos/linq2db/linq2db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linq2db/linq2db/downloads","issues_url":"https://api.github.com/repos/linq2db/linq2db/issues{/number}","pulls_url":"https://api.github.com/repos/linq2db/linq2db/pulls{/number}","milestones_url":"https://api.github.com/repos/linq2db/linq2db/milestones{/number}","notifications_url":"https://api.github.com/repos/linq2db/linq2db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linq2db/linq2db/labels{/name}","releases_url":"https://api.github.com/repos/linq2db/linq2db/releases{/id}","deployments_url":"https://api.github.com/repos/linq2db/linq2db/deployments","created_at":"2011-06-18T16:24:37Z","updated_at":"2018-03-25T14:20:30Z","pushed_at":"2018-03-25T17:02:11Z","git_url":"git://github.com/linq2db/linq2db.git","ssh_url":"git@github.com:linq2db/linq2db.git","clone_url":"https://github.com/linq2db/linq2db.git","svn_url":"https://github.com/linq2db/linq2db","homepage":"","size":426277,"stargazers_count":848,"watchers_count":848,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":200,"open_issues":154,"watchers":848,"default_branch":"master"}},"base":{"label":"linq2db:master","ref":"master","sha":"efb715ecebac5a9ba93a4a4d8d9ce49bef50b26e","user":{"login":"linq2db","id":865669,"avatar_url":"https://avatars3.githubusercontent.com/u/865669?v=4","gravatar_id":"","url":"https://api.github.com/users/linq2db","html_url":"https://github.com/linq2db","followers_url":"https://api.github.com/users/linq2db/followers","following_url":"https://api.github.com/users/linq2db/following{/other_user}","gists_url":"https://api.github.com/users/linq2db/gists{/gist_id}","starred_url":"https://api.github.com/users/linq2db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linq2db/subscriptions","organizations_url":"https://api.github.com/users/linq2db/orgs","repos_url":"https://api.github.com/users/linq2db/repos","events_url":"https://api.github.com/users/linq2db/events{/privacy}","received_events_url":"https://api.github.com/users/linq2db/received_events","type":"Organization","site_admin":false},"repo":{"id":1916228,"name":"linq2db","full_name":"linq2db/linq2db","owner":{"login":"linq2db","id":865669,"avatar_url":"https://avatars3.githubusercontent.com/u/865669?v=4","gravatar_id":"","url":"https://api.github.com/users/linq2db","html_url":"https://github.com/linq2db","followers_url":"https://api.github.com/users/linq2db/followers","following_url":"https://api.github.com/users/linq2db/following{/other_user}","gists_url":"https://api.github.com/users/linq2db/gists{/gist_id}","starred_url":"https://api.github.com/users/linq2db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linq2db/subscriptions","organizations_url":"https://api.github.com/users/linq2db/orgs","repos_url":"https://api.github.com/users/linq2db/repos","events_url":"https://api.github.com/users/linq2db/events{/privacy}","received_events_url":"https://api.github.com/users/linq2db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linq2db/linq2db","description":"Linq to database provider.","fork":false,"url":"https://api.github.com/repos/linq2db/linq2db","forks_url":"https://api.github.com/repos/linq2db/linq2db/forks","keys_url":"https://api.github.com/repos/linq2db/linq2db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linq2db/linq2db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linq2db/linq2db/teams","hooks_url":"https://api.github.com/repos/linq2db/linq2db/hooks","issue_events_url":"https://api.github.com/repos/linq2db/linq2db/issues/events{/number}","events_url":"https://api.github.com/repos/linq2db/linq2db/events","assignees_url":"https://api.github.com/repos/linq2db/linq2db/assignees{/user}","branches_url":"https://api.github.com/repos/linq2db/linq2db/branches{/branch}","tags_url":"https://api.github.com/repos/linq2db/linq2db/tags","blobs_url":"https://api.github.com/repos/linq2db/linq2db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linq2db/linq2db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linq2db/linq2db/git/refs{/sha}","trees_url":"https://api.github.com/repos/linq2db/linq2db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linq2db/linq2db/statuses/{sha}","languages_url":"https://api.github.com/repos/linq2db/linq2db/languages","stargazers_url":"https://api.github.com/repos/linq2db/linq2db/stargazers","contributors_url":"https://api.github.com/repos/linq2db/linq2db/contributors","subscribers_url":"https://api.github.com/repos/linq2db/linq2db/subscribers","subscription_url":"https://api.github.com/repos/linq2db/linq2db/subscription","commits_url":"https://api.github.com/repos/linq2db/linq2db/commits{/sha}","git_commits_url":"https://api.github.com/repos/linq2db/linq2db/git/commits{/sha}","comments_url":"https://api.github.com/repos/linq2db/linq2db/comments{/number}","issue_comment_url":"https://api.github.com/repos/linq2db/linq2db/issues/comments{/number}","contents_url":"https://api.github.com/repos/linq2db/linq2db/contents/{+path}","compare_url":"https://api.github.com/repos/linq2db/linq2db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linq2db/linq2db/merges","archive_url":"https://api.github.com/repos/linq2db/linq2db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linq2db/linq2db/downloads","issues_url":"https://api.github.com/repos/linq2db/linq2db/issues{/number}","pulls_url":"https://api.github.com/repos/linq2db/linq2db/pulls{/number}","milestones_url":"https://api.github.com/repos/linq2db/linq2db/milestones{/number}","notifications_url":"https://api.github.com/repos/linq2db/linq2db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linq2db/linq2db/labels{/name}","releases_url":"https://api.github.com/repos/linq2db/linq2db/releases{/id}","deployments_url":"https://api.github.com/repos/linq2db/linq2db/deployments","created_at":"2011-06-18T16:24:37Z","updated_at":"2018-03-25T14:20:30Z","pushed_at":"2018-03-25T17:02:11Z","git_url":"git://github.com/linq2db/linq2db.git","ssh_url":"git@github.com:linq2db/linq2db.git","clone_url":"https://github.com/linq2db/linq2db.git","svn_url":"https://github.com/linq2db/linq2db","homepage":"","size":426277,"stargazers_count":848,"watchers_count":848,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":200,"open_issues":154,"watchers":848,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linq2db/linq2db/pulls/1000"},"html":{"href":"https://github.com/linq2db/linq2db/pull/1000"},"issue":{"href":"https://api.github.com/repos/linq2db/linq2db/issues/1000"},"comments":{"href":"https://api.github.com/repos/linq2db/linq2db/issues/1000/comments"},"review_comments":{"href":"https://api.github.com/repos/linq2db/linq2db/pulls/1000/comments"},"review_comment":{"href":"https://api.github.com/repos/linq2db/linq2db/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linq2db/linq2db/pulls/1000/commits"},"statuses":{"href":"https://api.github.com/repos/linq2db/linq2db/statuses/b1588bb17a39b9332cb39d13ff4d7b2ac949d092"}},"author_association":"OWNER"}}
{"actor":{"display_login":"sdanyliv"}}