{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/pdk/issues/506","repository_url":"https://api.github.com/repos/puppetlabs/pdk","labels_url":"https://api.github.com/repos/puppetlabs/pdk/issues/506/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/pdk/issues/506/comments","events_url":"https://api.github.com/repos/puppetlabs/pdk/issues/506/events","html_url":"https://github.com/puppetlabs/pdk/pull/506","id":322157708,"number":506,"title":"(PDK-809) Exit early if the module is not PDK compatible","user":{"login":"rodjek","id":80629,"avatar_url":"https://avatars2.githubusercontent.com/u/80629?v=4","gravatar_id":"","url":"https://api.github.com/users/rodjek","html_url":"https://github.com/rodjek","followers_url":"https://api.github.com/users/rodjek/followers","following_url":"https://api.github.com/users/rodjek/following{/other_user}","gists_url":"https://api.github.com/users/rodjek/gists{/gist_id}","starred_url":"https://api.github.com/users/rodjek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodjek/subscriptions","organizations_url":"https://api.github.com/users/rodjek/orgs","repos_url":"https://api.github.com/users/rodjek/repos","events_url":"https://api.github.com/users/rodjek/events{/privacy}","received_events_url":"https://api.github.com/users/rodjek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-11T03:46:26Z","updated_at":"2018-05-11T03:59:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/puppetlabs/pdk/pulls/506","html_url":"https://github.com/puppetlabs/pdk/pull/506","diff_url":"https://github.com/puppetlabs/pdk/pull/506.diff","patch_url":"https://github.com/puppetlabs/pdk/pull/506.patch"},"body":"The current behaviour if you run `pdk validate` or `pdk test unit` on a module that hasn't been converted to be PDK compatible is to display a warning and attempt to continue anyway.\r\n\r\n```\r\nsemirhage :0: pdk/foo (git:master → origin ↑10 ?:1!)$ ../bin/pdk validate\r\npdk (WARN): This module is not PDK compatible. Run `pdk convert` to make it compatible with your version of PDK.\r\npdk (INFO): Running all available validators...\r\npdk (INFO): Using Ruby 2.4.4\r\npdk (INFO): Using Puppet 5.5.1\r\n[✔] Resolving default Gemfile dependencies.\r\n[✔] Checking metadata syntax (metadata.json tasks/*.json).\r\n[✔] Checking module metadata style (metadata.json).\r\n[✔] Checking Ruby code style (**/**.rb).\r\ninfo: task-metadata-lint: ./: Target does not contain any files to validate (tasks/*.json).\r\ninfo: puppet-syntax: ./: Target does not contain any files to validate (**/**.pp).\r\ninfo: puppet-lint: ./: Target does not contain any files to validate (**/*.pp).\r\n```\r\n\r\nWith this change, the PDK will instead display the message and exit early.\r\n\r\n```\r\nsemirhage :0: pdk/foo (git:pdk-809 U:2 ?:1!)$ ../bin/pdk validate\r\npdk (ERROR): This module is not PDK compatible. Run `pdk convert` to make it compatible with your version of PDK.\r\n```"},"comment":{"url":"https://api.github.com/repos/puppetlabs/pdk/issues/comments/388252983","html_url":"https://github.com/puppetlabs/pdk/pull/506#issuecomment-388252983","issue_url":"https://api.github.com/repos/puppetlabs/pdk/issues/506","id":388252983,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-05-11T03:59:49Z","updated_at":"2018-05-11T03:59:49Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/16933221/badge)](https://coveralls.io/builds/16933221)\n\nCoverage remained the same at 92.847% when pulling **df332eb0074b533154b3499c70840f9a3a6f1142 on rodjek:pdk-809** into **69f4332905fb22f935195ac71e149faaa8f64411 on puppetlabs:master**.\n"}}
{"actor":{"display_login":"coveralls"}}