{"action":"created","comment":{"url":"https://api.github.com/repos/tox-rs/tox/pulls/comments/180468626","pull_request_review_id":110893567,"id":180468626,"diff_hunk":"@@ -282,13 +297,13 @@ impl Server {\n     */\n     fn handle_ping_resp(&self, packet: PingResponse) -> IoFuture<()>\n     {\n-        let state = self.state.read();\n+        let mut state = self.state.write();\n         let payload = packet.get_payload(&self.sk);\n         let payload = match payload {\n-            Err(e) => {\n+            Err(_) => {\n                 return Box::new( future::err(\n                     Error::new(ErrorKind::Other,\n-                        format!(\"PingResponse::get_payload() failed: {:?}\", e)","path":"src/toxcore/dht/server.rs","position":41,"original_position":41,"commit_id":"56567add73ed2620899b2af9f523dd14998c2689","original_commit_id":"56567add73ed2620899b2af9f523dd14998c2689","user":{"login":"kpp","id":467709,"avatar_url":"https://avatars1.githubusercontent.com/u/467709?v=4","gravatar_id":"","url":"https://api.github.com/users/kpp","html_url":"https://github.com/kpp","followers_url":"https://api.github.com/users/kpp/followers","following_url":"https://api.github.com/users/kpp/following{/other_user}","gists_url":"https://api.github.com/users/kpp/gists{/gist_id}","starred_url":"https://api.github.com/users/kpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpp/subscriptions","organizations_url":"https://api.github.com/users/kpp/orgs","repos_url":"https://api.github.com/users/kpp/repos","events_url":"https://api.github.com/users/kpp/events{/privacy}","received_events_url":"https://api.github.com/users/kpp/received_events","type":"User","site_admin":false},"body":"???","created_at":"2018-04-10T15:37:47Z","updated_at":"2018-04-10T15:37:48Z","html_url":"https://github.com/tox-rs/tox/pull/73#discussion_r180468626","pull_request_url":"https://api.github.com/repos/tox-rs/tox/pulls/73","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/comments/180468626"},"html":{"href":"https://github.com/tox-rs/tox/pull/73#discussion_r180468626"},"pull_request":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/tox-rs/tox/pulls/73","id":178665413,"html_url":"https://github.com/tox-rs/tox/pull/73","diff_url":"https://github.com/tox-rs/tox/pull/73.diff","patch_url":"https://github.com/tox-rs/tox/pull/73.patch","issue_url":"https://api.github.com/repos/tox-rs/tox/issues/73","number":73,"state":"open","locked":false,"title":"feat(dht): remove timed out clients","user":{"login":"NamsooCho","id":10192129,"avatar_url":"https://avatars1.githubusercontent.com/u/10192129?v=4","gravatar_id":"","url":"https://api.github.com/users/NamsooCho","html_url":"https://github.com/NamsooCho","followers_url":"https://api.github.com/users/NamsooCho/followers","following_url":"https://api.github.com/users/NamsooCho/following{/other_user}","gists_url":"https://api.github.com/users/NamsooCho/gists{/gist_id}","starred_url":"https://api.github.com/users/NamsooCho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NamsooCho/subscriptions","organizations_url":"https://api.github.com/users/NamsooCho/orgs","repos_url":"https://api.github.com/users/NamsooCho/repos","events_url":"https://api.github.com/users/NamsooCho/events{/privacy}","received_events_url":"https://api.github.com/users/NamsooCho/received_events","type":"User","site_admin":false},"body":"Remove clients which is timed-out for 182 seconds","created_at":"2018-03-31T04:19:45Z","updated_at":"2018-04-10T15:37:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e1ba2014fdcd80d749eacfb63819040a60e2c46","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tox-rs/tox/pulls/73/commits","review_comments_url":"https://api.github.com/repos/tox-rs/tox/pulls/73/comments","review_comment_url":"https://api.github.com/repos/tox-rs/tox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tox-rs/tox/issues/73/comments","statuses_url":"https://api.github.com/repos/tox-rs/tox/statuses/56567add73ed2620899b2af9f523dd14998c2689","head":{"label":"tox-rs:remove_timeout","ref":"remove_timeout","sha":"56567add73ed2620899b2af9f523dd14998c2689","user":{"login":"tox-rs","id":35774911,"avatar_url":"https://avatars2.githubusercontent.com/u/35774911?v=4","gravatar_id":"","url":"https://api.github.com/users/tox-rs","html_url":"https://github.com/tox-rs","followers_url":"https://api.github.com/users/tox-rs/followers","following_url":"https://api.github.com/users/tox-rs/following{/other_user}","gists_url":"https://api.github.com/users/tox-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tox-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tox-rs/subscriptions","organizations_url":"https://api.github.com/users/tox-rs/orgs","repos_url":"https://api.github.com/users/tox-rs/repos","events_url":"https://api.github.com/users/tox-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tox-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":118792123,"name":"tox","full_name":"tox-rs/tox","owner":{"login":"tox-rs","id":35774911,"avatar_url":"https://avatars2.githubusercontent.com/u/35774911?v=4","gravatar_id":"","url":"https://api.github.com/users/tox-rs","html_url":"https://github.com/tox-rs","followers_url":"https://api.github.com/users/tox-rs/followers","following_url":"https://api.github.com/users/tox-rs/following{/other_user}","gists_url":"https://api.github.com/users/tox-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tox-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tox-rs/subscriptions","organizations_url":"https://api.github.com/users/tox-rs/orgs","repos_url":"https://api.github.com/users/tox-rs/repos","events_url":"https://api.github.com/users/tox-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tox-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tox-rs/tox","description":"toxcore implementation in Rust","fork":false,"url":"https://api.github.com/repos/tox-rs/tox","forks_url":"https://api.github.com/repos/tox-rs/tox/forks","keys_url":"https://api.github.com/repos/tox-rs/tox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tox-rs/tox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tox-rs/tox/teams","hooks_url":"https://api.github.com/repos/tox-rs/tox/hooks","issue_events_url":"https://api.github.com/repos/tox-rs/tox/issues/events{/number}","events_url":"https://api.github.com/repos/tox-rs/tox/events","assignees_url":"https://api.github.com/repos/tox-rs/tox/assignees{/user}","branches_url":"https://api.github.com/repos/tox-rs/tox/branches{/branch}","tags_url":"https://api.github.com/repos/tox-rs/tox/tags","blobs_url":"https://api.github.com/repos/tox-rs/tox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tox-rs/tox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tox-rs/tox/git/refs{/sha}","trees_url":"https://api.github.com/repos/tox-rs/tox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tox-rs/tox/statuses/{sha}","languages_url":"https://api.github.com/repos/tox-rs/tox/languages","stargazers_url":"https://api.github.com/repos/tox-rs/tox/stargazers","contributors_url":"https://api.github.com/repos/tox-rs/tox/contributors","subscribers_url":"https://api.github.com/repos/tox-rs/tox/subscribers","subscription_url":"https://api.github.com/repos/tox-rs/tox/subscription","commits_url":"https://api.github.com/repos/tox-rs/tox/commits{/sha}","git_commits_url":"https://api.github.com/repos/tox-rs/tox/git/commits{/sha}","comments_url":"https://api.github.com/repos/tox-rs/tox/comments{/number}","issue_comment_url":"https://api.github.com/repos/tox-rs/tox/issues/comments{/number}","contents_url":"https://api.github.com/repos/tox-rs/tox/contents/{+path}","compare_url":"https://api.github.com/repos/tox-rs/tox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tox-rs/tox/merges","archive_url":"https://api.github.com/repos/tox-rs/tox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tox-rs/tox/downloads","issues_url":"https://api.github.com/repos/tox-rs/tox/issues{/number}","pulls_url":"https://api.github.com/repos/tox-rs/tox/pulls{/number}","milestones_url":"https://api.github.com/repos/tox-rs/tox/milestones{/number}","notifications_url":"https://api.github.com/repos/tox-rs/tox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tox-rs/tox/labels{/name}","releases_url":"https://api.github.com/repos/tox-rs/tox/releases{/id}","deployments_url":"https://api.github.com/repos/tox-rs/tox/deployments","created_at":"2018-01-24T16:35:53Z","updated_at":"2018-04-10T11:32:24Z","pushed_at":"2018-04-10T14:48:22Z","git_url":"git://github.com/tox-rs/tox.git","ssh_url":"git@github.com:tox-rs/tox.git","clone_url":"https://github.com/tox-rs/tox.git","svn_url":"https://github.com/tox-rs/tox","homepage":"","size":1739,"stargazers_count":52,"watchers_count":52,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":5,"watchers":52,"default_branch":"master"}},"base":{"label":"tox-rs:master","ref":"master","sha":"1197ba133862dba615144e6b6166e95c4c14e3cf","user":{"login":"tox-rs","id":35774911,"avatar_url":"https://avatars2.githubusercontent.com/u/35774911?v=4","gravatar_id":"","url":"https://api.github.com/users/tox-rs","html_url":"https://github.com/tox-rs","followers_url":"https://api.github.com/users/tox-rs/followers","following_url":"https://api.github.com/users/tox-rs/following{/other_user}","gists_url":"https://api.github.com/users/tox-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tox-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tox-rs/subscriptions","organizations_url":"https://api.github.com/users/tox-rs/orgs","repos_url":"https://api.github.com/users/tox-rs/repos","events_url":"https://api.github.com/users/tox-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tox-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":118792123,"name":"tox","full_name":"tox-rs/tox","owner":{"login":"tox-rs","id":35774911,"avatar_url":"https://avatars2.githubusercontent.com/u/35774911?v=4","gravatar_id":"","url":"https://api.github.com/users/tox-rs","html_url":"https://github.com/tox-rs","followers_url":"https://api.github.com/users/tox-rs/followers","following_url":"https://api.github.com/users/tox-rs/following{/other_user}","gists_url":"https://api.github.com/users/tox-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tox-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tox-rs/subscriptions","organizations_url":"https://api.github.com/users/tox-rs/orgs","repos_url":"https://api.github.com/users/tox-rs/repos","events_url":"https://api.github.com/users/tox-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tox-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tox-rs/tox","description":"toxcore implementation in Rust","fork":false,"url":"https://api.github.com/repos/tox-rs/tox","forks_url":"https://api.github.com/repos/tox-rs/tox/forks","keys_url":"https://api.github.com/repos/tox-rs/tox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tox-rs/tox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tox-rs/tox/teams","hooks_url":"https://api.github.com/repos/tox-rs/tox/hooks","issue_events_url":"https://api.github.com/repos/tox-rs/tox/issues/events{/number}","events_url":"https://api.github.com/repos/tox-rs/tox/events","assignees_url":"https://api.github.com/repos/tox-rs/tox/assignees{/user}","branches_url":"https://api.github.com/repos/tox-rs/tox/branches{/branch}","tags_url":"https://api.github.com/repos/tox-rs/tox/tags","blobs_url":"https://api.github.com/repos/tox-rs/tox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tox-rs/tox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tox-rs/tox/git/refs{/sha}","trees_url":"https://api.github.com/repos/tox-rs/tox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tox-rs/tox/statuses/{sha}","languages_url":"https://api.github.com/repos/tox-rs/tox/languages","stargazers_url":"https://api.github.com/repos/tox-rs/tox/stargazers","contributors_url":"https://api.github.com/repos/tox-rs/tox/contributors","subscribers_url":"https://api.github.com/repos/tox-rs/tox/subscribers","subscription_url":"https://api.github.com/repos/tox-rs/tox/subscription","commits_url":"https://api.github.com/repos/tox-rs/tox/commits{/sha}","git_commits_url":"https://api.github.com/repos/tox-rs/tox/git/commits{/sha}","comments_url":"https://api.github.com/repos/tox-rs/tox/comments{/number}","issue_comment_url":"https://api.github.com/repos/tox-rs/tox/issues/comments{/number}","contents_url":"https://api.github.com/repos/tox-rs/tox/contents/{+path}","compare_url":"https://api.github.com/repos/tox-rs/tox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tox-rs/tox/merges","archive_url":"https://api.github.com/repos/tox-rs/tox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tox-rs/tox/downloads","issues_url":"https://api.github.com/repos/tox-rs/tox/issues{/number}","pulls_url":"https://api.github.com/repos/tox-rs/tox/pulls{/number}","milestones_url":"https://api.github.com/repos/tox-rs/tox/milestones{/number}","notifications_url":"https://api.github.com/repos/tox-rs/tox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tox-rs/tox/labels{/name}","releases_url":"https://api.github.com/repos/tox-rs/tox/releases{/id}","deployments_url":"https://api.github.com/repos/tox-rs/tox/deployments","created_at":"2018-01-24T16:35:53Z","updated_at":"2018-04-10T11:32:24Z","pushed_at":"2018-04-10T14:48:22Z","git_url":"git://github.com/tox-rs/tox.git","ssh_url":"git@github.com:tox-rs/tox.git","clone_url":"https://github.com/tox-rs/tox.git","svn_url":"https://github.com/tox-rs/tox","homepage":"","size":1739,"stargazers_count":52,"watchers_count":52,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":5,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/73"},"html":{"href":"https://github.com/tox-rs/tox/pull/73"},"issue":{"href":"https://api.github.com/repos/tox-rs/tox/issues/73"},"comments":{"href":"https://api.github.com/repos/tox-rs/tox/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/tox-rs/tox/statuses/56567add73ed2620899b2af9f523dd14998c2689"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kpp"}}