{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments/202504933","pull_request_review_id":137227678,"id":202504933,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUwNDkzMw==","diff_hunk":"@@ -472,9 +476,17 @@ bool OlaServer::InternalNewConnection(\n }\n \n void OlaServer::ReloadPluginsInternal() {\n+#ifdef HAVE_LIBSYSTEMD\n+  // Return value is intentionally not checked for both calls.\n+  // See return value section under sd_notify(3).\n+  sd_notify(0, \"RELOADING=1\\nSTATUS=Reloading plugins\\n\");\n+#endif  // HAVE_LIBSYSTEMD\n   OLA_INFO << \"Reloading plugins\";\n   StopPlugins();\n   m_plugin_manager->LoadAll();\n+#ifdef HAVE_LIBSYSTEMD\n+  sd_notify(0, \"READY=1\\nSTATUS=Plugin reload complete\\n\");","path":"olad/OlaServer.cpp","position":24,"original_position":24,"commit_id":"a30e4409a085a7a88516f9cc44485e8aa897652e","original_commit_id":"a30e4409a085a7a88516f9cc44485e8aa897652e","user":{"login":"shenghaoyang","id":10371596,"node_id":"MDQ6VXNlcjEwMzcxNTk2","avatar_url":"https://avatars0.githubusercontent.com/u/10371596?v=4","gravatar_id":"","url":"https://api.github.com/users/shenghaoyang","html_url":"https://github.com/shenghaoyang","followers_url":"https://api.github.com/users/shenghaoyang/followers","following_url":"https://api.github.com/users/shenghaoyang/following{/other_user}","gists_url":"https://api.github.com/users/shenghaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/shenghaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenghaoyang/subscriptions","organizations_url":"https://api.github.com/users/shenghaoyang/orgs","repos_url":"https://api.github.com/users/shenghaoyang/repos","events_url":"https://api.github.com/users/shenghaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/shenghaoyang/received_events","type":"User","site_admin":false},"body":"Ditto.","created_at":"2018-07-14T03:47:42Z","updated_at":"2018-07-14T03:47:42Z","html_url":"https://github.com/OpenLightingProject/ola/pull/1444#discussion_r202504933","pull_request_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1444","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments/202504933"},"html":{"href":"https://github.com/OpenLightingProject/ola/pull/1444#discussion_r202504933"},"pull_request":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1444"}},"in_reply_to_id":202499810},"pull_request":{"url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1444","id":200893898,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODkzODk4","html_url":"https://github.com/OpenLightingProject/ola/pull/1444","diff_url":"https://github.com/OpenLightingProject/ola/pull/1444.diff","patch_url":"https://github.com/OpenLightingProject/ola/pull/1444.patch","issue_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/1444","number":1444,"state":"open","locked":false,"title":"Add functionality to notify systemd on olad startup and config reload","user":{"login":"shenghaoyang","id":10371596,"node_id":"MDQ6VXNlcjEwMzcxNTk2","avatar_url":"https://avatars0.githubusercontent.com/u/10371596?v=4","gravatar_id":"","url":"https://api.github.com/users/shenghaoyang","html_url":"https://github.com/shenghaoyang","followers_url":"https://api.github.com/users/shenghaoyang/followers","following_url":"https://api.github.com/users/shenghaoyang/following{/other_user}","gists_url":"https://api.github.com/users/shenghaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/shenghaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenghaoyang/subscriptions","organizations_url":"https://api.github.com/users/shenghaoyang/orgs","repos_url":"https://api.github.com/users/shenghaoyang/repos","events_url":"https://api.github.com/users/shenghaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/shenghaoyang/received_events","type":"User","site_admin":false},"body":"- This helps users who run olad under the management of systemd to\r\n  order their services after olad startup, (i.e. starting up a daemon\r\n  that depends on the olad RPC socket being available), avoiding\r\n  the need for a manual delay.\r\n\r\n- If anyone's versed in autotools magic, please help check the\r\n  changes to `configure.ac`. I've only dabbled with autotools one\r\n  other time in my life, and I'm not sure if what I did was exactly correct.\r\n\r\n- Tested on my local machine with a unit file running the olad binary\r\n  as a notifying service. Reload messages tested as well. And I do\r\n  see the systemd generated reload notifications bounding the\r\n  output from olad during the reload process. \r\n\r\n- Not sure how we go about writing test cases for this, though. \r\n  Seems a bit pathological to formally test notification functionality, \r\n  but if the CI environment has `systemd` and `libsystemd` installed, \r\n  we could cook up a test for the notification functionality using \r\n  `systemd-run` - if the notification didn't go through, then\r\n  `systemd-run` should notify on an error starting the service.\r\n\r\nThanks for reviewing.\r\n\r\nShenghao","created_at":"2018-07-12T05:49:04Z","updated_at":"2018-07-14T03:47:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"416c52b9864dea123c6cb8c4a3f96062906a784e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/OpenLightingProject/ola/milestones/9","html_url":"https://github.com/OpenLightingProject/ola/milestone/9","labels_url":"https://api.github.com/repos/OpenLightingProject/ola/milestones/9/labels","id":1457508,"node_id":"MDk6TWlsZXN0b25lMTQ1NzUwOA==","number":9,"title":"0.11.0","description":"New features","creator":{"login":"peternewman","id":6216436,"node_id":"MDQ6VXNlcjYyMTY0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6216436?v=4","gravatar_id":"","url":"https://api.github.com/users/peternewman","html_url":"https://github.com/peternewman","followers_url":"https://api.github.com/users/peternewman/followers","following_url":"https://api.github.com/users/peternewman/following{/other_user}","gists_url":"https://api.github.com/users/peternewman/gists{/gist_id}","starred_url":"https://api.github.com/users/peternewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peternewman/subscriptions","organizations_url":"https://api.github.com/users/peternewman/orgs","repos_url":"https://api.github.com/users/peternewman/repos","events_url":"https://api.github.com/users/peternewman/events{/privacy}","received_events_url":"https://api.github.com/users/peternewman/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":156,"state":"open","created_at":"2015-12-12T22:03:07Z","updated_at":"2018-07-14T00:55:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1444/commits","review_comments_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1444/comments","review_comment_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/1444/comments","statuses_url":"https://api.github.com/repos/OpenLightingProject/ola/statuses/a30e4409a085a7a88516f9cc44485e8aa897652e","head":{"label":"shenghaoyang:add_notify","ref":"add_notify","sha":"a30e4409a085a7a88516f9cc44485e8aa897652e","user":{"login":"shenghaoyang","id":10371596,"node_id":"MDQ6VXNlcjEwMzcxNTk2","avatar_url":"https://avatars0.githubusercontent.com/u/10371596?v=4","gravatar_id":"","url":"https://api.github.com/users/shenghaoyang","html_url":"https://github.com/shenghaoyang","followers_url":"https://api.github.com/users/shenghaoyang/followers","following_url":"https://api.github.com/users/shenghaoyang/following{/other_user}","gists_url":"https://api.github.com/users/shenghaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/shenghaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenghaoyang/subscriptions","organizations_url":"https://api.github.com/users/shenghaoyang/orgs","repos_url":"https://api.github.com/users/shenghaoyang/repos","events_url":"https://api.github.com/users/shenghaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/shenghaoyang/received_events","type":"User","site_admin":false},"repo":{"id":132242756,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIyNDI3NTY=","name":"ola","full_name":"shenghaoyang/ola","owner":{"login":"shenghaoyang","id":10371596,"node_id":"MDQ6VXNlcjEwMzcxNTk2","avatar_url":"https://avatars0.githubusercontent.com/u/10371596?v=4","gravatar_id":"","url":"https://api.github.com/users/shenghaoyang","html_url":"https://github.com/shenghaoyang","followers_url":"https://api.github.com/users/shenghaoyang/followers","following_url":"https://api.github.com/users/shenghaoyang/following{/other_user}","gists_url":"https://api.github.com/users/shenghaoyang/gists{/gist_id}","starred_url":"https://api.github.com/users/shenghaoyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenghaoyang/subscriptions","organizations_url":"https://api.github.com/users/shenghaoyang/orgs","repos_url":"https://api.github.com/users/shenghaoyang/repos","events_url":"https://api.github.com/users/shenghaoyang/events{/privacy}","received_events_url":"https://api.github.com/users/shenghaoyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shenghaoyang/ola","description":"The Open Lighting Architecture - The Travel Adaptor for the Lighting Industry","fork":true,"url":"https://api.github.com/repos/shenghaoyang/ola","forks_url":"https://api.github.com/repos/shenghaoyang/ola/forks","keys_url":"https://api.github.com/repos/shenghaoyang/ola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shenghaoyang/ola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shenghaoyang/ola/teams","hooks_url":"https://api.github.com/repos/shenghaoyang/ola/hooks","issue_events_url":"https://api.github.com/repos/shenghaoyang/ola/issues/events{/number}","events_url":"https://api.github.com/repos/shenghaoyang/ola/events","assignees_url":"https://api.github.com/repos/shenghaoyang/ola/assignees{/user}","branches_url":"https://api.github.com/repos/shenghaoyang/ola/branches{/branch}","tags_url":"https://api.github.com/repos/shenghaoyang/ola/tags","blobs_url":"https://api.github.com/repos/shenghaoyang/ola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shenghaoyang/ola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shenghaoyang/ola/git/refs{/sha}","trees_url":"https://api.github.com/repos/shenghaoyang/ola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shenghaoyang/ola/statuses/{sha}","languages_url":"https://api.github.com/repos/shenghaoyang/ola/languages","stargazers_url":"https://api.github.com/repos/shenghaoyang/ola/stargazers","contributors_url":"https://api.github.com/repos/shenghaoyang/ola/contributors","subscribers_url":"https://api.github.com/repos/shenghaoyang/ola/subscribers","subscription_url":"https://api.github.com/repos/shenghaoyang/ola/subscription","commits_url":"https://api.github.com/repos/shenghaoyang/ola/commits{/sha}","git_commits_url":"https://api.github.com/repos/shenghaoyang/ola/git/commits{/sha}","comments_url":"https://api.github.com/repos/shenghaoyang/ola/comments{/number}","issue_comment_url":"https://api.github.com/repos/shenghaoyang/ola/issues/comments{/number}","contents_url":"https://api.github.com/repos/shenghaoyang/ola/contents/{+path}","compare_url":"https://api.github.com/repos/shenghaoyang/ola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shenghaoyang/ola/merges","archive_url":"https://api.github.com/repos/shenghaoyang/ola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shenghaoyang/ola/downloads","issues_url":"https://api.github.com/repos/shenghaoyang/ola/issues{/number}","pulls_url":"https://api.github.com/repos/shenghaoyang/ola/pulls{/number}","milestones_url":"https://api.github.com/repos/shenghaoyang/ola/milestones{/number}","notifications_url":"https://api.github.com/repos/shenghaoyang/ola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shenghaoyang/ola/labels{/name}","releases_url":"https://api.github.com/repos/shenghaoyang/ola/releases{/id}","deployments_url":"https://api.github.com/repos/shenghaoyang/ola/deployments","created_at":"2018-05-05T11:42:35Z","updated_at":"2018-05-05T11:42:41Z","pushed_at":"2018-07-12T05:31:11Z","git_url":"git://github.com/shenghaoyang/ola.git","ssh_url":"git@github.com:shenghaoyang/ola.git","clone_url":"https://github.com/shenghaoyang/ola.git","svn_url":"https://github.com/shenghaoyang/ola","homepage":"https://www.openlighting.org/ola/","size":21804,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenLightingProject:master","ref":"master","sha":"d1010976c47de23dc6031749179f8d92596b7e8d","user":{"login":"OpenLightingProject","id":6199314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxOTkzMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6199314?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLightingProject","html_url":"https://github.com/OpenLightingProject","followers_url":"https://api.github.com/users/OpenLightingProject/followers","following_url":"https://api.github.com/users/OpenLightingProject/following{/other_user}","gists_url":"https://api.github.com/users/OpenLightingProject/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLightingProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLightingProject/subscriptions","organizations_url":"https://api.github.com/users/OpenLightingProject/orgs","repos_url":"https://api.github.com/users/OpenLightingProject/repos","events_url":"https://api.github.com/users/OpenLightingProject/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLightingProject/received_events","type":"Organization","site_admin":false},"repo":{"id":15233168,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIzMzE2OA==","name":"ola","full_name":"OpenLightingProject/ola","owner":{"login":"OpenLightingProject","id":6199314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxOTkzMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6199314?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLightingProject","html_url":"https://github.com/OpenLightingProject","followers_url":"https://api.github.com/users/OpenLightingProject/followers","following_url":"https://api.github.com/users/OpenLightingProject/following{/other_user}","gists_url":"https://api.github.com/users/OpenLightingProject/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLightingProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLightingProject/subscriptions","organizations_url":"https://api.github.com/users/OpenLightingProject/orgs","repos_url":"https://api.github.com/users/OpenLightingProject/repos","events_url":"https://api.github.com/users/OpenLightingProject/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLightingProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenLightingProject/ola","description":"The Open Lighting Architecture - The Travel Adaptor for the Lighting Industry","fork":false,"url":"https://api.github.com/repos/OpenLightingProject/ola","forks_url":"https://api.github.com/repos/OpenLightingProject/ola/forks","keys_url":"https://api.github.com/repos/OpenLightingProject/ola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLightingProject/ola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLightingProject/ola/teams","hooks_url":"https://api.github.com/repos/OpenLightingProject/ola/hooks","issue_events_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLightingProject/ola/events","assignees_url":"https://api.github.com/repos/OpenLightingProject/ola/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLightingProject/ola/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLightingProject/ola/tags","blobs_url":"https://api.github.com/repos/OpenLightingProject/ola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLightingProject/ola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLightingProject/ola/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLightingProject/ola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLightingProject/ola/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLightingProject/ola/languages","stargazers_url":"https://api.github.com/repos/OpenLightingProject/ola/stargazers","contributors_url":"https://api.github.com/repos/OpenLightingProject/ola/contributors","subscribers_url":"https://api.github.com/repos/OpenLightingProject/ola/subscribers","subscription_url":"https://api.github.com/repos/OpenLightingProject/ola/subscription","commits_url":"https://api.github.com/repos/OpenLightingProject/ola/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLightingProject/ola/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLightingProject/ola/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLightingProject/ola/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLightingProject/ola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLightingProject/ola/merges","archive_url":"https://api.github.com/repos/OpenLightingProject/ola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLightingProject/ola/downloads","issues_url":"https://api.github.com/repos/OpenLightingProject/ola/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLightingProject/ola/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLightingProject/ola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLightingProject/ola/labels{/name}","releases_url":"https://api.github.com/repos/OpenLightingProject/ola/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLightingProject/ola/deployments","created_at":"2013-12-16T18:06:52Z","updated_at":"2018-07-12T21:26:46Z","pushed_at":"2018-07-14T01:00:59Z","git_url":"git://github.com/OpenLightingProject/ola.git","ssh_url":"git@github.com:OpenLightingProject/ola.git","clone_url":"https://github.com/OpenLightingProject/ola.git","svn_url":"https://github.com/OpenLightingProject/ola","homepage":"https://www.openlighting.org/ola/","size":21834,"stargazers_count":261,"watchers_count":261,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":121,"open_issues":166,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1444"},"html":{"href":"https://github.com/OpenLightingProject/ola/pull/1444"},"issue":{"href":"https://api.github.com/repos/OpenLightingProject/ola/issues/1444"},"comments":{"href":"https://api.github.com/repos/OpenLightingProject/ola/issues/1444/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1444/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/1444/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLightingProject/ola/statuses/a30e4409a085a7a88516f9cc44485e8aa897652e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shenghaoyang"}}