{"action":"created","issue":{"url":"https://api.github.com/repos/alibaba/pouch/issues/2083","repository_url":"https://api.github.com/repos/alibaba/pouch","labels_url":"https://api.github.com/repos/alibaba/pouch/issues/2083/labels{/name}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/2083/comments","events_url":"https://api.github.com/repos/alibaba/pouch/issues/2083/events","html_url":"https://github.com/alibaba/pouch/pull/2083","id":349958526,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTIyNDM0","number":2083,"title":"WIP bugfix: fix that ListVolumes did not implement filter by labels","user":{"login":"xiaoxubeii","id":912096,"node_id":"MDQ6VXNlcjkxMjA5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/912096?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaoxubeii","html_url":"https://github.com/xiaoxubeii","followers_url":"https://api.github.com/users/xiaoxubeii/followers","following_url":"https://api.github.com/users/xiaoxubeii/following{/other_user}","gists_url":"https://api.github.com/users/xiaoxubeii/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaoxubeii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaoxubeii/subscriptions","organizations_url":"https://api.github.com/users/xiaoxubeii/orgs","repos_url":"https://api.github.com/users/xiaoxubeii/repos","events_url":"https://api.github.com/users/xiaoxubeii/events{/privacy}","received_events_url":"https://api.github.com/users/xiaoxubeii/received_events","type":"User","site_admin":false},"labels":[{"id":684575943,"node_id":"MDU6TGFiZWw2ODQ1NzU5NDM=","url":"https://api.github.com/repos/alibaba/pouch/labels/kind/bug","name":"kind/bug","color":"f77e56","default":false},{"id":730467634,"node_id":"MDU6TGFiZWw3MzA0Njc2MzQ=","url":"https://api.github.com/repos/alibaba/pouch/labels/volume","name":"volume","color":"34ba7b","default":false}],"state":"open","locked":false,"assignee":{"login":"rudyfly","id":2264659,"node_id":"MDQ6VXNlcjIyNjQ2NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/2264659?v=4","gravatar_id":"","url":"https://api.github.com/users/rudyfly","html_url":"https://github.com/rudyfly","followers_url":"https://api.github.com/users/rudyfly/followers","following_url":"https://api.github.com/users/rudyfly/following{/other_user}","gists_url":"https://api.github.com/users/rudyfly/gists{/gist_id}","starred_url":"https://api.github.com/users/rudyfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudyfly/subscriptions","organizations_url":"https://api.github.com/users/rudyfly/orgs","repos_url":"https://api.github.com/users/rudyfly/repos","events_url":"https://api.github.com/users/rudyfly/events{/privacy}","received_events_url":"https://api.github.com/users/rudyfly/received_events","type":"User","site_admin":false},"assignees":[{"login":"rudyfly","id":2264659,"node_id":"MDQ6VXNlcjIyNjQ2NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/2264659?v=4","gravatar_id":"","url":"https://api.github.com/users/rudyfly","html_url":"https://github.com/rudyfly","followers_url":"https://api.github.com/users/rudyfly/followers","following_url":"https://api.github.com/users/rudyfly/following{/other_user}","gists_url":"https://api.github.com/users/rudyfly/gists{/gist_id}","starred_url":"https://api.github.com/users/rudyfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudyfly/subscriptions","organizations_url":"https://api.github.com/users/rudyfly/orgs","repos_url":"https://api.github.com/users/rudyfly/repos","events_url":"https://api.github.com/users/rudyfly/events{/privacy}","received_events_url":"https://api.github.com/users/rudyfly/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-08-13T09:44:10Z","updated_at":"2018-08-17T02:45:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/2083","html_url":"https://github.com/alibaba/pouch/pull/2083","diff_url":"https://github.com/alibaba/pouch/pull/2083.diff","patch_url":"https://github.com/alibaba/pouch/pull/2083.patch"},"body":"<!-- \r\nPlease make sure you have read and understood the contributing guidelines;\r\nhttps://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md -->\r\n\r\n### Ⅰ. Describe what this PR did\r\nFix `Core.ListVolumes` cannot filter volumes by labels.\r\n\r\n### Ⅱ. Does this pull request fix one issue?\r\n<!--If that, add \"fixes #xxxx\" below in the next line, for example, fixes #15. Otherwise, add \"NONE\" -->\r\nfixes #1817.\r\n\r\n### Ⅲ. Describe how you did it\r\nReference the codes.\r\n\r\n### Ⅳ. Describe how to verify it\r\nReference the testcase.\r\n\r\n### Ⅴ. Special notes for reviews\r\nNONE\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/alibaba/pouch/issues/comments/413741899","html_url":"https://github.com/alibaba/pouch/pull/2083#issuecomment-413741899","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/2083","id":413741899,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzc0MTg5OQ==","user":{"login":"xiaoxubeii","id":912096,"node_id":"MDQ6VXNlcjkxMjA5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/912096?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaoxubeii","html_url":"https://github.com/xiaoxubeii","followers_url":"https://api.github.com/users/xiaoxubeii/followers","following_url":"https://api.github.com/users/xiaoxubeii/following{/other_user}","gists_url":"https://api.github.com/users/xiaoxubeii/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaoxubeii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaoxubeii/subscriptions","organizations_url":"https://api.github.com/users/xiaoxubeii/orgs","repos_url":"https://api.github.com/users/xiaoxubeii/repos","events_url":"https://api.github.com/users/xiaoxubeii/events{/privacy}","received_events_url":"https://api.github.com/users/xiaoxubeii/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T02:45:44Z","updated_at":"2018-08-17T02:45:44Z","author_association":"CONTRIBUTOR","body":"@rudyfly You mean that we don't need default label when call `VolumeManager.List`:\r\n```\r\nfunc (vm *VolumeManager) List(ctx context.Context, labels map[string]string) ([]*types.Volume, error) {\r\n       // Remove default hostname label\r\n\tif _, ok := labels[\"hostname\"]; !ok {\r\n\t\thostname, err := os.Hostname()\r\n\t\tif err != nil {\r\n\t\t\treturn nil, err\r\n\t\t}\r\n\r\n\t\tlabels[\"hostname\"] = hostname\r\n\t}\r\n       // Remove default hostname label\r\n\r\n\treturn vm.core.ListVolumes(labels)\r\n}\r\n```"}}
{"actor":{"display_login":"xiaoxubeii"}}