{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments/204507996","pull_request_review_id":139587881,"id":204507996,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDUwNzk5Ng==","diff_hunk":"@@ -4,54 +4,40 @@\n #pragma once\n #include <experimental/filesystem>\n #include \"application.h\"\n-#include \"requesthandler.h\"\n+\n+enum PollingAppOfflineApplicationMode","path":"src/AspNetCoreModuleV2/CommonLib/PollingAppOfflineApplication.h","position":6,"original_position":6,"commit_id":"1979e3e3a84210aa2338c1c038fceda4ed50b74f","original_commit_id":"1979e3e3a84210aa2338c1c038fceda4ed50b74f","user":{"login":"jkotalik","id":8302101,"node_id":"MDQ6VXNlcjgzMDIxMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8302101?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotalik","html_url":"https://github.com/jkotalik","followers_url":"https://api.github.com/users/jkotalik/followers","following_url":"https://api.github.com/users/jkotalik/following{/other_user}","gists_url":"https://api.github.com/users/jkotalik/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotalik/subscriptions","organizations_url":"https://api.github.com/users/jkotalik/orgs","repos_url":"https://api.github.com/users/jkotalik/repos","events_url":"https://api.github.com/users/jkotalik/events{/privacy}","received_events_url":"https://api.github.com/users/jkotalik/received_events","type":"User","site_admin":false},"body":"Consider just having this be a bool.","created_at":"2018-07-23T18:25:54Z","updated_at":"2018-07-23T18:29:33Z","html_url":"https://github.com/aspnet/IISIntegration/pull/1071#discussion_r204507996","pull_request_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/1071","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments/204507996"},"html":{"href":"https://github.com/aspnet/IISIntegration/pull/1071#discussion_r204507996"},"pull_request":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/1071"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/1071","id":202068128,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDY4MTI4","html_url":"https://github.com/aspnet/IISIntegration/pull/1071","diff_url":"https://github.com/aspnet/IISIntegration/pull/1071.diff","patch_url":"https://github.com/aspnet/IISIntegration/pull/1071.patch","issue_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/1071","number":1071,"state":"open","locked":false,"title":"Fix another shutdown race and appofline race","user":{"login":"pakrym","id":1697911,"node_id":"MDQ6VXNlcjE2OTc5MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1697911?v=4","gravatar_id":"","url":"https://api.github.com/users/pakrym","html_url":"https://github.com/pakrym","followers_url":"https://api.github.com/users/pakrym/followers","following_url":"https://api.github.com/users/pakrym/following{/other_user}","gists_url":"https://api.github.com/users/pakrym/gists{/gist_id}","starred_url":"https://api.github.com/users/pakrym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakrym/subscriptions","organizations_url":"https://api.github.com/users/pakrym/orgs","repos_url":"https://api.github.com/users/pakrym/repos","events_url":"https://api.github.com/users/pakrym/events{/privacy}","received_events_url":"https://api.github.com/users/pakrym/received_events","type":"User","site_admin":false},"body":"Shutdown race was between ExtractApplication and EnsureApplicationCreated, the application might have been freed in between the calls.","created_at":"2018-07-17T20:59:41Z","updated_at":"2018-07-23T18:29:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"190de3062be8888bf692d326a5268fef1dc283fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/1071/commits","review_comments_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/1071/comments","review_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/1071/comments","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/1979e3e3a84210aa2338c1c038fceda4ed50b74f","head":{"label":"aspnet:pakrym/fix-shutdown-race2","ref":"pakrym/fix-shutdown-race2","sha":"1979e3e3a84210aa2338c1c038fceda4ed50b74f","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42883699,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjg4MzY5OQ==","name":"IISIntegration","full_name":"aspnet/IISIntegration","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/IISIntegration","description":"ASP.NET Core IIS integration","fork":false,"url":"https://api.github.com/repos/aspnet/IISIntegration","forks_url":"https://api.github.com/repos/aspnet/IISIntegration/forks","keys_url":"https://api.github.com/repos/aspnet/IISIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/IISIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/IISIntegration/teams","hooks_url":"https://api.github.com/repos/aspnet/IISIntegration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/IISIntegration/events","assignees_url":"https://api.github.com/repos/aspnet/IISIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/IISIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/IISIntegration/tags","blobs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/IISIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/IISIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/IISIntegration/languages","stargazers_url":"https://api.github.com/repos/aspnet/IISIntegration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/IISIntegration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/IISIntegration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/IISIntegration/subscription","commits_url":"https://api.github.com/repos/aspnet/IISIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/IISIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/IISIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/IISIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/IISIntegration/merges","archive_url":"https://api.github.com/repos/aspnet/IISIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/IISIntegration/downloads","issues_url":"https://api.github.com/repos/aspnet/IISIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/IISIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/IISIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/IISIntegration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/IISIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/IISIntegration/deployments","created_at":"2015-09-21T17:55:09Z","updated_at":"2018-07-23T15:57:47Z","pushed_at":"2018-07-23T18:17:45Z","git_url":"git://github.com/aspnet/IISIntegration.git","ssh_url":"git@github.com:aspnet/IISIntegration.git","clone_url":"https://github.com/aspnet/IISIntegration.git","svn_url":"https://github.com/aspnet/IISIntegration","homepage":"","size":11912,"stargazers_count":114,"watchers_count":114,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":44,"open_issues":116,"watchers":114,"default_branch":"release/2.2"}},"base":{"label":"aspnet:release/2.2","ref":"release/2.2","sha":"256aed83699aea838635aed65d1ec45f615e4533","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42883699,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjg4MzY5OQ==","name":"IISIntegration","full_name":"aspnet/IISIntegration","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/IISIntegration","description":"ASP.NET Core IIS integration","fork":false,"url":"https://api.github.com/repos/aspnet/IISIntegration","forks_url":"https://api.github.com/repos/aspnet/IISIntegration/forks","keys_url":"https://api.github.com/repos/aspnet/IISIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/IISIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/IISIntegration/teams","hooks_url":"https://api.github.com/repos/aspnet/IISIntegration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/IISIntegration/events","assignees_url":"https://api.github.com/repos/aspnet/IISIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/IISIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/IISIntegration/tags","blobs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/IISIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/IISIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/IISIntegration/languages","stargazers_url":"https://api.github.com/repos/aspnet/IISIntegration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/IISIntegration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/IISIntegration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/IISIntegration/subscription","commits_url":"https://api.github.com/repos/aspnet/IISIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/IISIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/IISIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/IISIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/IISIntegration/merges","archive_url":"https://api.github.com/repos/aspnet/IISIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/IISIntegration/downloads","issues_url":"https://api.github.com/repos/aspnet/IISIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/IISIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/IISIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/IISIntegration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/IISIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/IISIntegration/deployments","created_at":"2015-09-21T17:55:09Z","updated_at":"2018-07-23T15:57:47Z","pushed_at":"2018-07-23T18:17:45Z","git_url":"git://github.com/aspnet/IISIntegration.git","ssh_url":"git@github.com:aspnet/IISIntegration.git","clone_url":"https://github.com/aspnet/IISIntegration.git","svn_url":"https://github.com/aspnet/IISIntegration","homepage":"","size":11912,"stargazers_count":114,"watchers_count":114,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":44,"open_issues":116,"watchers":114,"default_branch":"release/2.2"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/1071"},"html":{"href":"https://github.com/aspnet/IISIntegration/pull/1071"},"issue":{"href":"https://api.github.com/repos/aspnet/IISIntegration/issues/1071"},"comments":{"href":"https://api.github.com/repos/aspnet/IISIntegration/issues/1071/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/1071/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/1071/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/IISIntegration/statuses/1979e3e3a84210aa2338c1c038fceda4ed50b74f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jkotalik"}}