{"action":"created","issue":{"url":"https://api.github.com/repos/jasmine/jasmine/issues/1473","repository_url":"https://api.github.com/repos/jasmine/jasmine","labels_url":"https://api.github.com/repos/jasmine/jasmine/issues/1473/labels{/name}","comments_url":"https://api.github.com/repos/jasmine/jasmine/issues/1473/comments","events_url":"https://api.github.com/repos/jasmine/jasmine/issues/1473/events","html_url":"https://github.com/jasmine/jasmine/pull/1473","id":285880969,"number":1473,"title":"Do not execute pending specs","user":{"login":"chrismwendt","id":1387653,"avatar_url":"https://avatars0.githubusercontent.com/u/1387653?v=4","gravatar_id":"","url":"https://api.github.com/users/chrismwendt","html_url":"https://github.com/chrismwendt","followers_url":"https://api.github.com/users/chrismwendt/followers","following_url":"https://api.github.com/users/chrismwendt/following{/other_user}","gists_url":"https://api.github.com/users/chrismwendt/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismwendt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismwendt/subscriptions","organizations_url":"https://api.github.com/users/chrismwendt/orgs","repos_url":"https://api.github.com/users/chrismwendt/repos","events_url":"https://api.github.com/users/chrismwendt/events{/privacy}","received_events_url":"https://api.github.com/users/chrismwendt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-01-04T04:47:25Z","updated_at":"2018-03-10T21:09:29Z","closed_at":"2018-03-10T21:09:29Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jasmine/jasmine/pulls/1473","html_url":"https://github.com/jasmine/jasmine/pull/1473","diff_url":"https://github.com/jasmine/jasmine/pull/1473.diff","patch_url":"https://github.com/jasmine/jasmine/pull/1473.patch"},"body":"## Description\r\n\r\nThis changes the implementation of `isExecutable` so that pending specs and suites without any executable specs are considered non-executable.\r\n\r\n## Motivation and Context\r\n\r\nPreviously, suites would needlessly execute beforeAll and afterAll when all of the specs were pending. This was causing lots of setup/teardown to occur for no reason.\r\n\r\nFixes #1265\r\n\r\n#1225 is similar, but was only concerned with **disabled** suites. In contrast, this change is concerned with **enabled** suites that have no executable specs or suites inside.\r\n\r\n## How Has This Been Tested?\r\n\r\n- This repo's test suite\r\n- Monkey patching Jasmine in an app that uses Protractor\r\n\r\n## Types of changes\r\n\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\nThis changes the conditions under which `specDone` executes, and probably has other side effects I'm not aware of at the moment.\r\n\r\n## Checklist:\r\n\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/jasmine/jasmine/issues/comments/372067157","html_url":"https://github.com/jasmine/jasmine/pull/1473#issuecomment-372067157","issue_url":"https://api.github.com/repos/jasmine/jasmine/issues/1473","id":372067157,"user":{"login":"sgravrock","id":2879775,"avatar_url":"https://avatars2.githubusercontent.com/u/2879775?v=4","gravatar_id":"","url":"https://api.github.com/users/sgravrock","html_url":"https://github.com/sgravrock","followers_url":"https://api.github.com/users/sgravrock/followers","following_url":"https://api.github.com/users/sgravrock/following{/other_user}","gists_url":"https://api.github.com/users/sgravrock/gists{/gist_id}","starred_url":"https://api.github.com/users/sgravrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgravrock/subscriptions","organizations_url":"https://api.github.com/users/sgravrock/orgs","repos_url":"https://api.github.com/users/sgravrock/repos","events_url":"https://api.github.com/users/sgravrock/events{/privacy}","received_events_url":"https://api.github.com/users/sgravrock/received_events","type":"User","site_admin":false},"created_at":"2018-03-10T21:09:29Z","updated_at":"2018-03-10T21:09:29Z","author_association":"OWNER","body":"I'm closing this since the underlying issue was fixed in 3.0. Feel free to open a new issue or PR if there's anything that we missed."}}
{"actor":{"display_login":"sgravrock"}}