{"action":"created","comment":{"url":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/comments/203421833","pull_request_review_id":138307298,"id":203421833,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQyMTgzMw==","diff_hunk":"@@ -2,21 +2,37 @@\n \n namespace Startup\\Models;\n \n+use Illuminate\\Database\\Eloquent\\Concerns\\HasTimestamps;\n use Illuminate\\Database\\Eloquent\\Model;\n use Laravel\\Cashier\\Billable;\n use Startup\\Traits\\HasSubscriptions;\n use Startup\\Traits\\HasTeam;\n \n-class Account extends Model\n+/**\n+ * @property    int                             $id\n+ * @property    string                          name\n+ * @property    int                             $owner_id\n+ * @property    string|null                     $billing_name\n+ * @property    string|null                     $stripe_id\n+ * @property    string|null                     $card_brand\n+ * @property    string|null                     $card_last_four\n+ * @property    \\Carbon\\Carbon                  $trial_ends_at\n+ * @property    \\Carbon\\Carbon                  $created_at\n+ * @property    \\Carbon\\Carbon                  $updated_at\n+ */\n+class Account extends Model implements \\JsonSerializable\n {\n-    use Billable, HasSubscriptions, HasTeam;\n+    use Billable, HasSubscriptions, HasTeam, HasTimestamps;","path":"app/Startup/Models/Account.php","position":26,"original_position":26,"commit_id":"37972c184569956681cb2aad5fa39de1dea81326","original_commit_id":"37972c184569956681cb2aad5fa39de1dea81326","user":{"login":"colynb","id":1049124,"node_id":"MDQ6VXNlcjEwNDkxMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1049124?v=4","gravatar_id":"","url":"https://api.github.com/users/colynb","html_url":"https://github.com/colynb","followers_url":"https://api.github.com/users/colynb/followers","following_url":"https://api.github.com/users/colynb/following{/other_user}","gists_url":"https://api.github.com/users/colynb/gists{/gist_id}","starred_url":"https://api.github.com/users/colynb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colynb/subscriptions","organizations_url":"https://api.github.com/users/colynb/orgs","repos_url":"https://api.github.com/users/colynb/repos","events_url":"https://api.github.com/users/colynb/events{/privacy}","received_events_url":"https://api.github.com/users/colynb/received_events","type":"User","site_admin":false},"body":"Doesn't the base Eloquent class already use this?","created_at":"2018-07-18T15:20:48Z","updated_at":"2018-07-18T15:20:49Z","html_url":"https://github.com/infrontlabs/laravel-startup/pull/1#discussion_r203421833","pull_request_url":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/comments/203421833"},"html":{"href":"https://github.com/infrontlabs/laravel-startup/pull/1#discussion_r203421833"},"pull_request":{"href":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/1","id":202140800,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTQwODAw","html_url":"https://github.com/infrontlabs/laravel-startup/pull/1","diff_url":"https://github.com/infrontlabs/laravel-startup/pull/1.diff","patch_url":"https://github.com/infrontlabs/laravel-startup/pull/1.patch","issue_url":"https://api.github.com/repos/infrontlabs/laravel-startup/issues/1","number":1,"state":"open","locked":false,"title":"Model serialization","user":{"login":"jamesvweston","id":12530200,"node_id":"MDQ6VXNlcjEyNTMwMjAw","avatar_url":"https://avatars2.githubusercontent.com/u/12530200?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesvweston","html_url":"https://github.com/jamesvweston","followers_url":"https://api.github.com/users/jamesvweston/followers","following_url":"https://api.github.com/users/jamesvweston/following{/other_user}","gists_url":"https://api.github.com/users/jamesvweston/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesvweston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesvweston/subscriptions","organizations_url":"https://api.github.com/users/jamesvweston/orgs","repos_url":"https://api.github.com/users/jamesvweston/repos","events_url":"https://api.github.com/users/jamesvweston/events{/privacy}","received_events_url":"https://api.github.com/users/jamesvweston/received_events","type":"User","site_admin":false},"body":"Colyn,\r\n\r\nI'm primarily creating this PR partly to show how I normally do this type of thing. Typically the task is created and assigned, branch is made, PR request made to the manager to review it, etc.\r\n\r\nBeyond that though this is mostly refactoring. Most migrations were modified to include foreign keys, created_at and updated_at fields were set to automatically be populated by the DB server, etc.\r\n\r\nAll models have php doc blocks on them. Most times I will also add doc blocks for relationships but haven't got there yet.\r\n\r\nI also added the Country and Address models & tables. I've used these in God knows how many projects and they're solid. Seeing as this is a boiler-plate package I think it's a good idea to include resources like this in it.","created_at":"2018-07-18T05:17:36Z","updated_at":"2018-07-18T15:20:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5118d540f799c14dcdb9b85372b0d1e90f29296","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/1/commits","review_comments_url":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/1/comments","review_comment_url":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infrontlabs/laravel-startup/issues/1/comments","statuses_url":"https://api.github.com/repos/infrontlabs/laravel-startup/statuses/37972c184569956681cb2aad5fa39de1dea81326","head":{"label":"infrontlabs:model_serialization","ref":"model_serialization","sha":"37972c184569956681cb2aad5fa39de1dea81326","user":{"login":"infrontlabs","id":30057124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMDU3MTI0","avatar_url":"https://avatars1.githubusercontent.com/u/30057124?v=4","gravatar_id":"","url":"https://api.github.com/users/infrontlabs","html_url":"https://github.com/infrontlabs","followers_url":"https://api.github.com/users/infrontlabs/followers","following_url":"https://api.github.com/users/infrontlabs/following{/other_user}","gists_url":"https://api.github.com/users/infrontlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/infrontlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infrontlabs/subscriptions","organizations_url":"https://api.github.com/users/infrontlabs/orgs","repos_url":"https://api.github.com/users/infrontlabs/repos","events_url":"https://api.github.com/users/infrontlabs/events{/privacy}","received_events_url":"https://api.github.com/users/infrontlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":135467414,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0Njc0MTQ=","name":"laravel-startup","full_name":"infrontlabs/laravel-startup","owner":{"login":"infrontlabs","id":30057124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMDU3MTI0","avatar_url":"https://avatars1.githubusercontent.com/u/30057124?v=4","gravatar_id":"","url":"https://api.github.com/users/infrontlabs","html_url":"https://github.com/infrontlabs","followers_url":"https://api.github.com/users/infrontlabs/followers","following_url":"https://api.github.com/users/infrontlabs/following{/other_user}","gists_url":"https://api.github.com/users/infrontlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/infrontlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infrontlabs/subscriptions","organizations_url":"https://api.github.com/users/infrontlabs/orgs","repos_url":"https://api.github.com/users/infrontlabs/repos","events_url":"https://api.github.com/users/infrontlabs/events{/privacy}","received_events_url":"https://api.github.com/users/infrontlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infrontlabs/laravel-startup","description":"Laravel Based SaaS Starting Point","fork":false,"url":"https://api.github.com/repos/infrontlabs/laravel-startup","forks_url":"https://api.github.com/repos/infrontlabs/laravel-startup/forks","keys_url":"https://api.github.com/repos/infrontlabs/laravel-startup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infrontlabs/laravel-startup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infrontlabs/laravel-startup/teams","hooks_url":"https://api.github.com/repos/infrontlabs/laravel-startup/hooks","issue_events_url":"https://api.github.com/repos/infrontlabs/laravel-startup/issues/events{/number}","events_url":"https://api.github.com/repos/infrontlabs/laravel-startup/events","assignees_url":"https://api.github.com/repos/infrontlabs/laravel-startup/assignees{/user}","branches_url":"https://api.github.com/repos/infrontlabs/laravel-startup/branches{/branch}","tags_url":"https://api.github.com/repos/infrontlabs/laravel-startup/tags","blobs_url":"https://api.github.com/repos/infrontlabs/laravel-startup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infrontlabs/laravel-startup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infrontlabs/laravel-startup/git/refs{/sha}","trees_url":"https://api.github.com/repos/infrontlabs/laravel-startup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infrontlabs/laravel-startup/statuses/{sha}","languages_url":"https://api.github.com/repos/infrontlabs/laravel-startup/languages","stargazers_url":"https://api.github.com/repos/infrontlabs/laravel-startup/stargazers","contributors_url":"https://api.github.com/repos/infrontlabs/laravel-startup/contributors","subscribers_url":"https://api.github.com/repos/infrontlabs/laravel-startup/subscribers","subscription_url":"https://api.github.com/repos/infrontlabs/laravel-startup/subscription","commits_url":"https://api.github.com/repos/infrontlabs/laravel-startup/commits{/sha}","git_commits_url":"https://api.github.com/repos/infrontlabs/laravel-startup/git/commits{/sha}","comments_url":"https://api.github.com/repos/infrontlabs/laravel-startup/comments{/number}","issue_comment_url":"https://api.github.com/repos/infrontlabs/laravel-startup/issues/comments{/number}","contents_url":"https://api.github.com/repos/infrontlabs/laravel-startup/contents/{+path}","compare_url":"https://api.github.com/repos/infrontlabs/laravel-startup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infrontlabs/laravel-startup/merges","archive_url":"https://api.github.com/repos/infrontlabs/laravel-startup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infrontlabs/laravel-startup/downloads","issues_url":"https://api.github.com/repos/infrontlabs/laravel-startup/issues{/number}","pulls_url":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls{/number}","milestones_url":"https://api.github.com/repos/infrontlabs/laravel-startup/milestones{/number}","notifications_url":"https://api.github.com/repos/infrontlabs/laravel-startup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infrontlabs/laravel-startup/labels{/name}","releases_url":"https://api.github.com/repos/infrontlabs/laravel-startup/releases{/id}","deployments_url":"https://api.github.com/repos/infrontlabs/laravel-startup/deployments","created_at":"2018-05-30T16:06:01Z","updated_at":"2018-07-18T04:27:37Z","pushed_at":"2018-07-18T05:17:37Z","git_url":"git://github.com/infrontlabs/laravel-startup.git","ssh_url":"git@github.com:infrontlabs/laravel-startup.git","clone_url":"https://github.com/infrontlabs/laravel-startup.git","svn_url":"https://github.com/infrontlabs/laravel-startup","homepage":"https://startup.infrontlabs.com","size":3177,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"infrontlabs:master","ref":"master","sha":"36d260202a29acb2164f8a4c596e723ef2952b86","user":{"login":"infrontlabs","id":30057124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMDU3MTI0","avatar_url":"https://avatars1.githubusercontent.com/u/30057124?v=4","gravatar_id":"","url":"https://api.github.com/users/infrontlabs","html_url":"https://github.com/infrontlabs","followers_url":"https://api.github.com/users/infrontlabs/followers","following_url":"https://api.github.com/users/infrontlabs/following{/other_user}","gists_url":"https://api.github.com/users/infrontlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/infrontlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infrontlabs/subscriptions","organizations_url":"https://api.github.com/users/infrontlabs/orgs","repos_url":"https://api.github.com/users/infrontlabs/repos","events_url":"https://api.github.com/users/infrontlabs/events{/privacy}","received_events_url":"https://api.github.com/users/infrontlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":135467414,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0Njc0MTQ=","name":"laravel-startup","full_name":"infrontlabs/laravel-startup","owner":{"login":"infrontlabs","id":30057124,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMDU3MTI0","avatar_url":"https://avatars1.githubusercontent.com/u/30057124?v=4","gravatar_id":"","url":"https://api.github.com/users/infrontlabs","html_url":"https://github.com/infrontlabs","followers_url":"https://api.github.com/users/infrontlabs/followers","following_url":"https://api.github.com/users/infrontlabs/following{/other_user}","gists_url":"https://api.github.com/users/infrontlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/infrontlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infrontlabs/subscriptions","organizations_url":"https://api.github.com/users/infrontlabs/orgs","repos_url":"https://api.github.com/users/infrontlabs/repos","events_url":"https://api.github.com/users/infrontlabs/events{/privacy}","received_events_url":"https://api.github.com/users/infrontlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infrontlabs/laravel-startup","description":"Laravel Based SaaS Starting Point","fork":false,"url":"https://api.github.com/repos/infrontlabs/laravel-startup","forks_url":"https://api.github.com/repos/infrontlabs/laravel-startup/forks","keys_url":"https://api.github.com/repos/infrontlabs/laravel-startup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infrontlabs/laravel-startup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infrontlabs/laravel-startup/teams","hooks_url":"https://api.github.com/repos/infrontlabs/laravel-startup/hooks","issue_events_url":"https://api.github.com/repos/infrontlabs/laravel-startup/issues/events{/number}","events_url":"https://api.github.com/repos/infrontlabs/laravel-startup/events","assignees_url":"https://api.github.com/repos/infrontlabs/laravel-startup/assignees{/user}","branches_url":"https://api.github.com/repos/infrontlabs/laravel-startup/branches{/branch}","tags_url":"https://api.github.com/repos/infrontlabs/laravel-startup/tags","blobs_url":"https://api.github.com/repos/infrontlabs/laravel-startup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infrontlabs/laravel-startup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infrontlabs/laravel-startup/git/refs{/sha}","trees_url":"https://api.github.com/repos/infrontlabs/laravel-startup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infrontlabs/laravel-startup/statuses/{sha}","languages_url":"https://api.github.com/repos/infrontlabs/laravel-startup/languages","stargazers_url":"https://api.github.com/repos/infrontlabs/laravel-startup/stargazers","contributors_url":"https://api.github.com/repos/infrontlabs/laravel-startup/contributors","subscribers_url":"https://api.github.com/repos/infrontlabs/laravel-startup/subscribers","subscription_url":"https://api.github.com/repos/infrontlabs/laravel-startup/subscription","commits_url":"https://api.github.com/repos/infrontlabs/laravel-startup/commits{/sha}","git_commits_url":"https://api.github.com/repos/infrontlabs/laravel-startup/git/commits{/sha}","comments_url":"https://api.github.com/repos/infrontlabs/laravel-startup/comments{/number}","issue_comment_url":"https://api.github.com/repos/infrontlabs/laravel-startup/issues/comments{/number}","contents_url":"https://api.github.com/repos/infrontlabs/laravel-startup/contents/{+path}","compare_url":"https://api.github.com/repos/infrontlabs/laravel-startup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infrontlabs/laravel-startup/merges","archive_url":"https://api.github.com/repos/infrontlabs/laravel-startup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infrontlabs/laravel-startup/downloads","issues_url":"https://api.github.com/repos/infrontlabs/laravel-startup/issues{/number}","pulls_url":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls{/number}","milestones_url":"https://api.github.com/repos/infrontlabs/laravel-startup/milestones{/number}","notifications_url":"https://api.github.com/repos/infrontlabs/laravel-startup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infrontlabs/laravel-startup/labels{/name}","releases_url":"https://api.github.com/repos/infrontlabs/laravel-startup/releases{/id}","deployments_url":"https://api.github.com/repos/infrontlabs/laravel-startup/deployments","created_at":"2018-05-30T16:06:01Z","updated_at":"2018-07-18T04:27:37Z","pushed_at":"2018-07-18T05:17:37Z","git_url":"git://github.com/infrontlabs/laravel-startup.git","ssh_url":"git@github.com:infrontlabs/laravel-startup.git","clone_url":"https://github.com/infrontlabs/laravel-startup.git","svn_url":"https://github.com/infrontlabs/laravel-startup","homepage":"https://startup.infrontlabs.com","size":3177,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/1"},"html":{"href":"https://github.com/infrontlabs/laravel-startup/pull/1"},"issue":{"href":"https://api.github.com/repos/infrontlabs/laravel-startup/issues/1"},"comments":{"href":"https://api.github.com/repos/infrontlabs/laravel-startup/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infrontlabs/laravel-startup/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/infrontlabs/laravel-startup/statuses/37972c184569956681cb2aad5fa39de1dea81326"}},"author_association":"NONE"}}
{"actor":{"display_login":"colynb"}}