{"action":"created","issue":{"url":"https://api.github.com/repos/fetchrobotics/fetch_ros/issues/82","repository_url":"https://api.github.com/repos/fetchrobotics/fetch_ros","labels_url":"https://api.github.com/repos/fetchrobotics/fetch_ros/issues/82/labels{/name}","comments_url":"https://api.github.com/repos/fetchrobotics/fetch_ros/issues/82/comments","events_url":"https://api.github.com/repos/fetchrobotics/fetch_ros/issues/82/events","html_url":"https://github.com/fetchrobotics/fetch_ros/pull/82","id":343441986,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDc4NzQ0","number":82,"title":"[fetch_depth_layer] Melodic: Update depth_layer no match for ‘operator=’ error","user":{"login":"josiahls","id":19930483,"node_id":"MDQ6VXNlcjE5OTMwNDgz","avatar_url":"https://avatars3.githubusercontent.com/u/19930483?v=4","gravatar_id":"","url":"https://api.github.com/users/josiahls","html_url":"https://github.com/josiahls","followers_url":"https://api.github.com/users/josiahls/followers","following_url":"https://api.github.com/users/josiahls/following{/other_user}","gists_url":"https://api.github.com/users/josiahls/gists{/gist_id}","starred_url":"https://api.github.com/users/josiahls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josiahls/subscriptions","organizations_url":"https://api.github.com/users/josiahls/orgs","repos_url":"https://api.github.com/users/josiahls/repos","events_url":"https://api.github.com/users/josiahls/events{/privacy}","received_events_url":"https://api.github.com/users/josiahls/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-22T21:51:00Z","updated_at":"2018-07-22T23:08:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/fetchrobotics/fetch_ros/pulls/82","html_url":"https://github.com/fetchrobotics/fetch_ros/pull/82","diff_url":"https://github.com/fetchrobotics/fetch_ros/pull/82.diff","patch_url":"https://github.com/fetchrobotics/fetch_ros/pull/82.patch"},"body":"I recently checked out this branch and attempted to run catkin_make. There was an issue with how the cv::Ptr was being set. \r\n\r\nThis is fixed by setting the normals_estimator_ pointer similarly to how the plane_estimator_ pointer is being set. The package can now compile. I am confused why I needed to change this, but I am curious to learn why. Obviously test this to make sure it actually runs, which I what I will be doing very soon.\r\n\r\nNote, as of 7/22/2018 I have been referencing #81 to get this to work, and modified the files specified in that issue along with my one commit.\r\n\r\nThe error below would occur:\r\n[ 97%] Building CXX object navigation/move_base/CMakeFiles/move_base.dir/src/move_base.cpp.o\r\n/home/josiah/PycharmProjects/fetch_robot_ws/src/fetch_ros/fetch_depth_layer/src/depth_layer.cpp: In member function ‘void costmap_2d::FetchDepthLayer::depthImageCallback(const ConstPtr&)’:\r\n/home/josiah/PycharmProjects/fetch_robot_ws/src/fetch_ros/fetch_depth_layer/src/depth_layer.cpp:239:28: error: no match for ‘operator=’ (operand types are ‘cv::Ptr<cv::rgbd::RgbdNormals>’ and ‘cv::rgbd::RgbdNormals*’)\r\n       normals_estimator_ = new RgbdNormals(cv_ptr->image.rows,cv_ptr->image.cols,  cv_ptr->image.depth(),K_);\r\n                            ^~~~\r\nIn file included from /usr/local/include/opencv2/core/cvstd.hpp:1033:0,\r\n                 from /usr/local/include/opencv2/core/base.hpp:58,\r\n                 from /usr/local/include/opencv2/core.hpp:54,\r\n                 from /usr/local/include/opencv2/core/core.hpp:48,\r\n                 from /opt/ros/melodic/include/cv_bridge/cv_bridge.h:43,\r\n                 from /home/josiah/PycharmProjects/fetch_robot_ws/src/fetch_ros/fetch_depth_layer/include/fetch_depth_layer/depth_layer.h:37,\r\n                 from /home/josiah/PycharmProjects/fetch_robot_ws/src/fetch_ros/fetch_depth_layer/src/depth_layer.cpp:32:\r\n/usr/local/include/opencv2/core/ptr.inl.hpp:160:9: note: candidate: cv::Ptr<T>& cv::Ptr<T>::operator=(const cv::Ptr<T>&) [with T = cv::rgbd::RgbdNormals]\r\n Ptr<T>& Ptr<T>::operator = (const Ptr<T>& o)\r\n         ^~~~~~\r\n/usr/local/include/opencv2/core/ptr.inl.hpp:160:9: note:   no known conversion for argument 1 from ‘cv::rgbd::RgbdNormals*’ to ‘const cv::Ptr<cv::rgbd::RgbdNormals>&’\r\nIn file included from /usr/local/include/opencv2/core/base.hpp:58:0,\r\n                 from /usr/local/include/opencv2/core.hpp:54,\r\n                 from /usr/local/include/opencv2/core/core.hpp:48,\r\n                 from /opt/ros/melodic/include/cv_bridge/cv_bridge.h:43,\r\n                 from /home/josiah/PycharmProjects/fetch_robot_ws/src/fetch_ros/fetch_depth_layer/include/fetch_depth_layer/depth_layer.h:37,\r\n                 from /home/josiah/PycharmProjects/fetch_robot_ws/src/fetch_ros/fetch_depth_layer/src/depth_layer.cpp:32:\r\n/usr/local/include/opencv2/core/cvstd.hpp:333:10: note: candidate: template<class Y> cv::Ptr<T>& cv::Ptr<T>::operator=(const cv::Ptr<Y>&) [with Y = Y; T = cv::rgbd::RgbdNormals]\r\n     Ptr& operator = (const Ptr<Y>& o);\r\n          ^~~~~~~~\r\n/usr/local/include/opencv2/core/cvstd.hpp:333:10: note:   template argument deduction/substitution failed:\r\n/home/josiah/PycharmProjects/fetch_robot_ws/src/fetch_ros/fetch_depth_layer/src/depth_layer.cpp:239:28: note:   mismatched types ‘const cv::Ptr<T>’ and ‘cv::rgbd::RgbdNormals*’\r\n       normals_estimator_ = temp;\r\n                            ^~~~\r\nIn file included from /usr/local/include/opencv2/core/cvstd.hpp:1033:0,\r\n                 from /usr/local/include/opencv2/core/base.hpp:58,\r\n                 from /usr/local/include/opencv2/core.hpp:54,\r\n                 from /usr/local/include/opencv2/core/core.hpp:48,\r\n                 from /opt/ros/melodic/include/cv_bridge/cv_bridge.h:43,\r\n                 from /home/josiah/PycharmProjects/fetch_robot_ws/src/fetch_ros/fetch_depth_layer/include/fetch_depth_layer/depth_layer.h:37,\r\n                 from /home/josiah/PycharmProjects/fetch_robot_ws/src/fetch_ros/fetch_depth_layer/src/depth_layer.cpp:32:\r\n/usr/local/include/opencv2/core/ptr.inl.hpp:263:9: note: candidate: cv::Ptr<T>& cv::Ptr<T>::operator=(cv::Ptr<T>&&) [with T = cv::rgbd::RgbdNormals]\r\n Ptr<T>& Ptr<T>::operator = (Ptr<T>&& o)\r\n         ^~~~~~\r\n/usr/local/include/opencv2/core/ptr.inl.hpp:263:9: note:   no known conversion for argument 1 from ‘cv::rgbd::RgbdNormals*’ to ‘cv::Ptr<cv::rgbd::RgbdNormals>&&’\r\nfetch_ros/fetch_depth_layer/CMakeFiles/fetch_depth_layer.dir/build.make:62: recipe for target 'fetch_ros/fetch_depth_layer/CMakeFiles/fetch_depth_layer.dir/src/depth_layer.cpp.o' failed\r\nmake[2]: *** [fetch_ros/fetch_depth_layer/CMakeFiles/fetch_depth_layer.dir/src/depth_layer.cpp.o] Error 1\r\nCMakeFiles/Makefile2:10133: recipe for target 'fetch_ros/fetch_depth_layer/CMakeFiles/fetch_depth_layer.dir/all' failed\r\nmake[1]: *** [fetch_ros/fetch_depth_layer/CMakeFiles/fetch_depth_layer.dir/all] Error 2\r\nmake[1]: *** Waiting for unfinished jobs....\r\n[ 98%] Linking CXX shared library /home/josiah/PycharmProjects/fetch_robot_ws/devel/lib/libmove_base.so\r\n[ 98%] Built target move_base\r\nMakefile:140: recipe for target 'all' failed\r\nmake: *** [all] Error 2\r\nInvoking \"make -j4 -l4\" failed"},"comment":{"url":"https://api.github.com/repos/fetchrobotics/fetch_ros/issues/comments/406904390","html_url":"https://github.com/fetchrobotics/fetch_ros/pull/82#issuecomment-406904390","issue_url":"https://api.github.com/repos/fetchrobotics/fetch_ros/issues/82","id":406904390,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjkwNDM5MA==","user":{"login":"moriarty","id":55676,"node_id":"MDQ6VXNlcjU1Njc2","avatar_url":"https://avatars3.githubusercontent.com/u/55676?v=4","gravatar_id":"","url":"https://api.github.com/users/moriarty","html_url":"https://github.com/moriarty","followers_url":"https://api.github.com/users/moriarty/followers","following_url":"https://api.github.com/users/moriarty/following{/other_user}","gists_url":"https://api.github.com/users/moriarty/gists{/gist_id}","starred_url":"https://api.github.com/users/moriarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moriarty/subscriptions","organizations_url":"https://api.github.com/users/moriarty/orgs","repos_url":"https://api.github.com/users/moriarty/repos","events_url":"https://api.github.com/users/moriarty/events{/privacy}","received_events_url":"https://api.github.com/users/moriarty/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T23:08:37Z","updated_at":"2018-07-22T23:08:37Z","author_association":"MEMBER","body":"It's strange that I can't reproduce this compile error.\r\nI recently cleaned up my work-space when I found #80 \r\n\r\nNow that the ros-planning/navigation#755 is merged, we can merge in #81.\r\n\r\nFirst, I'll delete my work-space and try to reproduce.\r\n\r\nCan you provide some info on how you installed OpenCV? And which version it is?\r\n\r\nAlso, before accepting this could you clean up the commit message a bit?\r\nthe first bit is fine it doesn't need _so much_ compile error output.\r\nhttps://chris.beams.io/posts/git-commit/"}}
{"actor":{"display_login":"moriarty"}}