{"action":"opened","issue":{"url":"https://api.github.com/repos/debbiemarkslab/EVcouplings/issues/195","repository_url":"https://api.github.com/repos/debbiemarkslab/EVcouplings","labels_url":"https://api.github.com/repos/debbiemarkslab/EVcouplings/issues/195/labels{/name}","comments_url":"https://api.github.com/repos/debbiemarkslab/EVcouplings/issues/195/comments","events_url":"https://api.github.com/repos/debbiemarkslab/EVcouplings/issues/195/events","html_url":"https://github.com/debbiemarkslab/EVcouplings/issues/195","id":386297116,"node_id":"MDU6SXNzdWUzODYyOTcxMTY=","number":195,"title":"Consistency with _files keys?","user":{"login":"sacdallago","id":6240943,"node_id":"MDQ6VXNlcjYyNDA5NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/6240943?v=4","gravatar_id":"","url":"https://api.github.com/users/sacdallago","html_url":"https://github.com/sacdallago","followers_url":"https://api.github.com/users/sacdallago/followers","following_url":"https://api.github.com/users/sacdallago/following{/other_user}","gists_url":"https://api.github.com/users/sacdallago/gists{/gist_id}","starred_url":"https://api.github.com/users/sacdallago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sacdallago/subscriptions","organizations_url":"https://api.github.com/users/sacdallago/orgs","repos_url":"https://api.github.com/users/sacdallago/repos","events_url":"https://api.github.com/users/sacdallago/events{/privacy}","received_events_url":"https://api.github.com/users/sacdallago/received_events","type":"User","site_admin":false},"labels":[{"id":749080684,"node_id":"MDU6TGFiZWw3NDkwODA2ODQ=","url":"https://api.github.com/repos/debbiemarkslab/EVcouplings/labels/discussion","name":"discussion","color":"e99695","default":false},{"id":744492586,"node_id":"MDU6TGFiZWw3NDQ0OTI1ODY=","url":"https://api.github.com/repos/debbiemarkslab/EVcouplings/labels/prio:%20low","name":"prio: low","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-30T18:19:09Z","updated_at":"2018-11-30T18:19:09Z","closed_at":null,"author_association":"MEMBER","body":"This is an annoying issue (I'm sorry), and it has to do mainly with consistency.\r\n\r\nUsually, when `*_files` keys are encountered in the out config, they are lists of files. That is not the case with `remapped_pdb_files`, where the `*_files` key points to a dictionary where the keys of the dictionary are the filenames and the value of the dictionary entry is an int cross-referencing the structure hits file.\r\n\r\nThis doesn't really produce any issue so far for creating the final archive or writing the file to an external source (like is needed in the web runs), but IMO it is inconsistent and creates a bit of confusion. If type checks were in place, this would definitely create an exception (dictionary vs. list).\r\n\r\nI think it would be better to use a list for these files and outsource the mapping from filename to structure hit in another outconfig key, or even embed this mapping in the structure hits file."}}
{"actor":{"display_login":"sacdallago"}}