{"action":"created","issue":{"url":"https://api.github.com/repos/avelino/awesome-go/issues/1807","repository_url":"https://api.github.com/repos/avelino/awesome-go","labels_url":"https://api.github.com/repos/avelino/awesome-go/issues/1807/labels{/name}","comments_url":"https://api.github.com/repos/avelino/awesome-go/issues/1807/comments","events_url":"https://api.github.com/repos/avelino/awesome-go/issues/1807/events","html_url":"https://github.com/avelino/awesome-go/pull/1807","id":297472941,"number":1807,"title":"Add go-prompt","user":{"login":"c-bata","id":5564044,"avatar_url":"https://avatars3.githubusercontent.com/u/5564044?v=4","gravatar_id":"","url":"https://api.github.com/users/c-bata","html_url":"https://github.com/c-bata","followers_url":"https://api.github.com/users/c-bata/followers","following_url":"https://api.github.com/users/c-bata/following{/other_user}","gists_url":"https://api.github.com/users/c-bata/gists{/gist_id}","starred_url":"https://api.github.com/users/c-bata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-bata/subscriptions","organizations_url":"https://api.github.com/users/c-bata/orgs","repos_url":"https://api.github.com/users/c-bata/repos","events_url":"https://api.github.com/users/c-bata/events{/privacy}","received_events_url":"https://api.github.com/users/c-bata/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-15T14:51:09Z","updated_at":"2018-02-15T15:18:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/avelino/awesome-go/pulls/1807","html_url":"https://github.com/avelino/awesome-go/pull/1807","diff_url":"https://github.com/avelino/awesome-go/pull/1807.diff","patch_url":"https://github.com/avelino/awesome-go/pull/1807.patch"},"body":"Please check if what you want to add to `awesome-go` list meets [quality standards](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#quality-standard) before sending pull request. Thanks!\r\n\r\n**Please provide package links to:**\r\n\r\n- github.com repo: https://github.com/c-bata/go-prompt\r\n- godoc.org: https://godoc.org/github.com/c-bata/go-promp\r\n- goreportcard.com: https://goreportcard.com/report/github.com/c-bata/go-prompt\r\n- coverage service link: [gocover](https://gocover.io/github.com/c-bata/go-prompt)\r\n\r\nVery good coverage\r\n\r\n**Note**: that new categories can be added only when there are 3 packages or more.\r\n\r\n**Make sure that you've checked the boxes below before you submit PR:**\r\n- [x] I have added my package in alphabetical order.\r\n- [x] I have an appropriate description with correct grammar.\r\n- [x] I know that this package was not listed before.\r\n- [x] I have added godoc link to the repo and to my pull request.\r\n- [x] I have added coverage service link to the repo and to my pull request.\r\n- [x] I have added goreportcard link to the repo and to my pull request.\r\n- [x] I have read [Contribution guidelines](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#contribution-guidelines), [maintainers note](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#maintainers) and [Quality standard](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#quality-standard).\r\n\r\nThanks for your PR, you're awesome! :+1:\r\n"},"comment":{"url":"https://api.github.com/repos/avelino/awesome-go/issues/comments/365958473","html_url":"https://github.com/avelino/awesome-go/pull/1807#issuecomment-365958473","issue_url":"https://api.github.com/repos/avelino/awesome-go/issues/1807","id":365958473,"user":{"login":"c-bata","id":5564044,"avatar_url":"https://avatars3.githubusercontent.com/u/5564044?v=4","gravatar_id":"","url":"https://api.github.com/users/c-bata","html_url":"https://github.com/c-bata","followers_url":"https://api.github.com/users/c-bata/followers","following_url":"https://api.github.com/users/c-bata/following{/other_user}","gists_url":"https://api.github.com/users/c-bata/gists{/gist_id}","starred_url":"https://api.github.com/users/c-bata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-bata/subscriptions","organizations_url":"https://api.github.com/users/c-bata/orgs","repos_url":"https://api.github.com/users/c-bata/repos","events_url":"https://api.github.com/users/c-bata/events{/privacy}","received_events_url":"https://api.github.com/users/c-bata/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T15:18:50Z","updated_at":"2018-02-15T15:18:50Z","author_association":"NONE","body":"It seems that two people submitted and rejected of proposals to add go-prompt before because it lacks some godoc comments (refs #1576 and #1640). Recently, I write all godoc comments of go-prompt and now go-prompt scored A+ on goreportcard.com\r\n\r\ngo-prompt probably won't fill quality standards of awesome-go despite the test coverage. I couldn't write valuable tests for rendering process. I think there is no value to check that go-prompt writes what's control byte sequences. The most important things is how properly visualized on many terminal emulators (i.e. iTerm2, GNOME and Win32 Console) they have different behaviors.\r\n\r\nI hope the coverage percentage does not prevent this project from being included.\r\n\r\nThanks."}}
{"actor":{"display_login":"c-bata"}}