{"action":"created","comment":{"url":"https://api.github.com/repos/libopenstorage/stork/pulls/comments/186186526","pull_request_review_id":117725895,"id":186186526,"diff_hunk":"@@ -68,3 +72,73 @@ func simpleSnapshotTest(t *testing.T) {\n \n \tdestroyAndWait(t, ctxs)\n }\n+\n+func groupSnapshotTest(t *testing.T) {\n+\tctxs, err := schedulerDriver.Schedule(generateInstanceID(t, \"\"),\n+\t\tscheduler.ScheduleOptions{AppKeys: []string{\"mysql-snap-group\"}})\n+\trequire.NoError(t, err, \"Error scheduling task\")\n+\trequire.Len(t, ctxs, 1, \"Only one task should have started\")\n+\n+\terr = schedulerDriver.WaitForRunning(ctxs[0])\n+\trequire.NoError(t, err, \"Error waiting for pod to get to running state\")\n+\n+\tscheduledNodes, err := schedulerDriver.GetNodesForApp(ctxs[0])\n+\trequire.NoError(t, err, \"Error getting node for app\")\n+\trequire.Len(t, scheduledNodes, 1, \"App should be scheduled on one node\")\n+\n+\terr = schedulerDriver.InspectVolumes(ctxs[0])\n+\trequire.NoError(t, err, \"Error waiting for volumes\")\n+\n+\tallVolumeNames := getVolumeNames(t, ctxs[0])\n+\trequire.Len(t, allVolumeNames, 3, \"Should only have two volumes and 1 snapshot\")\n+\n+\tdataVolumesNames := make([]string, 0)\n+\tfor _, volume := range allVolumeNames {\n+\t\tif !strings.HasPrefix(volume, \"snapshot\") {\n+\t\t\tdataVolumesNames = append(dataVolumesNames, volume)\n+\t\t}\n+\t}\n+","path":"test/integration_test/snapshot_test.go","position":50,"original_position":50,"commit_id":"0826f341f1fd72ccfab43663aa5d75907bb8fd6f","original_commit_id":"0826f341f1fd72ccfab43663aa5d75907bb8fd6f","user":{"login":"disrani-px","id":25230810,"avatar_url":"https://avatars3.githubusercontent.com/u/25230810?v=4","gravatar_id":"","url":"https://api.github.com/users/disrani-px","html_url":"https://github.com/disrani-px","followers_url":"https://api.github.com/users/disrani-px/followers","following_url":"https://api.github.com/users/disrani-px/following{/other_user}","gists_url":"https://api.github.com/users/disrani-px/gists{/gist_id}","starred_url":"https://api.github.com/users/disrani-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disrani-px/subscriptions","organizations_url":"https://api.github.com/users/disrani-px/orgs","repos_url":"https://api.github.com/users/disrani-px/repos","events_url":"https://api.github.com/users/disrani-px/events{/privacy}","received_events_url":"https://api.github.com/users/disrani-px/received_events","type":"User","site_admin":false},"body":"Actually 2 data volumes","created_at":"2018-05-04T19:04:36Z","updated_at":"2018-05-04T19:04:36Z","html_url":"https://github.com/libopenstorage/stork/pull/78#discussion_r186186526","pull_request_url":"https://api.github.com/repos/libopenstorage/stork/pulls/78","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/comments/186186526"},"html":{"href":"https://github.com/libopenstorage/stork/pull/78#discussion_r186186526"},"pull_request":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/78"}},"in_reply_to_id":185982890},"pull_request":{"url":"https://api.github.com/repos/libopenstorage/stork/pulls/78","id":185872557,"html_url":"https://github.com/libopenstorage/stork/pull/78","diff_url":"https://github.com/libopenstorage/stork/pull/78.diff","patch_url":"https://github.com/libopenstorage/stork/pull/78.patch","issue_url":"https://api.github.com/repos/libopenstorage/stork/issues/78","number":78,"state":"open","locked":false,"title":" Add supports for cloud and group snapshots","user":{"login":"harsh-px","id":26801153,"avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-04T00:48:47Z","updated_at":"2018-05-04T19:04:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff3a4f8a5593c577ee2a9dfb9981f34cc8978f4a","assignee":{"login":"harsh-px","id":26801153,"avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"assignees":[{"login":"harsh-px","id":26801153,"avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libopenstorage/stork/pulls/78/commits","review_comments_url":"https://api.github.com/repos/libopenstorage/stork/pulls/78/comments","review_comment_url":"https://api.github.com/repos/libopenstorage/stork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libopenstorage/stork/issues/78/comments","statuses_url":"https://api.github.com/repos/libopenstorage/stork/statuses/0826f341f1fd72ccfab43663aa5d75907bb8fd6f","head":{"label":"harsh-px:group-snap-pr","ref":"group-snap-pr","sha":"0826f341f1fd72ccfab43663aa5d75907bb8fd6f","user":{"login":"harsh-px","id":26801153,"avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"repo":{"id":129169020,"name":"stork","full_name":"harsh-px/stork","owner":{"login":"harsh-px","id":26801153,"avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harsh-px/stork","description":"Stork - Storage Orchestration Runtime for Kubernetes","fork":true,"url":"https://api.github.com/repos/harsh-px/stork","forks_url":"https://api.github.com/repos/harsh-px/stork/forks","keys_url":"https://api.github.com/repos/harsh-px/stork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harsh-px/stork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harsh-px/stork/teams","hooks_url":"https://api.github.com/repos/harsh-px/stork/hooks","issue_events_url":"https://api.github.com/repos/harsh-px/stork/issues/events{/number}","events_url":"https://api.github.com/repos/harsh-px/stork/events","assignees_url":"https://api.github.com/repos/harsh-px/stork/assignees{/user}","branches_url":"https://api.github.com/repos/harsh-px/stork/branches{/branch}","tags_url":"https://api.github.com/repos/harsh-px/stork/tags","blobs_url":"https://api.github.com/repos/harsh-px/stork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harsh-px/stork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harsh-px/stork/git/refs{/sha}","trees_url":"https://api.github.com/repos/harsh-px/stork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harsh-px/stork/statuses/{sha}","languages_url":"https://api.github.com/repos/harsh-px/stork/languages","stargazers_url":"https://api.github.com/repos/harsh-px/stork/stargazers","contributors_url":"https://api.github.com/repos/harsh-px/stork/contributors","subscribers_url":"https://api.github.com/repos/harsh-px/stork/subscribers","subscription_url":"https://api.github.com/repos/harsh-px/stork/subscription","commits_url":"https://api.github.com/repos/harsh-px/stork/commits{/sha}","git_commits_url":"https://api.github.com/repos/harsh-px/stork/git/commits{/sha}","comments_url":"https://api.github.com/repos/harsh-px/stork/comments{/number}","issue_comment_url":"https://api.github.com/repos/harsh-px/stork/issues/comments{/number}","contents_url":"https://api.github.com/repos/harsh-px/stork/contents/{+path}","compare_url":"https://api.github.com/repos/harsh-px/stork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harsh-px/stork/merges","archive_url":"https://api.github.com/repos/harsh-px/stork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harsh-px/stork/downloads","issues_url":"https://api.github.com/repos/harsh-px/stork/issues{/number}","pulls_url":"https://api.github.com/repos/harsh-px/stork/pulls{/number}","milestones_url":"https://api.github.com/repos/harsh-px/stork/milestones{/number}","notifications_url":"https://api.github.com/repos/harsh-px/stork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harsh-px/stork/labels{/name}","releases_url":"https://api.github.com/repos/harsh-px/stork/releases{/id}","deployments_url":"https://api.github.com/repos/harsh-px/stork/deployments","created_at":"2018-04-12T00:14:44Z","updated_at":"2018-04-12T00:14:47Z","pushed_at":"2018-05-04T01:44:00Z","git_url":"git://github.com/harsh-px/stork.git","ssh_url":"git@github.com:harsh-px/stork.git","clone_url":"https://github.com/harsh-px/stork.git","svn_url":"https://github.com/harsh-px/stork","homepage":"","size":6337,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libopenstorage:master","ref":"master","sha":"db0f19df337c3c53ed4b76808f34c00f39c2ed53","user":{"login":"libopenstorage","id":13478636,"avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":102562155,"name":"stork","full_name":"libopenstorage/stork","owner":{"login":"libopenstorage","id":13478636,"avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libopenstorage/stork","description":"Stork - Storage Orchestration Runtime for Kubernetes","fork":false,"url":"https://api.github.com/repos/libopenstorage/stork","forks_url":"https://api.github.com/repos/libopenstorage/stork/forks","keys_url":"https://api.github.com/repos/libopenstorage/stork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libopenstorage/stork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libopenstorage/stork/teams","hooks_url":"https://api.github.com/repos/libopenstorage/stork/hooks","issue_events_url":"https://api.github.com/repos/libopenstorage/stork/issues/events{/number}","events_url":"https://api.github.com/repos/libopenstorage/stork/events","assignees_url":"https://api.github.com/repos/libopenstorage/stork/assignees{/user}","branches_url":"https://api.github.com/repos/libopenstorage/stork/branches{/branch}","tags_url":"https://api.github.com/repos/libopenstorage/stork/tags","blobs_url":"https://api.github.com/repos/libopenstorage/stork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libopenstorage/stork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libopenstorage/stork/git/refs{/sha}","trees_url":"https://api.github.com/repos/libopenstorage/stork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libopenstorage/stork/statuses/{sha}","languages_url":"https://api.github.com/repos/libopenstorage/stork/languages","stargazers_url":"https://api.github.com/repos/libopenstorage/stork/stargazers","contributors_url":"https://api.github.com/repos/libopenstorage/stork/contributors","subscribers_url":"https://api.github.com/repos/libopenstorage/stork/subscribers","subscription_url":"https://api.github.com/repos/libopenstorage/stork/subscription","commits_url":"https://api.github.com/repos/libopenstorage/stork/commits{/sha}","git_commits_url":"https://api.github.com/repos/libopenstorage/stork/git/commits{/sha}","comments_url":"https://api.github.com/repos/libopenstorage/stork/comments{/number}","issue_comment_url":"https://api.github.com/repos/libopenstorage/stork/issues/comments{/number}","contents_url":"https://api.github.com/repos/libopenstorage/stork/contents/{+path}","compare_url":"https://api.github.com/repos/libopenstorage/stork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libopenstorage/stork/merges","archive_url":"https://api.github.com/repos/libopenstorage/stork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libopenstorage/stork/downloads","issues_url":"https://api.github.com/repos/libopenstorage/stork/issues{/number}","pulls_url":"https://api.github.com/repos/libopenstorage/stork/pulls{/number}","milestones_url":"https://api.github.com/repos/libopenstorage/stork/milestones{/number}","notifications_url":"https://api.github.com/repos/libopenstorage/stork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libopenstorage/stork/labels{/name}","releases_url":"https://api.github.com/repos/libopenstorage/stork/releases{/id}","deployments_url":"https://api.github.com/repos/libopenstorage/stork/deployments","created_at":"2017-09-06T04:20:51Z","updated_at":"2018-05-03T19:44:15Z","pushed_at":"2018-05-04T01:44:01Z","git_url":"git://github.com/libopenstorage/stork.git","ssh_url":"git@github.com:libopenstorage/stork.git","clone_url":"https://github.com/libopenstorage/stork.git","svn_url":"https://github.com/libopenstorage/stork","homepage":"","size":6271,"stargazers_count":67,"watchers_count":67,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":8,"open_issues":12,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/78"},"html":{"href":"https://github.com/libopenstorage/stork/pull/78"},"issue":{"href":"https://api.github.com/repos/libopenstorage/stork/issues/78"},"comments":{"href":"https://api.github.com/repos/libopenstorage/stork/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/libopenstorage/stork/statuses/0826f341f1fd72ccfab43663aa5d75907bb8fd6f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"disrani-px"}}