{"action":"closed","number":457,"pull_request":{"url":"https://api.github.com/repos/input-output-hk/mantis/pulls/457","id":188925628,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4OTI1NjI4","html_url":"https://github.com/input-output-hk/mantis/pull/457","diff_url":"https://github.com/input-output-hk/mantis/pull/457.diff","patch_url":"https://github.com/input-output-hk/mantis/pull/457.patch","issue_url":"https://api.github.com/repos/input-output-hk/mantis/issues/457","number":457,"state":"closed","locked":false,"title":"[EC-524 ]Feature/fast sync refactor","user":{"login":"KonradStaniec","id":10688236,"node_id":"MDQ6VXNlcjEwNjg4MjM2","avatar_url":"https://avatars2.githubusercontent.com/u/10688236?v=4","gravatar_id":"","url":"https://api.github.com/users/KonradStaniec","html_url":"https://github.com/KonradStaniec","followers_url":"https://api.github.com/users/KonradStaniec/followers","following_url":"https://api.github.com/users/KonradStaniec/following{/other_user}","gists_url":"https://api.github.com/users/KonradStaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/KonradStaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KonradStaniec/subscriptions","organizations_url":"https://api.github.com/users/KonradStaniec/orgs","repos_url":"https://api.github.com/users/KonradStaniec/repos","events_url":"https://api.github.com/users/KonradStaniec/events{/privacy}","received_events_url":"https://api.github.com/users/KonradStaniec/received_events","type":"User","site_admin":false},"body":"Things done:\r\n1. Separate fastSync into two classes - one handling requests, one handling state changes\r\n2. Handle state changes into one place\r\n3. Write unit test to test each state transition separatly, and treat current actor based tests more like integration tests.\r\n\r\nThings to be done (current pr grew enough):\r\nSeparate whole download algorithm out of fast sync ","created_at":"2018-05-18T05:33:44Z","updated_at":"2018-12-12T05:32:31Z","closed_at":"2018-12-12T05:32:31Z","merged_at":null,"merge_commit_sha":"d5c89985d0311e26353b9e45fb2194e5bb761710","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":963546616,"node_id":"MDU6TGFiZWw5NjM1NDY2MTY=","url":"https://api.github.com/repos/input-output-hk/mantis/labels/phase/release2.0","name":"phase/release2.0","color":"bf0f9e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/mantis/pulls/457/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/mantis/pulls/457/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/mantis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/mantis/issues/457/comments","statuses_url":"https://api.github.com/repos/input-output-hk/mantis/statuses/9966a6a3461baa6de17ebfb4b29f92ca73372008","head":{"label":"input-output-hk:feature/fast_sync_refactor","ref":"feature/fast_sync_refactor","sha":"9966a6a3461baa6de17ebfb4b29f92ca73372008","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI1NjExMw==","name":"mantis","full_name":"input-output-hk/mantis","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/mantis","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/mantis","forks_url":"https://api.github.com/repos/input-output-hk/mantis/forks","keys_url":"https://api.github.com/repos/input-output-hk/mantis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/mantis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/mantis/teams","hooks_url":"https://api.github.com/repos/input-output-hk/mantis/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/mantis/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/mantis/events","assignees_url":"https://api.github.com/repos/input-output-hk/mantis/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/mantis/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/mantis/tags","blobs_url":"https://api.github.com/repos/input-output-hk/mantis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/mantis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/mantis/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/mantis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/mantis/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/mantis/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/mantis/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/mantis/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/mantis/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/mantis/subscription","commits_url":"https://api.github.com/repos/input-output-hk/mantis/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/mantis/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/mantis/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/mantis/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/mantis/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/mantis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/mantis/merges","archive_url":"https://api.github.com/repos/input-output-hk/mantis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/mantis/downloads","issues_url":"https://api.github.com/repos/input-output-hk/mantis/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/mantis/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/mantis/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/mantis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/mantis/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/mantis/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/mantis/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2018-12-10T11:52:10Z","pushed_at":"2018-12-10T15:14:29Z","git_url":"git://github.com/input-output-hk/mantis.git","ssh_url":"git@github.com:input-output-hk/mantis.git","clone_url":"https://github.com/input-output-hk/mantis.git","svn_url":"https://github.com/input-output-hk/mantis","homepage":null,"size":17124,"stargazers_count":144,"watchers_count":144,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":23,"watchers":144,"default_branch":"master"}},"base":{"label":"input-output-hk:phase/release2_0","ref":"phase/release2_0","sha":"f8bcf5df325fa96da27fa38d9be2a8f505beda83","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI1NjExMw==","name":"mantis","full_name":"input-output-hk/mantis","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/mantis","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/mantis","forks_url":"https://api.github.com/repos/input-output-hk/mantis/forks","keys_url":"https://api.github.com/repos/input-output-hk/mantis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/mantis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/mantis/teams","hooks_url":"https://api.github.com/repos/input-output-hk/mantis/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/mantis/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/mantis/events","assignees_url":"https://api.github.com/repos/input-output-hk/mantis/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/mantis/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/mantis/tags","blobs_url":"https://api.github.com/repos/input-output-hk/mantis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/mantis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/mantis/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/mantis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/mantis/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/mantis/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/mantis/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/mantis/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/mantis/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/mantis/subscription","commits_url":"https://api.github.com/repos/input-output-hk/mantis/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/mantis/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/mantis/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/mantis/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/mantis/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/mantis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/mantis/merges","archive_url":"https://api.github.com/repos/input-output-hk/mantis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/mantis/downloads","issues_url":"https://api.github.com/repos/input-output-hk/mantis/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/mantis/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/mantis/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/mantis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/mantis/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/mantis/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/mantis/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2018-12-10T11:52:10Z","pushed_at":"2018-12-10T15:14:29Z","git_url":"git://github.com/input-output-hk/mantis.git","ssh_url":"git@github.com:input-output-hk/mantis.git","clone_url":"https://github.com/input-output-hk/mantis.git","svn_url":"https://github.com/input-output-hk/mantis","homepage":null,"size":17124,"stargazers_count":144,"watchers_count":144,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":23,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/457"},"html":{"href":"https://github.com/input-output-hk/mantis/pull/457"},"issue":{"href":"https://api.github.com/repos/input-output-hk/mantis/issues/457"},"comments":{"href":"https://api.github.com/repos/input-output-hk/mantis/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/mantis/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/mantis/statuses/9966a6a3461baa6de17ebfb4b29f92ca73372008"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":33,"maintainer_can_modify":false,"commits":7,"additions":996,"deletions":466,"changed_files":8}}
{"actor":{"display_login":"KonradStaniec"}}