{"action":"created","comment":{"url":"https://api.github.com/repos/d3ledger/notary/pulls/comments/237374148","pull_request_review_id":179653610,"id":237374148,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzM3NDE0OA==","diff_hunk":"@@ -25,3 +25,5 @@ test.ethereum.gasLimit=6000000\n # --------- Bitcoin ---------\n test.bitcoin.walletPath=deploy/bitcoin/test-btc.wallet\n test.bitcoin.blockStoragePath=deploy/bitcoin/blocks\n+# --------- Timeout (minutes) ---------\n+test.testTimeout=5","path":"configs/test_local.properties","position":5,"original_position":5,"commit_id":"b35dbb28bd136fc7c6516c24eb45e2d35aaa907f","original_commit_id":"b35dbb28bd136fc7c6516c24eb45e2d35aaa907f","user":{"login":"Alexey-N-Chernyshov","id":495478,"node_id":"MDQ6VXNlcjQ5NTQ3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/495478?v=4","gravatar_id":"","url":"https://api.github.com/users/Alexey-N-Chernyshov","html_url":"https://github.com/Alexey-N-Chernyshov","followers_url":"https://api.github.com/users/Alexey-N-Chernyshov/followers","following_url":"https://api.github.com/users/Alexey-N-Chernyshov/following{/other_user}","gists_url":"https://api.github.com/users/Alexey-N-Chernyshov/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexey-N-Chernyshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexey-N-Chernyshov/subscriptions","organizations_url":"https://api.github.com/users/Alexey-N-Chernyshov/orgs","repos_url":"https://api.github.com/users/Alexey-N-Chernyshov/repos","events_url":"https://api.github.com/users/Alexey-N-Chernyshov/events{/privacy}","received_events_url":"https://api.github.com/users/Alexey-N-Chernyshov/received_events","type":"User","site_admin":false},"body":"Agree.","created_at":"2018-11-29T07:17:04Z","updated_at":"2018-11-29T07:17:10Z","html_url":"https://github.com/d3ledger/notary/pull/287#discussion_r237374148","pull_request_url":"https://api.github.com/repos/d3ledger/notary/pulls/287","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/d3ledger/notary/pulls/comments/237374148"},"html":{"href":"https://github.com/d3ledger/notary/pull/287#discussion_r237374148"},"pull_request":{"href":"https://api.github.com/repos/d3ledger/notary/pulls/287"}},"in_reply_to_id":236981040},"pull_request":{"url":"https://api.github.com/repos/d3ledger/notary/pulls/287","id":233847067,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODQ3MDY3","html_url":"https://github.com/d3ledger/notary/pull/287","diff_url":"https://github.com/d3ledger/notary/pull/287.diff","patch_url":"https://github.com/d3ledger/notary/pull/287.patch","issue_url":"https://api.github.com/repos/d3ledger/notary/issues/287","number":287,"state":"open","locked":false,"title":"Feature/tests timeouts","user":{"login":"Mingela","id":17858062,"node_id":"MDQ6VXNlcjE3ODU4MDYy","avatar_url":"https://avatars3.githubusercontent.com/u/17858062?v=4","gravatar_id":"","url":"https://api.github.com/users/Mingela","html_url":"https://github.com/Mingela","followers_url":"https://api.github.com/users/Mingela/followers","following_url":"https://api.github.com/users/Mingela/following{/other_user}","gists_url":"https://api.github.com/users/Mingela/gists{/gist_id}","starred_url":"https://api.github.com/users/Mingela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mingela/subscriptions","organizations_url":"https://api.github.com/users/Mingela/orgs","repos_url":"https://api.github.com/users/Mingela/repos","events_url":"https://api.github.com/users/Mingela/events{/privacy}","received_events_url":"https://api.github.com/users/Mingela/received_events","type":"User","site_admin":false},"body":"<!-- ### Requirements -->\r\n<!-- * Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. -->\r\n<!-- * Jenkins builds must be passed. -->\r\n<!-- * Critical and blocker issues reported by Sorabot must be fixed. -->\r\n\r\n\r\n### Description of the Change\r\nAdded awkward integration tests timeouts. \r\n\r\nDetails: \r\nhttps://github.com/junit-team/junit5/issues/80#issuecomment-391313036 \r\nhttps://blog.philipphauer.de/best-practices-unit-testing-kotlin/\r\n\r\nOn the one hand it is generally bad idea to use JUnit4 for Kotlin\r\nOn the other hand there is no convenient way to implement timeouts in JUnit5 yet\r\n\r\n### Usage Examples or Tests *[optional]*\r\n","created_at":"2018-11-27T10:01:53Z","updated_at":"2018-11-29T07:17:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31fb0681c36ee4e7e7b335c62e3a2d3f5be25a26","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Alexey-N-Chernyshov","id":495478,"node_id":"MDQ6VXNlcjQ5NTQ3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/495478?v=4","gravatar_id":"","url":"https://api.github.com/users/Alexey-N-Chernyshov","html_url":"https://github.com/Alexey-N-Chernyshov","followers_url":"https://api.github.com/users/Alexey-N-Chernyshov/followers","following_url":"https://api.github.com/users/Alexey-N-Chernyshov/following{/other_user}","gists_url":"https://api.github.com/users/Alexey-N-Chernyshov/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexey-N-Chernyshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexey-N-Chernyshov/subscriptions","organizations_url":"https://api.github.com/users/Alexey-N-Chernyshov/orgs","repos_url":"https://api.github.com/users/Alexey-N-Chernyshov/repos","events_url":"https://api.github.com/users/Alexey-N-Chernyshov/events{/privacy}","received_events_url":"https://api.github.com/users/Alexey-N-Chernyshov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/d3ledger/notary/pulls/287/commits","review_comments_url":"https://api.github.com/repos/d3ledger/notary/pulls/287/comments","review_comment_url":"https://api.github.com/repos/d3ledger/notary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3ledger/notary/issues/287/comments","statuses_url":"https://api.github.com/repos/d3ledger/notary/statuses/b35dbb28bd136fc7c6516c24eb45e2d35aaa907f","head":{"label":"d3ledger:feature/tests-timeouts","ref":"feature/tests-timeouts","sha":"b35dbb28bd136fc7c6516c24eb45e2d35aaa907f","user":{"login":"d3ledger","id":31348469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ4NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/31348469?v=4","gravatar_id":"","url":"https://api.github.com/users/d3ledger","html_url":"https://github.com/d3ledger","followers_url":"https://api.github.com/users/d3ledger/followers","following_url":"https://api.github.com/users/d3ledger/following{/other_user}","gists_url":"https://api.github.com/users/d3ledger/gists{/gist_id}","starred_url":"https://api.github.com/users/d3ledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3ledger/subscriptions","organizations_url":"https://api.github.com/users/d3ledger/orgs","repos_url":"https://api.github.com/users/d3ledger/repos","events_url":"https://api.github.com/users/d3ledger/events{/privacy}","received_events_url":"https://api.github.com/users/d3ledger/received_events","type":"Organization","site_admin":false},"repo":{"id":129921969,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5MjE5Njk=","name":"notary","full_name":"d3ledger/notary","private":false,"owner":{"login":"d3ledger","id":31348469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ4NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/31348469?v=4","gravatar_id":"","url":"https://api.github.com/users/d3ledger","html_url":"https://github.com/d3ledger","followers_url":"https://api.github.com/users/d3ledger/followers","following_url":"https://api.github.com/users/d3ledger/following{/other_user}","gists_url":"https://api.github.com/users/d3ledger/gists{/gist_id}","starred_url":"https://api.github.com/users/d3ledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3ledger/subscriptions","organizations_url":"https://api.github.com/users/d3ledger/orgs","repos_url":"https://api.github.com/users/d3ledger/repos","events_url":"https://api.github.com/users/d3ledger/events{/privacy}","received_events_url":"https://api.github.com/users/d3ledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/d3ledger/notary","description":"Backend code for a D3 notary","fork":false,"url":"https://api.github.com/repos/d3ledger/notary","forks_url":"https://api.github.com/repos/d3ledger/notary/forks","keys_url":"https://api.github.com/repos/d3ledger/notary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3ledger/notary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3ledger/notary/teams","hooks_url":"https://api.github.com/repos/d3ledger/notary/hooks","issue_events_url":"https://api.github.com/repos/d3ledger/notary/issues/events{/number}","events_url":"https://api.github.com/repos/d3ledger/notary/events","assignees_url":"https://api.github.com/repos/d3ledger/notary/assignees{/user}","branches_url":"https://api.github.com/repos/d3ledger/notary/branches{/branch}","tags_url":"https://api.github.com/repos/d3ledger/notary/tags","blobs_url":"https://api.github.com/repos/d3ledger/notary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3ledger/notary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3ledger/notary/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3ledger/notary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3ledger/notary/statuses/{sha}","languages_url":"https://api.github.com/repos/d3ledger/notary/languages","stargazers_url":"https://api.github.com/repos/d3ledger/notary/stargazers","contributors_url":"https://api.github.com/repos/d3ledger/notary/contributors","subscribers_url":"https://api.github.com/repos/d3ledger/notary/subscribers","subscription_url":"https://api.github.com/repos/d3ledger/notary/subscription","commits_url":"https://api.github.com/repos/d3ledger/notary/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3ledger/notary/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3ledger/notary/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3ledger/notary/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3ledger/notary/contents/{+path}","compare_url":"https://api.github.com/repos/d3ledger/notary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3ledger/notary/merges","archive_url":"https://api.github.com/repos/d3ledger/notary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3ledger/notary/downloads","issues_url":"https://api.github.com/repos/d3ledger/notary/issues{/number}","pulls_url":"https://api.github.com/repos/d3ledger/notary/pulls{/number}","milestones_url":"https://api.github.com/repos/d3ledger/notary/milestones{/number}","notifications_url":"https://api.github.com/repos/d3ledger/notary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3ledger/notary/labels{/name}","releases_url":"https://api.github.com/repos/d3ledger/notary/releases{/id}","deployments_url":"https://api.github.com/repos/d3ledger/notary/deployments","created_at":"2018-04-17T15:01:56Z","updated_at":"2018-11-22T10:30:33Z","pushed_at":"2018-11-29T07:08:28Z","git_url":"git://github.com/d3ledger/notary.git","ssh_url":"git@github.com:d3ledger/notary.git","clone_url":"https://github.com/d3ledger/notary.git","svn_url":"https://github.com/d3ledger/notary","homepage":"","size":79220,"stargazers_count":9,"watchers_count":9,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":12,"watchers":9,"default_branch":"master"}},"base":{"label":"d3ledger:develop","ref":"develop","sha":"c4b8022e76dc246bae14ad5e01403d6c1e31fe59","user":{"login":"d3ledger","id":31348469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ4NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/31348469?v=4","gravatar_id":"","url":"https://api.github.com/users/d3ledger","html_url":"https://github.com/d3ledger","followers_url":"https://api.github.com/users/d3ledger/followers","following_url":"https://api.github.com/users/d3ledger/following{/other_user}","gists_url":"https://api.github.com/users/d3ledger/gists{/gist_id}","starred_url":"https://api.github.com/users/d3ledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3ledger/subscriptions","organizations_url":"https://api.github.com/users/d3ledger/orgs","repos_url":"https://api.github.com/users/d3ledger/repos","events_url":"https://api.github.com/users/d3ledger/events{/privacy}","received_events_url":"https://api.github.com/users/d3ledger/received_events","type":"Organization","site_admin":false},"repo":{"id":129921969,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5MjE5Njk=","name":"notary","full_name":"d3ledger/notary","private":false,"owner":{"login":"d3ledger","id":31348469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ4NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/31348469?v=4","gravatar_id":"","url":"https://api.github.com/users/d3ledger","html_url":"https://github.com/d3ledger","followers_url":"https://api.github.com/users/d3ledger/followers","following_url":"https://api.github.com/users/d3ledger/following{/other_user}","gists_url":"https://api.github.com/users/d3ledger/gists{/gist_id}","starred_url":"https://api.github.com/users/d3ledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3ledger/subscriptions","organizations_url":"https://api.github.com/users/d3ledger/orgs","repos_url":"https://api.github.com/users/d3ledger/repos","events_url":"https://api.github.com/users/d3ledger/events{/privacy}","received_events_url":"https://api.github.com/users/d3ledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/d3ledger/notary","description":"Backend code for a D3 notary","fork":false,"url":"https://api.github.com/repos/d3ledger/notary","forks_url":"https://api.github.com/repos/d3ledger/notary/forks","keys_url":"https://api.github.com/repos/d3ledger/notary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3ledger/notary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3ledger/notary/teams","hooks_url":"https://api.github.com/repos/d3ledger/notary/hooks","issue_events_url":"https://api.github.com/repos/d3ledger/notary/issues/events{/number}","events_url":"https://api.github.com/repos/d3ledger/notary/events","assignees_url":"https://api.github.com/repos/d3ledger/notary/assignees{/user}","branches_url":"https://api.github.com/repos/d3ledger/notary/branches{/branch}","tags_url":"https://api.github.com/repos/d3ledger/notary/tags","blobs_url":"https://api.github.com/repos/d3ledger/notary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3ledger/notary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3ledger/notary/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3ledger/notary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3ledger/notary/statuses/{sha}","languages_url":"https://api.github.com/repos/d3ledger/notary/languages","stargazers_url":"https://api.github.com/repos/d3ledger/notary/stargazers","contributors_url":"https://api.github.com/repos/d3ledger/notary/contributors","subscribers_url":"https://api.github.com/repos/d3ledger/notary/subscribers","subscription_url":"https://api.github.com/repos/d3ledger/notary/subscription","commits_url":"https://api.github.com/repos/d3ledger/notary/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3ledger/notary/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3ledger/notary/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3ledger/notary/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3ledger/notary/contents/{+path}","compare_url":"https://api.github.com/repos/d3ledger/notary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3ledger/notary/merges","archive_url":"https://api.github.com/repos/d3ledger/notary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3ledger/notary/downloads","issues_url":"https://api.github.com/repos/d3ledger/notary/issues{/number}","pulls_url":"https://api.github.com/repos/d3ledger/notary/pulls{/number}","milestones_url":"https://api.github.com/repos/d3ledger/notary/milestones{/number}","notifications_url":"https://api.github.com/repos/d3ledger/notary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3ledger/notary/labels{/name}","releases_url":"https://api.github.com/repos/d3ledger/notary/releases{/id}","deployments_url":"https://api.github.com/repos/d3ledger/notary/deployments","created_at":"2018-04-17T15:01:56Z","updated_at":"2018-11-22T10:30:33Z","pushed_at":"2018-11-29T07:08:28Z","git_url":"git://github.com/d3ledger/notary.git","ssh_url":"git@github.com:d3ledger/notary.git","clone_url":"https://github.com/d3ledger/notary.git","svn_url":"https://github.com/d3ledger/notary","homepage":"","size":79220,"stargazers_count":9,"watchers_count":9,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":12,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/d3ledger/notary/pulls/287"},"html":{"href":"https://github.com/d3ledger/notary/pull/287"},"issue":{"href":"https://api.github.com/repos/d3ledger/notary/issues/287"},"comments":{"href":"https://api.github.com/repos/d3ledger/notary/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/d3ledger/notary/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/d3ledger/notary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3ledger/notary/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/d3ledger/notary/statuses/b35dbb28bd136fc7c6516c24eb45e2d35aaa907f"}},"author_association":"NONE"}}
{"actor":{"display_login":"Alexey-N-Chernyshov"}}