{"action":"created","comment":{"url":"https://api.github.com/repos/hughsie/lvfs-website/pulls/comments/171902005","pull_request_review_id":100840795,"id":171902005,"diff_hunk":"@@ -3,8 +3,50 @@\n \n {% block content %}\n <div class=\"container mt-3\">\n-<h1>Firmware Details</h1>\n \n+<!-- veto information -->\n+{% if fw.target == 'testing' and 'no-release-urgency' in vetos %}\n+<div class=\"card mb-3\">\n+  <h3 class=\"card-header list-group-item-warning\">\n+    More information required!\n+  </h3>\n+  <div class=\"card-body\">\n+    <p class=\"card-text\">\n+      All components need an update urgency before a firmware can be moved to stable.\n+      You can do this for each component on this firmware by clicking <b>Details</b>\n+      &raquo; <b>Update Details</b> and setting an urgency from the dropdown.\n+    </p>\n+    <p class=\"card-text\">\n+      For future firmware uploads, this can be set automatically using\n+      <code>&lt;release urgency=\"high\"&gt;</code> in the\n+      <a href=\"/metainfo\"><code>.metainfo.xml</code></a> file.","path":"app/templates/firmware-details.html","position":21,"original_position":21,"commit_id":"a237d98fc34c160bc43012ee66cc1294865e9111","original_commit_id":"a237d98fc34c160bc43012ee66cc1294865e9111","user":{"login":"superm1","id":494526,"avatar_url":"https://avatars0.githubusercontent.com/u/494526?v=4","gravatar_id":"","url":"https://api.github.com/users/superm1","html_url":"https://github.com/superm1","followers_url":"https://api.github.com/users/superm1/followers","following_url":"https://api.github.com/users/superm1/following{/other_user}","gists_url":"https://api.github.com/users/superm1/gists{/gist_id}","starred_url":"https://api.github.com/users/superm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superm1/subscriptions","organizations_url":"https://api.github.com/users/superm1/orgs","repos_url":"https://api.github.com/users/superm1/repos","events_url":"https://api.github.com/users/superm1/events{/privacy}","received_events_url":"https://api.github.com/users/superm1/received_events","type":"User","site_admin":false},"body":"Why not show the urgency drop down in the card rather than make them run around to do it?","created_at":"2018-03-02T16:54:31Z","updated_at":"2018-03-02T16:54:31Z","html_url":"https://github.com/hughsie/lvfs-website/pull/79#discussion_r171902005","pull_request_url":"https://api.github.com/repos/hughsie/lvfs-website/pulls/79","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hughsie/lvfs-website/pulls/comments/171902005"},"html":{"href":"https://github.com/hughsie/lvfs-website/pull/79#discussion_r171902005"},"pull_request":{"href":"https://api.github.com/repos/hughsie/lvfs-website/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/hughsie/lvfs-website/pulls/79","id":172505745,"html_url":"https://github.com/hughsie/lvfs-website/pull/79","diff_url":"https://github.com/hughsie/lvfs-website/pull/79.diff","patch_url":"https://github.com/hughsie/lvfs-website/pull/79.patch","issue_url":"https://api.github.com/repos/hughsie/lvfs-website/issues/79","number":79,"state":"open","locked":false,"title":"Require urgency and release notes before moving to stable","user":{"login":"hughsie","id":151380,"avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/hughsie/lvfs-website/issues/77","created_at":"2018-03-02T13:43:24Z","updated_at":"2018-03-02T16:54:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4680482ea7bdf36791e18d09b696ebe7d423a68","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hughsie/lvfs-website/pulls/79/commits","review_comments_url":"https://api.github.com/repos/hughsie/lvfs-website/pulls/79/comments","review_comment_url":"https://api.github.com/repos/hughsie/lvfs-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hughsie/lvfs-website/issues/79/comments","statuses_url":"https://api.github.com/repos/hughsie/lvfs-website/statuses/a237d98fc34c160bc43012ee66cc1294865e9111","head":{"label":"hughsie:wip/hughsie/better-update-info","ref":"wip/hughsie/better-update-info","sha":"a237d98fc34c160bc43012ee66cc1294865e9111","user":{"login":"hughsie","id":151380,"avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"repo":{"id":47995721,"name":"lvfs-website","full_name":"hughsie/lvfs-website","owner":{"login":"hughsie","id":151380,"avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughsie/lvfs-website","description":"The LVFS website","fork":false,"url":"https://api.github.com/repos/hughsie/lvfs-website","forks_url":"https://api.github.com/repos/hughsie/lvfs-website/forks","keys_url":"https://api.github.com/repos/hughsie/lvfs-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughsie/lvfs-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughsie/lvfs-website/teams","hooks_url":"https://api.github.com/repos/hughsie/lvfs-website/hooks","issue_events_url":"https://api.github.com/repos/hughsie/lvfs-website/issues/events{/number}","events_url":"https://api.github.com/repos/hughsie/lvfs-website/events","assignees_url":"https://api.github.com/repos/hughsie/lvfs-website/assignees{/user}","branches_url":"https://api.github.com/repos/hughsie/lvfs-website/branches{/branch}","tags_url":"https://api.github.com/repos/hughsie/lvfs-website/tags","blobs_url":"https://api.github.com/repos/hughsie/lvfs-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughsie/lvfs-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughsie/lvfs-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughsie/lvfs-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughsie/lvfs-website/statuses/{sha}","languages_url":"https://api.github.com/repos/hughsie/lvfs-website/languages","stargazers_url":"https://api.github.com/repos/hughsie/lvfs-website/stargazers","contributors_url":"https://api.github.com/repos/hughsie/lvfs-website/contributors","subscribers_url":"https://api.github.com/repos/hughsie/lvfs-website/subscribers","subscription_url":"https://api.github.com/repos/hughsie/lvfs-website/subscription","commits_url":"https://api.github.com/repos/hughsie/lvfs-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughsie/lvfs-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughsie/lvfs-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughsie/lvfs-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughsie/lvfs-website/contents/{+path}","compare_url":"https://api.github.com/repos/hughsie/lvfs-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughsie/lvfs-website/merges","archive_url":"https://api.github.com/repos/hughsie/lvfs-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughsie/lvfs-website/downloads","issues_url":"https://api.github.com/repos/hughsie/lvfs-website/issues{/number}","pulls_url":"https://api.github.com/repos/hughsie/lvfs-website/pulls{/number}","milestones_url":"https://api.github.com/repos/hughsie/lvfs-website/milestones{/number}","notifications_url":"https://api.github.com/repos/hughsie/lvfs-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughsie/lvfs-website/labels{/name}","releases_url":"https://api.github.com/repos/hughsie/lvfs-website/releases{/id}","deployments_url":"https://api.github.com/repos/hughsie/lvfs-website/deployments","created_at":"2015-12-14T19:13:26Z","updated_at":"2017-02-27T01:29:00Z","pushed_at":"2018-03-02T16:52:55Z","git_url":"git://github.com/hughsie/lvfs-website.git","ssh_url":"git@github.com:hughsie/lvfs-website.git","clone_url":"https://github.com/hughsie/lvfs-website.git","svn_url":"https://github.com/hughsie/lvfs-website","homepage":null,"size":2039,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":4,"open_issues":17,"watchers":1,"default_branch":"master"}},"base":{"label":"hughsie:master","ref":"master","sha":"679694d104bb196f35542a6b54e794b8d84fad26","user":{"login":"hughsie","id":151380,"avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"repo":{"id":47995721,"name":"lvfs-website","full_name":"hughsie/lvfs-website","owner":{"login":"hughsie","id":151380,"avatar_url":"https://avatars0.githubusercontent.com/u/151380?v=4","gravatar_id":"","url":"https://api.github.com/users/hughsie","html_url":"https://github.com/hughsie","followers_url":"https://api.github.com/users/hughsie/followers","following_url":"https://api.github.com/users/hughsie/following{/other_user}","gists_url":"https://api.github.com/users/hughsie/gists{/gist_id}","starred_url":"https://api.github.com/users/hughsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughsie/subscriptions","organizations_url":"https://api.github.com/users/hughsie/orgs","repos_url":"https://api.github.com/users/hughsie/repos","events_url":"https://api.github.com/users/hughsie/events{/privacy}","received_events_url":"https://api.github.com/users/hughsie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughsie/lvfs-website","description":"The LVFS website","fork":false,"url":"https://api.github.com/repos/hughsie/lvfs-website","forks_url":"https://api.github.com/repos/hughsie/lvfs-website/forks","keys_url":"https://api.github.com/repos/hughsie/lvfs-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughsie/lvfs-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughsie/lvfs-website/teams","hooks_url":"https://api.github.com/repos/hughsie/lvfs-website/hooks","issue_events_url":"https://api.github.com/repos/hughsie/lvfs-website/issues/events{/number}","events_url":"https://api.github.com/repos/hughsie/lvfs-website/events","assignees_url":"https://api.github.com/repos/hughsie/lvfs-website/assignees{/user}","branches_url":"https://api.github.com/repos/hughsie/lvfs-website/branches{/branch}","tags_url":"https://api.github.com/repos/hughsie/lvfs-website/tags","blobs_url":"https://api.github.com/repos/hughsie/lvfs-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughsie/lvfs-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughsie/lvfs-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughsie/lvfs-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughsie/lvfs-website/statuses/{sha}","languages_url":"https://api.github.com/repos/hughsie/lvfs-website/languages","stargazers_url":"https://api.github.com/repos/hughsie/lvfs-website/stargazers","contributors_url":"https://api.github.com/repos/hughsie/lvfs-website/contributors","subscribers_url":"https://api.github.com/repos/hughsie/lvfs-website/subscribers","subscription_url":"https://api.github.com/repos/hughsie/lvfs-website/subscription","commits_url":"https://api.github.com/repos/hughsie/lvfs-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughsie/lvfs-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughsie/lvfs-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughsie/lvfs-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughsie/lvfs-website/contents/{+path}","compare_url":"https://api.github.com/repos/hughsie/lvfs-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughsie/lvfs-website/merges","archive_url":"https://api.github.com/repos/hughsie/lvfs-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughsie/lvfs-website/downloads","issues_url":"https://api.github.com/repos/hughsie/lvfs-website/issues{/number}","pulls_url":"https://api.github.com/repos/hughsie/lvfs-website/pulls{/number}","milestones_url":"https://api.github.com/repos/hughsie/lvfs-website/milestones{/number}","notifications_url":"https://api.github.com/repos/hughsie/lvfs-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughsie/lvfs-website/labels{/name}","releases_url":"https://api.github.com/repos/hughsie/lvfs-website/releases{/id}","deployments_url":"https://api.github.com/repos/hughsie/lvfs-website/deployments","created_at":"2015-12-14T19:13:26Z","updated_at":"2017-02-27T01:29:00Z","pushed_at":"2018-03-02T16:52:55Z","git_url":"git://github.com/hughsie/lvfs-website.git","ssh_url":"git@github.com:hughsie/lvfs-website.git","clone_url":"https://github.com/hughsie/lvfs-website.git","svn_url":"https://github.com/hughsie/lvfs-website","homepage":null,"size":2039,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":4,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hughsie/lvfs-website/pulls/79"},"html":{"href":"https://github.com/hughsie/lvfs-website/pull/79"},"issue":{"href":"https://api.github.com/repos/hughsie/lvfs-website/issues/79"},"comments":{"href":"https://api.github.com/repos/hughsie/lvfs-website/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/hughsie/lvfs-website/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/hughsie/lvfs-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hughsie/lvfs-website/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/hughsie/lvfs-website/statuses/a237d98fc34c160bc43012ee66cc1294865e9111"}},"author_association":"OWNER"}}
{"actor":{"display_login":"superm1"}}