{"action":"created","comment":{"url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/comments/237809692","pull_request_review_id":180198757,"id":237809692,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzgwOTY5Mg==","diff_hunk":"@@ -810,8 +812,15 @@ static int next_multi_pcap_file(struct ctx *ctx, int fd)\n \t} else\n \t\tftime = time(NULL);\n \n-\tslprintf(fname, sizeof(fname), \"%s/%s%lu.pcap\", ctx->device_out,\n-\t\t ctx->prefix ? : \"dump-\", ftime);\n+\tif (ctx->overwrite_interval > 0) {\n+\t    slprintf(fname, sizeof(fname), \"%s/%s%010lu.pcap\", ctx->device_out,\n+\t             ctx->prefix ? : \"dump-\", ctx->file_number++);","path":"netsniff-ng.c","position":33,"original_position":33,"commit_id":"2465b24ddc997e99b2afc58d23d090fdeb22395f","original_commit_id":"2465b24ddc997e99b2afc58d23d090fdeb22395f","user":{"login":"tklauser","id":539708,"node_id":"MDQ6VXNlcjUzOTcwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/539708?v=4","gravatar_id":"","url":"https://api.github.com/users/tklauser","html_url":"https://github.com/tklauser","followers_url":"https://api.github.com/users/tklauser/followers","following_url":"https://api.github.com/users/tklauser/following{/other_user}","gists_url":"https://api.github.com/users/tklauser/gists{/gist_id}","starred_url":"https://api.github.com/users/tklauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklauser/subscriptions","organizations_url":"https://api.github.com/users/tklauser/orgs","repos_url":"https://api.github.com/users/tklauser/repos","events_url":"https://api.github.com/users/tklauser/events{/privacy}","received_events_url":"https://api.github.com/users/tklauser/received_events","type":"User","site_admin":false},"body":"Move the file number increment out of the slprintf call to improve readability.","created_at":"2018-11-30T10:16:08Z","updated_at":"2018-11-30T10:21:48Z","html_url":"https://github.com/netsniff-ng/netsniff-ng/pull/201#discussion_r237809692","pull_request_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/201","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/comments/237809692"},"html":{"href":"https://github.com/netsniff-ng/netsniff-ng/pull/201#discussion_r237809692"},"pull_request":{"href":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/201","id":234866684,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODY2Njg0","html_url":"https://github.com/netsniff-ng/netsniff-ng/pull/201","diff_url":"https://github.com/netsniff-ng/netsniff-ng/pull/201.diff","patch_url":"https://github.com/netsniff-ng/netsniff-ng/pull/201.patch","issue_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/issues/201","number":201,"state":"open","locked":false,"title":"Fix #147 Implement rotating capture files","user":{"login":"expressoCoder","id":863220,"node_id":"MDQ6VXNlcjg2MzIyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/863220?v=4","gravatar_id":"","url":"https://api.github.com/users/expressoCoder","html_url":"https://github.com/expressoCoder","followers_url":"https://api.github.com/users/expressoCoder/followers","following_url":"https://api.github.com/users/expressoCoder/following{/other_user}","gists_url":"https://api.github.com/users/expressoCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/expressoCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expressoCoder/subscriptions","organizations_url":"https://api.github.com/users/expressoCoder/orgs","repos_url":"https://api.github.com/users/expressoCoder/repos","events_url":"https://api.github.com/users/expressoCoder/events{/privacy}","received_events_url":"https://api.github.com/users/expressoCoder/received_events","type":"User","site_admin":false},"body":"Added new option -O, --overwrite. Replaces timestamp with number that wraps around. Relies on -F being specified","created_at":"2018-11-30T04:14:18Z","updated_at":"2018-11-30T10:21:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a77b4946afad39d4e3ac0dbe1c1f6344d7399b3d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/201/commits","review_comments_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/201/comments","review_comment_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/issues/201/comments","statuses_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/statuses/2465b24ddc997e99b2afc58d23d090fdeb22395f","head":{"label":"expressoCoder:rotate-files","ref":"rotate-files","sha":"2465b24ddc997e99b2afc58d23d090fdeb22395f","user":{"login":"expressoCoder","id":863220,"node_id":"MDQ6VXNlcjg2MzIyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/863220?v=4","gravatar_id":"","url":"https://api.github.com/users/expressoCoder","html_url":"https://github.com/expressoCoder","followers_url":"https://api.github.com/users/expressoCoder/followers","following_url":"https://api.github.com/users/expressoCoder/following{/other_user}","gists_url":"https://api.github.com/users/expressoCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/expressoCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expressoCoder/subscriptions","organizations_url":"https://api.github.com/users/expressoCoder/orgs","repos_url":"https://api.github.com/users/expressoCoder/repos","events_url":"https://api.github.com/users/expressoCoder/events{/privacy}","received_events_url":"https://api.github.com/users/expressoCoder/received_events","type":"User","site_admin":false},"repo":{"id":159765560,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk3NjU1NjA=","name":"netsniff-ng","full_name":"expressoCoder/netsniff-ng","private":false,"owner":{"login":"expressoCoder","id":863220,"node_id":"MDQ6VXNlcjg2MzIyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/863220?v=4","gravatar_id":"","url":"https://api.github.com/users/expressoCoder","html_url":"https://github.com/expressoCoder","followers_url":"https://api.github.com/users/expressoCoder/followers","following_url":"https://api.github.com/users/expressoCoder/following{/other_user}","gists_url":"https://api.github.com/users/expressoCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/expressoCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expressoCoder/subscriptions","organizations_url":"https://api.github.com/users/expressoCoder/orgs","repos_url":"https://api.github.com/users/expressoCoder/repos","events_url":"https://api.github.com/users/expressoCoder/events{/privacy}","received_events_url":"https://api.github.com/users/expressoCoder/received_events","type":"User","site_admin":false},"html_url":"https://github.com/expressoCoder/netsniff-ng","description":"A Swiss army knife for your daily Linux network plumbing.","fork":true,"url":"https://api.github.com/repos/expressoCoder/netsniff-ng","forks_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/forks","keys_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/teams","hooks_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/hooks","issue_events_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/issues/events{/number}","events_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/events","assignees_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/assignees{/user}","branches_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/branches{/branch}","tags_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/tags","blobs_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/languages","stargazers_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/stargazers","contributors_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/contributors","subscribers_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/subscribers","subscription_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/subscription","commits_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/contents/{+path}","compare_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/merges","archive_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/downloads","issues_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/issues{/number}","pulls_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/labels{/name}","releases_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/releases{/id}","deployments_url":"https://api.github.com/repos/expressoCoder/netsniff-ng/deployments","created_at":"2018-11-30T03:50:41Z","updated_at":"2018-11-30T03:50:44Z","pushed_at":"2018-11-30T04:10:42Z","git_url":"git://github.com/expressoCoder/netsniff-ng.git","ssh_url":"git@github.com:expressoCoder/netsniff-ng.git","clone_url":"https://github.com/expressoCoder/netsniff-ng.git","svn_url":"https://github.com/expressoCoder/netsniff-ng","homepage":"http://netsniff-ng.org","size":2810,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netsniff-ng:master","ref":"master","sha":"f79d3ab1dee474740ba7ad119fd8a86a73a796bc","user":{"login":"netsniff-ng","id":6716649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTY2NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6716649?v=4","gravatar_id":"","url":"https://api.github.com/users/netsniff-ng","html_url":"https://github.com/netsniff-ng","followers_url":"https://api.github.com/users/netsniff-ng/followers","following_url":"https://api.github.com/users/netsniff-ng/following{/other_user}","gists_url":"https://api.github.com/users/netsniff-ng/gists{/gist_id}","starred_url":"https://api.github.com/users/netsniff-ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netsniff-ng/subscriptions","organizations_url":"https://api.github.com/users/netsniff-ng/orgs","repos_url":"https://api.github.com/users/netsniff-ng/repos","events_url":"https://api.github.com/users/netsniff-ng/events{/privacy}","received_events_url":"https://api.github.com/users/netsniff-ng/received_events","type":"Organization","site_admin":false},"repo":{"id":1496894,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2ODk0","name":"netsniff-ng","full_name":"netsniff-ng/netsniff-ng","private":false,"owner":{"login":"netsniff-ng","id":6716649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTY2NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6716649?v=4","gravatar_id":"","url":"https://api.github.com/users/netsniff-ng","html_url":"https://github.com/netsniff-ng","followers_url":"https://api.github.com/users/netsniff-ng/followers","following_url":"https://api.github.com/users/netsniff-ng/following{/other_user}","gists_url":"https://api.github.com/users/netsniff-ng/gists{/gist_id}","starred_url":"https://api.github.com/users/netsniff-ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netsniff-ng/subscriptions","organizations_url":"https://api.github.com/users/netsniff-ng/orgs","repos_url":"https://api.github.com/users/netsniff-ng/repos","events_url":"https://api.github.com/users/netsniff-ng/events{/privacy}","received_events_url":"https://api.github.com/users/netsniff-ng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/netsniff-ng/netsniff-ng","description":"A Swiss army knife for your daily Linux network plumbing.","fork":false,"url":"https://api.github.com/repos/netsniff-ng/netsniff-ng","forks_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/forks","keys_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/teams","hooks_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/hooks","issue_events_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/issues/events{/number}","events_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/events","assignees_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/assignees{/user}","branches_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/branches{/branch}","tags_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/tags","blobs_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/languages","stargazers_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/stargazers","contributors_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/contributors","subscribers_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/subscribers","subscription_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/subscription","commits_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/contents/{+path}","compare_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/merges","archive_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/downloads","issues_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/issues{/number}","pulls_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/labels{/name}","releases_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/releases{/id}","deployments_url":"https://api.github.com/repos/netsniff-ng/netsniff-ng/deployments","created_at":"2011-03-18T16:21:21Z","updated_at":"2018-11-29T02:02:52Z","pushed_at":"2018-11-30T04:14:19Z","git_url":"git://github.com/netsniff-ng/netsniff-ng.git","ssh_url":"git@github.com:netsniff-ng/netsniff-ng.git","clone_url":"https://github.com/netsniff-ng/netsniff-ng.git","svn_url":"https://github.com/netsniff-ng/netsniff-ng","homepage":"http://netsniff-ng.org","size":2809,"stargazers_count":643,"watchers_count":643,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":167,"open_issues":44,"watchers":643,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/201"},"html":{"href":"https://github.com/netsniff-ng/netsniff-ng/pull/201"},"issue":{"href":"https://api.github.com/repos/netsniff-ng/netsniff-ng/issues/201"},"comments":{"href":"https://api.github.com/repos/netsniff-ng/netsniff-ng/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netsniff-ng/netsniff-ng/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/netsniff-ng/netsniff-ng/statuses/2465b24ddc997e99b2afc58d23d090fdeb22395f"}},"author_association":"NONE"}}
{"actor":{"display_login":"tklauser"}}