{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/211989644","pull_request_review_id":148526023,"id":211989644,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTk4OTY0NA==","diff_hunk":"@@ -20,3 +20,7 @@ def test_find_eog():\n \n     events = find_eog_events(raw, reject_by_annotation=True)\n     assert all(events[:, 0] < 29000)\n+\n+\t#threshold option \n+\tevents_thr = find_eog_events(raw, thresh=100e-6)\n+\tassert len(events) == 5","path":"mne/preprocessing/tests/test_eog.py","position":7,"original_position":7,"commit_id":"efe6300b9c672186158a48ee7e8f0437080f1579","original_commit_id":"efe6300b9c672186158a48ee7e8f0437080f1579","user":{"login":"agramfort","id":161052,"node_id":"MDQ6VXNlcjE2MTA1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/161052?v=4","gravatar_id":"","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"body":"looks like you have an indentation problem:\r\n\r\ndid you run:\r\n\r\n`pytest mne/preprocessing/tests/test_eog.py`\r\n\r\n?\r\n\r\nand\r\n\r\n`flake8 mne/preprocessing/tests/test_eog.py`\r\n\r\n?","created_at":"2018-08-22T15:02:01Z","updated_at":"2018-08-22T15:02:09Z","html_url":"https://github.com/mne-tools/mne-python/pull/5461#discussion_r211989644","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5461","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/211989644"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/5461#discussion_r211989644"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5461"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5461","id":209932631,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTMyNjMx","html_url":"https://github.com/mne-tools/mne-python/pull/5461","diff_url":"https://github.com/mne-tools/mne-python/pull/5461.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/5461.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5461","number":5461,"state":"open","locked":false,"title":"Added threshold option for find_eog_events() and create_eog_epochs()","user":{"login":"pmolfese","id":3665743,"node_id":"MDQ6VXNlcjM2NjU3NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3665743?v=4","gravatar_id":"","url":"https://api.github.com/users/pmolfese","html_url":"https://github.com/pmolfese","followers_url":"https://api.github.com/users/pmolfese/followers","following_url":"https://api.github.com/users/pmolfese/following{/other_user}","gists_url":"https://api.github.com/users/pmolfese/gists{/gist_id}","starred_url":"https://api.github.com/users/pmolfese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmolfese/subscriptions","organizations_url":"https://api.github.com/users/pmolfese/orgs","repos_url":"https://api.github.com/users/pmolfese/repos","events_url":"https://api.github.com/users/pmolfese/events{/privacy}","received_events_url":"https://api.github.com/users/pmolfese/received_events","type":"User","site_admin":false},"body":"#### What does this implement/fix?\r\nFound that find_eog_events() and thus create_eog_epochs() weren't detecting many EOG events, despite seeing them in data.  The function used on the backend - peak_finder() - can take a threshold as argument, added option for user to pass a threshold to the function.  Initial testing found better detection of blinks.  \r\n\r\n\r\n#### Additional information\r\nPerhaps more necessary in EEG recordings.  \r\n","created_at":"2018-08-21T19:34:39Z","updated_at":"2018-08-22T15:02:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38cf5749628fdeb837cd354f9124b2591f10f007","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5461/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5461/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5461/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/efe6300b9c672186158a48ee7e8f0437080f1579","head":{"label":"pmolfese:master","ref":"master","sha":"efe6300b9c672186158a48ee7e8f0437080f1579","user":{"login":"pmolfese","id":3665743,"node_id":"MDQ6VXNlcjM2NjU3NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3665743?v=4","gravatar_id":"","url":"https://api.github.com/users/pmolfese","html_url":"https://github.com/pmolfese","followers_url":"https://api.github.com/users/pmolfese/followers","following_url":"https://api.github.com/users/pmolfese/following{/other_user}","gists_url":"https://api.github.com/users/pmolfese/gists{/gist_id}","starred_url":"https://api.github.com/users/pmolfese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmolfese/subscriptions","organizations_url":"https://api.github.com/users/pmolfese/orgs","repos_url":"https://api.github.com/users/pmolfese/repos","events_url":"https://api.github.com/users/pmolfese/events{/privacy}","received_events_url":"https://api.github.com/users/pmolfese/received_events","type":"User","site_admin":false},"repo":{"id":145609375,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2MDkzNzU=","name":"mne-python","full_name":"pmolfese/mne-python","owner":{"login":"pmolfese","id":3665743,"node_id":"MDQ6VXNlcjM2NjU3NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3665743?v=4","gravatar_id":"","url":"https://api.github.com/users/pmolfese","html_url":"https://github.com/pmolfese","followers_url":"https://api.github.com/users/pmolfese/followers","following_url":"https://api.github.com/users/pmolfese/following{/other_user}","gists_url":"https://api.github.com/users/pmolfese/gists{/gist_id}","starred_url":"https://api.github.com/users/pmolfese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmolfese/subscriptions","organizations_url":"https://api.github.com/users/pmolfese/orgs","repos_url":"https://api.github.com/users/pmolfese/repos","events_url":"https://api.github.com/users/pmolfese/events{/privacy}","received_events_url":"https://api.github.com/users/pmolfese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmolfese/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/pmolfese/mne-python","forks_url":"https://api.github.com/repos/pmolfese/mne-python/forks","keys_url":"https://api.github.com/repos/pmolfese/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmolfese/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmolfese/mne-python/teams","hooks_url":"https://api.github.com/repos/pmolfese/mne-python/hooks","issue_events_url":"https://api.github.com/repos/pmolfese/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/pmolfese/mne-python/events","assignees_url":"https://api.github.com/repos/pmolfese/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/pmolfese/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/pmolfese/mne-python/tags","blobs_url":"https://api.github.com/repos/pmolfese/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmolfese/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmolfese/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmolfese/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmolfese/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/pmolfese/mne-python/languages","stargazers_url":"https://api.github.com/repos/pmolfese/mne-python/stargazers","contributors_url":"https://api.github.com/repos/pmolfese/mne-python/contributors","subscribers_url":"https://api.github.com/repos/pmolfese/mne-python/subscribers","subscription_url":"https://api.github.com/repos/pmolfese/mne-python/subscription","commits_url":"https://api.github.com/repos/pmolfese/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmolfese/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmolfese/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmolfese/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmolfese/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/pmolfese/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmolfese/mne-python/merges","archive_url":"https://api.github.com/repos/pmolfese/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmolfese/mne-python/downloads","issues_url":"https://api.github.com/repos/pmolfese/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/pmolfese/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/pmolfese/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/pmolfese/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmolfese/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/pmolfese/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/pmolfese/mne-python/deployments","created_at":"2018-08-21T19:21:51Z","updated_at":"2018-08-22T14:10:22Z","pushed_at":"2018-08-22T14:10:19Z","git_url":"git://github.com/pmolfese/mne-python.git","ssh_url":"git@github.com:pmolfese/mne-python.git","clone_url":"https://github.com/pmolfese/mne-python.git","svn_url":"https://github.com/pmolfese/mne-python","homepage":"http://martinos.org/mne/","size":101016,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"0802291704a45000b04c31d696c5c84828997c27","user":{"login":"mne-tools","id":583875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4Mzg3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAxNTg0","name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4Mzg3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2018-08-21T20:36:59Z","pushed_at":"2018-08-22T14:59:44Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":100980,"stargazers_count":574,"watchers_count":574,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":435,"mirror_url":null,"archived":false,"open_issues_count":257,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":435,"open_issues":257,"watchers":574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5461"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/5461"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/5461"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/5461/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5461/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5461/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/efe6300b9c672186158a48ee7e8f0437080f1579"}},"author_association":"NONE"}}
{"actor":{"display_login":"agramfort"}}