{"action":"created","issue":{"url":"https://api.github.com/repos/ijl20/tfc_web/issues/113","repository_url":"https://api.github.com/repos/ijl20/tfc_web","labels_url":"https://api.github.com/repos/ijl20/tfc_web/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/ijl20/tfc_web/issues/113/comments","events_url":"https://api.github.com/repos/ijl20/tfc_web/issues/113/events","html_url":"https://github.com/ijl20/tfc_web/pull/113","id":314105500,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgxNDg2ODUy","number":113,"title":" Rework styling in layout.css, separate from smartpanel.css","user":{"login":"jw35","id":2385623,"node_id":"MDQ6VXNlcjIzODU2MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2385623?v=4","gravatar_id":"","url":"https://api.github.com/users/jw35","html_url":"https://github.com/jw35","followers_url":"https://api.github.com/users/jw35/followers","following_url":"https://api.github.com/users/jw35/following{/other_user}","gists_url":"https://api.github.com/users/jw35/gists{/gist_id}","starred_url":"https://api.github.com/users/jw35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jw35/subscriptions","organizations_url":"https://api.github.com/users/jw35/orgs","repos_url":"https://api.github.com/users/jw35/repos","events_url":"https://api.github.com/users/jw35/events{/privacy}","received_events_url":"https://api.github.com/users/jw35/received_events","type":"User","site_admin":false},"labels":[{"id":827671282,"node_id":"MDU6TGFiZWw4Mjc2NzEyODI=","url":"https://api.github.com/repos/ijl20/tfc_web/labels/SmartPanels","name":"SmartPanels","color":"49e3f4","default":false}],"state":"open","locked":false,"assignee":{"login":"jw35","id":2385623,"node_id":"MDQ6VXNlcjIzODU2MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2385623?v=4","gravatar_id":"","url":"https://api.github.com/users/jw35","html_url":"https://github.com/jw35","followers_url":"https://api.github.com/users/jw35/followers","following_url":"https://api.github.com/users/jw35/following{/other_user}","gists_url":"https://api.github.com/users/jw35/gists{/gist_id}","starred_url":"https://api.github.com/users/jw35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jw35/subscriptions","organizations_url":"https://api.github.com/users/jw35/orgs","repos_url":"https://api.github.com/users/jw35/repos","events_url":"https://api.github.com/users/jw35/events{/privacy}","received_events_url":"https://api.github.com/users/jw35/received_events","type":"User","site_admin":false},"assignees":[{"login":"jw35","id":2385623,"node_id":"MDQ6VXNlcjIzODU2MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2385623?v=4","gravatar_id":"","url":"https://api.github.com/users/jw35","html_url":"https://github.com/jw35","followers_url":"https://api.github.com/users/jw35/followers","following_url":"https://api.github.com/users/jw35/following{/other_user}","gists_url":"https://api.github.com/users/jw35/gists{/gist_id}","starred_url":"https://api.github.com/users/jw35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jw35/subscriptions","organizations_url":"https://api.github.com/users/jw35/orgs","repos_url":"https://api.github.com/users/jw35/repos","events_url":"https://api.github.com/users/jw35/events{/privacy}","received_events_url":"https://api.github.com/users/jw35/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-04-13T13:23:03Z","updated_at":"2018-08-19T19:37:32Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ijl20/tfc_web/pulls/113","html_url":"https://github.com/ijl20/tfc_web/pull/113","diff_url":"https://github.com/ijl20/tfc_web/pull/113.diff","patch_url":"https://github.com/ijl20/tfc_web/pull/113.patch"},"body":"This pull-request represents an experiment. I believe the result is worthwhile, but may have implications that I haven't thought of. Comments, even negative ones, would be welcome.\r\n\r\nThis version of tfc_web is currently running on \r\ntfc-app4, in particular serving http://tfc-app4.cl.cam.ac.uk/smartpanel/layout/1/\r\n\r\nChange summary:\r\n\r\nSeperate layout.html from layout_config.html. Initailly by \r\nmaking it depend on a seperate css file, layout.css, which started as a\r\ncopy of smartpanel.css.\r\n\r\nIn layout.html, switch the grid layout to using nested \\<div\\>s rather\r\nthen \\<ol\\>/\\<li\\> and limit in-line CSS to things we want to template\r\neffecting size and/or position. Arrange that it has fewer implications\r\nfor the styling of the widgets themselves, remove global suppression of\r\nmargin/border, etc. Add 'class=\"layout\"' to the body tag.\r\n\r\nIn layout.css, adapt styling copied over from smartpanel.css to match\r\nthe changes above and remove unreferenced rules ans unnecessary styling.\r\nUSe absolute positioning to locate the logo and grid container divs to\r\navoid the need to globally set margins and padding to 0. All layout.css\r\nselectors are prefixed by .layout. This essentially namespace-\r\nqualifies all the class names to make it easier to use layout.css\r\nwith other css without name clashes.\r\n\r\nIn widgets.css, remove the rules that were only there to undo changes\r\napplied by smartpanel.css, and move the global reset of box-model\r\nstyling into layout.css where it belongs."},"comment":{"url":"https://api.github.com/repos/ijl20/tfc_web/issues/comments/414150588","html_url":"https://github.com/ijl20/tfc_web/pull/113#issuecomment-414150588","issue_url":"https://api.github.com/repos/ijl20/tfc_web/issues/113","id":414150588,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDE1MDU4OA==","user":{"login":"abrahammartin","id":1429691,"node_id":"MDQ6VXNlcjE0Mjk2OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1429691?v=4","gravatar_id":"","url":"https://api.github.com/users/abrahammartin","html_url":"https://github.com/abrahammartin","followers_url":"https://api.github.com/users/abrahammartin/followers","following_url":"https://api.github.com/users/abrahammartin/following{/other_user}","gists_url":"https://api.github.com/users/abrahammartin/gists{/gist_id}","starred_url":"https://api.github.com/users/abrahammartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrahammartin/subscriptions","organizations_url":"https://api.github.com/users/abrahammartin/orgs","repos_url":"https://api.github.com/users/abrahammartin/repos","events_url":"https://api.github.com/users/abrahammartin/events{/privacy}","received_events_url":"https://api.github.com/users/abrahammartin/received_events","type":"User","site_admin":false},"created_at":"2018-08-19T19:37:32Z","updated_at":"2018-08-19T19:37:32Z","author_association":"COLLABORATOR","body":"@jw35 do you want to adapt this PR to the new designer or should I close it?"}}
{"actor":{"display_login":"abrahammartin"}}