{"action":"closed","number":862,"pull_request":{"url":"https://api.github.com/repos/tpm2-software/tpm2-tss/pulls/862","id":175361993,"html_url":"https://github.com/tpm2-software/tpm2-tss/pull/862","diff_url":"https://github.com/tpm2-software/tpm2-tss/pull/862.diff","patch_url":"https://github.com/tpm2-software/tpm2-tss/pull/862.patch","issue_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/issues/862","number":862,"state":"closed","locked":false,"title":"headers: Remove tpm20.h header.","user":{"login":"flihp","id":1550813,"avatar_url":"https://avatars2.githubusercontent.com/u/1550813?v=4","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"body":"This \"convenience\" header isn't part of the spec. It also pulled in a\r\nnumber of headers that had nothing to do with the TPM or the spec:\r\nstddef.h, stdint.h, stdlib.h, string.h etc. Now that we've cleaned up\r\nthe headers users consuming the following libraries only need to include\r\nthe related header:\r\n- libtss2-mu, include tss2_mu.h\r\n- libtss2-sys, include tss2_sys.h\r\n- libtss2-esys, include tss2_esys.h\r\n\r\nThis obsoletes the tpm20.h file completely. All other changes in this\r\ncommit are fixing up our source code to include the right headers and\r\ncleaning up other places where we were leaning on tpm20.h header to\r\ninclude system headers for us (aka undoing the sloppy structure that\r\nthis \"convenience\" header encouraged / required).\r\n\r\nThere are also a number of source files that had no newline at the end\r\nof the file. The script that I used to fix up the tpm20.h include in\r\nthese files added this, as most editors would do as well. I'm leaving\r\nthese in place baring objections during code review.\r\n\r\nSigned-off-by: Philip Tricca <philip.b.tricca@intel.com>","created_at":"2018-03-15T19:55:07Z","updated_at":"2018-03-16T11:31:46Z","closed_at":"2018-03-16T11:31:46Z","merged_at":"2018-03-16T11:31:46Z","merge_commit_sha":"910f17c96d91159ea29e660a5450c3cfad591d62","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/pulls/862/commits","review_comments_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/pulls/862/comments","review_comment_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/issues/862/comments","statuses_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/statuses/3c37597aea4dc6bd3138a58c6933bccef3f31121","head":{"label":"flihp:inconvenience","ref":"inconvenience","sha":"3c37597aea4dc6bd3138a58c6933bccef3f31121","user":{"login":"flihp","id":1550813,"avatar_url":"https://avatars2.githubusercontent.com/u/1550813?v=4","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"repo":{"id":40271238,"name":"tpm2-tss","full_name":"flihp/tpm2-tss","owner":{"login":"flihp","id":1550813,"avatar_url":"https://avatars2.githubusercontent.com/u/1550813?v=4","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flihp/tpm2-tss","description":null,"fork":true,"url":"https://api.github.com/repos/flihp/tpm2-tss","forks_url":"https://api.github.com/repos/flihp/tpm2-tss/forks","keys_url":"https://api.github.com/repos/flihp/tpm2-tss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flihp/tpm2-tss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flihp/tpm2-tss/teams","hooks_url":"https://api.github.com/repos/flihp/tpm2-tss/hooks","issue_events_url":"https://api.github.com/repos/flihp/tpm2-tss/issues/events{/number}","events_url":"https://api.github.com/repos/flihp/tpm2-tss/events","assignees_url":"https://api.github.com/repos/flihp/tpm2-tss/assignees{/user}","branches_url":"https://api.github.com/repos/flihp/tpm2-tss/branches{/branch}","tags_url":"https://api.github.com/repos/flihp/tpm2-tss/tags","blobs_url":"https://api.github.com/repos/flihp/tpm2-tss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flihp/tpm2-tss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flihp/tpm2-tss/git/refs{/sha}","trees_url":"https://api.github.com/repos/flihp/tpm2-tss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flihp/tpm2-tss/statuses/{sha}","languages_url":"https://api.github.com/repos/flihp/tpm2-tss/languages","stargazers_url":"https://api.github.com/repos/flihp/tpm2-tss/stargazers","contributors_url":"https://api.github.com/repos/flihp/tpm2-tss/contributors","subscribers_url":"https://api.github.com/repos/flihp/tpm2-tss/subscribers","subscription_url":"https://api.github.com/repos/flihp/tpm2-tss/subscription","commits_url":"https://api.github.com/repos/flihp/tpm2-tss/commits{/sha}","git_commits_url":"https://api.github.com/repos/flihp/tpm2-tss/git/commits{/sha}","comments_url":"https://api.github.com/repos/flihp/tpm2-tss/comments{/number}","issue_comment_url":"https://api.github.com/repos/flihp/tpm2-tss/issues/comments{/number}","contents_url":"https://api.github.com/repos/flihp/tpm2-tss/contents/{+path}","compare_url":"https://api.github.com/repos/flihp/tpm2-tss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flihp/tpm2-tss/merges","archive_url":"https://api.github.com/repos/flihp/tpm2-tss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flihp/tpm2-tss/downloads","issues_url":"https://api.github.com/repos/flihp/tpm2-tss/issues{/number}","pulls_url":"https://api.github.com/repos/flihp/tpm2-tss/pulls{/number}","milestones_url":"https://api.github.com/repos/flihp/tpm2-tss/milestones{/number}","notifications_url":"https://api.github.com/repos/flihp/tpm2-tss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flihp/tpm2-tss/labels{/name}","releases_url":"https://api.github.com/repos/flihp/tpm2-tss/releases{/id}","deployments_url":"https://api.github.com/repos/flihp/tpm2-tss/deployments","created_at":"2015-08-05T22:10:59Z","updated_at":"2017-08-03T20:02:37Z","pushed_at":"2018-03-16T00:31:30Z","git_url":"git://github.com/flihp/tpm2-tss.git","ssh_url":"git@github.com:flihp/tpm2-tss.git","clone_url":"https://github.com/flihp/tpm2-tss.git","svn_url":"https://github.com/flihp/tpm2-tss","homepage":null,"size":16523,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tpm2-software:master","ref":"master","sha":"88ced72935b96c5d4bb3c6850274b20b25bc3c0f","user":{"login":"tpm2-software","id":34488697,"avatar_url":"https://avatars3.githubusercontent.com/u/34488697?v=4","gravatar_id":"","url":"https://api.github.com/users/tpm2-software","html_url":"https://github.com/tpm2-software","followers_url":"https://api.github.com/users/tpm2-software/followers","following_url":"https://api.github.com/users/tpm2-software/following{/other_user}","gists_url":"https://api.github.com/users/tpm2-software/gists{/gist_id}","starred_url":"https://api.github.com/users/tpm2-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpm2-software/subscriptions","organizations_url":"https://api.github.com/users/tpm2-software/orgs","repos_url":"https://api.github.com/users/tpm2-software/repos","events_url":"https://api.github.com/users/tpm2-software/events{/privacy}","received_events_url":"https://api.github.com/users/tpm2-software/received_events","type":"Organization","site_admin":false},"repo":{"id":38320020,"name":"tpm2-tss","full_name":"tpm2-software/tpm2-tss","owner":{"login":"tpm2-software","id":34488697,"avatar_url":"https://avatars3.githubusercontent.com/u/34488697?v=4","gravatar_id":"","url":"https://api.github.com/users/tpm2-software","html_url":"https://github.com/tpm2-software","followers_url":"https://api.github.com/users/tpm2-software/followers","following_url":"https://api.github.com/users/tpm2-software/following{/other_user}","gists_url":"https://api.github.com/users/tpm2-software/gists{/gist_id}","starred_url":"https://api.github.com/users/tpm2-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpm2-software/subscriptions","organizations_url":"https://api.github.com/users/tpm2-software/orgs","repos_url":"https://api.github.com/users/tpm2-software/repos","events_url":"https://api.github.com/users/tpm2-software/events{/privacy}","received_events_url":"https://api.github.com/users/tpm2-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tpm2-software/tpm2-tss","description":"OSS implementation of the TCG TPM2 Software Stack (TSS2)","fork":false,"url":"https://api.github.com/repos/tpm2-software/tpm2-tss","forks_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/forks","keys_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/teams","hooks_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/hooks","issue_events_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/issues/events{/number}","events_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/events","assignees_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/assignees{/user}","branches_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/branches{/branch}","tags_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/tags","blobs_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/statuses/{sha}","languages_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/languages","stargazers_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/stargazers","contributors_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/contributors","subscribers_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/subscribers","subscription_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/subscription","commits_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/contents/{+path}","compare_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/merges","archive_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/downloads","issues_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/issues{/number}","pulls_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/pulls{/number}","milestones_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/milestones{/number}","notifications_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/labels{/name}","releases_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/releases{/id}","deployments_url":"https://api.github.com/repos/tpm2-software/tpm2-tss/deployments","created_at":"2015-06-30T16:21:57Z","updated_at":"2018-03-15T22:40:33Z","pushed_at":"2018-03-16T11:31:45Z","git_url":"git://github.com/tpm2-software/tpm2-tss.git","ssh_url":"git@github.com:tpm2-software/tpm2-tss.git","clone_url":"https://github.com/tpm2-software/tpm2-tss.git","svn_url":"https://github.com/tpm2-software/tpm2-tss","homepage":"https://github.com/tpm2-software/tpm2-tss","size":16346,"stargazers_count":114,"watchers_count":114,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":80,"open_issues":56,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tss/pulls/862"},"html":{"href":"https://github.com/tpm2-software/tpm2-tss/pull/862"},"issue":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tss/issues/862"},"comments":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tss/issues/862/comments"},"review_comments":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tss/pulls/862/comments"},"review_comment":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tss/pulls/862/commits"},"statuses":{"href":"https://api.github.com/repos/tpm2-software/tpm2-tss/statuses/3c37597aea4dc6bd3138a58c6933bccef3f31121"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"AndreasFuchsSIT","id":5175109,"avatar_url":"https://avatars3.githubusercontent.com/u/5175109?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreasFuchsSIT","html_url":"https://github.com/AndreasFuchsSIT","followers_url":"https://api.github.com/users/AndreasFuchsSIT/followers","following_url":"https://api.github.com/users/AndreasFuchsSIT/following{/other_user}","gists_url":"https://api.github.com/users/AndreasFuchsSIT/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasFuchsSIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasFuchsSIT/subscriptions","organizations_url":"https://api.github.com/users/AndreasFuchsSIT/orgs","repos_url":"https://api.github.com/users/AndreasFuchsSIT/repos","events_url":"https://api.github.com/users/AndreasFuchsSIT/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasFuchsSIT/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":880,"deletions":513,"changed_files":344}}
{"actor":{"display_login":"AndreasFuchsSIT"}}