{"action":"created","issue":{"url":"https://api.github.com/repos/kubevirt/web-ui-components/issues/10","repository_url":"https://api.github.com/repos/kubevirt/web-ui-components","labels_url":"https://api.github.com/repos/kubevirt/web-ui-components/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/web-ui-components/issues/10/comments","events_url":"https://api.github.com/repos/kubevirt/web-ui-components/issues/10/events","html_url":"https://github.com/kubevirt/web-ui-components/pull/10","id":355980714,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzgzNDU2","number":10,"title":"[WIP] Create vm wizard - Storage","user":{"login":"suomiy","id":3648838,"node_id":"MDQ6VXNlcjM2NDg4Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/3648838?v=4","gravatar_id":"","url":"https://api.github.com/users/suomiy","html_url":"https://github.com/suomiy","followers_url":"https://api.github.com/users/suomiy/followers","following_url":"https://api.github.com/users/suomiy/following{/other_user}","gists_url":"https://api.github.com/users/suomiy/gists{/gist_id}","starred_url":"https://api.github.com/users/suomiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suomiy/subscriptions","organizations_url":"https://api.github.com/users/suomiy/orgs","repos_url":"https://api.github.com/users/suomiy/repos","events_url":"https://api.github.com/users/suomiy/events{/privacy}","received_events_url":"https://api.github.com/users/suomiy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-08-31T13:28:22Z","updated_at":"2018-09-13T17:47:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubevirt/web-ui-components/pulls/10","html_url":"https://github.com/kubevirt/web-ui-components/pull/10","diff_url":"https://github.com/kubevirt/web-ui-components/pull/10.diff","patch_url":"https://github.com/kubevirt/web-ui-components/pull/10.patch"},"body":"This is build on top of #4 and there are currently two unfixable bugs for the table: #8 , #9\r\n- [published storybook](https://clever-allen-639701.netlify.com/?selectedKind=Wizards&selectedStory=New%20VM%20Wizard&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel)\r\n\r\n\r\nI created EditableDraggableTable component which can also be used for the Network; supports:\r\n- inline editing with custom inner components\r\n- drag and drop\r\n- renders custom definitions from `columns.renderConfigs`\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kubevirt/web-ui-components/issues/comments/421093555","html_url":"https://github.com/kubevirt/web-ui-components/pull/10#issuecomment-421093555","issue_url":"https://api.github.com/repos/kubevirt/web-ui-components/issues/10","id":421093555,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTA5MzU1NQ==","user":{"login":"lizsurette","id":208455,"node_id":"MDQ6VXNlcjIwODQ1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/208455?v=4","gravatar_id":"","url":"https://api.github.com/users/lizsurette","html_url":"https://github.com/lizsurette","followers_url":"https://api.github.com/users/lizsurette/followers","following_url":"https://api.github.com/users/lizsurette/following{/other_user}","gists_url":"https://api.github.com/users/lizsurette/gists{/gist_id}","starred_url":"https://api.github.com/users/lizsurette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizsurette/subscriptions","organizations_url":"https://api.github.com/users/lizsurette/orgs","repos_url":"https://api.github.com/users/lizsurette/repos","events_url":"https://api.github.com/users/lizsurette/events{/privacy}","received_events_url":"https://api.github.com/users/lizsurette/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T17:47:55Z","updated_at":"2018-09-13T17:47:55Z","author_association":"NONE","body":"> @lizsurette\r\n> I am not sure what is wrong, it is working here. Can you try to open it in incognito window?\r\n> \r\n> link: https://clever-allen-639701.netlify.com/\r\nAll is well now! Maybe a caching issue? Thanks for the help :)\r\n\r\nThis is looking great and I just wanted to add a few other comments/suggestions. Here is a screenshot of what I'm seeing at the moment:\r\n<img width=\"970\" alt=\"screen shot 2018-09-13 at 1 43 01 pm\" src=\"https://user-images.githubusercontent.com/208455/45505673-2ece9e80-b75b-11e8-843c-3e15cdecb6cf.png\">\r\n\r\n1) I'm noticing the same CSS issue that Ohad pointed out with the save/cancel buttons. Seems like depending on where you scroll it will display in a different spot each time.\r\n\r\n2) After choosing to Create a Disk, clicking the \"Cancel\" action should actually remove the line from the table rather than add a blank one.\r\n\r\n3) Instead of \"Select\" could we change the text to \"Select Storage\" when attaching storage?\r\n"}}
{"actor":{"display_login":"lizsurette"}}