{"action":"created","comment":{"url":"https://api.github.com/repos/influxdata/platform/pulls/comments/206276108","pull_request_review_id":141660494,"id":206276108,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjI3NjEwOA==","diff_hunk":"@@ -252,6 +248,8 @@ paths:\n           application/json:\n             schema:\n               $ref: \"#/components/schemas/InfluxqlQueryError\"\n+  # 2.x query endpoint\n+  /query:","path":"http/swagger.yml","position":25,"original_position":25,"commit_id":"2f242a03f84dc05d7c803251ab7aa9c062b8175e","original_commit_id":"2f242a03f84dc05d7c803251ab7aa9c062b8175e","user":{"login":"pauldix","id":4331,"node_id":"MDQ6VXNlcjQzMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/4331?v=4","gravatar_id":"","url":"https://api.github.com/users/pauldix","html_url":"https://github.com/pauldix","followers_url":"https://api.github.com/users/pauldix/followers","following_url":"https://api.github.com/users/pauldix/following{/other_user}","gists_url":"https://api.github.com/users/pauldix/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldix/subscriptions","organizations_url":"https://api.github.com/users/pauldix/orgs","repos_url":"https://api.github.com/users/pauldix/repos","events_url":"https://api.github.com/users/pauldix/events{/privacy}","received_events_url":"https://api.github.com/users/pauldix/received_events","type":"User","site_admin":false},"body":"err, put `/api/v1` before orgs..","created_at":"2018-07-30T18:30:23Z","updated_at":"2018-07-30T18:30:23Z","html_url":"https://github.com/influxdata/platform/pull/505#discussion_r206276108","pull_request_url":"https://api.github.com/repos/influxdata/platform/pulls/505","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/influxdata/platform/pulls/comments/206276108"},"html":{"href":"https://github.com/influxdata/platform/pull/505#discussion_r206276108"},"pull_request":{"href":"https://api.github.com/repos/influxdata/platform/pulls/505"}},"in_reply_to_id":206275815},"pull_request":{"url":"https://api.github.com/repos/influxdata/platform/pulls/505","id":204557618,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTU3NjE4","html_url":"https://github.com/influxdata/platform/pull/505","diff_url":"https://github.com/influxdata/platform/pull/505.diff","patch_url":"https://github.com/influxdata/platform/pull/505.patch","issue_url":"https://api.github.com/repos/influxdata/platform/issues/505","number":505,"state":"open","locked":false,"title":"[WIP] Update the vairous QueryService to be consistent","user":{"login":"nathanielc","id":3771906,"node_id":"MDQ6VXNlcjM3NzE5MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3771906?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanielc","html_url":"https://github.com/nathanielc","followers_url":"https://api.github.com/users/nathanielc/followers","following_url":"https://api.github.com/users/nathanielc/following{/other_user}","gists_url":"https://api.github.com/users/nathanielc/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielc/subscriptions","organizations_url":"https://api.github.com/users/nathanielc/orgs","repos_url":"https://api.github.com/users/nathanielc/repos","events_url":"https://api.github.com/users/nathanielc/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielc/received_events","type":"User","site_admin":false},"body":"_Briefly describe your proposed changes:_\r\n\r\nUpdate each of the QueryService to consume a query.Request.\r\n\r\n_What was the problem?_\r\n\r\nThere were three different query services. Each had a unique and different API that did not clearly communicate why you would use one over the other.\r\n\r\n\r\n_What was the solution?_\r\n\r\nThe solution was three fold:\r\n\r\n* Move all query services into platform\r\n* Update all service to use the query.Request and query.ProxyRequest types\r\n* Make use of the Compiler interface in the implementation of all services.\r\n\r\nAs a result of these changes the differences between queryd and transpilerd vanished. As such transpilerd has been removed from platform.\r\n\r\n  - [ ] Rebased/mergeable\r\n  - [ ] Tests pass\r\n  - [ ] swagger.json updated ","created_at":"2018-07-27T23:00:58Z","updated_at":"2018-07-30T18:30:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e24433711b63328c84d077864ffaad19a5a7eb9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jlapacik","id":22945345,"node_id":"MDQ6VXNlcjIyOTQ1MzQ1","avatar_url":"https://avatars3.githubusercontent.com/u/22945345?v=4","gravatar_id":"","url":"https://api.github.com/users/jlapacik","html_url":"https://github.com/jlapacik","followers_url":"https://api.github.com/users/jlapacik/followers","following_url":"https://api.github.com/users/jlapacik/following{/other_user}","gists_url":"https://api.github.com/users/jlapacik/gists{/gist_id}","starred_url":"https://api.github.com/users/jlapacik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlapacik/subscriptions","organizations_url":"https://api.github.com/users/jlapacik/orgs","repos_url":"https://api.github.com/users/jlapacik/repos","events_url":"https://api.github.com/users/jlapacik/events{/privacy}","received_events_url":"https://api.github.com/users/jlapacik/received_events","type":"User","site_admin":false},{"login":"aanthony1243","id":25036188,"node_id":"MDQ6VXNlcjI1MDM2MTg4","avatar_url":"https://avatars3.githubusercontent.com/u/25036188?v=4","gravatar_id":"","url":"https://api.github.com/users/aanthony1243","html_url":"https://github.com/aanthony1243","followers_url":"https://api.github.com/users/aanthony1243/followers","following_url":"https://api.github.com/users/aanthony1243/following{/other_user}","gists_url":"https://api.github.com/users/aanthony1243/gists{/gist_id}","starred_url":"https://api.github.com/users/aanthony1243/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanthony1243/subscriptions","organizations_url":"https://api.github.com/users/aanthony1243/orgs","repos_url":"https://api.github.com/users/aanthony1243/repos","events_url":"https://api.github.com/users/aanthony1243/events{/privacy}","received_events_url":"https://api.github.com/users/aanthony1243/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/influxdata/platform/pulls/505/commits","review_comments_url":"https://api.github.com/repos/influxdata/platform/pulls/505/comments","review_comment_url":"https://api.github.com/repos/influxdata/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/influxdata/platform/issues/505/comments","statuses_url":"https://api.github.com/repos/influxdata/platform/statuses/2f242a03f84dc05d7c803251ab7aa9c062b8175e","head":{"label":"influxdata:nc-query-service","ref":"nc-query-service","sha":"2f242a03f84dc05d7c803251ab7aa9c062b8175e","user":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":132783164,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3ODMxNjQ=","name":"platform","full_name":"influxdata/platform","owner":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/influxdata/platform","description":"InfluxDB 2.0: The community version of the InfluxData Platform for Time Series","fork":false,"url":"https://api.github.com/repos/influxdata/platform","forks_url":"https://api.github.com/repos/influxdata/platform/forks","keys_url":"https://api.github.com/repos/influxdata/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/platform/teams","hooks_url":"https://api.github.com/repos/influxdata/platform/hooks","issue_events_url":"https://api.github.com/repos/influxdata/platform/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/platform/events","assignees_url":"https://api.github.com/repos/influxdata/platform/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/platform/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/platform/tags","blobs_url":"https://api.github.com/repos/influxdata/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/platform/languages","stargazers_url":"https://api.github.com/repos/influxdata/platform/stargazers","contributors_url":"https://api.github.com/repos/influxdata/platform/contributors","subscribers_url":"https://api.github.com/repos/influxdata/platform/subscribers","subscription_url":"https://api.github.com/repos/influxdata/platform/subscription","commits_url":"https://api.github.com/repos/influxdata/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/platform/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/platform/merges","archive_url":"https://api.github.com/repos/influxdata/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/platform/downloads","issues_url":"https://api.github.com/repos/influxdata/platform/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/platform/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/platform/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/platform/deployments","created_at":"2018-05-09T16:17:29Z","updated_at":"2018-07-30T17:54:11Z","pushed_at":"2018-07-30T18:17:47Z","git_url":"git://github.com/influxdata/platform.git","ssh_url":"git@github.com:influxdata/platform.git","clone_url":"https://github.com/influxdata/platform.git","svn_url":"https://github.com/influxdata/platform","homepage":"","size":21584,"stargazers_count":133,"watchers_count":133,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":247,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":247,"watchers":133,"default_branch":"master"}},"base":{"label":"influxdata:master","ref":"master","sha":"31fb402c16669fd1847f7c28cb3981a0edff97e6","user":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":132783164,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3ODMxNjQ=","name":"platform","full_name":"influxdata/platform","owner":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/influxdata/platform","description":"InfluxDB 2.0: The community version of the InfluxData Platform for Time Series","fork":false,"url":"https://api.github.com/repos/influxdata/platform","forks_url":"https://api.github.com/repos/influxdata/platform/forks","keys_url":"https://api.github.com/repos/influxdata/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/platform/teams","hooks_url":"https://api.github.com/repos/influxdata/platform/hooks","issue_events_url":"https://api.github.com/repos/influxdata/platform/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/platform/events","assignees_url":"https://api.github.com/repos/influxdata/platform/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/platform/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/platform/tags","blobs_url":"https://api.github.com/repos/influxdata/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/platform/languages","stargazers_url":"https://api.github.com/repos/influxdata/platform/stargazers","contributors_url":"https://api.github.com/repos/influxdata/platform/contributors","subscribers_url":"https://api.github.com/repos/influxdata/platform/subscribers","subscription_url":"https://api.github.com/repos/influxdata/platform/subscription","commits_url":"https://api.github.com/repos/influxdata/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/platform/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/platform/merges","archive_url":"https://api.github.com/repos/influxdata/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/platform/downloads","issues_url":"https://api.github.com/repos/influxdata/platform/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/platform/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/platform/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/platform/deployments","created_at":"2018-05-09T16:17:29Z","updated_at":"2018-07-30T17:54:11Z","pushed_at":"2018-07-30T18:17:47Z","git_url":"git://github.com/influxdata/platform.git","ssh_url":"git@github.com:influxdata/platform.git","clone_url":"https://github.com/influxdata/platform.git","svn_url":"https://github.com/influxdata/platform","homepage":"","size":21584,"stargazers_count":133,"watchers_count":133,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":247,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":247,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/influxdata/platform/pulls/505"},"html":{"href":"https://github.com/influxdata/platform/pull/505"},"issue":{"href":"https://api.github.com/repos/influxdata/platform/issues/505"},"comments":{"href":"https://api.github.com/repos/influxdata/platform/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/influxdata/platform/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/influxdata/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/influxdata/platform/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/influxdata/platform/statuses/2f242a03f84dc05d7c803251ab7aa9c062b8175e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pauldix"}}