{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/parser/pulls/comments/240208945","pull_request_review_id":183184528,"id":240208945,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDIwODk0NQ==","diff_hunk":"@@ -131,6 +131,16 @@ func (tc *testExpressionsSuite) createTestCase4ColumnNameExpr() []exprTestCase {\n \t}\n }\n \n+func (tc *testExpressionsSuite) createTestCase4BetweenExpr() []exprTestCase {\n+\treturn []exprTestCase{\n+\t\t{\"select b between 1 and 2\", \"SELECT `b` BETWEEN 1 AND 2\"},\n+\t\t{\"select b not between 1 and 2\", \"SELECT `b` NOT BETWEEN 1 AND 2\"},\n+\t\t{\"select b between a and b\", \"SELECT `b` BETWEEN `a` AND `b`\"},\n+\t\t{\"select b between '' and 'b'\", \"SELECT `b` BETWEEN \\\"\\\" AND \\\"b\\\"\"},","path":"ast/expressions_test.go","position":9,"original_position":9,"commit_id":"ae9365da87756ef466879ec37fd3be334026cb61","original_commit_id":"ae9365da87756ef466879ec37fd3be334026cb61","user":{"login":"kennytm","id":103023,"node_id":"MDQ6VXNlcjEwMzAyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/103023?v=4","gravatar_id":"","url":"https://api.github.com/users/kennytm","html_url":"https://github.com/kennytm","followers_url":"https://api.github.com/users/kennytm/followers","following_url":"https://api.github.com/users/kennytm/following{/other_user}","gists_url":"https://api.github.com/users/kennytm/gists{/gist_id}","starred_url":"https://api.github.com/users/kennytm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennytm/subscriptions","organizations_url":"https://api.github.com/users/kennytm/orgs","repos_url":"https://api.github.com/users/kennytm/repos","events_url":"https://api.github.com/users/kennytm/events{/privacy}","received_events_url":"https://api.github.com/users/kennytm/received_events","type":"User","site_admin":false},"body":"I think `Restore()` and `Format()` should carry a `FormatContext` parameter to encapsulate the SQL mode, but this kind of refactoring is out-of-scope for *this* PR.","created_at":"2018-12-10T13:31:08Z","updated_at":"2018-12-10T13:31:09Z","html_url":"https://github.com/pingcap/parser/pull/71#discussion_r240208945","pull_request_url":"https://api.github.com/repos/pingcap/parser/pulls/71","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/parser/pulls/comments/240208945"},"html":{"href":"https://github.com/pingcap/parser/pull/71#discussion_r240208945"},"pull_request":{"href":"https://api.github.com/repos/pingcap/parser/pulls/71"}},"in_reply_to_id":240157680},"pull_request":{"url":"https://api.github.com/repos/pingcap/parser/pulls/71","id":236778368,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2Nzc4MzY4","html_url":"https://github.com/pingcap/parser/pull/71","diff_url":"https://github.com/pingcap/parser/pull/71.diff","patch_url":"https://github.com/pingcap/parser/pull/71.patch","issue_url":"https://api.github.com/repos/pingcap/parser/issues/71","number":71,"state":"open","locked":false,"title":"parser: implement Restore for BetweenExpr","user":{"login":"haplone","id":5062273,"node_id":"MDQ6VXNlcjUwNjIyNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5062273?v=4","gravatar_id":"","url":"https://api.github.com/users/haplone","html_url":"https://github.com/haplone","followers_url":"https://api.github.com/users/haplone/followers","following_url":"https://api.github.com/users/haplone/following{/other_user}","gists_url":"https://api.github.com/users/haplone/gists{/gist_id}","starred_url":"https://api.github.com/users/haplone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haplone/subscriptions","organizations_url":"https://api.github.com/users/haplone/orgs","repos_url":"https://api.github.com/users/haplone/repos","events_url":"https://api.github.com/users/haplone/events{/privacy}","received_events_url":"https://api.github.com/users/haplone/received_events","type":"User","site_admin":false},"body":"* implement BetweenExpr#Restore by call Format\r\n* add expressions_test.go#createTestCase4BetweenExpr \r\n\r\npingcap/tidb#8532","created_at":"2018-12-07T07:33:51Z","updated_at":"2018-12-10T13:31:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"327a5f6ac1ac691caf7fda46bf76b9cfe32e5522","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1114098590,"node_id":"MDU6TGFiZWwxMTE0MDk4NTkw","url":"https://api.github.com/repos/pingcap/parser/labels/LGTM1","name":"LGTM1","color":"c7cafc","default":false},{"id":1120357525,"node_id":"MDU6TGFiZWwxMTIwMzU3NTI1","url":"https://api.github.com/repos/pingcap/parser/labels/contribution","name":"contribution","color":"c5f780","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/parser/pulls/71/commits","review_comments_url":"https://api.github.com/repos/pingcap/parser/pulls/71/comments","review_comment_url":"https://api.github.com/repos/pingcap/parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/parser/issues/71/comments","statuses_url":"https://api.github.com/repos/pingcap/parser/statuses/ae9365da87756ef466879ec37fd3be334026cb61","head":{"label":"haplone:master_sql_restore","ref":"master_sql_restore","sha":"ae9365da87756ef466879ec37fd3be334026cb61","user":{"login":"haplone","id":5062273,"node_id":"MDQ6VXNlcjUwNjIyNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5062273?v=4","gravatar_id":"","url":"https://api.github.com/users/haplone","html_url":"https://github.com/haplone","followers_url":"https://api.github.com/users/haplone/followers","following_url":"https://api.github.com/users/haplone/following{/other_user}","gists_url":"https://api.github.com/users/haplone/gists{/gist_id}","starred_url":"https://api.github.com/users/haplone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haplone/subscriptions","organizations_url":"https://api.github.com/users/haplone/orgs","repos_url":"https://api.github.com/users/haplone/repos","events_url":"https://api.github.com/users/haplone/events{/privacy}","received_events_url":"https://api.github.com/users/haplone/received_events","type":"User","site_admin":false},"repo":{"id":160764103,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA3NjQxMDM=","name":"parser","full_name":"haplone/parser","private":false,"owner":{"login":"haplone","id":5062273,"node_id":"MDQ6VXNlcjUwNjIyNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5062273?v=4","gravatar_id":"","url":"https://api.github.com/users/haplone","html_url":"https://github.com/haplone","followers_url":"https://api.github.com/users/haplone/followers","following_url":"https://api.github.com/users/haplone/following{/other_user}","gists_url":"https://api.github.com/users/haplone/gists{/gist_id}","starred_url":"https://api.github.com/users/haplone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haplone/subscriptions","organizations_url":"https://api.github.com/users/haplone/orgs","repos_url":"https://api.github.com/users/haplone/repos","events_url":"https://api.github.com/users/haplone/events{/privacy}","received_events_url":"https://api.github.com/users/haplone/received_events","type":"User","site_admin":false},"html_url":"https://github.com/haplone/parser","description":"TiDB SQL Parser","fork":true,"url":"https://api.github.com/repos/haplone/parser","forks_url":"https://api.github.com/repos/haplone/parser/forks","keys_url":"https://api.github.com/repos/haplone/parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haplone/parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haplone/parser/teams","hooks_url":"https://api.github.com/repos/haplone/parser/hooks","issue_events_url":"https://api.github.com/repos/haplone/parser/issues/events{/number}","events_url":"https://api.github.com/repos/haplone/parser/events","assignees_url":"https://api.github.com/repos/haplone/parser/assignees{/user}","branches_url":"https://api.github.com/repos/haplone/parser/branches{/branch}","tags_url":"https://api.github.com/repos/haplone/parser/tags","blobs_url":"https://api.github.com/repos/haplone/parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haplone/parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haplone/parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/haplone/parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haplone/parser/statuses/{sha}","languages_url":"https://api.github.com/repos/haplone/parser/languages","stargazers_url":"https://api.github.com/repos/haplone/parser/stargazers","contributors_url":"https://api.github.com/repos/haplone/parser/contributors","subscribers_url":"https://api.github.com/repos/haplone/parser/subscribers","subscription_url":"https://api.github.com/repos/haplone/parser/subscription","commits_url":"https://api.github.com/repos/haplone/parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/haplone/parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/haplone/parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/haplone/parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/haplone/parser/contents/{+path}","compare_url":"https://api.github.com/repos/haplone/parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haplone/parser/merges","archive_url":"https://api.github.com/repos/haplone/parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haplone/parser/downloads","issues_url":"https://api.github.com/repos/haplone/parser/issues{/number}","pulls_url":"https://api.github.com/repos/haplone/parser/pulls{/number}","milestones_url":"https://api.github.com/repos/haplone/parser/milestones{/number}","notifications_url":"https://api.github.com/repos/haplone/parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haplone/parser/labels{/name}","releases_url":"https://api.github.com/repos/haplone/parser/releases{/id}","deployments_url":"https://api.github.com/repos/haplone/parser/deployments","created_at":"2018-12-07T03:11:01Z","updated_at":"2018-12-07T03:11:03Z","pushed_at":"2018-12-09T12:48:54Z","git_url":"git://github.com/haplone/parser.git","ssh_url":"git@github.com:haplone/parser.git","clone_url":"https://github.com/haplone/parser.git","svn_url":"https://github.com/haplone/parser","homepage":null,"size":1213,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"ce789e70c83b246eacb360efb4feca9184caf620","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":153882884,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM4ODI4ODQ=","name":"parser","full_name":"pingcap/parser","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/parser","description":"TiDB SQL Parser","fork":false,"url":"https://api.github.com/repos/pingcap/parser","forks_url":"https://api.github.com/repos/pingcap/parser/forks","keys_url":"https://api.github.com/repos/pingcap/parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/parser/teams","hooks_url":"https://api.github.com/repos/pingcap/parser/hooks","issue_events_url":"https://api.github.com/repos/pingcap/parser/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/parser/events","assignees_url":"https://api.github.com/repos/pingcap/parser/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/parser/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/parser/tags","blobs_url":"https://api.github.com/repos/pingcap/parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/parser/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/parser/languages","stargazers_url":"https://api.github.com/repos/pingcap/parser/stargazers","contributors_url":"https://api.github.com/repos/pingcap/parser/contributors","subscribers_url":"https://api.github.com/repos/pingcap/parser/subscribers","subscription_url":"https://api.github.com/repos/pingcap/parser/subscription","commits_url":"https://api.github.com/repos/pingcap/parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/parser/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/parser/merges","archive_url":"https://api.github.com/repos/pingcap/parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/parser/downloads","issues_url":"https://api.github.com/repos/pingcap/parser/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/parser/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/parser/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/parser/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/parser/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/parser/deployments","created_at":"2018-10-20T07:55:25Z","updated_at":"2018-12-10T08:03:29Z","pushed_at":"2018-12-10T10:17:55Z","git_url":"git://github.com/pingcap/parser.git","ssh_url":"git@github.com:pingcap/parser.git","clone_url":"https://github.com/pingcap/parser.git","svn_url":"https://github.com/pingcap/parser","homepage":null,"size":1222,"stargazers_count":104,"watchers_count":104,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":43,"open_issues":14,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/parser/pulls/71"},"html":{"href":"https://github.com/pingcap/parser/pull/71"},"issue":{"href":"https://api.github.com/repos/pingcap/parser/issues/71"},"comments":{"href":"https://api.github.com/repos/pingcap/parser/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/parser/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/parser/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/parser/statuses/ae9365da87756ef466879ec37fd3be334026cb61"}},"author_association":"NONE"}}
{"actor":{"display_login":"kennytm"}}