{"action":"created","comment":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/comments/166075917","pull_request_review_id":94102771,"id":166075917,"diff_hunk":"@@ -631,6 +631,9 @@ def train(self) -> None:\n \n         logger.info(\"Beginning training.\")\n \n+        train_metrics = None\n+        val_metrics = None","path":"allennlp/training/trainer.py","position":14,"original_position":14,"commit_id":"ce154e82c4ed3c2adf07a70fdb386f4f131b6837","original_commit_id":"ce154e82c4ed3c2adf07a70fdb386f4f131b6837","user":{"login":"schmmd","id":954798,"avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"body":"https://github.com/schmmd/allennlp/blob/ce154e82c4ed3c2adf07a70fdb386f4f131b6837/allennlp/training/trainer.py#L662\r\n\r\nI'll change it to empty dict.","created_at":"2018-02-05T18:58:14Z","updated_at":"2018-02-05T18:58:14Z","html_url":"https://github.com/allenai/allennlp/pull/757#discussion_r166075917","pull_request_url":"https://api.github.com/repos/allenai/allennlp/pulls/757","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments/166075917"},"html":{"href":"https://github.com/allenai/allennlp/pull/757#discussion_r166075917"},"pull_request":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/757"}},"in_reply_to_id":166055254},"pull_request":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/757","id":166858157,"html_url":"https://github.com/allenai/allennlp/pull/757","diff_url":"https://github.com/allenai/allennlp/pull/757.diff","patch_url":"https://github.com/allenai/allennlp/pull/757.patch","issue_url":"https://api.github.com/repos/allenai/allennlp/issues/757","number":757,"state":"open","locked":false,"title":"WIP: Add metrics.json output and migrate to run_with_beaker.py","user":{"login":"schmmd","id":954798,"avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"body":"This PR makes three primary changes:\r\n\r\n* Adds a `metrics.json` output to AllenNLP.  This output is created whether using Beaker or not, as it's easier to generate as part of AllenNLP rather than post-processing logs and the output is useful whether running in Beaker or as a standalone.\r\n\r\n* Nearly outputs the settings in `config.json` as environment variables so they show up in Beaker as parameters.  This gives users the ability to select these parameters when using Beaker's group view.  However, [Beaker's UI looks terrible](http://beaker.allenai.org/ex/ex_n46sgjsv9u26) when several environment variables are output (see [the bug report](https://app.asana.com/0/546081553220630/546132563400408)) so this is disabled presently.\r\n\r\n* Migrates `run_with_beaker` from Bash to Python, which was a pre-requisite for the first two changes.","created_at":"2018-02-02T17:21:34Z","updated_at":"2018-02-05T18:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3da2ac3b13ed12e94101b33f51a7c851b2d45b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/allenai/allennlp/pulls/757/commits","review_comments_url":"https://api.github.com/repos/allenai/allennlp/pulls/757/comments","review_comment_url":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allenai/allennlp/issues/757/comments","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/ce154e82c4ed3c2adf07a70fdb386f4f131b6837","head":{"label":"schmmd:beaker-python","ref":"beaker-python","sha":"ce154e82c4ed3c2adf07a70fdb386f4f131b6837","user":{"login":"schmmd","id":954798,"avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"repo":{"id":95493347,"name":"allennlp","full_name":"schmmd/allennlp","owner":{"login":"schmmd","id":954798,"avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schmmd/allennlp","description":"A natural language processing toolkit using state-of-the-art deep learning models.","fork":true,"url":"https://api.github.com/repos/schmmd/allennlp","forks_url":"https://api.github.com/repos/schmmd/allennlp/forks","keys_url":"https://api.github.com/repos/schmmd/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schmmd/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schmmd/allennlp/teams","hooks_url":"https://api.github.com/repos/schmmd/allennlp/hooks","issue_events_url":"https://api.github.com/repos/schmmd/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/schmmd/allennlp/events","assignees_url":"https://api.github.com/repos/schmmd/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/schmmd/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/schmmd/allennlp/tags","blobs_url":"https://api.github.com/repos/schmmd/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schmmd/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schmmd/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/schmmd/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schmmd/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/schmmd/allennlp/languages","stargazers_url":"https://api.github.com/repos/schmmd/allennlp/stargazers","contributors_url":"https://api.github.com/repos/schmmd/allennlp/contributors","subscribers_url":"https://api.github.com/repos/schmmd/allennlp/subscribers","subscription_url":"https://api.github.com/repos/schmmd/allennlp/subscription","commits_url":"https://api.github.com/repos/schmmd/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/schmmd/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/schmmd/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/schmmd/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/schmmd/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/schmmd/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schmmd/allennlp/merges","archive_url":"https://api.github.com/repos/schmmd/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schmmd/allennlp/downloads","issues_url":"https://api.github.com/repos/schmmd/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/schmmd/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/schmmd/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/schmmd/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schmmd/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/schmmd/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/schmmd/allennlp/deployments","created_at":"2017-06-26T22:04:12Z","updated_at":"2017-06-26T22:04:13Z","pushed_at":"2018-02-05T18:19:36Z","git_url":"git://github.com/schmmd/allennlp.git","ssh_url":"git@github.com:schmmd/allennlp.git","clone_url":"https://github.com/schmmd/allennlp.git","svn_url":"https://github.com/schmmd/allennlp","homepage":null,"size":6930,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"allenai:master","ref":"master","sha":"ab4aeb28f1b81747c985a188b6c4c569c02aaa75","user":{"login":"allenai","id":5667695,"avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"repo":{"id":91356408,"name":"allennlp","full_name":"allenai/allennlp","owner":{"login":"allenai","id":5667695,"avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allenai/allennlp","description":"An open-source NLP research library, built on PyTorch.","fork":false,"url":"https://api.github.com/repos/allenai/allennlp","forks_url":"https://api.github.com/repos/allenai/allennlp/forks","keys_url":"https://api.github.com/repos/allenai/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allenai/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allenai/allennlp/teams","hooks_url":"https://api.github.com/repos/allenai/allennlp/hooks","issue_events_url":"https://api.github.com/repos/allenai/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/allenai/allennlp/events","assignees_url":"https://api.github.com/repos/allenai/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/allenai/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/allenai/allennlp/tags","blobs_url":"https://api.github.com/repos/allenai/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allenai/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allenai/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/allenai/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/allenai/allennlp/languages","stargazers_url":"https://api.github.com/repos/allenai/allennlp/stargazers","contributors_url":"https://api.github.com/repos/allenai/allennlp/contributors","subscribers_url":"https://api.github.com/repos/allenai/allennlp/subscribers","subscription_url":"https://api.github.com/repos/allenai/allennlp/subscription","commits_url":"https://api.github.com/repos/allenai/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/allenai/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/allenai/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/allenai/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/allenai/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/allenai/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allenai/allennlp/merges","archive_url":"https://api.github.com/repos/allenai/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allenai/allennlp/downloads","issues_url":"https://api.github.com/repos/allenai/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/allenai/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/allenai/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/allenai/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allenai/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/allenai/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/allenai/allennlp/deployments","created_at":"2017-05-15T15:52:41Z","updated_at":"2018-02-05T13:18:14Z","pushed_at":"2018-02-05T18:49:56Z","git_url":"git://github.com/allenai/allennlp.git","ssh_url":"git@github.com:allenai/allennlp.git","clone_url":"https://github.com/allenai/allennlp.git","svn_url":"https://github.com/allenai/allennlp","homepage":"http://www.allennlp.org/","size":7120,"stargazers_count":1432,"watchers_count":1432,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":169,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":169,"open_issues":61,"watchers":1432,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/757"},"html":{"href":"https://github.com/allenai/allennlp/pull/757"},"issue":{"href":"https://api.github.com/repos/allenai/allennlp/issues/757"},"comments":{"href":"https://api.github.com/repos/allenai/allennlp/issues/757/comments"},"review_comments":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/757/comments"},"review_comment":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/757/commits"},"statuses":{"href":"https://api.github.com/repos/allenai/allennlp/statuses/ce154e82c4ed3c2adf07a70fdb386f4f131b6837"}},"author_association":"OWNER"}}
{"actor":{"display_login":"schmmd"}}