{"action":"created","comment":{"url":"https://api.github.com/repos/apache/predictionio/pulls/comments/234818468","pull_request_review_id":176542514,"id":234818468,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDgxODQ2OA==","diff_hunk":"@@ -0,0 +1,57 @@\n+#!/bin/bash\n+#\n+# Licensed to the Apache Software Foundation (ASF) under one or more\n+# contributor license agreements.  See the NOTICE file distributed with\n+# this work for additional information regarding copyright ownership.\n+# The ASF licenses this file to You under the Apache License, Version 2.0\n+# (the \"License\"); you may not use this file except in compliance with\n+# the License.  You may obtain a copy of the License at\n+#\n+#    http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+#\n+\n+# Go to PredictionIO directory\n+FWDIR=\"$(cd \"`dirname \"$0\"`\"/..; pwd)\"\n+cd ${FWDIR}\n+\n+# Extract information from PIO's build configuration\n+PIO_VERSION=$(grep ^version ${FWDIR}/build.sbt | grep ThisBuild | grep -o '\".*\"' | sed 's/\"//g')\n+SCALA_VERSION=$(grep ^scalaVersion ${FWDIR}/build.sbt | grep ThisBuild | grep -o ', \".*\"' | sed 's/[, \"]//g')\n+\n+echo \"=======================================================================\"\n+echo \"PIO_VERSION: $PIO_VERSION\"\n+echo \"SCALA_VERSION: $SCALA_VERSION\"\n+echo \"=======================================================================\"","path":"tests/check_templates.sh","position":30,"original_position":30,"commit_id":"fa9f40ca3814c1eb26a506c93ef3220f898d2817","original_commit_id":"fa9f40ca3814c1eb26a506c93ef3220f898d2817","user":{"login":"takezoe","id":1094760,"node_id":"MDQ6VXNlcjEwOTQ3NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1094760?v=4","gravatar_id":"","url":"https://api.github.com/users/takezoe","html_url":"https://github.com/takezoe","followers_url":"https://api.github.com/users/takezoe/followers","following_url":"https://api.github.com/users/takezoe/following{/other_user}","gists_url":"https://api.github.com/users/takezoe/gists{/gist_id}","starred_url":"https://api.github.com/users/takezoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takezoe/subscriptions","organizations_url":"https://api.github.com/users/takezoe/orgs","repos_url":"https://api.github.com/users/takezoe/repos","events_url":"https://api.github.com/users/takezoe/events{/privacy}","received_events_url":"https://api.github.com/users/takezoe/received_events","type":"User","site_admin":false},"body":"TODO: Check Spark version","created_at":"2018-11-19T23:17:21Z","updated_at":"2018-11-19T23:17:22Z","html_url":"https://github.com/apache/predictionio/pull/500#discussion_r234818468","pull_request_url":"https://api.github.com/repos/apache/predictionio/pulls/500","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/predictionio/pulls/comments/234818468"},"html":{"href":"https://github.com/apache/predictionio/pull/500#discussion_r234818468"},"pull_request":{"href":"https://api.github.com/repos/apache/predictionio/pulls/500"}}},"pull_request":{"url":"https://api.github.com/repos/apache/predictionio/pulls/500","id":231941177,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTQxMTc3","html_url":"https://github.com/apache/predictionio/pull/500","diff_url":"https://github.com/apache/predictionio/pull/500.diff","patch_url":"https://github.com/apache/predictionio/pull/500.patch","issue_url":"https://api.github.com/repos/apache/predictionio/issues/500","number":500,"state":"open","locked":false,"title":"[WIP] Incorporate the official templates in core repository","user":{"login":"takezoe","id":1094760,"node_id":"MDQ6VXNlcjEwOTQ3NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1094760?v=4","gravatar_id":"","url":"https://api.github.com/users/takezoe","html_url":"https://github.com/takezoe","followers_url":"https://api.github.com/users/takezoe/followers","following_url":"https://api.github.com/users/takezoe/following{/other_user}","gists_url":"https://api.github.com/users/takezoe/gists{/gist_id}","starred_url":"https://api.github.com/users/takezoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takezoe/subscriptions","organizations_url":"https://api.github.com/users/takezoe/orgs","repos_url":"https://api.github.com/users/takezoe/repos","events_url":"https://api.github.com/users/takezoe/events{/privacy}","received_events_url":"https://api.github.com/users/takezoe/received_events","type":"User","site_admin":false},"body":"I'm considering about incorporate the official templates with main repository to reduce maintenance costs of them. My idea is:\r\n\r\n- Check versions of PredictionIO/Scala/Spark/etc by TravisCI using a shell script and if these versions are not same among PredictionIO and templates, test will fail.\r\n- Include the official templates and examples in the distribution which is made by `make-distribution.sh`.\r\n- Documentations which refer these templates or examples will be fixed to be started from:\r\n   ```\r\n   $ cd $PIO_HOME/templates/template-scala-parallel-recommendation\r\n   $ pio build\r\n   ...\r\n   ```\r\n   instead of:\r\n   ```\r\n   $ git clone https://github.com/apache/predictionio-template-recommender.git\r\n   $ cd predictionio-template-recommender\r\n   $ pio build\r\n   ...\r\n   ```\r\nCurrently, for every release, we have to update versions of PredictionIO/Scala/Spark/etc, then create tag for each template repository by hand. If the official templates are in the same repository with PredictionIO itself, we will be able to finish this boring operation at once. Also, it will ensure that all official templates is synchronized with the latest PredictionIO version.\r\n","created_at":"2018-11-19T11:34:20Z","updated_at":"2018-11-19T23:17:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"322d822caa231c178f88d33c9fa6668ccb9348ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/predictionio/pulls/500/commits","review_comments_url":"https://api.github.com/repos/apache/predictionio/pulls/500/comments","review_comment_url":"https://api.github.com/repos/apache/predictionio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/predictionio/issues/500/comments","statuses_url":"https://api.github.com/repos/apache/predictionio/statuses/fa9f40ca3814c1eb26a506c93ef3220f898d2817","head":{"label":"takezoe:include-templates","ref":"include-templates","sha":"fa9f40ca3814c1eb26a506c93ef3220f898d2817","user":{"login":"takezoe","id":1094760,"node_id":"MDQ6VXNlcjEwOTQ3NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1094760?v=4","gravatar_id":"","url":"https://api.github.com/users/takezoe","html_url":"https://github.com/takezoe","followers_url":"https://api.github.com/users/takezoe/followers","following_url":"https://api.github.com/users/takezoe/following{/other_user}","gists_url":"https://api.github.com/users/takezoe/gists{/gist_id}","starred_url":"https://api.github.com/users/takezoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takezoe/subscriptions","organizations_url":"https://api.github.com/users/takezoe/orgs","repos_url":"https://api.github.com/users/takezoe/repos","events_url":"https://api.github.com/users/takezoe/events{/privacy}","received_events_url":"https://api.github.com/users/takezoe/received_events","type":"User","site_admin":false},"repo":{"id":81959620,"node_id":"MDEwOlJlcG9zaXRvcnk4MTk1OTYyMA==","name":"predictionio","full_name":"takezoe/predictionio","private":false,"owner":{"login":"takezoe","id":1094760,"node_id":"MDQ6VXNlcjEwOTQ3NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1094760?v=4","gravatar_id":"","url":"https://api.github.com/users/takezoe","html_url":"https://github.com/takezoe","followers_url":"https://api.github.com/users/takezoe/followers","following_url":"https://api.github.com/users/takezoe/following{/other_user}","gists_url":"https://api.github.com/users/takezoe/gists{/gist_id}","starred_url":"https://api.github.com/users/takezoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takezoe/subscriptions","organizations_url":"https://api.github.com/users/takezoe/orgs","repos_url":"https://api.github.com/users/takezoe/repos","events_url":"https://api.github.com/users/takezoe/events{/privacy}","received_events_url":"https://api.github.com/users/takezoe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/takezoe/predictionio","description":"PredictionIO, a machine learning server for developers and ML engineers. Built on Apache Spark, HBase and Spray.","fork":true,"url":"https://api.github.com/repos/takezoe/predictionio","forks_url":"https://api.github.com/repos/takezoe/predictionio/forks","keys_url":"https://api.github.com/repos/takezoe/predictionio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takezoe/predictionio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takezoe/predictionio/teams","hooks_url":"https://api.github.com/repos/takezoe/predictionio/hooks","issue_events_url":"https://api.github.com/repos/takezoe/predictionio/issues/events{/number}","events_url":"https://api.github.com/repos/takezoe/predictionio/events","assignees_url":"https://api.github.com/repos/takezoe/predictionio/assignees{/user}","branches_url":"https://api.github.com/repos/takezoe/predictionio/branches{/branch}","tags_url":"https://api.github.com/repos/takezoe/predictionio/tags","blobs_url":"https://api.github.com/repos/takezoe/predictionio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takezoe/predictionio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takezoe/predictionio/git/refs{/sha}","trees_url":"https://api.github.com/repos/takezoe/predictionio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takezoe/predictionio/statuses/{sha}","languages_url":"https://api.github.com/repos/takezoe/predictionio/languages","stargazers_url":"https://api.github.com/repos/takezoe/predictionio/stargazers","contributors_url":"https://api.github.com/repos/takezoe/predictionio/contributors","subscribers_url":"https://api.github.com/repos/takezoe/predictionio/subscribers","subscription_url":"https://api.github.com/repos/takezoe/predictionio/subscription","commits_url":"https://api.github.com/repos/takezoe/predictionio/commits{/sha}","git_commits_url":"https://api.github.com/repos/takezoe/predictionio/git/commits{/sha}","comments_url":"https://api.github.com/repos/takezoe/predictionio/comments{/number}","issue_comment_url":"https://api.github.com/repos/takezoe/predictionio/issues/comments{/number}","contents_url":"https://api.github.com/repos/takezoe/predictionio/contents/{+path}","compare_url":"https://api.github.com/repos/takezoe/predictionio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takezoe/predictionio/merges","archive_url":"https://api.github.com/repos/takezoe/predictionio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takezoe/predictionio/downloads","issues_url":"https://api.github.com/repos/takezoe/predictionio/issues{/number}","pulls_url":"https://api.github.com/repos/takezoe/predictionio/pulls{/number}","milestones_url":"https://api.github.com/repos/takezoe/predictionio/milestones{/number}","notifications_url":"https://api.github.com/repos/takezoe/predictionio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takezoe/predictionio/labels{/name}","releases_url":"https://api.github.com/repos/takezoe/predictionio/releases{/id}","deployments_url":"https://api.github.com/repos/takezoe/predictionio/deployments","created_at":"2017-02-14T15:30:37Z","updated_at":"2018-11-03T10:25:42Z","pushed_at":"2018-11-19T22:53:40Z","git_url":"git://github.com/takezoe/predictionio.git","ssh_url":"git@github.com:takezoe/predictionio.git","clone_url":"https://github.com/takezoe/predictionio.git","svn_url":"https://github.com/takezoe/predictionio","homepage":"http://prediction.io/","size":36248,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"4342fcd9d0a7b549543b59467f5e1b008523fe4f","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":7827081,"node_id":"MDEwOlJlcG9zaXRvcnk3ODI3MDgx","name":"predictionio","full_name":"apache/predictionio","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/predictionio","description":"PredictionIO, a machine learning server for developers and ML engineers. Built on Apache Spark, HBase and Spray.","fork":false,"url":"https://api.github.com/repos/apache/predictionio","forks_url":"https://api.github.com/repos/apache/predictionio/forks","keys_url":"https://api.github.com/repos/apache/predictionio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/predictionio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/predictionio/teams","hooks_url":"https://api.github.com/repos/apache/predictionio/hooks","issue_events_url":"https://api.github.com/repos/apache/predictionio/issues/events{/number}","events_url":"https://api.github.com/repos/apache/predictionio/events","assignees_url":"https://api.github.com/repos/apache/predictionio/assignees{/user}","branches_url":"https://api.github.com/repos/apache/predictionio/branches{/branch}","tags_url":"https://api.github.com/repos/apache/predictionio/tags","blobs_url":"https://api.github.com/repos/apache/predictionio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/predictionio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/predictionio/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/predictionio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/predictionio/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/predictionio/languages","stargazers_url":"https://api.github.com/repos/apache/predictionio/stargazers","contributors_url":"https://api.github.com/repos/apache/predictionio/contributors","subscribers_url":"https://api.github.com/repos/apache/predictionio/subscribers","subscription_url":"https://api.github.com/repos/apache/predictionio/subscription","commits_url":"https://api.github.com/repos/apache/predictionio/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/predictionio/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/predictionio/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/predictionio/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/predictionio/contents/{+path}","compare_url":"https://api.github.com/repos/apache/predictionio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/predictionio/merges","archive_url":"https://api.github.com/repos/apache/predictionio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/predictionio/downloads","issues_url":"https://api.github.com/repos/apache/predictionio/issues{/number}","pulls_url":"https://api.github.com/repos/apache/predictionio/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/predictionio/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/predictionio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/predictionio/labels{/name}","releases_url":"https://api.github.com/repos/apache/predictionio/releases{/id}","deployments_url":"https://api.github.com/repos/apache/predictionio/deployments","created_at":"2013-01-25T19:42:32Z","updated_at":"2018-11-19T15:40:40Z","pushed_at":"2018-11-19T22:53:45Z","git_url":"git://github.com/apache/predictionio.git","ssh_url":"git@github.com:apache/predictionio.git","clone_url":"https://github.com/apache/predictionio.git","svn_url":"https://github.com/apache/predictionio","homepage":"https://predictionio.apache.org","size":36262,"stargazers_count":11529,"watchers_count":11529,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1898,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1898,"open_issues":76,"watchers":11529,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/predictionio/pulls/500"},"html":{"href":"https://github.com/apache/predictionio/pull/500"},"issue":{"href":"https://api.github.com/repos/apache/predictionio/issues/500"},"comments":{"href":"https://api.github.com/repos/apache/predictionio/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/predictionio/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/predictionio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/predictionio/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/apache/predictionio/statuses/fa9f40ca3814c1eb26a506c93ef3220f898d2817"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"takezoe"}}