{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/230518851","pull_request_review_id":171284738,"id":230518851,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDUxODg1MQ==","diff_hunk":"@@ -140,7 +137,7 @@ describe('ProfilerDOM', () => {\n \n               // Evaluate in an unwrapped callback,\n               // Because trace/wrap won't decrement the count within the wrapped callback.\n-              setImmediate(() => {\n+              Promise.resolve().then(() => {","path":"packages/react/src/__tests__/ReactProfilerDOM-test.internal.js","position":17,"original_position":17,"commit_id":"5029cba182ad4663bce61e0e7a8a8920dd7b4dcc","original_commit_id":"5029cba182ad4663bce61e0e7a8a8920dd7b4dcc","user":{"login":"nhunzaker","id":590904,"node_id":"MDQ6VXNlcjU5MDkwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/590904?v=4","gravatar_id":"","url":"https://api.github.com/users/nhunzaker","html_url":"https://github.com/nhunzaker","followers_url":"https://api.github.com/users/nhunzaker/followers","following_url":"https://api.github.com/users/nhunzaker/following{/other_user}","gists_url":"https://api.github.com/users/nhunzaker/gists{/gist_id}","starred_url":"https://api.github.com/users/nhunzaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhunzaker/subscriptions","organizations_url":"https://api.github.com/users/nhunzaker/orgs","repos_url":"https://api.github.com/users/nhunzaker/repos","events_url":"https://api.github.com/users/nhunzaker/events{/privacy}","received_events_url":"https://api.github.com/users/nhunzaker/received_events","type":"User","site_admin":false},"body":"Naw, I think this is fine.","created_at":"2018-11-02T21:53:45Z","updated_at":"2018-11-02T21:53:45Z","html_url":"https://github.com/facebook/react/pull/14003#discussion_r230518851","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/14003","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/230518851"},"html":{"href":"https://github.com/facebook/react/pull/14003#discussion_r230518851"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/14003"}},"in_reply_to_id":230484386},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/14003","id":226316775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzE2Nzc1","html_url":"https://github.com/facebook/react/pull/14003","diff_url":"https://github.com/facebook/react/pull/14003.diff","patch_url":"https://github.com/facebook/react/pull/14003.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/14003","number":14003,"state":"open","locked":false,"title":"chore(tests): don't rely on jest fake timers scheduling real timers","user":{"login":"SimenB","id":1404810,"node_id":"MDQ6VXNlcjE0MDQ4MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"body":"I'm currently working on replacing Jest's custom fake timers implementation with Lolex (https://github.com/facebook/jest/pull/5171). As part of that, I wanted to test that React's tests still work. They didn't...\r\n\r\nA quirk of Jest's current implementation is that we schedule `process.nextTick` and `setImmediate` on the real timers, even though they're faked. Then we just make sure to do nothing if Jest invoked the function when advancing time, or vice versa if Node triggered it before us. That behavior is intentionally _not_ re-implemented in the new version.\r\n\r\nThis PR changes from using `setImmediate` to `Promise.resolve().then()` to \"wait 1 tick\" which behaves the same.","created_at":"2018-10-27T19:12:39Z","updated_at":"2018-11-02T21:53:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5c51208fcec3572446cdf66ab578354a5855b55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196858374,"node_id":"MDU6TGFiZWwxOTY4NTgzNzQ=","url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/14003/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/14003/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/14003/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/5029cba182ad4663bce61e0e7a8a8920dd7b4dcc","head":{"label":"SimenB:lolex-compliance","ref":"lolex-compliance","sha":"5029cba182ad4663bce61e0e7a8a8920dd7b4dcc","user":{"login":"SimenB","id":1404810,"node_id":"MDQ6VXNlcjE0MDQ4MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"repo":{"id":49518776,"node_id":"MDEwOlJlcG9zaXRvcnk0OTUxODc3Ng==","name":"react","full_name":"SimenB/react","private":false,"owner":{"login":"SimenB","id":1404810,"node_id":"MDQ6VXNlcjE0MDQ4MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SimenB/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/SimenB/react","forks_url":"https://api.github.com/repos/SimenB/react/forks","keys_url":"https://api.github.com/repos/SimenB/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimenB/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimenB/react/teams","hooks_url":"https://api.github.com/repos/SimenB/react/hooks","issue_events_url":"https://api.github.com/repos/SimenB/react/issues/events{/number}","events_url":"https://api.github.com/repos/SimenB/react/events","assignees_url":"https://api.github.com/repos/SimenB/react/assignees{/user}","branches_url":"https://api.github.com/repos/SimenB/react/branches{/branch}","tags_url":"https://api.github.com/repos/SimenB/react/tags","blobs_url":"https://api.github.com/repos/SimenB/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimenB/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimenB/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimenB/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimenB/react/statuses/{sha}","languages_url":"https://api.github.com/repos/SimenB/react/languages","stargazers_url":"https://api.github.com/repos/SimenB/react/stargazers","contributors_url":"https://api.github.com/repos/SimenB/react/contributors","subscribers_url":"https://api.github.com/repos/SimenB/react/subscribers","subscription_url":"https://api.github.com/repos/SimenB/react/subscription","commits_url":"https://api.github.com/repos/SimenB/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimenB/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimenB/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimenB/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimenB/react/contents/{+path}","compare_url":"https://api.github.com/repos/SimenB/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimenB/react/merges","archive_url":"https://api.github.com/repos/SimenB/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimenB/react/downloads","issues_url":"https://api.github.com/repos/SimenB/react/issues{/number}","pulls_url":"https://api.github.com/repos/SimenB/react/pulls{/number}","milestones_url":"https://api.github.com/repos/SimenB/react/milestones{/number}","notifications_url":"https://api.github.com/repos/SimenB/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimenB/react/labels{/name}","releases_url":"https://api.github.com/repos/SimenB/react/releases{/id}","deployments_url":"https://api.github.com/repos/SimenB/react/deployments","created_at":"2016-01-12T18:01:33Z","updated_at":"2018-11-02T21:50:15Z","pushed_at":"2018-11-02T21:50:08Z","git_url":"git://github.com/SimenB/react.git","ssh_url":"git@github.com:SimenB/react.git","clone_url":"https://github.com/SimenB/react.git","svn_url":"https://github.com/SimenB/react","homepage":"https://facebook.github.io/react/","size":118358,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"ae4f3f07e583e33c8a21e146d6682d5a08c174b4","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MDI1MA==","name":"react","full_name":"facebook/react","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2018-11-02T21:44:26Z","pushed_at":"2018-11-02T21:43:46Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://reactjs.org","size":139334,"stargazers_count":114604,"watchers_count":114604,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20670,"mirror_url":null,"archived":false,"open_issues_count":433,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20670,"open_issues":433,"watchers":114604,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/14003"},"html":{"href":"https://github.com/facebook/react/pull/14003"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/14003"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/14003/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/14003/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/14003/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/5029cba182ad4663bce61e0e7a8a8920dd7b4dcc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nhunzaker"}}