{"action":"created","comment":{"url":"https://api.github.com/repos/singularityware/singularity/pulls/comments/182503854","pull_request_review_id":113312468,"id":182503854,"diff_hunk":"@@ -76,8 +93,41 @@ int _singularity_image_squashfs_init(struct image_object *image, int open_flags)\n     /* if LAUNCH_STRING is present, figure out squashfs magic offset */\n     p = strstr(buf, \"hsqs\");\n     if ( p != NULL ) {\n-        singularity_message(VERBOSE2, \"File is a valid SquashFS image\\n\");\n+        char *compression_type = NULL;\n+\n         image->offset = p - buf;\n+\n+        if ( ( image->offset + sizeof(struct squashfs_header) ) > sizeof(buf) ) {\n+            singularity_message(VERBOSE, \"File is not a valid SquashFS image\\n\");\n+            return(-1);\n+        }\n+\n+        singularity_message(VERBOSE2, \"File is a valid SquashFS image\\n\");\n+\n+        s_header = (struct squashfs_header *)p;\n+\n+        switch( s_header->compression ) {\n+        case SQUASHFS_LZMA:\n+            compression_type = strdup(\"lzma\");\n+            break;\n+        case SQUASHFS_LZO:\n+            compression_type = strdup(\"lzo\");\n+            break;\n+        case SQUASHFS_XZ:\n+            compression_type = strdup(\"xz\");\n+            break;\n+        case SQUASHFS_LZ4:\n+            compression_type = strdup(\"lz4\");\n+            break;\n+        default:\n+            break;\n+        }\n+\n+        if ( compression_type ) {","path":"src/lib/image/squashfs/init.c","position":70,"original_position":70,"commit_id":"7f0a29972c610e4ac5d748b36b8a34d884a08795","original_commit_id":"7f0a29972c610e4ac5d748b36b8a34d884a08795","user":{"login":"bauerm97","id":14863407,"avatar_url":"https://avatars3.githubusercontent.com/u/14863407?v=4","gravatar_id":"","url":"https://api.github.com/users/bauerm97","html_url":"https://github.com/bauerm97","followers_url":"https://api.github.com/users/bauerm97/followers","following_url":"https://api.github.com/users/bauerm97/following{/other_user}","gists_url":"https://api.github.com/users/bauerm97/gists{/gist_id}","starred_url":"https://api.github.com/users/bauerm97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bauerm97/subscriptions","organizations_url":"https://api.github.com/users/bauerm97/orgs","repos_url":"https://api.github.com/users/bauerm97/repos","events_url":"https://api.github.com/users/bauerm97/events{/privacy}","received_events_url":"https://api.github.com/users/bauerm97/received_events","type":"User","site_admin":false},"body":"I'm not sure it's necessary to spit out a warning every time an image is run that was compressed. I think it makes more sense to output this to DEBUG.","created_at":"2018-04-18T17:15:40Z","updated_at":"2018-04-18T17:16:19Z","html_url":"https://github.com/singularityware/singularity/pull/1456#discussion_r182503854","pull_request_url":"https://api.github.com/repos/singularityware/singularity/pulls/1456","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/comments/182503854"},"html":{"href":"https://github.com/singularityware/singularity/pull/1456#discussion_r182503854"},"pull_request":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/1456"}}},"pull_request":{"url":"https://api.github.com/repos/singularityware/singularity/pulls/1456","id":181262353,"html_url":"https://github.com/singularityware/singularity/pull/1456","diff_url":"https://github.com/singularityware/singularity/pull/1456.diff","patch_url":"https://github.com/singularityware/singularity/pull/1456.patch","issue_url":"https://api.github.com/repos/singularityware/singularity/issues/1456","number":1456,"state":"open","locked":false,"title":"Mksquashfs opts","user":{"login":"ArangoGutierrez","id":15933089,"avatar_url":"https://avatars1.githubusercontent.com/u/15933089?v=4","gravatar_id":"","url":"https://api.github.com/users/ArangoGutierrez","html_url":"https://github.com/ArangoGutierrez","followers_url":"https://api.github.com/users/ArangoGutierrez/followers","following_url":"https://api.github.com/users/ArangoGutierrez/following{/other_user}","gists_url":"https://api.github.com/users/ArangoGutierrez/gists{/gist_id}","starred_url":"https://api.github.com/users/ArangoGutierrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArangoGutierrez/subscriptions","organizations_url":"https://api.github.com/users/ArangoGutierrez/orgs","repos_url":"https://api.github.com/users/ArangoGutierrez/repos","events_url":"https://api.github.com/users/ArangoGutierrez/events{/privacy}","received_events_url":"https://api.github.com/users/ArangoGutierrez/received_events","type":"User","site_admin":false},"body":"**Description of the Pull Request (PR):**\r\n\r\nEnable users to choose comp at build time\r\n\r\n```\r\n--comp <comp>    select squashfs Compressors \r\n                    available:\r\n                        gzip (default)\r\n                        lzma\r\n                        lzo\r\n                        xz\r\n```\r\n\r\nexample for lzo\r\n\r\n```\r\nsudo singularity build --comp lzo lzo_comp.img testdef\r\n```\r\n\r\nComp differences:\r\n\r\n```bash\r\n-rwxr-xr-x.  1 root    root     36M Apr 12 15:45 default_comp.img\r\n-rwxr-xr-x.  1 root    root     39M Apr 12 15:41 lzo_comp.img\r\n-rwxr-xr-x.  1 root    root     30M Apr 12 15:41 xz_comp.img\r\n```\r\n\r\n**Checkoff for all PRs:**\r\n\r\n- [x] I have read the [Guidelines for Contributing](https://github.com/singularityware/singularity/blob/master/CONTRIBUTING.md), and this PR conforms to the stated requirements.\r\n- [x] I have added changes to the [CHANGELOG](https://github.com/singularityware/singularity/blob/development/CHANGELOG.md) and and documentation updates to the [singularityware](https://www.github.com/singularityware/singularityware.github.io) documentation base.\r\n- [x] I have tested this PR locally with a `make test`\r\n- [x] This PR is NOT against the project's master branch\r\n- [x] I have added myself as a contributor to the [contributors's file](https://github.com/singularityware/singularity/blob/master/CONTRIBUTORS.md)\r\n- [x] This PR is ready for review and/or merge\r\n\r\n\r\nAttn: @singularityware/singularity-admin ","created_at":"2018-04-12T16:39:39Z","updated_at":"2018-04-18T17:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3584ec4b665f8a9160440e435d9e330aa90d164e","assignee":{"login":"ArangoGutierrez","id":15933089,"avatar_url":"https://avatars1.githubusercontent.com/u/15933089?v=4","gravatar_id":"","url":"https://api.github.com/users/ArangoGutierrez","html_url":"https://github.com/ArangoGutierrez","followers_url":"https://api.github.com/users/ArangoGutierrez/followers","following_url":"https://api.github.com/users/ArangoGutierrez/following{/other_user}","gists_url":"https://api.github.com/users/ArangoGutierrez/gists{/gist_id}","starred_url":"https://api.github.com/users/ArangoGutierrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArangoGutierrez/subscriptions","organizations_url":"https://api.github.com/users/ArangoGutierrez/orgs","repos_url":"https://api.github.com/users/ArangoGutierrez/repos","events_url":"https://api.github.com/users/ArangoGutierrez/events{/privacy}","received_events_url":"https://api.github.com/users/ArangoGutierrez/received_events","type":"User","site_admin":false},"assignees":[{"login":"ArangoGutierrez","id":15933089,"avatar_url":"https://avatars1.githubusercontent.com/u/15933089?v=4","gravatar_id":"","url":"https://api.github.com/users/ArangoGutierrez","html_url":"https://github.com/ArangoGutierrez","followers_url":"https://api.github.com/users/ArangoGutierrez/followers","following_url":"https://api.github.com/users/ArangoGutierrez/following{/other_user}","gists_url":"https://api.github.com/users/ArangoGutierrez/gists{/gist_id}","starred_url":"https://api.github.com/users/ArangoGutierrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArangoGutierrez/subscriptions","organizations_url":"https://api.github.com/users/ArangoGutierrez/orgs","repos_url":"https://api.github.com/users/ArangoGutierrez/repos","events_url":"https://api.github.com/users/ArangoGutierrez/events{/privacy}","received_events_url":"https://api.github.com/users/ArangoGutierrez/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cclerget","id":3274134,"avatar_url":"https://avatars2.githubusercontent.com/u/3274134?v=4","gravatar_id":"","url":"https://api.github.com/users/cclerget","html_url":"https://github.com/cclerget","followers_url":"https://api.github.com/users/cclerget/followers","following_url":"https://api.github.com/users/cclerget/following{/other_user}","gists_url":"https://api.github.com/users/cclerget/gists{/gist_id}","starred_url":"https://api.github.com/users/cclerget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclerget/subscriptions","organizations_url":"https://api.github.com/users/cclerget/orgs","repos_url":"https://api.github.com/users/cclerget/repos","events_url":"https://api.github.com/users/cclerget/events{/privacy}","received_events_url":"https://api.github.com/users/cclerget/received_events","type":"User","site_admin":false},{"login":"yhcote","id":13560291,"avatar_url":"https://avatars1.githubusercontent.com/u/13560291?v=4","gravatar_id":"","url":"https://api.github.com/users/yhcote","html_url":"https://github.com/yhcote","followers_url":"https://api.github.com/users/yhcote/followers","following_url":"https://api.github.com/users/yhcote/following{/other_user}","gists_url":"https://api.github.com/users/yhcote/gists{/gist_id}","starred_url":"https://api.github.com/users/yhcote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhcote/subscriptions","organizations_url":"https://api.github.com/users/yhcote/orgs","repos_url":"https://api.github.com/users/yhcote/repos","events_url":"https://api.github.com/users/yhcote/events{/privacy}","received_events_url":"https://api.github.com/users/yhcote/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":271060105,"url":"https://api.github.com/repos/singularityware/singularity/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/singularityware/singularity/pulls/1456/commits","review_comments_url":"https://api.github.com/repos/singularityware/singularity/pulls/1456/comments","review_comment_url":"https://api.github.com/repos/singularityware/singularity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/singularityware/singularity/issues/1456/comments","statuses_url":"https://api.github.com/repos/singularityware/singularity/statuses/7f0a29972c610e4ac5d748b36b8a34d884a08795","head":{"label":"ArangoGutierrez:mksquashfs-opts","ref":"mksquashfs-opts","sha":"7f0a29972c610e4ac5d748b36b8a34d884a08795","user":{"login":"ArangoGutierrez","id":15933089,"avatar_url":"https://avatars1.githubusercontent.com/u/15933089?v=4","gravatar_id":"","url":"https://api.github.com/users/ArangoGutierrez","html_url":"https://github.com/ArangoGutierrez","followers_url":"https://api.github.com/users/ArangoGutierrez/followers","following_url":"https://api.github.com/users/ArangoGutierrez/following{/other_user}","gists_url":"https://api.github.com/users/ArangoGutierrez/gists{/gist_id}","starred_url":"https://api.github.com/users/ArangoGutierrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArangoGutierrez/subscriptions","organizations_url":"https://api.github.com/users/ArangoGutierrez/orgs","repos_url":"https://api.github.com/users/ArangoGutierrez/repos","events_url":"https://api.github.com/users/ArangoGutierrez/events{/privacy}","received_events_url":"https://api.github.com/users/ArangoGutierrez/received_events","type":"User","site_admin":false},"repo":{"id":108599400,"name":"singularity","full_name":"ArangoGutierrez/singularity","owner":{"login":"ArangoGutierrez","id":15933089,"avatar_url":"https://avatars1.githubusercontent.com/u/15933089?v=4","gravatar_id":"","url":"https://api.github.com/users/ArangoGutierrez","html_url":"https://github.com/ArangoGutierrez","followers_url":"https://api.github.com/users/ArangoGutierrez/followers","following_url":"https://api.github.com/users/ArangoGutierrez/following{/other_user}","gists_url":"https://api.github.com/users/ArangoGutierrez/gists{/gist_id}","starred_url":"https://api.github.com/users/ArangoGutierrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArangoGutierrez/subscriptions","organizations_url":"https://api.github.com/users/ArangoGutierrez/orgs","repos_url":"https://api.github.com/users/ArangoGutierrez/repos","events_url":"https://api.github.com/users/ArangoGutierrez/events{/privacy}","received_events_url":"https://api.github.com/users/ArangoGutierrez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ArangoGutierrez/singularity","description":"Singularity: Application containers for Linux","fork":true,"url":"https://api.github.com/repos/ArangoGutierrez/singularity","forks_url":"https://api.github.com/repos/ArangoGutierrez/singularity/forks","keys_url":"https://api.github.com/repos/ArangoGutierrez/singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArangoGutierrez/singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArangoGutierrez/singularity/teams","hooks_url":"https://api.github.com/repos/ArangoGutierrez/singularity/hooks","issue_events_url":"https://api.github.com/repos/ArangoGutierrez/singularity/issues/events{/number}","events_url":"https://api.github.com/repos/ArangoGutierrez/singularity/events","assignees_url":"https://api.github.com/repos/ArangoGutierrez/singularity/assignees{/user}","branches_url":"https://api.github.com/repos/ArangoGutierrez/singularity/branches{/branch}","tags_url":"https://api.github.com/repos/ArangoGutierrez/singularity/tags","blobs_url":"https://api.github.com/repos/ArangoGutierrez/singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArangoGutierrez/singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArangoGutierrez/singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArangoGutierrez/singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArangoGutierrez/singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/ArangoGutierrez/singularity/languages","stargazers_url":"https://api.github.com/repos/ArangoGutierrez/singularity/stargazers","contributors_url":"https://api.github.com/repos/ArangoGutierrez/singularity/contributors","subscribers_url":"https://api.github.com/repos/ArangoGutierrez/singularity/subscribers","subscription_url":"https://api.github.com/repos/ArangoGutierrez/singularity/subscription","commits_url":"https://api.github.com/repos/ArangoGutierrez/singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArangoGutierrez/singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArangoGutierrez/singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArangoGutierrez/singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArangoGutierrez/singularity/contents/{+path}","compare_url":"https://api.github.com/repos/ArangoGutierrez/singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArangoGutierrez/singularity/merges","archive_url":"https://api.github.com/repos/ArangoGutierrez/singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArangoGutierrez/singularity/downloads","issues_url":"https://api.github.com/repos/ArangoGutierrez/singularity/issues{/number}","pulls_url":"https://api.github.com/repos/ArangoGutierrez/singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/ArangoGutierrez/singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/ArangoGutierrez/singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArangoGutierrez/singularity/labels{/name}","releases_url":"https://api.github.com/repos/ArangoGutierrez/singularity/releases{/id}","deployments_url":"https://api.github.com/repos/ArangoGutierrez/singularity/deployments","created_at":"2017-10-27T21:56:52Z","updated_at":"2017-10-27T21:56:54Z","pushed_at":"2018-04-12T20:17:35Z","git_url":"git://github.com/ArangoGutierrez/singularity.git","ssh_url":"git@github.com:ArangoGutierrez/singularity.git","clone_url":"https://github.com/ArangoGutierrez/singularity.git","svn_url":"https://github.com/ArangoGutierrez/singularity","homepage":"http://singularity.lbl.gov/","size":7899,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"singularityware:development-2.x","ref":"development-2.x","sha":"b1420f0e448a52a120fc364aad19d8be4dfe810e","user":{"login":"singularityware","id":20306680,"avatar_url":"https://avatars0.githubusercontent.com/u/20306680?v=4","gravatar_id":"","url":"https://api.github.com/users/singularityware","html_url":"https://github.com/singularityware","followers_url":"https://api.github.com/users/singularityware/followers","following_url":"https://api.github.com/users/singularityware/following{/other_user}","gists_url":"https://api.github.com/users/singularityware/gists{/gist_id}","starred_url":"https://api.github.com/users/singularityware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singularityware/subscriptions","organizations_url":"https://api.github.com/users/singularityware/orgs","repos_url":"https://api.github.com/users/singularityware/repos","events_url":"https://api.github.com/users/singularityware/events{/privacy}","received_events_url":"https://api.github.com/users/singularityware/received_events","type":"Organization","site_admin":false},"repo":{"id":43982667,"name":"singularity","full_name":"singularityware/singularity","owner":{"login":"singularityware","id":20306680,"avatar_url":"https://avatars0.githubusercontent.com/u/20306680?v=4","gravatar_id":"","url":"https://api.github.com/users/singularityware","html_url":"https://github.com/singularityware","followers_url":"https://api.github.com/users/singularityware/followers","following_url":"https://api.github.com/users/singularityware/following{/other_user}","gists_url":"https://api.github.com/users/singularityware/gists{/gist_id}","starred_url":"https://api.github.com/users/singularityware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singularityware/subscriptions","organizations_url":"https://api.github.com/users/singularityware/orgs","repos_url":"https://api.github.com/users/singularityware/repos","events_url":"https://api.github.com/users/singularityware/events{/privacy}","received_events_url":"https://api.github.com/users/singularityware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/singularityware/singularity","description":"Singularity: Application containers for Linux","fork":false,"url":"https://api.github.com/repos/singularityware/singularity","forks_url":"https://api.github.com/repos/singularityware/singularity/forks","keys_url":"https://api.github.com/repos/singularityware/singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singularityware/singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singularityware/singularity/teams","hooks_url":"https://api.github.com/repos/singularityware/singularity/hooks","issue_events_url":"https://api.github.com/repos/singularityware/singularity/issues/events{/number}","events_url":"https://api.github.com/repos/singularityware/singularity/events","assignees_url":"https://api.github.com/repos/singularityware/singularity/assignees{/user}","branches_url":"https://api.github.com/repos/singularityware/singularity/branches{/branch}","tags_url":"https://api.github.com/repos/singularityware/singularity/tags","blobs_url":"https://api.github.com/repos/singularityware/singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singularityware/singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singularityware/singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/singularityware/singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singularityware/singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/singularityware/singularity/languages","stargazers_url":"https://api.github.com/repos/singularityware/singularity/stargazers","contributors_url":"https://api.github.com/repos/singularityware/singularity/contributors","subscribers_url":"https://api.github.com/repos/singularityware/singularity/subscribers","subscription_url":"https://api.github.com/repos/singularityware/singularity/subscription","commits_url":"https://api.github.com/repos/singularityware/singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/singularityware/singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/singularityware/singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/singularityware/singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/singularityware/singularity/contents/{+path}","compare_url":"https://api.github.com/repos/singularityware/singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singularityware/singularity/merges","archive_url":"https://api.github.com/repos/singularityware/singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singularityware/singularity/downloads","issues_url":"https://api.github.com/repos/singularityware/singularity/issues{/number}","pulls_url":"https://api.github.com/repos/singularityware/singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/singularityware/singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/singularityware/singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singularityware/singularity/labels{/name}","releases_url":"https://api.github.com/repos/singularityware/singularity/releases{/id}","deployments_url":"https://api.github.com/repos/singularityware/singularity/deployments","created_at":"2015-10-09T22:15:12Z","updated_at":"2018-04-18T13:47:57Z","pushed_at":"2018-04-17T22:07:54Z","git_url":"git://github.com/singularityware/singularity.git","ssh_url":"git@github.com:singularityware/singularity.git","clone_url":"https://github.com/singularityware/singularity.git","svn_url":"https://github.com/singularityware/singularity","homepage":"http://singularity.lbl.gov/","size":8034,"stargazers_count":571,"watchers_count":571,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":182,"mirror_url":null,"archived":false,"open_issues_count":216,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":182,"open_issues":216,"watchers":571,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/1456"},"html":{"href":"https://github.com/singularityware/singularity/pull/1456"},"issue":{"href":"https://api.github.com/repos/singularityware/singularity/issues/1456"},"comments":{"href":"https://api.github.com/repos/singularityware/singularity/issues/1456/comments"},"review_comments":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/1456/comments"},"review_comment":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/singularityware/singularity/pulls/1456/commits"},"statuses":{"href":"https://api.github.com/repos/singularityware/singularity/statuses/7f0a29972c610e4ac5d748b36b8a34d884a08795"}},"author_association":"OWNER"}}
{"actor":{"display_login":"bauerm97"}}