{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/Ellypse/Storyline/pulls/26","id":201470159,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDcwMTU5","html_url":"https://github.com/Ellypse/Storyline/pull/26","diff_url":"https://github.com/Ellypse/Storyline/pull/26.diff","patch_url":"https://github.com/Ellypse/Storyline/pull/26.patch","issue_url":"https://api.github.com/repos/Ellypse/Storyline/issues/26","number":26,"state":"open","locked":false,"title":"Multi-paragraph emotes","user":{"login":"Solanya","id":17127080,"node_id":"MDQ6VXNlcjE3MTI3MDgw","avatar_url":"https://avatars0.githubusercontent.com/u/17127080?v=4","gravatar_id":"","url":"https://api.github.com/users/Solanya","html_url":"https://github.com/Solanya","followers_url":"https://api.github.com/users/Solanya/followers","following_url":"https://api.github.com/users/Solanya/following{/other_user}","gists_url":"https://api.github.com/users/Solanya/gists{/gist_id}","starred_url":"https://api.github.com/users/Solanya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solanya/subscriptions","organizations_url":"https://api.github.com/users/Solanya/orgs","repos_url":"https://api.github.com/users/Solanya/repos","events_url":"https://api.github.com/users/Solanya/events{/privacy}","received_events_url":"https://api.github.com/users/Solanya/received_events","type":"User","site_admin":false},"body":"Some quests in Battle for Azeroth are displaying multi-paragraph emotes that aren't currently supported in Storyline (as it is only checking for a `<` at the start of the text).\r\n\r\nWhat this new code does : \r\n- It builds a new array, `stillEmote`, of the size of the texts array. For each text index, it is true if the previous text was an emote left open, else false.\r\n\r\n- The first index is always false, as there is no emote left open before the first text.\r\n  - If the current text isn't continuation of an existing emote and we have more `<` than `>`, we set the next index to be a continuation of an existing emote. If we have the same number, there is either no emote or it was closed in the same paragraph, so next index isn't a continuation either.\r\n  - If the current text is a continuation of an existing emote and we have more `>` than `<`, we set the next index to not be a continuation, as the emote is closed in the current text. If we have the same number, the emote still hasn't been closed, so next index is a continuation as well.\r\n\r\n**I'll have to run through quests again to check if they ever open an emote in the middle of a text, as I don't think this behaviour is currently supported by Storyline. The multi-paragraph code would work, but I'm not 100% sure the color would be applied to the beginning of the emote.**\r\n\r\nThis code doesn't expect Blizzard to make nested emotes. I'm calling the police if they do.","created_at":"2018-07-14T21:36:17Z","updated_at":"2018-07-14T21:36:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ellypse/Storyline/pulls/26/commits","review_comments_url":"https://api.github.com/repos/Ellypse/Storyline/pulls/26/comments","review_comment_url":"https://api.github.com/repos/Ellypse/Storyline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ellypse/Storyline/issues/26/comments","statuses_url":"https://api.github.com/repos/Ellypse/Storyline/statuses/9ccfeddd20c4c7779a4b5f8201a2780f3567da0b","head":{"label":"Solanya:bugfix/multi_paragraph_emote","ref":"bugfix/multi_paragraph_emote","sha":"9ccfeddd20c4c7779a4b5f8201a2780f3567da0b","user":{"login":"Solanya","id":17127080,"node_id":"MDQ6VXNlcjE3MTI3MDgw","avatar_url":"https://avatars0.githubusercontent.com/u/17127080?v=4","gravatar_id":"","url":"https://api.github.com/users/Solanya","html_url":"https://github.com/Solanya","followers_url":"https://api.github.com/users/Solanya/followers","following_url":"https://api.github.com/users/Solanya/following{/other_user}","gists_url":"https://api.github.com/users/Solanya/gists{/gist_id}","starred_url":"https://api.github.com/users/Solanya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solanya/subscriptions","organizations_url":"https://api.github.com/users/Solanya/orgs","repos_url":"https://api.github.com/users/Solanya/repos","events_url":"https://api.github.com/users/Solanya/events{/privacy}","received_events_url":"https://api.github.com/users/Solanya/received_events","type":"User","site_admin":false},"repo":{"id":131318752,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEzMTg3NTI=","name":"Storyline","full_name":"Solanya/Storyline","owner":{"login":"Solanya","id":17127080,"node_id":"MDQ6VXNlcjE3MTI3MDgw","avatar_url":"https://avatars0.githubusercontent.com/u/17127080?v=4","gravatar_id":"","url":"https://api.github.com/users/Solanya","html_url":"https://github.com/Solanya","followers_url":"https://api.github.com/users/Solanya/followers","following_url":"https://api.github.com/users/Solanya/following{/other_user}","gists_url":"https://api.github.com/users/Solanya/gists{/gist_id}","starred_url":"https://api.github.com/users/Solanya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solanya/subscriptions","organizations_url":"https://api.github.com/users/Solanya/orgs","repos_url":"https://api.github.com/users/Solanya/repos","events_url":"https://api.github.com/users/Solanya/events{/privacy}","received_events_url":"https://api.github.com/users/Solanya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Solanya/Storyline","description":"A World of Warcraft add-on that improves the questing experience by replacing the default dialog frame by a more immersive frame with 3D models.","fork":true,"url":"https://api.github.com/repos/Solanya/Storyline","forks_url":"https://api.github.com/repos/Solanya/Storyline/forks","keys_url":"https://api.github.com/repos/Solanya/Storyline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Solanya/Storyline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Solanya/Storyline/teams","hooks_url":"https://api.github.com/repos/Solanya/Storyline/hooks","issue_events_url":"https://api.github.com/repos/Solanya/Storyline/issues/events{/number}","events_url":"https://api.github.com/repos/Solanya/Storyline/events","assignees_url":"https://api.github.com/repos/Solanya/Storyline/assignees{/user}","branches_url":"https://api.github.com/repos/Solanya/Storyline/branches{/branch}","tags_url":"https://api.github.com/repos/Solanya/Storyline/tags","blobs_url":"https://api.github.com/repos/Solanya/Storyline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Solanya/Storyline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Solanya/Storyline/git/refs{/sha}","trees_url":"https://api.github.com/repos/Solanya/Storyline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Solanya/Storyline/statuses/{sha}","languages_url":"https://api.github.com/repos/Solanya/Storyline/languages","stargazers_url":"https://api.github.com/repos/Solanya/Storyline/stargazers","contributors_url":"https://api.github.com/repos/Solanya/Storyline/contributors","subscribers_url":"https://api.github.com/repos/Solanya/Storyline/subscribers","subscription_url":"https://api.github.com/repos/Solanya/Storyline/subscription","commits_url":"https://api.github.com/repos/Solanya/Storyline/commits{/sha}","git_commits_url":"https://api.github.com/repos/Solanya/Storyline/git/commits{/sha}","comments_url":"https://api.github.com/repos/Solanya/Storyline/comments{/number}","issue_comment_url":"https://api.github.com/repos/Solanya/Storyline/issues/comments{/number}","contents_url":"https://api.github.com/repos/Solanya/Storyline/contents/{+path}","compare_url":"https://api.github.com/repos/Solanya/Storyline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Solanya/Storyline/merges","archive_url":"https://api.github.com/repos/Solanya/Storyline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Solanya/Storyline/downloads","issues_url":"https://api.github.com/repos/Solanya/Storyline/issues{/number}","pulls_url":"https://api.github.com/repos/Solanya/Storyline/pulls{/number}","milestones_url":"https://api.github.com/repos/Solanya/Storyline/milestones{/number}","notifications_url":"https://api.github.com/repos/Solanya/Storyline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Solanya/Storyline/labels{/name}","releases_url":"https://api.github.com/repos/Solanya/Storyline/releases{/id}","deployments_url":"https://api.github.com/repos/Solanya/Storyline/deployments","created_at":"2018-04-27T16:10:45Z","updated_at":"2018-04-27T16:10:47Z","pushed_at":"2018-07-14T21:26:01Z","git_url":"git://github.com/Solanya/Storyline.git","ssh_url":"git@github.com:Solanya/Storyline.git","clone_url":"https://github.com/Solanya/Storyline.git","svn_url":"https://github.com/Solanya/Storyline","homepage":"https://mods.curse.com/addons/wow/storyline","size":18270,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ellypse:dev","ref":"dev","sha":"eea04b202ce80bf5cb32c47addeb50580992fcbb","user":{"login":"Ellypse","id":9035119,"node_id":"MDQ6VXNlcjkwMzUxMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/9035119?v=4","gravatar_id":"","url":"https://api.github.com/users/Ellypse","html_url":"https://github.com/Ellypse","followers_url":"https://api.github.com/users/Ellypse/followers","following_url":"https://api.github.com/users/Ellypse/following{/other_user}","gists_url":"https://api.github.com/users/Ellypse/gists{/gist_id}","starred_url":"https://api.github.com/users/Ellypse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ellypse/subscriptions","organizations_url":"https://api.github.com/users/Ellypse/orgs","repos_url":"https://api.github.com/users/Ellypse/repos","events_url":"https://api.github.com/users/Ellypse/events{/privacy}","received_events_url":"https://api.github.com/users/Ellypse/received_events","type":"User","site_admin":false},"repo":{"id":83543956,"node_id":"MDEwOlJlcG9zaXRvcnk4MzU0Mzk1Ng==","name":"Storyline","full_name":"Ellypse/Storyline","owner":{"login":"Ellypse","id":9035119,"node_id":"MDQ6VXNlcjkwMzUxMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/9035119?v=4","gravatar_id":"","url":"https://api.github.com/users/Ellypse","html_url":"https://github.com/Ellypse","followers_url":"https://api.github.com/users/Ellypse/followers","following_url":"https://api.github.com/users/Ellypse/following{/other_user}","gists_url":"https://api.github.com/users/Ellypse/gists{/gist_id}","starred_url":"https://api.github.com/users/Ellypse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ellypse/subscriptions","organizations_url":"https://api.github.com/users/Ellypse/orgs","repos_url":"https://api.github.com/users/Ellypse/repos","events_url":"https://api.github.com/users/Ellypse/events{/privacy}","received_events_url":"https://api.github.com/users/Ellypse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ellypse/Storyline","description":"A World of Warcraft add-on that improves the questing experience by replacing the default dialog frame by a more immersive frame with 3D models.","fork":false,"url":"https://api.github.com/repos/Ellypse/Storyline","forks_url":"https://api.github.com/repos/Ellypse/Storyline/forks","keys_url":"https://api.github.com/repos/Ellypse/Storyline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ellypse/Storyline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ellypse/Storyline/teams","hooks_url":"https://api.github.com/repos/Ellypse/Storyline/hooks","issue_events_url":"https://api.github.com/repos/Ellypse/Storyline/issues/events{/number}","events_url":"https://api.github.com/repos/Ellypse/Storyline/events","assignees_url":"https://api.github.com/repos/Ellypse/Storyline/assignees{/user}","branches_url":"https://api.github.com/repos/Ellypse/Storyline/branches{/branch}","tags_url":"https://api.github.com/repos/Ellypse/Storyline/tags","blobs_url":"https://api.github.com/repos/Ellypse/Storyline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ellypse/Storyline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ellypse/Storyline/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ellypse/Storyline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ellypse/Storyline/statuses/{sha}","languages_url":"https://api.github.com/repos/Ellypse/Storyline/languages","stargazers_url":"https://api.github.com/repos/Ellypse/Storyline/stargazers","contributors_url":"https://api.github.com/repos/Ellypse/Storyline/contributors","subscribers_url":"https://api.github.com/repos/Ellypse/Storyline/subscribers","subscription_url":"https://api.github.com/repos/Ellypse/Storyline/subscription","commits_url":"https://api.github.com/repos/Ellypse/Storyline/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ellypse/Storyline/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ellypse/Storyline/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ellypse/Storyline/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ellypse/Storyline/contents/{+path}","compare_url":"https://api.github.com/repos/Ellypse/Storyline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ellypse/Storyline/merges","archive_url":"https://api.github.com/repos/Ellypse/Storyline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ellypse/Storyline/downloads","issues_url":"https://api.github.com/repos/Ellypse/Storyline/issues{/number}","pulls_url":"https://api.github.com/repos/Ellypse/Storyline/pulls{/number}","milestones_url":"https://api.github.com/repos/Ellypse/Storyline/milestones{/number}","notifications_url":"https://api.github.com/repos/Ellypse/Storyline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ellypse/Storyline/labels{/name}","releases_url":"https://api.github.com/repos/Ellypse/Storyline/releases{/id}","deployments_url":"https://api.github.com/repos/Ellypse/Storyline/deployments","created_at":"2017-03-01T10:47:58Z","updated_at":"2018-05-06T09:16:21Z","pushed_at":"2018-07-14T15:54:34Z","git_url":"git://github.com/Ellypse/Storyline.git","ssh_url":"git@github.com:Ellypse/Storyline.git","clone_url":"https://github.com/Ellypse/Storyline.git","svn_url":"https://github.com/Ellypse/Storyline","homepage":"https://mods.curse.com/addons/wow/storyline","size":18279,"stargazers_count":6,"watchers_count":6,"language":"Lua","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":1,"open_issues":18,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ellypse/Storyline/pulls/26"},"html":{"href":"https://github.com/Ellypse/Storyline/pull/26"},"issue":{"href":"https://api.github.com/repos/Ellypse/Storyline/issues/26"},"comments":{"href":"https://api.github.com/repos/Ellypse/Storyline/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/Ellypse/Storyline/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/Ellypse/Storyline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ellypse/Storyline/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/Ellypse/Storyline/statuses/9ccfeddd20c4c7779a4b5f8201a2780f3567da0b"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":28,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"Solanya"}}