{"action":"created","comment":{"url":"https://api.github.com/repos/actix/actix-web/pulls/comments/202549421","pull_request_review_id":137273357,"id":202549421,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjU0OTQyMQ==","diff_hunk":"@@ -146,6 +147,32 @@ impl ResourceInfo {\n         }\n         false\n     }\n+\n+    /// Check if application contains matching route.\n+    ///\n+    /// This method does take `prefix` into account\n+    /// but behaves like `has_route` in case `prefix` is not set in the router.\n+    ///\n+    /// For example if prefix is `/test` and router contains route `/name`, the\n+    /// following path would be recognizable `/test/name` and `has_prefixed_route()` call\n+    /// would return `true`.\n+    /// It will not match against prefix in case it's not given. For example for `/name`","path":"src/router.rs","position":21,"original_position":21,"commit_id":"8f645088878380b40485dedff5eb51020aa5f353","original_commit_id":"8f645088878380b40485dedff5eb51020aa5f353","user":{"login":"DoumanAsh","id":5676053,"node_id":"MDQ6VXNlcjU2NzYwNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5676053?v=4","gravatar_id":"","url":"https://api.github.com/users/DoumanAsh","html_url":"https://github.com/DoumanAsh","followers_url":"https://api.github.com/users/DoumanAsh/followers","following_url":"https://api.github.com/users/DoumanAsh/following{/other_user}","gists_url":"https://api.github.com/users/DoumanAsh/gists{/gist_id}","starred_url":"https://api.github.com/users/DoumanAsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoumanAsh/subscriptions","organizations_url":"https://api.github.com/users/DoumanAsh/orgs","repos_url":"https://api.github.com/users/DoumanAsh/repos","events_url":"https://api.github.com/users/DoumanAsh/events{/privacy}","received_events_url":"https://api.github.com/users/DoumanAsh/received_events","type":"User","site_admin":false},"body":"I'm not sure I follow this comment, what exactly you wanted to say here?\r\nDid you mean that path `/name` would match route `/name` when prefix `/test` is omitted?","created_at":"2018-07-15T17:56:09Z","updated_at":"2018-07-15T17:58:43Z","html_url":"https://github.com/actix/actix-web/pull/381#discussion_r202549421","pull_request_url":"https://api.github.com/repos/actix/actix-web/pulls/381","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/actix/actix-web/pulls/comments/202549421"},"html":{"href":"https://github.com/actix/actix-web/pull/381#discussion_r202549421"},"pull_request":{"href":"https://api.github.com/repos/actix/actix-web/pulls/381"}}},"pull_request":{"url":"https://api.github.com/repos/actix/actix-web/pulls/381","id":200372632,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMzcyNjMy","html_url":"https://github.com/actix/actix-web/pull/381","diff_url":"https://github.com/actix/actix-web/pull/381.diff","patch_url":"https://github.com/actix/actix-web/pull/381.patch","issue_url":"https://api.github.com/repos/actix/actix-web/issues/381","number":381,"state":"open","locked":false,"title":"Add prefix aware RouteInfo::has_prefixed_route()","user":{"login":"OtaK","id":1262712,"node_id":"MDQ6VXNlcjEyNjI3MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1262712?v=4","gravatar_id":"","url":"https://api.github.com/users/OtaK","html_url":"https://github.com/OtaK","followers_url":"https://api.github.com/users/OtaK/followers","following_url":"https://api.github.com/users/OtaK/following{/other_user}","gists_url":"https://api.github.com/users/OtaK/gists{/gist_id}","starred_url":"https://api.github.com/users/OtaK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OtaK/subscriptions","organizations_url":"https://api.github.com/users/OtaK/orgs","repos_url":"https://api.github.com/users/OtaK/repos","events_url":"https://api.github.com/users/OtaK/events{/privacy}","received_events_url":"https://api.github.com/users/OtaK/received_events","type":"User","site_admin":false},"body":"Fixes #354 ","created_at":"2018-07-10T12:02:24Z","updated_at":"2018-07-15T17:58:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc042babe21c865908efbae1804f261918b743bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/actix/actix-web/pulls/381/commits","review_comments_url":"https://api.github.com/repos/actix/actix-web/pulls/381/comments","review_comment_url":"https://api.github.com/repos/actix/actix-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/actix/actix-web/issues/381/comments","statuses_url":"https://api.github.com/repos/actix/actix-web/statuses/8f645088878380b40485dedff5eb51020aa5f353","head":{"label":"OtaK:fix/has_route_prefixes","ref":"fix/has_route_prefixes","sha":"8f645088878380b40485dedff5eb51020aa5f353","user":{"login":"OtaK","id":1262712,"node_id":"MDQ6VXNlcjEyNjI3MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1262712?v=4","gravatar_id":"","url":"https://api.github.com/users/OtaK","html_url":"https://github.com/OtaK","followers_url":"https://api.github.com/users/OtaK/followers","following_url":"https://api.github.com/users/OtaK/following{/other_user}","gists_url":"https://api.github.com/users/OtaK/gists{/gist_id}","starred_url":"https://api.github.com/users/OtaK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OtaK/subscriptions","organizations_url":"https://api.github.com/users/OtaK/orgs","repos_url":"https://api.github.com/users/OtaK/repos","events_url":"https://api.github.com/users/OtaK/events{/privacy}","received_events_url":"https://api.github.com/users/OtaK/received_events","type":"User","site_admin":false},"repo":{"id":140416341,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0MTYzNDE=","name":"actix-web","full_name":"OtaK/actix-web","owner":{"login":"OtaK","id":1262712,"node_id":"MDQ6VXNlcjEyNjI3MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1262712?v=4","gravatar_id":"","url":"https://api.github.com/users/OtaK","html_url":"https://github.com/OtaK","followers_url":"https://api.github.com/users/OtaK/followers","following_url":"https://api.github.com/users/OtaK/following{/other_user}","gists_url":"https://api.github.com/users/OtaK/gists{/gist_id}","starred_url":"https://api.github.com/users/OtaK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OtaK/subscriptions","organizations_url":"https://api.github.com/users/OtaK/orgs","repos_url":"https://api.github.com/users/OtaK/repos","events_url":"https://api.github.com/users/OtaK/events{/privacy}","received_events_url":"https://api.github.com/users/OtaK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OtaK/actix-web","description":"Actix web is a small, pragmatic, and extremely fast rust web framework.","fork":true,"url":"https://api.github.com/repos/OtaK/actix-web","forks_url":"https://api.github.com/repos/OtaK/actix-web/forks","keys_url":"https://api.github.com/repos/OtaK/actix-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OtaK/actix-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OtaK/actix-web/teams","hooks_url":"https://api.github.com/repos/OtaK/actix-web/hooks","issue_events_url":"https://api.github.com/repos/OtaK/actix-web/issues/events{/number}","events_url":"https://api.github.com/repos/OtaK/actix-web/events","assignees_url":"https://api.github.com/repos/OtaK/actix-web/assignees{/user}","branches_url":"https://api.github.com/repos/OtaK/actix-web/branches{/branch}","tags_url":"https://api.github.com/repos/OtaK/actix-web/tags","blobs_url":"https://api.github.com/repos/OtaK/actix-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OtaK/actix-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OtaK/actix-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/OtaK/actix-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OtaK/actix-web/statuses/{sha}","languages_url":"https://api.github.com/repos/OtaK/actix-web/languages","stargazers_url":"https://api.github.com/repos/OtaK/actix-web/stargazers","contributors_url":"https://api.github.com/repos/OtaK/actix-web/contributors","subscribers_url":"https://api.github.com/repos/OtaK/actix-web/subscribers","subscription_url":"https://api.github.com/repos/OtaK/actix-web/subscription","commits_url":"https://api.github.com/repos/OtaK/actix-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/OtaK/actix-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/OtaK/actix-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/OtaK/actix-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/OtaK/actix-web/contents/{+path}","compare_url":"https://api.github.com/repos/OtaK/actix-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OtaK/actix-web/merges","archive_url":"https://api.github.com/repos/OtaK/actix-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OtaK/actix-web/downloads","issues_url":"https://api.github.com/repos/OtaK/actix-web/issues{/number}","pulls_url":"https://api.github.com/repos/OtaK/actix-web/pulls{/number}","milestones_url":"https://api.github.com/repos/OtaK/actix-web/milestones{/number}","notifications_url":"https://api.github.com/repos/OtaK/actix-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OtaK/actix-web/labels{/name}","releases_url":"https://api.github.com/repos/OtaK/actix-web/releases{/id}","deployments_url":"https://api.github.com/repos/OtaK/actix-web/deployments","created_at":"2018-07-10T10:32:49Z","updated_at":"2018-07-15T15:56:05Z","pushed_at":"2018-07-15T17:37:37Z","git_url":"git://github.com/OtaK/actix-web.git","ssh_url":"git@github.com:OtaK/actix-web.git","clone_url":"https://github.com/OtaK/actix-web.git","svn_url":"https://github.com/OtaK/actix-web","homepage":"https://actix.rs","size":5989,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"actix:master","ref":"master","sha":"30c84786b707a1a02b712798ef01325439de9337","user":{"login":"actix","id":32776943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc2OTQz","avatar_url":"https://avatars3.githubusercontent.com/u/32776943?v=4","gravatar_id":"","url":"https://api.github.com/users/actix","html_url":"https://github.com/actix","followers_url":"https://api.github.com/users/actix/followers","following_url":"https://api.github.com/users/actix/following{/other_user}","gists_url":"https://api.github.com/users/actix/gists{/gist_id}","starred_url":"https://api.github.com/users/actix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actix/subscriptions","organizations_url":"https://api.github.com/users/actix/orgs","repos_url":"https://api.github.com/users/actix/repos","events_url":"https://api.github.com/users/actix/events{/privacy}","received_events_url":"https://api.github.com/users/actix/received_events","type":"Organization","site_admin":false},"repo":{"id":105379569,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUzNzk1Njk=","name":"actix-web","full_name":"actix/actix-web","owner":{"login":"actix","id":32776943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc2OTQz","avatar_url":"https://avatars3.githubusercontent.com/u/32776943?v=4","gravatar_id":"","url":"https://api.github.com/users/actix","html_url":"https://github.com/actix","followers_url":"https://api.github.com/users/actix/followers","following_url":"https://api.github.com/users/actix/following{/other_user}","gists_url":"https://api.github.com/users/actix/gists{/gist_id}","starred_url":"https://api.github.com/users/actix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actix/subscriptions","organizations_url":"https://api.github.com/users/actix/orgs","repos_url":"https://api.github.com/users/actix/repos","events_url":"https://api.github.com/users/actix/events{/privacy}","received_events_url":"https://api.github.com/users/actix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/actix/actix-web","description":"Actix web is a small, pragmatic, and extremely fast rust web framework.","fork":false,"url":"https://api.github.com/repos/actix/actix-web","forks_url":"https://api.github.com/repos/actix/actix-web/forks","keys_url":"https://api.github.com/repos/actix/actix-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/actix/actix-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/actix/actix-web/teams","hooks_url":"https://api.github.com/repos/actix/actix-web/hooks","issue_events_url":"https://api.github.com/repos/actix/actix-web/issues/events{/number}","events_url":"https://api.github.com/repos/actix/actix-web/events","assignees_url":"https://api.github.com/repos/actix/actix-web/assignees{/user}","branches_url":"https://api.github.com/repos/actix/actix-web/branches{/branch}","tags_url":"https://api.github.com/repos/actix/actix-web/tags","blobs_url":"https://api.github.com/repos/actix/actix-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/actix/actix-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/actix/actix-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/actix/actix-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/actix/actix-web/statuses/{sha}","languages_url":"https://api.github.com/repos/actix/actix-web/languages","stargazers_url":"https://api.github.com/repos/actix/actix-web/stargazers","contributors_url":"https://api.github.com/repos/actix/actix-web/contributors","subscribers_url":"https://api.github.com/repos/actix/actix-web/subscribers","subscription_url":"https://api.github.com/repos/actix/actix-web/subscription","commits_url":"https://api.github.com/repos/actix/actix-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/actix/actix-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/actix/actix-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/actix/actix-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/actix/actix-web/contents/{+path}","compare_url":"https://api.github.com/repos/actix/actix-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/actix/actix-web/merges","archive_url":"https://api.github.com/repos/actix/actix-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/actix/actix-web/downloads","issues_url":"https://api.github.com/repos/actix/actix-web/issues{/number}","pulls_url":"https://api.github.com/repos/actix/actix-web/pulls{/number}","milestones_url":"https://api.github.com/repos/actix/actix-web/milestones{/number}","notifications_url":"https://api.github.com/repos/actix/actix-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/actix/actix-web/labels{/name}","releases_url":"https://api.github.com/repos/actix/actix-web/releases{/id}","deployments_url":"https://api.github.com/repos/actix/actix-web/deployments","created_at":"2017-09-30T15:30:02Z","updated_at":"2018-07-15T16:59:13Z","pushed_at":"2018-07-15T17:37:39Z","git_url":"git://github.com/actix/actix-web.git","ssh_url":"git@github.com:actix/actix-web.git","clone_url":"https://github.com/actix/actix-web.git","svn_url":"https://github.com/actix/actix-web","homepage":"https://actix.rs","size":6029,"stargazers_count":1921,"watchers_count":1921,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":125,"open_issues":45,"watchers":1921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/actix/actix-web/pulls/381"},"html":{"href":"https://github.com/actix/actix-web/pull/381"},"issue":{"href":"https://api.github.com/repos/actix/actix-web/issues/381"},"comments":{"href":"https://api.github.com/repos/actix/actix-web/issues/381/comments"},"review_comments":{"href":"https://api.github.com/repos/actix/actix-web/pulls/381/comments"},"review_comment":{"href":"https://api.github.com/repos/actix/actix-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/actix/actix-web/pulls/381/commits"},"statuses":{"href":"https://api.github.com/repos/actix/actix-web/statuses/8f645088878380b40485dedff5eb51020aa5f353"}},"author_association":"NONE"}}
{"actor":{"display_login":"DoumanAsh"}}