{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/173174887","pull_request_review_id":102318782,"id":173174887,"diff_hunk":"@@ -21,7 +21,7 @@ import (\n \n \t\"github.com/cilium/cilium/test/helpers\"\n \n-\t. \"github.com/onsi/ginkgo\"\n+\t. \"github.com/eloycoto/ginkgo-ext\"","path":"test/runtime/chaos.go","position":5,"original_position":5,"commit_id":"1dde554e0d56820d853768caac500eb10b3d9c0d","original_commit_id":"1dde554e0d56820d853768caac500eb10b3d9c0d","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"should not use dot imports","created_at":"2018-03-08T14:34:34Z","updated_at":"2018-03-08T14:34:34Z","html_url":"https://github.com/cilium/cilium/pull/3059#discussion_r173174887","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/3059","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/173174887"},"html":{"href":"https://github.com/cilium/cilium/pull/3059#discussion_r173174887"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3059"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/3059","id":173751449,"html_url":"https://github.com/cilium/cilium/pull/3059","diff_url":"https://github.com/cilium/cilium/pull/3059.diff","patch_url":"https://github.com/cilium/cilium/pull/3059.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/3059","number":3059,"state":"open","locked":false,"title":"RFC: Ginkgo: First bootstrap of using BeforeAll and AfterAll","user":{"login":"eloycoto","id":868013,"avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"body":"This commit fixed our outstanding issue about creating and deleting containers\r\nfor the same Testcase and do not have the option for setup and teardown\r\nactions.\r\n\r\nThis code added a new vendor dependency, \"ginkgo-ext\" that it's a copy\r\nof `Mirantis/Virtlet` e2e ginkgo-extension with a few additions to\r\nsupport `--focus` option.\r\n\r\nThe main changes in this code are:\r\n\r\n- `BeforeAll()` replaces BeforeSuite. On the other hand, `BeforeAll` can\r\nbe used on Describe and Context  like the initialize function that we're\r\nusing now.\r\n\r\n- `AfterAll()` replaces `AfterSuite()`. On the other hand, `AfterAll()`\r\ncan be used in Describe and Context to clean the state after the\r\ntestCase finished, like tearDown function in any unit testing function.\r\n\r\nThe example TestCase can be the following:\r\n\r\n```\r\nvar _ = Describe(\"K8Spolicies\", func() {\r\n\r\n        AfterAll(func() {\r\n                fmt.Println(\"AfterAll---<\")\r\n        })\r\n\r\n\t\tAfterEach(func(){\r\n\t\t\tfmt.Println(\"AfterEach\")\r\n\t\t})\r\n\r\n        Context(\"Test Group\", func() {\r\n\r\n                AfterAll(func() {\r\n                        fmt.Println(\"AfterAll---<Context\")\r\n                })\r\n\r\n                It(\"Test1\", func() {\r\n                        Expect(true).To(BeTrue())\r\n                })\r\n\r\n                It(\"Test2\", func() {\r\n                        Expect(true).To(BeTrue())\r\n                })\r\n        })\r\n\r\n        It(\"Test1\", func() {\r\n                Expect(true).To(BeTrue())\r\n        })\r\n\r\n        It(\"Test2\", func() {\r\n                Expect(true).To(BeTrue())\r\n        })\r\n})\r\n```\r\n\r\nATM I only migrated `RuntimeValidatedMonitor`, where the AfterAll/BeforeEach is\r\nused, the idea is to run the test for a few days, and if nothing fails move to\r\nother testCases.\r\n\r\nPending things: \r\n\r\n- [] Move eloycoto/ginkgo-ext to cilium org. ","created_at":"2018-03-08T14:34:21Z","updated_at":"2018-03-08T14:34:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e6801682d3deb885b8c5d70c8d4e9318109117e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"ci","id":2519781,"slug":"ci","description":"CI integration","privacy":"closed","url":"https://api.github.com/teams/2519781","members_url":"https://api.github.com/teams/2519781/members{/member}","repositories_url":"https://api.github.com/teams/2519781/repos","permission":"pull"},{"name":"vendor","id":2519791,"slug":"vendor","description":"Vendor dependencies","privacy":"closed","url":"https://api.github.com/teams/2519791","members_url":"https://api.github.com/teams/2519791/members{/member}","repositories_url":"https://api.github.com/teams/2519791/repos","permission":"pull"},{"name":"janitors","id":2519796,"slug":"janitors","description":"Rotating team of janitors for unowned code","privacy":"closed","url":"https://api.github.com/teams/2519796","members_url":"https://api.github.com/teams/2519796/members{/member}","repositories_url":"https://api.github.com/teams/2519796/repos","permission":"pull"}],"labels":[{"id":709779088,"url":"https://api.github.com/repos/cilium/cilium/labels/area/CI","name":"area/CI","color":"bfd4f2","default":false},{"id":300384441,"url":"https://api.github.com/repos/cilium/cilium/labels/kind/enhancement","name":"kind/enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/3059/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/3059/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/3059/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/1dde554e0d56820d853768caac500eb10b3d9c0d","head":{"label":"eloycoto:ginkgoExt","ref":"ginkgoExt","sha":"1dde554e0d56820d853768caac500eb10b3d9c0d","user":{"login":"eloycoto","id":868013,"avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"repo":{"id":93093102,"name":"cilium","full_name":"eloycoto/cilium","owner":{"login":"eloycoto","id":868013,"avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eloycoto/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":true,"url":"https://api.github.com/repos/eloycoto/cilium","forks_url":"https://api.github.com/repos/eloycoto/cilium/forks","keys_url":"https://api.github.com/repos/eloycoto/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eloycoto/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eloycoto/cilium/teams","hooks_url":"https://api.github.com/repos/eloycoto/cilium/hooks","issue_events_url":"https://api.github.com/repos/eloycoto/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/eloycoto/cilium/events","assignees_url":"https://api.github.com/repos/eloycoto/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/eloycoto/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/eloycoto/cilium/tags","blobs_url":"https://api.github.com/repos/eloycoto/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eloycoto/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eloycoto/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/eloycoto/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eloycoto/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/eloycoto/cilium/languages","stargazers_url":"https://api.github.com/repos/eloycoto/cilium/stargazers","contributors_url":"https://api.github.com/repos/eloycoto/cilium/contributors","subscribers_url":"https://api.github.com/repos/eloycoto/cilium/subscribers","subscription_url":"https://api.github.com/repos/eloycoto/cilium/subscription","commits_url":"https://api.github.com/repos/eloycoto/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/eloycoto/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/eloycoto/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/eloycoto/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/eloycoto/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/eloycoto/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eloycoto/cilium/merges","archive_url":"https://api.github.com/repos/eloycoto/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eloycoto/cilium/downloads","issues_url":"https://api.github.com/repos/eloycoto/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/eloycoto/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/eloycoto/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/eloycoto/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eloycoto/cilium/labels{/name}","releases_url":"https://api.github.com/repos/eloycoto/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/eloycoto/cilium/deployments","created_at":"2017-06-01T19:40:10Z","updated_at":"2017-06-01T19:40:13Z","pushed_at":"2018-03-08T14:31:31Z","git_url":"git://github.com/eloycoto/cilium.git","ssh_url":"git@github.com:eloycoto/cilium.git","clone_url":"https://github.com/eloycoto/cilium.git","svn_url":"https://github.com/eloycoto/cilium","homepage":"","size":64546,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"c7ba09632af954b3f386589b527ad0e90554c97d","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"API-aware Networking and Security for Containers based on BPF","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-03-08T12:29:37Z","pushed_at":"2018-03-08T14:34:22Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":42067,"stargazers_count":1543,"watchers_count":1543,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"archived":false,"open_issues_count":386,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":153,"open_issues":386,"watchers":1543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3059"},"html":{"href":"https://github.com/cilium/cilium/pull/3059"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/3059"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/3059/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3059/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3059/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/1dde554e0d56820d853768caac500eb10b3d9c0d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}