{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/182691327","pull_request_review_id":113536339,"id":182691327,"diff_hunk":"@@ -2911,7 +2930,8 @@ void CipherBase::SetAuthTag(const FunctionCallbackInfo<Value>& args) {\n   unsigned int tag_len = Buffer::Length(args[0]);\n   const int mode = EVP_CIPHER_CTX_mode(cipher->ctx_);\n   if (mode == EVP_CIPH_GCM_MODE) {","path":"src/node_crypto.cc","position":57,"original_position":57,"commit_id":"c2f18700afe83e0ac30d410e4d3b1b8cfed024f9","original_commit_id":"c2f18700afe83e0ac30d410e4d3b1b8cfed024f9","user":{"login":"tniessen","id":3109072,"avatar_url":"https://avatars3.githubusercontent.com/u/3109072?v=4","gravatar_id":"","url":"https://api.github.com/users/tniessen","html_url":"https://github.com/tniessen","followers_url":"https://api.github.com/users/tniessen/followers","following_url":"https://api.github.com/users/tniessen/following{/other_user}","gists_url":"https://api.github.com/users/tniessen/gists{/gist_id}","starred_url":"https://api.github.com/users/tniessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tniessen/subscriptions","organizations_url":"https://api.github.com/users/tniessen/orgs","repos_url":"https://api.github.com/users/tniessen/repos","events_url":"https://api.github.com/users/tniessen/events{/privacy}","received_events_url":"https://api.github.com/users/tniessen/received_events","type":"User","site_admin":false},"body":"@yhwang This is basically the same problem as we discussed in #20040. I will fix it in that PR so this can remain semver-minor.","created_at":"2018-04-19T09:46:09Z","updated_at":"2018-04-19T09:46:09Z","html_url":"https://github.com/nodejs/node/pull/20039#discussion_r182691327","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/20039","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/182691327"},"html":{"href":"https://github.com/nodejs/node/pull/20039#discussion_r182691327"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/20039"}},"in_reply_to_id":182518081},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20039","id":181674586,"html_url":"https://github.com/nodejs/node/pull/20039","diff_url":"https://github.com/nodejs/node/pull/20039.diff","patch_url":"https://github.com/nodejs/node/pull/20039.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/20039","number":20039,"state":"open","locked":false,"title":"crypto: allow to restrict valid GCM tag length","user":{"login":"tniessen","id":3109072,"avatar_url":"https://avatars3.githubusercontent.com/u/3109072?v=4","gravatar_id":"","url":"https://api.github.com/users/tniessen","html_url":"https://github.com/tniessen","followers_url":"https://api.github.com/users/tniessen/followers","following_url":"https://api.github.com/users/tniessen/following{/other_user}","gists_url":"https://api.github.com/users/tniessen/gists{/gist_id}","starred_url":"https://api.github.com/users/tniessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tniessen/subscriptions","organizations_url":"https://api.github.com/users/tniessen/orgs","repos_url":"https://api.github.com/users/tniessen/repos","events_url":"https://api.github.com/users/tniessen/events{/privacy}","received_events_url":"https://api.github.com/users/tniessen/received_events","type":"User","site_admin":false},"body":"This change allows users to restrict accepted GCM authentication tag lengths to a single value as proposed in https://github.com/nodejs/node/issues/17523#issuecomment-359395838. This relies on the API changes introduced in https://github.com/nodejs/node/pull/18138.\r\n\r\nFixes: https://github.com/nodejs/node/issues/17523\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-04-15T00:52:07Z","updated_at":"2018-04-19T09:46:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a480d6ae327954a9834d744eff485f34e8baa023","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars0.githubusercontent.com/u/275871?v=4","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":155267357,"url":"https://api.github.com/repos/nodejs/node/labels/crypto","name":"crypto","color":"009800","default":false},{"id":311670452,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"eb6420","default":false},{"id":364533783,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"c2e0c6","default":false},{"id":575600232,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v8.x","name":"dont-land-on-v8.x","color":"1d76db","default":false},{"id":744829308,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v9.x","name":"dont-land-on-v9.x","color":"0e8a16","default":false},{"id":169485478,"url":"https://api.github.com/repos/nodejs/node/labels/semver-minor","name":"semver-minor","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/20039/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/20039/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20039/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/c2f18700afe83e0ac30d410e4d3b1b8cfed024f9","head":{"label":"tniessen:crypto-gcm-custom-tag-len","ref":"crypto-gcm-custom-tag-len","sha":"c2f18700afe83e0ac30d410e4d3b1b8cfed024f9","user":{"login":"tniessen","id":3109072,"avatar_url":"https://avatars3.githubusercontent.com/u/3109072?v=4","gravatar_id":"","url":"https://api.github.com/users/tniessen","html_url":"https://github.com/tniessen","followers_url":"https://api.github.com/users/tniessen/followers","following_url":"https://api.github.com/users/tniessen/following{/other_user}","gists_url":"https://api.github.com/users/tniessen/gists{/gist_id}","starred_url":"https://api.github.com/users/tniessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tniessen/subscriptions","organizations_url":"https://api.github.com/users/tniessen/orgs","repos_url":"https://api.github.com/users/tniessen/repos","events_url":"https://api.github.com/users/tniessen/events{/privacy}","received_events_url":"https://api.github.com/users/tniessen/received_events","type":"User","site_admin":false},"repo":{"id":82696757,"name":"node","full_name":"tniessen/node","owner":{"login":"tniessen","id":3109072,"avatar_url":"https://avatars3.githubusercontent.com/u/3109072?v=4","gravatar_id":"","url":"https://api.github.com/users/tniessen","html_url":"https://github.com/tniessen","followers_url":"https://api.github.com/users/tniessen/followers","following_url":"https://api.github.com/users/tniessen/following{/other_user}","gists_url":"https://api.github.com/users/tniessen/gists{/gist_id}","starred_url":"https://api.github.com/users/tniessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tniessen/subscriptions","organizations_url":"https://api.github.com/users/tniessen/orgs","repos_url":"https://api.github.com/users/tniessen/repos","events_url":"https://api.github.com/users/tniessen/events{/privacy}","received_events_url":"https://api.github.com/users/tniessen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tniessen/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/tniessen/node","forks_url":"https://api.github.com/repos/tniessen/node/forks","keys_url":"https://api.github.com/repos/tniessen/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tniessen/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tniessen/node/teams","hooks_url":"https://api.github.com/repos/tniessen/node/hooks","issue_events_url":"https://api.github.com/repos/tniessen/node/issues/events{/number}","events_url":"https://api.github.com/repos/tniessen/node/events","assignees_url":"https://api.github.com/repos/tniessen/node/assignees{/user}","branches_url":"https://api.github.com/repos/tniessen/node/branches{/branch}","tags_url":"https://api.github.com/repos/tniessen/node/tags","blobs_url":"https://api.github.com/repos/tniessen/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tniessen/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tniessen/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/tniessen/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tniessen/node/statuses/{sha}","languages_url":"https://api.github.com/repos/tniessen/node/languages","stargazers_url":"https://api.github.com/repos/tniessen/node/stargazers","contributors_url":"https://api.github.com/repos/tniessen/node/contributors","subscribers_url":"https://api.github.com/repos/tniessen/node/subscribers","subscription_url":"https://api.github.com/repos/tniessen/node/subscription","commits_url":"https://api.github.com/repos/tniessen/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/tniessen/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/tniessen/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/tniessen/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/tniessen/node/contents/{+path}","compare_url":"https://api.github.com/repos/tniessen/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tniessen/node/merges","archive_url":"https://api.github.com/repos/tniessen/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tniessen/node/downloads","issues_url":"https://api.github.com/repos/tniessen/node/issues{/number}","pulls_url":"https://api.github.com/repos/tniessen/node/pulls{/number}","milestones_url":"https://api.github.com/repos/tniessen/node/milestones{/number}","notifications_url":"https://api.github.com/repos/tniessen/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tniessen/node/labels{/name}","releases_url":"https://api.github.com/repos/tniessen/node/releases{/id}","deployments_url":"https://api.github.com/repos/tniessen/node/deployments","created_at":"2017-02-21T15:39:16Z","updated_at":"2018-04-11T12:30:32Z","pushed_at":"2018-04-15T01:11:11Z","git_url":"git://github.com/tniessen/node.git","ssh_url":"git@github.com:tniessen/node.git","clone_url":"https://github.com/tniessen/node.git","svn_url":"https://github.com/tniessen/node","homepage":"https://nodejs.org","size":370469,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"715d7f31b384723b1fc4691cfd54a3e6a1a56bb8","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-04-19T09:36:06Z","pushed_at":"2018-04-19T09:15:47Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":373854,"stargazers_count":47772,"watchers_count":47772,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10057,"mirror_url":null,"archived":false,"open_issues_count":737,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10057,"open_issues":737,"watchers":47772,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/20039"},"html":{"href":"https://github.com/nodejs/node/pull/20039"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/20039"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/20039/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/20039/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/20039/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/c2f18700afe83e0ac30d410e4d3b1b8cfed024f9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tniessen"}}