{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/python_mozetl/issues/282","repository_url":"https://api.github.com/repos/mozilla/python_mozetl","labels_url":"https://api.github.com/repos/mozilla/python_mozetl/issues/282/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/python_mozetl/issues/282/comments","events_url":"https://api.github.com/repos/mozilla/python_mozetl/issues/282/events","html_url":"https://github.com/mozilla/python_mozetl/pull/282","id":393192264,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjg2NDQz","number":282,"title":"Add Python 3 support ","user":{"login":"acmiyaguchi","id":3304040,"node_id":"MDQ6VXNlcjMzMDQwNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3304040?v=4","gravatar_id":"","url":"https://api.github.com/users/acmiyaguchi","html_url":"https://github.com/acmiyaguchi","followers_url":"https://api.github.com/users/acmiyaguchi/followers","following_url":"https://api.github.com/users/acmiyaguchi/following{/other_user}","gists_url":"https://api.github.com/users/acmiyaguchi/gists{/gist_id}","starred_url":"https://api.github.com/users/acmiyaguchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acmiyaguchi/subscriptions","organizations_url":"https://api.github.com/users/acmiyaguchi/orgs","repos_url":"https://api.github.com/users/acmiyaguchi/repos","events_url":"https://api.github.com/users/acmiyaguchi/events{/privacy}","received_events_url":"https://api.github.com/users/acmiyaguchi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-20T20:02:46Z","updated_at":"2018-12-21T00:44:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mozilla/python_mozetl/pulls/282","html_url":"https://github.com/mozilla/python_mozetl/pull/282","diff_url":"https://github.com/mozilla/python_mozetl/pull/282.diff","patch_url":"https://github.com/mozilla/python_mozetl/pull/282.patch"},"body":"This fixes #273, allowing for python 3 in the project.\r\n\r\n* Update CI to include py27/py36 in tox and circleci\r\n* Format the code base with black by fixing the minimum amount of syntax incompatibility via 2to3\r\n* Format using 2to3 + black\r\n* Individually fix each of the broken tests in CI\r\n* Add black as one of the linting commands\r\n\r\nI tried to make the manual changes as minimal as possible. I still need to run the jobs within EMR/Databricks to ensure that jobs are running correctly.\r\n\r\nFinally, there's probably some need to add better dependency management and packaging. I've looked at some options:\r\n\r\n* pip-tools and requirements.txt\r\n* pipenv and Pipfile.lock\r\n* poetry and pyproject.toml\r\n\r\nThey all share a common weakness of not supporting both major versions of Python. It seems best to wean off py27 first and then pin dependencies to py36."},"comment":{"url":"https://api.github.com/repos/mozilla/python_mozetl/issues/comments/449189732","html_url":"https://github.com/mozilla/python_mozetl/pull/282#issuecomment-449189732","issue_url":"https://api.github.com/repos/mozilla/python_mozetl/issues/282","id":449189732,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTE4OTczMg==","user":{"login":"relud","id":433717,"node_id":"MDQ6VXNlcjQzMzcxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/433717?v=4","gravatar_id":"","url":"https://api.github.com/users/relud","html_url":"https://github.com/relud","followers_url":"https://api.github.com/users/relud/followers","following_url":"https://api.github.com/users/relud/following{/other_user}","gists_url":"https://api.github.com/users/relud/gists{/gist_id}","starred_url":"https://api.github.com/users/relud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relud/subscriptions","organizations_url":"https://api.github.com/users/relud/orgs","repos_url":"https://api.github.com/users/relud/repos","events_url":"https://api.github.com/users/relud/events{/privacy}","received_events_url":"https://api.github.com/users/relud/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T00:44:22Z","updated_at":"2018-12-21T00:44:22Z","author_association":"CONTRIBUTOR","body":"> I'd like to have black earlier in the process as opposed to later, so I can run it after each commit in the required fixes.\r\n\r\nokay, just be aware that black is the change that will take me the longest to review by far. 4K lines is going to take me days to find the time just to read it. Everything else combined I'm comfortable getting reviewed in <1 day."}}
{"actor":{"display_login":"relud"}}