{"action":"created","comment":{"url":"https://api.github.com/repos/cafejojo/schaapi/pulls/comments/190484584","pull_request_review_id":122867817,"id":190484584,"diff_hunk":"@@ -0,0 +1,36 @@\n+package org.cafejojo.schaapi.pipeline.projectcompiler.javajar\n+\n+import org.cafejojo.schaapi.models.Project\n+import org.cafejojo.schaapi.models.project.java.JavaJarProject\n+import org.cafejojo.schaapi.pipeline.ProjectCompiler\n+import java.io.FileInputStream\n+import java.util.jar.JarInputStream\n+\n+/**\n+ * Compiles a Java project consisting of a single JAR.","path":"modules/pipeline/java-jar-project-compiler/src/main/kotlin/org/cafejojo/schaapi/pipeline/projectcompiler/javajar/ProjectCompiler.kt","position":10,"original_position":10,"commit_id":"7fd62a989b3dbef2ecd5ff0b47fc217611f20058","original_commit_id":"7fd62a989b3dbef2ecd5ff0b47fc217611f20058","user":{"login":"gandreadis","id":5272244,"avatar_url":"https://avatars3.githubusercontent.com/u/5272244?v=4","gravatar_id":"","url":"https://api.github.com/users/gandreadis","html_url":"https://github.com/gandreadis","followers_url":"https://api.github.com/users/gandreadis/followers","following_url":"https://api.github.com/users/gandreadis/following{/other_user}","gists_url":"https://api.github.com/users/gandreadis/gists{/gist_id}","starred_url":"https://api.github.com/users/gandreadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandreadis/subscriptions","organizations_url":"https://api.github.com/users/gandreadis/orgs","repos_url":"https://api.github.com/users/gandreadis/repos","events_url":"https://api.github.com/users/gandreadis/events{/privacy}","received_events_url":"https://api.github.com/users/gandreadis/received_events","type":"User","site_admin":false},"body":"I agree that it doesn't really compile, but on the other hand, the whole `ProjectCompiler` name of the interface is confusing / not applicable to this module (as it does not actually compile but rather analyse). ","created_at":"2018-05-24T07:10:07Z","updated_at":"2018-05-24T07:10:07Z","html_url":"https://github.com/cafejojo/schaapi/pull/120#discussion_r190484584","pull_request_url":"https://api.github.com/repos/cafejojo/schaapi/pulls/120","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cafejojo/schaapi/pulls/comments/190484584"},"html":{"href":"https://github.com/cafejojo/schaapi/pull/120#discussion_r190484584"},"pull_request":{"href":"https://api.github.com/repos/cafejojo/schaapi/pulls/120"}},"in_reply_to_id":190410208},"pull_request":{"url":"https://api.github.com/repos/cafejojo/schaapi/pulls/120","id":190084034,"html_url":"https://github.com/cafejojo/schaapi/pull/120","diff_url":"https://github.com/cafejojo/schaapi/pull/120.diff","patch_url":"https://github.com/cafejojo/schaapi/pull/120.patch","issue_url":"https://api.github.com/repos/cafejojo/schaapi/issues/120","number":120,"state":"open","locked":false,"title":"Add JAR project compiler","user":{"login":"gandreadis","id":5272244,"avatar_url":"https://avatars3.githubusercontent.com/u/5272244?v=4","gravatar_id":"","url":"https://api.github.com/users/gandreadis","html_url":"https://github.com/gandreadis","followers_url":"https://api.github.com/users/gandreadis/followers","following_url":"https://api.github.com/users/gandreadis/following{/other_user}","gists_url":"https://api.github.com/users/gandreadis/gists{/gist_id}","starred_url":"https://api.github.com/users/gandreadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandreadis/subscriptions","organizations_url":"https://api.github.com/users/gandreadis/orgs","repos_url":"https://api.github.com/users/gandreadis/repos","events_url":"https://api.github.com/users/gandreadis/events{/privacy}","received_events_url":"https://api.github.com/users/gandreadis/received_events","type":"User","site_admin":false},"body":"## Builds on top of #119\r\n\r\nFor better reviewing, review [Add JAR project compiler functionality](https://github.com/cafejojo/schaapi/commit/7fd62a989b3dbef2ecd5ff0b47fc217611f20058) and newer.\r\n\r\n-----\r\n\r\nAdds a `ProjectCompiler` pipeline stage implementation for JAR projects. The compiler walks through the list of files in the JAR and, if they are class files, adds their name to the list of fully qualified class names.","created_at":"2018-05-23T19:42:07Z","updated_at":"2018-05-24T07:10:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb1309f44ae93e1878e358c44310dd49a7a6e609","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":924632477,"url":"https://api.github.com/repos/cafejojo/schaapi/labels/DO%20NOT%20MERGE","name":"DO NOT MERGE","color":"d93f0b","default":false},{"id":913454595,"url":"https://api.github.com/repos/cafejojo/schaapi/labels/enhancement","name":"enhancement","color":"9dbdf9","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/cafejojo/schaapi/pulls/120/commits","review_comments_url":"https://api.github.com/repos/cafejojo/schaapi/pulls/120/comments","review_comment_url":"https://api.github.com/repos/cafejojo/schaapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cafejojo/schaapi/issues/120/comments","statuses_url":"https://api.github.com/repos/cafejojo/schaapi/statuses/7fd62a989b3dbef2ecd5ff0b47fc217611f20058","head":{"label":"cafejojo:jar-project-compiler","ref":"jar-project-compiler","sha":"7fd62a989b3dbef2ecd5ff0b47fc217611f20058","user":{"login":"cafejojo","id":38208512,"avatar_url":"https://avatars3.githubusercontent.com/u/38208512?v=4","gravatar_id":"","url":"https://api.github.com/users/cafejojo","html_url":"https://github.com/cafejojo","followers_url":"https://api.github.com/users/cafejojo/followers","following_url":"https://api.github.com/users/cafejojo/following{/other_user}","gists_url":"https://api.github.com/users/cafejojo/gists{/gist_id}","starred_url":"https://api.github.com/users/cafejojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafejojo/subscriptions","organizations_url":"https://api.github.com/users/cafejojo/orgs","repos_url":"https://api.github.com/users/cafejojo/repos","events_url":"https://api.github.com/users/cafejojo/events{/privacy}","received_events_url":"https://api.github.com/users/cafejojo/received_events","type":"Organization","site_admin":false},"repo":{"id":130986816,"name":"schaapi","full_name":"cafejojo/schaapi","owner":{"login":"cafejojo","id":38208512,"avatar_url":"https://avatars3.githubusercontent.com/u/38208512?v=4","gravatar_id":"","url":"https://api.github.com/users/cafejojo","html_url":"https://github.com/cafejojo","followers_url":"https://api.github.com/users/cafejojo/followers","following_url":"https://api.github.com/users/cafejojo/following{/other_user}","gists_url":"https://api.github.com/users/cafejojo/gists{/gist_id}","starred_url":"https://api.github.com/users/cafejojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafejojo/subscriptions","organizations_url":"https://api.github.com/users/cafejojo/orgs","repos_url":"https://api.github.com/users/cafejojo/repos","events_url":"https://api.github.com/users/cafejojo/events{/privacy}","received_events_url":"https://api.github.com/users/cafejojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cafejojo/schaapi","description":"🐑 Safe Changes for APIs","fork":false,"url":"https://api.github.com/repos/cafejojo/schaapi","forks_url":"https://api.github.com/repos/cafejojo/schaapi/forks","keys_url":"https://api.github.com/repos/cafejojo/schaapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cafejojo/schaapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cafejojo/schaapi/teams","hooks_url":"https://api.github.com/repos/cafejojo/schaapi/hooks","issue_events_url":"https://api.github.com/repos/cafejojo/schaapi/issues/events{/number}","events_url":"https://api.github.com/repos/cafejojo/schaapi/events","assignees_url":"https://api.github.com/repos/cafejojo/schaapi/assignees{/user}","branches_url":"https://api.github.com/repos/cafejojo/schaapi/branches{/branch}","tags_url":"https://api.github.com/repos/cafejojo/schaapi/tags","blobs_url":"https://api.github.com/repos/cafejojo/schaapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cafejojo/schaapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cafejojo/schaapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cafejojo/schaapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cafejojo/schaapi/statuses/{sha}","languages_url":"https://api.github.com/repos/cafejojo/schaapi/languages","stargazers_url":"https://api.github.com/repos/cafejojo/schaapi/stargazers","contributors_url":"https://api.github.com/repos/cafejojo/schaapi/contributors","subscribers_url":"https://api.github.com/repos/cafejojo/schaapi/subscribers","subscription_url":"https://api.github.com/repos/cafejojo/schaapi/subscription","commits_url":"https://api.github.com/repos/cafejojo/schaapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cafejojo/schaapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cafejojo/schaapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cafejojo/schaapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cafejojo/schaapi/contents/{+path}","compare_url":"https://api.github.com/repos/cafejojo/schaapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cafejojo/schaapi/merges","archive_url":"https://api.github.com/repos/cafejojo/schaapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cafejojo/schaapi/downloads","issues_url":"https://api.github.com/repos/cafejojo/schaapi/issues{/number}","pulls_url":"https://api.github.com/repos/cafejojo/schaapi/pulls{/number}","milestones_url":"https://api.github.com/repos/cafejojo/schaapi/milestones{/number}","notifications_url":"https://api.github.com/repos/cafejojo/schaapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cafejojo/schaapi/labels{/name}","releases_url":"https://api.github.com/repos/cafejojo/schaapi/releases{/id}","deployments_url":"https://api.github.com/repos/cafejojo/schaapi/deployments","created_at":"2018-04-25T10:00:57Z","updated_at":"2018-05-23T14:20:33Z","pushed_at":"2018-05-24T07:06:43Z","git_url":"git://github.com/cafejojo/schaapi.git","ssh_url":"git@github.com:cafejojo/schaapi.git","clone_url":"https://github.com/cafejojo/schaapi.git","svn_url":"https://github.com/cafejojo/schaapi","homepage":"","size":9772,"stargazers_count":5,"watchers_count":5,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":9,"watchers":5,"default_branch":"master"}},"base":{"label":"cafejojo:master","ref":"master","sha":"5b76632cf18ff85eb8c34670d96c9d14246f9c26","user":{"login":"cafejojo","id":38208512,"avatar_url":"https://avatars3.githubusercontent.com/u/38208512?v=4","gravatar_id":"","url":"https://api.github.com/users/cafejojo","html_url":"https://github.com/cafejojo","followers_url":"https://api.github.com/users/cafejojo/followers","following_url":"https://api.github.com/users/cafejojo/following{/other_user}","gists_url":"https://api.github.com/users/cafejojo/gists{/gist_id}","starred_url":"https://api.github.com/users/cafejojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafejojo/subscriptions","organizations_url":"https://api.github.com/users/cafejojo/orgs","repos_url":"https://api.github.com/users/cafejojo/repos","events_url":"https://api.github.com/users/cafejojo/events{/privacy}","received_events_url":"https://api.github.com/users/cafejojo/received_events","type":"Organization","site_admin":false},"repo":{"id":130986816,"name":"schaapi","full_name":"cafejojo/schaapi","owner":{"login":"cafejojo","id":38208512,"avatar_url":"https://avatars3.githubusercontent.com/u/38208512?v=4","gravatar_id":"","url":"https://api.github.com/users/cafejojo","html_url":"https://github.com/cafejojo","followers_url":"https://api.github.com/users/cafejojo/followers","following_url":"https://api.github.com/users/cafejojo/following{/other_user}","gists_url":"https://api.github.com/users/cafejojo/gists{/gist_id}","starred_url":"https://api.github.com/users/cafejojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafejojo/subscriptions","organizations_url":"https://api.github.com/users/cafejojo/orgs","repos_url":"https://api.github.com/users/cafejojo/repos","events_url":"https://api.github.com/users/cafejojo/events{/privacy}","received_events_url":"https://api.github.com/users/cafejojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cafejojo/schaapi","description":"🐑 Safe Changes for APIs","fork":false,"url":"https://api.github.com/repos/cafejojo/schaapi","forks_url":"https://api.github.com/repos/cafejojo/schaapi/forks","keys_url":"https://api.github.com/repos/cafejojo/schaapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cafejojo/schaapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cafejojo/schaapi/teams","hooks_url":"https://api.github.com/repos/cafejojo/schaapi/hooks","issue_events_url":"https://api.github.com/repos/cafejojo/schaapi/issues/events{/number}","events_url":"https://api.github.com/repos/cafejojo/schaapi/events","assignees_url":"https://api.github.com/repos/cafejojo/schaapi/assignees{/user}","branches_url":"https://api.github.com/repos/cafejojo/schaapi/branches{/branch}","tags_url":"https://api.github.com/repos/cafejojo/schaapi/tags","blobs_url":"https://api.github.com/repos/cafejojo/schaapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cafejojo/schaapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cafejojo/schaapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cafejojo/schaapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cafejojo/schaapi/statuses/{sha}","languages_url":"https://api.github.com/repos/cafejojo/schaapi/languages","stargazers_url":"https://api.github.com/repos/cafejojo/schaapi/stargazers","contributors_url":"https://api.github.com/repos/cafejojo/schaapi/contributors","subscribers_url":"https://api.github.com/repos/cafejojo/schaapi/subscribers","subscription_url":"https://api.github.com/repos/cafejojo/schaapi/subscription","commits_url":"https://api.github.com/repos/cafejojo/schaapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cafejojo/schaapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cafejojo/schaapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cafejojo/schaapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cafejojo/schaapi/contents/{+path}","compare_url":"https://api.github.com/repos/cafejojo/schaapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cafejojo/schaapi/merges","archive_url":"https://api.github.com/repos/cafejojo/schaapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cafejojo/schaapi/downloads","issues_url":"https://api.github.com/repos/cafejojo/schaapi/issues{/number}","pulls_url":"https://api.github.com/repos/cafejojo/schaapi/pulls{/number}","milestones_url":"https://api.github.com/repos/cafejojo/schaapi/milestones{/number}","notifications_url":"https://api.github.com/repos/cafejojo/schaapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cafejojo/schaapi/labels{/name}","releases_url":"https://api.github.com/repos/cafejojo/schaapi/releases{/id}","deployments_url":"https://api.github.com/repos/cafejojo/schaapi/deployments","created_at":"2018-04-25T10:00:57Z","updated_at":"2018-05-23T14:20:33Z","pushed_at":"2018-05-24T07:06:43Z","git_url":"git://github.com/cafejojo/schaapi.git","ssh_url":"git@github.com:cafejojo/schaapi.git","clone_url":"https://github.com/cafejojo/schaapi.git","svn_url":"https://github.com/cafejojo/schaapi","homepage":"","size":9772,"stargazers_count":5,"watchers_count":5,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":9,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cafejojo/schaapi/pulls/120"},"html":{"href":"https://github.com/cafejojo/schaapi/pull/120"},"issue":{"href":"https://api.github.com/repos/cafejojo/schaapi/issues/120"},"comments":{"href":"https://api.github.com/repos/cafejojo/schaapi/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/cafejojo/schaapi/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/cafejojo/schaapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cafejojo/schaapi/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/cafejojo/schaapi/statuses/7fd62a989b3dbef2ecd5ff0b47fc217611f20058"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gandreadis"}}