{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/15797","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/15797/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/15797/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/15797/events","html_url":"https://github.com/nodejs/node/issues/15797","id":263387419,"number":15797,"title":"fs - add copyDirectory function","user":{"login":"metabench","id":1186693,"avatar_url":"https://avatars0.githubusercontent.com/u/1186693?v=4","gravatar_id":"","url":"https://api.github.com/users/metabench","html_url":"https://github.com/metabench","followers_url":"https://api.github.com/users/metabench/followers","following_url":"https://api.github.com/users/metabench/following{/other_user}","gists_url":"https://api.github.com/users/metabench/gists{/gist_id}","starred_url":"https://api.github.com/users/metabench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabench/subscriptions","organizations_url":"https://api.github.com/users/metabench/orgs","repos_url":"https://api.github.com/users/metabench/repos","events_url":"https://api.github.com/users/metabench/events{/privacy}","received_events_url":"https://api.github.com/users/metabench/received_events","type":"User","site_admin":false},"labels":[{"id":207445406,"url":"https://api.github.com/repos/nodejs/node/labels/feature%20request","name":"feature request","color":"0D7BDE","default":false},{"id":155435785,"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-06T09:33:47Z","updated_at":"2018-05-07T19:39:40Z","closed_at":"2017-10-06T12:37:18Z","author_association":"NONE","body":"A `copyFolder` alias would be useful to have. Though `directory` was the original term and seems more technical, many coders are familiar with the term `folder` and it's quicker to type, and makes for slightly more compact source code.\r\n\r\nI suppose there are some difficulties with `fs.copyDirectory` as it was not included in 8.5.0 alongside `fs.copyFile`. \r\n\r\nI also suggest the option for keeping the original timestamps, like with the issue https://github.com/nodejs/node/issues/15793, which applies to `fs.copyFile`.\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/387179154","html_url":"https://github.com/nodejs/node/issues/15797#issuecomment-387179154","issue_url":"https://api.github.com/repos/nodejs/node/issues/15797","id":387179154,"user":{"login":"metabench","id":1186693,"avatar_url":"https://avatars0.githubusercontent.com/u/1186693?v=4","gravatar_id":"","url":"https://api.github.com/users/metabench","html_url":"https://github.com/metabench","followers_url":"https://api.github.com/users/metabench/followers","following_url":"https://api.github.com/users/metabench/following{/other_user}","gists_url":"https://api.github.com/users/metabench/gists{/gist_id}","starred_url":"https://api.github.com/users/metabench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabench/subscriptions","organizations_url":"https://api.github.com/users/metabench/orgs","repos_url":"https://api.github.com/users/metabench/repos","events_url":"https://api.github.com/users/metabench/events{/privacy}","received_events_url":"https://api.github.com/users/metabench/received_events","type":"User","site_admin":false},"created_at":"2018-05-07T19:39:39Z","updated_at":"2018-05-07T19:39:39Z","author_association":"NONE","body":"@cjihrig, @mscdex Userland has got more potential for security vulnerabilities. The expectation with the node core is that it has had very thorough security and reliability testing and auditing. There is a lower level of confidence in packages in the npm ecosystem.\r\n\r\nWhile I understand that putting functionality such as this into the node core extends the surface area where things could go wrong in the core, since this was last discussed there have been some more npm/ecosystem problems, so thought that would be a reason to (try to) open this up for discussion again.\r\n\r\nParticularly with code that accesses the file system, it would be easier to ensure (or accurately judge) that a project's code is safe if it uses functionality in the node core rather than userland.\r\n\r\nThere is also the issue of bloat within project dependencies, where overly simple functions (I know that's subjective) are required modules. I understand that the core developers are focused on not making a bloated node core, but by including more functionality within the core (with the code quality and overview standards that come with it), there is less space for some functionality which is repeated across a variety of applications to go wrong."}}
{"actor":{"display_login":"metabench"}}