{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/185342529","pull_request_review_id":116712443,"id":185342529,"diff_hunk":"@@ -79,64 +79,53 @@\n  * <tt>boundary_id</tt> that uniquely identifies which part of the\n  * boundary this face is on. If nothing is specified at creation time,\n  * each boundary face has a zero boundary id and each triangulation\n- * object has an invalid manifold id. On the other hand, the boundary\n+ * object has an flat manifold id. On the other hand, the boundary\n  * id of faces and the manifold id of objects can be set either at\n  * creation time or later by looping over all cells and querying their\n  * faces.\n  *\n- * It is then possible to associate objects describing the geometry to\n- * certain boundary_id values used in a triangulation and to certain\n+ * It is then possible to associate objects describing the geometry to certain\n  * manifold_id values.\n  *\n- * Before version 8.2, the library allowed only boundary faces to\n- * follow a curved geometric description. Since version 8.2 this has\n- * been introduced also for interior faces and cells, and the\n- * boundary_id has been separated from the manifold_id.\n- *\n- * Although the old behavior is still supported, one should use the\n- * boundary indicator only for the physical meaning associated, for\n- * example, to boundary conditions, and revert to manifold_ids to\n- * describe the geometry of the triangulation.\n- *\n- * The behavior of the Triangulation class w.r.t. geometry\n- * descriptions is the following: Triangulation::set_boundary() and\n- * Triangulation::set_manifold() do the exact same thing: they attach\n- * a manifold descriptor to the specified id. The first function\n- * expects a Boundary descriptor (which is a specialization of a\n- * Manifold description) and is provided mainly for backward\n- * compatibility, while the second class expects a Manifold\n- * descriptor. Notice that the Triangulation class only uses the\n- * Manifold interface, and you could describe both the interior and\n- * the boundary of the domain using the same object. The additional\n- * information contained in the Boundary interface is related to the\n- * computation of the exact normals. \n- *\n- * Whenever a new vertex is needed in an object, the Triangulation\n- * queries the manifold_id of the object which needs refinement. If\n- * the manifold_id is set to numbers::invalid_manifold_id, then the\n- * Triangulation queries the boundary_id (if the face is on the\n- * boundary) or the material_id (if the Triangulation is of\n- * codimension one and the object is a cell). If the previous queries\n- * resulted in a number different from numbers::invalid_manifold_id,\n- * then the Triangulation looks whether a previous call to\n- * Triangulation::set_manifold() (or set_boundary()) was performed\n- * with the given id, and if yes, it uses the stored object to obtain\n- * new vertices, otherwise it uses a FlatManifold or StraightBoundary\n- * object.\n- *\n- * @note This behavior is backward compatible to that of deal.II versions\n- * prior to 8.2. If one ignores the manifold_id of an object (i.e., if it has\n- * never been set), by default it is and remains set to\n- * numbers::invalid_manifold_id. In that case, the first query above will\n- * trigger a query to the old style boundary_id. This behavior will be\n- * maintained for a while, but might eventually be changed. The suggested\n- * strategy is to use manifold_ids to describe the geometry, and boundary_ids\n- * to describe boundary conditions.\n- * \n+ * Before version 8.2, the library allowed only boundary faces to follow a\n+ * curved geometric description. Since version 8.2 this has been introduced also\n+ * for interior faces and cells, and the boundary_id has been separated from the\n+ * manifold_id. The former is used to identify the type of boundary conditions\n+ * to apply, while the latter is used to identify the geometry and describe how\n+ * new vertices should be created upon refinement of the mesh, or where high\n+ * order Mapping objects should place their support points on the exact\n+ * geometry.\n+ *\n+ * Since version 9.0 of the library, the boundary_id associated to the boundary\n+ * faces is ignored by Manifold objects, and Manifold descriptors can only be\n+ * attached to manifold ids.\n+ *\n+ * The behavior of the Triangulation class w.r.t. geometry descriptions is the\n+ * following: Triangulation::set_manifold() attaches a manifold descriptor to\n+ * the specified manifold id. The function expects a Manifold descriptor, and\n+ * you could describe both the interior and the boundary of the domain using the\n+ * same object.\n+ *\n+ * Whenever a new vertex is needed in an object, the Triangulation queries the\n+ * manifold_id of the object which needs refinement. If the query resulted in a\n+ * number different from numbers::flat_manifold_id, then the Triangulation looks\n+ * whether a previous call to Triangulation::set_manifold() was performed with\n+ * the given id, and if yes, it uses the stored object to obtain new vertices,\n+ * otherwise it uses a FlatManifold object.\n+ *\n+ * @note This behavior is **not** backward compatible to that of deal.II\n+ * versions prior to 9.0. If one ignores the manifold_id of an object (i.e., if\n+ * it has never been set), by default it is and remains set to\n+ * numbers::flat_manifold_id. In previous versions of the library, the\n+ * boundary_id of the boundary faces would be queried and used in place of the\n+ * manifold_id. If you have old programs that only set boundary ids, you should","path":"doc/doxygen/headers/boundary.h","position":91,"original_position":91,"commit_id":"836090c20f9734e07d8dd67b4550fd72da19f7a8","original_commit_id":"836090c20f9734e07d8dd67b4550fd72da19f7a8","user":{"login":"drwells","id":3917035,"avatar_url":"https://avatars0.githubusercontent.com/u/3917035?v=4","gravatar_id":"","url":"https://api.github.com/users/drwells","html_url":"https://github.com/drwells","followers_url":"https://api.github.com/users/drwells/followers","following_url":"https://api.github.com/users/drwells/following{/other_user}","gists_url":"https://api.github.com/users/drwells/gists{/gist_id}","starred_url":"https://api.github.com/users/drwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwells/subscriptions","organizations_url":"https://api.github.com/users/drwells/orgs","repos_url":"https://api.github.com/users/drwells/repos","events_url":"https://api.github.com/users/drwells/events{/privacy}","received_events_url":"https://api.github.com/users/drwells/received_events","type":"User","site_admin":false},"body":"same thing: if I have read this correctly then it should be plural and not possessive and there should not be an `'`","created_at":"2018-05-01T21:42:51Z","updated_at":"2018-05-01T21:42:51Z","html_url":"https://github.com/dealii/dealii/pull/6416#discussion_r185342529","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/6416","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/185342529"},"html":{"href":"https://github.com/dealii/dealii/pull/6416#discussion_r185342529"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/6416"}},"in_reply_to_id":185315956},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/6416","id":185196114,"html_url":"https://github.com/dealii/dealii/pull/6416","diff_url":"https://github.com/dealii/dealii/pull/6416.diff","patch_url":"https://github.com/dealii/dealii/pull/6416.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/6416","number":6416,"state":"open","locked":false,"title":"Fixed some documentation about boundary and manifold.","user":{"login":"luca-heltai","id":2919756,"avatar_url":"https://avatars1.githubusercontent.com/u/2919756?v=4","gravatar_id":"","url":"https://api.github.com/users/luca-heltai","html_url":"https://github.com/luca-heltai","followers_url":"https://api.github.com/users/luca-heltai/followers","following_url":"https://api.github.com/users/luca-heltai/following{/other_user}","gists_url":"https://api.github.com/users/luca-heltai/gists{/gist_id}","starred_url":"https://api.github.com/users/luca-heltai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luca-heltai/subscriptions","organizations_url":"https://api.github.com/users/luca-heltai/orgs","repos_url":"https://api.github.com/users/luca-heltai/repos","events_url":"https://api.github.com/users/luca-heltai/events{/privacy}","received_events_url":"https://api.github.com/users/luca-heltai/received_events","type":"User","site_admin":false},"body":"Part of #6274","created_at":"2018-05-01T14:56:43Z","updated_at":"2018-05-01T21:42:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c708f4dff95ab1b444964b1cf9181c56d7b32c92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/6416/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/6416/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/6416/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/836090c20f9734e07d8dd67b4550fd72da19f7a8","head":{"label":"luca-heltai:fix-manifold-doc","ref":"fix-manifold-doc","sha":"836090c20f9734e07d8dd67b4550fd72da19f7a8","user":{"login":"luca-heltai","id":2919756,"avatar_url":"https://avatars1.githubusercontent.com/u/2919756?v=4","gravatar_id":"","url":"https://api.github.com/users/luca-heltai","html_url":"https://github.com/luca-heltai","followers_url":"https://api.github.com/users/luca-heltai/followers","following_url":"https://api.github.com/users/luca-heltai/following{/other_user}","gists_url":"https://api.github.com/users/luca-heltai/gists{/gist_id}","starred_url":"https://api.github.com/users/luca-heltai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luca-heltai/subscriptions","organizations_url":"https://api.github.com/users/luca-heltai/orgs","repos_url":"https://api.github.com/users/luca-heltai/repos","events_url":"https://api.github.com/users/luca-heltai/events{/privacy}","received_events_url":"https://api.github.com/users/luca-heltai/received_events","type":"User","site_admin":false},"repo":{"id":22053864,"name":"dealii","full_name":"luca-heltai/dealii","owner":{"login":"luca-heltai","id":2919756,"avatar_url":"https://avatars1.githubusercontent.com/u/2919756?v=4","gravatar_id":"","url":"https://api.github.com/users/luca-heltai","html_url":"https://github.com/luca-heltai","followers_url":"https://api.github.com/users/luca-heltai/followers","following_url":"https://api.github.com/users/luca-heltai/following{/other_user}","gists_url":"https://api.github.com/users/luca-heltai/gists{/gist_id}","starred_url":"https://api.github.com/users/luca-heltai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luca-heltai/subscriptions","organizations_url":"https://api.github.com/users/luca-heltai/orgs","repos_url":"https://api.github.com/users/luca-heltai/repos","events_url":"https://api.github.com/users/luca-heltai/events{/privacy}","received_events_url":"https://api.github.com/users/luca-heltai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luca-heltai/dealii","description":null,"fork":true,"url":"https://api.github.com/repos/luca-heltai/dealii","forks_url":"https://api.github.com/repos/luca-heltai/dealii/forks","keys_url":"https://api.github.com/repos/luca-heltai/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luca-heltai/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luca-heltai/dealii/teams","hooks_url":"https://api.github.com/repos/luca-heltai/dealii/hooks","issue_events_url":"https://api.github.com/repos/luca-heltai/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/luca-heltai/dealii/events","assignees_url":"https://api.github.com/repos/luca-heltai/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/luca-heltai/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/luca-heltai/dealii/tags","blobs_url":"https://api.github.com/repos/luca-heltai/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luca-heltai/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luca-heltai/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/luca-heltai/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luca-heltai/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/luca-heltai/dealii/languages","stargazers_url":"https://api.github.com/repos/luca-heltai/dealii/stargazers","contributors_url":"https://api.github.com/repos/luca-heltai/dealii/contributors","subscribers_url":"https://api.github.com/repos/luca-heltai/dealii/subscribers","subscription_url":"https://api.github.com/repos/luca-heltai/dealii/subscription","commits_url":"https://api.github.com/repos/luca-heltai/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/luca-heltai/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/luca-heltai/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/luca-heltai/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/luca-heltai/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/luca-heltai/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luca-heltai/dealii/merges","archive_url":"https://api.github.com/repos/luca-heltai/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luca-heltai/dealii/downloads","issues_url":"https://api.github.com/repos/luca-heltai/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/luca-heltai/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/luca-heltai/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/luca-heltai/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luca-heltai/dealii/labels{/name}","releases_url":"https://api.github.com/repos/luca-heltai/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/luca-heltai/dealii/deployments","created_at":"2014-07-21T06:17:40Z","updated_at":"2018-04-05T13:27:08Z","pushed_at":"2018-05-01T15:25:56Z","git_url":"git://github.com/luca-heltai/dealii.git","ssh_url":"git@github.com:luca-heltai/dealii.git","clone_url":"https://github.com/luca-heltai/dealii.git","svn_url":"https://github.com/luca-heltai/dealii","homepage":null,"size":187136,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"3b7436af94526aa01d9b097cdb35368bb1b633e6","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2018-05-01T19:55:07Z","pushed_at":"2018-05-01T20:34:30Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":185742,"stargazers_count":322,"watchers_count":322,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":300,"mirror_url":null,"archived":false,"open_issues_count":262,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":300,"open_issues":262,"watchers":322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/6416"},"html":{"href":"https://github.com/dealii/dealii/pull/6416"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/6416"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/6416/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/6416/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/6416/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/836090c20f9734e07d8dd67b4550fd72da19f7a8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"drwells"}}