{"action":"created","issue":{"url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/436","repository_url":"https://api.github.com/repos/ilosuna/mylittleforum","labels_url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/436/labels{/name}","comments_url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/436/comments","events_url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/436/events","html_url":"https://github.com/ilosuna/mylittleforum/issues/436","id":394619931,"node_id":"MDU6SXNzdWUzOTQ2MTk5MzE=","number":436,"title":"uncommon UI-behaviour of radio button groups in the settings panel","user":{"login":"auge8472","id":1734660,"node_id":"MDQ6VXNlcjE3MzQ2NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1734660?v=4","gravatar_id":"","url":"https://api.github.com/users/auge8472","html_url":"https://github.com/auge8472","followers_url":"https://api.github.com/users/auge8472/followers","following_url":"https://api.github.com/users/auge8472/following{/other_user}","gists_url":"https://api.github.com/users/auge8472/gists{/gist_id}","starred_url":"https://api.github.com/users/auge8472/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auge8472/subscriptions","organizations_url":"https://api.github.com/users/auge8472/orgs","repos_url":"https://api.github.com/users/auge8472/repos","events_url":"https://api.github.com/users/auge8472/events{/privacy}","received_events_url":"https://api.github.com/users/auge8472/received_events","type":"User","site_admin":false},"labels":[{"id":453058788,"node_id":"MDU6TGFiZWw0NTMwNTg3ODg=","url":"https://api.github.com/repos/ilosuna/mylittleforum/labels/cleanup","name":"cleanup","color":"f0c000","default":false},{"id":385268913,"node_id":"MDU6TGFiZWwzODUyNjg5MTM=","url":"https://api.github.com/repos/ilosuna/mylittleforum/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-28T11:51:19Z","updated_at":"2018-12-29T13:05:38Z","closed_at":null,"author_association":"COLLABORATOR","body":"I attempt to clean up several forms UI-wise in my own theme. I currently rework the radio button and checkbox groups in the main settings, the spam protection settings and the user profile edit form. There, comparing my with the default theme, I encountered a behaviour, that misled me since years again and again.\r\n\r\nThe not activated otions of a group are (or in case of changes get) grayed out. That makes me think, they are not accessible (not only deactivated/not activated). It makes IMHO sense to (really) toggle the access to a dependent setting like in example the terms of use URL dependent from the checkbox to use the terms-of-use-feature. To be correct, this currently doesn't work because the label of the checkbox gets \"activated\" but the label of the text input for the URL stays \"deactivated\" (grayed out) but is accessible all the time. Same with the data-privacy-statement-settings, which are a copy of the terms-of-use-settings.\r\n\r\nOn the other hand it makes no sense at all to gray out checkboxes or radio buttons and their labels because another checkbox or radio button got checked. It's no problem to remove the CSS-rules for the classes `.active` and `.inactive` but the classes get set via JavaScript independent from that. It's IMHO an unexpected behaviour for forum users and admins because it will not happen in a \"normal\" OS-GUI the elements are borrowed from.\r\n\r\nWe can realise a proper styling with only CSS for the modern browsers that understand CSS3 (pseudo class `:checked` [exists for a more then adequate subset](https://caniuse.com/#feat=css-sel3) of browsers). Old – no, really ancient – browsers will show normal radio button or checkbox groups.\r\n\r\nI propose to remove the feature from the JavaScript ressources and the subtemplates or to rework it to steer dependent form fields. In the latter case it should toggle the disabled-attribute and not the CSS-rules for one or two classes, that does not deactivate the form field but is only a lookalike."},"comment":{"url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/comments/450491925","html_url":"https://github.com/ilosuna/mylittleforum/issues/436#issuecomment-450491925","issue_url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/436","id":450491925,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDQ5MTkyNQ==","user":{"login":"auge8472","id":1734660,"node_id":"MDQ6VXNlcjE3MzQ2NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1734660?v=4","gravatar_id":"","url":"https://api.github.com/users/auge8472","html_url":"https://github.com/auge8472","followers_url":"https://api.github.com/users/auge8472/followers","following_url":"https://api.github.com/users/auge8472/following{/other_user}","gists_url":"https://api.github.com/users/auge8472/gists{/gist_id}","starred_url":"https://api.github.com/users/auge8472/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auge8472/subscriptions","organizations_url":"https://api.github.com/users/auge8472/orgs","repos_url":"https://api.github.com/users/auge8472/repos","events_url":"https://api.github.com/users/auge8472/events{/privacy}","received_events_url":"https://api.github.com/users/auge8472/received_events","type":"User","site_admin":false},"created_at":"2018-12-29T13:05:38Z","updated_at":"2018-12-29T13:05:38Z","author_association":"COLLABORATOR","body":"> I still prefer a new theme - in contrast to pathological changes in admin area.\r\n\r\nACK, but you see, what a mess this is. Wether I nor Lautentiu have a *really* ready theme even I work on it since more than two years (every when and then).\r\n\r\nI also prefer a revolution instead a evolution but tere is dust we have to blow away in so many corners and here and there I come across such dust. Even if we would not solve this instantaneous I have to write it down. Otherwise I would forget it again.\r\n\r\n> Following your proposal: remove the JS part and rework the css rules.\r\n\r\nI found the code in the JS-files and will add a commit."}}
{"actor":{"display_login":"auge8472"}}