{"action":"created","comment":{"url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/comments/209289390","pull_request_review_id":145278881,"id":209289390,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTI4OTM5MA==","diff_hunk":"@@ -1,16 +1,21 @@\n-﻿#region Get-LWVMWareNetworkSwitch\n-function Get-LWVMWareNetworkSwitch\n+﻿#region Get-LWVMwareNetworkSwitch\n+function Get-LWVMwareNetworkSwitch\n {\n     param (\n         [Parameter(Mandatory)]\n         [AutomatedLab.VirtualNetwork[]]$VirtualNetwork\n     )\n-\t\n+\n     Write-LogFunctionEntry\n \n     foreach ($network in $VirtualNetwork)\n     {\n-        $network = Get-VDPortgroup -Name $network.Name\n+        $network = Get-VirtualPortgroup -Name $network.Name -ErrorAction SilentlyContinue\n+\n+        if (-not $network)\n+        {\n+            $network = Get-VDPortgroup -Name $network.Name -ErrorAction SilentlyContinue","path":"AutomatedLabWorker/AutomatedLabVMWareWorkerNetwork.psm1","position":21,"original_position":21,"commit_id":"c51ca5f36666458a429b553f0a1058f3c7cc7f91","original_commit_id":"c51ca5f36666458a429b553f0a1058f3c7cc7f91","user":{"login":"nyanhp","id":19172911,"node_id":"MDQ6VXNlcjE5MTcyOTEx","avatar_url":"https://avatars2.githubusercontent.com/u/19172911?v=4","gravatar_id":"","url":"https://api.github.com/users/nyanhp","html_url":"https://github.com/nyanhp","followers_url":"https://api.github.com/users/nyanhp/followers","following_url":"https://api.github.com/users/nyanhp/following{/other_user}","gists_url":"https://api.github.com/users/nyanhp/gists{/gist_id}","starred_url":"https://api.github.com/users/nyanhp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyanhp/subscriptions","organizations_url":"https://api.github.com/users/nyanhp/orgs","repos_url":"https://api.github.com/users/nyanhp/repos","events_url":"https://api.github.com/users/nyanhp/events{/privacy}","received_events_url":"https://api.github.com/users/nyanhp/received_events","type":"User","site_admin":false},"body":"Is there a difference between Get-VirtualPortGroup and Get-VDPortGroup? For consistency, I would suggest using the same cmdlet both times unless they behave differently.","created_at":"2018-08-10T15:01:16Z","updated_at":"2018-08-10T15:04:11Z","html_url":"https://github.com/AutomatedLab/AutomatedLab/pull/427#discussion_r209289390","pull_request_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/427","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/comments/209289390"},"html":{"href":"https://github.com/AutomatedLab/AutomatedLab/pull/427#discussion_r209289390"},"pull_request":{"href":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/427"}}},"pull_request":{"url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/427","id":207006288,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDA2Mjg4","html_url":"https://github.com/AutomatedLab/AutomatedLab/pull/427","diff_url":"https://github.com/AutomatedLab/AutomatedLab/pull/427.diff","patch_url":"https://github.com/AutomatedLab/AutomatedLab/pull/427.patch","issue_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/issues/427","number":427,"state":"open","locked":false,"title":"implement improvements regarding VMware support","user":{"login":"carfesh","id":16491101,"node_id":"MDQ6VXNlcjE2NDkxMTAx","avatar_url":"https://avatars3.githubusercontent.com/u/16491101?v=4","gravatar_id":"","url":"https://api.github.com/users/carfesh","html_url":"https://github.com/carfesh","followers_url":"https://api.github.com/users/carfesh/followers","following_url":"https://api.github.com/users/carfesh/following{/other_user}","gists_url":"https://api.github.com/users/carfesh/gists{/gist_id}","starred_url":"https://api.github.com/users/carfesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carfesh/subscriptions","organizations_url":"https://api.github.com/users/carfesh/orgs","repos_url":"https://api.github.com/users/carfesh/repos","events_url":"https://api.github.com/users/carfesh/events{/privacy}","received_events_url":"https://api.github.com/users/carfesh/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nas discussed with @raandree I'd like to continue the work @Jawz84 has started to improve VMware support in this pull request.\r\n\r\nFor the time being development is still ongoing, so IMO the request is not yet a candidate for merging - I hope that there are no changes in the develop branch that would break the ability to merge later on; I already opened this request to make you aware that it is being worked on, to get feedback early on and to use the CI checks that are automatically performed on pull requests.\r\n\r\nFor the time being I merged most of the changes @Jawz84 had performed in his own fork/branch manually, as they could no longer be merged via patch.\r\n\r\nThere's two topics I'm working on:\r\n1. a Hyper-V based lab should build properly if VMware PowerCLI is installed on the AL workstation (prevent/reduce clobber)\r\n2. the ability to build a lab based on VMware\r\n\r\nPart 1 is looking better already, part 2 has not been tested yet.","created_at":"2018-08-08T13:23:50Z","updated_at":"2018-08-10T15:04:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1861722cb6b4d17834d20296e59d817155daa0e2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/427/commits","review_comments_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/427/comments","review_comment_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/issues/427/comments","statuses_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/statuses/c51ca5f36666458a429b553f0a1058f3c7cc7f91","head":{"label":"carfesh:feature/VMwareSupport","ref":"feature/VMwareSupport","sha":"c51ca5f36666458a429b553f0a1058f3c7cc7f91","user":{"login":"carfesh","id":16491101,"node_id":"MDQ6VXNlcjE2NDkxMTAx","avatar_url":"https://avatars3.githubusercontent.com/u/16491101?v=4","gravatar_id":"","url":"https://api.github.com/users/carfesh","html_url":"https://github.com/carfesh","followers_url":"https://api.github.com/users/carfesh/followers","following_url":"https://api.github.com/users/carfesh/following{/other_user}","gists_url":"https://api.github.com/users/carfesh/gists{/gist_id}","starred_url":"https://api.github.com/users/carfesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carfesh/subscriptions","organizations_url":"https://api.github.com/users/carfesh/orgs","repos_url":"https://api.github.com/users/carfesh/repos","events_url":"https://api.github.com/users/carfesh/events{/privacy}","received_events_url":"https://api.github.com/users/carfesh/received_events","type":"User","site_admin":false},"repo":{"id":143963870,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5NjM4NzA=","name":"AutomatedLab","full_name":"carfesh/AutomatedLab","owner":{"login":"carfesh","id":16491101,"node_id":"MDQ6VXNlcjE2NDkxMTAx","avatar_url":"https://avatars3.githubusercontent.com/u/16491101?v=4","gravatar_id":"","url":"https://api.github.com/users/carfesh","html_url":"https://github.com/carfesh","followers_url":"https://api.github.com/users/carfesh/followers","following_url":"https://api.github.com/users/carfesh/following{/other_user}","gists_url":"https://api.github.com/users/carfesh/gists{/gist_id}","starred_url":"https://api.github.com/users/carfesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carfesh/subscriptions","organizations_url":"https://api.github.com/users/carfesh/orgs","repos_url":"https://api.github.com/users/carfesh/repos","events_url":"https://api.github.com/users/carfesh/events{/privacy}","received_events_url":"https://api.github.com/users/carfesh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carfesh/AutomatedLab","description":"AutomatedLab is a provisioning solution and framework that lets you deploy complex labs on HyperV and Azure with simple PowerShell scripts. It supports all Windows operating systems from 2008 R2 to 2016 including Nano Server and various products like AD, Exchange, PKI, IIS, etc.","fork":true,"url":"https://api.github.com/repos/carfesh/AutomatedLab","forks_url":"https://api.github.com/repos/carfesh/AutomatedLab/forks","keys_url":"https://api.github.com/repos/carfesh/AutomatedLab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carfesh/AutomatedLab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carfesh/AutomatedLab/teams","hooks_url":"https://api.github.com/repos/carfesh/AutomatedLab/hooks","issue_events_url":"https://api.github.com/repos/carfesh/AutomatedLab/issues/events{/number}","events_url":"https://api.github.com/repos/carfesh/AutomatedLab/events","assignees_url":"https://api.github.com/repos/carfesh/AutomatedLab/assignees{/user}","branches_url":"https://api.github.com/repos/carfesh/AutomatedLab/branches{/branch}","tags_url":"https://api.github.com/repos/carfesh/AutomatedLab/tags","blobs_url":"https://api.github.com/repos/carfesh/AutomatedLab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carfesh/AutomatedLab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carfesh/AutomatedLab/git/refs{/sha}","trees_url":"https://api.github.com/repos/carfesh/AutomatedLab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carfesh/AutomatedLab/statuses/{sha}","languages_url":"https://api.github.com/repos/carfesh/AutomatedLab/languages","stargazers_url":"https://api.github.com/repos/carfesh/AutomatedLab/stargazers","contributors_url":"https://api.github.com/repos/carfesh/AutomatedLab/contributors","subscribers_url":"https://api.github.com/repos/carfesh/AutomatedLab/subscribers","subscription_url":"https://api.github.com/repos/carfesh/AutomatedLab/subscription","commits_url":"https://api.github.com/repos/carfesh/AutomatedLab/commits{/sha}","git_commits_url":"https://api.github.com/repos/carfesh/AutomatedLab/git/commits{/sha}","comments_url":"https://api.github.com/repos/carfesh/AutomatedLab/comments{/number}","issue_comment_url":"https://api.github.com/repos/carfesh/AutomatedLab/issues/comments{/number}","contents_url":"https://api.github.com/repos/carfesh/AutomatedLab/contents/{+path}","compare_url":"https://api.github.com/repos/carfesh/AutomatedLab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carfesh/AutomatedLab/merges","archive_url":"https://api.github.com/repos/carfesh/AutomatedLab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carfesh/AutomatedLab/downloads","issues_url":"https://api.github.com/repos/carfesh/AutomatedLab/issues{/number}","pulls_url":"https://api.github.com/repos/carfesh/AutomatedLab/pulls{/number}","milestones_url":"https://api.github.com/repos/carfesh/AutomatedLab/milestones{/number}","notifications_url":"https://api.github.com/repos/carfesh/AutomatedLab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carfesh/AutomatedLab/labels{/name}","releases_url":"https://api.github.com/repos/carfesh/AutomatedLab/releases{/id}","deployments_url":"https://api.github.com/repos/carfesh/AutomatedLab/deployments","created_at":"2018-08-08T05:11:05Z","updated_at":"2018-08-08T05:11:08Z","pushed_at":"2018-08-10T06:21:37Z","git_url":"git://github.com/carfesh/AutomatedLab.git","ssh_url":"git@github.com:carfesh/AutomatedLab.git","clone_url":"https://github.com/carfesh/AutomatedLab.git","svn_url":"https://github.com/carfesh/AutomatedLab","homepage":"","size":30708,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"AutomatedLab:develop","ref":"develop","sha":"a3b234f748af8e3de5eee4af4b4dfb4b7d8e86e0","user":{"login":"AutomatedLab","id":21196077,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMTk2MDc3","avatar_url":"https://avatars1.githubusercontent.com/u/21196077?v=4","gravatar_id":"","url":"https://api.github.com/users/AutomatedLab","html_url":"https://github.com/AutomatedLab","followers_url":"https://api.github.com/users/AutomatedLab/followers","following_url":"https://api.github.com/users/AutomatedLab/following{/other_user}","gists_url":"https://api.github.com/users/AutomatedLab/gists{/gist_id}","starred_url":"https://api.github.com/users/AutomatedLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutomatedLab/subscriptions","organizations_url":"https://api.github.com/users/AutomatedLab/orgs","repos_url":"https://api.github.com/users/AutomatedLab/repos","events_url":"https://api.github.com/users/AutomatedLab/events{/privacy}","received_events_url":"https://api.github.com/users/AutomatedLab/received_events","type":"Organization","site_admin":false},"repo":{"id":66317384,"node_id":"MDEwOlJlcG9zaXRvcnk2NjMxNzM4NA==","name":"AutomatedLab","full_name":"AutomatedLab/AutomatedLab","owner":{"login":"AutomatedLab","id":21196077,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMTk2MDc3","avatar_url":"https://avatars1.githubusercontent.com/u/21196077?v=4","gravatar_id":"","url":"https://api.github.com/users/AutomatedLab","html_url":"https://github.com/AutomatedLab","followers_url":"https://api.github.com/users/AutomatedLab/followers","following_url":"https://api.github.com/users/AutomatedLab/following{/other_user}","gists_url":"https://api.github.com/users/AutomatedLab/gists{/gist_id}","starred_url":"https://api.github.com/users/AutomatedLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutomatedLab/subscriptions","organizations_url":"https://api.github.com/users/AutomatedLab/orgs","repos_url":"https://api.github.com/users/AutomatedLab/repos","events_url":"https://api.github.com/users/AutomatedLab/events{/privacy}","received_events_url":"https://api.github.com/users/AutomatedLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AutomatedLab/AutomatedLab","description":"AutomatedLab is a provisioning solution and framework that lets you deploy complex labs on HyperV and Azure with simple PowerShell scripts. It supports all Windows operating systems from 2008 R2 to 2016 including Nano Server and various products like AD, Exchange, PKI, IIS, etc.","fork":false,"url":"https://api.github.com/repos/AutomatedLab/AutomatedLab","forks_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/forks","keys_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/teams","hooks_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/hooks","issue_events_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/issues/events{/number}","events_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/events","assignees_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/assignees{/user}","branches_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/branches{/branch}","tags_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/tags","blobs_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/git/refs{/sha}","trees_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/statuses/{sha}","languages_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/languages","stargazers_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/stargazers","contributors_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/contributors","subscribers_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/subscribers","subscription_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/subscription","commits_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/commits{/sha}","git_commits_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/git/commits{/sha}","comments_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/comments{/number}","issue_comment_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/issues/comments{/number}","contents_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/contents/{+path}","compare_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/merges","archive_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/downloads","issues_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/issues{/number}","pulls_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls{/number}","milestones_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/milestones{/number}","notifications_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/labels{/name}","releases_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/releases{/id}","deployments_url":"https://api.github.com/repos/AutomatedLab/AutomatedLab/deployments","created_at":"2016-08-23T00:08:15Z","updated_at":"2018-08-10T06:27:01Z","pushed_at":"2018-08-10T06:21:38Z","git_url":"git://github.com/AutomatedLab/AutomatedLab.git","ssh_url":"git@github.com:AutomatedLab/AutomatedLab.git","clone_url":"https://github.com/AutomatedLab/AutomatedLab.git","svn_url":"https://github.com/AutomatedLab/AutomatedLab","homepage":"","size":30629,"stargazers_count":381,"watchers_count":381,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":85,"open_issues":35,"watchers":381,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/427"},"html":{"href":"https://github.com/AutomatedLab/AutomatedLab/pull/427"},"issue":{"href":"https://api.github.com/repos/AutomatedLab/AutomatedLab/issues/427"},"comments":{"href":"https://api.github.com/repos/AutomatedLab/AutomatedLab/issues/427/comments"},"review_comments":{"href":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/427/comments"},"review_comment":{"href":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AutomatedLab/AutomatedLab/pulls/427/commits"},"statuses":{"href":"https://api.github.com/repos/AutomatedLab/AutomatedLab/statuses/c51ca5f36666458a429b553f0a1058f3c7cc7f91"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nyanhp"}}