{"action":"closed","number":3128,"pull_request":{"url":"https://api.github.com/repos/matrix-org/synapse/pulls/3128","id":183831744,"html_url":"https://github.com/matrix-org/synapse/pull/3128","diff_url":"https://github.com/matrix-org/synapse/pull/3128.diff","patch_url":"https://github.com/matrix-org/synapse/pull/3128.patch","issue_url":"https://api.github.com/repos/matrix-org/synapse/issues/3128","number":3128,"state":"closed","locked":false,"title":"Prevent double group invites from breaking a group","user":{"login":"vurpo","id":6452110,"avatar_url":"https://avatars1.githubusercontent.com/u/6452110?v=4","gravatar_id":"","url":"https://api.github.com/users/vurpo","html_url":"https://github.com/vurpo","followers_url":"https://api.github.com/users/vurpo/followers","following_url":"https://api.github.com/users/vurpo/following{/other_user}","gists_url":"https://api.github.com/users/vurpo/gists{/gist_id}","starred_url":"https://api.github.com/users/vurpo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vurpo/subscriptions","organizations_url":"https://api.github.com/users/vurpo/orgs","repos_url":"https://api.github.com/users/vurpo/repos","events_url":"https://api.github.com/users/vurpo/events{/privacy}","received_events_url":"https://api.github.com/users/vurpo/received_events","type":"User","site_admin":false},"body":"Fixes #2633. This just changes a constraint in the database schema to be unique, so that any attempt to invite a user to a group twice will just return a 500 error, and not break the database.\r\n\r\nI don't know what would happen if you applied this update to an already-broken database, though. Maybe there should be an SQL statement before this one that deletes any duplicate group invites before attempting to add the unique requirement?","created_at":"2018-04-24T18:55:23Z","updated_at":"2018-04-25T14:01:28Z","closed_at":"2018-04-25T14:01:28Z","merged_at":null,"merge_commit_sha":"3ce13e41d4b170e66bac4868348eb92879f84587","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/synapse/pulls/3128/commits","review_comments_url":"https://api.github.com/repos/matrix-org/synapse/pulls/3128/comments","review_comment_url":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/synapse/issues/3128/comments","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/4e43cd12bf997b94a610cd9de03b602d0b463481","head":{"label":"vurpo:fix-2633","ref":"fix-2633","sha":"4e43cd12bf997b94a610cd9de03b602d0b463481","user":{"login":"vurpo","id":6452110,"avatar_url":"https://avatars1.githubusercontent.com/u/6452110?v=4","gravatar_id":"","url":"https://api.github.com/users/vurpo","html_url":"https://github.com/vurpo","followers_url":"https://api.github.com/users/vurpo/followers","following_url":"https://api.github.com/users/vurpo/following{/other_user}","gists_url":"https://api.github.com/users/vurpo/gists{/gist_id}","starred_url":"https://api.github.com/users/vurpo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vurpo/subscriptions","organizations_url":"https://api.github.com/users/vurpo/orgs","repos_url":"https://api.github.com/users/vurpo/repos","events_url":"https://api.github.com/users/vurpo/events{/privacy}","received_events_url":"https://api.github.com/users/vurpo/received_events","type":"User","site_admin":false},"repo":{"id":130899456,"name":"synapse","full_name":"vurpo/synapse","owner":{"login":"vurpo","id":6452110,"avatar_url":"https://avatars1.githubusercontent.com/u/6452110?v=4","gravatar_id":"","url":"https://api.github.com/users/vurpo","html_url":"https://github.com/vurpo","followers_url":"https://api.github.com/users/vurpo/followers","following_url":"https://api.github.com/users/vurpo/following{/other_user}","gists_url":"https://api.github.com/users/vurpo/gists{/gist_id}","starred_url":"https://api.github.com/users/vurpo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vurpo/subscriptions","organizations_url":"https://api.github.com/users/vurpo/orgs","repos_url":"https://api.github.com/users/vurpo/repos","events_url":"https://api.github.com/users/vurpo/events{/privacy}","received_events_url":"https://api.github.com/users/vurpo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vurpo/synapse","description":"Synapse: Matrix reference homeserver","fork":true,"url":"https://api.github.com/repos/vurpo/synapse","forks_url":"https://api.github.com/repos/vurpo/synapse/forks","keys_url":"https://api.github.com/repos/vurpo/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vurpo/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vurpo/synapse/teams","hooks_url":"https://api.github.com/repos/vurpo/synapse/hooks","issue_events_url":"https://api.github.com/repos/vurpo/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/vurpo/synapse/events","assignees_url":"https://api.github.com/repos/vurpo/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/vurpo/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/vurpo/synapse/tags","blobs_url":"https://api.github.com/repos/vurpo/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vurpo/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vurpo/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/vurpo/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vurpo/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/vurpo/synapse/languages","stargazers_url":"https://api.github.com/repos/vurpo/synapse/stargazers","contributors_url":"https://api.github.com/repos/vurpo/synapse/contributors","subscribers_url":"https://api.github.com/repos/vurpo/synapse/subscribers","subscription_url":"https://api.github.com/repos/vurpo/synapse/subscription","commits_url":"https://api.github.com/repos/vurpo/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/vurpo/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/vurpo/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/vurpo/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/vurpo/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/vurpo/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vurpo/synapse/merges","archive_url":"https://api.github.com/repos/vurpo/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vurpo/synapse/downloads","issues_url":"https://api.github.com/repos/vurpo/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/vurpo/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/vurpo/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/vurpo/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vurpo/synapse/labels{/name}","releases_url":"https://api.github.com/repos/vurpo/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/vurpo/synapse/deployments","created_at":"2018-04-24T18:45:48Z","updated_at":"2018-04-24T18:45:52Z","pushed_at":"2018-04-24T18:46:45Z","git_url":"git://github.com/vurpo/synapse.git","ssh_url":"git@github.com:vurpo/synapse.git","clone_url":"https://github.com/vurpo/synapse.git","svn_url":"https://github.com/vurpo/synapse","homepage":"http://matrix.org","size":17311,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matrix-org:develop","ref":"develop","sha":"1bb83d5d41e5e3e90ec14a6a9d1f385c452885de","user":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":22844864,"name":"synapse","full_name":"matrix-org/synapse","owner":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/synapse","description":"Synapse: Matrix reference homeserver","fork":false,"url":"https://api.github.com/repos/matrix-org/synapse","forks_url":"https://api.github.com/repos/matrix-org/synapse/forks","keys_url":"https://api.github.com/repos/matrix-org/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/synapse/teams","hooks_url":"https://api.github.com/repos/matrix-org/synapse/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/synapse/events","assignees_url":"https://api.github.com/repos/matrix-org/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/synapse/tags","blobs_url":"https://api.github.com/repos/matrix-org/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/synapse/languages","stargazers_url":"https://api.github.com/repos/matrix-org/synapse/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/synapse/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/synapse/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/synapse/subscription","commits_url":"https://api.github.com/repos/matrix-org/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/synapse/merges","archive_url":"https://api.github.com/repos/matrix-org/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/synapse/downloads","issues_url":"https://api.github.com/repos/matrix-org/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/synapse/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/synapse/deployments","created_at":"2014-08-11T15:51:42Z","updated_at":"2018-04-25T11:41:02Z","pushed_at":"2018-04-25T13:59:24Z","git_url":"git://github.com/matrix-org/synapse.git","ssh_url":"git@github.com:matrix-org/synapse.git","clone_url":"https://github.com/matrix-org/synapse.git","svn_url":"https://github.com/matrix-org/synapse","homepage":"http://matrix.org","size":17344,"stargazers_count":2817,"watchers_count":2817,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":399,"mirror_url":null,"archived":false,"open_issues_count":838,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":399,"open_issues":838,"watchers":2817,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/3128"},"html":{"href":"https://github.com/matrix-org/synapse/pull/3128"},"issue":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/3128"},"comments":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/3128/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/3128/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/3128/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/synapse/statuses/4e43cd12bf997b94a610cd9de03b602d0b463481"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":4,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"ara4n"}}