{"action":"closed","number":5893,"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5893","id":188433046,"html_url":"https://github.com/bbatsov/rubocop/pull/5893","diff_url":"https://github.com/bbatsov/rubocop/pull/5893.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/5893.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/5893","number":5893,"state":"closed","locked":false,"title":"[Fix #5888] Do not register an offense for headers or env keyword args","user":{"login":"rrosenblum","id":1528852,"avatar_url":"https://avatars0.githubusercontent.com/u/1528852?v=4","gravatar_id":"","url":"https://api.github.com/users/rrosenblum","html_url":"https://github.com/rrosenblum","followers_url":"https://api.github.com/users/rrosenblum/followers","following_url":"https://api.github.com/users/rrosenblum/following{/other_user}","gists_url":"https://api.github.com/users/rrosenblum/gists{/gist_id}","starred_url":"https://api.github.com/users/rrosenblum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrosenblum/subscriptions","organizations_url":"https://api.github.com/users/rrosenblum/orgs","repos_url":"https://api.github.com/users/rrosenblum/repos","events_url":"https://api.github.com/users/rrosenblum/events{/privacy}","received_events_url":"https://api.github.com/users/rrosenblum/received_events","type":"User","site_admin":false},"body":"This is a partial fix for #5888. It will prevent the cop from registering an offense when `headers` or `env` is used as a keyword. As noted in the issue, controller tests and request tests have a different method signature. This cop is not safe to work on both types of tests at the same time.","created_at":"2018-05-16T13:29:24Z","updated_at":"2018-05-17T07:59:34Z","closed_at":"2018-05-17T07:59:34Z","merged_at":"2018-05-17T07:59:34Z","merge_commit_sha":"4158a04a993681297b170e8c35a51669570303a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5893/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5893/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/5893/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/0ad524429cb05bfb13e423b0f5e5a76db8bb1703","head":{"label":"rrosenblum:5888_http_positional_args","ref":"5888_http_positional_args","sha":"0ad524429cb05bfb13e423b0f5e5a76db8bb1703","user":{"login":"rrosenblum","id":1528852,"avatar_url":"https://avatars0.githubusercontent.com/u/1528852?v=4","gravatar_id":"","url":"https://api.github.com/users/rrosenblum","html_url":"https://github.com/rrosenblum","followers_url":"https://api.github.com/users/rrosenblum/followers","following_url":"https://api.github.com/users/rrosenblum/following{/other_user}","gists_url":"https://api.github.com/users/rrosenblum/gists{/gist_id}","starred_url":"https://api.github.com/users/rrosenblum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrosenblum/subscriptions","organizations_url":"https://api.github.com/users/rrosenblum/orgs","repos_url":"https://api.github.com/users/rrosenblum/repos","events_url":"https://api.github.com/users/rrosenblum/events{/privacy}","received_events_url":"https://api.github.com/users/rrosenblum/received_events","type":"User","site_admin":false},"repo":{"id":28112474,"name":"rubocop","full_name":"rrosenblum/rubocop","owner":{"login":"rrosenblum","id":1528852,"avatar_url":"https://avatars0.githubusercontent.com/u/1528852?v=4","gravatar_id":"","url":"https://api.github.com/users/rrosenblum","html_url":"https://github.com/rrosenblum","followers_url":"https://api.github.com/users/rrosenblum/followers","following_url":"https://api.github.com/users/rrosenblum/following{/other_user}","gists_url":"https://api.github.com/users/rrosenblum/gists{/gist_id}","starred_url":"https://api.github.com/users/rrosenblum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrosenblum/subscriptions","organizations_url":"https://api.github.com/users/rrosenblum/orgs","repos_url":"https://api.github.com/users/rrosenblum/repos","events_url":"https://api.github.com/users/rrosenblum/events{/privacy}","received_events_url":"https://api.github.com/users/rrosenblum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rrosenblum/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/rrosenblum/rubocop","forks_url":"https://api.github.com/repos/rrosenblum/rubocop/forks","keys_url":"https://api.github.com/repos/rrosenblum/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rrosenblum/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rrosenblum/rubocop/teams","hooks_url":"https://api.github.com/repos/rrosenblum/rubocop/hooks","issue_events_url":"https://api.github.com/repos/rrosenblum/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/rrosenblum/rubocop/events","assignees_url":"https://api.github.com/repos/rrosenblum/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/rrosenblum/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/rrosenblum/rubocop/tags","blobs_url":"https://api.github.com/repos/rrosenblum/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rrosenblum/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rrosenblum/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/rrosenblum/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rrosenblum/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/rrosenblum/rubocop/languages","stargazers_url":"https://api.github.com/repos/rrosenblum/rubocop/stargazers","contributors_url":"https://api.github.com/repos/rrosenblum/rubocop/contributors","subscribers_url":"https://api.github.com/repos/rrosenblum/rubocop/subscribers","subscription_url":"https://api.github.com/repos/rrosenblum/rubocop/subscription","commits_url":"https://api.github.com/repos/rrosenblum/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/rrosenblum/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/rrosenblum/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/rrosenblum/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/rrosenblum/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/rrosenblum/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rrosenblum/rubocop/merges","archive_url":"https://api.github.com/repos/rrosenblum/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rrosenblum/rubocop/downloads","issues_url":"https://api.github.com/repos/rrosenblum/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/rrosenblum/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/rrosenblum/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/rrosenblum/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rrosenblum/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/rrosenblum/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/rrosenblum/rubocop/deployments","created_at":"2014-12-16T23:54:29Z","updated_at":"2018-05-14T18:40:40Z","pushed_at":"2018-05-17T07:59:24Z","git_url":"git://github.com/rrosenblum/rubocop.git","ssh_url":"git@github.com:rrosenblum/rubocop.git","clone_url":"https://github.com/rrosenblum/rubocop.git","svn_url":"https://github.com/rrosenblum/rubocop","homepage":"","size":21024,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"9f976de2aa17203d692dcf1df921ecdbeacb78d1","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/bbatsov/rubocop/deployments","created_at":"2012-04-21T10:09:58Z","updated_at":"2018-05-17T07:58:16Z","pushed_at":"2018-05-17T07:59:34Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"http://rubocop.readthedocs.io","size":21134,"stargazers_count":9020,"watchers_count":9020,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1765,"mirror_url":null,"archived":false,"open_issues_count":342,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1765,"open_issues":342,"watchers":9020,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5893"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/5893"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/5893"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/5893/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5893/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5893/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/0ad524429cb05bfb13e423b0f5e5a76db8bb1703"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":12,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"bbatsov"}}