{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/go-txfile/pulls/comments/198206478","pull_request_review_id":132077422,"id":198206478,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODIwNjQ3OA==","diff_hunk":"@@ -5,6 +5,5 @@ os:\n   - osx\n \n go:\n-  - '1.9'","path":".travis.yml","position":4,"original_position":4,"commit_id":"38366931f78a23a17c6754d2fca6edcd47dde62f","original_commit_id":"38366931f78a23a17c6754d2fca6edcd47dde62f","user":{"login":"ph","id":640,"node_id":"MDQ6VXNlcjY0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/640?v=4","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"body":"we might want something that doesn't use `strings.builder` or shim it.","created_at":"2018-06-26T16:08:43Z","updated_at":"2018-06-26T16:14:14Z","html_url":"https://github.com/elastic/go-txfile/pull/12#discussion_r198206478","pull_request_url":"https://api.github.com/repos/elastic/go-txfile/pulls/12","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/go-txfile/pulls/comments/198206478"},"html":{"href":"https://github.com/elastic/go-txfile/pull/12#discussion_r198206478"},"pull_request":{"href":"https://api.github.com/repos/elastic/go-txfile/pulls/12"}},"in_reply_to_id":198191689},"pull_request":{"url":"https://api.github.com/repos/elastic/go-txfile/pulls/12","id":197195686,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTk1Njg2","html_url":"https://github.com/elastic/go-txfile/pull/12","diff_url":"https://github.com/elastic/go-txfile/pull/12.diff","patch_url":"https://github.com/elastic/go-txfile/pull/12.patch","issue_url":"https://api.github.com/repos/elastic/go-txfile/issues/12","number":12,"state":"open","locked":false,"title":"[WIP] Improve error reporting","user":{"login":"urso","id":75886,"node_id":"MDQ6VXNlcjc1ODg2","avatar_url":"https://avatars1.githubusercontent.com/u/75886?v=4","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"body":"- Introduces txfile/txerr for error generation and custom queries on errors\r\n- Errors must be consumable by: Application error handling, Application logging, End User, Operator, and Developer\r\n  - Application error handling requires well defined comparable error codes\r\n\r\nAn error value:\r\n  - is a tree of errors\r\n  - A node type can have 0, 1 or N children. txerr assumes (not enforced by types):\r\n    - errors capturing 1 cause only to implement `Cause() error`\r\n    - errors capturing N causes must implement `Causes() []error`\r\n    - errors not implementing `Cause` or `Causes`, or returning `nil` are leaf nodes (root causes).\r\n  - each node in the tree can provide additional context (accessed via Methods)\r\n  - common error context (optional):\r\n    - Operation: Document operation/function call. Common format: `<package>/<function name>`.\r\n    - Kind: comparable error value:\r\n      - must be a constant, so error kinds can be compared by value\r\n      - use custom type (`type kind ...`), so error comparison does not produce false positives when comparing error codes from multiple packages.\r\n    - Message: custom error message (Note: `vfs` package implements `Path() string`, but no Message).\r\n\r\nThe txerr package provides functions to 'build', iterate, query and print error values. Using `txerr.Is(myKind, err)`, the full error tree is searched for an error matching the error kind.\r\n\r\nNote: the `reason` type is a temporary placeholder for now, forcing the compiler to generate compile time errors while doing the refactoring (might be removed once finished).\r\n\r\nTODO:\r\n- Introduce custom error type with additional context in packages:\r\n  - [ ] txfile (so far only Open function improved)\r\n  - [ ] txfile/pq\r\n  - [x] internal/vfs (not based on txfile/txerr, but integrates with txerr thanks to compatible interfaces)\r\n\r\n","created_at":"2018-06-25T18:19:07Z","updated_at":"2018-06-26T16:14:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"074ae454240d46ed657f3fa31c6a643670c15066","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kvch","id":3876218,"node_id":"MDQ6VXNlcjM4NzYyMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3876218?v=4","gravatar_id":"","url":"https://api.github.com/users/kvch","html_url":"https://github.com/kvch","followers_url":"https://api.github.com/users/kvch/followers","following_url":"https://api.github.com/users/kvch/following{/other_user}","gists_url":"https://api.github.com/users/kvch/gists{/gist_id}","starred_url":"https://api.github.com/users/kvch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvch/subscriptions","organizations_url":"https://api.github.com/users/kvch/orgs","repos_url":"https://api.github.com/users/kvch/repos","events_url":"https://api.github.com/users/kvch/events{/privacy}","received_events_url":"https://api.github.com/users/kvch/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":887759181,"node_id":"MDU6TGFiZWw4ODc3NTkxODE=","url":"https://api.github.com/repos/elastic/go-txfile/labels/in%20progress","name":"in progress","color":"2ac7f7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/go-txfile/pulls/12/commits","review_comments_url":"https://api.github.com/repos/elastic/go-txfile/pulls/12/comments","review_comment_url":"https://api.github.com/repos/elastic/go-txfile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/go-txfile/issues/12/comments","statuses_url":"https://api.github.com/repos/elastic/go-txfile/statuses/38366931f78a23a17c6754d2fca6edcd47dde62f","head":{"label":"urso:improve-errors","ref":"improve-errors","sha":"38366931f78a23a17c6754d2fca6edcd47dde62f","user":{"login":"urso","id":75886,"node_id":"MDQ6VXNlcjc1ODg2","avatar_url":"https://avatars1.githubusercontent.com/u/75886?v=4","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"repo":{"id":127319475,"node_id":"MDEwOlJlcG9zaXRvcnkxMjczMTk0NzU=","name":"go-txfile","full_name":"urso/go-txfile","owner":{"login":"urso","id":75886,"node_id":"MDQ6VXNlcjc1ODg2","avatar_url":"https://avatars1.githubusercontent.com/u/75886?v=4","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/urso/go-txfile","description":null,"fork":true,"url":"https://api.github.com/repos/urso/go-txfile","forks_url":"https://api.github.com/repos/urso/go-txfile/forks","keys_url":"https://api.github.com/repos/urso/go-txfile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urso/go-txfile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urso/go-txfile/teams","hooks_url":"https://api.github.com/repos/urso/go-txfile/hooks","issue_events_url":"https://api.github.com/repos/urso/go-txfile/issues/events{/number}","events_url":"https://api.github.com/repos/urso/go-txfile/events","assignees_url":"https://api.github.com/repos/urso/go-txfile/assignees{/user}","branches_url":"https://api.github.com/repos/urso/go-txfile/branches{/branch}","tags_url":"https://api.github.com/repos/urso/go-txfile/tags","blobs_url":"https://api.github.com/repos/urso/go-txfile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urso/go-txfile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urso/go-txfile/git/refs{/sha}","trees_url":"https://api.github.com/repos/urso/go-txfile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urso/go-txfile/statuses/{sha}","languages_url":"https://api.github.com/repos/urso/go-txfile/languages","stargazers_url":"https://api.github.com/repos/urso/go-txfile/stargazers","contributors_url":"https://api.github.com/repos/urso/go-txfile/contributors","subscribers_url":"https://api.github.com/repos/urso/go-txfile/subscribers","subscription_url":"https://api.github.com/repos/urso/go-txfile/subscription","commits_url":"https://api.github.com/repos/urso/go-txfile/commits{/sha}","git_commits_url":"https://api.github.com/repos/urso/go-txfile/git/commits{/sha}","comments_url":"https://api.github.com/repos/urso/go-txfile/comments{/number}","issue_comment_url":"https://api.github.com/repos/urso/go-txfile/issues/comments{/number}","contents_url":"https://api.github.com/repos/urso/go-txfile/contents/{+path}","compare_url":"https://api.github.com/repos/urso/go-txfile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urso/go-txfile/merges","archive_url":"https://api.github.com/repos/urso/go-txfile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urso/go-txfile/downloads","issues_url":"https://api.github.com/repos/urso/go-txfile/issues{/number}","pulls_url":"https://api.github.com/repos/urso/go-txfile/pulls{/number}","milestones_url":"https://api.github.com/repos/urso/go-txfile/milestones{/number}","notifications_url":"https://api.github.com/repos/urso/go-txfile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urso/go-txfile/labels{/name}","releases_url":"https://api.github.com/repos/urso/go-txfile/releases{/id}","deployments_url":"https://api.github.com/repos/urso/go-txfile/deployments","created_at":"2018-03-29T16:39:15Z","updated_at":"2018-06-21T10:52:04Z","pushed_at":"2018-06-25T18:34:34Z","git_url":"git://github.com/urso/go-txfile.git","ssh_url":"git@github.com:urso/go-txfile.git","clone_url":"https://github.com/urso/go-txfile.git","svn_url":"https://github.com/urso/go-txfile","homepage":null,"size":172,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"2f6b8d94b0a80969c73ba48b45d6f519382122f2","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":127318523,"node_id":"MDEwOlJlcG9zaXRvcnkxMjczMTg1MjM=","name":"go-txfile","full_name":"elastic/go-txfile","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/go-txfile","description":null,"fork":false,"url":"https://api.github.com/repos/elastic/go-txfile","forks_url":"https://api.github.com/repos/elastic/go-txfile/forks","keys_url":"https://api.github.com/repos/elastic/go-txfile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/go-txfile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/go-txfile/teams","hooks_url":"https://api.github.com/repos/elastic/go-txfile/hooks","issue_events_url":"https://api.github.com/repos/elastic/go-txfile/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/go-txfile/events","assignees_url":"https://api.github.com/repos/elastic/go-txfile/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/go-txfile/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/go-txfile/tags","blobs_url":"https://api.github.com/repos/elastic/go-txfile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/go-txfile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/go-txfile/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/go-txfile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/go-txfile/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/go-txfile/languages","stargazers_url":"https://api.github.com/repos/elastic/go-txfile/stargazers","contributors_url":"https://api.github.com/repos/elastic/go-txfile/contributors","subscribers_url":"https://api.github.com/repos/elastic/go-txfile/subscribers","subscription_url":"https://api.github.com/repos/elastic/go-txfile/subscription","commits_url":"https://api.github.com/repos/elastic/go-txfile/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/go-txfile/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/go-txfile/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/go-txfile/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/go-txfile/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/go-txfile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/go-txfile/merges","archive_url":"https://api.github.com/repos/elastic/go-txfile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/go-txfile/downloads","issues_url":"https://api.github.com/repos/elastic/go-txfile/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/go-txfile/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/go-txfile/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/go-txfile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/go-txfile/labels{/name}","releases_url":"https://api.github.com/repos/elastic/go-txfile/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/go-txfile/deployments","created_at":"2018-03-29T16:30:47Z","updated_at":"2018-06-19T19:09:19Z","pushed_at":"2018-06-25T18:34:35Z","git_url":"git://github.com/elastic/go-txfile.git","ssh_url":"git@github.com:elastic/go-txfile.git","clone_url":"https://github.com/elastic/go-txfile.git","svn_url":"https://github.com/elastic/go-txfile","homepage":null,"size":142,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/go-txfile/pulls/12"},"html":{"href":"https://github.com/elastic/go-txfile/pull/12"},"issue":{"href":"https://api.github.com/repos/elastic/go-txfile/issues/12"},"comments":{"href":"https://api.github.com/repos/elastic/go-txfile/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/go-txfile/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/go-txfile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/go-txfile/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/go-txfile/statuses/38366931f78a23a17c6754d2fca6edcd47dde62f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ph"}}