{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/187555046","pull_request_review_id":119359217,"id":187555046,"diff_hunk":"@@ -127,8 +130,14 @@ public void setJmsAcknowledgeMode(final int mode) {\n                 messageHandler = new TransactedSessionMessageHandler();\n                 break;\n             default:\n-                LOG.warn(\"Unsupported Acknowledge mode: \"\n-                    + mode + \" (See javax.jms.Session for valid values)\");\n+                // individual message ack-ing needs vendor specific mode\n+                if (individualAcks) {","path":"external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java","position":null,"original_position":66,"commit_id":"41df21fa495ae252f3e109ea30a0623af821f3c4","original_commit_id":"41df21fa495ae252f3e109ea30a0623af821f3c4","user":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars2.githubusercontent.com/u/1317309?v=4","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"body":"This change requires end users to call individualAcks earlier than this method. Could we guide this in javadoc or in exception message? Or can we fix it? (Maybe it defers verification step in open() so violating fail-fast...)","created_at":"2018-05-11T08:43:45Z","updated_at":"2018-05-11T08:43:46Z","html_url":"https://github.com/apache/storm/pull/2639#discussion_r187555046","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/2639","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/187555046"},"html":{"href":"https://github.com/apache/storm/pull/2639#discussion_r187555046"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/2639"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/2639","id":182853348,"html_url":"https://github.com/apache/storm/pull/2639","diff_url":"https://github.com/apache/storm/pull/2639.diff","patch_url":"https://github.com/apache/storm/pull/2639.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/2639","number":2639,"state":"open","locked":false,"title":"STORM-3035: fix the issue in JmsSpout.ack when toCommit is empty","user":{"login":"arunmahadevan","id":6792890,"avatar_url":"https://avatars0.githubusercontent.com/u/6792890?v=4","gravatar_id":"","url":"https://api.github.com/users/arunmahadevan","html_url":"https://github.com/arunmahadevan","followers_url":"https://api.github.com/users/arunmahadevan/followers","following_url":"https://api.github.com/users/arunmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/arunmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/arunmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunmahadevan/subscriptions","organizations_url":"https://api.github.com/users/arunmahadevan/orgs","repos_url":"https://api.github.com/users/arunmahadevan/repos","events_url":"https://api.github.com/users/arunmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/arunmahadevan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-19T17:58:39Z","updated_at":"2018-05-11T08:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d431dc395f1d372958ece9dc584dcba5ecc51054","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/2639/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/2639/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/2639/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/41df21fa495ae252f3e109ea30a0623af821f3c4","head":{"label":"arunmahadevan:STORM-3035","ref":"STORM-3035","sha":"41df21fa495ae252f3e109ea30a0623af821f3c4","user":{"login":"arunmahadevan","id":6792890,"avatar_url":"https://avatars0.githubusercontent.com/u/6792890?v=4","gravatar_id":"","url":"https://api.github.com/users/arunmahadevan","html_url":"https://github.com/arunmahadevan","followers_url":"https://api.github.com/users/arunmahadevan/followers","following_url":"https://api.github.com/users/arunmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/arunmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/arunmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunmahadevan/subscriptions","organizations_url":"https://api.github.com/users/arunmahadevan/orgs","repos_url":"https://api.github.com/users/arunmahadevan/repos","events_url":"https://api.github.com/users/arunmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/arunmahadevan/received_events","type":"User","site_admin":false},"repo":{"id":38767161,"name":"storm","full_name":"arunmahadevan/storm","owner":{"login":"arunmahadevan","id":6792890,"avatar_url":"https://avatars0.githubusercontent.com/u/6792890?v=4","gravatar_id":"","url":"https://api.github.com/users/arunmahadevan","html_url":"https://github.com/arunmahadevan","followers_url":"https://api.github.com/users/arunmahadevan/followers","following_url":"https://api.github.com/users/arunmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/arunmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/arunmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunmahadevan/subscriptions","organizations_url":"https://api.github.com/users/arunmahadevan/orgs","repos_url":"https://api.github.com/users/arunmahadevan/repos","events_url":"https://api.github.com/users/arunmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/arunmahadevan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arunmahadevan/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/arunmahadevan/storm","forks_url":"https://api.github.com/repos/arunmahadevan/storm/forks","keys_url":"https://api.github.com/repos/arunmahadevan/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arunmahadevan/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arunmahadevan/storm/teams","hooks_url":"https://api.github.com/repos/arunmahadevan/storm/hooks","issue_events_url":"https://api.github.com/repos/arunmahadevan/storm/issues/events{/number}","events_url":"https://api.github.com/repos/arunmahadevan/storm/events","assignees_url":"https://api.github.com/repos/arunmahadevan/storm/assignees{/user}","branches_url":"https://api.github.com/repos/arunmahadevan/storm/branches{/branch}","tags_url":"https://api.github.com/repos/arunmahadevan/storm/tags","blobs_url":"https://api.github.com/repos/arunmahadevan/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arunmahadevan/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arunmahadevan/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/arunmahadevan/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arunmahadevan/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/arunmahadevan/storm/languages","stargazers_url":"https://api.github.com/repos/arunmahadevan/storm/stargazers","contributors_url":"https://api.github.com/repos/arunmahadevan/storm/contributors","subscribers_url":"https://api.github.com/repos/arunmahadevan/storm/subscribers","subscription_url":"https://api.github.com/repos/arunmahadevan/storm/subscription","commits_url":"https://api.github.com/repos/arunmahadevan/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/arunmahadevan/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/arunmahadevan/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/arunmahadevan/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/arunmahadevan/storm/contents/{+path}","compare_url":"https://api.github.com/repos/arunmahadevan/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arunmahadevan/storm/merges","archive_url":"https://api.github.com/repos/arunmahadevan/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arunmahadevan/storm/downloads","issues_url":"https://api.github.com/repos/arunmahadevan/storm/issues{/number}","pulls_url":"https://api.github.com/repos/arunmahadevan/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/arunmahadevan/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/arunmahadevan/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arunmahadevan/storm/labels{/name}","releases_url":"https://api.github.com/repos/arunmahadevan/storm/releases{/id}","deployments_url":"https://api.github.com/repos/arunmahadevan/storm/deployments","created_at":"2015-07-08T16:48:04Z","updated_at":"2015-07-08T16:48:07Z","pushed_at":"2018-05-11T01:18:56Z","git_url":"git://github.com/arunmahadevan/storm.git","ssh_url":"git@github.com:arunmahadevan/storm.git","clone_url":"https://github.com/arunmahadevan/storm.git","svn_url":"https://github.com/arunmahadevan/storm","homepage":null,"size":121559,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5deba40fca0f88f61d2086cb902318ad9bb044f1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","deployments_url":"https://api.github.com/repos/apache/storm/deployments","created_at":"2013-11-05T08:00:14Z","updated_at":"2018-05-11T03:15:29Z","pushed_at":"2018-05-11T02:07:36Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":174198,"stargazers_count":5020,"watchers_count":5020,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3598,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3598,"open_issues":163,"watchers":5020,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/2639"},"html":{"href":"https://github.com/apache/storm/pull/2639"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/2639"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/2639/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/2639/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/2639/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/41df21fa495ae252f3e109ea30a0623af821f3c4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"HeartSaVioR"}}