{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/comments/223240798","pull_request_review_id":162319665,"id":223240798,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzI0MDc5OA==","diff_hunk":"@@ -186,11 +186,13 @@\n   if proj.respond_to?(:additional_rubies)\n     proj.additional_rubies.keys.each do |rubyver|\n       proj.component \"ruby-#{rubyver}\"\n-    end\n \n-    proj.component \"ruby-multi-augeas\" unless platform.is_windows?\n-    proj.component \"ruby-multi-selinux\" if platform.name =~ /^el-(5|6|7)-.*/ || platform.is_fedora?\n-    proj.component \"ruby-multi-stomp\"\n+      ruby_minor = rubyver.split('.')[0,2].join('.')\n+\n+      proj.component \"ruby-#{ruby_minor}-augeas\" unless platform.is_windows?\n+      proj.component \"ruby-#{ruby_minor}-selinux\" if platform.name =~ /^el-(5|6|7)-.*/ || platform.is_fedora?","path":"configs/projects/pdk-runtime.rb","position":null,"original_position":12,"commit_id":"03b18e60cd783f6919a7209fab4ab9929821db78","original_commit_id":"77c1ad3f7e771565005f9a5d2db67a04232e8397","user":{"login":"rodjek","id":80629,"node_id":"MDQ6VXNlcjgwNjI5","avatar_url":"https://avatars2.githubusercontent.com/u/80629?v=4","gravatar_id":"","url":"https://api.github.com/users/rodjek","html_url":"https://github.com/rodjek","followers_url":"https://api.github.com/users/rodjek/followers","following_url":"https://api.github.com/users/rodjek/following{/other_user}","gists_url":"https://api.github.com/users/rodjek/gists{/gist_id}","starred_url":"https://api.github.com/users/rodjek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodjek/subscriptions","organizations_url":"https://api.github.com/users/rodjek/orgs","repos_url":"https://api.github.com/users/rodjek/repos","events_url":"https://api.github.com/users/rodjek/events{/privacy}","received_events_url":"https://api.github.com/users/rodjek/received_events","type":"User","site_admin":false},"body":"Updated","created_at":"2018-10-08T02:58:06Z","updated_at":"2018-10-08T02:58:06Z","html_url":"https://github.com/puppetlabs/puppet-runtime/pull/109#discussion_r223240798","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/109","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/comments/223240798"},"html":{"href":"https://github.com/puppetlabs/puppet-runtime/pull/109#discussion_r223240798"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/109"}},"in_reply_to_id":223240415},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/109","id":220990617,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTkwNjE3","html_url":"https://github.com/puppetlabs/puppet-runtime/pull/109","diff_url":"https://github.com/puppetlabs/puppet-runtime/pull/109.diff","patch_url":"https://github.com/puppetlabs/puppet-runtime/pull/109.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/issues/109","number":109,"state":"open","locked":false,"title":"(PDK-1056) Revert multi-version components to multiple single version components","user":{"login":"rodjek","id":80629,"node_id":"MDQ6VXNlcjgwNjI5","avatar_url":"https://avatars2.githubusercontent.com/u/80629?v=4","gravatar_id":"","url":"https://api.github.com/users/rodjek","html_url":"https://github.com/rodjek","followers_url":"https://api.github.com/users/rodjek/followers","following_url":"https://api.github.com/users/rodjek/following{/other_user}","gists_url":"https://api.github.com/users/rodjek/gists{/gist_id}","starred_url":"https://api.github.com/users/rodjek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodjek/subscriptions","organizations_url":"https://api.github.com/users/rodjek/orgs","repos_url":"https://api.github.com/users/rodjek/repos","events_url":"https://api.github.com/users/rodjek/events{/privacy}","received_events_url":"https://api.github.com/users/rodjek/received_events","type":"User","site_admin":false},"body":"Unfortunately, looping through the additional rubies in a single components doesn't result in the expected outcome due to the way the DSL writes out the component Makefiles. The `build` and `install` commands end up getting grouped together rather than getting executed in evaluation order.\r\n\r\nSo instead of:\r\n\r\n1. build (2.1.9)\r\n2. install (2.1.9)\r\n3. build (2.5.1)\r\n4. install (2.5.1)\r\n\r\nWe get:\r\n\r\n1. build (2.1.9)\r\n2. build (2.5.1)\r\n3. install (2.1.9)\r\n4. install (2.5.1)\r\n\r\nIn the case that @bmjen noticed on Friday, this lead to a version of `libselinux.so` that was linked against Ruby 2.5.1 being installed in the Ruby 2.1.9 runtime (as the 2.5.1 build command clobbered the artifacts of the 2.1.9 build command).\r\n\r\nIn order to unblock shipping PDK 1.7.1, this PR reverts the multi-ruby components back into single-ruby components. We can come back to this later and make it more efficient.","created_at":"2018-10-08T02:17:05Z","updated_at":"2018-10-08T02:58:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eb5e1810a32dd690d5ad35e44ebbfa5f7b1ab83","assignee":null,"assignees":[],"requested_reviewers":[{"login":"scotje","id":9058,"node_id":"MDQ6VXNlcjkwNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9058?v=4","gravatar_id":"","url":"https://api.github.com/users/scotje","html_url":"https://github.com/scotje","followers_url":"https://api.github.com/users/scotje/followers","following_url":"https://api.github.com/users/scotje/following{/other_user}","gists_url":"https://api.github.com/users/scotje/gists{/gist_id}","starred_url":"https://api.github.com/users/scotje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scotje/subscriptions","organizations_url":"https://api.github.com/users/scotje/orgs","repos_url":"https://api.github.com/users/scotje/repos","events_url":"https://api.github.com/users/scotje/events{/privacy}","received_events_url":"https://api.github.com/users/scotje/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/109/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/109/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/issues/109/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/statuses/03b18e60cd783f6919a7209fab4ab9929821db78","head":{"label":"rodjek:revert_pdk_multi_components","ref":"revert_pdk_multi_components","sha":"03b18e60cd783f6919a7209fab4ab9929821db78","user":{"login":"rodjek","id":80629,"node_id":"MDQ6VXNlcjgwNjI5","avatar_url":"https://avatars2.githubusercontent.com/u/80629?v=4","gravatar_id":"","url":"https://api.github.com/users/rodjek","html_url":"https://github.com/rodjek","followers_url":"https://api.github.com/users/rodjek/followers","following_url":"https://api.github.com/users/rodjek/following{/other_user}","gists_url":"https://api.github.com/users/rodjek/gists{/gist_id}","starred_url":"https://api.github.com/users/rodjek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodjek/subscriptions","organizations_url":"https://api.github.com/users/rodjek/orgs","repos_url":"https://api.github.com/users/rodjek/repos","events_url":"https://api.github.com/users/rodjek/events{/privacy}","received_events_url":"https://api.github.com/users/rodjek/received_events","type":"User","site_admin":false},"repo":{"id":152005017,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwMDUwMTc=","name":"puppet-runtime","full_name":"rodjek/puppet-runtime","private":false,"owner":{"login":"rodjek","id":80629,"node_id":"MDQ6VXNlcjgwNjI5","avatar_url":"https://avatars2.githubusercontent.com/u/80629?v=4","gravatar_id":"","url":"https://api.github.com/users/rodjek","html_url":"https://github.com/rodjek","followers_url":"https://api.github.com/users/rodjek/followers","following_url":"https://api.github.com/users/rodjek/following{/other_user}","gists_url":"https://api.github.com/users/rodjek/gists{/gist_id}","starred_url":"https://api.github.com/users/rodjek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodjek/subscriptions","organizations_url":"https://api.github.com/users/rodjek/orgs","repos_url":"https://api.github.com/users/rodjek/repos","events_url":"https://api.github.com/users/rodjek/events{/privacy}","received_events_url":"https://api.github.com/users/rodjek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rodjek/puppet-runtime","description":"runtime dependencies for Vanagon projects","fork":true,"url":"https://api.github.com/repos/rodjek/puppet-runtime","forks_url":"https://api.github.com/repos/rodjek/puppet-runtime/forks","keys_url":"https://api.github.com/repos/rodjek/puppet-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rodjek/puppet-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rodjek/puppet-runtime/teams","hooks_url":"https://api.github.com/repos/rodjek/puppet-runtime/hooks","issue_events_url":"https://api.github.com/repos/rodjek/puppet-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/rodjek/puppet-runtime/events","assignees_url":"https://api.github.com/repos/rodjek/puppet-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/rodjek/puppet-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/rodjek/puppet-runtime/tags","blobs_url":"https://api.github.com/repos/rodjek/puppet-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rodjek/puppet-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rodjek/puppet-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/rodjek/puppet-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rodjek/puppet-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/rodjek/puppet-runtime/languages","stargazers_url":"https://api.github.com/repos/rodjek/puppet-runtime/stargazers","contributors_url":"https://api.github.com/repos/rodjek/puppet-runtime/contributors","subscribers_url":"https://api.github.com/repos/rodjek/puppet-runtime/subscribers","subscription_url":"https://api.github.com/repos/rodjek/puppet-runtime/subscription","commits_url":"https://api.github.com/repos/rodjek/puppet-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/rodjek/puppet-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/rodjek/puppet-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/rodjek/puppet-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/rodjek/puppet-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/rodjek/puppet-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rodjek/puppet-runtime/merges","archive_url":"https://api.github.com/repos/rodjek/puppet-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rodjek/puppet-runtime/downloads","issues_url":"https://api.github.com/repos/rodjek/puppet-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/rodjek/puppet-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/rodjek/puppet-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/rodjek/puppet-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rodjek/puppet-runtime/labels{/name}","releases_url":"https://api.github.com/repos/rodjek/puppet-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/rodjek/puppet-runtime/deployments","created_at":"2018-10-08T02:03:52Z","updated_at":"2018-10-08T02:03:55Z","pushed_at":"2018-10-08T02:57:44Z","git_url":"git://github.com/rodjek/puppet-runtime.git","ssh_url":"git@github.com:rodjek/puppet-runtime.git","clone_url":"https://github.com/rodjek/puppet-runtime.git","svn_url":"https://github.com/rodjek/puppet-runtime","homepage":null,"size":683,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"a64fcec4027ac009a4f0ebe49cac385dba9c62c2","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":103158500,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMxNTg1MDA=","name":"puppet-runtime","full_name":"puppetlabs/puppet-runtime","private":false,"owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/puppetlabs/puppet-runtime","description":"runtime dependencies for Vanagon projects","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-runtime","forks_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet-runtime/deployments","created_at":"2017-09-11T16:11:23Z","updated_at":"2018-10-05T15:51:23Z","pushed_at":"2018-10-08T02:57:46Z","git_url":"git://github.com/puppetlabs/puppet-runtime.git","ssh_url":"git@github.com:puppetlabs/puppet-runtime.git","clone_url":"https://github.com/puppetlabs/puppet-runtime.git","svn_url":"https://github.com/puppetlabs/puppet-runtime","homepage":null,"size":683,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":32,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/109"},"html":{"href":"https://github.com/puppetlabs/puppet-runtime/pull/109"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-runtime/issues/109"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-runtime/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-runtime/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-runtime/statuses/03b18e60cd783f6919a7209fab4ab9929821db78"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rodjek"}}