{"action":"closed","number":1671,"pull_request":{"url":"https://api.github.com/repos/marmelab/admin-on-rest/pulls/1671","id":175861504,"html_url":"https://github.com/marmelab/admin-on-rest/pull/1671","diff_url":"https://github.com/marmelab/admin-on-rest/pull/1671.diff","patch_url":"https://github.com/marmelab/admin-on-rest/pull/1671.patch","issue_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1671","number":1671,"state":"closed","locked":false,"title":"[RFR]: SelectArrayInput don't translate when optionText is a React Component","user":{"login":"tkvw","id":621098,"avatar_url":"https://avatars1.githubusercontent.com/u/621098?v=4","gravatar_id":"","url":"https://api.github.com/users/tkvw","html_url":"https://github.com/tkvw","followers_url":"https://api.github.com/users/tkvw/followers","following_url":"https://api.github.com/users/tkvw/following{/other_user}","gists_url":"https://api.github.com/users/tkvw/gists{/gist_id}","starred_url":"https://api.github.com/users/tkvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkvw/subscriptions","organizations_url":"https://api.github.com/users/tkvw/orgs","repos_url":"https://api.github.com/users/tkvw/repos","events_url":"https://api.github.com/users/tkvw/events{/privacy}","received_events_url":"https://api.github.com/users/tkvw/received_events","type":"User","site_admin":false},"body":"The translate option did not check if the optionText is a component. Component clones should not be translated. Added `translate` prop to clone properties. ","created_at":"2018-03-19T10:44:38Z","updated_at":"2018-03-21T20:53:11Z","closed_at":"2018-03-21T20:53:11Z","merged_at":"2018-03-21T20:53:11Z","merge_commit_sha":"2a02e03b27eed5377623fd50a428565a00e8e3b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/marmelab/admin-on-rest/pulls/1671/commits","review_comments_url":"https://api.github.com/repos/marmelab/admin-on-rest/pulls/1671/comments","review_comment_url":"https://api.github.com/repos/marmelab/admin-on-rest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1671/comments","statuses_url":"https://api.github.com/repos/marmelab/admin-on-rest/statuses/32391f0c6fd92df4588dee421f39bf49b9b24557","head":{"label":"tkvw:selectinput","ref":"selectinput","sha":"32391f0c6fd92df4588dee421f39bf49b9b24557","user":{"login":"tkvw","id":621098,"avatar_url":"https://avatars1.githubusercontent.com/u/621098?v=4","gravatar_id":"","url":"https://api.github.com/users/tkvw","html_url":"https://github.com/tkvw","followers_url":"https://api.github.com/users/tkvw/followers","following_url":"https://api.github.com/users/tkvw/following{/other_user}","gists_url":"https://api.github.com/users/tkvw/gists{/gist_id}","starred_url":"https://api.github.com/users/tkvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkvw/subscriptions","organizations_url":"https://api.github.com/users/tkvw/orgs","repos_url":"https://api.github.com/users/tkvw/repos","events_url":"https://api.github.com/users/tkvw/events{/privacy}","received_events_url":"https://api.github.com/users/tkvw/received_events","type":"User","site_admin":false},"repo":{"id":111396630,"name":"admin-on-rest","full_name":"tkvw/admin-on-rest","owner":{"login":"tkvw","id":621098,"avatar_url":"https://avatars1.githubusercontent.com/u/621098?v=4","gravatar_id":"","url":"https://api.github.com/users/tkvw","html_url":"https://github.com/tkvw","followers_url":"https://api.github.com/users/tkvw/followers","following_url":"https://api.github.com/users/tkvw/following{/other_user}","gists_url":"https://api.github.com/users/tkvw/gists{/gist_id}","starred_url":"https://api.github.com/users/tkvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkvw/subscriptions","organizations_url":"https://api.github.com/users/tkvw/orgs","repos_url":"https://api.github.com/users/tkvw/repos","events_url":"https://api.github.com/users/tkvw/events{/privacy}","received_events_url":"https://api.github.com/users/tkvw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkvw/admin-on-rest","description":"A frontend framework for building admin SPAs on top of REST services, using React and Material Design","fork":true,"url":"https://api.github.com/repos/tkvw/admin-on-rest","forks_url":"https://api.github.com/repos/tkvw/admin-on-rest/forks","keys_url":"https://api.github.com/repos/tkvw/admin-on-rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkvw/admin-on-rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkvw/admin-on-rest/teams","hooks_url":"https://api.github.com/repos/tkvw/admin-on-rest/hooks","issue_events_url":"https://api.github.com/repos/tkvw/admin-on-rest/issues/events{/number}","events_url":"https://api.github.com/repos/tkvw/admin-on-rest/events","assignees_url":"https://api.github.com/repos/tkvw/admin-on-rest/assignees{/user}","branches_url":"https://api.github.com/repos/tkvw/admin-on-rest/branches{/branch}","tags_url":"https://api.github.com/repos/tkvw/admin-on-rest/tags","blobs_url":"https://api.github.com/repos/tkvw/admin-on-rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkvw/admin-on-rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkvw/admin-on-rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkvw/admin-on-rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkvw/admin-on-rest/statuses/{sha}","languages_url":"https://api.github.com/repos/tkvw/admin-on-rest/languages","stargazers_url":"https://api.github.com/repos/tkvw/admin-on-rest/stargazers","contributors_url":"https://api.github.com/repos/tkvw/admin-on-rest/contributors","subscribers_url":"https://api.github.com/repos/tkvw/admin-on-rest/subscribers","subscription_url":"https://api.github.com/repos/tkvw/admin-on-rest/subscription","commits_url":"https://api.github.com/repos/tkvw/admin-on-rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkvw/admin-on-rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkvw/admin-on-rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkvw/admin-on-rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkvw/admin-on-rest/contents/{+path}","compare_url":"https://api.github.com/repos/tkvw/admin-on-rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkvw/admin-on-rest/merges","archive_url":"https://api.github.com/repos/tkvw/admin-on-rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkvw/admin-on-rest/downloads","issues_url":"https://api.github.com/repos/tkvw/admin-on-rest/issues{/number}","pulls_url":"https://api.github.com/repos/tkvw/admin-on-rest/pulls{/number}","milestones_url":"https://api.github.com/repos/tkvw/admin-on-rest/milestones{/number}","notifications_url":"https://api.github.com/repos/tkvw/admin-on-rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkvw/admin-on-rest/labels{/name}","releases_url":"https://api.github.com/repos/tkvw/admin-on-rest/releases{/id}","deployments_url":"https://api.github.com/repos/tkvw/admin-on-rest/deployments","created_at":"2017-11-20T10:37:39Z","updated_at":"2017-11-20T10:37:42Z","pushed_at":"2018-03-21T15:49:27Z","git_url":"git://github.com/tkvw/admin-on-rest.git","ssh_url":"git@github.com:tkvw/admin-on-rest.git","clone_url":"https://github.com/tkvw/admin-on-rest.git","svn_url":"https://github.com/tkvw/admin-on-rest","homepage":"http://marmelab.com/admin-on-rest","size":78077,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marmelab:next","ref":"next","sha":"b907ffffa86f3ac029cda504c1ec1ad1f8fc8878","user":{"login":"marmelab","id":3116319,"avatar_url":"https://avatars1.githubusercontent.com/u/3116319?v=4","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"repo":{"id":63226588,"name":"admin-on-rest","full_name":"marmelab/admin-on-rest","owner":{"login":"marmelab","id":3116319,"avatar_url":"https://avatars1.githubusercontent.com/u/3116319?v=4","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marmelab/admin-on-rest","description":"A frontend framework for building admin SPAs on top of REST services, using React and Material Design","fork":false,"url":"https://api.github.com/repos/marmelab/admin-on-rest","forks_url":"https://api.github.com/repos/marmelab/admin-on-rest/forks","keys_url":"https://api.github.com/repos/marmelab/admin-on-rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marmelab/admin-on-rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marmelab/admin-on-rest/teams","hooks_url":"https://api.github.com/repos/marmelab/admin-on-rest/hooks","issue_events_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/events{/number}","events_url":"https://api.github.com/repos/marmelab/admin-on-rest/events","assignees_url":"https://api.github.com/repos/marmelab/admin-on-rest/assignees{/user}","branches_url":"https://api.github.com/repos/marmelab/admin-on-rest/branches{/branch}","tags_url":"https://api.github.com/repos/marmelab/admin-on-rest/tags","blobs_url":"https://api.github.com/repos/marmelab/admin-on-rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marmelab/admin-on-rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marmelab/admin-on-rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/marmelab/admin-on-rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marmelab/admin-on-rest/statuses/{sha}","languages_url":"https://api.github.com/repos/marmelab/admin-on-rest/languages","stargazers_url":"https://api.github.com/repos/marmelab/admin-on-rest/stargazers","contributors_url":"https://api.github.com/repos/marmelab/admin-on-rest/contributors","subscribers_url":"https://api.github.com/repos/marmelab/admin-on-rest/subscribers","subscription_url":"https://api.github.com/repos/marmelab/admin-on-rest/subscription","commits_url":"https://api.github.com/repos/marmelab/admin-on-rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/marmelab/admin-on-rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/marmelab/admin-on-rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/marmelab/admin-on-rest/contents/{+path}","compare_url":"https://api.github.com/repos/marmelab/admin-on-rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marmelab/admin-on-rest/merges","archive_url":"https://api.github.com/repos/marmelab/admin-on-rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marmelab/admin-on-rest/downloads","issues_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues{/number}","pulls_url":"https://api.github.com/repos/marmelab/admin-on-rest/pulls{/number}","milestones_url":"https://api.github.com/repos/marmelab/admin-on-rest/milestones{/number}","notifications_url":"https://api.github.com/repos/marmelab/admin-on-rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marmelab/admin-on-rest/labels{/name}","releases_url":"https://api.github.com/repos/marmelab/admin-on-rest/releases{/id}","deployments_url":"https://api.github.com/repos/marmelab/admin-on-rest/deployments","created_at":"2016-07-13T07:58:54Z","updated_at":"2018-03-21T20:34:34Z","pushed_at":"2018-03-21T20:53:11Z","git_url":"git://github.com/marmelab/admin-on-rest.git","ssh_url":"git@github.com:marmelab/admin-on-rest.git","clone_url":"https://github.com/marmelab/admin-on-rest.git","svn_url":"https://github.com/marmelab/admin-on-rest","homepage":"http://marmelab.com/admin-on-rest","size":78096,"stargazers_count":3860,"watchers_count":3860,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":752,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":752,"open_issues":54,"watchers":3860,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marmelab/admin-on-rest/pulls/1671"},"html":{"href":"https://github.com/marmelab/admin-on-rest/pull/1671"},"issue":{"href":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1671"},"comments":{"href":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1671/comments"},"review_comments":{"href":"https://api.github.com/repos/marmelab/admin-on-rest/pulls/1671/comments"},"review_comment":{"href":"https://api.github.com/repos/marmelab/admin-on-rest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marmelab/admin-on-rest/pulls/1671/commits"},"statuses":{"href":"https://api.github.com/repos/marmelab/admin-on-rest/statuses/32391f0c6fd92df4588dee421f39bf49b9b24557"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fzaninotto","id":99944,"avatar_url":"https://avatars3.githubusercontent.com/u/99944?v=4","gravatar_id":"","url":"https://api.github.com/users/fzaninotto","html_url":"https://github.com/fzaninotto","followers_url":"https://api.github.com/users/fzaninotto/followers","following_url":"https://api.github.com/users/fzaninotto/following{/other_user}","gists_url":"https://api.github.com/users/fzaninotto/gists{/gist_id}","starred_url":"https://api.github.com/users/fzaninotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzaninotto/subscriptions","organizations_url":"https://api.github.com/users/fzaninotto/orgs","repos_url":"https://api.github.com/users/fzaninotto/repos","events_url":"https://api.github.com/users/fzaninotto/events{/privacy}","received_events_url":"https://api.github.com/users/fzaninotto/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":35,"deletions":22,"changed_files":2}}
{"actor":{"display_login":"fzaninotto"}}