{"action":"opened","number":811,"pull_request":{"url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/811","id":171217712,"html_url":"https://github.com/wildfly-swarm/wildfly-swarm/pull/811","diff_url":"https://github.com/wildfly-swarm/wildfly-swarm/pull/811.diff","patch_url":"https://github.com/wildfly-swarm/wildfly-swarm/pull/811.patch","issue_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/811","number":811,"state":"open","locked":false,"title":"SWARM-1813 Configuring interfaces through YAML doesn't work","user":{"login":"johnAls","id":1553684,"avatar_url":"https://avatars0.githubusercontent.com/u/1553684?v=4","gravatar_id":"","url":"https://api.github.com/users/johnAls","html_url":"https://github.com/johnAls","followers_url":"https://api.github.com/users/johnAls/followers","following_url":"https://api.github.com/users/johnAls/following{/other_user}","gists_url":"https://api.github.com/users/johnAls/gists{/gist_id}","starred_url":"https://api.github.com/users/johnAls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnAls/subscriptions","organizations_url":"https://api.github.com/users/johnAls/orgs","repos_url":"https://api.github.com/users/johnAls/repos","events_url":"https://api.github.com/users/johnAls/events{/privacy}","received_events_url":"https://api.github.com/users/johnAls/received_events","type":"User","site_admin":false},"body":"InterfaceExtension did handle configuration of interfaces with yaml but it was if statement that always was false, don't really understand the purpose of it. \r\nSo removed the statement added so you can handle defaultInterface in SocketBindingGroup so exempel \r\n``` \r\nnetwork:\r\n  socket-binding-groups:\r\n      standard-sockets:\r\n        default-interface: other\r\n    interfaces:\r\n      other:\r\n        bind: 192.168.1.48\r\n      public:\r\n        bind: 127.0.0.1\r\n```\r\nwill now work\r\n\r\n- [x] Have you followed the guidelines in our [Contributing](http://wildfly-swarm.io/community/contributing/) document?\r\n- [x] Have you created a [JIRA](https://issues.jboss.org/browse/SWARM) and used it in the commit message?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/wildfly-swarm/wildfly-swarm/pulls) for the same issue?\r\n- [x] Have you built the project locally prior to submission with `mvn clean install`?\r\n\r\n-----\r\n","created_at":"2018-02-25T07:34:57Z","updated_at":"2018-02-25T07:34:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/811/commits","review_comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/811/comments","review_comment_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/811/comments","statuses_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/statuses/e364fe63ad058cd1a92cf63ce8dbfbb405416642","head":{"label":"johnAls:SWARM-1813","ref":"SWARM-1813","sha":"e364fe63ad058cd1a92cf63ce8dbfbb405416642","user":{"login":"johnAls","id":1553684,"avatar_url":"https://avatars0.githubusercontent.com/u/1553684?v=4","gravatar_id":"","url":"https://api.github.com/users/johnAls","html_url":"https://github.com/johnAls","followers_url":"https://api.github.com/users/johnAls/followers","following_url":"https://api.github.com/users/johnAls/following{/other_user}","gists_url":"https://api.github.com/users/johnAls/gists{/gist_id}","starred_url":"https://api.github.com/users/johnAls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnAls/subscriptions","organizations_url":"https://api.github.com/users/johnAls/orgs","repos_url":"https://api.github.com/users/johnAls/repos","events_url":"https://api.github.com/users/johnAls/events{/privacy}","received_events_url":"https://api.github.com/users/johnAls/received_events","type":"User","site_admin":false},"repo":{"id":118516339,"name":"wildfly-swarm","full_name":"johnAls/wildfly-swarm","owner":{"login":"johnAls","id":1553684,"avatar_url":"https://avatars0.githubusercontent.com/u/1553684?v=4","gravatar_id":"","url":"https://api.github.com/users/johnAls","html_url":"https://github.com/johnAls","followers_url":"https://api.github.com/users/johnAls/followers","following_url":"https://api.github.com/users/johnAls/following{/other_user}","gists_url":"https://api.github.com/users/johnAls/gists{/gist_id}","starred_url":"https://api.github.com/users/johnAls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnAls/subscriptions","organizations_url":"https://api.github.com/users/johnAls/orgs","repos_url":"https://api.github.com/users/johnAls/repos","events_url":"https://api.github.com/users/johnAls/events{/privacy}","received_events_url":"https://api.github.com/users/johnAls/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnAls/wildfly-swarm","description":"Source code for the WildFly Swarm project","fork":true,"url":"https://api.github.com/repos/johnAls/wildfly-swarm","forks_url":"https://api.github.com/repos/johnAls/wildfly-swarm/forks","keys_url":"https://api.github.com/repos/johnAls/wildfly-swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnAls/wildfly-swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnAls/wildfly-swarm/teams","hooks_url":"https://api.github.com/repos/johnAls/wildfly-swarm/hooks","issue_events_url":"https://api.github.com/repos/johnAls/wildfly-swarm/issues/events{/number}","events_url":"https://api.github.com/repos/johnAls/wildfly-swarm/events","assignees_url":"https://api.github.com/repos/johnAls/wildfly-swarm/assignees{/user}","branches_url":"https://api.github.com/repos/johnAls/wildfly-swarm/branches{/branch}","tags_url":"https://api.github.com/repos/johnAls/wildfly-swarm/tags","blobs_url":"https://api.github.com/repos/johnAls/wildfly-swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnAls/wildfly-swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnAls/wildfly-swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnAls/wildfly-swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnAls/wildfly-swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/johnAls/wildfly-swarm/languages","stargazers_url":"https://api.github.com/repos/johnAls/wildfly-swarm/stargazers","contributors_url":"https://api.github.com/repos/johnAls/wildfly-swarm/contributors","subscribers_url":"https://api.github.com/repos/johnAls/wildfly-swarm/subscribers","subscription_url":"https://api.github.com/repos/johnAls/wildfly-swarm/subscription","commits_url":"https://api.github.com/repos/johnAls/wildfly-swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnAls/wildfly-swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnAls/wildfly-swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnAls/wildfly-swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnAls/wildfly-swarm/contents/{+path}","compare_url":"https://api.github.com/repos/johnAls/wildfly-swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnAls/wildfly-swarm/merges","archive_url":"https://api.github.com/repos/johnAls/wildfly-swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnAls/wildfly-swarm/downloads","issues_url":"https://api.github.com/repos/johnAls/wildfly-swarm/issues{/number}","pulls_url":"https://api.github.com/repos/johnAls/wildfly-swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/johnAls/wildfly-swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/johnAls/wildfly-swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnAls/wildfly-swarm/labels{/name}","releases_url":"https://api.github.com/repos/johnAls/wildfly-swarm/releases{/id}","deployments_url":"https://api.github.com/repos/johnAls/wildfly-swarm/deployments","created_at":"2018-01-22T21:16:09Z","updated_at":"2018-01-22T21:16:15Z","pushed_at":"2018-02-24T22:30:14Z","git_url":"git://github.com/johnAls/wildfly-swarm.git","ssh_url":"git@github.com:johnAls/wildfly-swarm.git","clone_url":"https://github.com/johnAls/wildfly-swarm.git","svn_url":"https://github.com/johnAls/wildfly-swarm","homepage":"http://wildfly-swarm.io/","size":16186,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly-swarm:master","ref":"master","sha":"afa5d91e3c3c72ad83344166da46a11cd6a9113a","user":{"login":"wildfly-swarm","id":11523816,"avatar_url":"https://avatars0.githubusercontent.com/u/11523816?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly-swarm","html_url":"https://github.com/wildfly-swarm","followers_url":"https://api.github.com/users/wildfly-swarm/followers","following_url":"https://api.github.com/users/wildfly-swarm/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-swarm/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-swarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-swarm/subscriptions","organizations_url":"https://api.github.com/users/wildfly-swarm/orgs","repos_url":"https://api.github.com/users/wildfly-swarm/repos","events_url":"https://api.github.com/users/wildfly-swarm/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-swarm/received_events","type":"Organization","site_admin":false},"repo":{"id":52040340,"name":"wildfly-swarm","full_name":"wildfly-swarm/wildfly-swarm","owner":{"login":"wildfly-swarm","id":11523816,"avatar_url":"https://avatars0.githubusercontent.com/u/11523816?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly-swarm","html_url":"https://github.com/wildfly-swarm","followers_url":"https://api.github.com/users/wildfly-swarm/followers","following_url":"https://api.github.com/users/wildfly-swarm/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-swarm/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-swarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-swarm/subscriptions","organizations_url":"https://api.github.com/users/wildfly-swarm/orgs","repos_url":"https://api.github.com/users/wildfly-swarm/repos","events_url":"https://api.github.com/users/wildfly-swarm/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-swarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly-swarm/wildfly-swarm","description":"Source code for the WildFly Swarm project","fork":false,"url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm","forks_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/forks","keys_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/teams","hooks_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/hooks","issue_events_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/events","assignees_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/tags","blobs_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/languages","stargazers_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/stargazers","contributors_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/contributors","subscribers_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/subscribers","subscription_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/subscription","commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/merges","archive_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/downloads","issues_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/labels{/name}","releases_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/deployments","created_at":"2016-02-18T21:32:47Z","updated_at":"2018-02-23T08:44:51Z","pushed_at":"2018-02-23T20:35:29Z","git_url":"git://github.com/wildfly-swarm/wildfly-swarm.git","ssh_url":"git@github.com:wildfly-swarm/wildfly-swarm.git","clone_url":"https://github.com/wildfly-swarm/wildfly-swarm.git","svn_url":"https://github.com/wildfly-swarm/wildfly-swarm","homepage":"http://wildfly-swarm.io/","size":16381,"stargazers_count":224,"watchers_count":224,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":170,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":170,"open_issues":4,"watchers":224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/811"},"html":{"href":"https://github.com/wildfly-swarm/wildfly-swarm/pull/811"},"issue":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/811"},"comments":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/issues/811/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/811/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/pulls/811/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm/statuses/e364fe63ad058cd1a92cf63ce8dbfbb405416642"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":62,"deletions":8,"changed_files":4}}
{"actor":{"display_login":"johnAls"}}