{"action":"created","issue":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/543","repository_url":"https://api.github.com/repos/Caltech-IPAC/firefly","labels_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/543/labels{/name}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/543/comments","events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/543/events","html_url":"https://github.com/Caltech-IPAC/firefly/pull/543","id":294553489,"number":543,"title":"DM-13326 Fixed issues on circular selection per feedback from IRSA tester","user":{"login":"cwang2016","id":17187356,"avatar_url":"https://avatars1.githubusercontent.com/u/17187356?v=4","gravatar_id":"","url":"https://api.github.com/users/cwang2016","html_url":"https://github.com/cwang2016","followers_url":"https://api.github.com/users/cwang2016/followers","following_url":"https://api.github.com/users/cwang2016/following{/other_user}","gists_url":"https://api.github.com/users/cwang2016/gists{/gist_id}","starred_url":"https://api.github.com/users/cwang2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwang2016/subscriptions","organizations_url":"https://api.github.com/users/cwang2016/orgs","repos_url":"https://api.github.com/users/cwang2016/repos","events_url":"https://api.github.com/users/cwang2016/events{/privacy}","received_events_url":"https://api.github.com/users/cwang2016/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cwang2016","id":17187356,"avatar_url":"https://avatars1.githubusercontent.com/u/17187356?v=4","gravatar_id":"","url":"https://api.github.com/users/cwang2016","html_url":"https://github.com/cwang2016","followers_url":"https://api.github.com/users/cwang2016/followers","following_url":"https://api.github.com/users/cwang2016/following{/other_user}","gists_url":"https://api.github.com/users/cwang2016/gists{/gist_id}","starred_url":"https://api.github.com/users/cwang2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwang2016/subscriptions","organizations_url":"https://api.github.com/users/cwang2016/orgs","repos_url":"https://api.github.com/users/cwang2016/repos","events_url":"https://api.github.com/users/cwang2016/events{/privacy}","received_events_url":"https://api.github.com/users/cwang2016/received_events","type":"User","site_admin":false},"assignees":[{"login":"cwang2016","id":17187356,"avatar_url":"https://avatars1.githubusercontent.com/u/17187356?v=4","gravatar_id":"","url":"https://api.github.com/users/cwang2016","html_url":"https://github.com/cwang2016","followers_url":"https://api.github.com/users/cwang2016/followers","following_url":"https://api.github.com/users/cwang2016/following{/other_user}","gists_url":"https://api.github.com/users/cwang2016/gists{/gist_id}","starred_url":"https://api.github.com/users/cwang2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwang2016/subscriptions","organizations_url":"https://api.github.com/users/cwang2016/orgs","repos_url":"https://api.github.com/users/cwang2016/repos","events_url":"https://api.github.com/users/cwang2016/events{/privacy}","received_events_url":"https://api.github.com/users/cwang2016/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-02-05T21:46:08Z","updated_at":"2018-02-05T21:51:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/543","html_url":"https://github.com/Caltech-IPAC/firefly/pull/543","diff_url":"https://github.com/Caltech-IPAC/firefly/pull/543.diff","patch_url":"https://github.com/Caltech-IPAC/firefly/pull/543.patch"},"body":"The development is made per ticket of \r\nhttps://jira.lsstcorp.org/browse/DM-13326\r\n\r\n- remove the select area layer after the selected area is cropped or zoomed (to fit selected area)\r\n- for circular selection, a circular region in red is shown on the top of cropped or zoomed (to fit selected area) image in order to indicate the selected (elliptical) area. This is done by using ImageOutline drawing layer, and ImageOutline drawing layer is updated to be generic to contain any Firefly defined drawing object. \r\n- the image is re-centered at the center of the selected area in case 'recenter image to selected area' is clicked after 'select an area'. \r\n- Fix the select area help text shown in overlay display menu. \r\n\r\ntest:\r\ndo image search on Firefly, \r\nclick 'select area' button and make 'Elliptical selection' and make a selection\r\ntry 'crop', 'zoom to fit selected area' or 'recenter image to select area' respectively. \r\ntry 'restore to the defaults' to resume the image \r\ncheck the title and help line for select area in 'overlay display' menu. \r\n\r\nrepeat the test on rotated image. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/comments/363233624","html_url":"https://github.com/Caltech-IPAC/firefly/pull/543#issuecomment-363233624","issue_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/543","id":363233624,"user":{"login":"cwang2016","id":17187356,"avatar_url":"https://avatars1.githubusercontent.com/u/17187356?v=4","gravatar_id":"","url":"https://api.github.com/users/cwang2016","html_url":"https://github.com/cwang2016","followers_url":"https://api.github.com/users/cwang2016/followers","following_url":"https://api.github.com/users/cwang2016/following{/other_user}","gists_url":"https://api.github.com/users/cwang2016/gists{/gist_id}","starred_url":"https://api.github.com/users/cwang2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwang2016/subscriptions","organizations_url":"https://api.github.com/users/cwang2016/orgs","repos_url":"https://api.github.com/users/cwang2016/repos","events_url":"https://api.github.com/users/cwang2016/events{/privacy}","received_events_url":"https://api.github.com/users/cwang2016/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T21:51:53Z","updated_at":"2018-02-05T21:51:53Z","author_association":"CONTRIBUTOR","body":"some issue is found regarding image crop on selected area. \r\n- should image crop be applied to all plots if no image is unlocked? the current code may crop only one image when no image is unlocked. \r\n"}}
{"actor":{"display_login":"cwang2016"}}