{"action":"created","comment":{"url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/comments/166883222","pull_request_review_id":95014412,"id":166883222,"diff_hunk":"@@ -85,6 +93,40 @@ public Fabric8WorkspaceEnvironmentProvider(\n             .build(CacheLoader.from(this::loadUserCheTenantData));\n   }\n \n+  @Inject\n+  private void setServiceAccountToken(\n+      @Named(\"che.openshift.service_account.auth_enable\") boolean enableServiceAccountTokenAuth,\n+      @Nullable @Named(\"che.openshift.service_account.secret\") String serviceAccSecret,\n+      @Nullable @Named(\"che.openshift.service_account.id\") String serviceAccId,\n+      @Nullable @Named(\"che.fabric8.auth.endpoint\") String authEndpoint) {","path":"plugins/fabric8-multi-tenant-manager/src/main/java/com/redhat/che/multitenant/Fabric8WorkspaceEnvironmentProvider.java","position":45,"original_position":45,"commit_id":"8dc1cc144b9f81e513f415366436789a11b0b7da","original_commit_id":"8dc1cc144b9f81e513f415366436789a11b0b7da","user":{"login":"garagatyi","id":1851863,"avatar_url":"https://avatars0.githubusercontent.com/u/1851863?v=4","gravatar_id":"","url":"https://api.github.com/users/garagatyi","html_url":"https://github.com/garagatyi","followers_url":"https://api.github.com/users/garagatyi/followers","following_url":"https://api.github.com/users/garagatyi/following{/other_user}","gists_url":"https://api.github.com/users/garagatyi/gists{/gist_id}","starred_url":"https://api.github.com/users/garagatyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garagatyi/subscriptions","organizations_url":"https://api.github.com/users/garagatyi/orgs","repos_url":"https://api.github.com/users/garagatyi/repos","events_url":"https://api.github.com/users/garagatyi/events{/privacy}","received_events_url":"https://api.github.com/users/garagatyi/received_events","type":"User","site_admin":false},"body":"tnx","created_at":"2018-02-08T10:03:40Z","updated_at":"2018-02-08T10:03:40Z","html_url":"https://github.com/redhat-developer/rh-che/pull/538#discussion_r166883222","pull_request_url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/538","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/comments/166883222"},"html":{"href":"https://github.com/redhat-developer/rh-che/pull/538#discussion_r166883222"},"pull_request":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/538"}},"in_reply_to_id":166866320},"pull_request":{"url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/538","id":167708976,"html_url":"https://github.com/redhat-developer/rh-che/pull/538","diff_url":"https://github.com/redhat-developer/rh-che/pull/538.diff","patch_url":"https://github.com/redhat-developer/rh-che/pull/538.patch","issue_url":"https://api.github.com/repos/redhat-developer/rh-che/issues/538","number":538,"state":"open","locked":false,"title":"[WIP] RH-CHE-532: add retrieving of service account token","user":{"login":"garagatyi","id":1851863,"avatar_url":"https://avatars0.githubusercontent.com/u/1851863?v=4","gravatar_id":"","url":"https://api.github.com/users/garagatyi","html_url":"https://github.com/garagatyi","followers_url":"https://api.github.com/users/garagatyi/followers","following_url":"https://api.github.com/users/garagatyi/following{/other_user}","gists_url":"https://api.github.com/users/garagatyi/gists{/gist_id}","starred_url":"https://api.github.com/users/garagatyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garagatyi/subscriptions","organizations_url":"https://api.github.com/users/garagatyi/orgs","repos_url":"https://api.github.com/users/garagatyi/repos","events_url":"https://api.github.com/users/garagatyi/events{/privacy}","received_events_url":"https://api.github.com/users/garagatyi/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nRetrieves service account token from Auth service to allow communication between Che and OS API using new auth system.\r\n@ibuziuk @davidfestal I'm not sure that I got what has to be done right, so, please, validate this solution. \r\nBTW I haven't tested this PR because I'm not sure how to do that in dev environment. And I think that because of recent addition of env vars that depends on presence of secrets I'm not sure rhche on minishift works\r\n\r\n### What issues does this PR fix or reference?\r\n#532 \r\n\r\n### How have you tested this PR?\r\n","created_at":"2018-02-07T14:33:59Z","updated_at":"2018-02-08T10:03:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a787c1f4553d2ee4fc5d2f6bd488d6d68ff15c53","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidfestal","id":686586,"avatar_url":"https://avatars1.githubusercontent.com/u/686586?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfestal","html_url":"https://github.com/davidfestal","followers_url":"https://api.github.com/users/davidfestal/followers","following_url":"https://api.github.com/users/davidfestal/following{/other_user}","gists_url":"https://api.github.com/users/davidfestal/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfestal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfestal/subscriptions","organizations_url":"https://api.github.com/users/davidfestal/orgs","repos_url":"https://api.github.com/users/davidfestal/repos","events_url":"https://api.github.com/users/davidfestal/events{/privacy}","received_events_url":"https://api.github.com/users/davidfestal/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/538/commits","review_comments_url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/538/comments","review_comment_url":"https://api.github.com/repos/redhat-developer/rh-che/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-developer/rh-che/issues/538/comments","statuses_url":"https://api.github.com/repos/redhat-developer/rh-che/statuses/8dc1cc144b9f81e513f415366436789a11b0b7da","head":{"label":"redhat-developer:garagatyi-newAuth","ref":"garagatyi-newAuth","sha":"8dc1cc144b9f81e513f415366436789a11b0b7da","user":{"login":"redhat-developer","id":11033755,"avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"repo":{"id":73191871,"name":"rh-che","full_name":"redhat-developer/rh-che","owner":{"login":"redhat-developer","id":11033755,"avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhat-developer/rh-che","description":"Red Hat Che distribution repository","fork":false,"url":"https://api.github.com/repos/redhat-developer/rh-che","forks_url":"https://api.github.com/repos/redhat-developer/rh-che/forks","keys_url":"https://api.github.com/repos/redhat-developer/rh-che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-developer/rh-che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-developer/rh-che/teams","hooks_url":"https://api.github.com/repos/redhat-developer/rh-che/hooks","issue_events_url":"https://api.github.com/repos/redhat-developer/rh-che/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-developer/rh-che/events","assignees_url":"https://api.github.com/repos/redhat-developer/rh-che/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-developer/rh-che/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-developer/rh-che/tags","blobs_url":"https://api.github.com/repos/redhat-developer/rh-che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-developer/rh-che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-developer/rh-che/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-developer/rh-che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-developer/rh-che/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-developer/rh-che/languages","stargazers_url":"https://api.github.com/repos/redhat-developer/rh-che/stargazers","contributors_url":"https://api.github.com/repos/redhat-developer/rh-che/contributors","subscribers_url":"https://api.github.com/repos/redhat-developer/rh-che/subscribers","subscription_url":"https://api.github.com/repos/redhat-developer/rh-che/subscription","commits_url":"https://api.github.com/repos/redhat-developer/rh-che/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-developer/rh-che/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-developer/rh-che/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-developer/rh-che/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-developer/rh-che/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-developer/rh-che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-developer/rh-che/merges","archive_url":"https://api.github.com/repos/redhat-developer/rh-che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-developer/rh-che/downloads","issues_url":"https://api.github.com/repos/redhat-developer/rh-che/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-developer/rh-che/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-developer/rh-che/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-developer/rh-che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-developer/rh-che/labels{/name}","releases_url":"https://api.github.com/repos/redhat-developer/rh-che/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-developer/rh-che/deployments","created_at":"2016-11-08T14:09:37Z","updated_at":"2018-01-22T09:43:27Z","pushed_at":"2018-02-07T14:34:00Z","git_url":"git://github.com/redhat-developer/rh-che.git","ssh_url":"git@github.com:redhat-developer/rh-che.git","clone_url":"https://github.com/redhat-developer/rh-che.git","svn_url":"https://github.com/redhat-developer/rh-che","homepage":"","size":3486,"stargazers_count":19,"watchers_count":19,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":30,"open_issues":68,"watchers":19,"default_branch":"master"}},"base":{"label":"redhat-developer:master","ref":"master","sha":"ecc035c44cd1c8a2f4a732214c230277fc70306c","user":{"login":"redhat-developer","id":11033755,"avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"repo":{"id":73191871,"name":"rh-che","full_name":"redhat-developer/rh-che","owner":{"login":"redhat-developer","id":11033755,"avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhat-developer/rh-che","description":"Red Hat Che distribution repository","fork":false,"url":"https://api.github.com/repos/redhat-developer/rh-che","forks_url":"https://api.github.com/repos/redhat-developer/rh-che/forks","keys_url":"https://api.github.com/repos/redhat-developer/rh-che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-developer/rh-che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-developer/rh-che/teams","hooks_url":"https://api.github.com/repos/redhat-developer/rh-che/hooks","issue_events_url":"https://api.github.com/repos/redhat-developer/rh-che/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-developer/rh-che/events","assignees_url":"https://api.github.com/repos/redhat-developer/rh-che/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-developer/rh-che/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-developer/rh-che/tags","blobs_url":"https://api.github.com/repos/redhat-developer/rh-che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-developer/rh-che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-developer/rh-che/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-developer/rh-che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-developer/rh-che/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-developer/rh-che/languages","stargazers_url":"https://api.github.com/repos/redhat-developer/rh-che/stargazers","contributors_url":"https://api.github.com/repos/redhat-developer/rh-che/contributors","subscribers_url":"https://api.github.com/repos/redhat-developer/rh-che/subscribers","subscription_url":"https://api.github.com/repos/redhat-developer/rh-che/subscription","commits_url":"https://api.github.com/repos/redhat-developer/rh-che/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-developer/rh-che/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-developer/rh-che/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-developer/rh-che/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-developer/rh-che/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-developer/rh-che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-developer/rh-che/merges","archive_url":"https://api.github.com/repos/redhat-developer/rh-che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-developer/rh-che/downloads","issues_url":"https://api.github.com/repos/redhat-developer/rh-che/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-developer/rh-che/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-developer/rh-che/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-developer/rh-che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-developer/rh-che/labels{/name}","releases_url":"https://api.github.com/repos/redhat-developer/rh-che/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-developer/rh-che/deployments","created_at":"2016-11-08T14:09:37Z","updated_at":"2018-01-22T09:43:27Z","pushed_at":"2018-02-07T14:34:00Z","git_url":"git://github.com/redhat-developer/rh-che.git","ssh_url":"git@github.com:redhat-developer/rh-che.git","clone_url":"https://github.com/redhat-developer/rh-che.git","svn_url":"https://github.com/redhat-developer/rh-che","homepage":"","size":3486,"stargazers_count":19,"watchers_count":19,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":30,"open_issues":68,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/538"},"html":{"href":"https://github.com/redhat-developer/rh-che/pull/538"},"issue":{"href":"https://api.github.com/repos/redhat-developer/rh-che/issues/538"},"comments":{"href":"https://api.github.com/repos/redhat-developer/rh-che/issues/538/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/538/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-developer/rh-che/pulls/538/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-developer/rh-che/statuses/8dc1cc144b9f81e513f415366436789a11b0b7da"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"garagatyi"}}