{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/234442561","pull_request_review_id":176087538,"id":234442561,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQ0MjU2MQ==","diff_hunk":"@@ -177,7 +177,10 @@ Miscellaneous\n \n - |Fix| Removed all mentions of `sklearn.externals.joblib`, and deprecated\n   joblib methods exposed in `sklearn.utils`, except for\n-  :func:`utils.parallel_backend` and :func:`utils.register_parallel_backend`.\n+  :func:`utils.parallel_backend` and :func:`utils.register_parallel_backend`,\n+  which impact the behavior of `sklearn`. Other functionalities are part of\n+  the [joblib](https://joblib.readthedocs.io/) package and should be used","path":"doc/whats_new/v0.20.rst","position":8,"original_position":7,"commit_id":"b9d3726c14147ec771135aed4a399d24aaff0ba4","original_commit_id":"b9d3726c14147ec771135aed4a399d24aaff0ba4","user":{"login":"rth","id":630936,"node_id":"MDQ6VXNlcjYzMDkzNg==","avatar_url":"https://avatars0.githubusercontent.com/u/630936?v=4","gravatar_id":"","url":"https://api.github.com/users/rth","html_url":"https://github.com/rth","followers_url":"https://api.github.com/users/rth/followers","following_url":"https://api.github.com/users/rth/following{/other_user}","gists_url":"https://api.github.com/users/rth/gists{/gist_id}","starred_url":"https://api.github.com/users/rth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rth/subscriptions","organizations_url":"https://api.github.com/users/rth/orgs","repos_url":"https://api.github.com/users/rth/repos","events_url":"https://api.github.com/users/rth/events{/privacy}","received_events_url":"https://api.github.com/users/rth/received_events","type":"User","site_admin":false},"body":"sorry, @tomMoral I confused you, this is .rst not .md..","created_at":"2018-11-18T12:31:39Z","updated_at":"2018-11-18T12:31:39Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12345#discussion_r234442561","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12345","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/234442561"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12345#discussion_r234442561"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12345"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12345","id":221831008,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODMxMDA4","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12345","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/12345.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/12345.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12345","number":12345,"state":"open","locked":false,"title":"FIX remove all mention to externals.joblib in the codebase","user":{"login":"tomMoral","id":3321081,"node_id":"MDQ6VXNlcjMzMjEwODE=","avatar_url":"https://avatars0.githubusercontent.com/u/3321081?v=4","gravatar_id":"","url":"https://api.github.com/users/tomMoral","html_url":"https://github.com/tomMoral","followers_url":"https://api.github.com/users/tomMoral/followers","following_url":"https://api.github.com/users/tomMoral/following{/other_user}","gists_url":"https://api.github.com/users/tomMoral/gists{/gist_id}","starred_url":"https://api.github.com/users/tomMoral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomMoral/subscriptions","organizations_url":"https://api.github.com/users/tomMoral/orgs","repos_url":"https://api.github.com/users/tomMoral/repos","events_url":"https://api.github.com/users/tomMoral/events{/privacy}","received_events_url":"https://api.github.com/users/tomMoral/received_events","type":"User","site_admin":false},"body":"This PR intends to fix the failure seen in the CRON job using master branch of `joblib`. (See [here]( https://travis-ci.org/scikit-learn/scikit-learn/builds/438229703?utm_source=github_status&utm_medium=notification))\r\n\r\nIt removes all mention to `externals.joblib` in the codebase and replace it with `sklearn.utils`.\r\n\r\nNote that for testing purposes, it is necessary to add the module `joblib` in `utils` to be able to access more advanced functionality of `joblib` without importing directly the module. I am not sure this is the best level to expose this, so let me know if this should only be access from `sklearn.utils._joblib`.","created_at":"2018-10-10T15:17:47Z","updated_at":"2018-11-18T12:31:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d47d2b1324301a2910570c7f9ca8370868072a38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/27","html_url":"https://github.com/scikit-learn/scikit-learn/milestone/27","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/27/labels","id":3690060,"node_id":"MDk6TWlsZXN0b25lMzY5MDA2MA==","number":27,"title":"0.20.1","description":null,"creator":{"login":"ogrisel","id":89061,"node_id":"MDQ6VXNlcjg5MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/89061?v=4","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":66,"state":"open","created_at":"2018-09-26T12:07:45Z","updated_at":"2018-11-16T17:15:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12345/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12345/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12345/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/b9d3726c14147ec771135aed4a399d24aaff0ba4","head":{"label":"tomMoral:FIX_vendor_joblib_usage","ref":"FIX_vendor_joblib_usage","sha":"b9d3726c14147ec771135aed4a399d24aaff0ba4","user":{"login":"tomMoral","id":3321081,"node_id":"MDQ6VXNlcjMzMjEwODE=","avatar_url":"https://avatars0.githubusercontent.com/u/3321081?v=4","gravatar_id":"","url":"https://api.github.com/users/tomMoral","html_url":"https://github.com/tomMoral","followers_url":"https://api.github.com/users/tomMoral/followers","following_url":"https://api.github.com/users/tomMoral/following{/other_user}","gists_url":"https://api.github.com/users/tomMoral/gists{/gist_id}","starred_url":"https://api.github.com/users/tomMoral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomMoral/subscriptions","organizations_url":"https://api.github.com/users/tomMoral/orgs","repos_url":"https://api.github.com/users/tomMoral/repos","events_url":"https://api.github.com/users/tomMoral/events{/privacy}","received_events_url":"https://api.github.com/users/tomMoral/received_events","type":"User","site_admin":false},"repo":{"id":37184837,"node_id":"MDEwOlJlcG9zaXRvcnkzNzE4NDgzNw==","name":"scikit-learn","full_name":"tomMoral/scikit-learn","private":false,"owner":{"login":"tomMoral","id":3321081,"node_id":"MDQ6VXNlcjMzMjEwODE=","avatar_url":"https://avatars0.githubusercontent.com/u/3321081?v=4","gravatar_id":"","url":"https://api.github.com/users/tomMoral","html_url":"https://github.com/tomMoral","followers_url":"https://api.github.com/users/tomMoral/followers","following_url":"https://api.github.com/users/tomMoral/following{/other_user}","gists_url":"https://api.github.com/users/tomMoral/gists{/gist_id}","starred_url":"https://api.github.com/users/tomMoral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomMoral/subscriptions","organizations_url":"https://api.github.com/users/tomMoral/orgs","repos_url":"https://api.github.com/users/tomMoral/repos","events_url":"https://api.github.com/users/tomMoral/events{/privacy}","received_events_url":"https://api.github.com/users/tomMoral/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tomMoral/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/tomMoral/scikit-learn","forks_url":"https://api.github.com/repos/tomMoral/scikit-learn/forks","keys_url":"https://api.github.com/repos/tomMoral/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomMoral/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomMoral/scikit-learn/teams","hooks_url":"https://api.github.com/repos/tomMoral/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/tomMoral/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/tomMoral/scikit-learn/events","assignees_url":"https://api.github.com/repos/tomMoral/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/tomMoral/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/tomMoral/scikit-learn/tags","blobs_url":"https://api.github.com/repos/tomMoral/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomMoral/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomMoral/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomMoral/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomMoral/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/tomMoral/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/tomMoral/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/tomMoral/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/tomMoral/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/tomMoral/scikit-learn/subscription","commits_url":"https://api.github.com/repos/tomMoral/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomMoral/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomMoral/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomMoral/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomMoral/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/tomMoral/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomMoral/scikit-learn/merges","archive_url":"https://api.github.com/repos/tomMoral/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomMoral/scikit-learn/downloads","issues_url":"https://api.github.com/repos/tomMoral/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/tomMoral/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/tomMoral/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/tomMoral/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomMoral/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/tomMoral/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/tomMoral/scikit-learn/deployments","created_at":"2015-06-10T08:26:27Z","updated_at":"2018-06-22T09:52:03Z","pushed_at":"2018-11-18T10:39:55Z","git_url":"git://github.com/tomMoral/scikit-learn.git","ssh_url":"git@github.com:tomMoral/scikit-learn.git","clone_url":"https://github.com/tomMoral/scikit-learn.git","svn_url":"https://github.com/tomMoral/scikit-learn","homepage":"http://scikit-learn.org","size":94465,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"bfc4a566423e036fbdc9fb02765fd893e4860c85","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","private":false,"owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-11-18T12:10:47Z","pushed_at":"2018-11-18T12:10:42Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":96724,"stargazers_count":31779,"watchers_count":31779,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15694,"mirror_url":null,"archived":false,"open_issues_count":1808,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15694,"open_issues":1808,"watchers":31779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12345"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12345"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12345"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12345/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12345/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12345/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/b9d3726c14147ec771135aed4a399d24aaff0ba4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rth"}}