{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/211071897","pull_request_review_id":147426891,"id":211071897,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA3MTg5Nw==","diff_hunk":"@@ -1362,6 +1357,46 @@ def __new__(cls, *args, **kwargs):\n \n         raise GeometryError(\"Circle.__new__ received unknown arguments\")\n \n+    def object_from_equation(self):\n+        \"\"\"Returns a Circle object from an equation of circle given as input.\n+        If the equation of the circle is ax**2 + by**2 + gx + hy + c = 0, then\n+        the input has to be of the following format: ax**2 + by**2 + gx + hy + c\n+\n+        Examples\n+        ========\n+\n+        >>> from sympy import Circle\n+        >>> from sympy.abc import x, y\n+        >>> Circle.object_from_equation(x**2 + y**2 + 3*x + 4*y - 8)\n+        Circle(Point2D(-3/2, -2), 3.77491721763537)\n+\n+        \"\"\"\n+\n+        from sympy.abc import x, y\n+        poly_x = poly(self, x)\n+        poly_y = poly(self, y)\n+        deg_x = degree(poly_x)\n+        deg_y = degree(poly_y)\n+        lead_x_coeff = LC(poly_x)\n+        lead_y_coeff = LC(poly_y)\n+\n+        if deg_x == 2 and deg_y == 2:\n+            if lead_x_coeff == lead_y_coeff:","path":"sympy/geometry/ellipse.py","position":316,"original_position":316,"commit_id":"7df908ebb0e24182a5ab3d9724337e62f8ddba8a","original_commit_id":"7df908ebb0e24182a5ab3d9724337e62f8ddba8a","user":{"login":"avishrivastava11","id":35996093,"node_id":"MDQ6VXNlcjM1OTk2MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/35996093?v=4","gravatar_id":"","url":"https://api.github.com/users/avishrivastava11","html_url":"https://github.com/avishrivastava11","followers_url":"https://api.github.com/users/avishrivastava11/followers","following_url":"https://api.github.com/users/avishrivastava11/following{/other_user}","gists_url":"https://api.github.com/users/avishrivastava11/gists{/gist_id}","starred_url":"https://api.github.com/users/avishrivastava11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avishrivastava11/subscriptions","organizations_url":"https://api.github.com/users/avishrivastava11/orgs","repos_url":"https://api.github.com/users/avishrivastava11/repos","events_url":"https://api.github.com/users/avishrivastava11/events{/privacy}","received_events_url":"https://api.github.com/users/avishrivastava11/received_events","type":"User","site_admin":false},"body":"@sidhantnagpal  \r\n>These conditions could be clubbed deg_x == deg_y == 2 and lead_x_coeff == lead_y_coeff and correspondingly have a single statement for raising exception (if it is not the case).\r\n\r\nI will do that\r\n>Also, did you consider degenerate cases?\r\n\r\nCould you elaborate what you mean by `degenerate` cases?","created_at":"2018-08-18T10:09:36Z","updated_at":"2018-08-18T10:09:36Z","html_url":"https://github.com/sympy/sympy/pull/15091#discussion_r211071897","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/15091","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/211071897"},"html":{"href":"https://github.com/sympy/sympy/pull/15091#discussion_r211071897"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/15091"}},"in_reply_to_id":210890880},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/15091","id":208249379,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MjQ5Mzc5","html_url":"https://github.com/sympy/sympy/pull/15091","diff_url":"https://github.com/sympy/sympy/pull/15091.diff","patch_url":"https://github.com/sympy/sympy/pull/15091.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/15091","number":15091,"state":"open","locked":false,"title":"Added conversion to line and circle object from an equation given as input","user":{"login":"avishrivastava11","id":35996093,"node_id":"MDQ6VXNlcjM1OTk2MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/35996093?v=4","gravatar_id":"","url":"https://api.github.com/users/avishrivastava11","html_url":"https://github.com/avishrivastava11","followers_url":"https://api.github.com/users/avishrivastava11/followers","following_url":"https://api.github.com/users/avishrivastava11/following{/other_user}","gists_url":"https://api.github.com/users/avishrivastava11/gists{/gist_id}","starred_url":"https://api.github.com/users/avishrivastava11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avishrivastava11/subscriptions","organizations_url":"https://api.github.com/users/avishrivastava11/orgs","repos_url":"https://api.github.com/users/avishrivastava11/repos","events_url":"https://api.github.com/users/avishrivastava11/events{/privacy}","received_events_url":"https://api.github.com/users/avishrivastava11/received_events","type":"User","site_admin":false},"body":"added conversion to line and circle object from an equation given as input\r\n\r\nFixes #11028\r\n\r\nmethods named `object_from_equation` have been added to each `line.py` and `circle.py` to add implementation of conversion of equation given as input into object of class `line` and `circle` respectively\r\n\r\n\r\nPlease take a look and suggest improvements.\r\nThanks\r\n\r\n\r\n#### Release Notes\r\n\r\n<!-- BEGIN RELEASE NOTES -->\r\n* geometry\r\n   * added methods named `object_from_equation` to class `Line` and `Circle` in Line.py and Circle.py respectively\r\n<!-- END RELEASE NOTES -->\r\n","created_at":"2018-08-14T11:24:34Z","updated_at":"2018-08-18T10:09:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0141654c20c55cc072fa4a02d2a71e850ad0250d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/15091/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/15091/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/15091/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/7df908ebb0e24182a5ab3d9724337e62f8ddba8a","head":{"label":"avishrivastava11:recognizing_equations","ref":"recognizing_equations","sha":"7df908ebb0e24182a5ab3d9724337e62f8ddba8a","user":{"login":"avishrivastava11","id":35996093,"node_id":"MDQ6VXNlcjM1OTk2MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/35996093?v=4","gravatar_id":"","url":"https://api.github.com/users/avishrivastava11","html_url":"https://github.com/avishrivastava11","followers_url":"https://api.github.com/users/avishrivastava11/followers","following_url":"https://api.github.com/users/avishrivastava11/following{/other_user}","gists_url":"https://api.github.com/users/avishrivastava11/gists{/gist_id}","starred_url":"https://api.github.com/users/avishrivastava11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avishrivastava11/subscriptions","organizations_url":"https://api.github.com/users/avishrivastava11/orgs","repos_url":"https://api.github.com/users/avishrivastava11/repos","events_url":"https://api.github.com/users/avishrivastava11/events{/privacy}","received_events_url":"https://api.github.com/users/avishrivastava11/received_events","type":"User","site_admin":false},"repo":{"id":143590322,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1OTAzMjI=","name":"sympy","full_name":"avishrivastava11/sympy","owner":{"login":"avishrivastava11","id":35996093,"node_id":"MDQ6VXNlcjM1OTk2MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/35996093?v=4","gravatar_id":"","url":"https://api.github.com/users/avishrivastava11","html_url":"https://github.com/avishrivastava11","followers_url":"https://api.github.com/users/avishrivastava11/followers","following_url":"https://api.github.com/users/avishrivastava11/following{/other_user}","gists_url":"https://api.github.com/users/avishrivastava11/gists{/gist_id}","starred_url":"https://api.github.com/users/avishrivastava11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avishrivastava11/subscriptions","organizations_url":"https://api.github.com/users/avishrivastava11/orgs","repos_url":"https://api.github.com/users/avishrivastava11/repos","events_url":"https://api.github.com/users/avishrivastava11/events{/privacy}","received_events_url":"https://api.github.com/users/avishrivastava11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avishrivastava11/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/avishrivastava11/sympy","forks_url":"https://api.github.com/repos/avishrivastava11/sympy/forks","keys_url":"https://api.github.com/repos/avishrivastava11/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avishrivastava11/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avishrivastava11/sympy/teams","hooks_url":"https://api.github.com/repos/avishrivastava11/sympy/hooks","issue_events_url":"https://api.github.com/repos/avishrivastava11/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/avishrivastava11/sympy/events","assignees_url":"https://api.github.com/repos/avishrivastava11/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/avishrivastava11/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/avishrivastava11/sympy/tags","blobs_url":"https://api.github.com/repos/avishrivastava11/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avishrivastava11/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avishrivastava11/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/avishrivastava11/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avishrivastava11/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/avishrivastava11/sympy/languages","stargazers_url":"https://api.github.com/repos/avishrivastava11/sympy/stargazers","contributors_url":"https://api.github.com/repos/avishrivastava11/sympy/contributors","subscribers_url":"https://api.github.com/repos/avishrivastava11/sympy/subscribers","subscription_url":"https://api.github.com/repos/avishrivastava11/sympy/subscription","commits_url":"https://api.github.com/repos/avishrivastava11/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/avishrivastava11/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/avishrivastava11/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/avishrivastava11/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/avishrivastava11/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/avishrivastava11/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avishrivastava11/sympy/merges","archive_url":"https://api.github.com/repos/avishrivastava11/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avishrivastava11/sympy/downloads","issues_url":"https://api.github.com/repos/avishrivastava11/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/avishrivastava11/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/avishrivastava11/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/avishrivastava11/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avishrivastava11/sympy/labels{/name}","releases_url":"https://api.github.com/repos/avishrivastava11/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/avishrivastava11/sympy/deployments","created_at":"2018-08-05T06:50:31Z","updated_at":"2018-08-13T09:59:16Z","pushed_at":"2018-08-14T11:17:45Z","git_url":"git://github.com/avishrivastava11/sympy.git","ssh_url":"git@github.com:avishrivastava11/sympy.git","clone_url":"https://github.com/avishrivastava11/sympy.git","svn_url":"https://github.com/avishrivastava11/sympy","homepage":"http://sympy.org/","size":94393,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"2961d8f076b742919d4a6fbe99a94d3cf5e46f9c","user":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"node_id":"MDEwOlJlcG9zaXRvcnk2NDA1MzQ=","name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2018-08-18T09:07:33Z","pushed_at":"2018-08-18T04:44:31Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":94591,"stargazers_count":5036,"watchers_count":5036,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2321,"mirror_url":null,"archived":false,"open_issues_count":3400,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2321,"open_issues":3400,"watchers":5036,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/15091"},"html":{"href":"https://github.com/sympy/sympy/pull/15091"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/15091"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/15091/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/15091/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/15091/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/7df908ebb0e24182a5ab3d9724337e62f8ddba8a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"avishrivastava11"}}