{"action":"created","comment":{"url":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/comments/200075337","pull_request_review_id":134317630,"id":200075337,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDA3NTMzNw==","diff_hunk":"@@ -179,9 +191,19 @@ def convert_tensorproductelement(element, **kwargs):\n     cell = element.cell()\n     if type(cell) is not ufl.TensorProductCell:\n         raise ValueError(\"TensorProductElement not on TensorProductCell?\")\n-    elements, deps = zip(*[_create_element(elem, **kwargs)\n-                           for elem in element.sub_elements()])\n-    return finat.TensorProductElement(elements), set.union(*deps)\n+    shift_axes = kwargs[\"shift_axes\"]\n+    dim_offset = 0\n+\n+    elements = []\n+    deps = set()\n+    for elem in element.sub_elements():\n+        kwargs[\"shift_axes\"] = shift_axes + dim_offset\n+        dim_offset += elem.cell().topological_dimension()\n+\n+        finat_elem, ds = _create_element(elem, **kwargs)\n+        elements.append(finat_elem)\n+        deps.update(ds)\n+    return finat.TensorProductElement(elements), deps","path":"tsfc/finatinterface.py","position":45,"original_position":45,"commit_id":"2cf747682e91873acc20bd8b5b34ee9df4250c04","original_commit_id":"2cf747682e91873acc20bd8b5b34ee9df4250c04","user":{"login":"miklos1","id":4210841,"node_id":"MDQ6VXNlcjQyMTA4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4210841?v=4","gravatar_id":"","url":"https://api.github.com/users/miklos1","html_url":"https://github.com/miklos1","followers_url":"https://api.github.com/users/miklos1/followers","following_url":"https://api.github.com/users/miklos1/following{/other_user}","gists_url":"https://api.github.com/users/miklos1/gists{/gist_id}","starred_url":"https://api.github.com/users/miklos1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miklos1/subscriptions","organizations_url":"https://api.github.com/users/miklos1/orgs","repos_url":"https://api.github.com/users/miklos1/repos","events_url":"https://api.github.com/users/miklos1/events{/privacy}","received_events_url":"https://api.github.com/users/miklos1/received_events","type":"User","site_admin":false},"body":"IIRC it was something like if you have a TPE(P4, P4, P4), then each P4 element is translated differently.","created_at":"2018-07-04T10:04:56Z","updated_at":"2018-07-04T10:04:56Z","html_url":"https://github.com/firedrakeproject/tsfc/pull/164#discussion_r200075337","pull_request_url":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/164","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/comments/200075337"},"html":{"href":"https://github.com/firedrakeproject/tsfc/pull/164#discussion_r200075337"},"pull_request":{"href":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/164"}},"in_reply_to_id":200070785},"pull_request":{"url":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/164","id":188666373,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4NjY2Mzcz","html_url":"https://github.com/firedrakeproject/tsfc/pull/164","diff_url":"https://github.com/firedrakeproject/tsfc/pull/164.diff","patch_url":"https://github.com/firedrakeproject/tsfc/pull/164.patch","issue_url":"https://api.github.com/repos/firedrakeproject/tsfc/issues/164","number":164,"state":"open","locked":false,"title":"Runtime tabulated","user":{"login":"celdred","id":1863886,"node_id":"MDQ6VXNlcjE4NjM4ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1863886?v=4","gravatar_id":"","url":"https://api.github.com/users/celdred","html_url":"https://github.com/celdred","followers_url":"https://api.github.com/users/celdred/followers","following_url":"https://api.github.com/users/celdred/following{/other_user}","gists_url":"https://api.github.com/users/celdred/gists{/gist_id}","starred_url":"https://api.github.com/users/celdred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celdred/subscriptions","organizations_url":"https://api.github.com/users/celdred/orgs","repos_url":"https://api.github.com/users/celdred/repos","events_url":"https://api.github.com/users/celdred/events{/privacy}","received_events_url":"https://api.github.com/users/celdred/received_events","type":"User","site_admin":false},"body":"This adds support for runtime tabulated elements (used in Themis) to TSFC. The only place I can foresee issues is kernel_interface/firedrake.py, since this changes some of the kernel arguments from pointers to const arrays (but it seems to pass tests on Travis?).  Should I create a new kernel_interface?\r\n","created_at":"2018-05-17T08:57:43Z","updated_at":"2018-07-04T10:04:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46650e40e12105f27c0a1b4e7a132c02558ba035","assignee":null,"assignees":[],"requested_reviewers":[{"login":"miklos1","id":4210841,"node_id":"MDQ6VXNlcjQyMTA4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4210841?v=4","gravatar_id":"","url":"https://api.github.com/users/miklos1","html_url":"https://github.com/miklos1","followers_url":"https://api.github.com/users/miklos1/followers","following_url":"https://api.github.com/users/miklos1/following{/other_user}","gists_url":"https://api.github.com/users/miklos1/gists{/gist_id}","starred_url":"https://api.github.com/users/miklos1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miklos1/subscriptions","organizations_url":"https://api.github.com/users/miklos1/orgs","repos_url":"https://api.github.com/users/miklos1/repos","events_url":"https://api.github.com/users/miklos1/events{/privacy}","received_events_url":"https://api.github.com/users/miklos1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/164/commits","review_comments_url":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/164/comments","review_comment_url":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firedrakeproject/tsfc/issues/164/comments","statuses_url":"https://api.github.com/repos/firedrakeproject/tsfc/statuses/2cf747682e91873acc20bd8b5b34ee9df4250c04","head":{"label":"firedrakeproject:runtime_tabulated","ref":"runtime_tabulated","sha":"2cf747682e91873acc20bd8b5b34ee9df4250c04","user":{"login":"firedrakeproject","id":5558005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTgwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":50843402,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg0MzQwMg==","name":"tsfc","full_name":"firedrakeproject/tsfc","owner":{"login":"firedrakeproject","id":5558005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTgwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firedrakeproject/tsfc","description":"Two-stage form compiler","fork":false,"url":"https://api.github.com/repos/firedrakeproject/tsfc","forks_url":"https://api.github.com/repos/firedrakeproject/tsfc/forks","keys_url":"https://api.github.com/repos/firedrakeproject/tsfc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firedrakeproject/tsfc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firedrakeproject/tsfc/teams","hooks_url":"https://api.github.com/repos/firedrakeproject/tsfc/hooks","issue_events_url":"https://api.github.com/repos/firedrakeproject/tsfc/issues/events{/number}","events_url":"https://api.github.com/repos/firedrakeproject/tsfc/events","assignees_url":"https://api.github.com/repos/firedrakeproject/tsfc/assignees{/user}","branches_url":"https://api.github.com/repos/firedrakeproject/tsfc/branches{/branch}","tags_url":"https://api.github.com/repos/firedrakeproject/tsfc/tags","blobs_url":"https://api.github.com/repos/firedrakeproject/tsfc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firedrakeproject/tsfc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firedrakeproject/tsfc/git/refs{/sha}","trees_url":"https://api.github.com/repos/firedrakeproject/tsfc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firedrakeproject/tsfc/statuses/{sha}","languages_url":"https://api.github.com/repos/firedrakeproject/tsfc/languages","stargazers_url":"https://api.github.com/repos/firedrakeproject/tsfc/stargazers","contributors_url":"https://api.github.com/repos/firedrakeproject/tsfc/contributors","subscribers_url":"https://api.github.com/repos/firedrakeproject/tsfc/subscribers","subscription_url":"https://api.github.com/repos/firedrakeproject/tsfc/subscription","commits_url":"https://api.github.com/repos/firedrakeproject/tsfc/commits{/sha}","git_commits_url":"https://api.github.com/repos/firedrakeproject/tsfc/git/commits{/sha}","comments_url":"https://api.github.com/repos/firedrakeproject/tsfc/comments{/number}","issue_comment_url":"https://api.github.com/repos/firedrakeproject/tsfc/issues/comments{/number}","contents_url":"https://api.github.com/repos/firedrakeproject/tsfc/contents/{+path}","compare_url":"https://api.github.com/repos/firedrakeproject/tsfc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firedrakeproject/tsfc/merges","archive_url":"https://api.github.com/repos/firedrakeproject/tsfc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firedrakeproject/tsfc/downloads","issues_url":"https://api.github.com/repos/firedrakeproject/tsfc/issues{/number}","pulls_url":"https://api.github.com/repos/firedrakeproject/tsfc/pulls{/number}","milestones_url":"https://api.github.com/repos/firedrakeproject/tsfc/milestones{/number}","notifications_url":"https://api.github.com/repos/firedrakeproject/tsfc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firedrakeproject/tsfc/labels{/name}","releases_url":"https://api.github.com/repos/firedrakeproject/tsfc/releases{/id}","deployments_url":"https://api.github.com/repos/firedrakeproject/tsfc/deployments","created_at":"2016-02-01T14:07:32Z","updated_at":"2018-06-05T12:19:12Z","pushed_at":"2018-07-04T09:02:38Z","git_url":"git://github.com/firedrakeproject/tsfc.git","ssh_url":"git@github.com:firedrakeproject/tsfc.git","clone_url":"https://github.com/firedrakeproject/tsfc.git","svn_url":"https://github.com/firedrakeproject/tsfc","homepage":null,"size":1107,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":15,"watchers":4,"default_branch":"master"}},"base":{"label":"firedrakeproject:master","ref":"master","sha":"a12d74e3b18d0b80e2b7a5b39744913138339f55","user":{"login":"firedrakeproject","id":5558005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTgwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":50843402,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg0MzQwMg==","name":"tsfc","full_name":"firedrakeproject/tsfc","owner":{"login":"firedrakeproject","id":5558005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTgwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5558005?v=4","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firedrakeproject/tsfc","description":"Two-stage form compiler","fork":false,"url":"https://api.github.com/repos/firedrakeproject/tsfc","forks_url":"https://api.github.com/repos/firedrakeproject/tsfc/forks","keys_url":"https://api.github.com/repos/firedrakeproject/tsfc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firedrakeproject/tsfc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firedrakeproject/tsfc/teams","hooks_url":"https://api.github.com/repos/firedrakeproject/tsfc/hooks","issue_events_url":"https://api.github.com/repos/firedrakeproject/tsfc/issues/events{/number}","events_url":"https://api.github.com/repos/firedrakeproject/tsfc/events","assignees_url":"https://api.github.com/repos/firedrakeproject/tsfc/assignees{/user}","branches_url":"https://api.github.com/repos/firedrakeproject/tsfc/branches{/branch}","tags_url":"https://api.github.com/repos/firedrakeproject/tsfc/tags","blobs_url":"https://api.github.com/repos/firedrakeproject/tsfc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firedrakeproject/tsfc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firedrakeproject/tsfc/git/refs{/sha}","trees_url":"https://api.github.com/repos/firedrakeproject/tsfc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firedrakeproject/tsfc/statuses/{sha}","languages_url":"https://api.github.com/repos/firedrakeproject/tsfc/languages","stargazers_url":"https://api.github.com/repos/firedrakeproject/tsfc/stargazers","contributors_url":"https://api.github.com/repos/firedrakeproject/tsfc/contributors","subscribers_url":"https://api.github.com/repos/firedrakeproject/tsfc/subscribers","subscription_url":"https://api.github.com/repos/firedrakeproject/tsfc/subscription","commits_url":"https://api.github.com/repos/firedrakeproject/tsfc/commits{/sha}","git_commits_url":"https://api.github.com/repos/firedrakeproject/tsfc/git/commits{/sha}","comments_url":"https://api.github.com/repos/firedrakeproject/tsfc/comments{/number}","issue_comment_url":"https://api.github.com/repos/firedrakeproject/tsfc/issues/comments{/number}","contents_url":"https://api.github.com/repos/firedrakeproject/tsfc/contents/{+path}","compare_url":"https://api.github.com/repos/firedrakeproject/tsfc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firedrakeproject/tsfc/merges","archive_url":"https://api.github.com/repos/firedrakeproject/tsfc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firedrakeproject/tsfc/downloads","issues_url":"https://api.github.com/repos/firedrakeproject/tsfc/issues{/number}","pulls_url":"https://api.github.com/repos/firedrakeproject/tsfc/pulls{/number}","milestones_url":"https://api.github.com/repos/firedrakeproject/tsfc/milestones{/number}","notifications_url":"https://api.github.com/repos/firedrakeproject/tsfc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firedrakeproject/tsfc/labels{/name}","releases_url":"https://api.github.com/repos/firedrakeproject/tsfc/releases{/id}","deployments_url":"https://api.github.com/repos/firedrakeproject/tsfc/deployments","created_at":"2016-02-01T14:07:32Z","updated_at":"2018-06-05T12:19:12Z","pushed_at":"2018-07-04T09:02:38Z","git_url":"git://github.com/firedrakeproject/tsfc.git","ssh_url":"git@github.com:firedrakeproject/tsfc.git","clone_url":"https://github.com/firedrakeproject/tsfc.git","svn_url":"https://github.com/firedrakeproject/tsfc","homepage":null,"size":1107,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":15,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/164"},"html":{"href":"https://github.com/firedrakeproject/tsfc/pull/164"},"issue":{"href":"https://api.github.com/repos/firedrakeproject/tsfc/issues/164"},"comments":{"href":"https://api.github.com/repos/firedrakeproject/tsfc/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firedrakeproject/tsfc/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/firedrakeproject/tsfc/statuses/2cf747682e91873acc20bd8b5b34ee9df4250c04"}},"author_association":"NONE"}}
{"actor":{"display_login":"miklos1"}}