{"action":"opened","number":1198,"pull_request":{"url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1198","id":235280254,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjgwMjU0","html_url":"https://github.com/QMCPACK/qmcpack/pull/1198","diff_url":"https://github.com/QMCPACK/qmcpack/pull/1198.diff","patch_url":"https://github.com/QMCPACK/qmcpack/pull/1198.patch","issue_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1198","number":1198,"state":"open","locked":false,"title":"Simplify radial jastrow builder","user":{"login":"ye-luo","id":1454251,"node_id":"MDQ6VXNlcjE0NTQyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1454251?v=4","gravatar_id":"","url":"https://api.github.com/users/ye-luo","html_url":"https://github.com/ye-luo","followers_url":"https://api.github.com/users/ye-luo/followers","following_url":"https://api.github.com/users/ye-luo/following{/other_user}","gists_url":"https://api.github.com/users/ye-luo/gists{/gist_id}","starred_url":"https://api.github.com/users/ye-luo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ye-luo/subscriptions","organizations_url":"https://api.github.com/users/ye-luo/orgs","repos_url":"https://api.github.com/users/ye-luo/repos","events_url":"https://api.github.com/users/ye-luo/events{/privacy}","received_events_url":"https://api.github.com/users/ye-luo/received_events","type":"User","site_admin":false},"body":"Mostly to reduce the nested templates.\r\n\r\nAlso change\r\n```C++\r\n      if (targetPtcl.Lattice.WignerSeitzRadius > 0)\r\n      {\r\n        functor->cutoff_radius = targetPtcl.Lattice.WignerSeitzRadius;\r\n      }\r\n      else if (functor->cutoff_radius < 10.0)\r\n      {\r\n        functor->cutoff_radius = 10.0;\r\n      }\r\n```\r\nto\r\n```C++\r\n      functor->cutoff_radius = targetPtcl.Lattice.WignerSeitzRadius;\r\n```\r\nBecause targetPtcl.Lattice.WignerSeitzRadius > 0 for any BC (PBC, OBC, mixed)\r\n\r\nNote: since we changed to RadialJastrowBuilder, spin polarized J1 is no more accessible. The old class was AoS. The solution will be expanding J1SoA to support the spin case and eventually becomes the only one.","created_at":"2018-12-02T19:46:40Z","updated_at":"2018-12-02T19:46:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1198/commits","review_comments_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1198/comments","review_comment_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1198/comments","statuses_url":"https://api.github.com/repos/QMCPACK/qmcpack/statuses/be7f8d9c8979819cbd9ac5fe5ecc6a972a47542c","head":{"label":"ye-luo:simplify-RadialJastrowBuilder","ref":"simplify-RadialJastrowBuilder","sha":"be7f8d9c8979819cbd9ac5fe5ecc6a972a47542c","user":{"login":"ye-luo","id":1454251,"node_id":"MDQ6VXNlcjE0NTQyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1454251?v=4","gravatar_id":"","url":"https://api.github.com/users/ye-luo","html_url":"https://github.com/ye-luo","followers_url":"https://api.github.com/users/ye-luo/followers","following_url":"https://api.github.com/users/ye-luo/following{/other_user}","gists_url":"https://api.github.com/users/ye-luo/gists{/gist_id}","starred_url":"https://api.github.com/users/ye-luo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ye-luo/subscriptions","organizations_url":"https://api.github.com/users/ye-luo/orgs","repos_url":"https://api.github.com/users/ye-luo/repos","events_url":"https://api.github.com/users/ye-luo/events{/privacy}","received_events_url":"https://api.github.com/users/ye-luo/received_events","type":"User","site_admin":false},"repo":{"id":78910422,"node_id":"MDEwOlJlcG9zaXRvcnk3ODkxMDQyMg==","name":"qmcpack","full_name":"ye-luo/qmcpack","private":false,"owner":{"login":"ye-luo","id":1454251,"node_id":"MDQ6VXNlcjE0NTQyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1454251?v=4","gravatar_id":"","url":"https://api.github.com/users/ye-luo","html_url":"https://github.com/ye-luo","followers_url":"https://api.github.com/users/ye-luo/followers","following_url":"https://api.github.com/users/ye-luo/following{/other_user}","gists_url":"https://api.github.com/users/ye-luo/gists{/gist_id}","starred_url":"https://api.github.com/users/ye-luo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ye-luo/subscriptions","organizations_url":"https://api.github.com/users/ye-luo/orgs","repos_url":"https://api.github.com/users/ye-luo/repos","events_url":"https://api.github.com/users/ye-luo/events{/privacy}","received_events_url":"https://api.github.com/users/ye-luo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ye-luo/qmcpack","description":"QMCPACK is an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids.","fork":true,"url":"https://api.github.com/repos/ye-luo/qmcpack","forks_url":"https://api.github.com/repos/ye-luo/qmcpack/forks","keys_url":"https://api.github.com/repos/ye-luo/qmcpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ye-luo/qmcpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ye-luo/qmcpack/teams","hooks_url":"https://api.github.com/repos/ye-luo/qmcpack/hooks","issue_events_url":"https://api.github.com/repos/ye-luo/qmcpack/issues/events{/number}","events_url":"https://api.github.com/repos/ye-luo/qmcpack/events","assignees_url":"https://api.github.com/repos/ye-luo/qmcpack/assignees{/user}","branches_url":"https://api.github.com/repos/ye-luo/qmcpack/branches{/branch}","tags_url":"https://api.github.com/repos/ye-luo/qmcpack/tags","blobs_url":"https://api.github.com/repos/ye-luo/qmcpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ye-luo/qmcpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ye-luo/qmcpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ye-luo/qmcpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ye-luo/qmcpack/statuses/{sha}","languages_url":"https://api.github.com/repos/ye-luo/qmcpack/languages","stargazers_url":"https://api.github.com/repos/ye-luo/qmcpack/stargazers","contributors_url":"https://api.github.com/repos/ye-luo/qmcpack/contributors","subscribers_url":"https://api.github.com/repos/ye-luo/qmcpack/subscribers","subscription_url":"https://api.github.com/repos/ye-luo/qmcpack/subscription","commits_url":"https://api.github.com/repos/ye-luo/qmcpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ye-luo/qmcpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ye-luo/qmcpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ye-luo/qmcpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ye-luo/qmcpack/contents/{+path}","compare_url":"https://api.github.com/repos/ye-luo/qmcpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ye-luo/qmcpack/merges","archive_url":"https://api.github.com/repos/ye-luo/qmcpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ye-luo/qmcpack/downloads","issues_url":"https://api.github.com/repos/ye-luo/qmcpack/issues{/number}","pulls_url":"https://api.github.com/repos/ye-luo/qmcpack/pulls{/number}","milestones_url":"https://api.github.com/repos/ye-luo/qmcpack/milestones{/number}","notifications_url":"https://api.github.com/repos/ye-luo/qmcpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ye-luo/qmcpack/labels{/name}","releases_url":"https://api.github.com/repos/ye-luo/qmcpack/releases{/id}","deployments_url":"https://api.github.com/repos/ye-luo/qmcpack/deployments","created_at":"2017-01-14T03:52:14Z","updated_at":"2018-11-30T03:43:33Z","pushed_at":"2018-12-02T19:35:36Z","git_url":"git://github.com/ye-luo/qmcpack.git","ssh_url":"git@github.com:ye-luo/qmcpack.git","clone_url":"https://github.com/ye-luo/qmcpack.git","svn_url":"https://github.com/ye-luo/qmcpack","homepage":null,"size":171956,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"QMCPACK:develop","ref":"develop","sha":"f9b90398d89e6dfa28b86e59928a8b0c431889dc","user":{"login":"QMCPACK","id":22754046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzU0MDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/22754046?v=4","gravatar_id":"","url":"https://api.github.com/users/QMCPACK","html_url":"https://github.com/QMCPACK","followers_url":"https://api.github.com/users/QMCPACK/followers","following_url":"https://api.github.com/users/QMCPACK/following{/other_user}","gists_url":"https://api.github.com/users/QMCPACK/gists{/gist_id}","starred_url":"https://api.github.com/users/QMCPACK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QMCPACK/subscriptions","organizations_url":"https://api.github.com/users/QMCPACK/orgs","repos_url":"https://api.github.com/users/QMCPACK/repos","events_url":"https://api.github.com/users/QMCPACK/events{/privacy}","received_events_url":"https://api.github.com/users/QMCPACK/received_events","type":"Organization","site_admin":false},"repo":{"id":78669859,"node_id":"MDEwOlJlcG9zaXRvcnk3ODY2OTg1OQ==","name":"qmcpack","full_name":"QMCPACK/qmcpack","private":false,"owner":{"login":"QMCPACK","id":22754046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzU0MDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/22754046?v=4","gravatar_id":"","url":"https://api.github.com/users/QMCPACK","html_url":"https://github.com/QMCPACK","followers_url":"https://api.github.com/users/QMCPACK/followers","following_url":"https://api.github.com/users/QMCPACK/following{/other_user}","gists_url":"https://api.github.com/users/QMCPACK/gists{/gist_id}","starred_url":"https://api.github.com/users/QMCPACK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QMCPACK/subscriptions","organizations_url":"https://api.github.com/users/QMCPACK/orgs","repos_url":"https://api.github.com/users/QMCPACK/repos","events_url":"https://api.github.com/users/QMCPACK/events{/privacy}","received_events_url":"https://api.github.com/users/QMCPACK/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QMCPACK/qmcpack","description":"Main repository for QMCPACK, an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids.","fork":false,"url":"https://api.github.com/repos/QMCPACK/qmcpack","forks_url":"https://api.github.com/repos/QMCPACK/qmcpack/forks","keys_url":"https://api.github.com/repos/QMCPACK/qmcpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QMCPACK/qmcpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QMCPACK/qmcpack/teams","hooks_url":"https://api.github.com/repos/QMCPACK/qmcpack/hooks","issue_events_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/events{/number}","events_url":"https://api.github.com/repos/QMCPACK/qmcpack/events","assignees_url":"https://api.github.com/repos/QMCPACK/qmcpack/assignees{/user}","branches_url":"https://api.github.com/repos/QMCPACK/qmcpack/branches{/branch}","tags_url":"https://api.github.com/repos/QMCPACK/qmcpack/tags","blobs_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QMCPACK/qmcpack/statuses/{sha}","languages_url":"https://api.github.com/repos/QMCPACK/qmcpack/languages","stargazers_url":"https://api.github.com/repos/QMCPACK/qmcpack/stargazers","contributors_url":"https://api.github.com/repos/QMCPACK/qmcpack/contributors","subscribers_url":"https://api.github.com/repos/QMCPACK/qmcpack/subscribers","subscription_url":"https://api.github.com/repos/QMCPACK/qmcpack/subscription","commits_url":"https://api.github.com/repos/QMCPACK/qmcpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/QMCPACK/qmcpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/QMCPACK/qmcpack/contents/{+path}","compare_url":"https://api.github.com/repos/QMCPACK/qmcpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QMCPACK/qmcpack/merges","archive_url":"https://api.github.com/repos/QMCPACK/qmcpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QMCPACK/qmcpack/downloads","issues_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues{/number}","pulls_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls{/number}","milestones_url":"https://api.github.com/repos/QMCPACK/qmcpack/milestones{/number}","notifications_url":"https://api.github.com/repos/QMCPACK/qmcpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QMCPACK/qmcpack/labels{/name}","releases_url":"https://api.github.com/repos/QMCPACK/qmcpack/releases{/id}","deployments_url":"https://api.github.com/repos/QMCPACK/qmcpack/deployments","created_at":"2017-01-11T19:02:29Z","updated_at":"2018-12-02T04:00:19Z","pushed_at":"2018-12-02T04:00:16Z","git_url":"git://github.com/QMCPACK/qmcpack.git","ssh_url":"git@github.com:QMCPACK/qmcpack.git","clone_url":"https://github.com/QMCPACK/qmcpack.git","svn_url":"https://github.com/QMCPACK/qmcpack","homepage":"http://www.qmcpack.org","size":171812,"stargazers_count":68,"watchers_count":68,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":52,"open_issues":197,"watchers":68,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1198"},"html":{"href":"https://github.com/QMCPACK/qmcpack/pull/1198"},"issue":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1198"},"comments":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1198/comments"},"review_comments":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1198/comments"},"review_comment":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1198/commits"},"statuses":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/statuses/be7f8d9c8979819cbd9ac5fe5ecc6a972a47542c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":65,"deletions":100,"changed_files":2}}
{"actor":{"display_login":"ye-luo"}}