{"action":"created","issue":{"url":"https://api.github.com/repos/andrewhathaway/Winterfell/issues/108","repository_url":"https://api.github.com/repos/andrewhathaway/Winterfell","labels_url":"https://api.github.com/repos/andrewhathaway/Winterfell/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/andrewhathaway/Winterfell/issues/108/comments","events_url":"https://api.github.com/repos/andrewhathaway/Winterfell/issues/108/events","html_url":"https://github.com/andrewhathaway/Winterfell/issues/108","id":298691882,"number":108,"title":"Invalid custom inputTypes are not rejected","user":{"login":"KingMob","id":946421,"avatar_url":"https://avatars2.githubusercontent.com/u/946421?v=4","gravatar_id":"","url":"https://api.github.com/users/KingMob","html_url":"https://github.com/KingMob","followers_url":"https://api.github.com/users/KingMob/followers","following_url":"https://api.github.com/users/KingMob/following{/other_user}","gists_url":"https://api.github.com/users/KingMob/gists{/gist_id}","starred_url":"https://api.github.com/users/KingMob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KingMob/subscriptions","organizations_url":"https://api.github.com/users/KingMob/orgs","repos_url":"https://api.github.com/users/KingMob/repos","events_url":"https://api.github.com/users/KingMob/events{/privacy}","received_events_url":"https://api.github.com/users/KingMob/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-20T18:01:19Z","updated_at":"2018-02-21T16:31:25Z","closed_at":null,"author_association":"NONE","body":"Pass in anything that's not a React Component to `addInputType`, and no exceptions will be thrown. \r\n\r\nOne issue is that `!` has higher precedence than `instanceof`. So, in `addInputType`, the line:\r\n\r\n```!React.Component instanceof instance.constructor```\r\n\r\nis actually negating `React.Component`, not the result of the `instanceof` test. \r\n\r\nHowever, wrapping it in parentheses like `!(React.Component instanceof instance.constructor)` doesn't fix the overall issue, so I think there's something wrong with the instanceof test, too. "},"comment":{"url":"https://api.github.com/repos/andrewhathaway/Winterfell/issues/comments/367385563","html_url":"https://github.com/andrewhathaway/Winterfell/issues/108#issuecomment-367385563","issue_url":"https://api.github.com/repos/andrewhathaway/Winterfell/issues/108","id":367385563,"user":{"login":"andrewhathaway","id":1188830,"avatar_url":"https://avatars1.githubusercontent.com/u/1188830?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewhathaway","html_url":"https://github.com/andrewhathaway","followers_url":"https://api.github.com/users/andrewhathaway/followers","following_url":"https://api.github.com/users/andrewhathaway/following{/other_user}","gists_url":"https://api.github.com/users/andrewhathaway/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewhathaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewhathaway/subscriptions","organizations_url":"https://api.github.com/users/andrewhathaway/orgs","repos_url":"https://api.github.com/users/andrewhathaway/repos","events_url":"https://api.github.com/users/andrewhathaway/events{/privacy}","received_events_url":"https://api.github.com/users/andrewhathaway/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T16:31:25Z","updated_at":"2018-02-21T16:31:25Z","author_association":"OWNER","body":"Ahh. This may have been a time thing, those validation checks have probably changed over time, and Winterfell hasn't kept up with that. I'll do some digging on this, and work out what the best validation check is. \r\n\r\nHappy to accept PRs too! :)"}}
{"actor":{"display_login":"andrewhathaway"}}