{"action":"opened","number":1704,"pull_request":{"url":"https://api.github.com/repos/kamailio/kamailio/pulls/1704","id":227883918,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3ODgzOTE4","html_url":"https://github.com/kamailio/kamailio/pull/1704","diff_url":"https://github.com/kamailio/kamailio/pull/1704.diff","patch_url":"https://github.com/kamailio/kamailio/pull/1704.patch","issue_url":"https://api.github.com/repos/kamailio/kamailio/issues/1704","number":1704,"state":"open","locked":false,"title":"dialplan: fix dp_replace() in cmd_export_t struct","user":{"login":"micmac1","id":10446172,"node_id":"MDQ6VXNlcjEwNDQ2MTcy","avatar_url":"https://avatars2.githubusercontent.com/u/10446172?v=4","gravatar_id":"","url":"https://api.github.com/users/micmac1","html_url":"https://github.com/micmac1","followers_url":"https://api.github.com/users/micmac1/followers","following_url":"https://api.github.com/users/micmac1/following{/other_user}","gists_url":"https://api.github.com/users/micmac1/gists{/gist_id}","starred_url":"https://api.github.com/users/micmac1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micmac1/subscriptions","organizations_url":"https://api.github.com/users/micmac1/orgs","repos_url":"https://api.github.com/users/micmac1/repos","events_url":"https://api.github.com/users/micmac1/events{/privacy}","received_events_url":"https://api.github.com/users/micmac1/received_events","type":"User","site_admin":false},"body":"In the struct `int param_no` is set to `2`. But `dp_replace()` has actually three\r\nparameters `(dpid, inval, outvar)`, so kamailio's cfg parser fails when\r\n`dp_replace()` is called:\r\n\r\n```\r\nyyparse(): cfg. parser: failed to find command dp_replace (params 3)\r\nyyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 366, column 45: unknown command, missing loadmodule?\r\n```\r\n\r\nThis commit fixes `int param_no` to address this.\r\n\r\nSigned-off-by: Sebastian Kemper <sebastian_ml@gmx.net>\r\n\r\n<!-- Kamailio Pull Request Template -->\r\n\r\n<!--\r\nIMPORTANT:\r\n  - for detailed contributing guidelines, read:\r\n    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md\r\n  - pull requests must be done to master branch, unless they are backports\r\n    of fixes from master branch to a stable branch\r\n  - backports to stable branches must be done with 'git cherry-pick -x ...'\r\n  - code is contributed under BSD for core and main components (tm, sl, auth, tls)\r\n  - code is contributed GPLv2 or a compatible license for the other components\r\n  - GPL code is contributed with OpenSSL licensing exception\r\n-->\r\n\r\n#### Pre-Submission Checklist\r\n<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->\r\n<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->\r\n<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->\r\n- [+] Commit message has the format required by CONTRIBUTING guide\r\n- [+] Commits are split per component (core, individual modules, libs, utils, ...)\r\n- [+] Each component has a single commit (if not, squash them into one commit)\r\n- [+] No commits to README files for modules (changes must be done to docbook files\r\nin `doc/` subfolder, the README file is autogenerated)\r\n\r\n#### Type Of Change\r\n- [+] Small bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds new functionality)\r\n- [ ] Breaking change (fix or feature that would change existing functionality)\r\n\r\n#### Checklist:\r\n<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->\r\n- [+] PR should be backported to stable branches\r\n- [+] Tested changes locally\r\n- [ ] Related to issue #XXXX (replace XXXX with an open issue number)\r\n\r\n#### Description\r\n<!-- Describe your changes in detail -->\r\nHi all,\r\n\r\nWhen trying out dp_replace() kamailio (5.1.6) wouldn't start. It was expecting 2 parameters instead of 3. This PR fixes that.\r\n\r\nKind regards,\r\nSeb","created_at":"2018-11-02T09:54:23Z","updated_at":"2018-11-02T09:54:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kamailio/kamailio/pulls/1704/commits","review_comments_url":"https://api.github.com/repos/kamailio/kamailio/pulls/1704/comments","review_comment_url":"https://api.github.com/repos/kamailio/kamailio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kamailio/kamailio/issues/1704/comments","statuses_url":"https://api.github.com/repos/kamailio/kamailio/statuses/cbff35909edccffe778d04f3871d880195d82b7a","head":{"label":"micmac1:dp_replace","ref":"dp_replace","sha":"cbff35909edccffe778d04f3871d880195d82b7a","user":{"login":"micmac1","id":10446172,"node_id":"MDQ6VXNlcjEwNDQ2MTcy","avatar_url":"https://avatars2.githubusercontent.com/u/10446172?v=4","gravatar_id":"","url":"https://api.github.com/users/micmac1","html_url":"https://github.com/micmac1","followers_url":"https://api.github.com/users/micmac1/followers","following_url":"https://api.github.com/users/micmac1/following{/other_user}","gists_url":"https://api.github.com/users/micmac1/gists{/gist_id}","starred_url":"https://api.github.com/users/micmac1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micmac1/subscriptions","organizations_url":"https://api.github.com/users/micmac1/orgs","repos_url":"https://api.github.com/users/micmac1/repos","events_url":"https://api.github.com/users/micmac1/events{/privacy}","received_events_url":"https://api.github.com/users/micmac1/received_events","type":"User","site_admin":false},"repo":{"id":151962832,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE5NjI4MzI=","name":"kamailio","full_name":"micmac1/kamailio","private":false,"owner":{"login":"micmac1","id":10446172,"node_id":"MDQ6VXNlcjEwNDQ2MTcy","avatar_url":"https://avatars2.githubusercontent.com/u/10446172?v=4","gravatar_id":"","url":"https://api.github.com/users/micmac1","html_url":"https://github.com/micmac1","followers_url":"https://api.github.com/users/micmac1/followers","following_url":"https://api.github.com/users/micmac1/following{/other_user}","gists_url":"https://api.github.com/users/micmac1/gists{/gist_id}","starred_url":"https://api.github.com/users/micmac1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micmac1/subscriptions","organizations_url":"https://api.github.com/users/micmac1/orgs","repos_url":"https://api.github.com/users/micmac1/repos","events_url":"https://api.github.com/users/micmac1/events{/privacy}","received_events_url":"https://api.github.com/users/micmac1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/micmac1/kamailio","description":"Kamailio - The Open Source SIP Server -","fork":true,"url":"https://api.github.com/repos/micmac1/kamailio","forks_url":"https://api.github.com/repos/micmac1/kamailio/forks","keys_url":"https://api.github.com/repos/micmac1/kamailio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micmac1/kamailio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micmac1/kamailio/teams","hooks_url":"https://api.github.com/repos/micmac1/kamailio/hooks","issue_events_url":"https://api.github.com/repos/micmac1/kamailio/issues/events{/number}","events_url":"https://api.github.com/repos/micmac1/kamailio/events","assignees_url":"https://api.github.com/repos/micmac1/kamailio/assignees{/user}","branches_url":"https://api.github.com/repos/micmac1/kamailio/branches{/branch}","tags_url":"https://api.github.com/repos/micmac1/kamailio/tags","blobs_url":"https://api.github.com/repos/micmac1/kamailio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micmac1/kamailio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micmac1/kamailio/git/refs{/sha}","trees_url":"https://api.github.com/repos/micmac1/kamailio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micmac1/kamailio/statuses/{sha}","languages_url":"https://api.github.com/repos/micmac1/kamailio/languages","stargazers_url":"https://api.github.com/repos/micmac1/kamailio/stargazers","contributors_url":"https://api.github.com/repos/micmac1/kamailio/contributors","subscribers_url":"https://api.github.com/repos/micmac1/kamailio/subscribers","subscription_url":"https://api.github.com/repos/micmac1/kamailio/subscription","commits_url":"https://api.github.com/repos/micmac1/kamailio/commits{/sha}","git_commits_url":"https://api.github.com/repos/micmac1/kamailio/git/commits{/sha}","comments_url":"https://api.github.com/repos/micmac1/kamailio/comments{/number}","issue_comment_url":"https://api.github.com/repos/micmac1/kamailio/issues/comments{/number}","contents_url":"https://api.github.com/repos/micmac1/kamailio/contents/{+path}","compare_url":"https://api.github.com/repos/micmac1/kamailio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micmac1/kamailio/merges","archive_url":"https://api.github.com/repos/micmac1/kamailio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micmac1/kamailio/downloads","issues_url":"https://api.github.com/repos/micmac1/kamailio/issues{/number}","pulls_url":"https://api.github.com/repos/micmac1/kamailio/pulls{/number}","milestones_url":"https://api.github.com/repos/micmac1/kamailio/milestones{/number}","notifications_url":"https://api.github.com/repos/micmac1/kamailio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micmac1/kamailio/labels{/name}","releases_url":"https://api.github.com/repos/micmac1/kamailio/releases{/id}","deployments_url":"https://api.github.com/repos/micmac1/kamailio/deployments","created_at":"2018-10-07T16:46:58Z","updated_at":"2018-10-07T16:47:15Z","pushed_at":"2018-11-02T09:48:17Z","git_url":"git://github.com/micmac1/kamailio.git","ssh_url":"git@github.com:micmac1/kamailio.git","clone_url":"https://github.com/micmac1/kamailio.git","svn_url":"https://github.com/micmac1/kamailio","homepage":"https://www.kamailio.org","size":70815,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kamailio:master","ref":"master","sha":"05846d00a063c069ec4b2c9bf589af111cd7992f","user":{"login":"kamailio","id":5348744,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDg3NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5348744?v=4","gravatar_id":"","url":"https://api.github.com/users/kamailio","html_url":"https://github.com/kamailio","followers_url":"https://api.github.com/users/kamailio/followers","following_url":"https://api.github.com/users/kamailio/following{/other_user}","gists_url":"https://api.github.com/users/kamailio/gists{/gist_id}","starred_url":"https://api.github.com/users/kamailio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamailio/subscriptions","organizations_url":"https://api.github.com/users/kamailio/orgs","repos_url":"https://api.github.com/users/kamailio/repos","events_url":"https://api.github.com/users/kamailio/events{/privacy}","received_events_url":"https://api.github.com/users/kamailio/received_events","type":"Organization","site_admin":false},"repo":{"id":15101579,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwMTU3OQ==","name":"kamailio","full_name":"kamailio/kamailio","private":false,"owner":{"login":"kamailio","id":5348744,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDg3NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5348744?v=4","gravatar_id":"","url":"https://api.github.com/users/kamailio","html_url":"https://github.com/kamailio","followers_url":"https://api.github.com/users/kamailio/followers","following_url":"https://api.github.com/users/kamailio/following{/other_user}","gists_url":"https://api.github.com/users/kamailio/gists{/gist_id}","starred_url":"https://api.github.com/users/kamailio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamailio/subscriptions","organizations_url":"https://api.github.com/users/kamailio/orgs","repos_url":"https://api.github.com/users/kamailio/repos","events_url":"https://api.github.com/users/kamailio/events{/privacy}","received_events_url":"https://api.github.com/users/kamailio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kamailio/kamailio","description":"Kamailio - The Open Source SIP Server -","fork":false,"url":"https://api.github.com/repos/kamailio/kamailio","forks_url":"https://api.github.com/repos/kamailio/kamailio/forks","keys_url":"https://api.github.com/repos/kamailio/kamailio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kamailio/kamailio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kamailio/kamailio/teams","hooks_url":"https://api.github.com/repos/kamailio/kamailio/hooks","issue_events_url":"https://api.github.com/repos/kamailio/kamailio/issues/events{/number}","events_url":"https://api.github.com/repos/kamailio/kamailio/events","assignees_url":"https://api.github.com/repos/kamailio/kamailio/assignees{/user}","branches_url":"https://api.github.com/repos/kamailio/kamailio/branches{/branch}","tags_url":"https://api.github.com/repos/kamailio/kamailio/tags","blobs_url":"https://api.github.com/repos/kamailio/kamailio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kamailio/kamailio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kamailio/kamailio/git/refs{/sha}","trees_url":"https://api.github.com/repos/kamailio/kamailio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kamailio/kamailio/statuses/{sha}","languages_url":"https://api.github.com/repos/kamailio/kamailio/languages","stargazers_url":"https://api.github.com/repos/kamailio/kamailio/stargazers","contributors_url":"https://api.github.com/repos/kamailio/kamailio/contributors","subscribers_url":"https://api.github.com/repos/kamailio/kamailio/subscribers","subscription_url":"https://api.github.com/repos/kamailio/kamailio/subscription","commits_url":"https://api.github.com/repos/kamailio/kamailio/commits{/sha}","git_commits_url":"https://api.github.com/repos/kamailio/kamailio/git/commits{/sha}","comments_url":"https://api.github.com/repos/kamailio/kamailio/comments{/number}","issue_comment_url":"https://api.github.com/repos/kamailio/kamailio/issues/comments{/number}","contents_url":"https://api.github.com/repos/kamailio/kamailio/contents/{+path}","compare_url":"https://api.github.com/repos/kamailio/kamailio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kamailio/kamailio/merges","archive_url":"https://api.github.com/repos/kamailio/kamailio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kamailio/kamailio/downloads","issues_url":"https://api.github.com/repos/kamailio/kamailio/issues{/number}","pulls_url":"https://api.github.com/repos/kamailio/kamailio/pulls{/number}","milestones_url":"https://api.github.com/repos/kamailio/kamailio/milestones{/number}","notifications_url":"https://api.github.com/repos/kamailio/kamailio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kamailio/kamailio/labels{/name}","releases_url":"https://api.github.com/repos/kamailio/kamailio/releases{/id}","deployments_url":"https://api.github.com/repos/kamailio/kamailio/deployments","created_at":"2013-12-11T08:09:40Z","updated_at":"2018-11-02T09:28:18Z","pushed_at":"2018-11-02T09:28:15Z","git_url":"git://github.com/kamailio/kamailio.git","ssh_url":"git@github.com:kamailio/kamailio.git","clone_url":"https://github.com/kamailio/kamailio.git","svn_url":"https://github.com/kamailio/kamailio","homepage":"https://www.kamailio.org","size":70911,"stargazers_count":769,"watchers_count":769,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":413,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":413,"open_issues":58,"watchers":769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kamailio/kamailio/pulls/1704"},"html":{"href":"https://github.com/kamailio/kamailio/pull/1704"},"issue":{"href":"https://api.github.com/repos/kamailio/kamailio/issues/1704"},"comments":{"href":"https://api.github.com/repos/kamailio/kamailio/issues/1704/comments"},"review_comments":{"href":"https://api.github.com/repos/kamailio/kamailio/pulls/1704/comments"},"review_comment":{"href":"https://api.github.com/repos/kamailio/kamailio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kamailio/kamailio/pulls/1704/commits"},"statuses":{"href":"https://api.github.com/repos/kamailio/kamailio/statuses/cbff35909edccffe778d04f3871d880195d82b7a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"micmac1"}}