{"action":"created","comment":{"url":"https://api.github.com/repos/aragon/aragon-apps/pulls/comments/198316976","pull_request_review_id":132227838,"id":198316976,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODMxNjk3Ng==","diff_hunk":"@@ -49,21 +49,31 @@ function highestValueIndex(values) {\n     .sort((v1, v2) => v2.value.minus(v1.value))[0].index\n }\n \n-export function scaleBigNumberValuesSet(values, total = new BigNumber(100)) {\n+// Scale a set of 0 => 1 values to equal `total`.","path":"apps/survey/app/src/math-utils.js","position":5,"original_position":5,"commit_id":"0ce583189a58e86704d40961e8294075569cfaed","original_commit_id":"0ce583189a58e86704d40961e8294075569cfaed","user":{"login":"sohkai","id":4166642,"node_id":"MDQ6VXNlcjQxNjY2NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4166642?v=4","gravatar_id":"","url":"https://api.github.com/users/sohkai","html_url":"https://github.com/sohkai","followers_url":"https://api.github.com/users/sohkai/followers","following_url":"https://api.github.com/users/sohkai/following{/other_user}","gists_url":"https://api.github.com/users/sohkai/gists{/gist_id}","starred_url":"https://api.github.com/users/sohkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohkai/subscriptions","organizations_url":"https://api.github.com/users/sohkai/orgs","repos_url":"https://api.github.com/users/sohkai/repos","events_url":"https://api.github.com/users/sohkai/events{/privacy}","received_events_url":"https://api.github.com/users/sohkai/received_events","type":"User","site_admin":false},"body":"Maybe `[0, 1] values` would work better as math notation? Or even a set of values summing to 1?","created_at":"2018-06-26T22:27:07Z","updated_at":"2018-06-26T22:27:54Z","html_url":"https://github.com/aragon/aragon-apps/pull/360#discussion_r198316976","pull_request_url":"https://api.github.com/repos/aragon/aragon-apps/pulls/360","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aragon/aragon-apps/pulls/comments/198316976"},"html":{"href":"https://github.com/aragon/aragon-apps/pull/360#discussion_r198316976"},"pull_request":{"href":"https://api.github.com/repos/aragon/aragon-apps/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/aragon/aragon-apps/pulls/360","id":193100143,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTAwMTQz","html_url":"https://github.com/aragon/aragon-apps/pull/360","diff_url":"https://github.com/aragon/aragon-apps/pull/360.diff","patch_url":"https://github.com/aragon/aragon-apps/pull/360.patch","issue_url":"https://api.github.com/repos/aragon/aragon-apps/issues/360","number":360,"state":"open","locked":false,"title":"Survey: Add Jest and some tests for math-utils.js","user":{"login":"bpierre","id":36158,"node_id":"MDQ6VXNlcjM2MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/36158?v=4","gravatar_id":"","url":"https://api.github.com/users/bpierre","html_url":"https://github.com/bpierre","followers_url":"https://api.github.com/users/bpierre/followers","following_url":"https://api.github.com/users/bpierre/following{/other_user}","gists_url":"https://api.github.com/users/bpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/bpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpierre/subscriptions","organizations_url":"https://api.github.com/users/bpierre/orgs","repos_url":"https://api.github.com/users/bpierre/repos","events_url":"https://api.github.com/users/bpierre/events{/privacy}","received_events_url":"https://api.github.com/users/bpierre/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-06T18:24:38Z","updated_at":"2018-06-26T22:27:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"deba3bbcae1c2e0ddccf874cbc9599ced06f2d9a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":954524130,"node_id":"MDU6TGFiZWw5NTQ1MjQxMzA=","url":"https://api.github.com/repos/aragon/aragon-apps/labels/app:%20survey","name":"app: survey","color":"446cb3","default":false},{"id":959272867,"node_id":"MDU6TGFiZWw5NTkyNzI4Njc=","url":"https://api.github.com/repos/aragon/aragon-apps/labels/sprint:%200.5.2","name":"sprint: 0.5.2","color":"b5f23c","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aragon/aragon-apps/pulls/360/commits","review_comments_url":"https://api.github.com/repos/aragon/aragon-apps/pulls/360/comments","review_comment_url":"https://api.github.com/repos/aragon/aragon-apps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aragon/aragon-apps/issues/360/comments","statuses_url":"https://api.github.com/repos/aragon/aragon-apps/statuses/0ce583189a58e86704d40961e8294075569cfaed","head":{"label":"aragon:add-jest","ref":"add-jest","sha":"0ce583189a58e86704d40961e8294075569cfaed","user":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"repo":{"id":107204572,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcyMDQ1NzI=","name":"aragon-apps","full_name":"aragon/aragon-apps","owner":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aragon/aragon-apps","description":"Aragon core team developed Aragon apps (smart contracts + webapps)","fork":false,"url":"https://api.github.com/repos/aragon/aragon-apps","forks_url":"https://api.github.com/repos/aragon/aragon-apps/forks","keys_url":"https://api.github.com/repos/aragon/aragon-apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aragon/aragon-apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aragon/aragon-apps/teams","hooks_url":"https://api.github.com/repos/aragon/aragon-apps/hooks","issue_events_url":"https://api.github.com/repos/aragon/aragon-apps/issues/events{/number}","events_url":"https://api.github.com/repos/aragon/aragon-apps/events","assignees_url":"https://api.github.com/repos/aragon/aragon-apps/assignees{/user}","branches_url":"https://api.github.com/repos/aragon/aragon-apps/branches{/branch}","tags_url":"https://api.github.com/repos/aragon/aragon-apps/tags","blobs_url":"https://api.github.com/repos/aragon/aragon-apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aragon/aragon-apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aragon/aragon-apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/aragon/aragon-apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aragon/aragon-apps/statuses/{sha}","languages_url":"https://api.github.com/repos/aragon/aragon-apps/languages","stargazers_url":"https://api.github.com/repos/aragon/aragon-apps/stargazers","contributors_url":"https://api.github.com/repos/aragon/aragon-apps/contributors","subscribers_url":"https://api.github.com/repos/aragon/aragon-apps/subscribers","subscription_url":"https://api.github.com/repos/aragon/aragon-apps/subscription","commits_url":"https://api.github.com/repos/aragon/aragon-apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/aragon/aragon-apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/aragon/aragon-apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/aragon/aragon-apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/aragon/aragon-apps/contents/{+path}","compare_url":"https://api.github.com/repos/aragon/aragon-apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aragon/aragon-apps/merges","archive_url":"https://api.github.com/repos/aragon/aragon-apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aragon/aragon-apps/downloads","issues_url":"https://api.github.com/repos/aragon/aragon-apps/issues{/number}","pulls_url":"https://api.github.com/repos/aragon/aragon-apps/pulls{/number}","milestones_url":"https://api.github.com/repos/aragon/aragon-apps/milestones{/number}","notifications_url":"https://api.github.com/repos/aragon/aragon-apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aragon/aragon-apps/labels{/name}","releases_url":"https://api.github.com/repos/aragon/aragon-apps/releases{/id}","deployments_url":"https://api.github.com/repos/aragon/aragon-apps/deployments","created_at":"2017-10-17T01:54:19Z","updated_at":"2018-06-24T12:00:06Z","pushed_at":"2018-06-26T08:24:26Z","git_url":"git://github.com/aragon/aragon-apps.git","ssh_url":"git@github.com:aragon/aragon-apps.git","clone_url":"https://github.com/aragon/aragon-apps.git","svn_url":"https://github.com/aragon/aragon-apps","homepage":"https://aragon.one/core","size":5309,"stargazers_count":87,"watchers_count":87,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":41,"open_issues":80,"watchers":87,"default_branch":"master"}},"base":{"label":"aragon:master","ref":"master","sha":"05bf9e858e5234429f13bda22b7db9f79cba2f9e","user":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"repo":{"id":107204572,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcyMDQ1NzI=","name":"aragon-apps","full_name":"aragon/aragon-apps","owner":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aragon/aragon-apps","description":"Aragon core team developed Aragon apps (smart contracts + webapps)","fork":false,"url":"https://api.github.com/repos/aragon/aragon-apps","forks_url":"https://api.github.com/repos/aragon/aragon-apps/forks","keys_url":"https://api.github.com/repos/aragon/aragon-apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aragon/aragon-apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aragon/aragon-apps/teams","hooks_url":"https://api.github.com/repos/aragon/aragon-apps/hooks","issue_events_url":"https://api.github.com/repos/aragon/aragon-apps/issues/events{/number}","events_url":"https://api.github.com/repos/aragon/aragon-apps/events","assignees_url":"https://api.github.com/repos/aragon/aragon-apps/assignees{/user}","branches_url":"https://api.github.com/repos/aragon/aragon-apps/branches{/branch}","tags_url":"https://api.github.com/repos/aragon/aragon-apps/tags","blobs_url":"https://api.github.com/repos/aragon/aragon-apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aragon/aragon-apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aragon/aragon-apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/aragon/aragon-apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aragon/aragon-apps/statuses/{sha}","languages_url":"https://api.github.com/repos/aragon/aragon-apps/languages","stargazers_url":"https://api.github.com/repos/aragon/aragon-apps/stargazers","contributors_url":"https://api.github.com/repos/aragon/aragon-apps/contributors","subscribers_url":"https://api.github.com/repos/aragon/aragon-apps/subscribers","subscription_url":"https://api.github.com/repos/aragon/aragon-apps/subscription","commits_url":"https://api.github.com/repos/aragon/aragon-apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/aragon/aragon-apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/aragon/aragon-apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/aragon/aragon-apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/aragon/aragon-apps/contents/{+path}","compare_url":"https://api.github.com/repos/aragon/aragon-apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aragon/aragon-apps/merges","archive_url":"https://api.github.com/repos/aragon/aragon-apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aragon/aragon-apps/downloads","issues_url":"https://api.github.com/repos/aragon/aragon-apps/issues{/number}","pulls_url":"https://api.github.com/repos/aragon/aragon-apps/pulls{/number}","milestones_url":"https://api.github.com/repos/aragon/aragon-apps/milestones{/number}","notifications_url":"https://api.github.com/repos/aragon/aragon-apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aragon/aragon-apps/labels{/name}","releases_url":"https://api.github.com/repos/aragon/aragon-apps/releases{/id}","deployments_url":"https://api.github.com/repos/aragon/aragon-apps/deployments","created_at":"2017-10-17T01:54:19Z","updated_at":"2018-06-24T12:00:06Z","pushed_at":"2018-06-26T08:24:26Z","git_url":"git://github.com/aragon/aragon-apps.git","ssh_url":"git@github.com:aragon/aragon-apps.git","clone_url":"https://github.com/aragon/aragon-apps.git","svn_url":"https://github.com/aragon/aragon-apps","homepage":"https://aragon.one/core","size":5309,"stargazers_count":87,"watchers_count":87,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":41,"open_issues":80,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aragon/aragon-apps/pulls/360"},"html":{"href":"https://github.com/aragon/aragon-apps/pull/360"},"issue":{"href":"https://api.github.com/repos/aragon/aragon-apps/issues/360"},"comments":{"href":"https://api.github.com/repos/aragon/aragon-apps/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/aragon/aragon-apps/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/aragon/aragon-apps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aragon/aragon-apps/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/aragon/aragon-apps/statuses/0ce583189a58e86704d40961e8294075569cfaed"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sohkai"}}