{"action":"created","issue":{"url":"https://api.github.com/repos/realm/SwiftLint/issues/2172","repository_url":"https://api.github.com/repos/realm/SwiftLint","labels_url":"https://api.github.com/repos/realm/SwiftLint/issues/2172/labels{/name}","comments_url":"https://api.github.com/repos/realm/SwiftLint/issues/2172/comments","events_url":"https://api.github.com/repos/realm/SwiftLint/issues/2172/events","html_url":"https://github.com/realm/SwiftLint/pull/2172","id":317920586,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0MjU3OTAw","number":2172,"title":"Add `missing_docs` rule back","user":{"login":"Nef10","id":4551135,"node_id":"MDQ6VXNlcjQ1NTExMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4551135?v=4","gravatar_id":"","url":"https://api.github.com/users/Nef10","html_url":"https://github.com/Nef10","followers_url":"https://api.github.com/users/Nef10/followers","following_url":"https://api.github.com/users/Nef10/following{/other_user}","gists_url":"https://api.github.com/users/Nef10/gists{/gist_id}","starred_url":"https://api.github.com/users/Nef10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nef10/subscriptions","organizations_url":"https://api.github.com/users/Nef10/orgs","repos_url":"https://api.github.com/users/Nef10/repos","events_url":"https://api.github.com/users/Nef10/events{/privacy}","received_events_url":"https://api.github.com/users/Nef10/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-26T08:10:06Z","updated_at":"2018-07-20T15:36:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/realm/SwiftLint/pulls/2172","html_url":"https://github.com/realm/SwiftLint/pull/2172","diff_url":"https://github.com/realm/SwiftLint/pull/2172.diff","patch_url":"https://github.com/realm/SwiftLint/pull/2172.patch"},"body":"This opt-in rule is based on the [old code](https://github.com/realm/SwiftLint/blob/80b0c96dd721da67657a04eb50e92c2936b2a1c9/Source/SwiftLintFramework/Rules/MissingDocsRule.swift)\r\n\r\nConfiguration works like this:\r\n```\r\nmissing_docs:\r\n  error: open\r\n  warning:\r\n  - internal\r\n  - public\r\n```\r\n\r\nOpen points:\r\n\r\n- [x] run test on docker\r\n- [ ] should we exclude test functions?\r\n- [ ] should we exclude functions like `==`?\r\n- [x] better configuration parsing \r\n- [x] unit tests for configuration parsing\r\n\r\nfixes #1652"},"comment":{"url":"https://api.github.com/repos/realm/SwiftLint/issues/comments/406638055","html_url":"https://github.com/realm/SwiftLint/pull/2172#issuecomment-406638055","issue_url":"https://api.github.com/repos/realm/SwiftLint/issues/2172","id":406638055,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjYzODA1NQ==","user":{"login":"joshuatbrown","id":59564,"node_id":"MDQ6VXNlcjU5NTY0","avatar_url":"https://avatars0.githubusercontent.com/u/59564?v=4","gravatar_id":"","url":"https://api.github.com/users/joshuatbrown","html_url":"https://github.com/joshuatbrown","followers_url":"https://api.github.com/users/joshuatbrown/followers","following_url":"https://api.github.com/users/joshuatbrown/following{/other_user}","gists_url":"https://api.github.com/users/joshuatbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuatbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuatbrown/subscriptions","organizations_url":"https://api.github.com/users/joshuatbrown/orgs","repos_url":"https://api.github.com/users/joshuatbrown/repos","events_url":"https://api.github.com/users/joshuatbrown/events{/privacy}","received_events_url":"https://api.github.com/users/joshuatbrown/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T15:36:13Z","updated_at":"2018-07-20T15:36:13Z","author_association":"NONE","body":"I'm not seeing what failed in circleci — only that there was \"1 error\". Are we just waiting on that to be fixed before this can be merged? I'd love to have this feature in SwiftLint and am happy to help if I can."}}
{"actor":{"display_login":"joshuatbrown"}}