{"action":"created","comment":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/213465666","pull_request_review_id":150308945,"id":213465666,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzQ2NTY2Ng==","diff_hunk":"@@ -980,6 +990,8 @@ void Ekf2::run()\n \t\t\t\t_gps_state[1].lat = gps.lat;\n \t\t\t\t_gps_state[1].lon = gps.lon;\n \t\t\t\t_gps_state[1].alt = gps.alt;\n+\t\t\t\t_gps_state[1].yaw_offset = gps_yaw_offset;","path":"src/modules/ekf2/ekf2_main.cpp","position":28,"original_position":28,"commit_id":"39079c344baf018b327b3c712846486f2385efb3","original_commit_id":"39079c344baf018b327b3c712846486f2385efb3","user":{"login":"dagar","id":84712,"node_id":"MDQ6VXNlcjg0NzEy","avatar_url":"https://avatars3.githubusercontent.com/u/84712?v=4","gravatar_id":"","url":"https://api.github.com/users/dagar","html_url":"https://github.com/dagar","followers_url":"https://api.github.com/users/dagar/followers","following_url":"https://api.github.com/users/dagar/following{/other_user}","gists_url":"https://api.github.com/users/dagar/gists{/gist_id}","starred_url":"https://api.github.com/users/dagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagar/subscriptions","organizations_url":"https://api.github.com/users/dagar/orgs","repos_url":"https://api.github.com/users/dagar/repos","events_url":"https://api.github.com/users/dagar/events{/privacy}","received_events_url":"https://api.github.com/users/dagar/received_events","type":"User","site_admin":false},"body":"yaw (gps.heading) missing?","created_at":"2018-08-28T20:44:41Z","updated_at":"2018-08-28T20:44:41Z","html_url":"https://github.com/PX4/Firmware/pull/10355#discussion_r213465666","pull_request_url":"https://api.github.com/repos/PX4/Firmware/pulls/10355","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/213465666"},"html":{"href":"https://github.com/PX4/Firmware/pull/10355#discussion_r213465666"},"pull_request":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/10355"}}},"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/10355","id":211550700,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTUwNzAw","html_url":"https://github.com/PX4/Firmware/pull/10355","diff_url":"https://github.com/PX4/Firmware/pull/10355.diff","patch_url":"https://github.com/PX4/Firmware/pull/10355.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/10355","number":10355,"state":"open","locked":false,"title":"ekf2: Allow use of RTK GPS heading","user":{"login":"priseborough","id":3596952,"node_id":"MDQ6VXNlcjM1OTY5NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3596952?v=4","gravatar_id":"","url":"https://api.github.com/users/priseborough","html_url":"https://github.com/priseborough","followers_url":"https://api.github.com/users/priseborough/followers","following_url":"https://api.github.com/users/priseborough/following{/other_user}","gists_url":"https://api.github.com/users/priseborough/gists{/gist_id}","starred_url":"https://api.github.com/users/priseborough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priseborough/subscriptions","organizations_url":"https://api.github.com/users/priseborough/orgs","repos_url":"https://api.github.com/users/priseborough/repos","events_url":"https://api.github.com/users/priseborough/events{/privacy}","received_events_url":"https://api.github.com/users/priseborough/received_events","type":"User","site_admin":false},"body":"Adds feature requested by https://github.com/PX4/Firmware/issues/10284\r\n\r\nRequires https://github.com/PX4/ecl/pull/497\r\n\r\nIs inactive with default parameters.\r\n\r\n**Testing**\r\n\r\nSee https://github.com/PX4/ecl/pull/497 for details of previous testing using replay.\r\n\r\nTODO repeat replay testing with this branch.\r\n\r\nTesting this branch requires settig EKF2_AID_MASK = 129 and EKF2_MAG_TYPE = 5. That will force the EKF to wait until GPS yaw is available before performing the yaw alignment. If EKF2_MAG_TYPE = 0, then the yaw will be set using the magnetomer intially and then reset to the GPS yaw when it becomes available.\r\n\r\n","created_at":"2018-08-28T20:38:52Z","updated_at":"2018-08-28T20:44:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"281f0fd8d8cae5aff5286f74ac960d8c98cb1dbd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bkueng","id":281593,"node_id":"MDQ6VXNlcjI4MTU5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/281593?v=4","gravatar_id":"","url":"https://api.github.com/users/bkueng","html_url":"https://github.com/bkueng","followers_url":"https://api.github.com/users/bkueng/followers","following_url":"https://api.github.com/users/bkueng/following{/other_user}","gists_url":"https://api.github.com/users/bkueng/gists{/gist_id}","starred_url":"https://api.github.com/users/bkueng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkueng/subscriptions","organizations_url":"https://api.github.com/users/bkueng/orgs","repos_url":"https://api.github.com/users/bkueng/repos","events_url":"https://api.github.com/users/bkueng/events{/privacy}","received_events_url":"https://api.github.com/users/bkueng/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":10884840,"node_id":"MDU6TGFiZWwxMDg4NDg0MA==","url":"https://api.github.com/repos/PX4/Firmware/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/10355/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/10355/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/10355/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/39079c344baf018b327b3c712846486f2385efb3","head":{"label":"priseborough:pr-ekfGpsYaw","ref":"pr-ekfGpsYaw","sha":"39079c344baf018b327b3c712846486f2385efb3","user":{"login":"priseborough","id":3596952,"node_id":"MDQ6VXNlcjM1OTY5NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3596952?v=4","gravatar_id":"","url":"https://api.github.com/users/priseborough","html_url":"https://github.com/priseborough","followers_url":"https://api.github.com/users/priseborough/followers","following_url":"https://api.github.com/users/priseborough/following{/other_user}","gists_url":"https://api.github.com/users/priseborough/gists{/gist_id}","starred_url":"https://api.github.com/users/priseborough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priseborough/subscriptions","organizations_url":"https://api.github.com/users/priseborough/orgs","repos_url":"https://api.github.com/users/priseborough/repos","events_url":"https://api.github.com/users/priseborough/events{/privacy}","received_events_url":"https://api.github.com/users/priseborough/received_events","type":"User","site_admin":false},"repo":{"id":21996422,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk5NjQyMg==","name":"Firmware","full_name":"priseborough/Firmware","owner":{"login":"priseborough","id":3596952,"node_id":"MDQ6VXNlcjM1OTY5NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3596952?v=4","gravatar_id":"","url":"https://api.github.com/users/priseborough","html_url":"https://github.com/priseborough","followers_url":"https://api.github.com/users/priseborough/followers","following_url":"https://api.github.com/users/priseborough/following{/other_user}","gists_url":"https://api.github.com/users/priseborough/gists{/gist_id}","starred_url":"https://api.github.com/users/priseborough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priseborough/subscriptions","organizations_url":"https://api.github.com/users/priseborough/orgs","repos_url":"https://api.github.com/users/priseborough/repos","events_url":"https://api.github.com/users/priseborough/events{/privacy}","received_events_url":"https://api.github.com/users/priseborough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/priseborough/Firmware","description":"PX4 Firmware for PX4FMU autopilot and PX4IO servo / failsafe board","fork":true,"url":"https://api.github.com/repos/priseborough/Firmware","forks_url":"https://api.github.com/repos/priseborough/Firmware/forks","keys_url":"https://api.github.com/repos/priseborough/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/priseborough/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/priseborough/Firmware/teams","hooks_url":"https://api.github.com/repos/priseborough/Firmware/hooks","issue_events_url":"https://api.github.com/repos/priseborough/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/priseborough/Firmware/events","assignees_url":"https://api.github.com/repos/priseborough/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/priseborough/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/priseborough/Firmware/tags","blobs_url":"https://api.github.com/repos/priseborough/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/priseborough/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/priseborough/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/priseborough/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/priseborough/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/priseborough/Firmware/languages","stargazers_url":"https://api.github.com/repos/priseborough/Firmware/stargazers","contributors_url":"https://api.github.com/repos/priseborough/Firmware/contributors","subscribers_url":"https://api.github.com/repos/priseborough/Firmware/subscribers","subscription_url":"https://api.github.com/repos/priseborough/Firmware/subscription","commits_url":"https://api.github.com/repos/priseborough/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/priseborough/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/priseborough/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/priseborough/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/priseborough/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/priseborough/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/priseborough/Firmware/merges","archive_url":"https://api.github.com/repos/priseborough/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/priseborough/Firmware/downloads","issues_url":"https://api.github.com/repos/priseborough/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/priseborough/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/priseborough/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/priseborough/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/priseborough/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/priseborough/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/priseborough/Firmware/deployments","created_at":"2014-07-18T22:35:21Z","updated_at":"2017-11-19T21:04:03Z","pushed_at":"2018-08-28T20:29:18Z","git_url":"git://github.com/priseborough/Firmware.git","ssh_url":"git@github.com:priseborough/Firmware.git","clone_url":"https://github.com/priseborough/Firmware.git","svn_url":"https://github.com/priseborough/Firmware","homepage":"https://pixhawk.ethz.ch/px4/","size":99542,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":0,"watchers":1,"default_branch":"patch-1"}},"base":{"label":"PX4:master","ref":"master","sha":"c10ea132b420072b5a0dfcb03940ddef2618dc87","user":{"login":"PX4","id":2096014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTYwMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjk4Nzkw","name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTYwMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2018-08-28T18:28:36Z","pushed_at":"2018-08-28T20:43:26Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"http://px4.io","size":102126,"stargazers_count":1914,"watchers_count":1914,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5674,"mirror_url":null,"archived":false,"open_issues_count":585,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":5674,"open_issues":585,"watchers":1914,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/10355"},"html":{"href":"https://github.com/PX4/Firmware/pull/10355"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/10355"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/10355/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/10355/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/10355/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/39079c344baf018b327b3c712846486f2385efb3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dagar"}}