{"action":"created","comment":{"url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/comments/194403644","pull_request_review_id":127566596,"id":194403644,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDQwMzY0NA==","diff_hunk":"@@ -0,0 +1,89 @@\n+'use strict';\n+const should = require('should');\n+const TestFixtureProver = require('../dist/commonjs/test_fixture_provider').TestFixtureProvider;\n+\n+describe.skip('Error End Event - ', () => {\n+\n+  let testFixtureProvider;\n+\n+  before(async () => {\n+    testFixtureProvider = new TestFixtureProver();\n+    await testFixtureProvider.initializeAndStart();\n+\n+    // TODO: The import is currently broken (existing processes are duplicated, not overwritten).\n+    // Until this is fixed, use the \"classic\" ioc registration\n+    //\n+    // const processDefFileList = ['error_end_event_test.bpmn'];\n+    // await testFixtureProvider.loadProcessesFromBPMNFiles(processDefFileList);\n+  });\n+\n+  after(async () => {\n+    await testFixtureProvider.tearDown();\n+  });\n+\n+  it('should thrown an error, when the error end event is reached', async () => {\n+    const processModelKey = 'error_end_event_test';\n+\n+    const processInstancePromise = testFixtureProvider.executeProcess(processModelKey);\n+    \n+    // TODO: Since the behavior of the error end event is not fully designed.\n+    // The object that is returned from a process, that ends with an Error","path":"_integration_tests/test/error_end_event_test.js","position":30,"original_position":30,"commit_id":"c7bc64e3a95c26ad258f0708c90ece149c5b6afb","original_commit_id":"c7bc64e3a95c26ad258f0708c90ece149c5b6afb","user":{"login":"ElRaptorus","id":15343316,"node_id":"MDQ6VXNlcjE1MzQzMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/15343316?v=4","gravatar_id":"","url":"https://api.github.com/users/ElRaptorus","html_url":"https://github.com/ElRaptorus","followers_url":"https://api.github.com/users/ElRaptorus/followers","following_url":"https://api.github.com/users/ElRaptorus/following{/other_user}","gists_url":"https://api.github.com/users/ElRaptorus/gists{/gist_id}","starred_url":"https://api.github.com/users/ElRaptorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElRaptorus/subscriptions","organizations_url":"https://api.github.com/users/ElRaptorus/orgs","repos_url":"https://api.github.com/users/ElRaptorus/repos","events_url":"https://api.github.com/users/ElRaptorus/events{/privacy}","received_events_url":"https://api.github.com/users/ElRaptorus/received_events","type":"User","site_admin":false},"body":"Please don't split a components name into multiple rows.\r\nJust makes comments like this harder to read.\r\n\r\nThe components name is `ErrorEndEvent` and it should always be written like this.","created_at":"2018-06-11T13:30:11Z","updated_at":"2018-06-11T13:31:58Z","html_url":"https://github.com/process-engine/process_engine_meta/pull/92#discussion_r194403644","pull_request_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/92","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/comments/194403644"},"html":{"href":"https://github.com/process-engine/process_engine_meta/pull/92#discussion_r194403644"},"pull_request":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/92"}}},"pull_request":{"url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/92","id":193973520,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzOTczNTIw","html_url":"https://github.com/process-engine/process_engine_meta/pull/92","diff_url":"https://github.com/process-engine/process_engine_meta/pull/92.diff","patch_url":"https://github.com/process-engine/process_engine_meta/pull/92.patch","issue_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/92","number":92,"state":"open","locked":false,"title":"[WIP] Integration tests for the error end event","user":{"login":"robpal94","id":38498731,"node_id":"MDQ6VXNlcjM4NDk4NzMx","avatar_url":"https://avatars1.githubusercontent.com/u/38498731?v=4","gravatar_id":"","url":"https://api.github.com/users/robpal94","html_url":"https://github.com/robpal94","followers_url":"https://api.github.com/users/robpal94/followers","following_url":"https://api.github.com/users/robpal94/following{/other_user}","gists_url":"https://api.github.com/users/robpal94/gists{/gist_id}","starred_url":"https://api.github.com/users/robpal94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robpal94/subscriptions","organizations_url":"https://api.github.com/users/robpal94/orgs","repos_url":"https://api.github.com/users/robpal94/repos","events_url":"https://api.github.com/users/robpal94/events{/privacy}","received_events_url":"https://api.github.com/users/robpal94/received_events","type":"User","site_admin":false},"body":"## What did you change?\r\nThis PR implements Integration tests for the error end event.\r\n\r\n## How can others test the changes?\r\nRun `npm test` in the _integration_tests directory.\r\n\r\n## PR-Checklist\r\n\r\nPlease check the boxes in this list after submitting your PR:\r\n\r\n- [ ] You can merge this PR **right now** (if not, please prefix the title with \"WIP: \")\r\n- [x] I've tested **all** changes included in this PR.\r\n- [x] I've also reviewed this PR myself before submitting (e.g. for scrambled letters, typos, etc.)\r\n- [x] I've merged the `develop` branch into my branch before finishing this PR.\r\n- [x] I've **not added any other changes** than the ones described above.\r\n- [x] I've mentioned all **PRs, which relate to this one**\r\n","created_at":"2018-06-11T12:59:54Z","updated_at":"2018-06-11T13:31:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"031ca9f24f34a084c60be14f56efd754fc0c0c83","assignee":null,"assignees":[],"requested_reviewers":[{"login":"5ebastianMeier","id":16539774,"node_id":"MDQ6VXNlcjE2NTM5Nzc0","avatar_url":"https://avatars0.githubusercontent.com/u/16539774?v=4","gravatar_id":"","url":"https://api.github.com/users/5ebastianMeier","html_url":"https://github.com/5ebastianMeier","followers_url":"https://api.github.com/users/5ebastianMeier/followers","following_url":"https://api.github.com/users/5ebastianMeier/following{/other_user}","gists_url":"https://api.github.com/users/5ebastianMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/5ebastianMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5ebastianMeier/subscriptions","organizations_url":"https://api.github.com/users/5ebastianMeier/orgs","repos_url":"https://api.github.com/users/5ebastianMeier/repos","events_url":"https://api.github.com/users/5ebastianMeier/events{/privacy}","received_events_url":"https://api.github.com/users/5ebastianMeier/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/92/commits","review_comments_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/92/comments","review_comment_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/92/comments","statuses_url":"https://api.github.com/repos/process-engine/process_engine_meta/statuses/c7bc64e3a95c26ad258f0708c90ece149c5b6afb","head":{"label":"process-engine:feature/Int_Test_Error_End_Event","ref":"feature/Int_Test_Error_End_Event","sha":"c7bc64e3a95c26ad258f0708c90ece149c5b6afb","user":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106316336,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzMTYzMzY=","name":"process_engine_meta","full_name":"process-engine/process_engine_meta","owner":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/process-engine/process_engine_meta","description":null,"fork":false,"url":"https://api.github.com/repos/process-engine/process_engine_meta","forks_url":"https://api.github.com/repos/process-engine/process_engine_meta/forks","keys_url":"https://api.github.com/repos/process-engine/process_engine_meta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/process_engine_meta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/process_engine_meta/teams","hooks_url":"https://api.github.com/repos/process-engine/process_engine_meta/hooks","issue_events_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/process_engine_meta/events","assignees_url":"https://api.github.com/repos/process-engine/process_engine_meta/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/process_engine_meta/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/process_engine_meta/tags","blobs_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/process_engine_meta/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/process_engine_meta/languages","stargazers_url":"https://api.github.com/repos/process-engine/process_engine_meta/stargazers","contributors_url":"https://api.github.com/repos/process-engine/process_engine_meta/contributors","subscribers_url":"https://api.github.com/repos/process-engine/process_engine_meta/subscribers","subscription_url":"https://api.github.com/repos/process-engine/process_engine_meta/subscription","commits_url":"https://api.github.com/repos/process-engine/process_engine_meta/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/process_engine_meta/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/process_engine_meta/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/process_engine_meta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/process_engine_meta/merges","archive_url":"https://api.github.com/repos/process-engine/process_engine_meta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/process_engine_meta/downloads","issues_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/process_engine_meta/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/process_engine_meta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/process_engine_meta/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/process_engine_meta/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/process_engine_meta/deployments","created_at":"2017-10-09T17:51:16Z","updated_at":"2018-06-11T12:49:08Z","pushed_at":"2018-06-11T13:07:26Z","git_url":"git://github.com/process-engine/process_engine_meta.git","ssh_url":"git@github.com:process-engine/process_engine_meta.git","clone_url":"https://github.com/process-engine/process_engine_meta.git","svn_url":"https://github.com/process-engine/process_engine_meta","homepage":null,"size":739,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":7,"watchers":3,"default_branch":"develop"}},"base":{"label":"process-engine:develop","ref":"develop","sha":"5cb563866ca46afe05600d9178fc69d7467cfda5","user":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106316336,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzMTYzMzY=","name":"process_engine_meta","full_name":"process-engine/process_engine_meta","owner":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/process-engine/process_engine_meta","description":null,"fork":false,"url":"https://api.github.com/repos/process-engine/process_engine_meta","forks_url":"https://api.github.com/repos/process-engine/process_engine_meta/forks","keys_url":"https://api.github.com/repos/process-engine/process_engine_meta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/process_engine_meta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/process_engine_meta/teams","hooks_url":"https://api.github.com/repos/process-engine/process_engine_meta/hooks","issue_events_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/process_engine_meta/events","assignees_url":"https://api.github.com/repos/process-engine/process_engine_meta/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/process_engine_meta/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/process_engine_meta/tags","blobs_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/process_engine_meta/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/process_engine_meta/languages","stargazers_url":"https://api.github.com/repos/process-engine/process_engine_meta/stargazers","contributors_url":"https://api.github.com/repos/process-engine/process_engine_meta/contributors","subscribers_url":"https://api.github.com/repos/process-engine/process_engine_meta/subscribers","subscription_url":"https://api.github.com/repos/process-engine/process_engine_meta/subscription","commits_url":"https://api.github.com/repos/process-engine/process_engine_meta/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/process_engine_meta/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/process_engine_meta/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/process_engine_meta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/process_engine_meta/merges","archive_url":"https://api.github.com/repos/process-engine/process_engine_meta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/process_engine_meta/downloads","issues_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/process_engine_meta/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/process_engine_meta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/process_engine_meta/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/process_engine_meta/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/process_engine_meta/deployments","created_at":"2017-10-09T17:51:16Z","updated_at":"2018-06-11T12:49:08Z","pushed_at":"2018-06-11T13:07:26Z","git_url":"git://github.com/process-engine/process_engine_meta.git","ssh_url":"git@github.com:process-engine/process_engine_meta.git","clone_url":"https://github.com/process-engine/process_engine_meta.git","svn_url":"https://github.com/process-engine/process_engine_meta","homepage":null,"size":739,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":7,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/92"},"html":{"href":"https://github.com/process-engine/process_engine_meta/pull/92"},"issue":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/issues/92"},"comments":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/statuses/c7bc64e3a95c26ad258f0708c90ece149c5b6afb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ElRaptorus"}}