{"action":"created","issue":{"url":"https://api.github.com/repos/albertlauncher/plugins/issues/17","repository_url":"https://api.github.com/repos/albertlauncher/plugins","labels_url":"https://api.github.com/repos/albertlauncher/plugins/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/albertlauncher/plugins/issues/17/comments","events_url":"https://api.github.com/repos/albertlauncher/plugins/issues/17/events","html_url":"https://github.com/albertlauncher/plugins/pull/17","id":375575790,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTg5NDM1","number":17,"title":"Prevent firefox bookmark index updates when no bookmarks were found","user":{"login":"SDEagle","id":867049,"node_id":"MDQ6VXNlcjg2NzA0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/867049?v=4","gravatar_id":"","url":"https://api.github.com/users/SDEagle","html_url":"https://github.com/SDEagle","followers_url":"https://api.github.com/users/SDEagle/followers","following_url":"https://api.github.com/users/SDEagle/following{/other_user}","gists_url":"https://api.github.com/users/SDEagle/gists{/gist_id}","starred_url":"https://api.github.com/users/SDEagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SDEagle/subscriptions","organizations_url":"https://api.github.com/users/SDEagle/orgs","repos_url":"https://api.github.com/users/SDEagle/repos","events_url":"https://api.github.com/users/SDEagle/events{/privacy}","received_events_url":"https://api.github.com/users/SDEagle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-30T16:19:07Z","updated_at":"2019-01-04T12:21:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/albertlauncher/plugins/pulls/17","html_url":"https://github.com/albertlauncher/plugins/pull/17","diff_url":"https://github.com/albertlauncher/plugins/pull/17.diff","patch_url":"https://github.com/albertlauncher/plugins/pull/17.patch"},"body":"Since Firefox 63 the SQLite Databse containing the bookmarks seems to be permanently locked when Firefox is running. The indexer is then unable to query the database and returns an empty result set which removes all bookmarks from alberts index :disappointed: \r\n\r\nThis PR changes the behavior to not apply updates from the indexing thread if the result set is empty. This is not a very clean solution but the indexer returns an empty vector as the error state which makes it hard to distinguish an error result from an actually empty result. On the other hand this solution will still do the right thing almost always except when you intentionally delete all your Firefox bookmarks and want them gone from alberts index, too. Not the most common use case, I guess... And you get it after a restart."},"comment":{"url":"https://api.github.com/repos/albertlauncher/plugins/issues/comments/451429888","html_url":"https://github.com/albertlauncher/plugins/pull/17#issuecomment-451429888","issue_url":"https://api.github.com/repos/albertlauncher/plugins/issues/17","id":451429888,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTQyOTg4OA==","user":{"login":"Elektropepi","id":13781376,"node_id":"MDQ6VXNlcjEzNzgxMzc2","avatar_url":"https://avatars0.githubusercontent.com/u/13781376?v=4","gravatar_id":"","url":"https://api.github.com/users/Elektropepi","html_url":"https://github.com/Elektropepi","followers_url":"https://api.github.com/users/Elektropepi/followers","following_url":"https://api.github.com/users/Elektropepi/following{/other_user}","gists_url":"https://api.github.com/users/Elektropepi/gists{/gist_id}","starred_url":"https://api.github.com/users/Elektropepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elektropepi/subscriptions","organizations_url":"https://api.github.com/users/Elektropepi/orgs","repos_url":"https://api.github.com/users/Elektropepi/repos","events_url":"https://api.github.com/users/Elektropepi/events{/privacy}","received_events_url":"https://api.github.com/users/Elektropepi/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T12:21:39Z","updated_at":"2019-01-04T12:21:39Z","author_association":"NONE","body":"I tested it and it fixes [this issue](https://github.com/albertlauncher/albert/issues/723). \r\nOnly problem seems to be that the firefox bookmarks are not updated as long as Firefox is open. (newly added/removed bookmarks are not correctly indexed)"}}
{"actor":{"display_login":"Elektropepi"}}