{"action":"created","issue":{"url":"https://api.github.com/repos/stardot/beebem-windows/issues/35","repository_url":"https://api.github.com/repos/stardot/beebem-windows","labels_url":"https://api.github.com/repos/stardot/beebem-windows/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/stardot/beebem-windows/issues/35/comments","events_url":"https://api.github.com/repos/stardot/beebem-windows/issues/35/events","html_url":"https://github.com/stardot/beebem-windows/issues/35","id":312289977,"number":35,"title":"Crash on start-up after fresh install of 415b1 feb12","user":{"login":"richard-broadhurst","id":22466543,"avatar_url":"https://avatars0.githubusercontent.com/u/22466543?v=4","gravatar_id":"","url":"https://api.github.com/users/richard-broadhurst","html_url":"https://github.com/richard-broadhurst","followers_url":"https://api.github.com/users/richard-broadhurst/followers","following_url":"https://api.github.com/users/richard-broadhurst/following{/other_user}","gists_url":"https://api.github.com/users/richard-broadhurst/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-broadhurst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-broadhurst/subscriptions","organizations_url":"https://api.github.com/users/richard-broadhurst/orgs","repos_url":"https://api.github.com/users/richard-broadhurst/repos","events_url":"https://api.github.com/users/richard-broadhurst/events{/privacy}","received_events_url":"https://api.github.com/users/richard-broadhurst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-08T09:33:43Z","updated_at":"2018-04-08T09:37:16Z","closed_at":null,"author_association":"NONE","body":"Beebem crashes on startup at end of install and trying to run beebem afterwards.\r\nI've built it locally with VS2017, I only have 6, 12, 13 and 17.\r\nTo build it from the .sln, I had to:\r\n#define WIN32 (the code deos #ifdef WIN32 #include <windows.h>, but windows.h is what is supposed to #define WIN32, it would be better to #ifdef _WIN32, which is supported by MSVC and gcc.\r\n#define _CRT_SECURE_NO_WARNINGS to remove the warnings (or replace all the function calls).\r\nSwap the character set to multi-byte instead of unicode (I always do this anyway!)\r\nI'm now seeing that the error is that m_DD2 is null in UpdateSmoothing, I suspect that this is because the config file has smoothing enabled, but beebem is not using DX as I have seen this bug in earlier versions."},"comment":{"url":"https://api.github.com/repos/stardot/beebem-windows/issues/comments/379536103","html_url":"https://github.com/stardot/beebem-windows/issues/35#issuecomment-379536103","issue_url":"https://api.github.com/repos/stardot/beebem-windows/issues/35","id":379536103,"user":{"login":"richard-broadhurst","id":22466543,"avatar_url":"https://avatars0.githubusercontent.com/u/22466543?v=4","gravatar_id":"","url":"https://api.github.com/users/richard-broadhurst","html_url":"https://github.com/richard-broadhurst","followers_url":"https://api.github.com/users/richard-broadhurst/followers","following_url":"https://api.github.com/users/richard-broadhurst/following{/other_user}","gists_url":"https://api.github.com/users/richard-broadhurst/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-broadhurst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-broadhurst/subscriptions","organizations_url":"https://api.github.com/users/richard-broadhurst/orgs","repos_url":"https://api.github.com/users/richard-broadhurst/repos","events_url":"https://api.github.com/users/richard-broadhurst/events{/privacy}","received_events_url":"https://api.github.com/users/richard-broadhurst/received_events","type":"User","site_admin":false},"created_at":"2018-04-08T09:37:16Z","updated_at":"2018-04-08T09:37:16Z","author_association":"NONE","body":"I've added an if (m_DD2) to the else in BeebWin::UpdateSmoothingwhich seems to have solved the immediate issue.\r\nvoid BeebWin::UpdateSmoothing(void)\r\n{\r\n\tDDSURFACEDESC ddsd;\r\n\tHRESULT ddrval;\r\n\r\n\tif (m_DisplayRenderer == IDM_DISPDX9)\r\n\t{\r\n\t\tif (m_DXSmoothing && (!m_DXSmoothMode7Only || TeletextEnabled))\r\n\t\t{\r\n\t\t\t// Turn on bilinear interpolation so image is smoothed\r\n\t\t\tm_pd3dDevice->SetSamplerState( 0, D3DSAMP_MINFILTER, D3DTEXF_LINEAR );\r\n\t\t\tm_pd3dDevice->SetSamplerState( 0, D3DSAMP_MAGFILTER, D3DTEXF_LINEAR );\r\n\t\t}\r\n\t\telse\r\n\t\t{\r\n\t\t\t// Turn off bilinear interpolation\r\n\t\t\tm_pd3dDevice->SetSamplerState( 0, D3DSAMP_MINFILTER, D3DTEXF_POINT );\r\n\t\t\tm_pd3dDevice->SetSamplerState( 0, D3DSAMP_MAGFILTER, D3DTEXF_POINT );\r\n\t\t}\r\n\t}\r\n\telse **if (m_DD2)**"}}
{"actor":{"display_login":"richard-broadhurst"}}