{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/comments/208109248","pull_request_review_id":143851771,"id":208109248,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODEwOTI0OA==","diff_hunk":"@@ -1,16 +1,33 @@\n # mbed-client-cli\n \n-This is the Command Line Library for a CLI application. This library provides methods for:\n+This is the Command Line Library for a CLI application. It uses only ansi C features so it is portable and works in mbed-os-3, mbed-os-5, linux and windows.\n+\n+## Features\n+\n+Library provides features such:\n \n * Adding commands to the interpreter.\n * Deleting commands from the interpreter.\n * Executing commands.\n * Adding command aliases to the interpreter.\n * Searching command arguments.\n+* implements several VT100/VT220 features, e.g.\n+  * move cursor left/right (or skipping word by pressing alt+up/right)\n+  * delete characters\n+  * CTRL+W to remove previous word\n+  * browse command history by pressing up/down\n+* implements basic commands, e.g.\n+  * echo\n+  * help\n+  * (un)set","path":"README.md","position":23,"original_position":23,"commit_id":"a040983c89b631d94af8e61802183b3c354cde38","original_commit_id":"b25a9bc53f0d410c106b7269f6ed7347246a6cff","user":{"login":"YifeiZuo01","id":19773173,"node_id":"MDQ6VXNlcjE5NzczMTcz","avatar_url":"https://avatars1.githubusercontent.com/u/19773173?v=4","gravatar_id":"","url":"https://api.github.com/users/YifeiZuo01","html_url":"https://github.com/YifeiZuo01","followers_url":"https://api.github.com/users/YifeiZuo01/followers","following_url":"https://api.github.com/users/YifeiZuo01/following{/other_user}","gists_url":"https://api.github.com/users/YifeiZuo01/gists{/gist_id}","starred_url":"https://api.github.com/users/YifeiZuo01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YifeiZuo01/subscriptions","organizations_url":"https://api.github.com/users/YifeiZuo01/orgs","repos_url":"https://api.github.com/users/YifeiZuo01/repos","events_url":"https://api.github.com/users/YifeiZuo01/events{/privacy}","received_events_url":"https://api.github.com/users/YifeiZuo01/received_events","type":"User","site_admin":false},"body":"okay, I see. I was testing with mbed-os-5-example.bin build by CI, but the mbed-client-cli.lib isn't up to date.","created_at":"2018-08-07T06:15:18Z","updated_at":"2018-08-07T06:15:18Z","html_url":"https://github.com/ARMmbed/mbed-client-cli/pull/76#discussion_r208109248","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/76","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/comments/208109248"},"html":{"href":"https://github.com/ARMmbed/mbed-client-cli/pull/76#discussion_r208109248"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/76"}},"in_reply_to_id":207889049},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/76","id":201996590,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTk2NTkw","html_url":"https://github.com/ARMmbed/mbed-client-cli/pull/76","diff_url":"https://github.com/ARMmbed/mbed-client-cli/pull/76.diff","patch_url":"https://github.com/ARMmbed/mbed-client-cli/pull/76.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/76","number":76,"state":"open","locked":false,"title":"Improvements for cli behaviour","user":{"login":"jupe","id":3822425,"node_id":"MDQ6VXNlcjM4MjI0MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3822425?v=4","gravatar_id":"","url":"https://api.github.com/users/jupe","html_url":"https://github.com/jupe","followers_url":"https://api.github.com/users/jupe/followers","following_url":"https://api.github.com/users/jupe/following{/other_user}","gists_url":"https://api.github.com/users/jupe/gists{/gist_id}","starred_url":"https://api.github.com/users/jupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupe/subscriptions","organizations_url":"https://api.github.com/users/jupe/orgs","repos_url":"https://api.github.com/users/jupe/repos","events_url":"https://api.github.com/users/jupe/events{/privacy}","received_events_url":"https://api.github.com/users/jupe/received_events","type":"User","site_admin":false},"body":"## Status\r\n**IN DEVELOPMENT**\r\n\r\n## Migrations\r\nNO\r\n\r\n## Description\r\nSeveral improvements:\r\n* optional disable man pages - to save memory\r\n* variable can be also integer\r\n* store previous retcode to `?` -variable\r\n* store prompt as `PS1` -variable (possible to change using `set´ -cmd)\r\n* api to request screen size: `cmd_request_screen_size(void)` -> generates variables: `COLUMNS`, `LINES`\r\n* `true` and `false` -commands\r\n* ctrl+w support (remove previous word)\r\n* escape character parsing (IOTSYSTOOL-131)\r\n* Improve test coverage\r\n\r\n## Todos\r\n- [ ] Tests\r\n- [x] Documentation","created_at":"2018-07-17T16:19:02Z","updated_at":"2018-08-07T06:15:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"716f89a2384ef4dda594c64448e5188ef0e39931","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kuggenhoffen","id":7490041,"node_id":"MDQ6VXNlcjc0OTAwNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7490041?v=4","gravatar_id":"","url":"https://api.github.com/users/kuggenhoffen","html_url":"https://github.com/kuggenhoffen","followers_url":"https://api.github.com/users/kuggenhoffen/followers","following_url":"https://api.github.com/users/kuggenhoffen/following{/other_user}","gists_url":"https://api.github.com/users/kuggenhoffen/gists{/gist_id}","starred_url":"https://api.github.com/users/kuggenhoffen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuggenhoffen/subscriptions","organizations_url":"https://api.github.com/users/kuggenhoffen/orgs","repos_url":"https://api.github.com/users/kuggenhoffen/repos","events_url":"https://api.github.com/users/kuggenhoffen/events{/privacy}","received_events_url":"https://api.github.com/users/kuggenhoffen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/76/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/76/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/76/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/statuses/a040983c89b631d94af8e61802183b3c354cde38","head":{"label":"ARMmbed:refactoring","ref":"refactoring","sha":"a040983c89b631d94af8e61802183b3c354cde38","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":41283271,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI4MzI3MQ==","name":"mbed-client-cli","full_name":"ARMmbed/mbed-client-cli","owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-client-cli","description":"Command Line Interface library for device","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-client-cli","forks_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/deployments","created_at":"2015-08-24T05:10:00Z","updated_at":"2018-08-06T19:04:49Z","pushed_at":"2018-08-06T19:47:04Z","git_url":"git://github.com/ARMmbed/mbed-client-cli.git","ssh_url":"git@github.com:ARMmbed/mbed-client-cli.git","clone_url":"https://github.com/ARMmbed/mbed-client-cli.git","svn_url":"https://github.com/ARMmbed/mbed-client-cli","homepage":"","size":248,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"737d05e0354241dd87f67c4df6c471d5b8685412","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":41283271,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI4MzI3MQ==","name":"mbed-client-cli","full_name":"ARMmbed/mbed-client-cli","owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-client-cli","description":"Command Line Interface library for device","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-client-cli","forks_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/deployments","created_at":"2015-08-24T05:10:00Z","updated_at":"2018-08-06T19:04:49Z","pushed_at":"2018-08-06T19:47:04Z","git_url":"git://github.com/ARMmbed/mbed-client-cli.git","ssh_url":"git@github.com:ARMmbed/mbed-client-cli.git","clone_url":"https://github.com/ARMmbed/mbed-client-cli.git","svn_url":"https://github.com/ARMmbed/mbed-client-cli","homepage":"","size":248,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/76"},"html":{"href":"https://github.com/ARMmbed/mbed-client-cli/pull/76"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/76"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/statuses/a040983c89b631d94af8e61802183b3c354cde38"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"YifeiZuo01"}}