{"action":"closed","number":198,"pull_request":{"url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/198","id":204037596,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MDM3NTk2","html_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller/pull/198","diff_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller/pull/198.diff","patch_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller/pull/198.patch","issue_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/198","number":198,"state":"closed","locked":false,"title":"Detach non-existing target groups from ASGs","user":{"login":"mikkeloscar","id":128566,"node_id":"MDQ6VXNlcjEyODU2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/128566?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkeloscar","html_url":"https://github.com/mikkeloscar","followers_url":"https://api.github.com/users/mikkeloscar/followers","following_url":"https://api.github.com/users/mikkeloscar/following{/other_user}","gists_url":"https://api.github.com/users/mikkeloscar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkeloscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkeloscar/subscriptions","organizations_url":"https://api.github.com/users/mikkeloscar/orgs","repos_url":"https://api.github.com/users/mikkeloscar/repos","events_url":"https://api.github.com/users/mikkeloscar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkeloscar/received_events","type":"User","site_admin":false},"body":"In case an Ingress stack is deleted, the TargetGroup will also be\ndeleted, but not removed from the list of TargetGroups in the ASG.\n\nThis renders the ASG in a state where it can't spawn new instances\nbecause it can't attach the non-existing TargetGroup.\n\nTo fix this, the controller will now look up all TargetGroups every time\nit consider TargetGroups to attachment/detachment of an ASG.\n\nFix #197","created_at":"2018-07-26T06:11:47Z","updated_at":"2018-07-26T16:47:26Z","closed_at":"2018-07-26T16:47:26Z","merged_at":"2018-07-26T16:47:26Z","merge_commit_sha":"81b43bcdaed9cb3d472d3c26c57727d5dce9aec7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/198/commits","review_comments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/198/comments","review_comment_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/198/comments","statuses_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/statuses/9bcdd5ff7fe872ced61025fbf629fe90d761d524","head":{"label":"zalando-incubator:detach-non-existing-tgs","ref":"detach-non-existing-tgs","sha":"9bcdd5ff7fe872ced61025fbf629fe90d761d524","user":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":75087504,"node_id":"MDEwOlJlcG9zaXRvcnk3NTA4NzUwNA==","name":"kube-ingress-aws-controller","full_name":"zalando-incubator/kube-ingress-aws-controller","owner":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller","description":"Configures AWS Load Balancers according to Kubernetes Ingress resources","fork":false,"url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller","forks_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/forks","keys_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/events","assignees_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/merges","archive_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/deployments","created_at":"2016-11-29T14:10:14Z","updated_at":"2018-07-25T21:40:31Z","pushed_at":"2018-07-26T16:47:26Z","git_url":"git://github.com/zalando-incubator/kube-ingress-aws-controller.git","ssh_url":"git@github.com:zalando-incubator/kube-ingress-aws-controller.git","clone_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller.git","svn_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller","homepage":"","size":946,"stargazers_count":175,"watchers_count":175,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":37,"open_issues":16,"watchers":175,"default_branch":"master"}},"base":{"label":"zalando-incubator:master","ref":"master","sha":"8c482ef1910bea5f52dbf01f4ce6c753814afd98","user":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":75087504,"node_id":"MDEwOlJlcG9zaXRvcnk3NTA4NzUwNA==","name":"kube-ingress-aws-controller","full_name":"zalando-incubator/kube-ingress-aws-controller","owner":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller","description":"Configures AWS Load Balancers according to Kubernetes Ingress resources","fork":false,"url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller","forks_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/forks","keys_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/events","assignees_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/merges","archive_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/deployments","created_at":"2016-11-29T14:10:14Z","updated_at":"2018-07-25T21:40:31Z","pushed_at":"2018-07-26T16:47:26Z","git_url":"git://github.com/zalando-incubator/kube-ingress-aws-controller.git","ssh_url":"git@github.com:zalando-incubator/kube-ingress-aws-controller.git","clone_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller.git","svn_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller","homepage":"","size":946,"stargazers_count":175,"watchers_count":175,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":37,"open_issues":16,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/198"},"html":{"href":"https://github.com/zalando-incubator/kube-ingress-aws-controller/pull/198"},"issue":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/198"},"comments":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/statuses/9bcdd5ff7fe872ced61025fbf629fe90d761d524"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mikkeloscar","id":128566,"node_id":"MDQ6VXNlcjEyODU2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/128566?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkeloscar","html_url":"https://github.com/mikkeloscar","followers_url":"https://api.github.com/users/mikkeloscar/followers","following_url":"https://api.github.com/users/mikkeloscar/following{/other_user}","gists_url":"https://api.github.com/users/mikkeloscar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkeloscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkeloscar/subscriptions","organizations_url":"https://api.github.com/users/mikkeloscar/orgs","repos_url":"https://api.github.com/users/mikkeloscar/repos","events_url":"https://api.github.com/users/mikkeloscar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkeloscar/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":108,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"mikkeloscar"}}