{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/913","repository_url":"https://api.github.com/repos/tensorflow/tfjs-core","labels_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/913/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/913/comments","events_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/913/events","html_url":"https://github.com/tensorflow/tfjs-core/pull/913","id":310211558,"number":913,"title":"Adds tf.atan2","user":{"login":"jgartman","id":12043806,"avatar_url":"https://avatars2.githubusercontent.com/u/12043806?v=4","gravatar_id":"","url":"https://api.github.com/users/jgartman","html_url":"https://github.com/jgartman","followers_url":"https://api.github.com/users/jgartman/followers","following_url":"https://api.github.com/users/jgartman/following{/other_user}","gists_url":"https://api.github.com/users/jgartman/gists{/gist_id}","starred_url":"https://api.github.com/users/jgartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgartman/subscriptions","organizations_url":"https://api.github.com/users/jgartman/orgs","repos_url":"https://api.github.com/users/jgartman/repos","events_url":"https://api.github.com/users/jgartman/events{/privacy}","received_events_url":"https://api.github.com/users/jgartman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-31T04:29:05Z","updated_at":"2018-03-31T23:01:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tensorflow/tfjs-core/pulls/913","html_url":"https://github.com/tensorflow/tfjs-core/pull/913","diff_url":"https://github.com/tensorflow/tfjs-core/pull/913.diff","patch_url":"https://github.com/tensorflow/tfjs-core/pull/913.patch"},"body":"Adds `tf.atan2` to the API\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/tensorflow/tfjs-core/913)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/comments/377729482","html_url":"https://github.com/tensorflow/tfjs-core/pull/913#issuecomment-377729482","issue_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/913","id":377729482,"user":{"login":"nsthorat","id":1100749,"avatar_url":"https://avatars0.githubusercontent.com/u/1100749?v=4","gravatar_id":"","url":"https://api.github.com/users/nsthorat","html_url":"https://github.com/nsthorat","followers_url":"https://api.github.com/users/nsthorat/followers","following_url":"https://api.github.com/users/nsthorat/following{/other_user}","gists_url":"https://api.github.com/users/nsthorat/gists{/gist_id}","starred_url":"https://api.github.com/users/nsthorat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsthorat/subscriptions","organizations_url":"https://api.github.com/users/nsthorat/orgs","repos_url":"https://api.github.com/users/nsthorat/repos","events_url":"https://api.github.com/users/nsthorat/events{/privacy}","received_events_url":"https://api.github.com/users/nsthorat/received_events","type":"User","site_admin":false},"created_at":"2018-03-31T23:01:10Z","updated_at":"2018-03-31T23:01:10Z","author_association":"COLLABORATOR","body":"This is absolutely awesome. Thank you for paying attention to detail, writing high-coverage unit tests and writing the gradient.\n\nI have a few minor minor comments and then I will merge this!\n\n---\n\nReview status: 0 of 7 files reviewed at latest revision, all discussions resolved.\n\n---\n\n*[src/ops/binary_ops.ts, line 466 at r1](https://beta.reviewable.io/reviews/tensorflow/tfjs-core/913#-L8yG6m51QIuubC037mJ:-L8yG6m51QIuubC037mK:b-3n9dm8) ([raw file](https://github.com/tensorflow/tfjs-core/blob/2414777655ce63d36b501c9bfb2b3e788c5ee8a9/src/ops/binary_ops.ts#L466)):*\n> ```XML\n> \n>   /*\n>    * Computes arctangent of 'Tensor's a / b element-wise: `atan2(a, b)`.\n> ```\n\nCan you use backticks for Tensor\n\n---\n\n*[src/ops/binary_ops.ts, line 473 at r1](https://beta.reviewable.io/reviews/tensorflow/tfjs-core/913#-L8yGJK-Bc52OGqOlx7q:-L8yGJK-Bc52OGqOlx7r:buhjcbw) ([raw file](https://github.com/tensorflow/tfjs-core/blob/2414777655ce63d36b501c9bfb2b3e788c5ee8a9/src/ops/binary_ops.ts#L473)):*\n> ```XML\n>    * const b = tf.tensor1d([2.0, 13.0, 3.5, .21]);\n>    *\n>    * tf.atan2(x, y)\n> ```\n\ntf.atan2(x, y).print();\n\n---\n\n*[src/ops/binary_ops.ts, line 474 at r1](https://beta.reviewable.io/reviews/tensorflow/tfjs-core/913#-L8yGM66DkCnID0NtXi0:-L8yGM66DkCnID0NtXi1:b-foh3zi) ([raw file](https://github.com/tensorflow/tfjs-core/blob/2414777655ce63d36b501c9bfb2b3e788c5ee8a9/src/ops/binary_ops.ts#L474)):*\n> ```XML\n>    *\n>    * tf.atan2(x, y)\n>    *\n> ```\n\nMissing 3 backticks to end the js block\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/tensorflow/tfjs-core/913#-:-L8yHaZ69qMJV3oczLFh:b-iwx0i2)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"nsthorat"}}