{"action":"closed","number":185,"pull_request":{"url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/185","id":219649616,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NjQ5NjE2","html_url":"https://github.com/awslabs/keras-apache-mxnet/pull/185","diff_url":"https://github.com/awslabs/keras-apache-mxnet/pull/185.diff","patch_url":"https://github.com/awslabs/keras-apache-mxnet/pull/185.patch","issue_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/185","number":185,"state":"closed","locked":false,"title":"Fix save weight for fine tune","user":{"login":"roywei","id":8022184,"node_id":"MDQ6VXNlcjgwMjIxODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8022184?v=4","gravatar_id":"","url":"https://api.github.com/users/roywei","html_url":"https://github.com/roywei","followers_url":"https://api.github.com/users/roywei/followers","following_url":"https://api.github.com/users/roywei/following{/other_user}","gists_url":"https://api.github.com/users/roywei/gists{/gist_id}","starred_url":"https://api.github.com/users/roywei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roywei/subscriptions","organizations_url":"https://api.github.com/users/roywei/orgs","repos_url":"https://api.github.com/users/roywei/repos","events_url":"https://api.github.com/users/roywei/events{/privacy}","received_events_url":"https://api.github.com/users/roywei/received_events","type":"User","site_admin":false},"body":"### Summary\r\nfix https://github.com/awslabs/keras-apache-mxnet/issues/138\r\n\r\n- If we load pre-trained weight and do some training, after that, when saving weights will not save updated weights. It's because we didn't get the latest weights (_arg_params) in bucketing module. \r\n\r\n- fixed with new get_arg_param method when saving weights\r\n\r\n- added unit test for testing fine-tune use case.\r\n\r\n\r\n\r\n### Related Issues\r\nhttps://github.com/awslabs/keras-apache-mxnet/issues/138\r\n\r\n### PR Overview\r\n\r\n- [x] This PR requires new unit tests [y/n] (make sure tests are included)\r\n- [x] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)\r\n- [x] This PR is backwards compatible [y/n]\r\n- [x] This PR changes the current API [y/n]\r\n","created_at":"2018-10-02T10:05:22Z","updated_at":"2018-10-05T15:45:16Z","closed_at":"2018-10-05T15:45:16Z","merged_at":"2018-10-05T15:45:16Z","merge_commit_sha":"b717f806933d1fd394358bc4a57a32adc8de17b9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sandeep-krishnamurthy","id":3403674,"node_id":"MDQ6VXNlcjM0MDM2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3403674?v=4","gravatar_id":"","url":"https://api.github.com/users/sandeep-krishnamurthy","html_url":"https://github.com/sandeep-krishnamurthy","followers_url":"https://api.github.com/users/sandeep-krishnamurthy/followers","following_url":"https://api.github.com/users/sandeep-krishnamurthy/following{/other_user}","gists_url":"https://api.github.com/users/sandeep-krishnamurthy/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeep-krishnamurthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeep-krishnamurthy/subscriptions","organizations_url":"https://api.github.com/users/sandeep-krishnamurthy/orgs","repos_url":"https://api.github.com/users/sandeep-krishnamurthy/repos","events_url":"https://api.github.com/users/sandeep-krishnamurthy/events{/privacy}","received_events_url":"https://api.github.com/users/sandeep-krishnamurthy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/185/commits","review_comments_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/185/comments","review_comment_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/185/comments","statuses_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/statuses/be9618cd242ad7eda451888f945a7acbb0e17fe5","head":{"label":"roywei:fix_save_weight","ref":"fix_save_weight","sha":"be9618cd242ad7eda451888f945a7acbb0e17fe5","user":{"login":"roywei","id":8022184,"node_id":"MDQ6VXNlcjgwMjIxODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8022184?v=4","gravatar_id":"","url":"https://api.github.com/users/roywei","html_url":"https://github.com/roywei","followers_url":"https://api.github.com/users/roywei/followers","following_url":"https://api.github.com/users/roywei/following{/other_user}","gists_url":"https://api.github.com/users/roywei/gists{/gist_id}","starred_url":"https://api.github.com/users/roywei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roywei/subscriptions","organizations_url":"https://api.github.com/users/roywei/orgs","repos_url":"https://api.github.com/users/roywei/repos","events_url":"https://api.github.com/users/roywei/events{/privacy}","received_events_url":"https://api.github.com/users/roywei/received_events","type":"User","site_admin":false},"repo":{"id":146657843,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2NTc4NDM=","name":"keras-apache-mxnet","full_name":"roywei/keras-apache-mxnet","private":false,"owner":{"login":"roywei","id":8022184,"node_id":"MDQ6VXNlcjgwMjIxODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8022184?v=4","gravatar_id":"","url":"https://api.github.com/users/roywei","html_url":"https://github.com/roywei","followers_url":"https://api.github.com/users/roywei/followers","following_url":"https://api.github.com/users/roywei/following{/other_user}","gists_url":"https://api.github.com/users/roywei/gists{/gist_id}","starred_url":"https://api.github.com/users/roywei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roywei/subscriptions","organizations_url":"https://api.github.com/users/roywei/orgs","repos_url":"https://api.github.com/users/roywei/repos","events_url":"https://api.github.com/users/roywei/events{/privacy}","received_events_url":"https://api.github.com/users/roywei/received_events","type":"User","site_admin":false},"html_url":"https://github.com/roywei/keras-apache-mxnet","description":"Amazon Deep Learning's Keras with Apache MXNet support","fork":true,"url":"https://api.github.com/repos/roywei/keras-apache-mxnet","forks_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/forks","keys_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/teams","hooks_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/hooks","issue_events_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/events","assignees_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/tags","blobs_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/languages","stargazers_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/stargazers","contributors_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/contributors","subscribers_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/subscribers","subscription_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/subscription","commits_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/merges","archive_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/downloads","issues_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/roywei/keras-apache-mxnet/deployments","created_at":"2018-08-29T20:58:49Z","updated_at":"2018-08-29T20:58:52Z","pushed_at":"2018-10-05T15:18:57Z","git_url":"git://github.com/roywei/keras-apache-mxnet.git","ssh_url":"git@github.com:roywei/keras-apache-mxnet.git","clone_url":"https://github.com/roywei/keras-apache-mxnet.git","svn_url":"https://github.com/roywei/keras-apache-mxnet","homepage":"https://github.com/awslabs/keras-apache-mxnet/wiki","size":12678,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:dev","ref":"dev","sha":"33a2143b1942563ed2b64a8b7bf39af293fc2f6b","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":109059493,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkwNTk0OTM=","name":"keras-apache-mxnet","full_name":"awslabs/keras-apache-mxnet","private":false,"owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awslabs/keras-apache-mxnet","description":"Amazon Deep Learning's Keras with Apache MXNet support","fork":true,"url":"https://api.github.com/repos/awslabs/keras-apache-mxnet","forks_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/forks","keys_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/teams","hooks_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/hooks","issue_events_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/events","assignees_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/tags","blobs_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/languages","stargazers_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/stargazers","contributors_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/contributors","subscribers_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/subscribers","subscription_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/subscription","commits_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/merges","archive_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/downloads","issues_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/deployments","created_at":"2017-10-31T22:36:43Z","updated_at":"2018-10-02T12:16:07Z","pushed_at":"2018-10-05T15:45:16Z","git_url":"git://github.com/awslabs/keras-apache-mxnet.git","ssh_url":"git@github.com:awslabs/keras-apache-mxnet.git","clone_url":"https://github.com/awslabs/keras-apache-mxnet.git","svn_url":"https://github.com/awslabs/keras-apache-mxnet","homepage":"https://github.com/awslabs/keras-apache-mxnet/wiki","size":12439,"stargazers_count":167,"watchers_count":167,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":30,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/185"},"html":{"href":"https://github.com/awslabs/keras-apache-mxnet/pull/185"},"issue":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/185"},"comments":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/statuses/be9618cd242ad7eda451888f945a7acbb0e17fe5"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"roywei","id":8022184,"node_id":"MDQ6VXNlcjgwMjIxODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8022184?v=4","gravatar_id":"","url":"https://api.github.com/users/roywei","html_url":"https://github.com/roywei","followers_url":"https://api.github.com/users/roywei/followers","following_url":"https://api.github.com/users/roywei/following{/other_user}","gists_url":"https://api.github.com/users/roywei/gists{/gist_id}","starred_url":"https://api.github.com/users/roywei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roywei/subscriptions","organizations_url":"https://api.github.com/users/roywei/orgs","repos_url":"https://api.github.com/users/roywei/repos","events_url":"https://api.github.com/users/roywei/events{/privacy}","received_events_url":"https://api.github.com/users/roywei/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":6,"additions":83,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"roywei"}}