{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/18773","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/18773/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/18773/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/18773/events","html_url":"https://github.com/nodejs/node/pull/18773","id":296960686,"number":18773,"title":"lib: refactor prototype and Function.call.bind usage","user":{"login":"devsnek","id":5952481,"avatar_url":"https://avatars3.githubusercontent.com/u/5952481?v=4","gravatar_id":"","url":"https://api.github.com/users/devsnek","html_url":"https://github.com/devsnek","followers_url":"https://api.github.com/users/devsnek/followers","following_url":"https://api.github.com/users/devsnek/following{/other_user}","gists_url":"https://api.github.com/users/devsnek/gists{/gist_id}","starred_url":"https://api.github.com/users/devsnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devsnek/subscriptions","organizations_url":"https://api.github.com/users/devsnek/orgs","repos_url":"https://api.github.com/users/devsnek/repos","events_url":"https://api.github.com/users/devsnek/events{/privacy}","received_events_url":"https://api.github.com/users/devsnek/received_events","type":"User","site_admin":false},"labels":[{"id":281232761,"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false},{"id":169485514,"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-14T03:02:20Z","updated_at":"2018-02-14T17:15:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/18773","html_url":"https://github.com/nodejs/node/pull/18773","diff_url":"https://github.com/nodejs/node/pull/18773.diff","patch_url":"https://github.com/nodejs/node/pull/18773.patch"},"body":"Moves usage of Object.prototype.* and methods saved with Function.call.bind to a single \"primordials\"  \"meta module\" which ensures the safety of the method, cleans up the lib a bit, and i think also plays nicely with when we start doing snapshots in the future if @hashseed can speak to that.\r\n\r\nThis is intended to sit on or maybe replace #18750 \r\n\r\nFixes: https://github.com/nodejs/node/issues/17434\r\n\r\ncc @apapirovski @hashseed @BridgeAR \r\n\r\n##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\ncrypto, assert, async_hooks, lib, bootstrap\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/365678789","html_url":"https://github.com/nodejs/node/pull/18773#issuecomment-365678789","issue_url":"https://api.github.com/repos/nodejs/node/issues/18773","id":365678789,"user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T17:15:45Z","updated_at":"2018-02-14T17:15:45Z","author_association":"MEMBER","body":"I still have to think about this. If we add it, I would like to expose it as a module though. The reason is that users could use those as well, so it would actually have a benefit."}}
{"actor":{"display_login":"BridgeAR"}}