{"action":"closed","number":1993,"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1993","id":225247030,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjQ3MDMw","html_url":"https://github.com/firebase/firebase-ios-sdk/pull/1993","diff_url":"https://github.com/firebase/firebase-ios-sdk/pull/1993.diff","patch_url":"https://github.com/firebase/firebase-ios-sdk/pull/1993.patch","issue_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1993","number":1993,"state":"closed","locked":false,"title":" Remove unnecessary notification flag","user":{"login":"ryanwilson","id":1097316,"node_id":"MDQ6VXNlcjEwOTczMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1097316?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanwilson","html_url":"https://github.com/ryanwilson","followers_url":"https://api.github.com/users/ryanwilson/followers","following_url":"https://api.github.com/users/ryanwilson/following{/other_user}","gists_url":"https://api.github.com/users/ryanwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanwilson/subscriptions","organizations_url":"https://api.github.com/users/ryanwilson/orgs","repos_url":"https://api.github.com/users/ryanwilson/repos","events_url":"https://api.github.com/users/ryanwilson/events{/privacy}","received_events_url":"https://api.github.com/users/ryanwilson/received_events","type":"User","site_admin":false},"body":"This was added when the Google pod could configure Firebase but the\r\nGoogle pod is deprecated and can only work with Firebase 3.X. These\r\nflags and conditional checks can be safely removed.","created_at":"2018-10-24T02:42:45Z","updated_at":"2018-10-24T11:17:13Z","closed_at":"2018-10-24T11:17:12Z","merged_at":"2018-10-24T11:17:12Z","merge_commit_sha":"ef5949d6a87ee49f0cf2f7c964f39412c598db70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":607586731,"node_id":"MDU6TGFiZWw2MDc1ODY3MzE=","url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels/Core","name":"Core","color":"bfd4f2","default":false},{"id":658858759,"node_id":"MDU6TGFiZWw2NTg4NTg3NTk=","url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones/19","html_url":"https://github.com/firebase/firebase-ios-sdk/milestone/19","labels_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones/19/labels","id":3750482,"node_id":"MDk6TWlsZXN0b25lMzc1MDQ4Mg==","number":19,"title":"M37","description":"","creator":{"login":"paulb777","id":73870,"node_id":"MDQ6VXNlcjczODcw","avatar_url":"https://avatars3.githubusercontent.com/u/73870?v=4","gravatar_id":"","url":"https://api.github.com/users/paulb777","html_url":"https://github.com/paulb777","followers_url":"https://api.github.com/users/paulb777/followers","following_url":"https://api.github.com/users/paulb777/following{/other_user}","gists_url":"https://api.github.com/users/paulb777/gists{/gist_id}","starred_url":"https://api.github.com/users/paulb777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulb777/subscriptions","organizations_url":"https://api.github.com/users/paulb777/orgs","repos_url":"https://api.github.com/users/paulb777/repos","events_url":"https://api.github.com/users/paulb777/events{/privacy}","received_events_url":"https://api.github.com/users/paulb777/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":5,"state":"open","created_at":"2018-10-18T21:04:50Z","updated_at":"2018-10-24T11:17:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1993/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1993/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1993/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/f2581e5f49bf6969ceeadfddd68f97cc7d9631e4","head":{"label":"firebase:rw-remove-old-core-flag","ref":"rw-remove-old-core-flag","sha":"f2581e5f49bf6969ceeadfddd68f97cc7d9631e4","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89033556,"node_id":"MDEwOlJlcG9zaXRvcnk4OTAzMzU1Ng==","name":"firebase-ios-sdk","full_name":"firebase/firebase-ios-sdk","private":false,"owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firebase/firebase-ios-sdk","description":"Firebase iOS SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/deployments","created_at":"2017-04-22T00:26:50Z","updated_at":"2018-10-23T23:53:19Z","pushed_at":"2018-10-24T11:17:12Z","git_url":"git://github.com/firebase/firebase-ios-sdk.git","ssh_url":"git@github.com:firebase/firebase-ios-sdk.git","clone_url":"https://github.com/firebase/firebase-ios-sdk.git","svn_url":"https://github.com/firebase/firebase-ios-sdk","homepage":"https://firebase.google.com","size":13963,"stargazers_count":908,"watchers_count":908,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":191,"open_issues":108,"watchers":908,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"69b17eb4f52b1a4a0e91cd725c9394db6e16f1e1","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89033556,"node_id":"MDEwOlJlcG9zaXRvcnk4OTAzMzU1Ng==","name":"firebase-ios-sdk","full_name":"firebase/firebase-ios-sdk","private":false,"owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firebase/firebase-ios-sdk","description":"Firebase iOS SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/deployments","created_at":"2017-04-22T00:26:50Z","updated_at":"2018-10-23T23:53:19Z","pushed_at":"2018-10-24T11:17:12Z","git_url":"git://github.com/firebase/firebase-ios-sdk.git","ssh_url":"git@github.com:firebase/firebase-ios-sdk.git","clone_url":"https://github.com/firebase/firebase-ios-sdk.git","svn_url":"https://github.com/firebase/firebase-ios-sdk","homepage":"https://firebase.google.com","size":13963,"stargazers_count":908,"watchers_count":908,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":191,"open_issues":108,"watchers":908,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1993"},"html":{"href":"https://github.com/firebase/firebase-ios-sdk/pull/1993"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1993"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/1993/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1993/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/1993/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/f2581e5f49bf6969ceeadfddd68f97cc7d9631e4"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ryanwilson","id":1097316,"node_id":"MDQ6VXNlcjEwOTczMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1097316?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanwilson","html_url":"https://github.com/ryanwilson","followers_url":"https://api.github.com/users/ryanwilson/followers","following_url":"https://api.github.com/users/ryanwilson/following{/other_user}","gists_url":"https://api.github.com/users/ryanwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanwilson/subscriptions","organizations_url":"https://api.github.com/users/ryanwilson/orgs","repos_url":"https://api.github.com/users/ryanwilson/repos","events_url":"https://api.github.com/users/ryanwilson/events{/privacy}","received_events_url":"https://api.github.com/users/ryanwilson/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":7,"deletions":35,"changed_files":2}}
{"actor":{"display_login":"ryanwilson"}}