{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/KWARC/rust-libxml/pulls/39","id":203063371,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDYzMzcx","html_url":"https://github.com/KWARC/rust-libxml/pull/39","diff_url":"https://github.com/KWARC/rust-libxml/pull/39.diff","patch_url":"https://github.com/KWARC/rust-libxml/pull/39.patch","issue_url":"https://api.github.com/repos/KWARC/rust-libxml/issues/39","number":39,"state":"closed","locked":false,"title":"Full libxml2 coverage via bindgen","user":{"login":"dginev","id":348975,"node_id":"MDQ6VXNlcjM0ODk3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/348975?v=4","gravatar_id":"","url":"https://api.github.com/users/dginev","html_url":"https://github.com/dginev","followers_url":"https://api.github.com/users/dginev/followers","following_url":"https://api.github.com/users/dginev/following{/other_user}","gists_url":"https://api.github.com/users/dginev/gists{/gist_id}","starred_url":"https://api.github.com/users/dginev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dginev/subscriptions","organizations_url":"https://api.github.com/users/dginev/orgs","repos_url":"https://api.github.com/users/dginev/repos","events_url":"https://api.github.com/users/dginev/events{/privacy}","received_events_url":"https://api.github.com/users/dginev/received_events","type":"User","site_admin":false},"body":"Fixes #19 \r\n\r\nInterestingly, the swap was only slightly painful. Bindgen seems to have 3 obvious positives as an approach for us:\r\n * full coverage for free, without us having to maintain the `c_signatures` file.\r\n * transparent view into the C data structures, which gives us more power in the internal wrapper methods. This also means the low-level helper C methods we had can be redone in Rust.\r\n * the full type alias system of libxml2 is now available, which is a lot more readable (and sane) than casting to `c_void` pointers everywhere\r\n\r\nThere is more polish to be done here before the PR is merged, but it is already good for an early review and feedback","created_at":"2018-07-22T15:49:31Z","updated_at":"2018-07-23T17:33:52Z","closed_at":"2018-07-23T17:33:52Z","merged_at":"2018-07-23T17:33:52Z","merge_commit_sha":"348c2e10531671c454e1ea0fb61b2892748ab3eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KWARC/rust-libxml/pulls/39/commits","review_comments_url":"https://api.github.com/repos/KWARC/rust-libxml/pulls/39/comments","review_comment_url":"https://api.github.com/repos/KWARC/rust-libxml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KWARC/rust-libxml/issues/39/comments","statuses_url":"https://api.github.com/repos/KWARC/rust-libxml/statuses/65d7f5f22cae0c337ac452a179a2518553593361","head":{"label":"KWARC:bindgen","ref":"bindgen","sha":"65d7f5f22cae0c337ac452a179a2518553593361","user":{"login":"KWARC","id":3624298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQyOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3624298?v=4","gravatar_id":"","url":"https://api.github.com/users/KWARC","html_url":"https://github.com/KWARC","followers_url":"https://api.github.com/users/KWARC/followers","following_url":"https://api.github.com/users/KWARC/following{/other_user}","gists_url":"https://api.github.com/users/KWARC/gists{/gist_id}","starred_url":"https://api.github.com/users/KWARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KWARC/subscriptions","organizations_url":"https://api.github.com/users/KWARC/orgs","repos_url":"https://api.github.com/users/KWARC/repos","events_url":"https://api.github.com/users/KWARC/events{/privacy}","received_events_url":"https://api.github.com/users/KWARC/received_events","type":"Organization","site_admin":false},"repo":{"id":36693740,"node_id":"MDEwOlJlcG9zaXRvcnkzNjY5Mzc0MA==","name":"rust-libxml","full_name":"KWARC/rust-libxml","owner":{"login":"KWARC","id":3624298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQyOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3624298?v=4","gravatar_id":"","url":"https://api.github.com/users/KWARC","html_url":"https://github.com/KWARC","followers_url":"https://api.github.com/users/KWARC/followers","following_url":"https://api.github.com/users/KWARC/following{/other_user}","gists_url":"https://api.github.com/users/KWARC/gists{/gist_id}","starred_url":"https://api.github.com/users/KWARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KWARC/subscriptions","organizations_url":"https://api.github.com/users/KWARC/orgs","repos_url":"https://api.github.com/users/KWARC/repos","events_url":"https://api.github.com/users/KWARC/events{/privacy}","received_events_url":"https://api.github.com/users/KWARC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KWARC/rust-libxml","description":"Rust wrapper for libxml2","fork":false,"url":"https://api.github.com/repos/KWARC/rust-libxml","forks_url":"https://api.github.com/repos/KWARC/rust-libxml/forks","keys_url":"https://api.github.com/repos/KWARC/rust-libxml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KWARC/rust-libxml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KWARC/rust-libxml/teams","hooks_url":"https://api.github.com/repos/KWARC/rust-libxml/hooks","issue_events_url":"https://api.github.com/repos/KWARC/rust-libxml/issues/events{/number}","events_url":"https://api.github.com/repos/KWARC/rust-libxml/events","assignees_url":"https://api.github.com/repos/KWARC/rust-libxml/assignees{/user}","branches_url":"https://api.github.com/repos/KWARC/rust-libxml/branches{/branch}","tags_url":"https://api.github.com/repos/KWARC/rust-libxml/tags","blobs_url":"https://api.github.com/repos/KWARC/rust-libxml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KWARC/rust-libxml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KWARC/rust-libxml/git/refs{/sha}","trees_url":"https://api.github.com/repos/KWARC/rust-libxml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KWARC/rust-libxml/statuses/{sha}","languages_url":"https://api.github.com/repos/KWARC/rust-libxml/languages","stargazers_url":"https://api.github.com/repos/KWARC/rust-libxml/stargazers","contributors_url":"https://api.github.com/repos/KWARC/rust-libxml/contributors","subscribers_url":"https://api.github.com/repos/KWARC/rust-libxml/subscribers","subscription_url":"https://api.github.com/repos/KWARC/rust-libxml/subscription","commits_url":"https://api.github.com/repos/KWARC/rust-libxml/commits{/sha}","git_commits_url":"https://api.github.com/repos/KWARC/rust-libxml/git/commits{/sha}","comments_url":"https://api.github.com/repos/KWARC/rust-libxml/comments{/number}","issue_comment_url":"https://api.github.com/repos/KWARC/rust-libxml/issues/comments{/number}","contents_url":"https://api.github.com/repos/KWARC/rust-libxml/contents/{+path}","compare_url":"https://api.github.com/repos/KWARC/rust-libxml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KWARC/rust-libxml/merges","archive_url":"https://api.github.com/repos/KWARC/rust-libxml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KWARC/rust-libxml/downloads","issues_url":"https://api.github.com/repos/KWARC/rust-libxml/issues{/number}","pulls_url":"https://api.github.com/repos/KWARC/rust-libxml/pulls{/number}","milestones_url":"https://api.github.com/repos/KWARC/rust-libxml/milestones{/number}","notifications_url":"https://api.github.com/repos/KWARC/rust-libxml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KWARC/rust-libxml/labels{/name}","releases_url":"https://api.github.com/repos/KWARC/rust-libxml/releases{/id}","deployments_url":"https://api.github.com/repos/KWARC/rust-libxml/deployments","created_at":"2015-06-01T22:53:44Z","updated_at":"2018-07-23T02:02:15Z","pushed_at":"2018-07-23T17:33:52Z","git_url":"git://github.com/KWARC/rust-libxml.git","ssh_url":"git@github.com:KWARC/rust-libxml.git","clone_url":"https://github.com/KWARC/rust-libxml.git","svn_url":"https://github.com/KWARC/rust-libxml","homepage":"https://crates.io/crates/libxml","size":5282,"stargazers_count":7,"watchers_count":7,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":3,"watchers":7,"default_branch":"master"}},"base":{"label":"KWARC:master","ref":"master","sha":"42feaea3320c08595a30546ed395a792dcc76766","user":{"login":"KWARC","id":3624298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQyOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3624298?v=4","gravatar_id":"","url":"https://api.github.com/users/KWARC","html_url":"https://github.com/KWARC","followers_url":"https://api.github.com/users/KWARC/followers","following_url":"https://api.github.com/users/KWARC/following{/other_user}","gists_url":"https://api.github.com/users/KWARC/gists{/gist_id}","starred_url":"https://api.github.com/users/KWARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KWARC/subscriptions","organizations_url":"https://api.github.com/users/KWARC/orgs","repos_url":"https://api.github.com/users/KWARC/repos","events_url":"https://api.github.com/users/KWARC/events{/privacy}","received_events_url":"https://api.github.com/users/KWARC/received_events","type":"Organization","site_admin":false},"repo":{"id":36693740,"node_id":"MDEwOlJlcG9zaXRvcnkzNjY5Mzc0MA==","name":"rust-libxml","full_name":"KWARC/rust-libxml","owner":{"login":"KWARC","id":3624298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQyOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3624298?v=4","gravatar_id":"","url":"https://api.github.com/users/KWARC","html_url":"https://github.com/KWARC","followers_url":"https://api.github.com/users/KWARC/followers","following_url":"https://api.github.com/users/KWARC/following{/other_user}","gists_url":"https://api.github.com/users/KWARC/gists{/gist_id}","starred_url":"https://api.github.com/users/KWARC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KWARC/subscriptions","organizations_url":"https://api.github.com/users/KWARC/orgs","repos_url":"https://api.github.com/users/KWARC/repos","events_url":"https://api.github.com/users/KWARC/events{/privacy}","received_events_url":"https://api.github.com/users/KWARC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KWARC/rust-libxml","description":"Rust wrapper for libxml2","fork":false,"url":"https://api.github.com/repos/KWARC/rust-libxml","forks_url":"https://api.github.com/repos/KWARC/rust-libxml/forks","keys_url":"https://api.github.com/repos/KWARC/rust-libxml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KWARC/rust-libxml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KWARC/rust-libxml/teams","hooks_url":"https://api.github.com/repos/KWARC/rust-libxml/hooks","issue_events_url":"https://api.github.com/repos/KWARC/rust-libxml/issues/events{/number}","events_url":"https://api.github.com/repos/KWARC/rust-libxml/events","assignees_url":"https://api.github.com/repos/KWARC/rust-libxml/assignees{/user}","branches_url":"https://api.github.com/repos/KWARC/rust-libxml/branches{/branch}","tags_url":"https://api.github.com/repos/KWARC/rust-libxml/tags","blobs_url":"https://api.github.com/repos/KWARC/rust-libxml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KWARC/rust-libxml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KWARC/rust-libxml/git/refs{/sha}","trees_url":"https://api.github.com/repos/KWARC/rust-libxml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KWARC/rust-libxml/statuses/{sha}","languages_url":"https://api.github.com/repos/KWARC/rust-libxml/languages","stargazers_url":"https://api.github.com/repos/KWARC/rust-libxml/stargazers","contributors_url":"https://api.github.com/repos/KWARC/rust-libxml/contributors","subscribers_url":"https://api.github.com/repos/KWARC/rust-libxml/subscribers","subscription_url":"https://api.github.com/repos/KWARC/rust-libxml/subscription","commits_url":"https://api.github.com/repos/KWARC/rust-libxml/commits{/sha}","git_commits_url":"https://api.github.com/repos/KWARC/rust-libxml/git/commits{/sha}","comments_url":"https://api.github.com/repos/KWARC/rust-libxml/comments{/number}","issue_comment_url":"https://api.github.com/repos/KWARC/rust-libxml/issues/comments{/number}","contents_url":"https://api.github.com/repos/KWARC/rust-libxml/contents/{+path}","compare_url":"https://api.github.com/repos/KWARC/rust-libxml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KWARC/rust-libxml/merges","archive_url":"https://api.github.com/repos/KWARC/rust-libxml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KWARC/rust-libxml/downloads","issues_url":"https://api.github.com/repos/KWARC/rust-libxml/issues{/number}","pulls_url":"https://api.github.com/repos/KWARC/rust-libxml/pulls{/number}","milestones_url":"https://api.github.com/repos/KWARC/rust-libxml/milestones{/number}","notifications_url":"https://api.github.com/repos/KWARC/rust-libxml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KWARC/rust-libxml/labels{/name}","releases_url":"https://api.github.com/repos/KWARC/rust-libxml/releases{/id}","deployments_url":"https://api.github.com/repos/KWARC/rust-libxml/deployments","created_at":"2015-06-01T22:53:44Z","updated_at":"2018-07-23T02:02:15Z","pushed_at":"2018-07-23T17:33:52Z","git_url":"git://github.com/KWARC/rust-libxml.git","ssh_url":"git@github.com:KWARC/rust-libxml.git","clone_url":"https://github.com/KWARC/rust-libxml.git","svn_url":"https://github.com/KWARC/rust-libxml","homepage":"https://crates.io/crates/libxml","size":5282,"stargazers_count":7,"watchers_count":7,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KWARC/rust-libxml/pulls/39"},"html":{"href":"https://github.com/KWARC/rust-libxml/pull/39"},"issue":{"href":"https://api.github.com/repos/KWARC/rust-libxml/issues/39"},"comments":{"href":"https://api.github.com/repos/KWARC/rust-libxml/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/KWARC/rust-libxml/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/KWARC/rust-libxml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KWARC/rust-libxml/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/KWARC/rust-libxml/statuses/65d7f5f22cae0c337ac452a179a2518553593361"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dginev","id":348975,"node_id":"MDQ6VXNlcjM0ODk3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/348975?v=4","gravatar_id":"","url":"https://api.github.com/users/dginev","html_url":"https://github.com/dginev","followers_url":"https://api.github.com/users/dginev/followers","following_url":"https://api.github.com/users/dginev/following{/other_user}","gists_url":"https://api.github.com/users/dginev/gists{/gist_id}","starred_url":"https://api.github.com/users/dginev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dginev/subscriptions","organizations_url":"https://api.github.com/users/dginev/orgs","repos_url":"https://api.github.com/users/dginev/repos","events_url":"https://api.github.com/users/dginev/events{/privacy}","received_events_url":"https://api.github.com/users/dginev/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":11,"additions":24894,"deletions":561,"changed_files":17}}
{"actor":{"display_login":"dginev"}}