{"action":"closed","number":44585,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44585","id":206552017,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTUyMDE3","html_url":"https://github.com/NixOS/nixpkgs/pull/44585","diff_url":"https://github.com/NixOS/nixpkgs/pull/44585.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44585.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44585","number":44585,"state":"closed","locked":false,"title":"osquery: do not rebuild at each nixpkgs commit","user":{"login":"symphorien","id":12595971,"node_id":"MDQ6VXNlcjEyNTk1OTcx","avatar_url":"https://avatars2.githubusercontent.com/u/12595971?v=4","gravatar_id":"","url":"https://api.github.com/users/symphorien","html_url":"https://github.com/symphorien","followers_url":"https://api.github.com/users/symphorien/followers","following_url":"https://api.github.com/users/symphorien/following{/other_user}","gists_url":"https://api.github.com/users/symphorien/gists{/gist_id}","starred_url":"https://api.github.com/users/symphorien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symphorien/subscriptions","organizations_url":"https://api.github.com/users/symphorien/orgs","repos_url":"https://api.github.com/users/symphorien/repos","events_url":"https://api.github.com/users/symphorien/events{/privacy}","received_events_url":"https://api.github.com/users/symphorien/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nIncludging `stdenv.lib.version` triggers a rebuild at each nixpkgs commit. It also makes osquery a permanent false positive in nox-review.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-08-07T00:47:11Z","updated_at":"2018-08-07T03:52:35Z","closed_at":"2018-08-07T03:52:35Z","merged_at":"2018-08-07T03:52:35Z","merge_commit_sha":"593fdd6933aa1e693804e411ed388fbe8fbcd52b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44585/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44585/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44585/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a85fedab2ea2303cb34c7c44823c53523f508130","head":{"label":"symphorien:osquery-platform","ref":"osquery-platform","sha":"a85fedab2ea2303cb34c7c44823c53523f508130","user":{"login":"symphorien","id":12595971,"node_id":"MDQ6VXNlcjEyNTk1OTcx","avatar_url":"https://avatars2.githubusercontent.com/u/12595971?v=4","gravatar_id":"","url":"https://api.github.com/users/symphorien","html_url":"https://github.com/symphorien","followers_url":"https://api.github.com/users/symphorien/followers","following_url":"https://api.github.com/users/symphorien/following{/other_user}","gists_url":"https://api.github.com/users/symphorien/gists{/gist_id}","starred_url":"https://api.github.com/users/symphorien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symphorien/subscriptions","organizations_url":"https://api.github.com/users/symphorien/orgs","repos_url":"https://api.github.com/users/symphorien/repos","events_url":"https://api.github.com/users/symphorien/events{/privacy}","received_events_url":"https://api.github.com/users/symphorien/received_events","type":"User","site_admin":false},"repo":{"id":77236175,"node_id":"MDEwOlJlcG9zaXRvcnk3NzIzNjE3NQ==","name":"nixpkgs","full_name":"symphorien/nixpkgs","owner":{"login":"symphorien","id":12595971,"node_id":"MDQ6VXNlcjEyNTk1OTcx","avatar_url":"https://avatars2.githubusercontent.com/u/12595971?v=4","gravatar_id":"","url":"https://api.github.com/users/symphorien","html_url":"https://github.com/symphorien","followers_url":"https://api.github.com/users/symphorien/followers","following_url":"https://api.github.com/users/symphorien/following{/other_user}","gists_url":"https://api.github.com/users/symphorien/gists{/gist_id}","starred_url":"https://api.github.com/users/symphorien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symphorien/subscriptions","organizations_url":"https://api.github.com/users/symphorien/orgs","repos_url":"https://api.github.com/users/symphorien/repos","events_url":"https://api.github.com/users/symphorien/events{/privacy}","received_events_url":"https://api.github.com/users/symphorien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/symphorien/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/symphorien/nixpkgs","forks_url":"https://api.github.com/repos/symphorien/nixpkgs/forks","keys_url":"https://api.github.com/repos/symphorien/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symphorien/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symphorien/nixpkgs/teams","hooks_url":"https://api.github.com/repos/symphorien/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/symphorien/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/symphorien/nixpkgs/events","assignees_url":"https://api.github.com/repos/symphorien/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/symphorien/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/symphorien/nixpkgs/tags","blobs_url":"https://api.github.com/repos/symphorien/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symphorien/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symphorien/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symphorien/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symphorien/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/symphorien/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/symphorien/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/symphorien/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/symphorien/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/symphorien/nixpkgs/subscription","commits_url":"https://api.github.com/repos/symphorien/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symphorien/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symphorien/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symphorien/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/symphorien/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/symphorien/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symphorien/nixpkgs/merges","archive_url":"https://api.github.com/repos/symphorien/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symphorien/nixpkgs/downloads","issues_url":"https://api.github.com/repos/symphorien/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/symphorien/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/symphorien/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/symphorien/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symphorien/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/symphorien/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/symphorien/nixpkgs/deployments","created_at":"2016-12-23T16:05:01Z","updated_at":"2016-12-23T16:05:27Z","pushed_at":"2018-08-07T00:44:39Z","git_url":"git://github.com/symphorien/nixpkgs.git","ssh_url":"git@github.com:symphorien/nixpkgs.git","clone_url":"https://github.com/symphorien/nixpkgs.git","svn_url":"https://github.com/symphorien/nixpkgs","homepage":null,"size":745496,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"893b080e5628af07199b2510ead18c0cf17cbb5a","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-08-07T01:26:19Z","pushed_at":"2018-08-07T03:52:35Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":833173,"stargazers_count":2620,"watchers_count":2620,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2929,"mirror_url":null,"archived":false,"open_issues_count":3057,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2929,"open_issues":3057,"watchers":2620,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44585"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44585"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44585"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44585/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44585/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44585/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a85fedab2ea2303cb34c7c44823c53523f508130"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Infinisil","id":20525370,"node_id":"MDQ6VXNlcjIwNTI1Mzcw","avatar_url":"https://avatars0.githubusercontent.com/u/20525370?v=4","gravatar_id":"","url":"https://api.github.com/users/Infinisil","html_url":"https://github.com/Infinisil","followers_url":"https://api.github.com/users/Infinisil/followers","following_url":"https://api.github.com/users/Infinisil/following{/other_user}","gists_url":"https://api.github.com/users/Infinisil/gists{/gist_id}","starred_url":"https://api.github.com/users/Infinisil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Infinisil/subscriptions","organizations_url":"https://api.github.com/users/Infinisil/orgs","repos_url":"https://api.github.com/users/Infinisil/repos","events_url":"https://api.github.com/users/Infinisil/events{/privacy}","received_events_url":"https://api.github.com/users/Infinisil/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"Infinisil"}}