{"action":"created","comment":{"url":"https://api.github.com/repos/python-cmd2/cmd2/pulls/comments/190468137","pull_request_review_id":122846849,"id":190468137,"diff_hunk":"@@ -3185,232 +3125,7 @@ def restore(self):\n                 setattr(self.obj, attrib, getattr(self, attrib))\n \n \n-class OutputTrap(object):","path":"cmd2/cmd2.py","position":335,"original_position":335,"commit_id":"db881e13796abdaabe6cb7d4121389c36e9aa407","original_commit_id":"db881e13796abdaabe6cb7d4121389c36e9aa407","user":{"login":"tleonhardt","id":2812720,"avatar_url":"https://avatars1.githubusercontent.com/u/2812720?v=4","gravatar_id":"","url":"https://api.github.com/users/tleonhardt","html_url":"https://github.com/tleonhardt","followers_url":"https://api.github.com/users/tleonhardt/followers","following_url":"https://api.github.com/users/tleonhardt/following{/other_user}","gists_url":"https://api.github.com/users/tleonhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/tleonhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tleonhardt/subscriptions","organizations_url":"https://api.github.com/users/tleonhardt/orgs","repos_url":"https://api.github.com/users/tleonhardt/repos","events_url":"https://api.github.com/users/tleonhardt/events{/privacy}","received_events_url":"https://api.github.com/users/tleonhardt/received_events","type":"User","site_admin":false},"body":"Thanks for moving all of the transcript testing stuff to its own file.  **cmd2.py** is now feeling a little more focused","created_at":"2018-05-24T05:17:33Z","updated_at":"2018-05-24T05:26:34Z","html_url":"https://github.com/python-cmd2/cmd2/pull/413#discussion_r190468137","pull_request_url":"https://api.github.com/repos/python-cmd2/cmd2/pulls/413","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/python-cmd2/cmd2/pulls/comments/190468137"},"html":{"href":"https://github.com/python-cmd2/cmd2/pull/413#discussion_r190468137"},"pull_request":{"href":"https://api.github.com/repos/python-cmd2/cmd2/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/python-cmd2/cmd2/pulls/413","id":190167916,"html_url":"https://github.com/python-cmd2/cmd2/pull/413","diff_url":"https://github.com/python-cmd2/cmd2/pull/413.diff","patch_url":"https://github.com/python-cmd2/cmd2/pull/413.patch","issue_url":"https://api.github.com/repos/python-cmd2/cmd2/issues/413","number":413,"state":"open","locked":false,"title":"Defer certain imports","user":{"login":"kotfu","id":218536,"avatar_url":"https://avatars1.githubusercontent.com/u/218536?v=4","gravatar_id":"","url":"https://api.github.com/users/kotfu","html_url":"https://github.com/kotfu","followers_url":"https://api.github.com/users/kotfu/followers","following_url":"https://api.github.com/users/kotfu/following{/other_user}","gists_url":"https://api.github.com/users/kotfu/gists{/gist_id}","starred_url":"https://api.github.com/users/kotfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kotfu/subscriptions","organizations_url":"https://api.github.com/users/kotfu/orgs","repos_url":"https://api.github.com/users/kotfu/repos","events_url":"https://api.github.com/users/kotfu/events{/privacy}","received_events_url":"https://api.github.com/users/kotfu/received_events","type":"User","site_admin":false},"body":"In an attempt to resolve #369, this PR:\r\n\r\n- puts a robust set of default imports in `cmd2/__init__.py` so those modules and functions are available when you **import cmd2**. In between version 0.8.5 and where **master** is now, we removed those imports to speed up the wall time for **import cmd2**, which also broke backwards compatibility\r\n- defers many imports of infrequently used libraries until we actually need them. This reduces the number of modules that are imported when you do **import cmd2**.\r\n- reduces by 10% the lines of code in `cmd2.py` so there is less code to parse every time you **import cmd2**\r\n- adds a note to `CHANGELOG.md` about the still unresolved #369.\r\n\r\n#369 is still not resolved, and we continue to work that issue, but will go ahead with 0.9.0 without resolving.\r\n\r\nBefore this PR is merged we need to\r\n- [ ] delete `mtime.sh` and `speedup_import.md`, two files to run and document import benchmarks\r\n","created_at":"2018-05-24T04:38:02Z","updated_at":"2018-05-24T05:26:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea273048c6824d7ffa74836d321378a3e5aa38d1","assignee":{"login":"kotfu","id":218536,"avatar_url":"https://avatars1.githubusercontent.com/u/218536?v=4","gravatar_id":"","url":"https://api.github.com/users/kotfu","html_url":"https://github.com/kotfu","followers_url":"https://api.github.com/users/kotfu/followers","following_url":"https://api.github.com/users/kotfu/following{/other_user}","gists_url":"https://api.github.com/users/kotfu/gists{/gist_id}","starred_url":"https://api.github.com/users/kotfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kotfu/subscriptions","organizations_url":"https://api.github.com/users/kotfu/orgs","repos_url":"https://api.github.com/users/kotfu/repos","events_url":"https://api.github.com/users/kotfu/events{/privacy}","received_events_url":"https://api.github.com/users/kotfu/received_events","type":"User","site_admin":false},"assignees":[{"login":"kotfu","id":218536,"avatar_url":"https://avatars1.githubusercontent.com/u/218536?v=4","gravatar_id":"","url":"https://api.github.com/users/kotfu","html_url":"https://github.com/kotfu","followers_url":"https://api.github.com/users/kotfu/followers","following_url":"https://api.github.com/users/kotfu/following{/other_user}","gists_url":"https://api.github.com/users/kotfu/gists{/gist_id}","starred_url":"https://api.github.com/users/kotfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kotfu/subscriptions","organizations_url":"https://api.github.com/users/kotfu/orgs","repos_url":"https://api.github.com/users/kotfu/repos","events_url":"https://api.github.com/users/kotfu/events{/privacy}","received_events_url":"https://api.github.com/users/kotfu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/python-cmd2/cmd2/milestones/17","html_url":"https://github.com/python-cmd2/cmd2/milestone/17","labels_url":"https://api.github.com/repos/python-cmd2/cmd2/milestones/17/labels","id":3260913,"number":17,"title":"0.9.0","description":"First release to only support Python 3, pyparsing replaced by shlex\r\n","creator":{"login":"tleonhardt","id":2812720,"avatar_url":"https://avatars1.githubusercontent.com/u/2812720?v=4","gravatar_id":"","url":"https://api.github.com/users/tleonhardt","html_url":"https://github.com/tleonhardt","followers_url":"https://api.github.com/users/tleonhardt/followers","following_url":"https://api.github.com/users/tleonhardt/following{/other_user}","gists_url":"https://api.github.com/users/tleonhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/tleonhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tleonhardt/subscriptions","organizations_url":"https://api.github.com/users/tleonhardt/orgs","repos_url":"https://api.github.com/users/tleonhardt/repos","events_url":"https://api.github.com/users/tleonhardt/events{/privacy}","received_events_url":"https://api.github.com/users/tleonhardt/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":33,"state":"open","created_at":"2018-04-12T06:18:41Z","updated_at":"2018-05-24T04:49:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/python-cmd2/cmd2/pulls/413/commits","review_comments_url":"https://api.github.com/repos/python-cmd2/cmd2/pulls/413/comments","review_comment_url":"https://api.github.com/repos/python-cmd2/cmd2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-cmd2/cmd2/issues/413/comments","statuses_url":"https://api.github.com/repos/python-cmd2/cmd2/statuses/db881e13796abdaabe6cb7d4121389c36e9aa407","head":{"label":"python-cmd2:speedup_import","ref":"speedup_import","sha":"db881e13796abdaabe6cb7d4121389c36e9aa407","user":{"login":"python-cmd2","id":17161025,"avatar_url":"https://avatars1.githubusercontent.com/u/17161025?v=4","gravatar_id":"","url":"https://api.github.com/users/python-cmd2","html_url":"https://github.com/python-cmd2","followers_url":"https://api.github.com/users/python-cmd2/followers","following_url":"https://api.github.com/users/python-cmd2/following{/other_user}","gists_url":"https://api.github.com/users/python-cmd2/gists{/gist_id}","starred_url":"https://api.github.com/users/python-cmd2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-cmd2/subscriptions","organizations_url":"https://api.github.com/users/python-cmd2/orgs","repos_url":"https://api.github.com/users/python-cmd2/repos","events_url":"https://api.github.com/users/python-cmd2/events{/privacy}","received_events_url":"https://api.github.com/users/python-cmd2/received_events","type":"Organization","site_admin":false},"repo":{"id":51442999,"name":"cmd2","full_name":"python-cmd2/cmd2","owner":{"login":"python-cmd2","id":17161025,"avatar_url":"https://avatars1.githubusercontent.com/u/17161025?v=4","gravatar_id":"","url":"https://api.github.com/users/python-cmd2","html_url":"https://github.com/python-cmd2","followers_url":"https://api.github.com/users/python-cmd2/followers","following_url":"https://api.github.com/users/python-cmd2/following{/other_user}","gists_url":"https://api.github.com/users/python-cmd2/gists{/gist_id}","starred_url":"https://api.github.com/users/python-cmd2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-cmd2/subscriptions","organizations_url":"https://api.github.com/users/python-cmd2/orgs","repos_url":"https://api.github.com/users/python-cmd2/repos","events_url":"https://api.github.com/users/python-cmd2/events{/privacy}","received_events_url":"https://api.github.com/users/python-cmd2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-cmd2/cmd2","description":"cmd2 - Quickly build feature-rich and user-friendly interactive command line applications in Python","fork":false,"url":"https://api.github.com/repos/python-cmd2/cmd2","forks_url":"https://api.github.com/repos/python-cmd2/cmd2/forks","keys_url":"https://api.github.com/repos/python-cmd2/cmd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-cmd2/cmd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-cmd2/cmd2/teams","hooks_url":"https://api.github.com/repos/python-cmd2/cmd2/hooks","issue_events_url":"https://api.github.com/repos/python-cmd2/cmd2/issues/events{/number}","events_url":"https://api.github.com/repos/python-cmd2/cmd2/events","assignees_url":"https://api.github.com/repos/python-cmd2/cmd2/assignees{/user}","branches_url":"https://api.github.com/repos/python-cmd2/cmd2/branches{/branch}","tags_url":"https://api.github.com/repos/python-cmd2/cmd2/tags","blobs_url":"https://api.github.com/repos/python-cmd2/cmd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-cmd2/cmd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-cmd2/cmd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-cmd2/cmd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-cmd2/cmd2/statuses/{sha}","languages_url":"https://api.github.com/repos/python-cmd2/cmd2/languages","stargazers_url":"https://api.github.com/repos/python-cmd2/cmd2/stargazers","contributors_url":"https://api.github.com/repos/python-cmd2/cmd2/contributors","subscribers_url":"https://api.github.com/repos/python-cmd2/cmd2/subscribers","subscription_url":"https://api.github.com/repos/python-cmd2/cmd2/subscription","commits_url":"https://api.github.com/repos/python-cmd2/cmd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-cmd2/cmd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-cmd2/cmd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-cmd2/cmd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-cmd2/cmd2/contents/{+path}","compare_url":"https://api.github.com/repos/python-cmd2/cmd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-cmd2/cmd2/merges","archive_url":"https://api.github.com/repos/python-cmd2/cmd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-cmd2/cmd2/downloads","issues_url":"https://api.github.com/repos/python-cmd2/cmd2/issues{/number}","pulls_url":"https://api.github.com/repos/python-cmd2/cmd2/pulls{/number}","milestones_url":"https://api.github.com/repos/python-cmd2/cmd2/milestones{/number}","notifications_url":"https://api.github.com/repos/python-cmd2/cmd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-cmd2/cmd2/labels{/name}","releases_url":"https://api.github.com/repos/python-cmd2/cmd2/releases{/id}","deployments_url":"https://api.github.com/repos/python-cmd2/cmd2/deployments","created_at":"2016-02-10T13:34:49Z","updated_at":"2018-05-24T04:46:08Z","pushed_at":"2018-05-24T04:55:36Z","git_url":"git://github.com/python-cmd2/cmd2.git","ssh_url":"git@github.com:python-cmd2/cmd2.git","clone_url":"https://github.com/python-cmd2/cmd2.git","svn_url":"https://github.com/python-cmd2/cmd2","homepage":"http://cmd2.readthedocs.io/","size":2867,"stargazers_count":109,"watchers_count":109,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":23,"open_issues":11,"watchers":109,"default_branch":"master"}},"base":{"label":"python-cmd2:master","ref":"master","sha":"5d64ebee348aeffb02fc385f903c9af431e3721b","user":{"login":"python-cmd2","id":17161025,"avatar_url":"https://avatars1.githubusercontent.com/u/17161025?v=4","gravatar_id":"","url":"https://api.github.com/users/python-cmd2","html_url":"https://github.com/python-cmd2","followers_url":"https://api.github.com/users/python-cmd2/followers","following_url":"https://api.github.com/users/python-cmd2/following{/other_user}","gists_url":"https://api.github.com/users/python-cmd2/gists{/gist_id}","starred_url":"https://api.github.com/users/python-cmd2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-cmd2/subscriptions","organizations_url":"https://api.github.com/users/python-cmd2/orgs","repos_url":"https://api.github.com/users/python-cmd2/repos","events_url":"https://api.github.com/users/python-cmd2/events{/privacy}","received_events_url":"https://api.github.com/users/python-cmd2/received_events","type":"Organization","site_admin":false},"repo":{"id":51442999,"name":"cmd2","full_name":"python-cmd2/cmd2","owner":{"login":"python-cmd2","id":17161025,"avatar_url":"https://avatars1.githubusercontent.com/u/17161025?v=4","gravatar_id":"","url":"https://api.github.com/users/python-cmd2","html_url":"https://github.com/python-cmd2","followers_url":"https://api.github.com/users/python-cmd2/followers","following_url":"https://api.github.com/users/python-cmd2/following{/other_user}","gists_url":"https://api.github.com/users/python-cmd2/gists{/gist_id}","starred_url":"https://api.github.com/users/python-cmd2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-cmd2/subscriptions","organizations_url":"https://api.github.com/users/python-cmd2/orgs","repos_url":"https://api.github.com/users/python-cmd2/repos","events_url":"https://api.github.com/users/python-cmd2/events{/privacy}","received_events_url":"https://api.github.com/users/python-cmd2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-cmd2/cmd2","description":"cmd2 - Quickly build feature-rich and user-friendly interactive command line applications in Python","fork":false,"url":"https://api.github.com/repos/python-cmd2/cmd2","forks_url":"https://api.github.com/repos/python-cmd2/cmd2/forks","keys_url":"https://api.github.com/repos/python-cmd2/cmd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-cmd2/cmd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-cmd2/cmd2/teams","hooks_url":"https://api.github.com/repos/python-cmd2/cmd2/hooks","issue_events_url":"https://api.github.com/repos/python-cmd2/cmd2/issues/events{/number}","events_url":"https://api.github.com/repos/python-cmd2/cmd2/events","assignees_url":"https://api.github.com/repos/python-cmd2/cmd2/assignees{/user}","branches_url":"https://api.github.com/repos/python-cmd2/cmd2/branches{/branch}","tags_url":"https://api.github.com/repos/python-cmd2/cmd2/tags","blobs_url":"https://api.github.com/repos/python-cmd2/cmd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-cmd2/cmd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-cmd2/cmd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-cmd2/cmd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-cmd2/cmd2/statuses/{sha}","languages_url":"https://api.github.com/repos/python-cmd2/cmd2/languages","stargazers_url":"https://api.github.com/repos/python-cmd2/cmd2/stargazers","contributors_url":"https://api.github.com/repos/python-cmd2/cmd2/contributors","subscribers_url":"https://api.github.com/repos/python-cmd2/cmd2/subscribers","subscription_url":"https://api.github.com/repos/python-cmd2/cmd2/subscription","commits_url":"https://api.github.com/repos/python-cmd2/cmd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-cmd2/cmd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-cmd2/cmd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-cmd2/cmd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-cmd2/cmd2/contents/{+path}","compare_url":"https://api.github.com/repos/python-cmd2/cmd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-cmd2/cmd2/merges","archive_url":"https://api.github.com/repos/python-cmd2/cmd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-cmd2/cmd2/downloads","issues_url":"https://api.github.com/repos/python-cmd2/cmd2/issues{/number}","pulls_url":"https://api.github.com/repos/python-cmd2/cmd2/pulls{/number}","milestones_url":"https://api.github.com/repos/python-cmd2/cmd2/milestones{/number}","notifications_url":"https://api.github.com/repos/python-cmd2/cmd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-cmd2/cmd2/labels{/name}","releases_url":"https://api.github.com/repos/python-cmd2/cmd2/releases{/id}","deployments_url":"https://api.github.com/repos/python-cmd2/cmd2/deployments","created_at":"2016-02-10T13:34:49Z","updated_at":"2018-05-24T04:46:08Z","pushed_at":"2018-05-24T04:55:36Z","git_url":"git://github.com/python-cmd2/cmd2.git","ssh_url":"git@github.com:python-cmd2/cmd2.git","clone_url":"https://github.com/python-cmd2/cmd2.git","svn_url":"https://github.com/python-cmd2/cmd2","homepage":"http://cmd2.readthedocs.io/","size":2867,"stargazers_count":109,"watchers_count":109,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":23,"open_issues":11,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-cmd2/cmd2/pulls/413"},"html":{"href":"https://github.com/python-cmd2/cmd2/pull/413"},"issue":{"href":"https://api.github.com/repos/python-cmd2/cmd2/issues/413"},"comments":{"href":"https://api.github.com/repos/python-cmd2/cmd2/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/python-cmd2/cmd2/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/python-cmd2/cmd2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-cmd2/cmd2/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/python-cmd2/cmd2/statuses/db881e13796abdaabe6cb7d4121389c36e9aa407"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tleonhardt"}}