{"action":"created","comment":{"url":"https://api.github.com/repos/pypa/wheel/pulls/comments/221872759","pull_request_review_id":160623815,"id":221872759,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTg3Mjc1OQ==","diff_hunk":"@@ -63,12 +77,12 @@ def __init__(self, file, mode='r'):\n                     path, hash_sum, size = line.rsplit(u',', 2)\n                     if hash_sum:\n                         algorithm, hash_sum = hash_sum.split(u'=')\n-                        if algorithm not in hashlib.algorithms_available:","path":"wheel/wheelfile.py","position":25,"original_position":25,"commit_id":"366ab61b4b274e42431029de150fbd59ba3d374f","original_commit_id":"366ab61b4b274e42431029de150fbd59ba3d374f","user":{"login":"benoit-pierre","id":5104286,"node_id":"MDQ6VXNlcjUxMDQyODY=","avatar_url":"https://avatars1.githubusercontent.com/u/5104286?v=4","gravatar_id":"","url":"https://api.github.com/users/benoit-pierre","html_url":"https://github.com/benoit-pierre","followers_url":"https://api.github.com/users/benoit-pierre/followers","following_url":"https://api.github.com/users/benoit-pierre/following{/other_user}","gists_url":"https://api.github.com/users/benoit-pierre/gists{/gist_id}","starred_url":"https://api.github.com/users/benoit-pierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoit-pierre/subscriptions","organizations_url":"https://api.github.com/users/benoit-pierre/orgs","repos_url":"https://api.github.com/users/benoit-pierre/repos","events_url":"https://api.github.com/users/benoit-pierre/events{/privacy}","received_events_url":"https://api.github.com/users/benoit-pierre/received_events","type":"User","site_admin":false},"body":"It's still done in the constructor, it's just that IMHO, in the unlikely event that `md5`,/ `sha` is unsupported, the code should still complain about PEP 427, not about the missing support.","created_at":"2018-10-02T08:57:45Z","updated_at":"2018-10-02T08:57:45Z","html_url":"https://github.com/pypa/wheel/pull/259#discussion_r221872759","pull_request_url":"https://api.github.com/repos/pypa/wheel/pulls/259","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pypa/wheel/pulls/comments/221872759"},"html":{"href":"https://github.com/pypa/wheel/pull/259#discussion_r221872759"},"pull_request":{"href":"https://api.github.com/repos/pypa/wheel/pulls/259"}},"in_reply_to_id":221870326},"pull_request":{"url":"https://api.github.com/repos/pypa/wheel/pulls/259","id":219618588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NjE4NTg4","html_url":"https://github.com/pypa/wheel/pull/259","diff_url":"https://github.com/pypa/wheel/pull/259.diff","patch_url":"https://github.com/pypa/wheel/pull/259.patch","issue_url":"https://api.github.com/repos/pypa/wheel/issues/259","number":259,"state":"open","locked":false,"title":"fix support for Python 2.7","user":{"login":"benoit-pierre","id":5104286,"node_id":"MDQ6VXNlcjUxMDQyODY=","avatar_url":"https://avatars1.githubusercontent.com/u/5104286?v=4","gravatar_id":"","url":"https://api.github.com/users/benoit-pierre","html_url":"https://github.com/benoit-pierre","followers_url":"https://api.github.com/users/benoit-pierre/followers","following_url":"https://api.github.com/users/benoit-pierre/following{/other_user}","gists_url":"https://api.github.com/users/benoit-pierre/gists{/gist_id}","starred_url":"https://api.github.com/users/benoit-pierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoit-pierre/subscriptions","organizations_url":"https://api.github.com/users/benoit-pierre/orgs","repos_url":"https://api.github.com/users/benoit-pierre/repos","events_url":"https://api.github.com/users/benoit-pierre/events{/privacy}","received_events_url":"https://api.github.com/users/benoit-pierre/received_events","type":"User","site_admin":false},"body":"`hashlib.algorithms_available` was only added in 2.7.9. Fix #258.","created_at":"2018-10-02T08:13:20Z","updated_at":"2018-10-02T08:57:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4680bb6a4027c24342b0b5f8a5647f0e900e39a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pypa/wheel/pulls/259/commits","review_comments_url":"https://api.github.com/repos/pypa/wheel/pulls/259/comments","review_comment_url":"https://api.github.com/repos/pypa/wheel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypa/wheel/issues/259/comments","statuses_url":"https://api.github.com/repos/pypa/wheel/statuses/366ab61b4b274e42431029de150fbd59ba3d374f","head":{"label":"benoit-pierre:fix_py27_support","ref":"fix_py27_support","sha":"366ab61b4b274e42431029de150fbd59ba3d374f","user":{"login":"benoit-pierre","id":5104286,"node_id":"MDQ6VXNlcjUxMDQyODY=","avatar_url":"https://avatars1.githubusercontent.com/u/5104286?v=4","gravatar_id":"","url":"https://api.github.com/users/benoit-pierre","html_url":"https://github.com/benoit-pierre","followers_url":"https://api.github.com/users/benoit-pierre/followers","following_url":"https://api.github.com/users/benoit-pierre/following{/other_user}","gists_url":"https://api.github.com/users/benoit-pierre/gists{/gist_id}","starred_url":"https://api.github.com/users/benoit-pierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoit-pierre/subscriptions","organizations_url":"https://api.github.com/users/benoit-pierre/orgs","repos_url":"https://api.github.com/users/benoit-pierre/repos","events_url":"https://api.github.com/users/benoit-pierre/events{/privacy}","received_events_url":"https://api.github.com/users/benoit-pierre/received_events","type":"User","site_admin":false},"repo":{"id":115825878,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU4MjU4Nzg=","name":"wheel","full_name":"benoit-pierre/wheel","private":false,"owner":{"login":"benoit-pierre","id":5104286,"node_id":"MDQ6VXNlcjUxMDQyODY=","avatar_url":"https://avatars1.githubusercontent.com/u/5104286?v=4","gravatar_id":"","url":"https://api.github.com/users/benoit-pierre","html_url":"https://github.com/benoit-pierre","followers_url":"https://api.github.com/users/benoit-pierre/followers","following_url":"https://api.github.com/users/benoit-pierre/following{/other_user}","gists_url":"https://api.github.com/users/benoit-pierre/gists{/gist_id}","starred_url":"https://api.github.com/users/benoit-pierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoit-pierre/subscriptions","organizations_url":"https://api.github.com/users/benoit-pierre/orgs","repos_url":"https://api.github.com/users/benoit-pierre/repos","events_url":"https://api.github.com/users/benoit-pierre/events{/privacy}","received_events_url":"https://api.github.com/users/benoit-pierre/received_events","type":"User","site_admin":false},"html_url":"https://github.com/benoit-pierre/wheel","description":"The official binary distribution format for Python","fork":true,"url":"https://api.github.com/repos/benoit-pierre/wheel","forks_url":"https://api.github.com/repos/benoit-pierre/wheel/forks","keys_url":"https://api.github.com/repos/benoit-pierre/wheel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benoit-pierre/wheel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benoit-pierre/wheel/teams","hooks_url":"https://api.github.com/repos/benoit-pierre/wheel/hooks","issue_events_url":"https://api.github.com/repos/benoit-pierre/wheel/issues/events{/number}","events_url":"https://api.github.com/repos/benoit-pierre/wheel/events","assignees_url":"https://api.github.com/repos/benoit-pierre/wheel/assignees{/user}","branches_url":"https://api.github.com/repos/benoit-pierre/wheel/branches{/branch}","tags_url":"https://api.github.com/repos/benoit-pierre/wheel/tags","blobs_url":"https://api.github.com/repos/benoit-pierre/wheel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benoit-pierre/wheel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benoit-pierre/wheel/git/refs{/sha}","trees_url":"https://api.github.com/repos/benoit-pierre/wheel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benoit-pierre/wheel/statuses/{sha}","languages_url":"https://api.github.com/repos/benoit-pierre/wheel/languages","stargazers_url":"https://api.github.com/repos/benoit-pierre/wheel/stargazers","contributors_url":"https://api.github.com/repos/benoit-pierre/wheel/contributors","subscribers_url":"https://api.github.com/repos/benoit-pierre/wheel/subscribers","subscription_url":"https://api.github.com/repos/benoit-pierre/wheel/subscription","commits_url":"https://api.github.com/repos/benoit-pierre/wheel/commits{/sha}","git_commits_url":"https://api.github.com/repos/benoit-pierre/wheel/git/commits{/sha}","comments_url":"https://api.github.com/repos/benoit-pierre/wheel/comments{/number}","issue_comment_url":"https://api.github.com/repos/benoit-pierre/wheel/issues/comments{/number}","contents_url":"https://api.github.com/repos/benoit-pierre/wheel/contents/{+path}","compare_url":"https://api.github.com/repos/benoit-pierre/wheel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benoit-pierre/wheel/merges","archive_url":"https://api.github.com/repos/benoit-pierre/wheel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benoit-pierre/wheel/downloads","issues_url":"https://api.github.com/repos/benoit-pierre/wheel/issues{/number}","pulls_url":"https://api.github.com/repos/benoit-pierre/wheel/pulls{/number}","milestones_url":"https://api.github.com/repos/benoit-pierre/wheel/milestones{/number}","notifications_url":"https://api.github.com/repos/benoit-pierre/wheel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benoit-pierre/wheel/labels{/name}","releases_url":"https://api.github.com/repos/benoit-pierre/wheel/releases{/id}","deployments_url":"https://api.github.com/repos/benoit-pierre/wheel/deployments","created_at":"2017-12-30T21:39:38Z","updated_at":"2018-09-23T17:42:14Z","pushed_at":"2018-10-02T08:12:26Z","git_url":"git://github.com/benoit-pierre/wheel.git","ssh_url":"git@github.com:benoit-pierre/wheel.git","clone_url":"https://github.com/benoit-pierre/wheel.git","svn_url":"https://github.com/benoit-pierre/wheel","homepage":null,"size":1217,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pypa:master","ref":"master","sha":"e774538e0be3a5ca79ca31b1ae01c6672480bef6","user":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":98346885,"node_id":"MDEwOlJlcG9zaXRvcnk5ODM0Njg4NQ==","name":"wheel","full_name":"pypa/wheel","private":false,"owner":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pypa/wheel","description":"The official binary distribution format for Python","fork":false,"url":"https://api.github.com/repos/pypa/wheel","forks_url":"https://api.github.com/repos/pypa/wheel/forks","keys_url":"https://api.github.com/repos/pypa/wheel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/wheel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/wheel/teams","hooks_url":"https://api.github.com/repos/pypa/wheel/hooks","issue_events_url":"https://api.github.com/repos/pypa/wheel/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/wheel/events","assignees_url":"https://api.github.com/repos/pypa/wheel/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/wheel/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/wheel/tags","blobs_url":"https://api.github.com/repos/pypa/wheel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/wheel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/wheel/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/wheel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/wheel/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/wheel/languages","stargazers_url":"https://api.github.com/repos/pypa/wheel/stargazers","contributors_url":"https://api.github.com/repos/pypa/wheel/contributors","subscribers_url":"https://api.github.com/repos/pypa/wheel/subscribers","subscription_url":"https://api.github.com/repos/pypa/wheel/subscription","commits_url":"https://api.github.com/repos/pypa/wheel/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/wheel/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/wheel/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/wheel/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/wheel/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/wheel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/wheel/merges","archive_url":"https://api.github.com/repos/pypa/wheel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/wheel/downloads","issues_url":"https://api.github.com/repos/pypa/wheel/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/wheel/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/wheel/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/wheel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/wheel/labels{/name}","releases_url":"https://api.github.com/repos/pypa/wheel/releases{/id}","deployments_url":"https://api.github.com/repos/pypa/wheel/deployments","created_at":"2017-07-25T20:24:25Z","updated_at":"2018-10-02T07:21:53Z","pushed_at":"2018-10-02T08:13:21Z","git_url":"git://github.com/pypa/wheel.git","ssh_url":"git@github.com:pypa/wheel.git","clone_url":"https://github.com/pypa/wheel.git","svn_url":"https://github.com/pypa/wheel","homepage":null,"size":1227,"stargazers_count":92,"watchers_count":92,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":32,"open_issues":20,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/wheel/pulls/259"},"html":{"href":"https://github.com/pypa/wheel/pull/259"},"issue":{"href":"https://api.github.com/repos/pypa/wheel/issues/259"},"comments":{"href":"https://api.github.com/repos/pypa/wheel/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/wheel/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/wheel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypa/wheel/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/wheel/statuses/366ab61b4b274e42431029de150fbd59ba3d374f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"benoit-pierre"}}