{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/192518154","pull_request_review_id":125320062,"id":192518154,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjUxODE1NA==","diff_hunk":"@@ -1002,8 +1015,12 @@ class _RenderSlider extends RenderBox {\n \n     config.isSemanticBoundary = isInteractive;\n     if (isInteractive) {\n+      config.textDirection = textDirection;\n       config.onIncrease = _increaseAction;\n       config.onDecrease = _decreaseAction;\n+      config.value = '${(value * 100).round().clamp(0, 100)}%';","path":"packages/flutter/lib/src/material/slider.dart","position":94,"original_position":43,"commit_id":"10bdbdf884ae8dfee729f4ba2782d1ad77dfd599","original_commit_id":"485dbfe452bb02f57909db9142753079a488826d","user":{"login":"jonahwilliams","id":8975114,"node_id":"MDQ6VXNlcjg5NzUxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"body":"Doing some more investigation - it is total possible to support values with a flag (normalizeSemanticsValue?) but because of how we lerp/unlerp doubles it is fairly easy to get a number like 20.000000000000001 which TalkBack will read out in its entirety.  We could always round to the nearest whole number and document that on the flag.\r\n\r\nThoughts @goderbauer ?","created_at":"2018-06-01T21:18:58Z","updated_at":"2018-06-01T21:18:58Z","html_url":"https://github.com/flutter/flutter/pull/18005#discussion_r192518154","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/18005","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/192518154"},"html":{"href":"https://github.com/flutter/flutter/pull/18005#discussion_r192518154"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18005"}},"in_reply_to_id":191588660},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/18005","id":191265229,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMjY1MjI5","html_url":"https://github.com/flutter/flutter/pull/18005","diff_url":"https://github.com/flutter/flutter/pull/18005.diff","patch_url":"https://github.com/flutter/flutter/pull/18005.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/18005","number":18005,"state":"open","locked":false,"title":"update a11y for material slider on android","user":{"login":"jonahwilliams","id":8975114,"node_id":"MDQ6VXNlcjg5NzUxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"body":"Slider values are announced when updating.  Volume control adjustment amount is set to 5% on Android to match native behavior.\r\n\r\nhttps://github.com/flutter/flutter/issues/14398","created_at":"2018-05-29T20:45:48Z","updated_at":"2018-06-01T21:18:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0784ff053163be8de4079cbbdb340998a3d5061","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/18005/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/18005/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/18005/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/10bdbdf884ae8dfee729f4ba2782d1ad77dfd599","head":{"label":"jonahwilliams:a11y_14398","ref":"a11y_14398","sha":"10bdbdf884ae8dfee729f4ba2782d1ad77dfd599","user":{"login":"jonahwilliams","id":8975114,"node_id":"MDQ6VXNlcjg5NzUxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"repo":{"id":123957473,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5NTc0NzM=","name":"flutter","full_name":"jonahwilliams/flutter","owner":{"login":"jonahwilliams","id":8975114,"node_id":"MDQ6VXNlcjg5NzUxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonahwilliams/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/jonahwilliams/flutter","forks_url":"https://api.github.com/repos/jonahwilliams/flutter/forks","keys_url":"https://api.github.com/repos/jonahwilliams/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonahwilliams/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonahwilliams/flutter/teams","hooks_url":"https://api.github.com/repos/jonahwilliams/flutter/hooks","issue_events_url":"https://api.github.com/repos/jonahwilliams/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/jonahwilliams/flutter/events","assignees_url":"https://api.github.com/repos/jonahwilliams/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/jonahwilliams/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/jonahwilliams/flutter/tags","blobs_url":"https://api.github.com/repos/jonahwilliams/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonahwilliams/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonahwilliams/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonahwilliams/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonahwilliams/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/jonahwilliams/flutter/languages","stargazers_url":"https://api.github.com/repos/jonahwilliams/flutter/stargazers","contributors_url":"https://api.github.com/repos/jonahwilliams/flutter/contributors","subscribers_url":"https://api.github.com/repos/jonahwilliams/flutter/subscribers","subscription_url":"https://api.github.com/repos/jonahwilliams/flutter/subscription","commits_url":"https://api.github.com/repos/jonahwilliams/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonahwilliams/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonahwilliams/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonahwilliams/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonahwilliams/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/jonahwilliams/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonahwilliams/flutter/merges","archive_url":"https://api.github.com/repos/jonahwilliams/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonahwilliams/flutter/downloads","issues_url":"https://api.github.com/repos/jonahwilliams/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/jonahwilliams/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/jonahwilliams/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/jonahwilliams/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonahwilliams/flutter/labels{/name}","releases_url":"https://api.github.com/repos/jonahwilliams/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/jonahwilliams/flutter/deployments","created_at":"2018-03-05T17:57:36Z","updated_at":"2018-03-26T16:03:34Z","pushed_at":"2018-06-01T20:42:42Z","git_url":"git://github.com/jonahwilliams/flutter.git","ssh_url":"git@github.com:jonahwilliams/flutter.git","clone_url":"https://github.com/jonahwilliams/flutter.git","svn_url":"https://github.com/jonahwilliams/flutter","homepage":"https://flutter.io","size":39377,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"529d25045393430742daf06517417a7687074dba","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-06-01T20:23:00Z","pushed_at":"2018-06-01T20:49:35Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":39246,"stargazers_count":25389,"watchers_count":25389,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2294,"mirror_url":null,"archived":false,"open_issues_count":3230,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2294,"open_issues":3230,"watchers":25389,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18005"},"html":{"href":"https://github.com/flutter/flutter/pull/18005"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/18005"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/18005/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18005/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18005/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/10bdbdf884ae8dfee729f4ba2782d1ad77dfd599"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jonahwilliams"}}