{"push_id":2862395645,"size":9,"distinct_size":1,"ref":"refs/heads/commitfest/20/1790","head":"7c34b77e85e444de49878889dc951dd38e1d8119","before":"02e10ad7e07f1bde486874478d72ae1ff5cebaf3","commits":[{"sha":"f47f3148011f1cb5dc34396382fc2f434844d247","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Minor cleanup/future-proofing for pg_saslprep().\n\nEnsure that pg_saslprep() initializes its output argument to NULL in\nall failure paths, and then remove the redundant initialization that\nsome (not all) of its callers did.  This does not fix any live bug,\nbut it reduces the odds of future bugs of omission.\n\nAlso add a comment about why the existing failure-path coding is\nadequate.\n\nBack-patch so as to keep the function's API consistent across branches,\nagain to forestall future bug introduction.\n\nPatch by me, reviewed by Michael Paquier\n\nDiscussion: https://postgr.es/m/16558.1536407783@sss.pgh.pa.us","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/f47f3148011f1cb5dc34396382fc2f434844d247"},{"sha":"076a3c2112b127b3b36346dbc64659f9a165f60f","author":{"name":"Noah Misch","email":"1db01d43e08596f43a65fb393d969b98ee5b4dc6@leadboat.com"},"message":"Fix logical subscriber wait in test.\n\nBuildfarm members sungazer and tern revealed this deficit.  Back-patch\nto v10, like commit 4f10e7ea7b2231f453bb18b6e710ac333eaf121b, which\nintroduced the test.","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/076a3c2112b127b3b36346dbc64659f9a165f60f"},{"sha":"c85ad9cc63e1487758f3969e20826cac0e944a27","author":{"name":"Noah Misch","email":"1db01d43e08596f43a65fb393d969b98ee5b4dc6@leadboat.com"},"message":"Allow ENOENT in check_mode_recursive().\n\nBuildfarm member tern failed src/bin/pg_ctl/t/001_start_stop.pl when a\ncheck_mode_recursive() call overlapped a server's startup-time deletion\nof pg_stat/global.stat.  Just warn.  Also, include errno in the message.\nBack-patch to v11, where check_mode_recursive() first appeared.","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/c85ad9cc63e1487758f3969e20826cac0e944a27"},{"sha":"ed0cdf0e05134d1084b01bf8a77e9e1dc5081f91","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Install a check for mis-linking of src/port and src/common functions.\n\nOn ELF-based platforms (and maybe others?) it's possible for a shared\nlibrary, when dynamically loaded into the backend, to call the backend\nversions of src/port and src/common functions rather than the frontend\nversions that are actually linked into the shlib.  This is definitely\nnot what we want, because the frontend versions often behave slightly\ndifferently.  Up to now it's been \"slight\" enough that nobody noticed;\nbut with the addition of SCRAM support functions in src/common, we're\nobserving crashes due to the difference between palloc and malloc\nmemory allocation rules, as reported in bug #15367 from Jeremy Evans.\n\nThe purpose of this patch is to create a direct test for this type of\nmis-linking, so that we know whether any given platform requires extra\nmeasures to prevent using the wrong functions.  If the test fails, it\nwill lead to connection failures in the contrib/postgres_fdw regression\ntest.  At the moment, *BSD platforms using ELF format are known to have\nthe problem and can be expected to fail; but we need to know whether\nanything else does, and we need a reliable ongoing check for future\nplatforms.\n\nActually fixing the problem will be the subject of later commit(s).\n\nDiscussion: https://postgr.es/m/153626613985.23143.4743626885618266803@wrigleys.postgresql.org","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/ed0cdf0e05134d1084b01bf8a77e9e1dc5081f91"},{"sha":"ff47d4bf1f208227a2e087ef7269e88285fa257e","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Work around stdbool problem in dfmgr.c.\n\nCommit 842cb9fa6 refactored things so that dfmgr.c includes <dlfcn.h>,\nwhich before that had only been directly included in platform-specific\nstub files.  It turns out that on macOS, <dlfcn.h> includes <stdbool.h>,\nand that causes problems on platforms where _Bool is not char-sized ...\nwhich happens to include the PPC versions of macOS.  Work around it\nmuch as we have in plperl.h, by #undef'ing bool after including the\nproblematic file, but only if we're not using stdbool-style booleans.\n\nDiscussion: https://postgr.es/m/E1fxqjl-0003YS-NS@gemulon.postgresql.org","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/ff47d4bf1f208227a2e087ef7269e88285fa257e"},{"sha":"5f08accdad2b03e0107bdc73d48783a01fe51c8c","author":{"name":"Alexander Korotkov","email":"1c137998207470ad0f56303c4fc305487ec0232f@postgresql.org"},"message":"Fix past pd_upper write in ginRedoRecompress()\n\nginRedoRecompress() replays actions over compressed segments of posting list\nin-place.  However, it might lead to write past pg_upper, because intermediate\nstate during playing the changes can take more space than both original state\nand final state.  This commit fixes that by refuse from in-place modification.\nInstead page tail is copied once modification is started, and then it's used\nas the source of original segments.  Backpatch to 9.4 where posting list\ncompression was introduced.\n\nReported-by: Sivasubramanian Ramasubramanian\nDiscussion: https://postgr.es/m/1536091151804.6588%40amazon.com\nAuthor: Alexander Korotkov based on patch from and ideas by Sivasubramanian Ramasubramanian\nReview: Sivasubramanian Ramasubramanian\nBackpatch-through: 9.4","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/5f08accdad2b03e0107bdc73d48783a01fe51c8c"},{"sha":"cf984672427ebc4446213fe8f71d8899452802b6","author":{"name":"Alexander Korotkov","email":"1c137998207470ad0f56303c4fc305487ec0232f@postgresql.org"},"message":"Improve behavior of to_timestamp()/to_date() functions\n\nto_timestamp()/to_date() functions were introduced mainly for Oracle\ncompatibility, and became very popular among PostgreSQL users.  However, some\nbehavior of to_timestamp()/to_date() functions are both incompatible with Oracle\nand confusing for our users.  This behavior is related to handling of spaces and\nseparators in non FX (fixed format) mode.  This commit reworks this behavior\nmaking less confusing, better documented and more compatible with Oracle.\n\nNevertheless, there are still following incompatibilities with Oracle.\n1) We don't insist that there are no format string patterns unmatched to\n   input string.\n2) In FX mode we don't insist space and separators in format string to exactly\n   match input string.\n3) When format string patterns are divided by mix of spaces and separators, we\n   don't distinguish them, while Oracle takes into account only last group of\n   spaces/separators.\n\nDiscussion: https://postgr.es/m/1873520224.1784572.1465833145330.JavaMail.yahoo%40mail.yahoo.com\nAuthor: Artur Zakirov, Alexander Korotkov, Liudmila Mantrova\nReview: Amul Sul, Robert Haas, Tom Lane, Dmitry Dolgov, David G. Johnston","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/cf984672427ebc4446213fe8f71d8899452802b6"},{"sha":"e3d77ea6b4e425093db23be492f236896dd7b501","author":{"name":"Tom Lane","email":"ffeaa947aef224da9ba99b6a18bdd74288df0e3e@sss.pgh.pa.us"},"message":"Prevent mis-linking of src/port and src/common functions on *BSD.\n\nOn ELF-based platforms (and maybe others?) it's possible for a shared\nlibrary, when dynamically loaded into the backend, to call the backend\nversions of src/port and src/common functions rather than the frontend\nversions that are actually linked into the shlib.  This is the cause\nof bug #15367 from Jeremy Evans, and is likely to lead to more problems\nin future; it's accidental that we've failed to notice any bad effects\nup to now.\n\nThe recommended way to fix this on ELF-based platforms is to use a\nlinker \"version script\" that makes the shlib's versions of the functions\nlocal.  (Apparently, -Bsymbolic would fix it as well, but with other\nside effects that we don't want.)  Doing so has the additional benefit\nthat we can make sure the shlib only exposes the symbols that are meant\nto be part of its API, and not ones that are just for cross-file\nreferences within the shlib.  So we'd already been using a version\nscript for libpq on popular platforms, but it's now apparent that it's\nnecessary for correctness on every ELF-based platform.\n\nHence, add appropriate logic to the openbsd, freebsd, and netbsd stanzas\nof Makefile.shlib; this is just a copy-and-paste from the linux stanza.\nThere may be additional work to do if commit ed0cdf0e0 reveals that the\nproblem exists elsewhere, but this is all that is known to be needed\nright now.\n\nBack-patch to v10 where SCRAM support came in.  The problem is ancient,\nbut analysis suggests that there were no really severe consequences\nin older branches.  Hence, I won't take the risk of such a large change\nin the build process for older branches.\n\nIn passing, remove a rather opaque comment about -Bsymbolic; I don't\nthink it's very on-point about why we don't use that, if indeed that's\nwhat it's talking about at all.\n\nPatch by me; thanks to Andrew Gierth for helping to diagnose the problem,\nand for additional testing.\n\nDiscussion: https://postgr.es/m/153626613985.23143.4743626885618266803@wrigleys.postgresql.org","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/e3d77ea6b4e425093db23be492f236896dd7b501"},{"sha":"7c34b77e85e444de49878889dc951dd38e1d8119","author":{"name":"Commitfest Bot","email":"b9e638e07cc2e2abf56c9c0cad7954f2e3bc1641@cputube.org"},"message":"[CF 20/1790] A fix for signal-handling and dynamic shared memory resizing on linux that can cause endless loop\n\nThis commit was automatically generated by cfbot at commitfest.cputube.org.\nIt is based on patches submitted to the PostgreSQL mailing lists and\nregistered in the PostgreSQL Commitfest application.\n\nThis branch will be overwritten each time a new patch version is posted to\nthe email thread, and also periodically to check for bitrot caused by changes\non the master branch.\n\nCommitfest entry: https://commitfest.postgresql.org/20/1790\nPatch(es): https://www.postgresql.org/message-id/CAN-RpxB-oeZve_J3SM_6=HXPmvEG=HX+9V9pi8g2YR7YW0rBBg@mail.gmail.com\nAuthor(s):","distinct":true,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/7c34b77e85e444de49878889dc951dd38e1d8119"}]}
{"actor":{"display_login":"postgresql-cfbot"}}