{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/39826","repository_url":"https://api.github.com/repos/tgstation/tgstation","labels_url":"https://api.github.com/repos/tgstation/tgstation/issues/39826/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/39826/comments","events_url":"https://api.github.com/repos/tgstation/tgstation/issues/39826/events","html_url":"https://github.com/tgstation/tgstation/pull/39826","id":352355758,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Njg3MzQ2","number":39826,"title":"Slash SSatmos init time by 93%","user":{"login":"SpaceManiac","id":222630,"node_id":"MDQ6VXNlcjIyMjYzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/222630?v=4","gravatar_id":"","url":"https://api.github.com/users/SpaceManiac","html_url":"https://github.com/SpaceManiac","followers_url":"https://api.github.com/users/SpaceManiac/followers","following_url":"https://api.github.com/users/SpaceManiac/following{/other_user}","gists_url":"https://api.github.com/users/SpaceManiac/gists{/gist_id}","starred_url":"https://api.github.com/users/SpaceManiac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpaceManiac/subscriptions","organizations_url":"https://api.github.com/users/SpaceManiac/orgs","repos_url":"https://api.github.com/users/SpaceManiac/repos","events_url":"https://api.github.com/users/SpaceManiac/events{/privacy}","received_events_url":"https://api.github.com/users/SpaceManiac/received_events","type":"User","site_admin":false},"labels":[{"id":575115976,"node_id":"MDU6TGFiZWw1NzUxMTU5NzY=","url":"https://api.github.com/repos/tgstation/tgstation/labels/Atmospherics","name":"Atmospherics","color":"9300ff","default":false},{"id":627951053,"node_id":"MDU6TGFiZWw2Mjc5NTEwNTM=","url":"https://api.github.com/repos/tgstation/tgstation/labels/Code%20Improvement","name":"Code Improvement","color":"551A8B","default":false},{"id":31457173,"node_id":"MDU6TGFiZWwzMTQ1NzE3Mw==","url":"https://api.github.com/repos/tgstation/tgstation/labels/Performance","name":"Performance","color":"0b02e1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-21T01:49:57Z","updated_at":"2018-08-21T02:52:42Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/39826","html_url":"https://github.com/tgstation/tgstation/pull/39826","diff_url":"https://github.com/tgstation/tgstation/pull/39826.diff","patch_url":"https://github.com/tgstation/tgstation/pull/39826.patch"},"body":":cl:\r\ncode: Atmospherics now initializes 93% faster.\r\n/:cl:\r\n\r\nOn BoxStation with default configs, takes SSatmos init from 46.3 seconds to 3.5 seconds.\r\n\r\nAccording to profiling, and confirmed in a test project, `setup_allturfs` spends almost all of its time on the `active_turfs -= T` line, slowly and painfully removing every turf in the world from `active_turfs` one by one. Instead, let's just clear it outright.\r\n\r\nNo ill effects observed, but someone who knows atmos code better should double-check this.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/comments/414532990","html_url":"https://github.com/tgstation/tgstation/pull/39826#issuecomment-414532990","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/39826","id":414532990,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDUzMjk5MA==","user":{"login":"octareenroon91","id":12420976,"node_id":"MDQ6VXNlcjEyNDIwOTc2","avatar_url":"https://avatars1.githubusercontent.com/u/12420976?v=4","gravatar_id":"","url":"https://api.github.com/users/octareenroon91","html_url":"https://github.com/octareenroon91","followers_url":"https://api.github.com/users/octareenroon91/followers","following_url":"https://api.github.com/users/octareenroon91/following{/other_user}","gists_url":"https://api.github.com/users/octareenroon91/gists{/gist_id}","starred_url":"https://api.github.com/users/octareenroon91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octareenroon91/subscriptions","organizations_url":"https://api.github.com/users/octareenroon91/orgs","repos_url":"https://api.github.com/users/octareenroon91/repos","events_url":"https://api.github.com/users/octareenroon91/events{/privacy}","received_events_url":"https://api.github.com/users/octareenroon91/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T02:52:42Z","updated_at":"2018-08-21T02:52:42Z","author_association":"CONTRIBUTOR","body":"OK that makes sense."}}
{"actor":{"display_login":"octareenroon91"}}