{"action":"created","issue":{"url":"https://api.github.com/repos/igniterealtime/Openfire/issues/1174","repository_url":"https://api.github.com/repos/igniterealtime/Openfire","labels_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/1174/labels{/name}","comments_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/1174/comments","events_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/1174/events","html_url":"https://github.com/igniterealtime/Openfire/pull/1174","id":370352810,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDUwMTc2","number":1174,"title":"OF-1517: Don't require encoded i18n files for plugins.","user":{"login":"guusdk","id":4253898,"node_id":"MDQ6VXNlcjQyNTM4OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4253898?v=4","gravatar_id":"","url":"https://api.github.com/users/guusdk","html_url":"https://github.com/guusdk","followers_url":"https://api.github.com/users/guusdk/followers","following_url":"https://api.github.com/users/guusdk/following{/other_user}","gists_url":"https://api.github.com/users/guusdk/gists{/gist_id}","starred_url":"https://api.github.com/users/guusdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guusdk/subscriptions","organizations_url":"https://api.github.com/users/guusdk/orgs","repos_url":"https://api.github.com/users/guusdk/repos","events_url":"https://api.github.com/users/guusdk/events{/privacy}","received_events_url":"https://api.github.com/users/guusdk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-10-15T21:33:24Z","updated_at":"2018-10-23T09:15:31Z","closed_at":"2018-10-19T16:52:44Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/igniterealtime/Openfire/pulls/1174","html_url":"https://github.com/igniterealtime/Openfire/pull/1174","diff_url":"https://github.com/igniterealtime/Openfire/pull/1174.diff","patch_url":"https://github.com/igniterealtime/Openfire/pull/1174.patch"},"body":"This commit prevents the need for \\u<hex><hex><hex><hex> encoded content in translation files. This change applies the fix that was done to the core in OF-1448 to the plugin structure.\r\n\r\nThe plugin assembly now copies all i18n files from the source folder to the build folder. There, the content is encoded using the native2ascii maven plugin. Finally, the encoded content is used in the plugin assembly.\r\n\r\nAll plugins to which this change applies (all plugins that have i18n files) will need to get a new release. This fix requires the new plugins to be build by Openfire 4.3.0 (which is as of yet unreleased). Runtime, there shouldn't be a need for 4.3.0.\r\n\r\nRelevant plugins have been modified. Their version number has been increased, and the changelog modified. Their pom files have been modified to inherit from 4.3.0-SNAPSHOT (which introduces this fix). This needs to be modified to 4.3.0 (sans -SNAPSHOT) before the plugin can be released (we should not release code that has -SNAPSHOT dependencies). For this to be possible, Openfire 4.3.0\r\nmust be released first."},"comment":{"url":"https://api.github.com/repos/igniterealtime/Openfire/issues/comments/432165978","html_url":"https://github.com/igniterealtime/Openfire/pull/1174#issuecomment-432165978","issue_url":"https://api.github.com/repos/igniterealtime/Openfire/issues/1174","id":432165978,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjE2NTk3OA==","user":{"login":"guusdk","id":4253898,"node_id":"MDQ6VXNlcjQyNTM4OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4253898?v=4","gravatar_id":"","url":"https://api.github.com/users/guusdk","html_url":"https://github.com/guusdk","followers_url":"https://api.github.com/users/guusdk/followers","following_url":"https://api.github.com/users/guusdk/following{/other_user}","gists_url":"https://api.github.com/users/guusdk/gists{/gist_id}","starred_url":"https://api.github.com/users/guusdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guusdk/subscriptions","organizations_url":"https://api.github.com/users/guusdk/orgs","repos_url":"https://api.github.com/users/guusdk/repos","events_url":"https://api.github.com/users/guusdk/events{/privacy}","received_events_url":"https://api.github.com/users/guusdk/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T09:15:31Z","updated_at":"2018-10-23T09:15:31Z","author_association":"MEMBER","body":"Is that strictly needed if the plugin code doesn't use any 1.8 API?"}}
{"actor":{"display_login":"guusdk"}}