{"action":"created","issue":{"url":"https://api.github.com/repos/projectfluent/fluent.js/issues/232","repository_url":"https://api.github.com/repos/projectfluent/fluent.js","labels_url":"https://api.github.com/repos/projectfluent/fluent.js/issues/232/labels{/name}","comments_url":"https://api.github.com/repos/projectfluent/fluent.js/issues/232/comments","events_url":"https://api.github.com/repos/projectfluent/fluent.js/issues/232/events","html_url":"https://github.com/projectfluent/fluent.js/pull/232","id":334665127,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTgxMjY0","number":232,"title":"Add VariantList","user":{"login":"zbraniecki","id":449986,"node_id":"MDQ6VXNlcjQ0OTk4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/449986?v=4","gravatar_id":"","url":"https://api.github.com/users/zbraniecki","html_url":"https://github.com/zbraniecki","followers_url":"https://api.github.com/users/zbraniecki/followers","following_url":"https://api.github.com/users/zbraniecki/following{/other_user}","gists_url":"https://api.github.com/users/zbraniecki/gists{/gist_id}","starred_url":"https://api.github.com/users/zbraniecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbraniecki/subscriptions","organizations_url":"https://api.github.com/users/zbraniecki/orgs","repos_url":"https://api.github.com/users/zbraniecki/repos","events_url":"https://api.github.com/users/zbraniecki/events{/privacy}","received_events_url":"https://api.github.com/users/zbraniecki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-21T21:30:01Z","updated_at":"2018-06-29T18:50:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/projectfluent/fluent.js/pulls/232","html_url":"https://github.com/projectfluent/fluent.js/pull/232","diff_url":"https://github.com/projectfluent/fluent.js/pull/232.diff","patch_url":"https://github.com/projectfluent/fluent.js/pull/232.patch"},"body":"This is not yet complete, but I'd like to get first feedback round.\r\n\r\nI'm in particular a bit confused about the Messages only accepting Patterns, while Terms accept VariantList | Pattern.\r\n\r\nShould I remove null-selector SelectExpression and replace it with VariantList? Does it mean that VariantList is a valid Expression that can show up in Pattern? If so, what's the difference between a Term with VariantList and a Term with a Pattern with a VariantList?\r\n\r\nWhat's the value of preventing Messages from having VariantList if they can have a Pattern with a Placeable with a VariantList?\r\n\r\n3 tests fail, pending answers to my questions :)"},"comment":{"url":"https://api.github.com/repos/projectfluent/fluent.js/issues/comments/401442442","html_url":"https://github.com/projectfluent/fluent.js/pull/232#issuecomment-401442442","issue_url":"https://api.github.com/repos/projectfluent/fluent.js/issues/232","id":401442442,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTQ0MjQ0Mg==","user":{"login":"zbraniecki","id":449986,"node_id":"MDQ6VXNlcjQ0OTk4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/449986?v=4","gravatar_id":"","url":"https://api.github.com/users/zbraniecki","html_url":"https://github.com/zbraniecki","followers_url":"https://api.github.com/users/zbraniecki/followers","following_url":"https://api.github.com/users/zbraniecki/following{/other_user}","gists_url":"https://api.github.com/users/zbraniecki/gists{/gist_id}","starred_url":"https://api.github.com/users/zbraniecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbraniecki/subscriptions","organizations_url":"https://api.github.com/users/zbraniecki/orgs","repos_url":"https://api.github.com/users/zbraniecki/repos","events_url":"https://api.github.com/users/zbraniecki/events{/privacy}","received_events_url":"https://api.github.com/users/zbraniecki/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T18:50:26Z","updated_at":"2018-06-29T18:50:26Z","author_association":"CONTRIBUTOR","body":"Ok, I updated as much as I could to your feedback, but am confused with tests. There's some minor issue with serialized adding a space in the closing bracket, but more importantly, there are some tests that expect select expression on message without selector, and I seem to get a pattern every time I try to get a variant list in my own test.\r\n\r\n@stasm - if you have time on Monday, feel free to take it over. If not, I'll resume on Tuesday."}}
{"actor":{"display_login":"zbraniecki"}}