{"action":"created","issue":{"url":"https://api.github.com/repos/FluentNHibernate/fluent-nhibernate/issues/395","repository_url":"https://api.github.com/repos/FluentNHibernate/fluent-nhibernate","labels_url":"https://api.github.com/repos/FluentNHibernate/fluent-nhibernate/issues/395/labels{/name}","comments_url":"https://api.github.com/repos/FluentNHibernate/fluent-nhibernate/issues/395/comments","events_url":"https://api.github.com/repos/FluentNHibernate/fluent-nhibernate/issues/395/events","html_url":"https://github.com/FluentNHibernate/fluent-nhibernate/pull/395","id":307471850,"number":395,"title":"Refactored MsSqlConnectionStringBuilder to remove dependencies.","user":{"login":"danilobreda","id":14843499,"avatar_url":"https://avatars0.githubusercontent.com/u/14843499?v=4","gravatar_id":"","url":"https://api.github.com/users/danilobreda","html_url":"https://github.com/danilobreda","followers_url":"https://api.github.com/users/danilobreda/followers","following_url":"https://api.github.com/users/danilobreda/following{/other_user}","gists_url":"https://api.github.com/users/danilobreda/gists{/gist_id}","starred_url":"https://api.github.com/users/danilobreda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danilobreda/subscriptions","organizations_url":"https://api.github.com/users/danilobreda/orgs","repos_url":"https://api.github.com/users/danilobreda/repos","events_url":"https://api.github.com/users/danilobreda/events{/privacy}","received_events_url":"https://api.github.com/users/danilobreda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-22T01:14:24Z","updated_at":"2018-03-22T01:26:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/FluentNHibernate/fluent-nhibernate/pulls/395","html_url":"https://github.com/FluentNHibernate/fluent-nhibernate/pull/395","diff_url":"https://github.com/FluentNHibernate/fluent-nhibernate/pull/395.diff","patch_url":"https://github.com/FluentNHibernate/fluent-nhibernate/pull/395.patch"},"body":"Issue https://github.com/FluentNHibernate/fluent-nhibernate/issues/393\r\n\r\nWe can now remove the need for System.Data.SqlClient.SqlConnectionStringBuilder and System.Data.SqlClient package."},"comment":{"url":"https://api.github.com/repos/FluentNHibernate/fluent-nhibernate/issues/comments/375148315","html_url":"https://github.com/FluentNHibernate/fluent-nhibernate/pull/395#issuecomment-375148315","issue_url":"https://api.github.com/repos/FluentNHibernate/fluent-nhibernate/issues/395","id":375148315,"user":{"login":"danilobreda","id":14843499,"avatar_url":"https://avatars0.githubusercontent.com/u/14843499?v=4","gravatar_id":"","url":"https://api.github.com/users/danilobreda","html_url":"https://github.com/danilobreda","followers_url":"https://api.github.com/users/danilobreda/followers","following_url":"https://api.github.com/users/danilobreda/following{/other_user}","gists_url":"https://api.github.com/users/danilobreda/gists{/gist_id}","starred_url":"https://api.github.com/users/danilobreda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danilobreda/subscriptions","organizations_url":"https://api.github.com/users/danilobreda/orgs","repos_url":"https://api.github.com/users/danilobreda/repos","events_url":"https://api.github.com/users/danilobreda/events{/privacy}","received_events_url":"https://api.github.com/users/danilobreda/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T01:26:15Z","updated_at":"2018-03-22T01:26:15Z","author_association":"NONE","body":"There is a Test error with a username/password with space on it:\r\n\r\n```\r\nFailed : FluentNHibernate.Testing.Cfg.Db.MsSqlConfigurationTester.ConnectionString_is_added_to_the_configuration\r\n  Expected string length 105 but was 103. Strings differ at index 74.\r\n  Expected: \"...tegrated Security=False;User ID=\"toni tester\";Password=secret\"\r\n  But was:  \"...tegrated Security=False;User Id=toni tester;Password=secret\"\r\n```\r\n\r\nShould I put the double quotes?"}}
{"actor":{"display_login":"danilobreda"}}