{"action":"created","comment":{"url":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/comments/208607942","pull_request_review_id":144451748,"id":208607942,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODYwNzk0Mg==","diff_hunk":"@@ -0,0 +1,56 @@\n+package main\n+\n+import (\n+\t\"flag\"\n+\t\"fmt\"\n+\t\"os\"\n+\n+\tgfd \"github.com/gluster/gluster-csi-drivers/pkg/glusterfs\"\n+\t\"github.com/gluster/gluster-csi-drivers/pkg/glusterfs/utils\"\n+\n+\t\"github.com/spf13/cobra\"\n+)\n+\n+func init() {\n+\tflag.Set(\"logtostderr\", \"true\")\n+}\n+\n+func main() {\n+\tflag.CommandLine.Parse([]string{})\n+\tvar config = utils.NewConfig()\n+\n+\tcmd := &cobra.Command{\n+\t\tUse:   \"glusterfs-csi-driver\",\n+\t\tShort: \"GlusterFS CSI driver\",\n+\t\tRun: func(cmd *cobra.Command, args []string) {\n+\t\t\thandle(config)\n+\t\t},\n+\t}\n+\n+\tcmd.Flags().AddGoFlagSet(flag.CommandLine)\n+\n+\tcmd.PersistentFlags().StringVar(&config.NodeID, \"nodeid\", \"\", \"CSI node id\")\n+\tcmd.MarkPersistentFlagRequired(\"nodeid\")\n+\n+\tcmd.PersistentFlags().StringVar(&config.Endpoint, \"endpoint\", \"\", \"CSI endpoint\")\n+\n+\tcmd.PersistentFlags().StringVar(&config.RestURL, \"resturl\", \"\", \"glusterd2 rest endpoint\")\n+\n+\tcmd.PersistentFlags().StringVar(&config.RestUser, \"username\", \"glustercli\", \"glusterd2 user name\")\n+\n+\tcmd.PersistentFlags().StringVar(&config.RestSecret, \"restsecret\", \"\", \"glusterd2 rest user secret\")\n+\n+\tif err := cmd.Execute(); err != nil {\n+\t\tfmt.Fprintf(os.Stderr, \"%s\", err.Error())\n+\t\tos.Exit(1)\n+\t}\n+}\n+\n+func handle(config *utils.Config) {\n+\tep := os.Getenv(\"CSI_ENDPOINT\")","path":"cmd/glusterfs/main.go","position":50,"original_position":50,"commit_id":"68f19a35bc4001d66c0e6978b70a95cc7c44550a","original_commit_id":"394528925fa2597f5ef5d5c343ab0e61f8372ad4","user":{"login":"humblec","id":5001742,"node_id":"MDQ6VXNlcjUwMDE3NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5001742?v=4","gravatar_id":"","url":"https://api.github.com/users/humblec","html_url":"https://github.com/humblec","followers_url":"https://api.github.com/users/humblec/followers","following_url":"https://api.github.com/users/humblec/following{/other_user}","gists_url":"https://api.github.com/users/humblec/gists{/gist_id}","starred_url":"https://api.github.com/users/humblec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humblec/subscriptions","organizations_url":"https://api.github.com/users/humblec/orgs","repos_url":"https://api.github.com/users/humblec/repos","events_url":"https://api.github.com/users/humblec/events{/privacy}","received_events_url":"https://api.github.com/users/humblec/received_events","type":"User","site_admin":false},"body":"I think its fine, the var may be useful later. ","created_at":"2018-08-08T14:41:25Z","updated_at":"2018-08-08T14:41:25Z","html_url":"https://github.com/gluster/gluster-csi-driver/pull/11#discussion_r208607942","pull_request_url":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/comments/208607942"},"html":{"href":"https://github.com/gluster/gluster-csi-driver/pull/11#discussion_r208607942"},"pull_request":{"href":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/11"}},"in_reply_to_id":208183235},"pull_request":{"url":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/11","id":206208882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjA4ODgy","html_url":"https://github.com/gluster/gluster-csi-driver/pull/11","diff_url":"https://github.com/gluster/gluster-csi-driver/pull/11.diff","patch_url":"https://github.com/gluster/gluster-csi-driver/pull/11.patch","issue_url":"https://api.github.com/repos/gluster/gluster-csi-driver/issues/11","number":11,"state":"open","locked":false,"title":"This patch provides GlusterFS CSI driver which is compatible with GD2 (https://github.com/gluster/glusterd2).","user":{"login":"humblec","id":5001742,"node_id":"MDQ6VXNlcjUwMDE3NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5001742?v=4","gravatar_id":"","url":"https://api.github.com/users/humblec","html_url":"https://github.com/humblec","followers_url":"https://api.github.com/users/humblec/followers","following_url":"https://api.github.com/users/humblec/following{/other_user}","gists_url":"https://api.github.com/users/humblec/gists{/gist_id}","starred_url":"https://api.github.com/users/humblec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humblec/subscriptions","organizations_url":"https://api.github.com/users/humblec/orgs","repos_url":"https://api.github.com/users/humblec/repos","events_url":"https://api.github.com/users/humblec/events{/privacy}","received_events_url":"https://api.github.com/users/humblec/received_events","type":"User","site_admin":false},"body":"    This patch provides GlusterFS CSI driver which is compatible\r\n    with GD2 (https://github.com/gluster/glusterd2).\r\n    \r\n    This code is capable of volume provision, deletion, mount and unmount against\r\n    CSI spec v0.3.\r\n    The deployment artifacts are delivered by the docker container images.\r\n    The dir structure of code is carved out based on the discussions on\r\n    https://github.com/gluster/gluster-csi-driver/pull/1#issuecomment-370506170\r\n    \r\n    Demo url: https://asciinema.org/a/195024\r\n    \r\nSigned-off-by: Humble Chirammal <hchiramm@redhat.com>","created_at":"2018-08-04T20:36:22Z","updated_at":"2018-08-08T14:41:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95f602646d90fda936dc8c8d0e7f75adfc615dcc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1012324411,"node_id":"MDU6TGFiZWwxMDEyMzI0NDEx","url":"https://api.github.com/repos/gluster/gluster-csi-driver/labels/MVP%201.0","name":"MVP 1.0","color":"9fd664","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/11/commits","review_comments_url":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/11/comments","review_comment_url":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gluster/gluster-csi-driver/issues/11/comments","statuses_url":"https://api.github.com/repos/gluster/gluster-csi-driver/statuses/68f19a35bc4001d66c0e6978b70a95cc7c44550a","head":{"label":"humblec:glusterfs-csi-gd2","ref":"glusterfs-csi-gd2","sha":"68f19a35bc4001d66c0e6978b70a95cc7c44550a","user":{"login":"humblec","id":5001742,"node_id":"MDQ6VXNlcjUwMDE3NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5001742?v=4","gravatar_id":"","url":"https://api.github.com/users/humblec","html_url":"https://github.com/humblec","followers_url":"https://api.github.com/users/humblec/followers","following_url":"https://api.github.com/users/humblec/following{/other_user}","gists_url":"https://api.github.com/users/humblec/gists{/gist_id}","starred_url":"https://api.github.com/users/humblec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humblec/subscriptions","organizations_url":"https://api.github.com/users/humblec/orgs","repos_url":"https://api.github.com/users/humblec/repos","events_url":"https://api.github.com/users/humblec/events{/privacy}","received_events_url":"https://api.github.com/users/humblec/received_events","type":"User","site_admin":false},"repo":{"id":117535382,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1MzUzODI=","name":"gluster-csi-driver","full_name":"humblec/gluster-csi-driver","owner":{"login":"humblec","id":5001742,"node_id":"MDQ6VXNlcjUwMDE3NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5001742?v=4","gravatar_id":"","url":"https://api.github.com/users/humblec","html_url":"https://github.com/humblec","followers_url":"https://api.github.com/users/humblec/followers","following_url":"https://api.github.com/users/humblec/following{/other_user}","gists_url":"https://api.github.com/users/humblec/gists{/gist_id}","starred_url":"https://api.github.com/users/humblec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humblec/subscriptions","organizations_url":"https://api.github.com/users/humblec/orgs","repos_url":"https://api.github.com/users/humblec/repos","events_url":"https://api.github.com/users/humblec/events{/privacy}","received_events_url":"https://api.github.com/users/humblec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/humblec/gluster-csi-driver","description":"Gluster Container Storage Interface (CSI) driver","fork":true,"url":"https://api.github.com/repos/humblec/gluster-csi-driver","forks_url":"https://api.github.com/repos/humblec/gluster-csi-driver/forks","keys_url":"https://api.github.com/repos/humblec/gluster-csi-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/humblec/gluster-csi-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/humblec/gluster-csi-driver/teams","hooks_url":"https://api.github.com/repos/humblec/gluster-csi-driver/hooks","issue_events_url":"https://api.github.com/repos/humblec/gluster-csi-driver/issues/events{/number}","events_url":"https://api.github.com/repos/humblec/gluster-csi-driver/events","assignees_url":"https://api.github.com/repos/humblec/gluster-csi-driver/assignees{/user}","branches_url":"https://api.github.com/repos/humblec/gluster-csi-driver/branches{/branch}","tags_url":"https://api.github.com/repos/humblec/gluster-csi-driver/tags","blobs_url":"https://api.github.com/repos/humblec/gluster-csi-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/humblec/gluster-csi-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/humblec/gluster-csi-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/humblec/gluster-csi-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/humblec/gluster-csi-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/humblec/gluster-csi-driver/languages","stargazers_url":"https://api.github.com/repos/humblec/gluster-csi-driver/stargazers","contributors_url":"https://api.github.com/repos/humblec/gluster-csi-driver/contributors","subscribers_url":"https://api.github.com/repos/humblec/gluster-csi-driver/subscribers","subscription_url":"https://api.github.com/repos/humblec/gluster-csi-driver/subscription","commits_url":"https://api.github.com/repos/humblec/gluster-csi-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/humblec/gluster-csi-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/humblec/gluster-csi-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/humblec/gluster-csi-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/humblec/gluster-csi-driver/contents/{+path}","compare_url":"https://api.github.com/repos/humblec/gluster-csi-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/humblec/gluster-csi-driver/merges","archive_url":"https://api.github.com/repos/humblec/gluster-csi-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/humblec/gluster-csi-driver/downloads","issues_url":"https://api.github.com/repos/humblec/gluster-csi-driver/issues{/number}","pulls_url":"https://api.github.com/repos/humblec/gluster-csi-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/humblec/gluster-csi-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/humblec/gluster-csi-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/humblec/gluster-csi-driver/labels{/name}","releases_url":"https://api.github.com/repos/humblec/gluster-csi-driver/releases{/id}","deployments_url":"https://api.github.com/repos/humblec/gluster-csi-driver/deployments","created_at":"2018-01-15T11:10:30Z","updated_at":"2018-08-04T20:29:23Z","pushed_at":"2018-08-08T14:39:16Z","git_url":"git://github.com/humblec/gluster-csi-driver.git","ssh_url":"git@github.com:humblec/gluster-csi-driver.git","clone_url":"https://github.com/humblec/gluster-csi-driver.git","svn_url":"https://github.com/humblec/gluster-csi-driver","homepage":"","size":47,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gluster:master","ref":"master","sha":"16ca20449adda62efef759da9c83ed1734d30a2c","user":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"repo":{"id":117171629,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxNzE2Mjk=","name":"gluster-csi-driver","full_name":"gluster/gluster-csi-driver","owner":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gluster/gluster-csi-driver","description":"Gluster Container Storage Interface (CSI) driver","fork":false,"url":"https://api.github.com/repos/gluster/gluster-csi-driver","forks_url":"https://api.github.com/repos/gluster/gluster-csi-driver/forks","keys_url":"https://api.github.com/repos/gluster/gluster-csi-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluster/gluster-csi-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluster/gluster-csi-driver/teams","hooks_url":"https://api.github.com/repos/gluster/gluster-csi-driver/hooks","issue_events_url":"https://api.github.com/repos/gluster/gluster-csi-driver/issues/events{/number}","events_url":"https://api.github.com/repos/gluster/gluster-csi-driver/events","assignees_url":"https://api.github.com/repos/gluster/gluster-csi-driver/assignees{/user}","branches_url":"https://api.github.com/repos/gluster/gluster-csi-driver/branches{/branch}","tags_url":"https://api.github.com/repos/gluster/gluster-csi-driver/tags","blobs_url":"https://api.github.com/repos/gluster/gluster-csi-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluster/gluster-csi-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluster/gluster-csi-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluster/gluster-csi-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluster/gluster-csi-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/gluster/gluster-csi-driver/languages","stargazers_url":"https://api.github.com/repos/gluster/gluster-csi-driver/stargazers","contributors_url":"https://api.github.com/repos/gluster/gluster-csi-driver/contributors","subscribers_url":"https://api.github.com/repos/gluster/gluster-csi-driver/subscribers","subscription_url":"https://api.github.com/repos/gluster/gluster-csi-driver/subscription","commits_url":"https://api.github.com/repos/gluster/gluster-csi-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluster/gluster-csi-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluster/gluster-csi-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluster/gluster-csi-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluster/gluster-csi-driver/contents/{+path}","compare_url":"https://api.github.com/repos/gluster/gluster-csi-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluster/gluster-csi-driver/merges","archive_url":"https://api.github.com/repos/gluster/gluster-csi-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluster/gluster-csi-driver/downloads","issues_url":"https://api.github.com/repos/gluster/gluster-csi-driver/issues{/number}","pulls_url":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/gluster/gluster-csi-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/gluster/gluster-csi-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluster/gluster-csi-driver/labels{/name}","releases_url":"https://api.github.com/repos/gluster/gluster-csi-driver/releases{/id}","deployments_url":"https://api.github.com/repos/gluster/gluster-csi-driver/deployments","created_at":"2018-01-12T00:42:24Z","updated_at":"2018-08-06T14:53:47Z","pushed_at":"2018-08-08T14:39:18Z","git_url":"git://github.com/gluster/gluster-csi-driver.git","ssh_url":"git@github.com:gluster/gluster-csi-driver.git","clone_url":"https://github.com/gluster/gluster-csi-driver.git","svn_url":"https://github.com/gluster/gluster-csi-driver","homepage":"","size":0,"stargazers_count":7,"watchers_count":7,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":7,"open_issues":11,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/11"},"html":{"href":"https://github.com/gluster/gluster-csi-driver/pull/11"},"issue":{"href":"https://api.github.com/repos/gluster/gluster-csi-driver/issues/11"},"comments":{"href":"https://api.github.com/repos/gluster/gluster-csi-driver/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gluster/gluster-csi-driver/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/gluster/gluster-csi-driver/statuses/68f19a35bc4001d66c0e6978b70a95cc7c44550a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"humblec"}}