{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/10380","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/10380/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/10380/comments","events_url":"https://api.github.com/repos/istio/istio/issues/10380/events","html_url":"https://github.com/istio/istio/issues/10380","id":389468200,"node_id":"MDU6SXNzdWUzODk0NjgyMDA=","number":10380,"title":"Remove the hardcoded sidecar template for `istioctl kube-inject`","user":{"login":"incfly","id":1661831,"node_id":"MDQ6VXNlcjE2NjE4MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1661831?v=4","gravatar_id":"","url":"https://api.github.com/users/incfly","html_url":"https://github.com/incfly","followers_url":"https://api.github.com/users/incfly/followers","following_url":"https://api.github.com/users/incfly/following{/other_user}","gists_url":"https://api.github.com/users/incfly/gists{/gist_id}","starred_url":"https://api.github.com/users/incfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incfly/subscriptions","organizations_url":"https://api.github.com/users/incfly/orgs","repos_url":"https://api.github.com/users/incfly/repos","events_url":"https://api.github.com/users/incfly/events{/privacy}","received_events_url":"https://api.github.com/users/incfly/received_events","type":"User","site_admin":false},"labels":[{"id":484582416,"node_id":"MDU6TGFiZWw0ODQ1ODI0MTY=","url":"https://api.github.com/repos/istio/istio/labels/community/help%20wanted","name":"community/help wanted","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-10T20:14:49Z","updated_at":"2018-12-14T03:40:27Z","closed_at":null,"author_association":"MEMBER","body":"Currently `istioctl` has the option to use a local hard coded template for kube-inject [1]. This is only for backward comparability when we switch to configmap stored injector configmap. Now it becomes a maintaining overhead to modify two sidecar templates, we need to remove the hardcoded one and only rely on the configmap.\r\n\r\nThis might need to update some test to read input from sidecar template from `install/kubernetes/helm`. \r\n\r\n[1] https://github.com/istio/istio/blob/master/pilot/pkg/kube/inject/mesh.go#L22"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/447203109","html_url":"https://github.com/istio/istio/issues/10380#issuecomment-447203109","issue_url":"https://api.github.com/repos/istio/istio/issues/10380","id":447203109,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzIwMzEwOQ==","user":{"login":"mathspanda","id":8100956,"node_id":"MDQ6VXNlcjgxMDA5NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/8100956?v=4","gravatar_id":"","url":"https://api.github.com/users/mathspanda","html_url":"https://github.com/mathspanda","followers_url":"https://api.github.com/users/mathspanda/followers","following_url":"https://api.github.com/users/mathspanda/following{/other_user}","gists_url":"https://api.github.com/users/mathspanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mathspanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathspanda/subscriptions","organizations_url":"https://api.github.com/users/mathspanda/orgs","repos_url":"https://api.github.com/users/mathspanda/repos","events_url":"https://api.github.com/users/mathspanda/events{/privacy}","received_events_url":"https://api.github.com/users/mathspanda/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T03:40:27Z","updated_at":"2018-12-14T03:40:27Z","author_association":"NONE","body":"Is there anyone working on this? If not, i am happy to work on it as my first issue."}}
{"actor":{"display_login":"mathspanda"}}