{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/203454423","pull_request_review_id":138053727,"id":203454423,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQ1NDQyMw==","diff_hunk":"@@ -433,4 +436,19 @@ public boolean isRegionAwarenessEnabled() {\n     public String getSchedulerIP() {\n         return envStore.getRequired(LIBPROCESS_IP_ENVVAR);\n     }\n+\n+    public JSONObject getBuildInfo() {\n+        JSONObject jsonObject = new JSONObject();\n+        jsonObject.put(PACKAGE_NAME_ENV, getPackageName());\n+        jsonObject.put(PACKAGE_VERSION_ENV, getPackageVersion());\n+        jsonObject.put(PACKAGE_BUILD_TIME_EPOCH_MS_ENV, Instant.ofEpochMilli(getPackageBuildTimeMs()));\n+        for (Field f : SDKBuildInfo.class.getDeclaredFields()) {","path":"sdk/scheduler/src/main/java/com/mesosphere/sdk/scheduler/SchedulerConfig.java","position":68,"original_position":68,"commit_id":"adc769a38f373a6140af3f1d64c236be48ea2b32","original_commit_id":"adc769a38f373a6140af3f1d64c236be48ea2b32","user":{"login":"nickbp","id":35933,"node_id":"MDQ6VXNlcjM1OTMz","avatar_url":"https://avatars2.githubusercontent.com/u/35933?v=4","gravatar_id":"","url":"https://api.github.com/users/nickbp","html_url":"https://github.com/nickbp","followers_url":"https://api.github.com/users/nickbp/followers","following_url":"https://api.github.com/users/nickbp/following{/other_user}","gists_url":"https://api.github.com/users/nickbp/gists{/gist_id}","starred_url":"https://api.github.com/users/nickbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickbp/subscriptions","organizations_url":"https://api.github.com/users/nickbp/orgs","repos_url":"https://api.github.com/users/nickbp/repos","events_url":"https://api.github.com/users/nickbp/events{/privacy}","received_events_url":"https://api.github.com/users/nickbp/received_events","type":"User","site_admin":false},"body":"Rather than using reflection, I think it's fine to just statically define some names here. I could see someone being suprised by these names changing if SDKBuildInfo members are renamed.","created_at":"2018-07-18T16:55:28Z","updated_at":"2018-07-18T16:55:30Z","html_url":"https://github.com/mesosphere/dcos-commons/pull/2573#discussion_r203454423","pull_request_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2573","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/203454423"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/2573#discussion_r203454423"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2573"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2573","id":199856702,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODU2NzAy","html_url":"https://github.com/mesosphere/dcos-commons/pull/2573","diff_url":"https://github.com/mesosphere/dcos-commons/pull/2573.diff","patch_url":"https://github.com/mesosphere/dcos-commons/pull/2573.patch","issue_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2573","number":2573,"state":"open","locked":false,"title":"DCOS-38544 Add mono to multi zk data migration","user":{"login":"takirala","id":2296947,"node_id":"MDQ6VXNlcjIyOTY5NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2296947?v=4","gravatar_id":"","url":"https://api.github.com/users/takirala","html_url":"https://github.com/takirala","followers_url":"https://api.github.com/users/takirala/followers","following_url":"https://api.github.com/users/takirala/following{/other_user}","gists_url":"https://api.github.com/users/takirala/gists{/gist_id}","starred_url":"https://api.github.com/users/takirala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takirala/subscriptions","organizations_url":"https://api.github.com/users/takirala/orgs","repos_url":"https://api.github.com/users/takirala/repos","events_url":"https://api.github.com/users/takirala/events{/privacy}","received_events_url":"https://api.github.com/users/takirala/received_events","type":"User","site_admin":false},"body":"Address [DCOS-38544](https://jira.mesosphere.com/browse/DCOS-38544)","created_at":"2018-07-06T22:03:59Z","updated_at":"2018-07-18T16:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df0179bd8929f6708ad2c2f85d2105bdeeaca0fa","assignee":{"login":"takirala","id":2296947,"node_id":"MDQ6VXNlcjIyOTY5NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2296947?v=4","gravatar_id":"","url":"https://api.github.com/users/takirala","html_url":"https://github.com/takirala","followers_url":"https://api.github.com/users/takirala/followers","following_url":"https://api.github.com/users/takirala/following{/other_user}","gists_url":"https://api.github.com/users/takirala/gists{/gist_id}","starred_url":"https://api.github.com/users/takirala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takirala/subscriptions","organizations_url":"https://api.github.com/users/takirala/orgs","repos_url":"https://api.github.com/users/takirala/repos","events_url":"https://api.github.com/users/takirala/events{/privacy}","received_events_url":"https://api.github.com/users/takirala/received_events","type":"User","site_admin":false},"assignees":[{"login":"takirala","id":2296947,"node_id":"MDQ6VXNlcjIyOTY5NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2296947?v=4","gravatar_id":"","url":"https://api.github.com/users/takirala","html_url":"https://github.com/takirala","followers_url":"https://api.github.com/users/takirala/followers","following_url":"https://api.github.com/users/takirala/following{/other_user}","gists_url":"https://api.github.com/users/takirala/gists{/gist_id}","starred_url":"https://api.github.com/users/takirala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takirala/subscriptions","organizations_url":"https://api.github.com/users/takirala/orgs","repos_url":"https://api.github.com/users/takirala/repos","events_url":"https://api.github.com/users/takirala/events{/privacy}","received_events_url":"https://api.github.com/users/takirala/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jeid64","id":1271427,"node_id":"MDQ6VXNlcjEyNzE0Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1271427?v=4","gravatar_id":"","url":"https://api.github.com/users/jeid64","html_url":"https://github.com/jeid64","followers_url":"https://api.github.com/users/jeid64/followers","following_url":"https://api.github.com/users/jeid64/following{/other_user}","gists_url":"https://api.github.com/users/jeid64/gists{/gist_id}","starred_url":"https://api.github.com/users/jeid64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeid64/subscriptions","organizations_url":"https://api.github.com/users/jeid64/orgs","repos_url":"https://api.github.com/users/jeid64/repos","events_url":"https://api.github.com/users/jeid64/events{/privacy}","received_events_url":"https://api.github.com/users/jeid64/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":649058275,"node_id":"MDU6TGFiZWw2NDkwNTgyNzU=","url":"https://api.github.com/repos/mesosphere/dcos-commons/labels/ready%20for%20review","name":"ready for review","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2573/commits","review_comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2573/comments","review_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2573/comments","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/adc769a38f373a6140af3f1d64c236be48ea2b32","head":{"label":"mesosphere:add-migration-tooling","ref":"add-migration-tooling","sha":"adc769a38f373a6140af3f1d64c236be48ea2b32","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI4NjQ5Nw==","name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2018-07-16T20:03:23Z","pushed_at":"2018-07-18T09:36:54Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":62914,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":145,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":145,"open_issues":70,"watchers":129,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"d812e433c62ee76c2e9154423b2a3f51e01f1ccb","user":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI4NjQ5Nw==","name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTg1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2018-07-16T20:03:23Z","pushed_at":"2018-07-18T09:36:54Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":62914,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":145,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":145,"open_issues":70,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2573"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/2573"},"issue":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2573"},"comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2573/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2573/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2573/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/adc769a38f373a6140af3f1d64c236be48ea2b32"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nickbp"}}