{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/folly/issues/812","repository_url":"https://api.github.com/repos/facebook/folly","labels_url":"https://api.github.com/repos/facebook/folly/issues/812/labels{/name}","comments_url":"https://api.github.com/repos/facebook/folly/issues/812/comments","events_url":"https://api.github.com/repos/facebook/folly/issues/812/events","html_url":"https://github.com/facebook/folly/pull/812","id":310258619,"number":812,"title":"Fix gcc7 error in ExceptionInfo constructor","user":{"login":"tudor","id":125148,"avatar_url":"https://avatars0.githubusercontent.com/u/125148?v=4","gravatar_id":"","url":"https://api.github.com/users/tudor","html_url":"https://github.com/tudor","followers_url":"https://api.github.com/users/tudor/followers","following_url":"https://api.github.com/users/tudor/following{/other_user}","gists_url":"https://api.github.com/users/tudor/gists{/gist_id}","starred_url":"https://api.github.com/users/tudor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tudor/subscriptions","organizations_url":"https://api.github.com/users/tudor/orgs","repos_url":"https://api.github.com/users/tudor/repos","events_url":"https://api.github.com/users/tudor/events{/privacy}","received_events_url":"https://api.github.com/users/tudor/received_events","type":"User","site_admin":false},"labels":[{"id":196858198,"url":"https://api.github.com/repos/facebook/folly/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-31T17:48:25Z","updated_at":"2018-03-31T18:16:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/facebook/folly/pulls/812","html_url":"https://github.com/facebook/folly/pull/812","diff_url":"https://github.com/facebook/folly/pull/812.diff","patch_url":"https://github.com/facebook/folly/pull/812.patch"},"body":"When trying to compile `folly/experimental/exception_tracer` with gcc-7.2, I get the following error:\r\n\r\n```\r\nExceptionCounterLib.cpp: In instantiation of '{anonymous}::throwHandler(void*, std::type_info*, void (*)(void*))::<lambda(auto:9&)> [with auto:9 = std::unordered_map<long unsigned int, folly::exception_tracer::ExceptionStats>]':\r\n../../../folly/Synchronized.h:162:20:   required from 'auto folly::SynchronizedBase<Subclass, (folly::detail::MutexLevel)1>::withWLock(Function&&) [with Function = {anonymous}::throwHandler(void*, std::type_info*, void (*)(void*))::<lambda(auto:9&)>; Subclass = folly::Synchronized<std::unordered_map<long unsigned int, folly::exception_tracer::ExceptionStats>, folly::RWSpinLock>]'\r\nExceptionCounterLib.cpp:132:4:   required from here\r\nExceptionCounterLib.cpp:127:21: error: uninitialized variable 'info' in 'constexpr' function\r\n       ExceptionInfo info;\r\n                     ^~~~\r\nIn file included from ../../../folly/experimental/exception_tracer/ExceptionCounterLib.h:22:0,\r\n                 from ExceptionCounterLib.cpp:16:\r\n../../../folly/experimental/exception_tracer/ExceptionTracer.h:30:8: note: 'struct folly::exception_tracer::ExceptionInfo' has no user-provided default constructor\r\n struct ExceptionInfo {\r\n        ^~~~~~~~~~~~~\r\n../../../folly/experimental/exception_tracer/ExceptionTracer.h:31:25: note: and the implicitly-defined constructor does not initialize 'const std::type_info* folly::exception_tracer::ExceptionInfo::type'\r\n   const std::type_info* type;\r\n                         ^~~~\r\n```\r\n\r\nFixed by initializing `ExceptionInfo::type`.\r\n\r\nCompiling with gcc 7.2 now works."},"comment":{"url":"https://api.github.com/repos/facebook/folly/issues/comments/377712648","html_url":"https://github.com/facebook/folly/pull/812#issuecomment-377712648","issue_url":"https://api.github.com/repos/facebook/folly/issues/812","id":377712648,"user":{"login":"tudor","id":125148,"avatar_url":"https://avatars0.githubusercontent.com/u/125148?v=4","gravatar_id":"","url":"https://api.github.com/users/tudor","html_url":"https://github.com/tudor","followers_url":"https://api.github.com/users/tudor/followers","following_url":"https://api.github.com/users/tudor/following{/other_user}","gists_url":"https://api.github.com/users/tudor/gists{/gist_id}","starred_url":"https://api.github.com/users/tudor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tudor/subscriptions","organizations_url":"https://api.github.com/users/tudor/orgs","repos_url":"https://api.github.com/users/tudor/repos","events_url":"https://api.github.com/users/tudor/events{/privacy}","received_events_url":"https://api.github.com/users/tudor/received_events","type":"User","site_admin":false},"created_at":"2018-03-31T18:16:55Z","updated_at":"2018-03-31T18:16:55Z","author_association":"CONTRIBUTOR","body":"FYI, I was also compiling with `-std=gnu++1z`, which now works."}}
{"actor":{"display_login":"tudor"}}