{"action":"created","issue":{"url":"https://api.github.com/repos/yarnpkg/yarn/issues/5825","repository_url":"https://api.github.com/repos/yarnpkg/yarn","labels_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5825/labels{/name}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5825/comments","events_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5825/events","html_url":"https://github.com/yarnpkg/yarn/pull/5825","id":323344838,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4MjI1ODMx","number":5825,"title":"fix(config): allow .npmrc config to supersede yarn defaults","user":{"login":"thoov","id":166909,"node_id":"MDQ6VXNlcjE2NjkwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/166909?v=4","gravatar_id":"","url":"https://api.github.com/users/thoov","html_url":"https://github.com/thoov","followers_url":"https://api.github.com/users/thoov/followers","following_url":"https://api.github.com/users/thoov/following{/other_user}","gists_url":"https://api.github.com/users/thoov/gists{/gist_id}","starred_url":"https://api.github.com/users/thoov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoov/subscriptions","organizations_url":"https://api.github.com/users/thoov/orgs","repos_url":"https://api.github.com/users/thoov/repos","events_url":"https://api.github.com/users/thoov/events{/privacy}","received_events_url":"https://api.github.com/users/thoov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"imsnif","id":795598,"node_id":"MDQ6VXNlcjc5NTU5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/795598?v=4","gravatar_id":"","url":"https://api.github.com/users/imsnif","html_url":"https://github.com/imsnif","followers_url":"https://api.github.com/users/imsnif/followers","following_url":"https://api.github.com/users/imsnif/following{/other_user}","gists_url":"https://api.github.com/users/imsnif/gists{/gist_id}","starred_url":"https://api.github.com/users/imsnif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imsnif/subscriptions","organizations_url":"https://api.github.com/users/imsnif/orgs","repos_url":"https://api.github.com/users/imsnif/repos","events_url":"https://api.github.com/users/imsnif/events{/privacy}","received_events_url":"https://api.github.com/users/imsnif/received_events","type":"User","site_admin":false},"assignees":[{"login":"imsnif","id":795598,"node_id":"MDQ6VXNlcjc5NTU5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/795598?v=4","gravatar_id":"","url":"https://api.github.com/users/imsnif","html_url":"https://github.com/imsnif","followers_url":"https://api.github.com/users/imsnif/followers","following_url":"https://api.github.com/users/imsnif/following{/other_user}","gists_url":"https://api.github.com/users/imsnif/gists{/gist_id}","starred_url":"https://api.github.com/users/imsnif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imsnif/subscriptions","organizations_url":"https://api.github.com/users/imsnif/orgs","repos_url":"https://api.github.com/users/imsnif/repos","events_url":"https://api.github.com/users/imsnif/events{/privacy}","received_events_url":"https://api.github.com/users/imsnif/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-05-15T19:06:19Z","updated_at":"2018-05-31T18:12:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5825","html_url":"https://github.com/yarnpkg/yarn/pull/5825","diff_url":"https://github.com/yarnpkg/yarn/pull/5825.diff","patch_url":"https://github.com/yarnpkg/yarn/pull/5825.patch"},"body":"**Summary**\r\n\r\nRunning `yarn config get registry` within a project that contains a .npmrc which overrides the registry config key is not respected and instead the default yarn registry option is returned. Conceptually if you look at the code for `getOption` it first checks to see if the config exists within yarn and if not found it will check for that config within npm's config. However, the problem arises as the config property that is built up gets merged with yarns default values. This means that any config key that exists as a yarn default cannot be overwritten via .npmrc. This change differentiates yarn default configs and configs specified via .yarnrc. This allows the proper config fall back.\r\n\r\n**Test plan**\r\n\r\n* mkdir /tmp/foobar\r\n* cd /tmp/foobar\r\n* echo 'registry=http://example.com' > .npmrc\r\n* yarn config get registry\r\n\r\nReturns `https://registry.yarnpkg.com/`\r\n\r\n* yarn-local config get registry\r\n\r\nReturns `http://example.com/`"},"comment":{"url":"https://api.github.com/repos/yarnpkg/yarn/issues/comments/393624258","html_url":"https://github.com/yarnpkg/yarn/pull/5825#issuecomment-393624258","issue_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5825","id":393624258,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzYyNDI1OA==","user":{"login":"arcanis","id":1037931,"node_id":"MDQ6VXNlcjEwMzc5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1037931?v=4","gravatar_id":"","url":"https://api.github.com/users/arcanis","html_url":"https://github.com/arcanis","followers_url":"https://api.github.com/users/arcanis/followers","following_url":"https://api.github.com/users/arcanis/following{/other_user}","gists_url":"https://api.github.com/users/arcanis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcanis/subscriptions","organizations_url":"https://api.github.com/users/arcanis/orgs","repos_url":"https://api.github.com/users/arcanis/repos","events_url":"https://api.github.com/users/arcanis/events{/privacy}","received_events_url":"https://api.github.com/users/arcanis/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T18:12:03Z","updated_at":"2018-05-31T18:12:03Z","author_association":"MEMBER","body":"Yeah, I think it would be a good thing. I wonder if we should whitelist the options and only keep the ones that we are sure are safe, since they might have different type or interpretation depending on the package manager."}}
{"actor":{"display_login":"arcanis"}}