{"action":"created","issue":{"url":"https://api.github.com/repos/jneen/parsimmon/issues/228","repository_url":"https://api.github.com/repos/jneen/parsimmon","labels_url":"https://api.github.com/repos/jneen/parsimmon/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/jneen/parsimmon/issues/228/comments","events_url":"https://api.github.com/repos/jneen/parsimmon/issues/228/events","html_url":"https://github.com/jneen/parsimmon/pull/228","id":303232933,"number":228,"title":"Non-byte aligned primitives.","user":{"login":"theqabalist","id":2925113,"avatar_url":"https://avatars3.githubusercontent.com/u/2925113?v=4","gravatar_id":"","url":"https://api.github.com/users/theqabalist","html_url":"https://github.com/theqabalist","followers_url":"https://api.github.com/users/theqabalist/followers","following_url":"https://api.github.com/users/theqabalist/following{/other_user}","gists_url":"https://api.github.com/users/theqabalist/gists{/gist_id}","starred_url":"https://api.github.com/users/theqabalist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theqabalist/subscriptions","organizations_url":"https://api.github.com/users/theqabalist/orgs","repos_url":"https://api.github.com/users/theqabalist/repos","events_url":"https://api.github.com/users/theqabalist/events{/privacy}","received_events_url":"https://api.github.com/users/theqabalist/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-03-07T19:40:56Z","updated_at":"2018-03-08T23:58:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jneen/parsimmon/pulls/228","html_url":"https://github.com/jneen/parsimmon/pull/228","diff_url":"https://github.com/jneen/parsimmon/pull/228.diff","patch_url":"https://github.com/jneen/parsimmon/pull/228.patch"},"body":"Opening this PR before I begin work so that discussion can reflect over the life of the PR. #224 "},"comment":{"url":"https://api.github.com/repos/jneen/parsimmon/issues/comments/371666804","html_url":"https://github.com/jneen/parsimmon/pull/228#issuecomment-371666804","issue_url":"https://api.github.com/repos/jneen/parsimmon/issues/228","id":371666804,"user":{"login":"wavebeem","id":176815,"avatar_url":"https://avatars1.githubusercontent.com/u/176815?v=4","gravatar_id":"","url":"https://api.github.com/users/wavebeem","html_url":"https://github.com/wavebeem","followers_url":"https://api.github.com/users/wavebeem/followers","following_url":"https://api.github.com/users/wavebeem/following{/other_user}","gists_url":"https://api.github.com/users/wavebeem/gists{/gist_id}","starred_url":"https://api.github.com/users/wavebeem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wavebeem/subscriptions","organizations_url":"https://api.github.com/users/wavebeem/orgs","repos_url":"https://api.github.com/users/wavebeem/repos","events_url":"https://api.github.com/users/wavebeem/events{/privacy}","received_events_url":"https://api.github.com/users/wavebeem/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T23:58:58Z","updated_at":"2018-03-08T23:58:58Z","author_association":"COLLABORATOR","body":"I really like the idea of putting the new buffer utilities into a buffer namespace!\r\n\r\nI think `Binary` might be a better namespace than `buffers` though.\r\n\r\nAlso, we should check for buffer support when constructing the API.\r\n\r\n```js\r\nfunction noBufferOops() {\r\n  throw new Error(\r\n    \"Buffer global does not exist; please consider using https://github.com/feross/buffer if you are running Parsimmon in a browser\"\r\n  );\r\n}\r\nif (hasBuffer) {\r\n  Parsimmon.Binary = {\r\n    bitSeq: bitSeq,\r\n    bitSeqObj: bitSeqObj,\r\n    byte: byte\r\n  };\r\n} else {\r\n  Parsimmon.Binary = {\r\n    bitSeq: noBufferOops,\r\n    bitSeqObj: noBufferOops,\r\n    byte: noBufferOops\r\n  };\r\n}\r\n```\r\n\r\nThanks again for your work on this so far!"}}
{"actor":{"display_login":"wavebeem"}}