{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/198317775","pull_request_review_id":132226952,"id":198317775,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODMxNzc3NQ==","diff_hunk":"@@ -39,22 +39,100 @@ import (\n )\n \n const (\n-\t// RbacFilterName is the name of the RBAC filter in envoy.\n-\tRbacFilterName = \"envoy.filters.http.rbac\"\n-\n-\tsourceIP        = \"source.ip\"\n-\tsourceService   = \"source.service\"\n-\tdestinationIP   = \"destination.ip\"\n-\tdestinationPort = \"destination.port\"\n-\tuserHeader      = \":user\"\n-\tmethodHeader    = \":method\"\n-\tpathHeader      = \":path\"\n-\t//TODO(yangminzhu): Update the key after the final header name of service is decided.\n-\tserviceHeader       = \":service\"\n-\trequestHeaderPrefix = \"request.header[\"\n-\trequestHeaderSuffix = \"]\"\n+\t// rbacFilterName is the name of the RBAC filter in envoy.\n+\trbacFilterName = \"envoy.filters.http.rbac\"\n+\n+\t// attributes that could be used in a ServiceRoleBinding property.\n+\tattrSrcIP     = \"source.ip\"     // supports both single ip and cidr, e.g. \"10.1.2.3\" or \"10.1.0.0/16\".\n+\tattrSrcHeader = \"source.header\" // header name is surrounded by brackets, e.g. \"source.header[User-Agent]\".\n+\n+\t// attributes that could be used in a ServiceRole constraint.\n+\tattrDestIP        = \"destination.ip\"        // supports both single ip and cidr, e.g. \"10.1.2.3\" or \"10.1.0.0/16\".\n+\tattrDestPort      = \"destination.port\"      // must be in the range [0, 65535].\n+\tattrDestHeader    = \"destination.header\"    // header name is surrounded by brackets, e.g. \"destination.header[User-Agent]\".","path":"pilot/pkg/networking/plugin/authz/rbac.go","position":28,"original_position":28,"commit_id":"dc59a65c12406db9ae67e1794e3c6f77b8eadb56","original_commit_id":"dc59a65c12406db9ae67e1794e3c6f77b8eadb56","user":{"login":"liminw","id":20001914,"node_id":"MDQ6VXNlcjIwMDAxOTE0","avatar_url":"https://avatars3.githubusercontent.com/u/20001914?v=4","gravatar_id":"","url":"https://api.github.com/users/liminw","html_url":"https://github.com/liminw","followers_url":"https://api.github.com/users/liminw/followers","following_url":"https://api.github.com/users/liminw/following{/other_user}","gists_url":"https://api.github.com/users/liminw/gists{/gist_id}","starred_url":"https://api.github.com/users/liminw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liminw/subscriptions","organizations_url":"https://api.github.com/users/liminw/orgs","repos_url":"https://api.github.com/users/liminw/repos","events_url":"https://api.github.com/users/liminw/events{/privacy}","received_events_url":"https://api.github.com/users/liminw/received_events","type":"User","site_admin":false},"body":"destination.header => request.headers","created_at":"2018-06-26T22:30:58Z","updated_at":"2018-06-26T22:54:10Z","html_url":"https://github.com/istio/istio/pull/6554#discussion_r198317775","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/6554","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/198317775"},"html":{"href":"https://github.com/istio/istio/pull/6554#discussion_r198317775"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/6554"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/6554","id":196864767,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODY0NzY3","html_url":"https://github.com/istio/istio/pull/6554","diff_url":"https://github.com/istio/istio/pull/6554.diff","patch_url":"https://github.com/istio/istio/pull/6554.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/6554","number":6554,"state":"open","locked":false,"title":"authz: add attributes support in ServiceRole","user":{"login":"yangminzhu","id":2189160,"node_id":"MDQ6VXNlcjIxODkxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2189160?v=4","gravatar_id":"","url":"https://api.github.com/users/yangminzhu","html_url":"https://github.com/yangminzhu","followers_url":"https://api.github.com/users/yangminzhu/followers","following_url":"https://api.github.com/users/yangminzhu/following{/other_user}","gists_url":"https://api.github.com/users/yangminzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yangminzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangminzhu/subscriptions","organizations_url":"https://api.github.com/users/yangminzhu/orgs","repos_url":"https://api.github.com/users/yangminzhu/repos","events_url":"https://api.github.com/users/yangminzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yangminzhu/received_events","type":"User","site_admin":false},"body":"See #6377","created_at":"2018-06-22T23:19:57Z","updated_at":"2018-06-26T22:54:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"311a6a3d562042cdeec9a5a84b319e830c0ea600","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":905361383,"node_id":"MDU6TGFiZWw5MDUzNjEzODM=","url":"https://api.github.com/repos/istio/istio/labels/area/security/aaa","name":"area/security/aaa","color":"0e8a16","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/6554/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/6554/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/6554/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/dc59a65c12406db9ae67e1794e3c6f77b8eadb56","head":{"label":"yangminzhu:dest_attr","ref":"dest_attr","sha":"dc59a65c12406db9ae67e1794e3c6f77b8eadb56","user":{"login":"yangminzhu","id":2189160,"node_id":"MDQ6VXNlcjIxODkxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2189160?v=4","gravatar_id":"","url":"https://api.github.com/users/yangminzhu","html_url":"https://github.com/yangminzhu","followers_url":"https://api.github.com/users/yangminzhu/followers","following_url":"https://api.github.com/users/yangminzhu/following{/other_user}","gists_url":"https://api.github.com/users/yangminzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yangminzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangminzhu/subscriptions","organizations_url":"https://api.github.com/users/yangminzhu/orgs","repos_url":"https://api.github.com/users/yangminzhu/repos","events_url":"https://api.github.com/users/yangminzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yangminzhu/received_events","type":"User","site_admin":false},"repo":{"id":122268122,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIyNjgxMjI=","name":"istio","full_name":"yangminzhu/istio","owner":{"login":"yangminzhu","id":2189160,"node_id":"MDQ6VXNlcjIxODkxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2189160?v=4","gravatar_id":"","url":"https://api.github.com/users/yangminzhu","html_url":"https://github.com/yangminzhu","followers_url":"https://api.github.com/users/yangminzhu/followers","following_url":"https://api.github.com/users/yangminzhu/following{/other_user}","gists_url":"https://api.github.com/users/yangminzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yangminzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangminzhu/subscriptions","organizations_url":"https://api.github.com/users/yangminzhu/orgs","repos_url":"https://api.github.com/users/yangminzhu/repos","events_url":"https://api.github.com/users/yangminzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yangminzhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yangminzhu/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/yangminzhu/istio","forks_url":"https://api.github.com/repos/yangminzhu/istio/forks","keys_url":"https://api.github.com/repos/yangminzhu/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yangminzhu/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yangminzhu/istio/teams","hooks_url":"https://api.github.com/repos/yangminzhu/istio/hooks","issue_events_url":"https://api.github.com/repos/yangminzhu/istio/issues/events{/number}","events_url":"https://api.github.com/repos/yangminzhu/istio/events","assignees_url":"https://api.github.com/repos/yangminzhu/istio/assignees{/user}","branches_url":"https://api.github.com/repos/yangminzhu/istio/branches{/branch}","tags_url":"https://api.github.com/repos/yangminzhu/istio/tags","blobs_url":"https://api.github.com/repos/yangminzhu/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yangminzhu/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yangminzhu/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/yangminzhu/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yangminzhu/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/yangminzhu/istio/languages","stargazers_url":"https://api.github.com/repos/yangminzhu/istio/stargazers","contributors_url":"https://api.github.com/repos/yangminzhu/istio/contributors","subscribers_url":"https://api.github.com/repos/yangminzhu/istio/subscribers","subscription_url":"https://api.github.com/repos/yangminzhu/istio/subscription","commits_url":"https://api.github.com/repos/yangminzhu/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/yangminzhu/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/yangminzhu/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/yangminzhu/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/yangminzhu/istio/contents/{+path}","compare_url":"https://api.github.com/repos/yangminzhu/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yangminzhu/istio/merges","archive_url":"https://api.github.com/repos/yangminzhu/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yangminzhu/istio/downloads","issues_url":"https://api.github.com/repos/yangminzhu/istio/issues{/number}","pulls_url":"https://api.github.com/repos/yangminzhu/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/yangminzhu/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/yangminzhu/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yangminzhu/istio/labels{/name}","releases_url":"https://api.github.com/repos/yangminzhu/istio/releases{/id}","deployments_url":"https://api.github.com/repos/yangminzhu/istio/deployments","created_at":"2018-02-20T23:07:28Z","updated_at":"2018-02-20T23:07:34Z","pushed_at":"2018-06-26T19:18:29Z","git_url":"git://github.com/yangminzhu/istio.git","ssh_url":"git@github.com:yangminzhu/istio.git","clone_url":"https://github.com/yangminzhu/istio.git","svn_url":"https://github.com/yangminzhu/istio","homepage":"https://istio.io","size":39522,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"6ae8a4abe3e93b56a5170312bb3ac979e9a68401","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-06-26T22:33:51Z","pushed_at":"2018-06-26T22:53:19Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":39986,"stargazers_count":8882,"watchers_count":8882,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1220,"mirror_url":null,"archived":false,"open_issues_count":799,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1220,"open_issues":799,"watchers":8882,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/6554"},"html":{"href":"https://github.com/istio/istio/pull/6554"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/6554"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/6554/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/6554/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/6554/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/dc59a65c12406db9ae67e1794e3c6f77b8eadb56"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"liminw"}}