{"action":"opened","number":2750,"pull_request":{"url":"https://api.github.com/repos/expo/expo/pulls/2750","id":232074706,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDc0NzA2","html_url":"https://github.com/expo/expo/pull/2750","diff_url":"https://github.com/expo/expo/pull/2750.diff","patch_url":"https://github.com/expo/expo/pull/2750.patch","issue_url":"https://api.github.com/repos/expo/expo/issues/2750","number":2750,"state":"open","locked":false,"title":"[android] Remove universal image loader dependency","user":{"login":"sjchmiela","id":1151041,"node_id":"MDQ6VXNlcjExNTEwNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1151041?v=4","gravatar_id":"","url":"https://api.github.com/users/sjchmiela","html_url":"https://github.com/sjchmiela","followers_url":"https://api.github.com/users/sjchmiela/followers","following_url":"https://api.github.com/users/sjchmiela/following{/other_user}","gists_url":"https://api.github.com/users/sjchmiela/gists{/gist_id}","starred_url":"https://api.github.com/users/sjchmiela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjchmiela/subscriptions","organizations_url":"https://api.github.com/users/sjchmiela/orgs","repos_url":"https://api.github.com/users/sjchmiela/repos","events_url":"https://api.github.com/users/sjchmiela/events{/privacy}","received_events_url":"https://api.github.com/users/sjchmiela/received_events","type":"User","site_admin":false},"body":"# Why\r\n\r\nWith https://github.com/expo/expo/pull/2746 should fix https://github.com/expo/expo/issues/2657.\r\n\r\n# How\r\n\r\nIt seems in `ImagePickerModule` and `ImageManipulatorModule` we're using a separate library to load images into the memory. This [Android Universal Image Loader](https://github.com/nostra13/Android-Universal-Image-Loader) keeps its own in-app cache, which makes installed app size blow up.\r\n\r\nI've removed this loader in favor of using (already used throughout React Native) Fresco.\r\n\r\n# Test Plan\r\n\r\nThe following scenarios seem to work properly:\r\n\r\n- [x] Pick a camera image\r\n- [x] Pick a camera image with `quality`\r\n- [x] Pick a camera image with `allowsEditing`\r\n- [x] Pick a camera image with `allowsEditing` and `quality`\r\n- [x] Pick a gallery image\r\n- [x] Pick a gallery image with `quality`\r\n- [x] Pick a gallery image with `allowsEditing`\r\n- [x] Pick a gallery image with `allowsEditing` and `quality`\r\n- [x] All the buttons in `ImageManipulator` screen in NCL work ok on both predefined image and on some MediaLibrary photo\r\n- [x] Running the Snack provided in the issue showed a 300 KB increase in app size rather than 3 MB","created_at":"2018-11-19T18:44:55Z","updated_at":"2018-11-19T18:44:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":657309341,"node_id":"MDU6TGFiZWw2NTczMDkzNDE=","url":"https://api.github.com/repos/expo/expo/labels/in%20review","name":"in review","color":"e6e6e6","default":false},{"id":598253983,"node_id":"MDU6TGFiZWw1OTgyNTM5ODM=","url":"https://api.github.com/repos/expo/expo/labels/project:%20android-runtime","name":"project: android-runtime","color":"fbca04","default":false},{"id":598255371,"node_id":"MDU6TGFiZWw1OTgyNTUzNzE=","url":"https://api.github.com/repos/expo/expo/labels/project:%20sdk","name":"project: sdk","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/expo/expo/pulls/2750/commits","review_comments_url":"https://api.github.com/repos/expo/expo/pulls/2750/comments","review_comment_url":"https://api.github.com/repos/expo/expo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/expo/expo/issues/2750/comments","statuses_url":"https://api.github.com/repos/expo/expo/statuses/45ab4c6f44fe7e88f1baa71a87a4f90688c807dd","head":{"label":"expo:@sjchmiela/remove_universal_image_loader_android","ref":"@sjchmiela/remove_universal_image_loader_android","sha":"45ab4c6f44fe7e88f1baa71a87a4f90688c807dd","user":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"repo":{"id":65750241,"node_id":"MDEwOlJlcG9zaXRvcnk2NTc1MDI0MQ==","name":"expo","full_name":"expo/expo","private":false,"owner":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/expo/expo","description":"The Expo platform for making cross-platform mobile apps","fork":false,"url":"https://api.github.com/repos/expo/expo","forks_url":"https://api.github.com/repos/expo/expo/forks","keys_url":"https://api.github.com/repos/expo/expo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expo/expo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expo/expo/teams","hooks_url":"https://api.github.com/repos/expo/expo/hooks","issue_events_url":"https://api.github.com/repos/expo/expo/issues/events{/number}","events_url":"https://api.github.com/repos/expo/expo/events","assignees_url":"https://api.github.com/repos/expo/expo/assignees{/user}","branches_url":"https://api.github.com/repos/expo/expo/branches{/branch}","tags_url":"https://api.github.com/repos/expo/expo/tags","blobs_url":"https://api.github.com/repos/expo/expo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expo/expo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expo/expo/git/refs{/sha}","trees_url":"https://api.github.com/repos/expo/expo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expo/expo/statuses/{sha}","languages_url":"https://api.github.com/repos/expo/expo/languages","stargazers_url":"https://api.github.com/repos/expo/expo/stargazers","contributors_url":"https://api.github.com/repos/expo/expo/contributors","subscribers_url":"https://api.github.com/repos/expo/expo/subscribers","subscription_url":"https://api.github.com/repos/expo/expo/subscription","commits_url":"https://api.github.com/repos/expo/expo/commits{/sha}","git_commits_url":"https://api.github.com/repos/expo/expo/git/commits{/sha}","comments_url":"https://api.github.com/repos/expo/expo/comments{/number}","issue_comment_url":"https://api.github.com/repos/expo/expo/issues/comments{/number}","contents_url":"https://api.github.com/repos/expo/expo/contents/{+path}","compare_url":"https://api.github.com/repos/expo/expo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expo/expo/merges","archive_url":"https://api.github.com/repos/expo/expo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expo/expo/downloads","issues_url":"https://api.github.com/repos/expo/expo/issues{/number}","pulls_url":"https://api.github.com/repos/expo/expo/pulls{/number}","milestones_url":"https://api.github.com/repos/expo/expo/milestones{/number}","notifications_url":"https://api.github.com/repos/expo/expo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expo/expo/labels{/name}","releases_url":"https://api.github.com/repos/expo/expo/releases{/id}","deployments_url":"https://api.github.com/repos/expo/expo/deployments","created_at":"2016-08-15T17:14:25Z","updated_at":"2018-11-19T18:38:40Z","pushed_at":"2018-11-19T18:28:24Z","git_url":"git://github.com/expo/expo.git","ssh_url":"git@github.com:expo/expo.git","clone_url":"https://github.com/expo/expo.git","svn_url":"https://github.com/expo/expo","homepage":"https://docs.expo.io/","size":814586,"stargazers_count":4529,"watchers_count":4529,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":379,"mirror_url":null,"archived":false,"open_issues_count":494,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":379,"open_issues":494,"watchers":4529,"default_branch":"master"}},"base":{"label":"expo:master","ref":"master","sha":"d1aac6bfe0bfcf5c914e593408a01433b9aa6104","user":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"repo":{"id":65750241,"node_id":"MDEwOlJlcG9zaXRvcnk2NTc1MDI0MQ==","name":"expo","full_name":"expo/expo","private":false,"owner":{"login":"expo","id":12504344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA0MzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/12504344?v=4","gravatar_id":"","url":"https://api.github.com/users/expo","html_url":"https://github.com/expo","followers_url":"https://api.github.com/users/expo/followers","following_url":"https://api.github.com/users/expo/following{/other_user}","gists_url":"https://api.github.com/users/expo/gists{/gist_id}","starred_url":"https://api.github.com/users/expo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/expo/subscriptions","organizations_url":"https://api.github.com/users/expo/orgs","repos_url":"https://api.github.com/users/expo/repos","events_url":"https://api.github.com/users/expo/events{/privacy}","received_events_url":"https://api.github.com/users/expo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/expo/expo","description":"The Expo platform for making cross-platform mobile apps","fork":false,"url":"https://api.github.com/repos/expo/expo","forks_url":"https://api.github.com/repos/expo/expo/forks","keys_url":"https://api.github.com/repos/expo/expo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/expo/expo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/expo/expo/teams","hooks_url":"https://api.github.com/repos/expo/expo/hooks","issue_events_url":"https://api.github.com/repos/expo/expo/issues/events{/number}","events_url":"https://api.github.com/repos/expo/expo/events","assignees_url":"https://api.github.com/repos/expo/expo/assignees{/user}","branches_url":"https://api.github.com/repos/expo/expo/branches{/branch}","tags_url":"https://api.github.com/repos/expo/expo/tags","blobs_url":"https://api.github.com/repos/expo/expo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/expo/expo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/expo/expo/git/refs{/sha}","trees_url":"https://api.github.com/repos/expo/expo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/expo/expo/statuses/{sha}","languages_url":"https://api.github.com/repos/expo/expo/languages","stargazers_url":"https://api.github.com/repos/expo/expo/stargazers","contributors_url":"https://api.github.com/repos/expo/expo/contributors","subscribers_url":"https://api.github.com/repos/expo/expo/subscribers","subscription_url":"https://api.github.com/repos/expo/expo/subscription","commits_url":"https://api.github.com/repos/expo/expo/commits{/sha}","git_commits_url":"https://api.github.com/repos/expo/expo/git/commits{/sha}","comments_url":"https://api.github.com/repos/expo/expo/comments{/number}","issue_comment_url":"https://api.github.com/repos/expo/expo/issues/comments{/number}","contents_url":"https://api.github.com/repos/expo/expo/contents/{+path}","compare_url":"https://api.github.com/repos/expo/expo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/expo/expo/merges","archive_url":"https://api.github.com/repos/expo/expo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/expo/expo/downloads","issues_url":"https://api.github.com/repos/expo/expo/issues{/number}","pulls_url":"https://api.github.com/repos/expo/expo/pulls{/number}","milestones_url":"https://api.github.com/repos/expo/expo/milestones{/number}","notifications_url":"https://api.github.com/repos/expo/expo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/expo/expo/labels{/name}","releases_url":"https://api.github.com/repos/expo/expo/releases{/id}","deployments_url":"https://api.github.com/repos/expo/expo/deployments","created_at":"2016-08-15T17:14:25Z","updated_at":"2018-11-19T18:38:40Z","pushed_at":"2018-11-19T18:28:24Z","git_url":"git://github.com/expo/expo.git","ssh_url":"git@github.com:expo/expo.git","clone_url":"https://github.com/expo/expo.git","svn_url":"https://github.com/expo/expo","homepage":"https://docs.expo.io/","size":814586,"stargazers_count":4529,"watchers_count":4529,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":379,"mirror_url":null,"archived":false,"open_issues_count":494,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":379,"open_issues":494,"watchers":4529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/expo/expo/pulls/2750"},"html":{"href":"https://github.com/expo/expo/pull/2750"},"issue":{"href":"https://api.github.com/repos/expo/expo/issues/2750"},"comments":{"href":"https://api.github.com/repos/expo/expo/issues/2750/comments"},"review_comments":{"href":"https://api.github.com/repos/expo/expo/pulls/2750/comments"},"review_comment":{"href":"https://api.github.com/repos/expo/expo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/expo/expo/pulls/2750/commits"},"statuses":{"href":"https://api.github.com/repos/expo/expo/statuses/45ab4c6f44fe7e88f1baa71a87a4f90688c807dd"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":106,"deletions":95,"changed_files":6}}
{"actor":{"display_login":"sjchmiela"}}