{"action":"opened","number":16,"pull_request":{"url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/pulls/16","id":225520043,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTIwMDQz","html_url":"https://github.com/csirtgadgets/csirtg-mail-py/pull/16","diff_url":"https://github.com/csirtgadgets/csirtg-mail-py/pull/16.diff","patch_url":"https://github.com/csirtgadgets/csirtg-mail-py/pull/16.patch","issue_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/issues/16","number":16,"state":"open","locked":false,"title":"Adding support for port numbers and username:passwords to URLs","user":{"login":"deanpemberton","id":5395440,"node_id":"MDQ6VXNlcjUzOTU0NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5395440?v=4","gravatar_id":"","url":"https://api.github.com/users/deanpemberton","html_url":"https://github.com/deanpemberton","followers_url":"https://api.github.com/users/deanpemberton/followers","following_url":"https://api.github.com/users/deanpemberton/following{/other_user}","gists_url":"https://api.github.com/users/deanpemberton/gists{/gist_id}","starred_url":"https://api.github.com/users/deanpemberton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanpemberton/subscriptions","organizations_url":"https://api.github.com/users/deanpemberton/orgs","repos_url":"https://api.github.com/users/deanpemberton/repos","events_url":"https://api.github.com/users/deanpemberton/events{/privacy}","received_events_url":"https://api.github.com/users/deanpemberton/received_events","type":"User","site_admin":false},"body":"As part of our testing we have discovered that URLs with port numbers were not being considered as valid by the _url function.  \r\nThis is because the urlparse function will return any  :portnumber and username:password@ sections in the URL in the netloc.  \r\nThe netloc with these additional sections is then being passed to _fqdn, _ipv4 and _ipv6 to validate, and subsequently failing the associated regular expressions for those types.\r\n\r\nThe fix below looks to extend these regular expressions to take optional username:password@ and :portnumber sections.  It also adjusts the RE_URL_PLAIN re to allow for the [ characters used with IPv6 literals in URLs.\r\n\r\nA new test case was added which exercises this code.","created_at":"2018-10-24T19:19:35Z","updated_at":"2018-10-24T19:19:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/pulls/16/commits","review_comments_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/pulls/16/comments","review_comment_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/issues/16/comments","statuses_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/statuses/f00587e1a1931768c25d3f52389730990b1c5ab3","head":{"label":"deanpemberton:master","ref":"master","sha":"f00587e1a1931768c25d3f52389730990b1c5ab3","user":{"login":"deanpemberton","id":5395440,"node_id":"MDQ6VXNlcjUzOTU0NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5395440?v=4","gravatar_id":"","url":"https://api.github.com/users/deanpemberton","html_url":"https://github.com/deanpemberton","followers_url":"https://api.github.com/users/deanpemberton/followers","following_url":"https://api.github.com/users/deanpemberton/following{/other_user}","gists_url":"https://api.github.com/users/deanpemberton/gists{/gist_id}","starred_url":"https://api.github.com/users/deanpemberton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanpemberton/subscriptions","organizations_url":"https://api.github.com/users/deanpemberton/orgs","repos_url":"https://api.github.com/users/deanpemberton/repos","events_url":"https://api.github.com/users/deanpemberton/events{/privacy}","received_events_url":"https://api.github.com/users/deanpemberton/received_events","type":"User","site_admin":false},"repo":{"id":146843008,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4NDMwMDg=","name":"csirtg-mail-py","full_name":"deanpemberton/csirtg-mail-py","private":false,"owner":{"login":"deanpemberton","id":5395440,"node_id":"MDQ6VXNlcjUzOTU0NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5395440?v=4","gravatar_id":"","url":"https://api.github.com/users/deanpemberton","html_url":"https://github.com/deanpemberton","followers_url":"https://api.github.com/users/deanpemberton/followers","following_url":"https://api.github.com/users/deanpemberton/following{/other_user}","gists_url":"https://api.github.com/users/deanpemberton/gists{/gist_id}","starred_url":"https://api.github.com/users/deanpemberton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanpemberton/subscriptions","organizations_url":"https://api.github.com/users/deanpemberton/orgs","repos_url":"https://api.github.com/users/deanpemberton/repos","events_url":"https://api.github.com/users/deanpemberton/events{/privacy}","received_events_url":"https://api.github.com/users/deanpemberton/received_events","type":"User","site_admin":false},"html_url":"https://github.com/deanpemberton/csirtg-mail-py","description":"The FASTEST way to parse Email","fork":true,"url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py","forks_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/forks","keys_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/teams","hooks_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/hooks","issue_events_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/issues/events{/number}","events_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/events","assignees_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/assignees{/user}","branches_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/branches{/branch}","tags_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/tags","blobs_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/statuses/{sha}","languages_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/languages","stargazers_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/stargazers","contributors_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/contributors","subscribers_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/subscribers","subscription_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/subscription","commits_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/contents/{+path}","compare_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/merges","archive_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/downloads","issues_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/issues{/number}","pulls_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/pulls{/number}","milestones_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/milestones{/number}","notifications_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/labels{/name}","releases_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/releases{/id}","deployments_url":"https://api.github.com/repos/deanpemberton/csirtg-mail-py/deployments","created_at":"2018-08-31T04:53:24Z","updated_at":"2018-10-24T19:04:51Z","pushed_at":"2018-10-24T19:04:49Z","git_url":"git://github.com/deanpemberton/csirtg-mail-py.git","ssh_url":"git@github.com:deanpemberton/csirtg-mail-py.git","clone_url":"https://github.com/deanpemberton/csirtg-mail-py.git","svn_url":"https://github.com/deanpemberton/csirtg-mail-py","homepage":"https://csirtgadgets.com","size":223,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"csirtgadgets:master","ref":"master","sha":"00572e0970e88561e038f68ab719d045c75ebb3e","user":{"login":"csirtgadgets","id":5203786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDM3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/5203786?v=4","gravatar_id":"","url":"https://api.github.com/users/csirtgadgets","html_url":"https://github.com/csirtgadgets","followers_url":"https://api.github.com/users/csirtgadgets/followers","following_url":"https://api.github.com/users/csirtgadgets/following{/other_user}","gists_url":"https://api.github.com/users/csirtgadgets/gists{/gist_id}","starred_url":"https://api.github.com/users/csirtgadgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csirtgadgets/subscriptions","organizations_url":"https://api.github.com/users/csirtgadgets/orgs","repos_url":"https://api.github.com/users/csirtgadgets/repos","events_url":"https://api.github.com/users/csirtgadgets/events{/privacy}","received_events_url":"https://api.github.com/users/csirtgadgets/received_events","type":"Organization","site_admin":false},"repo":{"id":71650341,"node_id":"MDEwOlJlcG9zaXRvcnk3MTY1MDM0MQ==","name":"csirtg-mail-py","full_name":"csirtgadgets/csirtg-mail-py","private":false,"owner":{"login":"csirtgadgets","id":5203786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDM3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/5203786?v=4","gravatar_id":"","url":"https://api.github.com/users/csirtgadgets","html_url":"https://github.com/csirtgadgets","followers_url":"https://api.github.com/users/csirtgadgets/followers","following_url":"https://api.github.com/users/csirtgadgets/following{/other_user}","gists_url":"https://api.github.com/users/csirtgadgets/gists{/gist_id}","starred_url":"https://api.github.com/users/csirtgadgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csirtgadgets/subscriptions","organizations_url":"https://api.github.com/users/csirtgadgets/orgs","repos_url":"https://api.github.com/users/csirtgadgets/repos","events_url":"https://api.github.com/users/csirtgadgets/events{/privacy}","received_events_url":"https://api.github.com/users/csirtgadgets/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/csirtgadgets/csirtg-mail-py","description":"The FASTEST way to parse Email","fork":false,"url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py","forks_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/forks","keys_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/teams","hooks_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/hooks","issue_events_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/issues/events{/number}","events_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/events","assignees_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/assignees{/user}","branches_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/branches{/branch}","tags_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/tags","blobs_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/statuses/{sha}","languages_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/languages","stargazers_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/stargazers","contributors_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/contributors","subscribers_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/subscribers","subscription_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/subscription","commits_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/contents/{+path}","compare_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/merges","archive_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/downloads","issues_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/issues{/number}","pulls_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/pulls{/number}","milestones_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/milestones{/number}","notifications_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/labels{/name}","releases_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/releases{/id}","deployments_url":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/deployments","created_at":"2016-10-22T16:11:46Z","updated_at":"2018-10-01T15:37:41Z","pushed_at":"2018-09-03T13:06:26Z","git_url":"git://github.com/csirtgadgets/csirtg-mail-py.git","ssh_url":"git@github.com:csirtgadgets/csirtg-mail-py.git","clone_url":"https://github.com/csirtgadgets/csirtg-mail-py.git","svn_url":"https://github.com/csirtgadgets/csirtg-mail-py","homepage":"https://csirtgadgets.com","size":224,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":3,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/pulls/16"},"html":{"href":"https://github.com/csirtgadgets/csirtg-mail-py/pull/16"},"issue":{"href":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/issues/16"},"comments":{"href":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/csirtgadgets/csirtg-mail-py/statuses/f00587e1a1931768c25d3f52389730990b1c5ab3"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":109,"deletions":8,"changed_files":3}}
{"actor":{"display_login":"deanpemberton"}}