{"action":"created","comment":{"url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/comments/201820471","pull_request_review_id":136398321,"id":201820471,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTgyMDQ3MQ==","diff_hunk":"@@ -578,6 +582,12 @@ def _build_object(self, nm, clsdata, parents,**kw):\n             properties[prop]['raw_name'] = prop\n             name_translation[prop] = prop.replace('@', '')\n             prop = name_translation[prop]\n+            ","path":"python_jsonschema_objects/classbuilder.py","position":15,"original_position":15,"commit_id":"6d62490d2cda97af5270b0d64e537dae7e12ad09","original_commit_id":"6d62490d2cda97af5270b0d64e537dae7e12ad09","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"blank line contains whitespace","created_at":"2018-07-11T19:56:52Z","updated_at":"2018-07-11T19:56:52Z","html_url":"https://github.com/cwacek/python-jsonschema-objects/pull/146#discussion_r201820471","pull_request_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/146","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/comments/201820471"},"html":{"href":"https://github.com/cwacek/python-jsonschema-objects/pull/146#discussion_r201820471"},"pull_request":{"href":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/146","id":200809010,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODA5MDEw","html_url":"https://github.com/cwacek/python-jsonschema-objects/pull/146","diff_url":"https://github.com/cwacek/python-jsonschema-objects/pull/146.diff","patch_url":"https://github.com/cwacek/python-jsonschema-objects/pull/146.patch","issue_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/issues/146","number":146,"state":"open","locked":false,"title":"Upstream our oneOf patches","user":{"login":"JonKohler","id":21041006,"node_id":"MDQ6VXNlcjIxMDQxMDA2","avatar_url":"https://avatars1.githubusercontent.com/u/21041006?v=4","gravatar_id":"","url":"https://api.github.com/users/JonKohler","html_url":"https://github.com/JonKohler","followers_url":"https://api.github.com/users/JonKohler/followers","following_url":"https://api.github.com/users/JonKohler/following{/other_user}","gists_url":"https://api.github.com/users/JonKohler/gists{/gist_id}","starred_url":"https://api.github.com/users/JonKohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonKohler/subscriptions","organizations_url":"https://api.github.com/users/JonKohler/orgs","repos_url":"https://api.github.com/users/JonKohler/repos","events_url":"https://api.github.com/users/JonKohler/events{/privacy}","received_events_url":"https://api.github.com/users/JonKohler/received_events","type":"User","site_admin":false},"body":"We've made the following changes to our private version of python-jsonschema-object, and are looking to upstream these to benefit the community \r\n\r\nPatch #1 \r\nAdd an if other wrap-around return self.as_dict. Knock on wood, this may give similar behavior to what was added on 87451f2?diff=split, but will defer to the community's larger knowledge of this section of code to advise us.\r\n\r\nPatch #2\r\nFix one bug in jsconschema-object to skip oneOf type setting when oneOf is combined with \"required\", not \"type: object\"\r\n\r\n\r\nThis branch also has the same content with #145 for the small pandocfilters ","created_at":"2018-07-11T19:56:31Z","updated_at":"2018-07-11T19:56:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa8ff98b4eb3b1ca5681f56c771d1eaa553afc3d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/146/commits","review_comments_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/146/comments","review_comment_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/issues/146/comments","statuses_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/statuses/6d62490d2cda97af5270b0d64e537dae7e12ad09","head":{"label":"JonKohler:upstream-oneof-feature","ref":"upstream-oneof-feature","sha":"6d62490d2cda97af5270b0d64e537dae7e12ad09","user":{"login":"JonKohler","id":21041006,"node_id":"MDQ6VXNlcjIxMDQxMDA2","avatar_url":"https://avatars1.githubusercontent.com/u/21041006?v=4","gravatar_id":"","url":"https://api.github.com/users/JonKohler","html_url":"https://github.com/JonKohler","followers_url":"https://api.github.com/users/JonKohler/followers","following_url":"https://api.github.com/users/JonKohler/following{/other_user}","gists_url":"https://api.github.com/users/JonKohler/gists{/gist_id}","starred_url":"https://api.github.com/users/JonKohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonKohler/subscriptions","organizations_url":"https://api.github.com/users/JonKohler/orgs","repos_url":"https://api.github.com/users/JonKohler/repos","events_url":"https://api.github.com/users/JonKohler/events{/privacy}","received_events_url":"https://api.github.com/users/JonKohler/received_events","type":"User","site_admin":false},"repo":{"id":140615743,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2MTU3NDM=","name":"python-jsonschema-objects","full_name":"JonKohler/python-jsonschema-objects","owner":{"login":"JonKohler","id":21041006,"node_id":"MDQ6VXNlcjIxMDQxMDA2","avatar_url":"https://avatars1.githubusercontent.com/u/21041006?v=4","gravatar_id":"","url":"https://api.github.com/users/JonKohler","html_url":"https://github.com/JonKohler","followers_url":"https://api.github.com/users/JonKohler/followers","following_url":"https://api.github.com/users/JonKohler/following{/other_user}","gists_url":"https://api.github.com/users/JonKohler/gists{/gist_id}","starred_url":"https://api.github.com/users/JonKohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonKohler/subscriptions","organizations_url":"https://api.github.com/users/JonKohler/orgs","repos_url":"https://api.github.com/users/JonKohler/repos","events_url":"https://api.github.com/users/JonKohler/events{/privacy}","received_events_url":"https://api.github.com/users/JonKohler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JonKohler/python-jsonschema-objects","description":"Automatic Python binding generation from JSON Schemas","fork":true,"url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects","forks_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/forks","keys_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/teams","hooks_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/hooks","issue_events_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/issues/events{/number}","events_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/events","assignees_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/assignees{/user}","branches_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/branches{/branch}","tags_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/tags","blobs_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/statuses/{sha}","languages_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/languages","stargazers_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/stargazers","contributors_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/contributors","subscribers_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/subscribers","subscription_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/subscription","commits_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/contents/{+path}","compare_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/merges","archive_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/downloads","issues_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/issues{/number}","pulls_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/pulls{/number}","milestones_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/milestones{/number}","notifications_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/labels{/name}","releases_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/releases{/id}","deployments_url":"https://api.github.com/repos/JonKohler/python-jsonschema-objects/deployments","created_at":"2018-07-11T18:44:56Z","updated_at":"2018-07-11T18:56:44Z","pushed_at":"2018-07-11T19:52:34Z","git_url":"git://github.com/JonKohler/python-jsonschema-objects.git","ssh_url":"git@github.com:JonKohler/python-jsonschema-objects.git","clone_url":"https://github.com/JonKohler/python-jsonschema-objects.git","svn_url":"https://github.com/JonKohler/python-jsonschema-objects","homepage":null,"size":345,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cwacek:master","ref":"master","sha":"e1694ac84542a7ea9ce5224fc1eb0ed34d5453c7","user":{"login":"cwacek","id":556690,"node_id":"MDQ6VXNlcjU1NjY5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/556690?v=4","gravatar_id":"","url":"https://api.github.com/users/cwacek","html_url":"https://github.com/cwacek","followers_url":"https://api.github.com/users/cwacek/followers","following_url":"https://api.github.com/users/cwacek/following{/other_user}","gists_url":"https://api.github.com/users/cwacek/gists{/gist_id}","starred_url":"https://api.github.com/users/cwacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwacek/subscriptions","organizations_url":"https://api.github.com/users/cwacek/orgs","repos_url":"https://api.github.com/users/cwacek/repos","events_url":"https://api.github.com/users/cwacek/events{/privacy}","received_events_url":"https://api.github.com/users/cwacek/received_events","type":"User","site_admin":false},"repo":{"id":18216839,"node_id":"MDEwOlJlcG9zaXRvcnkxODIxNjgzOQ==","name":"python-jsonschema-objects","full_name":"cwacek/python-jsonschema-objects","owner":{"login":"cwacek","id":556690,"node_id":"MDQ6VXNlcjU1NjY5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/556690?v=4","gravatar_id":"","url":"https://api.github.com/users/cwacek","html_url":"https://github.com/cwacek","followers_url":"https://api.github.com/users/cwacek/followers","following_url":"https://api.github.com/users/cwacek/following{/other_user}","gists_url":"https://api.github.com/users/cwacek/gists{/gist_id}","starred_url":"https://api.github.com/users/cwacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwacek/subscriptions","organizations_url":"https://api.github.com/users/cwacek/orgs","repos_url":"https://api.github.com/users/cwacek/repos","events_url":"https://api.github.com/users/cwacek/events{/privacy}","received_events_url":"https://api.github.com/users/cwacek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cwacek/python-jsonschema-objects","description":"Automatic Python binding generation from JSON Schemas","fork":false,"url":"https://api.github.com/repos/cwacek/python-jsonschema-objects","forks_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/forks","keys_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/teams","hooks_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/hooks","issue_events_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/issues/events{/number}","events_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/events","assignees_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/assignees{/user}","branches_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/branches{/branch}","tags_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/tags","blobs_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/git/refs{/sha}","trees_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/statuses/{sha}","languages_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/languages","stargazers_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/stargazers","contributors_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/contributors","subscribers_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/subscribers","subscription_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/subscription","commits_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/commits{/sha}","git_commits_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/git/commits{/sha}","comments_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/comments{/number}","issue_comment_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/issues/comments{/number}","contents_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/contents/{+path}","compare_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/merges","archive_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/downloads","issues_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/issues{/number}","pulls_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls{/number}","milestones_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/milestones{/number}","notifications_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/labels{/name}","releases_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/releases{/id}","deployments_url":"https://api.github.com/repos/cwacek/python-jsonschema-objects/deployments","created_at":"2014-03-28T15:29:21Z","updated_at":"2018-07-05T02:18:58Z","pushed_at":"2018-07-11T19:56:32Z","git_url":"git://github.com/cwacek/python-jsonschema-objects.git","ssh_url":"git@github.com:cwacek/python-jsonschema-objects.git","clone_url":"https://github.com/cwacek/python-jsonschema-objects.git","svn_url":"https://github.com/cwacek/python-jsonschema-objects","homepage":null,"size":333,"stargazers_count":170,"watchers_count":170,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":54,"open_issues":29,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/146"},"html":{"href":"https://github.com/cwacek/python-jsonschema-objects/pull/146"},"issue":{"href":"https://api.github.com/repos/cwacek/python-jsonschema-objects/issues/146"},"comments":{"href":"https://api.github.com/repos/cwacek/python-jsonschema-objects/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cwacek/python-jsonschema-objects/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/cwacek/python-jsonschema-objects/statuses/6d62490d2cda97af5270b0d64e537dae7e12ad09"}},"author_association":"NONE"}}
{"actor":{"display_login":"houndci-bot"}}