{"action":"created","issue":{"url":"https://api.github.com/repos/knative/serving/issues/2074","repository_url":"https://api.github.com/repos/knative/serving","labels_url":"https://api.github.com/repos/knative/serving/issues/2074/labels{/name}","comments_url":"https://api.github.com/repos/knative/serving/issues/2074/comments","events_url":"https://api.github.com/repos/knative/serving/issues/2074/events","html_url":"https://github.com/knative/serving/pull/2074","id":362746855,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzgwMTQ1","number":2074,"title":"[PoC] Phased Reconciliation for Routes","user":{"login":"dprotaso","id":18562,"node_id":"MDQ6VXNlcjE4NTYy","avatar_url":"https://avatars2.githubusercontent.com/u/18562?v=4","gravatar_id":"","url":"https://api.github.com/users/dprotaso","html_url":"https://github.com/dprotaso","followers_url":"https://api.github.com/users/dprotaso/followers","following_url":"https://api.github.com/users/dprotaso/following{/other_user}","gists_url":"https://api.github.com/users/dprotaso/gists{/gist_id}","starred_url":"https://api.github.com/users/dprotaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dprotaso/subscriptions","organizations_url":"https://api.github.com/users/dprotaso/orgs","repos_url":"https://api.github.com/users/dprotaso/repos","events_url":"https://api.github.com/users/dprotaso/events{/privacy}","received_events_url":"https://api.github.com/users/dprotaso/received_events","type":"User","site_admin":false},"labels":[{"id":867084768,"node_id":"MDU6TGFiZWw4NjcwODQ3Njg=","url":"https://api.github.com/repos/knative/serving/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"b60205","default":false},{"id":860875203,"node_id":"MDU6TGFiZWw4NjA4NzUyMDM=","url":"https://api.github.com/repos/knative/serving/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-09-21T19:31:25Z","updated_at":"2018-10-09T17:08:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2074","html_url":"https://github.com/knative/serving/pull/2074","diff_url":"https://github.com/knative/serving/pull/2074.diff","patch_url":"https://github.com/knative/serving/pull/2074.patch"},"body":"Initial PoC for completing #1942\r\n\r\nLooking for feedback on\r\n  * [PhasedTests (TableTest v2)](https://github.com/dprotaso/serving/blob/route-reconciler/pkg/reconciler/testing/phase.go)\r\n  * [The structure of phases and their tests](https://github.com/dprotaso/serving/tree/route-reconciler/pkg/reconciler/v1alpha1/routephase/phase)\r\n  * [Alternative way to invoke a phase/scenario table row](https://github.com/dprotaso/serving/blob/route-reconciler/pkg/reconciler/v1alpha1/routephase/phase/virtual_service_test.go#L1083). \r\n    * This helps with @mattmoor's goals in the PR #1941\r\n  * [Use of injection inspired by controller-runtime](https://github.com/dprotaso/serving/blob/route-reconciler/pkg/reconciler/v1alpha1/inject/inject.go) and it's use [when initializing the phases for tests](https://github.com/dprotaso/serving/blob/route-reconciler/pkg/reconciler/v1alpha1/testing/initializer.go#L16)\r\n* Thoughts about using a similar injection style for the purposes 'production' setup\r\n   * This could end up being a `github.com/knative/pkg/controller` v2\r\n   * Implementation [here](https://github.com/dprotaso/serving/blob/route-reconciler/pkg/reconciler/v1alpha1/initializer.go#L190)\r\n\r\nActive Questions:\r\n* What contract should we impose on phases\r\n  * ie. should phases be allowed to 'read' from the resource's status (virtual service does this for the domain, I don't like that it does)\r\n* This approach won't give you a full view of how all the phases combined affect the resource status.\r\n  * For example reconciling a route's k8s service set's the `DomainInternal` other phases don't care or do anything about this property. \r\n* Should we be setting unrelated properties (ie. DomainInternal) in the fixtures that describe the route's steady state etc.. for phases that don't care about it. Does it matter?\r\n\r\n/hold"},"comment":{"url":"https://api.github.com/repos/knative/serving/issues/comments/428273406","html_url":"https://github.com/knative/serving/pull/2074#issuecomment-428273406","issue_url":"https://api.github.com/repos/knative/serving/issues/2074","id":428273406,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODI3MzQwNg==","user":{"login":"knative-prow-robot","id":41213312,"node_id":"MDQ6VXNlcjQxMjEzMzEy","avatar_url":"https://avatars2.githubusercontent.com/u/41213312?v=4","gravatar_id":"","url":"https://api.github.com/users/knative-prow-robot","html_url":"https://github.com/knative-prow-robot","followers_url":"https://api.github.com/users/knative-prow-robot/followers","following_url":"https://api.github.com/users/knative-prow-robot/following{/other_user}","gists_url":"https://api.github.com/users/knative-prow-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/knative-prow-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative-prow-robot/subscriptions","organizations_url":"https://api.github.com/users/knative-prow-robot/orgs","repos_url":"https://api.github.com/users/knative-prow-robot/repos","events_url":"https://api.github.com/users/knative-prow-robot/events{/privacy}","received_events_url":"https://api.github.com/users/knative-prow-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T17:08:56Z","updated_at":"2018-10-09T17:08:56Z","author_association":"NONE","body":"@dprotaso: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-knative-serving-go-coverage | daf95950085552aca09ba2f1141b088d80653315 | [link](https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_serving/2074/pull-knative-serving-go-coverage/1049708174245892099/) | `/test pull-knative-serving-go-coverage`\n\n[Full PR test history](https://gubernator.knative.dev/pr/knative_serving/2074). [Your PR dashboard](https://gubernator.knative.dev/pr/dprotaso).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"knative-prow-robot"}}