{"action":"created","issue":{"url":"https://api.github.com/repos/awesomeWM/awesome/issues/2388","repository_url":"https://api.github.com/repos/awesomeWM/awesome","labels_url":"https://api.github.com/repos/awesomeWM/awesome/issues/2388/labels{/name}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/issues/2388/comments","events_url":"https://api.github.com/repos/awesomeWM/awesome/issues/2388/events","html_url":"https://github.com/awesomeWM/awesome/pull/2388","id":359366636,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0ODczOTYz","number":2388,"title":"Fix awful.placement.no_overlap + awful.placement.no_offscreen","user":{"login":"sigprof","id":616082,"node_id":"MDQ6VXNlcjYxNjA4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/616082?v=4","gravatar_id":"","url":"https://api.github.com/users/sigprof","html_url":"https://github.com/sigprof","followers_url":"https://api.github.com/users/sigprof/followers","following_url":"https://api.github.com/users/sigprof/following{/other_user}","gists_url":"https://api.github.com/users/sigprof/gists{/gist_id}","starred_url":"https://api.github.com/users/sigprof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigprof/subscriptions","organizations_url":"https://api.github.com/users/sigprof/orgs","repos_url":"https://api.github.com/users/sigprof/repos","events_url":"https://api.github.com/users/sigprof/events{/privacy}","received_events_url":"https://api.github.com/users/sigprof/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/awesomeWM/awesome/milestones/1","html_url":"https://github.com/awesomeWM/awesome/milestone/1","labels_url":"https://api.github.com/repos/awesomeWM/awesome/milestones/1/labels","id":1069592,"node_id":"MDk6TWlsZXN0b25lMTA2OTU5Mg==","number":1,"title":"next: pull requests to be merged soon","description":"Pending pull requests to be merged soon.","creator":{"login":"blueyed","id":9766,"node_id":"MDQ6VXNlcjk3NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/9766?v=4","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":756,"state":"open","created_at":"2015-04-15T22:58:10Z","updated_at":"2018-09-12T11:09:35Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-09-12T08:21:46Z","updated_at":"2018-09-13T05:58:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/2388","html_url":"https://github.com/awesomeWM/awesome/pull/2388","diff_url":"https://github.com/awesomeWM/awesome/pull/2388.diff","patch_url":"https://github.com/awesomeWM/awesome/pull/2388.patch"},"body":"Fix multiple problems in `awful.placement.no_overlap` and `awful.placement.no_offscreen` related to their conversion to the new placement infrastructure:\r\n\r\n- `no_offscreen` did not work properly when composed with other placement functions — it used the real client geometry instead of the geometry returned by the previous placement function; this usually resulted in all windows being placed at the top left corner of the workarea.\r\n- When getting the client geometry, `no_offscreen` did not adjust it for margins specified in arguments, but the reverse adjustment was performed before returning the result; because of this, after adding margins the client size was incorrectly decreased by the values of those margins.\r\n- `no_overlap` did not perform the reverse adjustment for the border width before returning the result, therefore after applying `no_overlap` the client width and height were increased by `2*border_width`. This error was not noticeable in the default configuration (`no_overlap + no_offscreen`), because the bug in `no_overlap` was masked by the above bug in `no_offscreen` (the result of `no_overlap` was discarded).\r\n\r\nActual fixes are 1 added line in `no_overlap` and 1 changed line in `no_offscreen`; the rest of the pull request contains a test for `no_overlap + no_offscreen` which should hopefully catch similar problems in the future."},"comment":{"url":"https://api.github.com/repos/awesomeWM/awesome/issues/comments/420892840","html_url":"https://github.com/awesomeWM/awesome/pull/2388#issuecomment-420892840","issue_url":"https://api.github.com/repos/awesomeWM/awesome/issues/2388","id":420892840,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDg5Mjg0MA==","user":{"login":"sigprof","id":616082,"node_id":"MDQ6VXNlcjYxNjA4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/616082?v=4","gravatar_id":"","url":"https://api.github.com/users/sigprof","html_url":"https://github.com/sigprof","followers_url":"https://api.github.com/users/sigprof/followers","following_url":"https://api.github.com/users/sigprof/following{/other_user}","gists_url":"https://api.github.com/users/sigprof/gists{/gist_id}","starred_url":"https://api.github.com/users/sigprof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigprof/subscriptions","organizations_url":"https://api.github.com/users/sigprof/orgs","repos_url":"https://api.github.com/users/sigprof/repos","events_url":"https://api.github.com/users/sigprof/events{/privacy}","received_events_url":"https://api.github.com/users/sigprof/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T05:58:43Z","updated_at":"2018-09-13T05:58:43Z","author_association":"CONTRIBUTOR","body":"I reordered commits so that the `no_overlap` fix is before the `no_offscreen` fix (fixing `no_offscreen` exposes the bug in `no_overlap`, which breaks some tests), and the new test now comes after all fixes."}}
{"actor":{"display_login":"sigprof"}}