{"action":"closed","issue":{"url":"https://api.github.com/repos/duosecurity/duo_unix/issues/104","repository_url":"https://api.github.com/repos/duosecurity/duo_unix","labels_url":"https://api.github.com/repos/duosecurity/duo_unix/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/duosecurity/duo_unix/issues/104/comments","events_url":"https://api.github.com/repos/duosecurity/duo_unix/issues/104/events","html_url":"https://github.com/duosecurity/duo_unix/issues/104","id":258275657,"number":104,"title":"Possible leak?","user":{"login":"script3r","id":587490,"avatar_url":"https://avatars1.githubusercontent.com/u/587490?v=4","gravatar_id":"","url":"https://api.github.com/users/script3r","html_url":"https://github.com/script3r","followers_url":"https://api.github.com/users/script3r/followers","following_url":"https://api.github.com/users/script3r/following{/other_user}","gists_url":"https://api.github.com/users/script3r/gists{/gist_id}","starred_url":"https://api.github.com/users/script3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/script3r/subscriptions","organizations_url":"https://api.github.com/users/script3r/orgs","repos_url":"https://api.github.com/users/script3r/repos","events_url":"https://api.github.com/users/script3r/events{/privacy}","received_events_url":"https://api.github.com/users/script3r/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-17T03:28:04Z","updated_at":"2018-05-24T18:20:41Z","closed_at":"2018-05-24T18:20:41Z","author_association":"NONE","body":"https://github.com/duosecurity/duo_unix/blob/4358b725e8d8da50ff5a8d7834bcd0b45bc0a790/lib/duo.c#L211\r\n\r\nWhat happens if the `asprintf` allocation succeeds, however the check `ctx->argc + 1 < (sizeof(ctx->argv) / sizeof(ctx->argv[0]))` fails? Shouldn't we free `p` right there?\r\n\r\nIn that case, `p` wouldn't be assigned to one of the `ctx->argv` entries, which means it wouldn't be `free()`d up by `duo_reset`, correct?\r\n\r\n"}}
{"actor":{"display_login":"xdesai"}}