{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/comments/191693926","pull_request_review_id":124311734,"id":191693926,"diff_hunk":"@@ -109,6 +109,18 @@ impl<T: futurepool::Context + 'static> ReadPool<T> {\n         }\n     }\n \n+    /// TODO: Remove thus function. Only used to be compatible with endpoint.\n+    #[inline]\n+    pub fn get_max_tasks(&self) -> usize {\n+        vec![","path":"src/server/readpool/mod.rs","position":20,"original_position":20,"commit_id":"e23e83fdc6cba6d5d304bcc9c80b64c25733bdff","original_commit_id":"e23e83fdc6cba6d5d304bcc9c80b64c25733bdff","user":{"login":"BusyJay","id":1701473,"avatar_url":"https://avatars3.githubusercontent.com/u/1701473?v=4","gravatar_id":"","url":"https://api.github.com/users/BusyJay","html_url":"https://github.com/BusyJay","followers_url":"https://api.github.com/users/BusyJay/followers","following_url":"https://api.github.com/users/BusyJay/following{/other_user}","gists_url":"https://api.github.com/users/BusyJay/gists{/gist_id}","starred_url":"https://api.github.com/users/BusyJay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BusyJay/subscriptions","organizations_url":"https://api.github.com/users/BusyJay/orgs","repos_url":"https://api.github.com/users/BusyJay/repos","events_url":"https://api.github.com/users/BusyJay/events{/privacy}","received_events_url":"https://api.github.com/users/BusyJay/received_events","type":"User","site_admin":false},"body":"Seems two if or two `cmp::max` can do the job perfectly.","created_at":"2018-05-30T09:07:42Z","updated_at":"2018-05-30T09:07:43Z","html_url":"https://github.com/pingcap/tikv/pull/3093#discussion_r191693926","pull_request_url":"https://api.github.com/repos/pingcap/tikv/pulls/3093","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments/191693926"},"html":{"href":"https://github.com/pingcap/tikv/pull/3093#discussion_r191693926"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3093"}},"in_reply_to_id":191287675},"pull_request":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/3093","id":189291778,"html_url":"https://github.com/pingcap/tikv/pull/3093","diff_url":"https://github.com/pingcap/tikv/pull/3093.diff","patch_url":"https://github.com/pingcap/tikv/pull/3093.patch","issue_url":"https://api.github.com/repos/pingcap/tikv/issues/3093","number":3093,"state":"open","locked":false,"title":"Add `max-tasks-per-worker-xxx` and remove `end-point-max-tasks`","user":{"login":"breeswish","id":1916485,"avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"body":"Note: most of our deployments mistakenly configured `end-point-max-tasks`, so we are not using `end-point-max-tasks` to override `max-tasks-per-worker-xxx`. Instead, `end-point-max-tasks` are just ignored.\r\n\r\n@BusyJay @hicqu @overvenus PTAL","created_at":"2018-05-21T06:17:34Z","updated_at":"2018-05-30T09:07:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b0fcad197978a8da0bf609d231db71d85f5bccd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"overvenus","id":2150711,"avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},{"login":"hicqu","id":8407317,"avatar_url":"https://avatars1.githubusercontent.com/u/8407317?v=4","gravatar_id":"","url":"https://api.github.com/users/hicqu","html_url":"https://github.com/hicqu","followers_url":"https://api.github.com/users/hicqu/followers","following_url":"https://api.github.com/users/hicqu/following{/other_user}","gists_url":"https://api.github.com/users/hicqu/gists{/gist_id}","starred_url":"https://api.github.com/users/hicqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hicqu/subscriptions","organizations_url":"https://api.github.com/users/hicqu/orgs","repos_url":"https://api.github.com/users/hicqu/repos","events_url":"https://api.github.com/users/hicqu/events{/privacy}","received_events_url":"https://api.github.com/users/hicqu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tikv/pulls/3093/commits","review_comments_url":"https://api.github.com/repos/pingcap/tikv/pulls/3093/comments","review_comment_url":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tikv/issues/3093/comments","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/e23e83fdc6cba6d5d304bcc9c80b64c25733bdff","head":{"label":"breeswish:wenxuan/readpool-tasks-fix","ref":"wenxuan/readpool-tasks-fix","sha":"e23e83fdc6cba6d5d304bcc9c80b64c25733bdff","user":{"login":"breeswish","id":1916485,"avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"repo":{"id":113962357,"name":"tikv","full_name":"breeswish/tikv","owner":{"login":"breeswish","id":1916485,"avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/breeswish/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":true,"url":"https://api.github.com/repos/breeswish/tikv","forks_url":"https://api.github.com/repos/breeswish/tikv/forks","keys_url":"https://api.github.com/repos/breeswish/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/breeswish/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/breeswish/tikv/teams","hooks_url":"https://api.github.com/repos/breeswish/tikv/hooks","issue_events_url":"https://api.github.com/repos/breeswish/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/breeswish/tikv/events","assignees_url":"https://api.github.com/repos/breeswish/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/breeswish/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/breeswish/tikv/tags","blobs_url":"https://api.github.com/repos/breeswish/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/breeswish/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/breeswish/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/breeswish/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/breeswish/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/breeswish/tikv/languages","stargazers_url":"https://api.github.com/repos/breeswish/tikv/stargazers","contributors_url":"https://api.github.com/repos/breeswish/tikv/contributors","subscribers_url":"https://api.github.com/repos/breeswish/tikv/subscribers","subscription_url":"https://api.github.com/repos/breeswish/tikv/subscription","commits_url":"https://api.github.com/repos/breeswish/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/breeswish/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/breeswish/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/breeswish/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/breeswish/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/breeswish/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/breeswish/tikv/merges","archive_url":"https://api.github.com/repos/breeswish/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/breeswish/tikv/downloads","issues_url":"https://api.github.com/repos/breeswish/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/breeswish/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/breeswish/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/breeswish/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/breeswish/tikv/labels{/name}","releases_url":"https://api.github.com/repos/breeswish/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/breeswish/tikv/deployments","created_at":"2017-12-12T08:14:53Z","updated_at":"2017-12-12T08:14:55Z","pushed_at":"2018-05-25T08:31:12Z","git_url":"git://github.com/breeswish/tikv.git","ssh_url":"git@github.com:breeswish/tikv.git","clone_url":"https://github.com/breeswish/tikv.git","svn_url":"https://github.com/breeswish/tikv","homepage":"https://pingcap.com","size":13755,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"4e299e445fb300875d9864422494fdadb9c9268b","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"name":"tikv","full_name":"pingcap/tikv","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/pingcap/tikv","forks_url":"https://api.github.com/repos/pingcap/tikv/forks","keys_url":"https://api.github.com/repos/pingcap/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tikv/teams","hooks_url":"https://api.github.com/repos/pingcap/tikv/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tikv/events","assignees_url":"https://api.github.com/repos/pingcap/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tikv/tags","blobs_url":"https://api.github.com/repos/pingcap/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tikv/languages","stargazers_url":"https://api.github.com/repos/pingcap/tikv/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tikv/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tikv/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tikv/subscription","commits_url":"https://api.github.com/repos/pingcap/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tikv/merges","archive_url":"https://api.github.com/repos/pingcap/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tikv/downloads","issues_url":"https://api.github.com/repos/pingcap/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tikv/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-05-30T08:13:30Z","pushed_at":"2018-05-30T09:04:44Z","git_url":"git://github.com/pingcap/tikv.git","ssh_url":"git@github.com:pingcap/tikv.git","clone_url":"https://github.com/pingcap/tikv.git","svn_url":"https://github.com/pingcap/tikv","homepage":"https://pingcap.com","size":13665,"stargazers_count":3201,"watchers_count":3201,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":406,"mirror_url":null,"archived":false,"open_issues_count":220,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":406,"open_issues":220,"watchers":3201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3093"},"html":{"href":"https://github.com/pingcap/tikv/pull/3093"},"issue":{"href":"https://api.github.com/repos/pingcap/tikv/issues/3093"},"comments":{"href":"https://api.github.com/repos/pingcap/tikv/issues/3093/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3093/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3093/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tikv/statuses/e23e83fdc6cba6d5d304bcc9c80b64c25733bdff"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"BusyJay"}}