{"action":"reopened","number":26802,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/26802","id":187538605,"html_url":"https://github.com/dotnet/roslyn/pull/26802","diff_url":"https://github.com/dotnet/roslyn/pull/26802.diff","patch_url":"https://github.com/dotnet/roslyn/pull/26802.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/26802","number":26802,"state":"open","locked":false,"title":"Code clean up ","user":{"login":"JieCarolHu","id":17056651,"avatar_url":"https://avatars1.githubusercontent.com/u/17056651?v=4","gravatar_id":"","url":"https://api.github.com/users/JieCarolHu","html_url":"https://github.com/JieCarolHu","followers_url":"https://api.github.com/users/JieCarolHu/followers","following_url":"https://api.github.com/users/JieCarolHu/following{/other_user}","gists_url":"https://api.github.com/users/JieCarolHu/gists{/gist_id}","starred_url":"https://api.github.com/users/JieCarolHu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieCarolHu/subscriptions","organizations_url":"https://api.github.com/users/JieCarolHu/orgs","repos_url":"https://api.github.com/users/JieCarolHu/repos","events_url":"https://api.github.com/users/JieCarolHu/events{/privacy}","received_events_url":"https://api.github.com/users/JieCarolHu/received_events","type":"User","site_admin":false},"body":"<details><summary>Ask Mode template not completed</summary>\r\n\r\n<!-- This template is not always required. If you aren't sure about whether it's needed or want help filling out the sections,\r\nsubmit the pull request and then ask us for help. :) -->\r\n\r\n### Customer scenario\r\n\r\nWhat does the customer do to get into this situation, and why do we think this\r\nis common enough to address for this release.  (Granted, sometimes this will be\r\nobvious \"Open project, VS crashes\" but in general, I need to understand how\r\ncommon a scenario is)\r\n\r\n### Bugs this fixes\r\n\r\n(either VSO or GitHub links)\r\n\r\n### Workarounds, if any\r\n\r\nAlso, why we think they are insufficient for RC vs. RC2, RC3, or RTW\r\n\r\n### Risk\r\n\r\nThis is generally a measure our how central the affected code is to adjacent\r\nscenarios and thus how likely your fix is to destabilize a broader area of code\r\n\r\n### Performance impact\r\n\r\n(with a brief justification for that assessment (e.g. \"Low perf impact because no extra allocations/no complexity changes\" vs. \"Low\")\r\n\r\n### Is this a regression from a previous update?\r\n\r\n### Root cause analysis\r\n\r\nHow did we miss it?  What tests are we adding to guard against it in the future?\r\n\r\n### How was the bug found?\r\n\r\n(E.g. customer reported it vs. ad hoc testing)\r\n\r\n### Test documentation updated?\r\n\r\nIf this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.\r\n\r\n</details>\r\n","created_at":"2018-05-11T18:36:00Z","updated_at":"2018-05-23T21:04:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70d2e3010bbd9b79cddf97bb5d474cd501725f6b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"roslyn-ide","id":1781706,"slug":"roslyn-ide","description":"Roslyn IDE Team","privacy":"closed","url":"https://api.github.com/teams/1781706","members_url":"https://api.github.com/teams/1781706/members{/member}","repositories_url":"https://api.github.com/teams/1781706/repos","permission":"pull"}],"labels":[{"id":166377917,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/26802/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/26802/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/26802/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/7e6905e7b74c3eb18d66454825914003c63e4ed9","head":{"label":"JieCarolHu:codeCleanUp_master","ref":"codeCleanUp_master","sha":"7e6905e7b74c3eb18d66454825914003c63e4ed9","user":{"login":"JieCarolHu","id":17056651,"avatar_url":"https://avatars1.githubusercontent.com/u/17056651?v=4","gravatar_id":"","url":"https://api.github.com/users/JieCarolHu","html_url":"https://github.com/JieCarolHu","followers_url":"https://api.github.com/users/JieCarolHu/followers","following_url":"https://api.github.com/users/JieCarolHu/following{/other_user}","gists_url":"https://api.github.com/users/JieCarolHu/gists{/gist_id}","starred_url":"https://api.github.com/users/JieCarolHu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieCarolHu/subscriptions","organizations_url":"https://api.github.com/users/JieCarolHu/orgs","repos_url":"https://api.github.com/users/JieCarolHu/repos","events_url":"https://api.github.com/users/JieCarolHu/events{/privacy}","received_events_url":"https://api.github.com/users/JieCarolHu/received_events","type":"User","site_admin":false},"repo":{"id":117298628,"name":"roslyn","full_name":"JieCarolHu/roslyn","owner":{"login":"JieCarolHu","id":17056651,"avatar_url":"https://avatars1.githubusercontent.com/u/17056651?v=4","gravatar_id":"","url":"https://api.github.com/users/JieCarolHu","html_url":"https://github.com/JieCarolHu","followers_url":"https://api.github.com/users/JieCarolHu/followers","following_url":"https://api.github.com/users/JieCarolHu/following{/other_user}","gists_url":"https://api.github.com/users/JieCarolHu/gists{/gist_id}","starred_url":"https://api.github.com/users/JieCarolHu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieCarolHu/subscriptions","organizations_url":"https://api.github.com/users/JieCarolHu/orgs","repos_url":"https://api.github.com/users/JieCarolHu/repos","events_url":"https://api.github.com/users/JieCarolHu/events{/privacy}","received_events_url":"https://api.github.com/users/JieCarolHu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JieCarolHu/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/JieCarolHu/roslyn","forks_url":"https://api.github.com/repos/JieCarolHu/roslyn/forks","keys_url":"https://api.github.com/repos/JieCarolHu/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JieCarolHu/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JieCarolHu/roslyn/teams","hooks_url":"https://api.github.com/repos/JieCarolHu/roslyn/hooks","issue_events_url":"https://api.github.com/repos/JieCarolHu/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/JieCarolHu/roslyn/events","assignees_url":"https://api.github.com/repos/JieCarolHu/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/JieCarolHu/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/JieCarolHu/roslyn/tags","blobs_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JieCarolHu/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/JieCarolHu/roslyn/languages","stargazers_url":"https://api.github.com/repos/JieCarolHu/roslyn/stargazers","contributors_url":"https://api.github.com/repos/JieCarolHu/roslyn/contributors","subscribers_url":"https://api.github.com/repos/JieCarolHu/roslyn/subscribers","subscription_url":"https://api.github.com/repos/JieCarolHu/roslyn/subscription","commits_url":"https://api.github.com/repos/JieCarolHu/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/JieCarolHu/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/JieCarolHu/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/JieCarolHu/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/JieCarolHu/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/JieCarolHu/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JieCarolHu/roslyn/merges","archive_url":"https://api.github.com/repos/JieCarolHu/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JieCarolHu/roslyn/downloads","issues_url":"https://api.github.com/repos/JieCarolHu/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/JieCarolHu/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/JieCarolHu/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/JieCarolHu/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JieCarolHu/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/JieCarolHu/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/JieCarolHu/roslyn/deployments","created_at":"2018-01-12T23:44:20Z","updated_at":"2018-01-12T23:45:01Z","pushed_at":"2018-05-23T20:45:23Z","git_url":"git://github.com/JieCarolHu/roslyn.git","ssh_url":"git@github.com:JieCarolHu/roslyn.git","clone_url":"https://github.com/JieCarolHu/roslyn.git","svn_url":"https://github.com/JieCarolHu/roslyn","homepage":"","size":343051,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"856331bfb6c984a97c8ea73abc8955349cf1f7ee","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-05-23T19:51:17Z","pushed_at":"2018-05-23T21:02:59Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":378546,"stargazers_count":9338,"watchers_count":9338,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2233,"mirror_url":null,"archived":false,"open_issues_count":4755,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2233,"open_issues":4755,"watchers":9338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26802"},"html":{"href":"https://github.com/dotnet/roslyn/pull/26802"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/26802"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/26802/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26802/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26802/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/7e6905e7b74c3eb18d66454825914003c63e4ed9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":39,"maintainer_can_modify":true,"commits":25,"additions":2301,"deletions":186,"changed_files":69}}
{"actor":{"display_login":"JieCarolHu"}}