{"action":"opened","number":2185,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/2185","id":196245863,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjQ1ODYz","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/2185","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/2185.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/2185.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/2185","number":2185,"state":"open","locked":false,"title":"Extend service account environment variable code to allow including any runtime configurations.","user":{"login":"ivanporty","id":11686100,"node_id":"MDQ6VXNlcjExNjg2MTAw","avatar_url":"https://avatars3.githubusercontent.com/u/11686100?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanporty","html_url":"https://github.com/ivanporty","followers_url":"https://api.github.com/users/ivanporty/followers","following_url":"https://api.github.com/users/ivanporty/following{/other_user}","gists_url":"https://api.github.com/users/ivanporty/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanporty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanporty/subscriptions","organizations_url":"https://api.github.com/users/ivanporty/orgs","repos_url":"https://api.github.com/users/ivanporty/repos","events_url":"https://api.github.com/users/ivanporty/events{/privacy}","received_events_url":"https://api.github.com/users/ivanporty/received_events","type":"User","site_admin":false},"body":"Fixes #2148.\r\n\r\nAlthough this looks like a relatively large PR, most of the code is re-used from the previous AppEngine-only based implementation, but extended to be able to use it for any runtime configurations via extension points.\r\n\r\nThe following is done:\r\n\r\n* `ServiceAccountKeyUltimateDisplayDialog` is moved into `ServiceAccountKeyDisplayDialog` into `google-cloud-apis` without form changes and stripped of any logic of finding and updating runtime configurations.\r\n* `ServiceAccountKeyDialogService` is removed, one common dialog is used now.\r\n* Extension point interface `ServiceAccountKeyRuntimeConfigurationProvider` for collecting runtime configurations and adding environment variables to them is added to `google-cloud-apis`\r\n* App Engine Local Run configuration env variables logic is moved into `AppEngineLocalRunServiceAccountKeyRuntimeConfigurationProvider` extension point.\r\n* Plain Java runtime configuration support is added with `JavaApplicationServiceAccountKeyRuntimeConfigurationProvider` extension point.\r\n* Unit test for `ServiceAccountKeyUltimateDisplayDialog` is split to UI related tests for common dialog and environment variables logic for new extension point.\r\n\r\nCan be now used and tested on both CE (any runtime target with `main()`) and UE (both plain Java and app engine local run targets).\r\n","created_at":"2018-06-20T19:18:56Z","updated_at":"2018-06-20T19:18:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/2185/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/2185/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/2185/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/statuses/d79db91133df5581abe7cf4f1df98df03fcf1891","head":{"label":"GoogleCloudPlatform:add-env-vars","ref":"add-env-vars","sha":"d79db91133df5581abe7cf4f1df98df03fcf1891","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":38834157,"node_id":"MDEwOlJlcG9zaXRvcnkzODgzNDE1Nw==","name":"google-cloud-intellij","full_name":"GoogleCloudPlatform/google-cloud-intellij","owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij","description":"Plugin to support the Google Cloud Platform in IntelliJ IDEA.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/deployments","created_at":"2015-07-09T17:08:59Z","updated_at":"2018-06-20T14:39:36Z","pushed_at":"2018-06-20T19:08:37Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-intellij.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-intellij.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij","homepage":"","size":20410,"stargazers_count":100,"watchers_count":100,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":33,"open_issues":180,"watchers":100,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"8ba9db294105aa547ceb59a3ce21362411e8d5e7","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":38834157,"node_id":"MDEwOlJlcG9zaXRvcnkzODgzNDE1Nw==","name":"google-cloud-intellij","full_name":"GoogleCloudPlatform/google-cloud-intellij","owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij","description":"Plugin to support the Google Cloud Platform in IntelliJ IDEA.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/deployments","created_at":"2015-07-09T17:08:59Z","updated_at":"2018-06-20T14:39:36Z","pushed_at":"2018-06-20T19:08:37Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-intellij.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-intellij.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij","homepage":"","size":20410,"stargazers_count":100,"watchers_count":100,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":33,"open_issues":180,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/2185"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/2185"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/2185"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/2185/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/2185/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/2185/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/statuses/d79db91133df5581abe7cf4f1df98df03fcf1891"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":11,"additions":688,"deletions":541,"changed_files":15}}
{"actor":{"display_login":"ivanporty"}}