{"action":"created","issue":{"url":"https://api.github.com/repos/reactstrap/reactstrap/issues/1287","repository_url":"https://api.github.com/repos/reactstrap/reactstrap","labels_url":"https://api.github.com/repos/reactstrap/reactstrap/issues/1287/labels{/name}","comments_url":"https://api.github.com/repos/reactstrap/reactstrap/issues/1287/comments","events_url":"https://api.github.com/repos/reactstrap/reactstrap/issues/1287/events","html_url":"https://github.com/reactstrap/reactstrap/issues/1287","id":378560274,"node_id":"MDU6SXNzdWUzNzg1NjAyNzQ=","number":1287,"title":"Any character opens Dropdown menu","user":{"login":"eckdanny-osi","id":30477263,"node_id":"MDQ6VXNlcjMwNDc3MjYz","avatar_url":"https://avatars2.githubusercontent.com/u/30477263?v=4","gravatar_id":"","url":"https://api.github.com/users/eckdanny-osi","html_url":"https://github.com/eckdanny-osi","followers_url":"https://api.github.com/users/eckdanny-osi/followers","following_url":"https://api.github.com/users/eckdanny-osi/following{/other_user}","gists_url":"https://api.github.com/users/eckdanny-osi/gists{/gist_id}","starred_url":"https://api.github.com/users/eckdanny-osi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eckdanny-osi/subscriptions","organizations_url":"https://api.github.com/users/eckdanny-osi/orgs","repos_url":"https://api.github.com/users/eckdanny-osi/repos","events_url":"https://api.github.com/users/eckdanny-osi/events{/privacy}","received_events_url":"https://api.github.com/users/eckdanny-osi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-08T03:09:10Z","updated_at":"2018-11-09T09:44:04Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"- components: `Dropdown`\r\n- reactstrap version `6.5.0`\r\n- import method `es`\r\n- react version `16.5.2`\r\n- bootstrap version `4.1.3`\r\n\r\n### What is happening?\r\n\r\nAny key (including e.g.; `Esc` or `Shift`) opens the `Dropdown` menu \r\n\r\n### What should be happening?\r\n\r\nopen the `Dropdown` (aria menu) only when `Enter` is pressed (from [WAI ARIA 1.1](https://www.w3.org/TR/wai-aria-practices-1.1/#menu))\r\n\r\n### Steps to reproduce issue\r\n\r\n1. keyboard nav to put focus on the `DropdownToggle` (the button tag)\r\n2. press a key\r\n\r\n![dropdown-bug](https://user-images.githubusercontent.com/30477263/48175365-8a7f5900-e2c0-11e8-8fcc-077eed673bf5.gif)\r\n\r\n### Code\r\n\r\n[![Edit 1vo8knprml](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/1vo8knprml)\r\n"},"comment":{"url":"https://api.github.com/repos/reactstrap/reactstrap/issues/comments/437305791","html_url":"https://github.com/reactstrap/reactstrap/issues/1287#issuecomment-437305791","issue_url":"https://api.github.com/repos/reactstrap/reactstrap/issues/1287","id":437305791,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzMwNTc5MQ==","user":{"login":"eckdanny-osi","id":30477263,"node_id":"MDQ6VXNlcjMwNDc3MjYz","avatar_url":"https://avatars2.githubusercontent.com/u/30477263?v=4","gravatar_id":"","url":"https://api.github.com/users/eckdanny-osi","html_url":"https://github.com/eckdanny-osi","followers_url":"https://api.github.com/users/eckdanny-osi/followers","following_url":"https://api.github.com/users/eckdanny-osi/following{/other_user}","gists_url":"https://api.github.com/users/eckdanny-osi/gists{/gist_id}","starred_url":"https://api.github.com/users/eckdanny-osi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eckdanny-osi/subscriptions","organizations_url":"https://api.github.com/users/eckdanny-osi/orgs","repos_url":"https://api.github.com/users/eckdanny-osi/repos","events_url":"https://api.github.com/users/eckdanny-osi/events{/privacy}","received_events_url":"https://api.github.com/users/eckdanny-osi/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T09:44:04Z","updated_at":"2018-11-09T09:44:04Z","author_association":"CONTRIBUTOR","body":"I've started working on a fork. 85% satisfied (leaving on road trip tmrw). Hoping to get a PR out early next week to address wai-aria/keyboard-nav improvements to `Dropdown`. The **WiP Branch** is [here](https://github.com/reactstrap/reactstrap/compare/master...eckdanny-osi:fix-dropdown-keyboard-nav?expand=1).\r\n\r\nGist of changes:\r\n\r\n* [x] Home/End key jumps\r\n* [x] up/down wraps\r\n* [x] spacebar enter interchangeable\r\n* [x] aria [role=menuitem]\r\n* [x] 1st item gets focus on menu expand\r\n* [x] misc focus mgmt\r\n* [ ] more tests\r\n* [ ] memoize some stuff\r\n\r\n![dropdown-upstream-pr](https://user-images.githubusercontent.com/30477263/48254716-a3baff00-e3bf-11e8-9b41-d3b592060744.gif)\r\n"}}
{"actor":{"display_login":"eckdanny-osi"}}