{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments/242769403","pull_request_review_id":186360339,"id":242769403,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjc2OTQwMw==","diff_hunk":"@@ -33,14 +33,14 @@ void Profiler::StartProfiling(const std::string& file_name) {\n void Profiler::EndTimeAndRecordEvent(EventCategory category,\n                                      const std::string& event_name,\n                                      TimePoint& start_time,\n-                                     const std::string& op_name,\n+                                     const std::pair<std::string, std::string>& op_name,","path":"onnxruntime/core/common/profiler.cc","position":5,"original_position":5,"commit_id":"e76b54facb785ab61107de2a21b3e7044f40d8fe","original_commit_id":"e76b54facb785ab61107de2a21b3e7044f40d8fe","user":{"login":"zwxxx","id":1248946,"node_id":"MDQ6VXNlcjEyNDg5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1248946?v=4","gravatar_id":"","url":"https://api.github.com/users/zwxxx","html_url":"https://github.com/zwxxx","followers_url":"https://api.github.com/users/zwxxx/followers","following_url":"https://api.github.com/users/zwxxx/following{/other_user}","gists_url":"https://api.github.com/users/zwxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/zwxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwxxx/subscriptions","organizations_url":"https://api.github.com/users/zwxxx/orgs","repos_url":"https://api.github.com/users/zwxxx/repos","events_url":"https://api.github.com/users/zwxxx/events{/privacy}","received_events_url":"https://api.github.com/users/zwxxx/received_events","type":"User","site_admin":false},"body":"events?","created_at":"2018-12-19T01:54:37Z","updated_at":"2018-12-19T01:54:37Z","html_url":"https://github.com/Microsoft/onnxruntime/pull/197#discussion_r242769403","pull_request_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/197","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments/242769403"},"html":{"href":"https://github.com/Microsoft/onnxruntime/pull/197#discussion_r242769403"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/197"}},"in_reply_to_id":242768027},"pull_request":{"url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/197","id":239295237,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5Mjk1MjM3","html_url":"https://github.com/Microsoft/onnxruntime/pull/197","diff_url":"https://github.com/Microsoft/onnxruntime/pull/197.diff","patch_url":"https://github.com/Microsoft/onnxruntime/pull/197.patch","issue_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/197","number":197,"state":"open","locked":false,"title":"Minor profiler refactor to avoid string construction","user":{"login":"zwxxx","id":1248946,"node_id":"MDQ6VXNlcjEyNDg5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1248946?v=4","gravatar_id":"","url":"https://api.github.com/users/zwxxx","html_url":"https://github.com/zwxxx","followers_url":"https://api.github.com/users/zwxxx/followers","following_url":"https://api.github.com/users/zwxxx/following{/other_user}","gists_url":"https://api.github.com/users/zwxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/zwxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwxxx/subscriptions","organizations_url":"https://api.github.com/users/zwxxx/orgs","repos_url":"https://api.github.com/users/zwxxx/repos","events_url":"https://api.github.com/users/zwxxx/events{/privacy}","received_events_url":"https://api.github.com/users/zwxxx/received_events","type":"User","site_admin":false},"body":"std string concatenation allocates. Check if profiler enabled then call EndTimeAndRecordEvent to avoid string construction and allocation. \r\n@pranavsharma\r\n@tracysh","created_at":"2018-12-17T21:50:43Z","updated_at":"2018-12-19T01:54:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f9449504fb9b7232e2aee6a298220aa153a8d38","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/197/commits","review_comments_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/197/comments","review_comment_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/197/comments","statuses_url":"https://api.github.com/repos/Microsoft/onnxruntime/statuses/e76b54facb785ab61107de2a21b3e7044f40d8fe","head":{"label":"zwxxx:refator_profiler","ref":"refator_profiler","sha":"e76b54facb785ab61107de2a21b3e7044f40d8fe","user":{"login":"zwxxx","id":1248946,"node_id":"MDQ6VXNlcjEyNDg5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1248946?v=4","gravatar_id":"","url":"https://api.github.com/users/zwxxx","html_url":"https://github.com/zwxxx","followers_url":"https://api.github.com/users/zwxxx/followers","following_url":"https://api.github.com/users/zwxxx/following{/other_user}","gists_url":"https://api.github.com/users/zwxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/zwxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwxxx/subscriptions","organizations_url":"https://api.github.com/users/zwxxx/orgs","repos_url":"https://api.github.com/users/zwxxx/repos","events_url":"https://api.github.com/users/zwxxx/events{/privacy}","received_events_url":"https://api.github.com/users/zwxxx/received_events","type":"User","site_admin":false},"repo":{"id":161570686,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE1NzA2ODY=","name":"onnxruntime","full_name":"zwxxx/onnxruntime","private":false,"owner":{"login":"zwxxx","id":1248946,"node_id":"MDQ6VXNlcjEyNDg5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1248946?v=4","gravatar_id":"","url":"https://api.github.com/users/zwxxx","html_url":"https://github.com/zwxxx","followers_url":"https://api.github.com/users/zwxxx/followers","following_url":"https://api.github.com/users/zwxxx/following{/other_user}","gists_url":"https://api.github.com/users/zwxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/zwxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwxxx/subscriptions","organizations_url":"https://api.github.com/users/zwxxx/orgs","repos_url":"https://api.github.com/users/zwxxx/repos","events_url":"https://api.github.com/users/zwxxx/events{/privacy}","received_events_url":"https://api.github.com/users/zwxxx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zwxxx/onnxruntime","description":"ONNX Runtime","fork":true,"url":"https://api.github.com/repos/zwxxx/onnxruntime","forks_url":"https://api.github.com/repos/zwxxx/onnxruntime/forks","keys_url":"https://api.github.com/repos/zwxxx/onnxruntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zwxxx/onnxruntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zwxxx/onnxruntime/teams","hooks_url":"https://api.github.com/repos/zwxxx/onnxruntime/hooks","issue_events_url":"https://api.github.com/repos/zwxxx/onnxruntime/issues/events{/number}","events_url":"https://api.github.com/repos/zwxxx/onnxruntime/events","assignees_url":"https://api.github.com/repos/zwxxx/onnxruntime/assignees{/user}","branches_url":"https://api.github.com/repos/zwxxx/onnxruntime/branches{/branch}","tags_url":"https://api.github.com/repos/zwxxx/onnxruntime/tags","blobs_url":"https://api.github.com/repos/zwxxx/onnxruntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zwxxx/onnxruntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zwxxx/onnxruntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/zwxxx/onnxruntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zwxxx/onnxruntime/statuses/{sha}","languages_url":"https://api.github.com/repos/zwxxx/onnxruntime/languages","stargazers_url":"https://api.github.com/repos/zwxxx/onnxruntime/stargazers","contributors_url":"https://api.github.com/repos/zwxxx/onnxruntime/contributors","subscribers_url":"https://api.github.com/repos/zwxxx/onnxruntime/subscribers","subscription_url":"https://api.github.com/repos/zwxxx/onnxruntime/subscription","commits_url":"https://api.github.com/repos/zwxxx/onnxruntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/zwxxx/onnxruntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/zwxxx/onnxruntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/zwxxx/onnxruntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/zwxxx/onnxruntime/contents/{+path}","compare_url":"https://api.github.com/repos/zwxxx/onnxruntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zwxxx/onnxruntime/merges","archive_url":"https://api.github.com/repos/zwxxx/onnxruntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zwxxx/onnxruntime/downloads","issues_url":"https://api.github.com/repos/zwxxx/onnxruntime/issues{/number}","pulls_url":"https://api.github.com/repos/zwxxx/onnxruntime/pulls{/number}","milestones_url":"https://api.github.com/repos/zwxxx/onnxruntime/milestones{/number}","notifications_url":"https://api.github.com/repos/zwxxx/onnxruntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zwxxx/onnxruntime/labels{/name}","releases_url":"https://api.github.com/repos/zwxxx/onnxruntime/releases{/id}","deployments_url":"https://api.github.com/repos/zwxxx/onnxruntime/deployments","created_at":"2018-12-13T02:06:43Z","updated_at":"2018-12-17T19:42:30Z","pushed_at":"2018-12-18T20:50:42Z","git_url":"git://github.com/zwxxx/onnxruntime.git","ssh_url":"git@github.com:zwxxx/onnxruntime.git","clone_url":"https://github.com/zwxxx/onnxruntime.git","svn_url":"https://github.com/zwxxx/onnxruntime","homepage":null,"size":20509,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"d0544a80824de2fd3d18cc60dd39f99f2c781d9d","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":156939672,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5Mzk2NzI=","name":"onnxruntime","full_name":"Microsoft/onnxruntime","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/onnxruntime","description":"ONNX Runtime","fork":false,"url":"https://api.github.com/repos/Microsoft/onnxruntime","forks_url":"https://api.github.com/repos/Microsoft/onnxruntime/forks","keys_url":"https://api.github.com/repos/Microsoft/onnxruntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/onnxruntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/onnxruntime/teams","hooks_url":"https://api.github.com/repos/Microsoft/onnxruntime/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/onnxruntime/events","assignees_url":"https://api.github.com/repos/Microsoft/onnxruntime/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/onnxruntime/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/onnxruntime/tags","blobs_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/onnxruntime/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/onnxruntime/languages","stargazers_url":"https://api.github.com/repos/Microsoft/onnxruntime/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/onnxruntime/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/onnxruntime/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/onnxruntime/subscription","commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/onnxruntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/onnxruntime/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/onnxruntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/onnxruntime/merges","archive_url":"https://api.github.com/repos/Microsoft/onnxruntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/onnxruntime/downloads","issues_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/onnxruntime/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/onnxruntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/onnxruntime/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/onnxruntime/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/onnxruntime/deployments","created_at":"2018-11-10T02:22:53Z","updated_at":"2018-12-18T23:25:47Z","pushed_at":"2018-12-19T01:52:32Z","git_url":"git://github.com/Microsoft/onnxruntime.git","ssh_url":"git@github.com:Microsoft/onnxruntime.git","clone_url":"https://github.com/Microsoft/onnxruntime.git","svn_url":"https://github.com/Microsoft/onnxruntime","homepage":null,"size":28649,"stargazers_count":408,"watchers_count":408,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":57,"open_issues":27,"watchers":408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/197"},"html":{"href":"https://github.com/Microsoft/onnxruntime/pull/197"},"issue":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/issues/197"},"comments":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/statuses/e76b54facb785ab61107de2a21b3e7044f40d8fe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zwxxx"}}