{"action":"created","issue":{"url":"https://api.github.com/repos/mozafari/verdictdb/issues/322","repository_url":"https://api.github.com/repos/mozafari/verdictdb","labels_url":"https://api.github.com/repos/mozafari/verdictdb/issues/322/labels{/name}","comments_url":"https://api.github.com/repos/mozafari/verdictdb/issues/322/comments","events_url":"https://api.github.com/repos/mozafari/verdictdb/issues/322/events","html_url":"https://github.com/mozafari/verdictdb/pull/322","id":386640117,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MzEyNzc5","number":322,"title":"Fix nullptr exception when aggregate column contains null value","user":{"login":"Beastjoe","id":20832758,"node_id":"MDQ6VXNlcjIwODMyNzU4","avatar_url":"https://avatars3.githubusercontent.com/u/20832758?v=4","gravatar_id":"","url":"https://api.github.com/users/Beastjoe","html_url":"https://github.com/Beastjoe","followers_url":"https://api.github.com/users/Beastjoe/followers","following_url":"https://api.github.com/users/Beastjoe/following{/other_user}","gists_url":"https://api.github.com/users/Beastjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/Beastjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beastjoe/subscriptions","organizations_url":"https://api.github.com/users/Beastjoe/orgs","repos_url":"https://api.github.com/users/Beastjoe/repos","events_url":"https://api.github.com/users/Beastjoe/events{/privacy}","received_events_url":"https://api.github.com/users/Beastjoe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-12-03T02:57:52Z","updated_at":"2018-12-04T03:10:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mozafari/verdictdb/pulls/322","html_url":"https://github.com/mozafari/verdictdb/pull/322","diff_url":"https://github.com/mozafari/verdictdb/pull/322.diff","patch_url":"https://github.com/mozafari/verdictdb/pull/322.patch"},"body":"Related issue #321.\r\n\r\nThe problem is in the execution of selectAsyncAggNode, where H2 jdbc driver will return NULL value if no rows are selected for aggregating. I think adding the check inside QueryResultAccuracyEstimatorFromDifference is enough, since DbmsQueryResult will interpret NULL as 0 automatically."},"comment":{"url":"https://api.github.com/repos/mozafari/verdictdb/issues/comments/443954464","html_url":"https://github.com/mozafari/verdictdb/pull/322#issuecomment-443954464","issue_url":"https://api.github.com/repos/mozafari/verdictdb/issues/322","id":443954464,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mzk1NDQ2NA==","user":{"login":"Beastjoe","id":20832758,"node_id":"MDQ6VXNlcjIwODMyNzU4","avatar_url":"https://avatars3.githubusercontent.com/u/20832758?v=4","gravatar_id":"","url":"https://api.github.com/users/Beastjoe","html_url":"https://github.com/Beastjoe","followers_url":"https://api.github.com/users/Beastjoe/followers","following_url":"https://api.github.com/users/Beastjoe/following{/other_user}","gists_url":"https://api.github.com/users/Beastjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/Beastjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beastjoe/subscriptions","organizations_url":"https://api.github.com/users/Beastjoe/orgs","repos_url":"https://api.github.com/users/Beastjoe/repos","events_url":"https://api.github.com/users/Beastjoe/events{/privacy}","received_events_url":"https://api.github.com/users/Beastjoe/received_events","type":"User","site_admin":false},"created_at":"2018-12-04T03:10:49Z","updated_at":"2018-12-04T03:10:49Z","author_association":"CONTRIBUTOR","body":"Since we sum up the aggregate values in selectAsyncAggExecutionNode, count() will also return NULL if no rows are selected. Does it matter?"}}
{"actor":{"display_login":"Beastjoe"}}