{"action":"created","issue":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/3078","repository_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap","labels_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/3078/labels{/name}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/3078/comments","events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/3078/events","html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/3078","id":305863394,"number":3078,"title":"V4 support - Modal","user":{"login":"jeffreyroshan","id":2136271,"avatar_url":"https://avatars3.githubusercontent.com/u/2136271?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffreyroshan","html_url":"https://github.com/jeffreyroshan","followers_url":"https://api.github.com/users/jeffreyroshan/followers","following_url":"https://api.github.com/users/jeffreyroshan/following{/other_user}","gists_url":"https://api.github.com/users/jeffreyroshan/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffreyroshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffreyroshan/subscriptions","organizations_url":"https://api.github.com/users/jeffreyroshan/orgs","repos_url":"https://api.github.com/users/jeffreyroshan/repos","events_url":"https://api.github.com/users/jeffreyroshan/events{/privacy}","received_events_url":"https://api.github.com/users/jeffreyroshan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-16T09:52:08Z","updated_at":"2018-03-20T10:07:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/3078","html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/3078","diff_url":"https://github.com/react-bootstrap/react-bootstrap/pull/3078.diff","patch_url":"https://github.com/react-bootstrap/react-bootstrap/pull/3078.patch"},"body":"# Changes\r\n\r\n- Fixed close button alignment\r\n- Updated example doc page\r\n- Added **vertically centered modal** in example\r\n- Added **centered** prop (bool) in Modal\r\n- Added **modal with grid layout** in example\r\n\r\n# Screenshot\r\n\r\n![modal-static](https://user-images.githubusercontent.com/2136271/37514273-76e5abc6-292d-11e8-95ba-a20e3a710739.png)\r\n![modal-basic](https://user-images.githubusercontent.com/2136271/37514274-7749115c-292d-11e8-8c26-7d003d2a5935.png)\r\n![modal-basic-close](https://user-images.githubusercontent.com/2136271/37514276-779f9112-292d-11e8-9242-31ec51c7bf82.png)\r\n![modal-container](https://user-images.githubusercontent.com/2136271/37514278-780e0de0-292d-11e8-970d-28523f31ea0b.png)\r\n![modal-small](https://user-images.githubusercontent.com/2136271/37514280-786f8386-292d-11e8-8407-1626d0fa3cba.png)\r\n![modal-large](https://user-images.githubusercontent.com/2136271/37514281-78c6d5be-292d-11e8-9f94-ca955fd9a173.png)\r\n![modal-custom-size](https://user-images.githubusercontent.com/2136271/37514282-79dff89a-292d-11e8-92c5-c00005e31c39.png)\r\n\r\n## Vertically centered modal\r\n![modal-centered](https://user-images.githubusercontent.com/2136271/37514308-8f076870-292d-11e8-944b-ae907416be2b.png)\r\n\r\n## Using grid in modal\r\n![modal-grid](https://user-images.githubusercontent.com/2136271/37514291-7f5daf42-292d-11e8-94ef-95c9bd2985f4.png)\r\n\r\n## New prop in Modal: centered (bool)\r\n![modal-prop-centered](https://user-images.githubusercontent.com/2136271/37514292-7fc1a68c-292d-11e8-8c2c-fda50541471c.png)\r\n\r\n\r\n### Need help with\r\n\r\n- How do I run specific test files?\r\n- Do we have a checklist for the Modal migration?\r\n"},"comment":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/comments/374541722","html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/3078#issuecomment-374541722","issue_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/3078","id":374541722,"user":{"login":"jeffreyroshan","id":2136271,"avatar_url":"https://avatars3.githubusercontent.com/u/2136271?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffreyroshan","html_url":"https://github.com/jeffreyroshan","followers_url":"https://api.github.com/users/jeffreyroshan/followers","following_url":"https://api.github.com/users/jeffreyroshan/following{/other_user}","gists_url":"https://api.github.com/users/jeffreyroshan/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffreyroshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffreyroshan/subscriptions","organizations_url":"https://api.github.com/users/jeffreyroshan/orgs","repos_url":"https://api.github.com/users/jeffreyroshan/repos","events_url":"https://api.github.com/users/jeffreyroshan/events{/privacy}","received_events_url":"https://api.github.com/users/jeffreyroshan/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T10:07:38Z","updated_at":"2018-03-20T10:07:38Z","author_association":"NONE","body":"@jquense after recent merge, I am getting the following error on `yarn run develop`\r\n\r\n```\r\n$ yarn run develop\r\nyarn run v1.5.1\r\n$ gatsby develop\r\nsuccess delete html and css files from previous builds — 0.020 s\r\nerror We encountered an error while trying to load your site's gatsby-config.js. Please fix the error and try again.\r\n\r\n\r\n  Error: /Work/Github/react-bootstrap/www/  gatsby-config.js:12\r\n    ...require('../.babelrc.js'),\r\n    ^^^\r\n  SyntaxError: Unexpected token ...\r\n```"}}
{"actor":{"display_login":"jeffreyroshan"}}