{"action":"opened","number":210,"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/pulls/210","id":193593747,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTkzNzQ3","html_url":"https://github.com/voxpupuli/puppet-prometheus/pull/210","diff_url":"https://github.com/voxpupuli/puppet-prometheus/pull/210.diff","patch_url":"https://github.com/voxpupuli/puppet-prometheus/pull/210.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/issues/210","number":210,"state":"open","locked":false,"title":"start-stop scripts get vars from prometheus::server scope","user":{"login":"edevreede","id":31131387,"node_id":"MDQ6VXNlcjMxMTMxMzg3","avatar_url":"https://avatars1.githubusercontent.com/u/31131387?v=4","gravatar_id":"","url":"https://api.github.com/users/edevreede","html_url":"https://github.com/edevreede","followers_url":"https://api.github.com/users/edevreede/followers","following_url":"https://api.github.com/users/edevreede/following{/other_user}","gists_url":"https://api.github.com/users/edevreede/gists{/gist_id}","starred_url":"https://api.github.com/users/edevreede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edevreede/subscriptions","organizations_url":"https://api.github.com/users/edevreede/orgs","repos_url":"https://api.github.com/users/edevreede/repos","events_url":"https://api.github.com/users/edevreede/events{/privacy}","received_events_url":"https://api.github.com/users/edevreede/received_events","type":"User","site_admin":false},"body":"#### Pull Request (PR) description\r\nMoving server install to prometheus::server class should also mean start-stop scripts take their parameters from this class, not the prometheus class.\r\n\r\n#### This Pull Request (PR) fixes the following issues\r\nCurrent implementation does not honour the setting like bin_dir to prometheus::server class. Which creates issues like installing from package (on Debian).\r\n\r\nI did not open a issue myself, what I see is much like issue #62, this fix works for me when installing the server from package on Debian stretch.\r\n \r\nFixes #62 ","created_at":"2018-06-08T12:04:34Z","updated_at":"2018-06-08T12:04:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/pulls/210/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/pulls/210/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/issues/210/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/statuses/7d35c423480439fede283254b42c60b8cb643946","head":{"label":"edevreede:fix_start_stop","ref":"fix_start_stop","sha":"7d35c423480439fede283254b42c60b8cb643946","user":{"login":"edevreede","id":31131387,"node_id":"MDQ6VXNlcjMxMTMxMzg3","avatar_url":"https://avatars1.githubusercontent.com/u/31131387?v=4","gravatar_id":"","url":"https://api.github.com/users/edevreede","html_url":"https://github.com/edevreede","followers_url":"https://api.github.com/users/edevreede/followers","following_url":"https://api.github.com/users/edevreede/following{/other_user}","gists_url":"https://api.github.com/users/edevreede/gists{/gist_id}","starred_url":"https://api.github.com/users/edevreede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edevreede/subscriptions","organizations_url":"https://api.github.com/users/edevreede/orgs","repos_url":"https://api.github.com/users/edevreede/repos","events_url":"https://api.github.com/users/edevreede/events{/privacy}","received_events_url":"https://api.github.com/users/edevreede/received_events","type":"User","site_admin":false},"repo":{"id":136611640,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MTE2NDA=","name":"puppet-prometheus","full_name":"edevreede/puppet-prometheus","owner":{"login":"edevreede","id":31131387,"node_id":"MDQ6VXNlcjMxMTMxMzg3","avatar_url":"https://avatars1.githubusercontent.com/u/31131387?v=4","gravatar_id":"","url":"https://api.github.com/users/edevreede","html_url":"https://github.com/edevreede","followers_url":"https://api.github.com/users/edevreede/followers","following_url":"https://api.github.com/users/edevreede/following{/other_user}","gists_url":"https://api.github.com/users/edevreede/gists{/gist_id}","starred_url":"https://api.github.com/users/edevreede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edevreede/subscriptions","organizations_url":"https://api.github.com/users/edevreede/orgs","repos_url":"https://api.github.com/users/edevreede/repos","events_url":"https://api.github.com/users/edevreede/events{/privacy}","received_events_url":"https://api.github.com/users/edevreede/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edevreede/puppet-prometheus","description":"Puppet module for prometheus","fork":true,"url":"https://api.github.com/repos/edevreede/puppet-prometheus","forks_url":"https://api.github.com/repos/edevreede/puppet-prometheus/forks","keys_url":"https://api.github.com/repos/edevreede/puppet-prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edevreede/puppet-prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edevreede/puppet-prometheus/teams","hooks_url":"https://api.github.com/repos/edevreede/puppet-prometheus/hooks","issue_events_url":"https://api.github.com/repos/edevreede/puppet-prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/edevreede/puppet-prometheus/events","assignees_url":"https://api.github.com/repos/edevreede/puppet-prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/edevreede/puppet-prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/edevreede/puppet-prometheus/tags","blobs_url":"https://api.github.com/repos/edevreede/puppet-prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edevreede/puppet-prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edevreede/puppet-prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/edevreede/puppet-prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edevreede/puppet-prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/edevreede/puppet-prometheus/languages","stargazers_url":"https://api.github.com/repos/edevreede/puppet-prometheus/stargazers","contributors_url":"https://api.github.com/repos/edevreede/puppet-prometheus/contributors","subscribers_url":"https://api.github.com/repos/edevreede/puppet-prometheus/subscribers","subscription_url":"https://api.github.com/repos/edevreede/puppet-prometheus/subscription","commits_url":"https://api.github.com/repos/edevreede/puppet-prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/edevreede/puppet-prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/edevreede/puppet-prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/edevreede/puppet-prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/edevreede/puppet-prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/edevreede/puppet-prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edevreede/puppet-prometheus/merges","archive_url":"https://api.github.com/repos/edevreede/puppet-prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edevreede/puppet-prometheus/downloads","issues_url":"https://api.github.com/repos/edevreede/puppet-prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/edevreede/puppet-prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/edevreede/puppet-prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/edevreede/puppet-prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edevreede/puppet-prometheus/labels{/name}","releases_url":"https://api.github.com/repos/edevreede/puppet-prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/edevreede/puppet-prometheus/deployments","created_at":"2018-06-08T11:43:52Z","updated_at":"2018-06-08T11:43:54Z","pushed_at":"2018-06-08T11:49:26Z","git_url":"git://github.com/edevreede/puppet-prometheus.git","ssh_url":"git@github.com:edevreede/puppet-prometheus.git","clone_url":"https://github.com/edevreede/puppet-prometheus.git","svn_url":"https://github.com/edevreede/puppet-prometheus","homepage":null,"size":508,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"acb4f1b193489e596017aea7a9c1fe6dbf440ab5","user":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":52801143,"node_id":"MDEwOlJlcG9zaXRvcnk1MjgwMTE0Mw==","name":"puppet-prometheus","full_name":"voxpupuli/puppet-prometheus","owner":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxpupuli/puppet-prometheus","description":"Puppet module for prometheus","fork":true,"url":"https://api.github.com/repos/voxpupuli/puppet-prometheus","forks_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-prometheus/deployments","created_at":"2016-02-29T15:20:39Z","updated_at":"2018-06-05T09:36:28Z","pushed_at":"2018-06-06T10:53:27Z","git_url":"git://github.com/voxpupuli/puppet-prometheus.git","ssh_url":"git@github.com:voxpupuli/puppet-prometheus.git","clone_url":"https://github.com/voxpupuli/puppet-prometheus.git","svn_url":"https://github.com/voxpupuli/puppet-prometheus","homepage":null,"size":508,"stargazers_count":31,"watchers_count":31,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":105,"open_issues":28,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-prometheus/pulls/210"},"html":{"href":"https://github.com/voxpupuli/puppet-prometheus/pull/210"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-prometheus/issues/210"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-prometheus/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-prometheus/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-prometheus/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-prometheus/statuses/7d35c423480439fede283254b42c60b8cb643946"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":25,"deletions":25,"changed_files":6}}
{"actor":{"display_login":"edevreede"}}