{"action":"created","comment":{"url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/comments/217494632","pull_request_review_id":155221594,"id":217494632,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzQ5NDYzMg==","diff_hunk":"@@ -265,13 +278,22 @@ def get_entry_val(k):\n \n     async def _create_new_category(self, category_name, category_val, category_description):\n         try:\n+            if isinstance(category_val, dict):\n+                new_category_val = copy.deepcopy(category_val)\n+                # Remove \"deprecated\" items from a new category configuration\n+                for i, v in category_val.items():\n+                    if 'deprecated' in v:\n+                        new_category_val.pop(i)\n+            else:\n+                new_category_val = category_val\n+\n             audit = AuditLogger(self._storage)\n-            await audit.information('CONAD', {'name': category_name, 'category': category_val})\n+            await audit.information('CONAD', {'name': category_name, 'category': new_category_val})\n             payload = PayloadBuilder().INSERT(key=category_name, description=category_description,\n-                                              value=category_val).payload()\n+                                              value=new_category_val).payload()\n             result = await self._storage.insert_into_tbl(\"configuration\", payload)\n             response = result['response']\n-            self._cacheManager.update(category_name, category_val)\n+            self._cacheManager.update(category_name, new_category_val)","path":"python/foglamp/common/configuration_manager.py","position":73,"original_position":73,"commit_id":"7b1f448a1d5a3bde32b033155afa5af5b806f9e3","original_commit_id":"7b1f448a1d5a3bde32b033155afa5af5b806f9e3","user":{"login":"praveen-garg","id":1974003,"node_id":"MDQ6VXNlcjE5NzQwMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1974003?v=4","gravatar_id":"","url":"https://api.github.com/users/praveen-garg","html_url":"https://github.com/praveen-garg","followers_url":"https://api.github.com/users/praveen-garg/followers","following_url":"https://api.github.com/users/praveen-garg/following{/other_user}","gists_url":"https://api.github.com/users/praveen-garg/gists{/gist_id}","starred_url":"https://api.github.com/users/praveen-garg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveen-garg/subscriptions","organizations_url":"https://api.github.com/users/praveen-garg/orgs","repos_url":"https://api.github.com/users/praveen-garg/repos","events_url":"https://api.github.com/users/praveen-garg/events{/privacy}","received_events_url":"https://api.github.com/users/praveen-garg/received_events","type":"User","site_admin":false},"body":"We should save the value as saved and returned in the DB. ","created_at":"2018-09-13T18:48:11Z","updated_at":"2018-09-13T18:48:11Z","html_url":"https://github.com/foglamp/FogLAMP/pull/1106#discussion_r217494632","pull_request_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1106","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/comments/217494632"},"html":{"href":"https://github.com/foglamp/FogLAMP/pull/1106#discussion_r217494632"},"pull_request":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1106"}}},"pull_request":{"url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1106","id":215282241,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MjgyMjQx","html_url":"https://github.com/foglamp/FogLAMP/pull/1106","diff_url":"https://github.com/foglamp/FogLAMP/pull/1106.diff","patch_url":"https://github.com/foglamp/FogLAMP/pull/1106.patch","issue_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/1106","number":1106,"state":"open","locked":false,"title":"FOGL-1673 - Updated plugin should delete obsolete config items","user":{"login":"amarendra-dianomic","id":27818158,"node_id":"MDQ6VXNlcjI3ODE4MTU4","avatar_url":"https://avatars0.githubusercontent.com/u/27818158?v=4","gravatar_id":"","url":"https://api.github.com/users/amarendra-dianomic","html_url":"https://github.com/amarendra-dianomic","followers_url":"https://api.github.com/users/amarendra-dianomic/followers","following_url":"https://api.github.com/users/amarendra-dianomic/following{/other_user}","gists_url":"https://api.github.com/users/amarendra-dianomic/gists{/gist_id}","starred_url":"https://api.github.com/users/amarendra-dianomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarendra-dianomic/subscriptions","organizations_url":"https://api.github.com/users/amarendra-dianomic/orgs","repos_url":"https://api.github.com/users/amarendra-dianomic/repos","events_url":"https://api.github.com/users/amarendra-dianomic/events{/privacy}","received_events_url":"https://api.github.com/users/amarendra-dianomic/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-13T13:26:49Z","updated_at":"2018-09-13T18:48:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"824526ffcedb92074fd28c5650258723ce746ab6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Singhal-Vaibhav","id":27723439,"node_id":"MDQ6VXNlcjI3NzIzNDM5","avatar_url":"https://avatars0.githubusercontent.com/u/27723439?v=4","gravatar_id":"","url":"https://api.github.com/users/Singhal-Vaibhav","html_url":"https://github.com/Singhal-Vaibhav","followers_url":"https://api.github.com/users/Singhal-Vaibhav/followers","following_url":"https://api.github.com/users/Singhal-Vaibhav/following{/other_user}","gists_url":"https://api.github.com/users/Singhal-Vaibhav/gists{/gist_id}","starred_url":"https://api.github.com/users/Singhal-Vaibhav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Singhal-Vaibhav/subscriptions","organizations_url":"https://api.github.com/users/Singhal-Vaibhav/orgs","repos_url":"https://api.github.com/users/Singhal-Vaibhav/repos","events_url":"https://api.github.com/users/Singhal-Vaibhav/events{/privacy}","received_events_url":"https://api.github.com/users/Singhal-Vaibhav/received_events","type":"User","site_admin":false},{"login":"ashish-jabble","id":27723735,"node_id":"MDQ6VXNlcjI3NzIzNzM1","avatar_url":"https://avatars0.githubusercontent.com/u/27723735?v=4","gravatar_id":"","url":"https://api.github.com/users/ashish-jabble","html_url":"https://github.com/ashish-jabble","followers_url":"https://api.github.com/users/ashish-jabble/followers","following_url":"https://api.github.com/users/ashish-jabble/following{/other_user}","gists_url":"https://api.github.com/users/ashish-jabble/gists{/gist_id}","starred_url":"https://api.github.com/users/ashish-jabble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashish-jabble/subscriptions","organizations_url":"https://api.github.com/users/ashish-jabble/orgs","repos_url":"https://api.github.com/users/ashish-jabble/repos","events_url":"https://api.github.com/users/ashish-jabble/events{/privacy}","received_events_url":"https://api.github.com/users/ashish-jabble/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":684030137,"node_id":"MDU6TGFiZWw2ODQwMzAxMzc=","url":"https://api.github.com/repos/foglamp/FogLAMP/labels/architectural_review_pending","name":"architectural_review_pending","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1106/commits","review_comments_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1106/comments","review_comment_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/1106/comments","statuses_url":"https://api.github.com/repos/foglamp/FogLAMP/statuses/7b1f448a1d5a3bde32b033155afa5af5b806f9e3","head":{"label":"foglamp:FOGL-1673","ref":"FOGL-1673","sha":"7b1f448a1d5a3bde32b033155afa5af5b806f9e3","user":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"repo":{"id":88887957,"node_id":"MDEwOlJlcG9zaXRvcnk4ODg4Nzk1Nw==","name":"FogLAMP","full_name":"foglamp/FogLAMP","owner":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/foglamp/FogLAMP","description":"An open source platform for the Internet of Things, it acts as an edge gateway between sensor devices and cloud storage systems","fork":false,"url":"https://api.github.com/repos/foglamp/FogLAMP","forks_url":"https://api.github.com/repos/foglamp/FogLAMP/forks","keys_url":"https://api.github.com/repos/foglamp/FogLAMP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foglamp/FogLAMP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foglamp/FogLAMP/teams","hooks_url":"https://api.github.com/repos/foglamp/FogLAMP/hooks","issue_events_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/events{/number}","events_url":"https://api.github.com/repos/foglamp/FogLAMP/events","assignees_url":"https://api.github.com/repos/foglamp/FogLAMP/assignees{/user}","branches_url":"https://api.github.com/repos/foglamp/FogLAMP/branches{/branch}","tags_url":"https://api.github.com/repos/foglamp/FogLAMP/tags","blobs_url":"https://api.github.com/repos/foglamp/FogLAMP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foglamp/FogLAMP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foglamp/FogLAMP/git/refs{/sha}","trees_url":"https://api.github.com/repos/foglamp/FogLAMP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foglamp/FogLAMP/statuses/{sha}","languages_url":"https://api.github.com/repos/foglamp/FogLAMP/languages","stargazers_url":"https://api.github.com/repos/foglamp/FogLAMP/stargazers","contributors_url":"https://api.github.com/repos/foglamp/FogLAMP/contributors","subscribers_url":"https://api.github.com/repos/foglamp/FogLAMP/subscribers","subscription_url":"https://api.github.com/repos/foglamp/FogLAMP/subscription","commits_url":"https://api.github.com/repos/foglamp/FogLAMP/commits{/sha}","git_commits_url":"https://api.github.com/repos/foglamp/FogLAMP/git/commits{/sha}","comments_url":"https://api.github.com/repos/foglamp/FogLAMP/comments{/number}","issue_comment_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/comments{/number}","contents_url":"https://api.github.com/repos/foglamp/FogLAMP/contents/{+path}","compare_url":"https://api.github.com/repos/foglamp/FogLAMP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foglamp/FogLAMP/merges","archive_url":"https://api.github.com/repos/foglamp/FogLAMP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foglamp/FogLAMP/downloads","issues_url":"https://api.github.com/repos/foglamp/FogLAMP/issues{/number}","pulls_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls{/number}","milestones_url":"https://api.github.com/repos/foglamp/FogLAMP/milestones{/number}","notifications_url":"https://api.github.com/repos/foglamp/FogLAMP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foglamp/FogLAMP/labels{/name}","releases_url":"https://api.github.com/repos/foglamp/FogLAMP/releases{/id}","deployments_url":"https://api.github.com/repos/foglamp/FogLAMP/deployments","created_at":"2017-04-20T16:35:27Z","updated_at":"2018-09-13T18:06:56Z","pushed_at":"2018-09-13T18:06:53Z","git_url":"git://github.com/foglamp/FogLAMP.git","ssh_url":"git@github.com:foglamp/FogLAMP.git","clone_url":"https://github.com/foglamp/FogLAMP.git","svn_url":"https://github.com/foglamp/FogLAMP","homepage":"http://foglamp.readthedocs.io/","size":14625,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":7,"watchers":27,"default_branch":"develop"}},"base":{"label":"foglamp:develop","ref":"develop","sha":"90ee7879cd2bceb7efc09b53ba225c02ad0c71e5","user":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"repo":{"id":88887957,"node_id":"MDEwOlJlcG9zaXRvcnk4ODg4Nzk1Nw==","name":"FogLAMP","full_name":"foglamp/FogLAMP","owner":{"login":"foglamp","id":27822234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODIyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/27822234?v=4","gravatar_id":"","url":"https://api.github.com/users/foglamp","html_url":"https://github.com/foglamp","followers_url":"https://api.github.com/users/foglamp/followers","following_url":"https://api.github.com/users/foglamp/following{/other_user}","gists_url":"https://api.github.com/users/foglamp/gists{/gist_id}","starred_url":"https://api.github.com/users/foglamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foglamp/subscriptions","organizations_url":"https://api.github.com/users/foglamp/orgs","repos_url":"https://api.github.com/users/foglamp/repos","events_url":"https://api.github.com/users/foglamp/events{/privacy}","received_events_url":"https://api.github.com/users/foglamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/foglamp/FogLAMP","description":"An open source platform for the Internet of Things, it acts as an edge gateway between sensor devices and cloud storage systems","fork":false,"url":"https://api.github.com/repos/foglamp/FogLAMP","forks_url":"https://api.github.com/repos/foglamp/FogLAMP/forks","keys_url":"https://api.github.com/repos/foglamp/FogLAMP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foglamp/FogLAMP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foglamp/FogLAMP/teams","hooks_url":"https://api.github.com/repos/foglamp/FogLAMP/hooks","issue_events_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/events{/number}","events_url":"https://api.github.com/repos/foglamp/FogLAMP/events","assignees_url":"https://api.github.com/repos/foglamp/FogLAMP/assignees{/user}","branches_url":"https://api.github.com/repos/foglamp/FogLAMP/branches{/branch}","tags_url":"https://api.github.com/repos/foglamp/FogLAMP/tags","blobs_url":"https://api.github.com/repos/foglamp/FogLAMP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foglamp/FogLAMP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foglamp/FogLAMP/git/refs{/sha}","trees_url":"https://api.github.com/repos/foglamp/FogLAMP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foglamp/FogLAMP/statuses/{sha}","languages_url":"https://api.github.com/repos/foglamp/FogLAMP/languages","stargazers_url":"https://api.github.com/repos/foglamp/FogLAMP/stargazers","contributors_url":"https://api.github.com/repos/foglamp/FogLAMP/contributors","subscribers_url":"https://api.github.com/repos/foglamp/FogLAMP/subscribers","subscription_url":"https://api.github.com/repos/foglamp/FogLAMP/subscription","commits_url":"https://api.github.com/repos/foglamp/FogLAMP/commits{/sha}","git_commits_url":"https://api.github.com/repos/foglamp/FogLAMP/git/commits{/sha}","comments_url":"https://api.github.com/repos/foglamp/FogLAMP/comments{/number}","issue_comment_url":"https://api.github.com/repos/foglamp/FogLAMP/issues/comments{/number}","contents_url":"https://api.github.com/repos/foglamp/FogLAMP/contents/{+path}","compare_url":"https://api.github.com/repos/foglamp/FogLAMP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foglamp/FogLAMP/merges","archive_url":"https://api.github.com/repos/foglamp/FogLAMP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foglamp/FogLAMP/downloads","issues_url":"https://api.github.com/repos/foglamp/FogLAMP/issues{/number}","pulls_url":"https://api.github.com/repos/foglamp/FogLAMP/pulls{/number}","milestones_url":"https://api.github.com/repos/foglamp/FogLAMP/milestones{/number}","notifications_url":"https://api.github.com/repos/foglamp/FogLAMP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foglamp/FogLAMP/labels{/name}","releases_url":"https://api.github.com/repos/foglamp/FogLAMP/releases{/id}","deployments_url":"https://api.github.com/repos/foglamp/FogLAMP/deployments","created_at":"2017-04-20T16:35:27Z","updated_at":"2018-09-13T18:06:56Z","pushed_at":"2018-09-13T18:06:53Z","git_url":"git://github.com/foglamp/FogLAMP.git","ssh_url":"git@github.com:foglamp/FogLAMP.git","clone_url":"https://github.com/foglamp/FogLAMP.git","svn_url":"https://github.com/foglamp/FogLAMP","homepage":"http://foglamp.readthedocs.io/","size":14625,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":7,"watchers":27,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1106"},"html":{"href":"https://github.com/foglamp/FogLAMP/pull/1106"},"issue":{"href":"https://api.github.com/repos/foglamp/FogLAMP/issues/1106"},"comments":{"href":"https://api.github.com/repos/foglamp/FogLAMP/issues/1106/comments"},"review_comments":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1106/comments"},"review_comment":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/foglamp/FogLAMP/pulls/1106/commits"},"statuses":{"href":"https://api.github.com/repos/foglamp/FogLAMP/statuses/7b1f448a1d5a3bde32b033155afa5af5b806f9e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"praveen-garg"}}