{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3702","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3702/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3702/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3702/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3702","id":361822287,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2Njk2NjI0","number":3702,"title":"Expand test coverage for GrpcResultSet and runWithRetries()","user":{"login":"nithinsujir","id":118742,"node_id":"MDQ6VXNlcjExODc0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/118742?v=4","gravatar_id":"","url":"https://api.github.com/users/nithinsujir","html_url":"https://github.com/nithinsujir","followers_url":"https://api.github.com/users/nithinsujir/followers","following_url":"https://api.github.com/users/nithinsujir/following{/other_user}","gists_url":"https://api.github.com/users/nithinsujir/gists{/gist_id}","starred_url":"https://api.github.com/users/nithinsujir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nithinsujir/subscriptions","organizations_url":"https://api.github.com/users/nithinsujir/orgs","repos_url":"https://api.github.com/users/nithinsujir/repos","events_url":"https://api.github.com/users/nithinsujir/events{/privacy}","received_events_url":"https://api.github.com/users/nithinsujir/received_events","type":"User","site_admin":false},"labels":[{"id":175662188,"node_id":"MDU6TGFiZWwxNzU2NjIxODg=","url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-19T16:11:17Z","updated_at":"2018-09-19T21:30:40Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/3702","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3702","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3702.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3702.patch"},"body":"The coverage is now at 84% for Instructions and 81% for Branches."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/comments/422965419","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3702#issuecomment-422965419","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3702","id":422965419,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjk2NTQxOQ==","user":{"login":"nithinsujir","id":118742,"node_id":"MDQ6VXNlcjExODc0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/118742?v=4","gravatar_id":"","url":"https://api.github.com/users/nithinsujir","html_url":"https://github.com/nithinsujir","followers_url":"https://api.github.com/users/nithinsujir/followers","following_url":"https://api.github.com/users/nithinsujir/following{/other_user}","gists_url":"https://api.github.com/users/nithinsujir/gists{/gist_id}","starred_url":"https://api.github.com/users/nithinsujir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nithinsujir/subscriptions","organizations_url":"https://api.github.com/users/nithinsujir/orgs","repos_url":"https://api.github.com/users/nithinsujir/repos","events_url":"https://api.github.com/users/nithinsujir/events{/privacy}","received_events_url":"https://api.github.com/users/nithinsujir/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T21:30:40Z","updated_at":"2018-09-19T21:30:40Z","author_association":"COLLABORATOR","body":"Cool, I'll change it. Thanks.\n\nOn Wed, Sep 19, 2018 at 2:24 PM Michael Darakananda <\nnotifications@github.com> wrote:\n\n> *@pongad* commented on this pull request.\n> ------------------------------\n>\n> In\n> google-cloud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java\n> <https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3702#discussion_r218968806>\n> :\n>\n> > +  }\n> +\n> +  @Test\n> +  public void getDoubleArray() {\n> +    double[] dArray = {Double.MAX_VALUE, Double.MIN_VALUE, 111, 333, 444, 0, -1, -2234};\n> +\n> +    consumer.onPartialResultSet(\n> +        PartialResultSet.newBuilder()\n> +            .setMetadata(makeMetadata(Type.struct(\n> +                Type.StructField.of(\"f\", Type.array(Type.float64())))))\n> +            .addValues(Value.float64Array(dArray).toProto())\n> +            .build());\n> +    consumer.onCompleted();\n> +    resultSet.next();\n> +\n> +    assertThat(resultSet.getDoubleArray(0).equals(dArray));\n>\n> I *think* it's fine? The Javadoc doesn't seem to think this is deprecated\n> https://google.github.io/truth/api/0.42/com/google/common/truth/PrimitiveDoubleArraySubject.html\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3702#discussion_r218968806>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAHP1lwmAqcyzOankuo5A9Pbpw2DCqlKks5ucrX-gaJpZM4WwgA4>\n> .\n>\n"}}
{"actor":{"display_login":"nithinsujir"}}