{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/235285092","pull_request_review_id":177113778,"id":235285092,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTI4NTA5Mg==","diff_hunk":"@@ -358,6 +358,13 @@ void SetupServerArgs()\n     gArgs.AddArg(\"-minimumchainwork=<hex>\", strprintf(\"Minimum work assumed to exist on a valid chain in hex (default: %s, testnet: %s)\", defaultChainParams->GetConsensus().nMinimumChainWork.GetHex(), testnetChainParams->GetConsensus().nMinimumChainWork.GetHex()), true, OptionsCategory::OPTIONS);\n     gArgs.AddArg(\"-par=<n>\", strprintf(\"Set the number of script verification threads (%u to %d, 0 = auto, <0 = leave that many cores free, default: %d)\",\n         -GetNumCores(), MAX_SCRIPTCHECK_THREADS, DEFAULT_SCRIPTCHECK_THREADS), false, OptionsCategory::OPTIONS);\n+    gArgs.AddArg(\"-mitigatespectre\", strprintf(\"Attempt to enable per process spectre mitigations (default: %u%s)\", DEFAULT_MITIGATE_SPECTRE, (\n+#ifdef ENABLE_WALLET\n+    DEFAULT_MITIGATE_SPECTRE ? \" or 0 if -disablewallet set\" : \"0\"\n+#else\n+    strprintf(\"%u\", DEFAULT_MITIGATE_SPECTRE)","path":"src/init.cpp","position":8,"original_position":8,"commit_id":"6dbaed44dec9ab1e41094244dd8d22ebe5a6c653","original_commit_id":"6dbaed44dec9ab1e41094244dd8d22ebe5a6c653","user":{"login":"jameshilliard","id":3298484,"node_id":"MDQ6VXNlcjMyOTg0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3298484?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshilliard","html_url":"https://github.com/jameshilliard","followers_url":"https://api.github.com/users/jameshilliard/followers","following_url":"https://api.github.com/users/jameshilliard/following{/other_user}","gists_url":"https://api.github.com/users/jameshilliard/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshilliard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshilliard/subscriptions","organizations_url":"https://api.github.com/users/jameshilliard/orgs","repos_url":"https://api.github.com/users/jameshilliard/repos","events_url":"https://api.github.com/users/jameshilliard/events{/privacy}","received_events_url":"https://api.github.com/users/jameshilliard/received_events","type":"User","site_admin":false},"body":"`DEFAULT_MITIGATE_SPECTRE` is somewhat redundant in `DEFAULT_MITIGATE_SPECTRE ? \" or 0 if -disablewallet set\" : \"0\"` since `DEFAULT_MITIGATE_SPECTRE` is controlled by `ENABLE_WALLET`, doesn't look like it would be printed twice.","created_at":"2018-11-21T08:08:27Z","updated_at":"2018-11-21T08:08:27Z","html_url":"https://github.com/bitcoin/bitcoin/pull/14776#discussion_r235285092","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14776","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/235285092"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14776#discussion_r235285092"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14776"}},"in_reply_to_id":235283644},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14776","id":232557321,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNTU3MzIx","html_url":"https://github.com/bitcoin/bitcoin/pull/14776","diff_url":"https://github.com/bitcoin/bitcoin/pull/14776.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/14776.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14776","number":14776,"state":"open","locked":false,"title":"Add process based prctl spectre mitigation controls.","user":{"login":"jameshilliard","id":3298484,"node_id":"MDQ6VXNlcjMyOTg0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3298484?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshilliard","html_url":"https://github.com/jameshilliard","followers_url":"https://api.github.com/users/jameshilliard/followers","following_url":"https://api.github.com/users/jameshilliard/following{/other_user}","gists_url":"https://api.github.com/users/jameshilliard/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshilliard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshilliard/subscriptions","organizations_url":"https://api.github.com/users/jameshilliard/orgs","repos_url":"https://api.github.com/users/jameshilliard/repos","events_url":"https://api.github.com/users/jameshilliard/events{/privacy}","received_events_url":"https://api.github.com/users/jameshilliard/received_events","type":"User","site_admin":false},"body":"This should ensure that kernel spectre mitigations are enabled if available when the wallet is enabled and disabled if possible when there is no wallet for improved performance.\r\n\r\nI also added a `-mitigatespectre` config switch to override the default behavior.\r\n\r\nI'm not entirely sure if this specific spectre mitigation should be automatically enabled but it appears the prctl interface will be used for newer more important process level spectre mitigations as well.","created_at":"2018-11-21T06:57:45Z","updated_at":"2018-11-21T08:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"472af2c1cdc148129621405c267cc0fdcadf05cb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":241832923,"node_id":"MDU6TGFiZWwyNDE4MzI5MjM=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Utils/log/libs","name":"Utils/log/libs","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14776/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14776/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14776/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/6dbaed44dec9ab1e41094244dd8d22ebe5a6c653","head":{"label":"jameshilliard:spectre-prctl","ref":"spectre-prctl","sha":"6dbaed44dec9ab1e41094244dd8d22ebe5a6c653","user":{"login":"jameshilliard","id":3298484,"node_id":"MDQ6VXNlcjMyOTg0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3298484?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshilliard","html_url":"https://github.com/jameshilliard","followers_url":"https://api.github.com/users/jameshilliard/followers","following_url":"https://api.github.com/users/jameshilliard/following{/other_user}","gists_url":"https://api.github.com/users/jameshilliard/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshilliard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshilliard/subscriptions","organizations_url":"https://api.github.com/users/jameshilliard/orgs","repos_url":"https://api.github.com/users/jameshilliard/repos","events_url":"https://api.github.com/users/jameshilliard/events{/privacy}","received_events_url":"https://api.github.com/users/jameshilliard/received_events","type":"User","site_admin":false},"repo":{"id":33961363,"node_id":"MDEwOlJlcG9zaXRvcnkzMzk2MTM2Mw==","name":"bitcoin","full_name":"jameshilliard/bitcoin","private":false,"owner":{"login":"jameshilliard","id":3298484,"node_id":"MDQ6VXNlcjMyOTg0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3298484?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshilliard","html_url":"https://github.com/jameshilliard","followers_url":"https://api.github.com/users/jameshilliard/followers","following_url":"https://api.github.com/users/jameshilliard/following{/other_user}","gists_url":"https://api.github.com/users/jameshilliard/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshilliard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshilliard/subscriptions","organizations_url":"https://api.github.com/users/jameshilliard/orgs","repos_url":"https://api.github.com/users/jameshilliard/repos","events_url":"https://api.github.com/users/jameshilliard/events{/privacy}","received_events_url":"https://api.github.com/users/jameshilliard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jameshilliard/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/jameshilliard/bitcoin","forks_url":"https://api.github.com/repos/jameshilliard/bitcoin/forks","keys_url":"https://api.github.com/repos/jameshilliard/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jameshilliard/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jameshilliard/bitcoin/teams","hooks_url":"https://api.github.com/repos/jameshilliard/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/jameshilliard/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/jameshilliard/bitcoin/events","assignees_url":"https://api.github.com/repos/jameshilliard/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/jameshilliard/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/jameshilliard/bitcoin/tags","blobs_url":"https://api.github.com/repos/jameshilliard/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jameshilliard/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jameshilliard/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jameshilliard/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jameshilliard/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/jameshilliard/bitcoin/languages","stargazers_url":"https://api.github.com/repos/jameshilliard/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/jameshilliard/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/jameshilliard/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/jameshilliard/bitcoin/subscription","commits_url":"https://api.github.com/repos/jameshilliard/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jameshilliard/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jameshilliard/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jameshilliard/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jameshilliard/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/jameshilliard/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jameshilliard/bitcoin/merges","archive_url":"https://api.github.com/repos/jameshilliard/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jameshilliard/bitcoin/downloads","issues_url":"https://api.github.com/repos/jameshilliard/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/jameshilliard/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/jameshilliard/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/jameshilliard/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jameshilliard/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/jameshilliard/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/jameshilliard/bitcoin/deployments","created_at":"2015-04-14T22:59:02Z","updated_at":"2018-08-21T18:58:55Z","pushed_at":"2018-11-21T07:49:24Z","git_url":"git://github.com/jameshilliard/bitcoin.git","ssh_url":"git@github.com:jameshilliard/bitcoin.git","clone_url":"https://github.com/jameshilliard/bitcoin.git","svn_url":"https://github.com/jameshilliard/bitcoin","homepage":"https://bitcoin.org/en/download","size":122145,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"6b90a2a0e06548b5c30a160fe76351a44fe3f861","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-11-21T08:08:02Z","pushed_at":"2018-11-21T07:49:27Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":116675,"stargazers_count":36004,"watchers_count":36004,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":21448,"mirror_url":null,"archived":false,"open_issues_count":875,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21448,"open_issues":875,"watchers":36004,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14776"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14776"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14776"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14776/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14776/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14776/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/6dbaed44dec9ab1e41094244dd8d22ebe5a6c653"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jameshilliard"}}