{"action":"created","comment":{"url":"https://api.github.com/repos/knative/eventing-sources/pulls/comments/228276559","pull_request_review_id":168513237,"id":228276559,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODI3NjU1OQ==","diff_hunk":"@@ -0,0 +1,35 @@\n+# This file is needed by kubebuilder but all functionality should exist inside\n+# the hack/ files.\n+\n+all: generate manifests test verify\n+\t\n+# Run tests\n+test: generate manifests verify","path":"Makefile","position":7,"original_position":7,"commit_id":"2b747327df8626c8c8a952bef741472a94a478ea","original_commit_id":"2b747327df8626c8c8a952bef741472a94a478ea","user":{"login":"grantr","id":680,"node_id":"MDQ6VXNlcjY4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/680?v=4","gravatar_id":"","url":"https://api.github.com/users/grantr","html_url":"https://github.com/grantr","followers_url":"https://api.github.com/users/grantr/followers","following_url":"https://api.github.com/users/grantr/following{/other_user}","gists_url":"https://api.github.com/users/grantr/gists{/gist_id}","starred_url":"https://api.github.com/users/grantr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantr/subscriptions","organizations_url":"https://api.github.com/users/grantr/orgs","repos_url":"https://api.github.com/users/grantr/repos","events_url":"https://api.github.com/users/grantr/events{/privacy}","received_events_url":"https://api.github.com/users/grantr/received_events","type":"User","site_admin":false},"body":"Same verify comment as above","created_at":"2018-10-25T18:01:24Z","updated_at":"2018-10-25T18:01:45Z","html_url":"https://github.com/knative/eventing-sources/pull/32#discussion_r228276559","pull_request_url":"https://api.github.com/repos/knative/eventing-sources/pulls/32","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/knative/eventing-sources/pulls/comments/228276559"},"html":{"href":"https://github.com/knative/eventing-sources/pull/32#discussion_r228276559"},"pull_request":{"href":"https://api.github.com/repos/knative/eventing-sources/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/knative/eventing-sources/pulls/32","id":225816809,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODE2ODA5","html_url":"https://github.com/knative/eventing-sources/pull/32","diff_url":"https://github.com/knative/eventing-sources/pull/32.diff","patch_url":"https://github.com/knative/eventing-sources/pull/32.patch","issue_url":"https://api.github.com/repos/knative/eventing-sources/issues/32","number":32,"state":"open","locked":false,"title":"adding a new makefile, like the old makefile.","user":{"login":"n3wscott","id":32305648,"node_id":"MDQ6VXNlcjMyMzA1NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/32305648?v=4","gravatar_id":"","url":"https://api.github.com/users/n3wscott","html_url":"https://github.com/n3wscott","followers_url":"https://api.github.com/users/n3wscott/followers","following_url":"https://api.github.com/users/n3wscott/following{/other_user}","gists_url":"https://api.github.com/users/n3wscott/gists{/gist_id}","starred_url":"https://api.github.com/users/n3wscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3wscott/subscriptions","organizations_url":"https://api.github.com/users/n3wscott/orgs","repos_url":"https://api.github.com/users/n3wscott/repos","events_url":"https://api.github.com/users/n3wscott/events{/privacy}","received_events_url":"https://api.github.com/users/n3wscott/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/knative/eventing-sources/issues/23\r\n\r\n## Proposed Changes\r\n\r\n  * Add a makefile that does not do work directly, but delegates to scripts in the hack dir.\r\n\r\n**Release Note**\r\n```release-note\r\nNONE\r\n```","created_at":"2018-10-25T16:01:07Z","updated_at":"2018-10-25T18:01:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"892ed681022abdadcdd203e45677d37219d8b28f","assignee":{"login":"grantr","id":680,"node_id":"MDQ6VXNlcjY4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/680?v=4","gravatar_id":"","url":"https://api.github.com/users/grantr","html_url":"https://github.com/grantr","followers_url":"https://api.github.com/users/grantr/followers","following_url":"https://api.github.com/users/grantr/following{/other_user}","gists_url":"https://api.github.com/users/grantr/gists{/gist_id}","starred_url":"https://api.github.com/users/grantr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantr/subscriptions","organizations_url":"https://api.github.com/users/grantr/orgs","repos_url":"https://api.github.com/users/grantr/repos","events_url":"https://api.github.com/users/grantr/events{/privacy}","received_events_url":"https://api.github.com/users/grantr/received_events","type":"User","site_admin":false},"assignees":[{"login":"grantr","id":680,"node_id":"MDQ6VXNlcjY4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/680?v=4","gravatar_id":"","url":"https://api.github.com/users/grantr","html_url":"https://github.com/grantr","followers_url":"https://api.github.com/users/grantr/followers","following_url":"https://api.github.com/users/grantr/following{/other_user}","gists_url":"https://api.github.com/users/grantr/gists{/gist_id}","starred_url":"https://api.github.com/users/grantr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantr/subscriptions","organizations_url":"https://api.github.com/users/grantr/orgs","repos_url":"https://api.github.com/users/grantr/repos","events_url":"https://api.github.com/users/grantr/events{/privacy}","received_events_url":"https://api.github.com/users/grantr/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"evankanderson","id":7959095,"node_id":"MDQ6VXNlcjc5NTkwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/7959095?v=4","gravatar_id":"","url":"https://api.github.com/users/evankanderson","html_url":"https://github.com/evankanderson","followers_url":"https://api.github.com/users/evankanderson/followers","following_url":"https://api.github.com/users/evankanderson/following{/other_user}","gists_url":"https://api.github.com/users/evankanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/evankanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evankanderson/subscriptions","organizations_url":"https://api.github.com/users/evankanderson/orgs","repos_url":"https://api.github.com/users/evankanderson/repos","events_url":"https://api.github.com/users/evankanderson/events{/privacy}","received_events_url":"https://api.github.com/users/evankanderson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1096379246,"node_id":"MDU6TGFiZWwxMDk2Mzc5MjQ2","url":"https://api.github.com/repos/knative/eventing-sources/labels/size/M","name":"size/M","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/eventing-sources/pulls/32/commits","review_comments_url":"https://api.github.com/repos/knative/eventing-sources/pulls/32/comments","review_comment_url":"https://api.github.com/repos/knative/eventing-sources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/eventing-sources/issues/32/comments","statuses_url":"https://api.github.com/repos/knative/eventing-sources/statuses/2b747327df8626c8c8a952bef741472a94a478ea","head":{"label":"n3wscott:makefile","ref":"makefile","sha":"2b747327df8626c8c8a952bef741472a94a478ea","user":{"login":"n3wscott","id":32305648,"node_id":"MDQ6VXNlcjMyMzA1NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/32305648?v=4","gravatar_id":"","url":"https://api.github.com/users/n3wscott","html_url":"https://github.com/n3wscott","followers_url":"https://api.github.com/users/n3wscott/followers","following_url":"https://api.github.com/users/n3wscott/following{/other_user}","gists_url":"https://api.github.com/users/n3wscott/gists{/gist_id}","starred_url":"https://api.github.com/users/n3wscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3wscott/subscriptions","organizations_url":"https://api.github.com/users/n3wscott/orgs","repos_url":"https://api.github.com/users/n3wscott/repos","events_url":"https://api.github.com/users/n3wscott/events{/privacy}","received_events_url":"https://api.github.com/users/n3wscott/received_events","type":"User","site_admin":false},"repo":{"id":153694547,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2OTQ1NDc=","name":"eventing-sources","full_name":"n3wscott/eventing-sources","private":false,"owner":{"login":"n3wscott","id":32305648,"node_id":"MDQ6VXNlcjMyMzA1NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/32305648?v=4","gravatar_id":"","url":"https://api.github.com/users/n3wscott","html_url":"https://github.com/n3wscott","followers_url":"https://api.github.com/users/n3wscott/followers","following_url":"https://api.github.com/users/n3wscott/following{/other_user}","gists_url":"https://api.github.com/users/n3wscott/gists{/gist_id}","starred_url":"https://api.github.com/users/n3wscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3wscott/subscriptions","organizations_url":"https://api.github.com/users/n3wscott/orgs","repos_url":"https://api.github.com/users/n3wscott/repos","events_url":"https://api.github.com/users/n3wscott/events{/privacy}","received_events_url":"https://api.github.com/users/n3wscott/received_events","type":"User","site_admin":false},"html_url":"https://github.com/n3wscott/eventing-sources","description":"Event source providers","fork":true,"url":"https://api.github.com/repos/n3wscott/eventing-sources","forks_url":"https://api.github.com/repos/n3wscott/eventing-sources/forks","keys_url":"https://api.github.com/repos/n3wscott/eventing-sources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n3wscott/eventing-sources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n3wscott/eventing-sources/teams","hooks_url":"https://api.github.com/repos/n3wscott/eventing-sources/hooks","issue_events_url":"https://api.github.com/repos/n3wscott/eventing-sources/issues/events{/number}","events_url":"https://api.github.com/repos/n3wscott/eventing-sources/events","assignees_url":"https://api.github.com/repos/n3wscott/eventing-sources/assignees{/user}","branches_url":"https://api.github.com/repos/n3wscott/eventing-sources/branches{/branch}","tags_url":"https://api.github.com/repos/n3wscott/eventing-sources/tags","blobs_url":"https://api.github.com/repos/n3wscott/eventing-sources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n3wscott/eventing-sources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n3wscott/eventing-sources/git/refs{/sha}","trees_url":"https://api.github.com/repos/n3wscott/eventing-sources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n3wscott/eventing-sources/statuses/{sha}","languages_url":"https://api.github.com/repos/n3wscott/eventing-sources/languages","stargazers_url":"https://api.github.com/repos/n3wscott/eventing-sources/stargazers","contributors_url":"https://api.github.com/repos/n3wscott/eventing-sources/contributors","subscribers_url":"https://api.github.com/repos/n3wscott/eventing-sources/subscribers","subscription_url":"https://api.github.com/repos/n3wscott/eventing-sources/subscription","commits_url":"https://api.github.com/repos/n3wscott/eventing-sources/commits{/sha}","git_commits_url":"https://api.github.com/repos/n3wscott/eventing-sources/git/commits{/sha}","comments_url":"https://api.github.com/repos/n3wscott/eventing-sources/comments{/number}","issue_comment_url":"https://api.github.com/repos/n3wscott/eventing-sources/issues/comments{/number}","contents_url":"https://api.github.com/repos/n3wscott/eventing-sources/contents/{+path}","compare_url":"https://api.github.com/repos/n3wscott/eventing-sources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n3wscott/eventing-sources/merges","archive_url":"https://api.github.com/repos/n3wscott/eventing-sources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n3wscott/eventing-sources/downloads","issues_url":"https://api.github.com/repos/n3wscott/eventing-sources/issues{/number}","pulls_url":"https://api.github.com/repos/n3wscott/eventing-sources/pulls{/number}","milestones_url":"https://api.github.com/repos/n3wscott/eventing-sources/milestones{/number}","notifications_url":"https://api.github.com/repos/n3wscott/eventing-sources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n3wscott/eventing-sources/labels{/name}","releases_url":"https://api.github.com/repos/n3wscott/eventing-sources/releases{/id}","deployments_url":"https://api.github.com/repos/n3wscott/eventing-sources/deployments","created_at":"2018-10-18T22:21:47Z","updated_at":"2018-10-24T21:07:34Z","pushed_at":"2018-10-25T17:14:38Z","git_url":"git://github.com/n3wscott/eventing-sources.git","ssh_url":"git@github.com:n3wscott/eventing-sources.git","clone_url":"https://github.com/n3wscott/eventing-sources.git","svn_url":"https://github.com/n3wscott/eventing-sources","homepage":null,"size":29101,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"78c56d1dc86293cb170f82811fd06ec0ff428234","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":153685000,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2ODUwMDA=","name":"eventing-sources","full_name":"knative/eventing-sources","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/eventing-sources","description":"Event Sources","fork":false,"url":"https://api.github.com/repos/knative/eventing-sources","forks_url":"https://api.github.com/repos/knative/eventing-sources/forks","keys_url":"https://api.github.com/repos/knative/eventing-sources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/eventing-sources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/eventing-sources/teams","hooks_url":"https://api.github.com/repos/knative/eventing-sources/hooks","issue_events_url":"https://api.github.com/repos/knative/eventing-sources/issues/events{/number}","events_url":"https://api.github.com/repos/knative/eventing-sources/events","assignees_url":"https://api.github.com/repos/knative/eventing-sources/assignees{/user}","branches_url":"https://api.github.com/repos/knative/eventing-sources/branches{/branch}","tags_url":"https://api.github.com/repos/knative/eventing-sources/tags","blobs_url":"https://api.github.com/repos/knative/eventing-sources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/eventing-sources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/eventing-sources/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/eventing-sources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/eventing-sources/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/eventing-sources/languages","stargazers_url":"https://api.github.com/repos/knative/eventing-sources/stargazers","contributors_url":"https://api.github.com/repos/knative/eventing-sources/contributors","subscribers_url":"https://api.github.com/repos/knative/eventing-sources/subscribers","subscription_url":"https://api.github.com/repos/knative/eventing-sources/subscription","commits_url":"https://api.github.com/repos/knative/eventing-sources/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/eventing-sources/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/eventing-sources/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/eventing-sources/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/eventing-sources/contents/{+path}","compare_url":"https://api.github.com/repos/knative/eventing-sources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/eventing-sources/merges","archive_url":"https://api.github.com/repos/knative/eventing-sources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/eventing-sources/downloads","issues_url":"https://api.github.com/repos/knative/eventing-sources/issues{/number}","pulls_url":"https://api.github.com/repos/knative/eventing-sources/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/eventing-sources/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/eventing-sources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/eventing-sources/labels{/name}","releases_url":"https://api.github.com/repos/knative/eventing-sources/releases{/id}","deployments_url":"https://api.github.com/repos/knative/eventing-sources/deployments","created_at":"2018-10-18T20:42:19Z","updated_at":"2018-10-25T08:41:24Z","pushed_at":"2018-10-25T16:08:36Z","git_url":"git://github.com/knative/eventing-sources.git","ssh_url":"git@github.com:knative/eventing-sources.git","clone_url":"https://github.com/knative/eventing-sources.git","svn_url":"https://github.com/knative/eventing-sources","homepage":"","size":28640,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":16,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/eventing-sources/pulls/32"},"html":{"href":"https://github.com/knative/eventing-sources/pull/32"},"issue":{"href":"https://api.github.com/repos/knative/eventing-sources/issues/32"},"comments":{"href":"https://api.github.com/repos/knative/eventing-sources/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/eventing-sources/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/eventing-sources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/eventing-sources/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/knative/eventing-sources/statuses/2b747327df8626c8c8a952bef741472a94a478ea"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"grantr"}}