{"action":"opened","number":13001,"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13001","id":225465286,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDY1Mjg2","html_url":"https://github.com/civicrm/civicrm-core/pull/13001","diff_url":"https://github.com/civicrm/civicrm-core/pull/13001.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/13001.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13001","number":13001,"state":"open","locked":false,"title":"dev/core#456 Improve UX of scheduling mass SMS","user":{"login":"JKingsnorth","id":5212601,"node_id":"MDQ6VXNlcjUyMTI2MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5212601?v=4","gravatar_id":"","url":"https://api.github.com/users/JKingsnorth","html_url":"https://github.com/JKingsnorth","followers_url":"https://api.github.com/users/JKingsnorth/followers","following_url":"https://api.github.com/users/JKingsnorth/following{/other_user}","gists_url":"https://api.github.com/users/JKingsnorth/gists{/gist_id}","starred_url":"https://api.github.com/users/JKingsnorth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JKingsnorth/subscriptions","organizations_url":"https://api.github.com/users/JKingsnorth/orgs","repos_url":"https://api.github.com/users/JKingsnorth/repos","events_url":"https://api.github.com/users/JKingsnorth/events{/privacy}","received_events_url":"https://api.github.com/users/JKingsnorth/received_events","type":"User","site_admin":false},"body":"Overview\r\n----------------------------------------\r\nAs an electronic marketer I want to be able to schedule SMS mailings. However the interface can cause unexpected results.\r\n\r\nIf I leave 'send immediately' ticked, then the 'schedule sms' date is overridden, and 'now' is chosen instead. ie:\r\n\r\n![sms-before-1](https://user-images.githubusercontent.com/5212601/47444806-3730e500-d7af-11e8-960a-9602999491f6.png)\r\n\r\n![sms-before-2](https://user-images.githubusercontent.com/5212601/47444816-3d26c600-d7af-11e8-9663-dd4a2f581735.png)\r\n\r\nThis is very poor UX. As the options should be 'distinct'.\r\n\r\nThe desired solution would be to use a form the same as when scheduling an email in the, which makes this kind of error impossible. ie: usign radio buttons like the email scheduling tool does.\r\n\r\nBefore\r\n----------------------------------------\r\nAmbiguous UI.\r\n\r\nAfter\r\n----------------------------------------\r\nClear UI, better formatted code, improved UX:\r\n\r\n- Options are now distinct\r\n- Deprecated datepicker element has been removed and replace with new one\r\n- Datepicker only displays dates in the future\r\n- JS enhances user experience, ie: preselected 'schedule at' if someone enters a date / clears date when 'send immediately' is selected\r\n\r\n![sms-after](https://user-images.githubusercontent.com/5212601/47444934-90007d80-d7af-11e8-83ac-62579edcbdbf.PNG)\r\n","created_at":"2018-10-24T16:11:17Z","updated_at":"2018-10-24T16:11:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13001/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13001/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13001/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/85f9b1e5caadb1c24091332e372c6e4d5ee1d8b6","head":{"label":"JKingsnorth:core-456","ref":"core-456","sha":"85f9b1e5caadb1c24091332e372c6e4d5ee1d8b6","user":{"login":"JKingsnorth","id":5212601,"node_id":"MDQ6VXNlcjUyMTI2MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5212601?v=4","gravatar_id":"","url":"https://api.github.com/users/JKingsnorth","html_url":"https://github.com/JKingsnorth","followers_url":"https://api.github.com/users/JKingsnorth/followers","following_url":"https://api.github.com/users/JKingsnorth/following{/other_user}","gists_url":"https://api.github.com/users/JKingsnorth/gists{/gist_id}","starred_url":"https://api.github.com/users/JKingsnorth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JKingsnorth/subscriptions","organizations_url":"https://api.github.com/users/JKingsnorth/orgs","repos_url":"https://api.github.com/users/JKingsnorth/repos","events_url":"https://api.github.com/users/JKingsnorth/events{/privacy}","received_events_url":"https://api.github.com/users/JKingsnorth/received_events","type":"User","site_admin":false},"repo":{"id":17708017,"node_id":"MDEwOlJlcG9zaXRvcnkxNzcwODAxNw==","name":"civicrm-core","full_name":"JKingsnorth/civicrm-core","private":false,"owner":{"login":"JKingsnorth","id":5212601,"node_id":"MDQ6VXNlcjUyMTI2MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5212601?v=4","gravatar_id":"","url":"https://api.github.com/users/JKingsnorth","html_url":"https://github.com/JKingsnorth","followers_url":"https://api.github.com/users/JKingsnorth/followers","following_url":"https://api.github.com/users/JKingsnorth/following{/other_user}","gists_url":"https://api.github.com/users/JKingsnorth/gists{/gist_id}","starred_url":"https://api.github.com/users/JKingsnorth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JKingsnorth/subscriptions","organizations_url":"https://api.github.com/users/JKingsnorth/orgs","repos_url":"https://api.github.com/users/JKingsnorth/repos","events_url":"https://api.github.com/users/JKingsnorth/events{/privacy}","received_events_url":"https://api.github.com/users/JKingsnorth/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JKingsnorth/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/JKingsnorth/civicrm-core","forks_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/forks","keys_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/teams","hooks_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/events","assignees_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/tags","blobs_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/subscription","commits_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/merges","archive_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/downloads","issues_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/JKingsnorth/civicrm-core/deployments","created_at":"2014-03-13T11:37:27Z","updated_at":"2016-04-21T10:19:53Z","pushed_at":"2018-10-24T16:04:15Z","git_url":"git://github.com/JKingsnorth/civicrm-core.git","ssh_url":"git@github.com:JKingsnorth/civicrm-core.git","clone_url":"https://github.com/JKingsnorth/civicrm-core.git","svn_url":"https://github.com/JKingsnorth/civicrm-core","homepage":null,"size":160117,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"7fb106e13eb8bfcb80ffb24da3cd450fd70825c8","user":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk1NDk5","name":"civicrm-core","full_name":"civicrm/civicrm-core","private":false,"owner":{"login":"civicrm","id":136373,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjM3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civicrm-core/deployments","created_at":"2013-03-01T06:11:56Z","updated_at":"2018-10-24T04:06:19Z","pushed_at":"2018-10-24T15:47:44Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":168586,"stargazers_count":298,"watchers_count":298,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":648,"mirror_url":null,"archived":false,"open_issues_count":114,"license":null,"forks":648,"open_issues":114,"watchers":298,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13001"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/13001"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/13001"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/13001/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13001/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13001/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/85f9b1e5caadb1c24091332e372c6e4d5ee1d8b6"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":41,"deletions":44,"changed_files":2}}
{"actor":{"display_login":"JKingsnorth"}}