{"action":"closed","number":367,"pull_request":{"url":"https://api.github.com/repos/elementary/music/pulls/367","id":196918125,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTE4MTI1","html_url":"https://github.com/elementary/music/pull/367","diff_url":"https://github.com/elementary/music/pull/367.diff","patch_url":"https://github.com/elementary/music/pull/367.patch","issue_url":"https://api.github.com/repos/elementary/music/issues/367","number":367,"state":"closed","locked":false,"title":"GenericList.vala: misc cleanup","user":{"login":"danrabbit","id":7277719,"node_id":"MDQ6VXNlcjcyNzc3MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7277719?v=4","gravatar_id":"","url":"https://api.github.com/users/danrabbit","html_url":"https://github.com/danrabbit","followers_url":"https://api.github.com/users/danrabbit/followers","following_url":"https://api.github.com/users/danrabbit/following{/other_user}","gists_url":"https://api.github.com/users/danrabbit/gists{/gist_id}","starred_url":"https://api.github.com/users/danrabbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrabbit/subscriptions","organizations_url":"https://api.github.com/users/danrabbit/orgs","repos_url":"https://api.github.com/users/danrabbit/repos","events_url":"https://api.github.com/users/danrabbit/events{/privacy}","received_events_url":"https://api.github.com/users/danrabbit/received_events","type":"User","site_admin":false},"body":"* Get rid of `get_is_current_list ()` since `is_current_list` is available\r\n* Organize properties\r\n* `add_columns ()` is only ever called once in the construct method, so just move its contents here\r\n* Fix indention in `key_press_event`\r\n* `current_cleared` is only ever used once, so just put it in a lambda\r\n* Group abstract methods\r\n* Move two methods that are only used in MusicList to MusicList","created_at":"2018-06-23T19:54:38Z","updated_at":"2018-06-26T16:36:32Z","closed_at":"2018-06-26T16:36:32Z","merged_at":"2018-06-26T16:36:32Z","merge_commit_sha":"0d1e0538b725d15700961b71650c538ee5e9022b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elementary/music/pulls/367/commits","review_comments_url":"https://api.github.com/repos/elementary/music/pulls/367/comments","review_comment_url":"https://api.github.com/repos/elementary/music/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elementary/music/issues/367/comments","statuses_url":"https://api.github.com/repos/elementary/music/statuses/4ecf6ad221f7bf7e7310a3340fb82259cd6185d5","head":{"label":"elementary:genericlist-cleanup","ref":"genericlist-cleanup","sha":"4ecf6ad221f7bf7e7310a3340fb82259cd6185d5","user":{"login":"elementary","id":1978534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzg1MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1978534?v=4","gravatar_id":"","url":"https://api.github.com/users/elementary","html_url":"https://github.com/elementary","followers_url":"https://api.github.com/users/elementary/followers","following_url":"https://api.github.com/users/elementary/following{/other_user}","gists_url":"https://api.github.com/users/elementary/gists{/gist_id}","starred_url":"https://api.github.com/users/elementary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementary/subscriptions","organizations_url":"https://api.github.com/users/elementary/orgs","repos_url":"https://api.github.com/users/elementary/repos","events_url":"https://api.github.com/users/elementary/events{/privacy}","received_events_url":"https://api.github.com/users/elementary/received_events","type":"Organization","site_admin":false},"repo":{"id":88930117,"node_id":"MDEwOlJlcG9zaXRvcnk4ODkzMDExNw==","name":"music","full_name":"elementary/music","owner":{"login":"elementary","id":1978534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzg1MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1978534?v=4","gravatar_id":"","url":"https://api.github.com/users/elementary","html_url":"https://github.com/elementary","followers_url":"https://api.github.com/users/elementary/followers","following_url":"https://api.github.com/users/elementary/following{/other_user}","gists_url":"https://api.github.com/users/elementary/gists{/gist_id}","starred_url":"https://api.github.com/users/elementary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementary/subscriptions","organizations_url":"https://api.github.com/users/elementary/orgs","repos_url":"https://api.github.com/users/elementary/repos","events_url":"https://api.github.com/users/elementary/events{/privacy}","received_events_url":"https://api.github.com/users/elementary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elementary/music","description":"Music player and library designed for elementary OS","fork":false,"url":"https://api.github.com/repos/elementary/music","forks_url":"https://api.github.com/repos/elementary/music/forks","keys_url":"https://api.github.com/repos/elementary/music/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elementary/music/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elementary/music/teams","hooks_url":"https://api.github.com/repos/elementary/music/hooks","issue_events_url":"https://api.github.com/repos/elementary/music/issues/events{/number}","events_url":"https://api.github.com/repos/elementary/music/events","assignees_url":"https://api.github.com/repos/elementary/music/assignees{/user}","branches_url":"https://api.github.com/repos/elementary/music/branches{/branch}","tags_url":"https://api.github.com/repos/elementary/music/tags","blobs_url":"https://api.github.com/repos/elementary/music/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elementary/music/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elementary/music/git/refs{/sha}","trees_url":"https://api.github.com/repos/elementary/music/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elementary/music/statuses/{sha}","languages_url":"https://api.github.com/repos/elementary/music/languages","stargazers_url":"https://api.github.com/repos/elementary/music/stargazers","contributors_url":"https://api.github.com/repos/elementary/music/contributors","subscribers_url":"https://api.github.com/repos/elementary/music/subscribers","subscription_url":"https://api.github.com/repos/elementary/music/subscription","commits_url":"https://api.github.com/repos/elementary/music/commits{/sha}","git_commits_url":"https://api.github.com/repos/elementary/music/git/commits{/sha}","comments_url":"https://api.github.com/repos/elementary/music/comments{/number}","issue_comment_url":"https://api.github.com/repos/elementary/music/issues/comments{/number}","contents_url":"https://api.github.com/repos/elementary/music/contents/{+path}","compare_url":"https://api.github.com/repos/elementary/music/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elementary/music/merges","archive_url":"https://api.github.com/repos/elementary/music/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elementary/music/downloads","issues_url":"https://api.github.com/repos/elementary/music/issues{/number}","pulls_url":"https://api.github.com/repos/elementary/music/pulls{/number}","milestones_url":"https://api.github.com/repos/elementary/music/milestones{/number}","notifications_url":"https://api.github.com/repos/elementary/music/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elementary/music/labels{/name}","releases_url":"https://api.github.com/repos/elementary/music/releases{/id}","deployments_url":"https://api.github.com/repos/elementary/music/deployments","created_at":"2017-04-21T02:20:31Z","updated_at":"2018-06-26T16:10:09Z","pushed_at":"2018-06-26T16:36:32Z","git_url":"git://github.com/elementary/music.git","ssh_url":"git@github.com:elementary/music.git","clone_url":"https://github.com/elementary/music.git","svn_url":"https://github.com/elementary/music","homepage":"https://elementary.io","size":92638,"stargazers_count":28,"watchers_count":28,"language":"Vala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":16,"open_issues":97,"watchers":28,"default_branch":"master"}},"base":{"label":"elementary:master","ref":"master","sha":"2d8c6354b169c0f4f79ed1c16414ae061308ba36","user":{"login":"elementary","id":1978534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzg1MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1978534?v=4","gravatar_id":"","url":"https://api.github.com/users/elementary","html_url":"https://github.com/elementary","followers_url":"https://api.github.com/users/elementary/followers","following_url":"https://api.github.com/users/elementary/following{/other_user}","gists_url":"https://api.github.com/users/elementary/gists{/gist_id}","starred_url":"https://api.github.com/users/elementary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementary/subscriptions","organizations_url":"https://api.github.com/users/elementary/orgs","repos_url":"https://api.github.com/users/elementary/repos","events_url":"https://api.github.com/users/elementary/events{/privacy}","received_events_url":"https://api.github.com/users/elementary/received_events","type":"Organization","site_admin":false},"repo":{"id":88930117,"node_id":"MDEwOlJlcG9zaXRvcnk4ODkzMDExNw==","name":"music","full_name":"elementary/music","owner":{"login":"elementary","id":1978534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzg1MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1978534?v=4","gravatar_id":"","url":"https://api.github.com/users/elementary","html_url":"https://github.com/elementary","followers_url":"https://api.github.com/users/elementary/followers","following_url":"https://api.github.com/users/elementary/following{/other_user}","gists_url":"https://api.github.com/users/elementary/gists{/gist_id}","starred_url":"https://api.github.com/users/elementary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementary/subscriptions","organizations_url":"https://api.github.com/users/elementary/orgs","repos_url":"https://api.github.com/users/elementary/repos","events_url":"https://api.github.com/users/elementary/events{/privacy}","received_events_url":"https://api.github.com/users/elementary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elementary/music","description":"Music player and library designed for elementary OS","fork":false,"url":"https://api.github.com/repos/elementary/music","forks_url":"https://api.github.com/repos/elementary/music/forks","keys_url":"https://api.github.com/repos/elementary/music/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elementary/music/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elementary/music/teams","hooks_url":"https://api.github.com/repos/elementary/music/hooks","issue_events_url":"https://api.github.com/repos/elementary/music/issues/events{/number}","events_url":"https://api.github.com/repos/elementary/music/events","assignees_url":"https://api.github.com/repos/elementary/music/assignees{/user}","branches_url":"https://api.github.com/repos/elementary/music/branches{/branch}","tags_url":"https://api.github.com/repos/elementary/music/tags","blobs_url":"https://api.github.com/repos/elementary/music/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elementary/music/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elementary/music/git/refs{/sha}","trees_url":"https://api.github.com/repos/elementary/music/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elementary/music/statuses/{sha}","languages_url":"https://api.github.com/repos/elementary/music/languages","stargazers_url":"https://api.github.com/repos/elementary/music/stargazers","contributors_url":"https://api.github.com/repos/elementary/music/contributors","subscribers_url":"https://api.github.com/repos/elementary/music/subscribers","subscription_url":"https://api.github.com/repos/elementary/music/subscription","commits_url":"https://api.github.com/repos/elementary/music/commits{/sha}","git_commits_url":"https://api.github.com/repos/elementary/music/git/commits{/sha}","comments_url":"https://api.github.com/repos/elementary/music/comments{/number}","issue_comment_url":"https://api.github.com/repos/elementary/music/issues/comments{/number}","contents_url":"https://api.github.com/repos/elementary/music/contents/{+path}","compare_url":"https://api.github.com/repos/elementary/music/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elementary/music/merges","archive_url":"https://api.github.com/repos/elementary/music/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elementary/music/downloads","issues_url":"https://api.github.com/repos/elementary/music/issues{/number}","pulls_url":"https://api.github.com/repos/elementary/music/pulls{/number}","milestones_url":"https://api.github.com/repos/elementary/music/milestones{/number}","notifications_url":"https://api.github.com/repos/elementary/music/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elementary/music/labels{/name}","releases_url":"https://api.github.com/repos/elementary/music/releases{/id}","deployments_url":"https://api.github.com/repos/elementary/music/deployments","created_at":"2017-04-21T02:20:31Z","updated_at":"2018-06-26T16:10:09Z","pushed_at":"2018-06-26T16:36:32Z","git_url":"git://github.com/elementary/music.git","ssh_url":"git@github.com:elementary/music.git","clone_url":"https://github.com/elementary/music.git","svn_url":"https://github.com/elementary/music","homepage":"https://elementary.io","size":92638,"stargazers_count":28,"watchers_count":28,"language":"Vala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":16,"open_issues":97,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elementary/music/pulls/367"},"html":{"href":"https://github.com/elementary/music/pull/367"},"issue":{"href":"https://api.github.com/repos/elementary/music/issues/367"},"comments":{"href":"https://api.github.com/repos/elementary/music/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/elementary/music/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/elementary/music/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elementary/music/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/elementary/music/statuses/4ecf6ad221f7bf7e7310a3340fb82259cd6185d5"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"danrabbit","id":7277719,"node_id":"MDQ6VXNlcjcyNzc3MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7277719?v=4","gravatar_id":"","url":"https://api.github.com/users/danrabbit","html_url":"https://github.com/danrabbit","followers_url":"https://api.github.com/users/danrabbit/followers","following_url":"https://api.github.com/users/danrabbit/following{/other_user}","gists_url":"https://api.github.com/users/danrabbit/gists{/gist_id}","starred_url":"https://api.github.com/users/danrabbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrabbit/subscriptions","organizations_url":"https://api.github.com/users/danrabbit/orgs","repos_url":"https://api.github.com/users/danrabbit/repos","events_url":"https://api.github.com/users/danrabbit/events{/privacy}","received_events_url":"https://api.github.com/users/danrabbit/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":44,"deletions":57,"changed_files":3}}
{"actor":{"display_login":"danrabbit"}}