{"action":"created","issue":{"url":"https://api.github.com/repos/imglib/imglib2/issues/225","repository_url":"https://api.github.com/repos/imglib/imglib2","labels_url":"https://api.github.com/repos/imglib/imglib2/issues/225/labels{/name}","comments_url":"https://api.github.com/repos/imglib/imglib2/issues/225/comments","events_url":"https://api.github.com/repos/imglib/imglib2/issues/225/events","html_url":"https://github.com/imglib/imglib2/pull/225","id":349109414,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzAyMDI3","number":225,"title":"Add ARGBType::equals","user":{"login":"maarzt","id":24407711,"node_id":"MDQ6VXNlcjI0NDA3NzEx","avatar_url":"https://avatars1.githubusercontent.com/u/24407711?v=4","gravatar_id":"","url":"https://api.github.com/users/maarzt","html_url":"https://github.com/maarzt","followers_url":"https://api.github.com/users/maarzt/followers","following_url":"https://api.github.com/users/maarzt/following{/other_user}","gists_url":"https://api.github.com/users/maarzt/gists{/gist_id}","starred_url":"https://api.github.com/users/maarzt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maarzt/subscriptions","organizations_url":"https://api.github.com/users/maarzt/orgs","repos_url":"https://api.github.com/users/maarzt/repos","events_url":"https://api.github.com/users/maarzt/events{/privacy}","received_events_url":"https://api.github.com/users/maarzt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-09T12:38:08Z","updated_at":"2018-08-09T12:57:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/imglib/imglib2/pulls/225","html_url":"https://github.com/imglib/imglib2/pull/225","diff_url":"https://github.com/imglib/imglib2/pull/225.diff","patch_url":"https://github.com/imglib/imglib2/pull/225.patch"},"body":"There's some surprising behavior with imglib2 types:\r\n* `new IntType(5).equals(new IntType(5)) == true`\r\n* `new ARGBType(5).equals(new ARGBType(5)) == false`\r\n\r\nThis is because ARGBType misses a implementation vor Object::equals.\r\n\r\nThis PR does the following:\r\n* Add proper implementations for Object::equals to all NumericTypes, including ARGBType.\r\n* Add unit test, to test all implementations of NumericType for their basic functionality."},"comment":{"url":"https://api.github.com/repos/imglib/imglib2/issues/comments/411748035","html_url":"https://github.com/imglib/imglib2/pull/225#issuecomment-411748035","issue_url":"https://api.github.com/repos/imglib/imglib2/issues/225","id":411748035,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTc0ODAzNQ==","user":{"login":"tpietzsch","id":622070,"node_id":"MDQ6VXNlcjYyMjA3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/622070?v=4","gravatar_id":"","url":"https://api.github.com/users/tpietzsch","html_url":"https://github.com/tpietzsch","followers_url":"https://api.github.com/users/tpietzsch/followers","following_url":"https://api.github.com/users/tpietzsch/following{/other_user}","gists_url":"https://api.github.com/users/tpietzsch/gists{/gist_id}","starred_url":"https://api.github.com/users/tpietzsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpietzsch/subscriptions","organizations_url":"https://api.github.com/users/tpietzsch/orgs","repos_url":"https://api.github.com/users/tpietzsch/repos","events_url":"https://api.github.com/users/tpietzsch/events{/privacy}","received_events_url":"https://api.github.com/users/tpietzsch/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T12:57:13Z","updated_at":"2018-08-09T12:57:13Z","author_association":"MEMBER","body":"we consciously did not add `equals()` implementations to all types, although I don't remember the details. There is `valueEquals()`.\r\nSee discussions in https://github.com/imglib/imglib2/pull/132 and https://github.com/imglib/imglib2/issues/130\r\nMaybe @axtimwalde has more pointers"}}
{"actor":{"display_login":"tpietzsch"}}