{"action":"created","issue":{"url":"https://api.github.com/repos/capitalone/cloud-custodian/issues/2296","repository_url":"https://api.github.com/repos/capitalone/cloud-custodian","labels_url":"https://api.github.com/repos/capitalone/cloud-custodian/issues/2296/labels{/name}","comments_url":"https://api.github.com/repos/capitalone/cloud-custodian/issues/2296/comments","events_url":"https://api.github.com/repos/capitalone/cloud-custodian/issues/2296/events","html_url":"https://github.com/capitalone/cloud-custodian/pull/2296","id":318551951,"number":2296,"title":"Adding dms-endpoint delete action and usecase examples","user":{"login":"jtroberts83","id":15660841,"avatar_url":"https://avatars1.githubusercontent.com/u/15660841?v=4","gravatar_id":"","url":"https://api.github.com/users/jtroberts83","html_url":"https://github.com/jtroberts83","followers_url":"https://api.github.com/users/jtroberts83/followers","following_url":"https://api.github.com/users/jtroberts83/following{/other_user}","gists_url":"https://api.github.com/users/jtroberts83/gists{/gist_id}","starred_url":"https://api.github.com/users/jtroberts83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtroberts83/subscriptions","organizations_url":"https://api.github.com/users/jtroberts83/orgs","repos_url":"https://api.github.com/users/jtroberts83/repos","events_url":"https://api.github.com/users/jtroberts83/events{/privacy}","received_events_url":"https://api.github.com/users/jtroberts83/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-27T21:14:28Z","updated_at":"2018-04-28T16:44:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/2296","html_url":"https://github.com/capitalone/cloud-custodian/pull/2296","diff_url":"https://github.com/capitalone/cloud-custodian/pull/2296.diff","patch_url":"https://github.com/capitalone/cloud-custodian/pull/2296.patch"},"body":"For better SSL enforcement on dms endpoints I have added a delete action and tests as well as a couple usecase examples on dms-endpoint SSL"},"comment":{"url":"https://api.github.com/repos/capitalone/cloud-custodian/issues/comments/385189538","html_url":"https://github.com/capitalone/cloud-custodian/pull/2296#issuecomment-385189538","issue_url":"https://api.github.com/repos/capitalone/cloud-custodian/issues/2296","id":385189538,"user":{"login":"kapilt","id":21650,"avatar_url":"https://avatars3.githubusercontent.com/u/21650?v=4","gravatar_id":"","url":"https://api.github.com/users/kapilt","html_url":"https://github.com/kapilt","followers_url":"https://api.github.com/users/kapilt/followers","following_url":"https://api.github.com/users/kapilt/following{/other_user}","gists_url":"https://api.github.com/users/kapilt/gists{/gist_id}","starred_url":"https://api.github.com/users/kapilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapilt/subscriptions","organizations_url":"https://api.github.com/users/kapilt/orgs","repos_url":"https://api.github.com/users/kapilt/repos","events_url":"https://api.github.com/users/kapilt/events{/privacy}","received_events_url":"https://api.github.com/users/kapilt/received_events","type":"User","site_admin":false},"created_at":"2018-04-28T16:44:03Z","updated_at":"2018-04-28T16:44:03Z","author_association":"MEMBER","body":"Docs and action look great, the test needs an additional check, its not actually verifying the delete, ie. if you replaced the action implementation with a `pass` the test would still pass. Typically we would construct a dms client and then verify that the endpoint no longer exists to verify the delete."}}
{"actor":{"display_login":"kapilt"}}