{"push_id":3021917485,"size":1,"distinct_size":1,"ref":"refs/heads/wk8/network_rm_follow_up","head":"4d41f4908af5f0cf6bc9918f5864431efd257c33","before":"f511af40fff6513728c0ce4af069e7898237add9","commits":[{"sha":"4d41f4908af5f0cf6bc9918f5864431efd257c33","author":{"name":"Jean Rouge","email":"4903337a90de5c78346778beaec179f4c4ff7869@cornell.edu"},"message":"Actually starting to use the deallocator to clean up services\n\n**- What I did**\n\nThis patch actually stars to use the deallocator to clean up services, as\nwell as service-level resources (as of now, only networks).\n\n**- How I did it**\n\nA previous patch (https://github.com/docker/swarmkit/pull/2759) introduced a\nnew component, the deallocator, responsible for cleaning up services and\nservice-level resources. This patch is actually starting to make use of that\ncomponent.\n\nSince the deallocator used to rely on the reaper deleting the tasks belonging\nto services that had been marked for removal, a previous version of this patch\nwas modifying the task reaper quite heavily to also keep track of such services\n(needed since otherwise the reaper would fail to clean up all of them, instead\nkeeping some for history tracking purposes). However, it soon appeared that\nthis was not the best approach:\n * this creates a hidden coupling between the reaper and the deallocator\n * it's also not the best user experience to suddenly remove all of a service's\n   task history while shutting down, for not apparent reason to the user\n\nFor these reasons, this patch instead amends the deallocator to also look at tasks status when keeping track of how many alive tasks remain to a service.\n\n**- How to test it**\n\nUpdated tests.\n\n**- Description for the changelog**\n\nServices & networks are no longer deleted immediately when a user requests their\ndeletion; instead, they are deleted when all their tasks are actually shut down.\n\nSigned-off-by: Jean Rouge <jer329@cornell.edu>","distinct":true,"url":"https://api.github.com/repos/wk8/swarmkit/commits/4d41f4908af5f0cf6bc9918f5864431efd257c33"}]}
{"actor":{"display_login":"wk8"}}