{"action":"closed","number":3215,"pull_request":{"url":"https://api.github.com/repos/wix/react-native-navigation/pulls/3215","id":188356337,"html_url":"https://github.com/wix/react-native-navigation/pull/3215","diff_url":"https://github.com/wix/react-native-navigation/pull/3215.diff","patch_url":"https://github.com/wix/react-native-navigation/pull/3215.patch","issue_url":"https://api.github.com/repos/wix/react-native-navigation/issues/3215","number":3215,"state":"closed","locked":false,"title":"Modal unmount e2e test","user":{"login":"yusufyildirim","id":22980987,"avatar_url":"https://avatars2.githubusercontent.com/u/22980987?v=4","gravatar_id":"","url":"https://api.github.com/users/yusufyildirim","html_url":"https://github.com/yusufyildirim","followers_url":"https://api.github.com/users/yusufyildirim/followers","following_url":"https://api.github.com/users/yusufyildirim/following{/other_user}","gists_url":"https://api.github.com/users/yusufyildirim/gists{/gist_id}","starred_url":"https://api.github.com/users/yusufyildirim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yusufyildirim/subscriptions","organizations_url":"https://api.github.com/users/yusufyildirim/orgs","repos_url":"https://api.github.com/users/yusufyildirim/repos","events_url":"https://api.github.com/users/yusufyildirim/events{/privacy}","received_events_url":"https://api.github.com/users/yusufyildirim/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI write a e2e test for the modal's unmount problem on iOS. I hope this will help you guys\r\n\r\nSteps to reproduce\r\n-------------------\r\nClick Show Modal\r\nClick Test Modal Lifecycle\r\nClick Dismiss\r\ndidDisappear alert appears\r\ncomponentWillUnmount alert should appear too but event doesn't firing\r\nClick Test Modal Lifecycle again\r\nPrevious modal's componentWillUnmount event triggers\r\n\r\n![2018-05-16 11 16 43](https://user-images.githubusercontent.com/22980987/40105110-b110ff60-58fa-11e8-9102-d0168b878f2b.gif)\r\n","created_at":"2018-05-16T08:35:28Z","updated_at":"2018-05-16T09:50:25Z","closed_at":"2018-05-16T09:50:25Z","merged_at":"2018-05-16T09:50:25Z","merge_commit_sha":"81a9cef3109d8643b0ba38c87378376d043d997e","assignee":{"login":"guyca","id":12352397,"avatar_url":"https://avatars2.githubusercontent.com/u/12352397?v=4","gravatar_id":"","url":"https://api.github.com/users/guyca","html_url":"https://github.com/guyca","followers_url":"https://api.github.com/users/guyca/followers","following_url":"https://api.github.com/users/guyca/following{/other_user}","gists_url":"https://api.github.com/users/guyca/gists{/gist_id}","starred_url":"https://api.github.com/users/guyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyca/subscriptions","organizations_url":"https://api.github.com/users/guyca/orgs","repos_url":"https://api.github.com/users/guyca/repos","events_url":"https://api.github.com/users/guyca/events{/privacy}","received_events_url":"https://api.github.com/users/guyca/received_events","type":"User","site_admin":false},"assignees":[{"login":"guyca","id":12352397,"avatar_url":"https://avatars2.githubusercontent.com/u/12352397?v=4","gravatar_id":"","url":"https://api.github.com/users/guyca","html_url":"https://github.com/guyca","followers_url":"https://api.github.com/users/guyca/followers","following_url":"https://api.github.com/users/guyca/following{/other_user}","gists_url":"https://api.github.com/users/guyca/gists{/gist_id}","starred_url":"https://api.github.com/users/guyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyca/subscriptions","organizations_url":"https://api.github.com/users/guyca/orgs","repos_url":"https://api.github.com/users/guyca/repos","events_url":"https://api.github.com/users/guyca/events{/privacy}","received_events_url":"https://api.github.com/users/guyca/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":602711689,"url":"https://api.github.com/repos/wix/react-native-navigation/labels/v2","name":"v2","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wix/react-native-navigation/pulls/3215/commits","review_comments_url":"https://api.github.com/repos/wix/react-native-navigation/pulls/3215/comments","review_comment_url":"https://api.github.com/repos/wix/react-native-navigation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/react-native-navigation/issues/3215/comments","statuses_url":"https://api.github.com/repos/wix/react-native-navigation/statuses/2a1f8c5b839f3753a4d760a55a7dd9ce18c7a760","head":{"label":"yusufyildirim:v2","ref":"v2","sha":"2a1f8c5b839f3753a4d760a55a7dd9ce18c7a760","user":{"login":"yusufyildirim","id":22980987,"avatar_url":"https://avatars2.githubusercontent.com/u/22980987?v=4","gravatar_id":"","url":"https://api.github.com/users/yusufyildirim","html_url":"https://github.com/yusufyildirim","followers_url":"https://api.github.com/users/yusufyildirim/followers","following_url":"https://api.github.com/users/yusufyildirim/following{/other_user}","gists_url":"https://api.github.com/users/yusufyildirim/gists{/gist_id}","starred_url":"https://api.github.com/users/yusufyildirim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yusufyildirim/subscriptions","organizations_url":"https://api.github.com/users/yusufyildirim/orgs","repos_url":"https://api.github.com/users/yusufyildirim/repos","events_url":"https://api.github.com/users/yusufyildirim/events{/privacy}","received_events_url":"https://api.github.com/users/yusufyildirim/received_events","type":"User","site_admin":false},"repo":{"id":100781278,"name":"react-native-navigation","full_name":"yusufyildirim/react-native-navigation","owner":{"login":"yusufyildirim","id":22980987,"avatar_url":"https://avatars2.githubusercontent.com/u/22980987?v=4","gravatar_id":"","url":"https://api.github.com/users/yusufyildirim","html_url":"https://github.com/yusufyildirim","followers_url":"https://api.github.com/users/yusufyildirim/followers","following_url":"https://api.github.com/users/yusufyildirim/following{/other_user}","gists_url":"https://api.github.com/users/yusufyildirim/gists{/gist_id}","starred_url":"https://api.github.com/users/yusufyildirim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yusufyildirim/subscriptions","organizations_url":"https://api.github.com/users/yusufyildirim/orgs","repos_url":"https://api.github.com/users/yusufyildirim/repos","events_url":"https://api.github.com/users/yusufyildirim/events{/privacy}","received_events_url":"https://api.github.com/users/yusufyildirim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yusufyildirim/react-native-navigation","description":"A complete native navigation solution for React Native","fork":true,"url":"https://api.github.com/repos/yusufyildirim/react-native-navigation","forks_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/forks","keys_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/teams","hooks_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/hooks","issue_events_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/events","assignees_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/tags","blobs_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/languages","stargazers_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/stargazers","contributors_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/contributors","subscribers_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/subscribers","subscription_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/subscription","commits_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/merges","archive_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/downloads","issues_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/labels{/name}","releases_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/yusufyildirim/react-native-navigation/deployments","created_at":"2017-08-19T08:31:31Z","updated_at":"2017-08-19T08:31:36Z","pushed_at":"2018-05-16T09:23:19Z","git_url":"git://github.com/yusufyildirim/react-native-navigation.git","ssh_url":"git@github.com:yusufyildirim/react-native-navigation.git","clone_url":"https://github.com/yusufyildirim/react-native-navigation.git","svn_url":"https://github.com/yusufyildirim/react-native-navigation","homepage":"https://wix.github.io/react-native-navigation/","size":10701,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wix:v2","ref":"v2","sha":"a3e42d446e41d1cf12ae28a332bbf993e138ccb1","user":{"login":"wix","id":686511,"avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":53662249,"name":"react-native-navigation","full_name":"wix/react-native-navigation","owner":{"login":"wix","id":686511,"avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/react-native-navigation","description":"A complete native navigation solution for React Native","fork":false,"url":"https://api.github.com/repos/wix/react-native-navigation","forks_url":"https://api.github.com/repos/wix/react-native-navigation/forks","keys_url":"https://api.github.com/repos/wix/react-native-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/react-native-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/react-native-navigation/teams","hooks_url":"https://api.github.com/repos/wix/react-native-navigation/hooks","issue_events_url":"https://api.github.com/repos/wix/react-native-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/wix/react-native-navigation/events","assignees_url":"https://api.github.com/repos/wix/react-native-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/wix/react-native-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/wix/react-native-navigation/tags","blobs_url":"https://api.github.com/repos/wix/react-native-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/react-native-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/react-native-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/react-native-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/react-native-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/react-native-navigation/languages","stargazers_url":"https://api.github.com/repos/wix/react-native-navigation/stargazers","contributors_url":"https://api.github.com/repos/wix/react-native-navigation/contributors","subscribers_url":"https://api.github.com/repos/wix/react-native-navigation/subscribers","subscription_url":"https://api.github.com/repos/wix/react-native-navigation/subscription","commits_url":"https://api.github.com/repos/wix/react-native-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/react-native-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/react-native-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/react-native-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/react-native-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/wix/react-native-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/react-native-navigation/merges","archive_url":"https://api.github.com/repos/wix/react-native-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/react-native-navigation/downloads","issues_url":"https://api.github.com/repos/wix/react-native-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/wix/react-native-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/react-native-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/react-native-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/react-native-navigation/labels{/name}","releases_url":"https://api.github.com/repos/wix/react-native-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/wix/react-native-navigation/deployments","created_at":"2016-03-11T11:22:54Z","updated_at":"2018-05-16T06:24:00Z","pushed_at":"2018-05-16T09:50:25Z","git_url":"git://github.com/wix/react-native-navigation.git","ssh_url":"git@github.com:wix/react-native-navigation.git","clone_url":"https://github.com/wix/react-native-navigation.git","svn_url":"https://github.com/wix/react-native-navigation","homepage":"https://wix.github.io/react-native-navigation/","size":10941,"stargazers_count":7317,"watchers_count":7317,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1432,"mirror_url":null,"archived":false,"open_issues_count":786,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1432,"open_issues":786,"watchers":7317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/react-native-navigation/pulls/3215"},"html":{"href":"https://github.com/wix/react-native-navigation/pull/3215"},"issue":{"href":"https://api.github.com/repos/wix/react-native-navigation/issues/3215"},"comments":{"href":"https://api.github.com/repos/wix/react-native-navigation/issues/3215/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/react-native-navigation/pulls/3215/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/react-native-navigation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/react-native-navigation/pulls/3215/commits"},"statuses":{"href":"https://api.github.com/repos/wix/react-native-navigation/statuses/2a1f8c5b839f3753a4d760a55a7dd9ce18c7a760"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"guyca","id":12352397,"avatar_url":"https://avatars2.githubusercontent.com/u/12352397?v=4","gravatar_id":"","url":"https://api.github.com/users/guyca","html_url":"https://github.com/guyca","followers_url":"https://api.github.com/users/guyca/followers","following_url":"https://api.github.com/users/guyca/following{/other_user}","gists_url":"https://api.github.com/users/guyca/gists{/gist_id}","starred_url":"https://api.github.com/users/guyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyca/subscriptions","organizations_url":"https://api.github.com/users/guyca/orgs","repos_url":"https://api.github.com/users/guyca/repos","events_url":"https://api.github.com/users/guyca/events{/privacy}","received_events_url":"https://api.github.com/users/guyca/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":9,"additions":34,"deletions":1,"changed_files":4}}
{"actor":{"display_login":"guyca"}}