{"action":"created","comment":{"url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/comments/201093116","pull_request_review_id":135527539,"id":201093116,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTA5MzExNg==","diff_hunk":"@@ -80,12 +79,12 @@ func (p *Proposer) proposeCollations() {\n \tfor {\n \t\tselect {\n \t\tcase tx := <-requests:\n-\t\t\tlog.Info(fmt.Sprintf(\"Received transaction: %x\", tx.Hash()))\n+\t\t\tlog.Infof(\"Received transaction: %x\", tx.Hash())\n \t\t\tif err := p.createCollation(p.ctx, []*gethTypes.Transaction{tx}); err != nil {\n-\t\t\t\tlog.Error(fmt.Sprintf(\"Create collation failed: %v\", err))\n+\t\t\t\tlog.Errorf(\"Create collation failed: %v\", err)\n \t\t\t}\n \t\tcase <-p.ctx.Done():\n-\t\t\tlog.Debug(\"Proposer context closed, exiting goroutine\")\n+\t\t\tlog.Info(\"Proposer context closed, exiting goroutine\")","path":"sharding/proposer/service.go","position":42,"original_position":42,"commit_id":"2215af80b7b38b4781ae896d899041815ae3d88f","original_commit_id":"2215af80b7b38b4781ae896d899041815ae3d88f","user":{"login":"prestonvanloon","id":7246818,"node_id":"MDQ6VXNlcjcyNDY4MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7246818?v=4","gravatar_id":"","url":"https://api.github.com/users/prestonvanloon","html_url":"https://github.com/prestonvanloon","followers_url":"https://api.github.com/users/prestonvanloon/followers","following_url":"https://api.github.com/users/prestonvanloon/following{/other_user}","gists_url":"https://api.github.com/users/prestonvanloon/gists{/gist_id}","starred_url":"https://api.github.com/users/prestonvanloon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestonvanloon/subscriptions","organizations_url":"https://api.github.com/users/prestonvanloon/orgs","repos_url":"https://api.github.com/users/prestonvanloon/repos","events_url":"https://api.github.com/users/prestonvanloon/events{/privacy}","received_events_url":"https://api.github.com/users/prestonvanloon/received_events","type":"User","site_admin":false},"body":"debug","created_at":"2018-07-09T17:56:15Z","updated_at":"2018-07-09T17:56:23Z","html_url":"https://github.com/prysmaticlabs/geth-sharding/pull/242#discussion_r201093116","pull_request_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/242","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/comments/201093116"},"html":{"href":"https://github.com/prysmaticlabs/geth-sharding/pull/242#discussion_r201093116"},"pull_request":{"href":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/242","id":200163959,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTYzOTU5","html_url":"https://github.com/prysmaticlabs/geth-sharding/pull/242","diff_url":"https://github.com/prysmaticlabs/geth-sharding/pull/242.diff","patch_url":"https://github.com/prysmaticlabs/geth-sharding/pull/242.patch","issue_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/242","number":242,"state":"open","locked":false,"title":"Remove Dependency on Geth: Replace Log With Logrus Package","user":{"login":"rauljordan","id":5572669,"node_id":"MDQ6VXNlcjU1NzI2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/5572669?v=4","gravatar_id":"","url":"https://api.github.com/users/rauljordan","html_url":"https://github.com/rauljordan","followers_url":"https://api.github.com/users/rauljordan/followers","following_url":"https://api.github.com/users/rauljordan/following{/other_user}","gists_url":"https://api.github.com/users/rauljordan/gists{/gist_id}","starred_url":"https://api.github.com/users/rauljordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauljordan/subscriptions","organizations_url":"https://api.github.com/users/rauljordan/orgs","repos_url":"https://api.github.com/users/rauljordan/repos","events_url":"https://api.github.com/users/rauljordan/events{/privacy}","received_events_url":"https://api.github.com/users/rauljordan/received_events","type":"User","site_admin":false},"body":"Hi all,\r\n\r\nThe final dependency we had on geth was the usage of the `go-ethereum/log` package. We have been discussing moving forward with a better log package that has better maintenance, has better documentation, and is easier to extend/customize. A great alternative is [logrus](https://github.com/sirupsen/logrus), which is a very popular option offering extensibility, simplicity, and leveled logs. Logrus also comes with test utils to verify log entries, which we make use of extensively in our PR.\r\n\r\nBy integrating logrus, we were able to delete geth's `debug` package in our repository and no longer needed to use the `internal/log_helper.go` file in our repo for verifying log messages. ","created_at":"2018-07-09T17:08:13Z","updated_at":"2018-07-09T17:56:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ea4d90c2cf9719e5d80838533305d6e191c6645","assignee":{"login":"rauljordan","id":5572669,"node_id":"MDQ6VXNlcjU1NzI2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/5572669?v=4","gravatar_id":"","url":"https://api.github.com/users/rauljordan","html_url":"https://github.com/rauljordan","followers_url":"https://api.github.com/users/rauljordan/followers","following_url":"https://api.github.com/users/rauljordan/following{/other_user}","gists_url":"https://api.github.com/users/rauljordan/gists{/gist_id}","starred_url":"https://api.github.com/users/rauljordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauljordan/subscriptions","organizations_url":"https://api.github.com/users/rauljordan/orgs","repos_url":"https://api.github.com/users/rauljordan/repos","events_url":"https://api.github.com/users/rauljordan/events{/privacy}","received_events_url":"https://api.github.com/users/rauljordan/received_events","type":"User","site_admin":false},"assignees":[{"login":"rauljordan","id":5572669,"node_id":"MDQ6VXNlcjU1NzI2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/5572669?v=4","gravatar_id":"","url":"https://api.github.com/users/rauljordan","html_url":"https://github.com/rauljordan","followers_url":"https://api.github.com/users/rauljordan/followers","following_url":"https://api.github.com/users/rauljordan/following{/other_user}","gists_url":"https://api.github.com/users/rauljordan/gists{/gist_id}","starred_url":"https://api.github.com/users/rauljordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauljordan/subscriptions","organizations_url":"https://api.github.com/users/rauljordan/orgs","repos_url":"https://api.github.com/users/rauljordan/repos","events_url":"https://api.github.com/users/rauljordan/events{/privacy}","received_events_url":"https://api.github.com/users/rauljordan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":802129906,"node_id":"MDU6TGFiZWw4MDIxMjk5MDY=","url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false},{"id":953164091,"node_id":"MDU6TGFiZWw5NTMxNjQwOTE=","url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/labels/Intermediate","name":"Intermediate","color":"179e40","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/242/commits","review_comments_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/242/comments","review_comment_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/242/comments","statuses_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/statuses/2215af80b7b38b4781ae896d899041815ae3d88f","head":{"label":"rauljordan:logrus","ref":"logrus","sha":"2215af80b7b38b4781ae896d899041815ae3d88f","user":{"login":"rauljordan","id":5572669,"node_id":"MDQ6VXNlcjU1NzI2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/5572669?v=4","gravatar_id":"","url":"https://api.github.com/users/rauljordan","html_url":"https://github.com/rauljordan","followers_url":"https://api.github.com/users/rauljordan/followers","following_url":"https://api.github.com/users/rauljordan/following{/other_user}","gists_url":"https://api.github.com/users/rauljordan/gists{/gist_id}","starred_url":"https://api.github.com/users/rauljordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauljordan/subscriptions","organizations_url":"https://api.github.com/users/rauljordan/orgs","repos_url":"https://api.github.com/users/rauljordan/repos","events_url":"https://api.github.com/users/rauljordan/events{/privacy}","received_events_url":"https://api.github.com/users/rauljordan/received_events","type":"User","site_admin":false},"repo":{"id":114583688,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ1ODM2ODg=","name":"go-ethereum","full_name":"rauljordan/go-ethereum","owner":{"login":"rauljordan","id":5572669,"node_id":"MDQ6VXNlcjU1NzI2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/5572669?v=4","gravatar_id":"","url":"https://api.github.com/users/rauljordan","html_url":"https://github.com/rauljordan","followers_url":"https://api.github.com/users/rauljordan/followers","following_url":"https://api.github.com/users/rauljordan/following{/other_user}","gists_url":"https://api.github.com/users/rauljordan/gists{/gist_id}","starred_url":"https://api.github.com/users/rauljordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauljordan/subscriptions","organizations_url":"https://api.github.com/users/rauljordan/orgs","repos_url":"https://api.github.com/users/rauljordan/repos","events_url":"https://api.github.com/users/rauljordan/events{/privacy}","received_events_url":"https://api.github.com/users/rauljordan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rauljordan/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":true,"url":"https://api.github.com/repos/rauljordan/go-ethereum","forks_url":"https://api.github.com/repos/rauljordan/go-ethereum/forks","keys_url":"https://api.github.com/repos/rauljordan/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rauljordan/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rauljordan/go-ethereum/teams","hooks_url":"https://api.github.com/repos/rauljordan/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/rauljordan/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/rauljordan/go-ethereum/events","assignees_url":"https://api.github.com/repos/rauljordan/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/rauljordan/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/rauljordan/go-ethereum/tags","blobs_url":"https://api.github.com/repos/rauljordan/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rauljordan/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rauljordan/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/rauljordan/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rauljordan/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/rauljordan/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/rauljordan/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/rauljordan/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/rauljordan/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/rauljordan/go-ethereum/subscription","commits_url":"https://api.github.com/repos/rauljordan/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/rauljordan/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/rauljordan/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/rauljordan/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/rauljordan/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/rauljordan/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rauljordan/go-ethereum/merges","archive_url":"https://api.github.com/repos/rauljordan/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rauljordan/go-ethereum/downloads","issues_url":"https://api.github.com/repos/rauljordan/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/rauljordan/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/rauljordan/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/rauljordan/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rauljordan/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/rauljordan/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/rauljordan/go-ethereum/deployments","created_at":"2017-12-18T01:45:07Z","updated_at":"2017-12-18T01:45:14Z","pushed_at":"2018-07-09T17:53:52Z","git_url":"git://github.com/rauljordan/go-ethereum.git","ssh_url":"git@github.com:rauljordan/go-ethereum.git","clone_url":"https://github.com/rauljordan/go-ethereum.git","svn_url":"https://github.com/rauljordan/go-ethereum","homepage":"https://geth.ethereum.org","size":112273,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prysmaticlabs:master","ref":"master","sha":"652044b23e94cfa05272f91e0773cfe54be1e0ab","user":{"login":"prysmaticlabs","id":35349758,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQ5NzU4","avatar_url":"https://avatars2.githubusercontent.com/u/35349758?v=4","gravatar_id":"","url":"https://api.github.com/users/prysmaticlabs","html_url":"https://github.com/prysmaticlabs","followers_url":"https://api.github.com/users/prysmaticlabs/followers","following_url":"https://api.github.com/users/prysmaticlabs/following{/other_user}","gists_url":"https://api.github.com/users/prysmaticlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prysmaticlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prysmaticlabs/subscriptions","organizations_url":"https://api.github.com/users/prysmaticlabs/orgs","repos_url":"https://api.github.com/users/prysmaticlabs/repos","events_url":"https://api.github.com/users/prysmaticlabs/events{/privacy}","received_events_url":"https://api.github.com/users/prysmaticlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":117156031,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxNTYwMzE=","name":"geth-sharding","full_name":"prysmaticlabs/geth-sharding","owner":{"login":"prysmaticlabs","id":35349758,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQ5NzU4","avatar_url":"https://avatars2.githubusercontent.com/u/35349758?v=4","gravatar_id":"","url":"https://api.github.com/users/prysmaticlabs","html_url":"https://github.com/prysmaticlabs","followers_url":"https://api.github.com/users/prysmaticlabs/followers","following_url":"https://api.github.com/users/prysmaticlabs/following{/other_user}","gists_url":"https://api.github.com/users/prysmaticlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prysmaticlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prysmaticlabs/subscriptions","organizations_url":"https://api.github.com/users/prysmaticlabs/orgs","repos_url":"https://api.github.com/users/prysmaticlabs/repos","events_url":"https://api.github.com/users/prysmaticlabs/events{/privacy}","received_events_url":"https://api.github.com/users/prysmaticlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prysmaticlabs/geth-sharding","description":"Go implementation of the Ethereum sharding specification and stateless client","fork":true,"url":"https://api.github.com/repos/prysmaticlabs/geth-sharding","forks_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/forks","keys_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/teams","hooks_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/hooks","issue_events_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/events{/number}","events_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/events","assignees_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/assignees{/user}","branches_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/branches{/branch}","tags_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/tags","blobs_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/git/refs{/sha}","trees_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/statuses/{sha}","languages_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/languages","stargazers_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/stargazers","contributors_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/contributors","subscribers_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/subscribers","subscription_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/subscription","commits_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/commits{/sha}","git_commits_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/git/commits{/sha}","comments_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/comments{/number}","issue_comment_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/comments{/number}","contents_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/contents/{+path}","compare_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/merges","archive_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/downloads","issues_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues{/number}","pulls_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls{/number}","milestones_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/milestones{/number}","notifications_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/labels{/name}","releases_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/releases{/id}","deployments_url":"https://api.github.com/repos/prysmaticlabs/geth-sharding/deployments","created_at":"2018-01-11T21:31:33Z","updated_at":"2018-07-09T14:02:10Z","pushed_at":"2018-07-09T17:53:54Z","git_url":"git://github.com/prysmaticlabs/geth-sharding.git","ssh_url":"git@github.com:prysmaticlabs/geth-sharding.git","clone_url":"https://github.com/prysmaticlabs/geth-sharding.git","svn_url":"https://github.com/prysmaticlabs/geth-sharding","homepage":"https://prysmaticlabs.com/","size":89656,"stargazers_count":115,"watchers_count":115,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":25,"license":null,"forks":14,"open_issues":25,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/242"},"html":{"href":"https://github.com/prysmaticlabs/geth-sharding/pull/242"},"issue":{"href":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/242"},"comments":{"href":"https://api.github.com/repos/prysmaticlabs/geth-sharding/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prysmaticlabs/geth-sharding/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/prysmaticlabs/geth-sharding/statuses/2215af80b7b38b4781ae896d899041815ae3d88f"}},"author_association":"NONE"}}
{"actor":{"display_login":"prestonvanloon"}}