{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/glow/pulls/comments/212815031","pull_request_review_id":149527146,"id":212815031,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjgxNTAzMQ==","diff_hunk":"@@ -202,6 +202,37 @@ void setKernelArg(cl_kernel kernel, unsigned argIdx, T value) {\n   GLOW_ASSERT(err == CL_SUCCESS && \"Unable to set parameter\");\n }\n \n+template<class T>\n+void setKernelArgShape(cl_kernel kernel, unsigned argIdx, T shapeValue) {","path":"lib/Backends/OpenCL/OpenCL.cpp","position":null,"original_position":5,"commit_id":"e8bc00e298b0c2b1baff9026d333e48e8982df4b","original_commit_id":"1e0b26961fb12c13bde18fe3c99f2d80f220e09d","user":{"login":"lygstate","id":121040,"node_id":"MDQ6VXNlcjEyMTA0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/121040?v=4","gravatar_id":"","url":"https://api.github.com/users/lygstate","html_url":"https://github.com/lygstate","followers_url":"https://api.github.com/users/lygstate/followers","following_url":"https://api.github.com/users/lygstate/following{/other_user}","gists_url":"https://api.github.com/users/lygstate/gists{/gist_id}","starred_url":"https://api.github.com/users/lygstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lygstate/subscriptions","organizations_url":"https://api.github.com/users/lygstate/orgs","repos_url":"https://api.github.com/users/lygstate/repos","events_url":"https://api.github.com/users/lygstate/events{/privacy}","received_events_url":"https://api.github.com/users/lygstate/received_events","type":"User","site_admin":false},"body":"It's not about OpenCL spec.\r\nBut the types defined  in kernel.cl","created_at":"2018-08-26T05:12:10Z","updated_at":"2018-08-26T05:12:11Z","html_url":"https://github.com/pytorch/glow/pull/1527#discussion_r212815031","pull_request_url":"https://api.github.com/repos/pytorch/glow/pulls/1527","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments/212815031"},"html":{"href":"https://github.com/pytorch/glow/pull/1527#discussion_r212815031"},"pull_request":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1527"}},"in_reply_to_id":212806647},"pull_request":{"url":"https://api.github.com/repos/pytorch/glow/pulls/1527","id":210884011,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODg0MDEx","html_url":"https://github.com/pytorch/glow/pull/1527","diff_url":"https://github.com/pytorch/glow/pull/1527.diff","patch_url":"https://github.com/pytorch/glow/pull/1527.patch","issue_url":"https://api.github.com/repos/pytorch/glow/issues/1527","number":1527,"state":"open","locked":false,"title":"Setting OCL Shapes properly.","user":{"login":"lygstate","id":121040,"node_id":"MDQ6VXNlcjEyMTA0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/121040?v=4","gravatar_id":"","url":"https://api.github.com/users/lygstate","html_url":"https://github.com/lygstate","followers_url":"https://api.github.com/users/lygstate/followers","following_url":"https://api.github.com/users/lygstate/following{/other_user}","gists_url":"https://api.github.com/users/lygstate/gists{/gist_id}","starred_url":"https://api.github.com/users/lygstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lygstate/subscriptions","organizations_url":"https://api.github.com/users/lygstate/orgs","repos_url":"https://api.github.com/users/lygstate/repos","events_url":"https://api.github.com/users/lygstate/events{/privacy}","received_events_url":"https://api.github.com/users/lygstate/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-25T03:57:29Z","updated_at":"2018-08-26T05:12:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34335479e3a956ed6580f24436f7cb0a439fedb5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":706497924,"node_id":"MDU6TGFiZWw3MDY0OTc5MjQ=","url":"https://api.github.com/repos/pytorch/glow/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/glow/pulls/1527/commits","review_comments_url":"https://api.github.com/repos/pytorch/glow/pulls/1527/comments","review_comment_url":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/glow/issues/1527/comments","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/e8bc00e298b0c2b1baff9026d333e48e8982df4b","head":{"label":"lygstate:ocl-shape","ref":"ocl-shape","sha":"e8bc00e298b0c2b1baff9026d333e48e8982df4b","user":{"login":"lygstate","id":121040,"node_id":"MDQ6VXNlcjEyMTA0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/121040?v=4","gravatar_id":"","url":"https://api.github.com/users/lygstate","html_url":"https://github.com/lygstate","followers_url":"https://api.github.com/users/lygstate/followers","following_url":"https://api.github.com/users/lygstate/following{/other_user}","gists_url":"https://api.github.com/users/lygstate/gists{/gist_id}","starred_url":"https://api.github.com/users/lygstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lygstate/subscriptions","organizations_url":"https://api.github.com/users/lygstate/orgs","repos_url":"https://api.github.com/users/lygstate/repos","events_url":"https://api.github.com/users/lygstate/events{/privacy}","received_events_url":"https://api.github.com/users/lygstate/received_events","type":"User","site_admin":false},"repo":{"id":139050740,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwNTA3NDA=","name":"glow","full_name":"lygstate/glow","owner":{"login":"lygstate","id":121040,"node_id":"MDQ6VXNlcjEyMTA0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/121040?v=4","gravatar_id":"","url":"https://api.github.com/users/lygstate","html_url":"https://github.com/lygstate","followers_url":"https://api.github.com/users/lygstate/followers","following_url":"https://api.github.com/users/lygstate/following{/other_user}","gists_url":"https://api.github.com/users/lygstate/gists{/gist_id}","starred_url":"https://api.github.com/users/lygstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lygstate/subscriptions","organizations_url":"https://api.github.com/users/lygstate/orgs","repos_url":"https://api.github.com/users/lygstate/repos","events_url":"https://api.github.com/users/lygstate/events{/privacy}","received_events_url":"https://api.github.com/users/lygstate/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lygstate/glow","description":"Compiler for Neural Network hardware accelerators","fork":true,"url":"https://api.github.com/repos/lygstate/glow","forks_url":"https://api.github.com/repos/lygstate/glow/forks","keys_url":"https://api.github.com/repos/lygstate/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lygstate/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lygstate/glow/teams","hooks_url":"https://api.github.com/repos/lygstate/glow/hooks","issue_events_url":"https://api.github.com/repos/lygstate/glow/issues/events{/number}","events_url":"https://api.github.com/repos/lygstate/glow/events","assignees_url":"https://api.github.com/repos/lygstate/glow/assignees{/user}","branches_url":"https://api.github.com/repos/lygstate/glow/branches{/branch}","tags_url":"https://api.github.com/repos/lygstate/glow/tags","blobs_url":"https://api.github.com/repos/lygstate/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lygstate/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lygstate/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/lygstate/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lygstate/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/lygstate/glow/languages","stargazers_url":"https://api.github.com/repos/lygstate/glow/stargazers","contributors_url":"https://api.github.com/repos/lygstate/glow/contributors","subscribers_url":"https://api.github.com/repos/lygstate/glow/subscribers","subscription_url":"https://api.github.com/repos/lygstate/glow/subscription","commits_url":"https://api.github.com/repos/lygstate/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/lygstate/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/lygstate/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/lygstate/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/lygstate/glow/contents/{+path}","compare_url":"https://api.github.com/repos/lygstate/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lygstate/glow/merges","archive_url":"https://api.github.com/repos/lygstate/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lygstate/glow/downloads","issues_url":"https://api.github.com/repos/lygstate/glow/issues{/number}","pulls_url":"https://api.github.com/repos/lygstate/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/lygstate/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/lygstate/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lygstate/glow/labels{/name}","releases_url":"https://api.github.com/repos/lygstate/glow/releases{/id}","deployments_url":"https://api.github.com/repos/lygstate/glow/deployments","created_at":"2018-06-28T17:45:52Z","updated_at":"2018-08-26T05:01:38Z","pushed_at":"2018-08-26T05:06:52Z","git_url":"git://github.com/lygstate/glow.git","ssh_url":"git@github.com:lygstate/glow.git","clone_url":"https://github.com/lygstate/glow.git","svn_url":"https://github.com/lygstate/glow","homepage":null,"size":7883,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"ee6ea3cdbe00dc77775452c340bb7c937deb7884","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":105281531,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyODE1MzE=","name":"glow","full_name":"pytorch/glow","owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/glow","description":"Compiler for Neural Network hardware accelerators","fork":false,"url":"https://api.github.com/repos/pytorch/glow","forks_url":"https://api.github.com/repos/pytorch/glow/forks","keys_url":"https://api.github.com/repos/pytorch/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/glow/teams","hooks_url":"https://api.github.com/repos/pytorch/glow/hooks","issue_events_url":"https://api.github.com/repos/pytorch/glow/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/glow/events","assignees_url":"https://api.github.com/repos/pytorch/glow/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/glow/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/glow/tags","blobs_url":"https://api.github.com/repos/pytorch/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/glow/languages","stargazers_url":"https://api.github.com/repos/pytorch/glow/stargazers","contributors_url":"https://api.github.com/repos/pytorch/glow/contributors","subscribers_url":"https://api.github.com/repos/pytorch/glow/subscribers","subscription_url":"https://api.github.com/repos/pytorch/glow/subscription","commits_url":"https://api.github.com/repos/pytorch/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/glow/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/glow/merges","archive_url":"https://api.github.com/repos/pytorch/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/glow/downloads","issues_url":"https://api.github.com/repos/pytorch/glow/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/glow/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/glow/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/glow/deployments","created_at":"2017-09-29T14:28:18Z","updated_at":"2018-08-25T18:46:21Z","pushed_at":"2018-08-26T05:06:54Z","git_url":"git://github.com/pytorch/glow.git","ssh_url":"git@github.com:pytorch/glow.git","clone_url":"https://github.com/pytorch/glow.git","svn_url":"https://github.com/pytorch/glow","homepage":null,"size":7863,"stargazers_count":692,"watchers_count":692,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":82,"open_issues":46,"watchers":692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1527"},"html":{"href":"https://github.com/pytorch/glow/pull/1527"},"issue":{"href":"https://api.github.com/repos/pytorch/glow/issues/1527"},"comments":{"href":"https://api.github.com/repos/pytorch/glow/issues/1527/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1527/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1527/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/glow/statuses/e8bc00e298b0c2b1baff9026d333e48e8982df4b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lygstate"}}