{"action":"created","comment":{"url":"https://api.github.com/repos/moreonion/share_light/pulls/comments/178782328","pull_request_review_id":108896615,"id":178782328,"diff_hunk":"@@ -64,25 +113,39 @@ public function getImageUrl() {\n     return FALSE;\n   }\n \n+  /**\n+   * HTML Renders the block.\n+   *\n+   * If google analytics tracking is enabled, the corresponding JavaScript files\n+   * are added.\n+   *\n+   * @return array\n+   *   A renderable array with\n+   *   `#theme`: set to `links` and\n+   *   `#links`: set to `channelLinks()` output, with each link wrapped in a\n+   *             '<span>' tag.\n+   */\n   public function render() {\n     drupal_alter('share_light_options', $this->options);\n \n-    // add tracking for GA if googleanalytics module is enabled\n+    // Add tracking for GA if googleanalytics module is enabled\n     // and share tracking is enabled (default: enabled)\n     $tracking_enabled = module_exists('googleanalytics') && variable_get('share_light_tracking_enabled', 1);\n     if ($tracking_enabled) {\n       drupal_add_js(drupal_get_path('module', 'share_light') . '/tracking.js');\n-      drupal_add_js(array('share_light' => array(\n-        'share_url' => $this->getUrl(FALSE),\n-      )), 'setting');\n+      drupal_add_js(array(\n+        'share_light' => array(\n+          'share_url' => $this->getUrl(FALSE),\n+        ),\n+      ), 'setting');\n     }\n \n+    drupal_add_js(drupal_get_path('module', 'share_light') . '/hide_mobile_buttons.js');\n     $links = $this->channelLinks();\n \n     foreach ($links as &$x) {\n       $x['title'] = \"<span>{$x['title']}</span>\";\n       $x['html'] = TRUE;\n-      $x['attributes']['target'] = '_blank';","path":"src/Block.php","position":147,"original_position":147,"commit_id":"8e92ec190770c3c807d824c464d0c0df1ed4fd5c","original_commit_id":"8e92ec190770c3c807d824c464d0c0df1ed4fd5c","user":{"login":"m-strasser","id":6950380,"avatar_url":"https://avatars1.githubusercontent.com/u/6950380?v=4","gravatar_id":"","url":"https://api.github.com/users/m-strasser","html_url":"https://github.com/m-strasser","followers_url":"https://api.github.com/users/m-strasser/followers","following_url":"https://api.github.com/users/m-strasser/following{/other_user}","gists_url":"https://api.github.com/users/m-strasser/gists{/gist_id}","starred_url":"https://api.github.com/users/m-strasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-strasser/subscriptions","organizations_url":"https://api.github.com/users/m-strasser/orgs","repos_url":"https://api.github.com/users/m-strasser/repos","events_url":"https://api.github.com/users/m-strasser/events{/privacy}","received_events_url":"https://api.github.com/users/m-strasser/received_events","type":"User","site_admin":false},"body":"`target` moved to each Channel separately as mobile buttons do not need `target=_blank` ","created_at":"2018-04-03T10:43:47Z","updated_at":"2018-04-03T10:43:47Z","html_url":"https://github.com/moreonion/share_light/pull/10#discussion_r178782328","pull_request_url":"https://api.github.com/repos/moreonion/share_light/pulls/10","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/moreonion/share_light/pulls/comments/178782328"},"html":{"href":"https://github.com/moreonion/share_light/pull/10#discussion_r178782328"},"pull_request":{"href":"https://api.github.com/repos/moreonion/share_light/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/moreonion/share_light/pulls/10","id":179058621,"html_url":"https://github.com/moreonion/share_light/pull/10","diff_url":"https://github.com/moreonion/share_light/pull/10.diff","patch_url":"https://github.com/moreonion/share_light/pull/10.patch","issue_url":"https://api.github.com/repos/moreonion/share_light/issues/10","number":10,"state":"open","locked":false,"title":"Feature mobile buttons","user":{"login":"m-strasser","id":6950380,"avatar_url":"https://avatars1.githubusercontent.com/u/6950380?v=4","gravatar_id":"","url":"https://api.github.com/users/m-strasser","html_url":"https://github.com/m-strasser","followers_url":"https://api.github.com/users/m-strasser/followers","following_url":"https://api.github.com/users/m-strasser/following{/other_user}","gists_url":"https://api.github.com/users/m-strasser/gists{/gist_id}","starred_url":"https://api.github.com/users/m-strasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-strasser/subscriptions","organizations_url":"https://api.github.com/users/m-strasser/orgs","repos_url":"https://api.github.com/users/m-strasser/repos","events_url":"https://api.github.com/users/m-strasser/events{/privacy}","received_events_url":"https://api.github.com/users/m-strasser/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-03T10:41:48Z","updated_at":"2018-04-03T10:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de40aae7401f7d9cf6e7a116c5c037cbc4fb79d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/moreonion/share_light/pulls/10/commits","review_comments_url":"https://api.github.com/repos/moreonion/share_light/pulls/10/comments","review_comment_url":"https://api.github.com/repos/moreonion/share_light/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moreonion/share_light/issues/10/comments","statuses_url":"https://api.github.com/repos/moreonion/share_light/statuses/8e92ec190770c3c807d824c464d0c0df1ed4fd5c","head":{"label":"moreonion:feature_mobile_buttons","ref":"feature_mobile_buttons","sha":"8e92ec190770c3c807d824c464d0c0df1ed4fd5c","user":{"login":"moreonion","id":558129,"avatar_url":"https://avatars3.githubusercontent.com/u/558129?v=4","gravatar_id":"","url":"https://api.github.com/users/moreonion","html_url":"https://github.com/moreonion","followers_url":"https://api.github.com/users/moreonion/followers","following_url":"https://api.github.com/users/moreonion/following{/other_user}","gists_url":"https://api.github.com/users/moreonion/gists{/gist_id}","starred_url":"https://api.github.com/users/moreonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moreonion/subscriptions","organizations_url":"https://api.github.com/users/moreonion/orgs","repos_url":"https://api.github.com/users/moreonion/repos","events_url":"https://api.github.com/users/moreonion/events{/privacy}","received_events_url":"https://api.github.com/users/moreonion/received_events","type":"Organization","site_admin":false},"repo":{"id":54648137,"name":"share_light","full_name":"moreonion/share_light","owner":{"login":"moreonion","id":558129,"avatar_url":"https://avatars3.githubusercontent.com/u/558129?v=4","gravatar_id":"","url":"https://api.github.com/users/moreonion","html_url":"https://github.com/moreonion","followers_url":"https://api.github.com/users/moreonion/followers","following_url":"https://api.github.com/users/moreonion/following{/other_user}","gists_url":"https://api.github.com/users/moreonion/gists{/gist_id}","starred_url":"https://api.github.com/users/moreonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moreonion/subscriptions","organizations_url":"https://api.github.com/users/moreonion/orgs","repos_url":"https://api.github.com/users/moreonion/repos","events_url":"https://api.github.com/users/moreonion/events{/privacy}","received_events_url":"https://api.github.com/users/moreonion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moreonion/share_light","description":null,"fork":false,"url":"https://api.github.com/repos/moreonion/share_light","forks_url":"https://api.github.com/repos/moreonion/share_light/forks","keys_url":"https://api.github.com/repos/moreonion/share_light/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moreonion/share_light/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moreonion/share_light/teams","hooks_url":"https://api.github.com/repos/moreonion/share_light/hooks","issue_events_url":"https://api.github.com/repos/moreonion/share_light/issues/events{/number}","events_url":"https://api.github.com/repos/moreonion/share_light/events","assignees_url":"https://api.github.com/repos/moreonion/share_light/assignees{/user}","branches_url":"https://api.github.com/repos/moreonion/share_light/branches{/branch}","tags_url":"https://api.github.com/repos/moreonion/share_light/tags","blobs_url":"https://api.github.com/repos/moreonion/share_light/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moreonion/share_light/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moreonion/share_light/git/refs{/sha}","trees_url":"https://api.github.com/repos/moreonion/share_light/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moreonion/share_light/statuses/{sha}","languages_url":"https://api.github.com/repos/moreonion/share_light/languages","stargazers_url":"https://api.github.com/repos/moreonion/share_light/stargazers","contributors_url":"https://api.github.com/repos/moreonion/share_light/contributors","subscribers_url":"https://api.github.com/repos/moreonion/share_light/subscribers","subscription_url":"https://api.github.com/repos/moreonion/share_light/subscription","commits_url":"https://api.github.com/repos/moreonion/share_light/commits{/sha}","git_commits_url":"https://api.github.com/repos/moreonion/share_light/git/commits{/sha}","comments_url":"https://api.github.com/repos/moreonion/share_light/comments{/number}","issue_comment_url":"https://api.github.com/repos/moreonion/share_light/issues/comments{/number}","contents_url":"https://api.github.com/repos/moreonion/share_light/contents/{+path}","compare_url":"https://api.github.com/repos/moreonion/share_light/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moreonion/share_light/merges","archive_url":"https://api.github.com/repos/moreonion/share_light/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moreonion/share_light/downloads","issues_url":"https://api.github.com/repos/moreonion/share_light/issues{/number}","pulls_url":"https://api.github.com/repos/moreonion/share_light/pulls{/number}","milestones_url":"https://api.github.com/repos/moreonion/share_light/milestones{/number}","notifications_url":"https://api.github.com/repos/moreonion/share_light/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moreonion/share_light/labels{/name}","releases_url":"https://api.github.com/repos/moreonion/share_light/releases{/id}","deployments_url":"https://api.github.com/repos/moreonion/share_light/deployments","created_at":"2016-03-24T14:27:56Z","updated_at":"2018-03-27T09:31:11Z","pushed_at":"2018-04-03T10:41:49Z","git_url":"git://github.com/moreonion/share_light.git","ssh_url":"git@github.com:moreonion/share_light.git","clone_url":"https://github.com/moreonion/share_light.git","svn_url":"https://github.com/moreonion/share_light","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"7.x-1.x"}},"base":{"label":"moreonion:7.x-1.x","ref":"7.x-1.x","sha":"4ebc0556f843e9c70c3738881023276818fb299c","user":{"login":"moreonion","id":558129,"avatar_url":"https://avatars3.githubusercontent.com/u/558129?v=4","gravatar_id":"","url":"https://api.github.com/users/moreonion","html_url":"https://github.com/moreonion","followers_url":"https://api.github.com/users/moreonion/followers","following_url":"https://api.github.com/users/moreonion/following{/other_user}","gists_url":"https://api.github.com/users/moreonion/gists{/gist_id}","starred_url":"https://api.github.com/users/moreonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moreonion/subscriptions","organizations_url":"https://api.github.com/users/moreonion/orgs","repos_url":"https://api.github.com/users/moreonion/repos","events_url":"https://api.github.com/users/moreonion/events{/privacy}","received_events_url":"https://api.github.com/users/moreonion/received_events","type":"Organization","site_admin":false},"repo":{"id":54648137,"name":"share_light","full_name":"moreonion/share_light","owner":{"login":"moreonion","id":558129,"avatar_url":"https://avatars3.githubusercontent.com/u/558129?v=4","gravatar_id":"","url":"https://api.github.com/users/moreonion","html_url":"https://github.com/moreonion","followers_url":"https://api.github.com/users/moreonion/followers","following_url":"https://api.github.com/users/moreonion/following{/other_user}","gists_url":"https://api.github.com/users/moreonion/gists{/gist_id}","starred_url":"https://api.github.com/users/moreonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moreonion/subscriptions","organizations_url":"https://api.github.com/users/moreonion/orgs","repos_url":"https://api.github.com/users/moreonion/repos","events_url":"https://api.github.com/users/moreonion/events{/privacy}","received_events_url":"https://api.github.com/users/moreonion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moreonion/share_light","description":null,"fork":false,"url":"https://api.github.com/repos/moreonion/share_light","forks_url":"https://api.github.com/repos/moreonion/share_light/forks","keys_url":"https://api.github.com/repos/moreonion/share_light/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moreonion/share_light/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moreonion/share_light/teams","hooks_url":"https://api.github.com/repos/moreonion/share_light/hooks","issue_events_url":"https://api.github.com/repos/moreonion/share_light/issues/events{/number}","events_url":"https://api.github.com/repos/moreonion/share_light/events","assignees_url":"https://api.github.com/repos/moreonion/share_light/assignees{/user}","branches_url":"https://api.github.com/repos/moreonion/share_light/branches{/branch}","tags_url":"https://api.github.com/repos/moreonion/share_light/tags","blobs_url":"https://api.github.com/repos/moreonion/share_light/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moreonion/share_light/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moreonion/share_light/git/refs{/sha}","trees_url":"https://api.github.com/repos/moreonion/share_light/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moreonion/share_light/statuses/{sha}","languages_url":"https://api.github.com/repos/moreonion/share_light/languages","stargazers_url":"https://api.github.com/repos/moreonion/share_light/stargazers","contributors_url":"https://api.github.com/repos/moreonion/share_light/contributors","subscribers_url":"https://api.github.com/repos/moreonion/share_light/subscribers","subscription_url":"https://api.github.com/repos/moreonion/share_light/subscription","commits_url":"https://api.github.com/repos/moreonion/share_light/commits{/sha}","git_commits_url":"https://api.github.com/repos/moreonion/share_light/git/commits{/sha}","comments_url":"https://api.github.com/repos/moreonion/share_light/comments{/number}","issue_comment_url":"https://api.github.com/repos/moreonion/share_light/issues/comments{/number}","contents_url":"https://api.github.com/repos/moreonion/share_light/contents/{+path}","compare_url":"https://api.github.com/repos/moreonion/share_light/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moreonion/share_light/merges","archive_url":"https://api.github.com/repos/moreonion/share_light/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moreonion/share_light/downloads","issues_url":"https://api.github.com/repos/moreonion/share_light/issues{/number}","pulls_url":"https://api.github.com/repos/moreonion/share_light/pulls{/number}","milestones_url":"https://api.github.com/repos/moreonion/share_light/milestones{/number}","notifications_url":"https://api.github.com/repos/moreonion/share_light/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moreonion/share_light/labels{/name}","releases_url":"https://api.github.com/repos/moreonion/share_light/releases{/id}","deployments_url":"https://api.github.com/repos/moreonion/share_light/deployments","created_at":"2016-03-24T14:27:56Z","updated_at":"2018-03-27T09:31:11Z","pushed_at":"2018-04-03T10:41:49Z","git_url":"git://github.com/moreonion/share_light.git","ssh_url":"git@github.com:moreonion/share_light.git","clone_url":"https://github.com/moreonion/share_light.git","svn_url":"https://github.com/moreonion/share_light","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"7.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/moreonion/share_light/pulls/10"},"html":{"href":"https://github.com/moreonion/share_light/pull/10"},"issue":{"href":"https://api.github.com/repos/moreonion/share_light/issues/10"},"comments":{"href":"https://api.github.com/repos/moreonion/share_light/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/moreonion/share_light/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/moreonion/share_light/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moreonion/share_light/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/moreonion/share_light/statuses/8e92ec190770c3c807d824c464d0c0df1ed4fd5c"}},"author_association":"NONE"}}
{"actor":{"display_login":"m-strasser"}}