{"action":"opened","issue":{"url":"https://api.github.com/repos/drush-ops/drush/issues/3376","repository_url":"https://api.github.com/repos/drush-ops/drush","labels_url":"https://api.github.com/repos/drush-ops/drush/issues/3376/labels{/name}","comments_url":"https://api.github.com/repos/drush-ops/drush/issues/3376/comments","events_url":"https://api.github.com/repos/drush-ops/drush/issues/3376/events","html_url":"https://github.com/drush-ops/drush/issues/3376","id":295983001,"number":3376,"title":"When an update fails, updatedb is still exiting with 0","user":{"login":"deviantintegral","id":255023,"avatar_url":"https://avatars2.githubusercontent.com/u/255023?v=4","gravatar_id":"","url":"https://api.github.com/users/deviantintegral","html_url":"https://github.com/deviantintegral","followers_url":"https://api.github.com/users/deviantintegral/followers","following_url":"https://api.github.com/users/deviantintegral/following{/other_user}","gists_url":"https://api.github.com/users/deviantintegral/gists{/gist_id}","starred_url":"https://api.github.com/users/deviantintegral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deviantintegral/subscriptions","organizations_url":"https://api.github.com/users/deviantintegral/orgs","repos_url":"https://api.github.com/users/deviantintegral/repos","events_url":"https://api.github.com/users/deviantintegral/events{/privacy}","received_events_url":"https://api.github.com/users/deviantintegral/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-09T19:21:03Z","updated_at":"2018-02-09T19:21:03Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"This looks like a regression from #3095.\r\n\r\nIn attempting to run updates from a Drupal 8.4.4 install to 8.5.x using Drush 9.1.0, a fatal error is thrown, but drush still returned success. Note the last line with the exit code:\r\n\r\n```\r\n-------- ------------- --------------- --------------------------------------- \r\n  Module   Update ID     Type            Description                            \r\n -------- ------------- --------------- --------------------------------------- \r\n  system   8501          hook_update_n   Add the 'revision_default' field to    \r\n                                         all relevant entity types.             \r\n  views    8500          hook_update_n   Update field names for multi-value     \r\n                                         base fields.                           \r\n  system   change_acti   post-update     Change plugin IDs of actions.          \r\n           on_plugins                                                           \r\n  system   field_forma   post-update     Clear caches due to schema changes in  \r\n           tter_entity                   core.entity.schema.yml.                \r\n           _schema                                                              \r\n  views    bulk_field_   post-update     Update dependencies for moved bulk     \r\n           moved                         field plugin.                          \r\n  views    entity_link   post-update     Add additional settings to the entity  \r\n           _url                          link field and convert node_path       \r\n                                         usage  to entity_link.                 \r\n  views    filter_plac   post-update     Add placeholder settings to string or  \r\n           eholder_tex                   numeric filters.                       \r\n           t                                                                    \r\n -------- ------------- --------------- --------------------------------------- \r\n\r\n // Do you wish to run the specified pending updates?: yes.                     \r\n\r\n [notice] Update started: system_update_8501\r\nTypeError: Return value of Doctrine\\Common\\Annotations\\AnnotationRegistry::reset() must be an instance of Doctrine\\Common\\Annotations\\void, none returned in Doctrine\\Common\\Annotations\\AnnotationRegistry::reset() (line 55 of /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationRegistry.php).\r\n [error]  TypeError: Return value of Doctrine\\Common\\Annotations\\AnnotationRegistry::reset() must be an instance of Doctrine\\Common\\Annotations\\void, none returned in Doctrine\\Common\\Annotations\\AnnotationRegistry::reset() (line 55 of /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationRegistry.php) #0 /srv/bindings/221f215df214430b82daa4e29943f72b/code/web/core/lib/Drupal/Component/Annotation/Plugin/Discovery/AnnotatedClassDiscovery.php(113): Doctrine\\Common\\Annotations\\AnnotationRegistry::reset()\r\n#1 /srv/bindings/221f215df214430b82daa4e29943f72b/code/web/core/lib/Drupal/Core/Entity/EntityTypeManager.php(106): Drupal\\Component\\Annotation\\Plugin\\Discovery\\AnnotatedClassDiscovery->getDefinitions()\r\n#2 /srv/bindings/221f215df214430b82daa4e29943f72b/code/web/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php(175): Drupal\\Core\\Entity\\EntityTypeManager->findDefinitions()\r\n#3 /srv/bindings/221f215df214430b82daa4e29943f72b/code/web/core/modules/system/system.install(2079): Drupal\\Core\\Plugin\\DefaultPluginManager->getDefinitions()\r\n#4 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/drush/drush/src/Commands/core/UpdateDBCommands.php(185): system_update_8501(Array)\r\n#5 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/drush/drush/includes/batch.inc(235): Drush\\Commands\\core\\UpdateDBCommands->updateDoOne('system', 8501, Array, Object(DrushBatchContext))\r\n#6 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/drush/drush/includes/batch.inc(183): _drush_batch_worker()\r\n#7 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/drush/drush/includes/batch.inc(95): _drush_batch_command('2')\r\n#8 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/drush/drush/src/Commands/core/UpdateDBCommands.php(142): drush_batch_command('2')\r\n#9 [internal function]: Drush\\Commands\\core\\UpdateDBCommands->process('2', Array)\r\n#10 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/consolidation/annotated-command/src/CommandProcessor.php(235): call_user_func_array(Array, Array)\r\n#11 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/consolidation/annotated-command/src/CommandProcessor.php(181): Consolidation\\AnnotatedCommand\\CommandProcessor->runCommandCallback(Array, Object(Consolidation\\AnnotatedCommand\\CommandData))\r\n#12 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/consolidation/annotated-command/src/CommandProcessor.php(150): Consolidation\\AnnotatedCommand\\CommandProcessor->validateRunAndAlter(Array, Array, Object(Consolidation\\AnnotatedCommand\\CommandData))\r\n#13 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(404): Consolidation\\AnnotatedCommand\\CommandProcessor->process(Object(Symfony\\Component\\Console\\Output\\ConsoleOutput), Array, Array, Object(Consolidation\\AnnotatedCommand\\CommandData))\r\n#14 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/symfony/console/Command/Command.php(252): Consolidation\\AnnotatedCommand\\AnnotatedCommand->execute(Object(Drush\\Symfony\\LessStrictArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#15 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/symfony/console/Application.php(964): Symfony\\Component\\Console\\Command\\Command->run(Object(Drush\\Symfony\\LessStrictArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#16 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/symfony/console/Application.php(248): Symfony\\Component\\Console\\Application->doRunCommand(Object(Consolidation\\AnnotatedCommand\\AnnotatedCommand), Object(Drush\\Symfony\\LessStrictArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#17 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/symfony/console/Application.php(148): Symfony\\Component\\Console\\Application->doRun(Object(Drush\\Symfony\\LessStrictArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#18 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/drush/drush/src/Runtime/Runtime.php(112): Symfony\\Component\\Console\\Application->run(Object(Drush\\Symfony\\LessStrictArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#19 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/drush/drush/src/Runtime/Runtime.php(41): Drush\\Runtime\\Runtime->doRun(Array)\r\n#20 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/drush/drush/drush.php(64): Drush\\Runtime\\Runtime->run(Array)\r\n#21 /srv/bindings/221f215df214430b82daa4e29943f72b/code/vendor/drush/drush/drush(4): require('/srv/bindings/2...')\r\n#22 {main}. \r\n [error]  Drush command terminated abnormally due to an unrecoverable error. \r\n [success] Finished performing updates.\r\n [notice] Command: test-85x.ci-9 -- drush updatedb [Exit: 0]\r\n```"}}
{"actor":{"display_login":"deviantintegral"}}