{"action":"created","issue":{"url":"https://api.github.com/repos/gwaldron/osgearth/issues/706","repository_url":"https://api.github.com/repos/gwaldron/osgearth","labels_url":"https://api.github.com/repos/gwaldron/osgearth/issues/706/labels{/name}","comments_url":"https://api.github.com/repos/gwaldron/osgearth/issues/706/comments","events_url":"https://api.github.com/repos/gwaldron/osgearth/issues/706/events","html_url":"https://github.com/gwaldron/osgearth/issues/706","id":145612975,"number":706,"title":"Cmake FindZLIB module import multi 'optimized' mark","user":{"login":"robling","id":1468628,"avatar_url":"https://avatars2.githubusercontent.com/u/1468628?v=4","gravatar_id":"","url":"https://api.github.com/users/robling","html_url":"https://github.com/robling","followers_url":"https://api.github.com/users/robling/followers","following_url":"https://api.github.com/users/robling/following{/other_user}","gists_url":"https://api.github.com/users/robling/gists{/gist_id}","starred_url":"https://api.github.com/users/robling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robling/subscriptions","organizations_url":"https://api.github.com/users/robling/orgs","repos_url":"https://api.github.com/users/robling/repos","events_url":"https://api.github.com/users/robling/events{/privacy}","received_events_url":"https://api.github.com/users/robling/received_events","type":"User","site_admin":false},"labels":[{"id":1098655,"url":"https://api.github.com/repos/gwaldron/osgearth/labels/nuisance","name":"nuisance","color":"ffcfcf","default":false}],"state":"closed","locked":false,"assignee":{"login":"jasonbeverage","id":326626,"avatar_url":"https://avatars0.githubusercontent.com/u/326626?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonbeverage","html_url":"https://github.com/jasonbeverage","followers_url":"https://api.github.com/users/jasonbeverage/followers","following_url":"https://api.github.com/users/jasonbeverage/following{/other_user}","gists_url":"https://api.github.com/users/jasonbeverage/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonbeverage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonbeverage/subscriptions","organizations_url":"https://api.github.com/users/jasonbeverage/orgs","repos_url":"https://api.github.com/users/jasonbeverage/repos","events_url":"https://api.github.com/users/jasonbeverage/events{/privacy}","received_events_url":"https://api.github.com/users/jasonbeverage/received_events","type":"User","site_admin":false},"assignees":[{"login":"jasonbeverage","id":326626,"avatar_url":"https://avatars0.githubusercontent.com/u/326626?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonbeverage","html_url":"https://github.com/jasonbeverage","followers_url":"https://api.github.com/users/jasonbeverage/followers","following_url":"https://api.github.com/users/jasonbeverage/following{/other_user}","gists_url":"https://api.github.com/users/jasonbeverage/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonbeverage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonbeverage/subscriptions","organizations_url":"https://api.github.com/users/jasonbeverage/orgs","repos_url":"https://api.github.com/users/jasonbeverage/repos","events_url":"https://api.github.com/users/jasonbeverage/events{/privacy}","received_events_url":"https://api.github.com/users/jasonbeverage/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2016-04-04T08:01:39Z","updated_at":"2018-05-15T16:59:02Z","closed_at":"2018-05-15T16:59:02Z","author_association":"NONE","body":"When I tried to build osgEarth 2.7.0 with Cmake 3.5, vs2010, I got a link error which requires 'optimized.lib' and 'debug.lib'. I've find there is repeated 'optimized' mark in 'ZLIB_LIBRARY'. Adding aome 'MESSAGE' statements and I got:\n\n```\nMESSAGE(${ZLIB_LIBRARY}) : optimized /PATH/TO/zlib1.lib debug /PATH/TO/zlib1d.lib  \nMESSAGE(${ZLIB_LIBRARIES}) : optimized /PATH/TO/zlib1.lib debug /PATH/TO/zlib1d.lib  \nMESSAGE(${ZLIB_LIBRARY_RELEASE}) : /PATH/TO/zlib1.lib\nMESSAGE(${ZLIB_LIBRARY_DEBUG}) :  /PATH/TO/zlib1d.lib\n```\n\nAnd the 'LINK_WITH_VARIABLES' Macro adds another 'optimized' mark to 'ZLIB_LIBRARY' which becomes the odd 'optimized.lib' linking target.\n\nI change line 355 in osgearth/src/osgEarth/CMakeLists.txt ::\n`LINK_WITH_VARIABLES(${LIB_NAME} OSG_LIBRARY OSGUTIL_LIBRA... ZLIB_LIBRARY ...`\nremove ZLIB_LIBRARY in it and add the following line::\n`LIST(APPEND ${LIB_NAME} ${ZLIB_LIBRARY})`\n\nThat works for me.\n"},"comment":{"url":"https://api.github.com/repos/gwaldron/osgearth/issues/comments/389239469","html_url":"https://github.com/gwaldron/osgearth/issues/706#issuecomment-389239469","issue_url":"https://api.github.com/repos/gwaldron/osgearth/issues/706","id":389239469,"user":{"login":"gwaldron","id":326618,"avatar_url":"https://avatars3.githubusercontent.com/u/326618?v=4","gravatar_id":"","url":"https://api.github.com/users/gwaldron","html_url":"https://github.com/gwaldron","followers_url":"https://api.github.com/users/gwaldron/followers","following_url":"https://api.github.com/users/gwaldron/following{/other_user}","gists_url":"https://api.github.com/users/gwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/gwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwaldron/subscriptions","organizations_url":"https://api.github.com/users/gwaldron/orgs","repos_url":"https://api.github.com/users/gwaldron/repos","events_url":"https://api.github.com/users/gwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/gwaldron/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T16:59:02Z","updated_at":"2018-05-15T16:59:02Z","author_association":"OWNER","body":"obe - addressed in cmake modules update"}}
{"actor":{"display_login":"gwaldron"}}