{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/243426879","pull_request_review_id":187196471,"id":243426879,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQyNjg3OQ==","diff_hunk":"@@ -55,11 +55,27 @@ using Random\n     end\n end\n @testset \"signed\" begin\n-    @test signed(3) == 3\n-    @test signed(UInt(3)) == 3\n+    @test signed(3) === 3\n+    @test signed(UInt(3)) === 3\n     @test isa(signed(UInt(3)), Int)\n-    @test signed(UInt(0) - 1) == -1\n-    @test_throws InexactError signed(UInt(-3))\n+    @test signed(UInt(0) - 1) === -1\n+    @test_throws InexactError signed(UInt(-3))  # Note that UInt() throws, not signed().\n+end","path":"test/int.jl","position":13,"original_position":13,"commit_id":"6a34de1b3f978eacd359d548335c0f2ee7a3d3e5","original_commit_id":"6a34de1b3f978eacd359d548335c0f2ee7a3d3e5","user":{"login":"NHDaly","id":1582097,"node_id":"MDQ6VXNlcjE1ODIwOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1582097?v=4","gravatar_id":"","url":"https://api.github.com/users/NHDaly","html_url":"https://github.com/NHDaly","followers_url":"https://api.github.com/users/NHDaly/followers","following_url":"https://api.github.com/users/NHDaly/following{/other_user}","gists_url":"https://api.github.com/users/NHDaly/gists{/gist_id}","starred_url":"https://api.github.com/users/NHDaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NHDaly/subscriptions","organizations_url":"https://api.github.com/users/NHDaly/orgs","repos_url":"https://api.github.com/users/NHDaly/repos","events_url":"https://api.github.com/users/NHDaly/events{/privacy}","received_events_url":"https://api.github.com/users/NHDaly/received_events","type":"User","site_admin":false},"body":"Looks like the test was added here: https://github.com/JuliaLang/julia/pull/11962, during `v0.4.0`.\r\n\r\nMaybe the behavior was different back then, or maybe it was a mistake? (It was David's _first PR ever_ after all! 😋) I'm happy to either remove the whole line or just leave the comment; whatever you prefer!","created_at":"2018-12-20T21:42:29Z","updated_at":"2018-12-20T21:42:29Z","html_url":"https://github.com/JuliaLang/julia/pull/30445#discussion_r243426879","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/30445","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/243426879"},"html":{"href":"https://github.com/JuliaLang/julia/pull/30445#discussion_r243426879"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/30445"}},"in_reply_to_id":243025745},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/30445","id":239672444,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NjcyNDQ0","html_url":"https://github.com/JuliaLang/julia/pull/30445","diff_url":"https://github.com/JuliaLang/julia/pull/30445.diff","patch_url":"https://github.com/JuliaLang/julia/pull/30445.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/30445","number":30445,"state":"open","locked":false,"title":"Add `signed(T)`, `unsigned(T)`.","user":{"login":"NHDaly","id":1582097,"node_id":"MDQ6VXNlcjE1ODIwOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1582097?v=4","gravatar_id":"","url":"https://api.github.com/users/NHDaly","html_url":"https://github.com/NHDaly","followers_url":"https://api.github.com/users/NHDaly/followers","following_url":"https://api.github.com/users/NHDaly/following{/other_user}","gists_url":"https://api.github.com/users/NHDaly/gists{/gist_id}","starred_url":"https://api.github.com/users/NHDaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NHDaly/subscriptions","organizations_url":"https://api.github.com/users/NHDaly/orgs","repos_url":"https://api.github.com/users/NHDaly/repos","events_url":"https://api.github.com/users/NHDaly/events{/privacy}","received_events_url":"https://api.github.com/users/NHDaly/received_events","type":"User","site_admin":false},"body":"Converts Types into their corresponding signed/unsigned equivalents, maintaining storage size, but changing signed-ness.\r\n\r\nFixes https://github.com/JuliaLang/julia/issues/30444.","created_at":"2018-12-19T00:05:51Z","updated_at":"2018-12-20T21:42:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34cbeedad6aa32c18d2856aae7fbd3816eeb55af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/30445/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/30445/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/30445/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/6a34de1b3f978eacd359d548335c0f2ee7a3d3e5","head":{"label":"NHDaly:signed_T__unsigned_T","ref":"signed_T__unsigned_T","sha":"6a34de1b3f978eacd359d548335c0f2ee7a3d3e5","user":{"login":"NHDaly","id":1582097,"node_id":"MDQ6VXNlcjE1ODIwOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1582097?v=4","gravatar_id":"","url":"https://api.github.com/users/NHDaly","html_url":"https://github.com/NHDaly","followers_url":"https://api.github.com/users/NHDaly/followers","following_url":"https://api.github.com/users/NHDaly/following{/other_user}","gists_url":"https://api.github.com/users/NHDaly/gists{/gist_id}","starred_url":"https://api.github.com/users/NHDaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NHDaly/subscriptions","organizations_url":"https://api.github.com/users/NHDaly/orgs","repos_url":"https://api.github.com/users/NHDaly/repos","events_url":"https://api.github.com/users/NHDaly/events{/privacy}","received_events_url":"https://api.github.com/users/NHDaly/received_events","type":"User","site_admin":false},"repo":{"id":87767461,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzc2NzQ2MQ==","name":"julia","full_name":"NHDaly/julia","private":false,"owner":{"login":"NHDaly","id":1582097,"node_id":"MDQ6VXNlcjE1ODIwOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1582097?v=4","gravatar_id":"","url":"https://api.github.com/users/NHDaly","html_url":"https://github.com/NHDaly","followers_url":"https://api.github.com/users/NHDaly/followers","following_url":"https://api.github.com/users/NHDaly/following{/other_user}","gists_url":"https://api.github.com/users/NHDaly/gists{/gist_id}","starred_url":"https://api.github.com/users/NHDaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NHDaly/subscriptions","organizations_url":"https://api.github.com/users/NHDaly/orgs","repos_url":"https://api.github.com/users/NHDaly/repos","events_url":"https://api.github.com/users/NHDaly/events{/privacy}","received_events_url":"https://api.github.com/users/NHDaly/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NHDaly/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/NHDaly/julia","forks_url":"https://api.github.com/repos/NHDaly/julia/forks","keys_url":"https://api.github.com/repos/NHDaly/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NHDaly/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NHDaly/julia/teams","hooks_url":"https://api.github.com/repos/NHDaly/julia/hooks","issue_events_url":"https://api.github.com/repos/NHDaly/julia/issues/events{/number}","events_url":"https://api.github.com/repos/NHDaly/julia/events","assignees_url":"https://api.github.com/repos/NHDaly/julia/assignees{/user}","branches_url":"https://api.github.com/repos/NHDaly/julia/branches{/branch}","tags_url":"https://api.github.com/repos/NHDaly/julia/tags","blobs_url":"https://api.github.com/repos/NHDaly/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NHDaly/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NHDaly/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/NHDaly/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NHDaly/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/NHDaly/julia/languages","stargazers_url":"https://api.github.com/repos/NHDaly/julia/stargazers","contributors_url":"https://api.github.com/repos/NHDaly/julia/contributors","subscribers_url":"https://api.github.com/repos/NHDaly/julia/subscribers","subscription_url":"https://api.github.com/repos/NHDaly/julia/subscription","commits_url":"https://api.github.com/repos/NHDaly/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/NHDaly/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/NHDaly/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/NHDaly/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/NHDaly/julia/contents/{+path}","compare_url":"https://api.github.com/repos/NHDaly/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NHDaly/julia/merges","archive_url":"https://api.github.com/repos/NHDaly/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NHDaly/julia/downloads","issues_url":"https://api.github.com/repos/NHDaly/julia/issues{/number}","pulls_url":"https://api.github.com/repos/NHDaly/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/NHDaly/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/NHDaly/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NHDaly/julia/labels{/name}","releases_url":"https://api.github.com/repos/NHDaly/julia/releases{/id}","deployments_url":"https://api.github.com/repos/NHDaly/julia/deployments","created_at":"2017-04-10T04:45:26Z","updated_at":"2018-12-19T00:05:45Z","pushed_at":"2018-12-19T18:24:14Z","git_url":"git://github.com/NHDaly/julia.git","ssh_url":"git@github.com:NHDaly/julia.git","clone_url":"https://github.com/NHDaly/julia.git","svn_url":"https://github.com/NHDaly/julia","homepage":"http://julialang.org/","size":195504,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"2c714888b413c503590fd953196f7dcc2c3a32e3","user":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ0MTk2","name":"julia","full_name":"JuliaLang/julia","private":false,"owner":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2018-12-20T21:32:08Z","pushed_at":"2018-12-20T21:33:00Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"https://julialang.org/","size":164452,"stargazers_count":19224,"watchers_count":19224,"language":"Julia","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3100,"mirror_url":null,"archived":false,"open_issues_count":3029,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3100,"open_issues":3029,"watchers":19224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/30445"},"html":{"href":"https://github.com/JuliaLang/julia/pull/30445"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/30445"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/30445/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/30445/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/30445/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/6a34de1b3f978eacd359d548335c0f2ee7a3d3e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"NHDaly"}}