{"action":"created","issue":{"url":"https://api.github.com/repos/cookieY/Yearning/issues/19","repository_url":"https://api.github.com/repos/cookieY/Yearning","labels_url":"https://api.github.com/repos/cookieY/Yearning/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/cookieY/Yearning/issues/19/comments","events_url":"https://api.github.com/repos/cookieY/Yearning/issues/19/events","html_url":"https://github.com/cookieY/Yearning/pull/19","id":307156433,"number":19,"title":"修改了用户登录界面的相关操作,去掉了前端代码中的 dist 文件夹","user":{"login":"LeoQuote","id":4143818,"avatar_url":"https://avatars3.githubusercontent.com/u/4143818?v=4","gravatar_id":"","url":"https://api.github.com/users/LeoQuote","html_url":"https://github.com/LeoQuote","followers_url":"https://api.github.com/users/LeoQuote/followers","following_url":"https://api.github.com/users/LeoQuote/following{/other_user}","gists_url":"https://api.github.com/users/LeoQuote/gists{/gist_id}","starred_url":"https://api.github.com/users/LeoQuote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeoQuote/subscriptions","organizations_url":"https://api.github.com/users/LeoQuote/orgs","repos_url":"https://api.github.com/users/LeoQuote/repos","events_url":"https://api.github.com/users/LeoQuote/events{/privacy}","received_events_url":"https://api.github.com/users/LeoQuote/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-21T08:38:22Z","updated_at":"2018-03-22T06:27:11Z","closed_at":"2018-03-21T11:11:46Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cookieY/Yearning/pulls/19","html_url":"https://github.com/cookieY/Yearning/pull/19","diff_url":"https://github.com/cookieY/Yearning/pull/19.diff","patch_url":"https://github.com/cookieY/Yearning/pull/19.patch"},"body":"* 修改了``user.py`` 在ldap 用户登录时, 不保存用户的密码, 密码项设置为 ``unusable_password`` , ldap 只做验证, 增强安全性\r\n* 修改了``Login.vue`` , 在登录时,不将密码明文保存在``cookie``内\r\n* 去掉了``dist``文件夹, 精简提交代码, 同时也更新了``gitignore``"},"comment":{"url":"https://api.github.com/repos/cookieY/Yearning/issues/comments/375193462","html_url":"https://github.com/cookieY/Yearning/pull/19#issuecomment-375193462","issue_url":"https://api.github.com/repos/cookieY/Yearning/issues/19","id":375193462,"user":{"login":"cookieY","id":22343354,"avatar_url":"https://avatars0.githubusercontent.com/u/22343354?v=4","gravatar_id":"","url":"https://api.github.com/users/cookieY","html_url":"https://github.com/cookieY","followers_url":"https://api.github.com/users/cookieY/followers","following_url":"https://api.github.com/users/cookieY/following{/other_user}","gists_url":"https://api.github.com/users/cookieY/gists{/gist_id}","starred_url":"https://api.github.com/users/cookieY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cookieY/subscriptions","organizations_url":"https://api.github.com/users/cookieY/orgs","repos_url":"https://api.github.com/users/cookieY/repos","events_url":"https://api.github.com/users/cookieY/events{/privacy}","received_events_url":"https://api.github.com/users/cookieY/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T06:27:11Z","updated_at":"2018-03-22T06:27:11Z","author_association":"OWNER","body":"1.kibana 不放的原因是github存在的只是开源代码，通过社区力量协助一起修改,主要的目标群体是开发人员而不是用户，因为用户会直接在官方下载。但是yearning面向的更多的是使用者而不是开发者,不能以开发者的角度去看待用户。如果不放或者放着不更新。岂不是要让用户还要装node自己去编译一遍？或者直接用Node去启动？ 在我看用node直接以开发者模式启动是会带来稳定性及其他问题。 首先项目的出发点是为了用户,使用方便是第一位。\r\n\r\n2.对于锁屏的问题,对于ldap用户来说你提交的修改为set_unusable_password 会导致ldap用户锁屏后无法解锁.(因为现在的逻辑是重新鉴权，但是并没有区分ldap用户和普通用户) 如果要实现这个功能需要更改前后端使其能够鉴别出两种模式的用户。虽然set_unusable_password方法更加安全 但是新建用户的密码也是已加密的形式存在于数据库中，所以安全性来说并没有带来多少实质性的提升。综合时间成本与安全成本，我个人感觉意义不大。如果是再跳一次登录页面。这样从本质上来说已经没有锁定账户的意义，而且这样的跳转是没有现阶段的锁屏来的体验度高。至于前端cookie明文问题会通过sha1加密的方式保存。\r\n\r\n3.至于关闭pr的问题。 我欢迎所有的意见及pr。但是作为yearning的作者，我也拥有合并及关闭的权利。我认为或者大家一致肯定的pr 我一定会及时合并。但是当我个人认为或大家认为有待商榷的部分可能需要再修改。 我个人的习惯是希望一个pr 一个commit。 如果是这个原因触及到了你，那我十分的抱歉。"}}
{"actor":{"display_login":"cookieY"}}