{"action":"created","issue":{"url":"https://api.github.com/repos/energy-plus/EnergyPlus/issues/26","repository_url":"https://api.github.com/repos/energy-plus/EnergyPlus","labels_url":"https://api.github.com/repos/energy-plus/EnergyPlus/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/energy-plus/EnergyPlus/issues/26/comments","events_url":"https://api.github.com/repos/energy-plus/EnergyPlus/issues/26/events","html_url":"https://github.com/energy-plus/EnergyPlus/pull/26","id":295333060,"number":26,"title":"Coil hackathon branch1","user":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-02-07T23:35:41Z","updated_at":"2018-02-16T02:03:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/energy-plus/EnergyPlus/pulls/26","html_url":"https://github.com/energy-plus/EnergyPlus/pull/26","diff_url":"https://github.com/energy-plus/EnergyPlus/pull/26.diff","patch_url":"https://github.com/energy-plus/EnergyPlus/pull/26.patch"},"body":"Pull request overview\r\n---------------------\r\nPlease change this line to a description of the pull request, with useful supporting information including whether it is a new feature, or fixes a defect, a cross reference to any defects addressed in this PR, the type of changes to be made, and whether diffs are expected/justified based on this change.\r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [ ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [ ] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n   - Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring\r\n   - NewFeature: This pull request includes code to add a new feature to EnergyPlus\r\n   - Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus\r\n   - DoNoPublish: This pull request includes changes that shouldn't be included in the changelog\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n   - [ ] If transition, add rules to spreadsheet\r\n   - [ ] If transition, add transition source\r\n   - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] Changed docs build successfully\r\n - [ ] ExpandObjects changes?\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n"},"comment":{"url":"https://api.github.com/repos/energy-plus/EnergyPlus/issues/comments/366124416","html_url":"https://github.com/energy-plus/EnergyPlus/pull/26#issuecomment-366124416","issue_url":"https://api.github.com/repos/energy-plus/EnergyPlus/issues/26","id":366124416,"user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars3.githubusercontent.com/u/5778156?v=4","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T02:03:02Z","updated_at":"2018-02-16T02:03:02Z","author_association":"COLLABORATOR","body":"Here's a rookie question. Why is PsychState a struct instead of a class? Couldn't we just make this a class and part of other classes that use it and just write to it instead of passing it around as an argument and a return?"}}
{"actor":{"display_login":"rraustad"}}