{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/22516","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/22516/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22516/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/22516/events","html_url":"https://github.com/nodejs/node/pull/22516","id":353969257,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODc3NjQw","number":22516,"title":"test: move test that depends on dns query to internet","user":{"login":"joyeecheung","id":4299420,"node_id":"MDQ6VXNlcjQyOTk0MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"labels":[{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-25T01:07:46Z","updated_at":"2018-08-25T01:26:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22516","html_url":"https://github.com/nodejs/node/pull/22516","diff_url":"https://github.com/nodejs/node/pull/22516.diff","patch_url":"https://github.com/nodejs/node/pull/22516.patch"},"body":"These test cases in `test/parallel/test-dns-lookup.js` send\r\ndns requests and depend on the results, which could fail\r\nif the DNS service for invalid hosts is hijacked by the ISP.\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/415920417","html_url":"https://github.com/nodejs/node/pull/22516#issuecomment-415920417","issue_url":"https://api.github.com/repos/nodejs/node/issues/22516","id":415920417,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTkyMDQxNw==","user":{"login":"Trott","id":718899,"node_id":"MDQ6VXNlcjcxODg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"created_at":"2018-08-25T01:26:39Z","updated_at":"2018-08-25T01:26:39Z","author_association":"MEMBER","body":"Related: I wonder if `make test-coverage` should be modified to include the `internet` tests."}}
{"actor":{"display_login":"Trott"}}