{"action":"created","comment":{"url":"https://api.github.com/repos/mesg-foundation/core/pulls/comments/240119504","pull_request_review_id":183073785,"id":240119504,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDExOTUwNA==","diff_hunk":"@@ -29,15 +34,53 @@ func (s *Server) DeployService(stream coreapi.Core_DeployServiceServer) error {\n \t\terr             error\n \t)\n \n-\tsr := newDeployServiceStreamReader(stream)\n-\turl, err := sr.GetURL()\n-\tif err != nil {\n+\t// receive the first message in the stream.\n+\tif err := sr.RecvMessage(); err != nil {\n \t\treturn err\n \t}\n-\tif url != \"\" {\n-\t\tservice, validationError, err = s.api.DeployServiceFromURL(url, api.DeployServiceStatusOption(statuses))\n+\n+\tdeployOptions := []api.DeployServiceOption{\n+\t\tapi.DeployServiceStatusOption(statuses),\n+\t}\n+\n+\t// receive confirmation for a force deploy.","path":"interface/grpc/core/deploy.go","position":49,"original_position":50,"commit_id":"296877bed6c24d56f47a6c706704f3901d81f68e","original_commit_id":"4f3705f12e3fe116abb077556944165724050798","user":{"login":"ilgooz","id":6023117,"node_id":"MDQ6VXNlcjYwMjMxMTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6023117?v=4","gravatar_id":"","url":"https://api.github.com/users/ilgooz","html_url":"https://github.com/ilgooz","followers_url":"https://api.github.com/users/ilgooz/followers","following_url":"https://api.github.com/users/ilgooz/following{/other_user}","gists_url":"https://api.github.com/users/ilgooz/gists{/gist_id}","starred_url":"https://api.github.com/users/ilgooz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilgooz/subscriptions","organizations_url":"https://api.github.com/users/ilgooz/orgs","repos_url":"https://api.github.com/users/ilgooz/repos","events_url":"https://api.github.com/users/ilgooz/events{/privacy}","received_events_url":"https://api.github.com/users/ilgooz/received_events","type":"User","site_admin":false},"body":"I don't think that would be a proper way of testing the DeployService. Feel free to create an another PR based on this one to implement the tests. So, we can compare and merge it to this PR if it's convenient enough.","created_at":"2018-12-10T08:37:14Z","updated_at":"2018-12-10T08:37:15Z","html_url":"https://github.com/mesg-foundation/core/pull/623#discussion_r240119504","pull_request_url":"https://api.github.com/repos/mesg-foundation/core/pulls/623","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/comments/240119504"},"html":{"href":"https://github.com/mesg-foundation/core/pull/623#discussion_r240119504"},"pull_request":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/623"}},"in_reply_to_id":239682776},"pull_request":{"url":"https://api.github.com/repos/mesg-foundation/core/pulls/623","id":236418592,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NDE4NTky","html_url":"https://github.com/mesg-foundation/core/pull/623","diff_url":"https://github.com/mesg-foundation/core/pull/623.diff","patch_url":"https://github.com/mesg-foundation/core/pull/623.patch","issue_url":"https://api.github.com/repos/mesg-foundation/core/issues/623","number":623,"state":"open","locked":false,"title":"[Wip] Ask user's confirmation when service will replace an other service","user":{"login":"NicolasMahe","id":5823445,"node_id":"MDQ6VXNlcjU4MjM0NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5823445?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasMahe","html_url":"https://github.com/NicolasMahe","followers_url":"https://api.github.com/users/NicolasMahe/followers","following_url":"https://api.github.com/users/NicolasMahe/following{/other_user}","gists_url":"https://api.github.com/users/NicolasMahe/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasMahe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasMahe/subscriptions","organizations_url":"https://api.github.com/users/NicolasMahe/orgs","repos_url":"https://api.github.com/users/NicolasMahe/repos","events_url":"https://api.github.com/users/NicolasMahe/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasMahe/received_events","type":"User","site_admin":false},"body":"# WIP","created_at":"2018-12-06T06:10:38Z","updated_at":"2018-12-10T08:37:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"576f1b888c7369b25a05f95c6e664bd67c2000f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesg-foundation/core/pulls/623/commits","review_comments_url":"https://api.github.com/repos/mesg-foundation/core/pulls/623/comments","review_comment_url":"https://api.github.com/repos/mesg-foundation/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesg-foundation/core/issues/623/comments","statuses_url":"https://api.github.com/repos/mesg-foundation/core/statuses/296877bed6c24d56f47a6c706704f3901d81f68e","head":{"label":"mesg-foundation:wip/unique-alias","ref":"wip/unique-alias","sha":"296877bed6c24d56f47a6c706704f3901d81f68e","user":{"login":"mesg-foundation","id":34158802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTU4ODAy","avatar_url":"https://avatars1.githubusercontent.com/u/34158802?v=4","gravatar_id":"","url":"https://api.github.com/users/mesg-foundation","html_url":"https://github.com/mesg-foundation","followers_url":"https://api.github.com/users/mesg-foundation/followers","following_url":"https://api.github.com/users/mesg-foundation/following{/other_user}","gists_url":"https://api.github.com/users/mesg-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/mesg-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesg-foundation/subscriptions","organizations_url":"https://api.github.com/users/mesg-foundation/orgs","repos_url":"https://api.github.com/users/mesg-foundation/repos","events_url":"https://api.github.com/users/mesg-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/mesg-foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":121732267,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3MzIyNjc=","name":"core","full_name":"mesg-foundation/core","private":false,"owner":{"login":"mesg-foundation","id":34158802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTU4ODAy","avatar_url":"https://avatars1.githubusercontent.com/u/34158802?v=4","gravatar_id":"","url":"https://api.github.com/users/mesg-foundation","html_url":"https://github.com/mesg-foundation","followers_url":"https://api.github.com/users/mesg-foundation/followers","following_url":"https://api.github.com/users/mesg-foundation/following{/other_user}","gists_url":"https://api.github.com/users/mesg-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/mesg-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesg-foundation/subscriptions","organizations_url":"https://api.github.com/users/mesg-foundation/orgs","repos_url":"https://api.github.com/users/mesg-foundation/repos","events_url":"https://api.github.com/users/mesg-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/mesg-foundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesg-foundation/core","description":"MESG is an open-source decentralized infrastructure which makes all technologies, including blockchains, interoperable. It’s a building platform for developers.","fork":false,"url":"https://api.github.com/repos/mesg-foundation/core","forks_url":"https://api.github.com/repos/mesg-foundation/core/forks","keys_url":"https://api.github.com/repos/mesg-foundation/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesg-foundation/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesg-foundation/core/teams","hooks_url":"https://api.github.com/repos/mesg-foundation/core/hooks","issue_events_url":"https://api.github.com/repos/mesg-foundation/core/issues/events{/number}","events_url":"https://api.github.com/repos/mesg-foundation/core/events","assignees_url":"https://api.github.com/repos/mesg-foundation/core/assignees{/user}","branches_url":"https://api.github.com/repos/mesg-foundation/core/branches{/branch}","tags_url":"https://api.github.com/repos/mesg-foundation/core/tags","blobs_url":"https://api.github.com/repos/mesg-foundation/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesg-foundation/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesg-foundation/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesg-foundation/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesg-foundation/core/statuses/{sha}","languages_url":"https://api.github.com/repos/mesg-foundation/core/languages","stargazers_url":"https://api.github.com/repos/mesg-foundation/core/stargazers","contributors_url":"https://api.github.com/repos/mesg-foundation/core/contributors","subscribers_url":"https://api.github.com/repos/mesg-foundation/core/subscribers","subscription_url":"https://api.github.com/repos/mesg-foundation/core/subscription","commits_url":"https://api.github.com/repos/mesg-foundation/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesg-foundation/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesg-foundation/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesg-foundation/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesg-foundation/core/contents/{+path}","compare_url":"https://api.github.com/repos/mesg-foundation/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesg-foundation/core/merges","archive_url":"https://api.github.com/repos/mesg-foundation/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesg-foundation/core/downloads","issues_url":"https://api.github.com/repos/mesg-foundation/core/issues{/number}","pulls_url":"https://api.github.com/repos/mesg-foundation/core/pulls{/number}","milestones_url":"https://api.github.com/repos/mesg-foundation/core/milestones{/number}","notifications_url":"https://api.github.com/repos/mesg-foundation/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesg-foundation/core/labels{/name}","releases_url":"https://api.github.com/repos/mesg-foundation/core/releases{/id}","deployments_url":"https://api.github.com/repos/mesg-foundation/core/deployments","created_at":"2018-02-16T09:13:42Z","updated_at":"2018-12-10T06:37:19Z","pushed_at":"2018-12-10T08:28:08Z","git_url":"git://github.com/mesg-foundation/core.git","ssh_url":"git@github.com:mesg-foundation/core.git","clone_url":"https://github.com/mesg-foundation/core.git","svn_url":"https://github.com/mesg-foundation/core","homepage":"https://mesg.com/","size":22692,"stargazers_count":44,"watchers_count":44,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":64,"watchers":44,"default_branch":"dev"}},"base":{"label":"mesg-foundation:dev","ref":"dev","sha":"512ee8ada670e73e9ea3c2deff504cc642e20496","user":{"login":"mesg-foundation","id":34158802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTU4ODAy","avatar_url":"https://avatars1.githubusercontent.com/u/34158802?v=4","gravatar_id":"","url":"https://api.github.com/users/mesg-foundation","html_url":"https://github.com/mesg-foundation","followers_url":"https://api.github.com/users/mesg-foundation/followers","following_url":"https://api.github.com/users/mesg-foundation/following{/other_user}","gists_url":"https://api.github.com/users/mesg-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/mesg-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesg-foundation/subscriptions","organizations_url":"https://api.github.com/users/mesg-foundation/orgs","repos_url":"https://api.github.com/users/mesg-foundation/repos","events_url":"https://api.github.com/users/mesg-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/mesg-foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":121732267,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3MzIyNjc=","name":"core","full_name":"mesg-foundation/core","private":false,"owner":{"login":"mesg-foundation","id":34158802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTU4ODAy","avatar_url":"https://avatars1.githubusercontent.com/u/34158802?v=4","gravatar_id":"","url":"https://api.github.com/users/mesg-foundation","html_url":"https://github.com/mesg-foundation","followers_url":"https://api.github.com/users/mesg-foundation/followers","following_url":"https://api.github.com/users/mesg-foundation/following{/other_user}","gists_url":"https://api.github.com/users/mesg-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/mesg-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesg-foundation/subscriptions","organizations_url":"https://api.github.com/users/mesg-foundation/orgs","repos_url":"https://api.github.com/users/mesg-foundation/repos","events_url":"https://api.github.com/users/mesg-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/mesg-foundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mesg-foundation/core","description":"MESG is an open-source decentralized infrastructure which makes all technologies, including blockchains, interoperable. It’s a building platform for developers.","fork":false,"url":"https://api.github.com/repos/mesg-foundation/core","forks_url":"https://api.github.com/repos/mesg-foundation/core/forks","keys_url":"https://api.github.com/repos/mesg-foundation/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesg-foundation/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesg-foundation/core/teams","hooks_url":"https://api.github.com/repos/mesg-foundation/core/hooks","issue_events_url":"https://api.github.com/repos/mesg-foundation/core/issues/events{/number}","events_url":"https://api.github.com/repos/mesg-foundation/core/events","assignees_url":"https://api.github.com/repos/mesg-foundation/core/assignees{/user}","branches_url":"https://api.github.com/repos/mesg-foundation/core/branches{/branch}","tags_url":"https://api.github.com/repos/mesg-foundation/core/tags","blobs_url":"https://api.github.com/repos/mesg-foundation/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesg-foundation/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesg-foundation/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesg-foundation/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesg-foundation/core/statuses/{sha}","languages_url":"https://api.github.com/repos/mesg-foundation/core/languages","stargazers_url":"https://api.github.com/repos/mesg-foundation/core/stargazers","contributors_url":"https://api.github.com/repos/mesg-foundation/core/contributors","subscribers_url":"https://api.github.com/repos/mesg-foundation/core/subscribers","subscription_url":"https://api.github.com/repos/mesg-foundation/core/subscription","commits_url":"https://api.github.com/repos/mesg-foundation/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesg-foundation/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesg-foundation/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesg-foundation/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesg-foundation/core/contents/{+path}","compare_url":"https://api.github.com/repos/mesg-foundation/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesg-foundation/core/merges","archive_url":"https://api.github.com/repos/mesg-foundation/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesg-foundation/core/downloads","issues_url":"https://api.github.com/repos/mesg-foundation/core/issues{/number}","pulls_url":"https://api.github.com/repos/mesg-foundation/core/pulls{/number}","milestones_url":"https://api.github.com/repos/mesg-foundation/core/milestones{/number}","notifications_url":"https://api.github.com/repos/mesg-foundation/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesg-foundation/core/labels{/name}","releases_url":"https://api.github.com/repos/mesg-foundation/core/releases{/id}","deployments_url":"https://api.github.com/repos/mesg-foundation/core/deployments","created_at":"2018-02-16T09:13:42Z","updated_at":"2018-12-10T06:37:19Z","pushed_at":"2018-12-10T08:28:08Z","git_url":"git://github.com/mesg-foundation/core.git","ssh_url":"git@github.com:mesg-foundation/core.git","clone_url":"https://github.com/mesg-foundation/core.git","svn_url":"https://github.com/mesg-foundation/core","homepage":"https://mesg.com/","size":22692,"stargazers_count":44,"watchers_count":44,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":64,"watchers":44,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/623"},"html":{"href":"https://github.com/mesg-foundation/core/pull/623"},"issue":{"href":"https://api.github.com/repos/mesg-foundation/core/issues/623"},"comments":{"href":"https://api.github.com/repos/mesg-foundation/core/issues/623/comments"},"review_comments":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/623/comments"},"review_comment":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesg-foundation/core/pulls/623/commits"},"statuses":{"href":"https://api.github.com/repos/mesg-foundation/core/statuses/296877bed6c24d56f47a6c706704f3901d81f68e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ilgooz"}}