{"action":"created","comment":{"url":"https://api.github.com/repos/ndmitchell/hlint/pulls/comments/175795776","pull_request_review_id":105383955,"id":175795776,"diff_hunk":"@@ -379,6 +379,8 @@\n     - warn: {lhs: mapM_ f (map g x), rhs: mapM_ (f . g) x}\n     - warn: {lhs: mapM id, rhs: sequence}\n     - warn: {lhs: mapM_ id, rhs: sequence_}\n+    - hint: {lhs: \"sequence [a]\", rhs: \"(:[]) <$> a\"}","path":"data/hlint.yaml","position":4,"original_position":4,"commit_id":"e62b8178dc763225fe57595d310d5145bff213d7","original_commit_id":"e62b8178dc763225fe57595d310d5145bff213d7","user":{"login":"yairchu","id":97606,"avatar_url":"https://avatars2.githubusercontent.com/u/97606?v=4","gravatar_id":"","url":"https://api.github.com/users/yairchu","html_url":"https://github.com/yairchu","followers_url":"https://api.github.com/users/yairchu/followers","following_url":"https://api.github.com/users/yairchu/following{/other_user}","gists_url":"https://api.github.com/users/yairchu/gists{/gist_id}","starred_url":"https://api.github.com/users/yairchu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yairchu/subscriptions","organizations_url":"https://api.github.com/users/yairchu/orgs","repos_url":"https://api.github.com/users/yairchu/repos","events_url":"https://api.github.com/users/yairchu/events{/privacy}","received_events_url":"https://api.github.com/users/yairchu/received_events","type":"User","site_admin":false},"body":"It's true that it's noisy syntacticly, but it is conceptually simpler.\r\n\r\nImagine a case where someone had `mconcat <$> sequence [a, b]` and later edited it to `mconcat <$> sequence [a]`. After seeing the suggestion they may notice it should actually be just `a` now.","created_at":"2018-03-20T14:53:11Z","updated_at":"2018-03-20T14:53:11Z","html_url":"https://github.com/ndmitchell/hlint/pull/455#discussion_r175795776","pull_request_url":"https://api.github.com/repos/ndmitchell/hlint/pulls/455","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ndmitchell/hlint/pulls/comments/175795776"},"html":{"href":"https://github.com/ndmitchell/hlint/pull/455#discussion_r175795776"},"pull_request":{"href":"https://api.github.com/repos/ndmitchell/hlint/pulls/455"}},"in_reply_to_id":175680976},"pull_request":{"url":"https://api.github.com/repos/ndmitchell/hlint/pulls/455","id":174728811,"html_url":"https://github.com/ndmitchell/hlint/pull/455","diff_url":"https://github.com/ndmitchell/hlint/pull/455.diff","patch_url":"https://github.com/ndmitchell/hlint/pull/455.patch","issue_url":"https://api.github.com/repos/ndmitchell/hlint/issues/455","number":455,"state":"open","locked":false,"title":"add some hints for odd uses of sequence","user":{"login":"yairchu","id":97606,"avatar_url":"https://avatars2.githubusercontent.com/u/97606?v=4","gravatar_id":"","url":"https://api.github.com/users/yairchu","html_url":"https://github.com/yairchu","followers_url":"https://api.github.com/users/yairchu/followers","following_url":"https://api.github.com/users/yairchu/following{/other_user}","gists_url":"https://api.github.com/users/yairchu/gists{/gist_id}","starred_url":"https://api.github.com/users/yairchu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yairchu/subscriptions","organizations_url":"https://api.github.com/users/yairchu/orgs","repos_url":"https://api.github.com/users/yairchu/repos","events_url":"https://api.github.com/users/yairchu/events{/privacy}","received_events_url":"https://api.github.com/users/yairchu/received_events","type":"User","site_admin":false},"body":"these situations occur when a list is changed to have one element, such as here:\r\nhttps://github.com/lamdu/lamdu/commit/27d87a6aa7569fa55607176e56127606024987c6#diff-ecf05a9fd506bf563383f04e1652a41aL258","created_at":"2018-03-13T17:09:23Z","updated_at":"2018-03-20T14:53:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6986857d38afd46d545b423eb34606116e10071a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ndmitchell/hlint/pulls/455/commits","review_comments_url":"https://api.github.com/repos/ndmitchell/hlint/pulls/455/comments","review_comment_url":"https://api.github.com/repos/ndmitchell/hlint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ndmitchell/hlint/issues/455/comments","statuses_url":"https://api.github.com/repos/ndmitchell/hlint/statuses/e62b8178dc763225fe57595d310d5145bff213d7","head":{"label":"yairchu:patch-1","ref":"patch-1","sha":"e62b8178dc763225fe57595d310d5145bff213d7","user":{"login":"yairchu","id":97606,"avatar_url":"https://avatars2.githubusercontent.com/u/97606?v=4","gravatar_id":"","url":"https://api.github.com/users/yairchu","html_url":"https://github.com/yairchu","followers_url":"https://api.github.com/users/yairchu/followers","following_url":"https://api.github.com/users/yairchu/following{/other_user}","gists_url":"https://api.github.com/users/yairchu/gists{/gist_id}","starred_url":"https://api.github.com/users/yairchu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yairchu/subscriptions","organizations_url":"https://api.github.com/users/yairchu/orgs","repos_url":"https://api.github.com/users/yairchu/repos","events_url":"https://api.github.com/users/yairchu/events{/privacy}","received_events_url":"https://api.github.com/users/yairchu/received_events","type":"User","site_admin":false},"repo":{"id":119397838,"name":"hlint","full_name":"yairchu/hlint","owner":{"login":"yairchu","id":97606,"avatar_url":"https://avatars2.githubusercontent.com/u/97606?v=4","gravatar_id":"","url":"https://api.github.com/users/yairchu","html_url":"https://github.com/yairchu","followers_url":"https://api.github.com/users/yairchu/followers","following_url":"https://api.github.com/users/yairchu/following{/other_user}","gists_url":"https://api.github.com/users/yairchu/gists{/gist_id}","starred_url":"https://api.github.com/users/yairchu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yairchu/subscriptions","organizations_url":"https://api.github.com/users/yairchu/orgs","repos_url":"https://api.github.com/users/yairchu/repos","events_url":"https://api.github.com/users/yairchu/events{/privacy}","received_events_url":"https://api.github.com/users/yairchu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yairchu/hlint","description":"Haskell source code suggestions","fork":true,"url":"https://api.github.com/repos/yairchu/hlint","forks_url":"https://api.github.com/repos/yairchu/hlint/forks","keys_url":"https://api.github.com/repos/yairchu/hlint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yairchu/hlint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yairchu/hlint/teams","hooks_url":"https://api.github.com/repos/yairchu/hlint/hooks","issue_events_url":"https://api.github.com/repos/yairchu/hlint/issues/events{/number}","events_url":"https://api.github.com/repos/yairchu/hlint/events","assignees_url":"https://api.github.com/repos/yairchu/hlint/assignees{/user}","branches_url":"https://api.github.com/repos/yairchu/hlint/branches{/branch}","tags_url":"https://api.github.com/repos/yairchu/hlint/tags","blobs_url":"https://api.github.com/repos/yairchu/hlint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yairchu/hlint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yairchu/hlint/git/refs{/sha}","trees_url":"https://api.github.com/repos/yairchu/hlint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yairchu/hlint/statuses/{sha}","languages_url":"https://api.github.com/repos/yairchu/hlint/languages","stargazers_url":"https://api.github.com/repos/yairchu/hlint/stargazers","contributors_url":"https://api.github.com/repos/yairchu/hlint/contributors","subscribers_url":"https://api.github.com/repos/yairchu/hlint/subscribers","subscription_url":"https://api.github.com/repos/yairchu/hlint/subscription","commits_url":"https://api.github.com/repos/yairchu/hlint/commits{/sha}","git_commits_url":"https://api.github.com/repos/yairchu/hlint/git/commits{/sha}","comments_url":"https://api.github.com/repos/yairchu/hlint/comments{/number}","issue_comment_url":"https://api.github.com/repos/yairchu/hlint/issues/comments{/number}","contents_url":"https://api.github.com/repos/yairchu/hlint/contents/{+path}","compare_url":"https://api.github.com/repos/yairchu/hlint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yairchu/hlint/merges","archive_url":"https://api.github.com/repos/yairchu/hlint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yairchu/hlint/downloads","issues_url":"https://api.github.com/repos/yairchu/hlint/issues{/number}","pulls_url":"https://api.github.com/repos/yairchu/hlint/pulls{/number}","milestones_url":"https://api.github.com/repos/yairchu/hlint/milestones{/number}","notifications_url":"https://api.github.com/repos/yairchu/hlint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yairchu/hlint/labels{/name}","releases_url":"https://api.github.com/repos/yairchu/hlint/releases{/id}","deployments_url":"https://api.github.com/repos/yairchu/hlint/deployments","created_at":"2018-01-29T15:04:19Z","updated_at":"2018-01-29T15:04:21Z","pushed_at":"2018-03-13T17:08:07Z","git_url":"git://github.com/yairchu/hlint.git","ssh_url":"git@github.com:yairchu/hlint.git","clone_url":"https://github.com/yairchu/hlint.git","svn_url":"https://github.com/yairchu/hlint","homepage":null,"size":2991,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ndmitchell:master","ref":"master","sha":"3b52053bf54e2fdea5f88fab337a7ef59d9ef9ee","user":{"login":"ndmitchell","id":1651197,"avatar_url":"https://avatars1.githubusercontent.com/u/1651197?v=4","gravatar_id":"","url":"https://api.github.com/users/ndmitchell","html_url":"https://github.com/ndmitchell","followers_url":"https://api.github.com/users/ndmitchell/followers","following_url":"https://api.github.com/users/ndmitchell/following{/other_user}","gists_url":"https://api.github.com/users/ndmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/ndmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndmitchell/subscriptions","organizations_url":"https://api.github.com/users/ndmitchell/orgs","repos_url":"https://api.github.com/users/ndmitchell/repos","events_url":"https://api.github.com/users/ndmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/ndmitchell/received_events","type":"User","site_admin":false},"repo":{"id":11603668,"name":"hlint","full_name":"ndmitchell/hlint","owner":{"login":"ndmitchell","id":1651197,"avatar_url":"https://avatars1.githubusercontent.com/u/1651197?v=4","gravatar_id":"","url":"https://api.github.com/users/ndmitchell","html_url":"https://github.com/ndmitchell","followers_url":"https://api.github.com/users/ndmitchell/followers","following_url":"https://api.github.com/users/ndmitchell/following{/other_user}","gists_url":"https://api.github.com/users/ndmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/ndmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndmitchell/subscriptions","organizations_url":"https://api.github.com/users/ndmitchell/orgs","repos_url":"https://api.github.com/users/ndmitchell/repos","events_url":"https://api.github.com/users/ndmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/ndmitchell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ndmitchell/hlint","description":"Haskell source code suggestions","fork":false,"url":"https://api.github.com/repos/ndmitchell/hlint","forks_url":"https://api.github.com/repos/ndmitchell/hlint/forks","keys_url":"https://api.github.com/repos/ndmitchell/hlint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndmitchell/hlint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndmitchell/hlint/teams","hooks_url":"https://api.github.com/repos/ndmitchell/hlint/hooks","issue_events_url":"https://api.github.com/repos/ndmitchell/hlint/issues/events{/number}","events_url":"https://api.github.com/repos/ndmitchell/hlint/events","assignees_url":"https://api.github.com/repos/ndmitchell/hlint/assignees{/user}","branches_url":"https://api.github.com/repos/ndmitchell/hlint/branches{/branch}","tags_url":"https://api.github.com/repos/ndmitchell/hlint/tags","blobs_url":"https://api.github.com/repos/ndmitchell/hlint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndmitchell/hlint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndmitchell/hlint/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndmitchell/hlint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndmitchell/hlint/statuses/{sha}","languages_url":"https://api.github.com/repos/ndmitchell/hlint/languages","stargazers_url":"https://api.github.com/repos/ndmitchell/hlint/stargazers","contributors_url":"https://api.github.com/repos/ndmitchell/hlint/contributors","subscribers_url":"https://api.github.com/repos/ndmitchell/hlint/subscribers","subscription_url":"https://api.github.com/repos/ndmitchell/hlint/subscription","commits_url":"https://api.github.com/repos/ndmitchell/hlint/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndmitchell/hlint/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndmitchell/hlint/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndmitchell/hlint/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndmitchell/hlint/contents/{+path}","compare_url":"https://api.github.com/repos/ndmitchell/hlint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndmitchell/hlint/merges","archive_url":"https://api.github.com/repos/ndmitchell/hlint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndmitchell/hlint/downloads","issues_url":"https://api.github.com/repos/ndmitchell/hlint/issues{/number}","pulls_url":"https://api.github.com/repos/ndmitchell/hlint/pulls{/number}","milestones_url":"https://api.github.com/repos/ndmitchell/hlint/milestones{/number}","notifications_url":"https://api.github.com/repos/ndmitchell/hlint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndmitchell/hlint/labels{/name}","releases_url":"https://api.github.com/repos/ndmitchell/hlint/releases{/id}","deployments_url":"https://api.github.com/repos/ndmitchell/hlint/deployments","created_at":"2013-07-23T08:43:40Z","updated_at":"2018-03-20T09:27:31Z","pushed_at":"2018-03-19T17:31:27Z","git_url":"git://github.com/ndmitchell/hlint.git","ssh_url":"git@github.com:ndmitchell/hlint.git","clone_url":"https://github.com/ndmitchell/hlint.git","svn_url":"https://github.com/ndmitchell/hlint","homepage":null,"size":2992,"stargazers_count":606,"watchers_count":606,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":80,"open_issues":118,"watchers":606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ndmitchell/hlint/pulls/455"},"html":{"href":"https://github.com/ndmitchell/hlint/pull/455"},"issue":{"href":"https://api.github.com/repos/ndmitchell/hlint/issues/455"},"comments":{"href":"https://api.github.com/repos/ndmitchell/hlint/issues/455/comments"},"review_comments":{"href":"https://api.github.com/repos/ndmitchell/hlint/pulls/455/comments"},"review_comment":{"href":"https://api.github.com/repos/ndmitchell/hlint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ndmitchell/hlint/pulls/455/commits"},"statuses":{"href":"https://api.github.com/repos/ndmitchell/hlint/statuses/e62b8178dc763225fe57595d310d5145bff213d7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yairchu"}}