{"action":"closed","number":29132,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/29132","id":181744255,"html_url":"https://github.com/dotnet/corefx/pull/29132","diff_url":"https://github.com/dotnet/corefx/pull/29132.diff","patch_url":"https://github.com/dotnet/corefx/pull/29132.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/29132","number":29132,"state":"closed","locked":false,"title":"change sync timeout handling back to use actual sync timeouts","user":{"login":"geoffkizer","id":12518809,"avatar_url":"https://avatars2.githubusercontent.com/u/12518809?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffkizer","html_url":"https://github.com/geoffkizer","followers_url":"https://api.github.com/users/geoffkizer/followers","following_url":"https://api.github.com/users/geoffkizer/following{/other_user}","gists_url":"https://api.github.com/users/geoffkizer/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffkizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffkizer/subscriptions","organizations_url":"https://api.github.com/users/geoffkizer/orgs","repos_url":"https://api.github.com/users/geoffkizer/repos","events_url":"https://api.github.com/users/geoffkizer/events{/privacy}","received_events_url":"https://api.github.com/users/geoffkizer/received_events","type":"User","site_admin":false},"body":"Fixes #29040 \r\n\r\nWe made a change in 2.1 (#22588) to force sync operations with timeout to go through the sync-over-async path.  This caused a nontrivial perf hit.  \r\n\r\nThis change reverts (mostly) the previous change and fixes the original issue by checking explicitly for blocking mode and not retrying when a timeout is exceeded.\r\n\r\nAlso, remove timeout handling from accept and connect operations since it is never used.\r\n\r\n@stephentoub @dotnet/ncl ","created_at":"2018-04-16T03:19:51Z","updated_at":"2018-04-16T10:42:30Z","closed_at":"2018-04-16T10:42:30Z","merged_at":"2018-04-16T10:42:28Z","merge_commit_sha":"18cac5a386bdf7dba8585a78c047d77345379a71","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":497898539,"url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Net.Sockets","name":"area-System.Net.Sockets","color":"d4c5f9","default":false},{"id":205613977,"url":"https://api.github.com/repos/dotnet/corefx/labels/os-linux","name":"os-linux","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/12","html_url":"https://github.com/dotnet/corefx/milestone/12","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/12/labels","id":2323293,"number":12,"title":"2.1.0","description":".NET Core 2.1, next major release. See [official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) for details.","creator":{"login":"karelz","id":5776068,"avatar_url":"https://avatars2.githubusercontent.com/u/5776068?v=4","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":7043,"state":"open","created_at":"2017-02-15T02:14:11Z","updated_at":"2018-04-16T10:42:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/29132/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/29132/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/29132/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/37f840d42871eb1127dd2a466d5512406cc5cf0c","head":{"label":"geoffkizer:synctimeoutfix","ref":"synctimeoutfix","sha":"37f840d42871eb1127dd2a466d5512406cc5cf0c","user":{"login":"geoffkizer","id":12518809,"avatar_url":"https://avatars2.githubusercontent.com/u/12518809?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffkizer","html_url":"https://github.com/geoffkizer","followers_url":"https://api.github.com/users/geoffkizer/followers","following_url":"https://api.github.com/users/geoffkizer/following{/other_user}","gists_url":"https://api.github.com/users/geoffkizer/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffkizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffkizer/subscriptions","organizations_url":"https://api.github.com/users/geoffkizer/orgs","repos_url":"https://api.github.com/users/geoffkizer/repos","events_url":"https://api.github.com/users/geoffkizer/events{/privacy}","received_events_url":"https://api.github.com/users/geoffkizer/received_events","type":"User","site_admin":false},"repo":{"id":50082194,"name":"corefx","full_name":"geoffkizer/corefx","owner":{"login":"geoffkizer","id":12518809,"avatar_url":"https://avatars2.githubusercontent.com/u/12518809?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffkizer","html_url":"https://github.com/geoffkizer","followers_url":"https://api.github.com/users/geoffkizer/followers","following_url":"https://api.github.com/users/geoffkizer/following{/other_user}","gists_url":"https://api.github.com/users/geoffkizer/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffkizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffkizer/subscriptions","organizations_url":"https://api.github.com/users/geoffkizer/orgs","repos_url":"https://api.github.com/users/geoffkizer/repos","events_url":"https://api.github.com/users/geoffkizer/events{/privacy}","received_events_url":"https://api.github.com/users/geoffkizer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geoffkizer/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/geoffkizer/corefx","forks_url":"https://api.github.com/repos/geoffkizer/corefx/forks","keys_url":"https://api.github.com/repos/geoffkizer/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoffkizer/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoffkizer/corefx/teams","hooks_url":"https://api.github.com/repos/geoffkizer/corefx/hooks","issue_events_url":"https://api.github.com/repos/geoffkizer/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/geoffkizer/corefx/events","assignees_url":"https://api.github.com/repos/geoffkizer/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/geoffkizer/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/geoffkizer/corefx/tags","blobs_url":"https://api.github.com/repos/geoffkizer/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoffkizer/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoffkizer/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoffkizer/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoffkizer/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/geoffkizer/corefx/languages","stargazers_url":"https://api.github.com/repos/geoffkizer/corefx/stargazers","contributors_url":"https://api.github.com/repos/geoffkizer/corefx/contributors","subscribers_url":"https://api.github.com/repos/geoffkizer/corefx/subscribers","subscription_url":"https://api.github.com/repos/geoffkizer/corefx/subscription","commits_url":"https://api.github.com/repos/geoffkizer/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoffkizer/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoffkizer/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoffkizer/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoffkizer/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/geoffkizer/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoffkizer/corefx/merges","archive_url":"https://api.github.com/repos/geoffkizer/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoffkizer/corefx/downloads","issues_url":"https://api.github.com/repos/geoffkizer/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/geoffkizer/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/geoffkizer/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/geoffkizer/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoffkizer/corefx/labels{/name}","releases_url":"https://api.github.com/repos/geoffkizer/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/geoffkizer/corefx/deployments","created_at":"2016-01-21T04:31:55Z","updated_at":"2018-04-16T01:53:56Z","pushed_at":"2018-04-16T04:16:56Z","git_url":"git://github.com/geoffkizer/corefx.git","ssh_url":"git@github.com:geoffkizer/corefx.git","clone_url":"https://github.com/geoffkizer/corefx.git","svn_url":"https://github.com/geoffkizer/corefx","homepage":"http://dotnet.github.io/","size":171807,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"3f97e480eb256a011f5035de72dbf21c6e53f523","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-04-16T08:55:55Z","pushed_at":"2018-04-16T10:42:28Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":177116,"stargazers_count":13760,"watchers_count":13760,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3945,"mirror_url":null,"archived":false,"open_issues_count":2243,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3945,"open_issues":2243,"watchers":13760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/29132"},"html":{"href":"https://github.com/dotnet/corefx/pull/29132"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/29132"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/29132/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/29132/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/29132/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/37f840d42871eb1127dd2a466d5512406cc5cf0c"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"comments":5,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":39,"deletions":38,"changed_files":3}}
{"actor":{"display_login":"stephentoub"}}