{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/pulls/4","id":225484411,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDg0NDEx","html_url":"https://github.com/omn0mn0m/Dungeon-Crawler/pull/4","diff_url":"https://github.com/omn0mn0m/Dungeon-Crawler/pull/4.diff","patch_url":"https://github.com/omn0mn0m/Dungeon-Crawler/pull/4.patch","issue_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/issues/4","number":4,"state":"closed","locked":false,"title":"NamList initialisation fixes at Game initialisation & reducing total amount of dependencies","user":{"login":"Kiree","id":10907748,"node_id":"MDQ6VXNlcjEwOTA3NzQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10907748?v=4","gravatar_id":"","url":"https://api.github.com/users/Kiree","html_url":"https://github.com/Kiree","followers_url":"https://api.github.com/users/Kiree/followers","following_url":"https://api.github.com/users/Kiree/following{/other_user}","gists_url":"https://api.github.com/users/Kiree/gists{/gist_id}","starred_url":"https://api.github.com/users/Kiree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kiree/subscriptions","organizations_url":"https://api.github.com/users/Kiree/orgs","repos_url":"https://api.github.com/users/Kiree/repos","events_url":"https://api.github.com/users/Kiree/events{/privacy}","received_events_url":"https://api.github.com/users/Kiree/received_events","type":"User","site_admin":false},"body":"While writing unit tests for the code base, I found issues when initialising some of the classes without having initialised the Game.java class first. As a fix, I introduced changes to the NamReader.java.\r\n\r\nNamReader.java now sets the rootPath of the filesystem for itself, and the methods of it are called with filenames alone. This changes the runtime of Game.java in a way that allows you to initialize any .nam based class (such as the AttackList.java, ItemList.java and HostileList.java). In other words, you can now call the constructor of ie. Hero.java without having instantiated a new instance of Game.\r\n\r\nI also reduced the total amount of calls to a specific instance of a Game by introducing a TextPrinter class. For the time being TextPrinter merely contains the print method formerly included in Game.java. This allows one to call the print method without first having instantiated a new instance of Game.\r\n\r\nAs part of the process, I added a jUnit test file NamReader.java under \\test\\io\\github\\omn0mn0m\\util\\NamReaderTest.java. In the file I included four unit tests: one for each of the List types (Hostile, Attack, Item) and one for testing the reading of Player Classes.","created_at":"2018-10-24T17:16:02Z","updated_at":"2018-10-24T23:51:07Z","closed_at":"2018-10-24T23:51:07Z","merged_at":"2018-10-24T23:51:07Z","merge_commit_sha":"12831738e4b2fa90c5f96a11cd08232375bd189a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/pulls/4/commits","review_comments_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/pulls/4/comments","review_comment_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/issues/4/comments","statuses_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/statuses/14a35c3fbe3fdbe0476c63dd68fa806372e5c3da","head":{"label":"Kiree:list-class-fixes","ref":"list-class-fixes","sha":"14a35c3fbe3fdbe0476c63dd68fa806372e5c3da","user":{"login":"Kiree","id":10907748,"node_id":"MDQ6VXNlcjEwOTA3NzQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10907748?v=4","gravatar_id":"","url":"https://api.github.com/users/Kiree","html_url":"https://github.com/Kiree","followers_url":"https://api.github.com/users/Kiree/followers","following_url":"https://api.github.com/users/Kiree/following{/other_user}","gists_url":"https://api.github.com/users/Kiree/gists{/gist_id}","starred_url":"https://api.github.com/users/Kiree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kiree/subscriptions","organizations_url":"https://api.github.com/users/Kiree/orgs","repos_url":"https://api.github.com/users/Kiree/repos","events_url":"https://api.github.com/users/Kiree/events{/privacy}","received_events_url":"https://api.github.com/users/Kiree/received_events","type":"User","site_admin":false},"repo":{"id":149745468,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk3NDU0Njg=","name":"Dungeon-Crawler","full_name":"Kiree/Dungeon-Crawler","private":false,"owner":{"login":"Kiree","id":10907748,"node_id":"MDQ6VXNlcjEwOTA3NzQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10907748?v=4","gravatar_id":"","url":"https://api.github.com/users/Kiree","html_url":"https://github.com/Kiree","followers_url":"https://api.github.com/users/Kiree/followers","following_url":"https://api.github.com/users/Kiree/following{/other_user}","gists_url":"https://api.github.com/users/Kiree/gists{/gist_id}","starred_url":"https://api.github.com/users/Kiree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kiree/subscriptions","organizations_url":"https://api.github.com/users/Kiree/orgs","repos_url":"https://api.github.com/users/Kiree/repos","events_url":"https://api.github.com/users/Kiree/events{/privacy}","received_events_url":"https://api.github.com/users/Kiree/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Kiree/Dungeon-Crawler","description":"A text-based RPG written in Java. Currently it has only been tested on Windows and Android, and it requires a very specific path for its files.","fork":true,"url":"https://api.github.com/repos/Kiree/Dungeon-Crawler","forks_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/forks","keys_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/teams","hooks_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/hooks","issue_events_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/issues/events{/number}","events_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/events","assignees_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/assignees{/user}","branches_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/branches{/branch}","tags_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/tags","blobs_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/languages","stargazers_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/stargazers","contributors_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/contributors","subscribers_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/subscribers","subscription_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/subscription","commits_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/contents/{+path}","compare_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/merges","archive_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/downloads","issues_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/issues{/number}","pulls_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/labels{/name}","releases_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/releases{/id}","deployments_url":"https://api.github.com/repos/Kiree/Dungeon-Crawler/deployments","created_at":"2018-09-21T10:00:00Z","updated_at":"2018-09-21T10:00:02Z","pushed_at":"2018-10-24T17:02:54Z","git_url":"git://github.com/Kiree/Dungeon-Crawler.git","ssh_url":"git@github.com:Kiree/Dungeon-Crawler.git","clone_url":"https://github.com/Kiree/Dungeon-Crawler.git","svn_url":"https://github.com/Kiree/Dungeon-Crawler","homepage":"","size":638,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"omn0mn0m:master","ref":"master","sha":"456b45a931309269c7681b44e5d6f16ad047a1d9","user":{"login":"omn0mn0m","id":3728374,"node_id":"MDQ6VXNlcjM3MjgzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3728374?v=4","gravatar_id":"","url":"https://api.github.com/users/omn0mn0m","html_url":"https://github.com/omn0mn0m","followers_url":"https://api.github.com/users/omn0mn0m/followers","following_url":"https://api.github.com/users/omn0mn0m/following{/other_user}","gists_url":"https://api.github.com/users/omn0mn0m/gists{/gist_id}","starred_url":"https://api.github.com/users/omn0mn0m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omn0mn0m/subscriptions","organizations_url":"https://api.github.com/users/omn0mn0m/orgs","repos_url":"https://api.github.com/users/omn0mn0m/repos","events_url":"https://api.github.com/users/omn0mn0m/events{/privacy}","received_events_url":"https://api.github.com/users/omn0mn0m/received_events","type":"User","site_admin":false},"repo":{"id":16526922,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUyNjkyMg==","name":"Dungeon-Crawler","full_name":"omn0mn0m/Dungeon-Crawler","private":false,"owner":{"login":"omn0mn0m","id":3728374,"node_id":"MDQ6VXNlcjM3MjgzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3728374?v=4","gravatar_id":"","url":"https://api.github.com/users/omn0mn0m","html_url":"https://github.com/omn0mn0m","followers_url":"https://api.github.com/users/omn0mn0m/followers","following_url":"https://api.github.com/users/omn0mn0m/following{/other_user}","gists_url":"https://api.github.com/users/omn0mn0m/gists{/gist_id}","starred_url":"https://api.github.com/users/omn0mn0m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omn0mn0m/subscriptions","organizations_url":"https://api.github.com/users/omn0mn0m/orgs","repos_url":"https://api.github.com/users/omn0mn0m/repos","events_url":"https://api.github.com/users/omn0mn0m/events{/privacy}","received_events_url":"https://api.github.com/users/omn0mn0m/received_events","type":"User","site_admin":false},"html_url":"https://github.com/omn0mn0m/Dungeon-Crawler","description":"A text-based RPG written in Java. Currently it has only been tested on Windows and Android, and it requires a very specific path for its files.","fork":false,"url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler","forks_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/forks","keys_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/teams","hooks_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/hooks","issue_events_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/issues/events{/number}","events_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/events","assignees_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/assignees{/user}","branches_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/branches{/branch}","tags_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/tags","blobs_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/languages","stargazers_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/stargazers","contributors_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/contributors","subscribers_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/subscribers","subscription_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/subscription","commits_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/contents/{+path}","compare_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/merges","archive_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/downloads","issues_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/issues{/number}","pulls_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/labels{/name}","releases_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/releases{/id}","deployments_url":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/deployments","created_at":"2014-02-04T21:53:39Z","updated_at":"2018-09-11T19:03:00Z","pushed_at":"2018-10-24T23:51:07Z","git_url":"git://github.com/omn0mn0m/Dungeon-Crawler.git","ssh_url":"git@github.com:omn0mn0m/Dungeon-Crawler.git","clone_url":"https://github.com/omn0mn0m/Dungeon-Crawler.git","svn_url":"https://github.com/omn0mn0m/Dungeon-Crawler","homepage":"","size":631,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":0,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/pulls/4"},"html":{"href":"https://github.com/omn0mn0m/Dungeon-Crawler/pull/4"},"issue":{"href":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/issues/4"},"comments":{"href":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/omn0mn0m/Dungeon-Crawler/statuses/14a35c3fbe3fdbe0476c63dd68fa806372e5c3da"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"omn0mn0m","id":3728374,"node_id":"MDQ6VXNlcjM3MjgzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3728374?v=4","gravatar_id":"","url":"https://api.github.com/users/omn0mn0m","html_url":"https://github.com/omn0mn0m","followers_url":"https://api.github.com/users/omn0mn0m/followers","following_url":"https://api.github.com/users/omn0mn0m/following{/other_user}","gists_url":"https://api.github.com/users/omn0mn0m/gists{/gist_id}","starred_url":"https://api.github.com/users/omn0mn0m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omn0mn0m/subscriptions","organizations_url":"https://api.github.com/users/omn0mn0m/orgs","repos_url":"https://api.github.com/users/omn0mn0m/repos","events_url":"https://api.github.com/users/omn0mn0m/events{/privacy}","received_events_url":"https://api.github.com/users/omn0mn0m/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":382,"deletions":270,"changed_files":18}}
{"actor":{"display_login":"omn0mn0m"}}