{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/235785508","pull_request_review_id":177732900,"id":235785508,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc4NTUwOA==","diff_hunk":"@@ -0,0 +1,30 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package kafka.zk\n+\n+import org.apache.zookeeper.ZooKeeper\n+\n+/**\n+ * This class should only be used in ZkSecurityMigrator tool.\n+ * This class will be removed after we migrate ZkSecurityMigrator away from ZK's asynchronous API.\n+ * @param kafkaZkClient\n+ */\n+class ZkSecurityMigratorUtils(val kafkaZkClient: KafkaZkClient) {","path":"core/src/main/scala/kafka/zk/ZkSecurityMigratorUtils.scala","position":26,"original_position":26,"commit_id":"dea3191337d97133fd6560721a450a1774ca263c","original_commit_id":"0fa9ad3ab1229e946bc58e6a1fc5587494c74fb1","user":{"login":"omkreddy","id":8134545,"node_id":"MDQ6VXNlcjgxMzQ1NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8134545?v=4","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"body":"This class is accessed in other package","created_at":"2018-11-22T16:50:15Z","updated_at":"2018-11-22T16:50:15Z","html_url":"https://github.com/apache/kafka/pull/5480#discussion_r235785508","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/5480","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/235785508"},"html":{"href":"https://github.com/apache/kafka/pull/5480#discussion_r235785508"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/5480"}},"in_reply_to_id":234740306},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/5480","id":207084902,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDg0OTAy","html_url":"https://github.com/apache/kafka/pull/5480","diff_url":"https://github.com/apache/kafka/pull/5480.diff","patch_url":"https://github.com/apache/kafka/pull/5480.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/5480","number":5480,"state":"open","locked":false,"title":"KAFKA-7259: Remove deprecated ZKUtils usage from ZkSecurityMigrator","user":{"login":"omkreddy","id":8134545,"node_id":"MDQ6VXNlcjgxMzQ1NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8134545?v=4","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"body":"- Remove ZKUtils usage from various tests\r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2018-08-08T17:40:54Z","updated_at":"2018-11-22T16:50:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6f3faf2a06687bed716434a1b3d158604d3a790","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/5480/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/5480/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/5480/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/dea3191337d97133fd6560721a450a1774ca263c","head":{"label":"omkreddy:zkutils","ref":"zkutils","sha":"dea3191337d97133fd6560721a450a1774ca263c","user":{"login":"omkreddy","id":8134545,"node_id":"MDQ6VXNlcjgxMzQ1NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8134545?v=4","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"repo":{"id":51066257,"node_id":"MDEwOlJlcG9zaXRvcnk1MTA2NjI1Nw==","name":"kafka","full_name":"omkreddy/kafka","private":false,"owner":{"login":"omkreddy","id":8134545,"node_id":"MDQ6VXNlcjgxMzQ1NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8134545?v=4","gravatar_id":"","url":"https://api.github.com/users/omkreddy","html_url":"https://github.com/omkreddy","followers_url":"https://api.github.com/users/omkreddy/followers","following_url":"https://api.github.com/users/omkreddy/following{/other_user}","gists_url":"https://api.github.com/users/omkreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/omkreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkreddy/subscriptions","organizations_url":"https://api.github.com/users/omkreddy/orgs","repos_url":"https://api.github.com/users/omkreddy/repos","events_url":"https://api.github.com/users/omkreddy/events{/privacy}","received_events_url":"https://api.github.com/users/omkreddy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/omkreddy/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/omkreddy/kafka","forks_url":"https://api.github.com/repos/omkreddy/kafka/forks","keys_url":"https://api.github.com/repos/omkreddy/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omkreddy/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omkreddy/kafka/teams","hooks_url":"https://api.github.com/repos/omkreddy/kafka/hooks","issue_events_url":"https://api.github.com/repos/omkreddy/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/omkreddy/kafka/events","assignees_url":"https://api.github.com/repos/omkreddy/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/omkreddy/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/omkreddy/kafka/tags","blobs_url":"https://api.github.com/repos/omkreddy/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omkreddy/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omkreddy/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/omkreddy/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omkreddy/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/omkreddy/kafka/languages","stargazers_url":"https://api.github.com/repos/omkreddy/kafka/stargazers","contributors_url":"https://api.github.com/repos/omkreddy/kafka/contributors","subscribers_url":"https://api.github.com/repos/omkreddy/kafka/subscribers","subscription_url":"https://api.github.com/repos/omkreddy/kafka/subscription","commits_url":"https://api.github.com/repos/omkreddy/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/omkreddy/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/omkreddy/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/omkreddy/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/omkreddy/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/omkreddy/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omkreddy/kafka/merges","archive_url":"https://api.github.com/repos/omkreddy/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omkreddy/kafka/downloads","issues_url":"https://api.github.com/repos/omkreddy/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/omkreddy/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/omkreddy/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/omkreddy/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omkreddy/kafka/labels{/name}","releases_url":"https://api.github.com/repos/omkreddy/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/omkreddy/kafka/deployments","created_at":"2016-02-04T09:42:20Z","updated_at":"2018-10-28T16:32:16Z","pushed_at":"2018-11-22T16:48:11Z","git_url":"git://github.com/omkreddy/kafka.git","ssh_url":"git@github.com:omkreddy/kafka.git","clone_url":"https://github.com/omkreddy/kafka.git","svn_url":"https://github.com/omkreddy/kafka","homepage":null,"size":71372,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"ad26914de65e2db244fbe36a2a5fd03de87dfb79","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"node_id":"MDEwOlJlcG9zaXRvcnkyMjExMjQz","name":"kafka","full_name":"apache/kafka","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-11-22T14:58:32Z","pushed_at":"2018-11-22T16:48:15Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":76504,"stargazers_count":10229,"watchers_count":10229,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5722,"mirror_url":null,"archived":false,"open_issues_count":532,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5722,"open_issues":532,"watchers":10229,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/5480"},"html":{"href":"https://github.com/apache/kafka/pull/5480"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/5480"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/5480/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/5480/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/5480/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/dea3191337d97133fd6560721a450a1774ca263c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"omkreddy"}}