{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/11998","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/11998/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/11998/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/11998/events","html_url":"https://github.com/WordPress/gutenberg/issues/11998","id":381740508,"node_id":"MDU6SXNzdWUzODE3NDA1MDg=","number":11998,"title":"Button color settings overridden in Twenty-* themes.","user":{"login":"m-e-h","id":3585901,"node_id":"MDQ6VXNlcjM1ODU5MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/3585901?v=4","gravatar_id":"","url":"https://api.github.com/users/m-e-h","html_url":"https://github.com/m-e-h","followers_url":"https://api.github.com/users/m-e-h/followers","following_url":"https://api.github.com/users/m-e-h/following{/other_user}","gists_url":"https://api.github.com/users/m-e-h/gists{/gist_id}","starred_url":"https://api.github.com/users/m-e-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-e-h/subscriptions","organizations_url":"https://api.github.com/users/m-e-h/orgs","repos_url":"https://api.github.com/users/m-e-h/repos","events_url":"https://api.github.com/users/m-e-h/events{/privacy}","received_events_url":"https://api.github.com/users/m-e-h/received_events","type":"User","site_admin":false},"labels":[{"id":816933178,"node_id":"MDU6TGFiZWw4MTY5MzMxNzg=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Needs%20Testing","name":"Needs Testing","color":"67dff7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-16T20:01:28Z","updated_at":"2018-11-20T15:52:15Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Describe the bug**\r\nAs mentioned in https://github.com/WordPress/gutenberg/issues/11779#issuecomment-438753222\r\nThe Twenty-* themes are overriding the core button styles such as `.wp-block-button__link:not(.has-background)`. But they're doing it with an equally specific selector that also overrides the \"utility\" class applied for the color `.has-pale-pink-background-color`.\r\n\r\nBy relying on `:not()` to allow for color overrides, we're assuming everyone else will, as well.\r\nUsing `:not()` to style a button wouldn't be my first instinct.\r\nAlso discussed here https://github.com/WordPress/gutenberg/issues/11677\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Add a button in Twenty Seventeen or Twenty Sixteen from the WP 5.0 Branch.\r\n2. Color the background and text color of the button.\r\n3. Check it out on the front end.\r\n\r\n**Additional context**\r\n- Gutenberg v4.4\r\n"},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/440322712","html_url":"https://github.com/WordPress/gutenberg/issues/11998#issuecomment-440322712","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/11998","id":440322712,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDMyMjcxMg==","user":{"login":"m-e-h","id":3585901,"node_id":"MDQ6VXNlcjM1ODU5MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/3585901?v=4","gravatar_id":"","url":"https://api.github.com/users/m-e-h","html_url":"https://github.com/m-e-h","followers_url":"https://api.github.com/users/m-e-h/followers","following_url":"https://api.github.com/users/m-e-h/following{/other_user}","gists_url":"https://api.github.com/users/m-e-h/gists{/gist_id}","starred_url":"https://api.github.com/users/m-e-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-e-h/subscriptions","organizations_url":"https://api.github.com/users/m-e-h/orgs","repos_url":"https://api.github.com/users/m-e-h/repos","events_url":"https://api.github.com/users/m-e-h/events{/privacy}","received_events_url":"https://api.github.com/users/m-e-h/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T15:52:14Z","updated_at":"2018-11-20T15:52:14Z","author_association":"CONTRIBUTOR","body":"This can probably be closed with the fix in https://github.com/WordPress/gutenberg/pull/12005\r\nBut the default themes are still going to have to adjust their CSS to allow for the Button Color settings to take affect. "}}
{"actor":{"display_login":"m-e-h"}}