{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/184851473","pull_request_review_id":116134368,"id":184851473,"diff_hunk":"@@ -76,6 +76,11 @@ def ontap_sf_host_argument_spec():\n         hostname=dict(required=True, type='str'),\n         username=dict(required=True, type='str', aliases=['user']),\n         password=dict(required=True, type='str', aliases=['pass'], no_log=True),\n+        major_api_version=dict(require=False, type='int'),\n+        minor_api_version=dict(require=False, type='int'),","path":"lib/ansible/module_utils/netapp.py","position":5,"original_position":5,"commit_id":"a8d7acb0641d6e1a371fcc73fe29e541de280877","original_commit_id":"a8d7acb0641d6e1a371fcc73fe29e541de280877","user":{"login":"Akasurde","id":633765,"avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"body":"Same for minor_api_version and rest.","created_at":"2018-04-28T12:07:30Z","updated_at":"2018-04-28T12:08:43Z","html_url":"https://github.com/ansible/ansible/pull/33293#discussion_r184851473","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/33293","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/184851473"},"html":{"href":"https://github.com/ansible/ansible/pull/33293#discussion_r184851473"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/33293"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/33293","id":154707680,"html_url":"https://github.com/ansible/ansible/pull/33293","diff_url":"https://github.com/ansible/ansible/pull/33293.diff","patch_url":"https://github.com/ansible/ansible/pull/33293.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/33293","number":33293,"state":"open","locked":false,"title":"Created configurable parameters for NetApp ontap connection","user":{"login":"mhuot","id":1780860,"avatar_url":"https://avatars0.githubusercontent.com/u/1780860?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuot","html_url":"https://github.com/mhuot","followers_url":"https://api.github.com/users/mhuot/followers","following_url":"https://api.github.com/users/mhuot/following{/other_user}","gists_url":"https://api.github.com/users/mhuot/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuot/subscriptions","organizations_url":"https://api.github.com/users/mhuot/orgs","repos_url":"https://api.github.com/users/mhuot/repos","events_url":"https://api.github.com/users/mhuot/events{/privacy}","received_events_url":"https://api.github.com/users/mhuot/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nFixes #33292 adds ability for user to specify NetApp Ontap module values for port, api_version, server_type and transport_type rather than only hard coded\r\n\r\n##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\nmodule_utils/netapp.py\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.5.0\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /usr/lib/python2.7/site-packages/ansible\r\n  executable location = /usr/bin/ansible\r\n  python version = 2.7.5 (default, Aug  4 2017, 00:39:18) [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)]\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\nThis is in response to a ToDo for adding these as parameters","created_at":"2017-11-27T01:01:08Z","updated_at":"2018-04-28T12:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f6f6f8968193fcb3cc334ad49b6679711090169","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":686214011,"url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.5","name":"affects_2.5","color":"ededed","default":false},{"id":852590921,"url":"https://api.github.com/repos/ansible/ansible/labels/feature","name":"feature","color":"006b75","default":false},{"id":723150340,"url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"ededed","default":false},{"id":581543918,"url":"https://api.github.com/repos/ansible/ansible/labels/stale_ci","name":"stale_ci","color":"fef2c0","default":false},{"id":636352796,"url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/33293/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/33293/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/33293/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/a8d7acb0641d6e1a371fcc73fe29e541de280877","head":{"label":"mhuot:feature/netapp-https","ref":"feature/netapp-https","sha":"a8d7acb0641d6e1a371fcc73fe29e541de280877","user":{"login":"mhuot","id":1780860,"avatar_url":"https://avatars0.githubusercontent.com/u/1780860?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuot","html_url":"https://github.com/mhuot","followers_url":"https://api.github.com/users/mhuot/followers","following_url":"https://api.github.com/users/mhuot/following{/other_user}","gists_url":"https://api.github.com/users/mhuot/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuot/subscriptions","organizations_url":"https://api.github.com/users/mhuot/orgs","repos_url":"https://api.github.com/users/mhuot/repos","events_url":"https://api.github.com/users/mhuot/events{/privacy}","received_events_url":"https://api.github.com/users/mhuot/received_events","type":"User","site_admin":false},"repo":{"id":110768616,"name":"ansible","full_name":"mhuot/ansible","owner":{"login":"mhuot","id":1780860,"avatar_url":"https://avatars0.githubusercontent.com/u/1780860?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuot","html_url":"https://github.com/mhuot","followers_url":"https://api.github.com/users/mhuot/followers","following_url":"https://api.github.com/users/mhuot/following{/other_user}","gists_url":"https://api.github.com/users/mhuot/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuot/subscriptions","organizations_url":"https://api.github.com/users/mhuot/orgs","repos_url":"https://api.github.com/users/mhuot/repos","events_url":"https://api.github.com/users/mhuot/events{/privacy}","received_events_url":"https://api.github.com/users/mhuot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhuot/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/mhuot/ansible","forks_url":"https://api.github.com/repos/mhuot/ansible/forks","keys_url":"https://api.github.com/repos/mhuot/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhuot/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhuot/ansible/teams","hooks_url":"https://api.github.com/repos/mhuot/ansible/hooks","issue_events_url":"https://api.github.com/repos/mhuot/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/mhuot/ansible/events","assignees_url":"https://api.github.com/repos/mhuot/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/mhuot/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/mhuot/ansible/tags","blobs_url":"https://api.github.com/repos/mhuot/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhuot/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhuot/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhuot/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhuot/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/mhuot/ansible/languages","stargazers_url":"https://api.github.com/repos/mhuot/ansible/stargazers","contributors_url":"https://api.github.com/repos/mhuot/ansible/contributors","subscribers_url":"https://api.github.com/repos/mhuot/ansible/subscribers","subscription_url":"https://api.github.com/repos/mhuot/ansible/subscription","commits_url":"https://api.github.com/repos/mhuot/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhuot/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhuot/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhuot/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhuot/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/mhuot/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhuot/ansible/merges","archive_url":"https://api.github.com/repos/mhuot/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhuot/ansible/downloads","issues_url":"https://api.github.com/repos/mhuot/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/mhuot/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/mhuot/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/mhuot/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhuot/ansible/labels{/name}","releases_url":"https://api.github.com/repos/mhuot/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/mhuot/ansible/deployments","created_at":"2017-11-15T01:44:50Z","updated_at":"2017-11-15T01:45:12Z","pushed_at":"2017-11-27T02:22:18Z","git_url":"git://github.com/mhuot/ansible.git","ssh_url":"git@github.com:mhuot/ansible.git","clone_url":"https://github.com/mhuot/ansible.git","svn_url":"https://github.com/mhuot/ansible","homepage":"https://www.ansible.com/","size":91413,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"8bc74443adfbc8a024cf735cf071f13d154eb233","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-04-28T11:16:30Z","pushed_at":"2018-04-28T11:45:08Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":119099,"stargazers_count":29920,"watchers_count":29920,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11047,"mirror_url":null,"archived":false,"open_issues_count":5038,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":11047,"open_issues":5038,"watchers":29920,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/33293"},"html":{"href":"https://github.com/ansible/ansible/pull/33293"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/33293"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/33293/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/33293/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/33293/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/a8d7acb0641d6e1a371fcc73fe29e541de280877"}},"author_association":"NONE"}}
{"actor":{"display_login":"Akasurde"}}