{"action":"created","comment":{"url":"https://api.github.com/repos/slashtrace/slashtrace/pulls/comments/228739104","pull_request_review_id":169082894,"id":228739104,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODczOTEwNA==","diff_hunk":"@@ -65,6 +65,12 @@ public function addHandler(EventHandler $handler)\n         $this->handlers[] = $handler;\n     }\n \n+    public function pushHandler(EventHandler $handler)","path":"src/SlashTrace.php","position":4,"original_position":4,"commit_id":"8d952173fd62d17c359c86b30d71542ceae2c720","original_commit_id":"8d952173fd62d17c359c86b30d71542ceae2c720","user":{"login":"victorstanciu","id":25879,"node_id":"MDQ6VXNlcjI1ODc5","avatar_url":"https://avatars2.githubusercontent.com/u/25879?v=4","gravatar_id":"","url":"https://api.github.com/users/victorstanciu","html_url":"https://github.com/victorstanciu","followers_url":"https://api.github.com/users/victorstanciu/followers","following_url":"https://api.github.com/users/victorstanciu/following{/other_user}","gists_url":"https://api.github.com/users/victorstanciu/gists{/gist_id}","starred_url":"https://api.github.com/users/victorstanciu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorstanciu/subscriptions","organizations_url":"https://api.github.com/users/victorstanciu/orgs","repos_url":"https://api.github.com/users/victorstanciu/repos","events_url":"https://api.github.com/users/victorstanciu/events{/privacy}","received_events_url":"https://api.github.com/users/victorstanciu/received_events","type":"User","site_admin":false},"body":"I'd like you to rename this method. I believe you're thinking in terms of a LIFO stack, but in PHP the \"push\" term is generally used for inserting elements _at the end_ of lists, which is what `SlashTrace->addHandler()` does. What do you think of calling it `prependHandler()`?","created_at":"2018-10-28T08:32:06Z","updated_at":"2018-10-28T08:33:17Z","html_url":"https://github.com/slashtrace/slashtrace/pull/7#discussion_r228739104","pull_request_url":"https://api.github.com/repos/slashtrace/slashtrace/pulls/7","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/slashtrace/slashtrace/pulls/comments/228739104"},"html":{"href":"https://github.com/slashtrace/slashtrace/pull/7#discussion_r228739104"},"pull_request":{"href":"https://api.github.com/repos/slashtrace/slashtrace/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/slashtrace/slashtrace/pulls/7","id":225754935,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NzU0OTM1","html_url":"https://github.com/slashtrace/slashtrace/pull/7","diff_url":"https://github.com/slashtrace/slashtrace/pull/7.diff","patch_url":"https://github.com/slashtrace/slashtrace/pull/7.patch","issue_url":"https://api.github.com/repos/slashtrace/slashtrace/issues/7","number":7,"state":"open","locked":false,"title":"allow to push handlers","user":{"login":"pmall","id":741677,"node_id":"MDQ6VXNlcjc0MTY3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/741677?v=4","gravatar_id":"","url":"https://api.github.com/users/pmall","html_url":"https://github.com/pmall","followers_url":"https://api.github.com/users/pmall/followers","following_url":"https://api.github.com/users/pmall/following{/other_user}","gists_url":"https://api.github.com/users/pmall/gists{/gist_id}","starred_url":"https://api.github.com/users/pmall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmall/subscriptions","organizations_url":"https://api.github.com/users/pmall/orgs","repos_url":"https://api.github.com/users/pmall/repos","events_url":"https://api.github.com/users/pmall/events{/privacy}","received_events_url":"https://api.github.com/users/pmall/received_events","type":"User","site_admin":false},"body":"This PR add a ->pushHandler() to the SlashTrace class. It allows to add handlers *before* the already registered handlers.","created_at":"2018-10-25T13:16:48Z","updated_at":"2018-10-28T08:33:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc9414e986aa412d2ccf41f557d54713aabfcbf9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/slashtrace/slashtrace/pulls/7/commits","review_comments_url":"https://api.github.com/repos/slashtrace/slashtrace/pulls/7/comments","review_comment_url":"https://api.github.com/repos/slashtrace/slashtrace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slashtrace/slashtrace/issues/7/comments","statuses_url":"https://api.github.com/repos/slashtrace/slashtrace/statuses/8d952173fd62d17c359c86b30d71542ceae2c720","head":{"label":"pmall:add-push-handler","ref":"add-push-handler","sha":"8d952173fd62d17c359c86b30d71542ceae2c720","user":{"login":"pmall","id":741677,"node_id":"MDQ6VXNlcjc0MTY3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/741677?v=4","gravatar_id":"","url":"https://api.github.com/users/pmall","html_url":"https://github.com/pmall","followers_url":"https://api.github.com/users/pmall/followers","following_url":"https://api.github.com/users/pmall/following{/other_user}","gists_url":"https://api.github.com/users/pmall/gists{/gist_id}","starred_url":"https://api.github.com/users/pmall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmall/subscriptions","organizations_url":"https://api.github.com/users/pmall/orgs","repos_url":"https://api.github.com/users/pmall/repos","events_url":"https://api.github.com/users/pmall/events{/privacy}","received_events_url":"https://api.github.com/users/pmall/received_events","type":"User","site_admin":false},"repo":{"id":154671981,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ2NzE5ODE=","name":"slashtrace","full_name":"pmall/slashtrace","private":false,"owner":{"login":"pmall","id":741677,"node_id":"MDQ6VXNlcjc0MTY3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/741677?v=4","gravatar_id":"","url":"https://api.github.com/users/pmall","html_url":"https://github.com/pmall","followers_url":"https://api.github.com/users/pmall/followers","following_url":"https://api.github.com/users/pmall/following{/other_user}","gists_url":"https://api.github.com/users/pmall/gists{/gist_id}","starred_url":"https://api.github.com/users/pmall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmall/subscriptions","organizations_url":"https://api.github.com/users/pmall/orgs","repos_url":"https://api.github.com/users/pmall/repos","events_url":"https://api.github.com/users/pmall/events{/privacy}","received_events_url":"https://api.github.com/users/pmall/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pmall/slashtrace","description":"Awesome error handler. Demo: https://slashtrace.com/demo.php","fork":true,"url":"https://api.github.com/repos/pmall/slashtrace","forks_url":"https://api.github.com/repos/pmall/slashtrace/forks","keys_url":"https://api.github.com/repos/pmall/slashtrace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmall/slashtrace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmall/slashtrace/teams","hooks_url":"https://api.github.com/repos/pmall/slashtrace/hooks","issue_events_url":"https://api.github.com/repos/pmall/slashtrace/issues/events{/number}","events_url":"https://api.github.com/repos/pmall/slashtrace/events","assignees_url":"https://api.github.com/repos/pmall/slashtrace/assignees{/user}","branches_url":"https://api.github.com/repos/pmall/slashtrace/branches{/branch}","tags_url":"https://api.github.com/repos/pmall/slashtrace/tags","blobs_url":"https://api.github.com/repos/pmall/slashtrace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmall/slashtrace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmall/slashtrace/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmall/slashtrace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmall/slashtrace/statuses/{sha}","languages_url":"https://api.github.com/repos/pmall/slashtrace/languages","stargazers_url":"https://api.github.com/repos/pmall/slashtrace/stargazers","contributors_url":"https://api.github.com/repos/pmall/slashtrace/contributors","subscribers_url":"https://api.github.com/repos/pmall/slashtrace/subscribers","subscription_url":"https://api.github.com/repos/pmall/slashtrace/subscription","commits_url":"https://api.github.com/repos/pmall/slashtrace/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmall/slashtrace/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmall/slashtrace/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmall/slashtrace/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmall/slashtrace/contents/{+path}","compare_url":"https://api.github.com/repos/pmall/slashtrace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmall/slashtrace/merges","archive_url":"https://api.github.com/repos/pmall/slashtrace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmall/slashtrace/downloads","issues_url":"https://api.github.com/repos/pmall/slashtrace/issues{/number}","pulls_url":"https://api.github.com/repos/pmall/slashtrace/pulls{/number}","milestones_url":"https://api.github.com/repos/pmall/slashtrace/milestones{/number}","notifications_url":"https://api.github.com/repos/pmall/slashtrace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmall/slashtrace/labels{/name}","releases_url":"https://api.github.com/repos/pmall/slashtrace/releases{/id}","deployments_url":"https://api.github.com/repos/pmall/slashtrace/deployments","created_at":"2018-10-25T13:02:31Z","updated_at":"2018-10-25T13:02:33Z","pushed_at":"2018-10-25T13:11:09Z","git_url":"git://github.com/pmall/slashtrace.git","ssh_url":"git@github.com:pmall/slashtrace.git","clone_url":"https://github.com/pmall/slashtrace.git","svn_url":"https://github.com/pmall/slashtrace","homepage":null,"size":102,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slashtrace:master","ref":"master","sha":"6509c3b9e67606dc25510d3f28de431f9cdadc97","user":{"login":"slashtrace","id":43583802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTgzODAy","avatar_url":"https://avatars2.githubusercontent.com/u/43583802?v=4","gravatar_id":"","url":"https://api.github.com/users/slashtrace","html_url":"https://github.com/slashtrace","followers_url":"https://api.github.com/users/slashtrace/followers","following_url":"https://api.github.com/users/slashtrace/following{/other_user}","gists_url":"https://api.github.com/users/slashtrace/gists{/gist_id}","starred_url":"https://api.github.com/users/slashtrace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashtrace/subscriptions","organizations_url":"https://api.github.com/users/slashtrace/orgs","repos_url":"https://api.github.com/users/slashtrace/repos","events_url":"https://api.github.com/users/slashtrace/events{/privacy}","received_events_url":"https://api.github.com/users/slashtrace/received_events","type":"Organization","site_admin":false},"repo":{"id":150456555,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0NTY1NTU=","name":"slashtrace","full_name":"slashtrace/slashtrace","private":false,"owner":{"login":"slashtrace","id":43583802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTgzODAy","avatar_url":"https://avatars2.githubusercontent.com/u/43583802?v=4","gravatar_id":"","url":"https://api.github.com/users/slashtrace","html_url":"https://github.com/slashtrace","followers_url":"https://api.github.com/users/slashtrace/followers","following_url":"https://api.github.com/users/slashtrace/following{/other_user}","gists_url":"https://api.github.com/users/slashtrace/gists{/gist_id}","starred_url":"https://api.github.com/users/slashtrace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashtrace/subscriptions","organizations_url":"https://api.github.com/users/slashtrace/orgs","repos_url":"https://api.github.com/users/slashtrace/repos","events_url":"https://api.github.com/users/slashtrace/events{/privacy}","received_events_url":"https://api.github.com/users/slashtrace/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/slashtrace/slashtrace","description":"Awesome error handler. Demo: https://slashtrace.com/demo.php","fork":false,"url":"https://api.github.com/repos/slashtrace/slashtrace","forks_url":"https://api.github.com/repos/slashtrace/slashtrace/forks","keys_url":"https://api.github.com/repos/slashtrace/slashtrace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slashtrace/slashtrace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slashtrace/slashtrace/teams","hooks_url":"https://api.github.com/repos/slashtrace/slashtrace/hooks","issue_events_url":"https://api.github.com/repos/slashtrace/slashtrace/issues/events{/number}","events_url":"https://api.github.com/repos/slashtrace/slashtrace/events","assignees_url":"https://api.github.com/repos/slashtrace/slashtrace/assignees{/user}","branches_url":"https://api.github.com/repos/slashtrace/slashtrace/branches{/branch}","tags_url":"https://api.github.com/repos/slashtrace/slashtrace/tags","blobs_url":"https://api.github.com/repos/slashtrace/slashtrace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slashtrace/slashtrace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slashtrace/slashtrace/git/refs{/sha}","trees_url":"https://api.github.com/repos/slashtrace/slashtrace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slashtrace/slashtrace/statuses/{sha}","languages_url":"https://api.github.com/repos/slashtrace/slashtrace/languages","stargazers_url":"https://api.github.com/repos/slashtrace/slashtrace/stargazers","contributors_url":"https://api.github.com/repos/slashtrace/slashtrace/contributors","subscribers_url":"https://api.github.com/repos/slashtrace/slashtrace/subscribers","subscription_url":"https://api.github.com/repos/slashtrace/slashtrace/subscription","commits_url":"https://api.github.com/repos/slashtrace/slashtrace/commits{/sha}","git_commits_url":"https://api.github.com/repos/slashtrace/slashtrace/git/commits{/sha}","comments_url":"https://api.github.com/repos/slashtrace/slashtrace/comments{/number}","issue_comment_url":"https://api.github.com/repos/slashtrace/slashtrace/issues/comments{/number}","contents_url":"https://api.github.com/repos/slashtrace/slashtrace/contents/{+path}","compare_url":"https://api.github.com/repos/slashtrace/slashtrace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slashtrace/slashtrace/merges","archive_url":"https://api.github.com/repos/slashtrace/slashtrace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slashtrace/slashtrace/downloads","issues_url":"https://api.github.com/repos/slashtrace/slashtrace/issues{/number}","pulls_url":"https://api.github.com/repos/slashtrace/slashtrace/pulls{/number}","milestones_url":"https://api.github.com/repos/slashtrace/slashtrace/milestones{/number}","notifications_url":"https://api.github.com/repos/slashtrace/slashtrace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slashtrace/slashtrace/labels{/name}","releases_url":"https://api.github.com/repos/slashtrace/slashtrace/releases{/id}","deployments_url":"https://api.github.com/repos/slashtrace/slashtrace/deployments","created_at":"2018-09-26T16:26:32Z","updated_at":"2018-10-27T11:08:37Z","pushed_at":"2018-10-25T13:16:49Z","git_url":"git://github.com/slashtrace/slashtrace.git","ssh_url":"git@github.com:slashtrace/slashtrace.git","clone_url":"https://github.com/slashtrace/slashtrace.git","svn_url":"https://github.com/slashtrace/slashtrace","homepage":null,"size":100,"stargazers_count":153,"watchers_count":153,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":2,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slashtrace/slashtrace/pulls/7"},"html":{"href":"https://github.com/slashtrace/slashtrace/pull/7"},"issue":{"href":"https://api.github.com/repos/slashtrace/slashtrace/issues/7"},"comments":{"href":"https://api.github.com/repos/slashtrace/slashtrace/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/slashtrace/slashtrace/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/slashtrace/slashtrace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slashtrace/slashtrace/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/slashtrace/slashtrace/statuses/8d952173fd62d17c359c86b30d71542ceae2c720"}},"author_association":"NONE"}}
{"actor":{"display_login":"victorstanciu"}}