{"action":"created","comment":{"url":"https://api.github.com/repos/bettio/AtomVM/pulls/comments/234831346","pull_request_review_id":176557820,"id":234831346,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDgzMTM0Ng==","diff_hunk":"@@ -3,24 +3,31 @@ project (AtomVM)\n \n add_subdirectory(libAtomVM)\n \n+if((${CMAKE_SYSTEM_NAME} STREQUAL \"Darwin\") OR \n+   (${CMAKE_SYSTEM_NAME} STREQUAL \"Linux\") OR ","path":"src/CMakeLists.txt","position":5,"original_position":5,"commit_id":"673db0674cc4e2f82765392cab12a052aeb462c1","original_commit_id":"673db0674cc4e2f82765392cab12a052aeb462c1","user":{"login":"bettio","id":24700,"node_id":"MDQ6VXNlcjI0NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/24700?v=4","gravatar_id":"","url":"https://api.github.com/users/bettio","html_url":"https://github.com/bettio","followers_url":"https://api.github.com/users/bettio/followers","following_url":"https://api.github.com/users/bettio/following{/other_user}","gists_url":"https://api.github.com/users/bettio/gists{/gist_id}","starred_url":"https://api.github.com/users/bettio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bettio/subscriptions","organizations_url":"https://api.github.com/users/bettio/orgs","repos_url":"https://api.github.com/users/bettio/repos","events_url":"https://api.github.com/users/bettio/events{/privacy}","received_events_url":"https://api.github.com/users/bettio/received_events","type":"User","site_admin":false},"body":"and also one here just after OR","created_at":"2018-11-20T00:24:27Z","updated_at":"2018-11-20T00:48:35Z","html_url":"https://github.com/bettio/AtomVM/pull/18#discussion_r234831346","pull_request_url":"https://api.github.com/repos/bettio/AtomVM/pulls/18","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bettio/AtomVM/pulls/comments/234831346"},"html":{"href":"https://github.com/bettio/AtomVM/pull/18#discussion_r234831346"},"pull_request":{"href":"https://api.github.com/repos/bettio/AtomVM/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/bettio/AtomVM/pulls/18","id":232120177,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTIwMTc3","html_url":"https://github.com/bettio/AtomVM/pull/18","diff_url":"https://github.com/bettio/AtomVM/pull/18.diff","patch_url":"https://github.com/bettio/AtomVM/pull/18.patch","issue_url":"https://api.github.com/repos/bettio/AtomVM/issues/18","number":18,"state":"open","locked":false,"title":"Build improvement","user":{"login":"fadushin","id":351578,"node_id":"MDQ6VXNlcjM1MTU3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/351578?v=4","gravatar_id":"","url":"https://api.github.com/users/fadushin","html_url":"https://github.com/fadushin","followers_url":"https://api.github.com/users/fadushin/followers","following_url":"https://api.github.com/users/fadushin/following{/other_user}","gists_url":"https://api.github.com/users/fadushin/gists{/gist_id}","starred_url":"https://api.github.com/users/fadushin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fadushin/subscriptions","organizations_url":"https://api.github.com/users/fadushin/orgs","repos_url":"https://api.github.com/users/fadushin/repos","events_url":"https://api.github.com/users/fadushin/events{/privacy}","received_events_url":"https://api.github.com/users/fadushin/received_events","type":"User","site_admin":false},"body":"Broke out platform code into a shared library that is linked by AtomVM and test code and fixed CentOS6 build.  Also added a .gitignore file.\r\n\r\nThe changes in this PR are licensed under the terms of AtomVM (LGPL and/or Apache2).","created_at":"2018-11-19T21:39:48Z","updated_at":"2018-11-20T00:48:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c3953558a35ccc5077168394a553b189e68839e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bettio/AtomVM/pulls/18/commits","review_comments_url":"https://api.github.com/repos/bettio/AtomVM/pulls/18/comments","review_comment_url":"https://api.github.com/repos/bettio/AtomVM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bettio/AtomVM/issues/18/comments","statuses_url":"https://api.github.com/repos/bettio/AtomVM/statuses/673db0674cc4e2f82765392cab12a052aeb462c1","head":{"label":"fadushin:cmake-platform-shlib","ref":"cmake-platform-shlib","sha":"673db0674cc4e2f82765392cab12a052aeb462c1","user":{"login":"fadushin","id":351578,"node_id":"MDQ6VXNlcjM1MTU3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/351578?v=4","gravatar_id":"","url":"https://api.github.com/users/fadushin","html_url":"https://github.com/fadushin","followers_url":"https://api.github.com/users/fadushin/followers","following_url":"https://api.github.com/users/fadushin/following{/other_user}","gists_url":"https://api.github.com/users/fadushin/gists{/gist_id}","starred_url":"https://api.github.com/users/fadushin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fadushin/subscriptions","organizations_url":"https://api.github.com/users/fadushin/orgs","repos_url":"https://api.github.com/users/fadushin/repos","events_url":"https://api.github.com/users/fadushin/events{/privacy}","received_events_url":"https://api.github.com/users/fadushin/received_events","type":"User","site_admin":false},"repo":{"id":156740245,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY3NDAyNDU=","name":"AtomVM","full_name":"fadushin/AtomVM","private":false,"owner":{"login":"fadushin","id":351578,"node_id":"MDQ6VXNlcjM1MTU3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/351578?v=4","gravatar_id":"","url":"https://api.github.com/users/fadushin","html_url":"https://github.com/fadushin","followers_url":"https://api.github.com/users/fadushin/followers","following_url":"https://api.github.com/users/fadushin/following{/other_user}","gists_url":"https://api.github.com/users/fadushin/gists{/gist_id}","starred_url":"https://api.github.com/users/fadushin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fadushin/subscriptions","organizations_url":"https://api.github.com/users/fadushin/orgs","repos_url":"https://api.github.com/users/fadushin/repos","events_url":"https://api.github.com/users/fadushin/events{/privacy}","received_events_url":"https://api.github.com/users/fadushin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fadushin/AtomVM","description":"Tiny Erlang VM","fork":true,"url":"https://api.github.com/repos/fadushin/AtomVM","forks_url":"https://api.github.com/repos/fadushin/AtomVM/forks","keys_url":"https://api.github.com/repos/fadushin/AtomVM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fadushin/AtomVM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fadushin/AtomVM/teams","hooks_url":"https://api.github.com/repos/fadushin/AtomVM/hooks","issue_events_url":"https://api.github.com/repos/fadushin/AtomVM/issues/events{/number}","events_url":"https://api.github.com/repos/fadushin/AtomVM/events","assignees_url":"https://api.github.com/repos/fadushin/AtomVM/assignees{/user}","branches_url":"https://api.github.com/repos/fadushin/AtomVM/branches{/branch}","tags_url":"https://api.github.com/repos/fadushin/AtomVM/tags","blobs_url":"https://api.github.com/repos/fadushin/AtomVM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fadushin/AtomVM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fadushin/AtomVM/git/refs{/sha}","trees_url":"https://api.github.com/repos/fadushin/AtomVM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fadushin/AtomVM/statuses/{sha}","languages_url":"https://api.github.com/repos/fadushin/AtomVM/languages","stargazers_url":"https://api.github.com/repos/fadushin/AtomVM/stargazers","contributors_url":"https://api.github.com/repos/fadushin/AtomVM/contributors","subscribers_url":"https://api.github.com/repos/fadushin/AtomVM/subscribers","subscription_url":"https://api.github.com/repos/fadushin/AtomVM/subscription","commits_url":"https://api.github.com/repos/fadushin/AtomVM/commits{/sha}","git_commits_url":"https://api.github.com/repos/fadushin/AtomVM/git/commits{/sha}","comments_url":"https://api.github.com/repos/fadushin/AtomVM/comments{/number}","issue_comment_url":"https://api.github.com/repos/fadushin/AtomVM/issues/comments{/number}","contents_url":"https://api.github.com/repos/fadushin/AtomVM/contents/{+path}","compare_url":"https://api.github.com/repos/fadushin/AtomVM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fadushin/AtomVM/merges","archive_url":"https://api.github.com/repos/fadushin/AtomVM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fadushin/AtomVM/downloads","issues_url":"https://api.github.com/repos/fadushin/AtomVM/issues{/number}","pulls_url":"https://api.github.com/repos/fadushin/AtomVM/pulls{/number}","milestones_url":"https://api.github.com/repos/fadushin/AtomVM/milestones{/number}","notifications_url":"https://api.github.com/repos/fadushin/AtomVM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fadushin/AtomVM/labels{/name}","releases_url":"https://api.github.com/repos/fadushin/AtomVM/releases{/id}","deployments_url":"https://api.github.com/repos/fadushin/AtomVM/deployments","created_at":"2018-11-08T16:59:46Z","updated_at":"2018-11-19T21:27:55Z","pushed_at":"2018-11-19T23:31:56Z","git_url":"git://github.com/fadushin/AtomVM.git","ssh_url":"git@github.com:fadushin/AtomVM.git","clone_url":"https://github.com/fadushin/AtomVM.git","svn_url":"https://github.com/fadushin/AtomVM","homepage":null,"size":882,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bettio:master","ref":"master","sha":"185c320308b6c28b16b6d9158bd1b07d90214145","user":{"login":"bettio","id":24700,"node_id":"MDQ6VXNlcjI0NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/24700?v=4","gravatar_id":"","url":"https://api.github.com/users/bettio","html_url":"https://github.com/bettio","followers_url":"https://api.github.com/users/bettio/followers","following_url":"https://api.github.com/users/bettio/following{/other_user}","gists_url":"https://api.github.com/users/bettio/gists{/gist_id}","starred_url":"https://api.github.com/users/bettio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bettio/subscriptions","organizations_url":"https://api.github.com/users/bettio/orgs","repos_url":"https://api.github.com/users/bettio/repos","events_url":"https://api.github.com/users/bettio/events{/privacy}","received_events_url":"https://api.github.com/users/bettio/received_events","type":"User","site_admin":false},"repo":{"id":109575106,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk1NzUxMDY=","name":"AtomVM","full_name":"bettio/AtomVM","private":false,"owner":{"login":"bettio","id":24700,"node_id":"MDQ6VXNlcjI0NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/24700?v=4","gravatar_id":"","url":"https://api.github.com/users/bettio","html_url":"https://github.com/bettio","followers_url":"https://api.github.com/users/bettio/followers","following_url":"https://api.github.com/users/bettio/following{/other_user}","gists_url":"https://api.github.com/users/bettio/gists{/gist_id}","starred_url":"https://api.github.com/users/bettio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bettio/subscriptions","organizations_url":"https://api.github.com/users/bettio/orgs","repos_url":"https://api.github.com/users/bettio/repos","events_url":"https://api.github.com/users/bettio/events{/privacy}","received_events_url":"https://api.github.com/users/bettio/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bettio/AtomVM","description":"Tiny Erlang VM","fork":false,"url":"https://api.github.com/repos/bettio/AtomVM","forks_url":"https://api.github.com/repos/bettio/AtomVM/forks","keys_url":"https://api.github.com/repos/bettio/AtomVM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bettio/AtomVM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bettio/AtomVM/teams","hooks_url":"https://api.github.com/repos/bettio/AtomVM/hooks","issue_events_url":"https://api.github.com/repos/bettio/AtomVM/issues/events{/number}","events_url":"https://api.github.com/repos/bettio/AtomVM/events","assignees_url":"https://api.github.com/repos/bettio/AtomVM/assignees{/user}","branches_url":"https://api.github.com/repos/bettio/AtomVM/branches{/branch}","tags_url":"https://api.github.com/repos/bettio/AtomVM/tags","blobs_url":"https://api.github.com/repos/bettio/AtomVM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bettio/AtomVM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bettio/AtomVM/git/refs{/sha}","trees_url":"https://api.github.com/repos/bettio/AtomVM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bettio/AtomVM/statuses/{sha}","languages_url":"https://api.github.com/repos/bettio/AtomVM/languages","stargazers_url":"https://api.github.com/repos/bettio/AtomVM/stargazers","contributors_url":"https://api.github.com/repos/bettio/AtomVM/contributors","subscribers_url":"https://api.github.com/repos/bettio/AtomVM/subscribers","subscription_url":"https://api.github.com/repos/bettio/AtomVM/subscription","commits_url":"https://api.github.com/repos/bettio/AtomVM/commits{/sha}","git_commits_url":"https://api.github.com/repos/bettio/AtomVM/git/commits{/sha}","comments_url":"https://api.github.com/repos/bettio/AtomVM/comments{/number}","issue_comment_url":"https://api.github.com/repos/bettio/AtomVM/issues/comments{/number}","contents_url":"https://api.github.com/repos/bettio/AtomVM/contents/{+path}","compare_url":"https://api.github.com/repos/bettio/AtomVM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bettio/AtomVM/merges","archive_url":"https://api.github.com/repos/bettio/AtomVM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bettio/AtomVM/downloads","issues_url":"https://api.github.com/repos/bettio/AtomVM/issues{/number}","pulls_url":"https://api.github.com/repos/bettio/AtomVM/pulls{/number}","milestones_url":"https://api.github.com/repos/bettio/AtomVM/milestones{/number}","notifications_url":"https://api.github.com/repos/bettio/AtomVM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bettio/AtomVM/labels{/name}","releases_url":"https://api.github.com/repos/bettio/AtomVM/releases{/id}","deployments_url":"https://api.github.com/repos/bettio/AtomVM/deployments","created_at":"2017-11-05T11:54:05Z","updated_at":"2018-11-19T23:41:03Z","pushed_at":"2018-11-19T21:39:49Z","git_url":"git://github.com/bettio/AtomVM.git","ssh_url":"git@github.com:bettio/AtomVM.git","clone_url":"https://github.com/bettio/AtomVM.git","svn_url":"https://github.com/bettio/AtomVM","homepage":null,"size":880,"stargazers_count":84,"watchers_count":84,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":2,"open_issues":15,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bettio/AtomVM/pulls/18"},"html":{"href":"https://github.com/bettio/AtomVM/pull/18"},"issue":{"href":"https://api.github.com/repos/bettio/AtomVM/issues/18"},"comments":{"href":"https://api.github.com/repos/bettio/AtomVM/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/bettio/AtomVM/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/bettio/AtomVM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bettio/AtomVM/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/bettio/AtomVM/statuses/673db0674cc4e2f82765392cab12a052aeb462c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bettio"}}