{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corert/issues/6514","repository_url":"https://api.github.com/repos/dotnet/corert","labels_url":"https://api.github.com/repos/dotnet/corert/issues/6514/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/6514/comments","events_url":"https://api.github.com/repos/dotnet/corert/issues/6514/events","html_url":"https://github.com/dotnet/corert/pull/6514","id":375283061,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzY0OTMy","number":6514,"title":"WIP: wasm:Enables Interop.GetRandomBytes for wasm","user":{"login":"yowl","id":2720041,"node_id":"MDQ6VXNlcjI3MjAwNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/2720041?v=4","gravatar_id":"","url":"https://api.github.com/users/yowl","html_url":"https://github.com/yowl","followers_url":"https://api.github.com/users/yowl/followers","following_url":"https://api.github.com/users/yowl/following{/other_user}","gists_url":"https://api.github.com/users/yowl/gists{/gist_id}","starred_url":"https://api.github.com/users/yowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yowl/subscriptions","organizations_url":"https://api.github.com/users/yowl/orgs","repos_url":"https://api.github.com/users/yowl/repos","events_url":"https://api.github.com/users/yowl/events{/privacy}","received_events_url":"https://api.github.com/users/yowl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-30T01:36:53Z","updated_at":"2018-11-04T13:38:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/6514","html_url":"https://github.com/dotnet/corert/pull/6514","diff_url":"https://github.com/dotnet/corert/pull/6514.diff","patch_url":"https://github.com/dotnet/corert/pull/6514.patch"},"body":"@morganbr @MichalStrehovsky I've made this PR to enable `GetHashcode` for strings as it uses `Marvin.DefaultSeed` and hence `Interop.GetRandomBytes`.  However, I don't know where this should go as where I've put it I think is wrong as I believe this file `src/System.Private.CoreLib/shared/Interop/Unix/System.Native/Interop.GetRandomBytes.cs` is shared with Corefx/CoreCLR.  Where should this go?  Perhaps its not even necessary as the Unix implementation in `Interop.Libraries.SystemNative` may will be enough with a different `DllImport`?  If it is required could you comment on whether we can safely assume `sizeof(int)==4` in wasm?\r\n\r\nThanks"},"comment":{"url":"https://api.github.com/repos/dotnet/corert/issues/comments/435670455","html_url":"https://github.com/dotnet/corert/pull/6514#issuecomment-435670455","issue_url":"https://api.github.com/repos/dotnet/corert/issues/6514","id":435670455,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTY3MDQ1NQ==","user":{"login":"MichalStrehovsky","id":13110571,"node_id":"MDQ6VXNlcjEzMTEwNTcx","avatar_url":"https://avatars0.githubusercontent.com/u/13110571?v=4","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"created_at":"2018-11-04T13:38:28Z","updated_at":"2018-11-04T13:38:28Z","author_association":"MEMBER","body":"Implementation for this comes from the CoreFX repo: https://github.com/dotnet/corefx/blob/a10890f4ffe0fadf090c922578ba0e606ebdd16c/src/Native/Unix/System.Native/pal_random.c#L23\r\n\r\nWe should be able to use that, but we'll need to finish build and packaging for the WASM CoreFX NuGet packages. @morganbr [has been working on this](https://github.com/dotnet/corefx/pull/32045) on and off."}}
{"actor":{"display_login":"MichalStrehovsky"}}