{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63284","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63284/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63284/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63284/events","html_url":"https://github.com/kubernetes/kubernetes/pull/63284","id":318704581,"number":63284,"title":"[WIP]: Use json-iter for JSON parsing","user":{"login":"ash2k","id":126021,"avatar_url":"https://avatars3.githubusercontent.com/u/126021?v=4","gravatar_id":"","url":"https://api.github.com/users/ash2k","html_url":"https://github.com/ash2k","followers_url":"https://api.github.com/users/ash2k/followers","following_url":"https://api.github.com/users/ash2k/following{/other_user}","gists_url":"https://api.github.com/users/ash2k/gists{/gist_id}","starred_url":"https://api.github.com/users/ash2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ash2k/subscriptions","organizations_url":"https://api.github.com/users/ash2k/orgs","repos_url":"https://api.github.com/users/ash2k/repos","events_url":"https://api.github.com/users/ash2k/events{/privacy}","received_events_url":"https://api.github.com/users/ash2k/received_events","type":"User","site_admin":false},"labels":[{"id":451459590,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687500047,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":105146073,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/enhancement","name":"kind/enhancement","color":"c7def8","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":173494222,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-29T09:57:41Z","updated_at":"2018-05-08T00:18:06Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63284","html_url":"https://github.com/kubernetes/kubernetes/pull/63284","diff_url":"https://github.com/kubernetes/kubernetes/pull/63284.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/63284.patch"},"body":"**What this PR does / why we need it**:\r\n1. Changes `k8s.io/apimachinery/pkg/util/json` to use `github.com/json-iterator/go` instead of  `encoding/json`;\r\n2. Changes all `encoding/json` usages and all direct `github.com/json-iterator/go` usages to `k8s.io/apimachinery/pkg/util/json`\r\n\r\nThis is to ensure json marshaling and unmarshaling is consistent and always uses the same library which is better performance-wise.\r\n\r\n**Special notes for your reviewer**:\r\nInconsistency discovered while working on https://github.com/kubernetes/kubernetes/pull/62981.\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n/kind enhancement\r\n/sig api-machinery"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/387245265","html_url":"https://github.com/kubernetes/kubernetes/pull/63284#issuecomment-387245265","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63284","id":387245265,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T00:18:06Z","updated_at":"2018-05-08T00:18:06Z","author_association":"COLLABORATOR","body":"@ash2k: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-verify | df230cf49e0e7f684d8840bca7d5ef99fe597d98 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63284/pull-kubernetes-verify/89432/) | `/test pull-kubernetes-verify`\npull-kubernetes-e2e-gce | df230cf49e0e7f684d8840bca7d5ef99fe597d98 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63284/pull-kubernetes-e2e-gce/33905/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | 7b7cbd2b9ec0baae5b76ebf392983319db29fbb7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63284/pull-kubernetes-e2e-gce-device-plugin-gpu/30676/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-bazel-test | 7b7cbd2b9ec0baae5b76ebf392983319db29fbb7 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/63284/pull-kubernetes-bazel-test/43516/) | `/test pull-kubernetes-bazel-test`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/63284). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/ash2k). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}