{"action":"created","issue":{"url":"https://api.github.com/repos/samvera/hyrax/issues/1077","repository_url":"https://api.github.com/repos/samvera/hyrax","labels_url":"https://api.github.com/repos/samvera/hyrax/issues/1077/labels{/name}","comments_url":"https://api.github.com/repos/samvera/hyrax/issues/1077/comments","events_url":"https://api.github.com/repos/samvera/hyrax/issues/1077/events","html_url":"https://github.com/samvera/hyrax/issues/1077","id":231751817,"node_id":"MDU6SXNzdWUyMzE3NTE4MTc=","number":1077,"title":"Generated indexer contradicts itself","user":{"login":"atz","id":109954,"node_id":"MDQ6VXNlcjEwOTk1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/109954?v=4","gravatar_id":"","url":"https://api.github.com/users/atz","html_url":"https://github.com/atz","followers_url":"https://api.github.com/users/atz/followers","following_url":"https://api.github.com/users/atz/following{/other_user}","gists_url":"https://api.github.com/users/atz/gists{/gist_id}","starred_url":"https://api.github.com/users/atz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atz/subscriptions","organizations_url":"https://api.github.com/users/atz/orgs","repos_url":"https://api.github.com/users/atz/repos","events_url":"https://api.github.com/users/atz/events{/privacy}","received_events_url":"https://api.github.com/users/atz/received_events","type":"User","site_admin":false},"labels":[{"id":505053956,"node_id":"MDU6TGFiZWw1MDUwNTM5NTY=","url":"https://api.github.com/repos/samvera/hyrax/labels/technical%20debt","name":"technical debt","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/samvera/hyrax/milestones/1","html_url":"https://github.com/samvera/hyrax/milestone/1","labels_url":"https://api.github.com/repos/samvera/hyrax/milestones/1/labels","id":2210731,"node_id":"MDk6TWlsZXN0b25lMjIxMDczMQ==","number":1,"title":"Backlog","description":"","creator":{"login":"mjgiarlo","id":131982,"node_id":"MDQ6VXNlcjEzMTk4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/131982?v=4","gravatar_id":"","url":"https://api.github.com/users/mjgiarlo","html_url":"https://github.com/mjgiarlo","followers_url":"https://api.github.com/users/mjgiarlo/followers","following_url":"https://api.github.com/users/mjgiarlo/following{/other_user}","gists_url":"https://api.github.com/users/mjgiarlo/gists{/gist_id}","starred_url":"https://api.github.com/users/mjgiarlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjgiarlo/subscriptions","organizations_url":"https://api.github.com/users/mjgiarlo/orgs","repos_url":"https://api.github.com/users/mjgiarlo/repos","events_url":"https://api.github.com/users/mjgiarlo/events{/privacy}","received_events_url":"https://api.github.com/users/mjgiarlo/received_events","type":"User","site_admin":false},"open_issues":253,"closed_issues":142,"state":"open","created_at":"2016-12-21T19:45:35Z","updated_at":"2018-07-09T19:40:20Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2017-05-26T22:55:42Z","updated_at":"2018-07-09T19:40:20Z","closed_at":"2018-07-09T19:40:20Z","author_association":"CONTRIBUTOR","body":"The [generator](https://github.com/samvera-labs/hyrax/blob/master/lib/generators/hyrax/work/templates/indexer.rb.erb) includes both:\r\n```ruby\r\n  include Hyrax::IndexesBasicMetadata\r\n```\r\nand:\r\n```ruby\r\n  include Hyrax::IndexesLinkedMetadata\r\n```\r\n\r\nThat is useless, since [IndexesBasicMetadata](https://github.com/samvera-labs/hyrax/blob/master/app/indexers/concerns/hyrax/indexes_basic_metadata.rb#L5-L7) and [IndexesLinkedMetadata](https://github.com/samvera-labs/hyrax/blob/master/app/indexers/concerns/hyrax/indexes_linked_metadata.rb#L5-L7) both override `rdf_service` differently (`BasicMetadataIndexer` vs. `DeepIndexingService`).  And that's ALL they do.  Only the last one \"wins\", so there is no point including the first one.  \r\n\r\nMOREOVER, why is this stuff buried in a module that the user has no understanding of anyway, just to hide the one thing the module actually does?  We should just put this in the generator:\r\n```ruby\r\ndef rdf_service\r\n  DeepIndexingService # Unlike BasicMetadataIndexer, fetches remote labels for based_near\r\nend\r\n```\r\n\r\nAnd remove `DeepIndexingService` completely.  (Further work could be done to eradicate `BasicMetadataIndexer`).  "},"comment":{"url":"https://api.github.com/repos/samvera/hyrax/issues/comments/403596375","html_url":"https://github.com/samvera/hyrax/issues/1077#issuecomment-403596375","issue_url":"https://api.github.com/repos/samvera/hyrax/issues/1077","id":403596375,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzU5NjM3NQ==","user":{"login":"no-reply","id":1361776,"node_id":"MDQ6VXNlcjEzNjE3NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1361776?v=4","gravatar_id":"","url":"https://api.github.com/users/no-reply","html_url":"https://github.com/no-reply","followers_url":"https://api.github.com/users/no-reply/followers","following_url":"https://api.github.com/users/no-reply/following{/other_user}","gists_url":"https://api.github.com/users/no-reply/gists{/gist_id}","starred_url":"https://api.github.com/users/no-reply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-reply/subscriptions","organizations_url":"https://api.github.com/users/no-reply/orgs","repos_url":"https://api.github.com/users/no-reply/repos","events_url":"https://api.github.com/users/no-reply/events{/privacy}","received_events_url":"https://api.github.com/users/no-reply/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T19:40:20Z","updated_at":"2018-07-09T19:40:20Z","author_association":"MEMBER","body":"This seems fine, and functions to provide the fallback @jcoyne described. Refactors are welcome (especially ones that use more flexible patterns than multiple/module inheritance), but I'm going to close this as a tracked issue."}}
{"actor":{"display_login":"no-reply"}}