{"action":"created","comment":{"url":"https://api.github.com/repos/indix/bubblewrap/pulls/comments/238702025","pull_request_review_id":181306851,"id":238702025,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODcwMjAyNQ==","diff_hunk":"@@ -30,12 +27,13 @@ class HttpClient(clientSettings: ClientSettings = ClientSettings()) {\n                                           .setUseInsecureTrustManager(true)\n                                           .setMaxRequestRetry(clientSettings.retries)\n                                           .setFollowRedirect(false)\n-                                          .setKeepAlive(clientSettings.keepAlive)\n-                                          .setNettyTimer(timer).build())\n+                                          .setKeepAlive(clientSettings.keepAlive).setNettyTimer(timer)\n+                                          .build())\n \n \n   def get(url: WebUrl, config: CrawlConfig) = {","path":"src/main/scala/bubblewrap/HttpClient.scala","position":41,"original_position":41,"commit_id":"5baa46e515c2cf708e05a4e8a536b951e8e40fd4","original_commit_id":"5baa46e515c2cf708e05a4e8a536b951e8e40fd4","user":{"login":"varadharajan","id":291096,"node_id":"MDQ6VXNlcjI5MTA5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/291096?v=4","gravatar_id":"","url":"https://api.github.com/users/varadharajan","html_url":"https://github.com/varadharajan","followers_url":"https://api.github.com/users/varadharajan/followers","following_url":"https://api.github.com/users/varadharajan/following{/other_user}","gists_url":"https://api.github.com/users/varadharajan/gists{/gist_id}","starred_url":"https://api.github.com/users/varadharajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varadharajan/subscriptions","organizations_url":"https://api.github.com/users/varadharajan/orgs","repos_url":"https://api.github.com/users/varadharajan/repos","events_url":"https://api.github.com/users/varadharajan/events{/privacy}","received_events_url":"https://api.github.com/users/varadharajan/received_events","type":"User","site_admin":false},"body":"@brewkode, Makes sense.","created_at":"2018-12-04T15:11:39Z","updated_at":"2018-12-04T15:11:40Z","html_url":"https://github.com/indix/bubblewrap/pull/22#discussion_r238702025","pull_request_url":"https://api.github.com/repos/indix/bubblewrap/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/indix/bubblewrap/pulls/comments/238702025"},"html":{"href":"https://github.com/indix/bubblewrap/pull/22#discussion_r238702025"},"pull_request":{"href":"https://api.github.com/repos/indix/bubblewrap/pulls/22"}},"in_reply_to_id":238696606},"pull_request":{"url":"https://api.github.com/repos/indix/bubblewrap/pulls/22","id":235828859,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1ODI4ODU5","html_url":"https://github.com/indix/bubblewrap/pull/22","diff_url":"https://github.com/indix/bubblewrap/pull/22.diff","patch_url":"https://github.com/indix/bubblewrap/pull/22.patch","issue_url":"https://api.github.com/repos/indix/bubblewrap/issues/22","number":22,"state":"open","locked":false,"title":"GC friendly HTTPHandler","user":{"login":"varadharajan","id":291096,"node_id":"MDQ6VXNlcjI5MTA5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/291096?v=4","gravatar_id":"","url":"https://api.github.com/users/varadharajan","html_url":"https://github.com/varadharajan","followers_url":"https://api.github.com/users/varadharajan/followers","following_url":"https://api.github.com/users/varadharajan/following{/other_user}","gists_url":"https://api.github.com/users/varadharajan/gists{/gist_id}","starred_url":"https://api.github.com/users/varadharajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varadharajan/subscriptions","organizations_url":"https://api.github.com/users/varadharajan/orgs","repos_url":"https://api.github.com/users/varadharajan/repos","events_url":"https://api.github.com/users/varadharajan/events{/privacy}","received_events_url":"https://api.github.com/users/varadharajan/received_events","type":"User","site_admin":false},"body":"At the moment, [httpResponse](https://github.com/indix/bubblewrap/blob/master/src/main/scala/bubblewrap/HttpHandler.scala#L17) is an instance val as part of the HTTPHandler. AsyncHTTPClient ties up this handler with NettyResponseFuture, which gets queued into the HashedWheelTimer. This means, the entire response will be available until keepAlive and the reapers triggers and clears up these objects. In order to free up the response data real quick, we need a hack by de-referencing it.  Looks hard for our eyes, but makes real impact.\r\n\r\nThe other change is with respect to having a small wheel so that timeoutTasks are checked more frequently.","created_at":"2018-12-04T14:28:06Z","updated_at":"2018-12-04T15:11:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"686a9b8f99b9ea9686a44e267c97a9d5e038d295","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anant-indix","id":33016449,"node_id":"MDQ6VXNlcjMzMDE2NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/33016449?v=4","gravatar_id":"","url":"https://api.github.com/users/anant-indix","html_url":"https://github.com/anant-indix","followers_url":"https://api.github.com/users/anant-indix/followers","following_url":"https://api.github.com/users/anant-indix/following{/other_user}","gists_url":"https://api.github.com/users/anant-indix/gists{/gist_id}","starred_url":"https://api.github.com/users/anant-indix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anant-indix/subscriptions","organizations_url":"https://api.github.com/users/anant-indix/orgs","repos_url":"https://api.github.com/users/anant-indix/repos","events_url":"https://api.github.com/users/anant-indix/events{/privacy}","received_events_url":"https://api.github.com/users/anant-indix/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/indix/bubblewrap/pulls/22/commits","review_comments_url":"https://api.github.com/repos/indix/bubblewrap/pulls/22/comments","review_comment_url":"https://api.github.com/repos/indix/bubblewrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indix/bubblewrap/issues/22/comments","statuses_url":"https://api.github.com/repos/indix/bubblewrap/statuses/5baa46e515c2cf708e05a4e8a536b951e8e40fd4","head":{"label":"indix:gc","ref":"gc","sha":"5baa46e515c2cf708e05a4e8a536b951e8e40fd4","user":{"login":"indix","id":22314469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzE0NDY5","avatar_url":"https://avatars3.githubusercontent.com/u/22314469?v=4","gravatar_id":"","url":"https://api.github.com/users/indix","html_url":"https://github.com/indix","followers_url":"https://api.github.com/users/indix/followers","following_url":"https://api.github.com/users/indix/following{/other_user}","gists_url":"https://api.github.com/users/indix/gists{/gist_id}","starred_url":"https://api.github.com/users/indix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indix/subscriptions","organizations_url":"https://api.github.com/users/indix/orgs","repos_url":"https://api.github.com/users/indix/repos","events_url":"https://api.github.com/users/indix/events{/privacy}","received_events_url":"https://api.github.com/users/indix/received_events","type":"Organization","site_admin":false},"repo":{"id":36442371,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQ0MjM3MQ==","name":"bubblewrap","full_name":"indix/bubblewrap","private":false,"owner":{"login":"indix","id":22314469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzE0NDY5","avatar_url":"https://avatars3.githubusercontent.com/u/22314469?v=4","gravatar_id":"","url":"https://api.github.com/users/indix","html_url":"https://github.com/indix","followers_url":"https://api.github.com/users/indix/followers","following_url":"https://api.github.com/users/indix/following{/other_user}","gists_url":"https://api.github.com/users/indix/gists{/gist_id}","starred_url":"https://api.github.com/users/indix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indix/subscriptions","organizations_url":"https://api.github.com/users/indix/orgs","repos_url":"https://api.github.com/users/indix/repos","events_url":"https://api.github.com/users/indix/events{/privacy}","received_events_url":"https://api.github.com/users/indix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/indix/bubblewrap","description":"Asynchronous crawler utils","fork":false,"url":"https://api.github.com/repos/indix/bubblewrap","forks_url":"https://api.github.com/repos/indix/bubblewrap/forks","keys_url":"https://api.github.com/repos/indix/bubblewrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indix/bubblewrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indix/bubblewrap/teams","hooks_url":"https://api.github.com/repos/indix/bubblewrap/hooks","issue_events_url":"https://api.github.com/repos/indix/bubblewrap/issues/events{/number}","events_url":"https://api.github.com/repos/indix/bubblewrap/events","assignees_url":"https://api.github.com/repos/indix/bubblewrap/assignees{/user}","branches_url":"https://api.github.com/repos/indix/bubblewrap/branches{/branch}","tags_url":"https://api.github.com/repos/indix/bubblewrap/tags","blobs_url":"https://api.github.com/repos/indix/bubblewrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indix/bubblewrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indix/bubblewrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/indix/bubblewrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indix/bubblewrap/statuses/{sha}","languages_url":"https://api.github.com/repos/indix/bubblewrap/languages","stargazers_url":"https://api.github.com/repos/indix/bubblewrap/stargazers","contributors_url":"https://api.github.com/repos/indix/bubblewrap/contributors","subscribers_url":"https://api.github.com/repos/indix/bubblewrap/subscribers","subscription_url":"https://api.github.com/repos/indix/bubblewrap/subscription","commits_url":"https://api.github.com/repos/indix/bubblewrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/indix/bubblewrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/indix/bubblewrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/indix/bubblewrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/indix/bubblewrap/contents/{+path}","compare_url":"https://api.github.com/repos/indix/bubblewrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indix/bubblewrap/merges","archive_url":"https://api.github.com/repos/indix/bubblewrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indix/bubblewrap/downloads","issues_url":"https://api.github.com/repos/indix/bubblewrap/issues{/number}","pulls_url":"https://api.github.com/repos/indix/bubblewrap/pulls{/number}","milestones_url":"https://api.github.com/repos/indix/bubblewrap/milestones{/number}","notifications_url":"https://api.github.com/repos/indix/bubblewrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indix/bubblewrap/labels{/name}","releases_url":"https://api.github.com/repos/indix/bubblewrap/releases{/id}","deployments_url":"https://api.github.com/repos/indix/bubblewrap/deployments","created_at":"2015-05-28T14:04:01Z","updated_at":"2018-12-04T12:05:34Z","pushed_at":"2018-12-04T14:31:54Z","git_url":"git://github.com/indix/bubblewrap.git","ssh_url":"git@github.com:indix/bubblewrap.git","clone_url":"https://github.com/indix/bubblewrap.git","svn_url":"https://github.com/indix/bubblewrap","homepage":null,"size":176,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"indix:master","ref":"master","sha":"666ab0e8c38c4459c96dfa9004bb36a7b383cb03","user":{"login":"indix","id":22314469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzE0NDY5","avatar_url":"https://avatars3.githubusercontent.com/u/22314469?v=4","gravatar_id":"","url":"https://api.github.com/users/indix","html_url":"https://github.com/indix","followers_url":"https://api.github.com/users/indix/followers","following_url":"https://api.github.com/users/indix/following{/other_user}","gists_url":"https://api.github.com/users/indix/gists{/gist_id}","starred_url":"https://api.github.com/users/indix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indix/subscriptions","organizations_url":"https://api.github.com/users/indix/orgs","repos_url":"https://api.github.com/users/indix/repos","events_url":"https://api.github.com/users/indix/events{/privacy}","received_events_url":"https://api.github.com/users/indix/received_events","type":"Organization","site_admin":false},"repo":{"id":36442371,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQ0MjM3MQ==","name":"bubblewrap","full_name":"indix/bubblewrap","private":false,"owner":{"login":"indix","id":22314469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzE0NDY5","avatar_url":"https://avatars3.githubusercontent.com/u/22314469?v=4","gravatar_id":"","url":"https://api.github.com/users/indix","html_url":"https://github.com/indix","followers_url":"https://api.github.com/users/indix/followers","following_url":"https://api.github.com/users/indix/following{/other_user}","gists_url":"https://api.github.com/users/indix/gists{/gist_id}","starred_url":"https://api.github.com/users/indix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indix/subscriptions","organizations_url":"https://api.github.com/users/indix/orgs","repos_url":"https://api.github.com/users/indix/repos","events_url":"https://api.github.com/users/indix/events{/privacy}","received_events_url":"https://api.github.com/users/indix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/indix/bubblewrap","description":"Asynchronous crawler utils","fork":false,"url":"https://api.github.com/repos/indix/bubblewrap","forks_url":"https://api.github.com/repos/indix/bubblewrap/forks","keys_url":"https://api.github.com/repos/indix/bubblewrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indix/bubblewrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indix/bubblewrap/teams","hooks_url":"https://api.github.com/repos/indix/bubblewrap/hooks","issue_events_url":"https://api.github.com/repos/indix/bubblewrap/issues/events{/number}","events_url":"https://api.github.com/repos/indix/bubblewrap/events","assignees_url":"https://api.github.com/repos/indix/bubblewrap/assignees{/user}","branches_url":"https://api.github.com/repos/indix/bubblewrap/branches{/branch}","tags_url":"https://api.github.com/repos/indix/bubblewrap/tags","blobs_url":"https://api.github.com/repos/indix/bubblewrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indix/bubblewrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indix/bubblewrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/indix/bubblewrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indix/bubblewrap/statuses/{sha}","languages_url":"https://api.github.com/repos/indix/bubblewrap/languages","stargazers_url":"https://api.github.com/repos/indix/bubblewrap/stargazers","contributors_url":"https://api.github.com/repos/indix/bubblewrap/contributors","subscribers_url":"https://api.github.com/repos/indix/bubblewrap/subscribers","subscription_url":"https://api.github.com/repos/indix/bubblewrap/subscription","commits_url":"https://api.github.com/repos/indix/bubblewrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/indix/bubblewrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/indix/bubblewrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/indix/bubblewrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/indix/bubblewrap/contents/{+path}","compare_url":"https://api.github.com/repos/indix/bubblewrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indix/bubblewrap/merges","archive_url":"https://api.github.com/repos/indix/bubblewrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indix/bubblewrap/downloads","issues_url":"https://api.github.com/repos/indix/bubblewrap/issues{/number}","pulls_url":"https://api.github.com/repos/indix/bubblewrap/pulls{/number}","milestones_url":"https://api.github.com/repos/indix/bubblewrap/milestones{/number}","notifications_url":"https://api.github.com/repos/indix/bubblewrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indix/bubblewrap/labels{/name}","releases_url":"https://api.github.com/repos/indix/bubblewrap/releases{/id}","deployments_url":"https://api.github.com/repos/indix/bubblewrap/deployments","created_at":"2015-05-28T14:04:01Z","updated_at":"2018-12-04T12:05:34Z","pushed_at":"2018-12-04T14:31:54Z","git_url":"git://github.com/indix/bubblewrap.git","ssh_url":"git@github.com:indix/bubblewrap.git","clone_url":"https://github.com/indix/bubblewrap.git","svn_url":"https://github.com/indix/bubblewrap","homepage":null,"size":176,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/indix/bubblewrap/pulls/22"},"html":{"href":"https://github.com/indix/bubblewrap/pull/22"},"issue":{"href":"https://api.github.com/repos/indix/bubblewrap/issues/22"},"comments":{"href":"https://api.github.com/repos/indix/bubblewrap/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/indix/bubblewrap/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/indix/bubblewrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indix/bubblewrap/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/indix/bubblewrap/statuses/5baa46e515c2cf708e05a4e8a536b951e8e40fd4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"varadharajan"}}