{"action":"created","comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/226540707","pull_request_review_id":166387669,"id":226540707,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjU0MDcwNw==","diff_hunk":"@@ -108,22 +108,22 @@ class DotDiagramGenerator(settings: doc.Settings) extends DiagramGenerator {\n         //   them by on node with a corresponding tooltip\n \n         val outgoingImplicits =\n-          if (_outgoingImplicits.length > settings.docDiagramsMaxImplicitClasses.value) {\n+          if (_outgoingImplicits.lengthCompare(settings.docDiagramsMaxImplicitClasses.value) > 0) {","path":"src/scaladoc/scala/tools/nsc/doc/html/page/diagram/DotDiagramGenerator.scala","position":5,"original_position":5,"commit_id":"a7b8de0a9a31d48ffb8e064f82cb19815c089a66","original_commit_id":"a7b8de0a9a31d48ffb8e064f82cb19815c089a66","user":{"login":"NthPortal","id":7505383,"node_id":"MDQ6VXNlcjc1MDUzODM=","avatar_url":"https://avatars0.githubusercontent.com/u/7505383?v=4","gravatar_id":"","url":"https://api.github.com/users/NthPortal","html_url":"https://github.com/NthPortal","followers_url":"https://api.github.com/users/NthPortal/followers","following_url":"https://api.github.com/users/NthPortal/following{/other_user}","gists_url":"https://api.github.com/users/NthPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/NthPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NthPortal/subscriptions","organizations_url":"https://api.github.com/users/NthPortal/orgs","repos_url":"https://api.github.com/users/NthPortal/repos","events_url":"https://api.github.com/users/NthPortal/events{/privacy}","received_events_url":"https://api.github.com/users/NthPortal/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n          if (_outgoingImplicits.lengthIs > settings.docDiagramsMaxImplicitClasses.value) {\r\n```","created_at":"2018-10-19T06:04:28Z","updated_at":"2018-10-19T06:28:10Z","html_url":"https://github.com/scala/scala/pull/7339#discussion_r226540707","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/7339","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/226540707"},"html":{"href":"https://github.com/scala/scala/pull/7339#discussion_r226540707"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/7339"}}},"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/7339","id":222951000,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTUxMDAw","html_url":"https://github.com/scala/scala/pull/7339","diff_url":"https://github.com/scala/scala/pull/7339.diff","patch_url":"https://github.com/scala/scala/pull/7339.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/7339","number":7339,"state":"open","locked":false,"title":"Proposal for not calculating the full size of the collection.","user":{"login":"Kobenko","id":21039161,"node_id":"MDQ6VXNlcjIxMDM5MTYx","avatar_url":"https://avatars0.githubusercontent.com/u/21039161?v=4","gravatar_id":"","url":"https://api.github.com/users/Kobenko","html_url":"https://github.com/Kobenko","followers_url":"https://api.github.com/users/Kobenko/followers","following_url":"https://api.github.com/users/Kobenko/following{/other_user}","gists_url":"https://api.github.com/users/Kobenko/gists{/gist_id}","starred_url":"https://api.github.com/users/Kobenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kobenko/subscriptions","organizations_url":"https://api.github.com/users/Kobenko/orgs","repos_url":"https://api.github.com/users/Kobenko/repos","events_url":"https://api.github.com/users/Kobenko/events{/privacy}","received_events_url":"https://api.github.com/users/Kobenko/received_events","type":"User","site_admin":false},"body":"During the comparison do not calculate the full size of the collection.\r\nSince calculating the size of a collection can be quite “expensive” calculation for some types of collections, we can reduce the comparison time from O (len) to O (len min n).","created_at":"2018-10-15T15:36:54Z","updated_at":"2018-10-19T06:28:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1a54f07e572864cf6e2e4a7238a60b81748c86c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/67","html_url":"https://github.com/scala/scala/milestone/67","labels_url":"https://api.github.com/repos/scala/scala/milestones/67/labels","id":2719691,"node_id":"MDk6TWlsZXN0b25lMjcxOTY5MQ==","number":67,"title":"2.13.0-RC1","description":"Merge to 2.13.x. A PR should have scala/bug issue. No new PRs after Dec 15. Lead: @adriaanm\r\n\r\nRestricted to fixes directly improving the collections, their usage or the migration to 2.13.0. We will also consider fixes for important regressions since 2.12. An exception may be made for a small addition that cannot target 2.13.1 due to binary incompatibilities.","creator":{"login":"adriaanm","id":91083,"node_id":"MDQ6VXNlcjkxMDgz","avatar_url":"https://avatars2.githubusercontent.com/u/91083?v=4","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"open_issues":71,"closed_issues":139,"state":"open","created_at":"2017-08-23T23:45:52Z","updated_at":"2018-10-19T05:55:54Z","due_on":"2019-01-11T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scala/scala/pulls/7339/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/7339/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/scala/issues/7339/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/a7b8de0a9a31d48ffb8e064f82cb19815c089a66","head":{"label":"Kobenko:2.13.x","ref":"2.13.x","sha":"a7b8de0a9a31d48ffb8e064f82cb19815c089a66","user":{"login":"Kobenko","id":21039161,"node_id":"MDQ6VXNlcjIxMDM5MTYx","avatar_url":"https://avatars0.githubusercontent.com/u/21039161?v=4","gravatar_id":"","url":"https://api.github.com/users/Kobenko","html_url":"https://github.com/Kobenko","followers_url":"https://api.github.com/users/Kobenko/followers","following_url":"https://api.github.com/users/Kobenko/following{/other_user}","gists_url":"https://api.github.com/users/Kobenko/gists{/gist_id}","starred_url":"https://api.github.com/users/Kobenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kobenko/subscriptions","organizations_url":"https://api.github.com/users/Kobenko/orgs","repos_url":"https://api.github.com/users/Kobenko/repos","events_url":"https://api.github.com/users/Kobenko/events{/privacy}","received_events_url":"https://api.github.com/users/Kobenko/received_events","type":"User","site_admin":false},"repo":{"id":153076303,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMwNzYzMDM=","name":"scala","full_name":"Kobenko/scala","private":false,"owner":{"login":"Kobenko","id":21039161,"node_id":"MDQ6VXNlcjIxMDM5MTYx","avatar_url":"https://avatars0.githubusercontent.com/u/21039161?v=4","gravatar_id":"","url":"https://api.github.com/users/Kobenko","html_url":"https://github.com/Kobenko","followers_url":"https://api.github.com/users/Kobenko/followers","following_url":"https://api.github.com/users/Kobenko/following{/other_user}","gists_url":"https://api.github.com/users/Kobenko/gists{/gist_id}","starred_url":"https://api.github.com/users/Kobenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kobenko/subscriptions","organizations_url":"https://api.github.com/users/Kobenko/orgs","repos_url":"https://api.github.com/users/Kobenko/repos","events_url":"https://api.github.com/users/Kobenko/events{/privacy}","received_events_url":"https://api.github.com/users/Kobenko/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Kobenko/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/Kobenko/scala","forks_url":"https://api.github.com/repos/Kobenko/scala/forks","keys_url":"https://api.github.com/repos/Kobenko/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kobenko/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kobenko/scala/teams","hooks_url":"https://api.github.com/repos/Kobenko/scala/hooks","issue_events_url":"https://api.github.com/repos/Kobenko/scala/issues/events{/number}","events_url":"https://api.github.com/repos/Kobenko/scala/events","assignees_url":"https://api.github.com/repos/Kobenko/scala/assignees{/user}","branches_url":"https://api.github.com/repos/Kobenko/scala/branches{/branch}","tags_url":"https://api.github.com/repos/Kobenko/scala/tags","blobs_url":"https://api.github.com/repos/Kobenko/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kobenko/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kobenko/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kobenko/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kobenko/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/Kobenko/scala/languages","stargazers_url":"https://api.github.com/repos/Kobenko/scala/stargazers","contributors_url":"https://api.github.com/repos/Kobenko/scala/contributors","subscribers_url":"https://api.github.com/repos/Kobenko/scala/subscribers","subscription_url":"https://api.github.com/repos/Kobenko/scala/subscription","commits_url":"https://api.github.com/repos/Kobenko/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kobenko/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kobenko/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kobenko/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kobenko/scala/contents/{+path}","compare_url":"https://api.github.com/repos/Kobenko/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kobenko/scala/merges","archive_url":"https://api.github.com/repos/Kobenko/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kobenko/scala/downloads","issues_url":"https://api.github.com/repos/Kobenko/scala/issues{/number}","pulls_url":"https://api.github.com/repos/Kobenko/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/Kobenko/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/Kobenko/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kobenko/scala/labels{/name}","releases_url":"https://api.github.com/repos/Kobenko/scala/releases{/id}","deployments_url":"https://api.github.com/repos/Kobenko/scala/deployments","created_at":"2018-10-15T08:11:05Z","updated_at":"2018-10-16T12:56:13Z","pushed_at":"2018-10-16T12:56:34Z","git_url":"git://github.com/Kobenko/scala.git","ssh_url":"git@github.com:Kobenko/scala.git","clone_url":"https://github.com/Kobenko/scala.git","svn_url":"https://github.com/Kobenko/scala","homepage":"http://www.scala-lang.org/","size":106260,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.13.x"}},"base":{"label":"scala:2.13.x","ref":"2.13.x","sha":"ec669bfbdd39dad22ef9d32f57cda5b1a9c7b05c","user":{"login":"scala","id":57059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MDU5","avatar_url":"https://avatars2.githubusercontent.com/u/57059?v=4","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"node_id":"MDEwOlJlcG9zaXRvcnkyODg4ODE4","name":"scala","full_name":"scala/scala","private":false,"owner":{"login":"scala","id":57059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MDU5","avatar_url":"https://avatars2.githubusercontent.com/u/57059?v=4","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","deployments_url":"https://api.github.com/repos/scala/scala/deployments","created_at":"2011-12-01T05:02:34Z","updated_at":"2018-10-19T04:41:04Z","pushed_at":"2018-10-19T05:56:39Z","git_url":"git://github.com/scala/scala.git","ssh_url":"git@github.com:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":106395,"stargazers_count":10779,"watchers_count":10779,"language":"Scala","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2557,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2557,"open_issues":88,"watchers":10779,"default_branch":"2.13.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/7339"},"html":{"href":"https://github.com/scala/scala/pull/7339"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/7339"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/7339/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/7339/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/7339/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/a7b8de0a9a31d48ffb8e064f82cb19815c089a66"}},"author_association":"NONE"}}
{"actor":{"display_login":"NthPortal"}}