{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/comments/223190487","pull_request_review_id":162266479,"id":223190487,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzE5MDQ4Nw==","diff_hunk":"@@ -51,9 +51,8 @@\n             mode: '0644',\n             owner: 'root',\n             group: 'root',\n-            path: '/etc/snmp/snmp.conf',\n-            require: ['Package[snmp-client]', 'File[/etc/snmp]']\n-          )\n+            path: '/etc/snmp/snmp.conf'","path":"spec/classes/snmp_client_spec.rb","position":7,"original_position":7,"commit_id":"3431608e520785fecda14e541ceae0925930dbc8","original_commit_id":"3431608e520785fecda14e541ceae0925930dbc8","user":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"body":"meh.  Just think of the noise correcting all 100 odd modules to the new style! ;)","created_at":"2018-10-06T18:44:37Z","updated_at":"2018-10-06T18:44:37Z","html_url":"https://github.com/voxpupuli/puppet-snmp/pull/149#discussion_r223190487","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/149","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/comments/223190487"},"html":{"href":"https://github.com/voxpupuli/puppet-snmp/pull/149#discussion_r223190487"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/149"}},"in_reply_to_id":223057977},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/149","id":220736397,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzM2Mzk3","html_url":"https://github.com/voxpupuli/puppet-snmp/pull/149","diff_url":"https://github.com/voxpupuli/puppet-snmp/pull/149.diff","patch_url":"https://github.com/voxpupuli/puppet-snmp/pull/149.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/issues/149","number":149,"state":"open","locked":false,"title":"DO NOT MERGE (needs squash): Refactoring","user":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"body":"Refactor (and hopefully simplify) some of the conditional logic and relationships.\r\n\r\nI've initially submitted this as a series of commits to make it easier to review (and find mistakes!).\r\nIf everything looks ok, I'll rebase and squash before merging.\r\n\r\nIn a future PR it should then be easy to move resources to separate classes and follow the `Install -> Config ~> Service` pattern.","created_at":"2018-10-05T15:16:04Z","updated_at":"2018-10-06T18:44:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aa8c2e9bc65e15dde83b8505fc00bbd20348088","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vStone","id":356719,"node_id":"MDQ6VXNlcjM1NjcxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/356719?v=4","gravatar_id":"","url":"https://api.github.com/users/vStone","html_url":"https://github.com/vStone","followers_url":"https://api.github.com/users/vStone/followers","following_url":"https://api.github.com/users/vStone/following{/other_user}","gists_url":"https://api.github.com/users/vStone/gists{/gist_id}","starred_url":"https://api.github.com/users/vStone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vStone/subscriptions","organizations_url":"https://api.github.com/users/vStone/orgs","repos_url":"https://api.github.com/users/vStone/repos","events_url":"https://api.github.com/users/vStone/events{/privacy}","received_events_url":"https://api.github.com/users/vStone/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1057312215,"node_id":"MDU6TGFiZWwxMDU3MzEyMjE1","url":"https://api.github.com/repos/voxpupuli/puppet-snmp/labels/needs-rebase","name":"needs-rebase","color":"8d05ba","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/149/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/149/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/issues/149/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/statuses/3431608e520785fecda14e541ceae0925930dbc8","head":{"label":"alexjfisher:refactor","ref":"refactor","sha":"3431608e520785fecda14e541ceae0925930dbc8","user":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"repo":{"id":150977968,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA5Nzc5Njg=","name":"puppet-snmp","full_name":"alexjfisher/puppet-snmp","private":false,"owner":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexjfisher/puppet-snmp","description":"Puppet module to manage Net-SNMP.","fork":true,"url":"https://api.github.com/repos/alexjfisher/puppet-snmp","forks_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/forks","keys_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/teams","hooks_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/hooks","issue_events_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/issues/events{/number}","events_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/events","assignees_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/assignees{/user}","branches_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/branches{/branch}","tags_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/tags","blobs_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/statuses/{sha}","languages_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/languages","stargazers_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/stargazers","contributors_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/contributors","subscribers_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/subscribers","subscription_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/subscription","commits_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/contents/{+path}","compare_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/merges","archive_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/downloads","issues_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/issues{/number}","pulls_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/pulls{/number}","milestones_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/milestones{/number}","notifications_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/labels{/name}","releases_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/releases{/id}","deployments_url":"https://api.github.com/repos/alexjfisher/puppet-snmp/deployments","created_at":"2018-09-30T15:10:55Z","updated_at":"2018-09-30T17:56:49Z","pushed_at":"2018-10-05T15:08:20Z","git_url":"git://github.com/alexjfisher/puppet-snmp.git","ssh_url":"git@github.com:alexjfisher/puppet-snmp.git","clone_url":"https://github.com/alexjfisher/puppet-snmp.git","svn_url":"https://github.com/alexjfisher/puppet-snmp","homepage":"http://forge.puppetlabs.com/razorsedge/snmp","size":398,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"7cb930a20457a5c32a6d81ff2cb11e1f588a91f2","user":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":3691169,"node_id":"MDEwOlJlcG9zaXRvcnkzNjkxMTY5","name":"puppet-snmp","full_name":"voxpupuli/puppet-snmp","private":false,"owner":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/voxpupuli/puppet-snmp","description":"Puppet module to manage Net-SNMP.","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-snmp","forks_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-snmp/deployments","created_at":"2012-03-12T01:39:28Z","updated_at":"2018-10-05T15:33:29Z","pushed_at":"2018-10-05T15:16:05Z","git_url":"git://github.com/voxpupuli/puppet-snmp.git","ssh_url":"git@github.com:voxpupuli/puppet-snmp.git","clone_url":"https://github.com/voxpupuli/puppet-snmp.git","svn_url":"https://github.com/voxpupuli/puppet-snmp","homepage":"http://forge.puppetlabs.com/razorsedge/snmp","size":399,"stargazers_count":28,"watchers_count":28,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":101,"open_issues":18,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/149"},"html":{"href":"https://github.com/voxpupuli/puppet-snmp/pull/149"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-snmp/issues/149"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-snmp/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-snmp/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-snmp/statuses/3431608e520785fecda14e541ceae0925930dbc8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alexjfisher"}}