{"action":"created","comment":{"url":"https://api.github.com/repos/igniterealtime/Smack/pulls/comments/199914726","pull_request_review_id":134126988,"id":199914726,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTkxNDcyNg==","diff_hunk":"@@ -56,11 +56,7 @@ public static boolean hasHint(Message message) {\n     }\n \n     public static void set(Message message) {\n-        if (StoreHint.hasHint(message)) {\n-            // No need to set the no-permanent-store hint when a no-store hint is already set.\n-            return;\n-        }\n-        setExplicitly(message);\n+        message.overrideExtension(INSTANCE);\n     }\n \n     public static void setExplicitly(Message message) {","path":"smack-experimental/src/main/java/org/jivesoftware/smackx/hints/element/NoPermanentStoreHint.java","position":12,"original_position":12,"commit_id":"4774ad234ef9c227c1fd53151d80238a327148f1","original_commit_id":"4774ad234ef9c227c1fd53151d80238a327148f1","user":{"login":"Flowdalic","id":432385,"node_id":"MDQ6VXNlcjQzMjM4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/432385?v=4","gravatar_id":"","url":"https://api.github.com/users/Flowdalic","html_url":"https://github.com/Flowdalic","followers_url":"https://api.github.com/users/Flowdalic/followers","following_url":"https://api.github.com/users/Flowdalic/following{/other_user}","gists_url":"https://api.github.com/users/Flowdalic/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowdalic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowdalic/subscriptions","organizations_url":"https://api.github.com/users/Flowdalic/orgs","repos_url":"https://api.github.com/users/Flowdalic/repos","events_url":"https://api.github.com/users/Flowdalic/events{/privacy}","received_events_url":"https://api.github.com/users/Flowdalic/received_events","type":"User","site_admin":false},"body":"Help me here: Why do you think that it is no longer needed?","created_at":"2018-07-03T18:46:40Z","updated_at":"2018-07-03T18:46:40Z","html_url":"https://github.com/igniterealtime/Smack/pull/249#discussion_r199914726","pull_request_url":"https://api.github.com/repos/igniterealtime/Smack/pulls/249","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/comments/199914726"},"html":{"href":"https://github.com/igniterealtime/Smack/pull/249#discussion_r199914726"},"pull_request":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/249"}},"in_reply_to_id":199868200},"pull_request":{"url":"https://api.github.com/repos/igniterealtime/Smack/pulls/249","id":198906612,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4OTA2NjEy","html_url":"https://github.com/igniterealtime/Smack/pull/249","diff_url":"https://github.com/igniterealtime/Smack/pull/249.diff","patch_url":"https://github.com/igniterealtime/Smack/pull/249.patch","issue_url":"https://api.github.com/repos/igniterealtime/Smack/issues/249","number":249,"state":"open","locked":false,"title":"Avoid adding multiple storage hints to a message","user":{"login":"vanitasvitae","id":7854206,"node_id":"MDQ6VXNlcjc4NTQyMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/7854206?v=4","gravatar_id":"","url":"https://api.github.com/users/vanitasvitae","html_url":"https://github.com/vanitasvitae","followers_url":"https://api.github.com/users/vanitasvitae/followers","following_url":"https://api.github.com/users/vanitasvitae/following{/other_user}","gists_url":"https://api.github.com/users/vanitasvitae/gists{/gist_id}","starred_url":"https://api.github.com/users/vanitasvitae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanitasvitae/subscriptions","organizations_url":"https://api.github.com/users/vanitasvitae/orgs","repos_url":"https://api.github.com/users/vanitasvitae/repos","events_url":"https://api.github.com/users/vanitasvitae/events{/privacy}","received_events_url":"https://api.github.com/users/vanitasvitae/received_events","type":"User","site_admin":false},"body":"Since ExtensionElements are stored in a list in the message, duplicate entries are possible. This commit avoids adding a storage hint to the message in case it already contains one.","created_at":"2018-07-03T09:44:01Z","updated_at":"2018-07-03T18:46:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e870e1d9af0f11e1912e9d549cac3cf393cadca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/igniterealtime/Smack/pulls/249/commits","review_comments_url":"https://api.github.com/repos/igniterealtime/Smack/pulls/249/comments","review_comment_url":"https://api.github.com/repos/igniterealtime/Smack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/igniterealtime/Smack/issues/249/comments","statuses_url":"https://api.github.com/repos/igniterealtime/Smack/statuses/4774ad234ef9c227c1fd53151d80238a327148f1","head":{"label":"vanitasvitae:checkHint","ref":"checkHint","sha":"4774ad234ef9c227c1fd53151d80238a327148f1","user":{"login":"vanitasvitae","id":7854206,"node_id":"MDQ6VXNlcjc4NTQyMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/7854206?v=4","gravatar_id":"","url":"https://api.github.com/users/vanitasvitae","html_url":"https://github.com/vanitasvitae","followers_url":"https://api.github.com/users/vanitasvitae/followers","following_url":"https://api.github.com/users/vanitasvitae/following{/other_user}","gists_url":"https://api.github.com/users/vanitasvitae/gists{/gist_id}","starred_url":"https://api.github.com/users/vanitasvitae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanitasvitae/subscriptions","organizations_url":"https://api.github.com/users/vanitasvitae/orgs","repos_url":"https://api.github.com/users/vanitasvitae/repos","events_url":"https://api.github.com/users/vanitasvitae/events{/privacy}","received_events_url":"https://api.github.com/users/vanitasvitae/received_events","type":"User","site_admin":false},"repo":{"id":83078451,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA3ODQ1MQ==","name":"Smack","full_name":"vanitasvitae/Smack","owner":{"login":"vanitasvitae","id":7854206,"node_id":"MDQ6VXNlcjc4NTQyMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/7854206?v=4","gravatar_id":"","url":"https://api.github.com/users/vanitasvitae","html_url":"https://github.com/vanitasvitae","followers_url":"https://api.github.com/users/vanitasvitae/followers","following_url":"https://api.github.com/users/vanitasvitae/following{/other_user}","gists_url":"https://api.github.com/users/vanitasvitae/gists{/gist_id}","starred_url":"https://api.github.com/users/vanitasvitae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanitasvitae/subscriptions","organizations_url":"https://api.github.com/users/vanitasvitae/orgs","repos_url":"https://api.github.com/users/vanitasvitae/repos","events_url":"https://api.github.com/users/vanitasvitae/events{/privacy}","received_events_url":"https://api.github.com/users/vanitasvitae/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vanitasvitae/Smack","description":"Fork of the XMPP library Smack introducing support for OMEMO encryption","fork":true,"url":"https://api.github.com/repos/vanitasvitae/Smack","forks_url":"https://api.github.com/repos/vanitasvitae/Smack/forks","keys_url":"https://api.github.com/repos/vanitasvitae/Smack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanitasvitae/Smack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanitasvitae/Smack/teams","hooks_url":"https://api.github.com/repos/vanitasvitae/Smack/hooks","issue_events_url":"https://api.github.com/repos/vanitasvitae/Smack/issues/events{/number}","events_url":"https://api.github.com/repos/vanitasvitae/Smack/events","assignees_url":"https://api.github.com/repos/vanitasvitae/Smack/assignees{/user}","branches_url":"https://api.github.com/repos/vanitasvitae/Smack/branches{/branch}","tags_url":"https://api.github.com/repos/vanitasvitae/Smack/tags","blobs_url":"https://api.github.com/repos/vanitasvitae/Smack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanitasvitae/Smack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanitasvitae/Smack/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanitasvitae/Smack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanitasvitae/Smack/statuses/{sha}","languages_url":"https://api.github.com/repos/vanitasvitae/Smack/languages","stargazers_url":"https://api.github.com/repos/vanitasvitae/Smack/stargazers","contributors_url":"https://api.github.com/repos/vanitasvitae/Smack/contributors","subscribers_url":"https://api.github.com/repos/vanitasvitae/Smack/subscribers","subscription_url":"https://api.github.com/repos/vanitasvitae/Smack/subscription","commits_url":"https://api.github.com/repos/vanitasvitae/Smack/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanitasvitae/Smack/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanitasvitae/Smack/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanitasvitae/Smack/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanitasvitae/Smack/contents/{+path}","compare_url":"https://api.github.com/repos/vanitasvitae/Smack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanitasvitae/Smack/merges","archive_url":"https://api.github.com/repos/vanitasvitae/Smack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanitasvitae/Smack/downloads","issues_url":"https://api.github.com/repos/vanitasvitae/Smack/issues{/number}","pulls_url":"https://api.github.com/repos/vanitasvitae/Smack/pulls{/number}","milestones_url":"https://api.github.com/repos/vanitasvitae/Smack/milestones{/number}","notifications_url":"https://api.github.com/repos/vanitasvitae/Smack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanitasvitae/Smack/labels{/name}","releases_url":"https://api.github.com/repos/vanitasvitae/Smack/releases{/id}","deployments_url":"https://api.github.com/repos/vanitasvitae/Smack/deployments","created_at":"2017-02-24T20:06:17Z","updated_at":"2018-07-03T09:37:44Z","pushed_at":"2018-07-03T16:16:56Z","git_url":"git://github.com/vanitasvitae/Smack.git","ssh_url":"git@github.com:vanitasvitae/Smack.git","clone_url":"https://github.com/vanitasvitae/Smack.git","svn_url":"https://github.com/vanitasvitae/Smack","homepage":"https://community.igniterealtime.org/blogs/ignite/2017/06/06/smack-v42-introduces-omemo-support","size":29143,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":1,"watchers":12,"default_branch":"master"}},"base":{"label":"igniterealtime:4.3","ref":"4.3","sha":"78a5f5089a497eb1f33a85151174468eb0ed0b80","user":{"login":"igniterealtime","id":5991032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTEwMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5991032?v=4","gravatar_id":"","url":"https://api.github.com/users/igniterealtime","html_url":"https://github.com/igniterealtime","followers_url":"https://api.github.com/users/igniterealtime/followers","following_url":"https://api.github.com/users/igniterealtime/following{/other_user}","gists_url":"https://api.github.com/users/igniterealtime/gists{/gist_id}","starred_url":"https://api.github.com/users/igniterealtime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igniterealtime/subscriptions","organizations_url":"https://api.github.com/users/igniterealtime/orgs","repos_url":"https://api.github.com/users/igniterealtime/repos","events_url":"https://api.github.com/users/igniterealtime/events{/privacy}","received_events_url":"https://api.github.com/users/igniterealtime/received_events","type":"Organization","site_admin":false},"repo":{"id":16477702,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ3NzcwMg==","name":"Smack","full_name":"igniterealtime/Smack","owner":{"login":"igniterealtime","id":5991032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTEwMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5991032?v=4","gravatar_id":"","url":"https://api.github.com/users/igniterealtime","html_url":"https://github.com/igniterealtime","followers_url":"https://api.github.com/users/igniterealtime/followers","following_url":"https://api.github.com/users/igniterealtime/following{/other_user}","gists_url":"https://api.github.com/users/igniterealtime/gists{/gist_id}","starred_url":"https://api.github.com/users/igniterealtime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igniterealtime/subscriptions","organizations_url":"https://api.github.com/users/igniterealtime/orgs","repos_url":"https://api.github.com/users/igniterealtime/repos","events_url":"https://api.github.com/users/igniterealtime/events{/privacy}","received_events_url":"https://api.github.com/users/igniterealtime/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/igniterealtime/Smack","description":"A modular and portable open source XMPP client library written in Java for Android and Java (SE) VMs","fork":false,"url":"https://api.github.com/repos/igniterealtime/Smack","forks_url":"https://api.github.com/repos/igniterealtime/Smack/forks","keys_url":"https://api.github.com/repos/igniterealtime/Smack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igniterealtime/Smack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igniterealtime/Smack/teams","hooks_url":"https://api.github.com/repos/igniterealtime/Smack/hooks","issue_events_url":"https://api.github.com/repos/igniterealtime/Smack/issues/events{/number}","events_url":"https://api.github.com/repos/igniterealtime/Smack/events","assignees_url":"https://api.github.com/repos/igniterealtime/Smack/assignees{/user}","branches_url":"https://api.github.com/repos/igniterealtime/Smack/branches{/branch}","tags_url":"https://api.github.com/repos/igniterealtime/Smack/tags","blobs_url":"https://api.github.com/repos/igniterealtime/Smack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igniterealtime/Smack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igniterealtime/Smack/git/refs{/sha}","trees_url":"https://api.github.com/repos/igniterealtime/Smack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igniterealtime/Smack/statuses/{sha}","languages_url":"https://api.github.com/repos/igniterealtime/Smack/languages","stargazers_url":"https://api.github.com/repos/igniterealtime/Smack/stargazers","contributors_url":"https://api.github.com/repos/igniterealtime/Smack/contributors","subscribers_url":"https://api.github.com/repos/igniterealtime/Smack/subscribers","subscription_url":"https://api.github.com/repos/igniterealtime/Smack/subscription","commits_url":"https://api.github.com/repos/igniterealtime/Smack/commits{/sha}","git_commits_url":"https://api.github.com/repos/igniterealtime/Smack/git/commits{/sha}","comments_url":"https://api.github.com/repos/igniterealtime/Smack/comments{/number}","issue_comment_url":"https://api.github.com/repos/igniterealtime/Smack/issues/comments{/number}","contents_url":"https://api.github.com/repos/igniterealtime/Smack/contents/{+path}","compare_url":"https://api.github.com/repos/igniterealtime/Smack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igniterealtime/Smack/merges","archive_url":"https://api.github.com/repos/igniterealtime/Smack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igniterealtime/Smack/downloads","issues_url":"https://api.github.com/repos/igniterealtime/Smack/issues{/number}","pulls_url":"https://api.github.com/repos/igniterealtime/Smack/pulls{/number}","milestones_url":"https://api.github.com/repos/igniterealtime/Smack/milestones{/number}","notifications_url":"https://api.github.com/repos/igniterealtime/Smack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igniterealtime/Smack/labels{/name}","releases_url":"https://api.github.com/repos/igniterealtime/Smack/releases{/id}","deployments_url":"https://api.github.com/repos/igniterealtime/Smack/deployments","created_at":"2014-02-03T11:36:51Z","updated_at":"2018-07-03T07:52:44Z","pushed_at":"2018-07-03T16:16:57Z","git_url":"git://github.com/igniterealtime/Smack.git","ssh_url":"git@github.com:igniterealtime/Smack.git","clone_url":"https://github.com/igniterealtime/Smack.git","svn_url":"https://github.com/igniterealtime/Smack","homepage":"https://igniterealtime.org/projects/smack/","size":27586,"stargazers_count":1744,"watchers_count":1744,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":711,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":711,"open_issues":11,"watchers":1744,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/249"},"html":{"href":"https://github.com/igniterealtime/Smack/pull/249"},"issue":{"href":"https://api.github.com/repos/igniterealtime/Smack/issues/249"},"comments":{"href":"https://api.github.com/repos/igniterealtime/Smack/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/igniterealtime/Smack/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/igniterealtime/Smack/statuses/4774ad234ef9c227c1fd53151d80238a327148f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Flowdalic"}}