{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/comments/194283702","pull_request_review_id":127423556,"id":194283702,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDI4MzcwMg==","diff_hunk":"@@ -73,7 +73,7 @@ func NewProxy(\n \t\ttenant:           tenant,\n \t\twit:              wit,\n \t\tidler:            idler,\n-\t\tbufferCheckSleep: 30,\n+\t\tbufferCheckSleep: 30 * time.Second,","path":"internal/proxy/proxy.go","position":5,"original_position":5,"commit_id":"58c1a5f8bceb942dc75391c0afb4a438e41593e9","original_commit_id":"58c1a5f8bceb942dc75391c0afb4a438e41593e9","user":{"login":"sthaha","id":3005132,"node_id":"MDQ6VXNlcjMwMDUxMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3005132?v=4","gravatar_id":"","url":"https://api.github.com/users/sthaha","html_url":"https://github.com/sthaha","followers_url":"https://api.github.com/users/sthaha/followers","following_url":"https://api.github.com/users/sthaha/following{/other_user}","gists_url":"https://api.github.com/users/sthaha/gists{/gist_id}","starred_url":"https://api.github.com/users/sthaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthaha/subscriptions","organizations_url":"https://api.github.com/users/sthaha/orgs","repos_url":"https://api.github.com/users/sthaha/repos","events_url":"https://api.github.com/users/sthaha/events{/privacy}","received_events_url":"https://api.github.com/users/sthaha/received_events","type":"User","site_admin":false},"body":"shouldn't the type be also changed to time.Duration ?","created_at":"2018-06-11T02:50:55Z","updated_at":"2018-06-11T03:02:27Z","html_url":"https://github.com/fabric8-services/fabric8-jenkins-proxy/pull/292#discussion_r194283702","pull_request_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/292","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/comments/194283702"},"html":{"href":"https://github.com/fabric8-services/fabric8-jenkins-proxy/pull/292#discussion_r194283702"},"pull_request":{"href":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/292"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/292","id":192993533,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTkzNTMz","html_url":"https://github.com/fabric8-services/fabric8-jenkins-proxy/pull/292","diff_url":"https://github.com/fabric8-services/fabric8-jenkins-proxy/pull/292.diff","patch_url":"https://github.com/fabric8-services/fabric8-jenkins-proxy/pull/292.patch","issue_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/issues/292","number":292,"state":"open","locked":false,"title":"Issue 290 Fix buggy ProcessBuffer","user":{"login":"kishansagathiya","id":10185999,"node_id":"MDQ6VXNlcjEwMTg1OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/10185999?v=4","gravatar_id":"","url":"https://api.github.com/users/kishansagathiya","html_url":"https://github.com/kishansagathiya","followers_url":"https://api.github.com/users/kishansagathiya/followers","following_url":"https://api.github.com/users/kishansagathiya/following{/other_user}","gists_url":"https://api.github.com/users/kishansagathiya/gists{/gist_id}","starred_url":"https://api.github.com/users/kishansagathiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishansagathiya/subscriptions","organizations_url":"https://api.github.com/users/kishansagathiya/orgs","repos_url":"https://api.github.com/users/kishansagathiya/repos","events_url":"https://api.github.com/users/kishansagathiya/events{/privacy}","received_events_url":"https://api.github.com/users/kishansagathiya/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-06T12:15:21Z","updated_at":"2018-06-11T03:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39047131b9f2c4af159450fb3ee85cea8fa72597","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/292/commits","review_comments_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/292/comments","review_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/issues/292/comments","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/statuses/58c1a5f8bceb942dc75391c0afb4a438e41593e9","head":{"label":"kishansagathiya:issue_290","ref":"issue_290","sha":"58c1a5f8bceb942dc75391c0afb4a438e41593e9","user":{"login":"kishansagathiya","id":10185999,"node_id":"MDQ6VXNlcjEwMTg1OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/10185999?v=4","gravatar_id":"","url":"https://api.github.com/users/kishansagathiya","html_url":"https://github.com/kishansagathiya","followers_url":"https://api.github.com/users/kishansagathiya/followers","following_url":"https://api.github.com/users/kishansagathiya/following{/other_user}","gists_url":"https://api.github.com/users/kishansagathiya/gists{/gist_id}","starred_url":"https://api.github.com/users/kishansagathiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishansagathiya/subscriptions","organizations_url":"https://api.github.com/users/kishansagathiya/orgs","repos_url":"https://api.github.com/users/kishansagathiya/repos","events_url":"https://api.github.com/users/kishansagathiya/events{/privacy}","received_events_url":"https://api.github.com/users/kishansagathiya/received_events","type":"User","site_admin":false},"repo":{"id":124858876,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ4NTg4NzY=","name":"fabric8-jenkins-proxy","full_name":"kishansagathiya/fabric8-jenkins-proxy","owner":{"login":"kishansagathiya","id":10185999,"node_id":"MDQ6VXNlcjEwMTg1OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/10185999?v=4","gravatar_id":"","url":"https://api.github.com/users/kishansagathiya","html_url":"https://github.com/kishansagathiya","followers_url":"https://api.github.com/users/kishansagathiya/followers","following_url":"https://api.github.com/users/kishansagathiya/following{/other_user}","gists_url":"https://api.github.com/users/kishansagathiya/gists{/gist_id}","starred_url":"https://api.github.com/users/kishansagathiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kishansagathiya/subscriptions","organizations_url":"https://api.github.com/users/kishansagathiya/orgs","repos_url":"https://api.github.com/users/kishansagathiya/repos","events_url":"https://api.github.com/users/kishansagathiya/events{/privacy}","received_events_url":"https://api.github.com/users/kishansagathiya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kishansagathiya/fabric8-jenkins-proxy","description":null,"fork":true,"url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy","forks_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/forks","keys_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/teams","hooks_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/hooks","issue_events_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/events","assignees_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/tags","blobs_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/languages","stargazers_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/stargazers","contributors_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/contributors","subscribers_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/subscribers","subscription_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/subscription","commits_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/merges","archive_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/downloads","issues_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/labels{/name}","releases_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/kishansagathiya/fabric8-jenkins-proxy/deployments","created_at":"2018-03-12T08:42:22Z","updated_at":"2018-03-12T08:42:23Z","pushed_at":"2018-06-08T08:45:46Z","git_url":"git://github.com/kishansagathiya/fabric8-jenkins-proxy.git","ssh_url":"git@github.com:kishansagathiya/fabric8-jenkins-proxy.git","clone_url":"https://github.com/kishansagathiya/fabric8-jenkins-proxy.git","svn_url":"https://github.com/kishansagathiya/fabric8-jenkins-proxy","homepage":null,"size":4909,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-services:master","ref":"master","sha":"1c40ff1e317607780f54546e2a514c494c72a36e","user":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"repo":{"id":108866769,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg4NjY3Njk=","name":"fabric8-jenkins-proxy","full_name":"fabric8-services/fabric8-jenkins-proxy","owner":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-services/fabric8-jenkins-proxy","description":null,"fork":false,"url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy","forks_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/forks","keys_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/teams","hooks_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/hooks","issue_events_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/events","assignees_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/tags","blobs_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/languages","stargazers_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/stargazers","contributors_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/contributors","subscribers_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/subscribers","subscription_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/subscription","commits_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/merges","archive_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/downloads","issues_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/deployments","created_at":"2017-10-30T15:02:04Z","updated_at":"2018-06-08T11:45:19Z","pushed_at":"2018-06-08T11:45:15Z","git_url":"git://github.com/fabric8-services/fabric8-jenkins-proxy.git","ssh_url":"git@github.com:fabric8-services/fabric8-jenkins-proxy.git","clone_url":"https://github.com/fabric8-services/fabric8-jenkins-proxy.git","svn_url":"https://github.com/fabric8-services/fabric8-jenkins-proxy","homepage":null,"size":546,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":42,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/292"},"html":{"href":"https://github.com/fabric8-services/fabric8-jenkins-proxy/pull/292"},"issue":{"href":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/issues/292"},"comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-services/fabric8-jenkins-proxy/statuses/58c1a5f8bceb942dc75391c0afb4a438e41593e9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sthaha"}}