{"action":"created","comment":{"url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments/214906501","pull_request_review_id":152056164,"id":214906501,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDkwNjUwMQ==","diff_hunk":"@@ -0,0 +1,62 @@\n+<?php\n+declare(strict_types = 1);\n+\n+namespace App\\Controller\\Styleguide\\Ds2013\\Utilities;\n+\n+use App\\Builders\\ClipBuilder;\n+use App\\Builders\\CollapsedBroadcastBuilder;\n+use App\\Builders\\CollectionBuilder;\n+use App\\Builders\\EpisodeBuilder;\n+use App\\Builders\\GalleryBuilder;\n+use App\\Builders\\ServiceBuilder;\n+use App\\Controller\\BaseController;\n+use BBC\\ProgrammesPagesService\\Domain\\Enumeration\\MediaTypeEnum;\n+use BBC\\ProgrammesPagesService\\Domain\\ValueObject\\Pid;\n+use BBC\\ProgrammesPagesService\\Domain\\ValueObject\\Sid;\n+use BBC\\ProgrammesPagesService\\Service\\CoreEntitiesService;\n+use Symfony\\Component\\HttpFoundation\\Request;\n+\n+class CtaInSituController extends BaseController\n+{\n+    public function __invoke(Request $request, CoreEntitiesService $coreEntitiesService)\n+    {\n+        if ($request->query->has('branding_context')) {\n+            $coreEntity = $coreEntitiesService->findByPidFull(new Pid($request->query->get('branding_context')));\n+            $this->setContextAndPreloadBranding($coreEntity);\n+        }\n+        // @TODO Should we instead load examples from queries here instead of hardcoding PIDs?","path":"src/Controller/Styleguide/Ds2013/Utilities/CtaInSituController.php","position":27,"original_position":27,"commit_id":"4d7993afda26fe839598eae0cd1e22af213d8b72","original_commit_id":"4d7993afda26fe839598eae0cd1e22af213d8b72","user":{"login":"votemike","id":3957065,"node_id":"MDQ6VXNlcjM5NTcwNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3957065?v=4","gravatar_id":"","url":"https://api.github.com/users/votemike","html_url":"https://github.com/votemike","followers_url":"https://api.github.com/users/votemike/followers","following_url":"https://api.github.com/users/votemike/following{/other_user}","gists_url":"https://api.github.com/users/votemike/gists{/gist_id}","starred_url":"https://api.github.com/users/votemike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/votemike/subscriptions","organizations_url":"https://api.github.com/users/votemike/orgs","repos_url":"https://api.github.com/users/votemike/repos","events_url":"https://api.github.com/users/votemike/events{/privacy}","received_events_url":"https://api.github.com/users/votemike/received_events","type":"User","site_admin":false},"body":"The hardcoded PIDs may end their availability.","created_at":"2018-09-04T13:09:36Z","updated_at":"2018-09-04T13:09:36Z","html_url":"https://github.com/bbc/programmes-frontend/pull/717#discussion_r214906501","pull_request_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/717","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments/214906501"},"html":{"href":"https://github.com/bbc/programmes-frontend/pull/717#discussion_r214906501"},"pull_request":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/717"}},"in_reply_to_id":214884630},"pull_request":{"url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/717","id":212008025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDA4MDI1","html_url":"https://github.com/bbc/programmes-frontend/pull/717","diff_url":"https://github.com/bbc/programmes-frontend/pull/717.diff","patch_url":"https://github.com/bbc/programmes-frontend/pull/717.patch","issue_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/717","number":717,"state":"open","locked":false,"title":"PROGRAMMES-6598 CTA Presenter","user":{"login":"votemike","id":3957065,"node_id":"MDQ6VXNlcjM5NTcwNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3957065?v=4","gravatar_id":"","url":"https://api.github.com/users/votemike","html_url":"https://github.com/votemike","followers_url":"https://api.github.com/users/votemike/followers","following_url":"https://api.github.com/users/votemike/following{/other_user}","gists_url":"https://api.github.com/users/votemike/gists{/gist_id}","starred_url":"https://api.github.com/users/votemike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/votemike/subscriptions","organizations_url":"https://api.github.com/users/votemike/orgs","repos_url":"https://api.github.com/users/votemike/repos","events_url":"https://api.github.com/users/votemike/events{/privacy}","received_events_url":"https://api.github.com/users/votemike/received_events","type":"User","site_admin":false},"body":"**REVIEW, DON'T APPROVE**\r\n\r\nThis PR creates a DS2013 Presenter for the CTA.\r\nIn the future, hopefully it will encompass the Amen CTAs and the MAP Playout CTA, but for now, it only covers the little square CTAs (and the Watch/Listen Live with those 3 pulsing bars.)\r\n\r\nThe design is white on black (black on white on hover) for everything except iPlayer. So there's no longer any colours from branding in these CTAs, nor are there any transparent backgrounds or anything. These are my choices, not UX or products. Do you agree that these all look OK? Once the team is happy, I'll ask UX. Then we'll hope product doesn't complain.\r\n\r\nPlease review the CTAs and site in general, but also the Styleguide page and make sure it contains all the information you'd like it to contain.\r\n\r\nIn order to test, checkout the branch, run `yarn run gulp` then visit http://sandbox.bbc.co.uk/programmes/styleguide/ds2013/utilities/cta or any of the 2013 pages.\r\n\r\nI don't dare attempt to replicate these CTAs in V2. Is that OK?\r\n\r\nCode TODOs\r\n- [x] Ensure all old CSS is removed\r\n- [x] Ensure all old PHP is removed\r\n- [x] Decide if the template for the Live CTA should extend the CTA template.\r\n- [ ] Once the above is done, write some tests\r\n\r\nSignoff TODOs\r\n- [ ] Get the team to accept the design\r\n- [ ] Put branch on Stage\r\n- [ ] Get Cathal to accept the design\r\n- [ ] Get UX to accept the design","created_at":"2018-08-30T09:11:02Z","updated_at":"2018-09-04T13:09:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f292ef07808bcbc28cd6183abdcf2a235dad176","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/717/commits","review_comments_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/717/comments","review_comment_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/717/comments","statuses_url":"https://api.github.com/repos/bbc/programmes-frontend/statuses/4d7993afda26fe839598eae0cd1e22af213d8b72","head":{"label":"bbc:PROGRAMMES-6598-cta-presenter","ref":"PROGRAMMES-6598-cta-presenter","sha":"4d7993afda26fe839598eae0cd1e22af213d8b72","user":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":85298889,"node_id":"MDEwOlJlcG9zaXRvcnk4NTI5ODg4OQ==","name":"programmes-frontend","full_name":"bbc/programmes-frontend","owner":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bbc/programmes-frontend","description":"The new frontend for bbc.co.uk/programmes","fork":false,"url":"https://api.github.com/repos/bbc/programmes-frontend","forks_url":"https://api.github.com/repos/bbc/programmes-frontend/forks","keys_url":"https://api.github.com/repos/bbc/programmes-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/programmes-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/programmes-frontend/teams","hooks_url":"https://api.github.com/repos/bbc/programmes-frontend/hooks","issue_events_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/programmes-frontend/events","assignees_url":"https://api.github.com/repos/bbc/programmes-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/programmes-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/programmes-frontend/tags","blobs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/programmes-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/programmes-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/programmes-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/programmes-frontend/languages","stargazers_url":"https://api.github.com/repos/bbc/programmes-frontend/stargazers","contributors_url":"https://api.github.com/repos/bbc/programmes-frontend/contributors","subscribers_url":"https://api.github.com/repos/bbc/programmes-frontend/subscribers","subscription_url":"https://api.github.com/repos/bbc/programmes-frontend/subscription","commits_url":"https://api.github.com/repos/bbc/programmes-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/programmes-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/programmes-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/programmes-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/programmes-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/programmes-frontend/merges","archive_url":"https://api.github.com/repos/bbc/programmes-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/programmes-frontend/downloads","issues_url":"https://api.github.com/repos/bbc/programmes-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/programmes-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/programmes-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/programmes-frontend/labels{/name}","releases_url":"https://api.github.com/repos/bbc/programmes-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/programmes-frontend/deployments","created_at":"2017-03-17T10:19:20Z","updated_at":"2018-08-30T10:00:57Z","pushed_at":"2018-09-04T13:05:07Z","git_url":"git://github.com/bbc/programmes-frontend.git","ssh_url":"git@github.com:bbc/programmes-frontend.git","clone_url":"https://github.com/bbc/programmes-frontend.git","svn_url":"https://github.com/bbc/programmes-frontend","homepage":"","size":3818,"stargazers_count":18,"watchers_count":18,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":3,"watchers":18,"default_branch":"develop"}},"base":{"label":"bbc:develop","ref":"develop","sha":"5042b8cb90014b6bff0a01b55f603d37b4859937","user":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":85298889,"node_id":"MDEwOlJlcG9zaXRvcnk4NTI5ODg4OQ==","name":"programmes-frontend","full_name":"bbc/programmes-frontend","owner":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bbc/programmes-frontend","description":"The new frontend for bbc.co.uk/programmes","fork":false,"url":"https://api.github.com/repos/bbc/programmes-frontend","forks_url":"https://api.github.com/repos/bbc/programmes-frontend/forks","keys_url":"https://api.github.com/repos/bbc/programmes-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/programmes-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/programmes-frontend/teams","hooks_url":"https://api.github.com/repos/bbc/programmes-frontend/hooks","issue_events_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/programmes-frontend/events","assignees_url":"https://api.github.com/repos/bbc/programmes-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/programmes-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/programmes-frontend/tags","blobs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/programmes-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/programmes-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/programmes-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/programmes-frontend/languages","stargazers_url":"https://api.github.com/repos/bbc/programmes-frontend/stargazers","contributors_url":"https://api.github.com/repos/bbc/programmes-frontend/contributors","subscribers_url":"https://api.github.com/repos/bbc/programmes-frontend/subscribers","subscription_url":"https://api.github.com/repos/bbc/programmes-frontend/subscription","commits_url":"https://api.github.com/repos/bbc/programmes-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/programmes-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/programmes-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/programmes-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/programmes-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/programmes-frontend/merges","archive_url":"https://api.github.com/repos/bbc/programmes-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/programmes-frontend/downloads","issues_url":"https://api.github.com/repos/bbc/programmes-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/programmes-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/programmes-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/programmes-frontend/labels{/name}","releases_url":"https://api.github.com/repos/bbc/programmes-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/programmes-frontend/deployments","created_at":"2017-03-17T10:19:20Z","updated_at":"2018-08-30T10:00:57Z","pushed_at":"2018-09-04T13:05:07Z","git_url":"git://github.com/bbc/programmes-frontend.git","ssh_url":"git@github.com:bbc/programmes-frontend.git","clone_url":"https://github.com/bbc/programmes-frontend.git","svn_url":"https://github.com/bbc/programmes-frontend","homepage":"","size":3818,"stargazers_count":18,"watchers_count":18,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":3,"watchers":18,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/717"},"html":{"href":"https://github.com/bbc/programmes-frontend/pull/717"},"issue":{"href":"https://api.github.com/repos/bbc/programmes-frontend/issues/717"},"comments":{"href":"https://api.github.com/repos/bbc/programmes-frontend/issues/717/comments"},"review_comments":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/717/comments"},"review_comment":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/717/commits"},"statuses":{"href":"https://api.github.com/repos/bbc/programmes-frontend/statuses/4d7993afda26fe839598eae0cd1e22af213d8b72"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"votemike"}}