{"action":"created","comment":{"url":"https://api.github.com/repos/openfaas/faas/pulls/comments/192259310","pull_request_review_id":125002521,"id":192259310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjI1OTMxMA==","diff_hunk":"@@ -87,11 +88,11 @@ functions:\n     image: functions/api-key-protected:latest\n ```\n \n-Note that unlike the `envVars` in the first example, we do not provide the secret value, just a list of names: `\"secrets\": [\"secret_api_key\"]`. The secret value has already been securely stored in the Docker swarm.  One really great result of this type of configuration is that you can simplify your function code by always referencing the same secret name, no matter the environment, the only change is how the environments are configured.\n+Note that unlike the `envVars` in the first example, we do not provide the secret value, just a list of names: `\"secrets\": [\"secret_api_key\"]`. The secret value has already been securely stored in the Docker swarm. One really great result of this type of configuration is that you can simplify your function code by always referencing the same secret name, no matter the environment, the only change is how the environments are configured.","path":"guide/secure_secret_management.md","position":54,"original_position":54,"commit_id":"d473a2a367f759ba0b0f1831eea93483f29730c5","original_commit_id":"d473a2a367f759ba0b0f1831eea93483f29730c5","user":{"login":"johnmccabe","id":83862,"node_id":"MDQ6VXNlcjgzODYy","avatar_url":"https://avatars3.githubusercontent.com/u/83862?v=4","gravatar_id":"","url":"https://api.github.com/users/johnmccabe","html_url":"https://github.com/johnmccabe","followers_url":"https://api.github.com/users/johnmccabe/followers","following_url":"https://api.github.com/users/johnmccabe/following{/other_user}","gists_url":"https://api.github.com/users/johnmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmccabe/subscriptions","organizations_url":"https://api.github.com/users/johnmccabe/orgs","repos_url":"https://api.github.com/users/johnmccabe/repos","events_url":"https://api.github.com/users/johnmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/johnmccabe/received_events","type":"User","site_admin":false},"body":"<img width=\"115\" alt=\"screen shot 2018-05-31 at 23 49 56\" src=\"https://user-images.githubusercontent.com/83862/40812360-5f359afe-652d-11e8-9a51-5f384ef0331d.png\">\r\n","created_at":"2018-05-31T22:50:20Z","updated_at":"2018-05-31T22:50:21Z","html_url":"https://github.com/openfaas/faas/pull/702#discussion_r192259310","pull_request_url":"https://api.github.com/repos/openfaas/faas/pulls/702","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openfaas/faas/pulls/comments/192259310"},"html":{"href":"https://github.com/openfaas/faas/pull/702#discussion_r192259310"},"pull_request":{"href":"https://api.github.com/repos/openfaas/faas/pulls/702"}},"in_reply_to_id":191043505},"pull_request":{"url":"https://api.github.com/repos/openfaas/faas/pulls/702","id":190731513,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNzMxNTEz","html_url":"https://github.com/openfaas/faas/pull/702","diff_url":"https://github.com/openfaas/faas/pull/702.diff","patch_url":"https://github.com/openfaas/faas/pull/702.patch","issue_url":"https://api.github.com/repos/openfaas/faas/issues/702","number":702,"state":"open","locked":false,"title":"Update secret docs and sample-functions","user":{"login":"LucasRoesler","id":891889,"node_id":"MDQ6VXNlcjg5MTg4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/891889?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasRoesler","html_url":"https://github.com/LucasRoesler","followers_url":"https://api.github.com/users/LucasRoesler/followers","following_url":"https://api.github.com/users/LucasRoesler/following{/other_user}","gists_url":"https://api.github.com/users/LucasRoesler/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasRoesler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasRoesler/subscriptions","organizations_url":"https://api.github.com/users/LucasRoesler/orgs","repos_url":"https://api.github.com/users/LucasRoesler/repos","events_url":"https://api.github.com/users/LucasRoesler/events{/privacy}","received_events_url":"https://api.github.com/users/LucasRoesler/received_events","type":"User","site_admin":false},"body":"\r\n## Description\r\n- Update the documentation about secret management to note the changed\r\nfile location\r\n- Remove the documentation on secret rotation, because this will not\r\ncurrently work\r\n- Update apikey-secret and ApiKeyProtected-Secrets to read secret values\r\nfrom both the old and the new locations\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n- [x] I have raised an issue to propose this change ([required](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md))\r\n\r\nRecent updates to faas-swarm and faas-netes changed the mount location\r\nof secrets to implement #692.  These changes update the docs to reflect this change.\r\n\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [x] I've read the [CONTRIBUTION](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md) guide\r\n- [x] I have signed-off my commits with `git commit -s`\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n","created_at":"2018-05-26T08:10:42Z","updated_at":"2018-05-31T22:50:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"272183cb9b633945b57a072bdf2c63e733d4edb6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openfaas/faas/pulls/702/commits","review_comments_url":"https://api.github.com/repos/openfaas/faas/pulls/702/comments","review_comment_url":"https://api.github.com/repos/openfaas/faas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openfaas/faas/issues/702/comments","statuses_url":"https://api.github.com/repos/openfaas/faas/statuses/d473a2a367f759ba0b0f1831eea93483f29730c5","head":{"label":"LucasRoesler:feature-update-secrets-documentation-and-examples","ref":"feature-update-secrets-documentation-and-examples","sha":"d473a2a367f759ba0b0f1831eea93483f29730c5","user":{"login":"LucasRoesler","id":891889,"node_id":"MDQ6VXNlcjg5MTg4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/891889?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasRoesler","html_url":"https://github.com/LucasRoesler","followers_url":"https://api.github.com/users/LucasRoesler/followers","following_url":"https://api.github.com/users/LucasRoesler/following{/other_user}","gists_url":"https://api.github.com/users/LucasRoesler/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasRoesler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasRoesler/subscriptions","organizations_url":"https://api.github.com/users/LucasRoesler/orgs","repos_url":"https://api.github.com/users/LucasRoesler/repos","events_url":"https://api.github.com/users/LucasRoesler/events{/privacy}","received_events_url":"https://api.github.com/users/LucasRoesler/received_events","type":"User","site_admin":false},"repo":{"id":104458868,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ0NTg4Njg=","name":"faas","full_name":"LucasRoesler/faas","owner":{"login":"LucasRoesler","id":891889,"node_id":"MDQ6VXNlcjg5MTg4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/891889?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasRoesler","html_url":"https://github.com/LucasRoesler","followers_url":"https://api.github.com/users/LucasRoesler/followers","following_url":"https://api.github.com/users/LucasRoesler/following{/other_user}","gists_url":"https://api.github.com/users/LucasRoesler/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasRoesler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasRoesler/subscriptions","organizations_url":"https://api.github.com/users/LucasRoesler/orgs","repos_url":"https://api.github.com/users/LucasRoesler/repos","events_url":"https://api.github.com/users/LucasRoesler/events{/privacy}","received_events_url":"https://api.github.com/users/LucasRoesler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LucasRoesler/faas","description":"Functions as a Service (OpenFaaS) - a serverless framework for Docker & Kubernetes","fork":true,"url":"https://api.github.com/repos/LucasRoesler/faas","forks_url":"https://api.github.com/repos/LucasRoesler/faas/forks","keys_url":"https://api.github.com/repos/LucasRoesler/faas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LucasRoesler/faas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LucasRoesler/faas/teams","hooks_url":"https://api.github.com/repos/LucasRoesler/faas/hooks","issue_events_url":"https://api.github.com/repos/LucasRoesler/faas/issues/events{/number}","events_url":"https://api.github.com/repos/LucasRoesler/faas/events","assignees_url":"https://api.github.com/repos/LucasRoesler/faas/assignees{/user}","branches_url":"https://api.github.com/repos/LucasRoesler/faas/branches{/branch}","tags_url":"https://api.github.com/repos/LucasRoesler/faas/tags","blobs_url":"https://api.github.com/repos/LucasRoesler/faas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LucasRoesler/faas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LucasRoesler/faas/git/refs{/sha}","trees_url":"https://api.github.com/repos/LucasRoesler/faas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LucasRoesler/faas/statuses/{sha}","languages_url":"https://api.github.com/repos/LucasRoesler/faas/languages","stargazers_url":"https://api.github.com/repos/LucasRoesler/faas/stargazers","contributors_url":"https://api.github.com/repos/LucasRoesler/faas/contributors","subscribers_url":"https://api.github.com/repos/LucasRoesler/faas/subscribers","subscription_url":"https://api.github.com/repos/LucasRoesler/faas/subscription","commits_url":"https://api.github.com/repos/LucasRoesler/faas/commits{/sha}","git_commits_url":"https://api.github.com/repos/LucasRoesler/faas/git/commits{/sha}","comments_url":"https://api.github.com/repos/LucasRoesler/faas/comments{/number}","issue_comment_url":"https://api.github.com/repos/LucasRoesler/faas/issues/comments{/number}","contents_url":"https://api.github.com/repos/LucasRoesler/faas/contents/{+path}","compare_url":"https://api.github.com/repos/LucasRoesler/faas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LucasRoesler/faas/merges","archive_url":"https://api.github.com/repos/LucasRoesler/faas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LucasRoesler/faas/downloads","issues_url":"https://api.github.com/repos/LucasRoesler/faas/issues{/number}","pulls_url":"https://api.github.com/repos/LucasRoesler/faas/pulls{/number}","milestones_url":"https://api.github.com/repos/LucasRoesler/faas/milestones{/number}","notifications_url":"https://api.github.com/repos/LucasRoesler/faas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LucasRoesler/faas/labels{/name}","releases_url":"https://api.github.com/repos/LucasRoesler/faas/releases{/id}","deployments_url":"https://api.github.com/repos/LucasRoesler/faas/deployments","created_at":"2017-09-22T09:47:34Z","updated_at":"2018-05-23T12:41:55Z","pushed_at":"2018-05-26T08:07:10Z","git_url":"git://github.com/LucasRoesler/faas.git","ssh_url":"git@github.com:LucasRoesler/faas.git","clone_url":"https://github.com/LucasRoesler/faas.git","svn_url":"https://github.com/LucasRoesler/faas","homepage":"https://blog.alexellis.io/introducing-functions-as-a-service/","size":22251,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openfaas:master","ref":"master","sha":"ab2aa14c4837626ddfef406a2c9ed5903f7b4e8a","user":{"login":"openfaas","id":27013154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDEzMTU0","avatar_url":"https://avatars3.githubusercontent.com/u/27013154?v=4","gravatar_id":"","url":"https://api.github.com/users/openfaas","html_url":"https://github.com/openfaas","followers_url":"https://api.github.com/users/openfaas/followers","following_url":"https://api.github.com/users/openfaas/following{/other_user}","gists_url":"https://api.github.com/users/openfaas/gists{/gist_id}","starred_url":"https://api.github.com/users/openfaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfaas/subscriptions","organizations_url":"https://api.github.com/users/openfaas/orgs","repos_url":"https://api.github.com/users/openfaas/repos","events_url":"https://api.github.com/users/openfaas/events{/privacy}","received_events_url":"https://api.github.com/users/openfaas/received_events","type":"Organization","site_admin":false},"repo":{"id":77144337,"node_id":"MDEwOlJlcG9zaXRvcnk3NzE0NDMzNw==","name":"faas","full_name":"openfaas/faas","owner":{"login":"openfaas","id":27013154,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDEzMTU0","avatar_url":"https://avatars3.githubusercontent.com/u/27013154?v=4","gravatar_id":"","url":"https://api.github.com/users/openfaas","html_url":"https://github.com/openfaas","followers_url":"https://api.github.com/users/openfaas/followers","following_url":"https://api.github.com/users/openfaas/following{/other_user}","gists_url":"https://api.github.com/users/openfaas/gists{/gist_id}","starred_url":"https://api.github.com/users/openfaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfaas/subscriptions","organizations_url":"https://api.github.com/users/openfaas/orgs","repos_url":"https://api.github.com/users/openfaas/repos","events_url":"https://api.github.com/users/openfaas/events{/privacy}","received_events_url":"https://api.github.com/users/openfaas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openfaas/faas","description":"OpenFaaS - Serverless Functions Made Simple for Docker & Kubernetes","fork":false,"url":"https://api.github.com/repos/openfaas/faas","forks_url":"https://api.github.com/repos/openfaas/faas/forks","keys_url":"https://api.github.com/repos/openfaas/faas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openfaas/faas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openfaas/faas/teams","hooks_url":"https://api.github.com/repos/openfaas/faas/hooks","issue_events_url":"https://api.github.com/repos/openfaas/faas/issues/events{/number}","events_url":"https://api.github.com/repos/openfaas/faas/events","assignees_url":"https://api.github.com/repos/openfaas/faas/assignees{/user}","branches_url":"https://api.github.com/repos/openfaas/faas/branches{/branch}","tags_url":"https://api.github.com/repos/openfaas/faas/tags","blobs_url":"https://api.github.com/repos/openfaas/faas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openfaas/faas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openfaas/faas/git/refs{/sha}","trees_url":"https://api.github.com/repos/openfaas/faas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openfaas/faas/statuses/{sha}","languages_url":"https://api.github.com/repos/openfaas/faas/languages","stargazers_url":"https://api.github.com/repos/openfaas/faas/stargazers","contributors_url":"https://api.github.com/repos/openfaas/faas/contributors","subscribers_url":"https://api.github.com/repos/openfaas/faas/subscribers","subscription_url":"https://api.github.com/repos/openfaas/faas/subscription","commits_url":"https://api.github.com/repos/openfaas/faas/commits{/sha}","git_commits_url":"https://api.github.com/repos/openfaas/faas/git/commits{/sha}","comments_url":"https://api.github.com/repos/openfaas/faas/comments{/number}","issue_comment_url":"https://api.github.com/repos/openfaas/faas/issues/comments{/number}","contents_url":"https://api.github.com/repos/openfaas/faas/contents/{+path}","compare_url":"https://api.github.com/repos/openfaas/faas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openfaas/faas/merges","archive_url":"https://api.github.com/repos/openfaas/faas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openfaas/faas/downloads","issues_url":"https://api.github.com/repos/openfaas/faas/issues{/number}","pulls_url":"https://api.github.com/repos/openfaas/faas/pulls{/number}","milestones_url":"https://api.github.com/repos/openfaas/faas/milestones{/number}","notifications_url":"https://api.github.com/repos/openfaas/faas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openfaas/faas/labels{/name}","releases_url":"https://api.github.com/repos/openfaas/faas/releases{/id}","deployments_url":"https://api.github.com/repos/openfaas/faas/deployments","created_at":"2016-12-22T12:51:39Z","updated_at":"2018-05-31T21:45:33Z","pushed_at":"2018-05-30T23:01:07Z","git_url":"git://github.com/openfaas/faas.git","ssh_url":"git@github.com:openfaas/faas.git","clone_url":"https://github.com/openfaas/faas.git","svn_url":"https://github.com/openfaas/faas","homepage":"https://blog.alexellis.io/introducing-functions-as-a-service/","size":22132,"stargazers_count":10278,"watchers_count":10278,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":726,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":726,"open_issues":98,"watchers":10278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openfaas/faas/pulls/702"},"html":{"href":"https://github.com/openfaas/faas/pull/702"},"issue":{"href":"https://api.github.com/repos/openfaas/faas/issues/702"},"comments":{"href":"https://api.github.com/repos/openfaas/faas/issues/702/comments"},"review_comments":{"href":"https://api.github.com/repos/openfaas/faas/pulls/702/comments"},"review_comment":{"href":"https://api.github.com/repos/openfaas/faas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openfaas/faas/pulls/702/commits"},"statuses":{"href":"https://api.github.com/repos/openfaas/faas/statuses/d473a2a367f759ba0b0f1831eea93483f29730c5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"johnmccabe"}}