{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments/213630956","pull_request_review_id":150505280,"id":213630956,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzYzMDk1Ng==","diff_hunk":"@@ -148,7 +160,11 @@ public override bool CanWrite\n \n         public override long Length\n         {\n-            get { return _buffer.Length; }\n+            get\n+            {\n+                var useInnerLength = _innerLength.HasValue && _innerLength > 0 && !_completelyBuffered && _buffer.Position == 0;","path":"src/Microsoft.AspNetCore.WebUtilities/FileBufferingReadStream.cs","position":33,"original_position":42,"commit_id":"3f55345707a64fb41599a2cbfc1e3bd2fa51a743","original_commit_id":"72ffb0b4f3ee05a54914154796c92210e7bca8bb","user":{"login":"Tratcher","id":1821173,"node_id":"MDQ6VXNlcjE4MjExNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1821173?v=4","gravatar_id":"","url":"https://api.github.com/users/Tratcher","html_url":"https://github.com/Tratcher","followers_url":"https://api.github.com/users/Tratcher/followers","following_url":"https://api.github.com/users/Tratcher/following{/other_user}","gists_url":"https://api.github.com/users/Tratcher/gists{/gist_id}","starred_url":"https://api.github.com/users/Tratcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tratcher/subscriptions","organizations_url":"https://api.github.com/users/Tratcher/orgs","repos_url":"https://api.github.com/users/Tratcher/repos","events_url":"https://api.github.com/users/Tratcher/events{/privacy}","received_events_url":"https://api.github.com/users/Tratcher/received_events","type":"User","site_admin":false},"body":"Which? Maybe they should be updated instead, this is a behaviour change.","created_at":"2018-08-29T10:53:39Z","updated_at":"2018-08-29T10:53:39Z","html_url":"https://github.com/aspnet/HttpAbstractions/pull/1032#discussion_r213630956","pull_request_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/1032","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments/213630956"},"html":{"href":"https://github.com/aspnet/HttpAbstractions/pull/1032#discussion_r213630956"},"pull_request":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/1032"}},"in_reply_to_id":213389406},"pull_request":{"url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/1032","id":210933145,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTMzMTQ1","html_url":"https://github.com/aspnet/HttpAbstractions/pull/1032","diff_url":"https://github.com/aspnet/HttpAbstractions/pull/1032.diff","patch_url":"https://github.com/aspnet/HttpAbstractions/pull/1032.patch","issue_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/1032","number":1032,"state":"open","locked":false,"title":"Fix FileBufferingReadStream not working with StreamContent","user":{"login":"cnblogs-dudu","id":3196961,"node_id":"MDQ6VXNlcjMxOTY5NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/3196961?v=4","gravatar_id":"","url":"https://api.github.com/users/cnblogs-dudu","html_url":"https://github.com/cnblogs-dudu","followers_url":"https://api.github.com/users/cnblogs-dudu/followers","following_url":"https://api.github.com/users/cnblogs-dudu/following{/other_user}","gists_url":"https://api.github.com/users/cnblogs-dudu/gists{/gist_id}","starred_url":"https://api.github.com/users/cnblogs-dudu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnblogs-dudu/subscriptions","organizations_url":"https://api.github.com/users/cnblogs-dudu/orgs","repos_url":"https://api.github.com/users/cnblogs-dudu/repos","events_url":"https://api.github.com/users/cnblogs-dudu/events{/privacy}","received_events_url":"https://api.github.com/users/cnblogs-dudu/received_events","type":"User","site_admin":false},"body":"Address dotnet/corefx#31866\r\n\r\nBefore FileBufferingReadStream is first read, it's length is not properly set. Before StreamContent is read, it's inner stream length is used to compute ContentLength. When they get together in HttpClient, an http request with misleading `Content-Length: 0` is produced.\r\n\r\nThis PR introduces `_innerLength` to return the length of inner stream before FileBufferingReadStream is first read.","created_at":"2018-08-26T04:10:57Z","updated_at":"2018-08-29T10:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07e4f0f24f21953fd4bcd9196e025341902b75e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/1032/commits","review_comments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/1032/comments","review_comment_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/1032/comments","statuses_url":"https://api.github.com/repos/aspnet/HttpAbstractions/statuses/3f55345707a64fb41599a2cbfc1e3bd2fa51a743","head":{"label":"cnblogs-dudu:improve-filebufferingreadstream-length","ref":"improve-filebufferingreadstream-length","sha":"3f55345707a64fb41599a2cbfc1e3bd2fa51a743","user":{"login":"cnblogs-dudu","id":3196961,"node_id":"MDQ6VXNlcjMxOTY5NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/3196961?v=4","gravatar_id":"","url":"https://api.github.com/users/cnblogs-dudu","html_url":"https://github.com/cnblogs-dudu","followers_url":"https://api.github.com/users/cnblogs-dudu/followers","following_url":"https://api.github.com/users/cnblogs-dudu/following{/other_user}","gists_url":"https://api.github.com/users/cnblogs-dudu/gists{/gist_id}","starred_url":"https://api.github.com/users/cnblogs-dudu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnblogs-dudu/subscriptions","organizations_url":"https://api.github.com/users/cnblogs-dudu/orgs","repos_url":"https://api.github.com/users/cnblogs-dudu/repos","events_url":"https://api.github.com/users/cnblogs-dudu/events{/privacy}","received_events_url":"https://api.github.com/users/cnblogs-dudu/received_events","type":"User","site_admin":false},"repo":{"id":146076698,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwNzY2OTg=","name":"HttpAbstractions","full_name":"cnblogs-dudu/HttpAbstractions","owner":{"login":"cnblogs-dudu","id":3196961,"node_id":"MDQ6VXNlcjMxOTY5NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/3196961?v=4","gravatar_id":"","url":"https://api.github.com/users/cnblogs-dudu","html_url":"https://github.com/cnblogs-dudu","followers_url":"https://api.github.com/users/cnblogs-dudu/followers","following_url":"https://api.github.com/users/cnblogs-dudu/following{/other_user}","gists_url":"https://api.github.com/users/cnblogs-dudu/gists{/gist_id}","starred_url":"https://api.github.com/users/cnblogs-dudu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnblogs-dudu/subscriptions","organizations_url":"https://api.github.com/users/cnblogs-dudu/orgs","repos_url":"https://api.github.com/users/cnblogs-dudu/repos","events_url":"https://api.github.com/users/cnblogs-dudu/events{/privacy}","received_events_url":"https://api.github.com/users/cnblogs-dudu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cnblogs-dudu/HttpAbstractions","description":"HTTP abstractions such as HttpRequest, HttpResponse, and HttpContext, as well as common web utilities.","fork":true,"url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions","forks_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/forks","keys_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/teams","hooks_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/hooks","issue_events_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/issues/events{/number}","events_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/events","assignees_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/assignees{/user}","branches_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/branches{/branch}","tags_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/tags","blobs_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/git/refs{/sha}","trees_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/statuses/{sha}","languages_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/languages","stargazers_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/stargazers","contributors_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/contributors","subscribers_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/subscribers","subscription_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/subscription","commits_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/commits{/sha}","git_commits_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/git/commits{/sha}","comments_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/comments{/number}","issue_comment_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/issues/comments{/number}","contents_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/contents/{+path}","compare_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/merges","archive_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/downloads","issues_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/issues{/number}","pulls_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/pulls{/number}","milestones_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/milestones{/number}","notifications_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/labels{/name}","releases_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/releases{/id}","deployments_url":"https://api.github.com/repos/cnblogs-dudu/HttpAbstractions/deployments","created_at":"2018-08-25T07:50:48Z","updated_at":"2018-08-25T14:10:16Z","pushed_at":"2018-08-29T09:55:04Z","git_url":"git://github.com/cnblogs-dudu/HttpAbstractions.git","ssh_url":"git@github.com:cnblogs-dudu/HttpAbstractions.git","clone_url":"https://github.com/cnblogs-dudu/HttpAbstractions.git","svn_url":"https://github.com/cnblogs-dudu/HttpAbstractions","homepage":"","size":3327,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aspnet:release/2.2","ref":"release/2.2","sha":"f3dc2d069c0c1ee756fbf416be35eae5ae904cda","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15320915,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyMDkxNQ==","name":"HttpAbstractions","full_name":"aspnet/HttpAbstractions","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/HttpAbstractions","description":"HTTP abstractions such as HttpRequest, HttpResponse, and HttpContext, as well as common web utilities.","fork":false,"url":"https://api.github.com/repos/aspnet/HttpAbstractions","forks_url":"https://api.github.com/repos/aspnet/HttpAbstractions/forks","keys_url":"https://api.github.com/repos/aspnet/HttpAbstractions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/HttpAbstractions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/HttpAbstractions/teams","hooks_url":"https://api.github.com/repos/aspnet/HttpAbstractions/hooks","issue_events_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/HttpAbstractions/events","assignees_url":"https://api.github.com/repos/aspnet/HttpAbstractions/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/HttpAbstractions/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/HttpAbstractions/tags","blobs_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/HttpAbstractions/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/HttpAbstractions/languages","stargazers_url":"https://api.github.com/repos/aspnet/HttpAbstractions/stargazers","contributors_url":"https://api.github.com/repos/aspnet/HttpAbstractions/contributors","subscribers_url":"https://api.github.com/repos/aspnet/HttpAbstractions/subscribers","subscription_url":"https://api.github.com/repos/aspnet/HttpAbstractions/subscription","commits_url":"https://api.github.com/repos/aspnet/HttpAbstractions/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/HttpAbstractions/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/HttpAbstractions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/HttpAbstractions/merges","archive_url":"https://api.github.com/repos/aspnet/HttpAbstractions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/HttpAbstractions/downloads","issues_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/HttpAbstractions/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/HttpAbstractions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/HttpAbstractions/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/HttpAbstractions/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/deployments","created_at":"2013-12-19T19:38:45Z","updated_at":"2018-08-29T05:07:20Z","pushed_at":"2018-08-29T09:55:05Z","git_url":"git://github.com/aspnet/HttpAbstractions.git","ssh_url":"git@github.com:aspnet/HttpAbstractions.git","clone_url":"https://github.com/aspnet/HttpAbstractions.git","svn_url":"https://github.com/aspnet/HttpAbstractions","homepage":"","size":3325,"stargazers_count":333,"watchers_count":333,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":181,"open_issues":10,"watchers":333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/1032"},"html":{"href":"https://github.com/aspnet/HttpAbstractions/pull/1032"},"issue":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/1032"},"comments":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/1032/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/1032/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/1032/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/statuses/3f55345707a64fb41599a2cbfc1e3bd2fa51a743"}},"author_association":"NONE"}}
{"actor":{"display_login":"Tratcher"}}