{"action":"closed","number":3196,"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/3196","id":238978928,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTc4OTI4","html_url":"https://github.com/apache/arrow/pull/3196","diff_url":"https://github.com/apache/arrow/pull/3196.diff","patch_url":"https://github.com/apache/arrow/pull/3196.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/3196","number":3196,"state":"closed","locked":false,"title":"ARROW-4049: [C++] Arrow never use glog even though glog is linked.","user":{"login":"sarutak","id":4736016,"node_id":"MDQ6VXNlcjQ3MzYwMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4736016?v=4","gravatar_id":"","url":"https://api.github.com/users/sarutak","html_url":"https://github.com/sarutak","followers_url":"https://api.github.com/users/sarutak/followers","following_url":"https://api.github.com/users/sarutak/following{/other_user}","gists_url":"https://api.github.com/users/sarutak/gists{/gist_id}","starred_url":"https://api.github.com/users/sarutak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarutak/subscriptions","organizations_url":"https://api.github.com/users/sarutak/orgs","repos_url":"https://api.github.com/users/sarutak/repos","events_url":"https://api.github.com/users/sarutak/events{/privacy}","received_events_url":"https://api.github.com/users/sarutak/received_events","type":"User","site_admin":false},"body":"The following is a part of arrow/util/logging.cc.\r\n\r\n```\r\n#ifdef ARROW_USE_GLOG\r\ntypedef google::LogMessage LoggingProvider;\r\n#else\r\ntypedef CerrLog LoggingProvider;\r\n#endif\r\n```\r\n\r\nAs you see, when ARROW_USE_GLOG is defined, glog is intended to be used but it's not never defined and glog is never used.\r\n\r\nI've fixed this by adding `add_definition` command when  CMake variable `ARROW_USE_GLOG` is ON.","created_at":"2018-12-16T17:23:29Z","updated_at":"2018-12-16T20:02:07Z","closed_at":"2018-12-16T20:02:07Z","merged_at":null,"merge_commit_sha":"f77030e2754c4b2b601abe8ec62fdbe3143c7e3b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/3196/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/3196/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/3196/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/87be741618d6cbfbf95f31236d865723a4de58c9","head":{"label":"sarutak:arrow-use-glog","ref":"arrow-use-glog","sha":"87be741618d6cbfbf95f31236d865723a4de58c9","user":{"login":"sarutak","id":4736016,"node_id":"MDQ6VXNlcjQ3MzYwMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4736016?v=4","gravatar_id":"","url":"https://api.github.com/users/sarutak","html_url":"https://github.com/sarutak","followers_url":"https://api.github.com/users/sarutak/followers","following_url":"https://api.github.com/users/sarutak/following{/other_user}","gists_url":"https://api.github.com/users/sarutak/gists{/gist_id}","starred_url":"https://api.github.com/users/sarutak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarutak/subscriptions","organizations_url":"https://api.github.com/users/sarutak/orgs","repos_url":"https://api.github.com/users/sarutak/repos","events_url":"https://api.github.com/users/sarutak/events{/privacy}","received_events_url":"https://api.github.com/users/sarutak/received_events","type":"User","site_admin":false},"repo":{"id":74099040,"node_id":"MDEwOlJlcG9zaXRvcnk3NDA5OTA0MA==","name":"arrow","full_name":"sarutak/arrow","private":false,"owner":{"login":"sarutak","id":4736016,"node_id":"MDQ6VXNlcjQ3MzYwMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4736016?v=4","gravatar_id":"","url":"https://api.github.com/users/sarutak","html_url":"https://github.com/sarutak","followers_url":"https://api.github.com/users/sarutak/followers","following_url":"https://api.github.com/users/sarutak/following{/other_user}","gists_url":"https://api.github.com/users/sarutak/gists{/gist_id}","starred_url":"https://api.github.com/users/sarutak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarutak/subscriptions","organizations_url":"https://api.github.com/users/sarutak/orgs","repos_url":"https://api.github.com/users/sarutak/repos","events_url":"https://api.github.com/users/sarutak/events{/privacy}","received_events_url":"https://api.github.com/users/sarutak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sarutak/arrow","description":"Mirror of Apache Arrow","fork":true,"url":"https://api.github.com/repos/sarutak/arrow","forks_url":"https://api.github.com/repos/sarutak/arrow/forks","keys_url":"https://api.github.com/repos/sarutak/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarutak/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarutak/arrow/teams","hooks_url":"https://api.github.com/repos/sarutak/arrow/hooks","issue_events_url":"https://api.github.com/repos/sarutak/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/sarutak/arrow/events","assignees_url":"https://api.github.com/repos/sarutak/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/sarutak/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/sarutak/arrow/tags","blobs_url":"https://api.github.com/repos/sarutak/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarutak/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarutak/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarutak/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarutak/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/sarutak/arrow/languages","stargazers_url":"https://api.github.com/repos/sarutak/arrow/stargazers","contributors_url":"https://api.github.com/repos/sarutak/arrow/contributors","subscribers_url":"https://api.github.com/repos/sarutak/arrow/subscribers","subscription_url":"https://api.github.com/repos/sarutak/arrow/subscription","commits_url":"https://api.github.com/repos/sarutak/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarutak/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarutak/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarutak/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarutak/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/sarutak/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarutak/arrow/merges","archive_url":"https://api.github.com/repos/sarutak/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarutak/arrow/downloads","issues_url":"https://api.github.com/repos/sarutak/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/sarutak/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/sarutak/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/sarutak/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarutak/arrow/labels{/name}","releases_url":"https://api.github.com/repos/sarutak/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/sarutak/arrow/deployments","created_at":"2016-11-18T05:44:45Z","updated_at":"2016-11-18T05:44:47Z","pushed_at":"2018-12-16T17:21:33Z","git_url":"git://github.com/sarutak/arrow.git","ssh_url":"git@github.com:sarutak/arrow.git","clone_url":"https://github.com/sarutak/arrow.git","svn_url":"https://github.com/sarutak/arrow","homepage":null,"size":22309,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ac047b2fd2893b711116bf8c6b7df8b60c6dd8e3","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"node_id":"MDEwOlJlcG9zaXRvcnk1MTkwNTM1Mw==","name":"arrow","full_name":"apache/arrow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2018-12-16T13:59:09Z","pushed_at":"2018-12-16T20:01:56Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"git@github.com:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":"https://arrow.apache.org","size":22303,"stargazers_count":2925,"watchers_count":2925,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":747,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":747,"open_issues":78,"watchers":2925,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/3196"},"html":{"href":"https://github.com/apache/arrow/pull/3196"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/3196"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/3196/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/3196/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/3196/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/87be741618d6cbfbf95f31236d865723a4de58c9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"wesm"}}