{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments/168212011","pull_request_review_id":96542091,"id":168212011,"diff_hunk":"@@ -112,14 +111,20 @@ this.HighlightsFeed = class HighlightsFeed {\n         this.fetchImage(page);\n       }\n \n+      // When we bookmark something it adds a history entry - so adjust the type","path":"system-addon/lib/HighlightsFeed.jsm","position":25,"original_position":25,"commit_id":"1af05e2e7c3eaa28e871d5ea3af4f2ca41002b1a","original_commit_id":"1af05e2e7c3eaa28e871d5ea3af4f2ca41002b1a","user":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"body":"These were my steps to reproduce for this that caused me to write this comment (on a clean profile):\r\n1. Bookmark a trending pocket story from the context menu\r\n2. Open debugger and set a breakpoint in HighlightsFeed.jsm right after we dedupe against top sites\r\n3. Force a refresh in Higlights (I dismissed another trending story)\r\n4. Observe ```this.store.getState().TopSites.rows``` and see that the first item in the array is the bookmarked trending story with type 'history' ... even though I've never actually visited it.\r\n\r\nSo it's a bit confusing that it's there even though I never actually visited the page. How about \"Adjust the type for 'history' items that are also 'bookmarked'\" for the comment?\r\n","created_at":"2018-02-14T15:36:55Z","updated_at":"2018-02-14T15:36:55Z","html_url":"https://github.com/mozilla/activity-stream/pull/3975#discussion_r168212011","pull_request_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/3975","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments/168212011"},"html":{"href":"https://github.com/mozilla/activity-stream/pull/3975#discussion_r168212011"},"pull_request":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/3975"}},"in_reply_to_id":168011813},"pull_request":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/3975","id":167735302,"html_url":"https://github.com/mozilla/activity-stream/pull/3975","diff_url":"https://github.com/mozilla/activity-stream/pull/3975.diff","patch_url":"https://github.com/mozilla/activity-stream/pull/3975.patch","issue_url":"https://api.github.com/repos/mozilla/activity-stream/issues/3975","number":3975,"state":"open","locked":false,"title":"Fix Bug 1432657 - Add pocket card type to highlight types","user":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"body":"1. Allows Pocket items to be shown in highlights\r\n2. Adds a \"remove from pocket list\" option in context menu (includes string + icon)\r\n3. Adds functionality to actually remove the item from the pocket list via context menu\r\n4. Adds a \"saved to pocket\" highlight  context  type (includes string + small version of regular pocket icon)\r\n5. Preemptively updates UI when removing a pocket item via the reducer \r\n\r\nHas the same behaviour as when you bookmark a trending story - update the card itself then next time you refresh it shows it in the highlights section\r\n","created_at":"2018-02-07T16:05:41Z","updated_at":"2018-02-14T15:36:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"646f1cbde61fb4f970ae0cbe686228e9ff1224a3","assignee":{"login":"Mardak","id":438537,"avatar_url":"https://avatars0.githubusercontent.com/u/438537?v=4","gravatar_id":"","url":"https://api.github.com/users/Mardak","html_url":"https://github.com/Mardak","followers_url":"https://api.github.com/users/Mardak/followers","following_url":"https://api.github.com/users/Mardak/following{/other_user}","gists_url":"https://api.github.com/users/Mardak/gists{/gist_id}","starred_url":"https://api.github.com/users/Mardak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mardak/subscriptions","organizations_url":"https://api.github.com/users/Mardak/orgs","repos_url":"https://api.github.com/users/Mardak/repos","events_url":"https://api.github.com/users/Mardak/events{/privacy}","received_events_url":"https://api.github.com/users/Mardak/received_events","type":"User","site_admin":false},"assignees":[{"login":"Mardak","id":438537,"avatar_url":"https://avatars0.githubusercontent.com/u/438537?v=4","gravatar_id":"","url":"https://api.github.com/users/Mardak","html_url":"https://github.com/Mardak","followers_url":"https://api.github.com/users/Mardak/followers","following_url":"https://api.github.com/users/Mardak/following{/other_user}","gists_url":"https://api.github.com/users/Mardak/gists{/gist_id}","starred_url":"https://api.github.com/users/Mardak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mardak/subscriptions","organizations_url":"https://api.github.com/users/Mardak/orgs","repos_url":"https://api.github.com/users/Mardak/repos","events_url":"https://api.github.com/users/Mardak/events{/privacy}","received_events_url":"https://api.github.com/users/Mardak/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":334509354,"url":"https://api.github.com/repos/mozilla/activity-stream/labels/PR%20/%20Needs%20review","name":"PR / Needs review","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/3975/commits","review_comments_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/3975/comments","review_comment_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/issues/3975/comments","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/1af05e2e7c3eaa28e871d5ea3af4f2ca41002b1a","head":{"label":"sarracini:bug_1432657","ref":"bug_1432657","sha":"1af05e2e7c3eaa28e871d5ea3af4f2ca41002b1a","user":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"repo":{"id":63179383,"name":"activity-stream","full_name":"sarracini/activity-stream","owner":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarracini/activity-stream","description":" MVP prototype add-on for activity streams","fork":true,"url":"https://api.github.com/repos/sarracini/activity-stream","forks_url":"https://api.github.com/repos/sarracini/activity-stream/forks","keys_url":"https://api.github.com/repos/sarracini/activity-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarracini/activity-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarracini/activity-stream/teams","hooks_url":"https://api.github.com/repos/sarracini/activity-stream/hooks","issue_events_url":"https://api.github.com/repos/sarracini/activity-stream/issues/events{/number}","events_url":"https://api.github.com/repos/sarracini/activity-stream/events","assignees_url":"https://api.github.com/repos/sarracini/activity-stream/assignees{/user}","branches_url":"https://api.github.com/repos/sarracini/activity-stream/branches{/branch}","tags_url":"https://api.github.com/repos/sarracini/activity-stream/tags","blobs_url":"https://api.github.com/repos/sarracini/activity-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarracini/activity-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarracini/activity-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarracini/activity-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarracini/activity-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/sarracini/activity-stream/languages","stargazers_url":"https://api.github.com/repos/sarracini/activity-stream/stargazers","contributors_url":"https://api.github.com/repos/sarracini/activity-stream/contributors","subscribers_url":"https://api.github.com/repos/sarracini/activity-stream/subscribers","subscription_url":"https://api.github.com/repos/sarracini/activity-stream/subscription","commits_url":"https://api.github.com/repos/sarracini/activity-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarracini/activity-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarracini/activity-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarracini/activity-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarracini/activity-stream/contents/{+path}","compare_url":"https://api.github.com/repos/sarracini/activity-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarracini/activity-stream/merges","archive_url":"https://api.github.com/repos/sarracini/activity-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarracini/activity-stream/downloads","issues_url":"https://api.github.com/repos/sarracini/activity-stream/issues{/number}","pulls_url":"https://api.github.com/repos/sarracini/activity-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/sarracini/activity-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/sarracini/activity-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarracini/activity-stream/labels{/name}","releases_url":"https://api.github.com/repos/sarracini/activity-stream/releases{/id}","deployments_url":"https://api.github.com/repos/sarracini/activity-stream/deployments","created_at":"2016-07-12T17:38:50Z","updated_at":"2016-07-12T17:38:52Z","pushed_at":"2018-02-13T18:21:28Z","git_url":"git://github.com/sarracini/activity-stream.git","ssh_url":"git@github.com:sarracini/activity-stream.git","clone_url":"https://github.com/sarracini/activity-stream.git","svn_url":"https://github.com/sarracini/activity-stream","homepage":"","size":7923,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"bcd5d2258600fad6dd3cf8951485b4b19203e955","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":50695589,"name":"activity-stream","full_name":"mozilla/activity-stream","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/activity-stream","description":"A refreshed \"new tab page\" for Firefox","fork":false,"url":"https://api.github.com/repos/mozilla/activity-stream","forks_url":"https://api.github.com/repos/mozilla/activity-stream/forks","keys_url":"https://api.github.com/repos/mozilla/activity-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/activity-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/activity-stream/teams","hooks_url":"https://api.github.com/repos/mozilla/activity-stream/hooks","issue_events_url":"https://api.github.com/repos/mozilla/activity-stream/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/activity-stream/events","assignees_url":"https://api.github.com/repos/mozilla/activity-stream/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/activity-stream/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/activity-stream/tags","blobs_url":"https://api.github.com/repos/mozilla/activity-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/activity-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/activity-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/activity-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/activity-stream/languages","stargazers_url":"https://api.github.com/repos/mozilla/activity-stream/stargazers","contributors_url":"https://api.github.com/repos/mozilla/activity-stream/contributors","subscribers_url":"https://api.github.com/repos/mozilla/activity-stream/subscribers","subscription_url":"https://api.github.com/repos/mozilla/activity-stream/subscription","commits_url":"https://api.github.com/repos/mozilla/activity-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/activity-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/activity-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/activity-stream/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/activity-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/activity-stream/merges","archive_url":"https://api.github.com/repos/mozilla/activity-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/activity-stream/downloads","issues_url":"https://api.github.com/repos/mozilla/activity-stream/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/activity-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/activity-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/activity-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/activity-stream/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/activity-stream/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/activity-stream/deployments","created_at":"2016-01-29T22:28:26Z","updated_at":"2018-02-06T01:21:15Z","pushed_at":"2018-02-14T01:56:23Z","git_url":"git://github.com/mozilla/activity-stream.git","ssh_url":"git@github.com:mozilla/activity-stream.git","clone_url":"https://github.com/mozilla/activity-stream.git","svn_url":"https://github.com/mozilla/activity-stream","homepage":"","size":8549,"stargazers_count":137,"watchers_count":137,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":85,"open_issues":48,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/3975"},"html":{"href":"https://github.com/mozilla/activity-stream/pull/3975"},"issue":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/3975"},"comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/3975/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/3975/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/3975/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/activity-stream/statuses/1af05e2e7c3eaa28e871d5ea3af4f2ca41002b1a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sarracini"}}