{"action":"created","issue":{"url":"https://api.github.com/repos/terrajobst/minsk/issues/18","repository_url":"https://api.github.com/repos/terrajobst/minsk","labels_url":"https://api.github.com/repos/terrajobst/minsk/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/terrajobst/minsk/issues/18/comments","events_url":"https://api.github.com/repos/terrajobst/minsk/issues/18/events","html_url":"https://github.com/terrajobst/minsk/pull/18","id":376253283,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTEyOTI2","number":18,"title":"Use pattern matching switch statement","user":{"login":"y2k4life","id":10999532,"node_id":"MDQ6VXNlcjEwOTk5NTMy","avatar_url":"https://avatars0.githubusercontent.com/u/10999532?v=4","gravatar_id":"","url":"https://api.github.com/users/y2k4life","html_url":"https://github.com/y2k4life","followers_url":"https://api.github.com/users/y2k4life/followers","following_url":"https://api.github.com/users/y2k4life/following{/other_user}","gists_url":"https://api.github.com/users/y2k4life/gists{/gist_id}","starred_url":"https://api.github.com/users/y2k4life/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y2k4life/subscriptions","organizations_url":"https://api.github.com/users/y2k4life/orgs","repos_url":"https://api.github.com/users/y2k4life/repos","events_url":"https://api.github.com/users/y2k4life/events{/privacy}","received_events_url":"https://api.github.com/users/y2k4life/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-01T04:52:23Z","updated_at":"2018-11-01T21:03:14Z","closed_at":"2018-11-01T07:58:31Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/terrajobst/minsk/pulls/18","html_url":"https://github.com/terrajobst/minsk/pull/18","diff_url":"https://github.com/terrajobst/minsk/pull/18.diff","patch_url":"https://github.com/terrajobst/minsk/pull/18.patch"},"body":"Simplify the switch statements and eliminates the need for casting"},"comment":{"url":"https://api.github.com/repos/terrajobst/minsk/issues/comments/435186361","html_url":"https://github.com/terrajobst/minsk/pull/18#issuecomment-435186361","issue_url":"https://api.github.com/repos/terrajobst/minsk/issues/18","id":435186361,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTE4NjM2MQ==","user":{"login":"y2k4life","id":10999532,"node_id":"MDQ6VXNlcjEwOTk5NTMy","avatar_url":"https://avatars0.githubusercontent.com/u/10999532?v=4","gravatar_id":"","url":"https://api.github.com/users/y2k4life","html_url":"https://github.com/y2k4life","followers_url":"https://api.github.com/users/y2k4life/followers","following_url":"https://api.github.com/users/y2k4life/following{/other_user}","gists_url":"https://api.github.com/users/y2k4life/gists{/gist_id}","starred_url":"https://api.github.com/users/y2k4life/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y2k4life/subscriptions","organizations_url":"https://api.github.com/users/y2k4life/orgs","repos_url":"https://api.github.com/users/y2k4life/repos","events_url":"https://api.github.com/users/y2k4life/events{/privacy}","received_events_url":"https://api.github.com/users/y2k4life/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T21:03:14Z","updated_at":"2018-11-01T21:03:14Z","author_association":"NONE","body":"Still not done. I might be done after this though. It is just a bothersome to me that something that was introduced in C# to help actually might not be helpful.\r\n\r\nReading ECMA-335 it is hard to read exactly what is going on with `isinst`, but to me it looks like it will not do casting if it is not the correct type. I don't think it is, try casting and if it fails then it is not the type. I think it is if this is the type then cast.\r\n\r\n>isinst typeTok \r\n>\r\n>The isinst instruction tests whether obj (type O) is an instance of the type typeTok.  If the actual type (not the verifier tracked type) of obj is verifier-assignable-to the type typeTok then isinst succeeds and obj (as result) is returned unchanged while verification tracks its type as typeTok. Unlike coercions (§III.1.6) and conversions (§III.3.27), isinst never changes the actual type of an object and preserves object identity (see Partition I). If obj is null, or obj is not verifier-assignable-to the type typeTok, isinst fails and returns null.\r\n"}}
{"actor":{"display_login":"y2k4life"}}