{"action":"created","issue":{"url":"https://api.github.com/repos/balabit/syslog-ng/issues/2207","repository_url":"https://api.github.com/repos/balabit/syslog-ng","labels_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2207/labels{/name}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2207/comments","events_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2207/events","html_url":"https://github.com/balabit/syslog-ng/pull/2207","id":344917436,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTk5MjI5","number":2207,"title":"RFC: m4/check_java_support: add -rpath to libmod-java so it finds libjvm.so","user":{"login":"bazsi","id":714102,"node_id":"MDQ6VXNlcjcxNDEwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/714102?v=4","gravatar_id":"","url":"https://api.github.com/users/bazsi","html_url":"https://github.com/bazsi","followers_url":"https://api.github.com/users/bazsi/followers","following_url":"https://api.github.com/users/bazsi/following{/other_user}","gists_url":"https://api.github.com/users/bazsi/gists{/gist_id}","starred_url":"https://api.github.com/users/bazsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazsi/subscriptions","organizations_url":"https://api.github.com/users/bazsi/orgs","repos_url":"https://api.github.com/users/bazsi/repos","events_url":"https://api.github.com/users/bazsi/events{/privacy}","received_events_url":"https://api.github.com/users/bazsi/received_events","type":"User","site_admin":false},"labels":[{"id":104723147,"node_id":"MDU6TGFiZWwxMDQ3MjMxNDc=","url":"https://api.github.com/repos/balabit/syslog-ng/labels/in%20progress","name":"in progress","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-26T16:31:53Z","updated_at":"2018-07-27T09:10:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2207","html_url":"https://github.com/balabit/syslog-ng/pull/2207","diff_url":"https://github.com/balabit/syslog-ng/pull/2207.diff","patch_url":"https://github.com/balabit/syslog-ng/pull/2207.patch"},"body":"This is primarily an RFC pull request, with this we would be encoding the path to libjvm.so into our libmod-java.so plugin, avoiding having to set LD_LIBRARY_PATH at runtime.\r\n\r\nI think it is pretty common to run into java() being unavailable because of the missing LD_LIBRARY_PATH setting.\r\n\r\nThe risk is that not all platforms might support rpath the same. Also, Debian has a policy against rpath, but I think it does not apply (but I am not sure). @mochrul \r\n\r\nI haven't implemented the cmake variant.\r\n\r\nWhat do you, especially package maintainers, think?\r\n@czanik "},"comment":{"url":"https://api.github.com/repos/balabit/syslog-ng/issues/comments/408360561","html_url":"https://github.com/balabit/syslog-ng/pull/2207#issuecomment-408360561","issue_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2207","id":408360561,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODM2MDU2MQ==","user":{"login":"lbudai","id":5908786,"node_id":"MDQ6VXNlcjU5MDg3ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/5908786?v=4","gravatar_id":"","url":"https://api.github.com/users/lbudai","html_url":"https://github.com/lbudai","followers_url":"https://api.github.com/users/lbudai/followers","following_url":"https://api.github.com/users/lbudai/following{/other_user}","gists_url":"https://api.github.com/users/lbudai/gists{/gist_id}","starred_url":"https://api.github.com/users/lbudai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbudai/subscriptions","organizations_url":"https://api.github.com/users/lbudai/orgs","repos_url":"https://api.github.com/users/lbudai/repos","events_url":"https://api.github.com/users/lbudai/events{/privacy}","received_events_url":"https://api.github.com/users/lbudai/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T09:10:11Z","updated_at":"2018-07-27T09:10:11Z","author_association":"CONTRIBUTOR","body":"@bazsi : could work, when building from source \r\n\r\nFrom packages point of view: what if the distro provides more than one java version? libjvm.so is not handled by the alternatives in Debian/Ubuntu, so it is easy to build a binary that contains an rpath pointing to a different(, or even nonexistent jvm.so...) which can be sometimes an issue. Or, in other words, it will only work when the builder environment and the runtime environment has the same java version (and distribution) installed... so if the user has an oracle jre, but we are building syslog-ng with openjdk, then rpath will points to nowhere on the client machine."}}
{"actor":{"display_login":"lbudai"}}