{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/199764308","pull_request_review_id":133944989,"id":199764308,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTc2NDMwOA==","diff_hunk":"@@ -51,15 +51,27 @@ class GUI_EXPORT QgsColorRampShaderWidget: public QWidget, protected Ui::QgsColo\n     //! Allows quantile classification mode for raster layers\n     void initForUseWithRasterLayer();\n \n-    //! Associates raster with the widget\n-    void setRasterBand( QgsRasterDataProvider *dp, int band, const QgsRectangle &extent );\n+    //! Associates raster with the widget, only when used for raster layer\n+    void setRasterDataProvider( QgsRasterDataProvider *dp );\n+\n+    //! Sets raster band, only when used for raster layer\n+    void setRasterBand( int band );\n+\n+    //! Sets extent, only when used for raster layer\n+    void setExtent( const QgsRectangle &extent );\n \n     //! Sets min max and classify color tree\n     void setMinMaxAndClassify( double min, double max );\n \n     //! Sets min max\n     void setMinMax( double min, double max );\n \n+    //! Gets min value\n+    double min() const;","path":"src/gui/raster/qgscolorrampshaderwidget.h","position":22,"original_position":22,"commit_id":"311c16f0f00ee38ebcdc849bf8f608a61125011c","original_commit_id":"311c16f0f00ee38ebcdc849bf8f608a61125011c","user":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"body":"np, thanks. Does this apply to all functions or just getters, let say `setMinMaxAndClassify` -> `setMinimumMaximumAndClassify` ?","created_at":"2018-07-03T10:53:34Z","updated_at":"2018-07-03T10:53:34Z","html_url":"https://github.com/qgis/QGIS/pull/7358#discussion_r199764308","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/7358","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/199764308"},"html":{"href":"https://github.com/qgis/QGIS/pull/7358#discussion_r199764308"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7358"}},"in_reply_to_id":199740543},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/7358","id":198891102,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODkxMTAy","html_url":"https://github.com/qgis/QGIS/pull/7358","diff_url":"https://github.com/qgis/QGIS/pull/7358.diff","patch_url":"https://github.com/qgis/QGIS/pull/7358.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/7358","number":7358,"state":"open","locked":false,"title":"also use color ramp shader widget for pseudo color renderer","user":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"body":"Use QgsColorRampShaderWidget  for raster layers (it is already used for mesh layers)","created_at":"2018-07-03T08:47:41Z","updated_at":"2018-07-03T10:53:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"219e5670316e1178db098ca6d32b39519ffcb58d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/7358/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/7358/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/7358/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/311c16f0f00ee38ebcdc849bf8f608a61125011c","head":{"label":"PeterPetrik:share_color_ramp_widget","ref":"share_color_ramp_widget","sha":"311c16f0f00ee38ebcdc849bf8f608a61125011c","user":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"repo":{"id":38666026,"node_id":"MDEwOlJlcG9zaXRvcnkzODY2NjAyNg==","name":"QGIS","full_name":"PeterPetrik/QGIS","owner":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PeterPetrik/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/PeterPetrik/QGIS","forks_url":"https://api.github.com/repos/PeterPetrik/QGIS/forks","keys_url":"https://api.github.com/repos/PeterPetrik/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeterPetrik/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeterPetrik/QGIS/teams","hooks_url":"https://api.github.com/repos/PeterPetrik/QGIS/hooks","issue_events_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/PeterPetrik/QGIS/events","assignees_url":"https://api.github.com/repos/PeterPetrik/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/PeterPetrik/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/PeterPetrik/QGIS/tags","blobs_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeterPetrik/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/PeterPetrik/QGIS/languages","stargazers_url":"https://api.github.com/repos/PeterPetrik/QGIS/stargazers","contributors_url":"https://api.github.com/repos/PeterPetrik/QGIS/contributors","subscribers_url":"https://api.github.com/repos/PeterPetrik/QGIS/subscribers","subscription_url":"https://api.github.com/repos/PeterPetrik/QGIS/subscription","commits_url":"https://api.github.com/repos/PeterPetrik/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeterPetrik/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeterPetrik/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/PeterPetrik/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeterPetrik/QGIS/merges","archive_url":"https://api.github.com/repos/PeterPetrik/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeterPetrik/QGIS/downloads","issues_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/PeterPetrik/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/PeterPetrik/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/PeterPetrik/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeterPetrik/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/PeterPetrik/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/PeterPetrik/QGIS/deployments","created_at":"2015-07-07T05:24:42Z","updated_at":"2018-07-02T12:08:07Z","pushed_at":"2018-07-03T08:46:11Z","git_url":"git://github.com/PeterPetrik/QGIS.git","ssh_url":"git@github.com:PeterPetrik/QGIS.git","clone_url":"https://github.com/PeterPetrik/QGIS.git","svn_url":"https://github.com/PeterPetrik/QGIS","homepage":"http://qgis.org","size":1380282,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"045b88e75bf18ae4f83e09f2dc5d73aafec724e3","user":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwNDgw","name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2018-07-03T09:11:40Z","pushed_at":"2018-07-03T09:52:50Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1441805,"stargazers_count":2101,"watchers_count":2101,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1267,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1267,"open_issues":27,"watchers":2101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7358"},"html":{"href":"https://github.com/qgis/QGIS/pull/7358"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/7358"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/7358/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7358/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7358/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/311c16f0f00ee38ebcdc849bf8f608a61125011c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PeterPetrik"}}