{"action":"created","comment":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/220121243","pull_request_review_id":158452589,"id":220121243,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDEyMTI0Mw==","diff_hunk":"@@ -104,6 +109,12 @@ private HashSet<string> ExtractEnums(ICollection<UnitySchemaFile> schemas)\n             return enumSet;\n         }\n \n+        private List<string> ExtractWorkerTypes(string path)\n+        {\n+            var fileNames = Directory.EnumerateFiles(path, \"spatialos.*.worker.json\");","path":"workers/unity/Packages/com.improbable.gdk.tools/.CodeGenerator/GdkCodeGenerator/src/CodeGenerator.cs","position":33,"original_position":33,"commit_id":"d84ee992bab1016648b0c7aee343648f917b1116","original_commit_id":"059a76f38490ee9d1abd3aec6bde01db7ab1137b","user":{"login":"jamiebrynes7","id":13353733,"node_id":"MDQ6VXNlcjEzMzUzNzMz","avatar_url":"https://avatars1.githubusercontent.com/u/13353733?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiebrynes7","html_url":"https://github.com/jamiebrynes7","followers_url":"https://api.github.com/users/jamiebrynes7/followers","following_url":"https://api.github.com/users/jamiebrynes7/following{/other_user}","gists_url":"https://api.github.com/users/jamiebrynes7/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiebrynes7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiebrynes7/subscriptions","organizations_url":"https://api.github.com/users/jamiebrynes7/orgs","repos_url":"https://api.github.com/users/jamiebrynes7/repos","events_url":"https://api.github.com/users/jamiebrynes7/events{/privacy}","received_events_url":"https://api.github.com/users/jamiebrynes7/received_events","type":"User","site_admin":false},"body":"Yeah this will need to be configurable ","created_at":"2018-09-25T09:30:50Z","updated_at":"2018-09-25T09:30:50Z","html_url":"https://github.com/spatialos/UnityGDK/pull/422#discussion_r220121243","pull_request_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/422","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/220121243"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/422#discussion_r220121243"},"pull_request":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/422"}},"in_reply_to_id":220008571},"pull_request":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/422","id":217803031,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3ODAzMDMx","html_url":"https://github.com/spatialos/UnityGDK/pull/422","diff_url":"https://github.com/spatialos/UnityGDK/pull/422.diff","patch_url":"https://github.com/spatialos/UnityGDK/pull/422.patch","issue_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/422","number":422,"state":"open","locked":false,"title":"simplify build system","user":{"login":"jessicafalk","id":31853332,"node_id":"MDQ6VXNlcjMxODUzMzMy","avatar_url":"https://avatars3.githubusercontent.com/u/31853332?v=4","gravatar_id":"","url":"https://api.github.com/users/jessicafalk","html_url":"https://github.com/jessicafalk","followers_url":"https://api.github.com/users/jessicafalk/followers","following_url":"https://api.github.com/users/jessicafalk/following{/other_user}","gists_url":"https://api.github.com/users/jessicafalk/gists{/gist_id}","starred_url":"https://api.github.com/users/jessicafalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessicafalk/subscriptions","organizations_url":"https://api.github.com/users/jessicafalk/orgs","repos_url":"https://api.github.com/users/jessicafalk/repos","events_url":"https://api.github.com/users/jessicafalk/events{/privacy}","received_events_url":"https://api.github.com/users/jessicafalk/received_events","type":"User","site_admin":false},"body":"**Contributions**: We are not currently taking public contributions - see our [contributions](CONTRIBUTING.md) policy. However, we are accepting issues and we do want your [feedback](../README.md#give-us-feedback).\r\n\r\n-------\r\n\r\n#### Description\r\nPlease read in commit order\r\n\r\nwhat has changed: \r\n1. menu items are now created during code gen phase and grab all worker types from the existing json files. \r\n2. made build target group dependent on build target and in general did a pass to ensure we can add e.g. mobile support fairly easily to it later on\r\n3. those build options that were mostly deprecated are all gone 🎉  Now you choose between development build and headless mode.\r\n4. just doing a general pass through the whole build system and trying to simplify whatever there is to simplify and structuring the code based on our coding standards (e.g. fields at the top, order based on access modifier, .. etc.)\r\n\r\nwhat does it look like?\r\n<img width=\"420\" alt=\"bildschirmfoto 2018-09-24 um 23 04 41\" src=\"https://user-images.githubusercontent.com/31853332/45981828-43aa0c80-c04e-11e8-8b33-ec721d5f0879.png\">\r\n\r\n#### Tests\r\nran builds locally and tested them. still need to test cloud deployments.\r\n\r\n#### Documentation\r\nthere is already a doc. will update documentation on it after this pr got reviewed\r\n\r\n#### Primary reviewers\r\n@zeroZshadow @firtina-improbable ","created_at":"2018-09-24T22:10:06Z","updated_at":"2018-09-25T09:30:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6964e3ac393afc800f6e3f08f2ef92bdd1b0033c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zeroZshadow","id":3106728,"node_id":"MDQ6VXNlcjMxMDY3Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/3106728?v=4","gravatar_id":"","url":"https://api.github.com/users/zeroZshadow","html_url":"https://github.com/zeroZshadow","followers_url":"https://api.github.com/users/zeroZshadow/followers","following_url":"https://api.github.com/users/zeroZshadow/following{/other_user}","gists_url":"https://api.github.com/users/zeroZshadow/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroZshadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroZshadow/subscriptions","organizations_url":"https://api.github.com/users/zeroZshadow/orgs","repos_url":"https://api.github.com/users/zeroZshadow/repos","events_url":"https://api.github.com/users/zeroZshadow/events{/privacy}","received_events_url":"https://api.github.com/users/zeroZshadow/received_events","type":"User","site_admin":false},{"login":"samiwh","id":14006669,"node_id":"MDQ6VXNlcjE0MDA2NjY5","avatar_url":"https://avatars0.githubusercontent.com/u/14006669?v=4","gravatar_id":"","url":"https://api.github.com/users/samiwh","html_url":"https://github.com/samiwh","followers_url":"https://api.github.com/users/samiwh/followers","following_url":"https://api.github.com/users/samiwh/following{/other_user}","gists_url":"https://api.github.com/users/samiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/samiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiwh/subscriptions","organizations_url":"https://api.github.com/users/samiwh/orgs","repos_url":"https://api.github.com/users/samiwh/repos","events_url":"https://api.github.com/users/samiwh/events{/privacy}","received_events_url":"https://api.github.com/users/samiwh/received_events","type":"User","site_admin":false},{"login":"firtina-improbable","id":31209570,"node_id":"MDQ6VXNlcjMxMjA5NTcw","avatar_url":"https://avatars1.githubusercontent.com/u/31209570?v=4","gravatar_id":"","url":"https://api.github.com/users/firtina-improbable","html_url":"https://github.com/firtina-improbable","followers_url":"https://api.github.com/users/firtina-improbable/followers","following_url":"https://api.github.com/users/firtina-improbable/following{/other_user}","gists_url":"https://api.github.com/users/firtina-improbable/gists{/gist_id}","starred_url":"https://api.github.com/users/firtina-improbable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firtina-improbable/subscriptions","organizations_url":"https://api.github.com/users/firtina-improbable/orgs","repos_url":"https://api.github.com/users/firtina-improbable/repos","events_url":"https://api.github.com/users/firtina-improbable/events{/privacy}","received_events_url":"https://api.github.com/users/firtina-improbable/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1002053376,"node_id":"MDU6TGFiZWwxMDAyMDUzMzc2","url":"https://api.github.com/repos/spatialos/UnityGDK/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/422/commits","review_comments_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/422/comments","review_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/422/comments","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/d84ee992bab1016648b0c7aee343648f917b1116","head":{"label":"spatialos:feature/simplify-build-system","ref":"feature/simplify-build-system","sha":"d84ee992bab1016648b0c7aee343648f917b1116","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","private":false,"owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-09-24T15:08:56Z","pushed_at":"2018-09-25T09:13:33Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":290988,"stargazers_count":89,"watchers_count":89,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":12,"watchers":89,"default_branch":"master"}},"base":{"label":"spatialos:master","ref":"master","sha":"71f0ebcf0d4b1972bf781a09e225850cacc4b6e5","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","private":false,"owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-09-24T15:08:56Z","pushed_at":"2018-09-25T09:13:33Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":290988,"stargazers_count":89,"watchers_count":89,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":12,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/422"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/422"},"issue":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/422"},"comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/spatialos/UnityGDK/statuses/d84ee992bab1016648b0c7aee343648f917b1116"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jamiebrynes7"}}