{"action":"created","comment":{"url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/comments/173633289","pull_request_review_id":102861506,"id":173633289,"diff_hunk":"@@ -40,6 +40,13 @@ class FilterBase(object):\n     Subclasses should implement `input` and/or `output` methods which must\n     return a string (unicode under python 2) or raise a NotImplementedError.\n     \"\"\"\n+\n+    # Since precompiling moves files around, it breaks url()\n+    # statements in css files. therefore we run the absolute and relative filter\n+    # on precompiled css files even if compression is disabled.\n+    # This flag allows those filters to do so.\n+    run_with_compression_disabled = False","path":"compressor/filters/base.py","position":9,"original_position":9,"commit_id":"2a8ab453d7b276ccbd8992edbff01c92436a327f","original_commit_id":"2a8ab453d7b276ccbd8992edbff01c92436a327f","user":{"login":"karyon","id":1891915,"avatar_url":"https://avatars0.githubusercontent.com/u/1891915?v=4","gravatar_id":"","url":"https://api.github.com/users/karyon","html_url":"https://github.com/karyon","followers_url":"https://api.github.com/users/karyon/followers","following_url":"https://api.github.com/users/karyon/following{/other_user}","gists_url":"https://api.github.com/users/karyon/gists{/gist_id}","starred_url":"https://api.github.com/users/karyon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karyon/subscriptions","organizations_url":"https://api.github.com/users/karyon/orgs","repos_url":"https://api.github.com/users/karyon/repos","events_url":"https://api.github.com/users/karyon/events{/privacy}","received_events_url":"https://api.github.com/users/karyon/received_events","type":"User","site_admin":false},"body":"i would keep the comment only here and remove it everywhere else.","created_at":"2018-03-10T20:04:44Z","updated_at":"2018-03-10T20:57:06Z","html_url":"https://github.com/django-compressor/django-compressor/pull/900#discussion_r173633289","pull_request_url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/900","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/comments/173633289"},"html":{"href":"https://github.com/django-compressor/django-compressor/pull/900#discussion_r173633289"},"pull_request":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/900"}}},"pull_request":{"url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/900","id":173762653,"html_url":"https://github.com/django-compressor/django-compressor/pull/900","diff_url":"https://github.com/django-compressor/django-compressor/pull/900.diff","patch_url":"https://github.com/django-compressor/django-compressor/pull/900.patch","issue_url":"https://api.github.com/repos/django-compressor/django-compressor/issues/900","number":900,"state":"open","locked":false,"title":"Abstract away resource types to allow the implementation of new types.","user":{"login":"alvra","id":470642,"avatar_url":"https://avatars0.githubusercontent.com/u/470642?v=4","gravatar_id":"","url":"https://api.github.com/users/alvra","html_url":"https://github.com/alvra","followers_url":"https://api.github.com/users/alvra/followers","following_url":"https://api.github.com/users/alvra/following{/other_user}","gists_url":"https://api.github.com/users/alvra/gists{/gist_id}","starred_url":"https://api.github.com/users/alvra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvra/subscriptions","organizations_url":"https://api.github.com/users/alvra/orgs","repos_url":"https://api.github.com/users/alvra/repos","events_url":"https://api.github.com/users/alvra/events{/privacy}","received_events_url":"https://api.github.com/users/alvra/received_events","type":"User","site_admin":false},"body":"This change makes it possible to compress other resources besides css and js, such as svg, jpeg, fonts etc.\r\n\r\nIt introduces a new setting for filters ``COMPRESS_FILTERS`` that combines the existing ``COMPRESS_CSS_FILTERS`` and ``COMPRESS_JS_FILTERS``. The existing settings are still supported, but can optionally be replaced by the new one. This change is fully backwards-compatible and tested.\r\n\r\nThe undocumented setting ``CSS/JS_COMPRESSORS`` are combined into ``COMPRESSORS``. This is not backwards-compatible nor tested.\r\n\r\nYou can now add your own compressors.\r\nIn the example below, compressor now knows the ``jpeg`` resource type. Of course, the third party jpeg compressor still has to implement it.\r\n```\r\n# settings.py\r\nCOMPRESSORS = dict(\r\n    css='compressor.css.CssCompressor',\r\n    js='compressor.js.JsCompressor',\r\n    jpeg='third.party.jpeg.JpegCompressor',\r\n    ...\r\n)\r\nFILTERS = dict(\r\n    jpeg=['third.party.jpeg.JpegOptimizerFilter'],\r\n)\r\n\r\n# page.html\r\n<body>\r\n  {% compress jpeg %}\r\n    <img src=\"/path/to/image.jpeg\" />\r\n  {% endcompress %}\r\n</body>\r\n```","created_at":"2018-03-08T15:14:47Z","updated_at":"2018-03-10T20:57:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8df0686603451990878c2265fdc5ca51eba5adcd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/900/commits","review_comments_url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/900/comments","review_comment_url":"https://api.github.com/repos/django-compressor/django-compressor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django-compressor/django-compressor/issues/900/comments","statuses_url":"https://api.github.com/repos/django-compressor/django-compressor/statuses/2a8ab453d7b276ccbd8992edbff01c92436a327f","head":{"label":"alvra:develop","ref":"develop","sha":"2a8ab453d7b276ccbd8992edbff01c92436a327f","user":{"login":"alvra","id":470642,"avatar_url":"https://avatars0.githubusercontent.com/u/470642?v=4","gravatar_id":"","url":"https://api.github.com/users/alvra","html_url":"https://github.com/alvra","followers_url":"https://api.github.com/users/alvra/followers","following_url":"https://api.github.com/users/alvra/following{/other_user}","gists_url":"https://api.github.com/users/alvra/gists{/gist_id}","starred_url":"https://api.github.com/users/alvra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvra/subscriptions","organizations_url":"https://api.github.com/users/alvra/orgs","repos_url":"https://api.github.com/users/alvra/repos","events_url":"https://api.github.com/users/alvra/events{/privacy}","received_events_url":"https://api.github.com/users/alvra/received_events","type":"User","site_admin":false},"repo":{"id":124377503,"name":"django-compressor","full_name":"alvra/django-compressor","owner":{"login":"alvra","id":470642,"avatar_url":"https://avatars0.githubusercontent.com/u/470642?v=4","gravatar_id":"","url":"https://api.github.com/users/alvra","html_url":"https://github.com/alvra","followers_url":"https://api.github.com/users/alvra/followers","following_url":"https://api.github.com/users/alvra/following{/other_user}","gists_url":"https://api.github.com/users/alvra/gists{/gist_id}","starred_url":"https://api.github.com/users/alvra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvra/subscriptions","organizations_url":"https://api.github.com/users/alvra/orgs","repos_url":"https://api.github.com/users/alvra/repos","events_url":"https://api.github.com/users/alvra/events{/privacy}","received_events_url":"https://api.github.com/users/alvra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alvra/django-compressor","description":"Compresses linked and inline javascript or CSS into a single cached file.","fork":true,"url":"https://api.github.com/repos/alvra/django-compressor","forks_url":"https://api.github.com/repos/alvra/django-compressor/forks","keys_url":"https://api.github.com/repos/alvra/django-compressor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alvra/django-compressor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alvra/django-compressor/teams","hooks_url":"https://api.github.com/repos/alvra/django-compressor/hooks","issue_events_url":"https://api.github.com/repos/alvra/django-compressor/issues/events{/number}","events_url":"https://api.github.com/repos/alvra/django-compressor/events","assignees_url":"https://api.github.com/repos/alvra/django-compressor/assignees{/user}","branches_url":"https://api.github.com/repos/alvra/django-compressor/branches{/branch}","tags_url":"https://api.github.com/repos/alvra/django-compressor/tags","blobs_url":"https://api.github.com/repos/alvra/django-compressor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alvra/django-compressor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alvra/django-compressor/git/refs{/sha}","trees_url":"https://api.github.com/repos/alvra/django-compressor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alvra/django-compressor/statuses/{sha}","languages_url":"https://api.github.com/repos/alvra/django-compressor/languages","stargazers_url":"https://api.github.com/repos/alvra/django-compressor/stargazers","contributors_url":"https://api.github.com/repos/alvra/django-compressor/contributors","subscribers_url":"https://api.github.com/repos/alvra/django-compressor/subscribers","subscription_url":"https://api.github.com/repos/alvra/django-compressor/subscription","commits_url":"https://api.github.com/repos/alvra/django-compressor/commits{/sha}","git_commits_url":"https://api.github.com/repos/alvra/django-compressor/git/commits{/sha}","comments_url":"https://api.github.com/repos/alvra/django-compressor/comments{/number}","issue_comment_url":"https://api.github.com/repos/alvra/django-compressor/issues/comments{/number}","contents_url":"https://api.github.com/repos/alvra/django-compressor/contents/{+path}","compare_url":"https://api.github.com/repos/alvra/django-compressor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alvra/django-compressor/merges","archive_url":"https://api.github.com/repos/alvra/django-compressor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alvra/django-compressor/downloads","issues_url":"https://api.github.com/repos/alvra/django-compressor/issues{/number}","pulls_url":"https://api.github.com/repos/alvra/django-compressor/pulls{/number}","milestones_url":"https://api.github.com/repos/alvra/django-compressor/milestones{/number}","notifications_url":"https://api.github.com/repos/alvra/django-compressor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alvra/django-compressor/labels{/name}","releases_url":"https://api.github.com/repos/alvra/django-compressor/releases{/id}","deployments_url":"https://api.github.com/repos/alvra/django-compressor/deployments","created_at":"2018-03-08T10:45:22Z","updated_at":"2018-03-08T10:45:24Z","pushed_at":"2018-03-08T15:26:25Z","git_url":"git://github.com/alvra/django-compressor.git","ssh_url":"git@github.com:alvra/django-compressor.git","clone_url":"https://github.com/alvra/django-compressor.git","svn_url":"https://github.com/alvra/django-compressor","homepage":"https://django-compressor.readthedocs.io/","size":1556,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"django-compressor:develop","ref":"develop","sha":"b04006bc3c13351ad3071de60a5da6073dc25e5a","user":{"login":"django-compressor","id":6460407,"avatar_url":"https://avatars3.githubusercontent.com/u/6460407?v=4","gravatar_id":"","url":"https://api.github.com/users/django-compressor","html_url":"https://github.com/django-compressor","followers_url":"https://api.github.com/users/django-compressor/followers","following_url":"https://api.github.com/users/django-compressor/following{/other_user}","gists_url":"https://api.github.com/users/django-compressor/gists{/gist_id}","starred_url":"https://api.github.com/users/django-compressor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-compressor/subscriptions","organizations_url":"https://api.github.com/users/django-compressor/orgs","repos_url":"https://api.github.com/users/django-compressor/repos","events_url":"https://api.github.com/users/django-compressor/events{/privacy}","received_events_url":"https://api.github.com/users/django-compressor/received_events","type":"Organization","site_admin":false},"repo":{"id":504028,"name":"django-compressor","full_name":"django-compressor/django-compressor","owner":{"login":"django-compressor","id":6460407,"avatar_url":"https://avatars3.githubusercontent.com/u/6460407?v=4","gravatar_id":"","url":"https://api.github.com/users/django-compressor","html_url":"https://github.com/django-compressor","followers_url":"https://api.github.com/users/django-compressor/followers","following_url":"https://api.github.com/users/django-compressor/following{/other_user}","gists_url":"https://api.github.com/users/django-compressor/gists{/gist_id}","starred_url":"https://api.github.com/users/django-compressor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-compressor/subscriptions","organizations_url":"https://api.github.com/users/django-compressor/orgs","repos_url":"https://api.github.com/users/django-compressor/repos","events_url":"https://api.github.com/users/django-compressor/events{/privacy}","received_events_url":"https://api.github.com/users/django-compressor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django-compressor/django-compressor","description":"Compresses linked and inline javascript or CSS into a single cached file.","fork":false,"url":"https://api.github.com/repos/django-compressor/django-compressor","forks_url":"https://api.github.com/repos/django-compressor/django-compressor/forks","keys_url":"https://api.github.com/repos/django-compressor/django-compressor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django-compressor/django-compressor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django-compressor/django-compressor/teams","hooks_url":"https://api.github.com/repos/django-compressor/django-compressor/hooks","issue_events_url":"https://api.github.com/repos/django-compressor/django-compressor/issues/events{/number}","events_url":"https://api.github.com/repos/django-compressor/django-compressor/events","assignees_url":"https://api.github.com/repos/django-compressor/django-compressor/assignees{/user}","branches_url":"https://api.github.com/repos/django-compressor/django-compressor/branches{/branch}","tags_url":"https://api.github.com/repos/django-compressor/django-compressor/tags","blobs_url":"https://api.github.com/repos/django-compressor/django-compressor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django-compressor/django-compressor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django-compressor/django-compressor/git/refs{/sha}","trees_url":"https://api.github.com/repos/django-compressor/django-compressor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django-compressor/django-compressor/statuses/{sha}","languages_url":"https://api.github.com/repos/django-compressor/django-compressor/languages","stargazers_url":"https://api.github.com/repos/django-compressor/django-compressor/stargazers","contributors_url":"https://api.github.com/repos/django-compressor/django-compressor/contributors","subscribers_url":"https://api.github.com/repos/django-compressor/django-compressor/subscribers","subscription_url":"https://api.github.com/repos/django-compressor/django-compressor/subscription","commits_url":"https://api.github.com/repos/django-compressor/django-compressor/commits{/sha}","git_commits_url":"https://api.github.com/repos/django-compressor/django-compressor/git/commits{/sha}","comments_url":"https://api.github.com/repos/django-compressor/django-compressor/comments{/number}","issue_comment_url":"https://api.github.com/repos/django-compressor/django-compressor/issues/comments{/number}","contents_url":"https://api.github.com/repos/django-compressor/django-compressor/contents/{+path}","compare_url":"https://api.github.com/repos/django-compressor/django-compressor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django-compressor/django-compressor/merges","archive_url":"https://api.github.com/repos/django-compressor/django-compressor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django-compressor/django-compressor/downloads","issues_url":"https://api.github.com/repos/django-compressor/django-compressor/issues{/number}","pulls_url":"https://api.github.com/repos/django-compressor/django-compressor/pulls{/number}","milestones_url":"https://api.github.com/repos/django-compressor/django-compressor/milestones{/number}","notifications_url":"https://api.github.com/repos/django-compressor/django-compressor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django-compressor/django-compressor/labels{/name}","releases_url":"https://api.github.com/repos/django-compressor/django-compressor/releases{/id}","deployments_url":"https://api.github.com/repos/django-compressor/django-compressor/deployments","created_at":"2010-02-05T15:48:14Z","updated_at":"2018-03-10T03:12:22Z","pushed_at":"2018-03-10T18:48:48Z","git_url":"git://github.com/django-compressor/django-compressor.git","ssh_url":"git@github.com:django-compressor/django-compressor.git","clone_url":"https://github.com/django-compressor/django-compressor.git","svn_url":"https://github.com/django-compressor/django-compressor","homepage":"https://django-compressor.readthedocs.io/","size":1555,"stargazers_count":2000,"watchers_count":2000,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":525,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":525,"open_issues":89,"watchers":2000,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/900"},"html":{"href":"https://github.com/django-compressor/django-compressor/pull/900"},"issue":{"href":"https://api.github.com/repos/django-compressor/django-compressor/issues/900"},"comments":{"href":"https://api.github.com/repos/django-compressor/django-compressor/issues/900/comments"},"review_comments":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/900/comments"},"review_comment":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django-compressor/django-compressor/pulls/900/commits"},"statuses":{"href":"https://api.github.com/repos/django-compressor/django-compressor/statuses/2a8ab453d7b276ccbd8992edbff01c92436a327f"}},"author_association":"NONE"}}
{"actor":{"display_login":"karyon"}}