{"action":"created","issue":{"url":"https://api.github.com/repos/spacetelescope/webbpsf/issues/242","repository_url":"https://api.github.com/repos/spacetelescope/webbpsf","labels_url":"https://api.github.com/repos/spacetelescope/webbpsf/issues/242/labels{/name}","comments_url":"https://api.github.com/repos/spacetelescope/webbpsf/issues/242/comments","events_url":"https://api.github.com/repos/spacetelescope/webbpsf/issues/242/events","html_url":"https://github.com/spacetelescope/webbpsf/pull/242","id":376863118,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTc3ODI4","number":242,"title":"PEP8 + Docstring updates to distortion code","user":{"login":"shanosborne","id":31218961,"node_id":"MDQ6VXNlcjMxMjE4OTYx","avatar_url":"https://avatars1.githubusercontent.com/u/31218961?v=4","gravatar_id":"","url":"https://api.github.com/users/shanosborne","html_url":"https://github.com/shanosborne","followers_url":"https://api.github.com/users/shanosborne/followers","following_url":"https://api.github.com/users/shanosborne/following{/other_user}","gists_url":"https://api.github.com/users/shanosborne/gists{/gist_id}","starred_url":"https://api.github.com/users/shanosborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanosborne/subscriptions","organizations_url":"https://api.github.com/users/shanosborne/orgs","repos_url":"https://api.github.com/users/shanosborne/repos","events_url":"https://api.github.com/users/shanosborne/events{/privacy}","received_events_url":"https://api.github.com/users/shanosborne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-02T15:42:25Z","updated_at":"2018-11-14T19:48:59Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/spacetelescope/webbpsf/pulls/242","html_url":"https://github.com/spacetelescope/webbpsf/pull/242","diff_url":"https://github.com/spacetelescope/webbpsf/pull/242.diff","patch_url":"https://github.com/spacetelescope/webbpsf/pull/242.patch"},"body":"I added/cleaned up a bunch of doctrings and comments in distortion.py and where distortion.py is called in webbpsf_core.py. I also removed some imports that were no longer being used. \r\n\r\nThere are no changes to the code or how it runs - only changes to docstrings, comments, and imports"},"comment":{"url":"https://api.github.com/repos/spacetelescope/webbpsf/issues/comments/438794545","html_url":"https://github.com/spacetelescope/webbpsf/pull/242#issuecomment-438794545","issue_url":"https://api.github.com/repos/spacetelescope/webbpsf/issues/242","id":438794545,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODc5NDU0NQ==","user":{"login":"shanosborne","id":31218961,"node_id":"MDQ6VXNlcjMxMjE4OTYx","avatar_url":"https://avatars1.githubusercontent.com/u/31218961?v=4","gravatar_id":"","url":"https://api.github.com/users/shanosborne","html_url":"https://github.com/shanosborne","followers_url":"https://api.github.com/users/shanosborne/followers","following_url":"https://api.github.com/users/shanosborne/following{/other_user}","gists_url":"https://api.github.com/users/shanosborne/gists{/gist_id}","starred_url":"https://api.github.com/users/shanosborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanosborne/subscriptions","organizations_url":"https://api.github.com/users/shanosborne/orgs","repos_url":"https://api.github.com/users/shanosborne/repos","events_url":"https://api.github.com/users/shanosborne/events{/privacy}","received_events_url":"https://api.github.com/users/shanosborne/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T19:48:59Z","updated_at":"2018-11-14T19:48:59Z","author_association":"COLLABORATOR","body":"Yes I'm done committing things, so you can merge it whenever. \r\n\r\nI mean, it definitely wouldn't hurt to double check the order of application. I don't know exactly how the SIAF measured its distortion values, but if they only come from the detector and not any of the mirrors (which I think they do), then wouldn't the rotation of the detector not matter since the coefficients are found in the reference frame of the detector? I know I did find a difference in the PSF outputs based on the order of operation, but I'm wondering if that came from the imperfect method of using interpolation to rotate the array. What was your thought process for why rotation needs to come first?"}}
{"actor":{"display_login":"shanosborne"}}