{"action":"closed","issue":{"url":"https://api.github.com/repos/palantir/blueprint/issues/3179","repository_url":"https://api.github.com/repos/palantir/blueprint","labels_url":"https://api.github.com/repos/palantir/blueprint/issues/3179/labels{/name}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/3179/comments","events_url":"https://api.github.com/repos/palantir/blueprint/issues/3179/events","html_url":"https://github.com/palantir/blueprint/issues/3179","id":385008872,"node_id":"MDU6SXNzdWUzODUwMDg4NzI=","number":3179,"title":"QueryList activeItem does not change when query and items change on props","user":{"login":"rhysbrettbowen","id":728134,"node_id":"MDQ6VXNlcjcyODEzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/728134?v=4","gravatar_id":"","url":"https://api.github.com/users/rhysbrettbowen","html_url":"https://github.com/rhysbrettbowen","followers_url":"https://api.github.com/users/rhysbrettbowen/followers","following_url":"https://api.github.com/users/rhysbrettbowen/following{/other_user}","gists_url":"https://api.github.com/users/rhysbrettbowen/gists{/gist_id}","starred_url":"https://api.github.com/users/rhysbrettbowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhysbrettbowen/subscriptions","organizations_url":"https://api.github.com/users/rhysbrettbowen/orgs","repos_url":"https://api.github.com/users/rhysbrettbowen/repos","events_url":"https://api.github.com/users/rhysbrettbowen/events{/privacy}","received_events_url":"https://api.github.com/users/rhysbrettbowen/received_events","type":"User","site_admin":false},"labels":[{"id":828059286,"node_id":"MDU6TGFiZWw4MjgwNTkyODY=","url":"https://api.github.com/repos/palantir/blueprint/labels/Package:%20select","name":"Package: select","color":"f5f8fa","default":false},{"id":468827752,"node_id":"MDU6TGFiZWw0Njg4Mjc3NTI=","url":"https://api.github.com/repos/palantir/blueprint/labels/Type:%20bug","name":"Type: bug","color":"de4343","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-27T22:10:59Z","updated_at":"2018-11-27T23:30:11Z","closed_at":"2018-11-27T23:30:11Z","author_association":"NONE","body":"<!-- IF YOU ARE A PALANTIR EMPLOYEE, DO NOT POST INTERNAL LINKS OR REFERENCES HERE -->\r\n\r\n#### Environment\r\n\r\n- __Package version(s)__: @blueprintjs/select:3.3.0\r\n- __Browser and OS versions__: <!-- fill this out -->\r\n\r\n#### Steps to reproduce\r\n\r\n1. have a QueryList and set the props for \"query\" and \"items\"\r\n2. select an activeItem\r\n3. change \"query\" and \"items\" props\r\n4. use Enter key\r\n\r\n#### Actual behavior\r\n\r\nan item from the old items props will be chosen with the new query\r\n\r\n#### Expected behavior\r\n\r\nthe new list of items will be used with the query\r\n\r\n#### Possible solution\r\n\r\nIssue is that `setQuery` is called here: https://github.com/rhysbrettbowen/blueprint/blob/develop/packages/select/src/components/query-list/queryList.tsx#L139\r\n\r\nand the `setQuery` method looks at the current props - not the next props.\r\n"}}
{"actor":{"display_login":"rhysbrettbowen"}}