{"action":"created","comment":{"url":"https://api.github.com/repos/uber/h3/pulls/comments/188796760","pull_request_review_id":120848709,"id":188796760,"diff_hunk":"@@ -402,6 +403,54 @@ void _ijkRotate60cw(CoordIJK* ijk) {\n     _ijkNormalize(ijk);\n }\n \n+/**\n+ * Rotates indexing digit 60 degrees counter-clockwise. Returns result.\n+ *\n+ * @param digit Indexing digit (between 1 and 6 inclusive)\n+ */\n+int _rotate60ccw(int digit) {\n+    switch (digit) {","path":"src/h3lib/lib/coordijk.c","position":24,"original_position":24,"commit_id":"e3510b63b811513023b43b2b594f326e973ec5a3","original_commit_id":"e3510b63b811513023b43b2b594f326e973ec5a3","user":{"login":"nrabinowitz","id":163940,"avatar_url":"https://avatars1.githubusercontent.com/u/163940?v=4","gravatar_id":"","url":"https://api.github.com/users/nrabinowitz","html_url":"https://github.com/nrabinowitz","followers_url":"https://api.github.com/users/nrabinowitz/followers","following_url":"https://api.github.com/users/nrabinowitz/following{/other_user}","gists_url":"https://api.github.com/users/nrabinowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/nrabinowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrabinowitz/subscriptions","organizations_url":"https://api.github.com/users/nrabinowitz/orgs","repos_url":"https://api.github.com/users/nrabinowitz/repos","events_url":"https://api.github.com/users/nrabinowitz/events{/privacy}","received_events_url":"https://api.github.com/users/nrabinowitz/received_events","type":"User","site_admin":false},"body":"This is mostly for my info: I'm a little confused here. Given the ASCII diagram on L45, I was expecting this to look like `(digit + 1) % 6`, and was going to leave a note that this would be clearer, but looking through the cases here that's not the case. What exactly is being rotated here, and how does it relate to the diagram on L45?","created_at":"2018-05-16T22:59:31Z","updated_at":"2018-05-16T23:03:14Z","html_url":"https://github.com/uber/h3/pull/56#discussion_r188796760","pull_request_url":"https://api.github.com/repos/uber/h3/pulls/56","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber/h3/pulls/comments/188796760"},"html":{"href":"https://github.com/uber/h3/pull/56#discussion_r188796760"},"pull_request":{"href":"https://api.github.com/repos/uber/h3/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/uber/h3/pulls/56","id":188493783,"html_url":"https://github.com/uber/h3/pull/56","diff_url":"https://github.com/uber/h3/pull/56.diff","patch_url":"https://github.com/uber/h3/pull/56.patch","issue_url":"https://api.github.com/repos/uber/h3/issues/56","number":56,"state":"open","locked":false,"title":"Change signature of h3NeighborRotations to not accept `CoordIJK*`","user":{"login":"isaacbrodsky","id":9139378,"avatar_url":"https://avatars2.githubusercontent.com/u/9139378?v=4","gravatar_id":"","url":"https://api.github.com/users/isaacbrodsky","html_url":"https://github.com/isaacbrodsky","followers_url":"https://api.github.com/users/isaacbrodsky/followers","following_url":"https://api.github.com/users/isaacbrodsky/following{/other_user}","gists_url":"https://api.github.com/users/isaacbrodsky/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacbrodsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacbrodsky/subscriptions","organizations_url":"https://api.github.com/users/isaacbrodsky/orgs","repos_url":"https://api.github.com/users/isaacbrodsky/repos","events_url":"https://api.github.com/users/isaacbrodsky/events{/privacy}","received_events_url":"https://api.github.com/users/isaacbrodsky/received_events","type":"User","site_admin":false},"body":"This always required looking up the CoordIJK structure in some array, and then prompty changing it back to an indexing digit. Using an indexing digit also allows for some code to be cleaned up (deduplicated) in H3 index rotation.\r\n\r\nThis could set up for using an enum type for the indexing digits, which might provide some compiler niceties.\r\n\r\nDid not clean up some defines like UNIT_VECS, which could now be replaced with some bitwise manipulation in `_unitIjkToDigit` (changes undefined behavior though.)","created_at":"2018-05-16T16:40:28Z","updated_at":"2018-05-16T23:03:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26582c15e2e0e2f679dee925d11b931f81651d46","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dfellis","id":765551,"avatar_url":"https://avatars0.githubusercontent.com/u/765551?v=4","gravatar_id":"","url":"https://api.github.com/users/dfellis","html_url":"https://github.com/dfellis","followers_url":"https://api.github.com/users/dfellis/followers","following_url":"https://api.github.com/users/dfellis/following{/other_user}","gists_url":"https://api.github.com/users/dfellis/gists{/gist_id}","starred_url":"https://api.github.com/users/dfellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfellis/subscriptions","organizations_url":"https://api.github.com/users/dfellis/orgs","repos_url":"https://api.github.com/users/dfellis/repos","events_url":"https://api.github.com/users/dfellis/events{/privacy}","received_events_url":"https://api.github.com/users/dfellis/received_events","type":"User","site_admin":false},{"login":"joegilley","id":1476969,"avatar_url":"https://avatars0.githubusercontent.com/u/1476969?v=4","gravatar_id":"","url":"https://api.github.com/users/joegilley","html_url":"https://github.com/joegilley","followers_url":"https://api.github.com/users/joegilley/followers","following_url":"https://api.github.com/users/joegilley/following{/other_user}","gists_url":"https://api.github.com/users/joegilley/gists{/gist_id}","starred_url":"https://api.github.com/users/joegilley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joegilley/subscriptions","organizations_url":"https://api.github.com/users/joegilley/orgs","repos_url":"https://api.github.com/users/joegilley/repos","events_url":"https://api.github.com/users/joegilley/events{/privacy}","received_events_url":"https://api.github.com/users/joegilley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/h3/pulls/56/commits","review_comments_url":"https://api.github.com/repos/uber/h3/pulls/56/comments","review_comment_url":"https://api.github.com/repos/uber/h3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/h3/issues/56/comments","statuses_url":"https://api.github.com/repos/uber/h3/statuses/e3510b63b811513023b43b2b594f326e973ec5a3","head":{"label":"isaacbrodsky:h3neighborrotation-no-ijk","ref":"h3neighborrotation-no-ijk","sha":"e3510b63b811513023b43b2b594f326e973ec5a3","user":{"login":"isaacbrodsky","id":9139378,"avatar_url":"https://avatars2.githubusercontent.com/u/9139378?v=4","gravatar_id":"","url":"https://api.github.com/users/isaacbrodsky","html_url":"https://github.com/isaacbrodsky","followers_url":"https://api.github.com/users/isaacbrodsky/followers","following_url":"https://api.github.com/users/isaacbrodsky/following{/other_user}","gists_url":"https://api.github.com/users/isaacbrodsky/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacbrodsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacbrodsky/subscriptions","organizations_url":"https://api.github.com/users/isaacbrodsky/orgs","repos_url":"https://api.github.com/users/isaacbrodsky/repos","events_url":"https://api.github.com/users/isaacbrodsky/events{/privacy}","received_events_url":"https://api.github.com/users/isaacbrodsky/received_events","type":"User","site_admin":false},"repo":{"id":117475313,"name":"h3","full_name":"isaacbrodsky/h3","owner":{"login":"isaacbrodsky","id":9139378,"avatar_url":"https://avatars2.githubusercontent.com/u/9139378?v=4","gravatar_id":"","url":"https://api.github.com/users/isaacbrodsky","html_url":"https://github.com/isaacbrodsky","followers_url":"https://api.github.com/users/isaacbrodsky/followers","following_url":"https://api.github.com/users/isaacbrodsky/following{/other_user}","gists_url":"https://api.github.com/users/isaacbrodsky/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacbrodsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacbrodsky/subscriptions","organizations_url":"https://api.github.com/users/isaacbrodsky/orgs","repos_url":"https://api.github.com/users/isaacbrodsky/repos","events_url":"https://api.github.com/users/isaacbrodsky/events{/privacy}","received_events_url":"https://api.github.com/users/isaacbrodsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isaacbrodsky/h3","description":"Hexagonal hierarchical geospatial indexing system","fork":true,"url":"https://api.github.com/repos/isaacbrodsky/h3","forks_url":"https://api.github.com/repos/isaacbrodsky/h3/forks","keys_url":"https://api.github.com/repos/isaacbrodsky/h3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaacbrodsky/h3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaacbrodsky/h3/teams","hooks_url":"https://api.github.com/repos/isaacbrodsky/h3/hooks","issue_events_url":"https://api.github.com/repos/isaacbrodsky/h3/issues/events{/number}","events_url":"https://api.github.com/repos/isaacbrodsky/h3/events","assignees_url":"https://api.github.com/repos/isaacbrodsky/h3/assignees{/user}","branches_url":"https://api.github.com/repos/isaacbrodsky/h3/branches{/branch}","tags_url":"https://api.github.com/repos/isaacbrodsky/h3/tags","blobs_url":"https://api.github.com/repos/isaacbrodsky/h3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaacbrodsky/h3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaacbrodsky/h3/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaacbrodsky/h3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaacbrodsky/h3/statuses/{sha}","languages_url":"https://api.github.com/repos/isaacbrodsky/h3/languages","stargazers_url":"https://api.github.com/repos/isaacbrodsky/h3/stargazers","contributors_url":"https://api.github.com/repos/isaacbrodsky/h3/contributors","subscribers_url":"https://api.github.com/repos/isaacbrodsky/h3/subscribers","subscription_url":"https://api.github.com/repos/isaacbrodsky/h3/subscription","commits_url":"https://api.github.com/repos/isaacbrodsky/h3/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaacbrodsky/h3/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaacbrodsky/h3/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaacbrodsky/h3/issues/comments{/number}","contents_url":"https://api.github.com/repos/isaacbrodsky/h3/contents/{+path}","compare_url":"https://api.github.com/repos/isaacbrodsky/h3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaacbrodsky/h3/merges","archive_url":"https://api.github.com/repos/isaacbrodsky/h3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaacbrodsky/h3/downloads","issues_url":"https://api.github.com/repos/isaacbrodsky/h3/issues{/number}","pulls_url":"https://api.github.com/repos/isaacbrodsky/h3/pulls{/number}","milestones_url":"https://api.github.com/repos/isaacbrodsky/h3/milestones{/number}","notifications_url":"https://api.github.com/repos/isaacbrodsky/h3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaacbrodsky/h3/labels{/name}","releases_url":"https://api.github.com/repos/isaacbrodsky/h3/releases{/id}","deployments_url":"https://api.github.com/repos/isaacbrodsky/h3/deployments","created_at":"2018-01-14T23:21:16Z","updated_at":"2018-05-03T04:25:05Z","pushed_at":"2018-05-16T16:39:37Z","git_url":"git://github.com/isaacbrodsky/h3.git","ssh_url":"git@github.com:isaacbrodsky/h3.git","clone_url":"https://github.com/isaacbrodsky/h3.git","svn_url":"https://github.com/isaacbrodsky/h3","homepage":"","size":16538,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"73eefeac72e07558b113461a442c0a928e466d49","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":114948816,"name":"h3","full_name":"uber/h3","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/h3","description":"Hexagonal hierarchical geospatial indexing system","fork":false,"url":"https://api.github.com/repos/uber/h3","forks_url":"https://api.github.com/repos/uber/h3/forks","keys_url":"https://api.github.com/repos/uber/h3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/h3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/h3/teams","hooks_url":"https://api.github.com/repos/uber/h3/hooks","issue_events_url":"https://api.github.com/repos/uber/h3/issues/events{/number}","events_url":"https://api.github.com/repos/uber/h3/events","assignees_url":"https://api.github.com/repos/uber/h3/assignees{/user}","branches_url":"https://api.github.com/repos/uber/h3/branches{/branch}","tags_url":"https://api.github.com/repos/uber/h3/tags","blobs_url":"https://api.github.com/repos/uber/h3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/h3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/h3/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/h3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/h3/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/h3/languages","stargazers_url":"https://api.github.com/repos/uber/h3/stargazers","contributors_url":"https://api.github.com/repos/uber/h3/contributors","subscribers_url":"https://api.github.com/repos/uber/h3/subscribers","subscription_url":"https://api.github.com/repos/uber/h3/subscription","commits_url":"https://api.github.com/repos/uber/h3/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/h3/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/h3/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/h3/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/h3/contents/{+path}","compare_url":"https://api.github.com/repos/uber/h3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/h3/merges","archive_url":"https://api.github.com/repos/uber/h3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/h3/downloads","issues_url":"https://api.github.com/repos/uber/h3/issues{/number}","pulls_url":"https://api.github.com/repos/uber/h3/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/h3/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/h3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/h3/labels{/name}","releases_url":"https://api.github.com/repos/uber/h3/releases{/id}","deployments_url":"https://api.github.com/repos/uber/h3/deployments","created_at":"2017-12-21T01:38:35Z","updated_at":"2018-05-16T02:47:31Z","pushed_at":"2018-05-16T16:40:29Z","git_url":"git://github.com/uber/h3.git","ssh_url":"git@github.com:uber/h3.git","clone_url":"https://github.com/uber/h3.git","svn_url":"https://github.com/uber/h3","homepage":"https://uber.github.io/h3/","size":17446,"stargazers_count":579,"watchers_count":579,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":30,"open_issues":5,"watchers":579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/h3/pulls/56"},"html":{"href":"https://github.com/uber/h3/pull/56"},"issue":{"href":"https://api.github.com/repos/uber/h3/issues/56"},"comments":{"href":"https://api.github.com/repos/uber/h3/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/h3/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/h3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/h3/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/uber/h3/statuses/e3510b63b811513023b43b2b594f326e973ec5a3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nrabinowitz"}}