{"action":"created","comment":{"url":"https://api.github.com/repos/ioam/holoviews/pulls/comments/170766869","pull_request_review_id":99503845,"id":170766869,"diff_hunk":"@@ -224,19 +224,25 @@ def load_hvjs(cls, logo=False, bokeh_logo=False, mpl_logo=False, plotly_logo=Fal\n         import jinja2\n         # Evaluate load_notebook.html template with widgetjs code\n         if JS:\n-            widgetjs, widgetcss = Renderer.html_assets(extras=False, backends=[])\n+            widgetjs, widgetcss = Renderer.html_assets(extras=False, backends=[], script=True)\n         else:\n             widgetjs, widgetcss = '', ''\n         templateLoader = jinja2.FileSystemLoader(os.path.dirname(os.path.abspath(__file__)))\n         jinjaEnv = jinja2.Environment(loader=templateLoader)\n         template = jinjaEnv.get_template('load_notebook.html')\n-        display(HTML(template.render({'widgetjs':    widgetjs,\n-                                      'widgetcss':   widgetcss,\n-                                      'logo':        logo,\n-                                      'bokeh_logo':  bokeh_logo,\n-                                      'mpl_logo':    mpl_logo,\n-                                      'plotly_logo': plotly_logo,\n-                                      'message':     message})))\n+        html = template.render({'widgetcss':   widgetcss,\n+                                'logo':        logo,\n+                                'bokeh_logo':  bokeh_logo,\n+                                'mpl_logo':    mpl_logo,\n+                                'plotly_logo': plotly_logo,\n+                                'message':     message})\n+        publish_display_data(data={'text/html': html})\n+        if JS:\n+            publish_display_data(data={\n+                MIME_TYPES['js']   : widgetjs,\n+                MIME_TYPES['jlab-hv-load'] : widgetjs\n+            })","path":"holoviews/ipython/__init__.py","position":45,"original_position":45,"commit_id":"40cf0c42be3f0138db0762e36c8fca72c7819e20","original_commit_id":"40cf0c42be3f0138db0762e36c8fca72c7819e20","user":{"login":"jlstevens","id":890576,"avatar_url":"https://avatars3.githubusercontent.com/u/890576?v=4","gravatar_id":"","url":"https://api.github.com/users/jlstevens","html_url":"https://github.com/jlstevens","followers_url":"https://api.github.com/users/jlstevens/followers","following_url":"https://api.github.com/users/jlstevens/following{/other_user}","gists_url":"https://api.github.com/users/jlstevens/gists{/gist_id}","starred_url":"https://api.github.com/users/jlstevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlstevens/subscriptions","organizations_url":"https://api.github.com/users/jlstevens/orgs","repos_url":"https://api.github.com/users/jlstevens/repos","events_url":"https://api.github.com/users/jlstevens/events{/privacy}","received_events_url":"https://api.github.com/users/jlstevens/received_events","type":"User","site_admin":false},"body":"I'll add a comment to explain that jupyterlab will only process the non-standard mime type.","created_at":"2018-02-26T23:08:28Z","updated_at":"2018-02-26T23:08:28Z","html_url":"https://github.com/ioam/holoviews/pull/2372#discussion_r170766869","pull_request_url":"https://api.github.com/repos/ioam/holoviews/pulls/2372","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/comments/170766869"},"html":{"href":"https://github.com/ioam/holoviews/pull/2372#discussion_r170766869"},"pull_request":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/2372"}}},"pull_request":{"url":"https://api.github.com/repos/ioam/holoviews/pulls/2372","id":171055352,"html_url":"https://github.com/ioam/holoviews/pull/2372","diff_url":"https://github.com/ioam/holoviews/pull/2372.diff","patch_url":"https://github.com/ioam/holoviews/pull/2372.patch","issue_url":"https://api.github.com/repos/ioam/holoviews/issues/2372","number":2372,"state":"open","locked":false,"title":"Add CommManager classes ","user":{"login":"philippjfr","id":1550771,"avatar_url":"https://avatars2.githubusercontent.com/u/1550771?v=4","gravatar_id":"","url":"https://api.github.com/users/philippjfr","html_url":"https://github.com/philippjfr","followers_url":"https://api.github.com/users/philippjfr/followers","following_url":"https://api.github.com/users/philippjfr/following{/other_user}","gists_url":"https://api.github.com/users/philippjfr/gists{/gist_id}","starred_url":"https://api.github.com/users/philippjfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippjfr/subscriptions","organizations_url":"https://api.github.com/users/philippjfr/orgs","repos_url":"https://api.github.com/users/philippjfr/repos","events_url":"https://api.github.com/users/philippjfr/events{/privacy}","received_events_url":"https://api.github.com/users/philippjfr/received_events","type":"User","site_admin":false},"body":"Builds on https://github.com/ioam/holoviews/pull/2368 abstracting all Comm handling onto so called CommHandler classes. By default HoloViews will ship with a JupyterCommHandler, which will handle both the classic notebook and JupyterLab.\r\n\r\nHere is the current status of JupyterLab support:\r\n\r\nStatic plots\r\n-------------\r\n\r\n* Static plots work (all backends)\r\n* Embedded widgets work (all backends)\r\n\r\nBackend -> Frontend\r\n-------------------------\r\n\r\n* Can send data from backend to frontend and update matplotlib and plotly plots\r\n* Cannot yet update bokeh plots\r\n\r\nFrontend -> Backend\r\n-------------------------\r\n\r\n* Bokeh callbacks work\r\n* Dynamic and Live widgets work\r\n\r\n- [x] Handle bokeh messages (either by exposing the API in bokeh or by duplicating some of that code in HoloViews)\r\n- [ ] Add tests\r\n- [ ] Review API and docstrings with @jlstevens ","created_at":"2018-02-23T16:18:21Z","updated_at":"2018-02-26T23:08:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8306b4b4c7628f305cb92956f58ba32cc8dc17f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":97850378,"url":"https://api.github.com/repos/ioam/holoviews/labels/feature","name":"feature","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ioam/holoviews/pulls/2372/commits","review_comments_url":"https://api.github.com/repos/ioam/holoviews/pulls/2372/comments","review_comment_url":"https://api.github.com/repos/ioam/holoviews/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ioam/holoviews/issues/2372/comments","statuses_url":"https://api.github.com/repos/ioam/holoviews/statuses/40cf0c42be3f0138db0762e36c8fca72c7819e20","head":{"label":"ioam:comm_manager","ref":"comm_manager","sha":"40cf0c42be3f0138db0762e36c8fca72c7819e20","user":{"login":"ioam","id":1693676,"avatar_url":"https://avatars2.githubusercontent.com/u/1693676?v=4","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"repo":{"id":19542768,"name":"holoviews","full_name":"ioam/holoviews","owner":{"login":"ioam","id":1693676,"avatar_url":"https://avatars2.githubusercontent.com/u/1693676?v=4","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ioam/holoviews","description":"Stop plotting your data - annotate your data and let it visualize itself.","fork":false,"url":"https://api.github.com/repos/ioam/holoviews","forks_url":"https://api.github.com/repos/ioam/holoviews/forks","keys_url":"https://api.github.com/repos/ioam/holoviews/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioam/holoviews/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioam/holoviews/teams","hooks_url":"https://api.github.com/repos/ioam/holoviews/hooks","issue_events_url":"https://api.github.com/repos/ioam/holoviews/issues/events{/number}","events_url":"https://api.github.com/repos/ioam/holoviews/events","assignees_url":"https://api.github.com/repos/ioam/holoviews/assignees{/user}","branches_url":"https://api.github.com/repos/ioam/holoviews/branches{/branch}","tags_url":"https://api.github.com/repos/ioam/holoviews/tags","blobs_url":"https://api.github.com/repos/ioam/holoviews/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioam/holoviews/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioam/holoviews/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioam/holoviews/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioam/holoviews/statuses/{sha}","languages_url":"https://api.github.com/repos/ioam/holoviews/languages","stargazers_url":"https://api.github.com/repos/ioam/holoviews/stargazers","contributors_url":"https://api.github.com/repos/ioam/holoviews/contributors","subscribers_url":"https://api.github.com/repos/ioam/holoviews/subscribers","subscription_url":"https://api.github.com/repos/ioam/holoviews/subscription","commits_url":"https://api.github.com/repos/ioam/holoviews/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioam/holoviews/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioam/holoviews/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioam/holoviews/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioam/holoviews/contents/{+path}","compare_url":"https://api.github.com/repos/ioam/holoviews/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioam/holoviews/merges","archive_url":"https://api.github.com/repos/ioam/holoviews/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioam/holoviews/downloads","issues_url":"https://api.github.com/repos/ioam/holoviews/issues{/number}","pulls_url":"https://api.github.com/repos/ioam/holoviews/pulls{/number}","milestones_url":"https://api.github.com/repos/ioam/holoviews/milestones{/number}","notifications_url":"https://api.github.com/repos/ioam/holoviews/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioam/holoviews/labels{/name}","releases_url":"https://api.github.com/repos/ioam/holoviews/releases{/id}","deployments_url":"https://api.github.com/repos/ioam/holoviews/deployments","created_at":"2014-05-07T16:59:22Z","updated_at":"2018-02-26T06:54:25Z","pushed_at":"2018-02-26T22:44:46Z","git_url":"git://github.com/ioam/holoviews.git","ssh_url":"git@github.com:ioam/holoviews.git","clone_url":"https://github.com/ioam/holoviews.git","svn_url":"https://github.com/ioam/holoviews","homepage":"http://holoviews.org","size":18248,"stargazers_count":702,"watchers_count":702,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":421,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":103,"open_issues":421,"watchers":702,"default_branch":"master"}},"base":{"label":"ioam:master","ref":"master","sha":"5313b75b64fe2baecec88a011ae5d47064b1c4e2","user":{"login":"ioam","id":1693676,"avatar_url":"https://avatars2.githubusercontent.com/u/1693676?v=4","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"repo":{"id":19542768,"name":"holoviews","full_name":"ioam/holoviews","owner":{"login":"ioam","id":1693676,"avatar_url":"https://avatars2.githubusercontent.com/u/1693676?v=4","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ioam/holoviews","description":"Stop plotting your data - annotate your data and let it visualize itself.","fork":false,"url":"https://api.github.com/repos/ioam/holoviews","forks_url":"https://api.github.com/repos/ioam/holoviews/forks","keys_url":"https://api.github.com/repos/ioam/holoviews/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioam/holoviews/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioam/holoviews/teams","hooks_url":"https://api.github.com/repos/ioam/holoviews/hooks","issue_events_url":"https://api.github.com/repos/ioam/holoviews/issues/events{/number}","events_url":"https://api.github.com/repos/ioam/holoviews/events","assignees_url":"https://api.github.com/repos/ioam/holoviews/assignees{/user}","branches_url":"https://api.github.com/repos/ioam/holoviews/branches{/branch}","tags_url":"https://api.github.com/repos/ioam/holoviews/tags","blobs_url":"https://api.github.com/repos/ioam/holoviews/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioam/holoviews/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioam/holoviews/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioam/holoviews/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioam/holoviews/statuses/{sha}","languages_url":"https://api.github.com/repos/ioam/holoviews/languages","stargazers_url":"https://api.github.com/repos/ioam/holoviews/stargazers","contributors_url":"https://api.github.com/repos/ioam/holoviews/contributors","subscribers_url":"https://api.github.com/repos/ioam/holoviews/subscribers","subscription_url":"https://api.github.com/repos/ioam/holoviews/subscription","commits_url":"https://api.github.com/repos/ioam/holoviews/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioam/holoviews/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioam/holoviews/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioam/holoviews/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioam/holoviews/contents/{+path}","compare_url":"https://api.github.com/repos/ioam/holoviews/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioam/holoviews/merges","archive_url":"https://api.github.com/repos/ioam/holoviews/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioam/holoviews/downloads","issues_url":"https://api.github.com/repos/ioam/holoviews/issues{/number}","pulls_url":"https://api.github.com/repos/ioam/holoviews/pulls{/number}","milestones_url":"https://api.github.com/repos/ioam/holoviews/milestones{/number}","notifications_url":"https://api.github.com/repos/ioam/holoviews/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioam/holoviews/labels{/name}","releases_url":"https://api.github.com/repos/ioam/holoviews/releases{/id}","deployments_url":"https://api.github.com/repos/ioam/holoviews/deployments","created_at":"2014-05-07T16:59:22Z","updated_at":"2018-02-26T06:54:25Z","pushed_at":"2018-02-26T22:44:46Z","git_url":"git://github.com/ioam/holoviews.git","ssh_url":"git@github.com:ioam/holoviews.git","clone_url":"https://github.com/ioam/holoviews.git","svn_url":"https://github.com/ioam/holoviews","homepage":"http://holoviews.org","size":18248,"stargazers_count":702,"watchers_count":702,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":421,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":103,"open_issues":421,"watchers":702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/2372"},"html":{"href":"https://github.com/ioam/holoviews/pull/2372"},"issue":{"href":"https://api.github.com/repos/ioam/holoviews/issues/2372"},"comments":{"href":"https://api.github.com/repos/ioam/holoviews/issues/2372/comments"},"review_comments":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/2372/comments"},"review_comment":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/2372/commits"},"statuses":{"href":"https://api.github.com/repos/ioam/holoviews/statuses/40cf0c42be3f0138db0762e36c8fca72c7819e20"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jlstevens"}}