{"action":"closed","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/15034","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/15034/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/15034/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/15034/events","html_url":"https://github.com/owncloud/core/issues/15034","id":62989723,"node_id":"MDU6SXNzdWU2Mjk4OTcyMw==","number":15034,"title":"Disabling the app trash or version does not cleanup trash or version files","user":{"login":"ernesttk","id":11074302,"node_id":"MDQ6VXNlcjExMDc0MzAy","avatar_url":"https://avatars1.githubusercontent.com/u/11074302?v=4","gravatar_id":"","url":"https://api.github.com/users/ernesttk","html_url":"https://github.com/ernesttk","followers_url":"https://api.github.com/users/ernesttk/followers","following_url":"https://api.github.com/users/ernesttk/following{/other_user}","gists_url":"https://api.github.com/users/ernesttk/gists{/gist_id}","starred_url":"https://api.github.com/users/ernesttk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ernesttk/subscriptions","organizations_url":"https://api.github.com/users/ernesttk/orgs","repos_url":"https://api.github.com/users/ernesttk/repos","events_url":"https://api.github.com/users/ernesttk/events{/privacy}","received_events_url":"https://api.github.com/users/ernesttk/received_events","type":"User","site_admin":false},"labels":[{"id":45887383,"node_id":"MDU6TGFiZWw0NTg4NzM4Mw==","url":"https://api.github.com/repos/owncloud/core/labels/app:files_trashbin","name":"app:files_trashbin","color":"02d7e1","default":false},{"id":32695114,"node_id":"MDU6TGFiZWwzMjY5NTExNA==","url":"https://api.github.com/repos/owncloud/core/labels/app:files_versions","name":"app:files_versions","color":"02d7e1","default":false},{"id":12406436,"node_id":"MDU6TGFiZWwxMjQwNjQzNg==","url":"https://api.github.com/repos/owncloud/core/labels/enhancement","name":"enhancement","color":"02e10c","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/11","html_url":"https://github.com/owncloud/core/milestone/11","labels_url":"https://api.github.com/repos/owncloud/core/milestones/11/labels","id":697149,"node_id":"MDk6TWlsZXN0b25lNjk3MTQ5","number":11,"title":"maybe some day","description":"","creator":{"login":"MTRichards","id":1818977,"node_id":"MDQ6VXNlcjE4MTg5Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1818977?v=4","gravatar_id":"","url":"https://api.github.com/users/MTRichards","html_url":"https://github.com/MTRichards","followers_url":"https://api.github.com/users/MTRichards/followers","following_url":"https://api.github.com/users/MTRichards/following{/other_user}","gists_url":"https://api.github.com/users/MTRichards/gists{/gist_id}","starred_url":"https://api.github.com/users/MTRichards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MTRichards/subscriptions","organizations_url":"https://api.github.com/users/MTRichards/orgs","repos_url":"https://api.github.com/users/MTRichards/repos","events_url":"https://api.github.com/users/MTRichards/events{/privacy}","received_events_url":"https://api.github.com/users/MTRichards/received_events","type":"User","site_admin":false},"open_issues":897,"closed_issues":1242,"state":"open","created_at":"2014-06-20T19:52:03Z","updated_at":"2018-08-15T05:00:23Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-03-19T13:37:13Z","updated_at":"2018-08-15T05:00:23Z","closed_at":"2018-08-15T05:00:23Z","author_association":"NONE","body":"See also my comment about the situation at the bottom of the issue \n### Steps to reproduce\n1.  Use default setting which has trash and versioning enabled. Add, modify and delete some files client side for a while to startup trash and versioning. Now, server side, in the \"data/username/\" directory the client files can be seen in there respective directories files/, files_trashbin/ and files_versions/.\n2.  Login to the web interface as admin and disable either or both the trash and the versioning. \n3.  modify and delete some files client side. \n4.  Old files from before disabling are still present in files_trashbin/ and or files_versions/ \n### Expected behavior\n\nThere should have been a automatic cleanup initiated by the action to disable the app (with or without warning for dummies). \n### Actual behavior\n\nFiles are left in place.\nOnly after I added trashbin_retention_obligation => 0 to config.php and re-enabled trashbin were the files in <user>files_tashbin/ deleted. I haven't figured out yet how to delete safely the versions\n### Server configuration\n\n**Operating system**: \ndebian \n\n**Web server:**\nApache 2.2.22-13+deb7u4\n\n**Database:**\nmysql 5.5.41-0+wheezy1\n\n**PHP version:**\n5.4.38-0+deb7u1\n\n**ownCloud version:** (see ownCloud admin page)\n8.0.2-5\n\n**Updated from an older ownCloud or fresh install:**\nupdated from 8.0.0\n\n**List of activated apps:**\nAll apps which are enabled by default. Those concerning this issue are:\nDeleted Files 0.6.2\nVersions 1.0.5\n\n**The content of config/config.php:**\n\n```\n  'datadirectory' => '/var/www/owncloud/data',\n  'overwrite.cli.url' => 'http://euscloud.eus.klm.nl/owncloud',\n  'dbtype' => 'mysql',\n  'version' => '8.0.2.0',\n  'dbname' => 'owncloud',\n  'dbhost' => 'localhost',\n  'dbtableprefix' => 'oc_',\n  'dbuser' => 'oc_root',\n  'dbpassword' => '',\n  'installed' => true,\n  'forcessl' => true,\n  'loglevel' => 2,\n  'theme' => '',\n  'maintenance' => false,\n  'trashbin_retention_obligation' => 0,\n```\n\nnote: trashbin_retention_obligation was added to finally delete the trashbin. But this only works with \"Deleted Files\" enabled. There may be something similar for app Versions, but I haven't discovered it.\n\n**Are you using external storage, if yes which one:** local/smb/sftp/...\nnone\n\n**Are you using encryption:** yes/no\nno\n\n**Are you using an external user-backend, if yes which one:** LDAP/ActiveDirectory/Webdav/...\nnot yet\n#### LDAP configuration (delete this part if not used)\n\nnot used\n### Client configuration\n\n**Browser:**\nfirefox\n\n**Operating system:**\nWindows 7\n### Logs\n\nNone of the systems show any errors, so no logs are included.\n\n**Situation around this issue**\nI use owncloud as a (near) instantaneous synchronization of my development environment between two workstation (and have a quick backup too). This means that files changes a lot. Versions are not needed because I also use subversion and neither is the trash needed as it would contain masses of compiler generated temporary files/. And actually this was the case and is the reason I disabled both.\nI haven't actually checked, but I suspect ownCloud's app API does not provide something like a pre-disable call which could be used to resolve this. If what I suspect is correct then this issue report should be seen as a enhancement. \nI realize this issue could be by design, this is for you to judge.\n"}}
{"actor":{"display_login":"DeepDiver1975"}}