{"action":"created","comment":{"url":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/comments/215165484","pull_request_review_id":152369862,"id":215165484,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTE2NTQ4NA==","diff_hunk":"@@ -0,0 +1,63 @@\n+package com.example.marcinwisniewski.intivetrainingapp\n+\n+import android.arch.core.executor.testing.InstantTaskExecutorRule\n+import com.example.marcinwisniewski.intivetrainingapp.movielist.model.Movie\n+import com.example.marcinwisniewski.intivetrainingapp.movielist.model.MovieData\n+import com.example.marcinwisniewski.intivetrainingapp.movielist.model.MovieRepository\n+import com.example.marcinwisniewski.intivetrainingapp.movielist.viewmodel.MovieListViewModel\n+import com.nhaarman.mockitokotlin2.mock\n+import com.nhaarman.mockitokotlin2.whenever\n+import io.reactivex.Single\n+import org.amshove.kluent.shouldBe\n+import org.junit.Before\n+import org.junit.Rule\n+import org.junit.Test\n+\n+const val DEFULT_MOVIE_ID = 1\n+const val DEFULT_MOVIE_TITLE = \"title\"\n+const val DEFULT_MOVIE_POSTER = \"default/3\"\n+const val DEFULT_MOVIE_YEAR = \"1991\"\n+const val DEFULT_MOVIE_GENRE = \"dramat\"\n+\n+class MovieListViewModelTest {\n+\n+    @Rule\n+    @JvmField\n+    var rule = InstantTaskExecutorRule()\n+\n+    @Rule\n+    @JvmField\n+    val schedulers = RxImmediateSchedulerRule()\n+\n+    private lateinit var mockedMovieRepository: MovieRepository\n+    private lateinit var testedMovieListViewModel: MovieListViewModel\n+\n+    @Before\n+    fun setUp() {\n+        mockedMovieRepository = mock()\n+        testedMovieListViewModel = MovieListViewModel(mockedMovieRepository)\n+    }\n+\n+    @Test\n+    fun testReceivedEmptyMovieList() {\n+        // Given","path":"app/src/test/java/com/example/marcinwisniewski/intivetrainingapp/MovieListViewModelTest.kt","position":null,"original_position":43,"commit_id":"6433d3773090878623677cc8d9962cbcd4f405d9","original_commit_id":"de66b3bc47037686ae3c1b8b3c7dacf61315740f","user":{"login":"lepetinez","id":17149880,"node_id":"MDQ6VXNlcjE3MTQ5ODgw","avatar_url":"https://avatars3.githubusercontent.com/u/17149880?v=4","gravatar_id":"","url":"https://api.github.com/users/lepetinez","html_url":"https://github.com/lepetinez","followers_url":"https://api.github.com/users/lepetinez/followers","following_url":"https://api.github.com/users/lepetinez/following{/other_user}","gists_url":"https://api.github.com/users/lepetinez/gists{/gist_id}","starred_url":"https://api.github.com/users/lepetinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepetinez/subscriptions","organizations_url":"https://api.github.com/users/lepetinez/orgs","repos_url":"https://api.github.com/users/lepetinez/repos","events_url":"https://api.github.com/users/lepetinez/events{/privacy}","received_events_url":"https://api.github.com/users/lepetinez/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-09-05T07:43:54Z","updated_at":"2018-09-05T07:43:54Z","html_url":"https://github.com/lepetinez/intive_training_app/pull/9#discussion_r215165484","pull_request_url":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/9","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/comments/215165484"},"html":{"href":"https://github.com/lepetinez/intive_training_app/pull/9#discussion_r215165484"},"pull_request":{"href":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/9"}},"in_reply_to_id":215023985},"pull_request":{"url":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/9","id":212709535,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzA5NTM1","html_url":"https://github.com/lepetinez/intive_training_app/pull/9","diff_url":"https://github.com/lepetinez/intive_training_app/pull/9.diff","patch_url":"https://github.com/lepetinez/intive_training_app/pull/9.patch","issue_url":"https://api.github.com/repos/lepetinez/intive_training_app/issues/9","number":9,"state":"open","locked":false,"title":"movielistviewmodel test implementation","user":{"login":"lepetinez","id":17149880,"node_id":"MDQ6VXNlcjE3MTQ5ODgw","avatar_url":"https://avatars3.githubusercontent.com/u/17149880?v=4","gravatar_id":"","url":"https://api.github.com/users/lepetinez","html_url":"https://github.com/lepetinez","followers_url":"https://api.github.com/users/lepetinez/followers","following_url":"https://api.github.com/users/lepetinez/following{/other_user}","gists_url":"https://api.github.com/users/lepetinez/gists{/gist_id}","starred_url":"https://api.github.com/users/lepetinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepetinez/subscriptions","organizations_url":"https://api.github.com/users/lepetinez/orgs","repos_url":"https://api.github.com/users/lepetinez/repos","events_url":"https://api.github.com/users/lepetinez/events{/privacy}","received_events_url":"https://api.github.com/users/lepetinez/received_events","type":"User","site_admin":false},"body":"I have implented only MovieListViewModel tests - in case that I am not sure if it is done proper.","created_at":"2018-09-03T10:45:15Z","updated_at":"2018-09-05T07:43:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5606e668061b0230e23ce23fedaa7496dc32b2d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/9/commits","review_comments_url":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/9/comments","review_comment_url":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lepetinez/intive_training_app/issues/9/comments","statuses_url":"https://api.github.com/repos/lepetinez/intive_training_app/statuses/6433d3773090878623677cc8d9962cbcd4f405d9","head":{"label":"lepetinez:feature/9_test_implementation","ref":"feature/9_test_implementation","sha":"6433d3773090878623677cc8d9962cbcd4f405d9","user":{"login":"lepetinez","id":17149880,"node_id":"MDQ6VXNlcjE3MTQ5ODgw","avatar_url":"https://avatars3.githubusercontent.com/u/17149880?v=4","gravatar_id":"","url":"https://api.github.com/users/lepetinez","html_url":"https://github.com/lepetinez","followers_url":"https://api.github.com/users/lepetinez/followers","following_url":"https://api.github.com/users/lepetinez/following{/other_user}","gists_url":"https://api.github.com/users/lepetinez/gists{/gist_id}","starred_url":"https://api.github.com/users/lepetinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepetinez/subscriptions","organizations_url":"https://api.github.com/users/lepetinez/orgs","repos_url":"https://api.github.com/users/lepetinez/repos","events_url":"https://api.github.com/users/lepetinez/events{/privacy}","received_events_url":"https://api.github.com/users/lepetinez/received_events","type":"User","site_admin":false},"repo":{"id":143292629,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyOTI2Mjk=","name":"intive_training_app","full_name":"lepetinez/intive_training_app","owner":{"login":"lepetinez","id":17149880,"node_id":"MDQ6VXNlcjE3MTQ5ODgw","avatar_url":"https://avatars3.githubusercontent.com/u/17149880?v=4","gravatar_id":"","url":"https://api.github.com/users/lepetinez","html_url":"https://github.com/lepetinez","followers_url":"https://api.github.com/users/lepetinez/followers","following_url":"https://api.github.com/users/lepetinez/following{/other_user}","gists_url":"https://api.github.com/users/lepetinez/gists{/gist_id}","starred_url":"https://api.github.com/users/lepetinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepetinez/subscriptions","organizations_url":"https://api.github.com/users/lepetinez/orgs","repos_url":"https://api.github.com/users/lepetinez/repos","events_url":"https://api.github.com/users/lepetinez/events{/privacy}","received_events_url":"https://api.github.com/users/lepetinez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lepetinez/intive_training_app","description":"Training app dedicated for self-learning (mainly jetpack features)","fork":false,"url":"https://api.github.com/repos/lepetinez/intive_training_app","forks_url":"https://api.github.com/repos/lepetinez/intive_training_app/forks","keys_url":"https://api.github.com/repos/lepetinez/intive_training_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lepetinez/intive_training_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lepetinez/intive_training_app/teams","hooks_url":"https://api.github.com/repos/lepetinez/intive_training_app/hooks","issue_events_url":"https://api.github.com/repos/lepetinez/intive_training_app/issues/events{/number}","events_url":"https://api.github.com/repos/lepetinez/intive_training_app/events","assignees_url":"https://api.github.com/repos/lepetinez/intive_training_app/assignees{/user}","branches_url":"https://api.github.com/repos/lepetinez/intive_training_app/branches{/branch}","tags_url":"https://api.github.com/repos/lepetinez/intive_training_app/tags","blobs_url":"https://api.github.com/repos/lepetinez/intive_training_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lepetinez/intive_training_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lepetinez/intive_training_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/lepetinez/intive_training_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lepetinez/intive_training_app/statuses/{sha}","languages_url":"https://api.github.com/repos/lepetinez/intive_training_app/languages","stargazers_url":"https://api.github.com/repos/lepetinez/intive_training_app/stargazers","contributors_url":"https://api.github.com/repos/lepetinez/intive_training_app/contributors","subscribers_url":"https://api.github.com/repos/lepetinez/intive_training_app/subscribers","subscription_url":"https://api.github.com/repos/lepetinez/intive_training_app/subscription","commits_url":"https://api.github.com/repos/lepetinez/intive_training_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/lepetinez/intive_training_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/lepetinez/intive_training_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/lepetinez/intive_training_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/lepetinez/intive_training_app/contents/{+path}","compare_url":"https://api.github.com/repos/lepetinez/intive_training_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lepetinez/intive_training_app/merges","archive_url":"https://api.github.com/repos/lepetinez/intive_training_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lepetinez/intive_training_app/downloads","issues_url":"https://api.github.com/repos/lepetinez/intive_training_app/issues{/number}","pulls_url":"https://api.github.com/repos/lepetinez/intive_training_app/pulls{/number}","milestones_url":"https://api.github.com/repos/lepetinez/intive_training_app/milestones{/number}","notifications_url":"https://api.github.com/repos/lepetinez/intive_training_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lepetinez/intive_training_app/labels{/name}","releases_url":"https://api.github.com/repos/lepetinez/intive_training_app/releases{/id}","deployments_url":"https://api.github.com/repos/lepetinez/intive_training_app/deployments","created_at":"2018-08-02T12:37:07Z","updated_at":"2018-09-03T10:19:26Z","pushed_at":"2018-09-05T07:43:35Z","git_url":"git://github.com/lepetinez/intive_training_app.git","ssh_url":"git@github.com:lepetinez/intive_training_app.git","clone_url":"https://github.com/lepetinez/intive_training_app.git","svn_url":"https://github.com/lepetinez/intive_training_app","homepage":null,"size":3757,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"lepetinez:master","ref":"master","sha":"66b9b47b8889973f31e70979623bfaf8a7c84666","user":{"login":"lepetinez","id":17149880,"node_id":"MDQ6VXNlcjE3MTQ5ODgw","avatar_url":"https://avatars3.githubusercontent.com/u/17149880?v=4","gravatar_id":"","url":"https://api.github.com/users/lepetinez","html_url":"https://github.com/lepetinez","followers_url":"https://api.github.com/users/lepetinez/followers","following_url":"https://api.github.com/users/lepetinez/following{/other_user}","gists_url":"https://api.github.com/users/lepetinez/gists{/gist_id}","starred_url":"https://api.github.com/users/lepetinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepetinez/subscriptions","organizations_url":"https://api.github.com/users/lepetinez/orgs","repos_url":"https://api.github.com/users/lepetinez/repos","events_url":"https://api.github.com/users/lepetinez/events{/privacy}","received_events_url":"https://api.github.com/users/lepetinez/received_events","type":"User","site_admin":false},"repo":{"id":143292629,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyOTI2Mjk=","name":"intive_training_app","full_name":"lepetinez/intive_training_app","owner":{"login":"lepetinez","id":17149880,"node_id":"MDQ6VXNlcjE3MTQ5ODgw","avatar_url":"https://avatars3.githubusercontent.com/u/17149880?v=4","gravatar_id":"","url":"https://api.github.com/users/lepetinez","html_url":"https://github.com/lepetinez","followers_url":"https://api.github.com/users/lepetinez/followers","following_url":"https://api.github.com/users/lepetinez/following{/other_user}","gists_url":"https://api.github.com/users/lepetinez/gists{/gist_id}","starred_url":"https://api.github.com/users/lepetinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepetinez/subscriptions","organizations_url":"https://api.github.com/users/lepetinez/orgs","repos_url":"https://api.github.com/users/lepetinez/repos","events_url":"https://api.github.com/users/lepetinez/events{/privacy}","received_events_url":"https://api.github.com/users/lepetinez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lepetinez/intive_training_app","description":"Training app dedicated for self-learning (mainly jetpack features)","fork":false,"url":"https://api.github.com/repos/lepetinez/intive_training_app","forks_url":"https://api.github.com/repos/lepetinez/intive_training_app/forks","keys_url":"https://api.github.com/repos/lepetinez/intive_training_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lepetinez/intive_training_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lepetinez/intive_training_app/teams","hooks_url":"https://api.github.com/repos/lepetinez/intive_training_app/hooks","issue_events_url":"https://api.github.com/repos/lepetinez/intive_training_app/issues/events{/number}","events_url":"https://api.github.com/repos/lepetinez/intive_training_app/events","assignees_url":"https://api.github.com/repos/lepetinez/intive_training_app/assignees{/user}","branches_url":"https://api.github.com/repos/lepetinez/intive_training_app/branches{/branch}","tags_url":"https://api.github.com/repos/lepetinez/intive_training_app/tags","blobs_url":"https://api.github.com/repos/lepetinez/intive_training_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lepetinez/intive_training_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lepetinez/intive_training_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/lepetinez/intive_training_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lepetinez/intive_training_app/statuses/{sha}","languages_url":"https://api.github.com/repos/lepetinez/intive_training_app/languages","stargazers_url":"https://api.github.com/repos/lepetinez/intive_training_app/stargazers","contributors_url":"https://api.github.com/repos/lepetinez/intive_training_app/contributors","subscribers_url":"https://api.github.com/repos/lepetinez/intive_training_app/subscribers","subscription_url":"https://api.github.com/repos/lepetinez/intive_training_app/subscription","commits_url":"https://api.github.com/repos/lepetinez/intive_training_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/lepetinez/intive_training_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/lepetinez/intive_training_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/lepetinez/intive_training_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/lepetinez/intive_training_app/contents/{+path}","compare_url":"https://api.github.com/repos/lepetinez/intive_training_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lepetinez/intive_training_app/merges","archive_url":"https://api.github.com/repos/lepetinez/intive_training_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lepetinez/intive_training_app/downloads","issues_url":"https://api.github.com/repos/lepetinez/intive_training_app/issues{/number}","pulls_url":"https://api.github.com/repos/lepetinez/intive_training_app/pulls{/number}","milestones_url":"https://api.github.com/repos/lepetinez/intive_training_app/milestones{/number}","notifications_url":"https://api.github.com/repos/lepetinez/intive_training_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lepetinez/intive_training_app/labels{/name}","releases_url":"https://api.github.com/repos/lepetinez/intive_training_app/releases{/id}","deployments_url":"https://api.github.com/repos/lepetinez/intive_training_app/deployments","created_at":"2018-08-02T12:37:07Z","updated_at":"2018-09-03T10:19:26Z","pushed_at":"2018-09-05T07:43:35Z","git_url":"git://github.com/lepetinez/intive_training_app.git","ssh_url":"git@github.com:lepetinez/intive_training_app.git","clone_url":"https://github.com/lepetinez/intive_training_app.git","svn_url":"https://github.com/lepetinez/intive_training_app","homepage":null,"size":3757,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/9"},"html":{"href":"https://github.com/lepetinez/intive_training_app/pull/9"},"issue":{"href":"https://api.github.com/repos/lepetinez/intive_training_app/issues/9"},"comments":{"href":"https://api.github.com/repos/lepetinez/intive_training_app/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lepetinez/intive_training_app/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/lepetinez/intive_training_app/statuses/6433d3773090878623677cc8d9962cbcd4f405d9"}},"author_association":"OWNER"}}
{"actor":{"display_login":"lepetinez"}}