{"action":"created","issue":{"url":"https://api.github.com/repos/insites/cookieconsent/issues/418","repository_url":"https://api.github.com/repos/insites/cookieconsent","labels_url":"https://api.github.com/repos/insites/cookieconsent/issues/418/labels{/name}","comments_url":"https://api.github.com/repos/insites/cookieconsent/issues/418/comments","events_url":"https://api.github.com/repos/insites/cookieconsent/issues/418/events","html_url":"https://github.com/insites/cookieconsent/issues/418","id":343382645,"node_id":"MDU6SXNzdWUzNDMzODI2NDU=","number":418,"title":"Javascript generation from website not working for me.","user":{"login":"lordSeaworth","id":20868357,"node_id":"MDQ6VXNlcjIwODY4MzU3","avatar_url":"https://avatars2.githubusercontent.com/u/20868357?v=4","gravatar_id":"","url":"https://api.github.com/users/lordSeaworth","html_url":"https://github.com/lordSeaworth","followers_url":"https://api.github.com/users/lordSeaworth/followers","following_url":"https://api.github.com/users/lordSeaworth/following{/other_user}","gists_url":"https://api.github.com/users/lordSeaworth/gists{/gist_id}","starred_url":"https://api.github.com/users/lordSeaworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordSeaworth/subscriptions","organizations_url":"https://api.github.com/users/lordSeaworth/orgs","repos_url":"https://api.github.com/users/lordSeaworth/repos","events_url":"https://api.github.com/users/lordSeaworth/events{/privacy}","received_events_url":"https://api.github.com/users/lordSeaworth/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-22T06:54:26Z","updated_at":"2018-07-24T08:47:41Z","closed_at":"2018-07-23T16:23:45Z","author_association":"NONE","body":"I first found out about this service and tried the example but it seems it forgets to add the https to the path.\r\n\r\nWhen i copy-paste the text from the website it won't work.\r\n\r\nThis is the current basic example it lets me copy from the site.\r\n\r\n```\r\n<link rel=\"stylesheet\" type=\"text/css\" href=\"//cdnjs.cloudflare.com/ajax/libs/cookieconsent2/3.1.0/cookieconsent.min.css\" />\r\n<script src=\"//cdnjs.cloudflare.com/ajax/libs/cookieconsent2/3.1.0/cookieconsent.min.js\"></script>\r\n<script>\r\nwindow.addEventListener(\"load\", function(){\r\nwindow.cookieconsent.initialise({\r\n  \"palette\": {\r\n    \"popup\": {\r\n      \"background\": \"#000\"\r\n    },\r\n    \"button\": {\r\n      \"background\": \"#f1d600\"\r\n    }\r\n  }\r\n})});\r\n</script>\r\n```\r\n\r\n//cdnjs.cloudflare.com should be https://cdnjs.cloudflare.com in both accounts.\r\nUnless i'm mistaken."},"comment":{"url":"https://api.github.com/repos/insites/cookieconsent/issues/comments/407330654","html_url":"https://github.com/insites/cookieconsent/issues/418#issuecomment-407330654","issue_url":"https://api.github.com/repos/insites/cookieconsent/issues/418","id":407330654,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzMzMDY1NA==","user":{"login":"nebrot","id":6941112,"node_id":"MDQ6VXNlcjY5NDExMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/6941112?v=4","gravatar_id":"","url":"https://api.github.com/users/nebrot","html_url":"https://github.com/nebrot","followers_url":"https://api.github.com/users/nebrot/followers","following_url":"https://api.github.com/users/nebrot/following{/other_user}","gists_url":"https://api.github.com/users/nebrot/gists{/gist_id}","starred_url":"https://api.github.com/users/nebrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebrot/subscriptions","organizations_url":"https://api.github.com/users/nebrot/orgs","repos_url":"https://api.github.com/users/nebrot/repos","events_url":"https://api.github.com/users/nebrot/events{/privacy}","received_events_url":"https://api.github.com/users/nebrot/received_events","type":"User","site_admin":false},"created_at":"2018-07-24T08:47:41Z","updated_at":"2018-07-24T08:47:41Z","author_association":"NONE","body":"It's not best practice anymore to use protocol-relative URL (https://www.paulirish.com/2010/the-protocol-relative-url/)\r\n> Now that SSL is encouraged for everyone and doesn’t have performance concerns, this technique is now an anti-pattern. If the asset you need is available on SSL, then always use the https:// asset.\r\nAllowing the snippet to request over HTTP opens the door for attacks like the recent Github Man-on-the-side attack. It’s always safe to request HTTPS assets even if your site is on HTTP, however the reverse is not true. "}}
{"actor":{"display_login":"nebrot"}}