{"action":"created","comment":{"url":"https://api.github.com/repos/samwise-tech/search-ql/pulls/comments/175456752","pull_request_review_id":104980775,"id":175456752,"diff_hunk":"@@ -11,16 +10,20 @@\n     \"module\": \"commonjs\",\n     \"moduleResolution\": \"node\",\n     \"noEmitHelpers\": true,\n-    \"noImplicitAny\": true,\n     \"noImplicitReturns\": true,\n-    \"noImplicitThis\": true,\n-    \"noStrictGenericChecks\": true, // TEMPORARY\n+//    \"noStrictGenericChecks\": true, // TEMPORARY\n     \"noUnusedLocals\": true,\n     \"noUnusedParameters\": true,\n-    \"outDir\": \"lib\",\n     \"sourceMap\": true,\n     \"target\": \"es5\",\n-    \"types\": [\"chai\", \"mocha\", \"node\"]\n+\n+    // --strict\n+    \"alwaysStrict\": true,\n+    \"noImplicitAny\": true,\n+    \"noImplicitThis\": true,\n+    // \"strictNullChecks\": true, // can not be used due to wrong immutable typings\n+//    \"strictFunctionTypes\": true,\n+//    \"strictPropertyInitialization\": true","path":"tsconfig.json","position":30,"original_position":30,"commit_id":"e70276c1ed29dd4eb294d2ce175cffc314d5d172","original_commit_id":"e70276c1ed29dd4eb294d2ce175cffc314d5d172","user":{"login":"tomecko","id":2458313,"avatar_url":"https://avatars2.githubusercontent.com/u/2458313?v=4","gravatar_id":"","url":"https://api.github.com/users/tomecko","html_url":"https://github.com/tomecko","followers_url":"https://api.github.com/users/tomecko/followers","following_url":"https://api.github.com/users/tomecko/following{/other_user}","gists_url":"https://api.github.com/users/tomecko/gists{/gist_id}","starred_url":"https://api.github.com/users/tomecko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomecko/subscriptions","organizations_url":"https://api.github.com/users/tomecko/orgs","repos_url":"https://api.github.com/users/tomecko/repos","events_url":"https://api.github.com/users/tomecko/events{/privacy}","received_events_url":"https://api.github.com/users/tomecko/received_events","type":"User","site_admin":false},"body":"inconsistent formatting","created_at":"2018-03-19T14:36:58Z","updated_at":"2018-03-19T14:37:17Z","html_url":"https://github.com/samwise-tech/search-ql/pull/22#discussion_r175456752","pull_request_url":"https://api.github.com/repos/samwise-tech/search-ql/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/samwise-tech/search-ql/pulls/comments/175456752"},"html":{"href":"https://github.com/samwise-tech/search-ql/pull/22#discussion_r175456752"},"pull_request":{"href":"https://api.github.com/repos/samwise-tech/search-ql/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/samwise-tech/search-ql/pulls/22","id":175725882,"html_url":"https://github.com/samwise-tech/search-ql/pull/22","diff_url":"https://github.com/samwise-tech/search-ql/pull/22.diff","patch_url":"https://github.com/samwise-tech/search-ql/pull/22.patch","issue_url":"https://api.github.com/repos/samwise-tech/search-ql/issues/22","number":22,"state":"open","locked":false,"title":"PC-1098: Upgrades for advanced search highlight","user":{"login":"ulfryk","id":1754948,"avatar_url":"https://avatars3.githubusercontent.com/u/1754948?v=4","gravatar_id":"","url":"https://api.github.com/users/ulfryk","html_url":"https://github.com/ulfryk","followers_url":"https://api.github.com/users/ulfryk/followers","following_url":"https://api.github.com/users/ulfryk/following{/other_user}","gists_url":"https://api.github.com/users/ulfryk/gists{/gist_id}","starred_url":"https://api.github.com/users/ulfryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulfryk/subscriptions","organizations_url":"https://api.github.com/users/ulfryk/orgs","repos_url":"https://api.github.com/users/ulfryk/repos","events_url":"https://api.github.com/users/ulfryk/events{/privacy}","received_events_url":"https://api.github.com/users/ulfryk/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-17T23:03:39Z","updated_at":"2018-03-19T14:37:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34998bfc2064ecb5f70c3e8578e11cf72faadb64","assignee":{"login":"ulfryk","id":1754948,"avatar_url":"https://avatars3.githubusercontent.com/u/1754948?v=4","gravatar_id":"","url":"https://api.github.com/users/ulfryk","html_url":"https://github.com/ulfryk","followers_url":"https://api.github.com/users/ulfryk/followers","following_url":"https://api.github.com/users/ulfryk/following{/other_user}","gists_url":"https://api.github.com/users/ulfryk/gists{/gist_id}","starred_url":"https://api.github.com/users/ulfryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulfryk/subscriptions","organizations_url":"https://api.github.com/users/ulfryk/orgs","repos_url":"https://api.github.com/users/ulfryk/repos","events_url":"https://api.github.com/users/ulfryk/events{/privacy}","received_events_url":"https://api.github.com/users/ulfryk/received_events","type":"User","site_admin":false},"assignees":[{"login":"ulfryk","id":1754948,"avatar_url":"https://avatars3.githubusercontent.com/u/1754948?v=4","gravatar_id":"","url":"https://api.github.com/users/ulfryk","html_url":"https://github.com/ulfryk","followers_url":"https://api.github.com/users/ulfryk/followers","following_url":"https://api.github.com/users/ulfryk/following{/other_user}","gists_url":"https://api.github.com/users/ulfryk/gists{/gist_id}","starred_url":"https://api.github.com/users/ulfryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulfryk/subscriptions","organizations_url":"https://api.github.com/users/ulfryk/orgs","repos_url":"https://api.github.com/users/ulfryk/repos","events_url":"https://api.github.com/users/ulfryk/events{/privacy}","received_events_url":"https://api.github.com/users/ulfryk/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dumpstate","id":5636144,"avatar_url":"https://avatars2.githubusercontent.com/u/5636144?v=4","gravatar_id":"","url":"https://api.github.com/users/dumpstate","html_url":"https://github.com/dumpstate","followers_url":"https://api.github.com/users/dumpstate/followers","following_url":"https://api.github.com/users/dumpstate/following{/other_user}","gists_url":"https://api.github.com/users/dumpstate/gists{/gist_id}","starred_url":"https://api.github.com/users/dumpstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumpstate/subscriptions","organizations_url":"https://api.github.com/users/dumpstate/orgs","repos_url":"https://api.github.com/users/dumpstate/repos","events_url":"https://api.github.com/users/dumpstate/events{/privacy}","received_events_url":"https://api.github.com/users/dumpstate/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/samwise-tech/search-ql/pulls/22/commits","review_comments_url":"https://api.github.com/repos/samwise-tech/search-ql/pulls/22/comments","review_comment_url":"https://api.github.com/repos/samwise-tech/search-ql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samwise-tech/search-ql/issues/22/comments","statuses_url":"https://api.github.com/repos/samwise-tech/search-ql/statuses/e70276c1ed29dd4eb294d2ce175cffc314d5d172","head":{"label":"samwise-tech:feature/PC-1098-advanced-search-highlight","ref":"feature/PC-1098-advanced-search-highlight","sha":"e70276c1ed29dd4eb294d2ce175cffc314d5d172","user":{"login":"samwise-tech","id":19862249,"avatar_url":"https://avatars3.githubusercontent.com/u/19862249?v=4","gravatar_id":"","url":"https://api.github.com/users/samwise-tech","html_url":"https://github.com/samwise-tech","followers_url":"https://api.github.com/users/samwise-tech/followers","following_url":"https://api.github.com/users/samwise-tech/following{/other_user}","gists_url":"https://api.github.com/users/samwise-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/samwise-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samwise-tech/subscriptions","organizations_url":"https://api.github.com/users/samwise-tech/orgs","repos_url":"https://api.github.com/users/samwise-tech/repos","events_url":"https://api.github.com/users/samwise-tech/events{/privacy}","received_events_url":"https://api.github.com/users/samwise-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":103571635,"name":"search-ql","full_name":"samwise-tech/search-ql","owner":{"login":"samwise-tech","id":19862249,"avatar_url":"https://avatars3.githubusercontent.com/u/19862249?v=4","gravatar_id":"","url":"https://api.github.com/users/samwise-tech","html_url":"https://github.com/samwise-tech","followers_url":"https://api.github.com/users/samwise-tech/followers","following_url":"https://api.github.com/users/samwise-tech/following{/other_user}","gists_url":"https://api.github.com/users/samwise-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/samwise-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samwise-tech/subscriptions","organizations_url":"https://api.github.com/users/samwise-tech/orgs","repos_url":"https://api.github.com/users/samwise-tech/repos","events_url":"https://api.github.com/users/samwise-tech/events{/privacy}","received_events_url":"https://api.github.com/users/samwise-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samwise-tech/search-ql","description":"QL used for advanced searches in Samwise applications","fork":false,"url":"https://api.github.com/repos/samwise-tech/search-ql","forks_url":"https://api.github.com/repos/samwise-tech/search-ql/forks","keys_url":"https://api.github.com/repos/samwise-tech/search-ql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samwise-tech/search-ql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samwise-tech/search-ql/teams","hooks_url":"https://api.github.com/repos/samwise-tech/search-ql/hooks","issue_events_url":"https://api.github.com/repos/samwise-tech/search-ql/issues/events{/number}","events_url":"https://api.github.com/repos/samwise-tech/search-ql/events","assignees_url":"https://api.github.com/repos/samwise-tech/search-ql/assignees{/user}","branches_url":"https://api.github.com/repos/samwise-tech/search-ql/branches{/branch}","tags_url":"https://api.github.com/repos/samwise-tech/search-ql/tags","blobs_url":"https://api.github.com/repos/samwise-tech/search-ql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samwise-tech/search-ql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samwise-tech/search-ql/git/refs{/sha}","trees_url":"https://api.github.com/repos/samwise-tech/search-ql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samwise-tech/search-ql/statuses/{sha}","languages_url":"https://api.github.com/repos/samwise-tech/search-ql/languages","stargazers_url":"https://api.github.com/repos/samwise-tech/search-ql/stargazers","contributors_url":"https://api.github.com/repos/samwise-tech/search-ql/contributors","subscribers_url":"https://api.github.com/repos/samwise-tech/search-ql/subscribers","subscription_url":"https://api.github.com/repos/samwise-tech/search-ql/subscription","commits_url":"https://api.github.com/repos/samwise-tech/search-ql/commits{/sha}","git_commits_url":"https://api.github.com/repos/samwise-tech/search-ql/git/commits{/sha}","comments_url":"https://api.github.com/repos/samwise-tech/search-ql/comments{/number}","issue_comment_url":"https://api.github.com/repos/samwise-tech/search-ql/issues/comments{/number}","contents_url":"https://api.github.com/repos/samwise-tech/search-ql/contents/{+path}","compare_url":"https://api.github.com/repos/samwise-tech/search-ql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samwise-tech/search-ql/merges","archive_url":"https://api.github.com/repos/samwise-tech/search-ql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samwise-tech/search-ql/downloads","issues_url":"https://api.github.com/repos/samwise-tech/search-ql/issues{/number}","pulls_url":"https://api.github.com/repos/samwise-tech/search-ql/pulls{/number}","milestones_url":"https://api.github.com/repos/samwise-tech/search-ql/milestones{/number}","notifications_url":"https://api.github.com/repos/samwise-tech/search-ql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samwise-tech/search-ql/labels{/name}","releases_url":"https://api.github.com/repos/samwise-tech/search-ql/releases{/id}","deployments_url":"https://api.github.com/repos/samwise-tech/search-ql/deployments","created_at":"2017-09-14T19:12:20Z","updated_at":"2018-02-21T08:45:45Z","pushed_at":"2018-03-19T12:36:11Z","git_url":"git://github.com/samwise-tech/search-ql.git","ssh_url":"git@github.com:samwise-tech/search-ql.git","clone_url":"https://github.com/samwise-tech/search-ql.git","svn_url":"https://github.com/samwise-tech/search-ql","homepage":null,"size":299,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"samwise-tech:develop","ref":"develop","sha":"c88ceff2a0670a58df5771c01d6568033a485170","user":{"login":"samwise-tech","id":19862249,"avatar_url":"https://avatars3.githubusercontent.com/u/19862249?v=4","gravatar_id":"","url":"https://api.github.com/users/samwise-tech","html_url":"https://github.com/samwise-tech","followers_url":"https://api.github.com/users/samwise-tech/followers","following_url":"https://api.github.com/users/samwise-tech/following{/other_user}","gists_url":"https://api.github.com/users/samwise-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/samwise-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samwise-tech/subscriptions","organizations_url":"https://api.github.com/users/samwise-tech/orgs","repos_url":"https://api.github.com/users/samwise-tech/repos","events_url":"https://api.github.com/users/samwise-tech/events{/privacy}","received_events_url":"https://api.github.com/users/samwise-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":103571635,"name":"search-ql","full_name":"samwise-tech/search-ql","owner":{"login":"samwise-tech","id":19862249,"avatar_url":"https://avatars3.githubusercontent.com/u/19862249?v=4","gravatar_id":"","url":"https://api.github.com/users/samwise-tech","html_url":"https://github.com/samwise-tech","followers_url":"https://api.github.com/users/samwise-tech/followers","following_url":"https://api.github.com/users/samwise-tech/following{/other_user}","gists_url":"https://api.github.com/users/samwise-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/samwise-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samwise-tech/subscriptions","organizations_url":"https://api.github.com/users/samwise-tech/orgs","repos_url":"https://api.github.com/users/samwise-tech/repos","events_url":"https://api.github.com/users/samwise-tech/events{/privacy}","received_events_url":"https://api.github.com/users/samwise-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samwise-tech/search-ql","description":"QL used for advanced searches in Samwise applications","fork":false,"url":"https://api.github.com/repos/samwise-tech/search-ql","forks_url":"https://api.github.com/repos/samwise-tech/search-ql/forks","keys_url":"https://api.github.com/repos/samwise-tech/search-ql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samwise-tech/search-ql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samwise-tech/search-ql/teams","hooks_url":"https://api.github.com/repos/samwise-tech/search-ql/hooks","issue_events_url":"https://api.github.com/repos/samwise-tech/search-ql/issues/events{/number}","events_url":"https://api.github.com/repos/samwise-tech/search-ql/events","assignees_url":"https://api.github.com/repos/samwise-tech/search-ql/assignees{/user}","branches_url":"https://api.github.com/repos/samwise-tech/search-ql/branches{/branch}","tags_url":"https://api.github.com/repos/samwise-tech/search-ql/tags","blobs_url":"https://api.github.com/repos/samwise-tech/search-ql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samwise-tech/search-ql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samwise-tech/search-ql/git/refs{/sha}","trees_url":"https://api.github.com/repos/samwise-tech/search-ql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samwise-tech/search-ql/statuses/{sha}","languages_url":"https://api.github.com/repos/samwise-tech/search-ql/languages","stargazers_url":"https://api.github.com/repos/samwise-tech/search-ql/stargazers","contributors_url":"https://api.github.com/repos/samwise-tech/search-ql/contributors","subscribers_url":"https://api.github.com/repos/samwise-tech/search-ql/subscribers","subscription_url":"https://api.github.com/repos/samwise-tech/search-ql/subscription","commits_url":"https://api.github.com/repos/samwise-tech/search-ql/commits{/sha}","git_commits_url":"https://api.github.com/repos/samwise-tech/search-ql/git/commits{/sha}","comments_url":"https://api.github.com/repos/samwise-tech/search-ql/comments{/number}","issue_comment_url":"https://api.github.com/repos/samwise-tech/search-ql/issues/comments{/number}","contents_url":"https://api.github.com/repos/samwise-tech/search-ql/contents/{+path}","compare_url":"https://api.github.com/repos/samwise-tech/search-ql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samwise-tech/search-ql/merges","archive_url":"https://api.github.com/repos/samwise-tech/search-ql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samwise-tech/search-ql/downloads","issues_url":"https://api.github.com/repos/samwise-tech/search-ql/issues{/number}","pulls_url":"https://api.github.com/repos/samwise-tech/search-ql/pulls{/number}","milestones_url":"https://api.github.com/repos/samwise-tech/search-ql/milestones{/number}","notifications_url":"https://api.github.com/repos/samwise-tech/search-ql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samwise-tech/search-ql/labels{/name}","releases_url":"https://api.github.com/repos/samwise-tech/search-ql/releases{/id}","deployments_url":"https://api.github.com/repos/samwise-tech/search-ql/deployments","created_at":"2017-09-14T19:12:20Z","updated_at":"2018-02-21T08:45:45Z","pushed_at":"2018-03-19T12:36:11Z","git_url":"git://github.com/samwise-tech/search-ql.git","ssh_url":"git@github.com:samwise-tech/search-ql.git","clone_url":"https://github.com/samwise-tech/search-ql.git","svn_url":"https://github.com/samwise-tech/search-ql","homepage":null,"size":299,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/samwise-tech/search-ql/pulls/22"},"html":{"href":"https://github.com/samwise-tech/search-ql/pull/22"},"issue":{"href":"https://api.github.com/repos/samwise-tech/search-ql/issues/22"},"comments":{"href":"https://api.github.com/repos/samwise-tech/search-ql/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/samwise-tech/search-ql/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/samwise-tech/search-ql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samwise-tech/search-ql/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/samwise-tech/search-ql/statuses/e70276c1ed29dd4eb294d2ce175cffc314d5d172"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tomecko"}}