{"action":"created","issue":{"url":"https://api.github.com/repos/flutter/flutter/issues/17928","repository_url":"https://api.github.com/repos/flutter/flutter","labels_url":"https://api.github.com/repos/flutter/flutter/issues/17928/labels{/name}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/17928/comments","events_url":"https://api.github.com/repos/flutter/flutter/issues/17928/events","html_url":"https://github.com/flutter/flutter/issues/17928","id":326694794,"node_id":"MDU6SXNzdWUzMjY2OTQ3OTQ=","number":17928,"title":"Feature Request: Material-compliant 'standard' bottom sheets","user":{"login":"johnfesa","id":33298326,"node_id":"MDQ6VXNlcjMzMjk4MzI2","avatar_url":"https://avatars0.githubusercontent.com/u/33298326?v=4","gravatar_id":"","url":"https://api.github.com/users/johnfesa","html_url":"https://github.com/johnfesa","followers_url":"https://api.github.com/users/johnfesa/followers","following_url":"https://api.github.com/users/johnfesa/following{/other_user}","gists_url":"https://api.github.com/users/johnfesa/gists{/gist_id}","starred_url":"https://api.github.com/users/johnfesa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnfesa/subscriptions","organizations_url":"https://api.github.com/users/johnfesa/orgs","repos_url":"https://api.github.com/users/johnfesa/repos","events_url":"https://api.github.com/users/johnfesa/events{/privacy}","received_events_url":"https://api.github.com/users/johnfesa/received_events","type":"User","site_admin":false},"labels":[{"id":404497317,"node_id":"MDU6TGFiZWw0MDQ0OTczMTc=","url":"https://api.github.com/repos/flutter/flutter/labels/a:%20fidelity","name":"a: fidelity","color":"38d8c8","default":false},{"id":469500179,"node_id":"MDU6TGFiZWw0Njk1MDAxNzk=","url":"https://api.github.com/repos/flutter/flutter/labels/customer:%20mulligan%20(g3)","name":"customer: mulligan (g3)","color":"bfe5bf","default":false},{"id":288585660,"node_id":"MDU6TGFiZWwyODg1ODU2NjA=","url":"https://api.github.com/repos/flutter/flutter/labels/f:%20material%20design","name":"f: material design","color":"207de5","default":false},{"id":284437560,"node_id":"MDU6TGFiZWwyODQ0Mzc1NjA=","url":"https://api.github.com/repos/flutter/flutter/labels/framework","name":"framework","color":"207de5","default":false},{"id":633132914,"node_id":"MDU6TGFiZWw2MzMxMzI5MTQ=","url":"https://api.github.com/repos/flutter/flutter/labels/severe:%20customer%20critical","name":"severe: customer critical","color":"905050","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/flutter/flutter/milestones/25","html_url":"https://github.com/flutter/flutter/milestone/25","labels_url":"https://api.github.com/repos/flutter/flutter/milestones/25/labels","id":3276194,"node_id":"MDk6TWlsZXN0b25lMzI3NjE5NA==","number":25,"title":"bucket5","description":"","creator":{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":11,"state":"closed","created_at":"2018-04-17T23:48:41Z","updated_at":"2018-06-19T19:29:44Z","due_on":"2018-06-12T07:00:00Z","closed_at":"2018-06-19T19:29:44Z"},"comments":5,"created_at":"2018-05-26T00:23:03Z","updated_at":"2018-12-07T16:48:58Z","closed_at":"2018-06-12T21:28:25Z","author_association":"NONE","body":"The existing functionality for displaying a \"persistent bottom sheet\" seems like it's intended to behave like what the Material spec now calls a \"[standard bottom sheet](https://material.io/design/components/sheets-bottom.html#standard-bottom-sheet)\", but the implementation doesn't behave like the Material spec in a couple of ways and the API doesn't really work well for typical usage scenarios.\r\n\r\nMulligan has a UX-approved design for features that requires this functionality.\r\n\r\nOutline of acceptance criteria based on the design:\r\n1. The spec mentions that a standard bottom sheet _may_ appear, but we also need the ability to ergonomically create a Scaffold that, at construction time, specifies a standard bottom sheet.\r\n2. The bottom sheet should be separately modifiable after construction of the Scaffold; this may mean changing height based on its contents changing, without direct user interaction.\r\n3. The bottom sheet shouldn't be able to be swiped off the screen. Maybe make this a configuration option, but the Material spec only describes _modal_ bottom sheets as being dismissible. Not standard (or 'persistent') bottom sheets.\r\n4. The standard bottom sheet shouldn't interact with the back/close button in the Scaffold or routes. Or at least this should not be the default behavior/it should be opt-in. It seems more useful to do this if the bottom sheet can expand to a full-screen treatment, which the Material spec documents bottom sheets can do, but we don't need this full-screen-expansion treatment at this time.\r\n\r\nReferences:\r\nhttps://docs.flutter.io/flutter/material/ScaffoldState/showBottomSheet.html\r\nhttps://github.com/flutter/flutter/blob/7587f54b204a61c1dbe84926caf3330d635cfa62/examples/flutter_gallery/lib/demo/material/persistent_bottom_sheet_demo.dart"},"comment":{"url":"https://api.github.com/repos/flutter/flutter/issues/comments/445293334","html_url":"https://github.com/flutter/flutter/issues/17928#issuecomment-445293334","issue_url":"https://api.github.com/repos/flutter/flutter/issues/17928","id":445293334,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTI5MzMzNA==","user":{"login":"kjeremy","id":4325700,"node_id":"MDQ6VXNlcjQzMjU3MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4325700?v=4","gravatar_id":"","url":"https://api.github.com/users/kjeremy","html_url":"https://github.com/kjeremy","followers_url":"https://api.github.com/users/kjeremy/followers","following_url":"https://api.github.com/users/kjeremy/following{/other_user}","gists_url":"https://api.github.com/users/kjeremy/gists{/gist_id}","starred_url":"https://api.github.com/users/kjeremy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjeremy/subscriptions","organizations_url":"https://api.github.com/users/kjeremy/orgs","repos_url":"https://api.github.com/users/kjeremy/repos","events_url":"https://api.github.com/users/kjeremy/events{/privacy}","received_events_url":"https://api.github.com/users/kjeremy/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T16:48:58Z","updated_at":"2018-12-07T16:48:58Z","author_association":"NONE","body":"@feinstein That's disappointing. Where is the animated bottom sheet in shrine? The only one I see is the modal one when displaying the shopping cart."}}
{"actor":{"display_login":"kjeremy"}}