{"action":"closed","number":377,"pull_request":{"url":"https://api.github.com/repos/freenas/webui/pulls/377","id":168090086,"html_url":"https://github.com/freenas/webui/pull/377","diff_url":"https://github.com/freenas/webui/pull/377.diff","patch_url":"https://github.com/freenas/webui/pull/377.patch","issue_url":"https://api.github.com/repos/freenas/webui/issues/377","number":377,"state":"closed","locked":false,"title":"Fix 27929","user":{"login":"psouthwell","id":10716616,"avatar_url":"https://avatars1.githubusercontent.com/u/10716616?v=4","gravatar_id":"","url":"https://api.github.com/users/psouthwell","html_url":"https://github.com/psouthwell","followers_url":"https://api.github.com/users/psouthwell/followers","following_url":"https://api.github.com/users/psouthwell/following{/other_user}","gists_url":"https://api.github.com/users/psouthwell/gists{/gist_id}","starred_url":"https://api.github.com/users/psouthwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psouthwell/subscriptions","organizations_url":"https://api.github.com/users/psouthwell/orgs","repos_url":"https://api.github.com/users/psouthwell/repos","events_url":"https://api.github.com/users/psouthwell/events{/privacy}","received_events_url":"https://api.github.com/users/psouthwell/received_events","type":"User","site_admin":false},"body":"Special request erin.\r\n\r\nIve removed dialogService from the WebsocketService.\r\n\r\nReason being that it comes up at a time in my case. .I didn't want to display it...\r\n\r\nIt can be invoked again.. Using hte subscription error method.. For example..\r\n\r\nwebsocketservice.call(\"someapi\", {}).subscrit((response)=>{\r\n                   // Normal code we all use now... Handles the resposne\r\n}, (error)=> {\r\n           // A method that I dont' see many of us using.. but is here and where I think \r\n           // the dialog service invoke should be.. So.. The UI comnponents.. Can customize\r\n           // whats done with the error.\r\n            this.dialogService.error(....);\r\n});\r\n\r\nas opposed to having the error being internal.. and un overrideable.. in the bowels of websocektservice.onmessage(...).... If that makes sense... \r\n\r\n\r\nSo... Lets see if you agree...  \r\n\r\nthe original bug\r\n\r\nhttps://redmine.ixsystems.com/issues/27929\r\n\r\n\r\nIs not reporoducable.. I thought it might be on a totally fresh... But I took nightly from today.. Made sure it's updated by trying an update (It said it was already updated)...\r\n\r\nAnd the UI works fine.. DOn't get the missing aggreation-cpu-sum path error.\r\n\r\nHowever.. I did put this in.. To protect against it.. And in the chart cases... Log the error instead of showing a dialog.. Whhen a dataset isn't found ;)","created_at":"2018-02-08T21:20:33Z","updated_at":"2018-02-09T17:12:26Z","closed_at":"2018-02-09T17:12:26Z","merged_at":null,"merge_commit_sha":"d96b9f23b8553a22d3e336e829e51bdee4f2ce40","assignee":{"login":"erinix","id":1542251,"avatar_url":"https://avatars0.githubusercontent.com/u/1542251?v=4","gravatar_id":"","url":"https://api.github.com/users/erinix","html_url":"https://github.com/erinix","followers_url":"https://api.github.com/users/erinix/followers","following_url":"https://api.github.com/users/erinix/following{/other_user}","gists_url":"https://api.github.com/users/erinix/gists{/gist_id}","starred_url":"https://api.github.com/users/erinix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erinix/subscriptions","organizations_url":"https://api.github.com/users/erinix/orgs","repos_url":"https://api.github.com/users/erinix/repos","events_url":"https://api.github.com/users/erinix/events{/privacy}","received_events_url":"https://api.github.com/users/erinix/received_events","type":"User","site_admin":false},"assignees":[{"login":"erinix","id":1542251,"avatar_url":"https://avatars0.githubusercontent.com/u/1542251?v=4","gravatar_id":"","url":"https://api.github.com/users/erinix","html_url":"https://github.com/erinix","followers_url":"https://api.github.com/users/erinix/followers","following_url":"https://api.github.com/users/erinix/following{/other_user}","gists_url":"https://api.github.com/users/erinix/gists{/gist_id}","starred_url":"https://api.github.com/users/erinix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erinix/subscriptions","organizations_url":"https://api.github.com/users/erinix/orgs","repos_url":"https://api.github.com/users/erinix/repos","events_url":"https://api.github.com/users/erinix/events{/privacy}","received_events_url":"https://api.github.com/users/erinix/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"erinix","id":1542251,"avatar_url":"https://avatars0.githubusercontent.com/u/1542251?v=4","gravatar_id":"","url":"https://api.github.com/users/erinix","html_url":"https://github.com/erinix","followers_url":"https://api.github.com/users/erinix/followers","following_url":"https://api.github.com/users/erinix/following{/other_user}","gists_url":"https://api.github.com/users/erinix/gists{/gist_id}","starred_url":"https://api.github.com/users/erinix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erinix/subscriptions","organizations_url":"https://api.github.com/users/erinix/orgs","repos_url":"https://api.github.com/users/erinix/repos","events_url":"https://api.github.com/users/erinix/events{/privacy}","received_events_url":"https://api.github.com/users/erinix/received_events","type":"User","site_admin":false},{"login":"lola27","id":8516787,"avatar_url":"https://avatars1.githubusercontent.com/u/8516787?v=4","gravatar_id":"","url":"https://api.github.com/users/lola27","html_url":"https://github.com/lola27","followers_url":"https://api.github.com/users/lola27/followers","following_url":"https://api.github.com/users/lola27/following{/other_user}","gists_url":"https://api.github.com/users/lola27/gists{/gist_id}","starred_url":"https://api.github.com/users/lola27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lola27/subscriptions","organizations_url":"https://api.github.com/users/lola27/orgs","repos_url":"https://api.github.com/users/lola27/repos","events_url":"https://api.github.com/users/lola27/events{/privacy}","received_events_url":"https://api.github.com/users/lola27/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freenas/webui/pulls/377/commits","review_comments_url":"https://api.github.com/repos/freenas/webui/pulls/377/comments","review_comment_url":"https://api.github.com/repos/freenas/webui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freenas/webui/issues/377/comments","statuses_url":"https://api.github.com/repos/freenas/webui/statuses/82d065d577f947237d72d24dbe89cb98a88ed041","head":{"label":"freenas:fix_27929","ref":"fix_27929","sha":"82d065d577f947237d72d24dbe89cb98a88ed041","user":{"login":"freenas","id":3792476,"avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"repo":{"id":90044084,"name":"webui","full_name":"freenas/webui","owner":{"login":"freenas","id":3792476,"avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freenas/webui","description":"FreeNAS Angular 4.x UI","fork":false,"url":"https://api.github.com/repos/freenas/webui","forks_url":"https://api.github.com/repos/freenas/webui/forks","keys_url":"https://api.github.com/repos/freenas/webui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenas/webui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenas/webui/teams","hooks_url":"https://api.github.com/repos/freenas/webui/hooks","issue_events_url":"https://api.github.com/repos/freenas/webui/issues/events{/number}","events_url":"https://api.github.com/repos/freenas/webui/events","assignees_url":"https://api.github.com/repos/freenas/webui/assignees{/user}","branches_url":"https://api.github.com/repos/freenas/webui/branches{/branch}","tags_url":"https://api.github.com/repos/freenas/webui/tags","blobs_url":"https://api.github.com/repos/freenas/webui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenas/webui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenas/webui/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenas/webui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenas/webui/statuses/{sha}","languages_url":"https://api.github.com/repos/freenas/webui/languages","stargazers_url":"https://api.github.com/repos/freenas/webui/stargazers","contributors_url":"https://api.github.com/repos/freenas/webui/contributors","subscribers_url":"https://api.github.com/repos/freenas/webui/subscribers","subscription_url":"https://api.github.com/repos/freenas/webui/subscription","commits_url":"https://api.github.com/repos/freenas/webui/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenas/webui/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenas/webui/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenas/webui/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenas/webui/contents/{+path}","compare_url":"https://api.github.com/repos/freenas/webui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenas/webui/merges","archive_url":"https://api.github.com/repos/freenas/webui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenas/webui/downloads","issues_url":"https://api.github.com/repos/freenas/webui/issues{/number}","pulls_url":"https://api.github.com/repos/freenas/webui/pulls{/number}","milestones_url":"https://api.github.com/repos/freenas/webui/milestones{/number}","notifications_url":"https://api.github.com/repos/freenas/webui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenas/webui/labels{/name}","releases_url":"https://api.github.com/repos/freenas/webui/releases{/id}","deployments_url":"https://api.github.com/repos/freenas/webui/deployments","created_at":"2017-05-02T14:42:01Z","updated_at":"2018-01-20T11:16:53Z","pushed_at":"2018-02-09T16:04:22Z","git_url":"git://github.com/freenas/webui.git","ssh_url":"git@github.com:freenas/webui.git","clone_url":"https://github.com/freenas/webui.git","svn_url":"https://github.com/freenas/webui","homepage":null,"size":19237,"stargazers_count":38,"watchers_count":38,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":16,"open_issues":4,"watchers":38,"default_branch":"master"}},"base":{"label":"freenas:master","ref":"master","sha":"9cbbac60824586875315e07ccfe06fcc492f9358","user":{"login":"freenas","id":3792476,"avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"repo":{"id":90044084,"name":"webui","full_name":"freenas/webui","owner":{"login":"freenas","id":3792476,"avatar_url":"https://avatars2.githubusercontent.com/u/3792476?v=4","gravatar_id":"","url":"https://api.github.com/users/freenas","html_url":"https://github.com/freenas","followers_url":"https://api.github.com/users/freenas/followers","following_url":"https://api.github.com/users/freenas/following{/other_user}","gists_url":"https://api.github.com/users/freenas/gists{/gist_id}","starred_url":"https://api.github.com/users/freenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenas/subscriptions","organizations_url":"https://api.github.com/users/freenas/orgs","repos_url":"https://api.github.com/users/freenas/repos","events_url":"https://api.github.com/users/freenas/events{/privacy}","received_events_url":"https://api.github.com/users/freenas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freenas/webui","description":"FreeNAS Angular 4.x UI","fork":false,"url":"https://api.github.com/repos/freenas/webui","forks_url":"https://api.github.com/repos/freenas/webui/forks","keys_url":"https://api.github.com/repos/freenas/webui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenas/webui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenas/webui/teams","hooks_url":"https://api.github.com/repos/freenas/webui/hooks","issue_events_url":"https://api.github.com/repos/freenas/webui/issues/events{/number}","events_url":"https://api.github.com/repos/freenas/webui/events","assignees_url":"https://api.github.com/repos/freenas/webui/assignees{/user}","branches_url":"https://api.github.com/repos/freenas/webui/branches{/branch}","tags_url":"https://api.github.com/repos/freenas/webui/tags","blobs_url":"https://api.github.com/repos/freenas/webui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenas/webui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenas/webui/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenas/webui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenas/webui/statuses/{sha}","languages_url":"https://api.github.com/repos/freenas/webui/languages","stargazers_url":"https://api.github.com/repos/freenas/webui/stargazers","contributors_url":"https://api.github.com/repos/freenas/webui/contributors","subscribers_url":"https://api.github.com/repos/freenas/webui/subscribers","subscription_url":"https://api.github.com/repos/freenas/webui/subscription","commits_url":"https://api.github.com/repos/freenas/webui/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenas/webui/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenas/webui/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenas/webui/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenas/webui/contents/{+path}","compare_url":"https://api.github.com/repos/freenas/webui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenas/webui/merges","archive_url":"https://api.github.com/repos/freenas/webui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenas/webui/downloads","issues_url":"https://api.github.com/repos/freenas/webui/issues{/number}","pulls_url":"https://api.github.com/repos/freenas/webui/pulls{/number}","milestones_url":"https://api.github.com/repos/freenas/webui/milestones{/number}","notifications_url":"https://api.github.com/repos/freenas/webui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenas/webui/labels{/name}","releases_url":"https://api.github.com/repos/freenas/webui/releases{/id}","deployments_url":"https://api.github.com/repos/freenas/webui/deployments","created_at":"2017-05-02T14:42:01Z","updated_at":"2018-01-20T11:16:53Z","pushed_at":"2018-02-09T16:04:22Z","git_url":"git://github.com/freenas/webui.git","ssh_url":"git@github.com:freenas/webui.git","clone_url":"https://github.com/freenas/webui.git","svn_url":"https://github.com/freenas/webui","homepage":null,"size":19237,"stargazers_count":38,"watchers_count":38,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":16,"open_issues":4,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freenas/webui/pulls/377"},"html":{"href":"https://github.com/freenas/webui/pull/377"},"issue":{"href":"https://api.github.com/repos/freenas/webui/issues/377"},"comments":{"href":"https://api.github.com/repos/freenas/webui/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/freenas/webui/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/freenas/webui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freenas/webui/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/freenas/webui/statuses/82d065d577f947237d72d24dbe89cb98a88ed041"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":33,"deletions":30,"changed_files":2}}
{"actor":{"display_login":"psouthwell"}}