{"action":"created","issue":{"url":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/16","repository_url":"https://api.github.com/repos/starlingx-staging/stx-horizon","labels_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/16/comments","events_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/16/events","html_url":"https://github.com/starlingx-staging/stx-horizon/pull/16","id":368772151,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODcyMzE3","number":16,"title":"Force user logout before token expiry","user":{"login":"dsullivanwr","id":43448479,"node_id":"MDQ6VXNlcjQzNDQ4NDc5","avatar_url":"https://avatars3.githubusercontent.com/u/43448479?v=4","gravatar_id":"","url":"https://api.github.com/users/dsullivanwr","html_url":"https://github.com/dsullivanwr","followers_url":"https://api.github.com/users/dsullivanwr/followers","following_url":"https://api.github.com/users/dsullivanwr/following{/other_user}","gists_url":"https://api.github.com/users/dsullivanwr/gists{/gist_id}","starred_url":"https://api.github.com/users/dsullivanwr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsullivanwr/subscriptions","organizations_url":"https://api.github.com/users/dsullivanwr/orgs","repos_url":"https://api.github.com/users/dsullivanwr/repos","events_url":"https://api.github.com/users/dsullivanwr/events{/privacy}","received_events_url":"https://api.github.com/users/dsullivanwr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-10T17:29:43Z","updated_at":"2018-10-11T17:04:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/starlingx-staging/stx-horizon/pulls/16","html_url":"https://github.com/starlingx-staging/stx-horizon/pull/16","diff_url":"https://github.com/starlingx-staging/stx-horizon/pull/16.diff","patch_url":"https://github.com/starlingx-staging/stx-horizon/pull/16.patch"},"body":"If a horizon user's token expires during long running operations, those\r\noperations can fail. This occured during long running heat operations\r\n(eg multiple stack deletions). We address this by setting the\r\nTOKEN_TIMEOUT_MARGIN to 10 minutes. This will log the user out 10\r\nminutes before the token expires.\r\n\r\nWe also set the horizon session timeout to 50 minutes for clarity.\r\n\r\nThe newtoken code was previously added under the assumption that the\r\ntoken could be extended. This is incorrect and that code has been\r\nremoved.\r\n\r\nPartial-Bug: 1797186\r\nSigned-off-by: David Sullivan <david.sullivan@windriver.com>"},"comment":{"url":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/comments/429037363","html_url":"https://github.com/starlingx-staging/stx-horizon/pull/16#issuecomment-429037363","issue_url":"https://api.github.com/repos/starlingx-staging/stx-horizon/issues/16","id":429037363,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTAzNzM2Mw==","user":{"login":"dsullivanwr","id":43448479,"node_id":"MDQ6VXNlcjQzNDQ4NDc5","avatar_url":"https://avatars3.githubusercontent.com/u/43448479?v=4","gravatar_id":"","url":"https://api.github.com/users/dsullivanwr","html_url":"https://github.com/dsullivanwr","followers_url":"https://api.github.com/users/dsullivanwr/followers","following_url":"https://api.github.com/users/dsullivanwr/following{/other_user}","gists_url":"https://api.github.com/users/dsullivanwr/gists{/gist_id}","starred_url":"https://api.github.com/users/dsullivanwr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsullivanwr/subscriptions","organizations_url":"https://api.github.com/users/dsullivanwr/orgs","repos_url":"https://api.github.com/users/dsullivanwr/repos","events_url":"https://api.github.com/users/dsullivanwr/events{/privacy}","received_events_url":"https://api.github.com/users/dsullivanwr/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T17:04:06Z","updated_at":"2018-10-11T17:04:06Z","author_association":"NONE","body":"That sounds like a much better option, I was wondering why we would do that here. Let me try that fix and I'll update this PR."}}
{"actor":{"display_login":"dsullivanwr"}}