{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/897","repository_url":"https://api.github.com/repos/openshift/ansible-service-broker","labels_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/897/labels{/name}","comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/897/comments","events_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/897/events","html_url":"https://github.com/openshift/ansible-service-broker/pull/897","id":315957990,"number":897,"title":"Bug 1569220 - Add dashboard redirector feature","user":{"login":"eriknelson","id":410933,"avatar_url":"https://avatars3.githubusercontent.com/u/410933?v=4","gravatar_id":"","url":"https://api.github.com/users/eriknelson","html_url":"https://github.com/eriknelson","followers_url":"https://api.github.com/users/eriknelson/followers","following_url":"https://api.github.com/users/eriknelson/following{/other_user}","gists_url":"https://api.github.com/users/eriknelson/gists{/gist_id}","starred_url":"https://api.github.com/users/eriknelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriknelson/subscriptions","organizations_url":"https://api.github.com/users/eriknelson/orgs","repos_url":"https://api.github.com/users/eriknelson/repos","events_url":"https://api.github.com/users/eriknelson/events{/privacy}","received_events_url":"https://api.github.com/users/eriknelson/received_events","type":"User","site_admin":false},"labels":[{"id":693604972,"url":"https://api.github.com/repos/openshift/ansible-service-broker/labels/needs-review","name":"needs-review","color":"d93f0b","default":false},{"id":711739419,"url":"https://api.github.com/repos/openshift/ansible-service-broker/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-19T16:48:20Z","updated_at":"2018-04-20T14:04:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/897","html_url":"https://github.com/openshift/ansible-service-broker/pull/897","diff_url":"https://github.com/openshift/ansible-service-broker/pull/897.diff","patch_url":"https://github.com/openshift/ansible-service-broker/pull/897.patch"},"body":"#### Describe what this PR does and why we need it:\r\nThis PR adds support for async provisioned dashboard urls. This is [currently not possible with the OSB spec](https://github.com/openservicebrokerapi/servicebroker/issues/4980), so our solution is to add a redirect service that runs alongside the broker. The broker immediately returns a URL to the redirector service as a sort of \"future\" url, that will ultimately redirect to an APB's specified `dashboard_url` location at the conclusion of its provision run.\r\n\r\nA few notes:\r\n* This feature requires an APB to be built on top of an `apb-base` that carries the dashboard redirector ansible module.\r\n* The broker author must specify in an `alpha` section of their APB spec that they would like to enable this feature. [Example APB](https://github.com/eriknelson/dashboard-url-apb/blob/master/apb.yml#L14).\r\n* The deployment of the broker must have the route to the dashboard redirector service specified in the broker's configmap. [We have a sensible default configured in the template for this](https://github.com/openshift/ansible-service-broker/blob/feature-add-dashboard-url/templates/deploy-ansible-service-broker.template.yaml#L287).\r\n* This is entirely opt in; there should be no change to existing behavior unless the feature is explicitly opted into by an APB author.\r\n\r\n#### Changes proposed in this pull request\r\n* Update bundle-lib and broker-client-go dependencies to bring in `DashboardURL` and `Alpha` feature gate support.\r\n* Update broker to check if conditions are right to use the feature.\r\n* Returns a `DashboardURL` on initial async provision response that points to the dashboard redirector service if the feature is enabled.\r\n* Adds dashboard-redirector binary and modifies the build files to bake it into the broker image.\r\n* Updates template to deploy the dashboard-redirector alongside the broker.\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/comments/383106477","html_url":"https://github.com/openshift/ansible-service-broker/pull/897#issuecomment-383106477","issue_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/897","id":383106477,"user":{"login":"fabianvf","id":2431974,"avatar_url":"https://avatars0.githubusercontent.com/u/2431974?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianvf","html_url":"https://github.com/fabianvf","followers_url":"https://api.github.com/users/fabianvf/followers","following_url":"https://api.github.com/users/fabianvf/following{/other_user}","gists_url":"https://api.github.com/users/fabianvf/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianvf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianvf/subscriptions","organizations_url":"https://api.github.com/users/fabianvf/orgs","repos_url":"https://api.github.com/users/fabianvf/repos","events_url":"https://api.github.com/users/fabianvf/events{/privacy}","received_events_url":"https://api.github.com/users/fabianvf/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T14:04:18Z","updated_at":"2018-04-20T14:04:18Z","author_association":"CONTRIBUTOR","body":"@eriknelson could you break the template changes out to a 3.10 aligned Trello card?"}}
{"actor":{"display_login":"fabianvf"}}