{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/krabsetw/pulls/comments/231222748","pull_request_review_id":172145143,"id":231222748,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTIyMjc0OA==","diff_hunk":"@@ -19,7 +19,13 @@ namespace krabs { namespace details {\n     struct ut {\n \n         typedef krabs::provider<> provider_type;\n+\t\t","path":"krabs/krabs/ut.hpp","position":null,"original_position":4,"commit_id":"1917587cf375fd056fb65ea14ea2bfbde3ed21e0","original_commit_id":"e864c5cc3a2f2dc5594c6fc7c66ce8275d2456c2","user":{"login":"issaharnoam","id":6853447,"node_id":"MDQ6VXNlcjY4NTM0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6853447?v=4","gravatar_id":"","url":"https://api.github.com/users/issaharnoam","html_url":"https://github.com/issaharnoam","followers_url":"https://api.github.com/users/issaharnoam/followers","following_url":"https://api.github.com/users/issaharnoam/following{/other_user}","gists_url":"https://api.github.com/users/issaharnoam/gists{/gist_id}","starred_url":"https://api.github.com/users/issaharnoam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/issaharnoam/subscriptions","organizations_url":"https://api.github.com/users/issaharnoam/orgs","repos_url":"https://api.github.com/users/issaharnoam/repos","events_url":"https://api.github.com/users/issaharnoam/events{/privacy}","received_events_url":"https://api.github.com/users/issaharnoam/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-11-06T17:42:04Z","updated_at":"2018-11-06T17:42:05Z","html_url":"https://github.com/Microsoft/krabsetw/pull/60#discussion_r231222748","pull_request_url":"https://api.github.com/repos/Microsoft/krabsetw/pulls/60","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/krabsetw/pulls/comments/231222748"},"html":{"href":"https://github.com/Microsoft/krabsetw/pull/60#discussion_r231222748"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/krabsetw/pulls/60"}},"in_reply_to_id":230781651},"pull_request":{"url":"https://api.github.com/repos/Microsoft/krabsetw/pulls/60","id":226365331,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzY1MzMx","html_url":"https://github.com/Microsoft/krabsetw/pull/60","diff_url":"https://github.com/Microsoft/krabsetw/pull/60.diff","patch_url":"https://github.com/Microsoft/krabsetw/pull/60.patch","issue_url":"https://api.github.com/repos/Microsoft/krabsetw/issues/60","number":60,"state":"open","locked":false,"title":"boosting krabs performance by filtering events on api level (without predicates)","user":{"login":"issaharnoam","id":6853447,"node_id":"MDQ6VXNlcjY4NTM0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6853447?v=4","gravatar_id":"","url":"https://api.github.com/users/issaharnoam","html_url":"https://github.com/issaharnoam","followers_url":"https://api.github.com/users/issaharnoam/followers","following_url":"https://api.github.com/users/issaharnoam/following{/other_user}","gists_url":"https://api.github.com/users/issaharnoam/gists{/gist_id}","starred_url":"https://api.github.com/users/issaharnoam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/issaharnoam/subscriptions","organizations_url":"https://api.github.com/users/issaharnoam/orgs","repos_url":"https://api.github.com/users/issaharnoam/repos","events_url":"https://api.github.com/users/issaharnoam/events{/privacy}","received_events_url":"https://api.github.com/users/issaharnoam/received_events","type":"User","site_admin":false},"body":"According profiler, it boosted application performance by 5-7%  (for certain set of filters and providers)\r\n","created_at":"2018-10-28T13:01:04Z","updated_at":"2018-11-06T17:42:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2462170fd4ffbe439e012e4b189e50203a7704b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/krabsetw/pulls/60/commits","review_comments_url":"https://api.github.com/repos/Microsoft/krabsetw/pulls/60/comments","review_comment_url":"https://api.github.com/repos/Microsoft/krabsetw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/krabsetw/issues/60/comments","statuses_url":"https://api.github.com/repos/Microsoft/krabsetw/statuses/1917587cf375fd056fb65ea14ea2bfbde3ed21e0","head":{"label":"issaharnoam:master","ref":"master","sha":"1917587cf375fd056fb65ea14ea2bfbde3ed21e0","user":{"login":"issaharnoam","id":6853447,"node_id":"MDQ6VXNlcjY4NTM0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6853447?v=4","gravatar_id":"","url":"https://api.github.com/users/issaharnoam","html_url":"https://github.com/issaharnoam","followers_url":"https://api.github.com/users/issaharnoam/followers","following_url":"https://api.github.com/users/issaharnoam/following{/other_user}","gists_url":"https://api.github.com/users/issaharnoam/gists{/gist_id}","starred_url":"https://api.github.com/users/issaharnoam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/issaharnoam/subscriptions","organizations_url":"https://api.github.com/users/issaharnoam/orgs","repos_url":"https://api.github.com/users/issaharnoam/repos","events_url":"https://api.github.com/users/issaharnoam/events{/privacy}","received_events_url":"https://api.github.com/users/issaharnoam/received_events","type":"User","site_admin":false},"repo":{"id":154027560,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQwMjc1NjA=","name":"krabsetw","full_name":"issaharnoam/krabsetw","private":false,"owner":{"login":"issaharnoam","id":6853447,"node_id":"MDQ6VXNlcjY4NTM0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6853447?v=4","gravatar_id":"","url":"https://api.github.com/users/issaharnoam","html_url":"https://github.com/issaharnoam","followers_url":"https://api.github.com/users/issaharnoam/followers","following_url":"https://api.github.com/users/issaharnoam/following{/other_user}","gists_url":"https://api.github.com/users/issaharnoam/gists{/gist_id}","starred_url":"https://api.github.com/users/issaharnoam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/issaharnoam/subscriptions","organizations_url":"https://api.github.com/users/issaharnoam/orgs","repos_url":"https://api.github.com/users/issaharnoam/repos","events_url":"https://api.github.com/users/issaharnoam/events{/privacy}","received_events_url":"https://api.github.com/users/issaharnoam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/issaharnoam/krabsetw","description":"KrabsETW - add support for native event filtering","fork":true,"url":"https://api.github.com/repos/issaharnoam/krabsetw","forks_url":"https://api.github.com/repos/issaharnoam/krabsetw/forks","keys_url":"https://api.github.com/repos/issaharnoam/krabsetw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/issaharnoam/krabsetw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/issaharnoam/krabsetw/teams","hooks_url":"https://api.github.com/repos/issaharnoam/krabsetw/hooks","issue_events_url":"https://api.github.com/repos/issaharnoam/krabsetw/issues/events{/number}","events_url":"https://api.github.com/repos/issaharnoam/krabsetw/events","assignees_url":"https://api.github.com/repos/issaharnoam/krabsetw/assignees{/user}","branches_url":"https://api.github.com/repos/issaharnoam/krabsetw/branches{/branch}","tags_url":"https://api.github.com/repos/issaharnoam/krabsetw/tags","blobs_url":"https://api.github.com/repos/issaharnoam/krabsetw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/issaharnoam/krabsetw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/issaharnoam/krabsetw/git/refs{/sha}","trees_url":"https://api.github.com/repos/issaharnoam/krabsetw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/issaharnoam/krabsetw/statuses/{sha}","languages_url":"https://api.github.com/repos/issaharnoam/krabsetw/languages","stargazers_url":"https://api.github.com/repos/issaharnoam/krabsetw/stargazers","contributors_url":"https://api.github.com/repos/issaharnoam/krabsetw/contributors","subscribers_url":"https://api.github.com/repos/issaharnoam/krabsetw/subscribers","subscription_url":"https://api.github.com/repos/issaharnoam/krabsetw/subscription","commits_url":"https://api.github.com/repos/issaharnoam/krabsetw/commits{/sha}","git_commits_url":"https://api.github.com/repos/issaharnoam/krabsetw/git/commits{/sha}","comments_url":"https://api.github.com/repos/issaharnoam/krabsetw/comments{/number}","issue_comment_url":"https://api.github.com/repos/issaharnoam/krabsetw/issues/comments{/number}","contents_url":"https://api.github.com/repos/issaharnoam/krabsetw/contents/{+path}","compare_url":"https://api.github.com/repos/issaharnoam/krabsetw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/issaharnoam/krabsetw/merges","archive_url":"https://api.github.com/repos/issaharnoam/krabsetw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/issaharnoam/krabsetw/downloads","issues_url":"https://api.github.com/repos/issaharnoam/krabsetw/issues{/number}","pulls_url":"https://api.github.com/repos/issaharnoam/krabsetw/pulls{/number}","milestones_url":"https://api.github.com/repos/issaharnoam/krabsetw/milestones{/number}","notifications_url":"https://api.github.com/repos/issaharnoam/krabsetw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/issaharnoam/krabsetw/labels{/name}","releases_url":"https://api.github.com/repos/issaharnoam/krabsetw/releases{/id}","deployments_url":"https://api.github.com/repos/issaharnoam/krabsetw/deployments","created_at":"2018-10-21T16:14:20Z","updated_at":"2018-11-06T17:41:43Z","pushed_at":"2018-11-06T17:41:40Z","git_url":"git://github.com/issaharnoam/krabsetw.git","ssh_url":"git@github.com:issaharnoam/krabsetw.git","clone_url":"https://github.com/issaharnoam/krabsetw.git","svn_url":"https://github.com/issaharnoam/krabsetw","homepage":"","size":2079,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"b218ae358ba769d78542f55a450e55e8d6e3e860","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":71814770,"node_id":"MDEwOlJlcG9zaXRvcnk3MTgxNDc3MA==","name":"krabsetw","full_name":"Microsoft/krabsetw","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/krabsetw","description":"KrabsETW provides a modern C++ wrapper and a .NET wrapper around the low-level ETW trace consumption functions.","fork":false,"url":"https://api.github.com/repos/Microsoft/krabsetw","forks_url":"https://api.github.com/repos/Microsoft/krabsetw/forks","keys_url":"https://api.github.com/repos/Microsoft/krabsetw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/krabsetw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/krabsetw/teams","hooks_url":"https://api.github.com/repos/Microsoft/krabsetw/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/krabsetw/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/krabsetw/events","assignees_url":"https://api.github.com/repos/Microsoft/krabsetw/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/krabsetw/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/krabsetw/tags","blobs_url":"https://api.github.com/repos/Microsoft/krabsetw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/krabsetw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/krabsetw/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/krabsetw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/krabsetw/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/krabsetw/languages","stargazers_url":"https://api.github.com/repos/Microsoft/krabsetw/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/krabsetw/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/krabsetw/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/krabsetw/subscription","commits_url":"https://api.github.com/repos/Microsoft/krabsetw/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/krabsetw/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/krabsetw/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/krabsetw/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/krabsetw/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/krabsetw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/krabsetw/merges","archive_url":"https://api.github.com/repos/Microsoft/krabsetw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/krabsetw/downloads","issues_url":"https://api.github.com/repos/Microsoft/krabsetw/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/krabsetw/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/krabsetw/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/krabsetw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/krabsetw/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/krabsetw/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/krabsetw/deployments","created_at":"2016-10-24T17:38:49Z","updated_at":"2018-11-05T08:15:54Z","pushed_at":"2018-11-06T17:41:42Z","git_url":"git://github.com/Microsoft/krabsetw.git","ssh_url":"git@github.com:Microsoft/krabsetw.git","clone_url":"https://github.com/Microsoft/krabsetw.git","svn_url":"https://github.com/Microsoft/krabsetw","homepage":"","size":2049,"stargazers_count":177,"watchers_count":177,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":6,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/krabsetw/pulls/60"},"html":{"href":"https://github.com/Microsoft/krabsetw/pull/60"},"issue":{"href":"https://api.github.com/repos/Microsoft/krabsetw/issues/60"},"comments":{"href":"https://api.github.com/repos/Microsoft/krabsetw/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/krabsetw/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/krabsetw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/krabsetw/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/krabsetw/statuses/1917587cf375fd056fb65ea14ea2bfbde3ed21e0"}},"author_association":"NONE"}}
{"actor":{"display_login":"issaharnoam"}}