{"action":"created","issue":{"url":"https://api.github.com/repos/oceanprotocol/dev-ocean/issues/65","repository_url":"https://api.github.com/repos/oceanprotocol/dev-ocean","labels_url":"https://api.github.com/repos/oceanprotocol/dev-ocean/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/oceanprotocol/dev-ocean/issues/65/comments","events_url":"https://api.github.com/repos/oceanprotocol/dev-ocean/issues/65/events","html_url":"https://github.com/oceanprotocol/dev-ocean/pull/65","id":369012712,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMDUxOTk5","number":65,"title":"squid api squid next iteration revision #2","user":{"login":"billbsing","id":5321213,"node_id":"MDQ6VXNlcjUzMjEyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5321213?v=4","gravatar_id":"","url":"https://api.github.com/users/billbsing","html_url":"https://github.com/billbsing","followers_url":"https://api.github.com/users/billbsing/followers","following_url":"https://api.github.com/users/billbsing/following{/other_user}","gists_url":"https://api.github.com/users/billbsing/gists{/gist_id}","starred_url":"https://api.github.com/users/billbsing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billbsing/subscriptions","organizations_url":"https://api.github.com/users/billbsing/orgs","repos_url":"https://api.github.com/users/billbsing/repos","events_url":"https://api.github.com/users/billbsing/events{/privacy}","received_events_url":"https://api.github.com/users/billbsing/received_events","type":"User","site_admin":false},"labels":[{"id":968984253,"node_id":"MDU6TGFiZWw5Njg5ODQyNTM=","url":"https://api.github.com/repos/oceanprotocol/dev-ocean/labels/help%20wanted","name":"help wanted","color":"008672","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-10-11T08:42:07Z","updated_at":"2018-10-16T10:14:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/oceanprotocol/dev-ocean/pulls/65","html_url":"https://github.com/oceanprotocol/dev-ocean/pull/65","diff_url":"https://github.com/oceanprotocol/dev-ocean/pull/65.diff","patch_url":"https://github.com/oceanprotocol/dev-ocean/pull/65.patch"},"body":"## Description\r\n\r\nThis will probably break everything! \r\n\r\nI thought i would add a possible re-design which is slightly different to the current Squid API.\r\n\r\nI've replaced DDO with meta data, as the end user calling the library just needs to know about the metadata, and the squid library can create the DDO and include the metadata.\r\n\r\nI'm also looking at this with a Python point of view. So with the squid-py the calls will have to be underscore_case instead of camelCase\r\n"},"comment":{"url":"https://api.github.com/repos/oceanprotocol/dev-ocean/issues/comments/430182320","html_url":"https://github.com/oceanprotocol/dev-ocean/pull/65#issuecomment-430182320","issue_url":"https://api.github.com/repos/oceanprotocol/dev-ocean/issues/65","id":430182320,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDE4MjMyMA==","user":{"login":"billbsing","id":5321213,"node_id":"MDQ6VXNlcjUzMjEyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5321213?v=4","gravatar_id":"","url":"https://api.github.com/users/billbsing","html_url":"https://github.com/billbsing","followers_url":"https://api.github.com/users/billbsing/followers","following_url":"https://api.github.com/users/billbsing/following{/other_user}","gists_url":"https://api.github.com/users/billbsing/gists{/gist_id}","starred_url":"https://api.github.com/users/billbsing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billbsing/subscriptions","organizations_url":"https://api.github.com/users/billbsing/orgs","repos_url":"https://api.github.com/users/billbsing/repos","events_url":"https://api.github.com/users/billbsing/events{/privacy}","received_events_url":"https://api.github.com/users/billbsing/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T10:14:37Z","updated_at":"2018-10-16T10:14:37Z","author_association":"NONE","body":"OK, so maybe we should do the following:\r\n\r\n1. Specify that at the moment the squid API is currently defined for an OO type language such as JavaScript, Java, Python e.t.c.\r\n1. Try to exclude coding examples\r\n1. Specify just the calling objects and methods that will actually perform Ocean work ( such as publish, register, getMetadata ).\r\n\r\n I think we should design this API document as a OO style , since moving from OO design to a non OO library is easier, by  just renaming each class method and passing the first variable as the object. \r\nSo for example:\r\n```c++\r\nasset.register(account_id, ...);\r\n\r\n// would be become in c\r\nasset_register(&asset_struct, account_id);\r\n\r\n```\r\nAnother possible point of view is that the Squid API should not be 'officially' defined by Ocean, since it's just a tool/library to make it easier to access the Ocean ecosystem such as the smart contracts and  Provider.\r\n"}}
{"actor":{"display_login":"billbsing"}}