{"action":"closed","number":1671,"pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1671","id":214429235,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDI5MjM1","html_url":"https://github.com/apache/bookkeeper/pull/1671","diff_url":"https://github.com/apache/bookkeeper/pull/1671.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1671.patch","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1671","number":1671,"state":"closed","locked":false,"title":"remove misleading comment","user":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"body":"\r\nDescriptions of the changes in this PR:\r\n\r\n*Motivation*\r\n\r\nParallelRead is actually used internally at ledger recovery. It is used at production.\r\n\r\n*Changes*\r\n\r\nRemoved misleading comment.\r\n\r\n> ---\r\n> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit\r\n> checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all\r\n> the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You\r\n> can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if\r\n> you are not sure, committers will help you:\r\n>\r\n> - [x] [skip bookkeeper-server bookie tests]: skip testing `org.apache.bookkeeper.bookie` in bookkeeper-server module.\r\n> - [x] [skip bookkeeper-server client tests]: skip testing `org.apache.bookkeeper.client` in bookkeeper-server module.\r\n> - [x] [skip bookkeeper-server replication tests]: skip testing `org.apache.bookkeeper.replication` in bookkeeper-server module.\r\n> - [x] [skip bookkeeper-server tls tests]: skip testing `org.apache.bookkeeper.tls` in bookkeeper-server module.\r\n> - [x] [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.\r\n> - [x] [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.\r\n> - [x] [skip build java8]: skip build on java8. *ONLY* skip this when *ONLY* changing files under documentation under `site`.\r\n> - [x] [skip build java9]: skip build on java9. *ONLY* skip this when *ONLY* changing files under documentation under `site`.\r\n> ---\r\n\r\n> ---\r\n> Be sure to do all of the following to help us incorporate your contribution\r\n> quickly and easily:\r\n>\r\n> If this PR is a BookKeeper Proposal (BP):\r\n>\r\n> - [ ] Make sure the PR title is formatted like:\r\n>     `<BP-#>: Description of bookkeeper proposal`\r\n>     `e.g. BP-1: 64 bits ledger is support`\r\n> - [ ] Attach the master issue link in the description of this PR.\r\n> - [ ] Attach the google doc link if the BP is written in Google Doc.\r\n>\r\n> Otherwise:\r\n> \r\n> - [ ] Make sure the PR title is formatted like:\r\n>     `<Issue #>: Description of pull request`\r\n>     `e.g. Issue 123: Description ...`\r\n> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.\r\n> - [ ] Replace `<Issue #>` in the title with the actual Issue number.\r\n> \r\n> ---\r\n","created_at":"2018-09-10T20:09:53Z","updated_at":"2018-12-04T18:53:42Z","closed_at":"2018-12-04T18:53:42Z","merged_at":"2018-12-04T18:53:42Z","merge_commit_sha":"b959f8f4d9363a11d27a28150b1fad54123d83cc","assignee":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"assignees":[{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":636302215,"node_id":"MDU6TGFiZWw2MzYzMDIyMTU=","url":"https://api.github.com/repos/apache/bookkeeper/labels/area/documentation","name":"area/documentation","color":"f9d0c4","default":false},{"id":1023209214,"node_id":"MDU6TGFiZWwxMDIzMjA5MjE0","url":"https://api.github.com/repos/apache/bookkeeper/labels/release/4.9.0","name":"release/4.9.0","color":"1d76db","default":false},{"id":636301220,"node_id":"MDU6TGFiZWw2MzYzMDEyMjA=","url":"https://api.github.com/repos/apache/bookkeeper/labels/type/task","name":"type/task","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/bookkeeper/milestones/5","html_url":"https://github.com/apache/bookkeeper/milestone/5","labels_url":"https://api.github.com/repos/apache/bookkeeper/milestones/5/labels","id":3566485,"node_id":"MDk6TWlsZXN0b25lMzU2NjQ4NQ==","number":5,"title":"4.9.0","description":"Release 4.9.0","creator":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":180,"state":"open","created_at":"2018-08-13T18:10:09Z","updated_at":"2018-12-04T18:53:42Z","due_on":"2018-11-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1671/commits","review_comments_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1671/comments","review_comment_url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1671/comments","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/11612aeea9846ce01cab9c3e9a4e9fce17e999b2","head":{"label":"sijie:remove_misleading_comment","ref":"remove_misleading_comment","sha":"11612aeea9846ce01cab9c3e9a4e9fce17e999b2","user":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"repo":{"id":3747333,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ3MzMz","name":"bookkeeper","full_name":"sijie/bookkeeper","private":false,"owner":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sijie/bookkeeper","description":"Mirror of Apache Bookkeeper","fork":true,"url":"https://api.github.com/repos/sijie/bookkeeper","forks_url":"https://api.github.com/repos/sijie/bookkeeper/forks","keys_url":"https://api.github.com/repos/sijie/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sijie/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sijie/bookkeeper/teams","hooks_url":"https://api.github.com/repos/sijie/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/sijie/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/sijie/bookkeeper/events","assignees_url":"https://api.github.com/repos/sijie/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/sijie/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/sijie/bookkeeper/tags","blobs_url":"https://api.github.com/repos/sijie/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sijie/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sijie/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/sijie/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sijie/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/sijie/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/sijie/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/sijie/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/sijie/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/sijie/bookkeeper/subscription","commits_url":"https://api.github.com/repos/sijie/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/sijie/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/sijie/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/sijie/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/sijie/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/sijie/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sijie/bookkeeper/merges","archive_url":"https://api.github.com/repos/sijie/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sijie/bookkeeper/downloads","issues_url":"https://api.github.com/repos/sijie/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/sijie/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/sijie/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/sijie/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sijie/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/sijie/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/sijie/bookkeeper/deployments","created_at":"2012-03-17T11:57:47Z","updated_at":"2018-12-04T02:02:02Z","pushed_at":"2018-12-04T02:01:44Z","git_url":"git://github.com/sijie/bookkeeper.git","ssh_url":"git@github.com:sijie/bookkeeper.git","clone_url":"https://github.com/sijie/bookkeeper.git","svn_url":"https://github.com/sijie/bookkeeper","homepage":null,"size":22880,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cdd659471e1fb75aaf7738302dbf0dfaf44a9127","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":1575956,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc1OTU2","name":"bookkeeper","full_name":"apache/bookkeeper","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/bookkeeper","description":"Apache Bookkeeper","fork":false,"url":"https://api.github.com/repos/apache/bookkeeper","forks_url":"https://api.github.com/repos/apache/bookkeeper/forks","keys_url":"https://api.github.com/repos/apache/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/bookkeeper/teams","hooks_url":"https://api.github.com/repos/apache/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/bookkeeper/events","assignees_url":"https://api.github.com/repos/apache/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/bookkeeper/tags","blobs_url":"https://api.github.com/repos/apache/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/apache/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/bookkeeper/subscription","commits_url":"https://api.github.com/repos/apache/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/bookkeeper/merges","archive_url":"https://api.github.com/repos/apache/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/bookkeeper/downloads","issues_url":"https://api.github.com/repos/apache/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/bookkeeper/deployments","created_at":"2011-04-06T07:00:07Z","updated_at":"2018-12-04T11:03:23Z","pushed_at":"2018-12-04T18:53:42Z","git_url":"git://github.com/apache/bookkeeper.git","ssh_url":"git@github.com:apache/bookkeeper.git","clone_url":"https://github.com/apache/bookkeeper.git","svn_url":"https://github.com/apache/bookkeeper","homepage":"https://bookkeeper.apache.org","size":38394,"stargazers_count":515,"watchers_count":515,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":211,"open_issues":180,"watchers":515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1671"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1671"},"issue":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1671"},"comments":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1671/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1671/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1671/commits"},"statuses":{"href":"https://api.github.com/repos/apache/bookkeeper/statuses/11612aeea9846ce01cab9c3e9a4e9fce17e999b2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"sijie"}}