{"action":"created","issue":{"url":"https://api.github.com/repos/pillarjs/send/issues/174","repository_url":"https://api.github.com/repos/pillarjs/send","labels_url":"https://api.github.com/repos/pillarjs/send/issues/174/labels{/name}","comments_url":"https://api.github.com/repos/pillarjs/send/issues/174/comments","events_url":"https://api.github.com/repos/pillarjs/send/issues/174/events","html_url":"https://github.com/pillarjs/send/pull/174","id":372970187,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MDE1NDAw","number":174,"title":"Proposal: Add host option to override node fs and path modules","user":{"login":"barak007","id":2240471,"node_id":"MDQ6VXNlcjIyNDA0NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/2240471?v=4","gravatar_id":"","url":"https://api.github.com/users/barak007","html_url":"https://github.com/barak007","followers_url":"https://api.github.com/users/barak007/followers","following_url":"https://api.github.com/users/barak007/following{/other_user}","gists_url":"https://api.github.com/users/barak007/gists{/gist_id}","starred_url":"https://api.github.com/users/barak007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barak007/subscriptions","organizations_url":"https://api.github.com/users/barak007/orgs","repos_url":"https://api.github.com/users/barak007/repos","events_url":"https://api.github.com/users/barak007/events{/privacy}","received_events_url":"https://api.github.com/users/barak007/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-23T12:19:09Z","updated_at":"2018-10-23T12:31:45Z","closed_at":"2018-10-23T12:31:45Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pillarjs/send/pulls/174","html_url":"https://github.com/pillarjs/send/pull/174","diff_url":"https://github.com/pillarjs/send/pull/174.diff","patch_url":"https://github.com/pillarjs/send/pull/174.patch"},"body":"Hi,\r\nI have a use-case that requires me to serve files from memory in my tests.\r\nCurrently, I use `express.static()` from `serve-static` which uses this package. Now, I want to keep the same API but enable passing an option to override the default host file-system and path resolution.\r\nThere is an [issue](expressjs/serve-static#83) in `express-static` that requests the same thing but hasn't seen much activity.\r\n\r\n\r\nAbout the tests missing from this pull request.\r\nSince there is no changed behavior, all of the current tests are passing. What I would really want to do is wrap all the existing test-cases in a factory and re-run them using an external host.\r\nWould you have any objections to this test plan? Would love to get this in.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pillarjs/send/issues/comments/432226796","html_url":"https://github.com/pillarjs/send/pull/174#issuecomment-432226796","issue_url":"https://api.github.com/repos/pillarjs/send/issues/174","id":432226796,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjIyNjc5Ng==","user":{"login":"dougwilson","id":67512,"node_id":"MDQ6VXNlcjY3NTEy","avatar_url":"https://avatars3.githubusercontent.com/u/67512?v=4","gravatar_id":"","url":"https://api.github.com/users/dougwilson","html_url":"https://github.com/dougwilson","followers_url":"https://api.github.com/users/dougwilson/followers","following_url":"https://api.github.com/users/dougwilson/following{/other_user}","gists_url":"https://api.github.com/users/dougwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/dougwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougwilson/subscriptions","organizations_url":"https://api.github.com/users/dougwilson/orgs","repos_url":"https://api.github.com/users/dougwilson/repos","events_url":"https://api.github.com/users/dougwilson/events{/privacy}","received_events_url":"https://api.github.com/users/dougwilson/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T12:31:45Z","updated_at":"2018-10-23T12:31:45Z","author_association":"MEMBER","body":"Sorry, this is not the correct implementation for all the reasons from the previously closed PRs and issues on this.\r\n\r\nPlease move the discussion/proposal to https://github.com/pillarjs/send/issues/160 . If someone can provide a proposal that addresses these, that would be the way to move forward.\r\n\r\nI'm actually working on a security fix currently that would complete rewrite which fs methods are called, even apart from the changes PR #125 makes. This PR would make those types of changes no longer backwards compatible as our exact usage of the internal fs becomes public as folks will end up only passing in the bare minimum to make their use case work.\r\n\r\nSee past discussion #149 as well."}}
{"actor":{"display_login":"dougwilson"}}