{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/217458028","pull_request_review_id":155174458,"id":217458028,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzQ1ODAyOA==","diff_hunk":"@@ -479,8 +480,26 @@ _is_alnum_underscore(char ch)\n     return _is_alpha_underscore(ch) || (ch >= '0' && ch <= '9');\n }\n \n+NPY_NO_EXPORT npy_longlong\n+npy_strtoll(const char *str, char **endptr, int base);","path":"numpy/core/src/umath/ufunc_object.c","position":13,"original_position":13,"commit_id":"5d8295dd8f36a191f6ecfa63aa0b3debb27a7cc4","original_commit_id":"5d8295dd8f36a191f6ecfa63aa0b3debb27a7cc4","user":{"login":"eric-wieser","id":425260,"node_id":"MDQ6VXNlcjQyNTI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"body":"Would prefer that we move this to a header, rather than repeating the prototype","created_at":"2018-09-13T16:50:12Z","updated_at":"2018-09-13T16:50:12Z","html_url":"https://github.com/numpy/numpy/pull/11175#discussion_r217458028","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/11175","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/217458028"},"html":{"href":"https://github.com/numpy/numpy/pull/11175#discussion_r217458028"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11175"}}},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/11175","id":190815800,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwODE1ODAw","html_url":"https://github.com/numpy/numpy/pull/11175","diff_url":"https://github.com/numpy/numpy/pull/11175.diff","patch_url":"https://github.com/numpy/numpy/pull/11175.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/11175","number":11175,"state":"open","locked":false,"title":" ENH: Generalized ufunc signature expansion for frozen and flexible dimensions","user":{"login":"mhvk","id":2789820,"node_id":"MDQ6VXNlcjI3ODk4MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2789820?v=4","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"body":"EDIT: now the replacement of #11132\r\n\r\nAn alternative to #11132, much more following its logic, but (I think) clearer. Mostly for @mattip to look at. I like the use of flags, although it may seem a bit overkill if we have just one. But I do hope to have a broadcast option (tentatively `n|1`). For now, I also kept the frozen dimensions, as those are quite easy.","created_at":"2018-05-28T00:56:37Z","updated_at":"2018-09-13T16:50:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"007f30c68ce0fc935892ecbea969ffa4f50b5cbb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":6359239,"node_id":"MDU6TGFiZWw2MzU5MjM5","url":"https://api.github.com/repos/numpy/numpy/labels/01%20-%20Enhancement","name":"01 - Enhancement","color":"fef2c0","default":false},{"id":6359893,"node_id":"MDU6TGFiZWw2MzU5ODkz","url":"https://api.github.com/repos/numpy/numpy/labels/15%20-%20Discussion","name":"15 - Discussion","color":"fef2c0","default":false},{"id":16917029,"node_id":"MDU6TGFiZWwxNjkxNzAyOQ==","url":"https://api.github.com/repos/numpy/numpy/labels/component:%20numpy.core","name":"component: numpy.core","color":"009800","default":false},{"id":959099844,"node_id":"MDU6TGFiZWw5NTkwOTk4NDQ=","url":"https://api.github.com/repos/numpy/numpy/labels/component:%20numpy.ufunc","name":"component: numpy.ufunc","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/numpy/numpy/milestones/58","html_url":"https://github.com/numpy/numpy/milestone/58","labels_url":"https://api.github.com/repos/numpy/numpy/milestones/58/labels","id":3353003,"node_id":"MDk6TWlsZXN0b25lMzM1MzAwMw==","number":58,"title":"1.16.0 release","description":"","creator":{"login":"charris","id":77272,"node_id":"MDQ6VXNlcjc3Mjcy","avatar_url":"https://avatars3.githubusercontent.com/u/77272?v=4","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":29,"state":"open","created_at":"2018-05-16T21:13:27Z","updated_at":"2018-09-11T15:03:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/11175/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/11175/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/11175/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/5d8295dd8f36a191f6ecfa63aa0b3debb27a7cc4","head":{"label":"mhvk:gufunc-signature-modification2","ref":"gufunc-signature-modification2","sha":"5d8295dd8f36a191f6ecfa63aa0b3debb27a7cc4","user":{"login":"mhvk","id":2789820,"node_id":"MDQ6VXNlcjI3ODk4MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2789820?v=4","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"repo":{"id":11478718,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3ODcxOA==","name":"numpy","full_name":"mhvk/numpy","owner":{"login":"mhvk","id":2789820,"node_id":"MDQ6VXNlcjI3ODk4MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2789820?v=4","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhvk/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/mhvk/numpy","forks_url":"https://api.github.com/repos/mhvk/numpy/forks","keys_url":"https://api.github.com/repos/mhvk/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhvk/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhvk/numpy/teams","hooks_url":"https://api.github.com/repos/mhvk/numpy/hooks","issue_events_url":"https://api.github.com/repos/mhvk/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/mhvk/numpy/events","assignees_url":"https://api.github.com/repos/mhvk/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/mhvk/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/mhvk/numpy/tags","blobs_url":"https://api.github.com/repos/mhvk/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhvk/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhvk/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhvk/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhvk/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/mhvk/numpy/languages","stargazers_url":"https://api.github.com/repos/mhvk/numpy/stargazers","contributors_url":"https://api.github.com/repos/mhvk/numpy/contributors","subscribers_url":"https://api.github.com/repos/mhvk/numpy/subscribers","subscription_url":"https://api.github.com/repos/mhvk/numpy/subscription","commits_url":"https://api.github.com/repos/mhvk/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhvk/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhvk/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhvk/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhvk/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/mhvk/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhvk/numpy/merges","archive_url":"https://api.github.com/repos/mhvk/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhvk/numpy/downloads","issues_url":"https://api.github.com/repos/mhvk/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/mhvk/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/mhvk/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/mhvk/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhvk/numpy/labels{/name}","releases_url":"https://api.github.com/repos/mhvk/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/mhvk/numpy/deployments","created_at":"2013-07-17T14:53:04Z","updated_at":"2018-09-01T17:24:27Z","pushed_at":"2018-09-13T16:26:55Z","git_url":"git://github.com/mhvk/numpy.git","ssh_url":"git@github.com:mhvk/numpy.git","clone_url":"https://github.com/mhvk/numpy.git","svn_url":"https://github.com/mhvk/numpy","homepage":"http://www.numpy.org/","size":56037,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"placeholder"}},"base":{"label":"numpy:master","ref":"master","sha":"99f7ad58fcfa3d09897426e468a66840026dbce8","user":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDc=","name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2018-09-13T13:41:22Z","pushed_at":"2018-09-13T16:26:58Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"https://www.numpy.org/","size":60360,"stargazers_count":8134,"watchers_count":8134,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2982,"mirror_url":null,"archived":false,"open_issues_count":1965,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2982,"open_issues":1965,"watchers":8134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11175"},"html":{"href":"https://github.com/numpy/numpy/pull/11175"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/11175"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/11175/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11175/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/11175/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/5d8295dd8f36a191f6ecfa63aa0b3debb27a7cc4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eric-wieser"}}