{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/38977","repository_url":"https://api.github.com/repos/tgstation/tgstation","labels_url":"https://api.github.com/repos/tgstation/tgstation/issues/38977/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/38977/comments","events_url":"https://api.github.com/repos/tgstation/tgstation/issues/38977/events","html_url":"https://github.com/tgstation/tgstation/pull/38977","id":339185888,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTE5NTA3","number":38977,"title":"[Ready] Fermentation Barrels","user":{"login":"fludd12","id":11167153,"node_id":"MDQ6VXNlcjExMTY3MTUz","avatar_url":"https://avatars1.githubusercontent.com/u/11167153?v=4","gravatar_id":"","url":"https://api.github.com/users/fludd12","html_url":"https://github.com/fludd12","followers_url":"https://api.github.com/users/fludd12/followers","following_url":"https://api.github.com/users/fludd12/following{/other_user}","gists_url":"https://api.github.com/users/fludd12/gists{/gist_id}","starred_url":"https://api.github.com/users/fludd12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fludd12/subscriptions","organizations_url":"https://api.github.com/users/fludd12/orgs","repos_url":"https://api.github.com/users/fludd12/repos","events_url":"https://api.github.com/users/fludd12/events{/privacy}","received_events_url":"https://api.github.com/users/fludd12/received_events","type":"User","site_admin":false},"labels":[{"id":149581322,"node_id":"MDU6TGFiZWwxNDk1ODEzMjI=","url":"https://api.github.com/repos/tgstation/tgstation/labels/Feature","name":"Feature","color":"009800","default":false},{"id":260619936,"node_id":"MDU6TGFiZWwyNjA2MTk5MzY=","url":"https://api.github.com/repos/tgstation/tgstation/labels/Needs%20Review","name":"Needs Review","color":"ffdfa2","default":false},{"id":31457996,"node_id":"MDU6TGFiZWwzMTQ1Nzk5Ng==","url":"https://api.github.com/repos/tgstation/tgstation/labels/Sprites","name":"Sprites","color":"5ECCD1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-07-08T00:37:22Z","updated_at":"2018-07-09T21:44:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/38977","html_url":"https://github.com/tgstation/tgstation/pull/38977","diff_url":"https://github.com/tgstation/tgstation/pull/38977.diff","patch_url":"https://github.com/tgstation/tgstation/pull/38977.patch"},"body":":cl:Fel\r\nadd: You can now craft wooden barrels with 30 pieces of wood! They can hold up to 300u of reagents.\r\nadd: Putting hydroponics-grown plants into the barrel lets you ferment them for alcohol! Some give bar drinks, while others simply give plain fruit wine.\r\n/:cl:\r\n\r\n- [x] ~~Figure out why wines sometimes change into other wines if they're in the same container.~~\r\n- [x] ~~Figure out why transferring wines spontaneously removes a quantity of them from existence sometimes.~~\r\n    - ~~`trans_to` calls `remove_reagent` which uses only ID to determine what to remove. Since all generic wines share the same ID, this removes that amount of reagent from all wines, and only adds the amount subtracted from one.~~\r\n    - [x] ~~Find a way to make this stop happening.~~\r\n        - I've opted to instead make the reagents merge and mix flavors and boozepower, rather than have them stay separate with the same ID. Not only does this clear up a lot of bad code, but it makes working with it easier. The only problem is it's not as fancy. Sorry, everyone!\r\n- [x] Balance? Sounds?\r\n- [x] Figure out why reagent data is being lost at times.\r\n- [x] Figure out why variable generation from data isn't perfect. (Naming is off, flavors repeat themselves...)\r\n- [x] Make the sprite prettier.\r\n\r\n**Done!**\r\n\r\nSprite from Onule and a few others! Thanks, guys!\r\n\r\nAnyway, ready for review, and balance suggestions!"},"comment":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/comments/403630243","html_url":"https://github.com/tgstation/tgstation/pull/38977#issuecomment-403630243","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/38977","id":403630243,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzYzMDI0Mw==","user":{"login":"ExcessiveUseOfCobblestone","id":11748095,"node_id":"MDQ6VXNlcjExNzQ4MDk1","avatar_url":"https://avatars3.githubusercontent.com/u/11748095?v=4","gravatar_id":"","url":"https://api.github.com/users/ExcessiveUseOfCobblestone","html_url":"https://github.com/ExcessiveUseOfCobblestone","followers_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/followers","following_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/following{/other_user}","gists_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/gists{/gist_id}","starred_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/subscriptions","organizations_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/orgs","repos_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/repos","events_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/events{/privacy}","received_events_url":"https://api.github.com/users/ExcessiveUseOfCobblestone/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T21:44:21Z","updated_at":"2018-07-09T21:44:21Z","author_association":"CONTRIBUTOR","body":"why are you using the id system it sucks and using it just makes it harder to remove."}}
{"actor":{"display_login":"ExcessiveUseOfCobblestone"}}