{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/wangle/pulls/comments/178087299","pull_request_review_id":108086900,"id":178087299,"diff_hunk":"@@ -86,6 +86,10 @@ int64_t TransportInfo::readRTT(const folly::AsyncSocket* sock) {\n #endif\n }\n \n+#ifdef __APPLE__\n+#define TCP_INFO TCP_CONNECTION_INFO;","path":"wangle/acceptor/TransportInfo.cpp","position":null,"original_position":5,"commit_id":"0a87fb9f6fa186ff5b0d1ec79454d7e147f070de","original_commit_id":"0a87fb9f6fa186ff5b0d1ec79454d7e147f070de","user":{"login":"mzlee","id":682724,"avatar_url":"https://avatars0.githubusercontent.com/u/682724?v=4","gravatar_id":"","url":"https://api.github.com/users/mzlee","html_url":"https://github.com/mzlee","followers_url":"https://api.github.com/users/mzlee/followers","following_url":"https://api.github.com/users/mzlee/following{/other_user}","gists_url":"https://api.github.com/users/mzlee/gists{/gist_id}","starred_url":"https://api.github.com/users/mzlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzlee/subscriptions","organizations_url":"https://api.github.com/users/mzlee/orgs","repos_url":"https://api.github.com/users/mzlee/repos","events_url":"https://api.github.com/users/mzlee/events{/privacy}","received_events_url":"https://api.github.com/users/mzlee/received_events","type":"User","site_admin":false},"body":"You have a typo on this line: please remove the semicolon in the define.","created_at":"2018-03-29T15:08:32Z","updated_at":"2018-03-29T15:08:32Z","html_url":"https://github.com/facebook/wangle/pull/125#discussion_r178087299","pull_request_url":"https://api.github.com/repos/facebook/wangle/pulls/125","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/wangle/pulls/comments/178087299"},"html":{"href":"https://github.com/facebook/wangle/pull/125#discussion_r178087299"},"pull_request":{"href":"https://api.github.com/repos/facebook/wangle/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/wangle/pulls/125","id":175778208,"html_url":"https://github.com/facebook/wangle/pull/125","diff_url":"https://github.com/facebook/wangle/pull/125.diff","patch_url":"https://github.com/facebook/wangle/pull/125.patch","issue_url":"https://api.github.com/repos/facebook/wangle/issues/125","number":125,"state":"open","locked":false,"title":"Allow access to tcpinfo on macOS, using tcp_connection_info","user":{"login":"DailyMats","id":31626679,"avatar_url":"https://avatars1.githubusercontent.com/u/31626679?v=4","gravatar_id":"","url":"https://api.github.com/users/DailyMats","html_url":"https://github.com/DailyMats","followers_url":"https://api.github.com/users/DailyMats/followers","following_url":"https://api.github.com/users/DailyMats/following{/other_user}","gists_url":"https://api.github.com/users/DailyMats/gists{/gist_id}","starred_url":"https://api.github.com/users/DailyMats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DailyMats/subscriptions","organizations_url":"https://api.github.com/users/DailyMats/orgs","repos_url":"https://api.github.com/users/DailyMats/repos","events_url":"https://api.github.com/users/DailyMats/events{/privacy}","received_events_url":"https://api.github.com/users/DailyMats/received_events","type":"User","site_admin":false},"body":"On macOS, the `tcp_connection_info` struct provides almost the same information as the `tcp_info` struct on Linux and FreeBSD. With the help of a couple of `#ifdef`s, this pull request makes the `tcpinfo` field in `wangle::TransportInfo` available on macOS as well.\r\n\r\nTo further simplify getting the TCP state through `tcpinfo.tcpi_state` (which is my main motivation for doing this), I've added `#ifdef`s for the macOS values `TCPS_*` to the Linux/FreeBSD `TCP_*` macros.","created_at":"2018-03-18T22:45:58Z","updated_at":"2018-03-29T15:08:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15f967b743d2de71d9548c0aa47a706368f6b680","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196857968,"url":"https://api.github.com/repos/facebook/wangle/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/wangle/pulls/125/commits","review_comments_url":"https://api.github.com/repos/facebook/wangle/pulls/125/comments","review_comment_url":"https://api.github.com/repos/facebook/wangle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/wangle/issues/125/comments","statuses_url":"https://api.github.com/repos/facebook/wangle/statuses/0a87fb9f6fa186ff5b0d1ec79454d7e147f070de","head":{"label":"DailyMats:macos_tcpinfo","ref":"macos_tcpinfo","sha":"0a87fb9f6fa186ff5b0d1ec79454d7e147f070de","user":{"login":"DailyMats","id":31626679,"avatar_url":"https://avatars1.githubusercontent.com/u/31626679?v=4","gravatar_id":"","url":"https://api.github.com/users/DailyMats","html_url":"https://github.com/DailyMats","followers_url":"https://api.github.com/users/DailyMats/followers","following_url":"https://api.github.com/users/DailyMats/following{/other_user}","gists_url":"https://api.github.com/users/DailyMats/gists{/gist_id}","starred_url":"https://api.github.com/users/DailyMats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DailyMats/subscriptions","organizations_url":"https://api.github.com/users/DailyMats/orgs","repos_url":"https://api.github.com/users/DailyMats/repos","events_url":"https://api.github.com/users/DailyMats/events{/privacy}","received_events_url":"https://api.github.com/users/DailyMats/received_events","type":"User","site_admin":false},"repo":{"id":125773566,"name":"wangle","full_name":"DailyMats/wangle","owner":{"login":"DailyMats","id":31626679,"avatar_url":"https://avatars1.githubusercontent.com/u/31626679?v=4","gravatar_id":"","url":"https://api.github.com/users/DailyMats","html_url":"https://github.com/DailyMats","followers_url":"https://api.github.com/users/DailyMats/followers","following_url":"https://api.github.com/users/DailyMats/following{/other_user}","gists_url":"https://api.github.com/users/DailyMats/gists{/gist_id}","starred_url":"https://api.github.com/users/DailyMats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DailyMats/subscriptions","organizations_url":"https://api.github.com/users/DailyMats/orgs","repos_url":"https://api.github.com/users/DailyMats/repos","events_url":"https://api.github.com/users/DailyMats/events{/privacy}","received_events_url":"https://api.github.com/users/DailyMats/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DailyMats/wangle","description":"Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.","fork":true,"url":"https://api.github.com/repos/DailyMats/wangle","forks_url":"https://api.github.com/repos/DailyMats/wangle/forks","keys_url":"https://api.github.com/repos/DailyMats/wangle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DailyMats/wangle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DailyMats/wangle/teams","hooks_url":"https://api.github.com/repos/DailyMats/wangle/hooks","issue_events_url":"https://api.github.com/repos/DailyMats/wangle/issues/events{/number}","events_url":"https://api.github.com/repos/DailyMats/wangle/events","assignees_url":"https://api.github.com/repos/DailyMats/wangle/assignees{/user}","branches_url":"https://api.github.com/repos/DailyMats/wangle/branches{/branch}","tags_url":"https://api.github.com/repos/DailyMats/wangle/tags","blobs_url":"https://api.github.com/repos/DailyMats/wangle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DailyMats/wangle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DailyMats/wangle/git/refs{/sha}","trees_url":"https://api.github.com/repos/DailyMats/wangle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DailyMats/wangle/statuses/{sha}","languages_url":"https://api.github.com/repos/DailyMats/wangle/languages","stargazers_url":"https://api.github.com/repos/DailyMats/wangle/stargazers","contributors_url":"https://api.github.com/repos/DailyMats/wangle/contributors","subscribers_url":"https://api.github.com/repos/DailyMats/wangle/subscribers","subscription_url":"https://api.github.com/repos/DailyMats/wangle/subscription","commits_url":"https://api.github.com/repos/DailyMats/wangle/commits{/sha}","git_commits_url":"https://api.github.com/repos/DailyMats/wangle/git/commits{/sha}","comments_url":"https://api.github.com/repos/DailyMats/wangle/comments{/number}","issue_comment_url":"https://api.github.com/repos/DailyMats/wangle/issues/comments{/number}","contents_url":"https://api.github.com/repos/DailyMats/wangle/contents/{+path}","compare_url":"https://api.github.com/repos/DailyMats/wangle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DailyMats/wangle/merges","archive_url":"https://api.github.com/repos/DailyMats/wangle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DailyMats/wangle/downloads","issues_url":"https://api.github.com/repos/DailyMats/wangle/issues{/number}","pulls_url":"https://api.github.com/repos/DailyMats/wangle/pulls{/number}","milestones_url":"https://api.github.com/repos/DailyMats/wangle/milestones{/number}","notifications_url":"https://api.github.com/repos/DailyMats/wangle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DailyMats/wangle/labels{/name}","releases_url":"https://api.github.com/repos/DailyMats/wangle/releases{/id}","deployments_url":"https://api.github.com/repos/DailyMats/wangle/deployments","created_at":"2018-03-18T22:30:11Z","updated_at":"2018-03-18T22:30:13Z","pushed_at":"2018-03-23T20:59:58Z","git_url":"git://github.com/DailyMats/wangle.git","ssh_url":"git@github.com:DailyMats/wangle.git","clone_url":"https://github.com/DailyMats/wangle.git","svn_url":"https://github.com/DailyMats/wangle","homepage":"","size":1487,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"5e6811801896ea2846c3dd96a6b7547fb3598716","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":27889694,"name":"wangle","full_name":"facebook/wangle","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/wangle","description":"Wangle is a framework providing a set of common client/server abstractions for building services in a consistent, modular, and composable way.","fork":false,"url":"https://api.github.com/repos/facebook/wangle","forks_url":"https://api.github.com/repos/facebook/wangle/forks","keys_url":"https://api.github.com/repos/facebook/wangle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/wangle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/wangle/teams","hooks_url":"https://api.github.com/repos/facebook/wangle/hooks","issue_events_url":"https://api.github.com/repos/facebook/wangle/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/wangle/events","assignees_url":"https://api.github.com/repos/facebook/wangle/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/wangle/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/wangle/tags","blobs_url":"https://api.github.com/repos/facebook/wangle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/wangle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/wangle/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/wangle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/wangle/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/wangle/languages","stargazers_url":"https://api.github.com/repos/facebook/wangle/stargazers","contributors_url":"https://api.github.com/repos/facebook/wangle/contributors","subscribers_url":"https://api.github.com/repos/facebook/wangle/subscribers","subscription_url":"https://api.github.com/repos/facebook/wangle/subscription","commits_url":"https://api.github.com/repos/facebook/wangle/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/wangle/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/wangle/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/wangle/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/wangle/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/wangle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/wangle/merges","archive_url":"https://api.github.com/repos/facebook/wangle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/wangle/downloads","issues_url":"https://api.github.com/repos/facebook/wangle/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/wangle/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/wangle/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/wangle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/wangle/labels{/name}","releases_url":"https://api.github.com/repos/facebook/wangle/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/wangle/deployments","created_at":"2014-12-11T20:12:30Z","updated_at":"2018-03-28T17:18:22Z","pushed_at":"2018-03-28T17:18:19Z","git_url":"git://github.com/facebook/wangle.git","ssh_url":"git@github.com:facebook/wangle.git","clone_url":"https://github.com/facebook/wangle.git","svn_url":"https://github.com/facebook/wangle","homepage":"","size":1478,"stargazers_count":1869,"watchers_count":1869,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":313,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":313,"open_issues":36,"watchers":1869,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/wangle/pulls/125"},"html":{"href":"https://github.com/facebook/wangle/pull/125"},"issue":{"href":"https://api.github.com/repos/facebook/wangle/issues/125"},"comments":{"href":"https://api.github.com/repos/facebook/wangle/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/wangle/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/wangle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/wangle/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/wangle/statuses/0a87fb9f6fa186ff5b0d1ec79454d7e147f070de"}},"author_association":"NONE"}}
{"actor":{"display_login":"mzlee"}}