{"action":"created","issue":{"url":"https://api.github.com/repos/novnc/noVNC/issues/737","repository_url":"https://api.github.com/repos/novnc/noVNC","labels_url":"https://api.github.com/repos/novnc/noVNC/issues/737/labels{/name}","comments_url":"https://api.github.com/repos/novnc/noVNC/issues/737/comments","events_url":"https://api.github.com/repos/novnc/noVNC/issues/737/events","html_url":"https://github.com/novnc/noVNC/issues/737","id":197911269,"node_id":"MDU6SXNzdWUxOTc5MTEyNjk=","number":737,"title":"Requests highest compression needlessly","user":{"login":"patrakov","id":2943163,"node_id":"MDQ6VXNlcjI5NDMxNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2943163?v=4","gravatar_id":"","url":"https://api.github.com/users/patrakov","html_url":"https://github.com/patrakov","followers_url":"https://api.github.com/users/patrakov/followers","following_url":"https://api.github.com/users/patrakov/following{/other_user}","gists_url":"https://api.github.com/users/patrakov/gists{/gist_id}","starred_url":"https://api.github.com/users/patrakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrakov/subscriptions","organizations_url":"https://api.github.com/users/patrakov/orgs","repos_url":"https://api.github.com/users/patrakov/repos","events_url":"https://api.github.com/users/patrakov/events{/privacy}","received_events_url":"https://api.github.com/users/patrakov/received_events","type":"User","site_admin":false},"labels":[{"id":89016,"node_id":"MDU6TGFiZWw4OTAxNg==","url":"https://api.github.com/repos/novnc/noVNC/labels/fixed","name":"fixed","color":"fbff85","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/novnc/noVNC/milestones/2","html_url":"https://github.com/novnc/noVNC/milestone/2","labels_url":"https://api.github.com/repos/novnc/noVNC/milestones/2/labels","id":2010059,"node_id":"MDk6TWlsZXN0b25lMjAxMDA1OQ==","number":2,"title":"v1.0.0","description":"","creator":{"login":"DirectXMan12","id":119737,"node_id":"MDQ6VXNlcjExOTczNw==","avatar_url":"https://avatars1.githubusercontent.com/u/119737?v=4","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":140,"state":"closed","created_at":"2016-09-16T20:17:49Z","updated_at":"2018-07-07T12:22:00Z","due_on":null,"closed_at":"2018-04-24T18:27:20Z"},"comments":5,"created_at":"2016-12-28T20:25:51Z","updated_at":"2018-08-31T07:00:57Z","closed_at":"2017-10-24T20:17:53Z","author_association":"CONTRIBUTOR","body":"By default, noVNC presents pseudo-encoding 0xffffff09 in its list of preferred encodings. This encoding corresponds to the highest compression level (9). However, libvncserver also interprets this compression level in its Tight encoder, and has an interesting comment:\r\n\r\nhttps://github.com/LibVNC/libvncserver/blob/9c7efb7633ba62cd80c93e83284663f805bb3031/libvncserver/tight.c#L331\r\n\r\n    /* CL 9 (which maps internally to CL 3) is included mainly for backward\r\n       compatibility with TightVNC Compression Levels 5-9.  It should be used\r\n       only in extremely low-bandwidth cases in which it can be shown to have a\r\n       benefit.  For low-color workloads, it provides typically only 10-20%\r\n       better compression than CL 2 with JPEG and CL 1 without JPEG, and it\r\n       uses, on average, twice as much CPU time. */\r\n\r\nSee also the top of the file.\r\n\r\nBesides the bad consequences for the CPU usage, it also hints libvncserver to use JPEG compression more often and thus sometimes blurs text. Red text in terminals on Ubuntu MATE 16.04 (with Vino) is affected. The screenshot below is with medium JPEG quality, but the same kind of blur is also reproducible with high JPEG quality, so it's best to avoid triggering this bug.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/2943163/21530771/edcded82-cd64-11e6-9082-d97d543c311c.png)\r\n\r\nI suggest defaulting to ['compress_custom', -254 ] which is the highest compression level that doesn't lead to this kind of artifact."},"comment":{"url":"https://api.github.com/repos/novnc/noVNC/issues/comments/417571750","html_url":"https://github.com/novnc/noVNC/issues/737#issuecomment-417571750","issue_url":"https://api.github.com/repos/novnc/noVNC/issues/737","id":417571750,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzU3MTc1MA==","user":{"login":"hongweipeng","id":7546325,"node_id":"MDQ6VXNlcjc1NDYzMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7546325?v=4","gravatar_id":"","url":"https://api.github.com/users/hongweipeng","html_url":"https://github.com/hongweipeng","followers_url":"https://api.github.com/users/hongweipeng/followers","following_url":"https://api.github.com/users/hongweipeng/following{/other_user}","gists_url":"https://api.github.com/users/hongweipeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongweipeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongweipeng/subscriptions","organizations_url":"https://api.github.com/users/hongweipeng/orgs","repos_url":"https://api.github.com/users/hongweipeng/repos","events_url":"https://api.github.com/users/hongweipeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongweipeng/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T07:00:57Z","updated_at":"2018-08-31T07:00:57Z","author_association":"NONE","body":"@patrakov hi brother, where can set jpeg compression level? I want to use the `JPEG_quality_lo` ."}}
{"actor":{"display_login":"hongweipeng"}}