{"action":"closed","issue":{"url":"https://api.github.com/repos/Elgg/Elgg/issues/12133","repository_url":"https://api.github.com/repos/Elgg/Elgg","labels_url":"https://api.github.com/repos/Elgg/Elgg/issues/12133/labels{/name}","comments_url":"https://api.github.com/repos/Elgg/Elgg/issues/12133/comments","events_url":"https://api.github.com/repos/Elgg/Elgg/issues/12133/events","html_url":"https://github.com/Elgg/Elgg/issues/12133","id":346536197,"node_id":"MDU6SXNzdWUzNDY1MzYxOTc=","number":12133,"title":"Stripping html tags necessary in messages_send() of messages plugin?","user":{"login":"iionly","id":1773681,"node_id":"MDQ6VXNlcjE3NzM2ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1773681?v=4","gravatar_id":"","url":"https://api.github.com/users/iionly","html_url":"https://github.com/iionly","followers_url":"https://api.github.com/users/iionly/followers","following_url":"https://api.github.com/users/iionly/following{/other_user}","gists_url":"https://api.github.com/users/iionly/gists{/gist_id}","starred_url":"https://api.github.com/users/iionly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iionly/subscriptions","organizations_url":"https://api.github.com/users/iionly/orgs","repos_url":"https://api.github.com/users/iionly/repos","events_url":"https://api.github.com/users/iionly/events{/privacy}","received_events_url":"https://api.github.com/users/iionly/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-01T10:13:40Z","updated_at":"2018-08-03T10:59:50Z","closed_at":"2018-08-03T10:59:50Z","author_association":"CONTRIBUTOR","body":"There's this discussion on the community site: https://elgg.org/discussion/view/2798328/emails-from-messages-do-not-retain-their-html-tags\r\n\r\nIt's about sending of email notification on new messages getting stripped from html tags.\r\n\r\nAs it seems the Elgg core elgg_send_email() function (https://github.com/Elgg/Elgg/blob/1cb28271f8f9c517f25c73424e22bbbf1c17ba15/engine/lib/notification.php#L592) strips html tags BUT does this only after triggering the 'email', 'system' plugin hook. So, you could use the hook to deal with email sending on your own (and also allow sending of html mails).\r\n\r\nSo, why would it be necessary for the messages plugin to also strip html tags before then making use of notify_user() which I assume means that the actual sending of the email gets done by elgg_send_email() in the following where the html tags again get stripped but at least only after the email', 'system' plugin hook gets triggered whereas the filtering within the messages plugin messages_send() can't be avoided?"}}
{"actor":{"display_login":"jeabakker"}}