{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments/217088182","pull_request_review_id":154719398,"id":217088182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzA4ODE4Mg==","diff_hunk":"@@ -59,7 +62,9 @@ ADD parser_viaq_docker_audit.rb viaq_docker_audit.rb /etc/fluent/plugin/\n ADD run.sh generate_syslog_config.rb ${HOME}/\n ADD lib/generate_throttle_configs/lib/*.rb ${HOME}/\n ADD lib/filter_parse_json_field/lib/*.rb /etc/fluent/plugin/\n-COPY utils/** ${HOME}/utils\n+COPY patch/logger/log.rb ${GEM_HOME}/gems/fluentd-0.12.43/lib/fluent\n+COPY patch/logger/supervisor.rb ${GEM_HOME}/gems/fluentd-0.12.43/lib/fluent\n+COPY utils/** ${HOME}/utils/","path":"fluentd/Dockerfile.centos7","position":19,"original_position":19,"commit_id":"af59a9f2f9d19262c3ef3c236577b41149be3782","original_commit_id":"af59a9f2f9d19262c3ef3c236577b41149be3782","user":{"login":"richm","id":23066,"node_id":"MDQ6VXNlcjIzMDY2","avatar_url":"https://avatars2.githubusercontent.com/u/23066?v=4","gravatar_id":"","url":"https://api.github.com/users/richm","html_url":"https://github.com/richm","followers_url":"https://api.github.com/users/richm/followers","following_url":"https://api.github.com/users/richm/following{/other_user}","gists_url":"https://api.github.com/users/richm/gists{/gist_id}","starred_url":"https://api.github.com/users/richm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richm/subscriptions","organizations_url":"https://api.github.com/users/richm/orgs","repos_url":"https://api.github.com/users/richm/repos","events_url":"https://api.github.com/users/richm/events{/privacy}","received_events_url":"https://api.github.com/users/richm/received_events","type":"User","site_admin":false},"body":"Do not change `COPY utils/** ${HOME}/utils/` as that seems to be working afaik.  I don't know why.\r\n\r\n> Also why is the \"ci/openshift-jenkins/logging\" test running twice?\r\n\r\nWhere do you see that?  There should only be a `/logging` and a `/json-file` test - each one should be run only once.\r\n\r\n> (In jenkins it is called journald why is that?)\r\n\r\nOriginally there was only one logging CI test, just called `/logging`, which used docker with `--log-driver=journald`.  When we added support for docker with `--log-driver=json-file` we added a new test called `/json-file`.  The test `ci/openshift-jenkins/logging` is really \"deploy docker with --log-driver=journald and test logging\", and `ci/openshift-jenkins/json-file` is \"deploy docker with --log=driver=json-file and test logging\".","created_at":"2018-09-12T15:49:11Z","updated_at":"2018-09-12T15:49:12Z","html_url":"https://github.com/openshift/origin-aggregated-logging/pull/1336#discussion_r217088182","pull_request_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1336","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments/217088182"},"html":{"href":"https://github.com/openshift/origin-aggregated-logging/pull/1336#discussion_r217088182"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1336"}},"in_reply_to_id":216877728},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1336","id":213966214,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTY2MjE0","html_url":"https://github.com/openshift/origin-aggregated-logging/pull/1336","diff_url":"https://github.com/openshift/origin-aggregated-logging/pull/1336.diff","patch_url":"https://github.com/openshift/origin-aggregated-logging/pull/1336.patch","issue_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/1336","number":1336,"state":"open","locked":false,"title":"Fluentd supports logging to file","user":{"login":"VladMasarik","id":28529900,"node_id":"MDQ6VXNlcjI4NTI5OTAw","avatar_url":"https://avatars0.githubusercontent.com/u/28529900?v=4","gravatar_id":"","url":"https://api.github.com/users/VladMasarik","html_url":"https://github.com/VladMasarik","followers_url":"https://api.github.com/users/VladMasarik/followers","following_url":"https://api.github.com/users/VladMasarik/following{/other_user}","gists_url":"https://api.github.com/users/VladMasarik/gists{/gist_id}","starred_url":"https://api.github.com/users/VladMasarik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladMasarik/subscriptions","organizations_url":"https://api.github.com/users/VladMasarik/orgs","repos_url":"https://api.github.com/users/VladMasarik/repos","events_url":"https://api.github.com/users/VladMasarik/events{/privacy}","received_events_url":"https://api.github.com/users/VladMasarik/received_events","type":"User","site_admin":false},"body":"Added support for Fleuntd to write its logs into files and rotate them.\r\nEnvironment variables allow for configuration of the logging.\r\nCreated utility to retrieve and follow the log file.\r\nUpdated Dockerfiles to contain these changes.\r\nDocumented changes.","created_at":"2018-09-07T15:36:39Z","updated_at":"2018-09-12T15:49:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbac4a3ca671bd56ad9c1d07475700e4fd446b0e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ewolinetz","id":1427473,"node_id":"MDQ6VXNlcjE0Mjc0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1427473?v=4","gravatar_id":"","url":"https://api.github.com/users/ewolinetz","html_url":"https://github.com/ewolinetz","followers_url":"https://api.github.com/users/ewolinetz/followers","following_url":"https://api.github.com/users/ewolinetz/following{/other_user}","gists_url":"https://api.github.com/users/ewolinetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ewolinetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewolinetz/subscriptions","organizations_url":"https://api.github.com/users/ewolinetz/orgs","repos_url":"https://api.github.com/users/ewolinetz/repos","events_url":"https://api.github.com/users/ewolinetz/events{/privacy}","received_events_url":"https://api.github.com/users/ewolinetz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":921677155,"node_id":"MDU6TGFiZWw5MjE2NzcxNTU=","url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels/backport/3.10","name":"backport/3.10","color":"d93f0b","default":false},{"id":1049438601,"node_id":"MDU6TGFiZWwxMDQ5NDM4NjAx","url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels/backport/3.11","name":"backport/3.11","color":"d93f0b","default":false},{"id":850882356,"node_id":"MDU6TGFiZWw4NTA4ODIzNTY=","url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels/backport/3.9","name":"backport/3.9","color":"d93f0b","default":false},{"id":723759343,"node_id":"MDU6TGFiZWw3MjM3NTkzNDM=","url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":921673120,"node_id":"MDU6TGFiZWw5MjE2NzMxMjA=","url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels/release/4.0","name":"release/4.0","color":"bfd4f2","default":false},{"id":728703472,"node_id":"MDU6TGFiZWw3Mjg3MDM0NzI=","url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1336/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1336/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/1336/comments","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/af59a9f2f9d19262c3ef3c236577b41149be3782","head":{"label":"VladMasarik:fluentd-logging","ref":"fluentd-logging","sha":"af59a9f2f9d19262c3ef3c236577b41149be3782","user":{"login":"VladMasarik","id":28529900,"node_id":"MDQ6VXNlcjI4NTI5OTAw","avatar_url":"https://avatars0.githubusercontent.com/u/28529900?v=4","gravatar_id":"","url":"https://api.github.com/users/VladMasarik","html_url":"https://github.com/VladMasarik","followers_url":"https://api.github.com/users/VladMasarik/followers","following_url":"https://api.github.com/users/VladMasarik/following{/other_user}","gists_url":"https://api.github.com/users/VladMasarik/gists{/gist_id}","starred_url":"https://api.github.com/users/VladMasarik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladMasarik/subscriptions","organizations_url":"https://api.github.com/users/VladMasarik/orgs","repos_url":"https://api.github.com/users/VladMasarik/repos","events_url":"https://api.github.com/users/VladMasarik/events{/privacy}","received_events_url":"https://api.github.com/users/VladMasarik/received_events","type":"User","site_admin":false},"repo":{"id":146310361,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzMTAzNjE=","name":"origin-aggregated-logging","full_name":"VladMasarik/origin-aggregated-logging","owner":{"login":"VladMasarik","id":28529900,"node_id":"MDQ6VXNlcjI4NTI5OTAw","avatar_url":"https://avatars0.githubusercontent.com/u/28529900?v=4","gravatar_id":"","url":"https://api.github.com/users/VladMasarik","html_url":"https://github.com/VladMasarik","followers_url":"https://api.github.com/users/VladMasarik/followers","following_url":"https://api.github.com/users/VladMasarik/following{/other_user}","gists_url":"https://api.github.com/users/VladMasarik/gists{/gist_id}","starred_url":"https://api.github.com/users/VladMasarik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladMasarik/subscriptions","organizations_url":"https://api.github.com/users/VladMasarik/orgs","repos_url":"https://api.github.com/users/VladMasarik/repos","events_url":"https://api.github.com/users/VladMasarik/events{/privacy}","received_events_url":"https://api.github.com/users/VladMasarik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VladMasarik/origin-aggregated-logging","description":null,"fork":true,"url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging","forks_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/VladMasarik/origin-aggregated-logging/deployments","created_at":"2018-08-27T14:38:26Z","updated_at":"2018-08-29T15:06:49Z","pushed_at":"2018-09-11T15:37:37Z","git_url":"git://github.com/VladMasarik/origin-aggregated-logging.git","ssh_url":"git@github.com:VladMasarik/origin-aggregated-logging.git","clone_url":"https://github.com/VladMasarik/origin-aggregated-logging.git","svn_url":"https://github.com/VladMasarik/origin-aggregated-logging","homepage":null,"size":12751,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"b7383025a9c6e331780c3ee1775b077ec865ffa0","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":42467822,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQ2NzgyMg==","name":"origin-aggregated-logging","full_name":"openshift/origin-aggregated-logging","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-aggregated-logging","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/origin-aggregated-logging","forks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/deployments","created_at":"2015-09-14T18:14:19Z","updated_at":"2018-09-11T22:17:32Z","pushed_at":"2018-09-12T15:39:15Z","git_url":"git://github.com/openshift/origin-aggregated-logging.git","ssh_url":"git@github.com:openshift/origin-aggregated-logging.git","clone_url":"https://github.com/openshift/origin-aggregated-logging.git","svn_url":"https://github.com/openshift/origin-aggregated-logging","homepage":null,"size":12749,"stargazers_count":72,"watchers_count":72,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":75,"license":null,"forks":142,"open_issues":75,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1336"},"html":{"href":"https://github.com/openshift/origin-aggregated-logging/pull/1336"},"issue":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/1336"},"comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/1336/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1336/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1336/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/af59a9f2f9d19262c3ef3c236577b41149be3782"}},"author_association":"NONE"}}
{"actor":{"display_login":"richm"}}