{"action":"created","issue":{"url":"https://api.github.com/repos/gitcoinco/web/issues/1556","repository_url":"https://api.github.com/repos/gitcoinco/web","labels_url":"https://api.github.com/repos/gitcoinco/web/issues/1556/labels{/name}","comments_url":"https://api.github.com/repos/gitcoinco/web/issues/1556/comments","events_url":"https://api.github.com/repos/gitcoinco/web/issues/1556/events","html_url":"https://github.com/gitcoinco/web/pull/1556","id":336004347,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTYxOTI0","number":1556,"title":"Fix for #1457 (Updated zIndex for Cookie Banner)","user":{"login":"premachb","id":1824604,"node_id":"MDQ6VXNlcjE4MjQ2MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1824604?v=4","gravatar_id":"","url":"https://api.github.com/users/premachb","html_url":"https://github.com/premachb","followers_url":"https://api.github.com/users/premachb/followers","following_url":"https://api.github.com/users/premachb/following{/other_user}","gists_url":"https://api.github.com/users/premachb/gists{/gist_id}","starred_url":"https://api.github.com/users/premachb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/premachb/subscriptions","organizations_url":"https://api.github.com/users/premachb/orgs","repos_url":"https://api.github.com/users/premachb/repos","events_url":"https://api.github.com/users/premachb/events{/privacy}","received_events_url":"https://api.github.com/users/premachb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-26T21:52:18Z","updated_at":"2018-06-26T21:56:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/gitcoinco/web/pulls/1556","html_url":"https://github.com/gitcoinco/web/pull/1556","diff_url":"https://github.com/gitcoinco/web/pull/1556.diff","patch_url":"https://github.com/gitcoinco/web/pull/1556.patch"},"body":"<!--\r\n  Thank you for your pull request. Please provide a description above and review\r\n  the requirements below.\r\n\r\n  Contributors guide: https://github.com/gitcoinco/web/blob/contributing/CONTRIBUTING.md\r\n-->\r\n\r\n##### Description\r\n<!-- A description on what this PR aims to solve -->\r\n\r\nUpdated the zIndex for the cookie banner on the ENS page so that the login box doesn't go above it. \r\n\r\nBefore: \r\n\r\n![before](https://user-images.githubusercontent.com/1824604/41941208-4915811c-7969-11e8-84b3-ce702e5f0377.png)\r\n\r\nAfter:\r\n\r\n![after](https://user-images.githubusercontent.com/1824604/41941213-4e3b4104-7969-11e8-9eab-1a26506c0b03.png)\r\n\r\nThis also includes a fix for the body vertically expanding due to the rain effect on the page. Modified body to use overflow rather than just overflow-x. As the yge and ens both use this main.css module, I made sure this didn't break both which it doesn't seem to.\r\n\r\nI can revert this if there is a specific reason for using overflow-x here.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] linter status: 100% pass\r\n- [x] changes don't break existing behavior\r\n- [x] commit message follows [commit guidelines](https://github.com/gitcoinco/web/blob/master/docs/CONTRIBUTING.md#step-4-commit)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, ui, crypto, etc). -->\r\n\r\nENS\r\n\r\n##### Testing\r\n<!-- Why should the PR reviewer trust that this change doesn't break anything? How have you tested this change? -->\r\n\r\nSimple CSS change so mostly just by checking both pages that use the css module I modified. Let me know if I missed anything\r\n\r\n##### Refers/Fixes\r\n<!--\r\n  Link to an issue if applicable. For example:\r\n  If your PR fixes an issue  -> Fixes: #102\r\n  If your PR refers an issue -> Refs: #101\r\n-->\r\n\r\nRefs: #1457 \r\n"},"comment":{"url":"https://api.github.com/repos/gitcoinco/web/issues/comments/400475966","html_url":"https://github.com/gitcoinco/web/pull/1556#issuecomment-400475966","issue_url":"https://api.github.com/repos/gitcoinco/web/issues/1556","id":400475966,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDQ3NTk2Ng==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-06-26T21:56:32Z","updated_at":"2018-06-26T21:56:32Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/gitcoinco/web/pull/1556?src=pr&el=h1) Report\n> Merging [#1556](https://codecov.io/gh/gitcoinco/web/pull/1556?src=pr&el=desc) into [master](https://codecov.io/gh/gitcoinco/web/commit/fe377988f3a4562da7c0a1e10e0f31b3a5e6c5b6?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/gitcoinco/web/pull/1556/graphs/tree.svg?token=w4mB7fvPA9&height=150&width=650&src=pr)](https://codecov.io/gh/gitcoinco/web/pull/1556?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master    #1556   +/-   ##\n=======================================\n  Coverage   28.41%   28.41%           \n=======================================\n  Files         130      130           \n  Lines        9561     9561           \n  Branches     1237     1237           \n=======================================\n  Hits         2717     2717           \n  Misses       6746     6746           \n  Partials       98       98\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/gitcoinco/web/pull/1556?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/gitcoinco/web/pull/1556?src=pr&el=footer). Last update [fe37798...ab2184b](https://codecov.io/gh/gitcoinco/web/pull/1556?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}