{"action":"created","comment":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/234464077","pull_request_review_id":176108244,"id":234464077,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQ2NDA3Nw==","diff_hunk":"@@ -329,6 +329,16 @@ public override string CurrentTimestampSelectString\n \n \t\tpublic override string QuerySequencesString => \"SELECT c.relname FROM pg_class c WHERE c.relkind = 'S'\";\n \n+\t\t/// <summary>\n+\t\t/// Does this dialect supports distributed transaction? <c>false</c>.\n+\t\t/// </summary>\n+\t\t/// <remarks>\n+\t\t/// Npgsql since its version 3.2.5 version has race conditions: it fails handling the threading involved with\n+\t\t/// distributed transactions. This causes a bunch of distributed tests to be flaky with Npgsql. Individually,\n+\t\t/// they usually succeed, but run together, some of them fail. The trouble was not occuring with Npgsql 3.2.4.1.\n+\t\t/// </remarks>\n+\t\tpublic override bool SupportsDistributedTransactions => false;","path":"src/NHibernate/Dialect/PostgreSQLDialect.cs","position":12,"original_position":12,"commit_id":"d5f46786ad903617b194eeeefebe8f1ce9b16d7e","original_commit_id":"d5f46786ad903617b194eeeefebe8f1ce9b16d7e","user":{"login":"hazzik","id":144791,"node_id":"MDQ6VXNlcjE0NDc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/144791?v=4","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"body":"I don't quite agree with this change. It does support distributed transactions, but has some bugs. Also, not related, but, it seems that this property should be on a driver, not on a dialect.","created_at":"2018-11-18T22:02:41Z","updated_at":"2018-11-18T22:02:41Z","html_url":"https://github.com/nhibernate/nhibernate-core/pull/1905#discussion_r234464077","pull_request_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1905","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/234464077"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/1905#discussion_r234464077"},"pull_request":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1905"}}},"pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1905","id":230972980,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTcyOTgw","html_url":"https://github.com/nhibernate/nhibernate-core/pull/1905","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/1905.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/1905.patch","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1905","number":1905,"state":"open","locked":false,"title":"Improve support of Npgsql 4","user":{"login":"hazzik","id":144791,"node_id":"MDQ6VXNlcjE0NDc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/144791?v=4","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"body":"We have some compatibility issues with the newer driver, so need to upgrade","created_at":"2018-11-14T20:35:45Z","updated_at":"2018-11-18T22:02:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e51de0126925aeb58e4a139be16903659361f70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":717851462,"node_id":"MDU6TGFiZWw3MTc4NTE0NjI=","url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels/c:%20DataProviders%20/%20Dialects","name":"c: DataProviders / Dialects","color":"ededed","default":false},{"id":717863290,"node_id":"MDU6TGFiZWw3MTc4NjMyOTA=","url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels/p:%20Minor","name":"p: Minor","color":"f9d0c4","default":false},{"id":661468479,"node_id":"MDU6TGFiZWw2NjE0Njg0Nzk=","url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels/t:%20Improvement","name":"t: Improvement","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1905/commits","review_comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1905/comments","review_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1905/comments","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/d5f46786ad903617b194eeeefebe8f1ce9b16d7e","head":{"label":"hazzik:npgsql4","ref":"npgsql4","sha":"d5f46786ad903617b194eeeefebe8f1ce9b16d7e","user":{"login":"hazzik","id":144791,"node_id":"MDQ6VXNlcjE0NDc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/144791?v=4","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"repo":{"id":3009271,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjcx","name":"nhibernate-core","full_name":"hazzik/nhibernate-core","private":false,"owner":{"login":"hazzik","id":144791,"node_id":"MDQ6VXNlcjE0NDc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/144791?v=4","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hazzik/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/hazzik/nhibernate-core","forks_url":"https://api.github.com/repos/hazzik/nhibernate-core/forks","keys_url":"https://api.github.com/repos/hazzik/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazzik/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazzik/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/hazzik/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/hazzik/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/hazzik/nhibernate-core/events","assignees_url":"https://api.github.com/repos/hazzik/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/hazzik/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/hazzik/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazzik/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hazzik/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/hazzik/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/hazzik/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/hazzik/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/hazzik/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/hazzik/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazzik/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazzik/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazzik/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/hazzik/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazzik/nhibernate-core/merges","archive_url":"https://api.github.com/repos/hazzik/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazzik/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/hazzik/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/hazzik/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hazzik/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hazzik/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazzik/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/hazzik/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/hazzik/nhibernate-core/deployments","created_at":"2011-12-19T02:04:00Z","updated_at":"2018-11-14T03:22:06Z","pushed_at":"2018-11-16T15:29:09Z","git_url":"git://github.com/hazzik/nhibernate-core.git","ssh_url":"git@github.com:hazzik/nhibernate-core.git","clone_url":"https://github.com/hazzik/nhibernate-core.git","svn_url":"https://github.com/hazzik/nhibernate-core","homepage":"http://nhibernate.info","size":85838,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":15,"watchers":3,"default_branch":"master"}},"base":{"label":"nhibernate:master","ref":"master","sha":"018cf1c9114b9f698b4bf1b8270bba12b0f80b8e","user":{"login":"nhibernate","id":961041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MTA0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":2206199,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA2MTk5","name":"nhibernate-core","full_name":"nhibernate/nhibernate-core","private":false,"owner":{"login":"nhibernate","id":961041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MTA0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nhibernate/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":false,"url":"https://api.github.com/repos/nhibernate/nhibernate-core","forks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/forks","keys_url":"https://api.github.com/repos/nhibernate/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhibernate/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhibernate/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/events","assignees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/nhibernate/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/nhibernate/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/nhibernate/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhibernate/nhibernate-core/merges","archive_url":"https://api.github.com/repos/nhibernate/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhibernate/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/nhibernate/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/nhibernate/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/deployments","created_at":"2011-08-14T17:51:09Z","updated_at":"2018-11-16T12:02:50Z","pushed_at":"2018-11-16T16:45:37Z","git_url":"git://github.com/nhibernate/nhibernate-core.git","ssh_url":"git@github.com:nhibernate/nhibernate-core.git","clone_url":"https://github.com/nhibernate/nhibernate-core.git","svn_url":"https://github.com/nhibernate/nhibernate-core","homepage":"http://nhibernate.info","size":85677,"stargazers_count":1484,"watchers_count":1484,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":795,"mirror_url":null,"archived":false,"open_issues_count":596,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":795,"open_issues":596,"watchers":1484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1905"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/1905"},"issue":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1905"},"comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1905/comments"},"review_comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1905/comments"},"review_comment":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1905/commits"},"statuses":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/d5f46786ad903617b194eeeefebe8f1ce9b16d7e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hazzik"}}