{"action":"created","comment":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/195070702","pull_request_review_id":128362818,"id":195070702,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTA3MDcwMg==","diff_hunk":"@@ -1401,6 +1423,13 @@ STATIC_UNIT_TESTED void osdRefresh(timeUs_t currentTimeUs)\n     static timeUs_t osdStatsRefreshTimeUs;\n     static uint16_t endBatteryVoltage;\n \n+#ifdef USE_DSHOT\n+    if (isTryingToArm() && !ARMING_FLAG(ARMED)) {\n+        osdShowTryingToArm(currentTimeUs);","path":"src/main/io/osd.c","position":46,"original_position":46,"commit_id":"843a25903a8625dc7e5d82eb65e8c09c9ddc574c","original_commit_id":"843a25903a8625dc7e5d82eb65e8c09c9ddc574c","user":{"login":"etracer65","id":17088539,"node_id":"MDQ6VXNlcjE3MDg4NTM5","avatar_url":"https://avatars1.githubusercontent.com/u/17088539?v=4","gravatar_id":"","url":"https://api.github.com/users/etracer65","html_url":"https://github.com/etracer65","followers_url":"https://api.github.com/users/etracer65/followers","following_url":"https://api.github.com/users/etracer65/following{/other_user}","gists_url":"https://api.github.com/users/etracer65/gists{/gist_id}","starred_url":"https://api.github.com/users/etracer65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etracer65/subscriptions","organizations_url":"https://api.github.com/users/etracer65/orgs","repos_url":"https://api.github.com/users/etracer65/repos","events_url":"https://api.github.com/users/etracer65/events{/privacy}","received_events_url":"https://api.github.com/users/etracer65/received_events","type":"User","site_admin":false},"body":"Well I did actually initially think about making it a warning.  But because of:\r\n1. User could disable warnings\r\n2. Warning size is only 11 characters\r\n3. Not really a \"arming disabled\" but \"arming delayed\" message\r\n\r\nItem 1 was the big issue.  For item 2 I would need to increase a few bytes to maintain the \"ARMING In x.y\" countdown feedback.  But this wouldn't provide the opportunity to display why the delay was happening like I do now with showing \"DISABLING BEACON\".  Item 3 is just semantics.\r\n\r\nSo item 1 was the biggest deal for me, followed by the loss in information for item 2.  But I'm open to changing it to a warning if we want to accept these issues.  I think it would need to override other possible warnings except for arming disabled reasons - but that will automatically happen becasue `isTryingToArm()` will never be true in these circumstances.\r\n\r\nAlso as you may have seen I opened an issue and called out Felix and Stefan to see if we can't fix this problem in the ESC firmware going forward.  Hopefully that'll be our long-term solution and we can eliminate this arming delayed code completely.","created_at":"2018-06-13T12:58:56Z","updated_at":"2018-06-13T12:58:56Z","html_url":"https://github.com/betaflight/betaflight/pull/6104#discussion_r195070702","pull_request_url":"https://api.github.com/repos/betaflight/betaflight/pulls/6104","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/195070702"},"html":{"href":"https://github.com/betaflight/betaflight/pull/6104#discussion_r195070702"},"pull_request":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/6104"}},"in_reply_to_id":195009631},"pull_request":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/6104","id":194440305,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDQwMzA1","html_url":"https://github.com/betaflight/betaflight/pull/6104","diff_url":"https://github.com/betaflight/betaflight/pull/6104.diff","patch_url":"https://github.com/betaflight/betaflight/pull/6104.patch","issue_url":"https://api.github.com/repos/betaflight/betaflight/issues/6104","number":6104,"state":"open","locked":false,"title":"Display OSD message and countdown if arming is delayed due to beacon","user":{"login":"etracer65","id":17088539,"node_id":"MDQ6VXNlcjE3MDg4NTM5","avatar_url":"https://avatars1.githubusercontent.com/u/17088539?v=4","gravatar_id":"","url":"https://api.github.com/users/etracer65","html_url":"https://github.com/etracer65","followers_url":"https://api.github.com/users/etracer65/followers","following_url":"https://api.github.com/users/etracer65/following{/other_user}","gists_url":"https://api.github.com/users/etracer65/gists{/gist_id}","starred_url":"https://api.github.com/users/etracer65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etracer65/subscriptions","organizations_url":"https://api.github.com/users/etracer65/orgs","repos_url":"https://api.github.com/users/etracer65/repos","events_url":"https://api.github.com/users/etracer65/events{/privacy}","received_events_url":"https://api.github.com/users/etracer65/received_events","type":"User","site_admin":false},"body":"Provides a clear indication that arming is delayed for cases where DSHOT beacon is active.\r\n\r\nClears the OSD and displays \"DISABLING BEACON\" and \"ARMING IN X.Y\" with an active countdown in tenths of a second while arming is delayed due to DSHOT beacon. Once delay period is over the normal \"ARMING\" message appears.\r\n\r\nIf the DSHOT beacon is not active then this delay screen is not displayed.\r\n","created_at":"2018-06-13T00:11:46Z","updated_at":"2018-06-13T12:58:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e05d6a16591aaf2948ce9d11df2460ee01d66b26","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":668857686,"node_id":"MDU6TGFiZWw2Njg4NTc2ODY=","url":"https://api.github.com/repos/betaflight/betaflight/labels/RN:%20IMPROVEMENT","name":"RN: IMPROVEMENT","color":"f9d0c4","default":false}],"milestone":{"url":"https://api.github.com/repos/betaflight/betaflight/milestones/7","html_url":"https://github.com/betaflight/betaflight/milestone/7","labels_url":"https://api.github.com/repos/betaflight/betaflight/milestones/7/labels","id":2278188,"node_id":"MDk6TWlsZXN0b25lMjI3ODE4OA==","number":7,"title":"Betaflight v3.4","description":"","creator":{"login":"blckmn","id":6168871,"node_id":"MDQ6VXNlcjYxNjg4NzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6168871?v=4","gravatar_id":"","url":"https://api.github.com/users/blckmn","html_url":"https://github.com/blckmn","followers_url":"https://api.github.com/users/blckmn/followers","following_url":"https://api.github.com/users/blckmn/following{/other_user}","gists_url":"https://api.github.com/users/blckmn/gists{/gist_id}","starred_url":"https://api.github.com/users/blckmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blckmn/subscriptions","organizations_url":"https://api.github.com/users/blckmn/orgs","repos_url":"https://api.github.com/users/blckmn/repos","events_url":"https://api.github.com/users/blckmn/events{/privacy}","received_events_url":"https://api.github.com/users/blckmn/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":351,"state":"open","created_at":"2017-01-25T19:22:55Z","updated_at":"2018-06-13T10:59:57Z","due_on":"2018-07-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/betaflight/betaflight/pulls/6104/commits","review_comments_url":"https://api.github.com/repos/betaflight/betaflight/pulls/6104/comments","review_comment_url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betaflight/betaflight/issues/6104/comments","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/843a25903a8625dc7e5d82eb65e8c09c9ddc574c","head":{"label":"etracer65:beacon_arm_delay_osd","ref":"beacon_arm_delay_osd","sha":"843a25903a8625dc7e5d82eb65e8c09c9ddc574c","user":{"login":"etracer65","id":17088539,"node_id":"MDQ6VXNlcjE3MDg4NTM5","avatar_url":"https://avatars1.githubusercontent.com/u/17088539?v=4","gravatar_id":"","url":"https://api.github.com/users/etracer65","html_url":"https://github.com/etracer65","followers_url":"https://api.github.com/users/etracer65/followers","following_url":"https://api.github.com/users/etracer65/following{/other_user}","gists_url":"https://api.github.com/users/etracer65/gists{/gist_id}","starred_url":"https://api.github.com/users/etracer65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etracer65/subscriptions","organizations_url":"https://api.github.com/users/etracer65/orgs","repos_url":"https://api.github.com/users/etracer65/repos","events_url":"https://api.github.com/users/etracer65/events{/privacy}","received_events_url":"https://api.github.com/users/etracer65/received_events","type":"User","site_admin":false},"repo":{"id":126493168,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY0OTMxNjg=","name":"betaflight","full_name":"etracer65/betaflight","owner":{"login":"etracer65","id":17088539,"node_id":"MDQ6VXNlcjE3MDg4NTM5","avatar_url":"https://avatars1.githubusercontent.com/u/17088539?v=4","gravatar_id":"","url":"https://api.github.com/users/etracer65","html_url":"https://github.com/etracer65","followers_url":"https://api.github.com/users/etracer65/followers","following_url":"https://api.github.com/users/etracer65/following{/other_user}","gists_url":"https://api.github.com/users/etracer65/gists{/gist_id}","starred_url":"https://api.github.com/users/etracer65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etracer65/subscriptions","organizations_url":"https://api.github.com/users/etracer65/orgs","repos_url":"https://api.github.com/users/etracer65/repos","events_url":"https://api.github.com/users/etracer65/events{/privacy}","received_events_url":"https://api.github.com/users/etracer65/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/etracer65/betaflight","description":null,"fork":true,"url":"https://api.github.com/repos/etracer65/betaflight","forks_url":"https://api.github.com/repos/etracer65/betaflight/forks","keys_url":"https://api.github.com/repos/etracer65/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etracer65/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etracer65/betaflight/teams","hooks_url":"https://api.github.com/repos/etracer65/betaflight/hooks","issue_events_url":"https://api.github.com/repos/etracer65/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/etracer65/betaflight/events","assignees_url":"https://api.github.com/repos/etracer65/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/etracer65/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/etracer65/betaflight/tags","blobs_url":"https://api.github.com/repos/etracer65/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etracer65/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etracer65/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/etracer65/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etracer65/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/etracer65/betaflight/languages","stargazers_url":"https://api.github.com/repos/etracer65/betaflight/stargazers","contributors_url":"https://api.github.com/repos/etracer65/betaflight/contributors","subscribers_url":"https://api.github.com/repos/etracer65/betaflight/subscribers","subscription_url":"https://api.github.com/repos/etracer65/betaflight/subscription","commits_url":"https://api.github.com/repos/etracer65/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/etracer65/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/etracer65/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/etracer65/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/etracer65/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/etracer65/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etracer65/betaflight/merges","archive_url":"https://api.github.com/repos/etracer65/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etracer65/betaflight/downloads","issues_url":"https://api.github.com/repos/etracer65/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/etracer65/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/etracer65/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/etracer65/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etracer65/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/etracer65/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/etracer65/betaflight/deployments","created_at":"2018-03-23T14:02:13Z","updated_at":"2018-06-11T14:51:36Z","pushed_at":"2018-06-13T00:09:07Z","git_url":"git://github.com/etracer65/betaflight.git","ssh_url":"git@github.com:etracer65/betaflight.git","clone_url":"https://github.com/etracer65/betaflight.git","svn_url":"https://github.com/etracer65/betaflight","homepage":"","size":226053,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"betaflight:master","ref":"master","sha":"a5ba01666bdadd00018bc432e0cf17ffe50ffbc5","user":{"login":"betaflight","id":19597933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk3OTMz","avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"repo":{"id":37060852,"node_id":"MDEwOlJlcG9zaXRvcnkzNzA2MDg1Mg==","name":"betaflight","full_name":"betaflight/betaflight","owner":{"login":"betaflight","id":19597933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk3OTMz","avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/betaflight/betaflight","description":"Open Source Flight Controller Firmware","fork":false,"url":"https://api.github.com/repos/betaflight/betaflight","forks_url":"https://api.github.com/repos/betaflight/betaflight/forks","keys_url":"https://api.github.com/repos/betaflight/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betaflight/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betaflight/betaflight/teams","hooks_url":"https://api.github.com/repos/betaflight/betaflight/hooks","issue_events_url":"https://api.github.com/repos/betaflight/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/betaflight/betaflight/events","assignees_url":"https://api.github.com/repos/betaflight/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/betaflight/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/betaflight/betaflight/tags","blobs_url":"https://api.github.com/repos/betaflight/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betaflight/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betaflight/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/betaflight/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/betaflight/betaflight/languages","stargazers_url":"https://api.github.com/repos/betaflight/betaflight/stargazers","contributors_url":"https://api.github.com/repos/betaflight/betaflight/contributors","subscribers_url":"https://api.github.com/repos/betaflight/betaflight/subscribers","subscription_url":"https://api.github.com/repos/betaflight/betaflight/subscription","commits_url":"https://api.github.com/repos/betaflight/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/betaflight/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/betaflight/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/betaflight/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/betaflight/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/betaflight/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betaflight/betaflight/merges","archive_url":"https://api.github.com/repos/betaflight/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betaflight/betaflight/downloads","issues_url":"https://api.github.com/repos/betaflight/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/betaflight/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/betaflight/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/betaflight/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betaflight/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/betaflight/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/betaflight/betaflight/deployments","created_at":"2015-06-08T10:37:44Z","updated_at":"2018-06-13T11:00:08Z","pushed_at":"2018-06-13T12:52:48Z","git_url":"git://github.com/betaflight/betaflight.git","ssh_url":"git@github.com:betaflight/betaflight.git","clone_url":"https://github.com/betaflight/betaflight.git","svn_url":"https://github.com/betaflight/betaflight","homepage":"","size":226111,"stargazers_count":1724,"watchers_count":1724,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":864,"mirror_url":null,"archived":false,"open_issues_count":200,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":864,"open_issues":200,"watchers":1724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/6104"},"html":{"href":"https://github.com/betaflight/betaflight/pull/6104"},"issue":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/6104"},"comments":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/6104/comments"},"review_comments":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/6104/comments"},"review_comment":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/6104/commits"},"statuses":{"href":"https://api.github.com/repos/betaflight/betaflight/statuses/843a25903a8625dc7e5d82eb65e8c09c9ddc574c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"etracer65"}}