{"action":"created","issue":{"url":"https://api.github.com/repos/ambrosus/ambrosus-node/issues/138","repository_url":"https://api.github.com/repos/ambrosus/ambrosus-node","labels_url":"https://api.github.com/repos/ambrosus/ambrosus-node/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/ambrosus/ambrosus-node/issues/138/comments","events_url":"https://api.github.com/repos/ambrosus/ambrosus-node/issues/138/events","html_url":"https://github.com/ambrosus/ambrosus-node/pull/138","id":325613859,"number":138,"title":"WIP: Docker improvements for local development","user":{"login":"danihodovic","id":5557301,"avatar_url":"https://avatars2.githubusercontent.com/u/5557301?v=4","gravatar_id":"","url":"https://api.github.com/users/danihodovic","html_url":"https://github.com/danihodovic","followers_url":"https://api.github.com/users/danihodovic/followers","following_url":"https://api.github.com/users/danihodovic/following{/other_user}","gists_url":"https://api.github.com/users/danihodovic/gists{/gist_id}","starred_url":"https://api.github.com/users/danihodovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danihodovic/subscriptions","organizations_url":"https://api.github.com/users/danihodovic/orgs","repos_url":"https://api.github.com/users/danihodovic/repos","events_url":"https://api.github.com/users/danihodovic/events{/privacy}","received_events_url":"https://api.github.com/users/danihodovic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-23T09:05:09Z","updated_at":"2018-05-24T12:37:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ambrosus/ambrosus-node/pulls/138","html_url":"https://github.com/ambrosus/ambrosus-node/pull/138","diff_url":"https://github.com/ambrosus/ambrosus-node/pull/138.diff","patch_url":"https://github.com/ambrosus/ambrosus-node/pull/138.patch"},"body":"This commit contains various Docker improvements so that Docker and\r\ndocker-compose can be used for local development seamlessly.\r\n\r\n- volumes are used to mount host source files in the Node container\r\n- Parity is dockerized with docker-compose\r\n- the Node inspector is exposed on 0.0.0.0 to allow debugging from an\r\n  app running within a container\r\n\r\nI would like to simplify how configuration is passed to the Node\r\napplication, but that's out of the scope of the PR, so I've only\r\nmodified it to ensure it works within the Docker environment.\r\n\r\nThe documentation has been modified to reflect these changes. The\r\ndocumentation assumes Docker as the first approach to setting up a\r\ndevelopment environment. The other approaches were removed."},"comment":{"url":"https://api.github.com/repos/ambrosus/ambrosus-node/issues/comments/391698827","html_url":"https://github.com/ambrosus/ambrosus-node/pull/138#issuecomment-391698827","issue_url":"https://api.github.com/repos/ambrosus/ambrosus-node/issues/138","id":391698827,"user":{"login":"danihodovic","id":5557301,"avatar_url":"https://avatars2.githubusercontent.com/u/5557301?v=4","gravatar_id":"","url":"https://api.github.com/users/danihodovic","html_url":"https://github.com/danihodovic","followers_url":"https://api.github.com/users/danihodovic/followers","following_url":"https://api.github.com/users/danihodovic/following{/other_user}","gists_url":"https://api.github.com/users/danihodovic/gists{/gist_id}","starred_url":"https://api.github.com/users/danihodovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danihodovic/subscriptions","organizations_url":"https://api.github.com/users/danihodovic/orgs","repos_url":"https://api.github.com/users/danihodovic/repos","events_url":"https://api.github.com/users/danihodovic/events{/privacy}","received_events_url":"https://api.github.com/users/danihodovic/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T12:37:02Z","updated_at":"2018-05-24T12:37:02Z","author_association":"CONTRIBUTOR","body":"> You have removed support for the WEB3_RPC env variable, so this should also be removed.\r\nFixed in https://github.com/ambrosus/ambrosus-node/pull/138/commits/fc7980d8fb34ea5ad490a4af2a09b46223346de5\r\n\r\n> you don't really need parity for tests. They run against Ganache;\r\nFixed in https://github.com/ambrosus/ambrosus-node/pull/138/commits/4639bb290ab5534cdb060ec23caa4fc2383635e7\r\n\r\n> IMO: this should be taken from the config with only the database name replaced.\r\nFixed in https://github.com/ambrosus/ambrosus-node/pull/138/commits/684b4d20cfb4874952393f0ccd1911104e2bd1c2 by reading from the configuration and replacing the database name."}}
{"actor":{"display_login":"danihodovic"}}