{"action":"closed","number":2050,"pull_request":{"url":"https://api.github.com/repos/opendatakit/collect/pulls/2050","id":177089268,"html_url":"https://github.com/opendatakit/collect/pull/2050","diff_url":"https://github.com/opendatakit/collect/pull/2050.diff","patch_url":"https://github.com/opendatakit/collect/pull/2050.patch","issue_url":"https://api.github.com/repos/opendatakit/collect/issues/2050","number":2050,"state":"closed","locked":false,"title":"Addressed rotation problems in RangeWidget under RTL languages. Fix #1983","user":{"login":"huangyz0918","id":15646062,"avatar_url":"https://avatars0.githubusercontent.com/u/15646062?v=4","gravatar_id":"","url":"https://api.github.com/users/huangyz0918","html_url":"https://github.com/huangyz0918","followers_url":"https://api.github.com/users/huangyz0918/followers","following_url":"https://api.github.com/users/huangyz0918/following{/other_user}","gists_url":"https://api.github.com/users/huangyz0918/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyz0918/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyz0918/subscriptions","organizations_url":"https://api.github.com/users/huangyz0918/orgs","repos_url":"https://api.github.com/users/huangyz0918/repos","events_url":"https://api.github.com/users/huangyz0918/events{/privacy}","received_events_url":"https://api.github.com/users/huangyz0918/received_events","type":"User","site_admin":false},"body":"Closes #1983  \r\n\r\n#### What has been done to verify that this works as intended?\r\nI found a difference in native Android views. With RTL languages environment, Android would draw views in different directions with different API levels.(API level > 17 and API level 16). Besides, when we are under a RTL language circumstance, the routations may be totally different from LTR languages. So we need to check the Android version, the System Language and reverse the views if necessary.\r\n\r\n\r\nHere are some tests records:\r\n\r\n__Form and Form list:__\r\n\r\n|   Android 4.1.1 (API level 16)           |  Android 4.4 (API level 19)      |\r\n| ---- | :----: |\r\n|<img src=\"https://i.loli.net/2018/03/23/5ab5090b3e31e.png\" width = \"300\" align=center />|<img src=\"https://i.loli.net/2018/03/23/5ab50c7005aa5.png\" width = \"300\" align=center />|\r\n|<img src=\"https://i.loli.net/2018/03/23/5ab5090b3f490.png\" width = \"300\" align=center />|<img src=\"https://i.loli.net/2018/03/23/5ab50c700718f.png\" width = \"300\" align=center />|\r\n\r\n|   Android 5.0 (API level 21)           |  Android 6.0 (API level 23)      |\r\n| ---- | :----: |\r\n|<img src=\"https://i.loli.net/2018/03/23/5ab50cb1efac4.png\" width = \"300\" align=center />|<img src=\"https://i.loli.net/2018/03/23/5ab50ccf160d0.png\" width = \"300\" align=center />|\r\n|<img src=\"https://i.loli.net/2018/03/23/5ab50cb1f0290.png\" width = \"300\" align=center />|<img src=\"https://i.loli.net/2018/03/23/5ab50ccf17a52.png\" width = \"300\" align=center />|\r\n\r\n|   Android 7.0 (API level 24)           |  Android 8.0 (API level 26)      |\r\n| ---- | :----: |\r\n|<img src=\"https://i.loli.net/2018/03/23/5ab50d0ed1328.png\" width = \"300\" align=center />|<img src=\"https://i.loli.net/2018/03/23/5ab5143d0f52a.png\" width = \"300\" align=center />|\r\n|<img src=\"https://i.loli.net/2018/03/23/5ab50d0ed2b35.png\" width = \"300\" align=center />|<img src=\"https://i.loli.net/2018/03/23/5ab5143d111f5.png\" width = \"300\" align=center />|\r\n\r\n#### Why is this the best possible solution? Were any other approaches considered?\r\nBecause these problems were caused by Android System, difference API would cause different behaviors. So I think this is best way to address this problem.\r\n\r\n#### Are there any risks to merging this code? If so, what are they?\r\nNa\r\n#### Do we need any specific form for testing your changes? If so, please attach one.\r\nNo, this problem only relate to RangeWidget.","created_at":"2018-03-23T14:39:36Z","updated_at":"2018-03-28T16:44:33Z","closed_at":"2018-03-28T16:44:33Z","merged_at":"2018-03-28T16:44:33Z","merge_commit_sha":"f37b3834fef616f9b30007eec19471318e2af3cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":807015281,"url":"https://api.github.com/repos/opendatakit/collect/labels/behavior%20verified","name":"behavior verified","color":"ededed","default":false},{"id":612677864,"url":"https://api.github.com/repos/opendatakit/collect/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/opendatakit/collect/pulls/2050/commits","review_comments_url":"https://api.github.com/repos/opendatakit/collect/pulls/2050/comments","review_comment_url":"https://api.github.com/repos/opendatakit/collect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opendatakit/collect/issues/2050/comments","statuses_url":"https://api.github.com/repos/opendatakit/collect/statuses/9647329edb8e4b02ab83ccc70da71b14ec67dc98","head":{"label":"huangyz0918:issue#1983","ref":"issue#1983","sha":"9647329edb8e4b02ab83ccc70da71b14ec67dc98","user":{"login":"huangyz0918","id":15646062,"avatar_url":"https://avatars0.githubusercontent.com/u/15646062?v=4","gravatar_id":"","url":"https://api.github.com/users/huangyz0918","html_url":"https://github.com/huangyz0918","followers_url":"https://api.github.com/users/huangyz0918/followers","following_url":"https://api.github.com/users/huangyz0918/following{/other_user}","gists_url":"https://api.github.com/users/huangyz0918/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyz0918/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyz0918/subscriptions","organizations_url":"https://api.github.com/users/huangyz0918/orgs","repos_url":"https://api.github.com/users/huangyz0918/repos","events_url":"https://api.github.com/users/huangyz0918/events{/privacy}","received_events_url":"https://api.github.com/users/huangyz0918/received_events","type":"User","site_admin":false},"repo":{"id":126432741,"name":"collect","full_name":"huangyz0918/collect","owner":{"login":"huangyz0918","id":15646062,"avatar_url":"https://avatars0.githubusercontent.com/u/15646062?v=4","gravatar_id":"","url":"https://api.github.com/users/huangyz0918","html_url":"https://github.com/huangyz0918","followers_url":"https://api.github.com/users/huangyz0918/followers","following_url":"https://api.github.com/users/huangyz0918/following{/other_user}","gists_url":"https://api.github.com/users/huangyz0918/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyz0918/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyz0918/subscriptions","organizations_url":"https://api.github.com/users/huangyz0918/orgs","repos_url":"https://api.github.com/users/huangyz0918/repos","events_url":"https://api.github.com/users/huangyz0918/events{/privacy}","received_events_url":"https://api.github.com/users/huangyz0918/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huangyz0918/collect","description":"ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨","fork":true,"url":"https://api.github.com/repos/huangyz0918/collect","forks_url":"https://api.github.com/repos/huangyz0918/collect/forks","keys_url":"https://api.github.com/repos/huangyz0918/collect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huangyz0918/collect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huangyz0918/collect/teams","hooks_url":"https://api.github.com/repos/huangyz0918/collect/hooks","issue_events_url":"https://api.github.com/repos/huangyz0918/collect/issues/events{/number}","events_url":"https://api.github.com/repos/huangyz0918/collect/events","assignees_url":"https://api.github.com/repos/huangyz0918/collect/assignees{/user}","branches_url":"https://api.github.com/repos/huangyz0918/collect/branches{/branch}","tags_url":"https://api.github.com/repos/huangyz0918/collect/tags","blobs_url":"https://api.github.com/repos/huangyz0918/collect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huangyz0918/collect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huangyz0918/collect/git/refs{/sha}","trees_url":"https://api.github.com/repos/huangyz0918/collect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huangyz0918/collect/statuses/{sha}","languages_url":"https://api.github.com/repos/huangyz0918/collect/languages","stargazers_url":"https://api.github.com/repos/huangyz0918/collect/stargazers","contributors_url":"https://api.github.com/repos/huangyz0918/collect/contributors","subscribers_url":"https://api.github.com/repos/huangyz0918/collect/subscribers","subscription_url":"https://api.github.com/repos/huangyz0918/collect/subscription","commits_url":"https://api.github.com/repos/huangyz0918/collect/commits{/sha}","git_commits_url":"https://api.github.com/repos/huangyz0918/collect/git/commits{/sha}","comments_url":"https://api.github.com/repos/huangyz0918/collect/comments{/number}","issue_comment_url":"https://api.github.com/repos/huangyz0918/collect/issues/comments{/number}","contents_url":"https://api.github.com/repos/huangyz0918/collect/contents/{+path}","compare_url":"https://api.github.com/repos/huangyz0918/collect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huangyz0918/collect/merges","archive_url":"https://api.github.com/repos/huangyz0918/collect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huangyz0918/collect/downloads","issues_url":"https://api.github.com/repos/huangyz0918/collect/issues{/number}","pulls_url":"https://api.github.com/repos/huangyz0918/collect/pulls{/number}","milestones_url":"https://api.github.com/repos/huangyz0918/collect/milestones{/number}","notifications_url":"https://api.github.com/repos/huangyz0918/collect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huangyz0918/collect/labels{/name}","releases_url":"https://api.github.com/repos/huangyz0918/collect/releases{/id}","deployments_url":"https://api.github.com/repos/huangyz0918/collect/deployments","created_at":"2018-03-23T04:23:22Z","updated_at":"2018-03-28T10:45:32Z","pushed_at":"2018-03-28T10:45:28Z","git_url":"git://github.com/huangyz0918/collect.git","ssh_url":"git@github.com:huangyz0918/collect.git","clone_url":"https://github.com/huangyz0918/collect.git","svn_url":"https://github.com/huangyz0918/collect","homepage":"https://docs.opendatakit.org/collect-intro","size":37437,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opendatakit:master","ref":"master","sha":"aac35767c39b2e08b83c9715a2ea6801c3695be8","user":{"login":"opendatakit","id":6222985,"avatar_url":"https://avatars0.githubusercontent.com/u/6222985?v=4","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"repo":{"id":40213809,"name":"collect","full_name":"opendatakit/collect","owner":{"login":"opendatakit","id":6222985,"avatar_url":"https://avatars0.githubusercontent.com/u/6222985?v=4","gravatar_id":"","url":"https://api.github.com/users/opendatakit","html_url":"https://github.com/opendatakit","followers_url":"https://api.github.com/users/opendatakit/followers","following_url":"https://api.github.com/users/opendatakit/following{/other_user}","gists_url":"https://api.github.com/users/opendatakit/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatakit/subscriptions","organizations_url":"https://api.github.com/users/opendatakit/orgs","repos_url":"https://api.github.com/users/opendatakit/repos","events_url":"https://api.github.com/users/opendatakit/events{/privacy}","received_events_url":"https://api.github.com/users/opendatakit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opendatakit/collect","description":"ODK Collect is an Android app for filling out forms. It's been used to collect billions of data points in challenging environments around the world. Contribute and make the world a better place! ✨📋✨","fork":false,"url":"https://api.github.com/repos/opendatakit/collect","forks_url":"https://api.github.com/repos/opendatakit/collect/forks","keys_url":"https://api.github.com/repos/opendatakit/collect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opendatakit/collect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opendatakit/collect/teams","hooks_url":"https://api.github.com/repos/opendatakit/collect/hooks","issue_events_url":"https://api.github.com/repos/opendatakit/collect/issues/events{/number}","events_url":"https://api.github.com/repos/opendatakit/collect/events","assignees_url":"https://api.github.com/repos/opendatakit/collect/assignees{/user}","branches_url":"https://api.github.com/repos/opendatakit/collect/branches{/branch}","tags_url":"https://api.github.com/repos/opendatakit/collect/tags","blobs_url":"https://api.github.com/repos/opendatakit/collect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opendatakit/collect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opendatakit/collect/git/refs{/sha}","trees_url":"https://api.github.com/repos/opendatakit/collect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opendatakit/collect/statuses/{sha}","languages_url":"https://api.github.com/repos/opendatakit/collect/languages","stargazers_url":"https://api.github.com/repos/opendatakit/collect/stargazers","contributors_url":"https://api.github.com/repos/opendatakit/collect/contributors","subscribers_url":"https://api.github.com/repos/opendatakit/collect/subscribers","subscription_url":"https://api.github.com/repos/opendatakit/collect/subscription","commits_url":"https://api.github.com/repos/opendatakit/collect/commits{/sha}","git_commits_url":"https://api.github.com/repos/opendatakit/collect/git/commits{/sha}","comments_url":"https://api.github.com/repos/opendatakit/collect/comments{/number}","issue_comment_url":"https://api.github.com/repos/opendatakit/collect/issues/comments{/number}","contents_url":"https://api.github.com/repos/opendatakit/collect/contents/{+path}","compare_url":"https://api.github.com/repos/opendatakit/collect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opendatakit/collect/merges","archive_url":"https://api.github.com/repos/opendatakit/collect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opendatakit/collect/downloads","issues_url":"https://api.github.com/repos/opendatakit/collect/issues{/number}","pulls_url":"https://api.github.com/repos/opendatakit/collect/pulls{/number}","milestones_url":"https://api.github.com/repos/opendatakit/collect/milestones{/number}","notifications_url":"https://api.github.com/repos/opendatakit/collect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opendatakit/collect/labels{/name}","releases_url":"https://api.github.com/repos/opendatakit/collect/releases{/id}","deployments_url":"https://api.github.com/repos/opendatakit/collect/deployments","created_at":"2015-08-04T23:21:33Z","updated_at":"2018-03-28T16:31:07Z","pushed_at":"2018-03-28T16:44:33Z","git_url":"git://github.com/opendatakit/collect.git","ssh_url":"git@github.com:opendatakit/collect.git","clone_url":"https://github.com/opendatakit/collect.git","svn_url":"https://github.com/opendatakit/collect","homepage":"https://docs.opendatakit.org/collect-intro","size":37421,"stargazers_count":215,"watchers_count":215,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":590,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":590,"open_issues":218,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/2050"},"html":{"href":"https://github.com/opendatakit/collect/pull/2050"},"issue":{"href":"https://api.github.com/repos/opendatakit/collect/issues/2050"},"comments":{"href":"https://api.github.com/repos/opendatakit/collect/issues/2050/comments"},"review_comments":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/2050/comments"},"review_comment":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opendatakit/collect/pulls/2050/commits"},"statuses":{"href":"https://api.github.com/repos/opendatakit/collect/statuses/9647329edb8e4b02ab83ccc70da71b14ec67dc98"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lognaturel","id":967540,"avatar_url":"https://avatars3.githubusercontent.com/u/967540?v=4","gravatar_id":"","url":"https://api.github.com/users/lognaturel","html_url":"https://github.com/lognaturel","followers_url":"https://api.github.com/users/lognaturel/followers","following_url":"https://api.github.com/users/lognaturel/following{/other_user}","gists_url":"https://api.github.com/users/lognaturel/gists{/gist_id}","starred_url":"https://api.github.com/users/lognaturel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lognaturel/subscriptions","organizations_url":"https://api.github.com/users/lognaturel/orgs","repos_url":"https://api.github.com/users/lognaturel/repos","events_url":"https://api.github.com/users/lognaturel/events{/privacy}","received_events_url":"https://api.github.com/users/lognaturel/received_events","type":"User","site_admin":false},"comments":15,"review_comments":3,"maintainer_can_modify":false,"commits":15,"additions":79,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"lognaturel"}}