{"action":"created","comment":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/comments/203200499","pull_request_review_id":138043944,"id":203200499,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzIwMDQ5OQ==","diff_hunk":"@@ -446,10 +449,39 @@ protected StringBundler doProcessTemplate(\n \t\t\tfor (PortletRenderer portletRenderer : portletRenderers) {\n \t\t\t\tPortlet portlet = portletRenderer.getPortlet();\n \n+\t\t\t\tif (!portlet.isReady()) {\n+\t\t\t\t\tcontinue;\n+\t\t\t\t}\n+\n+\t\t\t\tInvokerPortlet invokerPortlet = null;\n+\n+\t\t\t\ttry {\n+\t\t\t\t\tinvokerPortlet = PortletInstanceFactoryUtil.create(\n+\t\t\t\t\t\tportlet, request.getServletContext());\n+\t\t\t\t}\n+\t\t\t\tcatch (PortletException pe) {\n+\t\t\t\t\t_log.error(pe, pe);\n+\t\t\t\t}\n+\t\t\t\tcatch (RuntimeException re) {\n+\t\t\t\t\t_log.error(re, re);\n+\t\t\t\t}\n+\n+\t\t\t\tif ((invokerPortlet == null) ||\n+\t\t\t\t\t!invokerPortlet.isHeaderPortlet()) {","path":"portal-impl/src/com/liferay/portal/layoutconfiguration/util/RuntimePageImpl.java","position":60,"original_position":39,"commit_id":"af446cd63ede0557f8c018e688f1e1efccd2d5f6","original_commit_id":"af446cd63ede0557f8c018e688f1e1efccd2d5f6","user":{"login":"shuyangzhou","id":173369,"node_id":"MDQ6VXNlcjE3MzM2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/173369?v=4","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"body":"@ngriffin7a can we do the invokerPortlet.isHeaderPortlet() check without InvokerPortlet ? It should be doable by just using portlet, right? Since most portlet is not header portlet, all those InvokerPortlet is just a waste.","created_at":"2018-07-17T22:22:41Z","updated_at":"2018-07-17T22:22:41Z","html_url":"https://github.com/shuyangzhou/liferay-portal/pull/6461#discussion_r203200499","pull_request_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/6461","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/comments/203200499"},"html":{"href":"https://github.com/shuyangzhou/liferay-portal/pull/6461#discussion_r203200499"},"pull_request":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/6461"}}},"pull_request":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/6461","id":202018879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDE4ODc5","html_url":"https://github.com/shuyangzhou/liferay-portal/pull/6461","diff_url":"https://github.com/shuyangzhou/liferay-portal/pull/6461.diff","patch_url":"https://github.com/shuyangzhou/liferay-portal/pull/6461.patch","issue_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/6461","number":6461,"state":"open","locked":false,"title":"LPS-80949 Portlet 3.0: Only dispatch to header_portlet.jsp if a portlet implements HeaderPortlet","user":{"login":"ngriffin7a","id":989387,"node_id":"MDQ6VXNlcjk4OTM4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/989387?v=4","gravatar_id":"","url":"https://api.github.com/users/ngriffin7a","html_url":"https://github.com/ngriffin7a","followers_url":"https://api.github.com/users/ngriffin7a/followers","following_url":"https://api.github.com/users/ngriffin7a/following{/other_user}","gists_url":"https://api.github.com/users/ngriffin7a/gists{/gist_id}","starred_url":"https://api.github.com/users/ngriffin7a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngriffin7a/subscriptions","organizations_url":"https://api.github.com/users/ngriffin7a/orgs","repos_url":"https://api.github.com/users/ngriffin7a/repos","events_url":"https://api.github.com/users/ngriffin7a/events{/privacy}","received_events_url":"https://api.github.com/users/ngriffin7a/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-17T17:46:22Z","updated_at":"2018-07-17T22:22:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3293524b670ed236cc1c4f18b88928e0ccf50147","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":868566587,"node_id":"MDU6TGFiZWw4Njg1NjY1ODc=","url":"https://api.github.com/repos/shuyangzhou/liferay-portal/labels/ci:test%20-%20failure","name":"ci:test - failure","color":"fccdcc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/6461/commits","review_comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/6461/comments","review_comment_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/6461/comments","statuses_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/af446cd63ede0557f8c018e688f1e1efccd2d5f6","head":{"label":"ngriffin7a:LPS-80949-render-headers-performance","ref":"LPS-80949-render-headers-performance","sha":"af446cd63ede0557f8c018e688f1e1efccd2d5f6","user":{"login":"ngriffin7a","id":989387,"node_id":"MDQ6VXNlcjk4OTM4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/989387?v=4","gravatar_id":"","url":"https://api.github.com/users/ngriffin7a","html_url":"https://github.com/ngriffin7a","followers_url":"https://api.github.com/users/ngriffin7a/followers","following_url":"https://api.github.com/users/ngriffin7a/following{/other_user}","gists_url":"https://api.github.com/users/ngriffin7a/gists{/gist_id}","starred_url":"https://api.github.com/users/ngriffin7a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngriffin7a/subscriptions","organizations_url":"https://api.github.com/users/ngriffin7a/orgs","repos_url":"https://api.github.com/users/ngriffin7a/repos","events_url":"https://api.github.com/users/ngriffin7a/events{/privacy}","received_events_url":"https://api.github.com/users/ngriffin7a/received_events","type":"User","site_admin":false},"repo":{"id":49888397,"node_id":"MDEwOlJlcG9zaXRvcnk0OTg4ODM5Nw==","name":"liferay-portal","full_name":"ngriffin7a/liferay-portal","owner":{"login":"ngriffin7a","id":989387,"node_id":"MDQ6VXNlcjk4OTM4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/989387?v=4","gravatar_id":"","url":"https://api.github.com/users/ngriffin7a","html_url":"https://github.com/ngriffin7a","followers_url":"https://api.github.com/users/ngriffin7a/followers","following_url":"https://api.github.com/users/ngriffin7a/following{/other_user}","gists_url":"https://api.github.com/users/ngriffin7a/gists{/gist_id}","starred_url":"https://api.github.com/users/ngriffin7a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngriffin7a/subscriptions","organizations_url":"https://api.github.com/users/ngriffin7a/orgs","repos_url":"https://api.github.com/users/ngriffin7a/repos","events_url":"https://api.github.com/users/ngriffin7a/events{/privacy}","received_events_url":"https://api.github.com/users/ngriffin7a/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngriffin7a/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/ngriffin7a/liferay-portal","forks_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/forks","keys_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/teams","hooks_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/events","assignees_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/tags","blobs_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/subscription","commits_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/merges","archive_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/downloads","issues_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ngriffin7a/liferay-portal/deployments","created_at":"2016-01-18T16:14:32Z","updated_at":"2018-07-17T20:29:30Z","pushed_at":"2018-07-17T21:27:20Z","git_url":"git://github.com/ngriffin7a/liferay-portal.git","ssh_url":"git@github.com:ngriffin7a/liferay-portal.git","clone_url":"https://github.com/ngriffin7a/liferay-portal.git","svn_url":"https://github.com/ngriffin7a/liferay-portal","homepage":"http://liferay.com","size":12722984,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shuyangzhou:master","ref":"master","sha":"50b613be9f028bbc168834e1170e8324d89ca8c4","user":{"login":"shuyangzhou","id":173369,"node_id":"MDQ6VXNlcjE3MzM2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/173369?v=4","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"repo":{"id":1921247,"node_id":"MDEwOlJlcG9zaXRvcnkxOTIxMjQ3","name":"liferay-portal","full_name":"shuyangzhou/liferay-portal","owner":{"login":"shuyangzhou","id":173369,"node_id":"MDQ6VXNlcjE3MzM2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/173369?v=4","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shuyangzhou/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/shuyangzhou/liferay-portal","forks_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/forks","keys_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/teams","hooks_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/events","assignees_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/tags","blobs_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/subscription","commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/merges","archive_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/downloads","issues_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/deployments","created_at":"2011-06-20T00:16:27Z","updated_at":"2018-07-17T21:41:39Z","pushed_at":"2018-07-17T22:13:38Z","git_url":"git://github.com/shuyangzhou/liferay-portal.git","ssh_url":"git@github.com:shuyangzhou/liferay-portal.git","clone_url":"https://github.com/shuyangzhou/liferay-portal.git","svn_url":"https://github.com/shuyangzhou/liferay-portal","homepage":"http://liferay.com","size":12696414,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/6461"},"html":{"href":"https://github.com/shuyangzhou/liferay-portal/pull/6461"},"issue":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/6461"},"comments":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/6461/comments"},"review_comments":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/6461/comments"},"review_comment":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/6461/commits"},"statuses":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/af446cd63ede0557f8c018e688f1e1efccd2d5f6"}},"author_association":"NONE"}}
{"actor":{"display_login":"shuyangzhou"}}