{"action":"created","issue":{"url":"https://api.github.com/repos/NLog/NLog/issues/2899","repository_url":"https://api.github.com/repos/NLog/NLog","labels_url":"https://api.github.com/repos/NLog/NLog/issues/2899/labels{/name}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/2899/comments","events_url":"https://api.github.com/repos/NLog/NLog/issues/2899/events","html_url":"https://github.com/NLog/NLog/pull/2899","id":356997881,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTIwMzI0","number":2899,"title":"support database parameter DbType and value conversion v2","user":{"login":"304NotModified","id":5808377,"node_id":"MDQ6VXNlcjU4MDgzNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5808377?v=4","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"labels":[{"id":191519538,"node_id":"MDU6TGFiZWwxOTE1MTk1Mzg=","url":"https://api.github.com/repos/NLog/NLog/labels/work%20in%20progress","name":"work in progress","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NLog/NLog/milestones/44","html_url":"https://github.com/NLog/NLog/milestone/44","labels_url":"https://api.github.com/repos/NLog/NLog/milestones/44/labels","id":2533607,"node_id":"MDk6TWlsZXN0b25lMjUzMzYwNw==","number":44,"title":"4.6","description":"","creator":{"login":"304NotModified","id":5808377,"node_id":"MDQ6VXNlcjU4MDgzNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5808377?v=4","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":41,"state":"open","created_at":"2017-05-21T12:35:33Z","updated_at":"2018-09-23T20:34:33Z","due_on":"2018-09-28T07:00:00Z","closed_at":null},"comments":8,"created_at":"2018-09-04T22:24:24Z","updated_at":"2018-09-24T20:47:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/2899","html_url":"https://github.com/NLog/NLog/pull/2899","diff_url":"https://github.com/NLog/NLog/pull/2899.diff","patch_url":"https://github.com/NLog/NLog/pull/2899.patch"},"body":"todo:\r\n\r\n- [x] fix state in DatabaseParameterTypeSetter -> no problem, parameters are also shared\r\n- [x] DatabaseParameterTypeSetter internal?\r\n- [x] need conversion for rawValue? -> not for now. Injection point is there\r\n- [x] static converter injection\r\n- [x] fix headers\r\n- [x] fix tests for new dummy \"createParameter\"\r\n- [x] naming IDatabaseValueConverter\r\n- [x] naming ParameterValueConverter\r\n- [x] docs IDatabaseValueConverter, naming methodes, parameters check\r\n- [x] IDatabaseValueConverter pass DatabaseParameterInfo?\r\n- [ ] unit tests for DatabaseValueConverter\r\n- [ ] unit tests for DatabaseTarget.GetParameterValue (fallbacks)\r\n- [ ] skip rawValue if the param-dbType is a string/not set. "},"comment":{"url":"https://api.github.com/repos/NLog/NLog/issues/comments/424119336","html_url":"https://github.com/NLog/NLog/pull/2899#issuecomment-424119336","issue_url":"https://api.github.com/repos/NLog/NLog/issues/2899","id":424119336,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDExOTMzNg==","user":{"login":"snakefoot","id":11509660,"node_id":"MDQ6VXNlcjExNTA5NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/11509660?v=4","gravatar_id":"","url":"https://api.github.com/users/snakefoot","html_url":"https://github.com/snakefoot","followers_url":"https://api.github.com/users/snakefoot/followers","following_url":"https://api.github.com/users/snakefoot/following{/other_user}","gists_url":"https://api.github.com/users/snakefoot/gists{/gist_id}","starred_url":"https://api.github.com/users/snakefoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snakefoot/subscriptions","organizations_url":"https://api.github.com/users/snakefoot/orgs","repos_url":"https://api.github.com/users/snakefoot/repos","events_url":"https://api.github.com/users/snakefoot/events{/privacy}","received_events_url":"https://api.github.com/users/snakefoot/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T20:47:37Z","updated_at":"2018-09-24T20:47:37Z","author_association":"CONTRIBUTOR","body":"> then you need your own DatabaseValueConverter (for now).\r\n\r\nStrange limitation, when it is obvious that the RawValue should be ignored when Format has been specified. Alternative one must register a custom layoutrenderer that does exactly the same, but without implementing the IRawValue-interface"}}
{"actor":{"display_login":"snakefoot"}}