{"action":"created","comment":{"url":"https://api.github.com/repos/callstack/react-native-paper/pulls/comments/182403666","pull_request_review_id":113190483,"id":182403666,"diff_hunk":"@@ -0,0 +1,224 @@\n+/* @flow */\n+\n+import * as React from 'react';\n+import colorModule from 'color';\n+import { View, Animated, StyleSheet } from 'react-native';\n+import Text from './Typography/Text';\n+import withTheme from '../core/withTheme';\n+import { black, white } from '../styles/colors';\n+import type { Theme } from '../types';\n+\n+const helperTextHeight = 16;\n+\n+type Props = {\n+  /**\n+   * @optional\n+   * Helper text to display.\n+   */\n+  helperText?: string,\n+  /**\n+   * @optional\n+   * Whether to style the TextInput with error style.\n+   */\n+  hasError?: boolean,","path":"src/components/HelperText.js","position":23,"original_position":23,"commit_id":"51221ccf9feb6245e483882dde8538580976afe7","original_commit_id":"c331035b8d60f5ab947e282ddfa177d5a826b3e3","user":{"login":"kpsroka","id":24893014,"avatar_url":"https://avatars0.githubusercontent.com/u/24893014?v=4","gravatar_id":"","url":"https://api.github.com/users/kpsroka","html_url":"https://github.com/kpsroka","followers_url":"https://api.github.com/users/kpsroka/followers","following_url":"https://api.github.com/users/kpsroka/following{/other_user}","gists_url":"https://api.github.com/users/kpsroka/gists{/gist_id}","starred_url":"https://api.github.com/users/kpsroka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpsroka/subscriptions","organizations_url":"https://api.github.com/users/kpsroka/orgs","repos_url":"https://api.github.com/users/kpsroka/repos","events_url":"https://api.github.com/users/kpsroka/events{/privacy}","received_events_url":"https://api.github.com/users/kpsroka/received_events","type":"User","site_admin":false},"body":"What effect would the `type` prop have? Maybe it's better to have `style` instead?","created_at":"2018-04-18T12:13:34Z","updated_at":"2018-04-18T12:13:34Z","html_url":"https://github.com/callstack/react-native-paper/pull/243#discussion_r182403666","pull_request_url":"https://api.github.com/repos/callstack/react-native-paper/pulls/243","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/callstack/react-native-paper/pulls/comments/182403666"},"html":{"href":"https://github.com/callstack/react-native-paper/pull/243#discussion_r182403666"},"pull_request":{"href":"https://api.github.com/repos/callstack/react-native-paper/pulls/243"}},"in_reply_to_id":181598829},"pull_request":{"url":"https://api.github.com/repos/callstack/react-native-paper/pulls/243","id":169655468,"html_url":"https://github.com/callstack/react-native-paper/pull/243","diff_url":"https://github.com/callstack/react-native-paper/pull/243.diff","patch_url":"https://github.com/callstack/react-native-paper/pull/243.patch","issue_url":"https://api.github.com/repos/callstack/react-native-paper/issues/243","number":243,"state":"open","locked":false,"title":"feat: implement helper and error text support in TextInput","user":{"login":"kpsroka","id":24893014,"avatar_url":"https://avatars0.githubusercontent.com/u/24893014?v=4","gravatar_id":"","url":"https://api.github.com/users/kpsroka","html_url":"https://github.com/kpsroka","followers_url":"https://api.github.com/users/kpsroka/followers","following_url":"https://api.github.com/users/kpsroka/following{/other_user}","gists_url":"https://api.github.com/users/kpsroka/gists{/gist_id}","starred_url":"https://api.github.com/users/kpsroka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpsroka/subscriptions","organizations_url":"https://api.github.com/users/kpsroka/orgs","repos_url":"https://api.github.com/users/kpsroka/repos","events_url":"https://api.github.com/users/kpsroka/events{/privacy}","received_events_url":"https://api.github.com/users/kpsroka/received_events","type":"User","site_admin":false},"body":"Please take a look at the example app for a demo of how it looks like/works. For now, I didn't want to refactor this into a separate element -- we should do that once we know what it should look like in other components. One not implemented feature is to have an icon in the error text. The [material docs](https://material.io/guidelines/components/text-fields.html#) use error-outline, but we might consider allowing any (or any material?) icon source.\r\n\r\n(Resolves #175)","created_at":"2018-02-16T15:41:23Z","updated_at":"2018-04-18T12:13:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d10887794b92c3d36609763b19e8254ac2d7216e","assignee":{"login":"satya164","id":1174278,"avatar_url":"https://avatars2.githubusercontent.com/u/1174278?v=4","gravatar_id":"","url":"https://api.github.com/users/satya164","html_url":"https://github.com/satya164","followers_url":"https://api.github.com/users/satya164/followers","following_url":"https://api.github.com/users/satya164/following{/other_user}","gists_url":"https://api.github.com/users/satya164/gists{/gist_id}","starred_url":"https://api.github.com/users/satya164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satya164/subscriptions","organizations_url":"https://api.github.com/users/satya164/orgs","repos_url":"https://api.github.com/users/satya164/repos","events_url":"https://api.github.com/users/satya164/events{/privacy}","received_events_url":"https://api.github.com/users/satya164/received_events","type":"User","site_admin":false},"assignees":[{"login":"satya164","id":1174278,"avatar_url":"https://avatars2.githubusercontent.com/u/1174278?v=4","gravatar_id":"","url":"https://api.github.com/users/satya164","html_url":"https://github.com/satya164","followers_url":"https://api.github.com/users/satya164/followers","following_url":"https://api.github.com/users/satya164/following{/other_user}","gists_url":"https://api.github.com/users/satya164/gists{/gist_id}","starred_url":"https://api.github.com/users/satya164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satya164/subscriptions","organizations_url":"https://api.github.com/users/satya164/orgs","repos_url":"https://api.github.com/users/satya164/repos","events_url":"https://api.github.com/users/satya164/events{/privacy}","received_events_url":"https://api.github.com/users/satya164/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":486927490,"url":"https://api.github.com/repos/callstack/react-native-paper/labels/wip","name":"wip","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/callstack/react-native-paper/pulls/243/commits","review_comments_url":"https://api.github.com/repos/callstack/react-native-paper/pulls/243/comments","review_comment_url":"https://api.github.com/repos/callstack/react-native-paper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callstack/react-native-paper/issues/243/comments","statuses_url":"https://api.github.com/repos/callstack/react-native-paper/statuses/51221ccf9feb6245e483882dde8538580976afe7","head":{"label":"callstack:feat/helper-text","ref":"feat/helper-text","sha":"51221ccf9feb6245e483882dde8538580976afe7","user":{"login":"callstack","id":17571969,"avatar_url":"https://avatars0.githubusercontent.com/u/17571969?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"repo":{"id":71323749,"name":"react-native-paper","full_name":"callstack/react-native-paper","owner":{"login":"callstack","id":17571969,"avatar_url":"https://avatars0.githubusercontent.com/u/17571969?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callstack/react-native-paper","description":"Material Design for React Native (Android & iOS)","fork":false,"url":"https://api.github.com/repos/callstack/react-native-paper","forks_url":"https://api.github.com/repos/callstack/react-native-paper/forks","keys_url":"https://api.github.com/repos/callstack/react-native-paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callstack/react-native-paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callstack/react-native-paper/teams","hooks_url":"https://api.github.com/repos/callstack/react-native-paper/hooks","issue_events_url":"https://api.github.com/repos/callstack/react-native-paper/issues/events{/number}","events_url":"https://api.github.com/repos/callstack/react-native-paper/events","assignees_url":"https://api.github.com/repos/callstack/react-native-paper/assignees{/user}","branches_url":"https://api.github.com/repos/callstack/react-native-paper/branches{/branch}","tags_url":"https://api.github.com/repos/callstack/react-native-paper/tags","blobs_url":"https://api.github.com/repos/callstack/react-native-paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callstack/react-native-paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callstack/react-native-paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/callstack/react-native-paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callstack/react-native-paper/statuses/{sha}","languages_url":"https://api.github.com/repos/callstack/react-native-paper/languages","stargazers_url":"https://api.github.com/repos/callstack/react-native-paper/stargazers","contributors_url":"https://api.github.com/repos/callstack/react-native-paper/contributors","subscribers_url":"https://api.github.com/repos/callstack/react-native-paper/subscribers","subscription_url":"https://api.github.com/repos/callstack/react-native-paper/subscription","commits_url":"https://api.github.com/repos/callstack/react-native-paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/callstack/react-native-paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/callstack/react-native-paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/callstack/react-native-paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/callstack/react-native-paper/contents/{+path}","compare_url":"https://api.github.com/repos/callstack/react-native-paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callstack/react-native-paper/merges","archive_url":"https://api.github.com/repos/callstack/react-native-paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callstack/react-native-paper/downloads","issues_url":"https://api.github.com/repos/callstack/react-native-paper/issues{/number}","pulls_url":"https://api.github.com/repos/callstack/react-native-paper/pulls{/number}","milestones_url":"https://api.github.com/repos/callstack/react-native-paper/milestones{/number}","notifications_url":"https://api.github.com/repos/callstack/react-native-paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callstack/react-native-paper/labels{/name}","releases_url":"https://api.github.com/repos/callstack/react-native-paper/releases{/id}","deployments_url":"https://api.github.com/repos/callstack/react-native-paper/deployments","created_at":"2016-10-19T05:56:53Z","updated_at":"2018-04-18T10:46:23Z","pushed_at":"2018-04-18T09:56:41Z","git_url":"git://github.com/callstack/react-native-paper.git","ssh_url":"git@github.com:callstack/react-native-paper.git","clone_url":"https://github.com/callstack/react-native-paper.git","svn_url":"https://github.com/callstack/react-native-paper","homepage":"https://callstack.github.io/react-native-paper/","size":25784,"stargazers_count":970,"watchers_count":970,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":81,"open_issues":49,"watchers":970,"default_branch":"master"}},"base":{"label":"callstack:master","ref":"master","sha":"db26d6c9fdc2b610e79b5f09e31fa57949a65d84","user":{"login":"callstack","id":17571969,"avatar_url":"https://avatars0.githubusercontent.com/u/17571969?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"repo":{"id":71323749,"name":"react-native-paper","full_name":"callstack/react-native-paper","owner":{"login":"callstack","id":17571969,"avatar_url":"https://avatars0.githubusercontent.com/u/17571969?v=4","gravatar_id":"","url":"https://api.github.com/users/callstack","html_url":"https://github.com/callstack","followers_url":"https://api.github.com/users/callstack/followers","following_url":"https://api.github.com/users/callstack/following{/other_user}","gists_url":"https://api.github.com/users/callstack/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack/subscriptions","organizations_url":"https://api.github.com/users/callstack/orgs","repos_url":"https://api.github.com/users/callstack/repos","events_url":"https://api.github.com/users/callstack/events{/privacy}","received_events_url":"https://api.github.com/users/callstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callstack/react-native-paper","description":"Material Design for React Native (Android & iOS)","fork":false,"url":"https://api.github.com/repos/callstack/react-native-paper","forks_url":"https://api.github.com/repos/callstack/react-native-paper/forks","keys_url":"https://api.github.com/repos/callstack/react-native-paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callstack/react-native-paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callstack/react-native-paper/teams","hooks_url":"https://api.github.com/repos/callstack/react-native-paper/hooks","issue_events_url":"https://api.github.com/repos/callstack/react-native-paper/issues/events{/number}","events_url":"https://api.github.com/repos/callstack/react-native-paper/events","assignees_url":"https://api.github.com/repos/callstack/react-native-paper/assignees{/user}","branches_url":"https://api.github.com/repos/callstack/react-native-paper/branches{/branch}","tags_url":"https://api.github.com/repos/callstack/react-native-paper/tags","blobs_url":"https://api.github.com/repos/callstack/react-native-paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callstack/react-native-paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callstack/react-native-paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/callstack/react-native-paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callstack/react-native-paper/statuses/{sha}","languages_url":"https://api.github.com/repos/callstack/react-native-paper/languages","stargazers_url":"https://api.github.com/repos/callstack/react-native-paper/stargazers","contributors_url":"https://api.github.com/repos/callstack/react-native-paper/contributors","subscribers_url":"https://api.github.com/repos/callstack/react-native-paper/subscribers","subscription_url":"https://api.github.com/repos/callstack/react-native-paper/subscription","commits_url":"https://api.github.com/repos/callstack/react-native-paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/callstack/react-native-paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/callstack/react-native-paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/callstack/react-native-paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/callstack/react-native-paper/contents/{+path}","compare_url":"https://api.github.com/repos/callstack/react-native-paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callstack/react-native-paper/merges","archive_url":"https://api.github.com/repos/callstack/react-native-paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callstack/react-native-paper/downloads","issues_url":"https://api.github.com/repos/callstack/react-native-paper/issues{/number}","pulls_url":"https://api.github.com/repos/callstack/react-native-paper/pulls{/number}","milestones_url":"https://api.github.com/repos/callstack/react-native-paper/milestones{/number}","notifications_url":"https://api.github.com/repos/callstack/react-native-paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callstack/react-native-paper/labels{/name}","releases_url":"https://api.github.com/repos/callstack/react-native-paper/releases{/id}","deployments_url":"https://api.github.com/repos/callstack/react-native-paper/deployments","created_at":"2016-10-19T05:56:53Z","updated_at":"2018-04-18T10:46:23Z","pushed_at":"2018-04-18T09:56:41Z","git_url":"git://github.com/callstack/react-native-paper.git","ssh_url":"git@github.com:callstack/react-native-paper.git","clone_url":"https://github.com/callstack/react-native-paper.git","svn_url":"https://github.com/callstack/react-native-paper","homepage":"https://callstack.github.io/react-native-paper/","size":25784,"stargazers_count":970,"watchers_count":970,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":81,"open_issues":49,"watchers":970,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callstack/react-native-paper/pulls/243"},"html":{"href":"https://github.com/callstack/react-native-paper/pull/243"},"issue":{"href":"https://api.github.com/repos/callstack/react-native-paper/issues/243"},"comments":{"href":"https://api.github.com/repos/callstack/react-native-paper/issues/243/comments"},"review_comments":{"href":"https://api.github.com/repos/callstack/react-native-paper/pulls/243/comments"},"review_comment":{"href":"https://api.github.com/repos/callstack/react-native-paper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callstack/react-native-paper/pulls/243/commits"},"statuses":{"href":"https://api.github.com/repos/callstack/react-native-paper/statuses/51221ccf9feb6245e483882dde8538580976afe7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kpsroka"}}