{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/cargo/issues/5123","repository_url":"https://api.github.com/repos/rust-lang/cargo","labels_url":"https://api.github.com/repos/rust-lang/cargo/issues/5123/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/5123/comments","events_url":"https://api.github.com/repos/rust-lang/cargo/issues/5123/events","html_url":"https://github.com/rust-lang/cargo/pull/5123","id":302368698,"number":5123,"title":"Auto-disable incremental on CI builds","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"matklad","id":1711539,"avatar_url":"https://avatars3.githubusercontent.com/u/1711539?v=4","gravatar_id":"","url":"https://api.github.com/users/matklad","html_url":"https://github.com/matklad","followers_url":"https://api.github.com/users/matklad/followers","following_url":"https://api.github.com/users/matklad/following{/other_user}","gists_url":"https://api.github.com/users/matklad/gists{/gist_id}","starred_url":"https://api.github.com/users/matklad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matklad/subscriptions","organizations_url":"https://api.github.com/users/matklad/orgs","repos_url":"https://api.github.com/users/matklad/repos","events_url":"https://api.github.com/users/matklad/events{/privacy}","received_events_url":"https://api.github.com/users/matklad/received_events","type":"User","site_admin":false},"assignees":[{"login":"matklad","id":1711539,"avatar_url":"https://avatars3.githubusercontent.com/u/1711539?v=4","gravatar_id":"","url":"https://api.github.com/users/matklad","html_url":"https://github.com/matklad","followers_url":"https://api.github.com/users/matklad/followers","following_url":"https://api.github.com/users/matklad/following{/other_user}","gists_url":"https://api.github.com/users/matklad/gists{/gist_id}","starred_url":"https://api.github.com/users/matklad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matklad/subscriptions","organizations_url":"https://api.github.com/users/matklad/orgs","repos_url":"https://api.github.com/users/matklad/repos","events_url":"https://api.github.com/users/matklad/events{/privacy}","received_events_url":"https://api.github.com/users/matklad/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2018-03-05T16:30:11Z","updated_at":"2018-03-05T22:02:06Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/5123","html_url":"https://github.com/rust-lang/cargo/pull/5123","diff_url":"https://github.com/rust-lang/cargo/pull/5123.diff","patch_url":"https://github.com/rust-lang/cargo/pull/5123.patch"},"body":"Most CI systems seem to export an environment variable named `CI` to indicate\r\nsuch. Incremental compilation is also known to slow down development builds due\r\nto the extra tracking necessary. As a result the *fastest* dev build currently\r\ninvolves disabling incremental compilation (so long as you're not actually\r\nincrementall compiling). In CI it's typically pretty rare that artifacts are\r\ncached as well (or so it seems).\r\n\r\nAs a result this commit is a stab at automatically disabling incremental\r\ncompilation on CI to see if we can improve the compile time of projects in these\r\nsituations."},"comment":{"url":"https://api.github.com/repos/rust-lang/cargo/issues/comments/370582872","html_url":"https://github.com/rust-lang/cargo/pull/5123#issuecomment-370582872","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/5123","id":370582872,"user":{"login":"dotdash","id":230962,"avatar_url":"https://avatars1.githubusercontent.com/u/230962?v=4","gravatar_id":"","url":"https://api.github.com/users/dotdash","html_url":"https://github.com/dotdash","followers_url":"https://api.github.com/users/dotdash/followers","following_url":"https://api.github.com/users/dotdash/following{/other_user}","gists_url":"https://api.github.com/users/dotdash/gists{/gist_id}","starred_url":"https://api.github.com/users/dotdash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotdash/subscriptions","organizations_url":"https://api.github.com/users/dotdash/orgs","repos_url":"https://api.github.com/users/dotdash/repos","events_url":"https://api.github.com/users/dotdash/events{/privacy}","received_events_url":"https://api.github.com/users/dotdash/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T22:02:05Z","updated_at":"2018-03-05T22:02:05Z","author_association":"CONTRIBUTOR","body":"I'm in favor of disabling inc. comp. in CI environments. Having fast builds\nin CI is really useful. But as others noted, it needs to be made heavily\nvisible. As such I'd go for a message that isn't just printed at the top of\neach build, where you could easily miss it, but with the first/last or\nmaybe each error that occurs. Because those are the places I'd actually\nlook at.\n\nAm 05.03.2018 22:53 schrieb \"Alex Crichton\" <notifications@github.com>:\n\nCargo itself goes from a 65s full build to a 58s full build when disabling\nincremental, a 10% improvement.\n\n@sfackler <https://github.com/sfackler> yes CARGO_INCREMENTAL=1 will enable\nincremental (or disable it) as will build.incremental in .cargo/config\nwhich can be used to force disable incremental compilation.\n\n@matklad <https://github.com/matklad> sure yeah some projects save the\ntarget directory but in general Cargo isn't suited for that as it never\ncleans it up.\n\n@michaelwoerister <https://github.com/michaelwoerister> @nagisa\n<https://github.com/nagisa> I agree its worrisome to differ on CI, but a\nbug in incremental vs not mode is also a pretty serious compiler bug.\n\n@michaelwoerister <https://github.com/michaelwoerister> it seems reasonable\nthough yeah to print out whether it's disabled or not!\n\n—\nYou are receiving this because you are on a team that was mentioned.\nReply to this email directly, view it on GitHub\n<https://github.com/rust-lang/cargo/pull/5123#issuecomment-370580167>, or mute\nthe thread\n<https://github.com/notifications/unsubscribe-auth/AAOGMi72NN-VQFdO1RAvcoXSWg1sz54Oks5tbbPjgaJpZM4Scljg>\n.\n"}}
{"actor":{"display_login":"dotdash"}}