{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/11688","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/11688/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/11688/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/11688/events","html_url":"https://github.com/Microsoft/vscode/issues/11688","id":175750834,"node_id":"MDU6SXNzdWUxNzU3NTA4MzQ=","number":11688,"title":"Feature request: 'Ignore comments' checkbox in the 'Find' dialog","user":{"login":"thorn0","id":94334,"node_id":"MDQ6VXNlcjk0MzM0","avatar_url":"https://avatars0.githubusercontent.com/u/94334?v=4","gravatar_id":"","url":"https://api.github.com/users/thorn0","html_url":"https://github.com/thorn0","followers_url":"https://api.github.com/users/thorn0/followers","following_url":"https://api.github.com/users/thorn0/following{/other_user}","gists_url":"https://api.github.com/users/thorn0/gists{/gist_id}","starred_url":"https://api.github.com/users/thorn0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorn0/subscriptions","organizations_url":"https://api.github.com/users/thorn0/orgs","repos_url":"https://api.github.com/users/thorn0/repos","events_url":"https://api.github.com/users/thorn0/events{/privacy}","received_events_url":"https://api.github.com/users/thorn0/received_events","type":"User","site_admin":false},"labels":[{"id":398766855,"node_id":"MDU6TGFiZWwzOTg3NjY4NTU=","url":"https://api.github.com/repos/Microsoft/vscode/labels/editor-find","name":"editor-find","color":"c5def5","default":false},{"id":272689392,"node_id":"MDU6TGFiZWwyNzI2ODkzOTI=","url":"https://api.github.com/repos/Microsoft/vscode/labels/feature-request","name":"feature-request","color":"dcdcdc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/8","html_url":"https://github.com/Microsoft/vscode/milestone/8","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/8/labels","id":1412124,"node_id":"MDk6TWlsZXN0b25lMTQxMjEyNA==","number":8,"title":"Backlog","description":"Work not yet planned for a specific release.","creator":{"login":"chrisdias","id":1487073,"node_id":"MDQ6VXNlcjE0ODcwNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1487073?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdias","html_url":"https://github.com/chrisdias","followers_url":"https://api.github.com/users/chrisdias/followers","following_url":"https://api.github.com/users/chrisdias/following{/other_user}","gists_url":"https://api.github.com/users/chrisdias/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdias/subscriptions","organizations_url":"https://api.github.com/users/chrisdias/orgs","repos_url":"https://api.github.com/users/chrisdias/repos","events_url":"https://api.github.com/users/chrisdias/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdias/received_events","type":"User","site_admin":false},"open_issues":1950,"closed_issues":4083,"state":"open","created_at":"2015-11-15T10:30:19Z","updated_at":"2018-09-17T22:34:29Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2016-09-08T13:16:16Z","updated_at":"2018-09-17T23:00:39Z","closed_at":null,"author_association":"NONE","body":"Wide popularity of the embedded documentation conventions like JSDoc and C#'s XML comments leads to a situation where comments often constitute the bigger part of a source file (e.g. look at the source of [angular.js](https://unpkg.com/angular/angular.js): the whole API documentation is there!). This abundance of comments makes it extremely difficult to find anything in the source code proper. For example, reading someone's code, we might want to know how and where a certain function is used. However, if we decide to conduct a search by its name, we might get lost in dozens of code samples in the comments and overlook some important case of its real usage. Shift-F12 often helps in such situations, but not always. This undermines the habitual workflow of those who are used to rely a lot on the search to read the code. Not sure if any other editor has this feature, but it would be great to have the 'Ignore comments' option in VS Code's search dialog.\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/422199032","html_url":"https://github.com/Microsoft/vscode/issues/11688#issuecomment-422199032","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/11688","id":422199032,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjE5OTAzMg==","user":{"login":"rebornix","id":876920,"node_id":"MDQ6VXNlcjg3NjkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/876920?v=4","gravatar_id":"","url":"https://api.github.com/users/rebornix","html_url":"https://github.com/rebornix","followers_url":"https://api.github.com/users/rebornix/followers","following_url":"https://api.github.com/users/rebornix/following{/other_user}","gists_url":"https://api.github.com/users/rebornix/gists{/gist_id}","starred_url":"https://api.github.com/users/rebornix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebornix/subscriptions","organizations_url":"https://api.github.com/users/rebornix/orgs","repos_url":"https://api.github.com/users/rebornix/repos","events_url":"https://api.github.com/users/rebornix/events{/privacy}","received_events_url":"https://api.github.com/users/rebornix/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T23:00:39Z","updated_at":"2018-09-17T23:00:39Z","author_association":"MEMBER","body":"As I mentioned above, this is an interesting feature which takes syntax into account for both find widget and search viewlet. WebStorm puts this feature in a filter dropdown list\r\n\r\n![image](https://user-images.githubusercontent.com/876920/45654844-5347b500-ba92-11e8-9ec8-28f0f3240890.png)\r\n\r\nWe don't necessarily need to make it an UI element but a setting where users can control whether to filter out string or comments while searching. The challenge here is we are making search/find language agnostic. Currently we rely on TextMate to do the tokenization, whose most grammars are complex and beautiful but not fast enough for simple searches. When we consider sementic highlighting, we can probably think about this feature as well. The language service provides ranges for comments and strings real quick and then we can quickly filter them out.\r\n\r\nThe same technique can be used for spell checker as well, but again, relies on a fast tokenizer.\r\n"}}
{"actor":{"display_login":"rebornix"}}