{"action":"created","issue":{"url":"https://api.github.com/repos/Islandora/islandora_solr_views/issues/54","repository_url":"https://api.github.com/repos/Islandora/islandora_solr_views","labels_url":"https://api.github.com/repos/Islandora/islandora_solr_views/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/Islandora/islandora_solr_views/issues/54/comments","events_url":"https://api.github.com/repos/Islandora/islandora_solr_views/issues/54/events","html_url":"https://github.com/Islandora/islandora_solr_views/pull/54","id":346228066,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTQzNzQ0","number":54,"title":"ISLANDORA-2141 Don't double-encode link to object.","user":{"login":"rosiel","id":1943338,"node_id":"MDQ6VXNlcjE5NDMzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1943338?v=4","gravatar_id":"","url":"https://api.github.com/users/rosiel","html_url":"https://github.com/rosiel","followers_url":"https://api.github.com/users/rosiel/followers","following_url":"https://api.github.com/users/rosiel/following{/other_user}","gists_url":"https://api.github.com/users/rosiel/gists{/gist_id}","starred_url":"https://api.github.com/users/rosiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosiel/subscriptions","organizations_url":"https://api.github.com/users/rosiel/orgs","repos_url":"https://api.github.com/users/rosiel/repos","events_url":"https://api.github.com/users/rosiel/events{/privacy}","received_events_url":"https://api.github.com/users/rosiel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-07-31T15:01:21Z","updated_at":"2018-08-28T12:04:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Islandora/islandora_solr_views/pulls/54","html_url":"https://github.com/Islandora/islandora_solr_views/pull/54","diff_url":"https://github.com/Islandora/islandora_solr_views/pull/54.diff","patch_url":"https://github.com/Islandora/islandora_solr_views/pull/54.patch"},"body":"**JIRA Ticket**: https://jira.duraspace.org/browse/ISLANDORA-2141\r\nActually re-fixes the problem from https://jira.duraspace.org/browse/ISLANDORA-1994\r\n\r\n# What does this Pull Request do?\r\n\r\nChanges how we solve the problem of parse_url failing on pids above namespace:65535, because the previous fix (urlencode()) caused unintended consequences. The final link was double-encoded (namespace%253A65536) and while Drupal still rendered the right object, other stuff broke:\r\n- Usage Stats views (that appear on the collection management page) no longer showed up\r\n- contextual views (which rely on the PID from the URL) no longer worked. \r\n\r\n# What's new?\r\n\r\nDon't double-encode; add a meaningless fragment to the url instead. (this tricks parse_url, which is the thing that's really at fault...) \r\n\r\n# How should this be tested?\r\n\r\nCreate an object with a PID of namespace:65536 or greater. (this is easily done by creating a collection; the collection form lets you assign a PID)\r\nCreate a view, with a field that \"links to object\" and shows this object.\r\n\r\nBefore the PR: the link renders, and includes %253A in place of colon (:) \r\nAfter the PR: the link renders, and includes #view at the end.\r\n\r\nTo test with Usage Stats\r\n- enable usage stats and make sure you have an object with some stats available.\r\n- get to that object from a \"link to object\" field in a solr view\r\nBefore this PR: the collection usage stats table doesn't show up\r\nAfter this PR: the collection usage stats table shows up.\r\n\r\n\r\n# Additional Notes:\r\n\r\n* Does this change require documentation to be updated? **Nope**\r\n* Does this change add any new dependencies? **Nope**\r\n* Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)?  **Nope**\r\n* Could this change impact execution of existing code? **Maybe!? Hopefully less than the previous solution?**\r\n\r\n# Interested parties\r\n@Islandora/7-x-1-x-committers and @bondjimbond \r\n"},"comment":{"url":"https://api.github.com/repos/Islandora/islandora_solr_views/issues/comments/416559071","html_url":"https://github.com/Islandora/islandora_solr_views/pull/54#issuecomment-416559071","issue_url":"https://api.github.com/repos/Islandora/islandora_solr_views/issues/54","id":416559071,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjU1OTA3MQ==","user":{"login":"MorganDawe","id":3580299,"node_id":"MDQ6VXNlcjM1ODAyOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/3580299?v=4","gravatar_id":"","url":"https://api.github.com/users/MorganDawe","html_url":"https://github.com/MorganDawe","followers_url":"https://api.github.com/users/MorganDawe/followers","following_url":"https://api.github.com/users/MorganDawe/following{/other_user}","gists_url":"https://api.github.com/users/MorganDawe/gists{/gist_id}","starred_url":"https://api.github.com/users/MorganDawe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorganDawe/subscriptions","organizations_url":"https://api.github.com/users/MorganDawe/orgs","repos_url":"https://api.github.com/users/MorganDawe/repos","events_url":"https://api.github.com/users/MorganDawe/events{/privacy}","received_events_url":"https://api.github.com/users/MorganDawe/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T12:04:26Z","updated_at":"2018-08-28T12:04:26Z","author_association":"NONE","body":" @DiegoPino my most sincere apologies for not responding sooner. This looks like it will absolutely address client support requirements, avoiding treating pids as port numbers. Thank you @rosiel , @bondjimbond and @DiegoPino for your work resolving this issue."}}
{"actor":{"display_login":"MorganDawe"}}