{"action":"created","comment":{"url":"https://api.github.com/repos/google/openhtf/pulls/comments/195807739","pull_request_review_id":129250533,"id":195807739,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTgwNzczOQ==","diff_hunk":"@@ -137,15 +137,19 @@ def __init__(self, test_desc, execution_uid, test_options):\n         start_time_millis=0,\n         # Copy metadata so we don't modify test_desc.\n         metadata=copy.deepcopy(test_desc.metadata))\n-    self.logger = logs.initialize_record_logger(\n+    logs.initialize_record_handler(\n         execution_uid, self.test_record, self.notify_update)\n+    self.logger = logs.get_record_logger_for(execution_uid)\n     self.plug_manager = plugs.PlugManager(\n         test_desc.plug_types, self.logger.name)\n     self.running_phase_state = None\n     self.user_defined_state = {}\n     self.execution_uid = execution_uid\n     self.test_options = test_options\n \n+  def __del__(self):","path":"openhtf/core/test_state.py","position":15,"original_position":15,"commit_id":"0960e330d677062451fcacd66106612563dabad7","original_commit_id":"0960e330d677062451fcacd66106612563dabad7","user":{"login":"Kenadia","id":3301218,"node_id":"MDQ6VXNlcjMzMDEyMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3301218?v=4","gravatar_id":"","url":"https://api.github.com/users/Kenadia","html_url":"https://github.com/Kenadia","followers_url":"https://api.github.com/users/Kenadia/followers","following_url":"https://api.github.com/users/Kenadia/following{/other_user}","gists_url":"https://api.github.com/users/Kenadia/gists{/gist_id}","starred_url":"https://api.github.com/users/Kenadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kenadia/subscriptions","organizations_url":"https://api.github.com/users/Kenadia/orgs","repos_url":"https://api.github.com/users/Kenadia/repos","events_url":"https://api.github.com/users/Kenadia/events{/privacy}","received_events_url":"https://api.github.com/users/Kenadia/received_events","type":"User","site_admin":false},"body":"It seems like this is never called. This might be a memory leak issue to be investigated separately.","created_at":"2018-06-15T17:09:00Z","updated_at":"2018-06-15T17:09:00Z","html_url":"https://github.com/google/openhtf/pull/799#discussion_r195807739","pull_request_url":"https://api.github.com/repos/google/openhtf/pulls/799","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/openhtf/pulls/comments/195807739"},"html":{"href":"https://github.com/google/openhtf/pull/799#discussion_r195807739"},"pull_request":{"href":"https://api.github.com/repos/google/openhtf/pulls/799"}}},"pull_request":{"url":"https://api.github.com/repos/google/openhtf/pulls/799","id":195234654,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjM0NjU0","html_url":"https://github.com/google/openhtf/pull/799","diff_url":"https://github.com/google/openhtf/pull/799.diff","patch_url":"https://github.com/google/openhtf/pull/799.patch","issue_url":"https://api.github.com/repos/google/openhtf/issues/799","number":799,"state":"open","locked":false,"title":"Refactor logs.py","user":{"login":"Kenadia","id":3301218,"node_id":"MDQ6VXNlcjMzMDEyMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3301218?v=4","gravatar_id":"","url":"https://api.github.com/users/Kenadia","html_url":"https://github.com/Kenadia","followers_url":"https://api.github.com/users/Kenadia/followers","following_url":"https://api.github.com/users/Kenadia/following{/other_user}","gists_url":"https://api.github.com/users/Kenadia/gists{/gist_id}","starred_url":"https://api.github.com/users/Kenadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kenadia/subscriptions","organizations_url":"https://api.github.com/users/Kenadia/orgs","repos_url":"https://api.github.com/users/Kenadia/repos","events_url":"https://api.github.com/users/Kenadia/events{/privacy}","received_events_url":"https://api.github.com/users/Kenadia/received_events","type":"User","site_admin":false},"body":"Summary:\r\n- Address #787\r\n- Rewrite obsolete docstrings.\r\n- Use `logger.getChild()` when possible to access child loggers.\r\n- Don't call `setLevel()` unnecessarily. Loggers and handlers default to the `NOTSET` level. Only “top-level” loggers with `propagate=False` need to have their level set.\r\n- Other minor cleanup. See comments inline.\r\n\r\n--\r\n\r\n<sub>Note: Originally I was trying to address #788, and did so by defining a second `openthf.output.servers` tree separate from the main `openhtf` logging tree, so that server logs including multicast logs could avoid being sent to the test record. @jettisonjoe pointed out that the server logs are generally more helpful than annoying, as long as they're kept at the debug level. So we need another way of addressing #788—probably by removing that log line entirely. FWIW here's what my original diff looked like: https://github.com/google/openhtf/compare/master...Kenadia:server-logs?expand=1</sub>\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/google/openhtf/799)\n<!-- Reviewable:end -->\n","created_at":"2018-06-15T17:08:05Z","updated_at":"2018-06-15T17:09:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4a63331b4eb56ce66364395d369e537edc31276","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jettisonjoe","id":8150422,"node_id":"MDQ6VXNlcjgxNTA0MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/8150422?v=4","gravatar_id":"","url":"https://api.github.com/users/jettisonjoe","html_url":"https://github.com/jettisonjoe","followers_url":"https://api.github.com/users/jettisonjoe/followers","following_url":"https://api.github.com/users/jettisonjoe/following{/other_user}","gists_url":"https://api.github.com/users/jettisonjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/jettisonjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jettisonjoe/subscriptions","organizations_url":"https://api.github.com/users/jettisonjoe/orgs","repos_url":"https://api.github.com/users/jettisonjoe/repos","events_url":"https://api.github.com/users/jettisonjoe/events{/privacy}","received_events_url":"https://api.github.com/users/jettisonjoe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/openhtf/pulls/799/commits","review_comments_url":"https://api.github.com/repos/google/openhtf/pulls/799/comments","review_comment_url":"https://api.github.com/repos/google/openhtf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/openhtf/issues/799/comments","statuses_url":"https://api.github.com/repos/google/openhtf/statuses/0960e330d677062451fcacd66106612563dabad7","head":{"label":"Kenadia:refactor-logs","ref":"refactor-logs","sha":"0960e330d677062451fcacd66106612563dabad7","user":{"login":"Kenadia","id":3301218,"node_id":"MDQ6VXNlcjMzMDEyMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3301218?v=4","gravatar_id":"","url":"https://api.github.com/users/Kenadia","html_url":"https://github.com/Kenadia","followers_url":"https://api.github.com/users/Kenadia/followers","following_url":"https://api.github.com/users/Kenadia/following{/other_user}","gists_url":"https://api.github.com/users/Kenadia/gists{/gist_id}","starred_url":"https://api.github.com/users/Kenadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kenadia/subscriptions","organizations_url":"https://api.github.com/users/Kenadia/orgs","repos_url":"https://api.github.com/users/Kenadia/repos","events_url":"https://api.github.com/users/Kenadia/events{/privacy}","received_events_url":"https://api.github.com/users/Kenadia/received_events","type":"User","site_admin":false},"repo":{"id":71505716,"node_id":"MDEwOlJlcG9zaXRvcnk3MTUwNTcxNg==","name":"openhtf","full_name":"Kenadia/openhtf","owner":{"login":"Kenadia","id":3301218,"node_id":"MDQ6VXNlcjMzMDEyMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3301218?v=4","gravatar_id":"","url":"https://api.github.com/users/Kenadia","html_url":"https://github.com/Kenadia","followers_url":"https://api.github.com/users/Kenadia/followers","following_url":"https://api.github.com/users/Kenadia/following{/other_user}","gists_url":"https://api.github.com/users/Kenadia/gists{/gist_id}","starred_url":"https://api.github.com/users/Kenadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kenadia/subscriptions","organizations_url":"https://api.github.com/users/Kenadia/orgs","repos_url":"https://api.github.com/users/Kenadia/repos","events_url":"https://api.github.com/users/Kenadia/events{/privacy}","received_events_url":"https://api.github.com/users/Kenadia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kenadia/openhtf","description":null,"fork":true,"url":"https://api.github.com/repos/Kenadia/openhtf","forks_url":"https://api.github.com/repos/Kenadia/openhtf/forks","keys_url":"https://api.github.com/repos/Kenadia/openhtf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kenadia/openhtf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kenadia/openhtf/teams","hooks_url":"https://api.github.com/repos/Kenadia/openhtf/hooks","issue_events_url":"https://api.github.com/repos/Kenadia/openhtf/issues/events{/number}","events_url":"https://api.github.com/repos/Kenadia/openhtf/events","assignees_url":"https://api.github.com/repos/Kenadia/openhtf/assignees{/user}","branches_url":"https://api.github.com/repos/Kenadia/openhtf/branches{/branch}","tags_url":"https://api.github.com/repos/Kenadia/openhtf/tags","blobs_url":"https://api.github.com/repos/Kenadia/openhtf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kenadia/openhtf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kenadia/openhtf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kenadia/openhtf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kenadia/openhtf/statuses/{sha}","languages_url":"https://api.github.com/repos/Kenadia/openhtf/languages","stargazers_url":"https://api.github.com/repos/Kenadia/openhtf/stargazers","contributors_url":"https://api.github.com/repos/Kenadia/openhtf/contributors","subscribers_url":"https://api.github.com/repos/Kenadia/openhtf/subscribers","subscription_url":"https://api.github.com/repos/Kenadia/openhtf/subscription","commits_url":"https://api.github.com/repos/Kenadia/openhtf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kenadia/openhtf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kenadia/openhtf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kenadia/openhtf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kenadia/openhtf/contents/{+path}","compare_url":"https://api.github.com/repos/Kenadia/openhtf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kenadia/openhtf/merges","archive_url":"https://api.github.com/repos/Kenadia/openhtf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kenadia/openhtf/downloads","issues_url":"https://api.github.com/repos/Kenadia/openhtf/issues{/number}","pulls_url":"https://api.github.com/repos/Kenadia/openhtf/pulls{/number}","milestones_url":"https://api.github.com/repos/Kenadia/openhtf/milestones{/number}","notifications_url":"https://api.github.com/repos/Kenadia/openhtf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kenadia/openhtf/labels{/name}","releases_url":"https://api.github.com/repos/Kenadia/openhtf/releases{/id}","deployments_url":"https://api.github.com/repos/Kenadia/openhtf/deployments","created_at":"2016-10-20T21:26:08Z","updated_at":"2018-06-14T17:37:43Z","pushed_at":"2018-06-15T16:58:35Z","git_url":"git://github.com/Kenadia/openhtf.git","ssh_url":"git@github.com:Kenadia/openhtf.git","clone_url":"https://github.com/Kenadia/openhtf.git","svn_url":"https://github.com/Kenadia/openhtf","homepage":null,"size":30654,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"c7af4ef74c610e33637819337585cd89bc8b1f2a","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":41519483,"node_id":"MDEwOlJlcG9zaXRvcnk0MTUxOTQ4Mw==","name":"openhtf","full_name":"google/openhtf","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/openhtf","description":"The open-source hardware testing framework.","fork":false,"url":"https://api.github.com/repos/google/openhtf","forks_url":"https://api.github.com/repos/google/openhtf/forks","keys_url":"https://api.github.com/repos/google/openhtf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/openhtf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/openhtf/teams","hooks_url":"https://api.github.com/repos/google/openhtf/hooks","issue_events_url":"https://api.github.com/repos/google/openhtf/issues/events{/number}","events_url":"https://api.github.com/repos/google/openhtf/events","assignees_url":"https://api.github.com/repos/google/openhtf/assignees{/user}","branches_url":"https://api.github.com/repos/google/openhtf/branches{/branch}","tags_url":"https://api.github.com/repos/google/openhtf/tags","blobs_url":"https://api.github.com/repos/google/openhtf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/openhtf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/openhtf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/openhtf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/openhtf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/openhtf/languages","stargazers_url":"https://api.github.com/repos/google/openhtf/stargazers","contributors_url":"https://api.github.com/repos/google/openhtf/contributors","subscribers_url":"https://api.github.com/repos/google/openhtf/subscribers","subscription_url":"https://api.github.com/repos/google/openhtf/subscription","commits_url":"https://api.github.com/repos/google/openhtf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/openhtf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/openhtf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/openhtf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/openhtf/contents/{+path}","compare_url":"https://api.github.com/repos/google/openhtf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/openhtf/merges","archive_url":"https://api.github.com/repos/google/openhtf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/openhtf/downloads","issues_url":"https://api.github.com/repos/google/openhtf/issues{/number}","pulls_url":"https://api.github.com/repos/google/openhtf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/openhtf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/openhtf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/openhtf/labels{/name}","releases_url":"https://api.github.com/repos/google/openhtf/releases{/id}","deployments_url":"https://api.github.com/repos/google/openhtf/deployments","created_at":"2015-08-28T01:14:17Z","updated_at":"2018-06-13T21:58:31Z","pushed_at":"2018-06-15T17:08:12Z","git_url":"git://github.com/google/openhtf.git","ssh_url":"git@github.com:google/openhtf.git","clone_url":"https://github.com/google/openhtf.git","svn_url":"https://github.com/google/openhtf","homepage":"","size":33272,"stargazers_count":125,"watchers_count":125,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":67,"open_issues":106,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/openhtf/pulls/799"},"html":{"href":"https://github.com/google/openhtf/pull/799"},"issue":{"href":"https://api.github.com/repos/google/openhtf/issues/799"},"comments":{"href":"https://api.github.com/repos/google/openhtf/issues/799/comments"},"review_comments":{"href":"https://api.github.com/repos/google/openhtf/pulls/799/comments"},"review_comment":{"href":"https://api.github.com/repos/google/openhtf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/openhtf/pulls/799/commits"},"statuses":{"href":"https://api.github.com/repos/google/openhtf/statuses/0960e330d677062451fcacd66106612563dabad7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Kenadia"}}