{"action":"created","issue":{"url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1727","repository_url":"https://api.github.com/repos/Mudlet/Mudlet","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1727/labels{/name}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1727/comments","events_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1727/events","html_url":"https://github.com/Mudlet/Mudlet/pull/1727","id":328754841,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjA0MzIz","number":1727,"title":"Fixes scroll logic to update TConsoles when scrolling at the top of the Console","user":{"login":"dicene","id":15068394,"node_id":"MDQ6VXNlcjE1MDY4Mzk0","avatar_url":"https://avatars3.githubusercontent.com/u/15068394?v=4","gravatar_id":"","url":"https://api.github.com/users/dicene","html_url":"https://github.com/dicene","followers_url":"https://api.github.com/users/dicene/followers","following_url":"https://api.github.com/users/dicene/following{/other_user}","gists_url":"https://api.github.com/users/dicene/gists{/gist_id}","starred_url":"https://api.github.com/users/dicene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dicene/subscriptions","organizations_url":"https://api.github.com/users/dicene/orgs","repos_url":"https://api.github.com/users/dicene/repos","events_url":"https://api.github.com/users/dicene/events{/privacy}","received_events_url":"https://api.github.com/users/dicene/received_events","type":"User","site_admin":false},"labels":[{"id":119740317,"node_id":"MDU6TGFiZWwxMTk3NDAzMTc=","url":"https://api.github.com/repos/Mudlet/Mudlet/labels/1%20-%20Ready%20for%20review","name":"1 - Ready for review","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"vadi2","id":110988,"node_id":"MDQ6VXNlcjExMDk4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/110988?v=4","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"assignees":[{"login":"vadi2","id":110988,"node_id":"MDQ6VXNlcjExMDk4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/110988?v=4","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},{"login":"SlySven","id":6163092,"node_id":"MDQ6VXNlcjYxNjMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-06-02T15:54:01Z","updated_at":"2018-06-05T05:28:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1727","html_url":"https://github.com/Mudlet/Mudlet/pull/1727","diff_url":"https://github.com/Mudlet/Mudlet/pull/1727.diff","patch_url":"https://github.com/Mudlet/Mudlet/pull/1727.patch"},"body":"Updates `TTextEdit` every scroll attempt, since `bufferScrollUp()` doesn't correctly always inform `TTextEdit::scrollUp()` when lines were actually scrolled.\r\n\r\n#### Brief overview of PR changes/additions\r\nSimple workaround to fix issue: https://github.com/Mudlet/Mudlet/issues/1702 where Consoles didn't properly update if you scrolled them to the very top line until you had done a TON of extra scrolling up past the top, and moved the mouse.\r\n\r\nA proper fix would have `bufferScrollUp()` correctly returning the lines scrolled when you hit the top of the buffer, but `mCursorY` isn't being tracked correctly, which takes a good deal more reworking than is appropriate for this small fix. These issues will likely be resolved when someone fixes the scrollbar itself.\r\n\r\n#### Motivation for adding to Mudlet\r\n\r\n#### Other info (issues closed, discussion etc)\r\n"},"comment":{"url":"https://api.github.com/repos/Mudlet/Mudlet/issues/comments/394586092","html_url":"https://github.com/Mudlet/Mudlet/pull/1727#issuecomment-394586092","issue_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1727","id":394586092,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDU4NjA5Mg==","user":{"login":"vadi2","id":110988,"node_id":"MDQ6VXNlcjExMDk4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/110988?v=4","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T05:28:12Z","updated_at":"2018-06-05T05:28:12Z","author_association":"MEMBER","body":"Finding it hard to replicate the issue. How much text in the buffer are we talking about?"}}
{"actor":{"display_login":"vadi2"}}