{"action":"opened","number":233,"pull_request":{"url":"https://api.github.com/repos/lansuite/lansuite/pulls/233","id":185146067,"html_url":"https://github.com/lansuite/lansuite/pull/233","diff_url":"https://github.com/lansuite/lansuite/pull/233.diff","patch_url":"https://github.com/lansuite/lansuite/pull/233.patch","issue_url":"https://api.github.com/repos/lansuite/lansuite/issues/233","number":233,"state":"open","locked":false,"title":"Module \"pdf\": Rework with autoloading, reformatting, namespacing and dependency injection","user":{"login":"andygrunwald","id":320064,"avatar_url":"https://avatars3.githubusercontent.com/u/320064?v=4","gravatar_id":"","url":"https://api.github.com/users/andygrunwald","html_url":"https://github.com/andygrunwald","followers_url":"https://api.github.com/users/andygrunwald/followers","following_url":"https://api.github.com/users/andygrunwald/following{/other_user}","gists_url":"https://api.github.com/users/andygrunwald/gists{/gist_id}","starred_url":"https://api.github.com/users/andygrunwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andygrunwald/subscriptions","organizations_url":"https://api.github.com/users/andygrunwald/orgs","repos_url":"https://api.github.com/users/andygrunwald/repos","events_url":"https://api.github.com/users/andygrunwald/events{/privacy}","received_events_url":"https://api.github.com/users/andygrunwald/received_events","type":"User","site_admin":false},"body":"This PR is a bigger rework of the pdf module.\r\nIt don't contain a functionality change. It fixes a couple of bugs and enables better testing in future.\r\n\r\nChanges in this PR:\r\n- Reformat of code of the PDF module\r\n- Adding of PHPDoc comments\r\n- Removal of unused variables\r\n- Moved classes to modules/pdf/Classes\r\n- Enables namespaces and autoloading via composer\r\n- Switched dependencies BarcodeSystem and Seat2 to dependency injection of PDF module (for better testing in future)\r\n- Moved class Seat2 to module/seating/Classes\r\n\r\nNext step for the PDF module would be #232","created_at":"2018-05-01T09:18:44Z","updated_at":"2018-05-01T09:18:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lansuite/lansuite/pulls/233/commits","review_comments_url":"https://api.github.com/repos/lansuite/lansuite/pulls/233/comments","review_comment_url":"https://api.github.com/repos/lansuite/lansuite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lansuite/lansuite/issues/233/comments","statuses_url":"https://api.github.com/repos/lansuite/lansuite/statuses/5cd626f7fe1cd0594c3c7775b984d65dca0ccb2f","head":{"label":"lansuite:major-pdf-module-rework","ref":"major-pdf-module-rework","sha":"5cd626f7fe1cd0594c3c7775b984d65dca0ccb2f","user":{"login":"lansuite","id":27761036,"avatar_url":"https://avatars3.githubusercontent.com/u/27761036?v=4","gravatar_id":"","url":"https://api.github.com/users/lansuite","html_url":"https://github.com/lansuite","followers_url":"https://api.github.com/users/lansuite/followers","following_url":"https://api.github.com/users/lansuite/following{/other_user}","gists_url":"https://api.github.com/users/lansuite/gists{/gist_id}","starred_url":"https://api.github.com/users/lansuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lansuite/subscriptions","organizations_url":"https://api.github.com/users/lansuite/orgs","repos_url":"https://api.github.com/users/lansuite/repos","events_url":"https://api.github.com/users/lansuite/events{/privacy}","received_events_url":"https://api.github.com/users/lansuite/received_events","type":"Organization","site_admin":false},"repo":{"id":32155592,"name":"lansuite","full_name":"lansuite/lansuite","owner":{"login":"lansuite","id":27761036,"avatar_url":"https://avatars3.githubusercontent.com/u/27761036?v=4","gravatar_id":"","url":"https://api.github.com/users/lansuite","html_url":"https://github.com/lansuite","followers_url":"https://api.github.com/users/lansuite/followers","following_url":"https://api.github.com/users/lansuite/following{/other_user}","gists_url":"https://api.github.com/users/lansuite/gists{/gist_id}","starred_url":"https://api.github.com/users/lansuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lansuite/subscriptions","organizations_url":"https://api.github.com/users/lansuite/orgs","repos_url":"https://api.github.com/users/lansuite/repos","events_url":"https://api.github.com/users/lansuite/events{/privacy}","received_events_url":"https://api.github.com/users/lansuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lansuite/lansuite","description":"A Content Management System designed especially for the needs of LAN-Parties","fork":false,"url":"https://api.github.com/repos/lansuite/lansuite","forks_url":"https://api.github.com/repos/lansuite/lansuite/forks","keys_url":"https://api.github.com/repos/lansuite/lansuite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lansuite/lansuite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lansuite/lansuite/teams","hooks_url":"https://api.github.com/repos/lansuite/lansuite/hooks","issue_events_url":"https://api.github.com/repos/lansuite/lansuite/issues/events{/number}","events_url":"https://api.github.com/repos/lansuite/lansuite/events","assignees_url":"https://api.github.com/repos/lansuite/lansuite/assignees{/user}","branches_url":"https://api.github.com/repos/lansuite/lansuite/branches{/branch}","tags_url":"https://api.github.com/repos/lansuite/lansuite/tags","blobs_url":"https://api.github.com/repos/lansuite/lansuite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lansuite/lansuite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lansuite/lansuite/git/refs{/sha}","trees_url":"https://api.github.com/repos/lansuite/lansuite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lansuite/lansuite/statuses/{sha}","languages_url":"https://api.github.com/repos/lansuite/lansuite/languages","stargazers_url":"https://api.github.com/repos/lansuite/lansuite/stargazers","contributors_url":"https://api.github.com/repos/lansuite/lansuite/contributors","subscribers_url":"https://api.github.com/repos/lansuite/lansuite/subscribers","subscription_url":"https://api.github.com/repos/lansuite/lansuite/subscription","commits_url":"https://api.github.com/repos/lansuite/lansuite/commits{/sha}","git_commits_url":"https://api.github.com/repos/lansuite/lansuite/git/commits{/sha}","comments_url":"https://api.github.com/repos/lansuite/lansuite/comments{/number}","issue_comment_url":"https://api.github.com/repos/lansuite/lansuite/issues/comments{/number}","contents_url":"https://api.github.com/repos/lansuite/lansuite/contents/{+path}","compare_url":"https://api.github.com/repos/lansuite/lansuite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lansuite/lansuite/merges","archive_url":"https://api.github.com/repos/lansuite/lansuite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lansuite/lansuite/downloads","issues_url":"https://api.github.com/repos/lansuite/lansuite/issues{/number}","pulls_url":"https://api.github.com/repos/lansuite/lansuite/pulls{/number}","milestones_url":"https://api.github.com/repos/lansuite/lansuite/milestones{/number}","notifications_url":"https://api.github.com/repos/lansuite/lansuite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lansuite/lansuite/labels{/name}","releases_url":"https://api.github.com/repos/lansuite/lansuite/releases{/id}","deployments_url":"https://api.github.com/repos/lansuite/lansuite/deployments","created_at":"2015-03-13T12:51:05Z","updated_at":"2018-04-30T08:51:30Z","pushed_at":"2018-05-01T09:13:16Z","git_url":"git://github.com/lansuite/lansuite.git","ssh_url":"git@github.com:lansuite/lansuite.git","clone_url":"https://github.com/lansuite/lansuite.git","svn_url":"https://github.com/lansuite/lansuite","homepage":"http://lansuite.orgapage.de/","size":25572,"stargazers_count":18,"watchers_count":18,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":28,"license":null,"forks":12,"open_issues":28,"watchers":18,"default_branch":"master"}},"base":{"label":"lansuite:master","ref":"master","sha":"c1b2c82d736d12a2a7bda08f18ff39afca04cca3","user":{"login":"lansuite","id":27761036,"avatar_url":"https://avatars3.githubusercontent.com/u/27761036?v=4","gravatar_id":"","url":"https://api.github.com/users/lansuite","html_url":"https://github.com/lansuite","followers_url":"https://api.github.com/users/lansuite/followers","following_url":"https://api.github.com/users/lansuite/following{/other_user}","gists_url":"https://api.github.com/users/lansuite/gists{/gist_id}","starred_url":"https://api.github.com/users/lansuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lansuite/subscriptions","organizations_url":"https://api.github.com/users/lansuite/orgs","repos_url":"https://api.github.com/users/lansuite/repos","events_url":"https://api.github.com/users/lansuite/events{/privacy}","received_events_url":"https://api.github.com/users/lansuite/received_events","type":"Organization","site_admin":false},"repo":{"id":32155592,"name":"lansuite","full_name":"lansuite/lansuite","owner":{"login":"lansuite","id":27761036,"avatar_url":"https://avatars3.githubusercontent.com/u/27761036?v=4","gravatar_id":"","url":"https://api.github.com/users/lansuite","html_url":"https://github.com/lansuite","followers_url":"https://api.github.com/users/lansuite/followers","following_url":"https://api.github.com/users/lansuite/following{/other_user}","gists_url":"https://api.github.com/users/lansuite/gists{/gist_id}","starred_url":"https://api.github.com/users/lansuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lansuite/subscriptions","organizations_url":"https://api.github.com/users/lansuite/orgs","repos_url":"https://api.github.com/users/lansuite/repos","events_url":"https://api.github.com/users/lansuite/events{/privacy}","received_events_url":"https://api.github.com/users/lansuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lansuite/lansuite","description":"A Content Management System designed especially for the needs of LAN-Parties","fork":false,"url":"https://api.github.com/repos/lansuite/lansuite","forks_url":"https://api.github.com/repos/lansuite/lansuite/forks","keys_url":"https://api.github.com/repos/lansuite/lansuite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lansuite/lansuite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lansuite/lansuite/teams","hooks_url":"https://api.github.com/repos/lansuite/lansuite/hooks","issue_events_url":"https://api.github.com/repos/lansuite/lansuite/issues/events{/number}","events_url":"https://api.github.com/repos/lansuite/lansuite/events","assignees_url":"https://api.github.com/repos/lansuite/lansuite/assignees{/user}","branches_url":"https://api.github.com/repos/lansuite/lansuite/branches{/branch}","tags_url":"https://api.github.com/repos/lansuite/lansuite/tags","blobs_url":"https://api.github.com/repos/lansuite/lansuite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lansuite/lansuite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lansuite/lansuite/git/refs{/sha}","trees_url":"https://api.github.com/repos/lansuite/lansuite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lansuite/lansuite/statuses/{sha}","languages_url":"https://api.github.com/repos/lansuite/lansuite/languages","stargazers_url":"https://api.github.com/repos/lansuite/lansuite/stargazers","contributors_url":"https://api.github.com/repos/lansuite/lansuite/contributors","subscribers_url":"https://api.github.com/repos/lansuite/lansuite/subscribers","subscription_url":"https://api.github.com/repos/lansuite/lansuite/subscription","commits_url":"https://api.github.com/repos/lansuite/lansuite/commits{/sha}","git_commits_url":"https://api.github.com/repos/lansuite/lansuite/git/commits{/sha}","comments_url":"https://api.github.com/repos/lansuite/lansuite/comments{/number}","issue_comment_url":"https://api.github.com/repos/lansuite/lansuite/issues/comments{/number}","contents_url":"https://api.github.com/repos/lansuite/lansuite/contents/{+path}","compare_url":"https://api.github.com/repos/lansuite/lansuite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lansuite/lansuite/merges","archive_url":"https://api.github.com/repos/lansuite/lansuite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lansuite/lansuite/downloads","issues_url":"https://api.github.com/repos/lansuite/lansuite/issues{/number}","pulls_url":"https://api.github.com/repos/lansuite/lansuite/pulls{/number}","milestones_url":"https://api.github.com/repos/lansuite/lansuite/milestones{/number}","notifications_url":"https://api.github.com/repos/lansuite/lansuite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lansuite/lansuite/labels{/name}","releases_url":"https://api.github.com/repos/lansuite/lansuite/releases{/id}","deployments_url":"https://api.github.com/repos/lansuite/lansuite/deployments","created_at":"2015-03-13T12:51:05Z","updated_at":"2018-04-30T08:51:30Z","pushed_at":"2018-05-01T09:13:16Z","git_url":"git://github.com/lansuite/lansuite.git","ssh_url":"git@github.com:lansuite/lansuite.git","clone_url":"https://github.com/lansuite/lansuite.git","svn_url":"https://github.com/lansuite/lansuite","homepage":"http://lansuite.orgapage.de/","size":25572,"stargazers_count":18,"watchers_count":18,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":28,"license":null,"forks":12,"open_issues":28,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lansuite/lansuite/pulls/233"},"html":{"href":"https://github.com/lansuite/lansuite/pull/233"},"issue":{"href":"https://api.github.com/repos/lansuite/lansuite/issues/233"},"comments":{"href":"https://api.github.com/repos/lansuite/lansuite/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/lansuite/lansuite/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/lansuite/lansuite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lansuite/lansuite/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/lansuite/lansuite/statuses/5cd626f7fe1cd0594c3c7775b984d65dca0ccb2f"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":552,"deletions":407,"changed_files":25}}
{"actor":{"display_login":"andygrunwald"}}