{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/48193","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/48193/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/48193/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/48193/events","html_url":"https://github.com/saltstack/salt/pull/48193","id":333418533,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjM1Njgy","number":48193,"title":"Properly wait on returns in saltnado","user":{"login":"jacksontj","id":1619869,"node_id":"MDQ6VXNlcjE2MTk4Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1619869?v=4","gravatar_id":"","url":"https://api.github.com/users/jacksontj","html_url":"https://github.com/jacksontj","followers_url":"https://api.github.com/users/jacksontj/followers","following_url":"https://api.github.com/users/jacksontj/following{/other_user}","gists_url":"https://api.github.com/users/jacksontj/gists{/gist_id}","starred_url":"https://api.github.com/users/jacksontj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacksontj/subscriptions","organizations_url":"https://api.github.com/users/jacksontj/orgs","repos_url":"https://api.github.com/users/jacksontj/repos","events_url":"https://api.github.com/users/jacksontj/events{/privacy}","received_events_url":"https://api.github.com/users/jacksontj/received_events","type":"User","site_admin":false},"labels":[{"id":78034416,"node_id":"MDU6TGFiZWw3ODAzNDQxNg==","url":"https://api.github.com/repos/saltstack/salt/labels/Bugfix%20-%20back-port","name":"Bugfix - back-port","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-18T20:15:29Z","updated_at":"2018-06-19T19:06:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/48193","html_url":"https://github.com/saltstack/salt/pull/48193","diff_url":"https://github.com/saltstack/salt/pull/48193.diff","patch_url":"https://github.com/saltstack/salt/pull/48193.patch"},"body":"This was broken because the behavior was to simply check the ckminions\r\nand wait for only those returns to complete. This works assuming\r\nckminions is accurate (which there are many cases where it isn't, such\r\nas syndics).\r\n\r\n_disbatch_local's waiting on returns needs to match LocalClient's\r\nbehavior (namely that in get_iter_returns). This means we are allowed to\r\nreturn when (1) we have waitged the min_wait_time (0 if not a syndic)\r\n(2) no minions are running the job (3) all minions we saw running it are\r\ndone running the job. The only method allowed for earlier termination is\r\nif the gather_job_timeout is exceeded.\r\n\r\nFixes #42659\r\n\r\n### What does this PR do?\r\n\r\n### What issues does this PR fix or reference?\r\n\r\n### Previous Behavior\r\nRemove this section if not relevant\r\n\r\n### New Behavior\r\nRemove this section if not relevant\r\n\r\n### Tests written?\r\n\r\nYes/No\r\n\r\n### Commits signed with GPG?\r\n\r\nYes/No\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nSee GitHub's [page on GPG signing](https://help.github.com/articles/signing-commits-using-gpg/) for more information about signing commits with GPG.\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/398510849","html_url":"https://github.com/saltstack/salt/pull/48193#issuecomment-398510849","issue_url":"https://api.github.com/repos/saltstack/salt/issues/48193","id":398510849,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODUxMDg0OQ==","user":{"login":"gtmanfred","id":732321,"node_id":"MDQ6VXNlcjczMjMyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/732321?v=4","gravatar_id":"","url":"https://api.github.com/users/gtmanfred","html_url":"https://github.com/gtmanfred","followers_url":"https://api.github.com/users/gtmanfred/followers","following_url":"https://api.github.com/users/gtmanfred/following{/other_user}","gists_url":"https://api.github.com/users/gtmanfred/gists{/gist_id}","starred_url":"https://api.github.com/users/gtmanfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtmanfred/subscriptions","organizations_url":"https://api.github.com/users/gtmanfred/orgs","repos_url":"https://api.github.com/users/gtmanfred/repos","events_url":"https://api.github.com/users/gtmanfred/events{/privacy}","received_events_url":"https://api.github.com/users/gtmanfred/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T19:06:48Z","updated_at":"2018-06-19T19:06:48Z","author_association":"MEMBER","body":"@jacksontj looks like you definitely fixed the syndic.\r\n\r\n```\r\nFirst differing element 0:\r\n{'minion': True, 'localhost': True}\r\n{'minion': True, 'localhost': True, 'sub_minion': True}\r\n\r\n- [{'localhost': True, 'minion': True}]\r\n+ [{'localhost': True, 'minion': True, 'sub_minion': True}]\r\n?                                ++++++++++++++++++++\r\n```\r\n\r\nWe are getting the subminion returning on the saltnado syndic tests, can you add that to the test case?\r\n\r\nThanks,\r\nDaniel"}}
{"actor":{"display_login":"gtmanfred"}}