{"action":"created","comment":{"url":"https://api.github.com/repos/contiamo/operational-ui/pulls/comments/225213170","pull_request_review_id":164765645,"id":225213170,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTIxMzE3MA==","diff_hunk":"@@ -103,7 +103,10 @@ class ContextMenu extends React.Component<ContextMenuProps, State> {\n     }\n   }\n \n-  public state: State = {\n+  private makeItem = (itemFromProps: ContextMenuProps[\"items\"][-1]) =>","path":"src/ContextMenu/ContextMenu.tsx","position":32,"original_position":32,"commit_id":"a18779d9ec964bbd76263a645709a00be3991fa3","original_commit_id":"a18779d9ec964bbd76263a645709a00be3991fa3","user":{"login":"peterszerzo","id":6738398,"node_id":"MDQ6VXNlcjY3MzgzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6738398?v=4","gravatar_id":"","url":"https://api.github.com/users/peterszerzo","html_url":"https://github.com/peterszerzo","followers_url":"https://api.github.com/users/peterszerzo/followers","following_url":"https://api.github.com/users/peterszerzo/following{/other_user}","gists_url":"https://api.github.com/users/peterszerzo/gists{/gist_id}","starred_url":"https://api.github.com/users/peterszerzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterszerzo/subscriptions","organizations_url":"https://api.github.com/users/peterszerzo/orgs","repos_url":"https://api.github.com/users/peterszerzo/repos","events_url":"https://api.github.com/users/peterszerzo/events{/privacy}","received_events_url":"https://api.github.com/users/peterszerzo/received_events","type":"User","site_admin":false},"body":"Can we add the comment from before, the one that said that the `getDerivedStateFromProps` solution was meant to standardize the public API, only that here we're achieving the same thing differently?","created_at":"2018-10-15T15:34:37Z","updated_at":"2018-10-15T15:34:48Z","html_url":"https://github.com/contiamo/operational-ui/pull/788#discussion_r225213170","pull_request_url":"https://api.github.com/repos/contiamo/operational-ui/pulls/788","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/comments/225213170"},"html":{"href":"https://github.com/contiamo/operational-ui/pull/788#discussion_r225213170"},"pull_request":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/788"}}},"pull_request":{"url":"https://api.github.com/repos/contiamo/operational-ui/pulls/788","id":222160767,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTYwNzY3","html_url":"https://github.com/contiamo/operational-ui/pull/788","diff_url":"https://github.com/contiamo/operational-ui/pull/788.diff","patch_url":"https://github.com/contiamo/operational-ui/pull/788.patch","issue_url":"https://api.github.com/repos/contiamo/operational-ui/issues/788","number":788,"state":"open","locked":false,"title":"**Breaking:** Adjustments","user":{"login":"TejasQ","id":9947422,"node_id":"MDQ6VXNlcjk5NDc0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/9947422?v=4","gravatar_id":"","url":"https://api.github.com/users/TejasQ","html_url":"https://github.com/TejasQ","followers_url":"https://api.github.com/users/TejasQ/followers","following_url":"https://api.github.com/users/TejasQ/following{/other_user}","gists_url":"https://api.github.com/users/TejasQ/gists{/gist_id}","starred_url":"https://api.github.com/users/TejasQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TejasQ/subscriptions","organizations_url":"https://api.github.com/users/TejasQ/orgs","repos_url":"https://api.github.com/users/TejasQ/repos","events_url":"https://api.github.com/users/TejasQ/events{/privacy}","received_events_url":"https://api.github.com/users/TejasQ/received_events","type":"User","site_admin":false},"body":"<!-- \r\n  ❗️IMPORTANT ❗️\r\n  Please prefix the title of this PR with _one_ of the following.\r\n\r\n  **Breaking:**\r\n    For when we break a public API.\r\n\r\n  **Feature:** \r\n    For when we add something NEW that doesn't\r\n    break the public API.\r\n      \r\n  **Fix:**\r\n    For when we fix something that previously\r\n    did not look or work correctly.\r\n    \r\n  Leaving off this prefix will prevent the PR from being\r\n  included in a release. A good case to omit the prefix\r\n  is when proposing infrastructural changes to the repo\r\n  that do not affect the library.\r\n-->\r\n# Summary\r\nThis PR composes a bunch of fixes to various open issues (see commits). It contains [_one_ breaking change](https://github.com/contiamo/operational-ui/pull/788/files#diff-85f3197de18a071f349f7f5a257a93e3R25) to the `onClick` prop of `ContextMenu`: in terms of API, it only takes one argument: a `ContextMenuItem` instead of a `string | ContextMenuItem`.\r\n\r\n<!-- Some context about this PR: screenshots and links to the docs are appreciate -->\r\n\r\n# Related issue\r\n#746 \r\n#778 \r\n#782 \r\n#785 \r\n#786 \r\n#757 \r\n<!-- Paste the github issue here -->\r\n\r\n# To be tested\r\n\r\nMe\r\n- [x] No error or warning in the console on `localhost:6060`\r\n\r\nTester 1\r\n\r\n- [ ] Things look good on the demo.\r\n  <!-- Put here everything that the reviewer 1 should test to be sure that everything is working properly -->\r\n\r\nTester 2\r\n\r\n- [ ] Things look good on the demo.\r\n  <!-- Put here everything that the reviewer 2 should test to be sure that everything is working properly -->\r\n","created_at":"2018-10-11T14:30:38Z","updated_at":"2018-10-15T15:34:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2dcc4c9523c934d8c2dd17d258f15c23c75caeb","assignee":{"login":"TejasQ","id":9947422,"node_id":"MDQ6VXNlcjk5NDc0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/9947422?v=4","gravatar_id":"","url":"https://api.github.com/users/TejasQ","html_url":"https://github.com/TejasQ","followers_url":"https://api.github.com/users/TejasQ/followers","following_url":"https://api.github.com/users/TejasQ/following{/other_user}","gists_url":"https://api.github.com/users/TejasQ/gists{/gist_id}","starred_url":"https://api.github.com/users/TejasQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TejasQ/subscriptions","organizations_url":"https://api.github.com/users/TejasQ/orgs","repos_url":"https://api.github.com/users/TejasQ/repos","events_url":"https://api.github.com/users/TejasQ/events{/privacy}","received_events_url":"https://api.github.com/users/TejasQ/received_events","type":"User","site_admin":false},"assignees":[{"login":"TejasQ","id":9947422,"node_id":"MDQ6VXNlcjk5NDc0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/9947422?v=4","gravatar_id":"","url":"https://api.github.com/users/TejasQ","html_url":"https://github.com/TejasQ","followers_url":"https://api.github.com/users/TejasQ/followers","following_url":"https://api.github.com/users/TejasQ/following{/other_user}","gists_url":"https://api.github.com/users/TejasQ/gists{/gist_id}","starred_url":"https://api.github.com/users/TejasQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TejasQ/subscriptions","organizations_url":"https://api.github.com/users/TejasQ/orgs","repos_url":"https://api.github.com/users/TejasQ/repos","events_url":"https://api.github.com/users/TejasQ/events{/privacy}","received_events_url":"https://api.github.com/users/TejasQ/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"fabien0102","id":1761469,"node_id":"MDQ6VXNlcjE3NjE0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1761469?v=4","gravatar_id":"","url":"https://api.github.com/users/fabien0102","html_url":"https://github.com/fabien0102","followers_url":"https://api.github.com/users/fabien0102/followers","following_url":"https://api.github.com/users/fabien0102/following{/other_user}","gists_url":"https://api.github.com/users/fabien0102/gists{/gist_id}","starred_url":"https://api.github.com/users/fabien0102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabien0102/subscriptions","organizations_url":"https://api.github.com/users/fabien0102/orgs","repos_url":"https://api.github.com/users/fabien0102/repos","events_url":"https://api.github.com/users/fabien0102/events{/privacy}","received_events_url":"https://api.github.com/users/fabien0102/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/contiamo/operational-ui/pulls/788/commits","review_comments_url":"https://api.github.com/repos/contiamo/operational-ui/pulls/788/comments","review_comment_url":"https://api.github.com/repos/contiamo/operational-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiamo/operational-ui/issues/788/comments","statuses_url":"https://api.github.com/repos/contiamo/operational-ui/statuses/a18779d9ec964bbd76263a645709a00be3991fa3","head":{"label":"contiamo:adjustments","ref":"adjustments","sha":"a18779d9ec964bbd76263a645709a00be3991fa3","user":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"repo":{"id":99110260,"node_id":"MDEwOlJlcG9zaXRvcnk5OTExMDI2MA==","name":"operational-ui","full_name":"contiamo/operational-ui","private":false,"owner":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/contiamo/operational-ui","description":"Building blocks for effective operational interfaces","fork":false,"url":"https://api.github.com/repos/contiamo/operational-ui","forks_url":"https://api.github.com/repos/contiamo/operational-ui/forks","keys_url":"https://api.github.com/repos/contiamo/operational-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiamo/operational-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiamo/operational-ui/teams","hooks_url":"https://api.github.com/repos/contiamo/operational-ui/hooks","issue_events_url":"https://api.github.com/repos/contiamo/operational-ui/issues/events{/number}","events_url":"https://api.github.com/repos/contiamo/operational-ui/events","assignees_url":"https://api.github.com/repos/contiamo/operational-ui/assignees{/user}","branches_url":"https://api.github.com/repos/contiamo/operational-ui/branches{/branch}","tags_url":"https://api.github.com/repos/contiamo/operational-ui/tags","blobs_url":"https://api.github.com/repos/contiamo/operational-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiamo/operational-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiamo/operational-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiamo/operational-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiamo/operational-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/contiamo/operational-ui/languages","stargazers_url":"https://api.github.com/repos/contiamo/operational-ui/stargazers","contributors_url":"https://api.github.com/repos/contiamo/operational-ui/contributors","subscribers_url":"https://api.github.com/repos/contiamo/operational-ui/subscribers","subscription_url":"https://api.github.com/repos/contiamo/operational-ui/subscription","commits_url":"https://api.github.com/repos/contiamo/operational-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiamo/operational-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiamo/operational-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiamo/operational-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiamo/operational-ui/contents/{+path}","compare_url":"https://api.github.com/repos/contiamo/operational-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiamo/operational-ui/merges","archive_url":"https://api.github.com/repos/contiamo/operational-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiamo/operational-ui/downloads","issues_url":"https://api.github.com/repos/contiamo/operational-ui/issues{/number}","pulls_url":"https://api.github.com/repos/contiamo/operational-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/contiamo/operational-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/contiamo/operational-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiamo/operational-ui/labels{/name}","releases_url":"https://api.github.com/repos/contiamo/operational-ui/releases{/id}","deployments_url":"https://api.github.com/repos/contiamo/operational-ui/deployments","created_at":"2017-08-02T11:44:17Z","updated_at":"2018-10-12T15:56:17Z","pushed_at":"2018-10-15T15:10:20Z","git_url":"git://github.com/contiamo/operational-ui.git","ssh_url":"git@github.com:contiamo/operational-ui.git","clone_url":"https://github.com/contiamo/operational-ui.git","svn_url":"https://github.com/contiamo/operational-ui","homepage":"https://operational-ui.js.org","size":45445,"stargazers_count":36,"watchers_count":36,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":20,"watchers":36,"default_branch":"master"}},"base":{"label":"contiamo:master","ref":"master","sha":"1da1ed484676917166d49cbf657945b158436b1a","user":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"repo":{"id":99110260,"node_id":"MDEwOlJlcG9zaXRvcnk5OTExMDI2MA==","name":"operational-ui","full_name":"contiamo/operational-ui","private":false,"owner":{"login":"contiamo","id":862286,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjI4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/862286?v=4","gravatar_id":"","url":"https://api.github.com/users/contiamo","html_url":"https://github.com/contiamo","followers_url":"https://api.github.com/users/contiamo/followers","following_url":"https://api.github.com/users/contiamo/following{/other_user}","gists_url":"https://api.github.com/users/contiamo/gists{/gist_id}","starred_url":"https://api.github.com/users/contiamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiamo/subscriptions","organizations_url":"https://api.github.com/users/contiamo/orgs","repos_url":"https://api.github.com/users/contiamo/repos","events_url":"https://api.github.com/users/contiamo/events{/privacy}","received_events_url":"https://api.github.com/users/contiamo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/contiamo/operational-ui","description":"Building blocks for effective operational interfaces","fork":false,"url":"https://api.github.com/repos/contiamo/operational-ui","forks_url":"https://api.github.com/repos/contiamo/operational-ui/forks","keys_url":"https://api.github.com/repos/contiamo/operational-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiamo/operational-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiamo/operational-ui/teams","hooks_url":"https://api.github.com/repos/contiamo/operational-ui/hooks","issue_events_url":"https://api.github.com/repos/contiamo/operational-ui/issues/events{/number}","events_url":"https://api.github.com/repos/contiamo/operational-ui/events","assignees_url":"https://api.github.com/repos/contiamo/operational-ui/assignees{/user}","branches_url":"https://api.github.com/repos/contiamo/operational-ui/branches{/branch}","tags_url":"https://api.github.com/repos/contiamo/operational-ui/tags","blobs_url":"https://api.github.com/repos/contiamo/operational-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiamo/operational-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiamo/operational-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiamo/operational-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiamo/operational-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/contiamo/operational-ui/languages","stargazers_url":"https://api.github.com/repos/contiamo/operational-ui/stargazers","contributors_url":"https://api.github.com/repos/contiamo/operational-ui/contributors","subscribers_url":"https://api.github.com/repos/contiamo/operational-ui/subscribers","subscription_url":"https://api.github.com/repos/contiamo/operational-ui/subscription","commits_url":"https://api.github.com/repos/contiamo/operational-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiamo/operational-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiamo/operational-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiamo/operational-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiamo/operational-ui/contents/{+path}","compare_url":"https://api.github.com/repos/contiamo/operational-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiamo/operational-ui/merges","archive_url":"https://api.github.com/repos/contiamo/operational-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiamo/operational-ui/downloads","issues_url":"https://api.github.com/repos/contiamo/operational-ui/issues{/number}","pulls_url":"https://api.github.com/repos/contiamo/operational-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/contiamo/operational-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/contiamo/operational-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiamo/operational-ui/labels{/name}","releases_url":"https://api.github.com/repos/contiamo/operational-ui/releases{/id}","deployments_url":"https://api.github.com/repos/contiamo/operational-ui/deployments","created_at":"2017-08-02T11:44:17Z","updated_at":"2018-10-12T15:56:17Z","pushed_at":"2018-10-15T15:10:20Z","git_url":"git://github.com/contiamo/operational-ui.git","ssh_url":"git@github.com:contiamo/operational-ui.git","clone_url":"https://github.com/contiamo/operational-ui.git","svn_url":"https://github.com/contiamo/operational-ui","homepage":"https://operational-ui.js.org","size":45445,"stargazers_count":36,"watchers_count":36,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":20,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/788"},"html":{"href":"https://github.com/contiamo/operational-ui/pull/788"},"issue":{"href":"https://api.github.com/repos/contiamo/operational-ui/issues/788"},"comments":{"href":"https://api.github.com/repos/contiamo/operational-ui/issues/788/comments"},"review_comments":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/788/comments"},"review_comment":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiamo/operational-ui/pulls/788/commits"},"statuses":{"href":"https://api.github.com/repos/contiamo/operational-ui/statuses/a18779d9ec964bbd76263a645709a00be3991fa3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"peterszerzo"}}