{"action":"closed","number":700,"pull_request":{"url":"https://api.github.com/repos/jfurrow/flood/pulls/700","id":212606477,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNjA2NDc3","html_url":"https://github.com/jfurrow/flood/pull/700","diff_url":"https://github.com/jfurrow/flood/pull/700.diff","patch_url":"https://github.com/jfurrow/flood/pull/700.patch","issue_url":"https://api.github.com/repos/jfurrow/flood/issues/700","number":700,"state":"closed","locked":false,"title":"Rate graph: use monotone interpolation to prevent Gibbs phenomenon","user":{"login":"Zopieux","id":81353,"node_id":"MDQ6VXNlcjgxMzUz","avatar_url":"https://avatars2.githubusercontent.com/u/81353?v=4","gravatar_id":"","url":"https://api.github.com/users/Zopieux","html_url":"https://github.com/Zopieux","followers_url":"https://api.github.com/users/Zopieux/followers","following_url":"https://api.github.com/users/Zopieux/following{/other_user}","gists_url":"https://api.github.com/users/Zopieux/gists{/gist_id}","starred_url":"https://api.github.com/users/Zopieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zopieux/subscriptions","organizations_url":"https://api.github.com/users/Zopieux/orgs","repos_url":"https://api.github.com/users/Zopieux/repos","events_url":"https://api.github.com/users/Zopieux/events{/privacy}","received_events_url":"https://api.github.com/users/Zopieux/received_events","type":"User","site_admin":false},"body":"See screenshots. tl;dr removed ripples by changing the graph interpolation function.\r\n\r\n## Description\r\nThe current d3 interpolation function for the rate graph is *cardinal*. While seemingly okay, this function creates some [Gibbs phenomenon ripples](https://en.wikipedia.org/wiki/Gibbs_phenomenon) which give impossible rates when displaying steep curves (typically a negative speed when a download starts/ends).\r\n\r\nGoing with *monotone* gives the exact same curve *feeling* while removing the ripples.\r\n\r\n## Motivation and Context\r\nThese ripples look terrible and are easily avoidable.\r\n\r\n## How Has This Been Tested?\r\nLocally.\r\n\r\n## Screenshots (if appropriate):\r\n![image](https://user-images.githubusercontent.com/81353/44959643-0e4c4c00-aef2-11e8-9bcb-816f3edd122f.png)\r\n![image](https://user-images.githubusercontent.com/81353/44959601-81a18e00-aef1-11e8-8456-45f7fe0424ba.png)\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n","created_at":"2018-09-02T18:54:38Z","updated_at":"2018-09-03T03:45:43Z","closed_at":"2018-09-03T03:45:43Z","merged_at":"2018-09-03T03:45:43Z","merge_commit_sha":"9891af3864a739c98b8e00d27172dd5a4adf49d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jfurrow/flood/pulls/700/commits","review_comments_url":"https://api.github.com/repos/jfurrow/flood/pulls/700/comments","review_comment_url":"https://api.github.com/repos/jfurrow/flood/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jfurrow/flood/issues/700/comments","statuses_url":"https://api.github.com/repos/jfurrow/flood/statuses/ba59d21ccf502c8944223b30ef60da4e469c93e4","head":{"label":"Zopieux:patch-1","ref":"patch-1","sha":"ba59d21ccf502c8944223b30ef60da4e469c93e4","user":{"login":"Zopieux","id":81353,"node_id":"MDQ6VXNlcjgxMzUz","avatar_url":"https://avatars2.githubusercontent.com/u/81353?v=4","gravatar_id":"","url":"https://api.github.com/users/Zopieux","html_url":"https://github.com/Zopieux","followers_url":"https://api.github.com/users/Zopieux/followers","following_url":"https://api.github.com/users/Zopieux/following{/other_user}","gists_url":"https://api.github.com/users/Zopieux/gists{/gist_id}","starred_url":"https://api.github.com/users/Zopieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zopieux/subscriptions","organizations_url":"https://api.github.com/users/Zopieux/orgs","repos_url":"https://api.github.com/users/Zopieux/repos","events_url":"https://api.github.com/users/Zopieux/events{/privacy}","received_events_url":"https://api.github.com/users/Zopieux/received_events","type":"User","site_admin":false},"repo":{"id":147111961,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxMTE5NjE=","name":"flood","full_name":"Zopieux/flood","owner":{"login":"Zopieux","id":81353,"node_id":"MDQ6VXNlcjgxMzUz","avatar_url":"https://avatars2.githubusercontent.com/u/81353?v=4","gravatar_id":"","url":"https://api.github.com/users/Zopieux","html_url":"https://github.com/Zopieux","followers_url":"https://api.github.com/users/Zopieux/followers","following_url":"https://api.github.com/users/Zopieux/following{/other_user}","gists_url":"https://api.github.com/users/Zopieux/gists{/gist_id}","starred_url":"https://api.github.com/users/Zopieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zopieux/subscriptions","organizations_url":"https://api.github.com/users/Zopieux/orgs","repos_url":"https://api.github.com/users/Zopieux/repos","events_url":"https://api.github.com/users/Zopieux/events{/privacy}","received_events_url":"https://api.github.com/users/Zopieux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zopieux/flood","description":"A modern web UI for rTorrent with a Node.js backend and React frontend.","fork":true,"url":"https://api.github.com/repos/Zopieux/flood","forks_url":"https://api.github.com/repos/Zopieux/flood/forks","keys_url":"https://api.github.com/repos/Zopieux/flood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zopieux/flood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zopieux/flood/teams","hooks_url":"https://api.github.com/repos/Zopieux/flood/hooks","issue_events_url":"https://api.github.com/repos/Zopieux/flood/issues/events{/number}","events_url":"https://api.github.com/repos/Zopieux/flood/events","assignees_url":"https://api.github.com/repos/Zopieux/flood/assignees{/user}","branches_url":"https://api.github.com/repos/Zopieux/flood/branches{/branch}","tags_url":"https://api.github.com/repos/Zopieux/flood/tags","blobs_url":"https://api.github.com/repos/Zopieux/flood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zopieux/flood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zopieux/flood/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zopieux/flood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zopieux/flood/statuses/{sha}","languages_url":"https://api.github.com/repos/Zopieux/flood/languages","stargazers_url":"https://api.github.com/repos/Zopieux/flood/stargazers","contributors_url":"https://api.github.com/repos/Zopieux/flood/contributors","subscribers_url":"https://api.github.com/repos/Zopieux/flood/subscribers","subscription_url":"https://api.github.com/repos/Zopieux/flood/subscription","commits_url":"https://api.github.com/repos/Zopieux/flood/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zopieux/flood/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zopieux/flood/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zopieux/flood/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zopieux/flood/contents/{+path}","compare_url":"https://api.github.com/repos/Zopieux/flood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zopieux/flood/merges","archive_url":"https://api.github.com/repos/Zopieux/flood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zopieux/flood/downloads","issues_url":"https://api.github.com/repos/Zopieux/flood/issues{/number}","pulls_url":"https://api.github.com/repos/Zopieux/flood/pulls{/number}","milestones_url":"https://api.github.com/repos/Zopieux/flood/milestones{/number}","notifications_url":"https://api.github.com/repos/Zopieux/flood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zopieux/flood/labels{/name}","releases_url":"https://api.github.com/repos/Zopieux/flood/releases{/id}","deployments_url":"https://api.github.com/repos/Zopieux/flood/deployments","created_at":"2018-09-02T18:39:46Z","updated_at":"2018-09-02T18:39:48Z","pushed_at":"2018-09-02T18:41:52Z","git_url":"git://github.com/Zopieux/flood.git","ssh_url":"git@github.com:Zopieux/flood.git","clone_url":"https://github.com/Zopieux/flood.git","svn_url":"https://github.com/Zopieux/flood","homepage":"","size":22464,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jfurrow:master","ref":"master","sha":"f492ad348aca43b8be506c46825b95e040db8a95","user":{"login":"jfurrow","id":1134755,"node_id":"MDQ6VXNlcjExMzQ3NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1134755?v=4","gravatar_id":"","url":"https://api.github.com/users/jfurrow","html_url":"https://github.com/jfurrow","followers_url":"https://api.github.com/users/jfurrow/followers","following_url":"https://api.github.com/users/jfurrow/following{/other_user}","gists_url":"https://api.github.com/users/jfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/jfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfurrow/subscriptions","organizations_url":"https://api.github.com/users/jfurrow/orgs","repos_url":"https://api.github.com/users/jfurrow/repos","events_url":"https://api.github.com/users/jfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/jfurrow/received_events","type":"User","site_admin":false},"repo":{"id":33637217,"node_id":"MDEwOlJlcG9zaXRvcnkzMzYzNzIxNw==","name":"flood","full_name":"jfurrow/flood","owner":{"login":"jfurrow","id":1134755,"node_id":"MDQ6VXNlcjExMzQ3NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1134755?v=4","gravatar_id":"","url":"https://api.github.com/users/jfurrow","html_url":"https://github.com/jfurrow","followers_url":"https://api.github.com/users/jfurrow/followers","following_url":"https://api.github.com/users/jfurrow/following{/other_user}","gists_url":"https://api.github.com/users/jfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/jfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfurrow/subscriptions","organizations_url":"https://api.github.com/users/jfurrow/orgs","repos_url":"https://api.github.com/users/jfurrow/repos","events_url":"https://api.github.com/users/jfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/jfurrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jfurrow/flood","description":"A modern web UI for rTorrent with a Node.js backend and React frontend.","fork":false,"url":"https://api.github.com/repos/jfurrow/flood","forks_url":"https://api.github.com/repos/jfurrow/flood/forks","keys_url":"https://api.github.com/repos/jfurrow/flood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfurrow/flood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfurrow/flood/teams","hooks_url":"https://api.github.com/repos/jfurrow/flood/hooks","issue_events_url":"https://api.github.com/repos/jfurrow/flood/issues/events{/number}","events_url":"https://api.github.com/repos/jfurrow/flood/events","assignees_url":"https://api.github.com/repos/jfurrow/flood/assignees{/user}","branches_url":"https://api.github.com/repos/jfurrow/flood/branches{/branch}","tags_url":"https://api.github.com/repos/jfurrow/flood/tags","blobs_url":"https://api.github.com/repos/jfurrow/flood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfurrow/flood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfurrow/flood/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfurrow/flood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfurrow/flood/statuses/{sha}","languages_url":"https://api.github.com/repos/jfurrow/flood/languages","stargazers_url":"https://api.github.com/repos/jfurrow/flood/stargazers","contributors_url":"https://api.github.com/repos/jfurrow/flood/contributors","subscribers_url":"https://api.github.com/repos/jfurrow/flood/subscribers","subscription_url":"https://api.github.com/repos/jfurrow/flood/subscription","commits_url":"https://api.github.com/repos/jfurrow/flood/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfurrow/flood/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfurrow/flood/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfurrow/flood/issues/comments{/number}","contents_url":"https://api.github.com/repos/jfurrow/flood/contents/{+path}","compare_url":"https://api.github.com/repos/jfurrow/flood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfurrow/flood/merges","archive_url":"https://api.github.com/repos/jfurrow/flood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfurrow/flood/downloads","issues_url":"https://api.github.com/repos/jfurrow/flood/issues{/number}","pulls_url":"https://api.github.com/repos/jfurrow/flood/pulls{/number}","milestones_url":"https://api.github.com/repos/jfurrow/flood/milestones{/number}","notifications_url":"https://api.github.com/repos/jfurrow/flood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfurrow/flood/labels{/name}","releases_url":"https://api.github.com/repos/jfurrow/flood/releases{/id}","deployments_url":"https://api.github.com/repos/jfurrow/flood/deployments","created_at":"2015-04-08T23:13:16Z","updated_at":"2018-09-03T03:43:39Z","pushed_at":"2018-09-03T03:45:43Z","git_url":"git://github.com/jfurrow/flood.git","ssh_url":"git@github.com:jfurrow/flood.git","clone_url":"https://github.com/jfurrow/flood.git","svn_url":"https://github.com/jfurrow/flood","homepage":"","size":22460,"stargazers_count":1215,"watchers_count":1215,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":109,"open_issues":140,"watchers":1215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jfurrow/flood/pulls/700"},"html":{"href":"https://github.com/jfurrow/flood/pull/700"},"issue":{"href":"https://api.github.com/repos/jfurrow/flood/issues/700"},"comments":{"href":"https://api.github.com/repos/jfurrow/flood/issues/700/comments"},"review_comments":{"href":"https://api.github.com/repos/jfurrow/flood/pulls/700/comments"},"review_comment":{"href":"https://api.github.com/repos/jfurrow/flood/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jfurrow/flood/pulls/700/commits"},"statuses":{"href":"https://api.github.com/repos/jfurrow/flood/statuses/ba59d21ccf502c8944223b30ef60da4e469c93e4"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jfurrow","id":1134755,"node_id":"MDQ6VXNlcjExMzQ3NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1134755?v=4","gravatar_id":"","url":"https://api.github.com/users/jfurrow","html_url":"https://github.com/jfurrow","followers_url":"https://api.github.com/users/jfurrow/followers","following_url":"https://api.github.com/users/jfurrow/following{/other_user}","gists_url":"https://api.github.com/users/jfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/jfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfurrow/subscriptions","organizations_url":"https://api.github.com/users/jfurrow/orgs","repos_url":"https://api.github.com/users/jfurrow/repos","events_url":"https://api.github.com/users/jfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/jfurrow/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"jfurrow"}}