{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/199231423","pull_request_review_id":133315874,"id":199231423,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTIzMTQyMw==","diff_hunk":"@@ -82,18 +83,23 @@ def describe_non_vm(vm_name)\n   def describe_vm(vm, reason)\n     {\n       \"name\"           => vm.name,\n-      \"cluster\"        => vm.ems_cluster.name,\n-      \"path\"           => \"#{vm.ext_management_system.name}/#{vm.parent_blue_folder_path(:exclude_non_display_folders => true)}\",\n+      \"cluster\"        => vm.ems_cluster.try(:name) || '',\n+      \"path\"           => vm.ext_management_system ? \"#{vm.ext_management_system.name}/#{vm.parent_blue_folder_path(:exclude_non_display_folders => true)}\" : '',\n       \"allocated_size\" => vm.allocated_disk_storage,\n       \"id\"             => vm.id,\n       \"reason\"         => reason\n     }\n   end\n \n   def validate_vm(vm, quick = true)\n+    validate_result = vm.validate_v2v_migration\n+    return validate_result unless validate_result == VM_VALID\n+\n     # a valid vm must find all resources in the mapping and has never been migrated\n     invalid_list = []\n \n+    return VM_INACTIVE unless vm.active?","path":"app/models/transformation_mapping.rb","position":29,"original_position":29,"commit_id":"deacfdcaabd1f2c4106c4a296128941dd8bc6103","original_commit_id":"deacfdcaabd1f2c4106c4a296128941dd8bc6103","user":{"login":"bzwei","id":7047579,"node_id":"MDQ6VXNlcjcwNDc1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7047579?v=4","gravatar_id":"","url":"https://api.github.com/users/bzwei","html_url":"https://github.com/bzwei","followers_url":"https://api.github.com/users/bzwei/followers","following_url":"https://api.github.com/users/bzwei/following{/other_user}","gists_url":"https://api.github.com/users/bzwei/gists{/gist_id}","starred_url":"https://api.github.com/users/bzwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzwei/subscriptions","organizations_url":"https://api.github.com/users/bzwei/orgs","repos_url":"https://api.github.com/users/bzwei/repos","events_url":"https://api.github.com/users/bzwei/events{/privacy}","received_events_url":"https://api.github.com/users/bzwei/received_events","type":"User","site_admin":false},"body":"remove this line `return VM_INACTIVE unless vm.active?`. Looks good else.","created_at":"2018-06-29T17:38:43Z","updated_at":"2018-06-29T17:38:43Z","html_url":"https://github.com/ManageIQ/manageiq/pull/17650#discussion_r199231423","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17650","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/199231423"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/17650#discussion_r199231423"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17650"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17650","id":198048244,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDQ4MjQ0","html_url":"https://github.com/ManageIQ/manageiq/pull/17650","diff_url":"https://github.com/ManageIQ/manageiq/pull/17650.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/17650.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17650","number":17650,"state":"open","locked":false,"title":"Fixes undefined method `name` error during CSV validation required for v2v migration","user":{"login":"AparnaKarve","id":1538216,"node_id":"MDQ6VXNlcjE1MzgyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1538216?v=4","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"body":"Account for a case when there is no `cluster` or `ext_management_system` info available from the csv file.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1596318","created_at":"2018-06-28T14:26:29Z","updated_at":"2018-06-29T17:38:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fee92408ce799a9c922b63eb675f273b74efe23e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":382968361,"node_id":"MDU6TGFiZWwzODI5NjgzNjE=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/blocker","name":"blocker","color":"000000","default":false},{"id":106615676,"node_id":"MDU6TGFiZWwxMDY2MTU2NzY=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"ee0701","default":true},{"id":736076551,"node_id":"MDU6TGFiZWw3MzYwNzY1NTE=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/gaprindashvili/yes","name":"gaprindashvili/yes","color":"000000","default":false},{"id":824241527,"node_id":"MDU6TGFiZWw4MjQyNDE1Mjc=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/transformation","name":"transformation","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17650/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17650/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17650/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/deacfdcaabd1f2c4106c4a296128941dd8bc6103","head":{"label":"AparnaKarve:fix_csv_describe_vm","ref":"fix_csv_describe_vm","sha":"deacfdcaabd1f2c4106c4a296128941dd8bc6103","user":{"login":"AparnaKarve","id":1538216,"node_id":"MDQ6VXNlcjE1MzgyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1538216?v=4","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"repo":{"id":20812346,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgxMjM0Ng==","name":"manageiq","full_name":"AparnaKarve/manageiq","owner":{"login":"AparnaKarve","id":1538216,"node_id":"MDQ6VXNlcjE1MzgyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1538216?v=4","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AparnaKarve/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/AparnaKarve/manageiq","forks_url":"https://api.github.com/repos/AparnaKarve/manageiq/forks","keys_url":"https://api.github.com/repos/AparnaKarve/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AparnaKarve/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AparnaKarve/manageiq/teams","hooks_url":"https://api.github.com/repos/AparnaKarve/manageiq/hooks","issue_events_url":"https://api.github.com/repos/AparnaKarve/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/AparnaKarve/manageiq/events","assignees_url":"https://api.github.com/repos/AparnaKarve/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/AparnaKarve/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/AparnaKarve/manageiq/tags","blobs_url":"https://api.github.com/repos/AparnaKarve/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AparnaKarve/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AparnaKarve/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/AparnaKarve/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AparnaKarve/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/AparnaKarve/manageiq/languages","stargazers_url":"https://api.github.com/repos/AparnaKarve/manageiq/stargazers","contributors_url":"https://api.github.com/repos/AparnaKarve/manageiq/contributors","subscribers_url":"https://api.github.com/repos/AparnaKarve/manageiq/subscribers","subscription_url":"https://api.github.com/repos/AparnaKarve/manageiq/subscription","commits_url":"https://api.github.com/repos/AparnaKarve/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/AparnaKarve/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/AparnaKarve/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/AparnaKarve/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/AparnaKarve/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/AparnaKarve/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AparnaKarve/manageiq/merges","archive_url":"https://api.github.com/repos/AparnaKarve/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AparnaKarve/manageiq/downloads","issues_url":"https://api.github.com/repos/AparnaKarve/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/AparnaKarve/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/AparnaKarve/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/AparnaKarve/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AparnaKarve/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/AparnaKarve/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/AparnaKarve/manageiq/deployments","created_at":"2014-06-13T17:37:56Z","updated_at":"2014-06-24T23:08:57Z","pushed_at":"2018-06-29T16:43:53Z","git_url":"git://github.com/AparnaKarve/manageiq.git","ssh_url":"git@github.com:AparnaKarve/manageiq.git","clone_url":"https://github.com/AparnaKarve/manageiq.git","svn_url":"https://github.com/AparnaKarve/manageiq","homepage":null,"size":224126,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"2e7a572fda03196752b3bd34a58ba5c695deee05","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc4OTc1Nw==","name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2018-06-29T16:46:29Z","pushed_at":"2018-06-29T16:46:09Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":254367,"stargazers_count":673,"watchers_count":673,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":646,"mirror_url":null,"archived":false,"open_issues_count":600,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":646,"open_issues":600,"watchers":673,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17650"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/17650"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/17650"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/17650/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17650/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17650/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/deacfdcaabd1f2c4106c4a296128941dd8bc6103"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bzwei"}}