{"action":"created","issue":{"url":"https://api.github.com/repos/gnudatalanguage/gdl/issues/431","repository_url":"https://api.github.com/repos/gnudatalanguage/gdl","labels_url":"https://api.github.com/repos/gnudatalanguage/gdl/issues/431/labels{/name}","comments_url":"https://api.github.com/repos/gnudatalanguage/gdl/issues/431/comments","events_url":"https://api.github.com/repos/gnudatalanguage/gdl/issues/431/events","html_url":"https://github.com/gnudatalanguage/gdl/pull/431","id":344700754,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MDMyNTI0","number":431,"title":"Hash/List functions in finished form.","user":{"login":"maynardGK","id":7710053,"node_id":"MDQ6VXNlcjc3MTAwNTM=","avatar_url":"https://avatars1.githubusercontent.com/u/7710053?v=4","gravatar_id":"","url":"https://api.github.com/users/maynardGK","html_url":"https://github.com/maynardGK","followers_url":"https://api.github.com/users/maynardGK/followers","following_url":"https://api.github.com/users/maynardGK/following{/other_user}","gists_url":"https://api.github.com/users/maynardGK/gists{/gist_id}","starred_url":"https://api.github.com/users/maynardGK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maynardGK/subscriptions","organizations_url":"https://api.github.com/users/maynardGK/orgs","repos_url":"https://api.github.com/users/maynardGK/repos","events_url":"https://api.github.com/users/maynardGK/events{/privacy}","received_events_url":"https://api.github.com/users/maynardGK/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-26T05:32:23Z","updated_at":"2018-07-27T13:30:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/431","html_url":"https://github.com/gnudatalanguage/gdl/pull/431","diff_url":"https://github.com/gnudatalanguage/gdl/pull/431.diff","patch_url":"https://github.com/gnudatalanguage/gdl/pull/431.patch"},"body":"HASH and LIST improvements were to be a separate PR but they were tacked into the Windows' build.\r\n Mostly all of the properties of HASH and LIST are now implemented with this change, which has radical changes to the list__overloadleftbracket and rightbracket routines. In hash.cpp, the /recursive option of the TOSTRUCT method is not working. \"ordered hash\" has a property flag but is not implemented. \r\n\r\nWin_build:\r\n\r\n   GDL is built in appveyor using mingw-w64 compiler and support libraries built with this\r\ncompiler.   The  **scripts/appveyor_1.msys** sequence obtains those, pre-built, needed from the msys repository **http://repo.msys2.org/mingw/i686/**.    Some of these distributions have been found to not be compatible with other elements of the appveyor build. So, \"version upgrades\" need to be tested methodically.\r\n\r\n  **wxwidgets** and **graphicsmagick** are the next two behemoth support libraries to be integrated.\r\n\r\nThe previous **appveyor.yml** included a build of wxWidgets which uses mingw32-make (not the msys make) and results in library and include files suitable for use by the \"Windows\" option of CMAKE.  Due to incomplete development of this branch in the cmake and plplot scripts, it wasn't getting included in the plplot build.  This build is preserved in  **scripts/wxmake_mingw**.bat (a  CMD script).\r\n\r\nTo create a custom plplot library used with GDL we use the cmake generator \"MSYS Makefiles\" in **scripts/appveyor_plplot.msys** and build with MSYS \"make: instead of building with \"mingw32-make\".  This script can also be used \"in place\" from a home system configured (using symbolic links) to look like your git directory is /c/project/gdl.  For this custom build of plplot, three minor patches are applied from this script using the files of **/c/projects/gdl/scripts/patch**.  Two of these patches involve the WIN device driver, a) correct the keyboard focus in both wingcc and wingdi, and b) align structures in wingdi so that it can be used in GDL identically to wingcc.  In the GDL cmake command, an entry for the plplot-driver selector USE_WINGDI_NOT_WINGCC swaps the (patched) wingdi.dll in place of wingcc. Improvements in axes and labelling can be noticed, but there is still no anti-aliasing of the plot line.\r\n\r\n  Using MSYS,  cmake scripting uses \"unix-style\" to find wxWidgets via extensive use of the /bin/wx-config script.  This usage is improved in the plplot build with a minor patch creating a convenient way to locate the library outside of its usual (as pointed to by wx-config)  location. \r\n  wxWidgets is not yet included in the GDL build because 1) the mingw32-make version won't work 2) the MSYS script is untested - a crucial \"sed\"  in there is needed for wx-config to put it together right. \r\n As yet untested but possibly more useful for progress at home, **scripts/appveyor_gdl.msys** would build GDL using MSYS make.  \r\n \r\nGraphicsMagick (GM) comes from **http://repo.msys2.org/mingw/i686/**  in 8-bit quantum form, which  isn't very interesting and also provides new test failures downstream (READ_JPEG); most complain that they prefer a 32-bit quantum.  A script is made for that, which can be run on a home MSYS installation, but the Appveyor machine does not seem to have enough to handle it.  When that can happen, the alternative directory can be named in the GDL build script  **scripts/mingw-bldgdl.bat**. \r\n\r\n\r\n\r\nGreg Jung\r\ngvjung@gmail.com"},"comment":{"url":"https://api.github.com/repos/gnudatalanguage/gdl/issues/comments/408418904","html_url":"https://github.com/gnudatalanguage/gdl/pull/431#issuecomment-408418904","issue_url":"https://api.github.com/repos/gnudatalanguage/gdl/issues/431","id":408418904,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODQxODkwNA==","user":{"login":"slayoo","id":89685,"node_id":"MDQ6VXNlcjg5Njg1","avatar_url":"https://avatars2.githubusercontent.com/u/89685?v=4","gravatar_id":"","url":"https://api.github.com/users/slayoo","html_url":"https://github.com/slayoo","followers_url":"https://api.github.com/users/slayoo/followers","following_url":"https://api.github.com/users/slayoo/following{/other_user}","gists_url":"https://api.github.com/users/slayoo/gists{/gist_id}","starred_url":"https://api.github.com/users/slayoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slayoo/subscriptions","organizations_url":"https://api.github.com/users/slayoo/orgs","repos_url":"https://api.github.com/users/slayoo/repos","events_url":"https://api.github.com/users/slayoo/events{/privacy}","received_events_url":"https://api.github.com/users/slayoo/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T13:30:38Z","updated_at":"2018-07-27T13:30:38Z","author_association":"MEMBER","body":"@maynardGK just to make sure - as of now, there is still just one build done on Appveyor, no Debug/Release matrix"}}
{"actor":{"display_login":"slayoo"}}