{"action":"created","comment":{"url":"https://api.github.com/repos/NYPL/nypl-core/pulls/comments/167670409","pull_request_review_id":95922790,"id":167670409,"diff_hunk":"@@ -1,3 +1,45 @@\n # NYPL Core\n \n-Models, mappings, and vocabularies for the NYPL Core ontology.  \n\\ No newline at end of file\n+Models, mappings, and vocabularies for the NYPL Core ontology.\n+\n+## Deployment Process\n+\n+### General Workflow for Changes\n+\n+* Create a new branch from master\n+* Change the CSV file(s) with the intended changes\n+* Serialize changes via the appropriate script(s)\n+* Commit changes\n+* Create a pre-release tag in the form vX.Xa, i.e. v1.1a\n+\n+#### For QA:\n+\n+* Test the pre-release tag on AWS nypl-sandbox by setting the\n+  NYPL_CORE_VERSION variable to vX.Xa for applications that need to test\n+  the changes\n+* Change environment variables for discovery-api (Elastic Beanstalk)\n+* Apply the changes which will trigger an application restart\n+* If no changes to variables are detected, a restart will not take\n+  place. One must force a restart to clear caches and pull in changes\n+* Test the changes on our QA server\n+* Make adjustments to the mapping as needed\n+* Create a new tag vX.Xb","path":"README.md","position":28,"original_position":28,"commit_id":"93b19653a5956d24dfbb184751961f016f572a42","original_commit_id":"93b19653a5956d24dfbb184751961f016f572a42","user":{"login":"saverkamp","id":609083,"avatar_url":"https://avatars2.githubusercontent.com/u/609083?v=4","gravatar_id":"","url":"https://api.github.com/users/saverkamp","html_url":"https://github.com/saverkamp","followers_url":"https://api.github.com/users/saverkamp/followers","following_url":"https://api.github.com/users/saverkamp/following{/other_user}","gists_url":"https://api.github.com/users/saverkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/saverkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saverkamp/subscriptions","organizations_url":"https://api.github.com/users/saverkamp/orgs","repos_url":"https://api.github.com/users/saverkamp/repos","events_url":"https://api.github.com/users/saverkamp/events{/privacy}","received_events_url":"https://api.github.com/users/saverkamp/received_events","type":"User","site_admin":false},"body":"I think it makes sense to increment the tag when there's more than one person involved (ex. vX.Xa fails testing, I need to reserialize, and Greg needs to re-test), but agree with Paul that if it's just one person involved, maybe not necessary.","created_at":"2018-02-12T20:03:30Z","updated_at":"2018-02-12T20:03:30Z","html_url":"https://github.com/NYPL/nypl-core/pull/14#discussion_r167670409","pull_request_url":"https://api.github.com/repos/NYPL/nypl-core/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/NYPL/nypl-core/pulls/comments/167670409"},"html":{"href":"https://github.com/NYPL/nypl-core/pull/14#discussion_r167670409"},"pull_request":{"href":"https://api.github.com/repos/NYPL/nypl-core/pulls/14"}},"in_reply_to_id":167597772},"pull_request":{"url":"https://api.github.com/repos/NYPL/nypl-core/pulls/14","id":167791961,"html_url":"https://github.com/NYPL/nypl-core/pull/14","diff_url":"https://github.com/NYPL/nypl-core/pull/14.diff","patch_url":"https://github.com/NYPL/nypl-core/pull/14.patch","issue_url":"https://api.github.com/repos/NYPL/nypl-core/issues/14","number":14,"state":"open","locked":false,"title":"First attempt at adding workflow steps to deployment","user":{"login":"gkallenberg","id":1726809,"avatar_url":"https://avatars1.githubusercontent.com/u/1726809?v=4","gravatar_id":"","url":"https://api.github.com/users/gkallenberg","html_url":"https://github.com/gkallenberg","followers_url":"https://api.github.com/users/gkallenberg/followers","following_url":"https://api.github.com/users/gkallenberg/following{/other_user}","gists_url":"https://api.github.com/users/gkallenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/gkallenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkallenberg/subscriptions","organizations_url":"https://api.github.com/users/gkallenberg/orgs","repos_url":"https://api.github.com/users/gkallenberg/repos","events_url":"https://api.github.com/users/gkallenberg/events{/privacy}","received_events_url":"https://api.github.com/users/gkallenberg/received_events","type":"User","site_admin":false},"body":"An attempt at clarifying how changes to mappings, vocabularies, etc. are added, reviewed, tested and deployed. Feel free to write plenty of comments. We had a bit of a hiccup deploying changes to production for the latest delivery locations change. So I wanted to add some sort of formal process for getting the work integrated and delivered. I also don't want to overstep since I'm not a regular contributor to this repo.","created_at":"2018-02-07T19:51:34Z","updated_at":"2018-02-12T20:03:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cd2421b74d55c39c01b74824c8866c2e9d6dab8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"saverkamp","id":609083,"avatar_url":"https://avatars2.githubusercontent.com/u/609083?v=4","gravatar_id":"","url":"https://api.github.com/users/saverkamp","html_url":"https://github.com/saverkamp","followers_url":"https://api.github.com/users/saverkamp/followers","following_url":"https://api.github.com/users/saverkamp/following{/other_user}","gists_url":"https://api.github.com/users/saverkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/saverkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saverkamp/subscriptions","organizations_url":"https://api.github.com/users/saverkamp/orgs","repos_url":"https://api.github.com/users/saverkamp/repos","events_url":"https://api.github.com/users/saverkamp/events{/privacy}","received_events_url":"https://api.github.com/users/saverkamp/received_events","type":"User","site_admin":false},{"login":"kfriedman","id":642889,"avatar_url":"https://avatars2.githubusercontent.com/u/642889?v=4","gravatar_id":"","url":"https://api.github.com/users/kfriedman","html_url":"https://github.com/kfriedman","followers_url":"https://api.github.com/users/kfriedman/followers","following_url":"https://api.github.com/users/kfriedman/following{/other_user}","gists_url":"https://api.github.com/users/kfriedman/gists{/gist_id}","starred_url":"https://api.github.com/users/kfriedman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfriedman/subscriptions","organizations_url":"https://api.github.com/users/kfriedman/orgs","repos_url":"https://api.github.com/users/kfriedman/repos","events_url":"https://api.github.com/users/kfriedman/events{/privacy}","received_events_url":"https://api.github.com/users/kfriedman/received_events","type":"User","site_admin":false},{"login":"katesweeney","id":22665384,"avatar_url":"https://avatars3.githubusercontent.com/u/22665384?v=4","gravatar_id":"","url":"https://api.github.com/users/katesweeney","html_url":"https://github.com/katesweeney","followers_url":"https://api.github.com/users/katesweeney/followers","following_url":"https://api.github.com/users/katesweeney/following{/other_user}","gists_url":"https://api.github.com/users/katesweeney/gists{/gist_id}","starred_url":"https://api.github.com/users/katesweeney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katesweeney/subscriptions","organizations_url":"https://api.github.com/users/katesweeney/orgs","repos_url":"https://api.github.com/users/katesweeney/repos","events_url":"https://api.github.com/users/katesweeney/events{/privacy}","received_events_url":"https://api.github.com/users/katesweeney/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NYPL/nypl-core/pulls/14/commits","review_comments_url":"https://api.github.com/repos/NYPL/nypl-core/pulls/14/comments","review_comment_url":"https://api.github.com/repos/NYPL/nypl-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NYPL/nypl-core/issues/14/comments","statuses_url":"https://api.github.com/repos/NYPL/nypl-core/statuses/93b19653a5956d24dfbb184751961f016f572a42","head":{"label":"NYPL:gk/deployment-process-docs","ref":"gk/deployment-process-docs","sha":"93b19653a5956d24dfbb184751961f016f572a42","user":{"login":"NYPL","id":944604,"avatar_url":"https://avatars1.githubusercontent.com/u/944604?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL","html_url":"https://github.com/NYPL","followers_url":"https://api.github.com/users/NYPL/followers","following_url":"https://api.github.com/users/NYPL/following{/other_user}","gists_url":"https://api.github.com/users/NYPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL/subscriptions","organizations_url":"https://api.github.com/users/NYPL/orgs","repos_url":"https://api.github.com/users/NYPL/repos","events_url":"https://api.github.com/users/NYPL/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL/received_events","type":"Organization","site_admin":false},"repo":{"id":95240515,"name":"nypl-core","full_name":"NYPL/nypl-core","owner":{"login":"NYPL","id":944604,"avatar_url":"https://avatars1.githubusercontent.com/u/944604?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL","html_url":"https://github.com/NYPL","followers_url":"https://api.github.com/users/NYPL/followers","following_url":"https://api.github.com/users/NYPL/following{/other_user}","gists_url":"https://api.github.com/users/NYPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL/subscriptions","organizations_url":"https://api.github.com/users/NYPL/orgs","repos_url":"https://api.github.com/users/NYPL/repos","events_url":"https://api.github.com/users/NYPL/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL/nypl-core","description":"Data models, mappings, and vocabularies for NYPL Core ontology","fork":false,"url":"https://api.github.com/repos/NYPL/nypl-core","forks_url":"https://api.github.com/repos/NYPL/nypl-core/forks","keys_url":"https://api.github.com/repos/NYPL/nypl-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL/nypl-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL/nypl-core/teams","hooks_url":"https://api.github.com/repos/NYPL/nypl-core/hooks","issue_events_url":"https://api.github.com/repos/NYPL/nypl-core/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL/nypl-core/events","assignees_url":"https://api.github.com/repos/NYPL/nypl-core/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL/nypl-core/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL/nypl-core/tags","blobs_url":"https://api.github.com/repos/NYPL/nypl-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL/nypl-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL/nypl-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL/nypl-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL/nypl-core/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL/nypl-core/languages","stargazers_url":"https://api.github.com/repos/NYPL/nypl-core/stargazers","contributors_url":"https://api.github.com/repos/NYPL/nypl-core/contributors","subscribers_url":"https://api.github.com/repos/NYPL/nypl-core/subscribers","subscription_url":"https://api.github.com/repos/NYPL/nypl-core/subscription","commits_url":"https://api.github.com/repos/NYPL/nypl-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL/nypl-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL/nypl-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL/nypl-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL/nypl-core/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL/nypl-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL/nypl-core/merges","archive_url":"https://api.github.com/repos/NYPL/nypl-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL/nypl-core/downloads","issues_url":"https://api.github.com/repos/NYPL/nypl-core/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL/nypl-core/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL/nypl-core/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL/nypl-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL/nypl-core/labels{/name}","releases_url":"https://api.github.com/repos/NYPL/nypl-core/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL/nypl-core/deployments","created_at":"2017-06-23T17:11:07Z","updated_at":"2017-06-27T16:02:23Z","pushed_at":"2018-02-12T16:46:41Z","git_url":"git://github.com/NYPL/nypl-core.git","ssh_url":"git@github.com:NYPL/nypl-core.git","clone_url":"https://github.com/NYPL/nypl-core.git","svn_url":"https://github.com/NYPL/nypl-core","homepage":null,"size":637,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"NYPL:master","ref":"master","sha":"bc986270b7d4c6660df2811077427ac439484661","user":{"login":"NYPL","id":944604,"avatar_url":"https://avatars1.githubusercontent.com/u/944604?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL","html_url":"https://github.com/NYPL","followers_url":"https://api.github.com/users/NYPL/followers","following_url":"https://api.github.com/users/NYPL/following{/other_user}","gists_url":"https://api.github.com/users/NYPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL/subscriptions","organizations_url":"https://api.github.com/users/NYPL/orgs","repos_url":"https://api.github.com/users/NYPL/repos","events_url":"https://api.github.com/users/NYPL/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL/received_events","type":"Organization","site_admin":false},"repo":{"id":95240515,"name":"nypl-core","full_name":"NYPL/nypl-core","owner":{"login":"NYPL","id":944604,"avatar_url":"https://avatars1.githubusercontent.com/u/944604?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL","html_url":"https://github.com/NYPL","followers_url":"https://api.github.com/users/NYPL/followers","following_url":"https://api.github.com/users/NYPL/following{/other_user}","gists_url":"https://api.github.com/users/NYPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL/subscriptions","organizations_url":"https://api.github.com/users/NYPL/orgs","repos_url":"https://api.github.com/users/NYPL/repos","events_url":"https://api.github.com/users/NYPL/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL/nypl-core","description":"Data models, mappings, and vocabularies for NYPL Core ontology","fork":false,"url":"https://api.github.com/repos/NYPL/nypl-core","forks_url":"https://api.github.com/repos/NYPL/nypl-core/forks","keys_url":"https://api.github.com/repos/NYPL/nypl-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL/nypl-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL/nypl-core/teams","hooks_url":"https://api.github.com/repos/NYPL/nypl-core/hooks","issue_events_url":"https://api.github.com/repos/NYPL/nypl-core/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL/nypl-core/events","assignees_url":"https://api.github.com/repos/NYPL/nypl-core/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL/nypl-core/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL/nypl-core/tags","blobs_url":"https://api.github.com/repos/NYPL/nypl-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL/nypl-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL/nypl-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL/nypl-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL/nypl-core/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL/nypl-core/languages","stargazers_url":"https://api.github.com/repos/NYPL/nypl-core/stargazers","contributors_url":"https://api.github.com/repos/NYPL/nypl-core/contributors","subscribers_url":"https://api.github.com/repos/NYPL/nypl-core/subscribers","subscription_url":"https://api.github.com/repos/NYPL/nypl-core/subscription","commits_url":"https://api.github.com/repos/NYPL/nypl-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL/nypl-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL/nypl-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL/nypl-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL/nypl-core/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL/nypl-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL/nypl-core/merges","archive_url":"https://api.github.com/repos/NYPL/nypl-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL/nypl-core/downloads","issues_url":"https://api.github.com/repos/NYPL/nypl-core/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL/nypl-core/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL/nypl-core/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL/nypl-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL/nypl-core/labels{/name}","releases_url":"https://api.github.com/repos/NYPL/nypl-core/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL/nypl-core/deployments","created_at":"2017-06-23T17:11:07Z","updated_at":"2017-06-27T16:02:23Z","pushed_at":"2018-02-12T16:46:41Z","git_url":"git://github.com/NYPL/nypl-core.git","ssh_url":"git@github.com:NYPL/nypl-core.git","clone_url":"https://github.com/NYPL/nypl-core.git","svn_url":"https://github.com/NYPL/nypl-core","homepage":null,"size":637,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NYPL/nypl-core/pulls/14"},"html":{"href":"https://github.com/NYPL/nypl-core/pull/14"},"issue":{"href":"https://api.github.com/repos/NYPL/nypl-core/issues/14"},"comments":{"href":"https://api.github.com/repos/NYPL/nypl-core/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/NYPL/nypl-core/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/NYPL/nypl-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NYPL/nypl-core/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/NYPL/nypl-core/statuses/93b19653a5956d24dfbb184751961f016f572a42"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"saverkamp"}}