{"action":"created","comment":{"url":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/comments/171661245","pull_request_review_id":100554532,"id":171661245,"diff_hunk":"@@ -232,11 +230,11 @@ public AccessJwtCreator setIsNoneAlgorithmAllowed(boolean isNoneAlgorithmAllowed\n      * @throws JWTCreationException     if the claims could not be converted to a valid JSON or there was a problem with the signing key.\n      */\n     public String sign(Algorithm algorithm) throws Exception {\n-        if(!jwt.getIsNoneAlgorithmAllowed() && algorithm.equals(Algorithm.none())) {\n+        if(!jwt.getIsNoneAlgorithmAllowed() && Algorithm.none().equals(algorithm)) {\n             throw new IllegalAccessException(\"None algorithm isn't allowed\");\n         }\n-        String JWS = jwt.sign(algorithm);\n         verifyClaims();\n+        String JWS = jwt.sign(algorithm);","path":"lib/src/main/java/com/auth0/jwt/creators/AccessJwtCreator.java","position":138,"original_position":138,"commit_id":"6763f1513789234edd84e421e7c568b729409404","original_commit_id":"6763f1513789234edd84e421e7c568b729409404","user":{"login":"jdahmubed","id":8576022,"avatar_url":"https://avatars3.githubusercontent.com/u/8576022?v=4","gravatar_id":"","url":"https://api.github.com/users/jdahmubed","html_url":"https://github.com/jdahmubed","followers_url":"https://api.github.com/users/jdahmubed/followers","following_url":"https://api.github.com/users/jdahmubed/following{/other_user}","gists_url":"https://api.github.com/users/jdahmubed/gists{/gist_id}","starred_url":"https://api.github.com/users/jdahmubed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdahmubed/subscriptions","organizations_url":"https://api.github.com/users/jdahmubed/orgs","repos_url":"https://api.github.com/users/jdahmubed/repos","events_url":"https://api.github.com/users/jdahmubed/events{/privacy}","received_events_url":"https://api.github.com/users/jdahmubed/received_events","type":"User","site_admin":false},"body":"that could lead to user error.  i think this way is better.","created_at":"2018-03-01T19:06:50Z","updated_at":"2018-03-01T19:06:50Z","html_url":"https://github.com/GJWT/javaOIDCMsg/pull/7#discussion_r171661245","pull_request_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/7","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/comments/171661245"},"html":{"href":"https://github.com/GJWT/javaOIDCMsg/pull/7#discussion_r171661245"},"pull_request":{"href":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/7"}},"in_reply_to_id":161542754},"pull_request":{"url":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/7","id":159536437,"html_url":"https://github.com/GJWT/javaOIDCMsg/pull/7","diff_url":"https://github.com/GJWT/javaOIDCMsg/pull/7.diff","patch_url":"https://github.com/GJWT/javaOIDCMsg/pull/7.patch","issue_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/issues/7","number":7,"state":"open","locked":false,"title":"X509","user":{"login":"jdahmubed","id":8576022,"avatar_url":"https://avatars3.githubusercontent.com/u/8576022?v=4","gravatar_id":"","url":"https://api.github.com/users/jdahmubed","html_url":"https://github.com/jdahmubed","followers_url":"https://api.github.com/users/jdahmubed/followers","following_url":"https://api.github.com/users/jdahmubed/following{/other_user}","gists_url":"https://api.github.com/users/jdahmubed/gists{/gist_id}","starred_url":"https://api.github.com/users/jdahmubed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdahmubed/subscriptions","organizations_url":"https://api.github.com/users/jdahmubed/orgs","repos_url":"https://api.github.com/users/jdahmubed/repos","events_url":"https://api.github.com/users/jdahmubed/events{/privacy}","received_events_url":"https://api.github.com/users/jdahmubed/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-20T22:49:46Z","updated_at":"2018-03-01T19:06:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"603a8e058f54cd2823843c8a4ba20f92d8296e89","assignee":null,"assignees":[],"requested_reviewers":[{"login":"TMSCH","id":2036827,"avatar_url":"https://avatars0.githubusercontent.com/u/2036827?v=4","gravatar_id":"","url":"https://api.github.com/users/TMSCH","html_url":"https://github.com/TMSCH","followers_url":"https://api.github.com/users/TMSCH/followers","following_url":"https://api.github.com/users/TMSCH/following{/other_user}","gists_url":"https://api.github.com/users/TMSCH/gists{/gist_id}","starred_url":"https://api.github.com/users/TMSCH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TMSCH/subscriptions","organizations_url":"https://api.github.com/users/TMSCH/orgs","repos_url":"https://api.github.com/users/TMSCH/repos","events_url":"https://api.github.com/users/TMSCH/events{/privacy}","received_events_url":"https://api.github.com/users/TMSCH/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/7/commits","review_comments_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/7/comments","review_comment_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/issues/7/comments","statuses_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/statuses/6763f1513789234edd84e421e7c568b729409404","head":{"label":"GJWT:x509","ref":"x509","sha":"6763f1513789234edd84e421e7c568b729409404","user":{"login":"GJWT","id":34324829,"avatar_url":"https://avatars0.githubusercontent.com/u/34324829?v=4","gravatar_id":"","url":"https://api.github.com/users/GJWT","html_url":"https://github.com/GJWT","followers_url":"https://api.github.com/users/GJWT/followers","following_url":"https://api.github.com/users/GJWT/following{/other_user}","gists_url":"https://api.github.com/users/GJWT/gists{/gist_id}","starred_url":"https://api.github.com/users/GJWT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GJWT/subscriptions","organizations_url":"https://api.github.com/users/GJWT/orgs","repos_url":"https://api.github.com/users/GJWT/repos","events_url":"https://api.github.com/users/GJWT/events{/privacy}","received_events_url":"https://api.github.com/users/GJWT/received_events","type":"Organization","site_admin":false},"repo":{"id":111128179,"name":"javaOIDCMsg","full_name":"GJWT/javaOIDCMsg","owner":{"login":"GJWT","id":34324829,"avatar_url":"https://avatars0.githubusercontent.com/u/34324829?v=4","gravatar_id":"","url":"https://api.github.com/users/GJWT","html_url":"https://github.com/GJWT","followers_url":"https://api.github.com/users/GJWT/followers","following_url":"https://api.github.com/users/GJWT/following{/other_user}","gists_url":"https://api.github.com/users/GJWT/gists{/gist_id}","starred_url":"https://api.github.com/users/GJWT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GJWT/subscriptions","organizations_url":"https://api.github.com/users/GJWT/orgs","repos_url":"https://api.github.com/users/GJWT/repos","events_url":"https://api.github.com/users/GJWT/events{/privacy}","received_events_url":"https://api.github.com/users/GJWT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GJWT/javaOIDCMsg","description":"JWTs for Java","fork":false,"url":"https://api.github.com/repos/GJWT/javaOIDCMsg","forks_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/forks","keys_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/teams","hooks_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/hooks","issue_events_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/issues/events{/number}","events_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/events","assignees_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/assignees{/user}","branches_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/branches{/branch}","tags_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/tags","blobs_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/git/refs{/sha}","trees_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/statuses/{sha}","languages_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/languages","stargazers_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/stargazers","contributors_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/contributors","subscribers_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/subscribers","subscription_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/subscription","commits_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/commits{/sha}","git_commits_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/git/commits{/sha}","comments_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/comments{/number}","issue_comment_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/issues/comments{/number}","contents_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/contents/{+path}","compare_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/merges","archive_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/downloads","issues_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/issues{/number}","pulls_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls{/number}","milestones_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/milestones{/number}","notifications_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/labels{/name}","releases_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/releases{/id}","deployments_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/deployments","created_at":"2017-11-17T16:52:05Z","updated_at":"2017-12-11T18:56:24Z","pushed_at":"2018-02-28T19:45:24Z","git_url":"git://github.com/GJWT/javaOIDCMsg.git","ssh_url":"git@github.com:GJWT/javaOIDCMsg.git","clone_url":"https://github.com/GJWT/javaOIDCMsg.git","svn_url":"https://github.com/GJWT/javaOIDCMsg","homepage":"","size":891,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":12,"watchers":1,"default_branch":"master"}},"base":{"label":"GJWT:master","ref":"master","sha":"cbdf7aa5be7896a7958e55b2ac2dda0a0956adda","user":{"login":"GJWT","id":34324829,"avatar_url":"https://avatars0.githubusercontent.com/u/34324829?v=4","gravatar_id":"","url":"https://api.github.com/users/GJWT","html_url":"https://github.com/GJWT","followers_url":"https://api.github.com/users/GJWT/followers","following_url":"https://api.github.com/users/GJWT/following{/other_user}","gists_url":"https://api.github.com/users/GJWT/gists{/gist_id}","starred_url":"https://api.github.com/users/GJWT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GJWT/subscriptions","organizations_url":"https://api.github.com/users/GJWT/orgs","repos_url":"https://api.github.com/users/GJWT/repos","events_url":"https://api.github.com/users/GJWT/events{/privacy}","received_events_url":"https://api.github.com/users/GJWT/received_events","type":"Organization","site_admin":false},"repo":{"id":111128179,"name":"javaOIDCMsg","full_name":"GJWT/javaOIDCMsg","owner":{"login":"GJWT","id":34324829,"avatar_url":"https://avatars0.githubusercontent.com/u/34324829?v=4","gravatar_id":"","url":"https://api.github.com/users/GJWT","html_url":"https://github.com/GJWT","followers_url":"https://api.github.com/users/GJWT/followers","following_url":"https://api.github.com/users/GJWT/following{/other_user}","gists_url":"https://api.github.com/users/GJWT/gists{/gist_id}","starred_url":"https://api.github.com/users/GJWT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GJWT/subscriptions","organizations_url":"https://api.github.com/users/GJWT/orgs","repos_url":"https://api.github.com/users/GJWT/repos","events_url":"https://api.github.com/users/GJWT/events{/privacy}","received_events_url":"https://api.github.com/users/GJWT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GJWT/javaOIDCMsg","description":"JWTs for Java","fork":false,"url":"https://api.github.com/repos/GJWT/javaOIDCMsg","forks_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/forks","keys_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/teams","hooks_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/hooks","issue_events_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/issues/events{/number}","events_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/events","assignees_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/assignees{/user}","branches_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/branches{/branch}","tags_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/tags","blobs_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/git/refs{/sha}","trees_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/statuses/{sha}","languages_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/languages","stargazers_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/stargazers","contributors_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/contributors","subscribers_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/subscribers","subscription_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/subscription","commits_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/commits{/sha}","git_commits_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/git/commits{/sha}","comments_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/comments{/number}","issue_comment_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/issues/comments{/number}","contents_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/contents/{+path}","compare_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/merges","archive_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/downloads","issues_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/issues{/number}","pulls_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls{/number}","milestones_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/milestones{/number}","notifications_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/labels{/name}","releases_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/releases{/id}","deployments_url":"https://api.github.com/repos/GJWT/javaOIDCMsg/deployments","created_at":"2017-11-17T16:52:05Z","updated_at":"2017-12-11T18:56:24Z","pushed_at":"2018-02-28T19:45:24Z","git_url":"git://github.com/GJWT/javaOIDCMsg.git","ssh_url":"git@github.com:GJWT/javaOIDCMsg.git","clone_url":"https://github.com/GJWT/javaOIDCMsg.git","svn_url":"https://github.com/GJWT/javaOIDCMsg","homepage":"","size":891,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":12,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/7"},"html":{"href":"https://github.com/GJWT/javaOIDCMsg/pull/7"},"issue":{"href":"https://api.github.com/repos/GJWT/javaOIDCMsg/issues/7"},"comments":{"href":"https://api.github.com/repos/GJWT/javaOIDCMsg/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GJWT/javaOIDCMsg/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/GJWT/javaOIDCMsg/statuses/6763f1513789234edd84e421e7c568b729409404"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jdahmubed"}}