{"action":"created","comment":{"url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments/242829749","pull_request_review_id":186434796,"id":242829749,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjgyOTc0OQ==","diff_hunk":"@@ -315,7 +315,7 @@ GEM\n       activesupport (>= 3.0)\n       i18n\n       polyamorous (~> 1.3.2)\n-    redis (4.0.1)\n+    redis (3.3.5)","path":"Gemfile.lock","position":5,"original_position":5,"commit_id":"1dbd202c7313eac32da4d7ed433c8ca7b4eda587","original_commit_id":"1dbd202c7313eac32da4d7ed433c8ca7b4eda587","user":{"login":"your","id":9043263,"node_id":"MDQ6VXNlcjkwNDMyNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/9043263?v=4","gravatar_id":"","url":"https://api.github.com/users/your","html_url":"https://github.com/your","followers_url":"https://api.github.com/users/your/followers","following_url":"https://api.github.com/users/your/following{/other_user}","gists_url":"https://api.github.com/users/your/gists{/gist_id}","starred_url":"https://api.github.com/users/your/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/your/subscriptions","organizations_url":"https://api.github.com/users/your/orgs","repos_url":"https://api.github.com/users/your/repos","events_url":"https://api.github.com/users/your/events{/privacy}","received_events_url":"https://api.github.com/users/your/received_events","type":"User","site_admin":false},"body":"@MarcoBgn Because it's a dependency of a dependency, that's not what you should use the `Gemfile` for. And in my experience when you do that, it's going to stay in the `Gemfile` for no reason for ever.","created_at":"2018-12-19T08:41:38Z","updated_at":"2018-12-19T08:41:38Z","html_url":"https://github.com/moneyadviceservice/rad/pull/430#discussion_r242829749","pull_request_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/430","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments/242829749"},"html":{"href":"https://github.com/moneyadviceservice/rad/pull/430#discussion_r242829749"},"pull_request":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/430"}},"in_reply_to_id":242828711},"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/430","id":239746060,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NzQ2MDYw","html_url":"https://github.com/moneyadviceservice/rad/pull/430","diff_url":"https://github.com/moneyadviceservice/rad/pull/430.diff","patch_url":"https://github.com/moneyadviceservice/rad/pull/430.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/430","number":430,"state":"open","locked":false,"title":"Downgrade `redis` to 3.3.5","user":{"login":"your","id":9043263,"node_id":"MDQ6VXNlcjkwNDMyNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/9043263?v=4","gravatar_id":"","url":"https://api.github.com/users/your","html_url":"https://github.com/your","followers_url":"https://api.github.com/users/your/followers","following_url":"https://api.github.com/users/your/following{/other_user}","gists_url":"https://api.github.com/users/your/gists{/gist_id}","starred_url":"https://api.github.com/users/your/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/your/subscriptions","organizations_url":"https://api.github.com/users/your/orgs","repos_url":"https://api.github.com/users/your/repos","events_url":"https://api.github.com/users/your/events{/privacy}","received_events_url":"https://api.github.com/users/your/received_events","type":"User","site_admin":false},"body":"[TP 10053](https://moneyadviceservice.tpondemand.com/entity/10053-rad-sidekiq-web-500)\r\n\r\nAs the title says, this PR downgrades `redis`, which was bumped to 4.0.1 with #418, as a \"loose\" dependency from `sidekiq` [here](https://github.com/mperham/sidekiq/blob/v3.3.4/sidekiq.gemspec#L17).\r\n\r\n**This allows the sidekiq web interface to be rendered properly instead of returning 500.**\r\n\r\n### More details\r\nWhen used with `sidekiq` 3.x, any `redis` 4.x version seems to be causing the following:\r\nhttps://github.com/antirez/redis/issues/4272\r\n\r\n```\r\nRedis::CommandError - ERR Syntax error, try CLIENT (LIST | KILL | GETNAME | SETNAME | PAUSE | REPLY):\r\n```\r\n\r\nWorth mentioning that the latest `sidekiq` 3.x added a tighter lock [here](https://github.com/mperham/sidekiq/blob/d547c2a8fc66ff3f973d69336ad15a4ebc13d159/sidekiq.gemspec#L18), but I am not willing to bump `sidekiq` at the moment.  ","created_at":"2018-12-19T08:15:11Z","updated_at":"2018-12-19T08:41:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"177d54068db7817329f43313e5a527ee46838bcd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"osharpe","id":30631572,"node_id":"MDQ6VXNlcjMwNjMxNTcy","avatar_url":"https://avatars3.githubusercontent.com/u/30631572?v=4","gravatar_id":"","url":"https://api.github.com/users/osharpe","html_url":"https://github.com/osharpe","followers_url":"https://api.github.com/users/osharpe/followers","following_url":"https://api.github.com/users/osharpe/following{/other_user}","gists_url":"https://api.github.com/users/osharpe/gists{/gist_id}","starred_url":"https://api.github.com/users/osharpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osharpe/subscriptions","organizations_url":"https://api.github.com/users/osharpe/orgs","repos_url":"https://api.github.com/users/osharpe/repos","events_url":"https://api.github.com/users/osharpe/events{/privacy}","received_events_url":"https://api.github.com/users/osharpe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/430/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/430/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/430/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/rad/statuses/1dbd202c7313eac32da4d7ed433c8ca7b4eda587","head":{"label":"moneyadviceservice:10053_sidekiq-web-500","ref":"10053_sidekiq-web-500","sha":"1dbd202c7313eac32da4d7ed433c8ca7b4eda587","user":{"login":"moneyadviceservice","id":2064781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQ3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":26871523,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg3MTUyMw==","name":"rad","full_name":"moneyadviceservice/rad","private":false,"owner":{"login":"moneyadviceservice","id":2064781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQ3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/moneyadviceservice/rad","description":"Retirement Adviser Directory","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/rad","forks_url":"https://api.github.com/repos/moneyadviceservice/rad/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/rad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/rad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/rad/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/rad/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/rad/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/rad/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/rad/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/rad/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/rad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/rad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/rad/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/rad/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/rad/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/rad/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/rad/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/rad/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/rad/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/rad/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/rad/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/rad/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/rad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/rad/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/rad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/rad/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/rad/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/rad/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/rad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/rad/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/rad/releases{/id}","deployments_url":"https://api.github.com/repos/moneyadviceservice/rad/deployments","created_at":"2014-11-19T16:55:48Z","updated_at":"2018-03-28T09:08:48Z","pushed_at":"2018-12-19T08:16:16Z","git_url":"git://github.com/moneyadviceservice/rad.git","ssh_url":"git@github.com:moneyadviceservice/rad.git","clone_url":"https://github.com/moneyadviceservice/rad.git","svn_url":"https://github.com/moneyadviceservice/rad","homepage":"","size":2475,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"moneyadviceservice:master","ref":"master","sha":"587ec5a3db3aefba201cdfd87ed5637f3d345bc3","user":{"login":"moneyadviceservice","id":2064781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQ3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":26871523,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg3MTUyMw==","name":"rad","full_name":"moneyadviceservice/rad","private":false,"owner":{"login":"moneyadviceservice","id":2064781,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQ3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/moneyadviceservice/rad","description":"Retirement Adviser Directory","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/rad","forks_url":"https://api.github.com/repos/moneyadviceservice/rad/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/rad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/rad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/rad/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/rad/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/rad/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/rad/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/rad/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/rad/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/rad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/rad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/rad/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/rad/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/rad/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/rad/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/rad/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/rad/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/rad/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/rad/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/rad/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/rad/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/rad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/rad/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/rad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/rad/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/rad/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/rad/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/rad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/rad/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/rad/releases{/id}","deployments_url":"https://api.github.com/repos/moneyadviceservice/rad/deployments","created_at":"2014-11-19T16:55:48Z","updated_at":"2018-03-28T09:08:48Z","pushed_at":"2018-12-19T08:16:16Z","git_url":"git://github.com/moneyadviceservice/rad.git","ssh_url":"git@github.com:moneyadviceservice/rad.git","clone_url":"https://github.com/moneyadviceservice/rad.git","svn_url":"https://github.com/moneyadviceservice/rad","homepage":"","size":2475,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/430"},"html":{"href":"https://github.com/moneyadviceservice/rad/pull/430"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/rad/issues/430"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/rad/issues/430/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/430/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/430/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/rad/statuses/1dbd202c7313eac32da4d7ed433c8ca7b4eda587"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"your"}}