{"action":"created","comment":{"url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments/221673157","pull_request_review_id":160379381,"id":221673157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTY3MzE1Nw==","diff_hunk":"@@ -2,11 +2,28 @@\n //  Copyright (c) 2018 Open Whisper Systems. All rights reserved.\n //\n \n+#import \"OWSError.h\"\n+\n NS_ASSUME_NONNULL_BEGIN\n \n+typedef NS_ENUM(NSUInteger, CDSSigningCertificateErrorCode) {","path":"SignalServiceKit/src/Contacts/CDSSigningCertificate.h","position":4,"original_position":8,"commit_id":"90201b70c1024a6899e2cd8e13738b2f65df3ffd","original_commit_id":"fd0535c41bd0b3faefd17bcffadb829130740f1e","user":{"login":"charlesmchen-signal","id":36971147,"node_id":"MDQ6VXNlcjM2OTcxMTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/36971147?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesmchen-signal","html_url":"https://github.com/charlesmchen-signal","followers_url":"https://api.github.com/users/charlesmchen-signal/followers","following_url":"https://api.github.com/users/charlesmchen-signal/following{/other_user}","gists_url":"https://api.github.com/users/charlesmchen-signal/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesmchen-signal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesmchen-signal/subscriptions","organizations_url":"https://api.github.com/users/charlesmchen-signal/orgs","repos_url":"https://api.github.com/users/charlesmchen-signal/repos","events_url":"https://api.github.com/users/charlesmchen-signal/events{/privacy}","received_events_url":"https://api.github.com/users/charlesmchen-signal/received_events","type":"User","site_admin":false},"body":"That seems reasonable.","created_at":"2018-10-01T16:28:16Z","updated_at":"2018-10-01T16:28:16Z","html_url":"https://github.com/signalapp/Signal-iOS/pull/3930#discussion_r221673157","pull_request_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3930","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments/221673157"},"html":{"href":"https://github.com/signalapp/Signal-iOS/pull/3930#discussion_r221673157"},"pull_request":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3930"}},"in_reply_to_id":221654936},"pull_request":{"url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3930","id":219388982,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5Mzg4OTgy","html_url":"https://github.com/signalapp/Signal-iOS/pull/3930","diff_url":"https://github.com/signalapp/Signal-iOS/pull/3930.diff","patch_url":"https://github.com/signalapp/Signal-iOS/pull/3930.patch","issue_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3930","number":3930,"state":"open","locked":false,"title":"fixup some tests","user":{"login":"michaelkirk-signal","id":36971200,"node_id":"MDQ6VXNlcjM2OTcxMjAw","avatar_url":"https://avatars3.githubusercontent.com/u/36971200?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkirk-signal","html_url":"https://github.com/michaelkirk-signal","followers_url":"https://api.github.com/users/michaelkirk-signal/followers","following_url":"https://api.github.com/users/michaelkirk-signal/following{/other_user}","gists_url":"https://api.github.com/users/michaelkirk-signal/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkirk-signal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkirk-signal/subscriptions","organizations_url":"https://api.github.com/users/michaelkirk-signal/orgs","repos_url":"https://api.github.com/users/michaelkirk-signal/repos","events_url":"https://api.github.com/users/michaelkirk-signal/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkirk-signal/received_events","type":"User","site_admin":false},"body":"PTAL @charlesmchen-signal ","created_at":"2018-10-01T14:06:37Z","updated_at":"2018-10-01T16:28:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"550db18feeaeb89aa857f6479e9cd25235fbd930","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3930/commits","review_comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3930/comments","review_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3930/comments","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/90201b70c1024a6899e2cd8e13738b2f65df3ffd","head":{"label":"signalapp:mkirk/fix-tests","ref":"mkirk/fix-tests","sha":"90201b70c1024a6899e2cd8e13738b2f65df3ffd","user":{"login":"signalapp","id":702459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMjQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQyOTY5OA==","name":"Signal-iOS","full_name":"signalapp/Signal-iOS","private":false,"owner":{"login":"signalapp","id":702459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMjQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/signalapp/Signal-iOS","description":"A private messenger for iOS.","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-iOS","forks_url":"https://api.github.com/repos/signalapp/Signal-iOS/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-iOS/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-iOS/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2018-09-30T13:19:50Z","pushed_at":"2018-10-01T15:44:19Z","git_url":"git://github.com/signalapp/Signal-iOS.git","ssh_url":"git@github.com:signalapp/Signal-iOS.git","clone_url":"https://github.com/signalapp/Signal-iOS.git","svn_url":"https://github.com/signalapp/Signal-iOS","homepage":"https://signal.org","size":490499,"stargazers_count":3673,"watchers_count":3673,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":893,"mirror_url":null,"archived":false,"open_issues_count":406,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":893,"open_issues":406,"watchers":3673,"default_branch":"master"}},"base":{"label":"signalapp:master","ref":"master","sha":"f0f25aa41398868e5a85a173101fdb4635550cfe","user":{"login":"signalapp","id":702459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMjQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQyOTY5OA==","name":"Signal-iOS","full_name":"signalapp/Signal-iOS","private":false,"owner":{"login":"signalapp","id":702459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMjQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/signalapp/Signal-iOS","description":"A private messenger for iOS.","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-iOS","forks_url":"https://api.github.com/repos/signalapp/Signal-iOS/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-iOS/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-iOS/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2018-09-30T13:19:50Z","pushed_at":"2018-10-01T15:44:19Z","git_url":"git://github.com/signalapp/Signal-iOS.git","ssh_url":"git@github.com:signalapp/Signal-iOS.git","clone_url":"https://github.com/signalapp/Signal-iOS.git","svn_url":"https://github.com/signalapp/Signal-iOS","homepage":"https://signal.org","size":490499,"stargazers_count":3673,"watchers_count":3673,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":893,"mirror_url":null,"archived":false,"open_issues_count":406,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":893,"open_issues":406,"watchers":3673,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3930"},"html":{"href":"https://github.com/signalapp/Signal-iOS/pull/3930"},"issue":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3930"},"comments":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3930/comments"},"review_comments":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3930/comments"},"review_comment":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3930/commits"},"statuses":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/90201b70c1024a6899e2cd8e13738b2f65df3ffd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"charlesmchen-signal"}}