{"action":"created","issue":{"url":"https://api.github.com/repos/OpenZeppelin/zeppelin-solidity/issues/803","repository_url":"https://api.github.com/repos/OpenZeppelin/zeppelin-solidity","labels_url":"https://api.github.com/repos/OpenZeppelin/zeppelin-solidity/issues/803/labels{/name}","comments_url":"https://api.github.com/repos/OpenZeppelin/zeppelin-solidity/issues/803/comments","events_url":"https://api.github.com/repos/OpenZeppelin/zeppelin-solidity/issues/803/events","html_url":"https://github.com/OpenZeppelin/zeppelin-solidity/pull/803","id":303302702,"number":803,"title":"ERC721 full implementation","user":{"login":"spalladino","id":429604,"avatar_url":"https://avatars2.githubusercontent.com/u/429604?v=4","gravatar_id":"","url":"https://api.github.com/users/spalladino","html_url":"https://github.com/spalladino","followers_url":"https://api.github.com/users/spalladino/followers","following_url":"https://api.github.com/users/spalladino/following{/other_user}","gists_url":"https://api.github.com/users/spalladino/gists{/gist_id}","starred_url":"https://api.github.com/users/spalladino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalladino/subscriptions","organizations_url":"https://api.github.com/users/spalladino/orgs","repos_url":"https://api.github.com/users/spalladino/repos","events_url":"https://api.github.com/users/spalladino/events{/privacy}","received_events_url":"https://api.github.com/users/spalladino/received_events","type":"User","site_admin":false},"labels":[{"id":793179772,"url":"https://api.github.com/repos/OpenZeppelin/zeppelin-solidity/labels/review","name":"review","color":"FF00FF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-03-07T23:45:29Z","updated_at":"2018-03-16T14:06:52Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/OpenZeppelin/zeppelin-solidity/pulls/803","html_url":"https://github.com/OpenZeppelin/zeppelin-solidity/pull/803","diff_url":"https://github.com/OpenZeppelin/zeppelin-solidity/pull/803.diff","patch_url":"https://github.com/OpenZeppelin/zeppelin-solidity/pull/803.patch"},"body":"Fixes #640 \r\nFixes #809 \r\n\r\nContinues the work of @facuspagnuolo in #682 \r\n\r\nCurrent status:\r\n- ERC721 implementation is complete\r\n\r\nPending discussions:\r\n- `exists` was added to the interface here, though will not be part of the standard\r\n- The 50K gas stipend for the `onERC721Received` call was removed (see [here](https://gitter.im/ETH-NFT/Lobby?at=5aa17c66458cbde5570faecd))\r\n"},"comment":{"url":"https://api.github.com/repos/OpenZeppelin/zeppelin-solidity/issues/comments/373723719","html_url":"https://github.com/OpenZeppelin/zeppelin-solidity/pull/803#issuecomment-373723719","issue_url":"https://api.github.com/repos/OpenZeppelin/zeppelin-solidity/issues/803","id":373723719,"user":{"login":"spalladino","id":429604,"avatar_url":"https://avatars2.githubusercontent.com/u/429604?v=4","gravatar_id":"","url":"https://api.github.com/users/spalladino","html_url":"https://github.com/spalladino","followers_url":"https://api.github.com/users/spalladino/followers","following_url":"https://api.github.com/users/spalladino/following{/other_user}","gists_url":"https://api.github.com/users/spalladino/gists{/gist_id}","starred_url":"https://api.github.com/users/spalladino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalladino/subscriptions","organizations_url":"https://api.github.com/users/spalladino/orgs","repos_url":"https://api.github.com/users/spalladino/repos","events_url":"https://api.github.com/users/spalladino/events{/privacy}","received_events_url":"https://api.github.com/users/spalladino/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T14:06:52Z","updated_at":"2018-03-16T14:06:52Z","author_association":"OWNER","body":"> Why does the implementation define name_ and symbol_ as internal and then explicitly make name and symbol getter functions? Why not just declare name and symbol as public? Just want to understand the reasoning for this. Is there a reason for this or is it just a style choice?\r\n\r\n@mudgen because Solidity does not support overriding an autogenerated public getter. If, for some reason, you want to override the name/symbol getters to return some calculated value, you wouldn't be able to do so. Name and symbol may not be the best examples, but we did notice some folks were [struggling with totalSupply in ERC20](https://github.com/OpenZeppelin/zeppelin-solidity/issues/434) for instance."}}
{"actor":{"display_login":"spalladino"}}