{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/339","repository_url":"https://api.github.com/repos/mozilla-mobile/android-components","labels_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/339/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/339/comments","events_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/339/events","html_url":"https://github.com/mozilla-mobile/android-components/pull/339","id":336327180,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODA2Mzc5","number":339,"title":"Closes #263 #324: Add FxA service component and sample app","user":{"login":"csadilek","id":472523,"node_id":"MDQ6VXNlcjQ3MjUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/472523?v=4","gravatar_id":"","url":"https://api.github.com/users/csadilek","html_url":"https://github.com/csadilek","followers_url":"https://api.github.com/users/csadilek/followers","following_url":"https://api.github.com/users/csadilek/following{/other_user}","gists_url":"https://api.github.com/users/csadilek/gists{/gist_id}","starred_url":"https://api.github.com/users/csadilek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csadilek/subscriptions","organizations_url":"https://api.github.com/users/csadilek/orgs","repos_url":"https://api.github.com/users/csadilek/repos","events_url":"https://api.github.com/users/csadilek/events{/privacy}","received_events_url":"https://api.github.com/users/csadilek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-27T17:47:43Z","updated_at":"2018-06-29T11:59:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/339","html_url":"https://github.com/mozilla-mobile/android-components/pull/339","diff_url":"https://github.com/mozilla-mobile/android-components/pull/339.diff","patch_url":"https://github.com/mozilla-mobile/android-components/pull/339.patch"},"body":"This brings in the prototype of the service-fxa module (based on the fxa client rust lib) and a sample app that uses it. The sample app shows a login button, and after successful login, displays some FxA profile data. This is pretty much the same as the iOS version hosted at https://github.com/mozilla/application-services/tree/master/sandvich-ios.\r\n\r\n*This is just a prototype:* 🙃 There are many known issues and topics to discuss. I think we should bring this in so we can collaborate on it. I will file a bunch of issues for the known limitations and ToDos.\r\n\r\nIssues filed so far: https://github.com/mozilla-mobile/android-components/labels/%3CFxA%3E\r\n"},"comment":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/comments/401333237","html_url":"https://github.com/mozilla-mobile/android-components/pull/339#issuecomment-401333237","issue_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/339","id":401333237,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTMzMzIzNw==","user":{"login":"pocmo","id":89638,"node_id":"MDQ6VXNlcjg5NjM4","avatar_url":"https://avatars0.githubusercontent.com/u/89638?v=4","gravatar_id":"","url":"https://api.github.com/users/pocmo","html_url":"https://github.com/pocmo","followers_url":"https://api.github.com/users/pocmo/followers","following_url":"https://api.github.com/users/pocmo/following{/other_user}","gists_url":"https://api.github.com/users/pocmo/gists{/gist_id}","starred_url":"https://api.github.com/users/pocmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pocmo/subscriptions","organizations_url":"https://api.github.com/users/pocmo/orgs","repos_url":"https://api.github.com/users/pocmo/repos","events_url":"https://api.github.com/users/pocmo/events{/privacy}","received_events_url":"https://api.github.com/users/pocmo/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T11:59:27Z","updated_at":"2018-06-29T11:59:27Z","author_association":"COLLABORATOR","body":"> The Firefox account libs all have fxa in the name. I think we should go with what the team prefers here. Do you feel strongly about this? I also slightly prefer the shorter name.\r\n\r\nI think that's fine and I wouldn't want to rename any of that - especially because it's internal. I'm mostly concerned about this _here_ being a public framework to be consumed by external partners and we are forcing everyone to do the mental mapping of FxA -> Firefox Accounts - something that (only externally) is not really clear. I definitely won't block you from merging it as-is because of that. 😃 "}}
{"actor":{"display_login":"pocmo"}}