{"push_id":3021074722,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"da3ea59a25890b5992413e80c4260e4350129061","before":"236373b6ba92b9a3935958a367e88b05d4f54854","commits":[{"sha":"f2f18b4e16656f0eb0d6b41981baa991ade3d33c","author":{"name":"Berthold Stoeger","email":"7086f6c34b4b8467a528b8d50bf664f0c7bd1715@mail.tuwien.ac.at"},"message":"Dive list: split reload() in reload() and setSortOrder()\n\nThe DiveListView code had a very fundamental problem with its\nheader: Each had its own idea of who is responsible for sorting.\nSince we can't easily change QHeaderView, accept QHeaderView\nas the authority on sort-column and order.\n\nTo make this possible, split the reload() function in two\ndistinct functions:\n - reload() reloads the model and sorts according to the\n   current sort criterion.\n - setSortOrder() tells the header to display a certain\n   sort criterion. If this is a new criterion, it will then\n   emit a signal. In this signal, resort according to that\n   criterion.\n\nThus, the actual sorting code has to be moved from the\nheaderClicked() to a new sortIndicatorChanged() slot.\nMorover, the sorting of the QHeaderView has to be used.\n\nReported-by: Stefan Fuchs <sfuchs@gmx.de>\nSigned-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>","distinct":true,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits/f2f18b4e16656f0eb0d6b41981baa991ade3d33c"},{"sha":"64a1a50e10c4ec8432de9d7cc08921b1b5b490a5","author":{"name":"Berthold Stoeger","email":"7086f6c34b4b8467a528b8d50bf664f0c7bd1715@mail.tuwien.ac.at"},"message":"Dive list: remove sortColumn and currentOrder members\n\nSince the QHeaderView of DiveListView is now the authority\nover sort-column and sort-order, it makes little sense\nto keep these as member variables. That would only risk\ninconsistencies. Remove them and query the QHeaderView\ninstead.\n\nWe still need to keep track of currentLayout, as we\nhave to detect if it changes to change the underlying\nmodel from tree to list or vice-versa.\n\nSigned-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>","distinct":true,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits/64a1a50e10c4ec8432de9d7cc08921b1b5b490a5"},{"sha":"da3ea59a25890b5992413e80c4260e4350129061","author":{"name":"Berthold Stoeger","email":"7086f6c34b4b8467a528b8d50bf664f0c7bd1715@mail.tuwien.ac.at"},"message":"Dive list: let sort arrows reflect sort order for NR and DATE\n\nThe old code always sorted by \"ascending\" by default. But\nbecause users typically want their new dives top, \"ascending\"\nwas defined for NR and DATE, such that it is actually descending.\nTurn these around and intitialize these two fields as\ndefault-descending.\n\nThis is possible using the Qt::InitialSortOrderRole role\nin DiveTripModel::headerData().\n\nSigned-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>","distinct":true,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits/da3ea59a25890b5992413e80c4260e4350129061"}]}
{"actor":{"display_login":"dirkhh"}}