{"action":"closed","number":143,"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/143","id":224888272,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0ODg4Mjcy","html_url":"https://github.com/pingcap/tidb-operator/pull/143","diff_url":"https://github.com/pingcap/tidb-operator/pull/143.diff","patch_url":"https://github.com/pingcap/tidb-operator/pull/143.patch","issue_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/143","number":143,"state":"closed","locked":false,"title":"change monitor/backup/binlog pvc labels","user":{"login":"xiaojingchen","id":5999258,"node_id":"MDQ6VXNlcjU5OTkyNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5999258?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaojingchen","html_url":"https://github.com/xiaojingchen","followers_url":"https://api.github.com/users/xiaojingchen/followers","following_url":"https://api.github.com/users/xiaojingchen/following{/other_user}","gists_url":"https://api.github.com/users/xiaojingchen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaojingchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaojingchen/subscriptions","organizations_url":"https://api.github.com/users/xiaojingchen/orgs","repos_url":"https://api.github.com/users/xiaojingchen/repos","events_url":"https://api.github.com/users/xiaojingchen/events{/privacy}","received_events_url":"https://api.github.com/users/xiaojingchen/received_events","type":"User","site_admin":false},"body":"The current monitor / fullbackup / binlog pvc is not managed by tidb-operator, so the pv recovery policy of these pvc bindings is `Delete` by default. In this case, the data is not secure. \r\nWe need to add the label `app.kubernetes.io/managed-by:tidb-operator` to these pvcs, then the pv bound to the pvc recycling policy can be changed to `Retain` by tidb-operator","created_at":"2018-10-23T04:01:15Z","updated_at":"2018-10-25T14:18:07Z","closed_at":"2018-10-25T14:18:07Z","merged_at":"2018-10-25T14:18:07Z","merge_commit_sha":"fd73d27f86554ae294eec228f55cc988417e6bc0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/143/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/143/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/143/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb-operator/statuses/afa3108e032d54205548601f61d29d748707227f","head":{"label":"xiaojingchen:change-charts-pv-labels","ref":"change-charts-pv-labels","sha":"afa3108e032d54205548601f61d29d748707227f","user":{"login":"xiaojingchen","id":5999258,"node_id":"MDQ6VXNlcjU5OTkyNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5999258?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaojingchen","html_url":"https://github.com/xiaojingchen","followers_url":"https://api.github.com/users/xiaojingchen/followers","following_url":"https://api.github.com/users/xiaojingchen/following{/other_user}","gists_url":"https://api.github.com/users/xiaojingchen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaojingchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaojingchen/subscriptions","organizations_url":"https://api.github.com/users/xiaojingchen/orgs","repos_url":"https://api.github.com/users/xiaojingchen/repos","events_url":"https://api.github.com/users/xiaojingchen/events{/privacy}","received_events_url":"https://api.github.com/users/xiaojingchen/received_events","type":"User","site_admin":false},"repo":{"id":144798460,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3OTg0NjA=","name":"tidb-operator","full_name":"xiaojingchen/tidb-operator","private":false,"owner":{"login":"xiaojingchen","id":5999258,"node_id":"MDQ6VXNlcjU5OTkyNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5999258?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaojingchen","html_url":"https://github.com/xiaojingchen","followers_url":"https://api.github.com/users/xiaojingchen/followers","following_url":"https://api.github.com/users/xiaojingchen/following{/other_user}","gists_url":"https://api.github.com/users/xiaojingchen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaojingchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaojingchen/subscriptions","organizations_url":"https://api.github.com/users/xiaojingchen/orgs","repos_url":"https://api.github.com/users/xiaojingchen/repos","events_url":"https://api.github.com/users/xiaojingchen/events{/privacy}","received_events_url":"https://api.github.com/users/xiaojingchen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xiaojingchen/tidb-operator","description":"TiDB operator creates and manages TiDB clusters running in Kubernetes","fork":true,"url":"https://api.github.com/repos/xiaojingchen/tidb-operator","forks_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/forks","keys_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/teams","hooks_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/hooks","issue_events_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/issues/events{/number}","events_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/events","assignees_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/assignees{/user}","branches_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/branches{/branch}","tags_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/tags","blobs_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/languages","stargazers_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/stargazers","contributors_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/contributors","subscribers_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/subscribers","subscription_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/subscription","commits_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/contents/{+path}","compare_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/merges","archive_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/downloads","issues_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/issues{/number}","pulls_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/labels{/name}","releases_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/releases{/id}","deployments_url":"https://api.github.com/repos/xiaojingchen/tidb-operator/deployments","created_at":"2018-08-15T02:58:56Z","updated_at":"2018-08-17T11:17:45Z","pushed_at":"2018-10-25T14:17:54Z","git_url":"git://github.com/xiaojingchen/tidb-operator.git","ssh_url":"git@github.com:xiaojingchen/tidb-operator.git","clone_url":"https://github.com/xiaojingchen/tidb-operator.git","svn_url":"https://github.com/xiaojingchen/tidb-operator","homepage":"","size":48634,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"8289959733e6bb65020f1af7a89ac5570f571e32","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":143867478,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4Njc0Nzg=","name":"tidb-operator","full_name":"pingcap/tidb-operator","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb-operator","description":"TiDB operator creates and manages TiDB clusters running in Kubernetes","fork":false,"url":"https://api.github.com/repos/pingcap/tidb-operator","forks_url":"https://api.github.com/repos/pingcap/tidb-operator/forks","keys_url":"https://api.github.com/repos/pingcap/tidb-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb-operator/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb-operator/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb-operator/events","assignees_url":"https://api.github.com/repos/pingcap/tidb-operator/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb-operator/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb-operator/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb-operator/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb-operator/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb-operator/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb-operator/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb-operator/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb-operator/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb-operator/merges","archive_url":"https://api.github.com/repos/pingcap/tidb-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb-operator/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb-operator/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb-operator/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb-operator/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb-operator/deployments","created_at":"2018-08-07T12:04:33Z","updated_at":"2018-10-25T05:22:59Z","pushed_at":"2018-10-25T14:18:07Z","git_url":"git://github.com/pingcap/tidb-operator.git","ssh_url":"git@github.com:pingcap/tidb-operator.git","clone_url":"https://github.com/pingcap/tidb-operator.git","svn_url":"https://github.com/pingcap/tidb-operator","homepage":"","size":48565,"stargazers_count":167,"watchers_count":167,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":38,"open_issues":16,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/143"},"html":{"href":"https://github.com/pingcap/tidb-operator/pull/143"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb-operator/issues/143"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb-operator/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb-operator/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb-operator/statuses/afa3108e032d54205548601f61d29d748707227f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tennix","id":7932127,"node_id":"MDQ6VXNlcjc5MzIxMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/7932127?v=4","gravatar_id":"","url":"https://api.github.com/users/tennix","html_url":"https://github.com/tennix","followers_url":"https://api.github.com/users/tennix/followers","following_url":"https://api.github.com/users/tennix/following{/other_user}","gists_url":"https://api.github.com/users/tennix/gists{/gist_id}","starred_url":"https://api.github.com/users/tennix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tennix/subscriptions","organizations_url":"https://api.github.com/users/tennix/orgs","repos_url":"https://api.github.com/users/tennix/repos","events_url":"https://api.github.com/users/tennix/events{/privacy}","received_events_url":"https://api.github.com/users/tennix/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":6,"deletions":2,"changed_files":4}}
{"actor":{"display_login":"tennix"}}