{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/220898398","pull_request_review_id":159412364,"id":220898398,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDg5ODM5OA==","diff_hunk":"@@ -0,0 +1,76 @@\n+/*\n+ * Copyright 2017 The Netty Project\n+ *\n+ * The Netty Project licenses this file to you under the Apache License,\n+ * version 2.0 (the \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at:\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package io.netty.handler.codec.dns;\n+\n+import io.netty.util.internal.StringUtil;\n+import io.netty.util.internal.UnstableApi;\n+\n+import static io.netty.util.internal.ObjectUtil.checkNotNull;\n+\n+@UnstableApi\n+public class DefaultDnsMxRecord extends AbstractDnsRecord implements DnsMxRecord {\n+    private final int preference;\n+    private final String hostname;\n+\n+    /**\n+     * Creates a new MX record.\n+     *\n+     * @param name the domain name\n+     * @param dnsClass the class of the record, usually one of the following:\n+     *                 <ul>\n+     *                     <li>{@link #CLASS_IN}</li>\n+     *                     <li>{@link #CLASS_CSNET}</li>\n+     *                     <li>{@link #CLASS_CHAOS}</li>\n+     *                     <li>{@link #CLASS_HESIOD}</li>\n+     *                     <li>{@link #CLASS_NONE}</li>\n+     *                     <li>{@link #CLASS_ANY}</li>\n+     *                 </ul>\n+     * @param timeToLive the TTL value of the record\n+     * @param hostname the canonical or primary name this MX record resolves to.\n+     */\n+    public DefaultDnsMxRecord(String name, int dnsClass, long timeToLive, int preference, String hostname) {\n+        super(name, DnsRecordType.MX, dnsClass, timeToLive);\n+        this.preference = preference;","path":"codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsMxRecord.java","position":46,"original_position":46,"commit_id":"ae75735e6504b36ecbb74749314bcff8ff35507c","original_commit_id":"ae75735e6504b36ecbb74749314bcff8ff35507c","user":{"login":"trustin","id":173918,"node_id":"MDQ6VXNlcjE3MzkxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"body":"Range check?","created_at":"2018-09-27T12:13:05Z","updated_at":"2018-09-27T12:31:27Z","html_url":"https://github.com/netty/netty/pull/6615#discussion_r220898398","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/6615","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/220898398"},"html":{"href":"https://github.com/netty/netty/pull/6615#discussion_r220898398"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/6615"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/6615","id":114745386,"node_id":"MDExOlB1bGxSZXF1ZXN0MTE0NzQ1Mzg2","html_url":"https://github.com/netty/netty/pull/6615","diff_url":"https://github.com/netty/netty/pull/6615.diff","patch_url":"https://github.com/netty/netty/pull/6615.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/6615","number":6615,"state":"open","locked":false,"title":"add common DNS record types","user":{"login":"flier","id":61618,"node_id":"MDQ6VXNlcjYxNjE4","avatar_url":"https://avatars0.githubusercontent.com/u/61618?v=4","gravatar_id":"","url":"https://api.github.com/users/flier","html_url":"https://github.com/flier","followers_url":"https://api.github.com/users/flier/followers","following_url":"https://api.github.com/users/flier/following{/other_user}","gists_url":"https://api.github.com/users/flier/gists{/gist_id}","starred_url":"https://api.github.com/users/flier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flier/subscriptions","organizations_url":"https://api.github.com/users/flier/orgs","repos_url":"https://api.github.com/users/flier/repos","events_url":"https://api.github.com/users/flier/events{/privacy}","received_events_url":"https://api.github.com/users/flier/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nadd more common DNS record types\r\n\r\nModification:\r\n\r\ndefine, decode and encode A, AAAA, CNAME, MX, NS, SOA, SRV and TXT record types\r\n\r\nResult:\r\n\r\n\r\n","created_at":"2017-04-07T05:19:42Z","updated_at":"2018-09-27T12:31:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd469d5ff45a0a84897d898a71b84dc7a844a523","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/6615/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/6615/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/6615/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/ae75735e6504b36ecbb74749314bcff8ff35507c","head":{"label":"flier:more-dns-record","ref":"more-dns-record","sha":"ae75735e6504b36ecbb74749314bcff8ff35507c","user":{"login":"flier","id":61618,"node_id":"MDQ6VXNlcjYxNjE4","avatar_url":"https://avatars0.githubusercontent.com/u/61618?v=4","gravatar_id":"","url":"https://api.github.com/users/flier","html_url":"https://github.com/flier","followers_url":"https://api.github.com/users/flier/followers","following_url":"https://api.github.com/users/flier/following{/other_user}","gists_url":"https://api.github.com/users/flier/gists{/gist_id}","starred_url":"https://api.github.com/users/flier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flier/subscriptions","organizations_url":"https://api.github.com/users/flier/orgs","repos_url":"https://api.github.com/users/flier/repos","events_url":"https://api.github.com/users/flier/events{/privacy}","received_events_url":"https://api.github.com/users/flier/received_events","type":"User","site_admin":false},"repo":{"id":87501072,"node_id":"MDEwOlJlcG9zaXRvcnk4NzUwMTA3Mg==","name":"netty","full_name":"flier/netty","private":false,"owner":{"login":"flier","id":61618,"node_id":"MDQ6VXNlcjYxNjE4","avatar_url":"https://avatars0.githubusercontent.com/u/61618?v=4","gravatar_id":"","url":"https://api.github.com/users/flier","html_url":"https://github.com/flier","followers_url":"https://api.github.com/users/flier/followers","following_url":"https://api.github.com/users/flier/following{/other_user}","gists_url":"https://api.github.com/users/flier/gists{/gist_id}","starred_url":"https://api.github.com/users/flier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flier/subscriptions","organizations_url":"https://api.github.com/users/flier/orgs","repos_url":"https://api.github.com/users/flier/repos","events_url":"https://api.github.com/users/flier/events{/privacy}","received_events_url":"https://api.github.com/users/flier/received_events","type":"User","site_admin":false},"html_url":"https://github.com/flier/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/flier/netty","forks_url":"https://api.github.com/repos/flier/netty/forks","keys_url":"https://api.github.com/repos/flier/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flier/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flier/netty/teams","hooks_url":"https://api.github.com/repos/flier/netty/hooks","issue_events_url":"https://api.github.com/repos/flier/netty/issues/events{/number}","events_url":"https://api.github.com/repos/flier/netty/events","assignees_url":"https://api.github.com/repos/flier/netty/assignees{/user}","branches_url":"https://api.github.com/repos/flier/netty/branches{/branch}","tags_url":"https://api.github.com/repos/flier/netty/tags","blobs_url":"https://api.github.com/repos/flier/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flier/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flier/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/flier/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flier/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/flier/netty/languages","stargazers_url":"https://api.github.com/repos/flier/netty/stargazers","contributors_url":"https://api.github.com/repos/flier/netty/contributors","subscribers_url":"https://api.github.com/repos/flier/netty/subscribers","subscription_url":"https://api.github.com/repos/flier/netty/subscription","commits_url":"https://api.github.com/repos/flier/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/flier/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/flier/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/flier/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/flier/netty/contents/{+path}","compare_url":"https://api.github.com/repos/flier/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flier/netty/merges","archive_url":"https://api.github.com/repos/flier/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flier/netty/downloads","issues_url":"https://api.github.com/repos/flier/netty/issues{/number}","pulls_url":"https://api.github.com/repos/flier/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/flier/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/flier/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flier/netty/labels{/name}","releases_url":"https://api.github.com/repos/flier/netty/releases{/id}","deployments_url":"https://api.github.com/repos/flier/netty/deployments","created_at":"2017-04-07T03:35:55Z","updated_at":"2017-04-07T03:36:09Z","pushed_at":"2018-09-25T12:34:13Z","git_url":"git://github.com/flier/netty.git","ssh_url":"git@github.com:flier/netty.git","clone_url":"https://github.com/flier/netty.git","svn_url":"https://github.com/flier/netty","homepage":"http://netty.io/","size":50990,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"4.1"}},"base":{"label":"netty:4.1","ref":"4.1","sha":"9a3be347af35107201f7d4a72416e76cf6b39a82","user":{"login":"netty","id":473791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mzc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/473791?v=4","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NTYz","name":"netty","full_name":"netty/netty","private":false,"owner":{"login":"netty","id":473791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mzc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/473791?v=4","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty/deployments","created_at":"2010-11-09T09:22:21Z","updated_at":"2018-09-27T11:38:49Z","pushed_at":"2018-09-27T10:47:19Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":52340,"stargazers_count":15804,"watchers_count":15804,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6939,"mirror_url":null,"archived":false,"open_issues_count":387,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6939,"open_issues":387,"watchers":15804,"default_branch":"4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/6615"},"html":{"href":"https://github.com/netty/netty/pull/6615"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/6615"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/6615/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/6615/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/6615/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/ae75735e6504b36ecbb74749314bcff8ff35507c"}},"author_association":"NONE"}}
{"actor":{"display_login":"trustin"}}