{"action":"opened","number":3394,"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/3394","id":170283129,"html_url":"https://github.com/aframevr/aframe/pull/3394","diff_url":"https://github.com/aframevr/aframe/pull/3394.diff","patch_url":"https://github.com/aframevr/aframe/pull/3394.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/3394","number":3394,"state":"open","locked":false,"title":"Wasd update","user":{"login":"greengiant83","id":4520126,"avatar_url":"https://avatars0.githubusercontent.com/u/4520126?v=4","gravatar_id":"","url":"https://api.github.com/users/greengiant83","html_url":"https://github.com/greengiant83","followers_url":"https://api.github.com/users/greengiant83/followers","following_url":"https://api.github.com/users/greengiant83/following{/other_user}","gists_url":"https://api.github.com/users/greengiant83/gists{/gist_id}","starred_url":"https://api.github.com/users/greengiant83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greengiant83/subscriptions","organizations_url":"https://api.github.com/users/greengiant83/orgs","repos_url":"https://api.github.com/users/greengiant83/repos","events_url":"https://api.github.com/users/greengiant83/events{/privacy}","received_events_url":"https://api.github.com/users/greengiant83/received_events","type":"User","site_admin":false},"body":"**Description:**\r\nAddresses issue: https://github.com/aframevr/aframe/issues/3351 \r\nThis allows wasd-controls to be placed in a parent entity around camera and motion controllers and have the motion controllers move with the player\r\n\r\n```\r\n<a-entity id=\"player\" wasd-controls=\"\">\r\n\t<a-camera wasd-controls-enabled=\"false\"></a-camera>\r\n\t<a-entity id=\"leftHand\" teleport-controls=\"cameraRig: #player\" laser-controls=\"hand: left\" raycaster=\"far:100; objects:.button\"></a-entity>\r\n\t<a-entity id=\"rightHand\" teleport-controls=\"cameraRig: #player\" laser-controls=\"hand: right\" raycaster=\"far:100; objects:.button\"></a-entity>\r\n</a-entity>\r\n```\r\n\r\n**Changes proposed:**\r\nAdds logic to use an independent element for orientation when calculating movement vector. \r\ncameraRig can be specified explicitly. Falling back from that the control will search child elements for a camera element to use. Falling back from there, the existing behavior is used\r\n\r\n","created_at":"2018-02-20T19:15:41Z","updated_at":"2018-02-20T19:15:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/3394/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/3394/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/3394/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/7f3f2f10d135dad10aa7b36648ca3db5bf0066f8","head":{"label":"greengiant83:wasd-update","ref":"wasd-update","sha":"7f3f2f10d135dad10aa7b36648ca3db5bf0066f8","user":{"login":"greengiant83","id":4520126,"avatar_url":"https://avatars0.githubusercontent.com/u/4520126?v=4","gravatar_id":"","url":"https://api.github.com/users/greengiant83","html_url":"https://github.com/greengiant83","followers_url":"https://api.github.com/users/greengiant83/followers","following_url":"https://api.github.com/users/greengiant83/following{/other_user}","gists_url":"https://api.github.com/users/greengiant83/gists{/gist_id}","starred_url":"https://api.github.com/users/greengiant83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greengiant83/subscriptions","organizations_url":"https://api.github.com/users/greengiant83/orgs","repos_url":"https://api.github.com/users/greengiant83/repos","events_url":"https://api.github.com/users/greengiant83/events{/privacy}","received_events_url":"https://api.github.com/users/greengiant83/received_events","type":"User","site_admin":false},"repo":{"id":122239340,"name":"aframe","full_name":"greengiant83/aframe","owner":{"login":"greengiant83","id":4520126,"avatar_url":"https://avatars0.githubusercontent.com/u/4520126?v=4","gravatar_id":"","url":"https://api.github.com/users/greengiant83","html_url":"https://github.com/greengiant83","followers_url":"https://api.github.com/users/greengiant83/followers","following_url":"https://api.github.com/users/greengiant83/following{/other_user}","gists_url":"https://api.github.com/users/greengiant83/gists{/gist_id}","starred_url":"https://api.github.com/users/greengiant83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greengiant83/subscriptions","organizations_url":"https://api.github.com/users/greengiant83/orgs","repos_url":"https://api.github.com/users/greengiant83/repos","events_url":"https://api.github.com/users/greengiant83/events{/privacy}","received_events_url":"https://api.github.com/users/greengiant83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greengiant83/aframe","description":":a: web framework for building virtual reality experiences.","fork":true,"url":"https://api.github.com/repos/greengiant83/aframe","forks_url":"https://api.github.com/repos/greengiant83/aframe/forks","keys_url":"https://api.github.com/repos/greengiant83/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greengiant83/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greengiant83/aframe/teams","hooks_url":"https://api.github.com/repos/greengiant83/aframe/hooks","issue_events_url":"https://api.github.com/repos/greengiant83/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/greengiant83/aframe/events","assignees_url":"https://api.github.com/repos/greengiant83/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/greengiant83/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/greengiant83/aframe/tags","blobs_url":"https://api.github.com/repos/greengiant83/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greengiant83/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greengiant83/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/greengiant83/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greengiant83/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/greengiant83/aframe/languages","stargazers_url":"https://api.github.com/repos/greengiant83/aframe/stargazers","contributors_url":"https://api.github.com/repos/greengiant83/aframe/contributors","subscribers_url":"https://api.github.com/repos/greengiant83/aframe/subscribers","subscription_url":"https://api.github.com/repos/greengiant83/aframe/subscription","commits_url":"https://api.github.com/repos/greengiant83/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/greengiant83/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/greengiant83/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/greengiant83/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/greengiant83/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/greengiant83/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greengiant83/aframe/merges","archive_url":"https://api.github.com/repos/greengiant83/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greengiant83/aframe/downloads","issues_url":"https://api.github.com/repos/greengiant83/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/greengiant83/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/greengiant83/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/greengiant83/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greengiant83/aframe/labels{/name}","releases_url":"https://api.github.com/repos/greengiant83/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/greengiant83/aframe/deployments","created_at":"2018-02-20T18:39:42Z","updated_at":"2018-02-20T18:39:44Z","pushed_at":"2018-02-20T19:02:37Z","git_url":"git://github.com/greengiant83/aframe.git","ssh_url":"git@github.com:greengiant83/aframe.git","clone_url":"https://github.com/greengiant83/aframe.git","svn_url":"https://github.com/greengiant83/aframe","homepage":"https://aframe.io/","size":201940,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"cba58c45f91c7d3862a3cf5e9d2578e245faddac","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars0.githubusercontent.com/u/16024092?v=4","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars0.githubusercontent.com/u/16024092?v=4","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":":a: web framework for building virtual reality experiences.","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2018-02-20T14:44:15Z","pushed_at":"2018-02-20T17:00:55Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":201940,"stargazers_count":7544,"watchers_count":7544,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1739,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1739,"open_issues":246,"watchers":7544,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3394"},"html":{"href":"https://github.com/aframevr/aframe/pull/3394"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/3394"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/3394/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3394/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3394/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/7f3f2f10d135dad10aa7b36648ca3db5bf0066f8"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":11083,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"greengiant83"}}