{"action":"created","issue":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/820","repository_url":"https://api.github.com/repos/openjournals/joss-reviews","labels_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/820/labels{/name}","comments_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/820/comments","events_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/820/events","html_url":"https://github.com/openjournals/joss-reviews/issues/820","id":340254615,"node_id":"MDU6SXNzdWUzNDAyNTQ2MTU=","number":820,"title":"[REVIEW]: WEdiff: A Python and C++ package for automatic differentiation","user":{"login":"whedon","id":18508068,"node_id":"MDQ6VXNlcjE4NTA4MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/18508068?v=4","gravatar_id":"","url":"https://api.github.com/users/whedon","html_url":"https://github.com/whedon","followers_url":"https://api.github.com/users/whedon/followers","following_url":"https://api.github.com/users/whedon/following{/other_user}","gists_url":"https://api.github.com/users/whedon/gists{/gist_id}","starred_url":"https://api.github.com/users/whedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whedon/subscriptions","organizations_url":"https://api.github.com/users/whedon/orgs","repos_url":"https://api.github.com/users/whedon/repos","events_url":"https://api.github.com/users/whedon/events{/privacy}","received_events_url":"https://api.github.com/users/whedon/received_events","type":"User","site_admin":false},"labels":[{"id":330465313,"node_id":"MDU6TGFiZWwzMzA0NjUzMTM=","url":"https://api.github.com/repos/openjournals/joss-reviews/labels/review","name":"review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"arfon","id":4483,"node_id":"MDQ6VXNlcjQ0ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4483?v=4","gravatar_id":"","url":"https://api.github.com/users/arfon","html_url":"https://github.com/arfon","followers_url":"https://api.github.com/users/arfon/followers","following_url":"https://api.github.com/users/arfon/following{/other_user}","gists_url":"https://api.github.com/users/arfon/gists{/gist_id}","starred_url":"https://api.github.com/users/arfon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arfon/subscriptions","organizations_url":"https://api.github.com/users/arfon/orgs","repos_url":"https://api.github.com/users/arfon/repos","events_url":"https://api.github.com/users/arfon/events{/privacy}","received_events_url":"https://api.github.com/users/arfon/received_events","type":"User","site_admin":false},"assignees":[{"login":"arfon","id":4483,"node_id":"MDQ6VXNlcjQ0ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4483?v=4","gravatar_id":"","url":"https://api.github.com/users/arfon","html_url":"https://github.com/arfon","followers_url":"https://api.github.com/users/arfon/followers","following_url":"https://api.github.com/users/arfon/following{/other_user}","gists_url":"https://api.github.com/users/arfon/gists{/gist_id}","starred_url":"https://api.github.com/users/arfon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arfon/subscriptions","organizations_url":"https://api.github.com/users/arfon/orgs","repos_url":"https://api.github.com/users/arfon/repos","events_url":"https://api.github.com/users/arfon/events{/privacy}","received_events_url":"https://api.github.com/users/arfon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-07-11T13:58:37Z","updated_at":"2018-09-06T17:14:35Z","closed_at":null,"author_association":"COLLABORATOR","body":"**Submitting author:** @ctdegroot (<a href=\"http://orcid.org/0000-0002-2069-8253\">Christopher DeGroot</a>)\n**Repository:** <a href=\"https://bitbucket.org/cdegroot/wediff\" target =\"_blank\">https://bitbucket.org/cdegroot/wediff</a>\n**Version:** N/A\n**Editor:** @arfon\n**Reviewer:** @highlando, @kyleniemeyer\n**Archive:** Pending\n\n## Status\n\n[![status](http://joss.theoj.org/papers/dc70f6c1be71729b111e7858e385888d/status.svg)](http://joss.theoj.org/papers/dc70f6c1be71729b111e7858e385888d)\n\nStatus badge code:\n\n```\nHTML: <a href=\"http://joss.theoj.org/papers/dc70f6c1be71729b111e7858e385888d\"><img src=\"http://joss.theoj.org/papers/dc70f6c1be71729b111e7858e385888d/status.svg\"></a>\nMarkdown: [![status](http://joss.theoj.org/papers/dc70f6c1be71729b111e7858e385888d/status.svg)](http://joss.theoj.org/papers/dc70f6c1be71729b111e7858e385888d)\n```\n**Reviewers and authors**:\n\nPlease avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=\"https://bitbucket.org/cdegroot/wediff\" target=\"_blank\">target repository</a> and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)\n\n## Reviewer instructions & questions\n\n@highlando & @kyleniemeyer, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:\n1. Make sure you're logged in to your GitHub account\n2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations\n\nThe reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arfon know.\n\n## Review checklist for @highlando\n### Conflict of interest\n\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\n\n### Code of Conduct\n\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\n\n### General checks\n\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://bitbucket.org/cdegroot/wediff\">repository url</a>?\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\n- [x] **Version:** Does the release version given match the GitHub release (N/A)?\n- [x] **Authorship:** Has the submitting author (@ctdegroot) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\n\n### Functionality\n\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\n\n### Documentation\n\n- [ ] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\n- [ ] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\n\n### Software paper\n\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [ ] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\n\n## Review checklist for @kyleniemeyer\n### Conflict of interest\n\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\n\n### Code of Conduct\n\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\n\n### General checks\n\n- [ ] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://bitbucket.org/cdegroot/wediff\">repository url</a>?\n- [ ] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\n- [ ] **Version:** Does the release version given match the GitHub release (N/A)?\n- [ ] **Authorship:** Has the submitting author (@ctdegroot) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\n\n### Functionality\n\n- [ ] **Installation:** Does installation proceed as outlined in the documentation?\n- [ ] **Functionality:** Have the functional claims of the software been confirmed?\n- [ ] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\n\n### Documentation\n\n- [ ] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [ ] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\n- [ ] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\n- [ ] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\n- [ ] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\n- [ ] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\n\n### Software paper\n\n- [ ] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\n- [ ] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [ ] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\n\n"},"comment":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/comments/419172411","html_url":"https://github.com/openjournals/joss-reviews/issues/820#issuecomment-419172411","issue_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/820","id":419172411,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTE3MjQxMQ==","user":{"login":"ctdegroot","id":6632661,"node_id":"MDQ6VXNlcjY2MzI2NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/6632661?v=4","gravatar_id":"","url":"https://api.github.com/users/ctdegroot","html_url":"https://github.com/ctdegroot","followers_url":"https://api.github.com/users/ctdegroot/followers","following_url":"https://api.github.com/users/ctdegroot/following{/other_user}","gists_url":"https://api.github.com/users/ctdegroot/gists{/gist_id}","starred_url":"https://api.github.com/users/ctdegroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctdegroot/subscriptions","organizations_url":"https://api.github.com/users/ctdegroot/orgs","repos_url":"https://api.github.com/users/ctdegroot/repos","events_url":"https://api.github.com/users/ctdegroot/events{/privacy}","received_events_url":"https://api.github.com/users/ctdegroot/received_events","type":"User","site_admin":false},"created_at":"2018-09-06T17:14:35Z","updated_at":"2018-09-06T17:14:35Z","author_association":"NONE","body":"Thanks @highlando for your review! \r\n\r\nI've added a few guidelines to the repo regarding contributions/support now. I've also added DOIs to the references that have them. Let me know if I should add the statement of need also to the documentation or if it is ok in the JOSS paper."}}
{"actor":{"display_login":"ctdegroot"}}