{"action":"created","issue":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5597","repository_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore","labels_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5597/labels{/name}","comments_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5597/comments","events_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5597/events","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5597","id":391824830,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjMyNzI0","number":5597,"title":"QA Fail Fixes (Project Check Category Persistence, Tool Card Order)","user":{"login":"RoyalSix","id":16184018,"node_id":"MDQ6VXNlcjE2MTg0MDE4","avatar_url":"https://avatars0.githubusercontent.com/u/16184018?v=4","gravatar_id":"","url":"https://api.github.com/users/RoyalSix","html_url":"https://github.com/RoyalSix","followers_url":"https://api.github.com/users/RoyalSix/followers","following_url":"https://api.github.com/users/RoyalSix/following{/other_user}","gists_url":"https://api.github.com/users/RoyalSix/gists{/gist_id}","starred_url":"https://api.github.com/users/RoyalSix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoyalSix/subscriptions","organizations_url":"https://api.github.com/users/RoyalSix/orgs","repos_url":"https://api.github.com/users/RoyalSix/repos","events_url":"https://api.github.com/users/RoyalSix/events{/privacy}","received_events_url":"https://api.github.com/users/RoyalSix/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-17T17:54:32Z","updated_at":"2018-12-18T17:58:26Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/5597","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5597","diff_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5597.diff","patch_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5597.patch"},"body":"#### Describe what your pull request addresses (Please include relevant issue numbers):\r\n- This PR fixes the following issues\r\n```\r\n- If the user unselects a a checkbox or two, save those settings (pegged to the project)\r\nNow it does save the setting, but it is not pegged to the project. It is used for all projects until changed again.\r\n\r\n- The UI mockups show the checkboxes in the sequence of Key Terms, Other Terms, Names, but as implemented the sequence is Key Terms, Names, Other Terms.\r\n```\r\n\r\n#### Please include detailed Test instructions for your pull request:\r\n-\r\n\r\n#### Standard Test Instructions for PR Review Process:\r\n\r\n- [ ] Double check unit tests that have been written\r\n- [ ] Check for documentation for code changes\r\n- [ ] Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR\r\n- [ ] Checkout the branch locally and ensure that app runs as expected\r\n  - [ ] Ensure tests pass\r\n  - [ ] Open and watch the console for errors\r\n  - [ ] Make sure all actions perform as expected\r\n  - [ ] Import and Load a new Project\r\n  - [ ] Load a tool and perform basic actions\r\n  - [ ] Switch tools and perform basic actions\r\n  - [ ] Switch project to an existing project\r\n  - [ ] Load a tool and perform basic actions\r\n  - [ ] Switch tools and perform basic actions\r\n  - [ ] Next time reverse the order of importing after loading an existing project\r\n- [ ] Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story\r\n- [ ] Ask Ben or Koz if you have any concerns about implementation (especially UI related)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/unfoldingword-dev/translationcore/5597)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/comments/448312082","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/5597#issuecomment-448312082","issue_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/5597","id":448312082,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODMxMjA4Mg==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-18T17:58:26Z","updated_at":"2018-12-18T17:58:26Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597?src=pr&el=h1) Report\n> :exclamation: No coverage uploaded for pull request base (`develop@e0daa5b`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).\n> The diff coverage is `26.86%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/graphs/tree.svg?width=650&token=JX8FJXc5PX&height=150&src=pr)](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##             develop    #5597   +/-   ##\n==========================================\n  Coverage           ?   55.94%           \n==========================================\n  Files              ?      265           \n  Lines              ?     8584           \n  Branches           ?     1411           \n==========================================\n  Hits               ?     4802           \n  Misses             ?     3298           \n  Partials           ?      484\n```\n\n\n| [Impacted Files](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/js/reducers/settingsReducer.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/diff?src=pr&el=tree#diff-c3JjL2pzL3JlZHVjZXJzL3NldHRpbmdzUmVkdWNlci5qcw==) | `43.75% <ø> (ø)` | |\n| [...c/js/components/home/toolsManagement/ToolsCards.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/diff?src=pr&el=tree#diff-c3JjL2pzL2NvbXBvbmVudHMvaG9tZS90b29sc01hbmFnZW1lbnQvVG9vbHNDYXJkcy5qcw==) | `0% <ø> (ø)` | |\n| [src/js/actions/ActionTypes.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/diff?src=pr&el=tree#diff-c3JjL2pzL2FjdGlvbnMvQWN0aW9uVHlwZXMuanM=) | `100% <ø> (ø)` | |\n| [src/js/localStorage/loadMethods.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/diff?src=pr&el=tree#diff-c3JjL2pzL2xvY2FsU3RvcmFnZS9sb2FkTWV0aG9kcy5qcw==) | `0% <ø> (ø)` | |\n| [src/js/components/home/toolsManagement/ToolCard.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/diff?src=pr&el=tree#diff-c3JjL2pzL2NvbXBvbmVudHMvaG9tZS90b29sc01hbmFnZW1lbnQvVG9vbENhcmQuanM=) | `0% <0%> (ø)` | |\n| [src/js/reducers/projectDetailsReducer.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/diff?src=pr&el=tree#diff-c3JjL2pzL3JlZHVjZXJzL3Byb2plY3REZXRhaWxzUmVkdWNlci5qcw==) | `58.97% <0%> (ø)` | |\n| [src/js/helpers/ResourcesHelpers.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/diff?src=pr&el=tree#diff-c3JjL2pzL2hlbHBlcnMvUmVzb3VyY2VzSGVscGVycy5qcw==) | `71.37% <0%> (ø)` | |\n| [src/js/containers/home/ToolsManagementContainer.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/diff?src=pr&el=tree#diff-c3JjL2pzL2NvbnRhaW5lcnMvaG9tZS9Ub29sc01hbmFnZW1lbnRDb250YWluZXIuanM=) | `0% <0%> (ø)` | |\n| [src/js/actions/ToolActions.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/diff?src=pr&el=tree#diff-c3JjL2pzL2FjdGlvbnMvVG9vbEFjdGlvbnMuanM=) | `12.63% <18.75%> (ø)` | |\n| [src/js/helpers/ProjectDetailsHelpers.js](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/diff?src=pr&el=tree#diff-c3JjL2pzL2hlbHBlcnMvUHJvamVjdERldGFpbHNIZWxwZXJzLmpz) | `85.01% <43.75%> (ø)` | |\n| ... and [1 more](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597?src=pr&el=footer). Last update [e0daa5b...b11f71d](https://codecov.io/gh/unfoldingWord-dev/translationCore/pull/5597?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}