{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments/180125681","pull_request_review_id":110492077,"id":180125681,"diff_hunk":"@@ -128,8 +128,10 @@ public String getMode() {\n   @BeforeClass\n   public static void waitForServerUp() throws Exception {\n     HttpUrlUtil.waitForServerUp(SERVER_URI, TIMEOUT_SECONDS, TimeUnit.SECONDS);\n-    // wait for HTTPS as well\n-    HttpUrlUtil.waitForServerUp(new URI(SERVER_URI.toASCIIString().replace(\"http:\", \"https:\")),\n-            TIMEOUT_SECONDS, TimeUnit.SECONDS);\n+    // wait for HTTPS as well, but only for remote\n+    if (!SERVER_URI.toASCIIString().startsWith(\"http://localhost\")) {","path":"tests/gcloud-testing-core/src/main/java/com/google/cloud/runtime/jetty/test/AbstractIntegrationTest.java","position":8,"original_position":8,"commit_id":"b1848f0ee23134ba895b105bba919a59b42161f6","original_commit_id":"b1848f0ee23134ba895b105bba919a59b42161f6","user":{"login":"balopat","id":635073,"avatar_url":"https://avatars1.githubusercontent.com/u/635073?v=4","gravatar_id":"","url":"https://api.github.com/users/balopat","html_url":"https://github.com/balopat","followers_url":"https://api.github.com/users/balopat/followers","following_url":"https://api.github.com/users/balopat/following{/other_user}","gists_url":"https://api.github.com/users/balopat/gists{/gist_id}","starred_url":"https://api.github.com/users/balopat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balopat/subscriptions","organizations_url":"https://api.github.com/users/balopat/orgs","repos_url":"https://api.github.com/users/balopat/repos","events_url":"https://api.github.com/users/balopat/events{/privacy}","received_events_url":"https://api.github.com/users/balopat/received_events","type":"User","site_admin":false},"body":"how about https://localhost? maybe `..contains(\"localhost\")`?","created_at":"2018-04-09T15:04:41Z","updated_at":"2018-04-09T15:04:42Z","html_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/231#discussion_r180125681","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/231","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments/180125681"},"html":{"href":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/231#discussion_r180125681"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/231"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/231","id":180336675,"html_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/231","diff_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/231.diff","patch_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/231.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/231","number":231,"state":"open","locked":false,"title":"Fix localhost HTTPS smoke test","user":{"login":"meltsufin","id":17732492,"avatar_url":"https://avatars2.githubusercontent.com/u/17732492?v=4","gravatar_id":"","url":"https://api.github.com/users/meltsufin","html_url":"https://github.com/meltsufin","followers_url":"https://api.github.com/users/meltsufin/followers","following_url":"https://api.github.com/users/meltsufin/following{/other_user}","gists_url":"https://api.github.com/users/meltsufin/gists{/gist_id}","starred_url":"https://api.github.com/users/meltsufin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meltsufin/subscriptions","organizations_url":"https://api.github.com/users/meltsufin/orgs","repos_url":"https://api.github.com/users/meltsufin/repos","events_url":"https://api.github.com/users/meltsufin/events{/privacy}","received_events_url":"https://api.github.com/users/meltsufin/received_events","type":"User","site_admin":false},"body":"HTTPS testing does not apply to `localhost`. So, do not wait for the `https://localhost...` endpoint to be responsive, like we do for the remote.","created_at":"2018-04-09T14:58:12Z","updated_at":"2018-04-09T15:04:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"344d3bf562129235f03d014e098296e23af8652e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ChengyuanZhao","id":29288945,"avatar_url":"https://avatars3.githubusercontent.com/u/29288945?v=4","gravatar_id":"","url":"https://api.github.com/users/ChengyuanZhao","html_url":"https://github.com/ChengyuanZhao","followers_url":"https://api.github.com/users/ChengyuanZhao/followers","following_url":"https://api.github.com/users/ChengyuanZhao/following{/other_user}","gists_url":"https://api.github.com/users/ChengyuanZhao/gists{/gist_id}","starred_url":"https://api.github.com/users/ChengyuanZhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChengyuanZhao/subscriptions","organizations_url":"https://api.github.com/users/ChengyuanZhao/orgs","repos_url":"https://api.github.com/users/ChengyuanZhao/repos","events_url":"https://api.github.com/users/ChengyuanZhao/events{/privacy}","received_events_url":"https://api.github.com/users/ChengyuanZhao/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/231/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/231/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/231/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/statuses/b1848f0ee23134ba895b105bba919a59b42161f6","head":{"label":"GoogleCloudPlatform:fix-localhost-https-test","ref":"fix-localhost-https-test","sha":"b1848f0ee23134ba895b105bba919a59b42161f6","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":66016354,"name":"jetty-runtime","full_name":"GoogleCloudPlatform/jetty-runtime","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/jetty-runtime","description":"Google Cloud Platform Jetty Docker image","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/deployments","created_at":"2016-08-18T17:14:04Z","updated_at":"2018-04-04T13:42:40Z","pushed_at":"2018-04-09T14:58:13Z","git_url":"git://github.com/GoogleCloudPlatform/jetty-runtime.git","ssh_url":"git@github.com:GoogleCloudPlatform/jetty-runtime.git","clone_url":"https://github.com/GoogleCloudPlatform/jetty-runtime.git","svn_url":"https://github.com/GoogleCloudPlatform/jetty-runtime","homepage":"","size":6106,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":21,"open_issues":22,"watchers":28,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"451f67e047dabdcfe5e9a8f1fe3594e8db57ccc5","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":66016354,"name":"jetty-runtime","full_name":"GoogleCloudPlatform/jetty-runtime","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/jetty-runtime","description":"Google Cloud Platform Jetty Docker image","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/deployments","created_at":"2016-08-18T17:14:04Z","updated_at":"2018-04-04T13:42:40Z","pushed_at":"2018-04-09T14:58:13Z","git_url":"git://github.com/GoogleCloudPlatform/jetty-runtime.git","ssh_url":"git@github.com:GoogleCloudPlatform/jetty-runtime.git","clone_url":"https://github.com/GoogleCloudPlatform/jetty-runtime.git","svn_url":"https://github.com/GoogleCloudPlatform/jetty-runtime","homepage":"","size":6106,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":21,"open_issues":22,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/231"},"html":{"href":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/231"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/231"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/statuses/b1848f0ee23134ba895b105bba919a59b42161f6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"balopat"}}