{"action":"closed","issue":{"url":"https://api.github.com/repos/datahq/pm/issues/292","repository_url":"https://api.github.com/repos/datahq/pm","labels_url":"https://api.github.com/repos/datahq/pm/issues/292/labels{/name}","comments_url":"https://api.github.com/repos/datahq/pm/issues/292/comments","events_url":"https://api.github.com/repos/datahq/pm/issues/292/events","html_url":"https://github.com/datahq/pm/issues/292","id":376785473,"node_id":"MDU6SXNzdWUzNzY3ODU0NzM=","number":292,"title":"Core datasets complex scripts bugs","user":{"login":"Branko-Dj","id":37669494,"node_id":"MDQ6VXNlcjM3NjY5NDk0","avatar_url":"https://avatars2.githubusercontent.com/u/37669494?v=4","gravatar_id":"","url":"https://api.github.com/users/Branko-Dj","html_url":"https://github.com/Branko-Dj","followers_url":"https://api.github.com/users/Branko-Dj/followers","following_url":"https://api.github.com/users/Branko-Dj/following{/other_user}","gists_url":"https://api.github.com/users/Branko-Dj/gists{/gist_id}","starred_url":"https://api.github.com/users/Branko-Dj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Branko-Dj/subscriptions","organizations_url":"https://api.github.com/users/Branko-Dj/orgs","repos_url":"https://api.github.com/users/Branko-Dj/repos","events_url":"https://api.github.com/users/Branko-Dj/events{/privacy}","received_events_url":"https://api.github.com/users/Branko-Dj/received_events","type":"User","site_admin":false},"labels":[{"id":641183082,"node_id":"MDU6TGFiZWw2NDExODMwODI=","url":"https://api.github.com/repos/datahq/pm/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"closed","locked":false,"assignee":{"login":"Branko-Dj","id":37669494,"node_id":"MDQ6VXNlcjM3NjY5NDk0","avatar_url":"https://avatars2.githubusercontent.com/u/37669494?v=4","gravatar_id":"","url":"https://api.github.com/users/Branko-Dj","html_url":"https://github.com/Branko-Dj","followers_url":"https://api.github.com/users/Branko-Dj/followers","following_url":"https://api.github.com/users/Branko-Dj/following{/other_user}","gists_url":"https://api.github.com/users/Branko-Dj/gists{/gist_id}","starred_url":"https://api.github.com/users/Branko-Dj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Branko-Dj/subscriptions","organizations_url":"https://api.github.com/users/Branko-Dj/orgs","repos_url":"https://api.github.com/users/Branko-Dj/repos","events_url":"https://api.github.com/users/Branko-Dj/events{/privacy}","received_events_url":"https://api.github.com/users/Branko-Dj/received_events","type":"User","site_admin":false},"assignees":[{"login":"Branko-Dj","id":37669494,"node_id":"MDQ6VXNlcjM3NjY5NDk0","avatar_url":"https://avatars2.githubusercontent.com/u/37669494?v=4","gravatar_id":"","url":"https://api.github.com/users/Branko-Dj","html_url":"https://github.com/Branko-Dj","followers_url":"https://api.github.com/users/Branko-Dj/followers","following_url":"https://api.github.com/users/Branko-Dj/following{/other_user}","gists_url":"https://api.github.com/users/Branko-Dj/gists{/gist_id}","starred_url":"https://api.github.com/users/Branko-Dj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Branko-Dj/subscriptions","organizations_url":"https://api.github.com/users/Branko-Dj/orgs","repos_url":"https://api.github.com/users/Branko-Dj/repos","events_url":"https://api.github.com/users/Branko-Dj/events{/privacy}","received_events_url":"https://api.github.com/users/Branko-Dj/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/datahq/pm/milestones/40","html_url":"https://github.com/datahq/pm/milestone/40","labels_url":"https://api.github.com/repos/datahq/pm/milestones/40/labels","id":3755996,"node_id":"MDk6TWlsZXN0b25lMzc1NTk5Ng==","number":40,"title":"Sprint - 19 Nov 2018","description":"","creator":{"login":"zelima","id":15143785,"node_id":"MDQ6VXNlcjE1MTQzNzg1","avatar_url":"https://avatars3.githubusercontent.com/u/15143785?v=4","gravatar_id":"","url":"https://api.github.com/users/zelima","html_url":"https://github.com/zelima","followers_url":"https://api.github.com/users/zelima/followers","following_url":"https://api.github.com/users/zelima/following{/other_user}","gists_url":"https://api.github.com/users/zelima/gists{/gist_id}","starred_url":"https://api.github.com/users/zelima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zelima/subscriptions","organizations_url":"https://api.github.com/users/zelima/orgs","repos_url":"https://api.github.com/users/zelima/repos","events_url":"https://api.github.com/users/zelima/events{/privacy}","received_events_url":"https://api.github.com/users/zelima/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":1,"state":"open","created_at":"2018-10-22T06:49:22Z","updated_at":"2018-11-20T08:57:27Z","due_on":"2018-11-19T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-11-02T12:11:57Z","updated_at":"2018-11-20T08:57:27Z","closed_at":"2018-11-20T08:57:26Z","author_association":"NONE","body":"https://github.com/datahq/pm/issues/292\r\n\r\nAs a PM I want to fix the scripts for core datasets that have bugs which have proven more troublesome to fix\r\n\r\n## Analysis\r\n\r\n1. **cofog**\r\n\r\nSource for `process.py` script on line 20 `access_db_zip_url = 'http://unstats.un.org/unsd/cr/registry/regdntransfer.asp?f=186'` is broken. Moving it to broken sources\r\n\r\n2. **corruption-perceptions-index**\r\n\r\nLoads of problems. Libraries need to be installed, sometimes source is downloaded but it is not unzipped, some sources unavailable, it's a mess. **I suggest complete refactoring of this script**\r\n\r\n3. **gdp-us**\r\nA slight change in url for sources was the problem, easy fix. It might be useful refactoring script to use python 3\r\n\r\n4. **geo-admin1-us**\r\nThis uses tuttle file so further analysis is needed\r\n\r\n5. **geo-countries**\r\nThis uses tuttle file so further analysis is needed\r\n\r\n6. **geo-ne-admin1**\r\nThis uses tuttle file so further analysis is needed\r\n\r\n7. **house-prices-global**\r\nFormat of the source csv file was changed so the script was slightly modified in order to work\r\n\r\n8. **house-prices-uk**\r\nScript is workin properly, the problem was in instructions for running the script in README which is now fixed\r\n\r\n9. **imf-weo**\r\nUnable to make script work, some problem with locales\r\n\r\n10. **interest-rates-gb**\r\nScript works properly but the source is outdated and the script should be refactored\r\n\r\n11. **language-codes**\r\nUnable to make PHP work, further analysis needed\r\n\r\n12. **pharmaceutical-drug-spending**\r\nFixed importing libraries in `population.py`\r\n\r\n13. **s-and-p-500**\r\nIn progress as a separate issue\r\n\r\n14. **s-and-p-500-companies**\r\nIn progress as a separate issue\r\n\r\n15. **un-locode**\r\nUnable to make PHP work, further analysis needed\r\n\r\n16. **world-cities**\r\nThis uses tuttle file so further analysis is needed\r\n\r\n## Acceptance criteria\r\n- [ ] The scripts with complex bugs are working properly. Those that require further analysis are labeled as such.\r\n\r\n## Tasks\r\n- [x] Determine and fix the bugs (if possible) or move repo to the [broken source issue(https://github.com/datahq/pm/issues/291) for the following list of datasets\r\n   - [x] https://github.com/datasets/cofog\r\n   - [x] https://github.com/datasets/corruption-perceptions-index\r\n   - [x] https://github.com/datasets/gdp-us\r\n   - [x] https://github.com/datasets/geo-admin1-us\r\n   - [x] https://github.com/datasets/geo-countries\r\n   - [x] https://github.com/datasets/geo-ne-admin1\r\n   - [x] https://github.com/datasets/house-prices-global\r\n   - [x] https://github.com/datasets/house-prices-uk\r\n   - [x] https://github.com/datasets/imf-weo\r\n   - [x] https://github.com/datasets/interest-rates-gb\r\n   - [x] https://github.com/datasets/language-codes\r\n   - [x] https://github.com/datasets/pharmaceutical-drug-spending\r\n   - [x] https://github.com/datasets/s-and-p-500\r\n   - [x] https://github.com/datasets/s-and-p-500-companies\r\n   - [x] https://github.com/datasets/un-locode\r\n   - [x] https://github.com/datasets/world-cities"}}
{"actor":{"display_login":"Branko-Dj"}}