{"action":"closed","number":3239,"pull_request":{"url":"https://api.github.com/repos/LLK/scratch-gui/pulls/3239","id":218467098,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDY3MDk4","html_url":"https://github.com/LLK/scratch-gui/pull/3239","diff_url":"https://github.com/LLK/scratch-gui/pull/3239.diff","patch_url":"https://github.com/LLK/scratch-gui/pull/3239.patch","issue_url":"https://api.github.com/repos/LLK/scratch-gui/issues/3239","number":3239,"state":"closed","locked":false,"title":"Don't show the \"Give Feedback\" button if there is a session","user":{"login":"rschamp","id":1512021,"node_id":"MDQ6VXNlcjE1MTIwMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1512021?v=4","gravatar_id":"","url":"https://api.github.com/users/rschamp","html_url":"https://github.com/rschamp","followers_url":"https://api.github.com/users/rschamp/followers","following_url":"https://api.github.com/users/rschamp/following{/other_user}","gists_url":"https://api.github.com/users/rschamp/gists{/gist_id}","starred_url":"https://api.github.com/users/rschamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschamp/subscriptions","organizations_url":"https://api.github.com/users/rschamp/orgs","repos_url":"https://api.github.com/users/rschamp/repos","events_url":"https://api.github.com/users/rschamp/events{/privacy}","received_events_url":"https://api.github.com/users/rschamp/received_events","type":"User","site_admin":false},"body":"/fyi @thisandagain \r\n\r\n### Proposed Changes\r\n\r\n_Describe what this Pull Request does_\r\n\r\nHide the \"Give Feedback\" button if there's session info (i.e., we are in scratch-www vs. beta)\r\n\r\n### Reason for Changes\r\n\r\n_Explain why these changes should be made_\r\n\r\nThis makes the rendering of the GUI in the preview project page look closer to the final design\r\n\r\n### Browser Coverage\r\nCheck the OS/browser combinations tested (At least 2)\r\n\r\nMac\r\n * [x] Chrome \r\n * [ ] Firefox \r\n * [x] Safari\r\n \r\nWindows\r\n * [ ] Chrome \r\n * [ ] Firefox \r\n * [ ] Edge\r\n \r\nChromebook\r\n * [ ] Chrome\r\n \r\niPad\r\n* [ ] Safari\r\n\r\nAndroid Tablet\r\n* [ ] Chrome\r\n","created_at":"2018-09-26T21:56:23Z","updated_at":"2018-09-27T01:11:40Z","closed_at":"2018-09-27T01:11:40Z","merged_at":"2018-09-27T01:11:40Z","merge_commit_sha":"87ec6bd767846dd7528fc6db40a2dd0d1047b585","assignee":{"login":"rschamp","id":1512021,"node_id":"MDQ6VXNlcjE1MTIwMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1512021?v=4","gravatar_id":"","url":"https://api.github.com/users/rschamp","html_url":"https://github.com/rschamp","followers_url":"https://api.github.com/users/rschamp/followers","following_url":"https://api.github.com/users/rschamp/following{/other_user}","gists_url":"https://api.github.com/users/rschamp/gists{/gist_id}","starred_url":"https://api.github.com/users/rschamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschamp/subscriptions","organizations_url":"https://api.github.com/users/rschamp/orgs","repos_url":"https://api.github.com/users/rschamp/repos","events_url":"https://api.github.com/users/rschamp/events{/privacy}","received_events_url":"https://api.github.com/users/rschamp/received_events","type":"User","site_admin":false},"assignees":[{"login":"rschamp","id":1512021,"node_id":"MDQ6VXNlcjE1MTIwMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1512021?v=4","gravatar_id":"","url":"https://api.github.com/users/rschamp","html_url":"https://github.com/rschamp","followers_url":"https://api.github.com/users/rschamp/followers","following_url":"https://api.github.com/users/rschamp/following{/other_user}","gists_url":"https://api.github.com/users/rschamp/gists{/gist_id}","starred_url":"https://api.github.com/users/rschamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschamp/subscriptions","organizations_url":"https://api.github.com/users/rschamp/orgs","repos_url":"https://api.github.com/users/rschamp/repos","events_url":"https://api.github.com/users/rschamp/events{/privacy}","received_events_url":"https://api.github.com/users/rschamp/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":461144953,"node_id":"MDU6TGFiZWw0NjExNDQ5NTM=","url":"https://api.github.com/repos/LLK/scratch-gui/labels/pr%20-%20good%20to%20merge","name":"pr - good to merge","color":"009866","default":false}],"milestone":{"url":"https://api.github.com/repos/LLK/scratch-gui/milestones/31","html_url":"https://github.com/LLK/scratch-gui/milestone/31","labels_url":"https://api.github.com/repos/LLK/scratch-gui/milestones/31/labels","id":3284459,"node_id":"MDk6TWlsZXN0b25lMzI4NDQ1OQ==","number":31,"title":"September 2018","description":"","creator":{"login":"thisandagain","id":747641,"node_id":"MDQ6VXNlcjc0NzY0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/747641?v=4","gravatar_id":"","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":68,"state":"open","created_at":"2018-04-20T14:00:12Z","updated_at":"2018-09-27T01:11:40Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/LLK/scratch-gui/pulls/3239/commits","review_comments_url":"https://api.github.com/repos/LLK/scratch-gui/pulls/3239/comments","review_comment_url":"https://api.github.com/repos/LLK/scratch-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLK/scratch-gui/issues/3239/comments","statuses_url":"https://api.github.com/repos/LLK/scratch-gui/statuses/e9febae2f3a33698c37692088b3e5fb07dd4250e","head":{"label":"rschamp:conditional-feedback","ref":"conditional-feedback","sha":"e9febae2f3a33698c37692088b3e5fb07dd4250e","user":{"login":"rschamp","id":1512021,"node_id":"MDQ6VXNlcjE1MTIwMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1512021?v=4","gravatar_id":"","url":"https://api.github.com/users/rschamp","html_url":"https://github.com/rschamp","followers_url":"https://api.github.com/users/rschamp/followers","following_url":"https://api.github.com/users/rschamp/following{/other_user}","gists_url":"https://api.github.com/users/rschamp/gists{/gist_id}","starred_url":"https://api.github.com/users/rschamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschamp/subscriptions","organizations_url":"https://api.github.com/users/rschamp/orgs","repos_url":"https://api.github.com/users/rschamp/repos","events_url":"https://api.github.com/users/rschamp/events{/privacy}","received_events_url":"https://api.github.com/users/rschamp/received_events","type":"User","site_admin":false},"repo":{"id":74614409,"node_id":"MDEwOlJlcG9zaXRvcnk3NDYxNDQwOQ==","name":"scratch-gui","full_name":"rschamp/scratch-gui","private":false,"owner":{"login":"rschamp","id":1512021,"node_id":"MDQ6VXNlcjE1MTIwMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1512021?v=4","gravatar_id":"","url":"https://api.github.com/users/rschamp","html_url":"https://github.com/rschamp","followers_url":"https://api.github.com/users/rschamp/followers","following_url":"https://api.github.com/users/rschamp/following{/other_user}","gists_url":"https://api.github.com/users/rschamp/gists{/gist_id}","starred_url":"https://api.github.com/users/rschamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschamp/subscriptions","organizations_url":"https://api.github.com/users/rschamp/orgs","repos_url":"https://api.github.com/users/rschamp/repos","events_url":"https://api.github.com/users/rschamp/events{/privacy}","received_events_url":"https://api.github.com/users/rschamp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rschamp/scratch-gui","description":"GraphicaL User Interface for creating and running Scratch 3.0 projects","fork":true,"url":"https://api.github.com/repos/rschamp/scratch-gui","forks_url":"https://api.github.com/repos/rschamp/scratch-gui/forks","keys_url":"https://api.github.com/repos/rschamp/scratch-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rschamp/scratch-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rschamp/scratch-gui/teams","hooks_url":"https://api.github.com/repos/rschamp/scratch-gui/hooks","issue_events_url":"https://api.github.com/repos/rschamp/scratch-gui/issues/events{/number}","events_url":"https://api.github.com/repos/rschamp/scratch-gui/events","assignees_url":"https://api.github.com/repos/rschamp/scratch-gui/assignees{/user}","branches_url":"https://api.github.com/repos/rschamp/scratch-gui/branches{/branch}","tags_url":"https://api.github.com/repos/rschamp/scratch-gui/tags","blobs_url":"https://api.github.com/repos/rschamp/scratch-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rschamp/scratch-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rschamp/scratch-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rschamp/scratch-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rschamp/scratch-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/rschamp/scratch-gui/languages","stargazers_url":"https://api.github.com/repos/rschamp/scratch-gui/stargazers","contributors_url":"https://api.github.com/repos/rschamp/scratch-gui/contributors","subscribers_url":"https://api.github.com/repos/rschamp/scratch-gui/subscribers","subscription_url":"https://api.github.com/repos/rschamp/scratch-gui/subscription","commits_url":"https://api.github.com/repos/rschamp/scratch-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rschamp/scratch-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rschamp/scratch-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rschamp/scratch-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rschamp/scratch-gui/contents/{+path}","compare_url":"https://api.github.com/repos/rschamp/scratch-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rschamp/scratch-gui/merges","archive_url":"https://api.github.com/repos/rschamp/scratch-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rschamp/scratch-gui/downloads","issues_url":"https://api.github.com/repos/rschamp/scratch-gui/issues{/number}","pulls_url":"https://api.github.com/repos/rschamp/scratch-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/rschamp/scratch-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/rschamp/scratch-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rschamp/scratch-gui/labels{/name}","releases_url":"https://api.github.com/repos/rschamp/scratch-gui/releases{/id}","deployments_url":"https://api.github.com/repos/rschamp/scratch-gui/deployments","created_at":"2016-11-23T21:12:38Z","updated_at":"2016-11-24T00:55:00Z","pushed_at":"2018-09-26T22:03:05Z","git_url":"git://github.com/rschamp/scratch-gui.git","ssh_url":"git@github.com:rschamp/scratch-gui.git","clone_url":"https://github.com/rschamp/scratch-gui.git","svn_url":"https://github.com/rschamp/scratch-gui","homepage":null,"size":403463,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"LLK:develop","ref":"develop","sha":"c9386857fc0ce326db6351c5ddf390e7c8cedb46","user":{"login":"LLK","id":3420800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjA4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3420800?v=4","gravatar_id":"","url":"https://api.github.com/users/LLK","html_url":"https://github.com/LLK","followers_url":"https://api.github.com/users/LLK/followers","following_url":"https://api.github.com/users/LLK/following{/other_user}","gists_url":"https://api.github.com/users/LLK/gists{/gist_id}","starred_url":"https://api.github.com/users/LLK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLK/subscriptions","organizations_url":"https://api.github.com/users/LLK/orgs","repos_url":"https://api.github.com/users/LLK/repos","events_url":"https://api.github.com/users/LLK/events{/privacy}","received_events_url":"https://api.github.com/users/LLK/received_events","type":"Organization","site_admin":false},"repo":{"id":68243930,"node_id":"MDEwOlJlcG9zaXRvcnk2ODI0MzkzMA==","name":"scratch-gui","full_name":"LLK/scratch-gui","private":false,"owner":{"login":"LLK","id":3420800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MjA4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3420800?v=4","gravatar_id":"","url":"https://api.github.com/users/LLK","html_url":"https://github.com/LLK","followers_url":"https://api.github.com/users/LLK/followers","following_url":"https://api.github.com/users/LLK/following{/other_user}","gists_url":"https://api.github.com/users/LLK/gists{/gist_id}","starred_url":"https://api.github.com/users/LLK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLK/subscriptions","organizations_url":"https://api.github.com/users/LLK/orgs","repos_url":"https://api.github.com/users/LLK/repos","events_url":"https://api.github.com/users/LLK/events{/privacy}","received_events_url":"https://api.github.com/users/LLK/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LLK/scratch-gui","description":"Graphical User Interface for creating and running Scratch 3.0 projects.","fork":false,"url":"https://api.github.com/repos/LLK/scratch-gui","forks_url":"https://api.github.com/repos/LLK/scratch-gui/forks","keys_url":"https://api.github.com/repos/LLK/scratch-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLK/scratch-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLK/scratch-gui/teams","hooks_url":"https://api.github.com/repos/LLK/scratch-gui/hooks","issue_events_url":"https://api.github.com/repos/LLK/scratch-gui/issues/events{/number}","events_url":"https://api.github.com/repos/LLK/scratch-gui/events","assignees_url":"https://api.github.com/repos/LLK/scratch-gui/assignees{/user}","branches_url":"https://api.github.com/repos/LLK/scratch-gui/branches{/branch}","tags_url":"https://api.github.com/repos/LLK/scratch-gui/tags","blobs_url":"https://api.github.com/repos/LLK/scratch-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLK/scratch-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLK/scratch-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLK/scratch-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLK/scratch-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/LLK/scratch-gui/languages","stargazers_url":"https://api.github.com/repos/LLK/scratch-gui/stargazers","contributors_url":"https://api.github.com/repos/LLK/scratch-gui/contributors","subscribers_url":"https://api.github.com/repos/LLK/scratch-gui/subscribers","subscription_url":"https://api.github.com/repos/LLK/scratch-gui/subscription","commits_url":"https://api.github.com/repos/LLK/scratch-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLK/scratch-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLK/scratch-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLK/scratch-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLK/scratch-gui/contents/{+path}","compare_url":"https://api.github.com/repos/LLK/scratch-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLK/scratch-gui/merges","archive_url":"https://api.github.com/repos/LLK/scratch-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLK/scratch-gui/downloads","issues_url":"https://api.github.com/repos/LLK/scratch-gui/issues{/number}","pulls_url":"https://api.github.com/repos/LLK/scratch-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/LLK/scratch-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/LLK/scratch-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLK/scratch-gui/labels{/name}","releases_url":"https://api.github.com/repos/LLK/scratch-gui/releases{/id}","deployments_url":"https://api.github.com/repos/LLK/scratch-gui/deployments","created_at":"2016-09-14T21:14:10Z","updated_at":"2018-09-27T00:32:22Z","pushed_at":"2018-09-27T01:11:40Z","git_url":"git://github.com/LLK/scratch-gui.git","ssh_url":"git@github.com:LLK/scratch-gui.git","clone_url":"https://github.com/LLK/scratch-gui.git","svn_url":"https://github.com/LLK/scratch-gui","homepage":"https://preview.scratch.mit.edu","size":472171,"stargazers_count":805,"watchers_count":805,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":570,"mirror_url":null,"archived":false,"open_issues_count":574,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":570,"open_issues":574,"watchers":805,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLK/scratch-gui/pulls/3239"},"html":{"href":"https://github.com/LLK/scratch-gui/pull/3239"},"issue":{"href":"https://api.github.com/repos/LLK/scratch-gui/issues/3239"},"comments":{"href":"https://api.github.com/repos/LLK/scratch-gui/issues/3239/comments"},"review_comments":{"href":"https://api.github.com/repos/LLK/scratch-gui/pulls/3239/comments"},"review_comment":{"href":"https://api.github.com/repos/LLK/scratch-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLK/scratch-gui/pulls/3239/commits"},"statuses":{"href":"https://api.github.com/repos/LLK/scratch-gui/statuses/e9febae2f3a33698c37692088b3e5fb07dd4250e"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rschamp","id":1512021,"node_id":"MDQ6VXNlcjE1MTIwMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1512021?v=4","gravatar_id":"","url":"https://api.github.com/users/rschamp","html_url":"https://github.com/rschamp","followers_url":"https://api.github.com/users/rschamp/followers","following_url":"https://api.github.com/users/rschamp/following{/other_user}","gists_url":"https://api.github.com/users/rschamp/gists{/gist_id}","starred_url":"https://api.github.com/users/rschamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschamp/subscriptions","organizations_url":"https://api.github.com/users/rschamp/orgs","repos_url":"https://api.github.com/users/rschamp/repos","events_url":"https://api.github.com/users/rschamp/events{/privacy}","received_events_url":"https://api.github.com/users/rschamp/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":19,"deletions":19,"changed_files":1}}
{"actor":{"display_login":"rschamp"}}