{"action":"created","comment":{"url":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/comments/226262889","pull_request_review_id":166037666,"id":226262889,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjI2Mjg4OQ==","diff_hunk":"@@ -0,0 +1,147 @@\n+defmodule CuriousMaria.ResourcesTest do\n+  use CuriousMaria.DataCase\n+\n+  alias CuriousMaria.Resources\n+\n+  describe \"topics\" do\n+    alias CuriousMaria.Resources.Topic\n+\n+    @valid_attrs %{title: \"some title\", description: \"some description\"}\n+    @update_attrs %{title: \"some updated title\", description: \"some updated description\"}\n+    @invalid_attrs %{title: nil}","path":"test/curious_maria/resources/resources_test.exs","position":11,"original_position":11,"commit_id":"d4a86cc217626194e418a56c881486c9e3a1d218","original_commit_id":"d4a86cc217626194e418a56c881486c9e3a1d218","user":{"login":"trenpixster","id":1025661,"node_id":"MDQ6VXNlcjEwMjU2NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1025661?v=4","gravatar_id":"","url":"https://api.github.com/users/trenpixster","html_url":"https://github.com/trenpixster","followers_url":"https://api.github.com/users/trenpixster/followers","following_url":"https://api.github.com/users/trenpixster/following{/other_user}","gists_url":"https://api.github.com/users/trenpixster/gists{/gist_id}","starred_url":"https://api.github.com/users/trenpixster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trenpixster/subscriptions","organizations_url":"https://api.github.com/users/trenpixster/orgs","repos_url":"https://api.github.com/users/trenpixster/repos","events_url":"https://api.github.com/users/trenpixster/events{/privacy}","received_events_url":"https://api.github.com/users/trenpixster/received_events","type":"User","site_admin":false},"body":"Do you also feel it might get confusing having multiple `@invalid_attrs` in the same file? Given this one is really slim - it only has one field - it might help readability by duplicating the code instead of using `@invalid_attrs`.\r\n\r\nSame line of thought for `@valid_attrs` and `@update_attrs`, since it is only used once, it might help readability and provide added context to colocate the code with the spec.\r\n\r\nI have to admit I tear a tear everytime I see `@module attributes`, it reminds me of `attr_accessor` on Ruby and having my eyes wandering between \"Where did this come from? Is it an argument from the function, or an attribute from the class? (╯°□°）╯︵ ┻━┻\" 😄 ","created_at":"2018-10-18T11:07:54Z","updated_at":"2018-10-18T11:09:26Z","html_url":"https://github.com/pedro-gaspar/curious_maria/pull/3#discussion_r226262889","pull_request_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/comments/226262889"},"html":{"href":"https://github.com/pedro-gaspar/curious_maria/pull/3#discussion_r226262889"},"pull_request":{"href":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/3","id":223827694,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODI3Njk0","html_url":"https://github.com/pedro-gaspar/curious_maria/pull/3","diff_url":"https://github.com/pedro-gaspar/curious_maria/pull/3.diff","patch_url":"https://github.com/pedro-gaspar/curious_maria/pull/3.patch","issue_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/issues/3","number":3,"state":"open","locked":false,"title":"Add Conference model","user":{"login":"pedro-gaspar","id":32003257,"node_id":"MDQ6VXNlcjMyMDAzMjU3","avatar_url":"https://avatars0.githubusercontent.com/u/32003257?v=4","gravatar_id":"","url":"https://api.github.com/users/pedro-gaspar","html_url":"https://github.com/pedro-gaspar","followers_url":"https://api.github.com/users/pedro-gaspar/followers","following_url":"https://api.github.com/users/pedro-gaspar/following{/other_user}","gists_url":"https://api.github.com/users/pedro-gaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-gaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-gaspar/subscriptions","organizations_url":"https://api.github.com/users/pedro-gaspar/orgs","repos_url":"https://api.github.com/users/pedro-gaspar/repos","events_url":"https://api.github.com/users/pedro-gaspar/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-gaspar/received_events","type":"User","site_admin":false},"body":"First check pull request #1\r\n\r\n Used to store tech conferences.","created_at":"2018-10-18T05:14:31Z","updated_at":"2018-10-18T11:09:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1b9d14b41d9828e69286f8d4b1663a9d1a87a92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1095595184,"node_id":"MDU6TGFiZWwxMDk1NTk1MTg0","url":"https://api.github.com/repos/pedro-gaspar/curious_maria/labels/backend","name":"backend","color":"84edd8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/3/commits","review_comments_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/3/comments","review_comment_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/issues/3/comments","statuses_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/statuses/d4a86cc217626194e418a56c881486c9e3a1d218","head":{"label":"pedro-gaspar:feature/conferences-model","ref":"feature/conferences-model","sha":"d4a86cc217626194e418a56c881486c9e3a1d218","user":{"login":"pedro-gaspar","id":32003257,"node_id":"MDQ6VXNlcjMyMDAzMjU3","avatar_url":"https://avatars0.githubusercontent.com/u/32003257?v=4","gravatar_id":"","url":"https://api.github.com/users/pedro-gaspar","html_url":"https://github.com/pedro-gaspar","followers_url":"https://api.github.com/users/pedro-gaspar/followers","following_url":"https://api.github.com/users/pedro-gaspar/following{/other_user}","gists_url":"https://api.github.com/users/pedro-gaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-gaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-gaspar/subscriptions","organizations_url":"https://api.github.com/users/pedro-gaspar/orgs","repos_url":"https://api.github.com/users/pedro-gaspar/repos","events_url":"https://api.github.com/users/pedro-gaspar/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-gaspar/received_events","type":"User","site_admin":false},"repo":{"id":153513383,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM1MTMzODM=","name":"curious_maria","full_name":"pedro-gaspar/curious_maria","private":false,"owner":{"login":"pedro-gaspar","id":32003257,"node_id":"MDQ6VXNlcjMyMDAzMjU3","avatar_url":"https://avatars0.githubusercontent.com/u/32003257?v=4","gravatar_id":"","url":"https://api.github.com/users/pedro-gaspar","html_url":"https://github.com/pedro-gaspar","followers_url":"https://api.github.com/users/pedro-gaspar/followers","following_url":"https://api.github.com/users/pedro-gaspar/following{/other_user}","gists_url":"https://api.github.com/users/pedro-gaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-gaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-gaspar/subscriptions","organizations_url":"https://api.github.com/users/pedro-gaspar/orgs","repos_url":"https://api.github.com/users/pedro-gaspar/repos","events_url":"https://api.github.com/users/pedro-gaspar/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-gaspar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pedro-gaspar/curious_maria","description":"Gather and highlight all useful resources and provide you fresh news about your favorite tech topic.","fork":false,"url":"https://api.github.com/repos/pedro-gaspar/curious_maria","forks_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/forks","keys_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/teams","hooks_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/hooks","issue_events_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/issues/events{/number}","events_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/events","assignees_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/assignees{/user}","branches_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/branches{/branch}","tags_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/tags","blobs_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/statuses/{sha}","languages_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/languages","stargazers_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/stargazers","contributors_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/contributors","subscribers_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/subscribers","subscription_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/subscription","commits_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/issues/comments{/number}","contents_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/contents/{+path}","compare_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/merges","archive_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/downloads","issues_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/issues{/number}","pulls_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls{/number}","milestones_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/milestones{/number}","notifications_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/labels{/name}","releases_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/releases{/id}","deployments_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/deployments","created_at":"2018-10-17T19:37:27Z","updated_at":"2018-10-18T04:41:04Z","pushed_at":"2018-10-18T05:26:51Z","git_url":"git://github.com/pedro-gaspar/curious_maria.git","ssh_url":"git@github.com:pedro-gaspar/curious_maria.git","clone_url":"https://github.com/pedro-gaspar/curious_maria.git","svn_url":"https://github.com/pedro-gaspar/curious_maria","homepage":"","size":121,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"pedro-gaspar:master","ref":"master","sha":"3e9e43561386beac8889c02f7f6de5c67c772540","user":{"login":"pedro-gaspar","id":32003257,"node_id":"MDQ6VXNlcjMyMDAzMjU3","avatar_url":"https://avatars0.githubusercontent.com/u/32003257?v=4","gravatar_id":"","url":"https://api.github.com/users/pedro-gaspar","html_url":"https://github.com/pedro-gaspar","followers_url":"https://api.github.com/users/pedro-gaspar/followers","following_url":"https://api.github.com/users/pedro-gaspar/following{/other_user}","gists_url":"https://api.github.com/users/pedro-gaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-gaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-gaspar/subscriptions","organizations_url":"https://api.github.com/users/pedro-gaspar/orgs","repos_url":"https://api.github.com/users/pedro-gaspar/repos","events_url":"https://api.github.com/users/pedro-gaspar/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-gaspar/received_events","type":"User","site_admin":false},"repo":{"id":153513383,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM1MTMzODM=","name":"curious_maria","full_name":"pedro-gaspar/curious_maria","private":false,"owner":{"login":"pedro-gaspar","id":32003257,"node_id":"MDQ6VXNlcjMyMDAzMjU3","avatar_url":"https://avatars0.githubusercontent.com/u/32003257?v=4","gravatar_id":"","url":"https://api.github.com/users/pedro-gaspar","html_url":"https://github.com/pedro-gaspar","followers_url":"https://api.github.com/users/pedro-gaspar/followers","following_url":"https://api.github.com/users/pedro-gaspar/following{/other_user}","gists_url":"https://api.github.com/users/pedro-gaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-gaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-gaspar/subscriptions","organizations_url":"https://api.github.com/users/pedro-gaspar/orgs","repos_url":"https://api.github.com/users/pedro-gaspar/repos","events_url":"https://api.github.com/users/pedro-gaspar/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-gaspar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pedro-gaspar/curious_maria","description":"Gather and highlight all useful resources and provide you fresh news about your favorite tech topic.","fork":false,"url":"https://api.github.com/repos/pedro-gaspar/curious_maria","forks_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/forks","keys_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/teams","hooks_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/hooks","issue_events_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/issues/events{/number}","events_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/events","assignees_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/assignees{/user}","branches_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/branches{/branch}","tags_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/tags","blobs_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/statuses/{sha}","languages_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/languages","stargazers_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/stargazers","contributors_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/contributors","subscribers_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/subscribers","subscription_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/subscription","commits_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/issues/comments{/number}","contents_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/contents/{+path}","compare_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/merges","archive_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/downloads","issues_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/issues{/number}","pulls_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls{/number}","milestones_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/milestones{/number}","notifications_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/labels{/name}","releases_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/releases{/id}","deployments_url":"https://api.github.com/repos/pedro-gaspar/curious_maria/deployments","created_at":"2018-10-17T19:37:27Z","updated_at":"2018-10-18T04:41:04Z","pushed_at":"2018-10-18T05:26:51Z","git_url":"git://github.com/pedro-gaspar/curious_maria.git","ssh_url":"git@github.com:pedro-gaspar/curious_maria.git","clone_url":"https://github.com/pedro-gaspar/curious_maria.git","svn_url":"https://github.com/pedro-gaspar/curious_maria","homepage":"","size":121,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/3"},"html":{"href":"https://github.com/pedro-gaspar/curious_maria/pull/3"},"issue":{"href":"https://api.github.com/repos/pedro-gaspar/curious_maria/issues/3"},"comments":{"href":"https://api.github.com/repos/pedro-gaspar/curious_maria/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pedro-gaspar/curious_maria/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/pedro-gaspar/curious_maria/statuses/d4a86cc217626194e418a56c881486c9e3a1d218"}},"author_association":"OWNER"}}
{"actor":{"display_login":"trenpixster"}}