{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60308","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60308/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60308/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60308/events","html_url":"https://github.com/kubernetes/kubernetes/pull/60308","id":299718447,"number":60308,"title":"Fix potential issues and bugs in hack/lib/*.sh scripts using shellcheck","user":{"login":"ipuustin","id":998633,"avatar_url":"https://avatars3.githubusercontent.com/u/998633?v=4","gravatar_id":"","url":"https://api.github.com/users/ipuustin","html_url":"https://github.com/ipuustin","followers_url":"https://api.github.com/users/ipuustin/followers","following_url":"https://api.github.com/users/ipuustin/following{/other_user}","gists_url":"https://api.github.com/users/ipuustin/gists{/gist_id}","starred_url":"https://api.github.com/users/ipuustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipuustin/subscriptions","organizations_url":"https://api.github.com/users/ipuustin/orgs","repos_url":"https://api.github.com/users/ipuustin/repos","events_url":"https://api.github.com/users/ipuustin/events{/privacy}","received_events_url":"https://api.github.com/users/ipuustin/received_events","type":"User","site_admin":false},"labels":[{"id":573014062,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-23T13:54:18Z","updated_at":"2018-02-23T13:54:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60308","html_url":"https://github.com/kubernetes/kubernetes/pull/60308","diff_url":"https://github.com/kubernetes/kubernetes/pull/60308.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/60308.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis PR is continuing the work for cleaning up the shell scripts using shellcheck and manual inspection. The plan is to make the scripts more robust in case for unexpected input and also to fix potential bugs.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThe changes are for scripts in `hack/lib/` directory, and as library scripts are used from multiple places. It is not trivial to see all possible places from where the scripts are accessed, so careful review is needed. I tried to make sure that the changes would be compatible for older bash versions too.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/368014955","html_url":"https://github.com/kubernetes/kubernetes/pull/60308#issuecomment-368014955","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60308","id":368014955,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T13:54:26Z","updated_at":"2018-02-23T13:54:26Z","author_association":"COLLABORATOR","body":"Hi @ipuustin. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}