{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/168077130","pull_request_review_id":96385286,"id":168077130,"diff_hunk":"@@ -227,16 +227,17 @@ type ModelSummary struct {\n \tShortName string `json:\"short-name\" yaml:\"short-name\"`\n \tUUID      string `json:\"model-uuid\" yaml:\"model-uuid\"`\n \n-\tControllerUUID     string              `json:\"controller-uuid\" yaml:\"controller-uuid\"`\n-\tControllerName     string              `json:\"controller-name\" yaml:\"controller-name\"`\n-\tOwner              string              `json:\"owner\" yaml:\"owner\"`\n-\tCloud              string              `json:\"cloud\" yaml:\"cloud\"`\n-\tCloudRegion        string              `json:\"region,omitempty\" yaml:\"region,omitempty\"`\n-\tProviderType       string              `json:\"type,omitempty\" yaml:\"type,omitempty\"`\n-\tLife               string              `json:\"life\" yaml:\"life\"`\n-\tStatus             *common.ModelStatus `json:\"status,omitempty\" yaml:\"status,omitempty\"`\n-\tUserAccess         string              `yaml:\"access\" json:\"access\"`\n-\tUserLastConnection string              `yaml:\"last-connection\" json:\"last-connection\"`\n+\tControllerUUID     string                  `json:\"controller-uuid\" yaml:\"controller-uuid\"`\n+\tControllerName     string                  `json:\"controller-name\" yaml:\"controller-name\"`\n+\tOwner              string                  `json:\"owner\" yaml:\"owner\"`\n+\tCloud              string                  `json:\"cloud\" yaml:\"cloud\"`\n+\tCloudRegion        string                  `json:\"region,omitempty\" yaml:\"region,omitempty\"`\n+\tCloudCredential    *common.ModelCredential `json:\"credential,omitempty\" yaml:\"credential,omitempty\"`","path":"cmd/juju/controller/listmodels.go","position":19,"original_position":19,"commit_id":"c3be317ff32503ba5155b3936a70b86ad86156cb","original_commit_id":"c3be317ff32503ba5155b3936a70b86ad86156cb","user":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars0.githubusercontent.com/u/9034160?v=4","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"body":"Currently, our credentials are identified per user per cloud. We display cloud here as it is part of the credential information. I would not want to drop it here without dropping the cloud from the credential name.","created_at":"2018-02-14T04:59:11Z","updated_at":"2018-02-14T04:59:11Z","html_url":"https://github.com/juju/juju/pull/8372#discussion_r168077130","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/8372","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/168077130"},"html":{"href":"https://github.com/juju/juju/pull/8372#discussion_r168077130"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/8372"}},"in_reply_to_id":168076255},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/8372","id":169016130,"html_url":"https://github.com/juju/juju/pull/8372","diff_url":"https://github.com/juju/juju/pull/8372.diff","patch_url":"https://github.com/juju/juju/pull/8372.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/8372","number":8372,"state":"open","locked":false,"title":"Credential UX: show cred in 'show-model' and 'models' (non-tabular formats).","user":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars0.githubusercontent.com/u/9034160?v=4","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"body":"## Description of change\r\n\r\nThere is no means of discovering what cloud credential a model uses unless you look directly in the database.\r\n\r\nThis PR exposes this information as part of the 'show-model' and 'models' (non-tabular formats) outputs.\r\n\r\nWe only show basic credential information deduced from its name - credential name, its owner and what cloud it belongs to.\r\n\r\n## QA steps\r\n\r\n1. bootstrap\r\n2. run 'show-model' or 'models --format=yaml/json'\r\nYou should be able to see the credential you've used.\r\n\r\n## Documentation changes\r\n\r\nPotentially, as part of the effort to improve user understanding around cloud credential management.\r\n\r\n## Bug reference\r\nPart of the solution to improve credential UX.\r\n","created_at":"2018-02-14T03:51:39Z","updated_at":"2018-02-14T04:59:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14b6fd30ea001d212562f9d1b2856c9720c8dc2c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/8372/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/8372/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/8372/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/c3be317ff32503ba5155b3936a70b86ad86156cb","head":{"label":"anastasiamac:show-model-cred","ref":"show-model-cred","sha":"c3be317ff32503ba5155b3936a70b86ad86156cb","user":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars0.githubusercontent.com/u/9034160?v=4","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"repo":{"id":24841340,"name":"juju","full_name":"anastasiamac/juju","owner":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars0.githubusercontent.com/u/9034160?v=4","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anastasiamac/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/anastasiamac/juju","forks_url":"https://api.github.com/repos/anastasiamac/juju/forks","keys_url":"https://api.github.com/repos/anastasiamac/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anastasiamac/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anastasiamac/juju/teams","hooks_url":"https://api.github.com/repos/anastasiamac/juju/hooks","issue_events_url":"https://api.github.com/repos/anastasiamac/juju/issues/events{/number}","events_url":"https://api.github.com/repos/anastasiamac/juju/events","assignees_url":"https://api.github.com/repos/anastasiamac/juju/assignees{/user}","branches_url":"https://api.github.com/repos/anastasiamac/juju/branches{/branch}","tags_url":"https://api.github.com/repos/anastasiamac/juju/tags","blobs_url":"https://api.github.com/repos/anastasiamac/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anastasiamac/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anastasiamac/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/anastasiamac/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anastasiamac/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/anastasiamac/juju/languages","stargazers_url":"https://api.github.com/repos/anastasiamac/juju/stargazers","contributors_url":"https://api.github.com/repos/anastasiamac/juju/contributors","subscribers_url":"https://api.github.com/repos/anastasiamac/juju/subscribers","subscription_url":"https://api.github.com/repos/anastasiamac/juju/subscription","commits_url":"https://api.github.com/repos/anastasiamac/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/anastasiamac/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/anastasiamac/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/anastasiamac/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/anastasiamac/juju/contents/{+path}","compare_url":"https://api.github.com/repos/anastasiamac/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anastasiamac/juju/merges","archive_url":"https://api.github.com/repos/anastasiamac/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anastasiamac/juju/downloads","issues_url":"https://api.github.com/repos/anastasiamac/juju/issues{/number}","pulls_url":"https://api.github.com/repos/anastasiamac/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/anastasiamac/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/anastasiamac/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anastasiamac/juju/labels{/name}","releases_url":"https://api.github.com/repos/anastasiamac/juju/releases{/id}","deployments_url":"https://api.github.com/repos/anastasiamac/juju/deployments","created_at":"2014-10-06T10:12:53Z","updated_at":"2016-01-13T06:23:49Z","pushed_at":"2018-02-14T04:24:20Z","git_url":"git://github.com/anastasiamac/juju.git","ssh_url":"git@github.com:anastasiamac/juju.git","clone_url":"https://github.com/anastasiamac/juju.git","svn_url":"https://github.com/anastasiamac/juju","homepage":"juju.ubuntu.com","size":201436,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:develop","ref":"develop","sha":"2cec2e767384985f36fb147332c35c9be1e96514","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-02-12T15:06:00Z","pushed_at":"2018-02-14T04:42:58Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":206141,"stargazers_count":1095,"watchers_count":1095,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":256,"open_issues":11,"watchers":1095,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/8372"},"html":{"href":"https://github.com/juju/juju/pull/8372"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/8372"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/8372/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/8372/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/8372/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/c3be317ff32503ba5155b3936a70b86ad86156cb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"anastasiamac"}}