{"action":"created","comment":{"url":"https://api.github.com/repos/rchain/rchain/pulls/comments/230779271","pull_request_review_id":171592303,"id":230779271,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDc3OTI3MQ==","diff_hunk":"@@ -51,34 +51,32 @@ class RuntimeManager private (val emptyStateHash: ByteString, runtimeContainer:\n       hash: StateHash,\n       terms: Seq[InternalProcessedDeploy],\n       time: Option[Long] = None\n-  )(\n-      implicit scheduler: Scheduler\n-  ): Either[(Option[Deploy], Failed), StateHash] = {\n-    val runtime = runtimeContainer.take()\n-    unsafeSetTimestamp(time, runtime)\n-    val result = replayEval(terms, runtime, hash)\n-    runtimeContainer.put(runtime)\n-    result\n-  }\n+  ): Task[Either[(Option[Deploy], Failed), StateHash]] =\n+    for {\n+      runtime <- Task.delay(runtimeContainer.take())","path":"casper/src/main/scala/coop/rchain/casper/util/rholang/RuntimeManager.scala","position":24,"original_position":24,"commit_id":"7fa8a10e4bbb17b7881cf26816b6d4b6f3d5c2e5","original_commit_id":"9cc56fc364a6eec3b1b4b82b3ef67f3307c1279e","user":{"login":"ArturGajowy","id":460141,"node_id":"MDQ6VXNlcjQ2MDE0MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460141?v=4","gravatar_id":"","url":"https://api.github.com/users/ArturGajowy","html_url":"https://github.com/ArturGajowy","followers_url":"https://api.github.com/users/ArturGajowy/followers","following_url":"https://api.github.com/users/ArturGajowy/following{/other_user}","gists_url":"https://api.github.com/users/ArturGajowy/gists{/gist_id}","starred_url":"https://api.github.com/users/ArturGajowy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArturGajowy/subscriptions","organizations_url":"https://api.github.com/users/ArturGajowy/orgs","repos_url":"https://api.github.com/users/ArturGajowy/repos","events_url":"https://api.github.com/users/ArturGajowy/events{/privacy}","received_events_url":"https://api.github.com/users/ArturGajowy/received_events","type":"User","site_admin":false},"body":"We have now: https://rchain.atlassian.net/browse/RHOL-1034","created_at":"2018-11-05T14:56:13Z","updated_at":"2018-11-05T14:56:13Z","html_url":"https://github.com/rchain/rchain/pull/1753#discussion_r230779271","pull_request_url":"https://api.github.com/repos/rchain/rchain/pulls/1753","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments/230779271"},"html":{"href":"https://github.com/rchain/rchain/pull/1753#discussion_r230779271"},"pull_request":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1753"}},"in_reply_to_id":229343596},"pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/1753","id":226284913,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2Mjg0OTEz","html_url":"https://github.com/rchain/rchain/pull/1753","diff_url":"https://github.com/rchain/rchain/pull/1753.diff","patch_url":"https://github.com/rchain/rchain/pull/1753.patch","issue_url":"https://api.github.com/repos/rchain/rchain/issues/1753","number":1753,"state":"open","locked":false,"title":"[NO-TICKET] Some refactoring work.","user":{"login":"goral09","id":5120801,"node_id":"MDQ6VXNlcjUxMjA4MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5120801?v=4","gravatar_id":"","url":"https://api.github.com/users/goral09","html_url":"https://github.com/goral09","followers_url":"https://api.github.com/users/goral09/followers","following_url":"https://api.github.com/users/goral09/following{/other_user}","gists_url":"https://api.github.com/users/goral09/gists{/gist_id}","starred_url":"https://api.github.com/users/goral09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goral09/subscriptions","organizations_url":"https://api.github.com/users/goral09/orgs","repos_url":"https://api.github.com/users/goral09/repos","events_url":"https://api.github.com/users/goral09/events{/privacy}","received_events_url":"https://api.github.com/users/goral09/received_events","type":"User","site_admin":false},"body":"## Overview\r\nNo particular JIRA task - just some refactoring I noticed.\r\n\r\n### Which JIRA issue does this PR relate to? If there is not a JIRA issue addressing this work, please create one now and add the link here.\r\nAdd link to corresponding JIRA issue.\r\n\r\n### Complete this checklist before you submit the PR\r\n- [x] This PR contains no more than 200 lines of code, excluding test code.\r\n- [x] This PR meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards).\r\n- [x] If this PR adds a new feature, this PR includes tests related to this feature.\r\n- [x] You assigned one person to review this PR\r\n\r\n### If you are not a member of the core development team, please confirm:\r\n- [ ] You signed the commit. Merging requires a signature. Please see the [developer wiki](https://rchain.atlassian.net/wiki/spaces/DOC/pages/498630673/How+to+sign+commits+to+rchain+rchain) for instructions.\r\n- [ ] Your GitHub account is also an account with [Travis CI](https://travis-ci.org). Unit tests will not run on your PR unless you have an account with Travis. Merge requires passed unit tests.\r\n\r\n### Notes\r\nOptional. Add any notes on caveats, approaches you tried that didn't work, or anything else.\r\n","created_at":"2018-10-27T10:26:19Z","updated_at":"2018-11-05T14:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4f6b2c1d8d1faba7014300a39432e01eba1b49f","assignee":{"login":"ArturGajowy","id":460141,"node_id":"MDQ6VXNlcjQ2MDE0MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460141?v=4","gravatar_id":"","url":"https://api.github.com/users/ArturGajowy","html_url":"https://github.com/ArturGajowy","followers_url":"https://api.github.com/users/ArturGajowy/followers","following_url":"https://api.github.com/users/ArturGajowy/following{/other_user}","gists_url":"https://api.github.com/users/ArturGajowy/gists{/gist_id}","starred_url":"https://api.github.com/users/ArturGajowy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArturGajowy/subscriptions","organizations_url":"https://api.github.com/users/ArturGajowy/orgs","repos_url":"https://api.github.com/users/ArturGajowy/repos","events_url":"https://api.github.com/users/ArturGajowy/events{/privacy}","received_events_url":"https://api.github.com/users/ArturGajowy/received_events","type":"User","site_admin":false},"assignees":[{"login":"ArturGajowy","id":460141,"node_id":"MDQ6VXNlcjQ2MDE0MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460141?v=4","gravatar_id":"","url":"https://api.github.com/users/ArturGajowy","html_url":"https://github.com/ArturGajowy","followers_url":"https://api.github.com/users/ArturGajowy/followers","following_url":"https://api.github.com/users/ArturGajowy/following{/other_user}","gists_url":"https://api.github.com/users/ArturGajowy/gists{/gist_id}","starred_url":"https://api.github.com/users/ArturGajowy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArturGajowy/subscriptions","organizations_url":"https://api.github.com/users/ArturGajowy/orgs","repos_url":"https://api.github.com/users/ArturGajowy/repos","events_url":"https://api.github.com/users/ArturGajowy/events{/privacy}","received_events_url":"https://api.github.com/users/ArturGajowy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"odeac","id":1412609,"node_id":"MDQ6VXNlcjE0MTI2MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1412609?v=4","gravatar_id":"","url":"https://api.github.com/users/odeac","html_url":"https://github.com/odeac","followers_url":"https://api.github.com/users/odeac/followers","following_url":"https://api.github.com/users/odeac/following{/other_user}","gists_url":"https://api.github.com/users/odeac/gists{/gist_id}","starred_url":"https://api.github.com/users/odeac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odeac/subscriptions","organizations_url":"https://api.github.com/users/odeac/orgs","repos_url":"https://api.github.com/users/odeac/repos","events_url":"https://api.github.com/users/odeac/events{/privacy}","received_events_url":"https://api.github.com/users/odeac/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rchain/rchain/pulls/1753/commits","review_comments_url":"https://api.github.com/repos/rchain/rchain/pulls/1753/comments","review_comment_url":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/1753/comments","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/7fa8a10e4bbb17b7881cf26816b6d4b6f3d5c2e5","head":{"label":"goral09:gorski-misc-fixes","ref":"gorski-misc-fixes","sha":"7fa8a10e4bbb17b7881cf26816b6d4b6f3d5c2e5","user":{"login":"goral09","id":5120801,"node_id":"MDQ6VXNlcjUxMjA4MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5120801?v=4","gravatar_id":"","url":"https://api.github.com/users/goral09","html_url":"https://github.com/goral09","followers_url":"https://api.github.com/users/goral09/followers","following_url":"https://api.github.com/users/goral09/following{/other_user}","gists_url":"https://api.github.com/users/goral09/gists{/gist_id}","starred_url":"https://api.github.com/users/goral09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goral09/subscriptions","organizations_url":"https://api.github.com/users/goral09/orgs","repos_url":"https://api.github.com/users/goral09/repos","events_url":"https://api.github.com/users/goral09/events{/privacy}","received_events_url":"https://api.github.com/users/goral09/received_events","type":"User","site_admin":false},"repo":{"id":129659641,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk2NTk2NDE=","name":"rchain","full_name":"goral09/rchain","private":false,"owner":{"login":"goral09","id":5120801,"node_id":"MDQ6VXNlcjUxMjA4MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5120801?v=4","gravatar_id":"","url":"https://api.github.com/users/goral09","html_url":"https://github.com/goral09","followers_url":"https://api.github.com/users/goral09/followers","following_url":"https://api.github.com/users/goral09/following{/other_user}","gists_url":"https://api.github.com/users/goral09/gists{/gist_id}","starred_url":"https://api.github.com/users/goral09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goral09/subscriptions","organizations_url":"https://api.github.com/users/goral09/orgs","repos_url":"https://api.github.com/users/goral09/repos","events_url":"https://api.github.com/users/goral09/events{/privacy}","received_events_url":"https://api.github.com/users/goral09/received_events","type":"User","site_admin":false},"html_url":"https://github.com/goral09/rchain","description":null,"fork":true,"url":"https://api.github.com/repos/goral09/rchain","forks_url":"https://api.github.com/repos/goral09/rchain/forks","keys_url":"https://api.github.com/repos/goral09/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goral09/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goral09/rchain/teams","hooks_url":"https://api.github.com/repos/goral09/rchain/hooks","issue_events_url":"https://api.github.com/repos/goral09/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/goral09/rchain/events","assignees_url":"https://api.github.com/repos/goral09/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/goral09/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/goral09/rchain/tags","blobs_url":"https://api.github.com/repos/goral09/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goral09/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goral09/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/goral09/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goral09/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/goral09/rchain/languages","stargazers_url":"https://api.github.com/repos/goral09/rchain/stargazers","contributors_url":"https://api.github.com/repos/goral09/rchain/contributors","subscribers_url":"https://api.github.com/repos/goral09/rchain/subscribers","subscription_url":"https://api.github.com/repos/goral09/rchain/subscription","commits_url":"https://api.github.com/repos/goral09/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/goral09/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/goral09/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/goral09/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/goral09/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/goral09/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goral09/rchain/merges","archive_url":"https://api.github.com/repos/goral09/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goral09/rchain/downloads","issues_url":"https://api.github.com/repos/goral09/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/goral09/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/goral09/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/goral09/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goral09/rchain/labels{/name}","releases_url":"https://api.github.com/repos/goral09/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/goral09/rchain/deployments","created_at":"2018-04-15T23:24:40Z","updated_at":"2018-04-25T19:11:17Z","pushed_at":"2018-11-05T14:47:10Z","git_url":"git://github.com/goral09/rchain.git","ssh_url":"git@github.com:goral09/rchain.git","clone_url":"https://github.com/goral09/rchain.git","svn_url":"https://github.com/goral09/rchain","homepage":null,"size":19720,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rchain:dev","ref":"dev","sha":"4ac57a0fecd4175fcd0b7773d48f31894afe19d5","user":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"repo":{"id":84493691,"node_id":"MDEwOlJlcG9zaXRvcnk4NDQ5MzY5MQ==","name":"rchain","full_name":"rchain/rchain","private":false,"owner":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rchain/rchain","description":null,"fork":false,"url":"https://api.github.com/repos/rchain/rchain","forks_url":"https://api.github.com/repos/rchain/rchain/forks","keys_url":"https://api.github.com/repos/rchain/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchain/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchain/rchain/teams","hooks_url":"https://api.github.com/repos/rchain/rchain/hooks","issue_events_url":"https://api.github.com/repos/rchain/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/rchain/rchain/events","assignees_url":"https://api.github.com/repos/rchain/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/rchain/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/rchain/rchain/tags","blobs_url":"https://api.github.com/repos/rchain/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchain/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchain/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchain/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/rchain/rchain/languages","stargazers_url":"https://api.github.com/repos/rchain/rchain/stargazers","contributors_url":"https://api.github.com/repos/rchain/rchain/contributors","subscribers_url":"https://api.github.com/repos/rchain/rchain/subscribers","subscription_url":"https://api.github.com/repos/rchain/rchain/subscription","commits_url":"https://api.github.com/repos/rchain/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchain/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchain/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchain/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchain/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/rchain/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchain/rchain/merges","archive_url":"https://api.github.com/repos/rchain/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchain/rchain/downloads","issues_url":"https://api.github.com/repos/rchain/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/rchain/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/rchain/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/rchain/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchain/rchain/labels{/name}","releases_url":"https://api.github.com/repos/rchain/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/rchain/rchain/deployments","created_at":"2017-03-09T22:15:35Z","updated_at":"2018-11-03T07:23:17Z","pushed_at":"2018-11-05T11:30:30Z","git_url":"git://github.com/rchain/rchain.git","ssh_url":"git@github.com:rchain/rchain.git","clone_url":"https://github.com/rchain/rchain.git","svn_url":"https://github.com/rchain/rchain","homepage":null,"size":19247,"stargazers_count":470,"watchers_count":470,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":139,"open_issues":33,"watchers":470,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1753"},"html":{"href":"https://github.com/rchain/rchain/pull/1753"},"issue":{"href":"https://api.github.com/repos/rchain/rchain/issues/1753"},"comments":{"href":"https://api.github.com/repos/rchain/rchain/issues/1753/comments"},"review_comments":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1753/comments"},"review_comment":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1753/commits"},"statuses":{"href":"https://api.github.com/repos/rchain/rchain/statuses/7fa8a10e4bbb17b7881cf26816b6d4b6f3d5c2e5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ArturGajowy"}}