{"action":"created","comment":{"url":"https://api.github.com/repos/http4s/http4s/pulls/comments/217903430","pull_request_review_id":155733305,"id":217903430,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzkwMzQzMA==","diff_hunk":"@@ -106,6 +106,19 @@ object UrlForm {\n     x.values.mapValues(_.toList).view.force === y.values.mapValues(_.toList).view.force\n   }\n \n+  implicit val monoidInstance: Monoid[UrlForm] = new Monoid[UrlForm] {\n+    override def empty: UrlForm = UrlForm.empty\n+\n+    override def combine(x: UrlForm, y: UrlForm): UrlForm =\n+      UrlForm(x.values.foldLeft(y.values) {","path":"core/src/main/scala/org/http4s/UrlForm.scala","position":8,"original_position":8,"commit_id":"f2af07d7f0dea654f9953224c7918b3c9c2a8a10","original_commit_id":"f2af07d7f0dea654f9953224c7918b3c9c2a8a10","user":{"login":"bpholt","id":1455476,"node_id":"MDQ6VXNlcjE0NTU0NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1455476?v=4","gravatar_id":"","url":"https://api.github.com/users/bpholt","html_url":"https://github.com/bpholt","followers_url":"https://api.github.com/users/bpholt/followers","following_url":"https://api.github.com/users/bpholt/following{/other_user}","gists_url":"https://api.github.com/users/bpholt/gists{/gist_id}","starred_url":"https://api.github.com/users/bpholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpholt/subscriptions","organizations_url":"https://api.github.com/users/bpholt/orgs","repos_url":"https://api.github.com/users/bpholt/repos","events_url":"https://api.github.com/users/bpholt/events{/privacy}","received_events_url":"https://api.github.com/users/bpholt/received_events","type":"User","site_admin":false},"body":"I borrowed this implementation from [`MapMonoid`](https://github.com/typelevel/cats/blob/97052b8673afbcd0f8bb79dd7cc273d0e6049bdc/kernel/src/main/scala/cats/kernel/instances/map.scala#L61-L70), more or less inlining the implementation of `Semigroup.maybeCombine`, because [there's no `Monoid[Seq[?]]` instance](https://github.com/typelevel/cats/issues/1222) in cats. Open to alternatives.","created_at":"2018-09-16T06:15:11Z","updated_at":"2018-09-16T06:15:11Z","html_url":"https://github.com/http4s/http4s/pull/2086#discussion_r217903430","pull_request_url":"https://api.github.com/repos/http4s/http4s/pulls/2086","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/http4s/http4s/pulls/comments/217903430"},"html":{"href":"https://github.com/http4s/http4s/pull/2086#discussion_r217903430"},"pull_request":{"href":"https://api.github.com/repos/http4s/http4s/pulls/2086"}}},"pull_request":{"url":"https://api.github.com/repos/http4s/http4s/pulls/2086","id":215781317,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzgxMzE3","html_url":"https://github.com/http4s/http4s/pull/2086","diff_url":"https://github.com/http4s/http4s/pull/2086.diff","patch_url":"https://github.com/http4s/http4s/pull/2086.patch","issue_url":"https://api.github.com/repos/http4s/http4s/issues/2086","number":2086,"state":"open","locked":false,"title":"add Monoid instance for UrlForm","user":{"login":"bpholt","id":1455476,"node_id":"MDQ6VXNlcjE0NTU0NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1455476?v=4","gravatar_id":"","url":"https://api.github.com/users/bpholt","html_url":"https://github.com/bpholt","followers_url":"https://api.github.com/users/bpholt/followers","following_url":"https://api.github.com/users/bpholt/following{/other_user}","gists_url":"https://api.github.com/users/bpholt/gists{/gist_id}","starred_url":"https://api.github.com/users/bpholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpholt/subscriptions","organizations_url":"https://api.github.com/users/bpholt/orgs","repos_url":"https://api.github.com/users/bpholt/repos","events_url":"https://api.github.com/users/bpholt/events{/privacy}","received_events_url":"https://api.github.com/users/bpholt/received_events","type":"User","site_admin":false},"body":"The tests I added are pretty rudimentary. I'm open to suggestions or even just a pointer to another Monoid instance's tests that would be good to emulate.","created_at":"2018-09-15T17:56:50Z","updated_at":"2018-09-16T06:15:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a259ea57f5d9e7e1bbcd6aeb3a5e5b9b96f14edb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/http4s/http4s/pulls/2086/commits","review_comments_url":"https://api.github.com/repos/http4s/http4s/pulls/2086/comments","review_comment_url":"https://api.github.com/repos/http4s/http4s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/http4s/http4s/issues/2086/comments","statuses_url":"https://api.github.com/repos/http4s/http4s/statuses/f2af07d7f0dea654f9953224c7918b3c9c2a8a10","head":{"label":"Dwolla:urlform-monoid","ref":"urlform-monoid","sha":"f2af07d7f0dea654f9953224c7918b3c9c2a8a10","user":{"login":"Dwolla","id":823934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyMzkzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/823934?v=4","gravatar_id":"","url":"https://api.github.com/users/Dwolla","html_url":"https://github.com/Dwolla","followers_url":"https://api.github.com/users/Dwolla/followers","following_url":"https://api.github.com/users/Dwolla/following{/other_user}","gists_url":"https://api.github.com/users/Dwolla/gists{/gist_id}","starred_url":"https://api.github.com/users/Dwolla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dwolla/subscriptions","organizations_url":"https://api.github.com/users/Dwolla/orgs","repos_url":"https://api.github.com/users/Dwolla/repos","events_url":"https://api.github.com/users/Dwolla/events{/privacy}","received_events_url":"https://api.github.com/users/Dwolla/received_events","type":"Organization","site_admin":false},"repo":{"id":101826750,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE4MjY3NTA=","name":"http4s","full_name":"Dwolla/http4s","private":false,"owner":{"login":"Dwolla","id":823934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyMzkzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/823934?v=4","gravatar_id":"","url":"https://api.github.com/users/Dwolla","html_url":"https://github.com/Dwolla","followers_url":"https://api.github.com/users/Dwolla/followers","following_url":"https://api.github.com/users/Dwolla/following{/other_user}","gists_url":"https://api.github.com/users/Dwolla/gists{/gist_id}","starred_url":"https://api.github.com/users/Dwolla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dwolla/subscriptions","organizations_url":"https://api.github.com/users/Dwolla/orgs","repos_url":"https://api.github.com/users/Dwolla/repos","events_url":"https://api.github.com/users/Dwolla/events{/privacy}","received_events_url":"https://api.github.com/users/Dwolla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Dwolla/http4s","description":"A minimal, idiomatic Scala interface for HTTP","fork":true,"url":"https://api.github.com/repos/Dwolla/http4s","forks_url":"https://api.github.com/repos/Dwolla/http4s/forks","keys_url":"https://api.github.com/repos/Dwolla/http4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dwolla/http4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dwolla/http4s/teams","hooks_url":"https://api.github.com/repos/Dwolla/http4s/hooks","issue_events_url":"https://api.github.com/repos/Dwolla/http4s/issues/events{/number}","events_url":"https://api.github.com/repos/Dwolla/http4s/events","assignees_url":"https://api.github.com/repos/Dwolla/http4s/assignees{/user}","branches_url":"https://api.github.com/repos/Dwolla/http4s/branches{/branch}","tags_url":"https://api.github.com/repos/Dwolla/http4s/tags","blobs_url":"https://api.github.com/repos/Dwolla/http4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dwolla/http4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dwolla/http4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dwolla/http4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dwolla/http4s/statuses/{sha}","languages_url":"https://api.github.com/repos/Dwolla/http4s/languages","stargazers_url":"https://api.github.com/repos/Dwolla/http4s/stargazers","contributors_url":"https://api.github.com/repos/Dwolla/http4s/contributors","subscribers_url":"https://api.github.com/repos/Dwolla/http4s/subscribers","subscription_url":"https://api.github.com/repos/Dwolla/http4s/subscription","commits_url":"https://api.github.com/repos/Dwolla/http4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dwolla/http4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dwolla/http4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dwolla/http4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dwolla/http4s/contents/{+path}","compare_url":"https://api.github.com/repos/Dwolla/http4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dwolla/http4s/merges","archive_url":"https://api.github.com/repos/Dwolla/http4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dwolla/http4s/downloads","issues_url":"https://api.github.com/repos/Dwolla/http4s/issues{/number}","pulls_url":"https://api.github.com/repos/Dwolla/http4s/pulls{/number}","milestones_url":"https://api.github.com/repos/Dwolla/http4s/milestones{/number}","notifications_url":"https://api.github.com/repos/Dwolla/http4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dwolla/http4s/labels{/name}","releases_url":"https://api.github.com/repos/Dwolla/http4s/releases{/id}","deployments_url":"https://api.github.com/repos/Dwolla/http4s/deployments","created_at":"2017-08-30T02:08:15Z","updated_at":"2018-05-01T06:19:49Z","pushed_at":"2018-09-16T06:11:09Z","git_url":"git://github.com/Dwolla/http4s.git","ssh_url":"git@github.com:Dwolla/http4s.git","clone_url":"https://github.com/Dwolla/http4s.git","svn_url":"https://github.com/Dwolla/http4s","homepage":"http://http4s.org/","size":65146,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"http4s:master","ref":"master","sha":"a37e81370037141052972bd27bad3bfa9b73a179","user":{"login":"http4s","id":1527492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Mjc0OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1527492?v=4","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"repo":{"id":3692188,"node_id":"MDEwOlJlcG9zaXRvcnkzNjkyMTg4","name":"http4s","full_name":"http4s/http4s","private":false,"owner":{"login":"http4s","id":1527492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Mjc0OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1527492?v=4","gravatar_id":"","url":"https://api.github.com/users/http4s","html_url":"https://github.com/http4s","followers_url":"https://api.github.com/users/http4s/followers","following_url":"https://api.github.com/users/http4s/following{/other_user}","gists_url":"https://api.github.com/users/http4s/gists{/gist_id}","starred_url":"https://api.github.com/users/http4s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http4s/subscriptions","organizations_url":"https://api.github.com/users/http4s/orgs","repos_url":"https://api.github.com/users/http4s/repos","events_url":"https://api.github.com/users/http4s/events{/privacy}","received_events_url":"https://api.github.com/users/http4s/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/http4s/http4s","description":"A minimal, idiomatic Scala interface for HTTP","fork":false,"url":"https://api.github.com/repos/http4s/http4s","forks_url":"https://api.github.com/repos/http4s/http4s/forks","keys_url":"https://api.github.com/repos/http4s/http4s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/http4s/http4s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/http4s/http4s/teams","hooks_url":"https://api.github.com/repos/http4s/http4s/hooks","issue_events_url":"https://api.github.com/repos/http4s/http4s/issues/events{/number}","events_url":"https://api.github.com/repos/http4s/http4s/events","assignees_url":"https://api.github.com/repos/http4s/http4s/assignees{/user}","branches_url":"https://api.github.com/repos/http4s/http4s/branches{/branch}","tags_url":"https://api.github.com/repos/http4s/http4s/tags","blobs_url":"https://api.github.com/repos/http4s/http4s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/http4s/http4s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/http4s/http4s/git/refs{/sha}","trees_url":"https://api.github.com/repos/http4s/http4s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/http4s/http4s/statuses/{sha}","languages_url":"https://api.github.com/repos/http4s/http4s/languages","stargazers_url":"https://api.github.com/repos/http4s/http4s/stargazers","contributors_url":"https://api.github.com/repos/http4s/http4s/contributors","subscribers_url":"https://api.github.com/repos/http4s/http4s/subscribers","subscription_url":"https://api.github.com/repos/http4s/http4s/subscription","commits_url":"https://api.github.com/repos/http4s/http4s/commits{/sha}","git_commits_url":"https://api.github.com/repos/http4s/http4s/git/commits{/sha}","comments_url":"https://api.github.com/repos/http4s/http4s/comments{/number}","issue_comment_url":"https://api.github.com/repos/http4s/http4s/issues/comments{/number}","contents_url":"https://api.github.com/repos/http4s/http4s/contents/{+path}","compare_url":"https://api.github.com/repos/http4s/http4s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/http4s/http4s/merges","archive_url":"https://api.github.com/repos/http4s/http4s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/http4s/http4s/downloads","issues_url":"https://api.github.com/repos/http4s/http4s/issues{/number}","pulls_url":"https://api.github.com/repos/http4s/http4s/pulls{/number}","milestones_url":"https://api.github.com/repos/http4s/http4s/milestones{/number}","notifications_url":"https://api.github.com/repos/http4s/http4s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/http4s/http4s/labels{/name}","releases_url":"https://api.github.com/repos/http4s/http4s/releases{/id}","deployments_url":"https://api.github.com/repos/http4s/http4s/deployments","created_at":"2012-03-12T04:41:20Z","updated_at":"2018-09-15T01:15:26Z","pushed_at":"2018-09-16T06:11:11Z","git_url":"git://github.com/http4s/http4s.git","ssh_url":"git@github.com:http4s/http4s.git","clone_url":"https://github.com/http4s/http4s.git","svn_url":"https://github.com/http4s/http4s","homepage":"https://http4s.org/","size":133544,"stargazers_count":1265,"watchers_count":1265,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":354,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":354,"open_issues":159,"watchers":1265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/http4s/http4s/pulls/2086"},"html":{"href":"https://github.com/http4s/http4s/pull/2086"},"issue":{"href":"https://api.github.com/repos/http4s/http4s/issues/2086"},"comments":{"href":"https://api.github.com/repos/http4s/http4s/issues/2086/comments"},"review_comments":{"href":"https://api.github.com/repos/http4s/http4s/pulls/2086/comments"},"review_comment":{"href":"https://api.github.com/repos/http4s/http4s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/http4s/http4s/pulls/2086/commits"},"statuses":{"href":"https://api.github.com/repos/http4s/http4s/statuses/f2af07d7f0dea654f9953224c7918b3c9c2a8a10"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bpholt"}}