{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/consul/pulls/comments/203296678","pull_request_review_id":138152752,"id":203296678,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzI5NjY3OA==","diff_hunk":"@@ -50,6 +50,24 @@ const (\n \twatchLimit = 2048\n )\n \n+// StoreConfig Handle a StoreConfig to handle particular behaviours","path":"agent/consul/state/state_store.go","position":4,"original_position":4,"commit_id":"db69d5cec8e9fe1b54db49e76035fd3c0b5e9372","original_commit_id":"db69d5cec8e9fe1b54db49e76035fd3c0b5e9372","user":{"login":"yfouquet","id":22475230,"node_id":"MDQ6VXNlcjIyNDc1MjMw","avatar_url":"https://avatars2.githubusercontent.com/u/22475230?v=4","gravatar_id":"","url":"https://api.github.com/users/yfouquet","html_url":"https://github.com/yfouquet","followers_url":"https://api.github.com/users/yfouquet/followers","following_url":"https://api.github.com/users/yfouquet/following{/other_user}","gists_url":"https://api.github.com/users/yfouquet/gists{/gist_id}","starred_url":"https://api.github.com/users/yfouquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yfouquet/subscriptions","organizations_url":"https://api.github.com/users/yfouquet/orgs","repos_url":"https://api.github.com/users/yfouquet/repos","events_url":"https://api.github.com/users/yfouquet/events{/privacy}","received_events_url":"https://api.github.com/users/yfouquet/received_events","type":"User","site_admin":false},"body":"Not really clear; i guess the start of the comment should have been removed?","created_at":"2018-07-18T08:43:00Z","updated_at":"2018-07-18T08:48:20Z","html_url":"https://github.com/hashicorp/consul/pull/4399#discussion_r203296678","pull_request_url":"https://api.github.com/repos/hashicorp/consul/pulls/4399","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/consul/pulls/comments/203296678"},"html":{"href":"https://github.com/hashicorp/consul/pull/4399#discussion_r203296678"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/consul/pulls/4399"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/consul/pulls/4399","id":201673521,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNjczNTIx","html_url":"https://github.com/hashicorp/consul/pull/4399","diff_url":"https://github.com/hashicorp/consul/pull/4399.diff","patch_url":"https://github.com/hashicorp/consul/pull/4399.patch","issue_url":"https://api.github.com/repos/hashicorp/consul/issues/4399","number":4399,"state":"open","locked":false,"title":"Node renaming - Support for allow_node_renaming","user":{"login":"pierresouchay","id":8089033,"node_id":"MDQ6VXNlcjgwODkwMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/8089033?v=4","gravatar_id":"","url":"https://api.github.com/users/pierresouchay","html_url":"https://github.com/pierresouchay","followers_url":"https://api.github.com/users/pierresouchay/followers","following_url":"https://api.github.com/users/pierresouchay/following{/other_user}","gists_url":"https://api.github.com/users/pierresouchay/gists{/gist_id}","starred_url":"https://api.github.com/users/pierresouchay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierresouchay/subscriptions","organizations_url":"https://api.github.com/users/pierresouchay/orgs","repos_url":"https://api.github.com/users/pierresouchay/repos","events_url":"https://api.github.com/users/pierresouchay/events{/privacy}","received_events_url":"https://api.github.com/users/pierresouchay/received_events","type":"User","site_admin":false},"body":"This PR replaces https://github.com/hashicorp/consul/pull/3983 and will fix #3974\r\n\r\nIt will allow node renaming if:\r\n * node does not conflict with another node name (case insensitive comparison)\r\n * new option allow_node_renaming is set on true (false by default)\r\n\r\nThis will ensure we do not break ascending compatibility","created_at":"2018-07-16T15:25:08Z","updated_at":"2018-07-18T08:48:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f57bd429726adcd34401a859634798c78530b26","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/consul/pulls/4399/commits","review_comments_url":"https://api.github.com/repos/hashicorp/consul/pulls/4399/comments","review_comment_url":"https://api.github.com/repos/hashicorp/consul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/consul/issues/4399/comments","statuses_url":"https://api.github.com/repos/hashicorp/consul/statuses/db69d5cec8e9fe1b54db49e76035fd3c0b5e9372","head":{"label":"pierresouchay:node_renaming","ref":"node_renaming","sha":"db69d5cec8e9fe1b54db49e76035fd3c0b5e9372","user":{"login":"pierresouchay","id":8089033,"node_id":"MDQ6VXNlcjgwODkwMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/8089033?v=4","gravatar_id":"","url":"https://api.github.com/users/pierresouchay","html_url":"https://github.com/pierresouchay","followers_url":"https://api.github.com/users/pierresouchay/followers","following_url":"https://api.github.com/users/pierresouchay/following{/other_user}","gists_url":"https://api.github.com/users/pierresouchay/gists{/gist_id}","starred_url":"https://api.github.com/users/pierresouchay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierresouchay/subscriptions","organizations_url":"https://api.github.com/users/pierresouchay/orgs","repos_url":"https://api.github.com/users/pierresouchay/repos","events_url":"https://api.github.com/users/pierresouchay/events{/privacy}","received_events_url":"https://api.github.com/users/pierresouchay/received_events","type":"User","site_admin":false},"repo":{"id":120542999,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA1NDI5OTk=","name":"consul","full_name":"pierresouchay/consul","owner":{"login":"pierresouchay","id":8089033,"node_id":"MDQ6VXNlcjgwODkwMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/8089033?v=4","gravatar_id":"","url":"https://api.github.com/users/pierresouchay","html_url":"https://github.com/pierresouchay","followers_url":"https://api.github.com/users/pierresouchay/followers","following_url":"https://api.github.com/users/pierresouchay/following{/other_user}","gists_url":"https://api.github.com/users/pierresouchay/gists{/gist_id}","starred_url":"https://api.github.com/users/pierresouchay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierresouchay/subscriptions","organizations_url":"https://api.github.com/users/pierresouchay/orgs","repos_url":"https://api.github.com/users/pierresouchay/repos","events_url":"https://api.github.com/users/pierresouchay/events{/privacy}","received_events_url":"https://api.github.com/users/pierresouchay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pierresouchay/consul","description":"Consul is a distributed, highly available, and data center aware solution to connect and configure applications across dynamic, distributed infrastructure.","fork":true,"url":"https://api.github.com/repos/pierresouchay/consul","forks_url":"https://api.github.com/repos/pierresouchay/consul/forks","keys_url":"https://api.github.com/repos/pierresouchay/consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pierresouchay/consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pierresouchay/consul/teams","hooks_url":"https://api.github.com/repos/pierresouchay/consul/hooks","issue_events_url":"https://api.github.com/repos/pierresouchay/consul/issues/events{/number}","events_url":"https://api.github.com/repos/pierresouchay/consul/events","assignees_url":"https://api.github.com/repos/pierresouchay/consul/assignees{/user}","branches_url":"https://api.github.com/repos/pierresouchay/consul/branches{/branch}","tags_url":"https://api.github.com/repos/pierresouchay/consul/tags","blobs_url":"https://api.github.com/repos/pierresouchay/consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pierresouchay/consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pierresouchay/consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/pierresouchay/consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pierresouchay/consul/statuses/{sha}","languages_url":"https://api.github.com/repos/pierresouchay/consul/languages","stargazers_url":"https://api.github.com/repos/pierresouchay/consul/stargazers","contributors_url":"https://api.github.com/repos/pierresouchay/consul/contributors","subscribers_url":"https://api.github.com/repos/pierresouchay/consul/subscribers","subscription_url":"https://api.github.com/repos/pierresouchay/consul/subscription","commits_url":"https://api.github.com/repos/pierresouchay/consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/pierresouchay/consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/pierresouchay/consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/pierresouchay/consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/pierresouchay/consul/contents/{+path}","compare_url":"https://api.github.com/repos/pierresouchay/consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pierresouchay/consul/merges","archive_url":"https://api.github.com/repos/pierresouchay/consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pierresouchay/consul/downloads","issues_url":"https://api.github.com/repos/pierresouchay/consul/issues{/number}","pulls_url":"https://api.github.com/repos/pierresouchay/consul/pulls{/number}","milestones_url":"https://api.github.com/repos/pierresouchay/consul/milestones{/number}","notifications_url":"https://api.github.com/repos/pierresouchay/consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pierresouchay/consul/labels{/name}","releases_url":"https://api.github.com/repos/pierresouchay/consul/releases{/id}","deployments_url":"https://api.github.com/repos/pierresouchay/consul/deployments","created_at":"2018-02-07T00:50:05Z","updated_at":"2018-02-07T00:50:09Z","pushed_at":"2018-07-17T16:03:29Z","git_url":"git://github.com/pierresouchay/consul.git","ssh_url":"git@github.com:pierresouchay/consul.git","clone_url":"https://github.com/pierresouchay/consul.git","svn_url":"https://github.com/pierresouchay/consul","homepage":"https://www.consul.io/","size":58007,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"4ec8c489c077b7c863ab9a7dc2344a45ea65a4da","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":14125254,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNTI1NA==","name":"consul","full_name":"hashicorp/consul","owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/consul","description":"Consul is a distributed, highly available, and data center aware solution to connect and configure applications across dynamic, distributed infrastructure.","fork":false,"url":"https://api.github.com/repos/hashicorp/consul","forks_url":"https://api.github.com/repos/hashicorp/consul/forks","keys_url":"https://api.github.com/repos/hashicorp/consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/consul/teams","hooks_url":"https://api.github.com/repos/hashicorp/consul/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/consul/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/consul/events","assignees_url":"https://api.github.com/repos/hashicorp/consul/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/consul/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/consul/tags","blobs_url":"https://api.github.com/repos/hashicorp/consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/consul/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/consul/languages","stargazers_url":"https://api.github.com/repos/hashicorp/consul/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/consul/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/consul/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/consul/subscription","commits_url":"https://api.github.com/repos/hashicorp/consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/consul/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/consul/merges","archive_url":"https://api.github.com/repos/hashicorp/consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/consul/downloads","issues_url":"https://api.github.com/repos/hashicorp/consul/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/consul/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/consul/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/consul/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/consul/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/consul/deployments","created_at":"2013-11-04T22:15:27Z","updated_at":"2018-07-18T08:33:51Z","pushed_at":"2018-07-17T20:49:09Z","git_url":"git://github.com/hashicorp/consul.git","ssh_url":"git@github.com:hashicorp/consul.git","clone_url":"https://github.com/hashicorp/consul.git","svn_url":"https://github.com/hashicorp/consul","homepage":"https://www.consul.io/","size":58811,"stargazers_count":12810,"watchers_count":12810,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2263,"mirror_url":null,"archived":false,"open_issues_count":468,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2263,"open_issues":468,"watchers":12810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/consul/pulls/4399"},"html":{"href":"https://github.com/hashicorp/consul/pull/4399"},"issue":{"href":"https://api.github.com/repos/hashicorp/consul/issues/4399"},"comments":{"href":"https://api.github.com/repos/hashicorp/consul/issues/4399/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/consul/pulls/4399/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/consul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/consul/pulls/4399/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/consul/statuses/db69d5cec8e9fe1b54db49e76035fd3c0b5e9372"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yfouquet"}}