{"action":"created","issue":{"url":"https://api.github.com/repos/js-joda/js-joda/issues/265","repository_url":"https://api.github.com/repos/js-joda/js-joda","labels_url":"https://api.github.com/repos/js-joda/js-joda/issues/265/labels{/name}","comments_url":"https://api.github.com/repos/js-joda/js-joda/issues/265/comments","events_url":"https://api.github.com/repos/js-joda/js-joda/issues/265/events","html_url":"https://github.com/js-joda/js-joda/pull/265","id":367958868,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjQ3ODA0","number":265,"title":"Add `ZoneId#id()` to type definitions","user":{"login":"firoxer","id":5222805,"node_id":"MDQ6VXNlcjUyMjI4MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5222805?v=4","gravatar_id":"","url":"https://api.github.com/users/firoxer","html_url":"https://github.com/firoxer","followers_url":"https://api.github.com/users/firoxer/followers","following_url":"https://api.github.com/users/firoxer/following{/other_user}","gists_url":"https://api.github.com/users/firoxer/gists{/gist_id}","starred_url":"https://api.github.com/users/firoxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firoxer/subscriptions","organizations_url":"https://api.github.com/users/firoxer/orgs","repos_url":"https://api.github.com/users/firoxer/repos","events_url":"https://api.github.com/users/firoxer/events{/privacy}","received_events_url":"https://api.github.com/users/firoxer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-08T21:26:44Z","updated_at":"2018-10-10T06:49:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/js-joda/js-joda/pulls/265","html_url":"https://github.com/js-joda/js-joda/pull/265","diff_url":"https://github.com/js-joda/js-joda/pull/265.diff","patch_url":"https://github.com/js-joda/js-joda/pull/265.patch"},"body":"Hi, I noticed #264 and thought it would be a small change to fix it. I corrected both the TypeScript and Flow definitions assuming that the docs about the return type at https://github.com/js-joda/js-joda/blob/2ea179c3588f848b16254db41c19849cc8992e94/src/ZoneId.js#L133 are correct. Hope this is alright."},"comment":{"url":"https://api.github.com/repos/js-joda/js-joda/issues/comments/428457673","html_url":"https://github.com/js-joda/js-joda/pull/265#issuecomment-428457673","issue_url":"https://api.github.com/repos/js-joda/js-joda/issues/265","id":428457673,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODQ1NzY3Mw==","user":{"login":"pithu","id":1837621,"node_id":"MDQ6VXNlcjE4Mzc2MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1837621?v=4","gravatar_id":"","url":"https://api.github.com/users/pithu","html_url":"https://github.com/pithu","followers_url":"https://api.github.com/users/pithu/followers","following_url":"https://api.github.com/users/pithu/following{/other_user}","gists_url":"https://api.github.com/users/pithu/gists{/gist_id}","starred_url":"https://api.github.com/users/pithu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pithu/subscriptions","organizations_url":"https://api.github.com/users/pithu/orgs","repos_url":"https://api.github.com/users/pithu/repos","events_url":"https://api.github.com/users/pithu/events{/privacy}","received_events_url":"https://api.github.com/users/pithu/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T06:49:13Z","updated_at":"2018-10-10T06:49:13Z","author_association":"MEMBER","body":"Hi @firoxer thanks for using js-joda and for contributing.\r\n\r\nCould you add a section to the typescript test file as well `test/typescript_defintions/js-joda-tests.ts` ?\r\n\r\nThat would be very helpful"}}
{"actor":{"display_login":"pithu"}}