{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64189","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64189/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64189/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64189/events","html_url":"https://github.com/kubernetes/kubernetes/pull/64189","id":325599090,"number":64189,"title":"Fix Windows CNI for the sandbox case","user":{"login":"alinbalutoiu","id":12464768,"avatar_url":"https://avatars2.githubusercontent.com/u/12464768?v=4","gravatar_id":"","url":"https://api.github.com/users/alinbalutoiu","html_url":"https://github.com/alinbalutoiu","followers_url":"https://api.github.com/users/alinbalutoiu/followers","following_url":"https://api.github.com/users/alinbalutoiu/following{/other_user}","gists_url":"https://api.github.com/users/alinbalutoiu/gists{/gist_id}","starred_url":"https://api.github.com/users/alinbalutoiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinbalutoiu/subscriptions","organizations_url":"https://api.github.com/users/alinbalutoiu/orgs","repos_url":"https://api.github.com/users/alinbalutoiu/repos","events_url":"https://api.github.com/users/alinbalutoiu/events{/privacy}","received_events_url":"https://api.github.com/users/alinbalutoiu/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":114528223,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":422106010,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/windows","name":"sig/windows","color":"d2b48c","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false},{"id":611767149,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/status/approved-for-milestone","name":"status/approved-for-milestone","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"assignees":[{"login":"feiskyer","id":676637,"avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars2.githubusercontent.com/u/7740897?v=4","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},{"login":"dcbw","id":10926354,"avatar_url":"https://avatars2.githubusercontent.com/u/10926354?v=4","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},{"login":"PatrickLang","id":11345431,"avatar_url":"https://avatars1.githubusercontent.com/u/11345431?v=4","gravatar_id":"","url":"https://api.github.com/users/PatrickLang","html_url":"https://github.com/PatrickLang","followers_url":"https://api.github.com/users/PatrickLang/followers","following_url":"https://api.github.com/users/PatrickLang/following{/other_user}","gists_url":"https://api.github.com/users/PatrickLang/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickLang/subscriptions","organizations_url":"https://api.github.com/users/PatrickLang/orgs","repos_url":"https://api.github.com/users/PatrickLang/repos","events_url":"https://api.github.com/users/PatrickLang/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickLang/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38","html_url":"https://github.com/kubernetes/kubernetes/milestone/38","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38/labels","id":2848396,"number":38,"title":"v1.11","description":null,"creator":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":132,"state":"open","created_at":"2017-10-18T17:24:38Z","updated_at":"2018-05-29T11:22:10Z","due_on":null,"closed_at":null},"comments":25,"created_at":"2018-05-23T08:24:33Z","updated_at":"2018-05-29T15:21:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64189","html_url":"https://github.com/kubernetes/kubernetes/pull/64189","diff_url":"https://github.com/kubernetes/kubernetes/pull/64189.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/64189.patch"},"body":"\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nWindows supports both sandbox and non-sandbox cases. The non-sandbox\r\ncase is for Windows Server 2016 and for Windows Server version greater\r\nthan 1709 which use Hyper-V containers.\r\n\r\nCurrently, the CNI on Windows fetches the IP from the containers\r\nwithin the pods regardless of the mode. This should be done only\r\nin the non-sandbox mode where the IP of the actual container\r\nwill be different than the IP of the sandbox container.\r\n\r\nIn the case where the sandbox container is supported, all the containers\r\nfrom the same pod will share the network details of the sandbox container.\r\n\r\nThis patch updates the CNI to fetch the IP from the sandbox container\r\nwhen this mode is supported.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #64188\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/392817329","html_url":"https://github.com/kubernetes/kubernetes/pull/64189#issuecomment-392817329","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64189","id":392817329,"user":{"login":"PatrickLang","id":11345431,"avatar_url":"https://avatars1.githubusercontent.com/u/11345431?v=4","gravatar_id":"","url":"https://api.github.com/users/PatrickLang","html_url":"https://github.com/PatrickLang","followers_url":"https://api.github.com/users/PatrickLang/followers","following_url":"https://api.github.com/users/PatrickLang/following{/other_user}","gists_url":"https://api.github.com/users/PatrickLang/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickLang/subscriptions","organizations_url":"https://api.github.com/users/PatrickLang/orgs","repos_url":"https://api.github.com/users/PatrickLang/repos","events_url":"https://api.github.com/users/PatrickLang/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickLang/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T15:21:34Z","updated_at":"2018-05-29T15:21:34Z","author_association":"NONE","body":"Trying this per bot's recommendations\r\n/assign @dchen1107 "}}
{"actor":{"display_login":"PatrickLang"}}