{"action":"created","issue":{"url":"https://api.github.com/repos/docker/infrakit/issues/890","repository_url":"https://api.github.com/repos/docker/infrakit","labels_url":"https://api.github.com/repos/docker/infrakit/issues/890/labels{/name}","comments_url":"https://api.github.com/repos/docker/infrakit/issues/890/comments","events_url":"https://api.github.com/repos/docker/infrakit/issues/890/events","html_url":"https://github.com/docker/infrakit/pull/890","id":306215853,"number":890,"title":"Provision full VPC on AWS using Resource Controller","user":{"login":"chungers","id":299504,"avatar_url":"https://avatars1.githubusercontent.com/u/299504?v=4","gravatar_id":"","url":"https://api.github.com/users/chungers","html_url":"https://github.com/chungers","followers_url":"https://api.github.com/users/chungers/followers","following_url":"https://api.github.com/users/chungers/following{/other_user}","gists_url":"https://api.github.com/users/chungers/gists{/gist_id}","starred_url":"https://api.github.com/users/chungers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chungers/subscriptions","organizations_url":"https://api.github.com/users/chungers/orgs","repos_url":"https://api.github.com/users/chungers/repos","events_url":"https://api.github.com/users/chungers/events{/privacy}","received_events_url":"https://api.github.com/users/chungers/received_events","type":"User","site_admin":false},"labels":[{"id":465756229,"url":"https://api.github.com/repos/docker/infrakit/labels/dco/no","name":"dco/no","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-18T06:00:59Z","updated_at":"2018-03-18T06:38:57Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/docker/infrakit/pulls/890","html_url":"https://github.com/docker/infrakit/pull/890","diff_url":"https://github.com/docker/infrakit/pull/890.diff","patch_url":"https://github.com/docker/infrakit/pull/890.patch"},"body":"This PR\r\n\r\n   + Cleans up the AWS plugin to\r\n      - Deprecate logrus\r\n      - Honor the `properties=true` bool flag when Describing instances to return properties of resources\r\n      - Make proper attachment of subnets to routes if specified.\r\n    + Adds a full `mystack.yml` that will create a full VPC with 1 internet gateway and 2 subnets\r\n    + Adds an `inventory.yml` for configuring the inventory controller which will monitor all the resources created by the resource controller (as driven by `mystack.yml`) and make all the resource properties (e.g. VpcId) be available in metadata form.\r\n    + Updates the compute instance / spot instance playbook files to look at the metadata in suggesting default values such as availability zones and subnet ids.\r\n\r\nSigned-off-by: David Chung david.chung@docker.com"},"comment":{"url":"https://api.github.com/repos/docker/infrakit/issues/comments/373976353","html_url":"https://github.com/docker/infrakit/pull/890#issuecomment-373976353","issue_url":"https://api.github.com/repos/docker/infrakit/issues/890","id":373976353,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-03-18T06:38:57Z","updated_at":"2018-03-18T06:38:57Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/docker/infrakit/pull/890?src=pr&el=h1) Report\n> Merging [#890](https://codecov.io/gh/docker/infrakit/pull/890?src=pr&el=desc) into [master](https://codecov.io/gh/docker/infrakit/commit/f7b80b0460bebf02933eafc05488cc281f988ae5?src=pr&el=desc) will **decrease** coverage by `0.13%`.\n> The diff coverage is `1.96%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/docker/infrakit/pull/890/graphs/tree.svg?token=z08ZKeIJfA&width=650&height=150&src=pr)](https://codecov.io/gh/docker/infrakit/pull/890?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #890      +/-   ##\n==========================================\n- Coverage   48.66%   48.52%   -0.14%     \n==========================================\n  Files          85       84       -1     \n  Lines        7790     7802      +12     \n==========================================\n- Hits         3791     3786       -5     \n- Misses       3692     3708      +16     \n- Partials      307      308       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/docker/infrakit/pull/890?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...ws/plugin/instance/autoscaling\\_autoscalinggroup.go](https://codecov.io/gh/docker/infrakit/pull/890/diff?src=pr&el=tree#diff-cGtnL3Byb3ZpZGVyL2F3cy9wbHVnaW4vaW5zdGFuY2UvYXV0b3NjYWxpbmdfYXV0b3NjYWxpbmdncm91cC5nbw==) | `0% <0%> (ø)` | :arrow_up: |\n| [pkg/provider/aws/plugin/instance/ec2\\_volume.go](https://codecov.io/gh/docker/infrakit/pull/890/diff?src=pr&el=tree#diff-cGtnL3Byb3ZpZGVyL2F3cy9wbHVnaW4vaW5zdGFuY2UvZWMyX3ZvbHVtZS5nbw==) | `0% <0%> (ø)` | :arrow_up: |\n| [.../provider/aws/plugin/instance/ec2\\_securitygroup.go](https://codecov.io/gh/docker/infrakit/pull/890/diff?src=pr&el=tree#diff-cGtnL3Byb3ZpZGVyL2F3cy9wbHVnaW4vaW5zdGFuY2UvZWMyX3NlY3VyaXR5Z3JvdXAuZ28=) | `0% <0%> (ø)` | :arrow_up: |\n| [pkg/provider/aws/plugin/instance/builder.go](https://codecov.io/gh/docker/infrakit/pull/890/diff?src=pr&el=tree#diff-cGtnL3Byb3ZpZGVyL2F3cy9wbHVnaW4vaW5zdGFuY2UvYnVpbGRlci5nbw==) | `0% <0%> (ø)` | :arrow_up: |\n| [...rovider/aws/plugin/instance/ec2\\_internetgateway.go](https://codecov.io/gh/docker/infrakit/pull/890/diff?src=pr&el=tree#diff-cGtnL3Byb3ZpZGVyL2F3cy9wbHVnaW4vaW5zdGFuY2UvZWMyX2ludGVybmV0Z2F0ZXdheS5nbw==) | `0% <0%> (ø)` | :arrow_up: |\n| [pkg/provider/aws/plugin/instance/ec2\\_routetable.go](https://codecov.io/gh/docker/infrakit/pull/890/diff?src=pr&el=tree#diff-cGtnL3Byb3ZpZGVyL2F3cy9wbHVnaW4vaW5zdGFuY2UvZWMyX3JvdXRldGFibGUuZ28=) | `0% <0%> (ø)` | :arrow_up: |\n| [pkg/provider/aws/plugin/instance/ec2\\_subnet.go](https://codecov.io/gh/docker/infrakit/pull/890/diff?src=pr&el=tree#diff-cGtnL3Byb3ZpZGVyL2F3cy9wbHVnaW4vaW5zdGFuY2UvZWMyX3N1Ym5ldC5nbw==) | `0% <0%> (ø)` | :arrow_up: |\n| [pkg/provider/aws/plugin/instance/ec2\\_vpc.go](https://codecov.io/gh/docker/infrakit/pull/890/diff?src=pr&el=tree#diff-cGtnL3Byb3ZpZGVyL2F3cy9wbHVnaW4vaW5zdGFuY2UvZWMyX3ZwYy5nbw==) | `0% <0%> (ø)` | :arrow_up: |\n| [.../provider/aws/plugin/instance/ec2\\_spot\\_instance.go](https://codecov.io/gh/docker/infrakit/pull/890/diff?src=pr&el=tree#diff-cGtnL3Byb3ZpZGVyL2F3cy9wbHVnaW4vaW5zdGFuY2UvZWMyX3Nwb3RfaW5zdGFuY2UuZ28=) | `0% <0%> (ø)` | :arrow_up: |\n| [pkg/provider/aws/plugin/instance/ec2\\_instance.go](https://codecov.io/gh/docker/infrakit/pull/890/diff?src=pr&el=tree#diff-cGtnL3Byb3ZpZGVyL2F3cy9wbHVnaW4vaW5zdGFuY2UvZWMyX2luc3RhbmNlLmdv) | `35.21% <33.33%> (ø)` | :arrow_up: |\n| ... and [1 more](https://codecov.io/gh/docker/infrakit/pull/890/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/docker/infrakit/pull/890?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/docker/infrakit/pull/890?src=pr&el=footer). Last update [f7b80b0...7dbb48a](https://codecov.io/gh/docker/infrakit/pull/890?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}