{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/214190379","pull_request_review_id":151194012,"id":214190379,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDE5MDM3OQ==","diff_hunk":"@@ -127,14 +127,14 @@ commands =\n [testenv:py3-lint]\n deps =\n   pycodestyle==2.3.1\n-  pylint==1.7.2\n+  pylint==2.1.1\n   future==0.16.0\n   isort==4.2.15\n   flake8==3.5.0\n setenv =\n     BEAM_EXPERIMENTAL_PY3=1\n commands =\n-  python --version\n+  pylint --version","path":"sdks/python/tox.ini","position":46,"original_position":46,"commit_id":"6bd3277c0f2ab61f0360a277c9536e18deec2984","original_commit_id":"6bd3277c0f2ab61f0360a277c9536e18deec2984","user":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"body":"Same","created_at":"2018-08-30T21:43:28Z","updated_at":"2018-08-30T21:43:28Z","html_url":"https://github.com/apache/beam/pull/6247#discussion_r214190379","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/6247","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/214190379"},"html":{"href":"https://github.com/apache/beam/pull/6247#discussion_r214190379"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/6247"}},"in_reply_to_id":214180808},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/6247","id":209336371,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzM2Mzcx","html_url":"https://github.com/apache/beam/pull/6247","diff_url":"https://github.com/apache/beam/pull/6247.diff","patch_url":"https://github.com/apache/beam/pull/6247.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/6247","number":6247,"state":"open","locked":false,"title":"tox.ini: Upgrade to current versions of PyLint","user":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"body":"PyLint adds new tests that might be of interest.\r\n* PyLint v1.9.3 is current for Python 2 but we can only use it when the __--py3k__ flag is not used\r\n* PyLint v2.1.1 is current for Python 3\r\n\r\nAdd four disable directives to .pylintrc to get all new tests to pass.  Once this PR has been merged then contributors can go through .pylintrc removing disable directives while fixing the related issues.\r\n\r\nRemove the __not-context-manager__ disable directive from .pylintrc because the related PyLint bug is now resolved.\r\n\r\nNew Python 2 tests that fail:\r\n1. inconsistent-return-statements\r\n2. keyword-arg-before-vararg\r\n3. raising-format-tuple\r\n4. wrong-import-order\r\n\r\n**Please** add a meaningful description for your change here\r\n\r\n------------------------\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.\r\n - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\nIt will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.\r\n\r\nPost-Commit Tests Status (on master branch)\r\n------------------------------------------------------------------------------------------------\r\n\r\nLang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark\r\n--- | --- | --- | --- | --- | --- | --- | ---\r\nGo | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---\r\nJava | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)\r\nPython | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---\r\n\r\n\r\n\r\n\r\n","created_at":"2018-08-19T00:25:58Z","updated_at":"2018-08-30T21:43:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f233cdcdc6014bbd94895a17b3a48af087a132f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/6247/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/6247/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/6247/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/6bd3277c0f2ab61f0360a277c9536e18deec2984","head":{"label":"cclauss:patch-1","ref":"patch-1","sha":"6bd3277c0f2ab61f0360a277c9536e18deec2984","user":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"repo":{"id":102283701,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIyODM3MDE=","name":"beam","full_name":"cclauss/beam","owner":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cclauss/beam","description":"Mirror of Apache Beam","fork":true,"url":"https://api.github.com/repos/cclauss/beam","forks_url":"https://api.github.com/repos/cclauss/beam/forks","keys_url":"https://api.github.com/repos/cclauss/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cclauss/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cclauss/beam/teams","hooks_url":"https://api.github.com/repos/cclauss/beam/hooks","issue_events_url":"https://api.github.com/repos/cclauss/beam/issues/events{/number}","events_url":"https://api.github.com/repos/cclauss/beam/events","assignees_url":"https://api.github.com/repos/cclauss/beam/assignees{/user}","branches_url":"https://api.github.com/repos/cclauss/beam/branches{/branch}","tags_url":"https://api.github.com/repos/cclauss/beam/tags","blobs_url":"https://api.github.com/repos/cclauss/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cclauss/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cclauss/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/cclauss/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cclauss/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/cclauss/beam/languages","stargazers_url":"https://api.github.com/repos/cclauss/beam/stargazers","contributors_url":"https://api.github.com/repos/cclauss/beam/contributors","subscribers_url":"https://api.github.com/repos/cclauss/beam/subscribers","subscription_url":"https://api.github.com/repos/cclauss/beam/subscription","commits_url":"https://api.github.com/repos/cclauss/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/cclauss/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/cclauss/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/cclauss/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/cclauss/beam/contents/{+path}","compare_url":"https://api.github.com/repos/cclauss/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cclauss/beam/merges","archive_url":"https://api.github.com/repos/cclauss/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cclauss/beam/downloads","issues_url":"https://api.github.com/repos/cclauss/beam/issues{/number}","pulls_url":"https://api.github.com/repos/cclauss/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/cclauss/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/cclauss/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cclauss/beam/labels{/name}","releases_url":"https://api.github.com/repos/cclauss/beam/releases{/id}","deployments_url":"https://api.github.com/repos/cclauss/beam/deployments","created_at":"2017-09-03T18:00:01Z","updated_at":"2018-08-07T18:49:32Z","pushed_at":"2018-08-19T11:28:47Z","git_url":"git://github.com/cclauss/beam.git","ssh_url":"git@github.com:cclauss/beam.git","clone_url":"https://github.com/cclauss/beam.git","svn_url":"https://github.com/cclauss/beam","homepage":"","size":95589,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f31b789d591f7b8f6f96899a79fb6edf45ebcd34","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-08-30T21:06:27Z","pushed_at":"2018-08-30T21:14:13Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"https://beam.apache.org","size":101645,"stargazers_count":2095,"watchers_count":2095,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1312,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1312,"open_issues":91,"watchers":2095,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/6247"},"html":{"href":"https://github.com/apache/beam/pull/6247"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/6247"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/6247/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/6247/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/6247/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/6bd3277c0f2ab61f0360a277c9536e18deec2984"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cclauss"}}