{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments/194091918","pull_request_review_id":127204942,"id":194091918,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDA5MTkxOA==","diff_hunk":"@@ -1,5 +1,9 @@\n # CHANGELOG - kubelet\n \n+## 1.4.0 / Unreleased\n+\n+* [CLEANUP] Handle exceptions inside `retrieve_pod_list`, instead of outside the function. See [#1648][]\n+","path":"kubelet/CHANGELOG.md","position":6,"original_position":6,"commit_id":"b365d1059a3f795cdaccbbce4d4816985ef93f6b","original_commit_id":"b365d1059a3f795cdaccbbce4d4816985ef93f6b","user":{"login":"antoinepouille","id":25852569,"node_id":"MDQ6VXNlcjI1ODUyNTY5","avatar_url":"https://avatars0.githubusercontent.com/u/25852569?v=4","gravatar_id":"","url":"https://api.github.com/users/antoinepouille","html_url":"https://github.com/antoinepouille","followers_url":"https://api.github.com/users/antoinepouille/followers","following_url":"https://api.github.com/users/antoinepouille/following{/other_user}","gists_url":"https://api.github.com/users/antoinepouille/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinepouille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinepouille/subscriptions","organizations_url":"https://api.github.com/users/antoinepouille/orgs","repos_url":"https://api.github.com/users/antoinepouille/repos","events_url":"https://api.github.com/users/antoinepouille/events{/privacy}","received_events_url":"https://api.github.com/users/antoinepouille/received_events","type":"User","site_admin":false},"body":"OK, thanks for the info!","created_at":"2018-06-08T15:18:39Z","updated_at":"2018-06-08T15:18:39Z","html_url":"https://github.com/DataDog/integrations-core/pull/1648#discussion_r194091918","pull_request_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/1648","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments/194091918"},"html":{"href":"https://github.com/DataDog/integrations-core/pull/1648#discussion_r194091918"},"pull_request":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/1648"}},"in_reply_to_id":194089925},"pull_request":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/1648","id":192078525,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDc4NTI1","html_url":"https://github.com/DataDog/integrations-core/pull/1648","diff_url":"https://github.com/DataDog/integrations-core/pull/1648.diff","patch_url":"https://github.com/DataDog/integrations-core/pull/1648.patch","issue_url":"https://api.github.com/repos/DataDog/integrations-core/issues/1648","number":1648,"state":"open","locked":false,"title":"Kubelet check: better encapsulate the pod list retrieval","user":{"login":"antoinepouille","id":25852569,"node_id":"MDQ6VXNlcjI1ODUyNTY5","avatar_url":"https://avatars0.githubusercontent.com/u/25852569?v=4","gravatar_id":"","url":"https://api.github.com/users/antoinepouille","html_url":"https://github.com/antoinepouille","followers_url":"https://api.github.com/users/antoinepouille/followers","following_url":"https://api.github.com/users/antoinepouille/following{/other_user}","gists_url":"https://api.github.com/users/antoinepouille/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinepouille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinepouille/subscriptions","organizations_url":"https://api.github.com/users/antoinepouille/orgs","repos_url":"https://api.github.com/users/antoinepouille/repos","events_url":"https://api.github.com/users/antoinepouille/events{/privacy}","received_events_url":"https://api.github.com/users/antoinepouille/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nSmall change to the call to `retrieve_pod_list` to include the exception handling present [at its single current call point](https://github.com/DataDog/integrations-core/blob/master/kubelet/datadog_checks/kubelet/kubelet.py#L116-L122)\r\n\r\n### Motivation\r\nAn important customer had the check fail on this method. That would happen for instance if they modified the original kubelet check and didn't catch the exception when the output of their query failed.\r\nAnyway, this should make the code better here :-)\r\n\r\n### Review checklist\r\n\r\n- [x] PR has a [meaningful title](https://github.com/DataDog/integrations-core/blob/master/CONTRIBUTING.md#pull-request-title) or PR has the `no-changelog` label attached\r\n- [x] Feature or bugfix has tests\r\n- [x] Git history is clean\r\n- [ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the [documentation repo](https://github.com/DataDog/documentation/issues/new)","created_at":"2018-06-01T16:07:06Z","updated_at":"2018-06-08T15:18:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f73db7805c7c3168f2a54daee8673a72dc982cb4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"agent-integrations","id":2704472,"node_id":"MDQ6VGVhbTI3MDQ0NzI=","slug":"agent-integrations","description":"Tiramisu and stuff","privacy":"closed","url":"https://api.github.com/teams/2704472","members_url":"https://api.github.com/teams/2704472/members{/member}","repositories_url":"https://api.github.com/teams/2704472/repos","permission":"pull"}],"labels":[{"id":932725515,"node_id":"MDU6TGFiZWw5MzI3MjU1MTU=","url":"https://api.github.com/repos/DataDog/integrations-core/labels/changelog/no-changelog","name":"changelog/no-changelog","color":"f2983e","default":false},{"id":592413329,"node_id":"MDU6TGFiZWw1OTI0MTMzMjk=","url":"https://api.github.com/repos/DataDog/integrations-core/labels/containers","name":"containers","color":"0052cc","default":false},{"id":936572172,"node_id":"MDU6TGFiZWw5MzY1NzIxNzI=","url":"https://api.github.com/repos/DataDog/integrations-core/labels/integration/kubelet","name":"integration/kubelet","color":"bfdadc","default":false},{"id":293952858,"node_id":"MDU6TGFiZWwyOTM5NTI4NTg=","url":"https://api.github.com/repos/DataDog/integrations-core/labels/kind/enhancement","name":"kind/enhancement","color":"84b6eb","default":false}],"milestone":{"url":"https://api.github.com/repos/DataDog/integrations-core/milestones/37","html_url":"https://github.com/DataDog/integrations-core/milestone/37","labels_url":"https://api.github.com/repos/DataDog/integrations-core/milestones/37/labels","id":3303812,"node_id":"MDk6TWlsZXN0b25lMzMwMzgxMg==","number":37,"title":"6.3","description":"","creator":{"login":"masci","id":7241,"node_id":"MDQ6VXNlcjcyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7241?v=4","gravatar_id":"","url":"https://api.github.com/users/masci","html_url":"https://github.com/masci","followers_url":"https://api.github.com/users/masci/followers","following_url":"https://api.github.com/users/masci/following{/other_user}","gists_url":"https://api.github.com/users/masci/gists{/gist_id}","starred_url":"https://api.github.com/users/masci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masci/subscriptions","organizations_url":"https://api.github.com/users/masci/orgs","repos_url":"https://api.github.com/users/masci/repos","events_url":"https://api.github.com/users/masci/events{/privacy}","received_events_url":"https://api.github.com/users/masci/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":35,"state":"open","created_at":"2018-04-27T09:14:46Z","updated_at":"2018-06-08T15:15:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/1648/commits","review_comments_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/1648/comments","review_comment_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/issues/1648/comments","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/b365d1059a3f795cdaccbbce4d4816985ef93f6b","head":{"label":"DataDog:antoine/kubelet-better-encapsulation-for-pod-list-retrieval","ref":"antoine/kubelet-better-encapsulation-for-pod-list-retrieval","sha":"b365d1059a3f795cdaccbbce4d4816985ef93f6b","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":47203045,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIwMzA0NQ==","name":"integrations-core","full_name":"DataDog/integrations-core","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/integrations-core","description":"Core integrations of the datadog agent","fork":false,"url":"https://api.github.com/repos/DataDog/integrations-core","forks_url":"https://api.github.com/repos/DataDog/integrations-core/forks","keys_url":"https://api.github.com/repos/DataDog/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/integrations-core/teams","hooks_url":"https://api.github.com/repos/DataDog/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/integrations-core/events","assignees_url":"https://api.github.com/repos/DataDog/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/integrations-core/tags","blobs_url":"https://api.github.com/repos/DataDog/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/integrations-core/languages","stargazers_url":"https://api.github.com/repos/DataDog/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/DataDog/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/DataDog/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/DataDog/integrations-core/subscription","commits_url":"https://api.github.com/repos/DataDog/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/integrations-core/merges","archive_url":"https://api.github.com/repos/DataDog/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/integrations-core/downloads","issues_url":"https://api.github.com/repos/DataDog/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/integrations-core/deployments","created_at":"2015-12-01T16:41:45Z","updated_at":"2018-06-08T15:15:30Z","pushed_at":"2018-06-08T15:15:29Z","git_url":"git://github.com/DataDog/integrations-core.git","ssh_url":"git@github.com:DataDog/integrations-core.git","clone_url":"https://github.com/DataDog/integrations-core.git","svn_url":"https://github.com/DataDog/integrations-core","homepage":null,"size":11452,"stargazers_count":121,"watchers_count":121,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":257,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":257,"open_issues":56,"watchers":121,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"e951c9a96fc3f107a9a655f7b63dd77ca69ae9cf","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":47203045,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIwMzA0NQ==","name":"integrations-core","full_name":"DataDog/integrations-core","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/integrations-core","description":"Core integrations of the datadog agent","fork":false,"url":"https://api.github.com/repos/DataDog/integrations-core","forks_url":"https://api.github.com/repos/DataDog/integrations-core/forks","keys_url":"https://api.github.com/repos/DataDog/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/integrations-core/teams","hooks_url":"https://api.github.com/repos/DataDog/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/integrations-core/events","assignees_url":"https://api.github.com/repos/DataDog/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/integrations-core/tags","blobs_url":"https://api.github.com/repos/DataDog/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/integrations-core/languages","stargazers_url":"https://api.github.com/repos/DataDog/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/DataDog/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/DataDog/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/DataDog/integrations-core/subscription","commits_url":"https://api.github.com/repos/DataDog/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/integrations-core/merges","archive_url":"https://api.github.com/repos/DataDog/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/integrations-core/downloads","issues_url":"https://api.github.com/repos/DataDog/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/integrations-core/deployments","created_at":"2015-12-01T16:41:45Z","updated_at":"2018-06-08T15:15:30Z","pushed_at":"2018-06-08T15:15:29Z","git_url":"git://github.com/DataDog/integrations-core.git","ssh_url":"git@github.com:DataDog/integrations-core.git","clone_url":"https://github.com/DataDog/integrations-core.git","svn_url":"https://github.com/DataDog/integrations-core","homepage":null,"size":11452,"stargazers_count":121,"watchers_count":121,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":257,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":257,"open_issues":56,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/1648"},"html":{"href":"https://github.com/DataDog/integrations-core/pull/1648"},"issue":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/1648"},"comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/1648/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/1648/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/1648/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/integrations-core/statuses/b365d1059a3f795cdaccbbce4d4816985ef93f6b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"antoinepouille"}}