{"action":"closed","number":187,"pull_request":{"url":"https://api.github.com/repos/google/go-containerregistry/pulls/187","id":191932505,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTMyNTA1","html_url":"https://github.com/google/go-containerregistry/pull/187","diff_url":"https://github.com/google/go-containerregistry/pull/187.diff","patch_url":"https://github.com/google/go-containerregistry/pull/187.patch","issue_url":"https://api.github.com/repos/google/go-containerregistry/issues/187","number":187,"state":"closed","locked":false,"title":"Avoid recomputing the DiffID of layers where we know it.","user":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"body":"Prior to this change, the `partial` package enabled folks to implement the bare minimum interface necessary to compute the remainder of the `v1.Image` or `v1.Layer` interface.  With this change, we start to adopt a pattern that allows implementors to go beyond this bare minimum and implement additional methods and have the `partial` wrappers respect and delegate to these additional methods.\r\n\r\nThe first use case of this pattern is in `remote.Layer` where we effectively know all of the layers' `DiffID`s, but because of the \"bare minimum\" constraint we had previously been unable to leverage this knowledge to elide recomputing the DiffID by downloading and uncompressing the layer.\r\n\r\nFixes: https://github.com/google/go-containerregistry/issues/166\r\n\r\ncc @sclevine ","created_at":"2018-06-01T04:37:50Z","updated_at":"2018-06-01T16:19:27Z","closed_at":"2018-06-01T16:19:27Z","merged_at":"2018-06-01T16:19:27Z","merge_commit_sha":"e033bc7269cacc3145d08df64ad5cf387c7fc48d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ImJasonH","id":210737,"node_id":"MDQ6VXNlcjIxMDczNw==","avatar_url":"https://avatars1.githubusercontent.com/u/210737?v=4","gravatar_id":"","url":"https://api.github.com/users/ImJasonH","html_url":"https://github.com/ImJasonH","followers_url":"https://api.github.com/users/ImJasonH/followers","following_url":"https://api.github.com/users/ImJasonH/following{/other_user}","gists_url":"https://api.github.com/users/ImJasonH/gists{/gist_id}","starred_url":"https://api.github.com/users/ImJasonH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImJasonH/subscriptions","organizations_url":"https://api.github.com/users/ImJasonH/orgs","repos_url":"https://api.github.com/users/ImJasonH/repos","events_url":"https://api.github.com/users/ImJasonH/events{/privacy}","received_events_url":"https://api.github.com/users/ImJasonH/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-containerregistry/pulls/187/commits","review_comments_url":"https://api.github.com/repos/google/go-containerregistry/pulls/187/comments","review_comment_url":"https://api.github.com/repos/google/go-containerregistry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-containerregistry/issues/187/comments","statuses_url":"https://api.github.com/repos/google/go-containerregistry/statuses/0d051fdcd5f56405a55fc6a2cd93c58f192bcee3","head":{"label":"mattmoor:dont-recompute-diffid","ref":"dont-recompute-diffid","sha":"0d051fdcd5f56405a55fc6a2cd93c58f192bcee3","user":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"repo":{"id":125290236,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyOTAyMzY=","name":"go-containerregistry","full_name":"mattmoor/go-containerregistry","owner":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattmoor/go-containerregistry","description":null,"fork":true,"url":"https://api.github.com/repos/mattmoor/go-containerregistry","forks_url":"https://api.github.com/repos/mattmoor/go-containerregistry/forks","keys_url":"https://api.github.com/repos/mattmoor/go-containerregistry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattmoor/go-containerregistry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattmoor/go-containerregistry/teams","hooks_url":"https://api.github.com/repos/mattmoor/go-containerregistry/hooks","issue_events_url":"https://api.github.com/repos/mattmoor/go-containerregistry/issues/events{/number}","events_url":"https://api.github.com/repos/mattmoor/go-containerregistry/events","assignees_url":"https://api.github.com/repos/mattmoor/go-containerregistry/assignees{/user}","branches_url":"https://api.github.com/repos/mattmoor/go-containerregistry/branches{/branch}","tags_url":"https://api.github.com/repos/mattmoor/go-containerregistry/tags","blobs_url":"https://api.github.com/repos/mattmoor/go-containerregistry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattmoor/go-containerregistry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattmoor/go-containerregistry/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattmoor/go-containerregistry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattmoor/go-containerregistry/statuses/{sha}","languages_url":"https://api.github.com/repos/mattmoor/go-containerregistry/languages","stargazers_url":"https://api.github.com/repos/mattmoor/go-containerregistry/stargazers","contributors_url":"https://api.github.com/repos/mattmoor/go-containerregistry/contributors","subscribers_url":"https://api.github.com/repos/mattmoor/go-containerregistry/subscribers","subscription_url":"https://api.github.com/repos/mattmoor/go-containerregistry/subscription","commits_url":"https://api.github.com/repos/mattmoor/go-containerregistry/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattmoor/go-containerregistry/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattmoor/go-containerregistry/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattmoor/go-containerregistry/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattmoor/go-containerregistry/contents/{+path}","compare_url":"https://api.github.com/repos/mattmoor/go-containerregistry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattmoor/go-containerregistry/merges","archive_url":"https://api.github.com/repos/mattmoor/go-containerregistry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattmoor/go-containerregistry/downloads","issues_url":"https://api.github.com/repos/mattmoor/go-containerregistry/issues{/number}","pulls_url":"https://api.github.com/repos/mattmoor/go-containerregistry/pulls{/number}","milestones_url":"https://api.github.com/repos/mattmoor/go-containerregistry/milestones{/number}","notifications_url":"https://api.github.com/repos/mattmoor/go-containerregistry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattmoor/go-containerregistry/labels{/name}","releases_url":"https://api.github.com/repos/mattmoor/go-containerregistry/releases{/id}","deployments_url":"https://api.github.com/repos/mattmoor/go-containerregistry/deployments","created_at":"2018-03-15T00:20:15Z","updated_at":"2018-03-15T00:20:17Z","pushed_at":"2018-06-01T13:41:45Z","git_url":"git://github.com/mattmoor/go-containerregistry.git","ssh_url":"git@github.com:mattmoor/go-containerregistry.git","clone_url":"https://github.com/mattmoor/go-containerregistry.git","svn_url":"https://github.com/mattmoor/go-containerregistry","homepage":null,"size":2090,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"301bc4aaa86255df53975435ff908f684727ad61","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":125253663,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyNTM2NjM=","name":"go-containerregistry","full_name":"google/go-containerregistry","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/go-containerregistry","description":null,"fork":false,"url":"https://api.github.com/repos/google/go-containerregistry","forks_url":"https://api.github.com/repos/google/go-containerregistry/forks","keys_url":"https://api.github.com/repos/google/go-containerregistry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-containerregistry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-containerregistry/teams","hooks_url":"https://api.github.com/repos/google/go-containerregistry/hooks","issue_events_url":"https://api.github.com/repos/google/go-containerregistry/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-containerregistry/events","assignees_url":"https://api.github.com/repos/google/go-containerregistry/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-containerregistry/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-containerregistry/tags","blobs_url":"https://api.github.com/repos/google/go-containerregistry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-containerregistry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-containerregistry/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-containerregistry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-containerregistry/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-containerregistry/languages","stargazers_url":"https://api.github.com/repos/google/go-containerregistry/stargazers","contributors_url":"https://api.github.com/repos/google/go-containerregistry/contributors","subscribers_url":"https://api.github.com/repos/google/go-containerregistry/subscribers","subscription_url":"https://api.github.com/repos/google/go-containerregistry/subscription","commits_url":"https://api.github.com/repos/google/go-containerregistry/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-containerregistry/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-containerregistry/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-containerregistry/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-containerregistry/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-containerregistry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-containerregistry/merges","archive_url":"https://api.github.com/repos/google/go-containerregistry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-containerregistry/downloads","issues_url":"https://api.github.com/repos/google/go-containerregistry/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-containerregistry/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-containerregistry/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-containerregistry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-containerregistry/labels{/name}","releases_url":"https://api.github.com/repos/google/go-containerregistry/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-containerregistry/deployments","created_at":"2018-03-14T18:02:49Z","updated_at":"2018-06-01T15:56:22Z","pushed_at":"2018-06-01T16:19:27Z","git_url":"git://github.com/google/go-containerregistry.git","ssh_url":"git@github.com:google/go-containerregistry.git","clone_url":"https://github.com/google/go-containerregistry.git","svn_url":"https://github.com/google/go-containerregistry","homepage":null,"size":2081,"stargazers_count":62,"watchers_count":62,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":27,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-containerregistry/pulls/187"},"html":{"href":"https://github.com/google/go-containerregistry/pull/187"},"issue":{"href":"https://api.github.com/repos/google/go-containerregistry/issues/187"},"comments":{"href":"https://api.github.com/repos/google/go-containerregistry/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-containerregistry/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-containerregistry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-containerregistry/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-containerregistry/statuses/0d051fdcd5f56405a55fc6a2cd93c58f192bcee3"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":22,"deletions":1,"changed_files":4}}
{"actor":{"display_login":"mattmoor"}}