{"action":"created","issue":{"url":"https://api.github.com/repos/thorntail/thorntail/issues/1175","repository_url":"https://api.github.com/repos/thorntail/thorntail","labels_url":"https://api.github.com/repos/thorntail/thorntail/issues/1175/labels{/name}","comments_url":"https://api.github.com/repos/thorntail/thorntail/issues/1175/comments","events_url":"https://api.github.com/repos/thorntail/thorntail/issues/1175/events","html_url":"https://github.com/thorntail/thorntail/pull/1175","id":383941687,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjg5NzUw","number":1175,"title":"[THORN-2156] Add support for accepting verification and decryption ke…","user":{"login":"dvddhln","id":2706002,"node_id":"MDQ6VXNlcjI3MDYwMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2706002?v=4","gravatar_id":"","url":"https://api.github.com/users/dvddhln","html_url":"https://github.com/dvddhln","followers_url":"https://api.github.com/users/dvddhln/followers","following_url":"https://api.github.com/users/dvddhln/following{/other_user}","gists_url":"https://api.github.com/users/dvddhln/gists{/gist_id}","starred_url":"https://api.github.com/users/dvddhln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvddhln/subscriptions","organizations_url":"https://api.github.com/users/dvddhln/orgs","repos_url":"https://api.github.com/users/dvddhln/repos","events_url":"https://api.github.com/users/dvddhln/events{/privacy}","received_events_url":"https://api.github.com/users/dvddhln/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-23T23:33:22Z","updated_at":"2018-11-25T17:56:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/thorntail/thorntail/pulls/1175","html_url":"https://github.com/thorntail/thorntail/pull/1175","diff_url":"https://github.com/thorntail/thorntail/pull/1175.diff","patch_url":"https://github.com/thorntail/thorntail/pull/1175.patch"},"body":"…y aliases\r\n\r\nMotivation\r\n----------\r\nProvide support for accepting verification and decryption key aliases in\r\nconfiguration.\r\n\r\nModifications\r\n-------------\r\nAdd logic for verification and decryption with tests.\r\n\r\nResult\r\n------\r\nThis will allow for accepting and using incoming headers when performing\r\nverification or decryption.\r\n\r\n- [x] Have you followed the guidelines in our [Contributing](http://wildfly-swarm.io/community/contributing/) document?\r\n- [x] [v2] Have you created a [JIRA](https://issues.jboss.org/browse/THORN) and used it in the commit message?\r\n- [ ] [v4] Have you created a [GitHub Issue](https://github.com/thorntail/thorntail/issues) and used it in the commit message?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/thorntail/thorntail/pulls) for the same issue?\r\n- [x] Have you built the project locally prior to submission with `mvn clean install`?\r\n\r\n-----\r\n"},"comment":{"url":"https://api.github.com/repos/thorntail/thorntail/issues/comments/441459087","html_url":"https://github.com/thorntail/thorntail/pull/1175#issuecomment-441459087","issue_url":"https://api.github.com/repos/thorntail/thorntail/issues/1175","id":441459087,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTQ1OTA4Nw==","user":{"login":"sberyozkin","id":467639,"node_id":"MDQ6VXNlcjQ2NzYzOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/467639?v=4","gravatar_id":"","url":"https://api.github.com/users/sberyozkin","html_url":"https://github.com/sberyozkin","followers_url":"https://api.github.com/users/sberyozkin/followers","following_url":"https://api.github.com/users/sberyozkin/following{/other_user}","gists_url":"https://api.github.com/users/sberyozkin/gists{/gist_id}","starred_url":"https://api.github.com/users/sberyozkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sberyozkin/subscriptions","organizations_url":"https://api.github.com/users/sberyozkin/orgs","repos_url":"https://api.github.com/users/sberyozkin/repos","events_url":"https://api.github.com/users/sberyozkin/events{/privacy}","received_events_url":"https://api.github.com/users/sberyozkin/received_events","type":"User","site_admin":false},"created_at":"2018-11-25T17:56:06Z","updated_at":"2018-11-25T17:56:06Z","author_association":"CONTRIBUTOR","body":"@dvddhln Hi David, it looks very neat, thanks :-) \r\nI have only 2 minor suggestions: \r\n* if the kid can be accepted but the incoming headers have no kid set, then continue with the default kid selection; \r\n* For the tests to really show that the accept alias works, the default alias value should be null. Right now it is set to the \"server\", but it should really be not set to some default value, I set it initially just to make things simpler fotr a start; you'd only need to fix few tests (which work with JKS stores), set the alias to 'server' in yaml, once you remove the default key alias value.\r\nThanks, Sergey"}}
{"actor":{"display_login":"sberyozkin"}}