{"action":"created","issue":{"url":"https://api.github.com/repos/yandex/ClickHouse/issues/3613","repository_url":"https://api.github.com/repos/yandex/ClickHouse","labels_url":"https://api.github.com/repos/yandex/ClickHouse/issues/3613/labels{/name}","comments_url":"https://api.github.com/repos/yandex/ClickHouse/issues/3613/comments","events_url":"https://api.github.com/repos/yandex/ClickHouse/issues/3613/events","html_url":"https://github.com/yandex/ClickHouse/issues/3613","id":382457614,"node_id":"MDU6SXNzdWUzODI0NTc2MTQ=","number":3613,"title":"Drop X- prefix from X-ClickHouse-Progress header","user":{"login":"simPod","id":327717,"node_id":"MDQ6VXNlcjMyNzcxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/327717?v=4","gravatar_id":"","url":"https://api.github.com/users/simPod","html_url":"https://github.com/simPod","followers_url":"https://api.github.com/users/simPod/followers","following_url":"https://api.github.com/users/simPod/following{/other_user}","gists_url":"https://api.github.com/users/simPod/gists{/gist_id}","starred_url":"https://api.github.com/users/simPod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simPod/subscriptions","organizations_url":"https://api.github.com/users/simPod/orgs","repos_url":"https://api.github.com/users/simPod/repos","events_url":"https://api.github.com/users/simPod/events{/privacy}","received_events_url":"https://api.github.com/users/simPod/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-20T01:13:27Z","updated_at":"2018-11-20T15:29:50Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"We should drop `X-` prefix from `X-ClickHouse-Progress` header based on IETF RFC https://tools.ietf.org/html/rfc6648\r\n\r\nThe document suggests\r\n\r\n```\r\n   Creators of new parameters to be used in the context of application\r\n   protocols:\r\n\r\n   1.  SHOULD assume that all parameters they create might become\r\n       standardized, public, commonly deployed, or usable across\r\n       multiple implementations.\r\n\r\n   2.  SHOULD employ meaningful parameter names that they have reason to\r\n       believe are currently unused.\r\n\r\n   3.  SHOULD NOT prefix their parameter names with \"X-\" or similar\r\n       constructs.\r\n```\r\n\r\nI propose simply `ClickHouse-Progress`\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/yandex/ClickHouse/issues/comments/440314140","html_url":"https://github.com/yandex/ClickHouse/issues/3613#issuecomment-440314140","issue_url":"https://api.github.com/repos/yandex/ClickHouse/issues/3613","id":440314140,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDMxNDE0MA==","user":{"login":"simPod","id":327717,"node_id":"MDQ6VXNlcjMyNzcxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/327717?v=4","gravatar_id":"","url":"https://api.github.com/users/simPod","html_url":"https://github.com/simPod","followers_url":"https://api.github.com/users/simPod/followers","following_url":"https://api.github.com/users/simPod/following{/other_user}","gists_url":"https://api.github.com/users/simPod/gists{/gist_id}","starred_url":"https://api.github.com/users/simPod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simPod/subscriptions","organizations_url":"https://api.github.com/users/simPod/orgs","repos_url":"https://api.github.com/users/simPod/repos","events_url":"https://api.github.com/users/simPod/events{/privacy}","received_events_url":"https://api.github.com/users/simPod/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T15:29:50Z","updated_at":"2018-11-20T15:29:50Z","author_association":"CONTRIBUTOR","body":"Sure but we should follow best practices. Ofc it's a BC break tho. Can be taken care of with version IMO.\r\n\r\n_About the hacking, yea. I had to bend Guzzle php as well but that's not relevant :)_"}}
{"actor":{"display_login":"simPod"}}