{"action":"opened","number":25006,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25006","id":181702283,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25006","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25006.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25006.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25006","number":25006,"state":"open","locked":false,"title":"A-Frame additions","user":{"login":"twastvedt","id":8107026,"avatar_url":"https://avatars2.githubusercontent.com/u/8107026?v=4","gravatar_id":"","url":"https://api.github.com/users/twastvedt","html_url":"https://github.com/twastvedt","followers_url":"https://api.github.com/users/twastvedt/followers","following_url":"https://api.github.com/users/twastvedt/following{/other_user}","gists_url":"https://api.github.com/users/twastvedt/gists{/gist_id}","starred_url":"https://api.github.com/users/twastvedt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twastvedt/subscriptions","organizations_url":"https://api.github.com/users/twastvedt/orgs","repos_url":"https://api.github.com/users/twastvedt/repos","events_url":"https://api.github.com/users/twastvedt/events{/privacy}","received_events_url":"https://api.github.com/users/twastvedt/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x ] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x ] Test the change in your own code. (Compile and run.)\r\n- [x ] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x ] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x ] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n    Note: there are still newable objects. I chose to keep the existing approach, as defended [here](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/16987).\r\n- [x ] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [x ] Provide a URL to documentation or source code which provides context for the suggested changes: \r\nThere are a bunch of changes here that I've added over the course of using this for a project. Primarily, though, this PR centers around adding generics to Components and Systems: [A-Frame Components](https://aframe.io/docs/0.7.0/core/component.html), [A-Frame Systems](https://aframe.io/docs/0.7.0/core/systems.html).\r\n- [x ] Increase the version number in the header if appropriate.\r\n- [x ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.","created_at":"2018-04-15T14:37:44Z","updated_at":"2018-04-15T14:37:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25006/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25006/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25006/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/3b4100358c037cac8491e73373e493a841c90e43","head":{"label":"twastvedt:aframe-new","ref":"aframe-new","sha":"3b4100358c037cac8491e73373e493a841c90e43","user":{"login":"twastvedt","id":8107026,"avatar_url":"https://avatars2.githubusercontent.com/u/8107026?v=4","gravatar_id":"","url":"https://api.github.com/users/twastvedt","html_url":"https://github.com/twastvedt","followers_url":"https://api.github.com/users/twastvedt/followers","following_url":"https://api.github.com/users/twastvedt/following{/other_user}","gists_url":"https://api.github.com/users/twastvedt/gists{/gist_id}","starred_url":"https://api.github.com/users/twastvedt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twastvedt/subscriptions","organizations_url":"https://api.github.com/users/twastvedt/orgs","repos_url":"https://api.github.com/users/twastvedt/repos","events_url":"https://api.github.com/users/twastvedt/events{/privacy}","received_events_url":"https://api.github.com/users/twastvedt/received_events","type":"User","site_admin":false},"repo":{"id":55720606,"name":"DefinitelyTyped","full_name":"twastvedt/DefinitelyTyped","owner":{"login":"twastvedt","id":8107026,"avatar_url":"https://avatars2.githubusercontent.com/u/8107026?v=4","gravatar_id":"","url":"https://api.github.com/users/twastvedt","html_url":"https://github.com/twastvedt","followers_url":"https://api.github.com/users/twastvedt/followers","following_url":"https://api.github.com/users/twastvedt/following{/other_user}","gists_url":"https://api.github.com/users/twastvedt/gists{/gist_id}","starred_url":"https://api.github.com/users/twastvedt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twastvedt/subscriptions","organizations_url":"https://api.github.com/users/twastvedt/orgs","repos_url":"https://api.github.com/users/twastvedt/repos","events_url":"https://api.github.com/users/twastvedt/events{/privacy}","received_events_url":"https://api.github.com/users/twastvedt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twastvedt/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/twastvedt/DefinitelyTyped","forks_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/twastvedt/DefinitelyTyped/deployments","created_at":"2016-04-07T19:05:25Z","updated_at":"2016-04-07T19:05:31Z","pushed_at":"2018-04-15T13:59:28Z","git_url":"git://github.com/twastvedt/DefinitelyTyped.git","ssh_url":"git@github.com:twastvedt/DefinitelyTyped.git","clone_url":"https://github.com/twastvedt/DefinitelyTyped.git","svn_url":"https://github.com/twastvedt/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":304645,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"7f0811ae8e865a8f2f9c1cdbbe4ba1ea9b82e250","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-04-15T13:20:08Z","pushed_at":"2018-04-15T12:01:11Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":311172,"stargazers_count":15100,"watchers_count":15100,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12576,"mirror_url":null,"archived":false,"open_issues_count":2046,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12576,"open_issues":2046,"watchers":15100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25006"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25006"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25006"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/25006/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25006/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/25006/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/3b4100358c037cac8491e73373e493a841c90e43"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":14,"additions":161,"deletions":88,"changed_files":3}}
{"actor":{"display_login":"twastvedt"}}