{"action":"closed","number":368,"pull_request":{"url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/pulls/368","id":219455515,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDU1NTE1","html_url":"https://github.com/STORM-IRIT/Radium-Engine/pull/368","diff_url":"https://github.com/STORM-IRIT/Radium-Engine/pull/368.diff","patch_url":"https://github.com/STORM-IRIT/Radium-Engine/pull/368.patch","issue_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/368","number":368,"state":"closed","locked":false,"title":"Remove dispatch of component registration methods","user":{"login":"hoshiryu","id":460844,"node_id":"MDQ6VXNlcjQ2MDg0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/460844?v=4","gravatar_id":"","url":"https://api.github.com/users/hoshiryu","html_url":"https://github.com/hoshiryu","followers_url":"https://api.github.com/users/hoshiryu/followers","following_url":"https://api.github.com/users/hoshiryu/following{/other_user}","gists_url":"https://api.github.com/users/hoshiryu/gists{/gist_id}","starred_url":"https://api.github.com/users/hoshiryu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoshiryu/subscriptions","organizations_url":"https://api.github.com/users/hoshiryu/orgs","repos_url":"https://api.github.com/users/hoshiryu/repos","events_url":"https://api.github.com/users/hoshiryu/events{/privacy}","received_events_url":"https://api.github.com/users/hoshiryu/received_events","type":"User","site_admin":false},"body":"* **Please check if the PR fulfills these requirements**\r\n- [ ] Is the Pull-Request done against the right branch:\r\n  - `master`: for hotfixes not impacting the API\r\n  - `master-v1`: for changes related to the Radium Stable Release V1.\r\n- [ ] The commit message follows our guidelines\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\nBe aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.\r\n\r\n\r\n* **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)\r\nFix the default behavior of `CouplingSystem` regarding the `registerComponent`, `unregisterComponent` and `unregisterAllComponents` methods of `Ra::Engine::System`.\r\nAlso give the file directory to the AbstractTimedSystem for caching/restoring frame data, so that the  CouplingSystem and its subsytems use the same by default.\r\n\r\n* **What is the current behavior?** (You can also link to an open issue here)\r\nBy default, the `CouplingSystem` dispatches the `registerComponent`, `unregisterComponent` and `unregisterAllComponents` to the coupled systems, which makes them register its own managed `Components`.\r\nThis is undesirable, since the `Systems` must only register `Components` they manage (create, run tasks over, link to some plugin interface).\r\n\r\n* **What is the new behavior (if this is a feature change)?**\r\nBy default, there is no dispatch for these methods.\r\nIn the case one wants the coupled systems to also register `Components` related to the `CouplingSystem`, then one must declare/implement it explicitely.\r\n\r\n* **Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?)\r\n\r\n\r\n\r\n* **Other information**:\r\n","created_at":"2018-10-01T17:32:01Z","updated_at":"2018-10-02T12:15:35Z","closed_at":"2018-10-02T12:15:35Z","merged_at":null,"merge_commit_sha":"ea6474a8bc9d72060b6a0992bfa1c4234b4a27c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":331992357,"node_id":"MDU6TGFiZWwzMzE5OTIzNTc=","url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/labels/Engine","name":"Engine","color":"fbca04","default":false},{"id":245081187,"node_id":"MDU6TGFiZWwyNDUwODExODc=","url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/labels/High%20priority","name":"High priority","color":"eb6420","default":false},{"id":827231367,"node_id":"MDU6TGFiZWw4MjcyMzEzNjc=","url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/labels/WIP","name":"WIP","color":"ffffff","default":false},{"id":232856100,"node_id":"MDU6TGFiZWwyMzI4NTYxMDA=","url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/pulls/368/commits","review_comments_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/pulls/368/comments","review_comment_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/368/comments","statuses_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/statuses/108a679f0faf39df1cde12f9aeaefedaae7c848c","head":{"label":"STORM-IRIT:fix_coupling_system","ref":"fix_coupling_system","sha":"108a679f0faf39df1cde12f9aeaefedaae7c848c","user":{"login":"STORM-IRIT","id":13313915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzEzOTE1","avatar_url":"https://avatars3.githubusercontent.com/u/13313915?v=4","gravatar_id":"","url":"https://api.github.com/users/STORM-IRIT","html_url":"https://github.com/STORM-IRIT","followers_url":"https://api.github.com/users/STORM-IRIT/followers","following_url":"https://api.github.com/users/STORM-IRIT/following{/other_user}","gists_url":"https://api.github.com/users/STORM-IRIT/gists{/gist_id}","starred_url":"https://api.github.com/users/STORM-IRIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STORM-IRIT/subscriptions","organizations_url":"https://api.github.com/users/STORM-IRIT/orgs","repos_url":"https://api.github.com/users/STORM-IRIT/repos","events_url":"https://api.github.com/users/STORM-IRIT/events{/privacy}","received_events_url":"https://api.github.com/users/STORM-IRIT/received_events","type":"Organization","site_admin":false},"repo":{"id":38614085,"node_id":"MDEwOlJlcG9zaXRvcnkzODYxNDA4NQ==","name":"Radium-Engine","full_name":"STORM-IRIT/Radium-Engine","private":false,"owner":{"login":"STORM-IRIT","id":13313915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzEzOTE1","avatar_url":"https://avatars3.githubusercontent.com/u/13313915?v=4","gravatar_id":"","url":"https://api.github.com/users/STORM-IRIT","html_url":"https://github.com/STORM-IRIT","followers_url":"https://api.github.com/users/STORM-IRIT/followers","following_url":"https://api.github.com/users/STORM-IRIT/following{/other_user}","gists_url":"https://api.github.com/users/STORM-IRIT/gists{/gist_id}","starred_url":"https://api.github.com/users/STORM-IRIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STORM-IRIT/subscriptions","organizations_url":"https://api.github.com/users/STORM-IRIT/orgs","repos_url":"https://api.github.com/users/STORM-IRIT/repos","events_url":"https://api.github.com/users/STORM-IRIT/events{/privacy}","received_events_url":"https://api.github.com/users/STORM-IRIT/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/STORM-IRIT/Radium-Engine","description":null,"fork":false,"url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine","forks_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/forks","keys_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/teams","hooks_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/hooks","issue_events_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/events{/number}","events_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/events","assignees_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/assignees{/user}","branches_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/branches{/branch}","tags_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/tags","blobs_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/statuses/{sha}","languages_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/languages","stargazers_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/stargazers","contributors_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/contributors","subscribers_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/subscribers","subscription_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/subscription","commits_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/contents/{+path}","compare_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/merges","archive_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/downloads","issues_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues{/number}","pulls_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/pulls{/number}","milestones_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/milestones{/number}","notifications_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/labels{/name}","releases_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/releases{/id}","deployments_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/deployments","created_at":"2015-07-06T11:14:38Z","updated_at":"2018-10-02T11:22:25Z","pushed_at":"2018-10-02T12:03:46Z","git_url":"git://github.com/STORM-IRIT/Radium-Engine.git","ssh_url":"git@github.com:STORM-IRIT/Radium-Engine.git","clone_url":"https://github.com/STORM-IRIT/Radium-Engine.git","svn_url":"https://github.com/STORM-IRIT/Radium-Engine","homepage":"https://storm-irit.github.io/Radium-Engine/","size":23520,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":54,"watchers":27,"default_branch":"master"}},"base":{"label":"STORM-IRIT:master-v1","ref":"master-v1","sha":"439eeb3408f46deaf877200e91997c1de2f73ad6","user":{"login":"STORM-IRIT","id":13313915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzEzOTE1","avatar_url":"https://avatars3.githubusercontent.com/u/13313915?v=4","gravatar_id":"","url":"https://api.github.com/users/STORM-IRIT","html_url":"https://github.com/STORM-IRIT","followers_url":"https://api.github.com/users/STORM-IRIT/followers","following_url":"https://api.github.com/users/STORM-IRIT/following{/other_user}","gists_url":"https://api.github.com/users/STORM-IRIT/gists{/gist_id}","starred_url":"https://api.github.com/users/STORM-IRIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STORM-IRIT/subscriptions","organizations_url":"https://api.github.com/users/STORM-IRIT/orgs","repos_url":"https://api.github.com/users/STORM-IRIT/repos","events_url":"https://api.github.com/users/STORM-IRIT/events{/privacy}","received_events_url":"https://api.github.com/users/STORM-IRIT/received_events","type":"Organization","site_admin":false},"repo":{"id":38614085,"node_id":"MDEwOlJlcG9zaXRvcnkzODYxNDA4NQ==","name":"Radium-Engine","full_name":"STORM-IRIT/Radium-Engine","private":false,"owner":{"login":"STORM-IRIT","id":13313915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzEzOTE1","avatar_url":"https://avatars3.githubusercontent.com/u/13313915?v=4","gravatar_id":"","url":"https://api.github.com/users/STORM-IRIT","html_url":"https://github.com/STORM-IRIT","followers_url":"https://api.github.com/users/STORM-IRIT/followers","following_url":"https://api.github.com/users/STORM-IRIT/following{/other_user}","gists_url":"https://api.github.com/users/STORM-IRIT/gists{/gist_id}","starred_url":"https://api.github.com/users/STORM-IRIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STORM-IRIT/subscriptions","organizations_url":"https://api.github.com/users/STORM-IRIT/orgs","repos_url":"https://api.github.com/users/STORM-IRIT/repos","events_url":"https://api.github.com/users/STORM-IRIT/events{/privacy}","received_events_url":"https://api.github.com/users/STORM-IRIT/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/STORM-IRIT/Radium-Engine","description":null,"fork":false,"url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine","forks_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/forks","keys_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/teams","hooks_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/hooks","issue_events_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/events{/number}","events_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/events","assignees_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/assignees{/user}","branches_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/branches{/branch}","tags_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/tags","blobs_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/statuses/{sha}","languages_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/languages","stargazers_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/stargazers","contributors_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/contributors","subscribers_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/subscribers","subscription_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/subscription","commits_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/contents/{+path}","compare_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/merges","archive_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/downloads","issues_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues{/number}","pulls_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/pulls{/number}","milestones_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/milestones{/number}","notifications_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/labels{/name}","releases_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/releases{/id}","deployments_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/deployments","created_at":"2015-07-06T11:14:38Z","updated_at":"2018-10-02T11:22:25Z","pushed_at":"2018-10-02T12:03:46Z","git_url":"git://github.com/STORM-IRIT/Radium-Engine.git","ssh_url":"git@github.com:STORM-IRIT/Radium-Engine.git","clone_url":"https://github.com/STORM-IRIT/Radium-Engine.git","svn_url":"https://github.com/STORM-IRIT/Radium-Engine","homepage":"https://storm-irit.github.io/Radium-Engine/","size":23520,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":54,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/pulls/368"},"html":{"href":"https://github.com/STORM-IRIT/Radium-Engine/pull/368"},"issue":{"href":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/368"},"comments":{"href":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/368/comments"},"review_comments":{"href":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/pulls/368/comments"},"review_comment":{"href":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/pulls/368/commits"},"statuses":{"href":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/statuses/108a679f0faf39df1cde12f9aeaefedaae7c848c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":95,"deletions":110,"changed_files":12}}
{"actor":{"display_login":"nmellado"}}