{"action":"created","issue":{"url":"https://api.github.com/repos/oppia/oppia/issues/5272","repository_url":"https://api.github.com/repos/oppia/oppia","labels_url":"https://api.github.com/repos/oppia/oppia/issues/5272/labels{/name}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5272/comments","events_url":"https://api.github.com/repos/oppia/oppia/issues/5272/events","html_url":"https://github.com/oppia/oppia/pull/5272","id":340692820,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDQzODIz","number":5272,"title":"Fixating position of preview tab's reset button to bottom right corner.","user":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"labels":[{"id":638838928,"node_id":"MDU6TGFiZWw2Mzg4Mzg5Mjg=","url":"https://api.github.com/repos/oppia/oppia/labels/PR:%20for%20current%20release","name":"PR: for current release","color":"FF69B4","default":false}],"state":"closed","locked":false,"assignee":{"login":"DubeySandeep","id":16653571,"node_id":"MDQ6VXNlcjE2NjUzNTcx","avatar_url":"https://avatars0.githubusercontent.com/u/16653571?v=4","gravatar_id":"","url":"https://api.github.com/users/DubeySandeep","html_url":"https://github.com/DubeySandeep","followers_url":"https://api.github.com/users/DubeySandeep/followers","following_url":"https://api.github.com/users/DubeySandeep/following{/other_user}","gists_url":"https://api.github.com/users/DubeySandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/DubeySandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DubeySandeep/subscriptions","organizations_url":"https://api.github.com/users/DubeySandeep/orgs","repos_url":"https://api.github.com/users/DubeySandeep/repos","events_url":"https://api.github.com/users/DubeySandeep/events{/privacy}","received_events_url":"https://api.github.com/users/DubeySandeep/received_events","type":"User","site_admin":false},"assignees":[{"login":"DubeySandeep","id":16653571,"node_id":"MDQ6VXNlcjE2NjUzNTcx","avatar_url":"https://avatars0.githubusercontent.com/u/16653571?v=4","gravatar_id":"","url":"https://api.github.com/users/DubeySandeep","html_url":"https://github.com/DubeySandeep","followers_url":"https://api.github.com/users/DubeySandeep/followers","following_url":"https://api.github.com/users/DubeySandeep/following{/other_user}","gists_url":"https://api.github.com/users/DubeySandeep/gists{/gist_id}","starred_url":"https://api.github.com/users/DubeySandeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DubeySandeep/subscriptions","organizations_url":"https://api.github.com/users/DubeySandeep/orgs","repos_url":"https://api.github.com/users/DubeySandeep/repos","events_url":"https://api.github.com/users/DubeySandeep/events{/privacy}","received_events_url":"https://api.github.com/users/DubeySandeep/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-07-12T15:39:52Z","updated_at":"2018-07-13T11:21:53Z","closed_at":"2018-07-13T09:33:38Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5272","html_url":"https://github.com/oppia/oppia/pull/5272","diff_url":"https://github.com/oppia/oppia/pull/5272.diff","patch_url":"https://github.com/oppia/oppia/pull/5272.patch"},"body":"<!--\r\n  - Thanks for submitting code to Oppia! Please fill out the following as part of\r\n  - your pull request so we can review your code more easily.\r\n  -->\r\n\r\n## Explanation\r\n<!--\r\n  - Explain what your PR does. If this PR fixes an existing bug, please include \r\n  - \"Fixes #bugnum:\" in the explanation so that GitHub can auto-close the issue \r\n  - when this PR is merged.\r\n  -->\r\nThis PR fixes #5092 which was introduced by my 3301699 commit. Some before and after pics:\r\nBefore (current develop) : \r\n![screen shot 2018-07-12 at 11 35 58 am](https://user-images.githubusercontent.com/11153258/42643834-1b34b9dc-85c8-11e8-8980-9aa56e81ce0a.png)\r\nAfter fix : \r\n![screen shot 2018-07-12 at 11 33 29 am](https://user-images.githubusercontent.com/11153258/42643844-2154697a-85c8-11e8-91a9-a53a61ee5e40.png)\r\n\r\n\r\n## Checklist\r\n- [ ] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes.\r\n- [ ] The PR explanation includes the words \"Fixes #bugnum: ...\".\r\n- [ ] The linter/Karma presubmit checks have passed.\r\n  - These should run automatically, but if not, you can manually trigger them locally using `python scripts/pre_commit_linter.py` and `bash scripts/run_frontend_tests.sh`.\r\n- [ ] The PR is made from a branch that's **not** called \"develop\".\r\n- [ ] The PR follows the [style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide).\r\n- [ ] The PR is assigned to an appropriate reviewer.\r\n  - If you're a new contributor, please ask on [Gitter](https://gitter.im/oppia/oppia-chat) for someone to assign a reviewer.\r\n  - If you're not sure who the appropriate reviewer is, please assign to the issue's \"owner\" -- see the \"talk-to\" label on the issue.\r\n"},"comment":{"url":"https://api.github.com/repos/oppia/oppia/issues/comments/404805102","html_url":"https://github.com/oppia/oppia/pull/5272#issuecomment-404805102","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5272","id":404805102,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDgwNTEwMg==","user":{"login":"hoangviet1993","id":11153258,"node_id":"MDQ6VXNlcjExMTUzMjU4","avatar_url":"https://avatars2.githubusercontent.com/u/11153258?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangviet1993","html_url":"https://github.com/hoangviet1993","followers_url":"https://api.github.com/users/hoangviet1993/followers","following_url":"https://api.github.com/users/hoangviet1993/following{/other_user}","gists_url":"https://api.github.com/users/hoangviet1993/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangviet1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangviet1993/subscriptions","organizations_url":"https://api.github.com/users/hoangviet1993/orgs","repos_url":"https://api.github.com/users/hoangviet1993/repos","events_url":"https://api.github.com/users/hoangviet1993/events{/privacy}","received_events_url":"https://api.github.com/users/hoangviet1993/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T11:21:53Z","updated_at":"2018-07-13T11:21:53Z","author_association":"CONTRIBUTOR","body":"I can adjust the button location should any user wanting the original design back. \r\n\r\nShould that happen, it would definitely require me moving the \"Restart from beginning\" button to base.html, which I do not think makes sense systematically. It would also need more code written to support the button from base.js. \r\n\r\nOverall, although I could not achieve restoring the original look, this PR is still a good compromise imo."}}
{"actor":{"display_login":"hoangviet1993"}}