{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/brew/issues/5061","repository_url":"https://api.github.com/repos/Homebrew/brew","labels_url":"https://api.github.com/repos/Homebrew/brew/issues/5061/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/5061/comments","events_url":"https://api.github.com/repos/Homebrew/brew/issues/5061/events","html_url":"https://github.com/Homebrew/brew/pull/5061","id":367616013,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTg4MDQ5","number":5061,"title":"Cask: set write permissions on symlinks","user":{"login":"amyspark","id":13498015,"node_id":"MDQ6VXNlcjEzNDk4MDE1","avatar_url":"https://avatars3.githubusercontent.com/u/13498015?v=4","gravatar_id":"","url":"https://api.github.com/users/amyspark","html_url":"https://github.com/amyspark","followers_url":"https://api.github.com/users/amyspark/followers","following_url":"https://api.github.com/users/amyspark/following{/other_user}","gists_url":"https://api.github.com/users/amyspark/gists{/gist_id}","starred_url":"https://api.github.com/users/amyspark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amyspark/subscriptions","organizations_url":"https://api.github.com/users/amyspark/orgs","repos_url":"https://api.github.com/users/amyspark/repos","events_url":"https://api.github.com/users/amyspark/events{/privacy}","received_events_url":"https://api.github.com/users/amyspark/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-08T01:37:16Z","updated_at":"2018-10-08T09:42:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/5061","html_url":"https://github.com/Homebrew/brew/pull/5061","diff_url":"https://github.com/Homebrew/brew/pull/5061.diff","patch_url":"https://github.com/Homebrew/brew/pull/5061.patch"},"body":"- [X] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [X] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [X] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/brew/blob/master/Library/Homebrew/test/PATH_spec.rb).\r\n- [X] Have you successfully run `brew style` with your changes locally?\r\n- [X] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\nRelated to Homebrew/homebrew-cask-versions#6368, turns out some zip files ship with symbolic links set to read-only for the current user, which is not covered by `chmod -R` (it needs the `-h` flag which is mutually exclusive).\r\n\r\nThis pull request adds an extra pass that only touches symlinks on the staged path, courtesy of `xargs`.\r\n\r\nPing @Homebrew/brew for review, as it blocks the AdoptOpenJDK Cask.\r\n"},"comment":{"url":"https://api.github.com/repos/Homebrew/brew/issues/comments/427775167","html_url":"https://github.com/Homebrew/brew/pull/5061#issuecomment-427775167","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/5061","id":427775167,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzc3NTE2Nw==","user":{"login":"amyspark","id":13498015,"node_id":"MDQ6VXNlcjEzNDk4MDE1","avatar_url":"https://avatars3.githubusercontent.com/u/13498015?v=4","gravatar_id":"","url":"https://api.github.com/users/amyspark","html_url":"https://github.com/amyspark","followers_url":"https://api.github.com/users/amyspark/followers","following_url":"https://api.github.com/users/amyspark/following{/other_user}","gists_url":"https://api.github.com/users/amyspark/gists{/gist_id}","starred_url":"https://api.github.com/users/amyspark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amyspark/subscriptions","organizations_url":"https://api.github.com/users/amyspark/orgs","repos_url":"https://api.github.com/users/amyspark/repos","events_url":"https://api.github.com/users/amyspark/events{/privacy}","received_events_url":"https://api.github.com/users/amyspark/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T09:42:47Z","updated_at":"2018-10-08T09:42:47Z","author_association":"MEMBER","body":"Under normal circumstances yes @claui. However, the propagation step does not follow symlinks (they can be broken e.g. `disk-inventory-x`'s Frameworks folder). It adds the extended attribute on the symlink itself, which is why it needs the `+w` permission."}}
{"actor":{"display_login":"amyspark"}}