{"action":"created","issue":{"url":"https://api.github.com/repos/nvaccess/nvda/issues/8051","repository_url":"https://api.github.com/repos/nvaccess/nvda","labels_url":"https://api.github.com/repos/nvaccess/nvda/issues/8051/labels{/name}","comments_url":"https://api.github.com/repos/nvaccess/nvda/issues/8051/comments","events_url":"https://api.github.com/repos/nvaccess/nvda/issues/8051/events","html_url":"https://github.com/nvaccess/nvda/pull/8051","id":301512695,"number":8051,"title":"Fix problems with ALVA protocol converter and time synchronisation","user":{"login":"leonardder","id":3049216,"avatar_url":"https://avatars1.githubusercontent.com/u/3049216?v=4","gravatar_id":"","url":"https://api.github.com/users/leonardder","html_url":"https://github.com/leonardder","followers_url":"https://api.github.com/users/leonardder/followers","following_url":"https://api.github.com/users/leonardder/following{/other_user}","gists_url":"https://api.github.com/users/leonardder/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardder/subscriptions","organizations_url":"https://api.github.com/users/leonardder/orgs","repos_url":"https://api.github.com/users/leonardder/repos","events_url":"https://api.github.com/users/leonardder/events{/privacy}","received_events_url":"https://api.github.com/users/leonardder/received_events","type":"User","site_admin":false},"labels":[{"id":284595196,"url":"https://api.github.com/repos/nvaccess/nvda/labels/Braille","name":"Braille","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-01T18:34:31Z","updated_at":"2018-03-02T12:49:42Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/nvaccess/nvda/pulls/8051","html_url":"https://github.com/nvaccess/nvda/pull/8051","diff_url":"https://github.com/nvaccess/nvda/pull/8051.diff","patch_url":"https://github.com/nvaccess/nvda/pull/8051.patch"},"body":"### Link to issue number:\r\nCloses #6731\r\n\r\n### Summary of the issue:\r\nThe ALVA protocol converter does not yet work correctly. This is because NVDA requests a feature report for the current display time. The converter returns a time report padded with zeros. Trying to create a datetime.datetime object with zeros raises a ValueError.\r\n\r\n### Description of how this pull request fixes the issue:\r\n1. Return early when interpretting a time report that has a year of 0.\r\n2. The request for the display time is now enclosed in a try/except block, failure is handled gracefully.\r\n\r\n### Testing performed:\r\nNone. @Adriani90 is again kindly asked to perform testing with [this](https://ci.appveyor.com/api/buildjobs/hrb0i89s01acq35l/artifacts/output%2Fnvda_snapshot_try-alvaFix-14899%2Cfd222ab8.exe). @dkager, could you please test this with your BC640?\r\n\r\n### Known issues with pull request:\r\nNone\r\n\r\n### Change log entry:\r\nChanges since RC1\r\n\r\n* The ALVA Protocol Converter should now really work as advertised (#8047)"},"comment":{"url":"https://api.github.com/repos/nvaccess/nvda/issues/comments/369912496","html_url":"https://github.com/nvaccess/nvda/pull/8051#issuecomment-369912496","issue_url":"https://api.github.com/repos/nvaccess/nvda/issues/8051","id":369912496,"user":{"login":"michaelDCurran","id":14154141,"avatar_url":"https://avatars0.githubusercontent.com/u/14154141?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelDCurran","html_url":"https://github.com/michaelDCurran","followers_url":"https://api.github.com/users/michaelDCurran/followers","following_url":"https://api.github.com/users/michaelDCurran/following{/other_user}","gists_url":"https://api.github.com/users/michaelDCurran/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelDCurran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelDCurran/subscriptions","organizations_url":"https://api.github.com/users/michaelDCurran/orgs","repos_url":"https://api.github.com/users/michaelDCurran/repos","events_url":"https://api.github.com/users/michaelDCurran/events{/privacy}","received_events_url":"https://api.github.com/users/michaelDCurran/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T12:49:42Z","updated_at":"2018-03-02T12:49:42Z","author_association":"CONTRIBUTOR","body":"New try build: https://ci.appveyor.com/api/buildjobs/7h3fylu2n1u5uuae/artifacts/output%2Fnvda_snapshot_try-alvaFixes-14900%2C8f6ece88.exe"}}
{"actor":{"display_login":"michaelDCurran"}}