{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/178437989","pull_request_review_id":108498660,"id":178437989,"diff_hunk":"@@ -85,53 +87,48 @@ class ConnectionPool {\n   /// \\param type The type of connection.\n   /// \\param conn The actual connection.\n   /// \\return Status of invoking this method.\n-  ray::Status RemoveSender(ConnectionType type, SenderConnection::pointer conn);\n+  ray::Status RemoveSender(ConnectionType type, boost::shared_ptr<SenderConnection> conn);\n+\n+  /// This object cannot be copied for thread-safety.\n+  ConnectionPool &operator=(const ConnectionPool &o) {\n+    throw std::runtime_error(\"Can't copy ConnectionPool.\");\n+  }\n \n  private:\n   /// A container type that maps ClientID to a connection type.\n   using SenderMapType =\n-      std::unordered_map<ray::ClientID, std::vector<SenderConnection::pointer>,\n+      std::unordered_map<ray::ClientID, std::vector<boost::shared_ptr<SenderConnection>>,\n                          ray::UniqueIDHasher>;\n   using ReceiverMapType =\n-      std::unordered_map<ray::ClientID, std::vector<std::shared_ptr<ReceiverConnection>>,\n+      std::unordered_map<ray::ClientID, std::vector<std::shared_ptr<TcpClientConnection>>,\n                          ray::UniqueIDHasher>;\n \n   /// Adds a receiver for ClientID to the given map.\n   void Add(ReceiverMapType &conn_map, const ClientID &client_id,\n-           std::shared_ptr<ReceiverConnection> conn);\n+           std::shared_ptr<TcpClientConnection> conn);\n \n   /// Adds a sender for ClientID to the given map.\n   void Add(SenderMapType &conn_map, const ClientID &client_id,\n-           SenderConnection::pointer conn);\n+           boost::shared_ptr<SenderConnection> conn);\n \n   /// Removes the given receiver for ClientID from the given map.\n   void Remove(ReceiverMapType &conn_map, const ClientID &client_id,\n-              std::shared_ptr<ReceiverConnection> conn);\n+              std::shared_ptr<TcpClientConnection> conn);\n \n   /// Returns the count of sender connections to ClientID.\n   uint64_t Count(SenderMapType &conn_map, const ClientID &client_id);\n \n   /// Removes a sender connection to ClientID from the pool of available connections.\n   /// This method assumes conn_map has available connections to ClientID.\n-  SenderConnection::pointer Borrow(SenderMapType &conn_map, const ClientID &client_id);\n+  boost::shared_ptr<SenderConnection> Borrow(SenderMapType &conn_map,","path":"src/ray/object_manager/connection_pool.h","position":130,"original_position":130,"commit_id":"64121b208056a674fc55032aef8a6edc06cf01ec","original_commit_id":"64121b208056a674fc55032aef8a6edc06cf01ec","user":{"login":"pcmoritz","id":113316,"avatar_url":"https://avatars1.githubusercontent.com/u/113316?v=4","gravatar_id":"","url":"https://api.github.com/users/pcmoritz","html_url":"https://github.com/pcmoritz","followers_url":"https://api.github.com/users/pcmoritz/followers","following_url":"https://api.github.com/users/pcmoritz/following{/other_user}","gists_url":"https://api.github.com/users/pcmoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/pcmoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcmoritz/subscriptions","organizations_url":"https://api.github.com/users/pcmoritz/orgs","repos_url":"https://api.github.com/users/pcmoritz/repos","events_url":"https://api.github.com/users/pcmoritz/events{/privacy}","received_events_url":"https://api.github.com/users/pcmoritz/received_events","type":"User","site_admin":false},"body":"std::shared_ptr","created_at":"2018-03-31T17:55:56Z","updated_at":"2018-03-31T17:55:56Z","html_url":"https://github.com/ray-project/ray/pull/1802#discussion_r178437989","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/1802","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/178437989"},"html":{"href":"https://github.com/ray-project/ray/pull/1802#discussion_r178437989"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1802"}}},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/1802","id":178515798,"html_url":"https://github.com/ray-project/ray/pull/1802","diff_url":"https://github.com/ray-project/ray/pull/1802.diff","patch_url":"https://github.com/ray-project/ray/pull/1802.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/1802","number":1802,"state":"open","locked":false,"title":"Multithreaded ObjectManager","user":{"login":"elibol","id":1884921,"avatar_url":"https://avatars1.githubusercontent.com/u/1884921?v=4","gravatar_id":"","url":"https://api.github.com/users/elibol","html_url":"https://github.com/elibol","followers_url":"https://api.github.com/users/elibol/followers","following_url":"https://api.github.com/users/elibol/following{/other_user}","gists_url":"https://api.github.com/users/elibol/gists{/gist_id}","starred_url":"https://api.github.com/users/elibol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elibol/subscriptions","organizations_url":"https://api.github.com/users/elibol/orgs","repos_url":"https://api.github.com/users/elibol/repos","events_url":"https://api.github.com/users/elibol/events{/privacy}","received_events_url":"https://api.github.com/users/elibol/received_events","type":"User","site_admin":false},"body":"Multithreaded ObjectManager with feedback incorporated from #1785.\r\n\r\nSupersedes #1791.","created_at":"2018-03-30T08:15:18Z","updated_at":"2018-03-31T17:55:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5640df856b64379d9386c45c597a5495322576fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/1802/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/1802/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/1802/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/64121b208056a674fc55032aef8a6edc06cf01ec","head":{"label":"elibol:melih/multithreading","ref":"melih/multithreading","sha":"64121b208056a674fc55032aef8a6edc06cf01ec","user":{"login":"elibol","id":1884921,"avatar_url":"https://avatars1.githubusercontent.com/u/1884921?v=4","gravatar_id":"","url":"https://api.github.com/users/elibol","html_url":"https://github.com/elibol","followers_url":"https://api.github.com/users/elibol/followers","following_url":"https://api.github.com/users/elibol/following{/other_user}","gists_url":"https://api.github.com/users/elibol/gists{/gist_id}","starred_url":"https://api.github.com/users/elibol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elibol/subscriptions","organizations_url":"https://api.github.com/users/elibol/orgs","repos_url":"https://api.github.com/users/elibol/repos","events_url":"https://api.github.com/users/elibol/events{/privacy}","received_events_url":"https://api.github.com/users/elibol/received_events","type":"User","site_admin":false},"repo":{"id":110614811,"name":"ray","full_name":"elibol/ray","owner":{"login":"elibol","id":1884921,"avatar_url":"https://avatars1.githubusercontent.com/u/1884921?v=4","gravatar_id":"","url":"https://api.github.com/users/elibol","html_url":"https://github.com/elibol","followers_url":"https://api.github.com/users/elibol/followers","following_url":"https://api.github.com/users/elibol/following{/other_user}","gists_url":"https://api.github.com/users/elibol/gists{/gist_id}","starred_url":"https://api.github.com/users/elibol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elibol/subscriptions","organizations_url":"https://api.github.com/users/elibol/orgs","repos_url":"https://api.github.com/users/elibol/repos","events_url":"https://api.github.com/users/elibol/events{/privacy}","received_events_url":"https://api.github.com/users/elibol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elibol/ray","description":"A high-performance distributed execution engine","fork":true,"url":"https://api.github.com/repos/elibol/ray","forks_url":"https://api.github.com/repos/elibol/ray/forks","keys_url":"https://api.github.com/repos/elibol/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elibol/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elibol/ray/teams","hooks_url":"https://api.github.com/repos/elibol/ray/hooks","issue_events_url":"https://api.github.com/repos/elibol/ray/issues/events{/number}","events_url":"https://api.github.com/repos/elibol/ray/events","assignees_url":"https://api.github.com/repos/elibol/ray/assignees{/user}","branches_url":"https://api.github.com/repos/elibol/ray/branches{/branch}","tags_url":"https://api.github.com/repos/elibol/ray/tags","blobs_url":"https://api.github.com/repos/elibol/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elibol/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elibol/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/elibol/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elibol/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/elibol/ray/languages","stargazers_url":"https://api.github.com/repos/elibol/ray/stargazers","contributors_url":"https://api.github.com/repos/elibol/ray/contributors","subscribers_url":"https://api.github.com/repos/elibol/ray/subscribers","subscription_url":"https://api.github.com/repos/elibol/ray/subscription","commits_url":"https://api.github.com/repos/elibol/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/elibol/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/elibol/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/elibol/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/elibol/ray/contents/{+path}","compare_url":"https://api.github.com/repos/elibol/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elibol/ray/merges","archive_url":"https://api.github.com/repos/elibol/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elibol/ray/downloads","issues_url":"https://api.github.com/repos/elibol/ray/issues{/number}","pulls_url":"https://api.github.com/repos/elibol/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/elibol/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/elibol/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elibol/ray/labels{/name}","releases_url":"https://api.github.com/repos/elibol/ray/releases{/id}","deployments_url":"https://api.github.com/repos/elibol/ray/deployments","created_at":"2017-11-13T23:32:29Z","updated_at":"2018-03-23T06:14:05Z","pushed_at":"2018-03-31T05:14:43Z","git_url":"git://github.com/elibol/ray.git","ssh_url":"git@github.com:elibol/ray.git","clone_url":"https://github.com/elibol/ray.git","svn_url":"https://github.com/elibol/ray","homepage":"","size":10929,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ray-project:xray-task-forwarding","ref":"xray-task-forwarding","sha":"55717ff091f51033882af7cbba7a2429f666ea52","user":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"name":"ray","full_name":"ray-project/ray","owner":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray","description":"A high-performance distributed execution engine","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2018-03-31T17:33:47Z","pushed_at":"2018-03-31T17:33:42Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"","size":10330,"stargazers_count":2887,"watchers_count":2887,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":374,"mirror_url":null,"archived":false,"open_issues_count":267,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":374,"open_issues":267,"watchers":2887,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1802"},"html":{"href":"https://github.com/ray-project/ray/pull/1802"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/1802"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/1802/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1802/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1802/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/64121b208056a674fc55032aef8a6edc06cf01ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pcmoritz"}}