{"action":"created","issue":{"url":"https://api.github.com/repos/pmorissette/bt/issues/140","repository_url":"https://api.github.com/repos/pmorissette/bt","labels_url":"https://api.github.com/repos/pmorissette/bt/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/pmorissette/bt/issues/140/comments","events_url":"https://api.github.com/repos/pmorissette/bt/issues/140/events","html_url":"https://github.com/pmorissette/bt/pull/140","id":313877177,"number":140,"title":"Run* Algos Overhaul","user":{"login":"JordanPlatts","id":3238194,"avatar_url":"https://avatars3.githubusercontent.com/u/3238194?v=4","gravatar_id":"","url":"https://api.github.com/users/JordanPlatts","html_url":"https://github.com/JordanPlatts","followers_url":"https://api.github.com/users/JordanPlatts/followers","following_url":"https://api.github.com/users/JordanPlatts/following{/other_user}","gists_url":"https://api.github.com/users/JordanPlatts/gists{/gist_id}","starred_url":"https://api.github.com/users/JordanPlatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordanPlatts/subscriptions","organizations_url":"https://api.github.com/users/JordanPlatts/orgs","repos_url":"https://api.github.com/users/JordanPlatts/repos","events_url":"https://api.github.com/users/JordanPlatts/events{/privacy}","received_events_url":"https://api.github.com/users/JordanPlatts/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-12T20:32:43Z","updated_at":"2018-04-13T23:11:43Z","closed_at":"2018-04-13T20:47:12Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/pmorissette/bt/pulls/140","html_url":"https://github.com/pmorissette/bt/pull/140","diff_url":"https://github.com/pmorissette/bt/pull/140.diff","patch_url":"https://github.com/pmorissette/bt/pull/140.patch"},"body":"Changed Run* Algos to use universe of dates to decide if it is the end or beginning of a period. \r\n\r\nIt has the ability to run on the first date or the last date instead of running on the first call or the last call. It also has ability to run on either the first of the period or the last of the period.\r\n\r\nThe biggest difference will be if the algo doesn't run on the first(or last if run_on_end_of_period == True) date in the period, then it will not run at all. For example, if you have a RunMonthly algo with run_on_end_of_period == False and it does not run on the first date in the month from the universe of dates it was given because an algo before it in the stack returned False, then it will not run all month. If the Run* algo is at the beginning of stack, then there is no difference. \r\n\r\nThis logic seems more intuitive for me but I thought I would ask the community first.\r\n@FinQuest \r\n@pmorissette \r\n"},"comment":{"url":"https://api.github.com/repos/pmorissette/bt/issues/comments/381281643","html_url":"https://github.com/pmorissette/bt/pull/140#issuecomment-381281643","issue_url":"https://api.github.com/repos/pmorissette/bt/issues/140","id":381281643,"user":{"login":"JordanPlatts","id":3238194,"avatar_url":"https://avatars3.githubusercontent.com/u/3238194?v=4","gravatar_id":"","url":"https://api.github.com/users/JordanPlatts","html_url":"https://github.com/JordanPlatts","followers_url":"https://api.github.com/users/JordanPlatts/followers","following_url":"https://api.github.com/users/JordanPlatts/following{/other_user}","gists_url":"https://api.github.com/users/JordanPlatts/gists{/gist_id}","starred_url":"https://api.github.com/users/JordanPlatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordanPlatts/subscriptions","organizations_url":"https://api.github.com/users/JordanPlatts/orgs","repos_url":"https://api.github.com/users/JordanPlatts/repos","events_url":"https://api.github.com/users/JordanPlatts/events{/privacy}","received_events_url":"https://api.github.com/users/JordanPlatts/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T23:11:43Z","updated_at":"2018-04-13T23:11:43Z","author_association":"COLLABORATOR","body":"@finquest the change in this pull request seems more intuitive to me. It relies on the dates in the universe given to it and not on the dates the algo has seen. Do you think it is more complex?  Be honest with me too. I won't take it personal. I appreciate any feedback."}}
{"actor":{"display_login":"JordanPlatts"}}