{"action":"created","comment":{"url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/comments/230589363","pull_request_review_id":171363118,"id":230589363,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDU4OTM2Mw==","diff_hunk":"@@ -46,4 +47,11 @@ object future {\n     def toFutureE(f: E => Throwable): IO[Nothing, Future[A]] = io.leftMap(f).toFuture\n   }\n \n+  class FutureOps[A](private val delayedFuture: () => Future[A]) extends AnyVal {\n+    def toIO(implicit ec: ExecutionContext): IO[Throwable, A]       = IOObjOps(IO).fromFuture(delayedFuture)(ec)\n+    def toFiber(implicit ec: ExecutionContext): Fiber[Throwable, A] = FiberObjOps(Fiber).fromFuture(delayedFuture())(ec)","path":"interop/shared/src/main/scala/scalaz/zio/interop/future.scala","position":14,"original_position":14,"commit_id":"87369340d0080787272b1745f4450fff3515f1ef","original_commit_id":"87369340d0080787272b1745f4450fff3515f1ef","user":{"login":"jdegoes","id":156745,"node_id":"MDQ6VXNlcjE1Njc0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/156745?v=4","gravatar_id":"","url":"https://api.github.com/users/jdegoes","html_url":"https://github.com/jdegoes","followers_url":"https://api.github.com/users/jdegoes/followers","following_url":"https://api.github.com/users/jdegoes/following{/other_user}","gists_url":"https://api.github.com/users/jdegoes/gists{/gist_id}","starred_url":"https://api.github.com/users/jdegoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdegoes/subscriptions","organizations_url":"https://api.github.com/users/jdegoes/orgs","repos_url":"https://api.github.com/users/jdegoes/repos","events_url":"https://api.github.com/users/jdegoes/events{/privacy}","received_events_url":"https://api.github.com/users/jdegoes/received_events","type":"User","site_admin":false},"body":"Let's rename `toIO` function to `unsafeToIO`, and then we can get this merged.","created_at":"2018-11-04T13:42:17Z","updated_at":"2018-11-04T13:42:17Z","html_url":"https://github.com/scalaz/scalaz-zio/pull/331#discussion_r230589363","pull_request_url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/331","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/comments/230589363"},"html":{"href":"https://github.com/scalaz/scalaz-zio/pull/331#discussion_r230589363"},"pull_request":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/331"}},"in_reply_to_id":230423352},"pull_request":{"url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/331","id":227319048,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MzE5MDQ4","html_url":"https://github.com/scalaz/scalaz-zio/pull/331","diff_url":"https://github.com/scalaz/scalaz-zio/pull/331.diff","patch_url":"https://github.com/scalaz/scalaz-zio/pull/331.patch","issue_url":"https://api.github.com/repos/scalaz/scalaz-zio/issues/331","number":331,"state":"open","locked":false,"title":"Enhance `interop` package for `Future`","user":{"login":"stankoua","id":3087990,"node_id":"MDQ6VXNlcjMwODc5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3087990?v=4","gravatar_id":"","url":"https://api.github.com/users/stankoua","html_url":"https://github.com/stankoua","followers_url":"https://api.github.com/users/stankoua/followers","following_url":"https://api.github.com/users/stankoua/following{/other_user}","gists_url":"https://api.github.com/users/stankoua/gists{/gist_id}","starred_url":"https://api.github.com/users/stankoua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stankoua/subscriptions","organizations_url":"https://api.github.com/users/stankoua/orgs","repos_url":"https://api.github.com/users/stankoua/repos","events_url":"https://api.github.com/users/stankoua/events{/privacy}","received_events_url":"https://api.github.com/users/stankoua/received_events","type":"User","site_admin":false},"body":"- Add syntax (implicit) on Future to convert to IO or Fiber\r\n- Add test for `Future.toIO` for a resolved `future`and a failed `future`\r\n- Add test for `Future.toFiber` for a resolved `future`and a failed `future`\r\nLink to #327","created_at":"2018-10-31T14:56:47Z","updated_at":"2018-11-04T13:42:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd336912d1edd3d0440fe9531d2b4cb112acc174","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/331/commits","review_comments_url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/331/comments","review_comment_url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalaz/scalaz-zio/issues/331/comments","statuses_url":"https://api.github.com/repos/scalaz/scalaz-zio/statuses/87369340d0080787272b1745f4450fff3515f1ef","head":{"label":"stankoua:interop-future-syntax","ref":"interop-future-syntax","sha":"87369340d0080787272b1745f4450fff3515f1ef","user":{"login":"stankoua","id":3087990,"node_id":"MDQ6VXNlcjMwODc5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3087990?v=4","gravatar_id":"","url":"https://api.github.com/users/stankoua","html_url":"https://github.com/stankoua","followers_url":"https://api.github.com/users/stankoua/followers","following_url":"https://api.github.com/users/stankoua/following{/other_user}","gists_url":"https://api.github.com/users/stankoua/gists{/gist_id}","starred_url":"https://api.github.com/users/stankoua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stankoua/subscriptions","organizations_url":"https://api.github.com/users/stankoua/orgs","repos_url":"https://api.github.com/users/stankoua/repos","events_url":"https://api.github.com/users/stankoua/events{/privacy}","received_events_url":"https://api.github.com/users/stankoua/received_events","type":"User","site_admin":false},"repo":{"id":155558698,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU1NTg2OTg=","name":"scalaz-zio","full_name":"stankoua/scalaz-zio","private":false,"owner":{"login":"stankoua","id":3087990,"node_id":"MDQ6VXNlcjMwODc5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3087990?v=4","gravatar_id":"","url":"https://api.github.com/users/stankoua","html_url":"https://github.com/stankoua","followers_url":"https://api.github.com/users/stankoua/followers","following_url":"https://api.github.com/users/stankoua/following{/other_user}","gists_url":"https://api.github.com/users/stankoua/gists{/gist_id}","starred_url":"https://api.github.com/users/stankoua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stankoua/subscriptions","organizations_url":"https://api.github.com/users/stankoua/orgs","repos_url":"https://api.github.com/users/stankoua/repos","events_url":"https://api.github.com/users/stankoua/events{/privacy}","received_events_url":"https://api.github.com/users/stankoua/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stankoua/scalaz-zio","description":"ZIO — A principled, powerful, standalone effect data type for any Scala project.","fork":true,"url":"https://api.github.com/repos/stankoua/scalaz-zio","forks_url":"https://api.github.com/repos/stankoua/scalaz-zio/forks","keys_url":"https://api.github.com/repos/stankoua/scalaz-zio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stankoua/scalaz-zio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stankoua/scalaz-zio/teams","hooks_url":"https://api.github.com/repos/stankoua/scalaz-zio/hooks","issue_events_url":"https://api.github.com/repos/stankoua/scalaz-zio/issues/events{/number}","events_url":"https://api.github.com/repos/stankoua/scalaz-zio/events","assignees_url":"https://api.github.com/repos/stankoua/scalaz-zio/assignees{/user}","branches_url":"https://api.github.com/repos/stankoua/scalaz-zio/branches{/branch}","tags_url":"https://api.github.com/repos/stankoua/scalaz-zio/tags","blobs_url":"https://api.github.com/repos/stankoua/scalaz-zio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stankoua/scalaz-zio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stankoua/scalaz-zio/git/refs{/sha}","trees_url":"https://api.github.com/repos/stankoua/scalaz-zio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stankoua/scalaz-zio/statuses/{sha}","languages_url":"https://api.github.com/repos/stankoua/scalaz-zio/languages","stargazers_url":"https://api.github.com/repos/stankoua/scalaz-zio/stargazers","contributors_url":"https://api.github.com/repos/stankoua/scalaz-zio/contributors","subscribers_url":"https://api.github.com/repos/stankoua/scalaz-zio/subscribers","subscription_url":"https://api.github.com/repos/stankoua/scalaz-zio/subscription","commits_url":"https://api.github.com/repos/stankoua/scalaz-zio/commits{/sha}","git_commits_url":"https://api.github.com/repos/stankoua/scalaz-zio/git/commits{/sha}","comments_url":"https://api.github.com/repos/stankoua/scalaz-zio/comments{/number}","issue_comment_url":"https://api.github.com/repos/stankoua/scalaz-zio/issues/comments{/number}","contents_url":"https://api.github.com/repos/stankoua/scalaz-zio/contents/{+path}","compare_url":"https://api.github.com/repos/stankoua/scalaz-zio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stankoua/scalaz-zio/merges","archive_url":"https://api.github.com/repos/stankoua/scalaz-zio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stankoua/scalaz-zio/downloads","issues_url":"https://api.github.com/repos/stankoua/scalaz-zio/issues{/number}","pulls_url":"https://api.github.com/repos/stankoua/scalaz-zio/pulls{/number}","milestones_url":"https://api.github.com/repos/stankoua/scalaz-zio/milestones{/number}","notifications_url":"https://api.github.com/repos/stankoua/scalaz-zio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stankoua/scalaz-zio/labels{/name}","releases_url":"https://api.github.com/repos/stankoua/scalaz-zio/releases{/id}","deployments_url":"https://api.github.com/repos/stankoua/scalaz-zio/deployments","created_at":"2018-10-31T13:04:49Z","updated_at":"2018-10-31T14:53:26Z","pushed_at":"2018-11-02T15:45:52Z","git_url":"git://github.com/stankoua/scalaz-zio.git","ssh_url":"git@github.com:stankoua/scalaz-zio.git","clone_url":"https://github.com/stankoua/scalaz-zio.git","svn_url":"https://github.com/stankoua/scalaz-zio","homepage":"https://scalaz.github.io/scalaz-zio/","size":1991,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalaz:master","ref":"master","sha":"989ca743611c82357efcdaa3ff9249d64a01eec7","user":{"login":"scalaz","id":183416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzQxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/183416?v=4","gravatar_id":"","url":"https://api.github.com/users/scalaz","html_url":"https://github.com/scalaz","followers_url":"https://api.github.com/users/scalaz/followers","following_url":"https://api.github.com/users/scalaz/following{/other_user}","gists_url":"https://api.github.com/users/scalaz/gists{/gist_id}","starred_url":"https://api.github.com/users/scalaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalaz/subscriptions","organizations_url":"https://api.github.com/users/scalaz/orgs","repos_url":"https://api.github.com/users/scalaz/repos","events_url":"https://api.github.com/users/scalaz/events{/privacy}","received_events_url":"https://api.github.com/users/scalaz/received_events","type":"Organization","site_admin":false},"repo":{"id":134079884,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQwNzk4ODQ=","name":"scalaz-zio","full_name":"scalaz/scalaz-zio","private":false,"owner":{"login":"scalaz","id":183416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzQxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/183416?v=4","gravatar_id":"","url":"https://api.github.com/users/scalaz","html_url":"https://github.com/scalaz","followers_url":"https://api.github.com/users/scalaz/followers","following_url":"https://api.github.com/users/scalaz/following{/other_user}","gists_url":"https://api.github.com/users/scalaz/gists{/gist_id}","starred_url":"https://api.github.com/users/scalaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalaz/subscriptions","organizations_url":"https://api.github.com/users/scalaz/orgs","repos_url":"https://api.github.com/users/scalaz/repos","events_url":"https://api.github.com/users/scalaz/events{/privacy}","received_events_url":"https://api.github.com/users/scalaz/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scalaz/scalaz-zio","description":"ZIO — A principled, powerful, standalone effect data type for any Scala project.","fork":false,"url":"https://api.github.com/repos/scalaz/scalaz-zio","forks_url":"https://api.github.com/repos/scalaz/scalaz-zio/forks","keys_url":"https://api.github.com/repos/scalaz/scalaz-zio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalaz/scalaz-zio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalaz/scalaz-zio/teams","hooks_url":"https://api.github.com/repos/scalaz/scalaz-zio/hooks","issue_events_url":"https://api.github.com/repos/scalaz/scalaz-zio/issues/events{/number}","events_url":"https://api.github.com/repos/scalaz/scalaz-zio/events","assignees_url":"https://api.github.com/repos/scalaz/scalaz-zio/assignees{/user}","branches_url":"https://api.github.com/repos/scalaz/scalaz-zio/branches{/branch}","tags_url":"https://api.github.com/repos/scalaz/scalaz-zio/tags","blobs_url":"https://api.github.com/repos/scalaz/scalaz-zio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalaz/scalaz-zio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalaz/scalaz-zio/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalaz/scalaz-zio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalaz/scalaz-zio/statuses/{sha}","languages_url":"https://api.github.com/repos/scalaz/scalaz-zio/languages","stargazers_url":"https://api.github.com/repos/scalaz/scalaz-zio/stargazers","contributors_url":"https://api.github.com/repos/scalaz/scalaz-zio/contributors","subscribers_url":"https://api.github.com/repos/scalaz/scalaz-zio/subscribers","subscription_url":"https://api.github.com/repos/scalaz/scalaz-zio/subscription","commits_url":"https://api.github.com/repos/scalaz/scalaz-zio/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalaz/scalaz-zio/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalaz/scalaz-zio/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalaz/scalaz-zio/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalaz/scalaz-zio/contents/{+path}","compare_url":"https://api.github.com/repos/scalaz/scalaz-zio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalaz/scalaz-zio/merges","archive_url":"https://api.github.com/repos/scalaz/scalaz-zio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalaz/scalaz-zio/downloads","issues_url":"https://api.github.com/repos/scalaz/scalaz-zio/issues{/number}","pulls_url":"https://api.github.com/repos/scalaz/scalaz-zio/pulls{/number}","milestones_url":"https://api.github.com/repos/scalaz/scalaz-zio/milestones{/number}","notifications_url":"https://api.github.com/repos/scalaz/scalaz-zio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalaz/scalaz-zio/labels{/name}","releases_url":"https://api.github.com/repos/scalaz/scalaz-zio/releases{/id}","deployments_url":"https://api.github.com/repos/scalaz/scalaz-zio/deployments","created_at":"2018-05-19T16:40:37Z","updated_at":"2018-11-04T12:41:51Z","pushed_at":"2018-11-04T13:33:37Z","git_url":"git://github.com/scalaz/scalaz-zio.git","ssh_url":"git@github.com:scalaz/scalaz-zio.git","clone_url":"https://github.com/scalaz/scalaz-zio.git","svn_url":"https://github.com/scalaz/scalaz-zio","homepage":"https://scalaz.github.io/scalaz-zio/","size":2043,"stargazers_count":400,"watchers_count":400,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":121,"open_issues":75,"watchers":400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/331"},"html":{"href":"https://github.com/scalaz/scalaz-zio/pull/331"},"issue":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/issues/331"},"comments":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/scalaz/scalaz-zio/statuses/87369340d0080787272b1745f4450fff3515f1ef"}},"author_association":"NONE"}}
{"actor":{"display_login":"jdegoes"}}