{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios-utilities/pulls/35","id":169596431,"html_url":"https://github.com/wireapp/wire-ios-utilities/pull/35","diff_url":"https://github.com/wireapp/wire-ios-utilities/pull/35.diff","patch_url":"https://github.com/wireapp/wire-ios-utilities/pull/35.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/issues/35","number":35,"state":"closed","locked":false,"title":"New length validator for strings","user":{"login":"mikeger","id":715129,"avatar_url":"https://avatars3.githubusercontent.com/u/715129?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeger","html_url":"https://github.com/mikeger","followers_url":"https://api.github.com/users/mikeger/followers","following_url":"https://api.github.com/users/mikeger/following{/other_user}","gists_url":"https://api.github.com/users/mikeger/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeger/subscriptions","organizations_url":"https://api.github.com/users/mikeger/orgs","repos_url":"https://api.github.com/users/mikeger/repos","events_url":"https://api.github.com/users/mikeger/events{/privacy}","received_events_url":"https://api.github.com/users/mikeger/received_events","type":"User","site_admin":false},"body":"## What's new in this PR?\r\n\r\n### Issues\r\n\r\nThe old string length validator was validating only the number of UTF16 code positions.\r\n\r\n### Causes\r\n\r\nIn Objective-C, the strings are represented in NSString as the sequence of UTF16 words.\r\n\r\n### Solutions\r\n\r\nRewrite the validator in Swift that is capable of counting the actual displayed characters, also fixed some typos.\r\n\r\nNew parameter `maximumByteLength` is added to make sure that the backend requirement on the byte length of fields can be satisfied.","created_at":"2018-02-16T10:59:57Z","updated_at":"2018-02-16T13:28:39Z","closed_at":"2018-02-16T13:28:39Z","merged_at":"2018-02-16T13:28:39Z","merge_commit_sha":"203195ba984c49dc2c7c99b2860400a749742721","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/pulls/35/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/pulls/35/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/issues/35/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/statuses/0c5952240ceb5e390323e7e350046ca8dbe9a6c1","head":{"label":"wireapp:fix/string-length-validator","ref":"fix/string-length-validator","sha":"0c5952240ceb5e390323e7e350046ca8dbe9a6c1","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":53574362,"name":"wire-ios-utilities","full_name":"wireapp/wire-ios-utilities","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-utilities","description":null,"fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-utilities","forks_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/deployments","created_at":"2016-03-10T10:02:34Z","updated_at":"2018-01-11T12:40:53Z","pushed_at":"2018-02-16T13:28:39Z","git_url":"git://github.com/wireapp/wire-ios-utilities.git","ssh_url":"git@github.com:wireapp/wire-ios-utilities.git","clone_url":"https://github.com/wireapp/wire-ios-utilities.git","svn_url":"https://github.com/wireapp/wire-ios-utilities","homepage":"https://wire.com","size":868,"stargazers_count":16,"watchers_count":16,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":6,"open_issues":1,"watchers":16,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"56cf9053cbf7ff68c32eb3ea91b2dcaae60e8eff","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":53574362,"name":"wire-ios-utilities","full_name":"wireapp/wire-ios-utilities","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-utilities","description":null,"fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-utilities","forks_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-utilities/deployments","created_at":"2016-03-10T10:02:34Z","updated_at":"2018-01-11T12:40:53Z","pushed_at":"2018-02-16T13:28:39Z","git_url":"git://github.com/wireapp/wire-ios-utilities.git","ssh_url":"git@github.com:wireapp/wire-ios-utilities.git","clone_url":"https://github.com/wireapp/wire-ios-utilities.git","svn_url":"https://github.com/wireapp/wire-ios-utilities","homepage":"https://wire.com","size":868,"stargazers_count":16,"watchers_count":16,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":6,"open_issues":1,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-utilities/pulls/35"},"html":{"href":"https://github.com/wireapp/wire-ios-utilities/pull/35"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios-utilities/issues/35"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-utilities/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-utilities/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios-utilities/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios-utilities/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios-utilities/statuses/0c5952240ceb5e390323e7e350046ca8dbe9a6c1"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mikeger","id":715129,"avatar_url":"https://avatars3.githubusercontent.com/u/715129?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeger","html_url":"https://github.com/mikeger","followers_url":"https://api.github.com/users/mikeger/followers","following_url":"https://api.github.com/users/mikeger/following{/other_user}","gists_url":"https://api.github.com/users/mikeger/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeger/subscriptions","organizations_url":"https://api.github.com/users/mikeger/orgs","repos_url":"https://api.github.com/users/mikeger/repos","events_url":"https://api.github.com/users/mikeger/events{/privacy}","received_events_url":"https://api.github.com/users/mikeger/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":3,"additions":99,"deletions":147,"changed_files":8}}
{"actor":{"display_login":"mikeger"}}