{"action":"created","issue":{"url":"https://api.github.com/repos/OpenSC/OpenSC/issues/1521","repository_url":"https://api.github.com/repos/OpenSC/OpenSC","labels_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/1521/labels{/name}","comments_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/1521/comments","events_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/1521/events","html_url":"https://github.com/OpenSC/OpenSC/pull/1521","id":375587530,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTk4NDIy","number":1521,"title":"incomplete mechanims list reported after merging RSA-PSS in some drivers","user":{"login":"Jakuje","id":2694489,"node_id":"MDQ6VXNlcjI2OTQ0ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2694489?v=4","gravatar_id":"","url":"https://api.github.com/users/Jakuje","html_url":"https://github.com/Jakuje","followers_url":"https://api.github.com/users/Jakuje/followers","following_url":"https://api.github.com/users/Jakuje/following{/other_user}","gists_url":"https://api.github.com/users/Jakuje/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakuje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakuje/subscriptions","organizations_url":"https://api.github.com/users/Jakuje/orgs","repos_url":"https://api.github.com/users/Jakuje/repos","events_url":"https://api.github.com/users/Jakuje/events{/privacy}","received_events_url":"https://api.github.com/users/Jakuje/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-30T16:43:29Z","updated_at":"2018-10-31T15:05:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/1521","html_url":"https://github.com/OpenSC/OpenSC/pull/1521","diff_url":"https://github.com/OpenSC/OpenSC/pull/1521.diff","patch_url":"https://github.com/OpenSC/OpenSC/pull/1521.patch"},"body":"After merging the change #1435 (RSA-PSS emulation), the cardos card stopped reporting the hashed mechanisms (for example `SHA1-RSA-PKCS`). This is done by changing of the semantics of the constant `SC_ALGORITHM_RSA_HASH_NONE`. ~~The attached patch resolves the issue for CardOS, cards we have around, but we might need some more system solution, because there might be more affected card drivers I can not test.~~\r\n\r\n~~I will leave the PR as it is now, but I will have a look tomorrow if there is a way how to resolve it systematically (sigh ... there is no sensible explanation what is the `SC_ALGORITHM_RSA_HASH_NONE` supposed to mean initially). Comments and proposals welcomed.~~\r\n\r\nThe current patch solves the issue in the mechanism registration function, which was wrong since the RSA-PSS implementation. Also other cards that depended on this behavior should start working with this PR.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n- [X] PKCS#11 module is tested\r\n- [ ] Windows minidriver is tested\r\n- [ ] macOS tokend is tested\r\n"},"comment":{"url":"https://api.github.com/repos/OpenSC/OpenSC/issues/comments/434722664","html_url":"https://github.com/OpenSC/OpenSC/pull/1521#issuecomment-434722664","issue_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/1521","id":434722664,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDcyMjY2NA==","user":{"login":"Jakuje","id":2694489,"node_id":"MDQ6VXNlcjI2OTQ0ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2694489?v=4","gravatar_id":"","url":"https://api.github.com/users/Jakuje","html_url":"https://github.com/Jakuje","followers_url":"https://api.github.com/users/Jakuje/followers","following_url":"https://api.github.com/users/Jakuje/following{/other_user}","gists_url":"https://api.github.com/users/Jakuje/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakuje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakuje/subscriptions","organizations_url":"https://api.github.com/users/Jakuje/orgs","repos_url":"https://api.github.com/users/Jakuje/repos","events_url":"https://api.github.com/users/Jakuje/events{/privacy}","received_events_url":"https://api.github.com/users/Jakuje/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T15:05:06Z","updated_at":"2018-10-31T15:05:06Z","author_association":"CONTRIBUTOR","body":"Hmm ...it might need some more love ... still looking into that."}}
{"actor":{"display_login":"Jakuje"}}