{"action":"created","comment":{"url":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/comments/229352809","pull_request_review_id":169831565,"id":229352809,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTM1MjgwOQ==","diff_hunk":"@@ -334,7 +334,8 @@ void MDHelper::SetMetricSetFiltering( TMetricApiType apiMask )\n /************************************************************************/\n void MDHelper::GetMetricsFromReport(\n     const char* pReportData,\n-    std::vector<TTypedValue_1_0>& results )\n+    std::vector<TTypedValue_1_0>& results,\n+\tstd::vector<TTypedValue_1_0>* maxValues)","path":"mdapi/MetricsDiscoveryHelper.cpp","position":6,"original_position":6,"commit_id":"955243dc2bb1989f67bb90a94cc3d78e4d7b5282","original_commit_id":"955243dc2bb1989f67bb90a94cc3d78e4d7b5282","user":{"login":"bashbaug","id":14812095,"node_id":"MDQ6VXNlcjE0ODEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/14812095?v=4","gravatar_id":"","url":"https://api.github.com/users/bashbaug","html_url":"https://github.com/bashbaug","followers_url":"https://api.github.com/users/bashbaug/followers","following_url":"https://api.github.com/users/bashbaug/following{/other_user}","gists_url":"https://api.github.com/users/bashbaug/gists{/gist_id}","starred_url":"https://api.github.com/users/bashbaug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashbaug/subscriptions","organizations_url":"https://api.github.com/users/bashbaug/orgs","repos_url":"https://api.github.com/users/bashbaug/repos","events_url":"https://api.github.com/users/bashbaug/events{/privacy}","received_events_url":"https://api.github.com/users/bashbaug/received_events","type":"User","site_admin":false},"body":"Passing a pointer to a vector feels a bit icky.  Is there any way to avoid this?  One option is to store the max values data in the same result vector, similar to the way it is currently storing both the \"metrics\" and \"information\".","created_at":"2018-10-30T15:20:40Z","updated_at":"2018-10-30T15:25:49Z","html_url":"https://github.com/intel/opencl-intercept-layer/pull/50#discussion_r229352809","pull_request_url":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/50","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/comments/229352809"},"html":{"href":"https://github.com/intel/opencl-intercept-layer/pull/50#discussion_r229352809"},"pull_request":{"href":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/50","id":225691490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NjkxNDkw","html_url":"https://github.com/intel/opencl-intercept-layer/pull/50","diff_url":"https://github.com/intel/opencl-intercept-layer/pull/50.diff","patch_url":"https://github.com/intel/opencl-intercept-layer/pull/50.patch","issue_url":"https://api.github.com/repos/intel/opencl-intercept-layer/issues/50","number":50,"state":"open","locked":false,"title":"Transfer changes from internal repo","user":{"login":"ppabis-intel","id":44462853,"node_id":"MDQ6VXNlcjQ0NDYyODUz","avatar_url":"https://avatars0.githubusercontent.com/u/44462853?v=4","gravatar_id":"","url":"https://api.github.com/users/ppabis-intel","html_url":"https://github.com/ppabis-intel","followers_url":"https://api.github.com/users/ppabis-intel/followers","following_url":"https://api.github.com/users/ppabis-intel/following{/other_user}","gists_url":"https://api.github.com/users/ppabis-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/ppabis-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppabis-intel/subscriptions","organizations_url":"https://api.github.com/users/ppabis-intel/orgs","repos_url":"https://api.github.com/users/ppabis-intel/repos","events_url":"https://api.github.com/users/ppabis-intel/events{/privacy}","received_events_url":"https://api.github.com/users/ppabis-intel/received_events","type":"User","site_admin":false},"body":"Added capability of reporting max values for each metric and their units, available since MD1.5.\r\n\r\n## Description of Changes\r\n\r\nIf max values are not needed to be collected, `std::vector maxValues` should be null.\r\nUnits printing is set using an extra `bool` parameter `printMax`.\r\n\r\n### Added two new controls:\r\n- *DevicePerfReportMax* - appends a possible max value next to each column of metrics\r\n- *DevicePerfAppendUnits* - add a row after metric names with units for each metric (empty for max)\r\n\r\n## Testing Done\r\n\r\nTested on Windows, results in CSV files look good, as well as DeviceTiming reports.\r\n","created_at":"2018-10-25T09:46:43Z","updated_at":"2018-10-30T15:25:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae7525efaf318c8f096fb94850826320c0a41cdf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/50/commits","review_comments_url":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/50/comments","review_comment_url":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intel/opencl-intercept-layer/issues/50/comments","statuses_url":"https://api.github.com/repos/intel/opencl-intercept-layer/statuses/955243dc2bb1989f67bb90a94cc3d78e4d7b5282","head":{"label":"ppabis-intel:mdapi_max_values","ref":"mdapi_max_values","sha":"955243dc2bb1989f67bb90a94cc3d78e4d7b5282","user":{"login":"ppabis-intel","id":44462853,"node_id":"MDQ6VXNlcjQ0NDYyODUz","avatar_url":"https://avatars0.githubusercontent.com/u/44462853?v=4","gravatar_id":"","url":"https://api.github.com/users/ppabis-intel","html_url":"https://github.com/ppabis-intel","followers_url":"https://api.github.com/users/ppabis-intel/followers","following_url":"https://api.github.com/users/ppabis-intel/following{/other_user}","gists_url":"https://api.github.com/users/ppabis-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/ppabis-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppabis-intel/subscriptions","organizations_url":"https://api.github.com/users/ppabis-intel/orgs","repos_url":"https://api.github.com/users/ppabis-intel/repos","events_url":"https://api.github.com/users/ppabis-intel/events{/privacy}","received_events_url":"https://api.github.com/users/ppabis-intel/received_events","type":"User","site_admin":false},"repo":{"id":154639570,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ2Mzk1NzA=","name":"opencl-intercept-layer","full_name":"ppabis-intel/opencl-intercept-layer","private":false,"owner":{"login":"ppabis-intel","id":44462853,"node_id":"MDQ6VXNlcjQ0NDYyODUz","avatar_url":"https://avatars0.githubusercontent.com/u/44462853?v=4","gravatar_id":"","url":"https://api.github.com/users/ppabis-intel","html_url":"https://github.com/ppabis-intel","followers_url":"https://api.github.com/users/ppabis-intel/followers","following_url":"https://api.github.com/users/ppabis-intel/following{/other_user}","gists_url":"https://api.github.com/users/ppabis-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/ppabis-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppabis-intel/subscriptions","organizations_url":"https://api.github.com/users/ppabis-intel/orgs","repos_url":"https://api.github.com/users/ppabis-intel/repos","events_url":"https://api.github.com/users/ppabis-intel/events{/privacy}","received_events_url":"https://api.github.com/users/ppabis-intel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ppabis-intel/opencl-intercept-layer","description":"Intercept Layer for Debugging and Analyzing OpenCL Applications","fork":true,"url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer","forks_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/forks","keys_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/teams","hooks_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/hooks","issue_events_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/issues/events{/number}","events_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/events","assignees_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/assignees{/user}","branches_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/branches{/branch}","tags_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/tags","blobs_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/statuses/{sha}","languages_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/languages","stargazers_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/stargazers","contributors_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/contributors","subscribers_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/subscribers","subscription_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/subscription","commits_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/contents/{+path}","compare_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/merges","archive_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/downloads","issues_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/issues{/number}","pulls_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/pulls{/number}","milestones_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/milestones{/number}","notifications_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/labels{/name}","releases_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/releases{/id}","deployments_url":"https://api.github.com/repos/ppabis-intel/opencl-intercept-layer/deployments","created_at":"2018-10-25T08:52:03Z","updated_at":"2018-10-25T08:52:06Z","pushed_at":"2018-10-25T09:39:55Z","git_url":"git://github.com/ppabis-intel/opencl-intercept-layer.git","ssh_url":"git@github.com:ppabis-intel/opencl-intercept-layer.git","clone_url":"https://github.com/ppabis-intel/opencl-intercept-layer.git","svn_url":"https://github.com/ppabis-intel/opencl-intercept-layer","homepage":"","size":1396,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intel:master","ref":"master","sha":"18dcd347e336626cab78339d2ca363bed3436375","user":{"login":"intel","id":17888862,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg4ODYy","avatar_url":"https://avatars3.githubusercontent.com/u/17888862?v=4","gravatar_id":"","url":"https://api.github.com/users/intel","html_url":"https://github.com/intel","followers_url":"https://api.github.com/users/intel/followers","following_url":"https://api.github.com/users/intel/following{/other_user}","gists_url":"https://api.github.com/users/intel/gists{/gist_id}","starred_url":"https://api.github.com/users/intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel/subscriptions","organizations_url":"https://api.github.com/users/intel/orgs","repos_url":"https://api.github.com/users/intel/repos","events_url":"https://api.github.com/users/intel/events{/privacy}","received_events_url":"https://api.github.com/users/intel/received_events","type":"Organization","site_admin":false},"repo":{"id":111613671,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2MTM2NzE=","name":"opencl-intercept-layer","full_name":"intel/opencl-intercept-layer","private":false,"owner":{"login":"intel","id":17888862,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg4ODYy","avatar_url":"https://avatars3.githubusercontent.com/u/17888862?v=4","gravatar_id":"","url":"https://api.github.com/users/intel","html_url":"https://github.com/intel","followers_url":"https://api.github.com/users/intel/followers","following_url":"https://api.github.com/users/intel/following{/other_user}","gists_url":"https://api.github.com/users/intel/gists{/gist_id}","starred_url":"https://api.github.com/users/intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel/subscriptions","organizations_url":"https://api.github.com/users/intel/orgs","repos_url":"https://api.github.com/users/intel/repos","events_url":"https://api.github.com/users/intel/events{/privacy}","received_events_url":"https://api.github.com/users/intel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/intel/opencl-intercept-layer","description":"Intercept Layer for Debugging and Analyzing OpenCL Applications","fork":false,"url":"https://api.github.com/repos/intel/opencl-intercept-layer","forks_url":"https://api.github.com/repos/intel/opencl-intercept-layer/forks","keys_url":"https://api.github.com/repos/intel/opencl-intercept-layer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel/opencl-intercept-layer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel/opencl-intercept-layer/teams","hooks_url":"https://api.github.com/repos/intel/opencl-intercept-layer/hooks","issue_events_url":"https://api.github.com/repos/intel/opencl-intercept-layer/issues/events{/number}","events_url":"https://api.github.com/repos/intel/opencl-intercept-layer/events","assignees_url":"https://api.github.com/repos/intel/opencl-intercept-layer/assignees{/user}","branches_url":"https://api.github.com/repos/intel/opencl-intercept-layer/branches{/branch}","tags_url":"https://api.github.com/repos/intel/opencl-intercept-layer/tags","blobs_url":"https://api.github.com/repos/intel/opencl-intercept-layer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel/opencl-intercept-layer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel/opencl-intercept-layer/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel/opencl-intercept-layer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel/opencl-intercept-layer/statuses/{sha}","languages_url":"https://api.github.com/repos/intel/opencl-intercept-layer/languages","stargazers_url":"https://api.github.com/repos/intel/opencl-intercept-layer/stargazers","contributors_url":"https://api.github.com/repos/intel/opencl-intercept-layer/contributors","subscribers_url":"https://api.github.com/repos/intel/opencl-intercept-layer/subscribers","subscription_url":"https://api.github.com/repos/intel/opencl-intercept-layer/subscription","commits_url":"https://api.github.com/repos/intel/opencl-intercept-layer/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel/opencl-intercept-layer/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel/opencl-intercept-layer/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel/opencl-intercept-layer/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel/opencl-intercept-layer/contents/{+path}","compare_url":"https://api.github.com/repos/intel/opencl-intercept-layer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel/opencl-intercept-layer/merges","archive_url":"https://api.github.com/repos/intel/opencl-intercept-layer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel/opencl-intercept-layer/downloads","issues_url":"https://api.github.com/repos/intel/opencl-intercept-layer/issues{/number}","pulls_url":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls{/number}","milestones_url":"https://api.github.com/repos/intel/opencl-intercept-layer/milestones{/number}","notifications_url":"https://api.github.com/repos/intel/opencl-intercept-layer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel/opencl-intercept-layer/labels{/name}","releases_url":"https://api.github.com/repos/intel/opencl-intercept-layer/releases{/id}","deployments_url":"https://api.github.com/repos/intel/opencl-intercept-layer/deployments","created_at":"2017-11-21T23:37:43Z","updated_at":"2018-10-30T14:24:54Z","pushed_at":"2018-10-30T14:24:52Z","git_url":"git://github.com/intel/opencl-intercept-layer.git","ssh_url":"git@github.com:intel/opencl-intercept-layer.git","clone_url":"https://github.com/intel/opencl-intercept-layer.git","svn_url":"https://github.com/intel/opencl-intercept-layer","homepage":"","size":1387,"stargazers_count":45,"watchers_count":45,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":5,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/50"},"html":{"href":"https://github.com/intel/opencl-intercept-layer/pull/50"},"issue":{"href":"https://api.github.com/repos/intel/opencl-intercept-layer/issues/50"},"comments":{"href":"https://api.github.com/repos/intel/opencl-intercept-layer/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intel/opencl-intercept-layer/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/intel/opencl-intercept-layer/statuses/955243dc2bb1989f67bb90a94cc3d78e4d7b5282"}},"author_association":"NONE"}}
{"actor":{"display_login":"bashbaug"}}