{"action":"created","issue":{"url":"https://api.github.com/repos/Neilpang/acme.sh/issues/1284","repository_url":"https://api.github.com/repos/Neilpang/acme.sh","labels_url":"https://api.github.com/repos/Neilpang/acme.sh/issues/1284/labels{/name}","comments_url":"https://api.github.com/repos/Neilpang/acme.sh/issues/1284/comments","events_url":"https://api.github.com/repos/Neilpang/acme.sh/issues/1284/events","html_url":"https://github.com/Neilpang/acme.sh/issues/1284","id":298022407,"number":1284,"title":"Patch for issue #1217 has a bug and is not complete ","user":{"login":"stevebovy","id":11862267,"avatar_url":"https://avatars0.githubusercontent.com/u/11862267?v=4","gravatar_id":"","url":"https://api.github.com/users/stevebovy","html_url":"https://github.com/stevebovy","followers_url":"https://api.github.com/users/stevebovy/followers","following_url":"https://api.github.com/users/stevebovy/following{/other_user}","gists_url":"https://api.github.com/users/stevebovy/gists{/gist_id}","starred_url":"https://api.github.com/users/stevebovy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevebovy/subscriptions","organizations_url":"https://api.github.com/users/stevebovy/orgs","repos_url":"https://api.github.com/users/stevebovy/repos","events_url":"https://api.github.com/users/stevebovy/events{/privacy}","received_events_url":"https://api.github.com/users/stevebovy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-17T17:45:37Z","updated_at":"2018-02-19T04:38:23Z","closed_at":null,"author_association":"NONE","body":"That patch is bad  ( see the $ )  \r\n\r\n\r\n  SOCAT_OPTIONS=TCP-LISTEN:$Le_HTTPPort,crlf,reuseaddr,fork\r\n\r\n  #Adding bind to local-address\r\n  if [ \"$ncaddr\" ]; then\r\n    >> $  <<  SOCAT_OPTIONS=\"$SOCAT_OPTIONS,bind=${ncaddr}\"\r\n  fi\r\n\r\n\r\nAlso the  net-stat function  _ss()  needs to be updated \r\n\r\n\r\nAdd $_local_address  to  netstat  check  !!!!\r\n\r\n_ss() {\r\n_port=\"$1\"\r\nif _exists \"ss\"; then\r\n_debug \"Using: ss\"\r\nss -ntpl 2>/dev/null | grep \"$_local_address:$_port \"\r\nreturn 0\r\nfi\r\nif _exists \"netstat\"; then\r\n_debug \"Using: netstat\"\r\nif netstat -h 2>&1 | grep \"-p proto\" >/dev/null; then\r\n#for windows version netstat tool\r\nnetstat -an -p tcp | grep \"LISTENING\" | grep \"$_local_address:$_port \"\r\nelse\r\nif netstat -help 2>&1 | grep \"-p protocol\" >/dev/null; then\r\nnetstat -an -p tcp | grep LISTEN | grep \"$_local_address:$_port \"\r\nelif netstat -help 2>&1 | grep -- '-P protocol' >/dev/null; then\r\n#for solaris\r\nnetstat -an -P tcp | grep \"$_local_address.$_port \" | grep \"LISTEN\"\r\nelif netstat -help 2>&1 | grep \"-p\" >/dev/null; then\r\n#for full linux\r\nnetstat -ntpl | grep \"$_local_address:$_port \"\r\nelse\r\n#for busybox (embedded linux; no pid support)\r\nnetstat -ntl 2>/dev/null | grep \"$_local_address:$_port \"\r\nfi\r\nfi\r\nreturn 0\r\nfi\r\n\r\n\r\n```\r\nacme.sh  --issue .....   --debug 2\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Neilpang/acme.sh/issues/comments/366587127","html_url":"https://github.com/Neilpang/acme.sh/issues/1284#issuecomment-366587127","issue_url":"https://api.github.com/repos/Neilpang/acme.sh/issues/1284","id":366587127,"user":{"login":"Neilpang","id":8305679,"avatar_url":"https://avatars2.githubusercontent.com/u/8305679?v=4","gravatar_id":"","url":"https://api.github.com/users/Neilpang","html_url":"https://github.com/Neilpang","followers_url":"https://api.github.com/users/Neilpang/followers","following_url":"https://api.github.com/users/Neilpang/following{/other_user}","gists_url":"https://api.github.com/users/Neilpang/gists{/gist_id}","starred_url":"https://api.github.com/users/Neilpang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neilpang/subscriptions","organizations_url":"https://api.github.com/users/Neilpang/orgs","repos_url":"https://api.github.com/users/Neilpang/repos","events_url":"https://api.github.com/users/Neilpang/events{/privacy}","received_events_url":"https://api.github.com/users/Neilpang/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T04:38:23Z","updated_at":"2018-02-19T04:38:23Z","author_association":"OWNER","body":"Is this still needed ?\r\n"}}
{"actor":{"display_login":"Neilpang"}}