{"action":"closed","number":153,"pull_request":{"url":"https://api.github.com/repos/Vauxoo/pylint-odoo/pulls/153","id":208609895,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjA5ODk1","html_url":"https://github.com/Vauxoo/pylint-odoo/pull/153","diff_url":"https://github.com/Vauxoo/pylint-odoo/pull/153.diff","patch_url":"https://github.com/Vauxoo/pylint-odoo/pull/153.patch","issue_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/issues/153","number":153,"state":"closed","locked":false,"title":"WIP: [FIX] manifest-version-format: Don't ignore valid Odoo versions","user":{"login":"luisg123v","id":19801181,"node_id":"MDQ6VXNlcjE5ODAxMTgx","avatar_url":"https://avatars1.githubusercontent.com/u/19801181?v=4","gravatar_id":"","url":"https://api.github.com/users/luisg123v","html_url":"https://github.com/luisg123v","followers_url":"https://api.github.com/users/luisg123v/followers","following_url":"https://api.github.com/users/luisg123v/following{/other_user}","gists_url":"https://api.github.com/users/luisg123v/gists{/gist_id}","starred_url":"https://api.github.com/users/luisg123v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisg123v/subscriptions","organizations_url":"https://api.github.com/users/luisg123v/orgs","repos_url":"https://api.github.com/users/luisg123v/repos","events_url":"https://api.github.com/users/luisg123v/events{/privacy}","received_events_url":"https://api.github.com/users/luisg123v/received_events","type":"User","site_admin":false},"body":"Currently, the parameter --valid_odoo_versions is being ignored when\r\nchecking a module's version in its manifest. So, for example, if the\r\nonly valid version is 11.0, and any module has in its manifest\r\n10.0.1.0.0, this lint would result in a false positive.\r\n\r\nThis commit ensures the above parameter is taken into account when\r\nchecking module versions set in the manifest.\r\n\r\nA new test case is provided for this behavior\r\n\r\nCloses #150","created_at":"2018-08-15T16:16:13Z","updated_at":"2018-08-20T22:33:34Z","closed_at":"2018-08-20T22:33:34Z","merged_at":null,"merge_commit_sha":"1d57ba85bcbe79802aaf4bfe3c2a9e37aa9d49d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/pulls/153/commits","review_comments_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/pulls/153/comments","review_comment_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/issues/153/comments","statuses_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/statuses/42584ed3f5291eede6c19c3fa04c44063f5bc798","head":{"label":"vauxoo-dev:master-dont_ignore_odoo_version-luisg","ref":"master-dont_ignore_odoo_version-luisg","sha":"42584ed3f5291eede6c19c3fa04c44063f5bc798","user":{"login":"vauxoo-dev","id":7662790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NjI3OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7662790?v=4","gravatar_id":"","url":"https://api.github.com/users/vauxoo-dev","html_url":"https://github.com/vauxoo-dev","followers_url":"https://api.github.com/users/vauxoo-dev/followers","following_url":"https://api.github.com/users/vauxoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/vauxoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/vauxoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vauxoo-dev/subscriptions","organizations_url":"https://api.github.com/users/vauxoo-dev/orgs","repos_url":"https://api.github.com/users/vauxoo-dev/repos","events_url":"https://api.github.com/users/vauxoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/vauxoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":44041810,"node_id":"MDEwOlJlcG9zaXRvcnk0NDA0MTgxMA==","name":"pylint-odoo","full_name":"vauxoo-dev/pylint-odoo","owner":{"login":"vauxoo-dev","id":7662790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NjI3OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7662790?v=4","gravatar_id":"","url":"https://api.github.com/users/vauxoo-dev","html_url":"https://github.com/vauxoo-dev","followers_url":"https://api.github.com/users/vauxoo-dev/followers","following_url":"https://api.github.com/users/vauxoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/vauxoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/vauxoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vauxoo-dev/subscriptions","organizations_url":"https://api.github.com/users/vauxoo-dev/orgs","repos_url":"https://api.github.com/users/vauxoo-dev/repos","events_url":"https://api.github.com/users/vauxoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/vauxoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vauxoo-dev/pylint-odoo","description":null,"fork":true,"url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo","forks_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/forks","keys_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/teams","hooks_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/hooks","issue_events_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/issues/events{/number}","events_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/events","assignees_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/assignees{/user}","branches_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/branches{/branch}","tags_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/tags","blobs_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/languages","stargazers_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/stargazers","contributors_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/contributors","subscribers_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/subscribers","subscription_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/subscription","commits_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/contents/{+path}","compare_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/merges","archive_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/downloads","issues_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/issues{/number}","pulls_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/labels{/name}","releases_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/releases{/id}","deployments_url":"https://api.github.com/repos/vauxoo-dev/pylint-odoo/deployments","created_at":"2015-10-11T06:30:59Z","updated_at":"2017-01-30T18:02:55Z","pushed_at":"2018-08-20T22:13:21Z","git_url":"git://github.com/vauxoo-dev/pylint-odoo.git","ssh_url":"git@github.com:vauxoo-dev/pylint-odoo.git","clone_url":"https://github.com/vauxoo-dev/pylint-odoo.git","svn_url":"https://github.com/vauxoo-dev/pylint-odoo","homepage":null,"size":743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Vauxoo:master","ref":"master","sha":"7e7c26f5aeceb5bf78f810d834f2f7db79ecff14","user":{"login":"Vauxoo","id":5997834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc4MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5997834?v=4","gravatar_id":"","url":"https://api.github.com/users/Vauxoo","html_url":"https://github.com/Vauxoo","followers_url":"https://api.github.com/users/Vauxoo/followers","following_url":"https://api.github.com/users/Vauxoo/following{/other_user}","gists_url":"https://api.github.com/users/Vauxoo/gists{/gist_id}","starred_url":"https://api.github.com/users/Vauxoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vauxoo/subscriptions","organizations_url":"https://api.github.com/users/Vauxoo/orgs","repos_url":"https://api.github.com/users/Vauxoo/repos","events_url":"https://api.github.com/users/Vauxoo/events{/privacy}","received_events_url":"https://api.github.com/users/Vauxoo/received_events","type":"Organization","site_admin":false},"repo":{"id":44041808,"node_id":"MDEwOlJlcG9zaXRvcnk0NDA0MTgwOA==","name":"pylint-odoo","full_name":"Vauxoo/pylint-odoo","owner":{"login":"Vauxoo","id":5997834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc4MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5997834?v=4","gravatar_id":"","url":"https://api.github.com/users/Vauxoo","html_url":"https://github.com/Vauxoo","followers_url":"https://api.github.com/users/Vauxoo/followers","following_url":"https://api.github.com/users/Vauxoo/following{/other_user}","gists_url":"https://api.github.com/users/Vauxoo/gists{/gist_id}","starred_url":"https://api.github.com/users/Vauxoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vauxoo/subscriptions","organizations_url":"https://api.github.com/users/Vauxoo/orgs","repos_url":"https://api.github.com/users/Vauxoo/repos","events_url":"https://api.github.com/users/Vauxoo/events{/privacy}","received_events_url":"https://api.github.com/users/Vauxoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vauxoo/pylint-odoo","description":null,"fork":true,"url":"https://api.github.com/repos/Vauxoo/pylint-odoo","forks_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/forks","keys_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/teams","hooks_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/hooks","issue_events_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/issues/events{/number}","events_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/events","assignees_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/assignees{/user}","branches_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/branches{/branch}","tags_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/tags","blobs_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/languages","stargazers_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/stargazers","contributors_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/contributors","subscribers_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/subscribers","subscription_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/subscription","commits_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/contents/{+path}","compare_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/merges","archive_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/downloads","issues_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/issues{/number}","pulls_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/labels{/name}","releases_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/releases{/id}","deployments_url":"https://api.github.com/repos/Vauxoo/pylint-odoo/deployments","created_at":"2015-10-11T06:30:53Z","updated_at":"2018-05-23T04:08:16Z","pushed_at":"2018-08-20T22:13:22Z","git_url":"git://github.com/Vauxoo/pylint-odoo.git","ssh_url":"git@github.com:Vauxoo/pylint-odoo.git","clone_url":"https://github.com/Vauxoo/pylint-odoo.git","svn_url":"https://github.com/Vauxoo/pylint-odoo","homepage":null,"size":571,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":4,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vauxoo/pylint-odoo/pulls/153"},"html":{"href":"https://github.com/Vauxoo/pylint-odoo/pull/153"},"issue":{"href":"https://api.github.com/repos/Vauxoo/pylint-odoo/issues/153"},"comments":{"href":"https://api.github.com/repos/Vauxoo/pylint-odoo/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/Vauxoo/pylint-odoo/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/Vauxoo/pylint-odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vauxoo/pylint-odoo/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/Vauxoo/pylint-odoo/statuses/42584ed3f5291eede6c19c3fa04c44063f5bc798"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"luisg123v"}}