{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/comments/226088922","pull_request_review_id":165829397,"id":226088922,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjA4ODkyMg==","diff_hunk":"@@ -83,7 +82,9 @@ func NewManager(config ManagerConfiguration, options ...httpsupport.HTTPClientOp\n \t}\n \ttm.config = config\n \n-\tkeysEndpoint := fmt.Sprintf(\"%s%s\", config.GetAuthServiceURL(), config.GetAuthKeysPath())\n+\tauthURL := httpsupport.AddTrailingSlashToURL(config.GetAuthServiceURL())\n+\t// TODO when we have a separate repo for Auth client we should use it to get the key path instead of hardcoding \"api/token/keys\"\n+\tkeysEndpoint := fmt.Sprintf(\"%s%s\", authURL, \"api/token/keys\")","path":"token/token.go","position":27,"original_position":27,"commit_id":"23b182d852993404f1030fef2ad3ea0ae94c60da","original_commit_id":"23b182d852993404f1030fef2ad3ea0ae94c60da","user":{"login":"alexeykazakov","id":620087,"node_id":"MDQ6VXNlcjYyMDA4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/620087?v=4","gravatar_id":"","url":"https://api.github.com/users/alexeykazakov","html_url":"https://github.com/alexeykazakov","followers_url":"https://api.github.com/users/alexeykazakov/followers","following_url":"https://api.github.com/users/alexeykazakov/following{/other_user}","gists_url":"https://api.github.com/users/alexeykazakov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeykazakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeykazakov/subscriptions","organizations_url":"https://api.github.com/users/alexeykazakov/orgs","repos_url":"https://api.github.com/users/alexeykazakov/repos","events_url":"https://api.github.com/users/alexeykazakov/events{/privacy}","received_events_url":"https://api.github.com/users/alexeykazakov/received_events","type":"User","site_admin":false},"body":"It should be `api/token/keys`. We are adding trailing slash to auth url (see line 85) if it doesn't already have. So, the authURL will have `/` in the end.","created_at":"2018-10-17T20:48:29Z","updated_at":"2018-10-17T20:48:29Z","html_url":"https://github.com/fabric8-services/fabric8-common/pull/25#discussion_r226088922","pull_request_url":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/25","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/comments/226088922"},"html":{"href":"https://github.com/fabric8-services/fabric8-common/pull/25#discussion_r226088922"},"pull_request":{"href":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/25"}},"in_reply_to_id":225850326},"pull_request":{"url":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/25","id":223443103,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDQzMTAz","html_url":"https://github.com/fabric8-services/fabric8-common/pull/25","diff_url":"https://github.com/fabric8-services/fabric8-common/pull/25.diff","patch_url":"https://github.com/fabric8-services/fabric8-common/pull/25.patch","issue_url":"https://api.github.com/repos/fabric8-services/fabric8-common/issues/25","number":25,"state":"open","locked":false,"title":"Use /api/token/keys path to fetch public keys","user":{"login":"alexeykazakov","id":620087,"node_id":"MDQ6VXNlcjYyMDA4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/620087?v=4","gravatar_id":"","url":"https://api.github.com/users/alexeykazakov","html_url":"https://github.com/alexeykazakov","followers_url":"https://api.github.com/users/alexeykazakov/followers","following_url":"https://api.github.com/users/alexeykazakov/following{/other_user}","gists_url":"https://api.github.com/users/alexeykazakov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeykazakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeykazakov/subscriptions","organizations_url":"https://api.github.com/users/alexeykazakov/orgs","repos_url":"https://api.github.com/users/alexeykazakov/repos","events_url":"https://api.github.com/users/alexeykazakov/events{/privacy}","received_events_url":"https://api.github.com/users/alexeykazakov/received_events","type":"User","site_admin":false},"body":"We don't really need to pass `/api/token/keys` as configuration param when loading public keys. It's the same path for all services.\r\n\r\nLet's hardcode it in token manager constructor until we extract auth client to a separate repository. Then we could use auth client to get the path.","created_at":"2018-10-17T01:31:48Z","updated_at":"2018-10-17T20:48:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb659da8aff4d861a75c4c84b1a63bd1de9a385d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/25/commits","review_comments_url":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/25/comments","review_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-common/issues/25/comments","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-common/statuses/23b182d852993404f1030fef2ad3ea0ae94c60da","head":{"label":"alexeykazakov:authpath","ref":"authpath","sha":"23b182d852993404f1030fef2ad3ea0ae94c60da","user":{"login":"alexeykazakov","id":620087,"node_id":"MDQ6VXNlcjYyMDA4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/620087?v=4","gravatar_id":"","url":"https://api.github.com/users/alexeykazakov","html_url":"https://github.com/alexeykazakov","followers_url":"https://api.github.com/users/alexeykazakov/followers","following_url":"https://api.github.com/users/alexeykazakov/following{/other_user}","gists_url":"https://api.github.com/users/alexeykazakov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeykazakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeykazakov/subscriptions","organizations_url":"https://api.github.com/users/alexeykazakov/orgs","repos_url":"https://api.github.com/users/alexeykazakov/repos","events_url":"https://api.github.com/users/alexeykazakov/events{/privacy}","received_events_url":"https://api.github.com/users/alexeykazakov/received_events","type":"User","site_admin":false},"repo":{"id":149202444,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkyMDI0NDQ=","name":"fabric8-common","full_name":"alexeykazakov/fabric8-common","private":false,"owner":{"login":"alexeykazakov","id":620087,"node_id":"MDQ6VXNlcjYyMDA4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/620087?v=4","gravatar_id":"","url":"https://api.github.com/users/alexeykazakov","html_url":"https://github.com/alexeykazakov","followers_url":"https://api.github.com/users/alexeykazakov/followers","following_url":"https://api.github.com/users/alexeykazakov/following{/other_user}","gists_url":"https://api.github.com/users/alexeykazakov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeykazakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeykazakov/subscriptions","organizations_url":"https://api.github.com/users/alexeykazakov/orgs","repos_url":"https://api.github.com/users/alexeykazakov/repos","events_url":"https://api.github.com/users/alexeykazakov/events{/privacy}","received_events_url":"https://api.github.com/users/alexeykazakov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexeykazakov/fabric8-common","description":"A repository for the common go packages of the Fabric8 services","fork":true,"url":"https://api.github.com/repos/alexeykazakov/fabric8-common","forks_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/forks","keys_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/teams","hooks_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/hooks","issue_events_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/issues/events{/number}","events_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/events","assignees_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/assignees{/user}","branches_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/branches{/branch}","tags_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/tags","blobs_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/statuses/{sha}","languages_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/languages","stargazers_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/stargazers","contributors_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/contributors","subscribers_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/subscribers","subscription_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/subscription","commits_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/contents/{+path}","compare_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/merges","archive_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/downloads","issues_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/issues{/number}","pulls_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/pulls{/number}","milestones_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/milestones{/number}","notifications_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/labels{/name}","releases_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/releases{/id}","deployments_url":"https://api.github.com/repos/alexeykazakov/fabric8-common/deployments","created_at":"2018-09-17T23:49:51Z","updated_at":"2018-09-17T23:49:53Z","pushed_at":"2018-10-17T01:28:16Z","git_url":"git://github.com/alexeykazakov/fabric8-common.git","ssh_url":"git@github.com:alexeykazakov/fabric8-common.git","clone_url":"https://github.com/alexeykazakov/fabric8-common.git","svn_url":"https://github.com/alexeykazakov/fabric8-common","homepage":"","size":239,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-services:master","ref":"master","sha":"441f5274bd64fdbf3d1d0eebd40dbb61f630807d","user":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"repo":{"id":139610958,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2MTA5NTg=","name":"fabric8-common","full_name":"fabric8-services/fabric8-common","private":false,"owner":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fabric8-services/fabric8-common","description":"A repository for the common go packages of the Fabric8 services","fork":false,"url":"https://api.github.com/repos/fabric8-services/fabric8-common","forks_url":"https://api.github.com/repos/fabric8-services/fabric8-common/forks","keys_url":"https://api.github.com/repos/fabric8-services/fabric8-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-services/fabric8-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-services/fabric8-common/teams","hooks_url":"https://api.github.com/repos/fabric8-services/fabric8-common/hooks","issue_events_url":"https://api.github.com/repos/fabric8-services/fabric8-common/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-services/fabric8-common/events","assignees_url":"https://api.github.com/repos/fabric8-services/fabric8-common/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-services/fabric8-common/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-services/fabric8-common/tags","blobs_url":"https://api.github.com/repos/fabric8-services/fabric8-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-services/fabric8-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-services/fabric8-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-services/fabric8-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-common/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-services/fabric8-common/languages","stargazers_url":"https://api.github.com/repos/fabric8-services/fabric8-common/stargazers","contributors_url":"https://api.github.com/repos/fabric8-services/fabric8-common/contributors","subscribers_url":"https://api.github.com/repos/fabric8-services/fabric8-common/subscribers","subscription_url":"https://api.github.com/repos/fabric8-services/fabric8-common/subscription","commits_url":"https://api.github.com/repos/fabric8-services/fabric8-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-services/fabric8-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-services/fabric8-common/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-services/fabric8-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-services/fabric8-common/merges","archive_url":"https://api.github.com/repos/fabric8-services/fabric8-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-services/fabric8-common/downloads","issues_url":"https://api.github.com/repos/fabric8-services/fabric8-common/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-services/fabric8-common/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-services/fabric8-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-services/fabric8-common/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-services/fabric8-common/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-services/fabric8-common/deployments","created_at":"2018-07-03T16:36:03Z","updated_at":"2018-10-16T15:03:27Z","pushed_at":"2018-10-17T05:28:48Z","git_url":"git://github.com/fabric8-services/fabric8-common.git","ssh_url":"git@github.com:fabric8-services/fabric8-common.git","clone_url":"https://github.com/fabric8-services/fabric8-common.git","svn_url":"https://github.com/fabric8-services/fabric8-common","homepage":"","size":232,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":7,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/25"},"html":{"href":"https://github.com/fabric8-services/fabric8-common/pull/25"},"issue":{"href":"https://api.github.com/repos/fabric8-services/fabric8-common/issues/25"},"comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-common/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-services/fabric8-common/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-services/fabric8-common/statuses/23b182d852993404f1030fef2ad3ea0ae94c60da"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alexeykazakov"}}