{"action":"created","comment":{"url":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/comments/221849257","pull_request_review_id":160595359,"id":221849257,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTg0OTI1Nw==","diff_hunk":"@@ -6,15 +6,5 @@\n \n interface HttpClientInterface\n {\n-    public function createUri($uri);\n-\n-    public function createRequest(\n-        $method,\n-        $uri,\n-        array $headers = array(),\n-        $body = null,\n-        $protocolVersion = '1.1'\n-    );\n-\n     public function sendRequest(RequestInterface $request, $timeout, $connectTimeout);","path":"src/Http/HttpClientInterface.php","position":14,"original_position":14,"commit_id":"e106728b981d20dafc3bfffc9d2cf7b9a3e67e55","original_commit_id":"e106728b981d20dafc3bfffc9d2cf7b9a3e67e55","user":{"login":"nunomaduro","id":5457236,"node_id":"MDQ6VXNlcjU0NTcyMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5457236?v=4","gravatar_id":"","url":"https://api.github.com/users/nunomaduro","html_url":"https://github.com/nunomaduro","followers_url":"https://api.github.com/users/nunomaduro/followers","following_url":"https://api.github.com/users/nunomaduro/following{/other_user}","gists_url":"https://api.github.com/users/nunomaduro/gists{/gist_id}","starred_url":"https://api.github.com/users/nunomaduro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunomaduro/subscriptions","organizations_url":"https://api.github.com/users/nunomaduro/orgs","repos_url":"https://api.github.com/users/nunomaduro/repos","events_url":"https://api.github.com/users/nunomaduro/events{/privacy}","received_events_url":"https://api.github.com/users/nunomaduro/received_events","type":"User","site_admin":false},"body":"Be sure (or in another pr) you document via `phpdocs` the exceptions that may be throw on this interface.","created_at":"2018-10-02T07:37:22Z","updated_at":"2018-10-02T07:38:41Z","html_url":"https://github.com/algolia/algoliasearch-client-php/pull/457#discussion_r221849257","pull_request_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/457","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/comments/221849257"},"html":{"href":"https://github.com/algolia/algoliasearch-client-php/pull/457#discussion_r221849257"},"pull_request":{"href":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/457","id":219434732,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDM0NzMy","html_url":"https://github.com/algolia/algoliasearch-client-php/pull/457","diff_url":"https://github.com/algolia/algoliasearch-client-php/pull/457.diff","patch_url":"https://github.com/algolia/algoliasearch-client-php/pull/457.patch","issue_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/issues/457","number":457,"state":"open","locked":false,"title":"HttpClientInterface only requires sendRequest method!","user":{"login":"julienbourdeau","id":1525636,"node_id":"MDQ6VXNlcjE1MjU2MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1525636?v=4","gravatar_id":"","url":"https://api.github.com/users/julienbourdeau","html_url":"https://github.com/julienbourdeau","followers_url":"https://api.github.com/users/julienbourdeau/followers","following_url":"https://api.github.com/users/julienbourdeau/following{/other_user}","gists_url":"https://api.github.com/users/julienbourdeau/gists{/gist_id}","starred_url":"https://api.github.com/users/julienbourdeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienbourdeau/subscriptions","organizations_url":"https://api.github.com/users/julienbourdeau/orgs","repos_url":"https://api.github.com/users/julienbourdeau/repos","events_url":"https://api.github.com/users/julienbourdeau/events{/privacy}","received_events_url":"https://api.github.com/users/julienbourdeau/received_events","type":"User","site_admin":false},"body":"| Q                 | A\r\n| ----------------- | ----------\r\n| Bug fix?          | no\r\n| New feature?      | no    <!-- please update the /CHANGELOG.md file -->\r\n| BC breaks?        | YES - httpClient Interface changed     \r\n| Related Issue     | Fix #...  <!-- will close issue automatically, if any -->\r\n| Need Doc update   | yes/no\r\n\r\n\r\n## Describe your change\r\n\r\nWhen I wrote the `HttpClientInterface`, I added 3 methods, but createUri and createRequest never belonged there, I just got confused because they were provided by guzzle and that I had to maintain a different implementation for PHP 5.3\r\n\r\nIn the end createUri and createRequest have become as private methods of `ApiWrapper` 🎉 \r\n\r\n\r\n### REMEMBER TO CHANGE BASE BRANCH BEFORE MERGING THIS PR\r\n","created_at":"2018-10-01T16:18:01Z","updated_at":"2018-10-02T07:38:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa34daa5e7d1a9d18193f9aa61a4e7880cf76336","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/457/commits","review_comments_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/457/comments","review_comment_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/issues/457/comments","statuses_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/statuses/e106728b981d20dafc3bfffc9d2cf7b9a3e67e55","head":{"label":"algolia:refacto/httpClientInterface","ref":"refacto/httpClientInterface","sha":"e106728b981d20dafc3bfffc9d2cf7b9a3e67e55","user":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":10172371,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE3MjM3MQ==","name":"algoliasearch-client-php","full_name":"algolia/algoliasearch-client-php","private":false,"owner":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/algolia/algoliasearch-client-php","description":"Algolia Search API Client for PHP","fork":false,"url":"https://api.github.com/repos/algolia/algoliasearch-client-php","forks_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/forks","keys_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/teams","hooks_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/hooks","issue_events_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/events","assignees_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/tags","blobs_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/languages","stargazers_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/stargazers","contributors_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/contributors","subscribers_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/subscribers","subscription_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/subscription","commits_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/merges","archive_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/downloads","issues_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/labels{/name}","releases_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/releases{/id}","deployments_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/deployments","created_at":"2013-05-20T12:37:37Z","updated_at":"2018-10-01T12:35:06Z","pushed_at":"2018-10-01T16:18:02Z","git_url":"git://github.com/algolia/algoliasearch-client-php.git","ssh_url":"git@github.com:algolia/algoliasearch-client-php.git","clone_url":"https://github.com/algolia/algoliasearch-client-php.git","svn_url":"https://github.com/algolia/algoliasearch-client-php","homepage":"https://www.algolia.com/doc/api-client/php/getting-started/","size":2039,"stargazers_count":320,"watchers_count":320,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":82,"open_issues":16,"watchers":320,"default_branch":"master"}},"base":{"label":"algolia:refactor/config-AGAIN","ref":"refactor/config-AGAIN","sha":"80640f80e3e4f7df633eac50d5dbc4ce4846bd75","user":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":10172371,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE3MjM3MQ==","name":"algoliasearch-client-php","full_name":"algolia/algoliasearch-client-php","private":false,"owner":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/algolia/algoliasearch-client-php","description":"Algolia Search API Client for PHP","fork":false,"url":"https://api.github.com/repos/algolia/algoliasearch-client-php","forks_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/forks","keys_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/teams","hooks_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/hooks","issue_events_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/events","assignees_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/tags","blobs_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/languages","stargazers_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/stargazers","contributors_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/contributors","subscribers_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/subscribers","subscription_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/subscription","commits_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/merges","archive_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/downloads","issues_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/labels{/name}","releases_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/releases{/id}","deployments_url":"https://api.github.com/repos/algolia/algoliasearch-client-php/deployments","created_at":"2013-05-20T12:37:37Z","updated_at":"2018-10-01T12:35:06Z","pushed_at":"2018-10-01T16:18:02Z","git_url":"git://github.com/algolia/algoliasearch-client-php.git","ssh_url":"git@github.com:algolia/algoliasearch-client-php.git","clone_url":"https://github.com/algolia/algoliasearch-client-php.git","svn_url":"https://github.com/algolia/algoliasearch-client-php","homepage":"https://www.algolia.com/doc/api-client/php/getting-started/","size":2039,"stargazers_count":320,"watchers_count":320,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":82,"open_issues":16,"watchers":320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/457"},"html":{"href":"https://github.com/algolia/algoliasearch-client-php/pull/457"},"issue":{"href":"https://api.github.com/repos/algolia/algoliasearch-client-php/issues/457"},"comments":{"href":"https://api.github.com/repos/algolia/algoliasearch-client-php/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/algolia/algoliasearch-client-php/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/algolia/algoliasearch-client-php/statuses/e106728b981d20dafc3bfffc9d2cf7b9a3e67e55"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nunomaduro"}}