{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/pulls/11","id":189823252,"html_url":"https://github.com/ItsGameNight/kdm-archivist/pull/11","diff_url":"https://github.com/ItsGameNight/kdm-archivist/pull/11.diff","patch_url":"https://github.com/ItsGameNight/kdm-archivist/pull/11.patch","issue_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/issues/11","number":11,"state":"closed","locked":false,"title":"Survivor Table Improvements","user":{"login":"mws96","id":6209744,"avatar_url":"https://avatars2.githubusercontent.com/u/6209744?v=4","gravatar_id":"","url":"https://api.github.com/users/mws96","html_url":"https://github.com/mws96","followers_url":"https://api.github.com/users/mws96/followers","following_url":"https://api.github.com/users/mws96/following{/other_user}","gists_url":"https://api.github.com/users/mws96/gists{/gist_id}","starred_url":"https://api.github.com/users/mws96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mws96/subscriptions","organizations_url":"https://api.github.com/users/mws96/orgs","repos_url":"https://api.github.com/users/mws96/repos","events_url":"https://api.github.com/users/mws96/events{/privacy}","received_events_url":"https://api.github.com/users/mws96/received_events","type":"User","site_admin":false},"body":"Lots of little tweaks/additions!\r\n\r\n### Cleaned up buttons at top of table\r\n- Styled them to be consistent with rest of app\r\n- Removed Drop All Survivor button\r\n- Added a filter drop down to filter by alive/dead/all\r\n- Added a button to reset departing survivors\r\n\r\n### Add survivor now opens modal for new survivor\r\nThis was the trickiest bit in this PR, mostly because 1) I had to update the Vuex addNewSurvivor action to return a promise with the new survivor ID passed through and 2) for some reason just passing the new survivor directly to a survivor modal in SurvivorTable wasn't working--changes made in the modal would affect the data store but the modal wouldn't update to reflect changes--so a a work around I just find the SurvivorTableRow for the new survivor and tell it to display the modal, which works\r\n\r\n### Departing survivors\r\n- Can now be marked/unmarked from SurvivorTable by clicking on the home/check mark button at bottom left of each SurvivorTableRow\r\n- Departing survivors show up at the top of the table\r\n- Cannot mark more than four survivors as departing at a time\r\n- Updated departing toggle in SurvivorModal to reflect new icons\r\n\r\n### Animations/transitions\r\n- Fixed bug that was causing SurvivorModal to not animate on appear\r\n- Added transitions to SurvivorTable to make it less jarring when updating a survivor and it moves suddenly due to changes\r\n- A few other little transitions in there for polish\r\n\r\n### Long press survivor table row to open modal\r\n- This one was @akarle 's idea, turned out really nice\r\n\r\n### Family information in SurvivorModal\r\n- Now can set parents\r\n- For now, parents are just stored as strings (name of parent)\r\n- Children list auto populates by filtering survivors in settlement who have mother/father set to the name of the survivor\r\n- This of course is error prone in two ways: 1) misspelling parent's name breaks it (but autocomplete should help here) and 2) if there are more than one survivor with the same name, there is a potential for incorrect behavior. This needs to be looked at in the future but for now I'm happy with it, as it's not game critical\r\n\r\n### Good code hygiene\r\n- Moved computed functions used to determine color styling/icon for yee scores into a mixin that is imported by both SurvivorTableRow and SurvivorModal","created_at":"2018-05-22T23:57:28Z","updated_at":"2018-05-23T01:56:13Z","closed_at":"2018-05-23T01:56:13Z","merged_at":"2018-05-23T01:56:13Z","merge_commit_sha":"ffaa74ba3e02b583d0e0bf1951914a3054d525fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/pulls/11/commits","review_comments_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/pulls/11/comments","review_comment_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/issues/11/comments","statuses_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/statuses/ffaa74ba3e02b583d0e0bf1951914a3054d525fc","head":{"label":"ItsGameNight:surv-table","ref":"surv-table","sha":"ffaa74ba3e02b583d0e0bf1951914a3054d525fc","user":{"login":"ItsGameNight","id":38361288,"avatar_url":"https://avatars3.githubusercontent.com/u/38361288?v=4","gravatar_id":"","url":"https://api.github.com/users/ItsGameNight","html_url":"https://github.com/ItsGameNight","followers_url":"https://api.github.com/users/ItsGameNight/followers","following_url":"https://api.github.com/users/ItsGameNight/following{/other_user}","gists_url":"https://api.github.com/users/ItsGameNight/gists{/gist_id}","starred_url":"https://api.github.com/users/ItsGameNight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ItsGameNight/subscriptions","organizations_url":"https://api.github.com/users/ItsGameNight/orgs","repos_url":"https://api.github.com/users/ItsGameNight/repos","events_url":"https://api.github.com/users/ItsGameNight/events{/privacy}","received_events_url":"https://api.github.com/users/ItsGameNight/received_events","type":"Organization","site_admin":false},"repo":{"id":129439430,"name":"kdm-archivist","full_name":"ItsGameNight/kdm-archivist","owner":{"login":"ItsGameNight","id":38361288,"avatar_url":"https://avatars3.githubusercontent.com/u/38361288?v=4","gravatar_id":"","url":"https://api.github.com/users/ItsGameNight","html_url":"https://github.com/ItsGameNight","followers_url":"https://api.github.com/users/ItsGameNight/followers","following_url":"https://api.github.com/users/ItsGameNight/following{/other_user}","gists_url":"https://api.github.com/users/ItsGameNight/gists{/gist_id}","starred_url":"https://api.github.com/users/ItsGameNight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ItsGameNight/subscriptions","organizations_url":"https://api.github.com/users/ItsGameNight/orgs","repos_url":"https://api.github.com/users/ItsGameNight/repos","events_url":"https://api.github.com/users/ItsGameNight/events{/privacy}","received_events_url":"https://api.github.com/users/ItsGameNight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ItsGameNight/kdm-archivist","description":"A Companion App for Kingdom Death: Monster","fork":false,"url":"https://api.github.com/repos/ItsGameNight/kdm-archivist","forks_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/forks","keys_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/teams","hooks_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/hooks","issue_events_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/issues/events{/number}","events_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/events","assignees_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/assignees{/user}","branches_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/branches{/branch}","tags_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/tags","blobs_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/git/refs{/sha}","trees_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/statuses/{sha}","languages_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/languages","stargazers_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/stargazers","contributors_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/contributors","subscribers_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/subscribers","subscription_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/subscription","commits_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/commits{/sha}","git_commits_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/git/commits{/sha}","comments_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/comments{/number}","issue_comment_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/issues/comments{/number}","contents_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/contents/{+path}","compare_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/merges","archive_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/downloads","issues_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/issues{/number}","pulls_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/pulls{/number}","milestones_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/milestones{/number}","notifications_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/labels{/name}","releases_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/releases{/id}","deployments_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/deployments","created_at":"2018-04-13T18:26:22Z","updated_at":"2018-05-22T17:48:29Z","pushed_at":"2018-05-23T01:56:13Z","git_url":"git://github.com/ItsGameNight/kdm-archivist.git","ssh_url":"git@github.com:ItsGameNight/kdm-archivist.git","clone_url":"https://github.com/ItsGameNight/kdm-archivist.git","svn_url":"https://github.com/ItsGameNight/kdm-archivist","homepage":null,"size":2655,"stargazers_count":1,"watchers_count":1,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ItsGameNight:master","ref":"master","sha":"88984ee50f9f34c9f51d257a424653f3214168cd","user":{"login":"ItsGameNight","id":38361288,"avatar_url":"https://avatars3.githubusercontent.com/u/38361288?v=4","gravatar_id":"","url":"https://api.github.com/users/ItsGameNight","html_url":"https://github.com/ItsGameNight","followers_url":"https://api.github.com/users/ItsGameNight/followers","following_url":"https://api.github.com/users/ItsGameNight/following{/other_user}","gists_url":"https://api.github.com/users/ItsGameNight/gists{/gist_id}","starred_url":"https://api.github.com/users/ItsGameNight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ItsGameNight/subscriptions","organizations_url":"https://api.github.com/users/ItsGameNight/orgs","repos_url":"https://api.github.com/users/ItsGameNight/repos","events_url":"https://api.github.com/users/ItsGameNight/events{/privacy}","received_events_url":"https://api.github.com/users/ItsGameNight/received_events","type":"Organization","site_admin":false},"repo":{"id":129439430,"name":"kdm-archivist","full_name":"ItsGameNight/kdm-archivist","owner":{"login":"ItsGameNight","id":38361288,"avatar_url":"https://avatars3.githubusercontent.com/u/38361288?v=4","gravatar_id":"","url":"https://api.github.com/users/ItsGameNight","html_url":"https://github.com/ItsGameNight","followers_url":"https://api.github.com/users/ItsGameNight/followers","following_url":"https://api.github.com/users/ItsGameNight/following{/other_user}","gists_url":"https://api.github.com/users/ItsGameNight/gists{/gist_id}","starred_url":"https://api.github.com/users/ItsGameNight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ItsGameNight/subscriptions","organizations_url":"https://api.github.com/users/ItsGameNight/orgs","repos_url":"https://api.github.com/users/ItsGameNight/repos","events_url":"https://api.github.com/users/ItsGameNight/events{/privacy}","received_events_url":"https://api.github.com/users/ItsGameNight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ItsGameNight/kdm-archivist","description":"A Companion App for Kingdom Death: Monster","fork":false,"url":"https://api.github.com/repos/ItsGameNight/kdm-archivist","forks_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/forks","keys_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/teams","hooks_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/hooks","issue_events_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/issues/events{/number}","events_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/events","assignees_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/assignees{/user}","branches_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/branches{/branch}","tags_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/tags","blobs_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/git/refs{/sha}","trees_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/statuses/{sha}","languages_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/languages","stargazers_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/stargazers","contributors_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/contributors","subscribers_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/subscribers","subscription_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/subscription","commits_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/commits{/sha}","git_commits_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/git/commits{/sha}","comments_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/comments{/number}","issue_comment_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/issues/comments{/number}","contents_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/contents/{+path}","compare_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/merges","archive_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/downloads","issues_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/issues{/number}","pulls_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/pulls{/number}","milestones_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/milestones{/number}","notifications_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/labels{/name}","releases_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/releases{/id}","deployments_url":"https://api.github.com/repos/ItsGameNight/kdm-archivist/deployments","created_at":"2018-04-13T18:26:22Z","updated_at":"2018-05-22T17:48:29Z","pushed_at":"2018-05-23T01:56:13Z","git_url":"git://github.com/ItsGameNight/kdm-archivist.git","ssh_url":"git@github.com:ItsGameNight/kdm-archivist.git","clone_url":"https://github.com/ItsGameNight/kdm-archivist.git","svn_url":"https://github.com/ItsGameNight/kdm-archivist","homepage":null,"size":2655,"stargazers_count":1,"watchers_count":1,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ItsGameNight/kdm-archivist/pulls/11"},"html":{"href":"https://github.com/ItsGameNight/kdm-archivist/pull/11"},"issue":{"href":"https://api.github.com/repos/ItsGameNight/kdm-archivist/issues/11"},"comments":{"href":"https://api.github.com/repos/ItsGameNight/kdm-archivist/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/ItsGameNight/kdm-archivist/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/ItsGameNight/kdm-archivist/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ItsGameNight/kdm-archivist/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/ItsGameNight/kdm-archivist/statuses/ffaa74ba3e02b583d0e0bf1951914a3054d525fc"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mws96","id":6209744,"avatar_url":"https://avatars2.githubusercontent.com/u/6209744?v=4","gravatar_id":"","url":"https://api.github.com/users/mws96","html_url":"https://github.com/mws96","followers_url":"https://api.github.com/users/mws96/followers","following_url":"https://api.github.com/users/mws96/following{/other_user}","gists_url":"https://api.github.com/users/mws96/gists{/gist_id}","starred_url":"https://api.github.com/users/mws96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mws96/subscriptions","organizations_url":"https://api.github.com/users/mws96/orgs","repos_url":"https://api.github.com/users/mws96/repos","events_url":"https://api.github.com/users/mws96/events{/privacy}","received_events_url":"https://api.github.com/users/mws96/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":17,"additions":713,"deletions":369,"changed_files":12}}
{"actor":{"display_login":"mws96"}}