{"action":"created","issue":{"url":"https://api.github.com/repos/webpack/webpack-cli/issues/635","repository_url":"https://api.github.com/repos/webpack/webpack-cli","labels_url":"https://api.github.com/repos/webpack/webpack-cli/issues/635/labels{/name}","comments_url":"https://api.github.com/repos/webpack/webpack-cli/issues/635/comments","events_url":"https://api.github.com/repos/webpack/webpack-cli/issues/635/events","html_url":"https://github.com/webpack/webpack-cli/pull/635","id":368549918,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzAwNDcw","number":635,"title":"Better test suite for binary tests","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","site_admin":false},"labels":[{"id":796805034,"node_id":"MDU6TGFiZWw3OTY4MDUwMzQ=","url":"https://api.github.com/repos/webpack/webpack-cli/labels/PR:%20unreviewed","name":"PR: unreviewed","color":"afd8f7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-10T08:31:27Z","updated_at":"2018-10-15T16:10:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/webpack/webpack-cli/pulls/635","html_url":"https://github.com/webpack/webpack-cli/pull/635","diff_url":"https://github.com/webpack/webpack-cli/pull/635.diff","patch_url":"https://github.com/webpack/webpack-cli/pull/635.patch"},"body":"<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->\r\n\r\n**What kind of change does this PR introduce?**\r\n<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->\r\nRefactor of the test bin cases in order to run them singularly. Also, it implements snapshot tests\r\n\r\n**Did you add tests for your changes?**\r\nWell, kinda :)\r\n\r\n**If relevant, did you update the documentation?**\r\nNot yet, probably I will once everything is ready\r\n\r\n**Summary**\r\nSo, taken from #621 I started the refactor of the bin tests. \r\nAs suggested, I removed from the stream of the output everything that has the Hash, timestamps and versions. This is because they change at every build/version change of webpack, causing the fail of the snapshot test.\r\n\r\nAlso, as suggested, we could change the way we pass the arguments from being an array to being an object. Feedbacks are welcom\r\n\r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n<!-- Try to link to an open issue for more information. -->\r\n\r\n**Does this PR introduce a breaking change?**\r\n<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->\r\n\r\n**Other information**\r\nLet's have some feedback"},"comment":{"url":"https://api.github.com/repos/webpack/webpack-cli/issues/comments/429916162","html_url":"https://github.com/webpack/webpack-cli/pull/635#issuecomment-429916162","issue_url":"https://api.github.com/repos/webpack/webpack-cli/issues/635","id":429916162,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTkxNjE2Mg==","user":{"login":"ematipico","id":602478,"node_id":"MDQ6VXNlcjYwMjQ3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T16:10:15Z","updated_at":"2018-10-15T16:10:15Z","author_association":"CONTRIBUTOR","body":"Hi @SimenB , thanks for your feedback!! Really appreciated! I tried to follow your suggestions but still we got issue inside the CI. Probably there's something that I am still missing...\r\n\r\nSo, I kill the process when there's some output (like you suggested where you wait for some kind of error). When there's output, we kill the process.\r\n\r\nInside jests tests, I return the promise and in theory jest should wait for it. Although on Travis it keeps failing with a timeout error, so Jest it's not waiting properly... any tips?"}}
{"actor":{"display_login":"ematipico"}}