{"action":"created","comment":{"url":"https://api.github.com/repos/cloudtools/troposphere/pulls/comments/226870583","pull_request_review_id":166793334,"id":226870583,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjg3MDU4Mw==","diff_hunk":"@@ -177,10 +178,28 @@ class DeploymentGroup(AWSObject):\n         'DeploymentGroupName': (basestring, False),\n         'DeploymentStyle': (DeploymentStyle, False),\n         'Ec2TagFilters': ([Ec2TagFilters], False),\n+        'Ec2TagSet': ([Ec2TagFilters], False),","path":"troposphere/codedeploy.py","position":23,"original_position":23,"commit_id":"a6b763fb6c6bdae6e78d020625adfd37282ccdfe","original_commit_id":"a6b763fb6c6bdae6e78d020625adfd37282ccdfe","user":{"login":"phobologic","id":517334,"node_id":"MDQ6VXNlcjUxNzMzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/517334?v=4","gravatar_id":"","url":"https://api.github.com/users/phobologic","html_url":"https://github.com/phobologic","followers_url":"https://api.github.com/users/phobologic/followers","following_url":"https://api.github.com/users/phobologic/following{/other_user}","gists_url":"https://api.github.com/users/phobologic/gists{/gist_id}","starred_url":"https://api.github.com/users/phobologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phobologic/subscriptions","organizations_url":"https://api.github.com/users/phobologic/orgs","repos_url":"https://api.github.com/users/phobologic/repos","events_url":"https://api.github.com/users/phobologic/events{/privacy}","received_events_url":"https://api.github.com/users/phobologic/received_events","type":"User","site_admin":false},"body":"Hey @mprince, I believe this requires a new Property type:\r\n\r\nhttps://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codedeploy-deploymentgroup-ec2tagset.html","created_at":"2018-10-21T17:15:55Z","updated_at":"2018-10-21T17:17:26Z","html_url":"https://github.com/cloudtools/troposphere/pull/1176#discussion_r226870583","pull_request_url":"https://api.github.com/repos/cloudtools/troposphere/pulls/1176","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cloudtools/troposphere/pulls/comments/226870583"},"html":{"href":"https://github.com/cloudtools/troposphere/pull/1176#discussion_r226870583"},"pull_request":{"href":"https://api.github.com/repos/cloudtools/troposphere/pulls/1176"}}},"pull_request":{"url":"https://api.github.com/repos/cloudtools/troposphere/pulls/1176","id":223690904,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjkwOTA0","html_url":"https://github.com/cloudtools/troposphere/pull/1176","diff_url":"https://github.com/cloudtools/troposphere/pull/1176.diff","patch_url":"https://github.com/cloudtools/troposphere/pull/1176.patch","issue_url":"https://api.github.com/repos/cloudtools/troposphere/issues/1176","number":1176,"state":"open","locked":false,"title":"Update codedeploy as of 09/20/18","user":{"login":"mprince","id":5485148,"node_id":"MDQ6VXNlcjU0ODUxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5485148?v=4","gravatar_id":"","url":"https://api.github.com/users/mprince","html_url":"https://github.com/mprince","followers_url":"https://api.github.com/users/mprince/followers","following_url":"https://api.github.com/users/mprince/following{/other_user}","gists_url":"https://api.github.com/users/mprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprince/subscriptions","organizations_url":"https://api.github.com/users/mprince/orgs","repos_url":"https://api.github.com/users/mprince/repos","events_url":"https://api.github.com/users/mprince/events{/privacy}","received_events_url":"https://api.github.com/users/mprince/received_events","type":"User","site_admin":false},"body":"[AWS CloudFormation Release History](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/ReleaseHistory.html)","created_at":"2018-10-17T17:28:17Z","updated_at":"2018-10-21T17:17:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0433c9235beedbd00c422f4d53db1cd4b3072b19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudtools/troposphere/pulls/1176/commits","review_comments_url":"https://api.github.com/repos/cloudtools/troposphere/pulls/1176/comments","review_comment_url":"https://api.github.com/repos/cloudtools/troposphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudtools/troposphere/issues/1176/comments","statuses_url":"https://api.github.com/repos/cloudtools/troposphere/statuses/a6b763fb6c6bdae6e78d020625adfd37282ccdfe","head":{"label":"mprince:codedeploy","ref":"codedeploy","sha":"a6b763fb6c6bdae6e78d020625adfd37282ccdfe","user":{"login":"mprince","id":5485148,"node_id":"MDQ6VXNlcjU0ODUxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5485148?v=4","gravatar_id":"","url":"https://api.github.com/users/mprince","html_url":"https://github.com/mprince","followers_url":"https://api.github.com/users/mprince/followers","following_url":"https://api.github.com/users/mprince/following{/other_user}","gists_url":"https://api.github.com/users/mprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprince/subscriptions","organizations_url":"https://api.github.com/users/mprince/orgs","repos_url":"https://api.github.com/users/mprince/repos","events_url":"https://api.github.com/users/mprince/events{/privacy}","received_events_url":"https://api.github.com/users/mprince/received_events","type":"User","site_admin":false},"repo":{"id":153335853,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMzU4NTM=","name":"troposphere","full_name":"mprince/troposphere","private":false,"owner":{"login":"mprince","id":5485148,"node_id":"MDQ6VXNlcjU0ODUxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5485148?v=4","gravatar_id":"","url":"https://api.github.com/users/mprince","html_url":"https://github.com/mprince","followers_url":"https://api.github.com/users/mprince/followers","following_url":"https://api.github.com/users/mprince/following{/other_user}","gists_url":"https://api.github.com/users/mprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprince/subscriptions","organizations_url":"https://api.github.com/users/mprince/orgs","repos_url":"https://api.github.com/users/mprince/repos","events_url":"https://api.github.com/users/mprince/events{/privacy}","received_events_url":"https://api.github.com/users/mprince/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mprince/troposphere","description":"troposphere - Python library to create AWS CloudFormation descriptions","fork":true,"url":"https://api.github.com/repos/mprince/troposphere","forks_url":"https://api.github.com/repos/mprince/troposphere/forks","keys_url":"https://api.github.com/repos/mprince/troposphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mprince/troposphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mprince/troposphere/teams","hooks_url":"https://api.github.com/repos/mprince/troposphere/hooks","issue_events_url":"https://api.github.com/repos/mprince/troposphere/issues/events{/number}","events_url":"https://api.github.com/repos/mprince/troposphere/events","assignees_url":"https://api.github.com/repos/mprince/troposphere/assignees{/user}","branches_url":"https://api.github.com/repos/mprince/troposphere/branches{/branch}","tags_url":"https://api.github.com/repos/mprince/troposphere/tags","blobs_url":"https://api.github.com/repos/mprince/troposphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mprince/troposphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mprince/troposphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/mprince/troposphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mprince/troposphere/statuses/{sha}","languages_url":"https://api.github.com/repos/mprince/troposphere/languages","stargazers_url":"https://api.github.com/repos/mprince/troposphere/stargazers","contributors_url":"https://api.github.com/repos/mprince/troposphere/contributors","subscribers_url":"https://api.github.com/repos/mprince/troposphere/subscribers","subscription_url":"https://api.github.com/repos/mprince/troposphere/subscription","commits_url":"https://api.github.com/repos/mprince/troposphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/mprince/troposphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/mprince/troposphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/mprince/troposphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/mprince/troposphere/contents/{+path}","compare_url":"https://api.github.com/repos/mprince/troposphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mprince/troposphere/merges","archive_url":"https://api.github.com/repos/mprince/troposphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mprince/troposphere/downloads","issues_url":"https://api.github.com/repos/mprince/troposphere/issues{/number}","pulls_url":"https://api.github.com/repos/mprince/troposphere/pulls{/number}","milestones_url":"https://api.github.com/repos/mprince/troposphere/milestones{/number}","notifications_url":"https://api.github.com/repos/mprince/troposphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mprince/troposphere/labels{/name}","releases_url":"https://api.github.com/repos/mprince/troposphere/releases{/id}","deployments_url":"https://api.github.com/repos/mprince/troposphere/deployments","created_at":"2018-10-16T18:38:31Z","updated_at":"2018-10-16T18:38:34Z","pushed_at":"2018-10-20T19:01:08Z","git_url":"git://github.com/mprince/troposphere.git","ssh_url":"git@github.com:mprince/troposphere.git","clone_url":"https://github.com/mprince/troposphere.git","svn_url":"https://github.com/mprince/troposphere","homepage":"","size":1747,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudtools:master","ref":"master","sha":"ecfccf22c5f43700bce236d357d56db350f43a75","user":{"login":"cloudtools","id":3028687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjg2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/3028687?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudtools","html_url":"https://github.com/cloudtools","followers_url":"https://api.github.com/users/cloudtools/followers","following_url":"https://api.github.com/users/cloudtools/following{/other_user}","gists_url":"https://api.github.com/users/cloudtools/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudtools/subscriptions","organizations_url":"https://api.github.com/users/cloudtools/orgs","repos_url":"https://api.github.com/users/cloudtools/repos","events_url":"https://api.github.com/users/cloudtools/events{/privacy}","received_events_url":"https://api.github.com/users/cloudtools/received_events","type":"Organization","site_admin":false},"repo":{"id":7137821,"node_id":"MDEwOlJlcG9zaXRvcnk3MTM3ODIx","name":"troposphere","full_name":"cloudtools/troposphere","private":false,"owner":{"login":"cloudtools","id":3028687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjg2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/3028687?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudtools","html_url":"https://github.com/cloudtools","followers_url":"https://api.github.com/users/cloudtools/followers","following_url":"https://api.github.com/users/cloudtools/following{/other_user}","gists_url":"https://api.github.com/users/cloudtools/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudtools/subscriptions","organizations_url":"https://api.github.com/users/cloudtools/orgs","repos_url":"https://api.github.com/users/cloudtools/repos","events_url":"https://api.github.com/users/cloudtools/events{/privacy}","received_events_url":"https://api.github.com/users/cloudtools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudtools/troposphere","description":"troposphere - Python library to create AWS CloudFormation descriptions","fork":false,"url":"https://api.github.com/repos/cloudtools/troposphere","forks_url":"https://api.github.com/repos/cloudtools/troposphere/forks","keys_url":"https://api.github.com/repos/cloudtools/troposphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudtools/troposphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudtools/troposphere/teams","hooks_url":"https://api.github.com/repos/cloudtools/troposphere/hooks","issue_events_url":"https://api.github.com/repos/cloudtools/troposphere/issues/events{/number}","events_url":"https://api.github.com/repos/cloudtools/troposphere/events","assignees_url":"https://api.github.com/repos/cloudtools/troposphere/assignees{/user}","branches_url":"https://api.github.com/repos/cloudtools/troposphere/branches{/branch}","tags_url":"https://api.github.com/repos/cloudtools/troposphere/tags","blobs_url":"https://api.github.com/repos/cloudtools/troposphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudtools/troposphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudtools/troposphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudtools/troposphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudtools/troposphere/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudtools/troposphere/languages","stargazers_url":"https://api.github.com/repos/cloudtools/troposphere/stargazers","contributors_url":"https://api.github.com/repos/cloudtools/troposphere/contributors","subscribers_url":"https://api.github.com/repos/cloudtools/troposphere/subscribers","subscription_url":"https://api.github.com/repos/cloudtools/troposphere/subscription","commits_url":"https://api.github.com/repos/cloudtools/troposphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudtools/troposphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudtools/troposphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudtools/troposphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudtools/troposphere/contents/{+path}","compare_url":"https://api.github.com/repos/cloudtools/troposphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudtools/troposphere/merges","archive_url":"https://api.github.com/repos/cloudtools/troposphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudtools/troposphere/downloads","issues_url":"https://api.github.com/repos/cloudtools/troposphere/issues{/number}","pulls_url":"https://api.github.com/repos/cloudtools/troposphere/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudtools/troposphere/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudtools/troposphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudtools/troposphere/labels{/name}","releases_url":"https://api.github.com/repos/cloudtools/troposphere/releases{/id}","deployments_url":"https://api.github.com/repos/cloudtools/troposphere/deployments","created_at":"2012-12-12T21:19:46Z","updated_at":"2018-10-21T17:14:44Z","pushed_at":"2018-10-21T17:14:37Z","git_url":"git://github.com/cloudtools/troposphere.git","ssh_url":"git@github.com:cloudtools/troposphere.git","clone_url":"https://github.com/cloudtools/troposphere.git","svn_url":"https://github.com/cloudtools/troposphere","homepage":"","size":1742,"stargazers_count":3079,"watchers_count":3079,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":945,"mirror_url":null,"archived":false,"open_issues_count":157,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":945,"open_issues":157,"watchers":3079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudtools/troposphere/pulls/1176"},"html":{"href":"https://github.com/cloudtools/troposphere/pull/1176"},"issue":{"href":"https://api.github.com/repos/cloudtools/troposphere/issues/1176"},"comments":{"href":"https://api.github.com/repos/cloudtools/troposphere/issues/1176/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudtools/troposphere/pulls/1176/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudtools/troposphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudtools/troposphere/pulls/1176/commits"},"statuses":{"href":"https://api.github.com/repos/cloudtools/troposphere/statuses/a6b763fb6c6bdae6e78d020625adfd37282ccdfe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"phobologic"}}