{"action":"opened","number":14606,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/14606","id":181381083,"html_url":"https://github.com/ampproject/amphtml/pull/14606","diff_url":"https://github.com/ampproject/amphtml/pull/14606.diff","patch_url":"https://github.com/ampproject/amphtml/pull/14606.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/14606","number":14606,"state":"open","locked":false,"title":"🐛 Respect CAN_SHOW_SYSTEM_LAYER_BUTTONS property on desktop","user":{"login":"newmuis","id":1651960,"avatar_url":"https://avatars3.githubusercontent.com/u/1651960?v=4","gravatar_id":"","url":"https://api.github.com/users/newmuis","html_url":"https://github.com/newmuis","followers_url":"https://api.github.com/users/newmuis/followers","following_url":"https://api.github.com/users/newmuis/following{/other_user}","gists_url":"https://api.github.com/users/newmuis/gists{/gist_id}","starred_url":"https://api.github.com/users/newmuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newmuis/subscriptions","organizations_url":"https://api.github.com/users/newmuis/orgs","repos_url":"https://api.github.com/users/newmuis/repos","events_url":"https://api.github.com/users/newmuis/events{/privacy}","received_events_url":"https://api.github.com/users/newmuis/received_events","type":"User","site_admin":false},"body":"Also subscribes to the state for both the share pill and the system layer.  Also, switches to using `visibility: hidden` instead of `display: none` to simplify (since we often change the `display` property for other reasons).\r\n\r\nFixes #14574 ","created_at":"2018-04-13T04:03:19Z","updated_at":"2018-04-13T04:03:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14606/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14606/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/14606/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/d1cf79eab1a6673e254c522c1c454dc3cdbe37a1","head":{"label":"newmuis:amp-story-embed-mode-desktop","ref":"amp-story-embed-mode-desktop","sha":"d1cf79eab1a6673e254c522c1c454dc3cdbe37a1","user":{"login":"newmuis","id":1651960,"avatar_url":"https://avatars3.githubusercontent.com/u/1651960?v=4","gravatar_id":"","url":"https://api.github.com/users/newmuis","html_url":"https://github.com/newmuis","followers_url":"https://api.github.com/users/newmuis/followers","following_url":"https://api.github.com/users/newmuis/following{/other_user}","gists_url":"https://api.github.com/users/newmuis/gists{/gist_id}","starred_url":"https://api.github.com/users/newmuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newmuis/subscriptions","organizations_url":"https://api.github.com/users/newmuis/orgs","repos_url":"https://api.github.com/users/newmuis/repos","events_url":"https://api.github.com/users/newmuis/events{/privacy}","received_events_url":"https://api.github.com/users/newmuis/received_events","type":"User","site_admin":false},"repo":{"id":118786678,"name":"amphtml","full_name":"newmuis/amphtml","owner":{"login":"newmuis","id":1651960,"avatar_url":"https://avatars3.githubusercontent.com/u/1651960?v=4","gravatar_id":"","url":"https://api.github.com/users/newmuis","html_url":"https://github.com/newmuis","followers_url":"https://api.github.com/users/newmuis/followers","following_url":"https://api.github.com/users/newmuis/following{/other_user}","gists_url":"https://api.github.com/users/newmuis/gists{/gist_id}","starred_url":"https://api.github.com/users/newmuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newmuis/subscriptions","organizations_url":"https://api.github.com/users/newmuis/orgs","repos_url":"https://api.github.com/users/newmuis/repos","events_url":"https://api.github.com/users/newmuis/events{/privacy}","received_events_url":"https://api.github.com/users/newmuis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/newmuis/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/newmuis/amphtml","forks_url":"https://api.github.com/repos/newmuis/amphtml/forks","keys_url":"https://api.github.com/repos/newmuis/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newmuis/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newmuis/amphtml/teams","hooks_url":"https://api.github.com/repos/newmuis/amphtml/hooks","issue_events_url":"https://api.github.com/repos/newmuis/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/newmuis/amphtml/events","assignees_url":"https://api.github.com/repos/newmuis/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/newmuis/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/newmuis/amphtml/tags","blobs_url":"https://api.github.com/repos/newmuis/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newmuis/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newmuis/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/newmuis/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newmuis/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/newmuis/amphtml/languages","stargazers_url":"https://api.github.com/repos/newmuis/amphtml/stargazers","contributors_url":"https://api.github.com/repos/newmuis/amphtml/contributors","subscribers_url":"https://api.github.com/repos/newmuis/amphtml/subscribers","subscription_url":"https://api.github.com/repos/newmuis/amphtml/subscription","commits_url":"https://api.github.com/repos/newmuis/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/newmuis/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/newmuis/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/newmuis/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/newmuis/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/newmuis/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newmuis/amphtml/merges","archive_url":"https://api.github.com/repos/newmuis/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newmuis/amphtml/downloads","issues_url":"https://api.github.com/repos/newmuis/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/newmuis/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/newmuis/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/newmuis/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newmuis/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/newmuis/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/newmuis/amphtml/deployments","created_at":"2018-01-24T15:51:50Z","updated_at":"2018-03-25T20:36:42Z","pushed_at":"2018-04-13T04:01:50Z","git_url":"git://github.com/newmuis/amphtml.git","ssh_url":"git@github.com:newmuis/amphtml.git","clone_url":"https://github.com/newmuis/amphtml.git","svn_url":"https://github.com/newmuis/amphtml","homepage":"https://www.ampproject.org","size":416708,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"a4b54904c66852c87dfc720ef8dca0818f4fb6dc","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-04-12T22:33:57Z","pushed_at":"2018-04-13T03:14:26Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":417150,"stargazers_count":11433,"watchers_count":11433,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2327,"mirror_url":null,"archived":false,"open_issues_count":1288,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2327,"open_issues":1288,"watchers":11433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14606"},"html":{"href":"https://github.com/ampproject/amphtml/pull/14606"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14606"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14606/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14606/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14606/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/d1cf79eab1a6673e254c522c1c454dc3cdbe37a1"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":18,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"newmuis"}}