{"action":"closed","number":9435,"pull_request":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9435","id":211929659,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTI5NjU5","html_url":"https://github.com/paritytech/parity-ethereum/pull/9435","diff_url":"https://github.com/paritytech/parity-ethereum/pull/9435.diff","patch_url":"https://github.com/paritytech/parity-ethereum/pull/9435.patch","issue_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9435","number":9435,"state":"closed","locked":false,"title":"aura: don't report skipped primaries when empty steps are enabled","user":{"login":"andresilva","id":123550,"node_id":"MDQ6VXNlcjEyMzU1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/123550?v=4","gravatar_id":"","url":"https://api.github.com/users/andresilva","html_url":"https://github.com/andresilva","followers_url":"https://api.github.com/users/andresilva/followers","following_url":"https://api.github.com/users/andresilva/following{/other_user}","gists_url":"https://api.github.com/users/andresilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andresilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresilva/subscriptions","organizations_url":"https://api.github.com/users/andresilva/orgs","repos_url":"https://api.github.com/users/andresilva/repos","events_url":"https://api.github.com/users/andresilva/events{/privacy}","received_events_url":"https://api.github.com/users/andresilva/received_events","type":"User","site_admin":false},"body":"Fix #9325.\r\n\r\nWhen empty steps are enabled we cannot report skipped primaries since we have no meaningful way to prove that the authority didn't actually broadcast an empty step message. This is already the existing behavior when verifying blocks (https://github.com/paritytech/parity-ethereum/blob/master/ethcore/src/engines/authority_round/mod.rs#L1146-L1180).","created_at":"2018-08-30T01:18:49Z","updated_at":"2018-09-06T11:33:47Z","closed_at":"2018-09-06T11:33:47Z","merged_at":"2018-09-06T11:33:47Z","merge_commit_sha":"4e8e5bbb86fab24790150c86affabf6af2d09d89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":309708192,"node_id":"MDU6TGFiZWwzMDk3MDgxOTI=","url":"https://api.github.com/repos/paritytech/parity-ethereum/labels/A8-looksgood%20%F0%9F%A6%84","name":"A8-looksgood 🦄","color":"C0E7CC","default":false},{"id":424253226,"node_id":"MDU6TGFiZWw0MjQyNTMyMjY=","url":"https://api.github.com/repos/paritytech/parity-ethereum/labels/B0-patchthis%20%F0%9F%95%B7","name":"B0-patchthis 🕷","color":"f4f5f9","default":false},{"id":441816407,"node_id":"MDU6TGFiZWw0NDE4MTY0MDc=","url":"https://api.github.com/repos/paritytech/parity-ethereum/labels/M4-core%20%E2%9B%93","name":"M4-core ⛓","color":"F5FCE6","default":false}],"milestone":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones/22","html_url":"https://github.com/paritytech/parity-ethereum/milestone/22","labels_url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones/22/labels","id":3153051,"node_id":"MDk6TWlsZXN0b25lMzE1MzA1MQ==","number":22,"title":"2.1","description":"","creator":{"login":"5chdn","id":15729797,"node_id":"MDQ6VXNlcjE1NzI5Nzk3","avatar_url":"https://avatars3.githubusercontent.com/u/15729797?v=4","gravatar_id":"","url":"https://api.github.com/users/5chdn","html_url":"https://github.com/5chdn","followers_url":"https://api.github.com/users/5chdn/followers","following_url":"https://api.github.com/users/5chdn/following{/other_user}","gists_url":"https://api.github.com/users/5chdn/gists{/gist_id}","starred_url":"https://api.github.com/users/5chdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5chdn/subscriptions","organizations_url":"https://api.github.com/users/5chdn/orgs","repos_url":"https://api.github.com/users/5chdn/repos","events_url":"https://api.github.com/users/5chdn/events{/privacy}","received_events_url":"https://api.github.com/users/5chdn/received_events","type":"User","site_admin":false},"open_issues":165,"closed_issues":396,"state":"open","created_at":"2018-03-01T09:29:12Z","updated_at":"2018-09-06T11:33:47Z","due_on":"2018-09-17T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9435/commits","review_comments_url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9435/comments","review_comment_url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9435/comments","statuses_url":"https://api.github.com/repos/paritytech/parity-ethereum/statuses/93adee521d84d7ba975b39e955b4e7a8a3b8f38f","head":{"label":"paritytech:andre/aura-fix-report-skipped","ref":"andre/aura-fix-report-skipped","sha":"93adee521d84d7ba975b39e955b4e7a8a3b8f38f","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"node_id":"MDEwOlJlcG9zaXRvcnk0NjcxNDkzOQ==","name":"parity-ethereum","full_name":"paritytech/parity-ethereum","owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity-ethereum","description":"The fast, light, and robust EVM and WASM client.","fork":false,"url":"https://api.github.com/repos/paritytech/parity-ethereum","forks_url":"https://api.github.com/repos/paritytech/parity-ethereum/forks","keys_url":"https://api.github.com/repos/paritytech/parity-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity-ethereum/teams","hooks_url":"https://api.github.com/repos/paritytech/parity-ethereum/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity-ethereum/events","assignees_url":"https://api.github.com/repos/paritytech/parity-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity-ethereum/tags","blobs_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity-ethereum/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity-ethereum/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity-ethereum/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity-ethereum/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity-ethereum/subscription","commits_url":"https://api.github.com/repos/paritytech/parity-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity-ethereum/merges","archive_url":"https://api.github.com/repos/paritytech/parity-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity-ethereum/downloads","issues_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity-ethereum/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2018-09-06T09:38:11Z","pushed_at":"2018-09-06T11:33:47Z","git_url":"git://github.com/paritytech/parity-ethereum.git","ssh_url":"git@github.com:paritytech/parity-ethereum.git","clone_url":"https://github.com/paritytech/parity-ethereum.git","svn_url":"https://github.com/paritytech/parity-ethereum","homepage":"https://parity.io","size":57445,"stargazers_count":4766,"watchers_count":4766,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1009,"mirror_url":null,"archived":false,"open_issues_count":251,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1009,"open_issues":251,"watchers":4766,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"8a5c9a8c709ebb92fbcf7a3d085d6e2a1046fcf9","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"node_id":"MDEwOlJlcG9zaXRvcnk0NjcxNDkzOQ==","name":"parity-ethereum","full_name":"paritytech/parity-ethereum","owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity-ethereum","description":"The fast, light, and robust EVM and WASM client.","fork":false,"url":"https://api.github.com/repos/paritytech/parity-ethereum","forks_url":"https://api.github.com/repos/paritytech/parity-ethereum/forks","keys_url":"https://api.github.com/repos/paritytech/parity-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity-ethereum/teams","hooks_url":"https://api.github.com/repos/paritytech/parity-ethereum/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity-ethereum/events","assignees_url":"https://api.github.com/repos/paritytech/parity-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity-ethereum/tags","blobs_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity-ethereum/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity-ethereum/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity-ethereum/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity-ethereum/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity-ethereum/subscription","commits_url":"https://api.github.com/repos/paritytech/parity-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity-ethereum/merges","archive_url":"https://api.github.com/repos/paritytech/parity-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity-ethereum/downloads","issues_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity-ethereum/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2018-09-06T09:38:11Z","pushed_at":"2018-09-06T11:33:47Z","git_url":"git://github.com/paritytech/parity-ethereum.git","ssh_url":"git@github.com:paritytech/parity-ethereum.git","clone_url":"https://github.com/paritytech/parity-ethereum.git","svn_url":"https://github.com/paritytech/parity-ethereum","homepage":"https://parity.io","size":57445,"stargazers_count":4766,"watchers_count":4766,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1009,"mirror_url":null,"archived":false,"open_issues_count":251,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1009,"open_issues":251,"watchers":4766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9435"},"html":{"href":"https://github.com/paritytech/parity-ethereum/pull/9435"},"issue":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9435"},"comments":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9435/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9435/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9435/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/parity-ethereum/statuses/93adee521d84d7ba975b39e955b4e7a8a3b8f38f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"5chdn","id":15729797,"node_id":"MDQ6VXNlcjE1NzI5Nzk3","avatar_url":"https://avatars3.githubusercontent.com/u/15729797?v=4","gravatar_id":"","url":"https://api.github.com/users/5chdn","html_url":"https://github.com/5chdn","followers_url":"https://api.github.com/users/5chdn/followers","following_url":"https://api.github.com/users/5chdn/following{/other_user}","gists_url":"https://api.github.com/users/5chdn/gists{/gist_id}","starred_url":"https://api.github.com/users/5chdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5chdn/subscriptions","organizations_url":"https://api.github.com/users/5chdn/orgs","repos_url":"https://api.github.com/users/5chdn/repos","events_url":"https://api.github.com/users/5chdn/events{/privacy}","received_events_url":"https://api.github.com/users/5chdn/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"5chdn"}}