{"action":"closed","issue":{"url":"https://api.github.com/repos/ReactTraining/react-router/issues/6452","repository_url":"https://api.github.com/repos/ReactTraining/react-router","labels_url":"https://api.github.com/repos/ReactTraining/react-router/issues/6452/labels{/name}","comments_url":"https://api.github.com/repos/ReactTraining/react-router/issues/6452/comments","events_url":"https://api.github.com/repos/ReactTraining/react-router/issues/6452/events","html_url":"https://github.com/ReactTraining/react-router/issues/6452","id":376972565,"node_id":"MDU6SXNzdWUzNzY5NzI1NjU=","number":6452,"title":"Version 4.3.0 of react-router-dom breaks NavLink bootstrap show/collapse behavior","user":{"login":"rgamage","id":16804880,"node_id":"MDQ6VXNlcjE2ODA0ODgw","avatar_url":"https://avatars0.githubusercontent.com/u/16804880?v=4","gravatar_id":"","url":"https://api.github.com/users/rgamage","html_url":"https://github.com/rgamage","followers_url":"https://api.github.com/users/rgamage/followers","following_url":"https://api.github.com/users/rgamage/following{/other_user}","gists_url":"https://api.github.com/users/rgamage/gists{/gist_id}","starred_url":"https://api.github.com/users/rgamage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgamage/subscriptions","organizations_url":"https://api.github.com/users/rgamage/orgs","repos_url":"https://api.github.com/users/rgamage/repos","events_url":"https://api.github.com/users/rgamage/events{/privacy}","received_events_url":"https://api.github.com/users/rgamage/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-02T21:24:24Z","updated_at":"2018-11-03T04:33:38Z","closed_at":"2018-11-03T04:33:38Z","author_association":"NONE","body":"## Version\r\nUsing React version 16.1.1, react-router-dom 4.2.2 -> 4.3.0\r\nbootstrap 4.1.3\r\njquery 3.2.1\r\n\r\n## Test Case\r\nUsing react-router-dom 4.2.2 or earlier, bootstrap collapse / show behaviors are working as expected, using NavLink and bootstrap's collapse behaviors:\r\n\r\n                        <NavLink className=\"form-control\" to=\"#profileNotifications\" data-toggle=\"collapse\" role=\"button\" aria-expanded=\"false\">\r\n                            Click here to show notification preferences\r\n                        </NavLink>\r\n\r\n\\<div>className=\"collapse\" id=\"profileNotifications\">\r\n    \\<p>hidden content, show when click the above link\\</p>\r\n\\</div>\r\n\r\n\r\n## Expected Behavior\r\nIn the example code above, clicking in the NavLink should expand/show the hidden content in the profileNotifications div below.\r\n\r\n## Actual Behavior\r\nUsing 4.3.0+, the expand behavior does not work.  The div below is always hidden, the 'show' class is not added to the div, as it should be.\r\n\r\nI've read that it may not be recommended to mix bootstrap.js behaviors with React, but I've only read that as a side comment from one poster.  If that is indeed the official recommendation from the React community, then I'm fine with replacing this implementation with react-style showing/hiding.  However, if the intent is to co-exist with bootstrap, then I'd like to get this working.  I seem to recall that if I simply leave out bootstrap.js, then I get errors that it is a required dependency of bootstrap.\r\n\r\nThanks in advance for the help.\r\n"}}
{"actor":{"display_login":"timdorr"}}