{"action":"closed","number":35363,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35363","id":170863309,"html_url":"https://github.com/NixOS/nixpkgs/pull/35363","diff_url":"https://github.com/NixOS/nixpkgs/pull/35363.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/35363.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35363","number":35363,"state":"closed","locked":false,"title":"busybox: 1.28.0 -> 1.28.1","user":{"login":"dtzWill","id":817330,"avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"body":"Minor bump but one fix does impact our sandbox shell:\nhttps://git.busybox.net/busybox/commit/?h=1_28_stable&id=59675c625d6500a9a0657481321954b0d1f63da9\n\nYou can try it with:\n\n```console\n$ nix run -f https://github.com/NixOS/nixpkgs/archive/master.tar.gz busybox-sandbox-shell -c busybox sh -c \"shift 5 && echo eek\"\neek\n$\n```\n\nAfter this update:\n\n```console\n$ nix run -f .  busybox-sandbox-shell -c busybox sh -c \"shift 5 && echo eek\"\n$ # no eek printed\n```\n\nbootstrap tools testing seems good.\n\n\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\n\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\n- Built on platform(s)\n   - [x] NixOS\n   - [ ] macOS\n   - [ ] other Linux distributions\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\n\n---","created_at":"2018-02-22T20:55:48Z","updated_at":"2018-02-22T21:04:34Z","closed_at":"2018-02-22T21:04:34Z","merged_at":"2018-02-22T21:04:34Z","merge_commit_sha":"664cb083e756d3db1ea6b8433d3fa1d88046c6bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731734101,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%2011-100","name":"10.rebuild-linux: 11-100","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35363/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35363/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35363/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/9261c17ad01b69018f50f5f8e1a5b979bacf5d4a","head":{"label":"dtzWill:update/busybox-1.28.1","ref":"update/busybox-1.28.1","sha":"9261c17ad01b69018f50f5f8e1a5b979bacf5d4a","user":{"login":"dtzWill","id":817330,"avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"repo":{"id":60178915,"name":"nixpkgs","full_name":"dtzWill/nixpkgs","owner":{"login":"dtzWill","id":817330,"avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtzWill/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/dtzWill/nixpkgs","forks_url":"https://api.github.com/repos/dtzWill/nixpkgs/forks","keys_url":"https://api.github.com/repos/dtzWill/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtzWill/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtzWill/nixpkgs/teams","hooks_url":"https://api.github.com/repos/dtzWill/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/dtzWill/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/dtzWill/nixpkgs/events","assignees_url":"https://api.github.com/repos/dtzWill/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/dtzWill/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/dtzWill/nixpkgs/tags","blobs_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtzWill/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/dtzWill/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/dtzWill/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/dtzWill/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/dtzWill/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/dtzWill/nixpkgs/subscription","commits_url":"https://api.github.com/repos/dtzWill/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtzWill/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtzWill/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtzWill/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/dtzWill/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtzWill/nixpkgs/merges","archive_url":"https://api.github.com/repos/dtzWill/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtzWill/nixpkgs/downloads","issues_url":"https://api.github.com/repos/dtzWill/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/dtzWill/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/dtzWill/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/dtzWill/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtzWill/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/dtzWill/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/dtzWill/nixpkgs/deployments","created_at":"2016-06-01T13:23:48Z","updated_at":"2016-06-01T13:24:12Z","pushed_at":"2018-02-22T20:52:41Z","git_url":"git://github.com/dtzWill/nixpkgs.git","ssh_url":"git@github.com:dtzWill/nixpkgs.git","clone_url":"https://github.com/dtzWill/nixpkgs.git","svn_url":"https://github.com/dtzWill/nixpkgs","homepage":null,"size":653743,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"28e10850d638f75ed7004ed85a39d57f736cc1ac","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-02-22T12:07:10Z","pushed_at":"2018-02-22T21:04:34Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":721712,"stargazers_count":2235,"watchers_count":2235,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2579,"mirror_url":null,"archived":false,"open_issues_count":2881,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2579,"open_issues":2881,"watchers":2235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35363"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/35363"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/35363"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/35363/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35363/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35363/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/9261c17ad01b69018f50f5f8e1a5b979bacf5d4a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dtzWill","id":817330,"avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"dtzWill"}}