{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/207492383","pull_request_review_id":143115185,"id":207492383,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzQ5MjM4Mw==","diff_hunk":"@@ -2655,7 +2655,34 @@\n             { \"item\": \"stick\", \"count\": [8, 12] }\n         ]\n     }\n-  },{\n+    },{\n+    \"type\" : \"furniture\",\n+    \"id\" : \"f_smoking_rack_active\",\n+    \"name\": \"active smoking rack\",\n+    \"description\": \"A special rack designed to smoke food for better preservation and taste.\",","path":"data/json/furniture.json","position":18,"original_position":18,"commit_id":"b59e4bf716993673c93ed55d4b60235a94b861f4","original_commit_id":"b59e4bf716993673c93ed55d4b60235a94b861f4","user":{"login":"cainiaowu","id":4143592,"node_id":"MDQ6VXNlcjQxNDM1OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4143592?v=4","gravatar_id":"","url":"https://api.github.com/users/cainiaowu","html_url":"https://github.com/cainiaowu","followers_url":"https://api.github.com/users/cainiaowu/followers","following_url":"https://api.github.com/users/cainiaowu/following{/other_user}","gists_url":"https://api.github.com/users/cainiaowu/gists{/gist_id}","starred_url":"https://api.github.com/users/cainiaowu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cainiaowu/subscriptions","organizations_url":"https://api.github.com/users/cainiaowu/orgs","repos_url":"https://api.github.com/users/cainiaowu/repos","events_url":"https://api.github.com/users/cainiaowu/events{/privacy}","received_events_url":"https://api.github.com/users/cainiaowu/received_events","type":"User","site_admin":false},"body":"Maybe add one additional line like\"it is currently lit\" to inform the player better?","created_at":"2018-08-03T09:34:31Z","updated_at":"2018-08-03T09:34:31Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24307#discussion_r207492383","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24307","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/207492383"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24307#discussion_r207492383"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24307"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24307","id":201495314,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDk1MzE0","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24307","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24307.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24307.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24307","number":24307,"state":"open","locked":false,"title":"[DONE] [CR] Smoking rack interactions expansion","user":{"login":"nexusmrsep","id":39925111,"node_id":"MDQ6VXNlcjM5OTI1MTEx","avatar_url":"https://avatars0.githubusercontent.com/u/39925111?v=4","gravatar_id":"","url":"https://api.github.com/users/nexusmrsep","html_url":"https://github.com/nexusmrsep","followers_url":"https://api.github.com/users/nexusmrsep/followers","following_url":"https://api.github.com/users/nexusmrsep/following{/other_user}","gists_url":"https://api.github.com/users/nexusmrsep/gists{/gist_id}","starred_url":"https://api.github.com/users/nexusmrsep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nexusmrsep/subscriptions","organizations_url":"https://api.github.com/users/nexusmrsep/orgs","repos_url":"https://api.github.com/users/nexusmrsep/repos","events_url":"https://api.github.com/users/nexusmrsep/events{/privacy}","received_events_url":"https://api.github.com/users/nexusmrsep/received_events","type":"User","site_admin":false},"body":"### **What does it do?**\r\n\r\nThis PR changes how **smoking rack** works to resolve #24270 \r\nSmoking rack new behavior is similar to charcoal kiln, where you load it with appropriate food and charcoal, light up and then leave smoking for enough time to do it's job.\r\n\r\n### **Racionale:**\r\nSmoking food by using recipes wastes precious time, forcing a watchful vigil over food being smoked.\r\nThis option allows to batch smoke food by placing it in the smoking rack, loading it with charcoal, firing it up, and leaving it behind while it does it's job.\r\nAlso see  #24270 for more info.\r\n\r\n### **Features**\r\n\r\n1. Smoking rack has an interactive menu with dynamic options (mainly to utilize existing reload_furniture function and to bypass NO_ITEM flag).\r\n2. Smoking rack allows food with SMOKABLE flag, does't allow already SMOKED (flag) food, and other food \r\n3. It converts non-smoked food to smoked food (TODO: need a better way to pair smokable food with smoked products, other then hard-coding it, json-izing would be ideal option)\r\n4. It holds max 20 liters of food, and needs 6 hours to finish smoking.\r\n5. Added new recipes for raw versions of existing (smoked) sausages - they require less time, have good batch ratios, and are considered raw (spoil time, possible parasites), so they need smoking to get the desired properties of the final product.\r\n6. [update] Smoking rack emits smoke (its a _smoking_ rack, could you expect anything else?; added `fake_smoke_plume` fake item to streamline this process)\r\n7. [update] adding food to rack via a popup menu.\r\n8. [update] added 'inspect rack' menu, mainly to inspect its contents\r\n\r\n### **Implementation:**\r\nLet's be real here, I'm not a pro so I scavenged as much good code as I could and stitched it together like a Frankenstein's monster. May not be pretty, but hopefully it'll be alive. It got more complicated then anticipated, but it's on a right path.\r\n\r\n### **TODO**:\r\n- [x] smoothing food inserting menu\r\n- [x] testing & debugging \r\n- [x] Inspect contents menu option \r\n","created_at":"2018-07-15T12:18:04Z","updated_at":"2018-08-03T09:34:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8b49bcd942b7b042f07a3a5e5c8dd6d2a2476ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":887828902,"node_id":"MDU6TGFiZWw4ODc4Mjg5MDI=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/%3CBugfix%3E","name":"<Bugfix>","color":"29fc29","default":false},{"id":14965560,"node_id":"MDU6TGFiZWwxNDk2NTU2MA==","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/%3CEnhancement%20/%20Feature%3E","name":"<Enhancement / Feature>","color":"84b6eb","default":false},{"id":887835116,"node_id":"MDU6TGFiZWw4ODc4MzUxMTY=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Fields%20/%20Furniture%20/%20Terrain%20/%20Traps","name":"Fields / Furniture / Terrain / Traps","color":"753939","default":false},{"id":659366627,"node_id":"MDU6TGFiZWw2NTkzNjY2Mjc=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/[C++]","name":"[C++]","color":"f9d0c4","default":false},{"id":235869031,"node_id":"MDU6TGFiZWwyMzU4NjkwMzE=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/[JSON]","name":"[JSON]","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24307/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24307/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24307/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/b59e4bf716993673c93ed55d4b60235a94b861f4","head":{"label":"nexusmrsep:smoking_rack_expansion","ref":"smoking_rack_expansion","sha":"b59e4bf716993673c93ed55d4b60235a94b861f4","user":{"login":"nexusmrsep","id":39925111,"node_id":"MDQ6VXNlcjM5OTI1MTEx","avatar_url":"https://avatars0.githubusercontent.com/u/39925111?v=4","gravatar_id":"","url":"https://api.github.com/users/nexusmrsep","html_url":"https://github.com/nexusmrsep","followers_url":"https://api.github.com/users/nexusmrsep/followers","following_url":"https://api.github.com/users/nexusmrsep/following{/other_user}","gists_url":"https://api.github.com/users/nexusmrsep/gists{/gist_id}","starred_url":"https://api.github.com/users/nexusmrsep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nexusmrsep/subscriptions","organizations_url":"https://api.github.com/users/nexusmrsep/orgs","repos_url":"https://api.github.com/users/nexusmrsep/repos","events_url":"https://api.github.com/users/nexusmrsep/events{/privacy}","received_events_url":"https://api.github.com/users/nexusmrsep/received_events","type":"User","site_admin":false},"repo":{"id":136736821,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY3MzY4MjE=","name":"Cataclysm-DDA","full_name":"nexusmrsep/Cataclysm-DDA","owner":{"login":"nexusmrsep","id":39925111,"node_id":"MDQ6VXNlcjM5OTI1MTEx","avatar_url":"https://avatars0.githubusercontent.com/u/39925111?v=4","gravatar_id":"","url":"https://api.github.com/users/nexusmrsep","html_url":"https://github.com/nexusmrsep","followers_url":"https://api.github.com/users/nexusmrsep/followers","following_url":"https://api.github.com/users/nexusmrsep/following{/other_user}","gists_url":"https://api.github.com/users/nexusmrsep/gists{/gist_id}","starred_url":"https://api.github.com/users/nexusmrsep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nexusmrsep/subscriptions","organizations_url":"https://api.github.com/users/nexusmrsep/orgs","repos_url":"https://api.github.com/users/nexusmrsep/repos","events_url":"https://api.github.com/users/nexusmrsep/events{/privacy}","received_events_url":"https://api.github.com/users/nexusmrsep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nexusmrsep/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":true,"url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA","forks_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/nexusmrsep/Cataclysm-DDA/deployments","created_at":"2018-06-09T15:49:24Z","updated_at":"2018-08-01T17:32:17Z","pushed_at":"2018-08-01T18:32:29Z","git_url":"git://github.com/nexusmrsep/Cataclysm-DDA.git","ssh_url":"git@github.com:nexusmrsep/Cataclysm-DDA.git","clone_url":"https://github.com/nexusmrsep/Cataclysm-DDA.git","svn_url":"https://github.com/nexusmrsep/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1263965,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"e1e5d813f8e10bdd7f02ce52ccb8c33fafe6278f","user":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"node_id":"MDEwOlJlcG9zaXRvcnk1OTczODU1","name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2018-08-03T06:46:59Z","pushed_at":"2018-08-03T09:00:02Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1263783,"stargazers_count":1993,"watchers_count":1993,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1363,"mirror_url":null,"archived":false,"open_issues_count":852,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1363,"open_issues":852,"watchers":1993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24307"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/24307"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24307"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/24307/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24307/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/24307/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/b59e4bf716993673c93ed55d4b60235a94b861f4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cainiaowu"}}