{"action":"created","issue":{"url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/580","repository_url":"https://api.github.com/repos/carbon-design-system/carbon-components-react","labels_url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/580/labels{/name}","comments_url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/580/comments","events_url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/580/events","html_url":"https://github.com/carbon-design-system/carbon-components-react/issues/580","id":294896339,"number":580,"title":"Discussion: Add typescript types","user":{"login":"psachs21","id":11449728,"avatar_url":"https://avatars2.githubusercontent.com/u/11449728?v=4","gravatar_id":"","url":"https://api.github.com/users/psachs21","html_url":"https://github.com/psachs21","followers_url":"https://api.github.com/users/psachs21/followers","following_url":"https://api.github.com/users/psachs21/following{/other_user}","gists_url":"https://api.github.com/users/psachs21/gists{/gist_id}","starred_url":"https://api.github.com/users/psachs21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psachs21/subscriptions","organizations_url":"https://api.github.com/users/psachs21/orgs","repos_url":"https://api.github.com/users/psachs21/repos","events_url":"https://api.github.com/users/psachs21/events{/privacy}","received_events_url":"https://api.github.com/users/psachs21/received_events","type":"User","site_admin":false},"labels":[{"id":757475886,"url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/labels/discussion","name":"discussion","color":"FCCA6B","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-02-06T20:08:26Z","updated_at":"2018-04-13T04:08:23Z","closed_at":"2018-02-06T20:50:45Z","author_association":"CONTRIBUTOR","body":"## Add typescript types: Typescript definition files would provide better documentation built into our editors themselves.\r\n\r\n## Detailed description\r\n\r\nThis is more of a discussion rather than an issue itself. We've started using typescript over many of our apps and I'm trying to identify what we can do to add more documentation wherever we can. I've found a library [react-to-typescript-definitions](https://www.npmjs.com/package/react-to-typescript-definitions) that provides some ability to generate types from prop types. However, the library doesn't fit to some of our setup and we have a few exceptions that aren't supported by the tool. We would need to manually edit the output somewhat.\r\n\r\nHow do people feel about supporting type definition files? I was thinking that each component would have a type file (`types.d.ts`) within the directory to explain it's exports. We would need to do some processing on those files to combine in to a single types definition.\r\n\r\nThoughts?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/comments/381016111","html_url":"https://github.com/carbon-design-system/carbon-components-react/issues/580#issuecomment-381016111","issue_url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/580","id":381016111,"user":{"login":"psachs21","id":11449728,"avatar_url":"https://avatars2.githubusercontent.com/u/11449728?v=4","gravatar_id":"","url":"https://api.github.com/users/psachs21","html_url":"https://github.com/psachs21","followers_url":"https://api.github.com/users/psachs21/followers","following_url":"https://api.github.com/users/psachs21/following{/other_user}","gists_url":"https://api.github.com/users/psachs21/gists{/gist_id}","starred_url":"https://api.github.com/users/psachs21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psachs21/subscriptions","organizations_url":"https://api.github.com/users/psachs21/orgs","repos_url":"https://api.github.com/users/psachs21/repos","events_url":"https://api.github.com/users/psachs21/events{/privacy}","received_events_url":"https://api.github.com/users/psachs21/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T04:08:22Z","updated_at":"2018-04-13T04:08:22Z","author_association":"CONTRIBUTOR","body":"I made some attempts to generate types but higher priority tasks keep on\npopping up so I haven't had a chance to return to this.\nOn Thu, Apr 12, 2018 at 10:36 PM Roman Masyhar <notifications@github.com>\nwrote:\n\n> So @psachs21 <https://github.com/psachs21>, what's the progress now?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/carbon-design-system/carbon-components-react/issues/580#issuecomment-381003494>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AK61gDHbLi_HE7s1aXCYsBNmFBzcszK9ks5toA9AgaJpZM4R7p6S>\n> .\n>\n"}}
{"actor":{"display_login":"psachs21"}}