{"action":"created","comment":{"url":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/comments/196924824","pull_request_review_id":130567467,"id":196924824,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjkyNDgyNA==","diff_hunk":"@@ -0,0 +1,92 @@\n+/**\n+ * @file storage_fs.h\n+ *\n+ * @section LICENSE\n+ *\n+ * The MIT License\n+ *\n+ * @copyright Copyright (c) 2018 Omics Data Automation Inc. and Intel Corporation\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+ * THE SOFTWARE.\n+ * \n+ * @section DESCRIPTION\n+ *\n+ * Storage API exposes some filesystem specific functionality implemented in TileDB.\n+ *\n+ */\n+\n+#ifndef __STORAGE_FS_H__\n+#define  __STORAGE_FS_H__\n+\n+#include <string>\n+#include <vector>\n+#include <sys/stat.h>\n+\n+/**@{*/\n+/** Return code. */\n+#define TILEDB_FS_OK         0\n+#define TILEDB_FS_ERR       -1\n+/**@}*/\n+\n+/** Default error message. */\n+#define TILEDB_FS_ERRMSG std::string(\"[TileDB::FileSystem] Error: \")\n+\n+/* ********************************* */\n+/*          GLOBAL VARIABLES         */\n+/* ********************************* */\n+\n+/** Stores potential error messages. */\n+extern std::string tiledb_fs_errmsg;\n+\n+/** Base Class for Filesystems */\n+class StorageFS {\n+ public:\n+  virtual ~StorageFS();\n+\n+  virtual std::string current_dir() = 0;\n+  \n+  virtual bool is_dir(const std::string& dir) = 0;\n+  virtual bool is_file(const std::string& file) = 0;\n+  virtual std::string real_dir(const std::string& dir) = 0;\n+  \n+  virtual int create_dir(const std::string& dir) = 0;\n+  virtual int delete_dir(const std::string& dir) = 0;\n+\n+  virtual std::vector<std::string> get_dirs(const std::string& dir) = 0;\n+  virtual std::vector<std::string> get_files(const std::string& dir) = 0;\n+\n+  virtual int create_file(const std::string& filename, int flags, mode_t mode) = 0;\n+  virtual int delete_file(const std::string& filename) = 0;\n+\n+  virtual size_t file_size(const std::string& filename) = 0;\n+\n+  virtual int read_from_file(const std::string& filename, off_t offset, void *buffer, size_t length) = 0;\n+  virtual int write_to_file(const std::string& filename, const void *buffer, size_t buffer_size) = 0;\n+\n+  virtual int move_path(const std::string& old_path, const std::string& new_path) = 0;\n+    \n+  virtual int sync_path(const std::string& path) = 0;\n+\n+  virtual int close_file(const std::string& filename);\n+\n+  virtual bool consolidation_support(); ","path":"core/include/storage_manager/storage_fs.h","position":88,"original_position":88,"commit_id":"bf3b976c083f1470da3f577aa979c9de041bd2c0","original_commit_id":"23ac5dc2b04c1e4a0866c74d1b4acdcbd21567ee","user":{"login":"kgururaj","id":5776852,"node_id":"MDQ6VXNlcjU3NzY4NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5776852?v=4","gravatar_id":"","url":"https://api.github.com/users/kgururaj","html_url":"https://github.com/kgururaj","followers_url":"https://api.github.com/users/kgururaj/followers","following_url":"https://api.github.com/users/kgururaj/following{/other_user}","gists_url":"https://api.github.com/users/kgururaj/gists{/gist_id}","starred_url":"https://api.github.com/users/kgururaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgururaj/subscriptions","organizations_url":"https://api.github.com/users/kgururaj/orgs","repos_url":"https://api.github.com/users/kgururaj/repos","events_url":"https://api.github.com/users/kgururaj/events{/privacy}","received_events_url":"https://api.github.com/users/kgururaj/received_events","type":"User","site_admin":false},"body":"Just to clarify, you can consolidate fragments on HDFS, GCS etc, but since locking isn't supported, running multiple consolidation processes at the same time could cause corruption? I think that's ok as long as we tell users about this issue","created_at":"2018-06-20T20:06:00Z","updated_at":"2018-06-20T20:06:00Z","html_url":"https://github.com/Intel-HLS/TileDB/pull/73#discussion_r196924824","pull_request_url":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/73","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/comments/196924824"},"html":{"href":"https://github.com/Intel-HLS/TileDB/pull/73#discussion_r196924824"},"pull_request":{"href":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/73"}},"in_reply_to_id":196882708},"pull_request":{"url":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/73","id":187363513,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3MzYzNTEz","html_url":"https://github.com/Intel-HLS/TileDB/pull/73","diff_url":"https://github.com/Intel-HLS/TileDB/pull/73.diff","patch_url":"https://github.com/Intel-HLS/TileDB/pull/73.patch","issue_url":"https://api.github.com/repos/Intel-HLS/TileDB/issues/73","number":73,"state":"open","locked":false,"title":"Support GATK","user":{"login":"omicsdataautomation","id":35779339,"node_id":"MDQ6VXNlcjM1Nzc5MzM5","avatar_url":"https://avatars3.githubusercontent.com/u/35779339?v=4","gravatar_id":"","url":"https://api.github.com/users/omicsdataautomation","html_url":"https://github.com/omicsdataautomation","followers_url":"https://api.github.com/users/omicsdataautomation/followers","following_url":"https://api.github.com/users/omicsdataautomation/following{/other_user}","gists_url":"https://api.github.com/users/omicsdataautomation/gists{/gist_id}","starred_url":"https://api.github.com/users/omicsdataautomation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omicsdataautomation/subscriptions","organizations_url":"https://api.github.com/users/omicsdataautomation/orgs","repos_url":"https://api.github.com/users/omicsdataautomation/repos","events_url":"https://api.github.com/users/omicsdataautomation/events{/privacy}","received_events_url":"https://api.github.com/users/omicsdataautomation/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-11T04:16:08Z","updated_at":"2018-06-20T20:06:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"333671c8bb25a351882dd73371aa19a419492cce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/73/commits","review_comments_url":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/73/comments","review_comment_url":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Intel-HLS/TileDB/issues/73/comments","statuses_url":"https://api.github.com/repos/Intel-HLS/TileDB/statuses/bf3b976c083f1470da3f577aa979c9de041bd2c0","head":{"label":"omicsdataautomation:genomicsdb_req","ref":"genomicsdb_req","sha":"bf3b976c083f1470da3f577aa979c9de041bd2c0","user":{"login":"omicsdataautomation","id":35779339,"node_id":"MDQ6VXNlcjM1Nzc5MzM5","avatar_url":"https://avatars3.githubusercontent.com/u/35779339?v=4","gravatar_id":"","url":"https://api.github.com/users/omicsdataautomation","html_url":"https://github.com/omicsdataautomation","followers_url":"https://api.github.com/users/omicsdataautomation/followers","following_url":"https://api.github.com/users/omicsdataautomation/following{/other_user}","gists_url":"https://api.github.com/users/omicsdataautomation/gists{/gist_id}","starred_url":"https://api.github.com/users/omicsdataautomation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omicsdataautomation/subscriptions","organizations_url":"https://api.github.com/users/omicsdataautomation/orgs","repos_url":"https://api.github.com/users/omicsdataautomation/repos","events_url":"https://api.github.com/users/omicsdataautomation/events{/privacy}","received_events_url":"https://api.github.com/users/omicsdataautomation/received_events","type":"User","site_admin":false},"repo":{"id":118809587,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MDk1ODc=","name":"TileDB","full_name":"omicsdataautomation/TileDB","owner":{"login":"omicsdataautomation","id":35779339,"node_id":"MDQ6VXNlcjM1Nzc5MzM5","avatar_url":"https://avatars3.githubusercontent.com/u/35779339?v=4","gravatar_id":"","url":"https://api.github.com/users/omicsdataautomation","html_url":"https://github.com/omicsdataautomation","followers_url":"https://api.github.com/users/omicsdataautomation/followers","following_url":"https://api.github.com/users/omicsdataautomation/following{/other_user}","gists_url":"https://api.github.com/users/omicsdataautomation/gists{/gist_id}","starred_url":"https://api.github.com/users/omicsdataautomation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omicsdataautomation/subscriptions","organizations_url":"https://api.github.com/users/omicsdataautomation/orgs","repos_url":"https://api.github.com/users/omicsdataautomation/repos","events_url":"https://api.github.com/users/omicsdataautomation/events{/privacy}","received_events_url":"https://api.github.com/users/omicsdataautomation/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omicsdataautomation/TileDB","description":"TileDB","fork":true,"url":"https://api.github.com/repos/omicsdataautomation/TileDB","forks_url":"https://api.github.com/repos/omicsdataautomation/TileDB/forks","keys_url":"https://api.github.com/repos/omicsdataautomation/TileDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omicsdataautomation/TileDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omicsdataautomation/TileDB/teams","hooks_url":"https://api.github.com/repos/omicsdataautomation/TileDB/hooks","issue_events_url":"https://api.github.com/repos/omicsdataautomation/TileDB/issues/events{/number}","events_url":"https://api.github.com/repos/omicsdataautomation/TileDB/events","assignees_url":"https://api.github.com/repos/omicsdataautomation/TileDB/assignees{/user}","branches_url":"https://api.github.com/repos/omicsdataautomation/TileDB/branches{/branch}","tags_url":"https://api.github.com/repos/omicsdataautomation/TileDB/tags","blobs_url":"https://api.github.com/repos/omicsdataautomation/TileDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omicsdataautomation/TileDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omicsdataautomation/TileDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/omicsdataautomation/TileDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omicsdataautomation/TileDB/statuses/{sha}","languages_url":"https://api.github.com/repos/omicsdataautomation/TileDB/languages","stargazers_url":"https://api.github.com/repos/omicsdataautomation/TileDB/stargazers","contributors_url":"https://api.github.com/repos/omicsdataautomation/TileDB/contributors","subscribers_url":"https://api.github.com/repos/omicsdataautomation/TileDB/subscribers","subscription_url":"https://api.github.com/repos/omicsdataautomation/TileDB/subscription","commits_url":"https://api.github.com/repos/omicsdataautomation/TileDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/omicsdataautomation/TileDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/omicsdataautomation/TileDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/omicsdataautomation/TileDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/omicsdataautomation/TileDB/contents/{+path}","compare_url":"https://api.github.com/repos/omicsdataautomation/TileDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omicsdataautomation/TileDB/merges","archive_url":"https://api.github.com/repos/omicsdataautomation/TileDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omicsdataautomation/TileDB/downloads","issues_url":"https://api.github.com/repos/omicsdataautomation/TileDB/issues{/number}","pulls_url":"https://api.github.com/repos/omicsdataautomation/TileDB/pulls{/number}","milestones_url":"https://api.github.com/repos/omicsdataautomation/TileDB/milestones{/number}","notifications_url":"https://api.github.com/repos/omicsdataautomation/TileDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omicsdataautomation/TileDB/labels{/name}","releases_url":"https://api.github.com/repos/omicsdataautomation/TileDB/releases{/id}","deployments_url":"https://api.github.com/repos/omicsdataautomation/TileDB/deployments","created_at":"2018-01-24T19:08:56Z","updated_at":"2018-06-06T03:08:21Z","pushed_at":"2018-06-20T18:44:21Z","git_url":"git://github.com/omicsdataautomation/TileDB.git","ssh_url":"git@github.com:omicsdataautomation/TileDB.git","clone_url":"https://github.com/omicsdataautomation/TileDB.git","svn_url":"https://github.com/omicsdataautomation/TileDB","homepage":"","size":10873,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Intel-HLS:genomicsdb_req","ref":"genomicsdb_req","sha":"c25af5e5eaf7cc431f7bec20dbe941bd85b3e59a","user":{"login":"Intel-HLS","id":18174158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTc0MTU4","avatar_url":"https://avatars1.githubusercontent.com/u/18174158?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-HLS","html_url":"https://github.com/Intel-HLS","followers_url":"https://api.github.com/users/Intel-HLS/followers","following_url":"https://api.github.com/users/Intel-HLS/following{/other_user}","gists_url":"https://api.github.com/users/Intel-HLS/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-HLS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-HLS/subscriptions","organizations_url":"https://api.github.com/users/Intel-HLS/orgs","repos_url":"https://api.github.com/users/Intel-HLS/repos","events_url":"https://api.github.com/users/Intel-HLS/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-HLS/received_events","type":"Organization","site_admin":false},"repo":{"id":55086031,"node_id":"MDEwOlJlcG9zaXRvcnk1NTA4NjAzMQ==","name":"TileDB","full_name":"Intel-HLS/TileDB","owner":{"login":"Intel-HLS","id":18174158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTc0MTU4","avatar_url":"https://avatars1.githubusercontent.com/u/18174158?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-HLS","html_url":"https://github.com/Intel-HLS","followers_url":"https://api.github.com/users/Intel-HLS/followers","following_url":"https://api.github.com/users/Intel-HLS/following{/other_user}","gists_url":"https://api.github.com/users/Intel-HLS/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-HLS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-HLS/subscriptions","organizations_url":"https://api.github.com/users/Intel-HLS/orgs","repos_url":"https://api.github.com/users/Intel-HLS/repos","events_url":"https://api.github.com/users/Intel-HLS/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-HLS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Intel-HLS/TileDB","description":"TileDB","fork":false,"url":"https://api.github.com/repos/Intel-HLS/TileDB","forks_url":"https://api.github.com/repos/Intel-HLS/TileDB/forks","keys_url":"https://api.github.com/repos/Intel-HLS/TileDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Intel-HLS/TileDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Intel-HLS/TileDB/teams","hooks_url":"https://api.github.com/repos/Intel-HLS/TileDB/hooks","issue_events_url":"https://api.github.com/repos/Intel-HLS/TileDB/issues/events{/number}","events_url":"https://api.github.com/repos/Intel-HLS/TileDB/events","assignees_url":"https://api.github.com/repos/Intel-HLS/TileDB/assignees{/user}","branches_url":"https://api.github.com/repos/Intel-HLS/TileDB/branches{/branch}","tags_url":"https://api.github.com/repos/Intel-HLS/TileDB/tags","blobs_url":"https://api.github.com/repos/Intel-HLS/TileDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Intel-HLS/TileDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Intel-HLS/TileDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/Intel-HLS/TileDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Intel-HLS/TileDB/statuses/{sha}","languages_url":"https://api.github.com/repos/Intel-HLS/TileDB/languages","stargazers_url":"https://api.github.com/repos/Intel-HLS/TileDB/stargazers","contributors_url":"https://api.github.com/repos/Intel-HLS/TileDB/contributors","subscribers_url":"https://api.github.com/repos/Intel-HLS/TileDB/subscribers","subscription_url":"https://api.github.com/repos/Intel-HLS/TileDB/subscription","commits_url":"https://api.github.com/repos/Intel-HLS/TileDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/Intel-HLS/TileDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/Intel-HLS/TileDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/Intel-HLS/TileDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/Intel-HLS/TileDB/contents/{+path}","compare_url":"https://api.github.com/repos/Intel-HLS/TileDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Intel-HLS/TileDB/merges","archive_url":"https://api.github.com/repos/Intel-HLS/TileDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Intel-HLS/TileDB/downloads","issues_url":"https://api.github.com/repos/Intel-HLS/TileDB/issues{/number}","pulls_url":"https://api.github.com/repos/Intel-HLS/TileDB/pulls{/number}","milestones_url":"https://api.github.com/repos/Intel-HLS/TileDB/milestones{/number}","notifications_url":"https://api.github.com/repos/Intel-HLS/TileDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Intel-HLS/TileDB/labels{/name}","releases_url":"https://api.github.com/repos/Intel-HLS/TileDB/releases{/id}","deployments_url":"https://api.github.com/repos/Intel-HLS/TileDB/deployments","created_at":"2016-03-30T18:11:47Z","updated_at":"2018-06-14T06:34:02Z","pushed_at":"2018-06-20T18:44:23Z","git_url":"git://github.com/Intel-HLS/TileDB.git","ssh_url":"git@github.com:Intel-HLS/TileDB.git","clone_url":"https://github.com/Intel-HLS/TileDB.git","svn_url":"https://github.com/Intel-HLS/TileDB","homepage":"http://istc-bigdata.org/tiledb","size":10613,"stargazers_count":82,"watchers_count":82,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":12,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/73"},"html":{"href":"https://github.com/Intel-HLS/TileDB/pull/73"},"issue":{"href":"https://api.github.com/repos/Intel-HLS/TileDB/issues/73"},"comments":{"href":"https://api.github.com/repos/Intel-HLS/TileDB/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Intel-HLS/TileDB/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/Intel-HLS/TileDB/statuses/bf3b976c083f1470da3f577aa979c9de041bd2c0"}},"author_association":"NONE"}}
{"actor":{"display_login":"kgururaj"}}