{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11634","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11634/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11634/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11634/events","html_url":"https://github.com/bitcoin/bitcoin/pull/11634","id":272131199,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUxMzMyMzQz","number":11634,"title":"wallet: Add missing cs_wallet/cs_KeyStore locks to wallet","user":{"login":"practicalswift","id":7826565,"node_id":"MDQ6VXNlcjc4MjY1NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7826565?v=4","gravatar_id":"","url":"https://api.github.com/users/practicalswift","html_url":"https://github.com/practicalswift","followers_url":"https://api.github.com/users/practicalswift/followers","following_url":"https://api.github.com/users/practicalswift/following{/other_user}","gists_url":"https://api.github.com/users/practicalswift/gists{/gist_id}","starred_url":"https://api.github.com/users/practicalswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/practicalswift/subscriptions","organizations_url":"https://api.github.com/users/practicalswift/orgs","repos_url":"https://api.github.com/users/practicalswift/repos","events_url":"https://api.github.com/users/practicalswift/events{/privacy}","received_events_url":"https://api.github.com/users/practicalswift/received_events","type":"User","site_admin":false},"labels":[{"id":149424,"node_id":"MDU6TGFiZWwxNDk0MjQ=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Wallet","name":"Wallet","color":"08a781","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":35,"created_at":"2017-11-08T09:33:55Z","updated_at":"2018-10-24T08:35:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11634","html_url":"https://github.com/bitcoin/bitcoin/pull/11634","diff_url":"https://github.com/bitcoin/bitcoin/pull/11634.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/11634.patch"},"body":"Add missing wallet locks:\r\n\r\n* Calling the function `GetConflicts(...)` requires holding the mutex `cs_wallet`\r\n* Calling the function `IsSpent(...)` requires holding the mutex `cs_wallet`\r\n* Accessing the variables `mapKeys` and `mapCryptedKeys` requires holding the mutex `cs_KeyStore`\r\n* Accessing the variable `nTimeFirstKey` requires holding the mutex `cs_wallet`\r\n* Accessing the variable `mapWallet` requires holding the mutex `cs_wallet`\r\n* Accessing the variable `nTimeFirstKey` requires holding the mutex `cs_wallet`"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/432564655","html_url":"https://github.com/bitcoin/bitcoin/pull/11634#issuecomment-432564655","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11634","id":432564655,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjU2NDY1NQ==","user":{"login":"practicalswift","id":7826565,"node_id":"MDQ6VXNlcjc4MjY1NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7826565?v=4","gravatar_id":"","url":"https://api.github.com/users/practicalswift","html_url":"https://github.com/practicalswift","followers_url":"https://api.github.com/users/practicalswift/followers","following_url":"https://api.github.com/users/practicalswift/following{/other_user}","gists_url":"https://api.github.com/users/practicalswift/gists{/gist_id}","starred_url":"https://api.github.com/users/practicalswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/practicalswift/subscriptions","organizations_url":"https://api.github.com/users/practicalswift/orgs","repos_url":"https://api.github.com/users/practicalswift/repos","events_url":"https://api.github.com/users/practicalswift/events{/privacy}","received_events_url":"https://api.github.com/users/practicalswift/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T08:35:59Z","updated_at":"2018-10-24T08:35:59Z","author_association":"MEMBER","body":"@MarcoFalke Would you mind reviewing the updated version? :-)"}}
{"actor":{"display_login":"practicalswift"}}