{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/215458161","pull_request_review_id":152728200,"id":215458161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTQ1ODE2MQ==","diff_hunk":"@@ -265,12 +265,12 @@ class MetadataReader {\n     return start;\n   }\n \n-  /// Given a pointer to an address, attemp to read the pointed value.\n-  Optional<StoredPointer> readPointedValue(StoredPointer Address) {\n-    StoredPointer PointedVal;\n-    if (!Reader->readInteger(RemoteAddress(Address), &PointedVal))\n+  /// Given a pointer to an address, attemp to read the pointer value.","path":"include/swift/Remote/MetadataReader.h","position":8,"original_position":8,"commit_id":"8d25db681b1e746f82f3a591df081d3125854784","original_commit_id":"8d25db681b1e746f82f3a591df081d3125854784","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"While you're fixing things, you have a typo \"attemp\" here.","created_at":"2018-09-05T23:42:51Z","updated_at":"2018-09-05T23:42:51Z","html_url":"https://github.com/apple/swift/pull/19153#discussion_r215458161","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/19153","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/215458161"},"html":{"href":"https://github.com/apple/swift/pull/19153#discussion_r215458161"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/19153"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/19153","id":213455940,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDU1OTQw","html_url":"https://github.com/apple/swift/pull/19153","diff_url":"https://github.com/apple/swift/pull/19153.diff","patch_url":"https://github.com/apple/swift/pull/19153.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/19153","number":19153,"state":"open","locked":false,"title":"[MetadataReader] Rename `pointed` to `pointer` for consistency.","user":{"login":"dcci","id":5737273,"node_id":"MDQ6VXNlcjU3MzcyNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/5737273?v=4","gravatar_id":"","url":"https://api.github.com/users/dcci","html_url":"https://github.com/dcci","followers_url":"https://api.github.com/users/dcci/followers","following_url":"https://api.github.com/users/dcci/following{/other_user}","gists_url":"https://api.github.com/users/dcci/gists{/gist_id}","starred_url":"https://api.github.com/users/dcci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcci/subscriptions","organizations_url":"https://api.github.com/users/dcci/orgs","repos_url":"https://api.github.com/users/dcci/repos","events_url":"https://api.github.com/users/dcci/events{/privacy}","received_events_url":"https://api.github.com/users/dcci/received_events","type":"User","site_admin":false},"body":"Pointed out by John McCall in a previous review (I just procrastinated\r\nto do it, until today).\r\n","created_at":"2018-09-05T23:29:02Z","updated_at":"2018-09-05T23:42:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"149ae857fb9850d2b5a4c0a19371c5f24c8f690c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rjmccall","id":793869,"node_id":"MDQ6VXNlcjc5Mzg2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/793869?v=4","gravatar_id":"","url":"https://api.github.com/users/rjmccall","html_url":"https://github.com/rjmccall","followers_url":"https://api.github.com/users/rjmccall/followers","following_url":"https://api.github.com/users/rjmccall/following{/other_user}","gists_url":"https://api.github.com/users/rjmccall/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmccall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmccall/subscriptions","organizations_url":"https://api.github.com/users/rjmccall/orgs","repos_url":"https://api.github.com/users/rjmccall/repos","events_url":"https://api.github.com/users/rjmccall/events{/privacy}","received_events_url":"https://api.github.com/users/rjmccall/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/19153/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/19153/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/19153/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/8d25db681b1e746f82f3a591df081d3125854784","head":{"label":"dcci:pointer-pointed","ref":"pointer-pointed","sha":"8d25db681b1e746f82f3a591df081d3125854784","user":{"login":"dcci","id":5737273,"node_id":"MDQ6VXNlcjU3MzcyNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/5737273?v=4","gravatar_id":"","url":"https://api.github.com/users/dcci","html_url":"https://github.com/dcci","followers_url":"https://api.github.com/users/dcci/followers","following_url":"https://api.github.com/users/dcci/following{/other_user}","gists_url":"https://api.github.com/users/dcci/gists{/gist_id}","starred_url":"https://api.github.com/users/dcci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcci/subscriptions","organizations_url":"https://api.github.com/users/dcci/orgs","repos_url":"https://api.github.com/users/dcci/repos","events_url":"https://api.github.com/users/dcci/events{/privacy}","received_events_url":"https://api.github.com/users/dcci/received_events","type":"User","site_admin":false},"repo":{"id":101579883,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE1Nzk4ODM=","name":"swift","full_name":"dcci/swift","owner":{"login":"dcci","id":5737273,"node_id":"MDQ6VXNlcjU3MzcyNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/5737273?v=4","gravatar_id":"","url":"https://api.github.com/users/dcci","html_url":"https://github.com/dcci","followers_url":"https://api.github.com/users/dcci/followers","following_url":"https://api.github.com/users/dcci/following{/other_user}","gists_url":"https://api.github.com/users/dcci/gists{/gist_id}","starred_url":"https://api.github.com/users/dcci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcci/subscriptions","organizations_url":"https://api.github.com/users/dcci/orgs","repos_url":"https://api.github.com/users/dcci/repos","events_url":"https://api.github.com/users/dcci/events{/privacy}","received_events_url":"https://api.github.com/users/dcci/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcci/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/dcci/swift","forks_url":"https://api.github.com/repos/dcci/swift/forks","keys_url":"https://api.github.com/repos/dcci/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcci/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcci/swift/teams","hooks_url":"https://api.github.com/repos/dcci/swift/hooks","issue_events_url":"https://api.github.com/repos/dcci/swift/issues/events{/number}","events_url":"https://api.github.com/repos/dcci/swift/events","assignees_url":"https://api.github.com/repos/dcci/swift/assignees{/user}","branches_url":"https://api.github.com/repos/dcci/swift/branches{/branch}","tags_url":"https://api.github.com/repos/dcci/swift/tags","blobs_url":"https://api.github.com/repos/dcci/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcci/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcci/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcci/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcci/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/dcci/swift/languages","stargazers_url":"https://api.github.com/repos/dcci/swift/stargazers","contributors_url":"https://api.github.com/repos/dcci/swift/contributors","subscribers_url":"https://api.github.com/repos/dcci/swift/subscribers","subscription_url":"https://api.github.com/repos/dcci/swift/subscription","commits_url":"https://api.github.com/repos/dcci/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcci/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcci/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcci/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcci/swift/contents/{+path}","compare_url":"https://api.github.com/repos/dcci/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcci/swift/merges","archive_url":"https://api.github.com/repos/dcci/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcci/swift/downloads","issues_url":"https://api.github.com/repos/dcci/swift/issues{/number}","pulls_url":"https://api.github.com/repos/dcci/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/dcci/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/dcci/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcci/swift/labels{/name}","releases_url":"https://api.github.com/repos/dcci/swift/releases{/id}","deployments_url":"https://api.github.com/repos/dcci/swift/deployments","created_at":"2017-08-27T20:59:04Z","updated_at":"2018-03-27T18:04:43Z","pushed_at":"2018-09-05T23:28:44Z","git_url":"git://github.com/dcci/swift.git","ssh_url":"git@github.com:dcci/swift.git","clone_url":"https://github.com/dcci/swift.git","svn_url":"https://github.com/dcci/swift","homepage":"https://swift.org/","size":324834,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"e81fc0d90ab453049ea0e3de1734d840081258c7","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-09-05T23:33:48Z","pushed_at":"2018-09-05T23:32:30Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":336764,"stargazers_count":45093,"watchers_count":45093,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7110,"mirror_url":null,"archived":false,"open_issues_count":383,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7110,"open_issues":383,"watchers":45093,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/19153"},"html":{"href":"https://github.com/apple/swift/pull/19153"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/19153"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/19153/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/19153/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/19153/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/8d25db681b1e746f82f3a591df081d3125854784"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jrose-apple"}}