{"action":"closed","issue":{"url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/24","repository_url":"https://api.github.com/repos/sourcegraph/sourcegraph","labels_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/24/comments","events_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/24/events","html_url":"https://github.com/sourcegraph/sourcegraph/issues/24","id":250741428,"node_id":"MDU6SXNzdWUyNTA3NDE0Mjg=","number":24,"title":"Cross-repo jump to def to file removed in master fails (kubernetes)","user":{"login":"beyang","id":1646931,"node_id":"MDQ6VXNlcjE2NDY5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1646931?v=4","gravatar_id":"","url":"https://api.github.com/users/beyang","html_url":"https://github.com/beyang","followers_url":"https://api.github.com/users/beyang/followers","following_url":"https://api.github.com/users/beyang/following{/other_user}","gists_url":"https://api.github.com/users/beyang/gists{/gist_id}","starred_url":"https://api.github.com/users/beyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beyang/subscriptions","organizations_url":"https://api.github.com/users/beyang/orgs","repos_url":"https://api.github.com/users/beyang/repos","events_url":"https://api.github.com/users/beyang/events{/privacy}","received_events_url":"https://api.github.com/users/beyang/received_events","type":"User","site_admin":false},"labels":[{"id":634723825,"node_id":"MDU6TGFiZWw2MzQ3MjM4MjU=","url":"https://api.github.com/repos/sourcegraph/sourcegraph/labels/bug","name":"bug","color":"b60205","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-08-16T19:56:55Z","updated_at":"2018-10-25T09:51:42Z","closed_at":"2018-10-25T09:51:42Z","author_association":"MEMBER","body":"Jump to def on `[s.Create]`https://sourcegraph.com/github.com/kubernetes/kubernetes@6430b1002c2900a1761cbd07cb77a1e4cf82b64e/-/blob/pkg/registry/extensions/deployment/registry.go#L69:16-69:22 breaks with `Unable to open 'rest.go': open server/pkg/registry/rest/rest.go: file does not exist.` error.\r\n\r\n~The file that we're attempting to jump to was removed in https://github.com/kubernetes/api/commit/ab8ef47cb141bc2c8fef662a179c948d53956ec4, and currently we don't take into the version information when performing a cross-repository jump-to-def.~\r\n\r\nThe reason this isn't taking into account version information is that we need to support symbolic links in our VFS. k8s.io/apiserver/pkg/registry/rest is vendored in, but in a weird way via a symbolic link https://sourcegraph.com/github.com/kubernetes/kubernetes@6430b1002c2900a1761cbd07cb77a1e4cf82b64e/-/blob/vendor/k8s.io/apiserver (via @keegancsmith)\r\n\r\n(HT @ahmetb)"}}
{"actor":{"display_login":"sqs"}}