{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/comments/227637442","pull_request_review_id":167724070,"id":227637442,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzYzNzQ0Mg==","diff_hunk":"@@ -5,12 +5,13 @@ import * as os from 'os';\n import * as path from 'path';\n \n let osPlat: string = os.platform();\n-let osArch: string = os.arch();\n+let architecture: string;","path":"Tasks/NodeToolV0/nodetool.ts","position":null,"original_position":5,"commit_id":"3c480d422a52fa5d2b87d3b67e56f3d9604fb87b","original_commit_id":"ace9ac1b0f04e9c223b667b1305d554014ad719e","user":{"login":"nschonni","id":1297909,"node_id":"MDQ6VXNlcjEyOTc5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1297909?v=4","gravatar_id":"","url":"https://api.github.com/users/nschonni","html_url":"https://github.com/nschonni","followers_url":"https://api.github.com/users/nschonni/followers","following_url":"https://api.github.com/users/nschonni/following{/other_user}","gists_url":"https://api.github.com/users/nschonni/gists{/gist_id}","starred_url":"https://api.github.com/users/nschonni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nschonni/subscriptions","organizations_url":"https://api.github.com/users/nschonni/orgs","repos_url":"https://api.github.com/users/nschonni/repos","events_url":"https://api.github.com/users/nschonni/events{/privacy}","received_events_url":"https://api.github.com/users/nschonni/received_events","type":"User","site_admin":false},"body":"OK, it's your project","created_at":"2018-10-24T04:13:49Z","updated_at":"2018-10-24T04:13:49Z","html_url":"https://github.com/Microsoft/azure-pipelines-tasks/pull/8688#discussion_r227637442","pull_request_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/8688","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/comments/227637442"},"html":{"href":"https://github.com/Microsoft/azure-pipelines-tasks/pull/8688#discussion_r227637442"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/8688"}},"in_reply_to_id":227630617},"pull_request":{"url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/8688","id":225249758,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjQ5NzU4","html_url":"https://github.com/Microsoft/azure-pipelines-tasks/pull/8688","diff_url":"https://github.com/Microsoft/azure-pipelines-tasks/pull/8688.diff","patch_url":"https://github.com/Microsoft/azure-pipelines-tasks/pull/8688.patch","issue_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/issues/8688","number":8688,"state":"open","locked":false,"title":"feat: Support selecting Node architecture","user":{"login":"nschonni","id":1297909,"node_id":"MDQ6VXNlcjEyOTc5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1297909?v=4","gravatar_id":"","url":"https://api.github.com/users/nschonni","html_url":"https://github.com/nschonni","followers_url":"https://api.github.com/users/nschonni/followers","following_url":"https://api.github.com/users/nschonni/following{/other_user}","gists_url":"https://api.github.com/users/nschonni/gists{/gist_id}","starred_url":"https://api.github.com/users/nschonni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nschonni/subscriptions","organizations_url":"https://api.github.com/users/nschonni/orgs","repos_url":"https://api.github.com/users/nschonni/repos","events_url":"https://api.github.com/users/nschonni/events{/privacy}","received_events_url":"https://api.github.com/users/nschonni/received_events","type":"User","site_admin":false},"body":"This is a quick pass at #6671 just to get the ball rolling again.\r\n\r\nThis is missing:\r\n- [ ] Localization\r\n- [ ] This ignores ARM builds. Probably better to keep the default as \"\" and use os.arch if it isn't set\r\n- [ ] x86 isn't supported on Linux for 10+\r\n\r\nI just eyeballed the `UsePython` task and tried to apply it's basic pattern to this task.","created_at":"2018-10-24T03:01:55Z","updated_at":"2018-10-24T04:13:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c7823086d0ccb4a689952ade73a06dad6c91261","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/8688/commits","review_comments_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/8688/comments","review_comment_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/issues/8688/comments","statuses_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/statuses/3c480d422a52fa5d2b87d3b67e56f3d9604fb87b","head":{"label":"nschonni:node-architecture-input","ref":"node-architecture-input","sha":"3c480d422a52fa5d2b87d3b67e56f3d9604fb87b","user":{"login":"nschonni","id":1297909,"node_id":"MDQ6VXNlcjEyOTc5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1297909?v=4","gravatar_id":"","url":"https://api.github.com/users/nschonni","html_url":"https://github.com/nschonni","followers_url":"https://api.github.com/users/nschonni/followers","following_url":"https://api.github.com/users/nschonni/following{/other_user}","gists_url":"https://api.github.com/users/nschonni/gists{/gist_id}","starred_url":"https://api.github.com/users/nschonni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nschonni/subscriptions","organizations_url":"https://api.github.com/users/nschonni/orgs","repos_url":"https://api.github.com/users/nschonni/repos","events_url":"https://api.github.com/users/nschonni/events{/privacy}","received_events_url":"https://api.github.com/users/nschonni/received_events","type":"User","site_admin":false},"repo":{"id":96808474,"node_id":"MDEwOlJlcG9zaXRvcnk5NjgwODQ3NA==","name":"azure-pipelines-tasks","full_name":"nschonni/azure-pipelines-tasks","private":false,"owner":{"login":"nschonni","id":1297909,"node_id":"MDQ6VXNlcjEyOTc5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1297909?v=4","gravatar_id":"","url":"https://api.github.com/users/nschonni","html_url":"https://github.com/nschonni","followers_url":"https://api.github.com/users/nschonni/followers","following_url":"https://api.github.com/users/nschonni/following{/other_user}","gists_url":"https://api.github.com/users/nschonni/gists{/gist_id}","starred_url":"https://api.github.com/users/nschonni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nschonni/subscriptions","organizations_url":"https://api.github.com/users/nschonni/orgs","repos_url":"https://api.github.com/users/nschonni/repos","events_url":"https://api.github.com/users/nschonni/events{/privacy}","received_events_url":"https://api.github.com/users/nschonni/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nschonni/azure-pipelines-tasks","description":"Build and Release Tasks for Visual Studio Team Services and Team Foundation Server","fork":true,"url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks","forks_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/forks","keys_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/teams","hooks_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/hooks","issue_events_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/events","assignees_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/tags","blobs_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/languages","stargazers_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/stargazers","contributors_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/contributors","subscribers_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/subscribers","subscription_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/subscription","commits_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/merges","archive_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/downloads","issues_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/labels{/name}","releases_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/nschonni/azure-pipelines-tasks/deployments","created_at":"2017-07-10T18:22:33Z","updated_at":"2018-10-24T02:31:45Z","pushed_at":"2018-10-24T04:13:35Z","git_url":"git://github.com/nschonni/azure-pipelines-tasks.git","ssh_url":"git@github.com:nschonni/azure-pipelines-tasks.git","clone_url":"https://github.com/nschonni/azure-pipelines-tasks.git","svn_url":"https://github.com/nschonni/azure-pipelines-tasks","homepage":"https://aka.ms/tfbuild","size":45595,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"7852f69e77ac2f0b776082d63cc23cb171ef9979","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"node_id":"MDEwOlJlcG9zaXRvcnkyNzYzMTY3Mw==","name":"azure-pipelines-tasks","full_name":"Microsoft/azure-pipelines-tasks","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/azure-pipelines-tasks","description":"Tasks for Azure Pipelines","fork":false,"url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks","forks_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/forks","keys_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/teams","hooks_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/events","assignees_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/tags","blobs_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/languages","stargazers_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/subscription","commits_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/merges","archive_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/downloads","issues_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2018-10-23T23:45:01Z","pushed_at":"2018-10-24T04:13:38Z","git_url":"git://github.com/Microsoft/azure-pipelines-tasks.git","ssh_url":"git@github.com:Microsoft/azure-pipelines-tasks.git","clone_url":"https://github.com/Microsoft/azure-pipelines-tasks.git","svn_url":"https://github.com/Microsoft/azure-pipelines-tasks","homepage":"https://aka.ms/tfbuild","size":396603,"stargazers_count":1079,"watchers_count":1079,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":914,"mirror_url":null,"archived":false,"open_issues_count":501,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":914,"open_issues":501,"watchers":1079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/8688"},"html":{"href":"https://github.com/Microsoft/azure-pipelines-tasks/pull/8688"},"issue":{"href":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/issues/8688"},"comments":{"href":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/issues/8688/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/8688/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/pulls/8688/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/azure-pipelines-tasks/statuses/3c480d422a52fa5d2b87d3b67e56f3d9604fb87b"}},"author_association":"NONE"}}
{"actor":{"display_login":"nschonni"}}