{"action":"created","comment":{"url":"https://api.github.com/repos/openebs/elves/pulls/comments/195225487","pull_request_review_id":128546267,"id":195225487,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTIyNTQ4Nw==","diff_hunk":"@@ -0,0 +1,72 @@\n+# The deployment for cstor-pool and cstor-pool-mgmt.\n+\n+apiVersion: apps/v1\n+kind: Deployment\n+metadata:\n+  name: cstor-pool\n+  labels:\n+    app: cstor-pool\n+spec:\n+  replicas: 1\n+  selector:\n+    matchLabels:\n+      app: cstor-pool\n+  template:\n+    metadata:\n+      labels:\n+        app: cstor-pool\n+    spec:\n+      containers:\n+      - name: cstor-pool\n+#The image name here will be changed to openebs once the business logic pr is reviewed and merged in openebs/maya.\n+        image: gkganeshr/cstor-pool:v1.1\n+        ports:\n+        - containerPort: 80\n+        securityContext: \n+          privileged: true\n+\n+        volumeMounts:\n+        - name: device\n+          mountPath: /dev     \n+        - name: tmp\n+          mountPath: /tmp\n+#To avoid clash between terminating and restarting pod, we keep initial delay.\n+        lifecycle:\n+          postStart:\n+            exec:\n+              command: [\"/bin/sh\", \"-c\", \"sleep 15\"]\n+\n+      - name:    cstor-pool-mgmt\n+#The image name here will be changed to openebs once the business logic pr is reviewed and merged in openebs/maya.\n+        image: gkganeshr/cstor-pool-mgmt:v1.8\n+        ports:\n+        - containerPort: 80\n+        securityContext: \n+          privileged: true\n+        volumeMounts:\n+        - name: device\n+          mountPath: /dev\n+        - name: tmp\n+          mountPath: /tmp\n+        env:\n+          #cstorid env has UID of cStorPool CR\n+        - name: cstorid\n+          value: \"f774f4dd-68a8-11e8-84c7-54e1ad4a9dd4\"\n+#To avoid clash between terminating and restarting pod, we keep initial delay.\n+        lifecycle:\n+          postStart:\n+            exec:\n+              command: [\"/bin/sh\", \"-c\", \"sleep 15\"]\n+\n+      volumes:\n+      - name: device\n+        hostPath:\n+          # directory location on host\n+          path: /dev\n+          # this field is optional\n+          type: Directory\n+      - name: tmp\n+        hostPath:\n+#From host, dir called /var/openebs/shared-<uid> is created to avoid clash if two replicas run on same node.\n+          path: /var/openebs/shared-a2b\n+          type: Directory","path":"k8s-dev/cstor-pool-mgmt/deployment-cstor-pool.yaml","position":72,"original_position":72,"commit_id":"47c34f2780c9923163c42adc961faae7fc7ed418","original_commit_id":"47c34f2780c9923163c42adc961faae7fc7ed418","user":{"login":"jkryl","id":5690145,"node_id":"MDQ6VXNlcjU2OTAxNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5690145?v=4","gravatar_id":"","url":"https://api.github.com/users/jkryl","html_url":"https://github.com/jkryl","followers_url":"https://api.github.com/users/jkryl/followers","following_url":"https://api.github.com/users/jkryl/following{/other_user}","gists_url":"https://api.github.com/users/jkryl/gists{/gist_id}","starred_url":"https://api.github.com/users/jkryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkryl/subscriptions","organizations_url":"https://api.github.com/users/jkryl/orgs","repos_url":"https://api.github.com/users/jkryl/repos","events_url":"https://api.github.com/users/jkryl/events{/privacy}","received_events_url":"https://api.github.com/users/jkryl/received_events","type":"User","site_admin":false},"body":"do we have an idea how container's /tmp dir will be regularly cleaned? As the container will be storing crash dumps to this directory, it may grow out of bounds in case of repeating crash very quickly. I quite liked Docker's EmptyDir which is cleaned always when the container shuts down unless the container crashed. However this strategy might not be available in k8s or maybe is too aggressive, just a thought.","created_at":"2018-06-13T20:30:59Z","updated_at":"2018-06-13T20:31:15Z","html_url":"https://github.com/openebs/elves/pull/41#discussion_r195225487","pull_request_url":"https://api.github.com/repos/openebs/elves/pulls/41","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openebs/elves/pulls/comments/195225487"},"html":{"href":"https://github.com/openebs/elves/pull/41#discussion_r195225487"},"pull_request":{"href":"https://api.github.com/repos/openebs/elves/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/openebs/elves/pulls/41","id":194194837,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTk0ODM3","html_url":"https://github.com/openebs/elves/pull/41","diff_url":"https://github.com/openebs/elves/pull/41.diff","patch_url":"https://github.com/openebs/elves/pull/41.patch","issue_url":"https://api.github.com/repos/openebs/elves/issues/41","number":41,"state":"open","locked":false,"title":"Upload yaml files for cstor-pool-mgmt","user":{"login":"gkGaneshR","id":14148430,"node_id":"MDQ6VXNlcjE0MTQ4NDMw","avatar_url":"https://avatars3.githubusercontent.com/u/14148430?v=4","gravatar_id":"","url":"https://api.github.com/users/gkGaneshR","html_url":"https://github.com/gkGaneshR","followers_url":"https://api.github.com/users/gkGaneshR/followers","following_url":"https://api.github.com/users/gkGaneshR/following{/other_user}","gists_url":"https://api.github.com/users/gkGaneshR/gists{/gist_id}","starred_url":"https://api.github.com/users/gkGaneshR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkGaneshR/subscriptions","organizations_url":"https://api.github.com/users/gkGaneshR/orgs","repos_url":"https://api.github.com/users/gkGaneshR/repos","events_url":"https://api.github.com/users/gkGaneshR/events{/privacy}","received_events_url":"https://api.github.com/users/gkGaneshR/received_events","type":"User","site_admin":false},"body":"Why is this change necessary ?\r\nfixes: openebs/openebs#1539, openebs/openebs#1605\r\n\r\nHow does this change address the issue ?\r\nThe initial version of cstor-pool deployment and custom resource yaml\r\nis updated.\r\n\r\nHow to verify this change ?\r\nMake sure /var/openebs/shared-<uid> dir is present in deploy yaml.\r\nkubectl apply -f pool-resource-cluster-1.yaml(with init status)\r\nGet UID of the corresponding pool\r\nMake sure the same UID is passed as env variable to deployment yaml.\r\nMake sure the disk specified on CR is present\r\nkubectl apply -f deployment-cstor-pool.yaml\r\nTo verify,\r\nkubectl logs cstor-pool-deploy- -c cstor-pool-mgmt\r\nCan also verify by kubectl exec into pod,\r\nCheck status of CR if it is online for successful pool creation,\r\noffline for failure.\r\nTo delete,\r\nkubectl delete -f pool-resource-cluster-1.yaml\r\nIf successful deletion,\r\nCR is deleted, Can also verify from zpool status by kubectl exec into pod\r\nIf deletion is failed,\r\ncstorpool Status field shows deletion-failed.\r\n\r\nkubectl apply -f replica-resource-1.yaml (specifying UID from cstorvolume CR)\r\nCheck pod logs and kubectl describe cvr <cvrname>\r\nAlso verify status.\r\n\r\nSpecial notes for your reviewer: The image name here will be changed to openebs once the business logic pr is raised, reviewed and merged in openebs/maya.\r\nStatus should always be init to create pool.\r\nThis is developed and verified on minikube and gke environment.\r\nStart k8s cluster like this,\r\n\r\nReference: https://docs.google.com/document/d/1Q5W3uHktHa-vOm8oGp-3kpAQ3V1tvyk5AYmxxtf57Rg/edit?usp=sharing\r\n\r\nSigned-off-by: gkGaneshR <gkganesh126@gmail.com>","created_at":"2018-06-12T07:55:40Z","updated_at":"2018-06-13T20:31:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52dc0bb9a38840c6a31030132f79abd3472c1a0e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openebs/elves/pulls/41/commits","review_comments_url":"https://api.github.com/repos/openebs/elves/pulls/41/comments","review_comment_url":"https://api.github.com/repos/openebs/elves/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openebs/elves/issues/41/comments","statuses_url":"https://api.github.com/repos/openebs/elves/statuses/47c34f2780c9923163c42adc961faae7fc7ed418","head":{"label":"gkGaneshR:cstor-yaml","ref":"cstor-yaml","sha":"47c34f2780c9923163c42adc961faae7fc7ed418","user":{"login":"gkGaneshR","id":14148430,"node_id":"MDQ6VXNlcjE0MTQ4NDMw","avatar_url":"https://avatars3.githubusercontent.com/u/14148430?v=4","gravatar_id":"","url":"https://api.github.com/users/gkGaneshR","html_url":"https://github.com/gkGaneshR","followers_url":"https://api.github.com/users/gkGaneshR/followers","following_url":"https://api.github.com/users/gkGaneshR/following{/other_user}","gists_url":"https://api.github.com/users/gkGaneshR/gists{/gist_id}","starred_url":"https://api.github.com/users/gkGaneshR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkGaneshR/subscriptions","organizations_url":"https://api.github.com/users/gkGaneshR/orgs","repos_url":"https://api.github.com/users/gkGaneshR/repos","events_url":"https://api.github.com/users/gkGaneshR/events{/privacy}","received_events_url":"https://api.github.com/users/gkGaneshR/received_events","type":"User","site_admin":false},"repo":{"id":106312149,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzMTIxNDk=","name":"elves","full_name":"gkGaneshR/elves","owner":{"login":"gkGaneshR","id":14148430,"node_id":"MDQ6VXNlcjE0MTQ4NDMw","avatar_url":"https://avatars3.githubusercontent.com/u/14148430?v=4","gravatar_id":"","url":"https://api.github.com/users/gkGaneshR","html_url":"https://github.com/gkGaneshR","followers_url":"https://api.github.com/users/gkGaneshR/followers","following_url":"https://api.github.com/users/gkGaneshR/following{/other_user}","gists_url":"https://api.github.com/users/gkGaneshR/gists{/gist_id}","starred_url":"https://api.github.com/users/gkGaneshR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkGaneshR/subscriptions","organizations_url":"https://api.github.com/users/gkGaneshR/orgs","repos_url":"https://api.github.com/users/gkGaneshR/repos","events_url":"https://api.github.com/users/gkGaneshR/events{/privacy}","received_events_url":"https://api.github.com/users/gkGaneshR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkGaneshR/elves","description":"Helpers of OpenEBS","fork":true,"url":"https://api.github.com/repos/gkGaneshR/elves","forks_url":"https://api.github.com/repos/gkGaneshR/elves/forks","keys_url":"https://api.github.com/repos/gkGaneshR/elves/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkGaneshR/elves/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkGaneshR/elves/teams","hooks_url":"https://api.github.com/repos/gkGaneshR/elves/hooks","issue_events_url":"https://api.github.com/repos/gkGaneshR/elves/issues/events{/number}","events_url":"https://api.github.com/repos/gkGaneshR/elves/events","assignees_url":"https://api.github.com/repos/gkGaneshR/elves/assignees{/user}","branches_url":"https://api.github.com/repos/gkGaneshR/elves/branches{/branch}","tags_url":"https://api.github.com/repos/gkGaneshR/elves/tags","blobs_url":"https://api.github.com/repos/gkGaneshR/elves/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkGaneshR/elves/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkGaneshR/elves/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkGaneshR/elves/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkGaneshR/elves/statuses/{sha}","languages_url":"https://api.github.com/repos/gkGaneshR/elves/languages","stargazers_url":"https://api.github.com/repos/gkGaneshR/elves/stargazers","contributors_url":"https://api.github.com/repos/gkGaneshR/elves/contributors","subscribers_url":"https://api.github.com/repos/gkGaneshR/elves/subscribers","subscription_url":"https://api.github.com/repos/gkGaneshR/elves/subscription","commits_url":"https://api.github.com/repos/gkGaneshR/elves/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkGaneshR/elves/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkGaneshR/elves/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkGaneshR/elves/issues/comments{/number}","contents_url":"https://api.github.com/repos/gkGaneshR/elves/contents/{+path}","compare_url":"https://api.github.com/repos/gkGaneshR/elves/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkGaneshR/elves/merges","archive_url":"https://api.github.com/repos/gkGaneshR/elves/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkGaneshR/elves/downloads","issues_url":"https://api.github.com/repos/gkGaneshR/elves/issues{/number}","pulls_url":"https://api.github.com/repos/gkGaneshR/elves/pulls{/number}","milestones_url":"https://api.github.com/repos/gkGaneshR/elves/milestones{/number}","notifications_url":"https://api.github.com/repos/gkGaneshR/elves/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkGaneshR/elves/labels{/name}","releases_url":"https://api.github.com/repos/gkGaneshR/elves/releases{/id}","deployments_url":"https://api.github.com/repos/gkGaneshR/elves/deployments","created_at":"2017-10-09T17:11:33Z","updated_at":"2017-10-09T17:11:38Z","pushed_at":"2018-06-12T07:54:42Z","git_url":"git://github.com/gkGaneshR/elves.git","ssh_url":"git@github.com:gkGaneshR/elves.git","clone_url":"https://github.com/gkGaneshR/elves.git","svn_url":"https://github.com/gkGaneshR/elves","homepage":"","size":42293,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openebs:master","ref":"master","sha":"b94f029d7bb87f82fd291b48d0ed9b42c581a52a","user":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"repo":{"id":73371469,"node_id":"MDEwOlJlcG9zaXRvcnk3MzM3MTQ2OQ==","name":"elves","full_name":"openebs/elves","owner":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openebs/elves","description":"Helpers of OpenEBS","fork":false,"url":"https://api.github.com/repos/openebs/elves","forks_url":"https://api.github.com/repos/openebs/elves/forks","keys_url":"https://api.github.com/repos/openebs/elves/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openebs/elves/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openebs/elves/teams","hooks_url":"https://api.github.com/repos/openebs/elves/hooks","issue_events_url":"https://api.github.com/repos/openebs/elves/issues/events{/number}","events_url":"https://api.github.com/repos/openebs/elves/events","assignees_url":"https://api.github.com/repos/openebs/elves/assignees{/user}","branches_url":"https://api.github.com/repos/openebs/elves/branches{/branch}","tags_url":"https://api.github.com/repos/openebs/elves/tags","blobs_url":"https://api.github.com/repos/openebs/elves/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openebs/elves/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openebs/elves/git/refs{/sha}","trees_url":"https://api.github.com/repos/openebs/elves/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openebs/elves/statuses/{sha}","languages_url":"https://api.github.com/repos/openebs/elves/languages","stargazers_url":"https://api.github.com/repos/openebs/elves/stargazers","contributors_url":"https://api.github.com/repos/openebs/elves/contributors","subscribers_url":"https://api.github.com/repos/openebs/elves/subscribers","subscription_url":"https://api.github.com/repos/openebs/elves/subscription","commits_url":"https://api.github.com/repos/openebs/elves/commits{/sha}","git_commits_url":"https://api.github.com/repos/openebs/elves/git/commits{/sha}","comments_url":"https://api.github.com/repos/openebs/elves/comments{/number}","issue_comment_url":"https://api.github.com/repos/openebs/elves/issues/comments{/number}","contents_url":"https://api.github.com/repos/openebs/elves/contents/{+path}","compare_url":"https://api.github.com/repos/openebs/elves/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openebs/elves/merges","archive_url":"https://api.github.com/repos/openebs/elves/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openebs/elves/downloads","issues_url":"https://api.github.com/repos/openebs/elves/issues{/number}","pulls_url":"https://api.github.com/repos/openebs/elves/pulls{/number}","milestones_url":"https://api.github.com/repos/openebs/elves/milestones{/number}","notifications_url":"https://api.github.com/repos/openebs/elves/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openebs/elves/labels{/name}","releases_url":"https://api.github.com/repos/openebs/elves/releases{/id}","deployments_url":"https://api.github.com/repos/openebs/elves/deployments","created_at":"2016-11-10T10:28:02Z","updated_at":"2018-06-13T17:59:14Z","pushed_at":"2018-06-13T15:50:32Z","git_url":"git://github.com/openebs/elves.git","ssh_url":"git@github.com:openebs/elves.git","clone_url":"https://github.com/openebs/elves.git","svn_url":"https://github.com/openebs/elves","homepage":"","size":42304,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":16,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openebs/elves/pulls/41"},"html":{"href":"https://github.com/openebs/elves/pull/41"},"issue":{"href":"https://api.github.com/repos/openebs/elves/issues/41"},"comments":{"href":"https://api.github.com/repos/openebs/elves/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/openebs/elves/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/openebs/elves/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openebs/elves/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/openebs/elves/statuses/47c34f2780c9923163c42adc961faae7fc7ed418"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jkryl"}}