{"action":"created","comment":{"url":"https://api.github.com/repos/buildkite/agent/pulls/comments/177946753","pull_request_review_id":107917434,"id":177946753,"diff_hunk":"@@ -315,8 +321,8 @@ var AgentStartCommand = cli.Command{\n \t\t\tcfg.BootstrapScript = fmt.Sprintf(\"%s bootstrap\", shellwords.Quote(os.Args[0]))\n \t\t}\n \n-\t\t// Turning off command eval will also turn off plugins.\n-\t\tif cfg.NoCommandEval {\n+\t\t// Turning off command eval or local hooks will also turn off plugins.\n+\t\tif cfg.NoCommandEval || cfg.NoLocalHooks {","path":"clicommand/agent_start.go","position":27,"original_position":27,"commit_id":"a2331bbbc2f4a24f66c761c0c9e21cfdaf907815","original_commit_id":"a2331bbbc2f4a24f66c761c0c9e21cfdaf907815","user":{"login":"keithpitt","id":25882,"avatar_url":"https://avatars2.githubusercontent.com/u/25882?v=4","gravatar_id":"","url":"https://api.github.com/users/keithpitt","html_url":"https://github.com/keithpitt","followers_url":"https://api.github.com/users/keithpitt/followers","following_url":"https://api.github.com/users/keithpitt/following{/other_user}","gists_url":"https://api.github.com/users/keithpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/keithpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithpitt/subscriptions","organizations_url":"https://api.github.com/users/keithpitt/orgs","repos_url":"https://api.github.com/users/keithpitt/repos","events_url":"https://api.github.com/users/keithpitt/events{/privacy}","received_events_url":"https://api.github.com/users/keithpitt/received_events","type":"User","site_admin":false},"body":"Ok, spoke about on video with @lox. If you consider plugins to be \"3rd party local hooks\" then this makes total sense...!","created_at":"2018-03-29T03:40:44Z","updated_at":"2018-03-29T03:40:44Z","html_url":"https://github.com/buildkite/agent/pull/707#discussion_r177946753","pull_request_url":"https://api.github.com/repos/buildkite/agent/pulls/707","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/buildkite/agent/pulls/comments/177946753"},"html":{"href":"https://github.com/buildkite/agent/pull/707#discussion_r177946753"},"pull_request":{"href":"https://api.github.com/repos/buildkite/agent/pulls/707"}},"in_reply_to_id":177935048},"pull_request":{"url":"https://api.github.com/repos/buildkite/agent/pulls/707","id":178200184,"html_url":"https://github.com/buildkite/agent/pull/707","diff_url":"https://github.com/buildkite/agent/pull/707.diff","patch_url":"https://github.com/buildkite/agent/pull/707.patch","issue_url":"https://api.github.com/repos/buildkite/agent/issues/707","number":707,"state":"open","locked":false,"title":"Add an agent config for no-local-hooks","user":{"login":"lox","id":15758,"avatar_url":"https://avatars1.githubusercontent.com/u/15758?v=4","gravatar_id":"","url":"https://api.github.com/users/lox","html_url":"https://github.com/lox","followers_url":"https://api.github.com/users/lox/followers","following_url":"https://api.github.com/users/lox/following{/other_user}","gists_url":"https://api.github.com/users/lox/gists{/gist_id}","starred_url":"https://api.github.com/users/lox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lox/subscriptions","organizations_url":"https://api.github.com/users/lox/orgs","repos_url":"https://api.github.com/users/lox/repos","events_url":"https://api.github.com/users/lox/events{/privacy}","received_events_url":"https://api.github.com/users/lox/received_events","type":"User","site_admin":false},"body":"This adds a `no-local-hooks` config for the agent. Global hooks can still set `BUILDKITE_NO_LOCAL_HOOKS` on a case-by-case basis.","created_at":"2018-03-29T00:36:39Z","updated_at":"2018-03-29T03:40:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"717c4b44da0f7fc3454464e6b32cf07f0132cf44","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/buildkite/agent/pulls/707/commits","review_comments_url":"https://api.github.com/repos/buildkite/agent/pulls/707/comments","review_comment_url":"https://api.github.com/repos/buildkite/agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildkite/agent/issues/707/comments","statuses_url":"https://api.github.com/repos/buildkite/agent/statuses/a2331bbbc2f4a24f66c761c0c9e21cfdaf907815","head":{"label":"buildkite:add-no-local-hooks-as-agent-config","ref":"add-no-local-hooks-as-agent-config","sha":"a2331bbbc2f4a24f66c761c0c9e21cfdaf907815","user":{"login":"buildkite","id":5055988,"avatar_url":"https://avatars1.githubusercontent.com/u/5055988?v=4","gravatar_id":"","url":"https://api.github.com/users/buildkite","html_url":"https://github.com/buildkite","followers_url":"https://api.github.com/users/buildkite/followers","following_url":"https://api.github.com/users/buildkite/following{/other_user}","gists_url":"https://api.github.com/users/buildkite/gists{/gist_id}","starred_url":"https://api.github.com/users/buildkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildkite/subscriptions","organizations_url":"https://api.github.com/users/buildkite/orgs","repos_url":"https://api.github.com/users/buildkite/repos","events_url":"https://api.github.com/users/buildkite/events{/privacy}","received_events_url":"https://api.github.com/users/buildkite/received_events","type":"Organization","site_admin":false},"repo":{"id":16347164,"name":"agent","full_name":"buildkite/agent","owner":{"login":"buildkite","id":5055988,"avatar_url":"https://avatars1.githubusercontent.com/u/5055988?v=4","gravatar_id":"","url":"https://api.github.com/users/buildkite","html_url":"https://github.com/buildkite","followers_url":"https://api.github.com/users/buildkite/followers","following_url":"https://api.github.com/users/buildkite/following{/other_user}","gists_url":"https://api.github.com/users/buildkite/gists{/gist_id}","starred_url":"https://api.github.com/users/buildkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildkite/subscriptions","organizations_url":"https://api.github.com/users/buildkite/orgs","repos_url":"https://api.github.com/users/buildkite/repos","events_url":"https://api.github.com/users/buildkite/events{/privacy}","received_events_url":"https://api.github.com/users/buildkite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildkite/agent","description":"The Buildkite Agent is an open-source toolkit written in Golang for securely running build jobs on any device or network","fork":false,"url":"https://api.github.com/repos/buildkite/agent","forks_url":"https://api.github.com/repos/buildkite/agent/forks","keys_url":"https://api.github.com/repos/buildkite/agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildkite/agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildkite/agent/teams","hooks_url":"https://api.github.com/repos/buildkite/agent/hooks","issue_events_url":"https://api.github.com/repos/buildkite/agent/issues/events{/number}","events_url":"https://api.github.com/repos/buildkite/agent/events","assignees_url":"https://api.github.com/repos/buildkite/agent/assignees{/user}","branches_url":"https://api.github.com/repos/buildkite/agent/branches{/branch}","tags_url":"https://api.github.com/repos/buildkite/agent/tags","blobs_url":"https://api.github.com/repos/buildkite/agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildkite/agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildkite/agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildkite/agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildkite/agent/statuses/{sha}","languages_url":"https://api.github.com/repos/buildkite/agent/languages","stargazers_url":"https://api.github.com/repos/buildkite/agent/stargazers","contributors_url":"https://api.github.com/repos/buildkite/agent/contributors","subscribers_url":"https://api.github.com/repos/buildkite/agent/subscribers","subscription_url":"https://api.github.com/repos/buildkite/agent/subscription","commits_url":"https://api.github.com/repos/buildkite/agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildkite/agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildkite/agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildkite/agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildkite/agent/contents/{+path}","compare_url":"https://api.github.com/repos/buildkite/agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildkite/agent/merges","archive_url":"https://api.github.com/repos/buildkite/agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildkite/agent/downloads","issues_url":"https://api.github.com/repos/buildkite/agent/issues{/number}","pulls_url":"https://api.github.com/repos/buildkite/agent/pulls{/number}","milestones_url":"https://api.github.com/repos/buildkite/agent/milestones{/number}","notifications_url":"https://api.github.com/repos/buildkite/agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildkite/agent/labels{/name}","releases_url":"https://api.github.com/repos/buildkite/agent/releases{/id}","deployments_url":"https://api.github.com/repos/buildkite/agent/deployments","created_at":"2014-01-29T14:31:28Z","updated_at":"2018-03-28T07:19:40Z","pushed_at":"2018-03-29T00:50:39Z","git_url":"git://github.com/buildkite/agent.git","ssh_url":"git@github.com:buildkite/agent.git","clone_url":"https://github.com/buildkite/agent.git","svn_url":"https://github.com/buildkite/agent","homepage":"https://buildkite.com/","size":20794,"stargazers_count":249,"watchers_count":249,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":100,"open_issues":22,"watchers":249,"default_branch":"master"}},"base":{"label":"buildkite:master","ref":"master","sha":"9e9955cac90f40b31f3fe1fd41aad0b515f3cfa4","user":{"login":"buildkite","id":5055988,"avatar_url":"https://avatars1.githubusercontent.com/u/5055988?v=4","gravatar_id":"","url":"https://api.github.com/users/buildkite","html_url":"https://github.com/buildkite","followers_url":"https://api.github.com/users/buildkite/followers","following_url":"https://api.github.com/users/buildkite/following{/other_user}","gists_url":"https://api.github.com/users/buildkite/gists{/gist_id}","starred_url":"https://api.github.com/users/buildkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildkite/subscriptions","organizations_url":"https://api.github.com/users/buildkite/orgs","repos_url":"https://api.github.com/users/buildkite/repos","events_url":"https://api.github.com/users/buildkite/events{/privacy}","received_events_url":"https://api.github.com/users/buildkite/received_events","type":"Organization","site_admin":false},"repo":{"id":16347164,"name":"agent","full_name":"buildkite/agent","owner":{"login":"buildkite","id":5055988,"avatar_url":"https://avatars1.githubusercontent.com/u/5055988?v=4","gravatar_id":"","url":"https://api.github.com/users/buildkite","html_url":"https://github.com/buildkite","followers_url":"https://api.github.com/users/buildkite/followers","following_url":"https://api.github.com/users/buildkite/following{/other_user}","gists_url":"https://api.github.com/users/buildkite/gists{/gist_id}","starred_url":"https://api.github.com/users/buildkite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildkite/subscriptions","organizations_url":"https://api.github.com/users/buildkite/orgs","repos_url":"https://api.github.com/users/buildkite/repos","events_url":"https://api.github.com/users/buildkite/events{/privacy}","received_events_url":"https://api.github.com/users/buildkite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildkite/agent","description":"The Buildkite Agent is an open-source toolkit written in Golang for securely running build jobs on any device or network","fork":false,"url":"https://api.github.com/repos/buildkite/agent","forks_url":"https://api.github.com/repos/buildkite/agent/forks","keys_url":"https://api.github.com/repos/buildkite/agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildkite/agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildkite/agent/teams","hooks_url":"https://api.github.com/repos/buildkite/agent/hooks","issue_events_url":"https://api.github.com/repos/buildkite/agent/issues/events{/number}","events_url":"https://api.github.com/repos/buildkite/agent/events","assignees_url":"https://api.github.com/repos/buildkite/agent/assignees{/user}","branches_url":"https://api.github.com/repos/buildkite/agent/branches{/branch}","tags_url":"https://api.github.com/repos/buildkite/agent/tags","blobs_url":"https://api.github.com/repos/buildkite/agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildkite/agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildkite/agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildkite/agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildkite/agent/statuses/{sha}","languages_url":"https://api.github.com/repos/buildkite/agent/languages","stargazers_url":"https://api.github.com/repos/buildkite/agent/stargazers","contributors_url":"https://api.github.com/repos/buildkite/agent/contributors","subscribers_url":"https://api.github.com/repos/buildkite/agent/subscribers","subscription_url":"https://api.github.com/repos/buildkite/agent/subscription","commits_url":"https://api.github.com/repos/buildkite/agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildkite/agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildkite/agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildkite/agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildkite/agent/contents/{+path}","compare_url":"https://api.github.com/repos/buildkite/agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildkite/agent/merges","archive_url":"https://api.github.com/repos/buildkite/agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildkite/agent/downloads","issues_url":"https://api.github.com/repos/buildkite/agent/issues{/number}","pulls_url":"https://api.github.com/repos/buildkite/agent/pulls{/number}","milestones_url":"https://api.github.com/repos/buildkite/agent/milestones{/number}","notifications_url":"https://api.github.com/repos/buildkite/agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildkite/agent/labels{/name}","releases_url":"https://api.github.com/repos/buildkite/agent/releases{/id}","deployments_url":"https://api.github.com/repos/buildkite/agent/deployments","created_at":"2014-01-29T14:31:28Z","updated_at":"2018-03-28T07:19:40Z","pushed_at":"2018-03-29T00:50:39Z","git_url":"git://github.com/buildkite/agent.git","ssh_url":"git@github.com:buildkite/agent.git","clone_url":"https://github.com/buildkite/agent.git","svn_url":"https://github.com/buildkite/agent","homepage":"https://buildkite.com/","size":20794,"stargazers_count":249,"watchers_count":249,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":100,"open_issues":22,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildkite/agent/pulls/707"},"html":{"href":"https://github.com/buildkite/agent/pull/707"},"issue":{"href":"https://api.github.com/repos/buildkite/agent/issues/707"},"comments":{"href":"https://api.github.com/repos/buildkite/agent/issues/707/comments"},"review_comments":{"href":"https://api.github.com/repos/buildkite/agent/pulls/707/comments"},"review_comment":{"href":"https://api.github.com/repos/buildkite/agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildkite/agent/pulls/707/commits"},"statuses":{"href":"https://api.github.com/repos/buildkite/agent/statuses/a2331bbbc2f4a24f66c761c0c9e21cfdaf907815"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"keithpitt"}}