{"action":"created","issue":{"url":"https://api.github.com/repos/andrewpbray/infer/issues/109","repository_url":"https://api.github.com/repos/andrewpbray/infer","labels_url":"https://api.github.com/repos/andrewpbray/infer/issues/109/labels{/name}","comments_url":"https://api.github.com/repos/andrewpbray/infer/issues/109/comments","events_url":"https://api.github.com/repos/andrewpbray/infer/issues/109/events","html_url":"https://github.com/andrewpbray/infer/issues/109","id":302910301,"number":109,"title":"Calculating an observed statistic","user":{"login":"andrewpbray","id":1627362,"avatar_url":"https://avatars3.githubusercontent.com/u/1627362?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewpbray","html_url":"https://github.com/andrewpbray","followers_url":"https://api.github.com/users/andrewpbray/followers","following_url":"https://api.github.com/users/andrewpbray/following{/other_user}","gists_url":"https://api.github.com/users/andrewpbray/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewpbray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewpbray/subscriptions","organizations_url":"https://api.github.com/users/andrewpbray/orgs","repos_url":"https://api.github.com/users/andrewpbray/repos","events_url":"https://api.github.com/users/andrewpbray/events{/privacy}","received_events_url":"https://api.github.com/users/andrewpbray/received_events","type":"User","site_admin":false},"labels":[{"id":804097392,"url":"https://api.github.com/repos/andrewpbray/infer/labels/back%20to%20later","name":"back to later","color":"fbca04","default":false},{"id":914032925,"url":"https://api.github.com/repos/andrewpbray/infer/labels/v0.3.0","name":"v0.3.0","color":"90b7f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":28,"created_at":"2018-03-06T23:39:36Z","updated_at":"2018-05-05T22:07:48Z","closed_at":null,"author_association":"OWNER","body":"We're looking into bringing the more fully functioning `visualize()` function into the package from Chester's dev branch, and it has an option to add the observed statistic as a vertical line. The question is, how are we expecting that people will generate that observed statistic? It seems to me like we should make this work:\r\n```\r\nmtcars %>%\r\n  specify(am ~ vs, success = \"1\") %>%\r\n  calculate(stat = \"diff in props\")\r\n```\r\nInterestingly, it is already very close to working. All we probably need to do is add a grouping variable as the object is coming out of `specify()` that links creates one big group, then `calculate()` can just work the way it normally does. Thoughts? @rudeboybert @hardin47, I recall you had opinions about this."},"comment":{"url":"https://api.github.com/repos/andrewpbray/infer/issues/comments/386838459","html_url":"https://github.com/andrewpbray/infer/issues/109#issuecomment-386838459","issue_url":"https://api.github.com/repos/andrewpbray/infer/issues/109","id":386838459,"user":{"login":"ismayc","id":9215614,"avatar_url":"https://avatars3.githubusercontent.com/u/9215614?v=4","gravatar_id":"","url":"https://api.github.com/users/ismayc","html_url":"https://github.com/ismayc","followers_url":"https://api.github.com/users/ismayc/followers","following_url":"https://api.github.com/users/ismayc/following{/other_user}","gists_url":"https://api.github.com/users/ismayc/gists{/gist_id}","starred_url":"https://api.github.com/users/ismayc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismayc/subscriptions","organizations_url":"https://api.github.com/users/ismayc/orgs","repos_url":"https://api.github.com/users/ismayc/repos","events_url":"https://api.github.com/users/ismayc/events{/privacy}","received_events_url":"https://api.github.com/users/ismayc/received_events","type":"User","site_admin":false},"created_at":"2018-05-05T22:07:47Z","updated_at":"2018-05-05T22:07:47Z","author_association":"COLLABORATOR","body":"@hardin47 @rudeboybert @mine-cetinkaya-rundel I've made more progress on this and have all of the \"intro stats\" examples created. I'm still working on `stat = \"z\"` and `stat = \"t\"`. https://infer-dev.netlify.com/articles/observed_stat_examples.html. \r\n\r\n@andrewpbray Maybe it makes sense to bump to v0.2.1 and skip the push to CRAN for v0.2.0. Would really love to get something sent to CRAN as soon as possible though. Let me know if you'd like me to work through the CRAN submission errors so we can get this updated. I'm happy to be temporary maintainer until things slow down for you too."}}
{"actor":{"display_login":"ismayc"}}