{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/socorro/pulls/comments/187427375","pull_request_review_id":119207510,"id":187427375,"diff_hunk":"@@ -79,6 +79,26 @@ services:\n     volumes:\n       - .:/app\n \n+  # For running tests in as we transition to Python 3\n+  testpython3:\n+    build:\n+      context: .\n+      dockerfile: ./docker/Dockerfile.python3\n+    image: local/socorro_python3\n+    env_file:\n+      - docker/config/local_dev.env\n+      - docker/config/never_on_a_server.env\n+      - my.env\n+    depends_on:\n+      - statsd\n+      - localstack-s3\n+      - postgresql\n+      - elasticsearch\n+      - rabbitmq\n+      - memcached\n+    volumes:\n+      - .:/app","path":"docker-compose.yml","position":22,"original_position":22,"commit_id":"b10d9de1b70d7b2a43085aed9b55080d999efeff","original_commit_id":"b10d9de1b70d7b2a43085aed9b55080d999efeff","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars1.githubusercontent.com/u/820826?v=4","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"body":"This is modeled after the `webapp` container because we use that for the tests. I don't know offhand what the tests needed or didn't need, so I just copied the webapp stuff. I figure this is temporary scaffolding.","created_at":"2018-05-10T19:02:17Z","updated_at":"2018-05-10T19:02:17Z","html_url":"https://github.com/mozilla-services/socorro/pull/4444#discussion_r187427375","pull_request_url":"https://api.github.com/repos/mozilla-services/socorro/pulls/4444","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/comments/187427375"},"html":{"href":"https://github.com/mozilla-services/socorro/pull/4444#discussion_r187427375"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/4444"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/socorro/pulls/4444","id":187277441,"html_url":"https://github.com/mozilla-services/socorro/pull/4444","diff_url":"https://github.com/mozilla-services/socorro/pull/4444.diff","patch_url":"https://github.com/mozilla-services/socorro/pull/4444.patch","issue_url":"https://api.github.com/repos/mozilla-services/socorro/issues/4444","number":4444,"state":"open","locked":false,"title":"fix bug 1460035: implement python 3 test scaffolding","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars1.githubusercontent.com/u/820826?v=4","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"body":"This adds a couple of make rules and shell scripts to give us scaffolding\r\nwith which we can iterate over fixing code to make it work in both\r\nPython 2 and Python 3.\r\n\r\nIn order to get the tests to run at all, I had to fix a bunch of Python\r\n3 issues. I also hoisted six to first-class dependency status.\r\n\r\nThis doesn't connect that with CI because linting fails epically. We'll do\r\nthat later.","created_at":"2018-05-10T19:00:10Z","updated_at":"2018-05-10T19:02:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd63d542ead237a9d0c2145c00c9995dd033d85b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Osmose","id":193106,"avatar_url":"https://avatars1.githubusercontent.com/u/193106?v=4","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/socorro/pulls/4444/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/socorro/pulls/4444/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/socorro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/socorro/issues/4444/comments","statuses_url":"https://api.github.com/repos/mozilla-services/socorro/statuses/b10d9de1b70d7b2a43085aed9b55080d999efeff","head":{"label":"willkg:1460035-python3","ref":"1460035-python3","sha":"b10d9de1b70d7b2a43085aed9b55080d999efeff","user":{"login":"willkg","id":820826,"avatar_url":"https://avatars1.githubusercontent.com/u/820826?v=4","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"repo":{"id":53347766,"name":"socorro","full_name":"willkg/socorro","owner":{"login":"willkg","id":820826,"avatar_url":"https://avatars1.githubusercontent.com/u/820826?v=4","gravatar_id":"","url":"https://api.github.com/users/willkg","html_url":"https://github.com/willkg","followers_url":"https://api.github.com/users/willkg/followers","following_url":"https://api.github.com/users/willkg/following{/other_user}","gists_url":"https://api.github.com/users/willkg/gists{/gist_id}","starred_url":"https://api.github.com/users/willkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willkg/subscriptions","organizations_url":"https://api.github.com/users/willkg/orgs","repos_url":"https://api.github.com/users/willkg/repos","events_url":"https://api.github.com/users/willkg/events{/privacy}","received_events_url":"https://api.github.com/users/willkg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willkg/socorro","description":"Socorro is a server to accept and process Breakpad crash reports. ","fork":true,"url":"https://api.github.com/repos/willkg/socorro","forks_url":"https://api.github.com/repos/willkg/socorro/forks","keys_url":"https://api.github.com/repos/willkg/socorro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willkg/socorro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willkg/socorro/teams","hooks_url":"https://api.github.com/repos/willkg/socorro/hooks","issue_events_url":"https://api.github.com/repos/willkg/socorro/issues/events{/number}","events_url":"https://api.github.com/repos/willkg/socorro/events","assignees_url":"https://api.github.com/repos/willkg/socorro/assignees{/user}","branches_url":"https://api.github.com/repos/willkg/socorro/branches{/branch}","tags_url":"https://api.github.com/repos/willkg/socorro/tags","blobs_url":"https://api.github.com/repos/willkg/socorro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willkg/socorro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willkg/socorro/git/refs{/sha}","trees_url":"https://api.github.com/repos/willkg/socorro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willkg/socorro/statuses/{sha}","languages_url":"https://api.github.com/repos/willkg/socorro/languages","stargazers_url":"https://api.github.com/repos/willkg/socorro/stargazers","contributors_url":"https://api.github.com/repos/willkg/socorro/contributors","subscribers_url":"https://api.github.com/repos/willkg/socorro/subscribers","subscription_url":"https://api.github.com/repos/willkg/socorro/subscription","commits_url":"https://api.github.com/repos/willkg/socorro/commits{/sha}","git_commits_url":"https://api.github.com/repos/willkg/socorro/git/commits{/sha}","comments_url":"https://api.github.com/repos/willkg/socorro/comments{/number}","issue_comment_url":"https://api.github.com/repos/willkg/socorro/issues/comments{/number}","contents_url":"https://api.github.com/repos/willkg/socorro/contents/{+path}","compare_url":"https://api.github.com/repos/willkg/socorro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willkg/socorro/merges","archive_url":"https://api.github.com/repos/willkg/socorro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willkg/socorro/downloads","issues_url":"https://api.github.com/repos/willkg/socorro/issues{/number}","pulls_url":"https://api.github.com/repos/willkg/socorro/pulls{/number}","milestones_url":"https://api.github.com/repos/willkg/socorro/milestones{/number}","notifications_url":"https://api.github.com/repos/willkg/socorro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willkg/socorro/labels{/name}","releases_url":"https://api.github.com/repos/willkg/socorro/releases{/id}","deployments_url":"https://api.github.com/repos/willkg/socorro/deployments","created_at":"2016-03-07T18:16:09Z","updated_at":"2016-03-07T18:16:13Z","pushed_at":"2018-05-10T18:59:38Z","git_url":"git://github.com/willkg/socorro.git","ssh_url":"git@github.com:willkg/socorro.git","clone_url":"https://github.com/willkg/socorro.git","svn_url":"https://github.com/willkg/socorro","homepage":"https://wiki.mozilla.org/Socorro","size":172311,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"fabd33c181d48a23169de1a72c321a888af318c5","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":2263742,"name":"socorro","full_name":"mozilla-services/socorro","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/socorro","description":"Socorro is a server to accept and process Breakpad crash reports. ","fork":false,"url":"https://api.github.com/repos/mozilla-services/socorro","forks_url":"https://api.github.com/repos/mozilla-services/socorro/forks","keys_url":"https://api.github.com/repos/mozilla-services/socorro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/socorro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/socorro/teams","hooks_url":"https://api.github.com/repos/mozilla-services/socorro/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/socorro/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/socorro/events","assignees_url":"https://api.github.com/repos/mozilla-services/socorro/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/socorro/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/socorro/tags","blobs_url":"https://api.github.com/repos/mozilla-services/socorro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/socorro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/socorro/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/socorro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/socorro/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/socorro/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/socorro/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/socorro/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/socorro/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/socorro/subscription","commits_url":"https://api.github.com/repos/mozilla-services/socorro/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/socorro/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/socorro/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/socorro/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/socorro/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/socorro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/socorro/merges","archive_url":"https://api.github.com/repos/mozilla-services/socorro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/socorro/downloads","issues_url":"https://api.github.com/repos/mozilla-services/socorro/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/socorro/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/socorro/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/socorro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/socorro/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/socorro/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/socorro/deployments","created_at":"2011-08-24T19:21:49Z","updated_at":"2018-05-10T16:38:07Z","pushed_at":"2018-05-10T19:00:11Z","git_url":"git://github.com/mozilla-services/socorro.git","ssh_url":"git@github.com:mozilla-services/socorro.git","clone_url":"https://github.com/mozilla-services/socorro.git","svn_url":"https://github.com/mozilla-services/socorro","homepage":"https://wiki.mozilla.org/Socorro","size":172335,"stargazers_count":411,"watchers_count":411,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":202,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":202,"open_issues":4,"watchers":411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/4444"},"html":{"href":"https://github.com/mozilla-services/socorro/pull/4444"},"issue":{"href":"https://api.github.com/repos/mozilla-services/socorro/issues/4444"},"comments":{"href":"https://api.github.com/repos/mozilla-services/socorro/issues/4444/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/4444/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/socorro/pulls/4444/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/socorro/statuses/b10d9de1b70d7b2a43085aed9b55080d999efeff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"willkg"}}