{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-plc4x/pulls/comments/207200100","pull_request_review_id":142760790,"id":207200100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzIwMDEwMA==","diff_hunk":"@@ -58,7 +58,12 @@ public void setUp() {\n     @After\n     public void tearDown() {\n         if(s7PlcConnection.isConnected()) {\n-            s7PlcConnection.close();\n+            try {\n+                s7PlcConnection.close();\n+            } catch (NullPointerException e) {","path":"plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/s7/connection/S7PlcConnectionIT.java","position":7,"original_position":7,"commit_id":"9f064b856f79dd391d164589da44345c7460d1f8","original_commit_id":"9f064b856f79dd391d164589da44345c7460d1f8","user":{"login":"sruehl","id":1769155,"node_id":"MDQ6VXNlcjE3NjkxNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1769155?v=4","gravatar_id":"","url":"https://api.github.com/users/sruehl","html_url":"https://github.com/sruehl","followers_url":"https://api.github.com/users/sruehl/followers","following_url":"https://api.github.com/users/sruehl/following{/other_user}","gists_url":"https://api.github.com/users/sruehl/gists{/gist_id}","starred_url":"https://api.github.com/users/sruehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sruehl/subscriptions","organizations_url":"https://api.github.com/users/sruehl/orgs","repos_url":"https://api.github.com/users/sruehl/repos","events_url":"https://api.github.com/users/sruehl/events{/privacy}","received_events_url":"https://api.github.com/users/sruehl/received_events","type":"User","site_admin":false},"body":"seems like the refactoring didn't solve this as this is still a netty thread? At least @chrisdutz is getting the very same exception on your branch right now... We should investigate why this\r\n\r\nchannel.closeFuture().await();\r\nchannel.eventLoop().parent().shutdownGracefully();\r\nwas there in the first place.","created_at":"2018-08-02T12:02:32Z","updated_at":"2018-08-02T12:02:32Z","html_url":"https://github.com/apache/incubator-plc4x/pull/10#discussion_r207200100","pull_request_url":"https://api.github.com/repos/apache/incubator-plc4x/pulls/10","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-plc4x/pulls/comments/207200100"},"html":{"href":"https://github.com/apache/incubator-plc4x/pull/10#discussion_r207200100"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-plc4x/pulls/10"}},"in_reply_to_id":207193000},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-plc4x/pulls/10","id":205654403,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjU0NDAz","html_url":"https://github.com/apache/incubator-plc4x/pull/10","diff_url":"https://github.com/apache/incubator-plc4x/pull/10.diff","patch_url":"https://github.com/apache/incubator-plc4x/pull/10.patch","issue_url":"https://api.github.com/repos/apache/incubator-plc4x/issues/10","number":10,"state":"open","locked":false,"title":"Fixed NPE in S7PlcConnection#close.","user":{"login":"JulianFeinauer","id":17098762,"node_id":"MDQ6VXNlcjE3MDk4NzYy","avatar_url":"https://avatars1.githubusercontent.com/u/17098762?v=4","gravatar_id":"","url":"https://api.github.com/users/JulianFeinauer","html_url":"https://github.com/JulianFeinauer","followers_url":"https://api.github.com/users/JulianFeinauer/followers","following_url":"https://api.github.com/users/JulianFeinauer/following{/other_user}","gists_url":"https://api.github.com/users/JulianFeinauer/gists{/gist_id}","starred_url":"https://api.github.com/users/JulianFeinauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulianFeinauer/subscriptions","organizations_url":"https://api.github.com/users/JulianFeinauer/orgs","repos_url":"https://api.github.com/users/JulianFeinauer/repos","events_url":"https://api.github.com/users/JulianFeinauer/events{/privacy}","received_events_url":"https://api.github.com/users/JulianFeinauer/received_events","type":"User","site_admin":false},"body":"Fix for the NPE in S7PlcConnection's close method.\r\nAfter fixing the NPE there was a netty blockingException, thus I had to refactor the program logic a bit.\r\nPlease check if this is suitable the way I dit this (I tried to add enough comment to make it understandable).","created_at":"2018-08-02T08:22:21Z","updated_at":"2018-08-02T12:02:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adf5497023c47e4966fa578492019d7765e2471e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-plc4x/pulls/10/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-plc4x/pulls/10/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-plc4x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-plc4x/issues/10/comments","statuses_url":"https://api.github.com/repos/apache/incubator-plc4x/statuses/9f064b856f79dd391d164589da44345c7460d1f8","head":{"label":"JulianFeinauer:fix-npe-on-s7-close","ref":"fix-npe-on-s7-close","sha":"9f064b856f79dd391d164589da44345c7460d1f8","user":{"login":"JulianFeinauer","id":17098762,"node_id":"MDQ6VXNlcjE3MDk4NzYy","avatar_url":"https://avatars1.githubusercontent.com/u/17098762?v=4","gravatar_id":"","url":"https://api.github.com/users/JulianFeinauer","html_url":"https://github.com/JulianFeinauer","followers_url":"https://api.github.com/users/JulianFeinauer/followers","following_url":"https://api.github.com/users/JulianFeinauer/following{/other_user}","gists_url":"https://api.github.com/users/JulianFeinauer/gists{/gist_id}","starred_url":"https://api.github.com/users/JulianFeinauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulianFeinauer/subscriptions","organizations_url":"https://api.github.com/users/JulianFeinauer/orgs","repos_url":"https://api.github.com/users/JulianFeinauer/repos","events_url":"https://api.github.com/users/JulianFeinauer/events{/privacy}","received_events_url":"https://api.github.com/users/JulianFeinauer/received_events","type":"User","site_admin":false},"repo":{"id":143151065,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxNTEwNjU=","name":"incubator-plc4x","full_name":"JulianFeinauer/incubator-plc4x","owner":{"login":"JulianFeinauer","id":17098762,"node_id":"MDQ6VXNlcjE3MDk4NzYy","avatar_url":"https://avatars1.githubusercontent.com/u/17098762?v=4","gravatar_id":"","url":"https://api.github.com/users/JulianFeinauer","html_url":"https://github.com/JulianFeinauer","followers_url":"https://api.github.com/users/JulianFeinauer/followers","following_url":"https://api.github.com/users/JulianFeinauer/following{/other_user}","gists_url":"https://api.github.com/users/JulianFeinauer/gists{/gist_id}","starred_url":"https://api.github.com/users/JulianFeinauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulianFeinauer/subscriptions","organizations_url":"https://api.github.com/users/JulianFeinauer/orgs","repos_url":"https://api.github.com/users/JulianFeinauer/repos","events_url":"https://api.github.com/users/JulianFeinauer/events{/privacy}","received_events_url":"https://api.github.com/users/JulianFeinauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JulianFeinauer/incubator-plc4x","description":"Mirror of Apache plc4x (Incubating)","fork":true,"url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x","forks_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/forks","keys_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/teams","hooks_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/hooks","issue_events_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/issues/events{/number}","events_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/events","assignees_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/assignees{/user}","branches_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/branches{/branch}","tags_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/tags","blobs_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/git/refs{/sha}","trees_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/statuses/{sha}","languages_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/languages","stargazers_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/stargazers","contributors_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/contributors","subscribers_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/subscribers","subscription_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/subscription","commits_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/commits{/sha}","git_commits_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/git/commits{/sha}","comments_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/comments{/number}","issue_comment_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/issues/comments{/number}","contents_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/contents/{+path}","compare_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/merges","archive_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/downloads","issues_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/issues{/number}","pulls_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/pulls{/number}","milestones_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/milestones{/number}","notifications_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/labels{/name}","releases_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/releases{/id}","deployments_url":"https://api.github.com/repos/JulianFeinauer/incubator-plc4x/deployments","created_at":"2018-08-01T12:09:25Z","updated_at":"2018-08-01T12:09:27Z","pushed_at":"2018-08-02T10:31:36Z","git_url":"git://github.com/JulianFeinauer/incubator-plc4x.git","ssh_url":"git@github.com:JulianFeinauer/incubator-plc4x.git","clone_url":"https://github.com/JulianFeinauer/incubator-plc4x.git","svn_url":"https://github.com/JulianFeinauer/incubator-plc4x","homepage":null,"size":41987,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"44c0d686795a9a35d00dbead5f2a822b7a20d013","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":114859883,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4NTk4ODM=","name":"incubator-plc4x","full_name":"apache/incubator-plc4x","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-plc4x","description":"Mirror of Apache plc4x (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-plc4x","forks_url":"https://api.github.com/repos/apache/incubator-plc4x/forks","keys_url":"https://api.github.com/repos/apache/incubator-plc4x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-plc4x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-plc4x/teams","hooks_url":"https://api.github.com/repos/apache/incubator-plc4x/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-plc4x/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-plc4x/events","assignees_url":"https://api.github.com/repos/apache/incubator-plc4x/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-plc4x/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-plc4x/tags","blobs_url":"https://api.github.com/repos/apache/incubator-plc4x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-plc4x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-plc4x/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-plc4x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-plc4x/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-plc4x/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-plc4x/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-plc4x/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-plc4x/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-plc4x/subscription","commits_url":"https://api.github.com/repos/apache/incubator-plc4x/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-plc4x/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-plc4x/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-plc4x/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-plc4x/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-plc4x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-plc4x/merges","archive_url":"https://api.github.com/repos/apache/incubator-plc4x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-plc4x/downloads","issues_url":"https://api.github.com/repos/apache/incubator-plc4x/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-plc4x/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-plc4x/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-plc4x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-plc4x/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-plc4x/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-plc4x/deployments","created_at":"2017-12-20T08:00:09Z","updated_at":"2018-08-02T09:21:02Z","pushed_at":"2018-08-02T10:31:37Z","git_url":"git://github.com/apache/incubator-plc4x.git","ssh_url":"git@github.com:apache/incubator-plc4x.git","clone_url":"https://github.com/apache/incubator-plc4x.git","svn_url":"https://github.com/apache/incubator-plc4x","homepage":null,"size":42164,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":1,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-plc4x/pulls/10"},"html":{"href":"https://github.com/apache/incubator-plc4x/pull/10"},"issue":{"href":"https://api.github.com/repos/apache/incubator-plc4x/issues/10"},"comments":{"href":"https://api.github.com/repos/apache/incubator-plc4x/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-plc4x/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-plc4x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-plc4x/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-plc4x/statuses/9f064b856f79dd391d164589da44345c7460d1f8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sruehl"}}