{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/8647","repository_url":"https://api.github.com/repos/netty/netty","labels_url":"https://api.github.com/repos/netty/netty/issues/8647/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/8647/comments","events_url":"https://api.github.com/repos/netty/netty/issues/8647/events","html_url":"https://github.com/netty/netty/pull/8647","id":389761026,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3Njc2NTUy","number":8647,"title":"Explict always call ctx.read() when AUTO_READ is false and HTTP/2 is …","user":{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"labels":[{"id":185731,"node_id":"MDU6TGFiZWwxODU3MzE=","url":"https://api.github.com/repos/netty/netty/labels/cleanup","name":"cleanup","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"assignees":[{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/206","html_url":"https://github.com/netty/netty/milestone/206","labels_url":"https://api.github.com/repos/netty/netty/milestones/206/labels","id":3857863,"node_id":"MDk6TWlsZXN0b25lMzg1Nzg2Mw==","number":206,"title":"4.1.33.Final","description":"","creator":{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":25,"state":"open","created_at":"2018-11-29T09:53:10Z","updated_at":"2018-12-13T18:02:21Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-12-11T13:20:39Z","updated_at":"2018-12-13T18:51:53Z","closed_at":"2018-12-13T18:02:21Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/8647","html_url":"https://github.com/netty/netty/pull/8647","diff_url":"https://github.com/netty/netty/pull/8647.diff","patch_url":"https://github.com/netty/netty/pull/8647.patch"},"body":"…used.\r\n\r\nMotivation:\r\n\r\nWe should always call ctx.read() even when AUTO_READ is false as flow-control is enforced by the HTTP/2 protocol.\r\n\r\nSee also https://tools.ietf.org/html/rfc7540#section-5.2.2.\r\n\r\nWe already did this before but not explicit and only did so because of some implementation details of ByteToMessageDecoder. It's better to be explicit here to not risk of breakage later on.\r\n\r\nModifications:\r\n\r\n- Ensure we always call ctx.read() when AUTO_READ is false\r\n- Add unit test.\r\n\r\nResult:\r\n\r\nNo risk of staling the connection when HTTP/2 is used."},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/447078732","html_url":"https://github.com/netty/netty/pull/8647#issuecomment-447078732","issue_url":"https://api.github.com/repos/netty/netty/issues/8647","id":447078732,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzA3ODczMg==","user":{"login":"normanmaurer","id":439362,"node_id":"MDQ6VXNlcjQzOTM2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T18:51:53Z","updated_at":"2018-12-13T18:51:53Z","author_association":"MEMBER","body":"@ejona86 hmm... it’s exactly the same what we do atm l. We just do it exploit now and not “depend” on the base class to do so"}}
{"actor":{"display_login":"normanmaurer"}}