{"action":"created","comment":{"url":"https://api.github.com/repos/webrtc/samples/pulls/comments/204330651","pull_request_review_id":139388967,"id":204330651,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDMzMDY1MQ==","diff_hunk":"@@ -0,0 +1,88 @@\n+/*\n+ *  Copyright (c) 2018 The WebRTC project authors. All Rights Reserved.\n+ *\n+ *  Use of this source code is governed by a BSD-style license\n+ *  that can be found in the LICENSE file in the root of the source\n+ *  tree.\n+ */\n+\n+/* global AudioContext, SoundMeter */\n+\n+'use strict';\n+\n+const instantMeter = document.querySelector('#instant meter')\n+const slowMeter = document.querySelector('#slow meter')\n+const unprocessedMeter = document.querySelector('#unprocessed meter')\n+\n+const instantValueDisplay = document.querySelector('#instant .value')\n+const slowValueDisplay = document.querySelector('#slow .value')\n+const unprocessedValueDisplay = document.querySelector('#unprocessed .value')\n+const errorMsg = document.querySelector('#errorMsg')\n+\n+try {\n+  window.AudioContext = window.AudioContext || window.webkitAudioContext;\n+  window.audioContext = new AudioContext();\n+} catch (e) {\n+  alert('Web Audio API not supported.');\n+}\n+\n+// Put variables in global scope to make them available to the browser console.\n+let constraints = window.constraints = {\n+  audio: {echoCancellation: true},\n+  video: false\n+}\n+\n+function handleSuccess(stream) {","path":"src/content/getusermedia/unprocessed-volume/js/main.js","position":35,"original_position":35,"commit_id":"ed5f742974e5d7a7d0e6265d4c8656c429b53b4b","original_commit_id":"a8008a409a234febef5cf66518b61c3cdadcc466","user":{"login":"ErikHellman","id":72444,"node_id":"MDQ6VXNlcjcyNDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/72444?v=4","gravatar_id":"","url":"https://api.github.com/users/ErikHellman","html_url":"https://github.com/ErikHellman","followers_url":"https://api.github.com/users/ErikHellman/followers","following_url":"https://api.github.com/users/ErikHellman/following{/other_user}","gists_url":"https://api.github.com/users/ErikHellman/gists{/gist_id}","starred_url":"https://api.github.com/users/ErikHellman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErikHellman/subscriptions","organizations_url":"https://api.github.com/users/ErikHellman/orgs","repos_url":"https://api.github.com/users/ErikHellman/repos","events_url":"https://api.github.com/users/ErikHellman/events{/privacy}","received_events_url":"https://api.github.com/users/ErikHellman/received_events","type":"User","site_admin":false},"body":"I've changed my mind on this. async/await is better in most cases than promise-chains. We should be good citizens and push the use of that. :)","created_at":"2018-07-23T09:08:00Z","updated_at":"2018-07-23T09:08:00Z","html_url":"https://github.com/webrtc/samples/pull/993#discussion_r204330651","pull_request_url":"https://api.github.com/repos/webrtc/samples/pulls/993","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/webrtc/samples/pulls/comments/204330651"},"html":{"href":"https://github.com/webrtc/samples/pull/993#discussion_r204330651"},"pull_request":{"href":"https://api.github.com/repos/webrtc/samples/pulls/993"}},"in_reply_to_id":195776637},"pull_request":{"url":"https://api.github.com/repos/webrtc/samples/pulls/993","id":163138391,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYzMTM4Mzkx","html_url":"https://github.com/webrtc/samples/pull/993","diff_url":"https://github.com/webrtc/samples/pull/993.diff","patch_url":"https://github.com/webrtc/samples/pull/993.patch","issue_url":"https://api.github.com/repos/webrtc/samples/issues/993","number":993,"state":"open","locked":false,"title":"Add a demo for \"Unprocessed volume\"","user":{"login":"alvestrand","id":480893,"node_id":"MDQ6VXNlcjQ4MDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/480893?v=4","gravatar_id":"","url":"https://api.github.com/users/alvestrand","html_url":"https://github.com/alvestrand","followers_url":"https://api.github.com/users/alvestrand/followers","following_url":"https://api.github.com/users/alvestrand/following{/other_user}","gists_url":"https://api.github.com/users/alvestrand/gists{/gist_id}","starred_url":"https://api.github.com/users/alvestrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvestrand/subscriptions","organizations_url":"https://api.github.com/users/alvestrand/orgs","repos_url":"https://api.github.com/users/alvestrand/repos","events_url":"https://api.github.com/users/alvestrand/events{/privacy}","received_events_url":"https://api.github.com/users/alvestrand/received_events","type":"User","site_admin":false},"body":"**Description**\r\nAdd a demo that demonstrates the difference between processed and unprocessed audio volume.\r\n\r\nThis doesn't work right as of Chrome 63 (and probably 65); the PR\r\nis created in order to get the implementation work going.\r\n","created_at":"2018-01-16T10:20:03Z","updated_at":"2018-07-23T09:08:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"397eba79624f6d76d3e89517313e6bb0f59f38c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":173972356,"node_id":"MDU6TGFiZWwxNzM5NzIzNTY=","url":"https://api.github.com/repos/webrtc/samples/labels/cla:%20no","name":"cla: no","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/webrtc/samples/pulls/993/commits","review_comments_url":"https://api.github.com/repos/webrtc/samples/pulls/993/comments","review_comment_url":"https://api.github.com/repos/webrtc/samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webrtc/samples/issues/993/comments","statuses_url":"https://api.github.com/repos/webrtc/samples/statuses/ed5f742974e5d7a7d0e6265d4c8656c429b53b4b","head":{"label":"webrtc:unprocessed-volume","ref":"unprocessed-volume","sha":"ed5f742974e5d7a7d0e6265d4c8656c429b53b4b","user":{"login":"webrtc","id":10526312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTI2MzEy","avatar_url":"https://avatars2.githubusercontent.com/u/10526312?v=4","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"repo":{"id":12970971,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3MDk3MQ==","name":"samples","full_name":"webrtc/samples","owner":{"login":"webrtc","id":10526312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTI2MzEy","avatar_url":"https://avatars2.githubusercontent.com/u/10526312?v=4","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webrtc/samples","description":"WebRTC Web demos and samples","fork":false,"url":"https://api.github.com/repos/webrtc/samples","forks_url":"https://api.github.com/repos/webrtc/samples/forks","keys_url":"https://api.github.com/repos/webrtc/samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webrtc/samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webrtc/samples/teams","hooks_url":"https://api.github.com/repos/webrtc/samples/hooks","issue_events_url":"https://api.github.com/repos/webrtc/samples/issues/events{/number}","events_url":"https://api.github.com/repos/webrtc/samples/events","assignees_url":"https://api.github.com/repos/webrtc/samples/assignees{/user}","branches_url":"https://api.github.com/repos/webrtc/samples/branches{/branch}","tags_url":"https://api.github.com/repos/webrtc/samples/tags","blobs_url":"https://api.github.com/repos/webrtc/samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webrtc/samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webrtc/samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/webrtc/samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webrtc/samples/statuses/{sha}","languages_url":"https://api.github.com/repos/webrtc/samples/languages","stargazers_url":"https://api.github.com/repos/webrtc/samples/stargazers","contributors_url":"https://api.github.com/repos/webrtc/samples/contributors","subscribers_url":"https://api.github.com/repos/webrtc/samples/subscribers","subscription_url":"https://api.github.com/repos/webrtc/samples/subscription","commits_url":"https://api.github.com/repos/webrtc/samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/webrtc/samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/webrtc/samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/webrtc/samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/webrtc/samples/contents/{+path}","compare_url":"https://api.github.com/repos/webrtc/samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webrtc/samples/merges","archive_url":"https://api.github.com/repos/webrtc/samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webrtc/samples/downloads","issues_url":"https://api.github.com/repos/webrtc/samples/issues{/number}","pulls_url":"https://api.github.com/repos/webrtc/samples/pulls{/number}","milestones_url":"https://api.github.com/repos/webrtc/samples/milestones{/number}","notifications_url":"https://api.github.com/repos/webrtc/samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webrtc/samples/labels{/name}","releases_url":"https://api.github.com/repos/webrtc/samples/releases{/id}","deployments_url":"https://api.github.com/repos/webrtc/samples/deployments","created_at":"2013-09-20T10:40:23Z","updated_at":"2018-07-23T07:57:34Z","pushed_at":"2018-07-23T08:59:43Z","git_url":"git://github.com/webrtc/samples.git","ssh_url":"git@github.com:webrtc/samples.git","clone_url":"https://github.com/webrtc/samples.git","svn_url":"https://github.com/webrtc/samples","homepage":"https://webrtc.github.io/samples","size":16583,"stargazers_count":5462,"watchers_count":5462,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2436,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2436,"open_issues":34,"watchers":5462,"default_branch":"gh-pages"}},"base":{"label":"webrtc:gh-pages","ref":"gh-pages","sha":"67fb8c1393c31801249a813c76f9959406511a1a","user":{"login":"webrtc","id":10526312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTI2MzEy","avatar_url":"https://avatars2.githubusercontent.com/u/10526312?v=4","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"repo":{"id":12970971,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3MDk3MQ==","name":"samples","full_name":"webrtc/samples","owner":{"login":"webrtc","id":10526312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTI2MzEy","avatar_url":"https://avatars2.githubusercontent.com/u/10526312?v=4","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webrtc/samples","description":"WebRTC Web demos and samples","fork":false,"url":"https://api.github.com/repos/webrtc/samples","forks_url":"https://api.github.com/repos/webrtc/samples/forks","keys_url":"https://api.github.com/repos/webrtc/samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webrtc/samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webrtc/samples/teams","hooks_url":"https://api.github.com/repos/webrtc/samples/hooks","issue_events_url":"https://api.github.com/repos/webrtc/samples/issues/events{/number}","events_url":"https://api.github.com/repos/webrtc/samples/events","assignees_url":"https://api.github.com/repos/webrtc/samples/assignees{/user}","branches_url":"https://api.github.com/repos/webrtc/samples/branches{/branch}","tags_url":"https://api.github.com/repos/webrtc/samples/tags","blobs_url":"https://api.github.com/repos/webrtc/samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webrtc/samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webrtc/samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/webrtc/samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webrtc/samples/statuses/{sha}","languages_url":"https://api.github.com/repos/webrtc/samples/languages","stargazers_url":"https://api.github.com/repos/webrtc/samples/stargazers","contributors_url":"https://api.github.com/repos/webrtc/samples/contributors","subscribers_url":"https://api.github.com/repos/webrtc/samples/subscribers","subscription_url":"https://api.github.com/repos/webrtc/samples/subscription","commits_url":"https://api.github.com/repos/webrtc/samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/webrtc/samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/webrtc/samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/webrtc/samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/webrtc/samples/contents/{+path}","compare_url":"https://api.github.com/repos/webrtc/samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webrtc/samples/merges","archive_url":"https://api.github.com/repos/webrtc/samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webrtc/samples/downloads","issues_url":"https://api.github.com/repos/webrtc/samples/issues{/number}","pulls_url":"https://api.github.com/repos/webrtc/samples/pulls{/number}","milestones_url":"https://api.github.com/repos/webrtc/samples/milestones{/number}","notifications_url":"https://api.github.com/repos/webrtc/samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webrtc/samples/labels{/name}","releases_url":"https://api.github.com/repos/webrtc/samples/releases{/id}","deployments_url":"https://api.github.com/repos/webrtc/samples/deployments","created_at":"2013-09-20T10:40:23Z","updated_at":"2018-07-23T07:57:34Z","pushed_at":"2018-07-23T08:59:43Z","git_url":"git://github.com/webrtc/samples.git","ssh_url":"git@github.com:webrtc/samples.git","clone_url":"https://github.com/webrtc/samples.git","svn_url":"https://github.com/webrtc/samples","homepage":"https://webrtc.github.io/samples","size":16583,"stargazers_count":5462,"watchers_count":5462,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2436,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2436,"open_issues":34,"watchers":5462,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/webrtc/samples/pulls/993"},"html":{"href":"https://github.com/webrtc/samples/pull/993"},"issue":{"href":"https://api.github.com/repos/webrtc/samples/issues/993"},"comments":{"href":"https://api.github.com/repos/webrtc/samples/issues/993/comments"},"review_comments":{"href":"https://api.github.com/repos/webrtc/samples/pulls/993/comments"},"review_comment":{"href":"https://api.github.com/repos/webrtc/samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webrtc/samples/pulls/993/commits"},"statuses":{"href":"https://api.github.com/repos/webrtc/samples/statuses/ed5f742974e5d7a7d0e6265d4c8656c429b53b4b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ErikHellman"}}