{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3783","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3783/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3783/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3783/events","html_url":"https://github.com/codice/ddf/pull/3783","id":363362909,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3ODIxMjMy","number":3783,"title":"DDF-4123 Replace platform-filter-delegate with pax web AuthenticationService","user":{"login":"KalCramer","id":5001399,"node_id":"MDQ6VXNlcjUwMDEzOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/5001399?v=4","gravatar_id":"","url":"https://api.github.com/users/KalCramer","html_url":"https://github.com/KalCramer","followers_url":"https://api.github.com/users/KalCramer/followers","following_url":"https://api.github.com/users/KalCramer/following{/other_user}","gists_url":"https://api.github.com/users/KalCramer/gists{/gist_id}","starred_url":"https://api.github.com/users/KalCramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KalCramer/subscriptions","organizations_url":"https://api.github.com/users/KalCramer/orgs","repos_url":"https://api.github.com/users/KalCramer/repos","events_url":"https://api.github.com/users/KalCramer/events{/privacy}","received_events_url":"https://api.github.com/users/KalCramer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"assignees":[{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},{"login":"stustison","id":4391679,"node_id":"MDQ6VXNlcjQzOTE2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-09-25T00:01:28Z","updated_at":"2018-09-25T16:37:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3783","html_url":"https://github.com/codice/ddf/pull/3783","diff_url":"https://github.com/codice/ddf/pull/3783.diff","patch_url":"https://github.com/codice/ddf/pull/3783.patch"},"body":"#### What does this PR do?\r\nReplace PlatformFilterDelegate with pax web AuthenticationService\r\n\r\n- This task will move the logic of adding security filters over to the platform-paxweb-jettyconfig fragment and use AuthenticatorService provided by pax.web.service to apply the security filters.\r\n\r\n#### Who is reviewing it? \r\n@jhunzik \r\n@brjeter \r\n@ryeats \r\n@derekwilhelm \r\n@paouelle \r\n\r\n#### Select relevant component teams: \r\n@codice/security \r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n@coyotesqrl\r\n@stustison\r\n\r\n#### How should this be tested?\r\n<!--(List steps with links to updated documentation)-->\r\n\r\n#### Any background context you want to provide?\r\n0. Continuation of PR found [here](https://github.com/brjeter/ddf/pull/2).\r\n1. Had to override org.ops4j.pax.web/pax-web-jetty to always use our authenticator and not define in every web.xml.\r\n2. blacklisted.properties is replaced with org.apache.karaf.features.xml to do this bundle override.\r\n3. Had to implement Principal for ddf.security.Subject so I could treat is as a principle and could attach subject to thread context.\r\n4. This solution, like what was there previously, is Jetty specific.\r\n5. This is my first DDF PR so be harsh.\r\n\r\n#### What are the relevant tickets?\r\n[DDF-4123](https://codice.atlassian.net/browse/DDF-4123)\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/424415003","html_url":"https://github.com/codice/ddf/pull/3783#issuecomment-424415003","issue_url":"https://api.github.com/repos/codice/ddf/issues/3783","id":424415003,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDQxNTAwMw==","user":{"login":"cxbot","id":21088360,"node_id":"MDQ6VXNlcjIxMDg4MzYw","avatar_url":"https://avatars2.githubusercontent.com/u/21088360?v=4","gravatar_id":"","url":"https://api.github.com/users/cxbot","html_url":"https://github.com/cxbot","followers_url":"https://api.github.com/users/cxbot/followers","following_url":"https://api.github.com/users/cxbot/following{/other_user}","gists_url":"https://api.github.com/users/cxbot/gists{/gist_id}","starred_url":"https://api.github.com/users/cxbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxbot/subscriptions","organizations_url":"https://api.github.com/users/cxbot/orgs","repos_url":"https://api.github.com/users/cxbot/repos","events_url":"https://api.github.com/users/cxbot/events{/privacy}","received_events_url":"https://api.github.com/users/cxbot/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T16:37:05Z","updated_at":"2018-09-25T16:37:05Z","author_association":"COLLABORATOR","body":"Internal build has been scheduled, your results will be available at build completion."}}
{"actor":{"display_login":"cxbot"}}