{"action":"created","comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/222466589","pull_request_review_id":161360984,"id":222466589,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjQ2NjU4OQ==","diff_hunk":"@@ -1,40 +1,12 @@\n <%@ page language=\"java\" contentType=\"text/javascript; charset=UTF-8\"\n     pageEncoding=\"UTF-8\"%>\n     \n-<%@ page import=\"java.util.List\" %>\n <%@ page import=\"org.mskcc.cbio.portal.servlet.CheckDarwinAccessServlet\" %>\n <%@ page import=\"org.mskcc.cbio.portal.util.GlobalProperties\" %>\n \n-<% \n-// Set API root variable for cbioportal-frontend repo\n-String url = request.getRequestURL().toString();\n-String baseURL = url.substring(0, url.length() - request.getRequestURI().length()) + request.getContextPath();\n-baseURL = baseURL.replace(\"https://\", \"\").replace(\"http://\", \"\");\n-\n-String studies = \"{\";\n-\n-List<String[]> priorityStudies = GlobalProperties.getPriorityStudies();\n-for (String[] group : priorityStudies) {\n-    if (group.length > 1) {\n-        studies += \"\\\"\"+group[0]+\"\\\" : \";\n-        studies += \"[\";\n-        int i = 1;\n-        while (i < group.length) {\n-            if (i >= 2) {\n-                studies += \",\";\n-            }\n-            studies += \"\\\"\"+group[i]+\"\\\"\";\n-            i++;\n-        }\n-        studies += \"],\";\n-        \n-    }\n-}\n-studies += \"}\";\n-\n-%>\n-\n-<%= request.getParameter(\"callback\") %>({\n+<%--\n+legacyConfig = \n+{\n     enableDarwin : <%=CheckDarwinAccessServlet.CheckDarwinAccess.existsDarwinProperties()%>,","path":"portal/src/main/webapp/config_service.jsp","position":41,"original_position":41,"commit_id":"9e155e029344bca5285982b802ba43f6d16c3179","original_commit_id":"9e155e029344bca5285982b802ba43f6d16c3179","user":{"login":"alisman","id":186521,"node_id":"MDQ6VXNlcjE4NjUyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/186521?v=4","gravatar_id":"","url":"https://api.github.com/users/alisman","html_url":"https://github.com/alisman","followers_url":"https://api.github.com/users/alisman/followers","following_url":"https://api.github.com/users/alisman/following{/other_user}","gists_url":"https://api.github.com/users/alisman/gists{/gist_id}","starred_url":"https://api.github.com/users/alisman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisman/subscriptions","organizations_url":"https://api.github.com/users/alisman/orgs","repos_url":"https://api.github.com/users/alisman/repos","events_url":"https://api.github.com/users/alisman/events{/privacy}","received_events_url":"https://api.github.com/users/alisman/received_events","type":"User","site_admin":false},"body":"i just left this legacy config here for reference.  will delete before merge","created_at":"2018-10-03T21:02:09Z","updated_at":"2018-10-03T21:02:09Z","html_url":"https://github.com/cBioPortal/cbioportal/pull/4935#discussion_r222466589","pull_request_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/4935","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/222466589"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/4935#discussion_r222466589"},"pull_request":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/4935"}}},"pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/4935","id":220173073,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTczMDcz","html_url":"https://github.com/cBioPortal/cbioportal/pull/4935","diff_url":"https://github.com/cBioPortal/cbioportal/pull/4935.diff","patch_url":"https://github.com/cBioPortal/cbioportal/pull/4935.patch","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/4935","number":4935,"state":"open","locked":false,"title":"Fix config","user":{"login":"alisman","id":186521,"node_id":"MDQ6VXNlcjE4NjUyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/186521?v=4","gravatar_id":"","url":"https://api.github.com/users/alisman","html_url":"https://github.com/alisman","followers_url":"https://api.github.com/users/alisman/followers","following_url":"https://api.github.com/users/alisman/following{/other_user}","gists_url":"https://api.github.com/users/alisman/gists{/gist_id}","starred_url":"https://api.github.com/users/alisman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisman/subscriptions","organizations_url":"https://api.github.com/users/alisman/orgs","repos_url":"https://api.github.com/users/alisman/repos","events_url":"https://api.github.com/users/alisman/events{/privacy}","received_events_url":"https://api.github.com/users/alisman/received_events","type":"User","site_admin":false},"body":"# What? Why?\r\nFix # .\r\n\r\nChanges proposed in this pull request:\r\n- a\r\n- b\r\n\r\n# Checks\r\n- [ ] Runs on Heroku.\r\n- [ ] Follows [7 rules of great commit messages](http://chris.beams.io/posts/git-commit/). For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid [merge commits, use rebase instead.](http://nathanleclaire.com/blog/2014/09/14/dont-be-scared-of-git-rebase/)\r\n- [ ] Follows the [Google Style Guide](https://github.com/google/styleguide).\r\n- [ ] If this is a feature, the PR is to rc. If this is a bug fix, the PR is to master.\r\n\r\n# Any screenshots or GIFs?\r\nIf this is a new visual feature please add a before/after screenshot or gif\r\nhere with e.g. [GifGrabber](http://www.gifgrabber.com/).\r\n","created_at":"2018-10-03T20:41:19Z","updated_at":"2018-10-03T21:02:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2840ee488dae59f18a7f190a9bbfdd06ac2506e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/4935/commits","review_comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/4935/comments","review_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/4935/comments","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/9e155e029344bca5285982b802ba43f6d16c3179","head":{"label":"alisman:fixConfig","ref":"fixConfig","sha":"9e155e029344bca5285982b802ba43f6d16c3179","user":{"login":"alisman","id":186521,"node_id":"MDQ6VXNlcjE4NjUyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/186521?v=4","gravatar_id":"","url":"https://api.github.com/users/alisman","html_url":"https://github.com/alisman","followers_url":"https://api.github.com/users/alisman/followers","following_url":"https://api.github.com/users/alisman/following{/other_user}","gists_url":"https://api.github.com/users/alisman/gists{/gist_id}","starred_url":"https://api.github.com/users/alisman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisman/subscriptions","organizations_url":"https://api.github.com/users/alisman/orgs","repos_url":"https://api.github.com/users/alisman/repos","events_url":"https://api.github.com/users/alisman/events{/privacy}","received_events_url":"https://api.github.com/users/alisman/received_events","type":"User","site_admin":false},"repo":{"id":69288034,"node_id":"MDEwOlJlcG9zaXRvcnk2OTI4ODAzNA==","name":"cbioportal","full_name":"alisman/cbioportal","private":false,"owner":{"login":"alisman","id":186521,"node_id":"MDQ6VXNlcjE4NjUyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/186521?v=4","gravatar_id":"","url":"https://api.github.com/users/alisman","html_url":"https://github.com/alisman","followers_url":"https://api.github.com/users/alisman/followers","following_url":"https://api.github.com/users/alisman/following{/other_user}","gists_url":"https://api.github.com/users/alisman/gists{/gist_id}","starred_url":"https://api.github.com/users/alisman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisman/subscriptions","organizations_url":"https://api.github.com/users/alisman/orgs","repos_url":"https://api.github.com/users/alisman/repos","events_url":"https://api.github.com/users/alisman/events{/privacy}","received_events_url":"https://api.github.com/users/alisman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alisman/cbioportal","description":"cBioPortal for Cancer Genomics","fork":true,"url":"https://api.github.com/repos/alisman/cbioportal","forks_url":"https://api.github.com/repos/alisman/cbioportal/forks","keys_url":"https://api.github.com/repos/alisman/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alisman/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alisman/cbioportal/teams","hooks_url":"https://api.github.com/repos/alisman/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/alisman/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/alisman/cbioportal/events","assignees_url":"https://api.github.com/repos/alisman/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/alisman/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/alisman/cbioportal/tags","blobs_url":"https://api.github.com/repos/alisman/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alisman/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alisman/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/alisman/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alisman/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/alisman/cbioportal/languages","stargazers_url":"https://api.github.com/repos/alisman/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/alisman/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/alisman/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/alisman/cbioportal/subscription","commits_url":"https://api.github.com/repos/alisman/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/alisman/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/alisman/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/alisman/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/alisman/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/alisman/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alisman/cbioportal/merges","archive_url":"https://api.github.com/repos/alisman/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alisman/cbioportal/downloads","issues_url":"https://api.github.com/repos/alisman/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/alisman/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/alisman/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/alisman/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alisman/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/alisman/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/alisman/cbioportal/deployments","created_at":"2016-09-26T20:02:47Z","updated_at":"2016-09-26T20:02:59Z","pushed_at":"2018-10-03T21:01:39Z","git_url":"git://github.com/alisman/cbioportal.git","ssh_url":"git@github.com:alisman/cbioportal.git","clone_url":"https://github.com/alisman/cbioportal.git","svn_url":"https://github.com/alisman/cbioportal","homepage":"http://cbioportal.org","size":219208,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"cBioPortal:spa","ref":"spa","sha":"5c2ce2461ea40ce4ab61e2d46d871c53f16c73a6","user":{"login":"cBioPortal","id":9876251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NzYyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/9876251?v=4","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"repo":{"id":32481543,"node_id":"MDEwOlJlcG9zaXRvcnkzMjQ4MTU0Mw==","name":"cbioportal","full_name":"cBioPortal/cbioportal","private":false,"owner":{"login":"cBioPortal","id":9876251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NzYyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/9876251?v=4","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cBioPortal/cbioportal","description":"cBioPortal for Cancer Genomics","fork":false,"url":"https://api.github.com/repos/cBioPortal/cbioportal","forks_url":"https://api.github.com/repos/cBioPortal/cbioportal/forks","keys_url":"https://api.github.com/repos/cBioPortal/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cBioPortal/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cBioPortal/cbioportal/teams","hooks_url":"https://api.github.com/repos/cBioPortal/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/cBioPortal/cbioportal/events","assignees_url":"https://api.github.com/repos/cBioPortal/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/cBioPortal/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/tags","blobs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/cBioPortal/cbioportal/languages","stargazers_url":"https://api.github.com/repos/cBioPortal/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/cBioPortal/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscription","commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/cBioPortal/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/cBioPortal/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cBioPortal/cbioportal/merges","archive_url":"https://api.github.com/repos/cBioPortal/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cBioPortal/cbioportal/downloads","issues_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/cBioPortal/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/cBioPortal/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/cBioPortal/cbioportal/deployments","created_at":"2015-03-18T20:09:09Z","updated_at":"2018-10-03T19:30:33Z","pushed_at":"2018-10-03T21:01:40Z","git_url":"git://github.com/cBioPortal/cbioportal.git","ssh_url":"git@github.com:cBioPortal/cbioportal.git","clone_url":"https://github.com/cBioPortal/cbioportal.git","svn_url":"https://github.com/cBioPortal/cbioportal","homepage":"http://cbioportal.org","size":218392,"stargazers_count":211,"watchers_count":211,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":196,"mirror_url":null,"archived":false,"open_issues_count":563,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":196,"open_issues":563,"watchers":211,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/4935"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/4935"},"issue":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/4935"},"comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/4935/comments"},"review_comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/4935/comments"},"review_comment":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/4935/commits"},"statuses":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/9e155e029344bca5285982b802ba43f6d16c3179"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"alisman"}}