{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/245458282","pull_request_review_id":189575343,"id":245458282,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ1ODI4Mg==","diff_hunk":"@@ -1367,11 +1363,6 @@ QScriptValue EntityItemProperties::copyToScriptValue(QScriptEngine* engine, bool\n     if (!psuedoPropertyFlagsActive || psueudoPropertyFlags.test(EntityPsuedoPropertyFlag::Type)) {\n         COPY_PROPERTY_TO_QSCRIPTVALUE_GETTER_ALWAYS(type, EntityTypes::getEntityTypeName(_type));\n     }\n-    if (!psuedoPropertyFlagsActive || psueudoPropertyFlags.test(EntityPsuedoPropertyFlag::Created)) {","path":"libraries/entities/src/EntityItemProperties.cpp","position":24,"original_position":24,"commit_id":"b5b7574c482ad2fbbeb30fe190297d46e8dda7cd","original_commit_id":"b5b7574c482ad2fbbeb30fe190297d46e8dda7cd","user":{"login":"SamGondelman","id":7650116,"node_id":"MDQ6VXNlcjc2NTAxMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7650116?v=4","gravatar_id":"","url":"https://api.github.com/users/SamGondelman","html_url":"https://github.com/SamGondelman","followers_url":"https://api.github.com/users/SamGondelman/followers","following_url":"https://api.github.com/users/SamGondelman/following{/other_user}","gists_url":"https://api.github.com/users/SamGondelman/gists{/gist_id}","starred_url":"https://api.github.com/users/SamGondelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamGondelman/subscriptions","organizations_url":"https://api.github.com/users/SamGondelman/orgs","repos_url":"https://api.github.com/users/SamGondelman/repos","events_url":"https://api.github.com/users/SamGondelman/events{/privacy}","received_events_url":"https://api.github.com/users/SamGondelman/received_events","type":"User","site_admin":false},"body":"`created` is not a pseudo property, it needs to be written all the time","created_at":"2019-01-05T00:57:31Z","updated_at":"2019-01-05T00:59:33Z","html_url":"https://github.com/highfidelity/hifi/pull/14657#discussion_r245458282","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/14657","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/245458282"},"html":{"href":"https://github.com/highfidelity/hifi/pull/14657#discussion_r245458282"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/14657"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/14657","id":242357383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMzU3Mzgz","html_url":"https://github.com/highfidelity/hifi/pull/14657","diff_url":"https://github.com/highfidelity/hifi/pull/14657.diff","patch_url":"https://github.com/highfidelity/hifi/pull/14657.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/14657","number":14657,"state":"open","locked":false,"title":"Case 20504: Trying to fix avatar entity issue","user":{"login":"SamGondelman","id":7650116,"node_id":"MDQ6VXNlcjc2NTAxMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7650116?v=4","gravatar_id":"","url":"https://api.github.com/users/SamGondelman","html_url":"https://github.com/SamGondelman","followers_url":"https://api.github.com/users/SamGondelman/followers","following_url":"https://api.github.com/users/SamGondelman/following{/other_user}","gists_url":"https://api.github.com/users/SamGondelman/gists{/gist_id}","starred_url":"https://api.github.com/users/SamGondelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamGondelman/subscriptions","organizations_url":"https://api.github.com/users/SamGondelman/orgs","repos_url":"https://api.github.com/users/SamGondelman/repos","events_url":"https://api.github.com/users/SamGondelman/events{/privacy}","received_events_url":"https://api.github.com/users/SamGondelman/received_events","type":"User","site_admin":false},"body":"https://highfidelity.manuscript.com/f/cases/20504/AvatarEntity-with-finite-lifetime-vanishes-immediately\r\n\r\nTest plan:\r\n- Run a server from this PR.  Go there and have someone else join you.\r\n- One of you runs this from the console:\r\n```\r\nEntities.addEntity({\r\n    type: \"Model\",\r\n    modelURL: \"http://hifi-content.s3.amazonaws.com/alan/dev/Cowboy-hat.fbx?2\",\r\n    shapeType: \"simple-hull\",\r\n    localPosition: { x:0, y:0.2, z:0 },\r\n    name: \"hat\",\r\n    dynamic: false,\r\n    collisionless: true,\r\n    parentID: MyAvatar.sessionUUID,\r\n    parentJointIndex: MyAvatar.getJointIndex(\"Head\"),\r\n    lifetime: 300,\r\n    dimensions: { x: 0.3239, y: 0.15, z: 0.3779 }\r\n}, true);\r\n```\r\n- Both of you see the hat appear.  Both of you can select the hat in Create.","created_at":"2019-01-04T19:55:22Z","updated_at":"2019-01-05T00:59:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9386f5305227a63cc7dffcd3b7bf6ab2b0b7a931","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sethalves","id":1137072,"node_id":"MDQ6VXNlcjExMzcwNzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1137072?v=4","gravatar_id":"","url":"https://api.github.com/users/sethalves","html_url":"https://github.com/sethalves","followers_url":"https://api.github.com/users/sethalves/followers","following_url":"https://api.github.com/users/sethalves/following{/other_user}","gists_url":"https://api.github.com/users/sethalves/gists{/gist_id}","starred_url":"https://api.github.com/users/sethalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethalves/subscriptions","organizations_url":"https://api.github.com/users/sethalves/orgs","repos_url":"https://api.github.com/users/sethalves/repos","events_url":"https://api.github.com/users/sethalves/events{/privacy}","received_events_url":"https://api.github.com/users/sethalves/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":412774488,"node_id":"MDU6TGFiZWw0MTI3NzQ0ODg=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Critical%20Fix","name":"Critical Fix","color":"fbca04","default":false},{"id":1119767751,"node_id":"MDU6TGFiZWwxMTE5NzY3NzUx","url":"https://api.github.com/repos/highfidelity/hifi/labels/Development%20Ready","name":"Development Ready","color":"bfdadc","default":false},{"id":675876856,"node_id":"MDU6TGFiZWw2NzU4NzY4NTY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Engine","name":"Engine","color":"A2277C","default":false},{"id":374042454,"node_id":"MDU6TGFiZWwzNzQwNDI0NTQ=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Packet%20Version%20Change","name":"Packet Version Change","color":"1d76db","default":false},{"id":733764234,"node_id":"MDU6TGFiZWw3MzM3NjQyMzQ=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Project%20Approved","name":"Project Approved","color":"009800","default":false},{"id":11332862,"node_id":"MDU6TGFiZWwxMTMzMjg2Mg==","url":"https://api.github.com/repos/highfidelity/hifi/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/38","html_url":"https://github.com/highfidelity/hifi/milestone/38","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/38/labels","id":3290838,"node_id":"MDk6TWlsZXN0b25lMzI5MDgzOA==","number":38,"title":"v0.78.0","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":56,"state":"open","created_at":"2018-04-23T19:27:30Z","updated_at":"2019-01-05T00:22:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/14657/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/14657/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/14657/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/b5b7574c482ad2fbbeb30fe190297d46e8dda7cd","head":{"label":"SamGondelman:propFix","ref":"propFix","sha":"b5b7574c482ad2fbbeb30fe190297d46e8dda7cd","user":{"login":"SamGondelman","id":7650116,"node_id":"MDQ6VXNlcjc2NTAxMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7650116?v=4","gravatar_id":"","url":"https://api.github.com/users/SamGondelman","html_url":"https://github.com/SamGondelman","followers_url":"https://api.github.com/users/SamGondelman/followers","following_url":"https://api.github.com/users/SamGondelman/following{/other_user}","gists_url":"https://api.github.com/users/SamGondelman/gists{/gist_id}","starred_url":"https://api.github.com/users/SamGondelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamGondelman/subscriptions","organizations_url":"https://api.github.com/users/SamGondelman/orgs","repos_url":"https://api.github.com/users/SamGondelman/repos","events_url":"https://api.github.com/users/SamGondelman/events{/privacy}","received_events_url":"https://api.github.com/users/SamGondelman/received_events","type":"User","site_admin":false},"repo":{"id":36534104,"node_id":"MDEwOlJlcG9zaXRvcnkzNjUzNDEwNA==","name":"hifi","full_name":"SamGondelman/hifi","private":false,"owner":{"login":"SamGondelman","id":7650116,"node_id":"MDQ6VXNlcjc2NTAxMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7650116?v=4","gravatar_id":"","url":"https://api.github.com/users/SamGondelman","html_url":"https://github.com/SamGondelman","followers_url":"https://api.github.com/users/SamGondelman/followers","following_url":"https://api.github.com/users/SamGondelman/following{/other_user}","gists_url":"https://api.github.com/users/SamGondelman/gists{/gist_id}","starred_url":"https://api.github.com/users/SamGondelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamGondelman/subscriptions","organizations_url":"https://api.github.com/users/SamGondelman/orgs","repos_url":"https://api.github.com/users/SamGondelman/repos","events_url":"https://api.github.com/users/SamGondelman/events{/privacy}","received_events_url":"https://api.github.com/users/SamGondelman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SamGondelman/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/SamGondelman/hifi","forks_url":"https://api.github.com/repos/SamGondelman/hifi/forks","keys_url":"https://api.github.com/repos/SamGondelman/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamGondelman/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamGondelman/hifi/teams","hooks_url":"https://api.github.com/repos/SamGondelman/hifi/hooks","issue_events_url":"https://api.github.com/repos/SamGondelman/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/SamGondelman/hifi/events","assignees_url":"https://api.github.com/repos/SamGondelman/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/SamGondelman/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/SamGondelman/hifi/tags","blobs_url":"https://api.github.com/repos/SamGondelman/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamGondelman/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamGondelman/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamGondelman/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamGondelman/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/SamGondelman/hifi/languages","stargazers_url":"https://api.github.com/repos/SamGondelman/hifi/stargazers","contributors_url":"https://api.github.com/repos/SamGondelman/hifi/contributors","subscribers_url":"https://api.github.com/repos/SamGondelman/hifi/subscribers","subscription_url":"https://api.github.com/repos/SamGondelman/hifi/subscription","commits_url":"https://api.github.com/repos/SamGondelman/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamGondelman/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamGondelman/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamGondelman/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamGondelman/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/SamGondelman/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamGondelman/hifi/merges","archive_url":"https://api.github.com/repos/SamGondelman/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamGondelman/hifi/downloads","issues_url":"https://api.github.com/repos/SamGondelman/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/SamGondelman/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/SamGondelman/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/SamGondelman/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamGondelman/hifi/labels{/name}","releases_url":"https://api.github.com/repos/SamGondelman/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/SamGondelman/hifi/deployments","created_at":"2015-05-29T23:20:11Z","updated_at":"2019-01-04T18:44:39Z","pushed_at":"2019-01-05T00:52:23Z","git_url":"git://github.com/SamGondelman/hifi.git","ssh_url":"git@github.com:SamGondelman/hifi.git","clone_url":"https://github.com/SamGondelman/hifi.git","svn_url":"https://github.com/SamGondelman/hifi","homepage":"","size":587898,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"4e5d275768847d9739bc97571407f0c6c320f33e","user":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"node_id":"MDEwOlJlcG9zaXRvcnk1MzcyODcy","name":"hifi","full_name":"highfidelity/hifi","private":false,"owner":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2019-01-05T00:22:30Z","pushed_at":"2019-01-05T00:52:25Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":588904,"stargazers_count":691,"watchers_count":691,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":431,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":431,"open_issues":167,"watchers":691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/14657"},"html":{"href":"https://github.com/highfidelity/hifi/pull/14657"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/14657"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/14657/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/14657/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/14657/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/b5b7574c482ad2fbbeb30fe190297d46e8dda7cd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SamGondelman"}}