{"action":"created","comment":{"url":"https://api.github.com/repos/macports/macports-ports/pulls/comments/219760321","pull_request_review_id":158009420,"id":219760321,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTc2MDMyMQ==","diff_hunk":"@@ -30,7 +30,11 @@ if {${subport} eq \"${name}\"} {\n \n     checksums           rmd160  ad84d422534a69c49a85017e0f04ba050115fb89 \\\n                         sha256  c23e6a1ccd0368c089e74772c02a420a5b475fdeb205ae6be39a93b3abeda965 \\\n-                        size    13578523\n+        size    13578523","path":"cad/LibreCAD/Portfile","position":5,"original_position":5,"commit_id":"ef5cce8e8cbc5d21c797295fdb21da337844f38f","original_commit_id":"ef5cce8e8cbc5d21c797295fdb21da337844f38f","user":{"login":"mojca","id":15606,"node_id":"MDQ6VXNlcjE1NjA2","avatar_url":"https://avatars3.githubusercontent.com/u/15606?v=4","gravatar_id":"","url":"https://api.github.com/users/mojca","html_url":"https://github.com/mojca","followers_url":"https://api.github.com/users/mojca/followers","following_url":"https://api.github.com/users/mojca/following{/other_user}","gists_url":"https://api.github.com/users/mojca/gists{/gist_id}","starred_url":"https://api.github.com/users/mojca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojca/subscriptions","organizations_url":"https://api.github.com/users/mojca/orgs","repos_url":"https://api.github.com/users/mojca/repos","events_url":"https://api.github.com/users/mojca/events{/privacy}","received_events_url":"https://api.github.com/users/mojca/received_events","type":"User","site_admin":false},"body":"What I would usually do is the following:\r\n```\r\ngit checkout librecad_qt511\r\n# edit the file\r\ngit add cad/LibreCAD/Portfile\r\ngit commit --amend\r\ngit push -f <your-repo>\r\n```\r\nThe `git commit --amend` will do a change to the last commit, while `git reset --soft HEAD^` will first undo the last commit and then you would make a new one. Resetting is usually more helpful when you added unwanted changes (and unwanted files) to the commit, while `git commit --amend` is a shortcut for trivial changes or when you want to change the commit message.\r\n\r\nThe important part is to force push the changes to the branch.","created_at":"2018-09-24T08:32:37Z","updated_at":"2018-09-24T08:32:37Z","html_url":"https://github.com/macports/macports-ports/pull/2624#discussion_r219760321","pull_request_url":"https://api.github.com/repos/macports/macports-ports/pulls/2624","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/comments/219760321"},"html":{"href":"https://github.com/macports/macports-ports/pull/2624#discussion_r219760321"},"pull_request":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/2624"}},"in_reply_to_id":219672481},"pull_request":{"url":"https://api.github.com/repos/macports/macports-ports/pulls/2624","id":217390443,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzkwNDQz","html_url":"https://github.com/macports/macports-ports/pull/2624","diff_url":"https://github.com/macports/macports-ports/pull/2624.diff","patch_url":"https://github.com/macports/macports-ports/pull/2624.patch","issue_url":"https://api.github.com/repos/macports/macports-ports/issues/2624","number":2624,"state":"open","locked":false,"title":"librecad-devel: fix for qt-5.11","user":{"login":"jjstickel","id":333148,"node_id":"MDQ6VXNlcjMzMzE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/333148?v=4","gravatar_id":"","url":"https://api.github.com/users/jjstickel","html_url":"https://github.com/jjstickel","followers_url":"https://api.github.com/users/jjstickel/followers","following_url":"https://api.github.com/users/jjstickel/following{/other_user}","gists_url":"https://api.github.com/users/jjstickel/gists{/gist_id}","starred_url":"https://api.github.com/users/jjstickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjstickel/subscriptions","organizations_url":"https://api.github.com/users/jjstickel/orgs","repos_url":"https://api.github.com/users/jjstickel/repos","events_url":"https://api.github.com/users/jjstickel/events{/privacy}","received_events_url":"https://api.github.com/users/jjstickel/received_events","type":"User","site_admin":false},"body":"* patch for qt-5.11\r\n* librecad (not devel) still broken\r\n\r\n#### Description\r\n\r\nLibreCAD sources need to be patched to work with qt-5.11. This PR does this for librecad-devel, but the source patch does not apply cleanly to librecad @2.1.3 (not devel). A different patch or using earlier versions of qt5 are potential solutions.\r\n\r\n###### Type(s)\r\n\r\n- [x] bugfix\r\n\r\n###### Tested on\r\n\r\nmacOS 10.12.6 16G1510\r\nXcode 9.0 9A235\r\n\r\n###### Verification <!-- (delete not applicable items) -->\r\nHave you\r\n\r\n- [x] followed our [Commit Message Guidelines](https://trac.macports.org/wiki/CommitMessages)?\r\n- [x] squashed and [minimized your commits](https://guide.macports.org/#project.github)?\r\n- [x] checked that there aren't other open [pull requests](https://github.com/macports/macports-ports/pulls) for the same change?\r\n- [ ] referenced existing tickets on [Trac](https://trac.macports.org/wiki/Tickets) with full URL?\r\n<!-- Please don't open a new Trac ticket if you are submitting a pull request. -->\r\n- [x] checked your Portfile with `port lint`?\r\n- [ ] tried existing tests with `sudo port test`?\r\n- [x] tried a full install with `sudo port -vst install`?\r\n- [x] tested basic functionality of all binary files?\r\n\r\n<!-- Use \"skip notification\" (surrounded with []) to avoid notifying maintainers -->\r\n","created_at":"2018-09-21T20:16:15Z","updated_at":"2018-09-24T08:32:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"849b61a37ce08d64df2964dc0569d668632c0c98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":598559460,"node_id":"MDU6TGFiZWw1OTg1NTk0NjA=","url":"https://api.github.com/repos/macports/macports-ports/labels/maintainer:%20none","name":"maintainer: none","color":"c2e0c6","default":false},{"id":457720719,"node_id":"MDU6TGFiZWw0NTc3MjA3MTk=","url":"https://api.github.com/repos/macports/macports-ports/labels/type:%20bugfix","name":"type: bugfix","color":"ee0701","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/macports/macports-ports/pulls/2624/commits","review_comments_url":"https://api.github.com/repos/macports/macports-ports/pulls/2624/comments","review_comment_url":"https://api.github.com/repos/macports/macports-ports/pulls/comments{/number}","comments_url":"https://api.github.com/repos/macports/macports-ports/issues/2624/comments","statuses_url":"https://api.github.com/repos/macports/macports-ports/statuses/ef5cce8e8cbc5d21c797295fdb21da337844f38f","head":{"label":"jjstickel:librecad_qt511","ref":"librecad_qt511","sha":"ef5cce8e8cbc5d21c797295fdb21da337844f38f","user":{"login":"jjstickel","id":333148,"node_id":"MDQ6VXNlcjMzMzE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/333148?v=4","gravatar_id":"","url":"https://api.github.com/users/jjstickel","html_url":"https://github.com/jjstickel","followers_url":"https://api.github.com/users/jjstickel/followers","following_url":"https://api.github.com/users/jjstickel/following{/other_user}","gists_url":"https://api.github.com/users/jjstickel/gists{/gist_id}","starred_url":"https://api.github.com/users/jjstickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjstickel/subscriptions","organizations_url":"https://api.github.com/users/jjstickel/orgs","repos_url":"https://api.github.com/users/jjstickel/repos","events_url":"https://api.github.com/users/jjstickel/events{/privacy}","received_events_url":"https://api.github.com/users/jjstickel/received_events","type":"User","site_admin":false},"repo":{"id":128458877,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0NTg4Nzc=","name":"macports-ports","full_name":"jjstickel/macports-ports","private":false,"owner":{"login":"jjstickel","id":333148,"node_id":"MDQ6VXNlcjMzMzE0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/333148?v=4","gravatar_id":"","url":"https://api.github.com/users/jjstickel","html_url":"https://github.com/jjstickel","followers_url":"https://api.github.com/users/jjstickel/followers","following_url":"https://api.github.com/users/jjstickel/following{/other_user}","gists_url":"https://api.github.com/users/jjstickel/gists{/gist_id}","starred_url":"https://api.github.com/users/jjstickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjstickel/subscriptions","organizations_url":"https://api.github.com/users/jjstickel/orgs","repos_url":"https://api.github.com/users/jjstickel/repos","events_url":"https://api.github.com/users/jjstickel/events{/privacy}","received_events_url":"https://api.github.com/users/jjstickel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jjstickel/macports-ports","description":"The MacPorts ports tree","fork":true,"url":"https://api.github.com/repos/jjstickel/macports-ports","forks_url":"https://api.github.com/repos/jjstickel/macports-ports/forks","keys_url":"https://api.github.com/repos/jjstickel/macports-ports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjstickel/macports-ports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjstickel/macports-ports/teams","hooks_url":"https://api.github.com/repos/jjstickel/macports-ports/hooks","issue_events_url":"https://api.github.com/repos/jjstickel/macports-ports/issues/events{/number}","events_url":"https://api.github.com/repos/jjstickel/macports-ports/events","assignees_url":"https://api.github.com/repos/jjstickel/macports-ports/assignees{/user}","branches_url":"https://api.github.com/repos/jjstickel/macports-ports/branches{/branch}","tags_url":"https://api.github.com/repos/jjstickel/macports-ports/tags","blobs_url":"https://api.github.com/repos/jjstickel/macports-ports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjstickel/macports-ports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjstickel/macports-ports/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjstickel/macports-ports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjstickel/macports-ports/statuses/{sha}","languages_url":"https://api.github.com/repos/jjstickel/macports-ports/languages","stargazers_url":"https://api.github.com/repos/jjstickel/macports-ports/stargazers","contributors_url":"https://api.github.com/repos/jjstickel/macports-ports/contributors","subscribers_url":"https://api.github.com/repos/jjstickel/macports-ports/subscribers","subscription_url":"https://api.github.com/repos/jjstickel/macports-ports/subscription","commits_url":"https://api.github.com/repos/jjstickel/macports-ports/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjstickel/macports-ports/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjstickel/macports-ports/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjstickel/macports-ports/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjstickel/macports-ports/contents/{+path}","compare_url":"https://api.github.com/repos/jjstickel/macports-ports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjstickel/macports-ports/merges","archive_url":"https://api.github.com/repos/jjstickel/macports-ports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjstickel/macports-ports/downloads","issues_url":"https://api.github.com/repos/jjstickel/macports-ports/issues{/number}","pulls_url":"https://api.github.com/repos/jjstickel/macports-ports/pulls{/number}","milestones_url":"https://api.github.com/repos/jjstickel/macports-ports/milestones{/number}","notifications_url":"https://api.github.com/repos/jjstickel/macports-ports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjstickel/macports-ports/labels{/name}","releases_url":"https://api.github.com/repos/jjstickel/macports-ports/releases{/id}","deployments_url":"https://api.github.com/repos/jjstickel/macports-ports/deployments","created_at":"2018-04-06T19:38:33Z","updated_at":"2018-09-21T19:01:35Z","pushed_at":"2018-09-21T20:10:16Z","git_url":"git://github.com/jjstickel/macports-ports.git","ssh_url":"git@github.com:jjstickel/macports-ports.git","clone_url":"https://github.com/jjstickel/macports-ports.git","svn_url":"https://github.com/jjstickel/macports-ports","homepage":"https://trac.macports.org","size":165404,"stargazers_count":0,"watchers_count":0,"language":"Tcl","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"macports:master","ref":"master","sha":"c0c8370e4852083885977f7dd1db0ee798bcb7e3","user":{"login":"macports","id":4225322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjUzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4225322?v=4","gravatar_id":"","url":"https://api.github.com/users/macports","html_url":"https://github.com/macports","followers_url":"https://api.github.com/users/macports/followers","following_url":"https://api.github.com/users/macports/following{/other_user}","gists_url":"https://api.github.com/users/macports/gists{/gist_id}","starred_url":"https://api.github.com/users/macports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macports/subscriptions","organizations_url":"https://api.github.com/users/macports/orgs","repos_url":"https://api.github.com/users/macports/repos","events_url":"https://api.github.com/users/macports/events{/privacy}","received_events_url":"https://api.github.com/users/macports/received_events","type":"Organization","site_admin":false},"repo":{"id":70365100,"node_id":"MDEwOlJlcG9zaXRvcnk3MDM2NTEwMA==","name":"macports-ports","full_name":"macports/macports-ports","private":false,"owner":{"login":"macports","id":4225322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjUzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4225322?v=4","gravatar_id":"","url":"https://api.github.com/users/macports","html_url":"https://github.com/macports","followers_url":"https://api.github.com/users/macports/followers","following_url":"https://api.github.com/users/macports/following{/other_user}","gists_url":"https://api.github.com/users/macports/gists{/gist_id}","starred_url":"https://api.github.com/users/macports/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macports/subscriptions","organizations_url":"https://api.github.com/users/macports/orgs","repos_url":"https://api.github.com/users/macports/repos","events_url":"https://api.github.com/users/macports/events{/privacy}","received_events_url":"https://api.github.com/users/macports/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/macports/macports-ports","description":"The MacPorts ports tree","fork":false,"url":"https://api.github.com/repos/macports/macports-ports","forks_url":"https://api.github.com/repos/macports/macports-ports/forks","keys_url":"https://api.github.com/repos/macports/macports-ports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macports/macports-ports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macports/macports-ports/teams","hooks_url":"https://api.github.com/repos/macports/macports-ports/hooks","issue_events_url":"https://api.github.com/repos/macports/macports-ports/issues/events{/number}","events_url":"https://api.github.com/repos/macports/macports-ports/events","assignees_url":"https://api.github.com/repos/macports/macports-ports/assignees{/user}","branches_url":"https://api.github.com/repos/macports/macports-ports/branches{/branch}","tags_url":"https://api.github.com/repos/macports/macports-ports/tags","blobs_url":"https://api.github.com/repos/macports/macports-ports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macports/macports-ports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macports/macports-ports/git/refs{/sha}","trees_url":"https://api.github.com/repos/macports/macports-ports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macports/macports-ports/statuses/{sha}","languages_url":"https://api.github.com/repos/macports/macports-ports/languages","stargazers_url":"https://api.github.com/repos/macports/macports-ports/stargazers","contributors_url":"https://api.github.com/repos/macports/macports-ports/contributors","subscribers_url":"https://api.github.com/repos/macports/macports-ports/subscribers","subscription_url":"https://api.github.com/repos/macports/macports-ports/subscription","commits_url":"https://api.github.com/repos/macports/macports-ports/commits{/sha}","git_commits_url":"https://api.github.com/repos/macports/macports-ports/git/commits{/sha}","comments_url":"https://api.github.com/repos/macports/macports-ports/comments{/number}","issue_comment_url":"https://api.github.com/repos/macports/macports-ports/issues/comments{/number}","contents_url":"https://api.github.com/repos/macports/macports-ports/contents/{+path}","compare_url":"https://api.github.com/repos/macports/macports-ports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macports/macports-ports/merges","archive_url":"https://api.github.com/repos/macports/macports-ports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macports/macports-ports/downloads","issues_url":"https://api.github.com/repos/macports/macports-ports/issues{/number}","pulls_url":"https://api.github.com/repos/macports/macports-ports/pulls{/number}","milestones_url":"https://api.github.com/repos/macports/macports-ports/milestones{/number}","notifications_url":"https://api.github.com/repos/macports/macports-ports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macports/macports-ports/labels{/name}","releases_url":"https://api.github.com/repos/macports/macports-ports/releases{/id}","deployments_url":"https://api.github.com/repos/macports/macports-ports/deployments","created_at":"2016-10-09T00:31:44Z","updated_at":"2018-09-24T07:24:37Z","pushed_at":"2018-09-24T07:30:25Z","git_url":"git://github.com/macports/macports-ports.git","ssh_url":"git@github.com:macports/macports-ports.git","clone_url":"https://github.com/macports/macports-ports.git","svn_url":"https://github.com/macports/macports-ports","homepage":"https://trac.macports.org","size":165517,"stargazers_count":423,"watchers_count":423,"language":"Tcl","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":410,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":410,"open_issues":24,"watchers":423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/2624"},"html":{"href":"https://github.com/macports/macports-ports/pull/2624"},"issue":{"href":"https://api.github.com/repos/macports/macports-ports/issues/2624"},"comments":{"href":"https://api.github.com/repos/macports/macports-ports/issues/2624/comments"},"review_comments":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/2624/comments"},"review_comment":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/macports/macports-ports/pulls/2624/commits"},"statuses":{"href":"https://api.github.com/repos/macports/macports-ports/statuses/ef5cce8e8cbc5d21c797295fdb21da337844f38f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mojca"}}