{"action":"created","comment":{"url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/comments/211757166","pull_request_review_id":148247552,"id":211757166,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTc1NzE2Ng==","diff_hunk":"@@ -294,6 +292,7 @@ describe(\"sorting and indexing\", () => {\n       expect(indexVals[13] === \"asdf\").toEqual(true);\n     });\n \n+    /*","path":"packages/loki/spec/generic/sortingIndexing.spec.ts","position":null,"original_position":37,"commit_id":"d0d77ae0b87c98d9e6c79e84e8d0f968b0675cdd","original_commit_id":"d9be137702badaf2257f829c4ef85715ed51a982","user":{"login":"obeliskos","id":7353046,"node_id":"MDQ6VXNlcjczNTMwNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7353046?v=4","gravatar_id":"","url":"https://api.github.com/users/obeliskos","html_url":"https://github.com/obeliskos","followers_url":"https://api.github.com/users/obeliskos/followers","following_url":"https://api.github.com/users/obeliskos/following{/other_user}","gists_url":"https://api.github.com/users/obeliskos/gists{/gist_id}","starred_url":"https://api.github.com/users/obeliskos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obeliskos/subscriptions","organizations_url":"https://api.github.com/users/obeliskos/orgs","repos_url":"https://api.github.com/users/obeliskos/repos","events_url":"https://api.github.com/users/obeliskos/events{/privacy}","received_events_url":"https://api.github.com/users/obeliskos/received_events","type":"User","site_admin":false},"body":"Added back core logic for that one unit test;  \r\n\r\nBefore going live with v1.0 I will probably want to reassess date operators either in default \"js\" operator package or \"loki\" abstract operator package (which we will make default when upgrading legacy lokijs databases)","created_at":"2018-08-21T20:56:08Z","updated_at":"2018-08-21T20:56:08Z","html_url":"https://github.com/LokiJS-Forge/LokiDB/pull/152#discussion_r211757166","pull_request_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/152","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/comments/211757166"},"html":{"href":"https://github.com/LokiJS-Forge/LokiDB/pull/152#discussion_r211757166"},"pull_request":{"href":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/152"}},"in_reply_to_id":211697293},"pull_request":{"url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/152","id":209305316,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzA1MzE2","html_url":"https://github.com/LokiJS-Forge/LokiDB/pull/152","diff_url":"https://github.com/LokiJS-Forge/LokiDB/pull/152.diff","patch_url":"https://github.com/LokiJS-Forge/LokiDB/pull/152.patch","issue_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/issues/152","number":152,"state":"open","locked":false,"title":"feat(loki): user definable comparators and operator packages","user":{"login":"obeliskos","id":7353046,"node_id":"MDQ6VXNlcjczNTMwNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7353046?v=4","gravatar_id":"","url":"https://api.github.com/users/obeliskos","html_url":"https://github.com/obeliskos","followers_url":"https://api.github.com/users/obeliskos/followers","following_url":"https://api.github.com/users/obeliskos/following{/other_user}","gists_url":"https://api.github.com/users/obeliskos/gists{/gist_id}","starred_url":"https://api.github.com/users/obeliskos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obeliskos/subscriptions","organizations_url":"https://api.github.com/users/obeliskos/orgs","repos_url":"https://api.github.com/users/obeliskos/repos","events_url":"https://api.github.com/users/obeliskos/events{/privacy}","received_events_url":"https://api.github.com/users/obeliskos/received_events","type":"User","site_admin":false},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [ ] The commit message follows our guidelines: https://github.com/LokiJS-Forge/LokiDB/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[ ] Bugfix\r\n[x] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\nCurrently, comparisons between unindexed finds, indexed finds, and sorting are utilizing the same 'helper' functions which are not easily 'tuned' for performance.  Only one implementation currently exists for our opererators within 'LokiOps'\r\n\r\nIssue Number: N/A\r\n\r\n\r\n## What is the new behavior?\r\nA named registration map of Comparators now exists for reference throughout LokiDB.  Multiple implementations of our operator packages now exist to allow backwards compatibility or tuned for different purposes or functionality.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\n","created_at":"2018-08-18T10:10:48Z","updated_at":"2018-08-21T20:56:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"488d48f5af043d9ccf52e4d06c3038f803b7f828","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/152/commits","review_comments_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/152/comments","review_comment_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/issues/152/comments","statuses_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/statuses/d0d77ae0b87c98d9e6c79e84e8d0f968b0675cdd","head":{"label":"LokiJS-Forge:feature/unindexed_comparators","ref":"feature/unindexed_comparators","sha":"d0d77ae0b87c98d9e6c79e84e8d0f968b0675cdd","user":{"login":"LokiJS-Forge","id":25157910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU3OTEw","avatar_url":"https://avatars3.githubusercontent.com/u/25157910?v=4","gravatar_id":"","url":"https://api.github.com/users/LokiJS-Forge","html_url":"https://github.com/LokiJS-Forge","followers_url":"https://api.github.com/users/LokiJS-Forge/followers","following_url":"https://api.github.com/users/LokiJS-Forge/following{/other_user}","gists_url":"https://api.github.com/users/LokiJS-Forge/gists{/gist_id}","starred_url":"https://api.github.com/users/LokiJS-Forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LokiJS-Forge/subscriptions","organizations_url":"https://api.github.com/users/LokiJS-Forge/orgs","repos_url":"https://api.github.com/users/LokiJS-Forge/repos","events_url":"https://api.github.com/users/LokiJS-Forge/events{/privacy}","received_events_url":"https://api.github.com/users/LokiJS-Forge/received_events","type":"Organization","site_admin":false},"repo":{"id":79145788,"node_id":"MDEwOlJlcG9zaXRvcnk3OTE0NTc4OA==","name":"LokiDB","full_name":"LokiJS-Forge/LokiDB","owner":{"login":"LokiJS-Forge","id":25157910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU3OTEw","avatar_url":"https://avatars3.githubusercontent.com/u/25157910?v=4","gravatar_id":"","url":"https://api.github.com/users/LokiJS-Forge","html_url":"https://github.com/LokiJS-Forge","followers_url":"https://api.github.com/users/LokiJS-Forge/followers","following_url":"https://api.github.com/users/LokiJS-Forge/following{/other_user}","gists_url":"https://api.github.com/users/LokiJS-Forge/gists{/gist_id}","starred_url":"https://api.github.com/users/LokiJS-Forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LokiJS-Forge/subscriptions","organizations_url":"https://api.github.com/users/LokiJS-Forge/orgs","repos_url":"https://api.github.com/users/LokiJS-Forge/repos","events_url":"https://api.github.com/users/LokiJS-Forge/events{/privacy}","received_events_url":"https://api.github.com/users/LokiJS-Forge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LokiJS-Forge/LokiDB","description":"blazing fast, feature-rich in-memory database written in TypeScript","fork":false,"url":"https://api.github.com/repos/LokiJS-Forge/LokiDB","forks_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/forks","keys_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/teams","hooks_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/hooks","issue_events_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/issues/events{/number}","events_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/events","assignees_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/assignees{/user}","branches_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/branches{/branch}","tags_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/tags","blobs_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/statuses/{sha}","languages_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/languages","stargazers_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/stargazers","contributors_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/contributors","subscribers_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/subscribers","subscription_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/subscription","commits_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/contents/{+path}","compare_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/merges","archive_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/downloads","issues_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/issues{/number}","pulls_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls{/number}","milestones_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/milestones{/number}","notifications_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/labels{/name}","releases_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/releases{/id}","deployments_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/deployments","created_at":"2017-01-16T18:18:41Z","updated_at":"2018-08-19T14:42:10Z","pushed_at":"2018-08-21T20:40:02Z","git_url":"git://github.com/LokiJS-Forge/LokiDB.git","ssh_url":"git@github.com:LokiJS-Forge/LokiDB.git","clone_url":"https://github.com/LokiJS-Forge/LokiDB.git","svn_url":"https://github.com/LokiJS-Forge/LokiDB","homepage":"","size":6256,"stargazers_count":48,"watchers_count":48,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":18,"watchers":48,"default_branch":"master"}},"base":{"label":"LokiJS-Forge:master","ref":"master","sha":"9944921185780665fe7e369c6ebe63469d343880","user":{"login":"LokiJS-Forge","id":25157910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU3OTEw","avatar_url":"https://avatars3.githubusercontent.com/u/25157910?v=4","gravatar_id":"","url":"https://api.github.com/users/LokiJS-Forge","html_url":"https://github.com/LokiJS-Forge","followers_url":"https://api.github.com/users/LokiJS-Forge/followers","following_url":"https://api.github.com/users/LokiJS-Forge/following{/other_user}","gists_url":"https://api.github.com/users/LokiJS-Forge/gists{/gist_id}","starred_url":"https://api.github.com/users/LokiJS-Forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LokiJS-Forge/subscriptions","organizations_url":"https://api.github.com/users/LokiJS-Forge/orgs","repos_url":"https://api.github.com/users/LokiJS-Forge/repos","events_url":"https://api.github.com/users/LokiJS-Forge/events{/privacy}","received_events_url":"https://api.github.com/users/LokiJS-Forge/received_events","type":"Organization","site_admin":false},"repo":{"id":79145788,"node_id":"MDEwOlJlcG9zaXRvcnk3OTE0NTc4OA==","name":"LokiDB","full_name":"LokiJS-Forge/LokiDB","owner":{"login":"LokiJS-Forge","id":25157910,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU3OTEw","avatar_url":"https://avatars3.githubusercontent.com/u/25157910?v=4","gravatar_id":"","url":"https://api.github.com/users/LokiJS-Forge","html_url":"https://github.com/LokiJS-Forge","followers_url":"https://api.github.com/users/LokiJS-Forge/followers","following_url":"https://api.github.com/users/LokiJS-Forge/following{/other_user}","gists_url":"https://api.github.com/users/LokiJS-Forge/gists{/gist_id}","starred_url":"https://api.github.com/users/LokiJS-Forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LokiJS-Forge/subscriptions","organizations_url":"https://api.github.com/users/LokiJS-Forge/orgs","repos_url":"https://api.github.com/users/LokiJS-Forge/repos","events_url":"https://api.github.com/users/LokiJS-Forge/events{/privacy}","received_events_url":"https://api.github.com/users/LokiJS-Forge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LokiJS-Forge/LokiDB","description":"blazing fast, feature-rich in-memory database written in TypeScript","fork":false,"url":"https://api.github.com/repos/LokiJS-Forge/LokiDB","forks_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/forks","keys_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/teams","hooks_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/hooks","issue_events_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/issues/events{/number}","events_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/events","assignees_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/assignees{/user}","branches_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/branches{/branch}","tags_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/tags","blobs_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/statuses/{sha}","languages_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/languages","stargazers_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/stargazers","contributors_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/contributors","subscribers_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/subscribers","subscription_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/subscription","commits_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/contents/{+path}","compare_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/merges","archive_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/downloads","issues_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/issues{/number}","pulls_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls{/number}","milestones_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/milestones{/number}","notifications_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/labels{/name}","releases_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/releases{/id}","deployments_url":"https://api.github.com/repos/LokiJS-Forge/LokiDB/deployments","created_at":"2017-01-16T18:18:41Z","updated_at":"2018-08-19T14:42:10Z","pushed_at":"2018-08-21T20:40:02Z","git_url":"git://github.com/LokiJS-Forge/LokiDB.git","ssh_url":"git@github.com:LokiJS-Forge/LokiDB.git","clone_url":"https://github.com/LokiJS-Forge/LokiDB.git","svn_url":"https://github.com/LokiJS-Forge/LokiDB","homepage":"","size":6256,"stargazers_count":48,"watchers_count":48,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":18,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/152"},"html":{"href":"https://github.com/LokiJS-Forge/LokiDB/pull/152"},"issue":{"href":"https://api.github.com/repos/LokiJS-Forge/LokiDB/issues/152"},"comments":{"href":"https://api.github.com/repos/LokiJS-Forge/LokiDB/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LokiJS-Forge/LokiDB/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/LokiJS-Forge/LokiDB/statuses/d0d77ae0b87c98d9e6c79e84e8d0f968b0675cdd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"obeliskos"}}