{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/plutus/pulls/comments/235945794","pull_request_review_id":177933129,"id":235945794,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTk0NTc5NA==","diff_hunk":"@@ -38,6 +38,8 @@\n - ignore: {name: Redundant if, within: [Language.Plutus.Coordination.Contracts.CrowdFunding, Language.Plutus.Coordination.Contracts.Vesting, Language.Plutus.Runtime.TH]}\n # This is rarely better, and often more confusing\n - ignore: {name: Use asks}\n+# It seems clearer to use case than fromMaybe\n+- ignore: {name: fromMaybe}","path":".hlint.yaml","position":5,"original_position":5,"commit_id":"59afff5039800d73f5702a4dd1597375da0c0445","original_commit_id":"59afff5039800d73f5702a4dd1597375da0c0445","user":{"login":"effectfully","id":10480926,"node_id":"MDQ6VXNlcjEwNDgwOTI2","avatar_url":"https://avatars1.githubusercontent.com/u/10480926?v=4","gravatar_id":"","url":"https://api.github.com/users/effectfully","html_url":"https://github.com/effectfully","followers_url":"https://api.github.com/users/effectfully/followers","following_url":"https://api.github.com/users/effectfully/following{/other_user}","gists_url":"https://api.github.com/users/effectfully/gists{/gist_id}","starred_url":"https://api.github.com/users/effectfully/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/effectfully/subscriptions","organizations_url":"https://api.github.com/users/effectfully/orgs","repos_url":"https://api.github.com/users/effectfully/repos","events_url":"https://api.github.com/users/effectfully/events{/privacy}","received_events_url":"https://api.github.com/users/effectfully/received_events","type":"User","site_admin":false},"body":"I disagree with this.","created_at":"2018-11-23T13:49:37Z","updated_at":"2018-11-23T13:49:38Z","html_url":"https://github.com/input-output-hk/plutus/pull/331#discussion_r235945794","pull_request_url":"https://api.github.com/repos/input-output-hk/plutus/pulls/331","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/comments/235945794"},"html":{"href":"https://github.com/input-output-hk/plutus/pull/331#discussion_r235945794"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/331"}}},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/plutus/pulls/331","id":233183825,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMTgzODI1","html_url":"https://github.com/input-output-hk/plutus/pull/331","diff_url":"https://github.com/input-output-hk/plutus/pull/331.diff","patch_url":"https://github.com/input-output-hk/plutus/pull/331.patch","issue_url":"https://api.github.com/repos/input-output-hk/plutus/issues/331","number":331,"state":"open","locked":false,"title":"Kwxm/l machine","user":{"login":"kwxm","id":2124565,"node_id":"MDQ6VXNlcjIxMjQ1NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2124565?v=4","gravatar_id":"","url":"https://api.github.com/users/kwxm","html_url":"https://github.com/kwxm","followers_url":"https://api.github.com/users/kwxm/followers","following_url":"https://api.github.com/users/kwxm/following{/other_user}","gists_url":"https://api.github.com/users/kwxm/gists{/gist_id}","starred_url":"https://api.github.com/users/kwxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwxm/subscriptions","organizations_url":"https://api.github.com/users/kwxm/orgs","repos_url":"https://api.github.com/users/kwxm/repos","events_url":"https://api.github.com/users/kwxm/events{/privacy}","received_events_url":"https://api.github.com/users/kwxm/received_events","type":"User","site_admin":false},"body":"Here's the lazy machine. There are several things that will need to be fixed eventually.\r\n\r\n1. The handling of built-in functions is a bit messy: this can be sorted out when the interface has been finalised. I've been chasing Roman's changes for some time which has necessitated frequent rebasing. Some of git's behaviour has been rather confusing (conflicts reappearing many times), so I'd like to get it merged to avoid any more of that.\r\n\r\n2. I've kept the structure as simple as possible to make it easy to see how it works. Some of the state could be put in a monad (the heap, and the table of dynamic built-ins, when that's stabilised), but that can be done later.\r\n\r\n3.    It's throwing exceptions rather than returning error results. This interacts with the built-in stuff again, so that can also be fixed later.\r\n","created_at":"2018-11-23T12:13:27Z","updated_at":"2018-11-23T13:49:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6b630b6d602388f9ec07f5dc7b1060fa362a067","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/plutus/pulls/331/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/plutus/pulls/331/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/plutus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/plutus/issues/331/comments","statuses_url":"https://api.github.com/repos/input-output-hk/plutus/statuses/59afff5039800d73f5702a4dd1597375da0c0445","head":{"label":"input-output-hk:kwxm/L-machine","ref":"kwxm/L-machine","sha":"59afff5039800d73f5702a4dd1597375da0c0445","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":73861563,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzg2MTU2Mw==","name":"plutus","full_name":"input-output-hk/plutus","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/plutus","description":"The Plutus language reference implementation and tools","fork":false,"url":"https://api.github.com/repos/input-output-hk/plutus","forks_url":"https://api.github.com/repos/input-output-hk/plutus/forks","keys_url":"https://api.github.com/repos/input-output-hk/plutus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/plutus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/plutus/teams","hooks_url":"https://api.github.com/repos/input-output-hk/plutus/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/plutus/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/plutus/events","assignees_url":"https://api.github.com/repos/input-output-hk/plutus/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/plutus/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/plutus/tags","blobs_url":"https://api.github.com/repos/input-output-hk/plutus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/plutus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/plutus/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/plutus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/plutus/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/plutus/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/plutus/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/plutus/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/plutus/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/plutus/subscription","commits_url":"https://api.github.com/repos/input-output-hk/plutus/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/plutus/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/plutus/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/plutus/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/plutus/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/plutus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/plutus/merges","archive_url":"https://api.github.com/repos/input-output-hk/plutus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/plutus/downloads","issues_url":"https://api.github.com/repos/input-output-hk/plutus/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/plutus/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/plutus/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/plutus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/plutus/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/plutus/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/plutus/deployments","created_at":"2016-11-15T22:38:43Z","updated_at":"2018-11-23T13:47:06Z","pushed_at":"2018-11-23T13:48:52Z","git_url":"git://github.com/input-output-hk/plutus.git","ssh_url":"git@github.com:input-output-hk/plutus.git","clone_url":"https://github.com/input-output-hk/plutus.git","svn_url":"https://github.com/input-output-hk/plutus","homepage":"","size":12015,"stargazers_count":147,"watchers_count":147,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":16,"watchers":147,"default_branch":"master"}},"base":{"label":"input-output-hk:master","ref":"master","sha":"50b2fafd4f32434fb5f11a659500d44919c37fb3","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":73861563,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzg2MTU2Mw==","name":"plutus","full_name":"input-output-hk/plutus","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/plutus","description":"The Plutus language reference implementation and tools","fork":false,"url":"https://api.github.com/repos/input-output-hk/plutus","forks_url":"https://api.github.com/repos/input-output-hk/plutus/forks","keys_url":"https://api.github.com/repos/input-output-hk/plutus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/plutus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/plutus/teams","hooks_url":"https://api.github.com/repos/input-output-hk/plutus/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/plutus/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/plutus/events","assignees_url":"https://api.github.com/repos/input-output-hk/plutus/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/plutus/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/plutus/tags","blobs_url":"https://api.github.com/repos/input-output-hk/plutus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/plutus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/plutus/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/plutus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/plutus/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/plutus/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/plutus/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/plutus/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/plutus/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/plutus/subscription","commits_url":"https://api.github.com/repos/input-output-hk/plutus/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/plutus/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/plutus/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/plutus/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/plutus/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/plutus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/plutus/merges","archive_url":"https://api.github.com/repos/input-output-hk/plutus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/plutus/downloads","issues_url":"https://api.github.com/repos/input-output-hk/plutus/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/plutus/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/plutus/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/plutus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/plutus/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/plutus/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/plutus/deployments","created_at":"2016-11-15T22:38:43Z","updated_at":"2018-11-23T13:47:06Z","pushed_at":"2018-11-23T13:48:52Z","git_url":"git://github.com/input-output-hk/plutus.git","ssh_url":"git@github.com:input-output-hk/plutus.git","clone_url":"https://github.com/input-output-hk/plutus.git","svn_url":"https://github.com/input-output-hk/plutus","homepage":"","size":12015,"stargazers_count":147,"watchers_count":147,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":16,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/331"},"html":{"href":"https://github.com/input-output-hk/plutus/pull/331"},"issue":{"href":"https://api.github.com/repos/input-output-hk/plutus/issues/331"},"comments":{"href":"https://api.github.com/repos/input-output-hk/plutus/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/plutus/statuses/59afff5039800d73f5702a4dd1597375da0c0445"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"effectfully"}}