{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/plugins/pulls/comments/234855543","pull_request_review_id":176586381,"id":234855543,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDg1NTU0Mw==","diff_hunk":"@@ -125,6 +126,18 @@ class GoogleMapOptions {\n   /// True if the map view should respond to zoom gestures.\n   final bool zoomGesturesEnabled;\n \n+  /// Whether to show a \"My Location\" layer over the map.\n+  ///\n+  /// The layer includes a location indicator and My Location button at the current device location if it is known.\n+  /// The indicator is a small blue dot if the device is stationary, or a chevron if the device is moving.\n+  /// The My Location button animates to focus on the user's current location if the user's location is currently known.\n+  ///\n+  /// Enabling this feature requires adding location permissions.\n+  /// On Android add either `<uses-permission android:name=\"android.permission.ACCESS_FINE_LOCATION\" />` or `<uses-permission android:name=\"android.permission.ACCESS_FINE_LOCATION\" />` to your `AndroidManifest.xml` file.","path":"packages/google_maps_flutter/lib/src/ui.dart","position":19,"original_position":19,"commit_id":"d14f5185edc3b7997ba347a7c3c1ca658b66cf67","original_commit_id":"d14f5185edc3b7997ba347a7c3c1ca658b66cf67","user":{"login":"amirh","id":1024117,"node_id":"MDQ6VXNlcjEwMjQxMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1024117?v=4","gravatar_id":"","url":"https://api.github.com/users/amirh","html_url":"https://github.com/amirh","followers_url":"https://api.github.com/users/amirh/followers","following_url":"https://api.github.com/users/amirh/following{/other_user}","gists_url":"https://api.github.com/users/amirh/gists{/gist_id}","starred_url":"https://api.github.com/users/amirh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirh/subscriptions","organizations_url":"https://api.github.com/users/amirh/orgs","repos_url":"https://api.github.com/users/amirh/repos","events_url":"https://api.github.com/users/amirh/events{/privacy}","received_events_url":"https://api.github.com/users/amirh/received_events","type":"User","site_admin":false},"body":"Did you mean for one of these to be coarse location?\r\nAlso probably worth including enough information for someone reading this to figure which permission he should add.","created_at":"2018-11-20T03:01:31Z","updated_at":"2018-11-20T03:20:11Z","html_url":"https://github.com/flutter/plugins/pull/898#discussion_r234855543","pull_request_url":"https://api.github.com/repos/flutter/plugins/pulls/898","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/plugins/pulls/comments/234855543"},"html":{"href":"https://github.com/flutter/plugins/pull/898#discussion_r234855543"},"pull_request":{"href":"https://api.github.com/repos/flutter/plugins/pulls/898"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/plugins/pulls/898","id":230698331,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjk4MzMx","html_url":"https://github.com/flutter/plugins/pull/898","diff_url":"https://github.com/flutter/plugins/pull/898.diff","patch_url":"https://github.com/flutter/plugins/pull/898.patch","issue_url":"https://api.github.com/repos/flutter/plugins/issues/898","number":898,"state":"open","locked":false,"title":"Adding My Location parameter to the Google Maps plugin","user":{"login":"timtraversy","id":21370530,"node_id":"MDQ6VXNlcjIxMzcwNTMw","avatar_url":"https://avatars0.githubusercontent.com/u/21370530?v=4","gravatar_id":"","url":"https://api.github.com/users/timtraversy","html_url":"https://github.com/timtraversy","followers_url":"https://api.github.com/users/timtraversy/followers","following_url":"https://api.github.com/users/timtraversy/following{/other_user}","gists_url":"https://api.github.com/users/timtraversy/gists{/gist_id}","starred_url":"https://api.github.com/users/timtraversy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timtraversy/subscriptions","organizations_url":"https://api.github.com/users/timtraversy/orgs","repos_url":"https://api.github.com/users/timtraversy/repos","events_url":"https://api.github.com/users/timtraversy/events{/privacy}","received_events_url":"https://api.github.com/users/timtraversy/received_events","type":"User","site_admin":false},"body":"This pull request introduces a **My Location parameter** to the **Google Maps plugin.** This is a feature that Google Maps offers that puts a blue location dot on the user's location, and provides a clickable compass. This parameter works the same way as the zoom, or scale options, and can be enabled or disabled by updating the map options. I've added:\r\n1. **The myLocationEnabled parameter to the Google Map options class**, as well as functions that switch it on and off in Android and iOS.\r\n2. A toggle location button in the **example app** which demonstrates the new parameter. This required adding location permissions to the app.\r\n\r\nI also **fixed a bug in the iOS code** which was improperly loading the map options when the map was first initiated.\r\n\r\n_Things I am uncertain about:_\r\n1. On iOS - when the location is turned on and then off, it can't be turned on again. This seems to be a bug in Google Maps, or maybe an intended functionality.\r\n2. Permission handling. Right now the location feature just quietly fails if they don't have permissions enabled, so it might be good to add some error reporting there.","created_at":"2018-11-14T03:26:10Z","updated_at":"2018-11-20T03:20:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd1b368e28697886d21c9878d0ea7bbfe6f00f06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":616170846,"node_id":"MDU6TGFiZWw2MTYxNzA4NDY=","url":"https://api.github.com/repos/flutter/plugins/labels/cla:%20yes","name":"cla: yes","color":"FFFFFF","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/plugins/pulls/898/commits","review_comments_url":"https://api.github.com/repos/flutter/plugins/pulls/898/comments","review_comment_url":"https://api.github.com/repos/flutter/plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/plugins/issues/898/comments","statuses_url":"https://api.github.com/repos/flutter/plugins/statuses/d14f5185edc3b7997ba347a7c3c1ca658b66cf67","head":{"label":"timtraversy:my_location","ref":"my_location","sha":"d14f5185edc3b7997ba347a7c3c1ca658b66cf67","user":{"login":"timtraversy","id":21370530,"node_id":"MDQ6VXNlcjIxMzcwNTMw","avatar_url":"https://avatars0.githubusercontent.com/u/21370530?v=4","gravatar_id":"","url":"https://api.github.com/users/timtraversy","html_url":"https://github.com/timtraversy","followers_url":"https://api.github.com/users/timtraversy/followers","following_url":"https://api.github.com/users/timtraversy/following{/other_user}","gists_url":"https://api.github.com/users/timtraversy/gists{/gist_id}","starred_url":"https://api.github.com/users/timtraversy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timtraversy/subscriptions","organizations_url":"https://api.github.com/users/timtraversy/orgs","repos_url":"https://api.github.com/users/timtraversy/repos","events_url":"https://api.github.com/users/timtraversy/events{/privacy}","received_events_url":"https://api.github.com/users/timtraversy/received_events","type":"User","site_admin":false},"repo":{"id":157455940,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc0NTU5NDA=","name":"plugins","full_name":"timtraversy/plugins","private":false,"owner":{"login":"timtraversy","id":21370530,"node_id":"MDQ6VXNlcjIxMzcwNTMw","avatar_url":"https://avatars0.githubusercontent.com/u/21370530?v=4","gravatar_id":"","url":"https://api.github.com/users/timtraversy","html_url":"https://github.com/timtraversy","followers_url":"https://api.github.com/users/timtraversy/followers","following_url":"https://api.github.com/users/timtraversy/following{/other_user}","gists_url":"https://api.github.com/users/timtraversy/gists{/gist_id}","starred_url":"https://api.github.com/users/timtraversy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timtraversy/subscriptions","organizations_url":"https://api.github.com/users/timtraversy/orgs","repos_url":"https://api.github.com/users/timtraversy/repos","events_url":"https://api.github.com/users/timtraversy/events{/privacy}","received_events_url":"https://api.github.com/users/timtraversy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/timtraversy/plugins","description":"Plugins for Flutter, including FlutterFire, maintained by the Flutter team","fork":true,"url":"https://api.github.com/repos/timtraversy/plugins","forks_url":"https://api.github.com/repos/timtraversy/plugins/forks","keys_url":"https://api.github.com/repos/timtraversy/plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timtraversy/plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timtraversy/plugins/teams","hooks_url":"https://api.github.com/repos/timtraversy/plugins/hooks","issue_events_url":"https://api.github.com/repos/timtraversy/plugins/issues/events{/number}","events_url":"https://api.github.com/repos/timtraversy/plugins/events","assignees_url":"https://api.github.com/repos/timtraversy/plugins/assignees{/user}","branches_url":"https://api.github.com/repos/timtraversy/plugins/branches{/branch}","tags_url":"https://api.github.com/repos/timtraversy/plugins/tags","blobs_url":"https://api.github.com/repos/timtraversy/plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timtraversy/plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timtraversy/plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/timtraversy/plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timtraversy/plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/timtraversy/plugins/languages","stargazers_url":"https://api.github.com/repos/timtraversy/plugins/stargazers","contributors_url":"https://api.github.com/repos/timtraversy/plugins/contributors","subscribers_url":"https://api.github.com/repos/timtraversy/plugins/subscribers","subscription_url":"https://api.github.com/repos/timtraversy/plugins/subscription","commits_url":"https://api.github.com/repos/timtraversy/plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/timtraversy/plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/timtraversy/plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/timtraversy/plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/timtraversy/plugins/contents/{+path}","compare_url":"https://api.github.com/repos/timtraversy/plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timtraversy/plugins/merges","archive_url":"https://api.github.com/repos/timtraversy/plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timtraversy/plugins/downloads","issues_url":"https://api.github.com/repos/timtraversy/plugins/issues{/number}","pulls_url":"https://api.github.com/repos/timtraversy/plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/timtraversy/plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/timtraversy/plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timtraversy/plugins/labels{/name}","releases_url":"https://api.github.com/repos/timtraversy/plugins/releases{/id}","deployments_url":"https://api.github.com/repos/timtraversy/plugins/deployments","created_at":"2018-11-13T22:32:21Z","updated_at":"2018-11-13T22:32:26Z","pushed_at":"2018-11-20T02:42:31Z","git_url":"git://github.com/timtraversy/plugins.git","ssh_url":"git@github.com:timtraversy/plugins.git","clone_url":"https://github.com/timtraversy/plugins.git","svn_url":"https://github.com/timtraversy/plugins","homepage":"https://flutter.io/","size":10958,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"eaa1388b11ac3ee6143ad782e573b9b9e314bc4b","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":88650014,"node_id":"MDEwOlJlcG9zaXRvcnk4ODY1MDAxNA==","name":"plugins","full_name":"flutter/plugins","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/plugins","description":"Plugins for Flutter, including FlutterFire, maintained by the Flutter team","fork":false,"url":"https://api.github.com/repos/flutter/plugins","forks_url":"https://api.github.com/repos/flutter/plugins/forks","keys_url":"https://api.github.com/repos/flutter/plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/plugins/teams","hooks_url":"https://api.github.com/repos/flutter/plugins/hooks","issue_events_url":"https://api.github.com/repos/flutter/plugins/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/plugins/events","assignees_url":"https://api.github.com/repos/flutter/plugins/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/plugins/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/plugins/tags","blobs_url":"https://api.github.com/repos/flutter/plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/plugins/languages","stargazers_url":"https://api.github.com/repos/flutter/plugins/stargazers","contributors_url":"https://api.github.com/repos/flutter/plugins/contributors","subscribers_url":"https://api.github.com/repos/flutter/plugins/subscribers","subscription_url":"https://api.github.com/repos/flutter/plugins/subscription","commits_url":"https://api.github.com/repos/flutter/plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/plugins/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/plugins/merges","archive_url":"https://api.github.com/repos/flutter/plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/plugins/downloads","issues_url":"https://api.github.com/repos/flutter/plugins/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/plugins/labels{/name}","releases_url":"https://api.github.com/repos/flutter/plugins/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/plugins/deployments","created_at":"2017-04-18T17:02:37Z","updated_at":"2018-11-20T02:14:24Z","pushed_at":"2018-11-20T02:42:33Z","git_url":"git://github.com/flutter/plugins.git","ssh_url":"git@github.com:flutter/plugins.git","clone_url":"https://github.com/flutter/plugins.git","svn_url":"https://github.com/flutter/plugins","homepage":"https://flutter.io/","size":10947,"stargazers_count":2471,"watchers_count":2471,"language":"Dart","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":930,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":930,"open_issues":63,"watchers":2471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/plugins/pulls/898"},"html":{"href":"https://github.com/flutter/plugins/pull/898"},"issue":{"href":"https://api.github.com/repos/flutter/plugins/issues/898"},"comments":{"href":"https://api.github.com/repos/flutter/plugins/issues/898/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/plugins/pulls/898/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/plugins/pulls/898/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/plugins/statuses/d14f5185edc3b7997ba347a7c3c1ca658b66cf67"}},"author_association":"NONE"}}
{"actor":{"display_login":"amirh"}}