{"action":"opened","number":679,"pull_request":{"url":"https://api.github.com/repos/OA-PASS/pass-ember/pulls/679","id":200185907,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTg1OTA3","html_url":"https://github.com/OA-PASS/pass-ember/pull/679","diff_url":"https://github.com/OA-PASS/pass-ember/pull/679.diff","patch_url":"https://github.com/OA-PASS/pass-ember/pull/679.patch","issue_url":"https://api.github.com/repos/OA-PASS/pass-ember/issues/679","number":679,"state":"open","locked":false,"title":"Move global error handler logic to a service.","user":{"login":"markpatton","id":3835155,"node_id":"MDQ6VXNlcjM4MzUxNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3835155?v=4","gravatar_id":"","url":"https://api.github.com/users/markpatton","html_url":"https://github.com/markpatton","followers_url":"https://api.github.com/users/markpatton/followers","following_url":"https://api.github.com/users/markpatton/following{/other_user}","gists_url":"https://api.github.com/users/markpatton/gists{/gist_id}","starred_url":"https://api.github.com/users/markpatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpatton/subscriptions","organizations_url":"https://api.github.com/users/markpatton/orgs","repos_url":"https://api.github.com/users/markpatton/repos","events_url":"https://api.github.com/users/markpatton/events{/privacy}","received_events_url":"https://api.github.com/users/markpatton/received_events","type":"User","site_admin":false},"body":"Eventually this will make testing simpler because we can mock the service.\r\n\r\nI copied the existing logic, but enabled the 403 handling just out of curiosity.\r\n\r\nTesting is a bit difficult. You have to manually trigger various error conditions.","created_at":"2018-07-09T18:42:31Z","updated_at":"2018-07-09T18:42:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OA-PASS/pass-ember/pulls/679/commits","review_comments_url":"https://api.github.com/repos/OA-PASS/pass-ember/pulls/679/comments","review_comment_url":"https://api.github.com/repos/OA-PASS/pass-ember/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OA-PASS/pass-ember/issues/679/comments","statuses_url":"https://api.github.com/repos/OA-PASS/pass-ember/statuses/f923d5993748b6171be7fc849d69e3a54974ab5d","head":{"label":"markpatton:error_service","ref":"error_service","sha":"f923d5993748b6171be7fc849d69e3a54974ab5d","user":{"login":"markpatton","id":3835155,"node_id":"MDQ6VXNlcjM4MzUxNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3835155?v=4","gravatar_id":"","url":"https://api.github.com/users/markpatton","html_url":"https://github.com/markpatton","followers_url":"https://api.github.com/users/markpatton/followers","following_url":"https://api.github.com/users/markpatton/following{/other_user}","gists_url":"https://api.github.com/users/markpatton/gists{/gist_id}","starred_url":"https://api.github.com/users/markpatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpatton/subscriptions","organizations_url":"https://api.github.com/users/markpatton/orgs","repos_url":"https://api.github.com/users/markpatton/repos","events_url":"https://api.github.com/users/markpatton/events{/privacy}","received_events_url":"https://api.github.com/users/markpatton/received_events","type":"User","site_admin":false},"repo":{"id":114022431,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQwMjI0MzE=","name":"pass-ember","full_name":"markpatton/pass-ember","owner":{"login":"markpatton","id":3835155,"node_id":"MDQ6VXNlcjM4MzUxNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3835155?v=4","gravatar_id":"","url":"https://api.github.com/users/markpatton","html_url":"https://github.com/markpatton","followers_url":"https://api.github.com/users/markpatton/followers","following_url":"https://api.github.com/users/markpatton/following{/other_user}","gists_url":"https://api.github.com/users/markpatton/gists{/gist_id}","starred_url":"https://api.github.com/users/markpatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpatton/subscriptions","organizations_url":"https://api.github.com/users/markpatton/orgs","repos_url":"https://api.github.com/users/markpatton/repos","events_url":"https://api.github.com/users/markpatton/events{/privacy}","received_events_url":"https://api.github.com/users/markpatton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markpatton/pass-ember","description":null,"fork":true,"url":"https://api.github.com/repos/markpatton/pass-ember","forks_url":"https://api.github.com/repos/markpatton/pass-ember/forks","keys_url":"https://api.github.com/repos/markpatton/pass-ember/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markpatton/pass-ember/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markpatton/pass-ember/teams","hooks_url":"https://api.github.com/repos/markpatton/pass-ember/hooks","issue_events_url":"https://api.github.com/repos/markpatton/pass-ember/issues/events{/number}","events_url":"https://api.github.com/repos/markpatton/pass-ember/events","assignees_url":"https://api.github.com/repos/markpatton/pass-ember/assignees{/user}","branches_url":"https://api.github.com/repos/markpatton/pass-ember/branches{/branch}","tags_url":"https://api.github.com/repos/markpatton/pass-ember/tags","blobs_url":"https://api.github.com/repos/markpatton/pass-ember/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markpatton/pass-ember/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markpatton/pass-ember/git/refs{/sha}","trees_url":"https://api.github.com/repos/markpatton/pass-ember/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markpatton/pass-ember/statuses/{sha}","languages_url":"https://api.github.com/repos/markpatton/pass-ember/languages","stargazers_url":"https://api.github.com/repos/markpatton/pass-ember/stargazers","contributors_url":"https://api.github.com/repos/markpatton/pass-ember/contributors","subscribers_url":"https://api.github.com/repos/markpatton/pass-ember/subscribers","subscription_url":"https://api.github.com/repos/markpatton/pass-ember/subscription","commits_url":"https://api.github.com/repos/markpatton/pass-ember/commits{/sha}","git_commits_url":"https://api.github.com/repos/markpatton/pass-ember/git/commits{/sha}","comments_url":"https://api.github.com/repos/markpatton/pass-ember/comments{/number}","issue_comment_url":"https://api.github.com/repos/markpatton/pass-ember/issues/comments{/number}","contents_url":"https://api.github.com/repos/markpatton/pass-ember/contents/{+path}","compare_url":"https://api.github.com/repos/markpatton/pass-ember/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markpatton/pass-ember/merges","archive_url":"https://api.github.com/repos/markpatton/pass-ember/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markpatton/pass-ember/downloads","issues_url":"https://api.github.com/repos/markpatton/pass-ember/issues{/number}","pulls_url":"https://api.github.com/repos/markpatton/pass-ember/pulls{/number}","milestones_url":"https://api.github.com/repos/markpatton/pass-ember/milestones{/number}","notifications_url":"https://api.github.com/repos/markpatton/pass-ember/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markpatton/pass-ember/labels{/name}","releases_url":"https://api.github.com/repos/markpatton/pass-ember/releases{/id}","deployments_url":"https://api.github.com/repos/markpatton/pass-ember/deployments","created_at":"2017-12-12T18:00:05Z","updated_at":"2017-12-12T18:00:07Z","pushed_at":"2018-07-09T18:38:18Z","git_url":"git://github.com/markpatton/pass-ember.git","ssh_url":"git@github.com:markpatton/pass-ember.git","clone_url":"https://github.com/markpatton/pass-ember.git","svn_url":"https://github.com/markpatton/pass-ember","homepage":null,"size":2583,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OA-PASS:develop","ref":"develop","sha":"29dd183593d75267e587dbcab4d262553305b265","user":{"login":"OA-PASS","id":36713230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzEzMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/36713230?v=4","gravatar_id":"","url":"https://api.github.com/users/OA-PASS","html_url":"https://github.com/OA-PASS","followers_url":"https://api.github.com/users/OA-PASS/followers","following_url":"https://api.github.com/users/OA-PASS/following{/other_user}","gists_url":"https://api.github.com/users/OA-PASS/gists{/gist_id}","starred_url":"https://api.github.com/users/OA-PASS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OA-PASS/subscriptions","organizations_url":"https://api.github.com/users/OA-PASS/orgs","repos_url":"https://api.github.com/users/OA-PASS/repos","events_url":"https://api.github.com/users/OA-PASS/events{/privacy}","received_events_url":"https://api.github.com/users/OA-PASS/received_events","type":"Organization","site_admin":false},"repo":{"id":109856632,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk4NTY2MzI=","name":"pass-ember","full_name":"OA-PASS/pass-ember","owner":{"login":"OA-PASS","id":36713230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzEzMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/36713230?v=4","gravatar_id":"","url":"https://api.github.com/users/OA-PASS","html_url":"https://github.com/OA-PASS","followers_url":"https://api.github.com/users/OA-PASS/followers","following_url":"https://api.github.com/users/OA-PASS/following{/other_user}","gists_url":"https://api.github.com/users/OA-PASS/gists{/gist_id}","starred_url":"https://api.github.com/users/OA-PASS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OA-PASS/subscriptions","organizations_url":"https://api.github.com/users/OA-PASS/orgs","repos_url":"https://api.github.com/users/OA-PASS/repos","events_url":"https://api.github.com/users/OA-PASS/events{/privacy}","received_events_url":"https://api.github.com/users/OA-PASS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OA-PASS/pass-ember","description":"UI code base for PASS","fork":false,"url":"https://api.github.com/repos/OA-PASS/pass-ember","forks_url":"https://api.github.com/repos/OA-PASS/pass-ember/forks","keys_url":"https://api.github.com/repos/OA-PASS/pass-ember/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OA-PASS/pass-ember/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OA-PASS/pass-ember/teams","hooks_url":"https://api.github.com/repos/OA-PASS/pass-ember/hooks","issue_events_url":"https://api.github.com/repos/OA-PASS/pass-ember/issues/events{/number}","events_url":"https://api.github.com/repos/OA-PASS/pass-ember/events","assignees_url":"https://api.github.com/repos/OA-PASS/pass-ember/assignees{/user}","branches_url":"https://api.github.com/repos/OA-PASS/pass-ember/branches{/branch}","tags_url":"https://api.github.com/repos/OA-PASS/pass-ember/tags","blobs_url":"https://api.github.com/repos/OA-PASS/pass-ember/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OA-PASS/pass-ember/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OA-PASS/pass-ember/git/refs{/sha}","trees_url":"https://api.github.com/repos/OA-PASS/pass-ember/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OA-PASS/pass-ember/statuses/{sha}","languages_url":"https://api.github.com/repos/OA-PASS/pass-ember/languages","stargazers_url":"https://api.github.com/repos/OA-PASS/pass-ember/stargazers","contributors_url":"https://api.github.com/repos/OA-PASS/pass-ember/contributors","subscribers_url":"https://api.github.com/repos/OA-PASS/pass-ember/subscribers","subscription_url":"https://api.github.com/repos/OA-PASS/pass-ember/subscription","commits_url":"https://api.github.com/repos/OA-PASS/pass-ember/commits{/sha}","git_commits_url":"https://api.github.com/repos/OA-PASS/pass-ember/git/commits{/sha}","comments_url":"https://api.github.com/repos/OA-PASS/pass-ember/comments{/number}","issue_comment_url":"https://api.github.com/repos/OA-PASS/pass-ember/issues/comments{/number}","contents_url":"https://api.github.com/repos/OA-PASS/pass-ember/contents/{+path}","compare_url":"https://api.github.com/repos/OA-PASS/pass-ember/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OA-PASS/pass-ember/merges","archive_url":"https://api.github.com/repos/OA-PASS/pass-ember/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OA-PASS/pass-ember/downloads","issues_url":"https://api.github.com/repos/OA-PASS/pass-ember/issues{/number}","pulls_url":"https://api.github.com/repos/OA-PASS/pass-ember/pulls{/number}","milestones_url":"https://api.github.com/repos/OA-PASS/pass-ember/milestones{/number}","notifications_url":"https://api.github.com/repos/OA-PASS/pass-ember/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OA-PASS/pass-ember/labels{/name}","releases_url":"https://api.github.com/repos/OA-PASS/pass-ember/releases{/id}","deployments_url":"https://api.github.com/repos/OA-PASS/pass-ember/deployments","created_at":"2017-11-07T15:49:10Z","updated_at":"2018-07-06T19:11:52Z","pushed_at":"2018-07-06T20:13:32Z","git_url":"git://github.com/OA-PASS/pass-ember.git","ssh_url":"git@github.com:OA-PASS/pass-ember.git","clone_url":"https://github.com/OA-PASS/pass-ember.git","svn_url":"https://github.com/OA-PASS/pass-ember","homepage":"","size":15062,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":10,"open_issues":24,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OA-PASS/pass-ember/pulls/679"},"html":{"href":"https://github.com/OA-PASS/pass-ember/pull/679"},"issue":{"href":"https://api.github.com/repos/OA-PASS/pass-ember/issues/679"},"comments":{"href":"https://api.github.com/repos/OA-PASS/pass-ember/issues/679/comments"},"review_comments":{"href":"https://api.github.com/repos/OA-PASS/pass-ember/pulls/679/comments"},"review_comment":{"href":"https://api.github.com/repos/OA-PASS/pass-ember/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OA-PASS/pass-ember/pulls/679/commits"},"statuses":{"href":"https://api.github.com/repos/OA-PASS/pass-ember/statuses/f923d5993748b6171be7fc849d69e3a54974ab5d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":180,"deletions":52,"changed_files":6}}
{"actor":{"display_login":"markpatton"}}