{"action":"created","issue":{"url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2271","repository_url":"https://api.github.com/repos/googleapis/gapic-generator","labels_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2271/labels{/name}","comments_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2271/comments","events_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2271/events","html_url":"https://github.com/googleapis/gapic-generator/pull/2271","id":354479265,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjMyMDk4","number":2271,"title":"Create separate directories for different versions of library.proto","user":{"login":"andreamlin","id":4016818,"node_id":"MDQ6VXNlcjQwMTY4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-27T21:09:06Z","updated_at":"2018-08-27T21:37:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2271","html_url":"https://github.com/googleapis/gapic-generator/pull/2271","diff_url":"https://github.com/googleapis/gapic-generator/pull/2271.diff","patch_url":"https://github.com/googleapis/gapic-generator/pull/2271.patch"},"body":"There's \r\n- annotated library.proto that has been moved to testsrc/libraryproto/annotationsonly\r\n- un-annotated library.proto that has been moved to testsrc/libraryproto/configonly, which also contains the library service yaml, gapic yaml, and package yaml\r\n- all other *.proto and *.yaml files for test services, that have been moved to testsrc/common\r\n\r\nThis makes it easy to write separate tests for GapicTestBase2.java that simply use different inputs, GapicCodeGeneratorAnnotationsTest that uses the annotated proto, and GapicCodeGeneratorTest that uses config files without an annotated proto.\r\n\r\nUpdate the test resource paths in all other paths to reflect the test resources directories refactoring.\r\nThe contents of *.yaml and *.proto files hasn't changed (although we readded the unannotated library.proto)"},"comment":{"url":"https://api.github.com/repos/googleapis/gapic-generator/issues/comments/416377264","html_url":"https://github.com/googleapis/gapic-generator/pull/2271#issuecomment-416377264","issue_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2271","id":416377264,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjM3NzI2NA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T21:37:25Z","updated_at":"2018-08-27T21:37:25Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/googleapis/gapic-generator/pull/2271?src=pr&el=h1) Report\n> Merging [#2271](https://codecov.io/gh/googleapis/gapic-generator/pull/2271?src=pr&el=desc) into [master](https://codecov.io/gh/googleapis/gapic-generator/commit/c7216ca8bb075f7ff80c920bd3f1cd8e5f32d396?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/googleapis/gapic-generator/pull/2271/graphs/tree.svg?width=650&token=Na1VZ26RzM&height=150&src=pr)](https://codecov.io/gh/googleapis/gapic-generator/pull/2271?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master    #2271      +/-   ##\n============================================\n- Coverage     86.76%   86.75%   -0.01%     \n+ Complexity     5135     5134       -1     \n============================================\n  Files           452      452              \n  Lines         20398    20398              \n  Branches       2190     2190              \n============================================\n- Hits          17699    17697       -2     \n- Misses         1929     1930       +1     \n- Partials        770      771       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/googleapis/gapic-generator/pull/2271?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...en/transformer/php/PhpGapicSurfaceTransformer.java](https://codecov.io/gh/googleapis/gapic-generator/pull/2271/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2FwaS9jb2RlZ2VuL3RyYW5zZm9ybWVyL3BocC9QaHBHYXBpY1N1cmZhY2VUcmFuc2Zvcm1lci5qYXZh) | `92.95% <0%> (-0.71%)` | `41% <0%> (-1%)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/googleapis/gapic-generator/pull/2271?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/googleapis/gapic-generator/pull/2271?src=pr&el=footer). Last update [c7216ca...8bde4d4](https://codecov.io/gh/googleapis/gapic-generator/pull/2271?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}