{"action":"closed","number":5557,"pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/5557","id":189639922,"html_url":"https://github.com/rust-lang/cargo/pull/5557","diff_url":"https://github.com/rust-lang/cargo/pull/5557.diff","patch_url":"https://github.com/rust-lang/cargo/pull/5557.patch","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/5557","number":5557,"state":"closed","locked":false,"title":"Fix test failure in changing_bin_features_caches_targets for Linux.","user":{"login":"ehuss","id":43198,"avatar_url":"https://avatars0.githubusercontent.com/u/43198?v=4","gravatar_id":"","url":"https://api.github.com/users/ehuss","html_url":"https://github.com/ehuss","followers_url":"https://api.github.com/users/ehuss/followers","following_url":"https://api.github.com/users/ehuss/following{/other_user}","gists_url":"https://api.github.com/users/ehuss/gists{/gist_id}","starred_url":"https://api.github.com/users/ehuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehuss/subscriptions","organizations_url":"https://api.github.com/users/ehuss/orgs","repos_url":"https://api.github.com/users/ehuss/repos","events_url":"https://api.github.com/users/ehuss/events{/privacy}","received_events_url":"https://api.github.com/users/ehuss/received_events","type":"User","site_admin":false},"body":"Fixes rust-lang/rust#50962.\r\n\r\nMy theory is that while copying the binary, another thread forked with the fd\r\nopen.  The copy finishes and attempts to exec before the other child execs (and\r\ncloses the writeable fd).\r\n\r\nI was able to easily repro this on linux.  I ran some stress tests of this fix\r\nlocally on linux and on appveyor, and was unable to trigger it again.","created_at":"2018-05-22T12:06:13Z","updated_at":"2018-05-22T14:35:46Z","closed_at":"2018-05-22T14:35:45Z","merged_at":"2018-05-22T14:35:45Z","merge_commit_sha":"83e87d42128d07bef733c26bd395d69e99c98655","assignee":{"login":"matklad","id":1711539,"avatar_url":"https://avatars3.githubusercontent.com/u/1711539?v=4","gravatar_id":"","url":"https://api.github.com/users/matklad","html_url":"https://github.com/matklad","followers_url":"https://api.github.com/users/matklad/followers","following_url":"https://api.github.com/users/matklad/following{/other_user}","gists_url":"https://api.github.com/users/matklad/gists{/gist_id}","starred_url":"https://api.github.com/users/matklad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matklad/subscriptions","organizations_url":"https://api.github.com/users/matklad/orgs","repos_url":"https://api.github.com/users/matklad/repos","events_url":"https://api.github.com/users/matklad/events{/privacy}","received_events_url":"https://api.github.com/users/matklad/received_events","type":"User","site_admin":false},"assignees":[{"login":"matklad","id":1711539,"avatar_url":"https://avatars3.githubusercontent.com/u/1711539?v=4","gravatar_id":"","url":"https://api.github.com/users/matklad","html_url":"https://github.com/matklad","followers_url":"https://api.github.com/users/matklad/followers","following_url":"https://api.github.com/users/matklad/following{/other_user}","gists_url":"https://api.github.com/users/matklad/gists{/gist_id}","starred_url":"https://api.github.com/users/matklad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matklad/subscriptions","organizations_url":"https://api.github.com/users/matklad/orgs","repos_url":"https://api.github.com/users/matklad/repos","events_url":"https://api.github.com/users/matklad/events{/privacy}","received_events_url":"https://api.github.com/users/matklad/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/cargo/pulls/5557/commits","review_comments_url":"https://api.github.com/repos/rust-lang/cargo/pulls/5557/comments","review_comment_url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/5557/comments","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/83e87d42128d07bef733c26bd395d69e99c98655","head":{"label":"ehuss:linux-cbfct","ref":"linux-cbfct","sha":"83e87d42128d07bef733c26bd395d69e99c98655","user":{"login":"ehuss","id":43198,"avatar_url":"https://avatars0.githubusercontent.com/u/43198?v=4","gravatar_id":"","url":"https://api.github.com/users/ehuss","html_url":"https://github.com/ehuss","followers_url":"https://api.github.com/users/ehuss/followers","following_url":"https://api.github.com/users/ehuss/following{/other_user}","gists_url":"https://api.github.com/users/ehuss/gists{/gist_id}","starred_url":"https://api.github.com/users/ehuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehuss/subscriptions","organizations_url":"https://api.github.com/users/ehuss/orgs","repos_url":"https://api.github.com/users/ehuss/repos","events_url":"https://api.github.com/users/ehuss/events{/privacy}","received_events_url":"https://api.github.com/users/ehuss/received_events","type":"User","site_admin":false},"repo":{"id":80226738,"name":"cargo","full_name":"ehuss/cargo","owner":{"login":"ehuss","id":43198,"avatar_url":"https://avatars0.githubusercontent.com/u/43198?v=4","gravatar_id":"","url":"https://api.github.com/users/ehuss","html_url":"https://github.com/ehuss","followers_url":"https://api.github.com/users/ehuss/followers","following_url":"https://api.github.com/users/ehuss/following{/other_user}","gists_url":"https://api.github.com/users/ehuss/gists{/gist_id}","starred_url":"https://api.github.com/users/ehuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehuss/subscriptions","organizations_url":"https://api.github.com/users/ehuss/orgs","repos_url":"https://api.github.com/users/ehuss/repos","events_url":"https://api.github.com/users/ehuss/events{/privacy}","received_events_url":"https://api.github.com/users/ehuss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehuss/cargo","description":"The Rust package manager","fork":true,"url":"https://api.github.com/repos/ehuss/cargo","forks_url":"https://api.github.com/repos/ehuss/cargo/forks","keys_url":"https://api.github.com/repos/ehuss/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehuss/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehuss/cargo/teams","hooks_url":"https://api.github.com/repos/ehuss/cargo/hooks","issue_events_url":"https://api.github.com/repos/ehuss/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/ehuss/cargo/events","assignees_url":"https://api.github.com/repos/ehuss/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/ehuss/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/ehuss/cargo/tags","blobs_url":"https://api.github.com/repos/ehuss/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehuss/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehuss/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehuss/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehuss/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/ehuss/cargo/languages","stargazers_url":"https://api.github.com/repos/ehuss/cargo/stargazers","contributors_url":"https://api.github.com/repos/ehuss/cargo/contributors","subscribers_url":"https://api.github.com/repos/ehuss/cargo/subscribers","subscription_url":"https://api.github.com/repos/ehuss/cargo/subscription","commits_url":"https://api.github.com/repos/ehuss/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehuss/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehuss/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehuss/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehuss/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/ehuss/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehuss/cargo/merges","archive_url":"https://api.github.com/repos/ehuss/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehuss/cargo/downloads","issues_url":"https://api.github.com/repos/ehuss/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/ehuss/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/ehuss/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/ehuss/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehuss/cargo/labels{/name}","releases_url":"https://api.github.com/repos/ehuss/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/ehuss/cargo/deployments","created_at":"2017-01-27T16:56:22Z","updated_at":"2018-05-06T15:27:03Z","pushed_at":"2018-05-22T11:45:56Z","git_url":"git://github.com/ehuss/cargo.git","ssh_url":"git@github.com:ehuss/cargo.git","clone_url":"https://github.com/ehuss/cargo.git","svn_url":"https://github.com/ehuss/cargo","homepage":"https://crates.io/","size":16538,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"64f8f1b72f6afaa2fcc01e30537e3efdb1d651f2","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":17420913,"name":"cargo","full_name":"rust-lang/cargo","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/cargo","description":"The Rust package manager","fork":false,"url":"https://api.github.com/repos/rust-lang/cargo","forks_url":"https://api.github.com/repos/rust-lang/cargo/forks","keys_url":"https://api.github.com/repos/rust-lang/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/cargo/teams","hooks_url":"https://api.github.com/repos/rust-lang/cargo/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/cargo/events","assignees_url":"https://api.github.com/repos/rust-lang/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/cargo/tags","blobs_url":"https://api.github.com/repos/rust-lang/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/cargo/languages","stargazers_url":"https://api.github.com/repos/rust-lang/cargo/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/cargo/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/cargo/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/cargo/subscription","commits_url":"https://api.github.com/repos/rust-lang/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/cargo/merges","archive_url":"https://api.github.com/repos/rust-lang/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/cargo/downloads","issues_url":"https://api.github.com/repos/rust-lang/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/cargo/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/cargo/deployments","created_at":"2014-03-04T23:20:42Z","updated_at":"2018-05-22T11:05:58Z","pushed_at":"2018-05-22T14:35:40Z","git_url":"git://github.com/rust-lang/cargo.git","ssh_url":"git@github.com:rust-lang/cargo.git","clone_url":"https://github.com/rust-lang/cargo.git","svn_url":"https://github.com/rust-lang/cargo","homepage":"https://doc.rust-lang.org/cargo","size":18735,"stargazers_count":3190,"watchers_count":3190,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":765,"mirror_url":null,"archived":false,"open_issues_count":679,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":765,"open_issues":679,"watchers":3190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/5557"},"html":{"href":"https://github.com/rust-lang/cargo/pull/5557"},"issue":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/5557"},"comments":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/5557/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/5557/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/5557/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/cargo/statuses/83e87d42128d07bef733c26bd395d69e99c98655"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars2.githubusercontent.com/u/3372342?v=4","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"bors"}}