{"action":"closed","number":214,"pull_request":{"url":"https://api.github.com/repos/jmhodges/howsmyssl/pulls/214","id":180971885,"html_url":"https://github.com/jmhodges/howsmyssl/pull/214","diff_url":"https://github.com/jmhodges/howsmyssl/pull/214.diff","patch_url":"https://github.com/jmhodges/howsmyssl/pull/214.patch","issue_url":"https://api.github.com/repos/jmhodges/howsmyssl/issues/214","number":214,"state":"closed","locked":false,"title":"return 200 for blocked JSONP requests","user":{"login":"jmhodges","id":598,"avatar_url":"https://avatars2.githubusercontent.com/u/598?v=4","gravatar_id":"","url":"https://api.github.com/users/jmhodges","html_url":"https://github.com/jmhodges","followers_url":"https://api.github.com/users/jmhodges/followers","following_url":"https://api.github.com/users/jmhodges/following{/other_user}","gists_url":"https://api.github.com/users/jmhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jmhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmhodges/subscriptions","organizations_url":"https://api.github.com/users/jmhodges/orgs","repos_url":"https://api.github.com/users/jmhodges/repos","events_url":"https://api.github.com/users/jmhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jmhodges/received_events","type":"User","site_admin":false},"body":"Turns out, when you do a <script src=\"yadda?callback=parseTLSThing\">, the script\r\nwon't run if a 4xx error code is returned. So, in order for folks to show errors\r\nto their users, and not just quietly log in their console, we have to return 200\r\nOK even on blocked domains.\r\n\r\nTo be clear, normal AJAX requests would work, but people do that script tag\r\nthing to be JSONP-y.\r\n\r\nThis patch also includes some new tests (and, along the way, a refactoring of\r\nthe current ones).","created_at":"2018-04-11T17:15:17Z","updated_at":"2018-04-11T17:17:46Z","closed_at":"2018-04-11T17:17:46Z","merged_at":"2018-04-11T17:17:46Z","merge_commit_sha":"c7c09bc569333ab75d92637f34026fb3ea5d16af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jmhodges/howsmyssl/pulls/214/commits","review_comments_url":"https://api.github.com/repos/jmhodges/howsmyssl/pulls/214/comments","review_comment_url":"https://api.github.com/repos/jmhodges/howsmyssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmhodges/howsmyssl/issues/214/comments","statuses_url":"https://api.github.com/repos/jmhodges/howsmyssl/statuses/bb7b788ca971199bbaa50ba09533031ffb10f0c1","head":{"label":"jmhodges:jsonp_error","ref":"jsonp_error","sha":"bb7b788ca971199bbaa50ba09533031ffb10f0c1","user":{"login":"jmhodges","id":598,"avatar_url":"https://avatars2.githubusercontent.com/u/598?v=4","gravatar_id":"","url":"https://api.github.com/users/jmhodges","html_url":"https://github.com/jmhodges","followers_url":"https://api.github.com/users/jmhodges/followers","following_url":"https://api.github.com/users/jmhodges/following{/other_user}","gists_url":"https://api.github.com/users/jmhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jmhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmhodges/subscriptions","organizations_url":"https://api.github.com/users/jmhodges/orgs","repos_url":"https://api.github.com/users/jmhodges/repos","events_url":"https://api.github.com/users/jmhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jmhodges/received_events","type":"User","site_admin":false},"repo":{"id":13897083,"name":"howsmyssl","full_name":"jmhodges/howsmyssl","owner":{"login":"jmhodges","id":598,"avatar_url":"https://avatars2.githubusercontent.com/u/598?v=4","gravatar_id":"","url":"https://api.github.com/users/jmhodges","html_url":"https://github.com/jmhodges","followers_url":"https://api.github.com/users/jmhodges/followers","following_url":"https://api.github.com/users/jmhodges/following{/other_user}","gists_url":"https://api.github.com/users/jmhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jmhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmhodges/subscriptions","organizations_url":"https://api.github.com/users/jmhodges/orgs","repos_url":"https://api.github.com/users/jmhodges/repos","events_url":"https://api.github.com/users/jmhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jmhodges/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmhodges/howsmyssl","description":"The web app running howsmyssl.com","fork":false,"url":"https://api.github.com/repos/jmhodges/howsmyssl","forks_url":"https://api.github.com/repos/jmhodges/howsmyssl/forks","keys_url":"https://api.github.com/repos/jmhodges/howsmyssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmhodges/howsmyssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmhodges/howsmyssl/teams","hooks_url":"https://api.github.com/repos/jmhodges/howsmyssl/hooks","issue_events_url":"https://api.github.com/repos/jmhodges/howsmyssl/issues/events{/number}","events_url":"https://api.github.com/repos/jmhodges/howsmyssl/events","assignees_url":"https://api.github.com/repos/jmhodges/howsmyssl/assignees{/user}","branches_url":"https://api.github.com/repos/jmhodges/howsmyssl/branches{/branch}","tags_url":"https://api.github.com/repos/jmhodges/howsmyssl/tags","blobs_url":"https://api.github.com/repos/jmhodges/howsmyssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmhodges/howsmyssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmhodges/howsmyssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmhodges/howsmyssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmhodges/howsmyssl/statuses/{sha}","languages_url":"https://api.github.com/repos/jmhodges/howsmyssl/languages","stargazers_url":"https://api.github.com/repos/jmhodges/howsmyssl/stargazers","contributors_url":"https://api.github.com/repos/jmhodges/howsmyssl/contributors","subscribers_url":"https://api.github.com/repos/jmhodges/howsmyssl/subscribers","subscription_url":"https://api.github.com/repos/jmhodges/howsmyssl/subscription","commits_url":"https://api.github.com/repos/jmhodges/howsmyssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmhodges/howsmyssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmhodges/howsmyssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmhodges/howsmyssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmhodges/howsmyssl/contents/{+path}","compare_url":"https://api.github.com/repos/jmhodges/howsmyssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmhodges/howsmyssl/merges","archive_url":"https://api.github.com/repos/jmhodges/howsmyssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmhodges/howsmyssl/downloads","issues_url":"https://api.github.com/repos/jmhodges/howsmyssl/issues{/number}","pulls_url":"https://api.github.com/repos/jmhodges/howsmyssl/pulls{/number}","milestones_url":"https://api.github.com/repos/jmhodges/howsmyssl/milestones{/number}","notifications_url":"https://api.github.com/repos/jmhodges/howsmyssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmhodges/howsmyssl/labels{/name}","releases_url":"https://api.github.com/repos/jmhodges/howsmyssl/releases{/id}","deployments_url":"https://api.github.com/repos/jmhodges/howsmyssl/deployments","created_at":"2013-10-27T06:48:13Z","updated_at":"2018-04-11T09:04:37Z","pushed_at":"2018-04-11T17:17:46Z","git_url":"git://github.com/jmhodges/howsmyssl.git","ssh_url":"git@github.com:jmhodges/howsmyssl.git","clone_url":"https://github.com/jmhodges/howsmyssl.git","svn_url":"https://github.com/jmhodges/howsmyssl","homepage":"","size":2796,"stargazers_count":255,"watchers_count":255,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":45,"open_issues":9,"watchers":255,"default_branch":"master"}},"base":{"label":"jmhodges:master","ref":"master","sha":"8f79c3b06923e80948486bcf966e429f27998758","user":{"login":"jmhodges","id":598,"avatar_url":"https://avatars2.githubusercontent.com/u/598?v=4","gravatar_id":"","url":"https://api.github.com/users/jmhodges","html_url":"https://github.com/jmhodges","followers_url":"https://api.github.com/users/jmhodges/followers","following_url":"https://api.github.com/users/jmhodges/following{/other_user}","gists_url":"https://api.github.com/users/jmhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jmhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmhodges/subscriptions","organizations_url":"https://api.github.com/users/jmhodges/orgs","repos_url":"https://api.github.com/users/jmhodges/repos","events_url":"https://api.github.com/users/jmhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jmhodges/received_events","type":"User","site_admin":false},"repo":{"id":13897083,"name":"howsmyssl","full_name":"jmhodges/howsmyssl","owner":{"login":"jmhodges","id":598,"avatar_url":"https://avatars2.githubusercontent.com/u/598?v=4","gravatar_id":"","url":"https://api.github.com/users/jmhodges","html_url":"https://github.com/jmhodges","followers_url":"https://api.github.com/users/jmhodges/followers","following_url":"https://api.github.com/users/jmhodges/following{/other_user}","gists_url":"https://api.github.com/users/jmhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jmhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmhodges/subscriptions","organizations_url":"https://api.github.com/users/jmhodges/orgs","repos_url":"https://api.github.com/users/jmhodges/repos","events_url":"https://api.github.com/users/jmhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jmhodges/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmhodges/howsmyssl","description":"The web app running howsmyssl.com","fork":false,"url":"https://api.github.com/repos/jmhodges/howsmyssl","forks_url":"https://api.github.com/repos/jmhodges/howsmyssl/forks","keys_url":"https://api.github.com/repos/jmhodges/howsmyssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmhodges/howsmyssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmhodges/howsmyssl/teams","hooks_url":"https://api.github.com/repos/jmhodges/howsmyssl/hooks","issue_events_url":"https://api.github.com/repos/jmhodges/howsmyssl/issues/events{/number}","events_url":"https://api.github.com/repos/jmhodges/howsmyssl/events","assignees_url":"https://api.github.com/repos/jmhodges/howsmyssl/assignees{/user}","branches_url":"https://api.github.com/repos/jmhodges/howsmyssl/branches{/branch}","tags_url":"https://api.github.com/repos/jmhodges/howsmyssl/tags","blobs_url":"https://api.github.com/repos/jmhodges/howsmyssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmhodges/howsmyssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmhodges/howsmyssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmhodges/howsmyssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmhodges/howsmyssl/statuses/{sha}","languages_url":"https://api.github.com/repos/jmhodges/howsmyssl/languages","stargazers_url":"https://api.github.com/repos/jmhodges/howsmyssl/stargazers","contributors_url":"https://api.github.com/repos/jmhodges/howsmyssl/contributors","subscribers_url":"https://api.github.com/repos/jmhodges/howsmyssl/subscribers","subscription_url":"https://api.github.com/repos/jmhodges/howsmyssl/subscription","commits_url":"https://api.github.com/repos/jmhodges/howsmyssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmhodges/howsmyssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmhodges/howsmyssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmhodges/howsmyssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmhodges/howsmyssl/contents/{+path}","compare_url":"https://api.github.com/repos/jmhodges/howsmyssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmhodges/howsmyssl/merges","archive_url":"https://api.github.com/repos/jmhodges/howsmyssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmhodges/howsmyssl/downloads","issues_url":"https://api.github.com/repos/jmhodges/howsmyssl/issues{/number}","pulls_url":"https://api.github.com/repos/jmhodges/howsmyssl/pulls{/number}","milestones_url":"https://api.github.com/repos/jmhodges/howsmyssl/milestones{/number}","notifications_url":"https://api.github.com/repos/jmhodges/howsmyssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmhodges/howsmyssl/labels{/name}","releases_url":"https://api.github.com/repos/jmhodges/howsmyssl/releases{/id}","deployments_url":"https://api.github.com/repos/jmhodges/howsmyssl/deployments","created_at":"2013-10-27T06:48:13Z","updated_at":"2018-04-11T09:04:37Z","pushed_at":"2018-04-11T17:17:46Z","git_url":"git://github.com/jmhodges/howsmyssl.git","ssh_url":"git@github.com:jmhodges/howsmyssl.git","clone_url":"https://github.com/jmhodges/howsmyssl.git","svn_url":"https://github.com/jmhodges/howsmyssl","homepage":"","size":2796,"stargazers_count":255,"watchers_count":255,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":45,"open_issues":9,"watchers":255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmhodges/howsmyssl/pulls/214"},"html":{"href":"https://github.com/jmhodges/howsmyssl/pull/214"},"issue":{"href":"https://api.github.com/repos/jmhodges/howsmyssl/issues/214"},"comments":{"href":"https://api.github.com/repos/jmhodges/howsmyssl/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/jmhodges/howsmyssl/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/jmhodges/howsmyssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmhodges/howsmyssl/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/jmhodges/howsmyssl/statuses/bb7b788ca971199bbaa50ba09533031ffb10f0c1"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jmhodges","id":598,"avatar_url":"https://avatars2.githubusercontent.com/u/598?v=4","gravatar_id":"","url":"https://api.github.com/users/jmhodges","html_url":"https://github.com/jmhodges","followers_url":"https://api.github.com/users/jmhodges/followers","following_url":"https://api.github.com/users/jmhodges/following{/other_user}","gists_url":"https://api.github.com/users/jmhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jmhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmhodges/subscriptions","organizations_url":"https://api.github.com/users/jmhodges/orgs","repos_url":"https://api.github.com/users/jmhodges/repos","events_url":"https://api.github.com/users/jmhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jmhodges/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":103,"deletions":64,"changed_files":2}}
{"actor":{"display_login":"jmhodges"}}