{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1673","repository_url":"https://api.github.com/repos/bazelbuild/rules_go","labels_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1673/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1673/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1673/events","html_url":"https://github.com/bazelbuild/rules_go/pull/1673","id":352307339,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjUyMjIy","number":1673,"title":"Allow the checker to run vet","user":{"login":"stjj89","id":3895885,"node_id":"MDQ6VXNlcjM4OTU4ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/3895885?v=4","gravatar_id":"","url":"https://api.github.com/users/stjj89","html_url":"https://github.com/stjj89","followers_url":"https://api.github.com/users/stjj89/followers","following_url":"https://api.github.com/users/stjj89/following{/other_user}","gists_url":"https://api.github.com/users/stjj89/gists{/gist_id}","starred_url":"https://api.github.com/users/stjj89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stjj89/subscriptions","organizations_url":"https://api.github.com/users/stjj89/orgs","repos_url":"https://api.github.com/users/stjj89/repos","events_url":"https://api.github.com/users/stjj89/events{/privacy}","received_events_url":"https://api.github.com/users/stjj89/received_events","type":"User","site_admin":false},"labels":[{"id":342134177,"node_id":"MDU6TGFiZWwzNDIxMzQxNzc=","url":"https://api.github.com/repos/bazelbuild/rules_go/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-20T21:43:44Z","updated_at":"2018-08-22T17:08:07Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1673","html_url":"https://github.com/bazelbuild/rules_go/pull/1673","diff_url":"https://github.com/bazelbuild/rules_go/pull/1673.diff","patch_url":"https://github.com/bazelbuild/rules_go/pull/1673.patch"},"body":"Add a go_checker attribute that causes the generated checker\r\nbinary to run 'go tool vet'.\r\n\r\nJust like in the official Go build toolchain, only a subset of\r\nvet checks are run. Any vet findings will fail compilation. To avoid\r\nbreaking users, vet is disabled by default.\r\n\r\nWhile there:\r\n- Fix issues with the importer used to load analysis packages.\r\n- Silence type-checking errors generated by the checker binary. It will\r\n  now fail silently if type-checking errors occur.\r\n- Refactor the checker binary and unit tests to improve readability."},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_go/issues/comments/415106359","html_url":"https://github.com/bazelbuild/rules_go/pull/1673#issuecomment-415106359","issue_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1673","id":415106359,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTEwNjM1OQ==","user":{"login":"stjj89","id":3895885,"node_id":"MDQ6VXNlcjM4OTU4ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/3895885?v=4","gravatar_id":"","url":"https://api.github.com/users/stjj89","html_url":"https://github.com/stjj89","followers_url":"https://api.github.com/users/stjj89/followers","following_url":"https://api.github.com/users/stjj89/following{/other_user}","gists_url":"https://api.github.com/users/stjj89/gists{/gist_id}","starred_url":"https://api.github.com/users/stjj89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stjj89/subscriptions","organizations_url":"https://api.github.com/users/stjj89/orgs","repos_url":"https://api.github.com/users/stjj89/repos","events_url":"https://api.github.com/users/stjj89/events{/privacy}","received_events_url":"https://api.github.com/users/stjj89/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T17:08:07Z","updated_at":"2018-08-22T17:08:07Z","author_association":"NONE","body":"The only extra change I have planned is a big renaming to brand this feature as \"nogo\". I also have the \"bottom-up\" and \"top-down\" checks on to-do list, but that can wait till after the launch.\r\n\r\nLet's see if I can get the importcfg change in by the end of this week. Otherwise, I don't mind waiting till after Sept 4. Thanks again for reviewing all of this code."}}
{"actor":{"display_login":"stjj89"}}