{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/design-system/pulls/comments/178391781","pull_request_review_id":108449942,"id":178391781,"diff_hunk":"@@ -0,0 +1,78 @@\n+.tbds-form__row + .tbds-form__row {\n+  margin-top: 2rem;\n+}\n+\n+.tbds-form__label {\n+  display: block;\n+  font-weight: $tbds-font-weight-bold;\n+  margin-bottom: 0.5rem;\n+}\n+\n+.tbds-form__help-text {\n+  color: #666;\n+  font-weight: $tbds-font-weight-normal;\n+}\n+\n+.tbds-form__help-text--block {\n+  display: block;\n+  margin-top: 0.3rem;\n+}\n+\n+.tbds-form__text-input {\n+  appearance: none;\n+  background-color: #fff;\n+  border: 1px solid #888;\n+  border-radius: 4px;\n+  font-size: 16px;\n+  margin: 0;\n+  padding: 0.5rem 0.8rem;\n+  width: 100%;\n+\n+  &:focus {\n+    border-color: $tbds-blue;\n+    box-shadow: 0 0 0 1px $tbds-blue;\n+    outline: none;\n+  }\n+}\n+\n+.tbds-form__textarea {\n+  appearance: none;\n+  background-color: #fff;\n+  border: 1px solid #888;\n+  border-radius: 4px;\n+  font-size: 16px;\n+  line-height: 1.4;\n+  margin: 0;\n+  min-height: 2.25rem;\n+  padding: 0.5rem 0.8rem;\n+  resize: vertical;\n+  width: 100%;\n+\n+  &:focus {\n+    border-color: $tbds-blue;","path":"packages/tbds-forms/lib/form.scss","position":52,"original_position":52,"commit_id":"fc68b8c9beaced6743cbf66ea76c010df813f47a","original_commit_id":"fc68b8c9beaced6743cbf66ea76c010df813f47a","user":{"login":"wardpenney","id":615249,"avatar_url":"https://avatars1.githubusercontent.com/u/615249?v=4","gravatar_id":"","url":"https://api.github.com/users/wardpenney","html_url":"https://github.com/wardpenney","followers_url":"https://api.github.com/users/wardpenney/followers","following_url":"https://api.github.com/users/wardpenney/following{/other_user}","gists_url":"https://api.github.com/users/wardpenney/gists{/gist_id}","starred_url":"https://api.github.com/users/wardpenney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wardpenney/subscriptions","organizations_url":"https://api.github.com/users/wardpenney/orgs","repos_url":"https://api.github.com/users/wardpenney/repos","events_url":"https://api.github.com/users/wardpenney/events{/privacy}","received_events_url":"https://api.github.com/users/wardpenney/received_events","type":"User","site_admin":false},"body":"Did we have a semantic-use variable name for something like this, instead of the hue-named variable?","created_at":"2018-03-30T22:01:17Z","updated_at":"2018-03-30T22:02:17Z","html_url":"https://github.com/thoughtbot/design-system/pull/19#discussion_r178391781","pull_request_url":"https://api.github.com/repos/thoughtbot/design-system/pulls/19","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/design-system/pulls/comments/178391781"},"html":{"href":"https://github.com/thoughtbot/design-system/pull/19#discussion_r178391781"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/design-system/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/design-system/pulls/19","id":178640867,"html_url":"https://github.com/thoughtbot/design-system/pull/19","diff_url":"https://github.com/thoughtbot/design-system/pull/19.diff","patch_url":"https://github.com/thoughtbot/design-system/pull/19.patch","issue_url":"https://api.github.com/repos/thoughtbot/design-system/issues/19","number":19,"state":"open","locked":false,"title":"Improvements to forms","user":{"login":"tysongach","id":903327,"avatar_url":"https://avatars0.githubusercontent.com/u/903327?v=4","gravatar_id":"","url":"https://api.github.com/users/tysongach","html_url":"https://github.com/tysongach","followers_url":"https://api.github.com/users/tysongach/followers","following_url":"https://api.github.com/users/tysongach/following{/other_user}","gists_url":"https://api.github.com/users/tysongach/gists{/gist_id}","starred_url":"https://api.github.com/users/tysongach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysongach/subscriptions","organizations_url":"https://api.github.com/users/tysongach/orgs","repos_url":"https://api.github.com/users/tysongach/repos","events_url":"https://api.github.com/users/tysongach/events{/privacy}","received_events_url":"https://api.github.com/users/tysongach/received_events","type":"User","site_admin":false},"body":"Rather than `tbds-form-text-input` and `tbds-form-label` being their own Elements (within the BEM naming scheme), this wraps them under a cohesive form component (or Block in BEM). This is because these elements were being styled the way they were because they are part of a form. And this is exactly the clarity that BEM class names can provide.\r\n\r\nBreaking changes:\r\n\r\n- `tbds-form-label` is now `tbds-form__label`\r\n- `tbds-form-text-input` is now `tbds-form__text-input`\r\n- `tbds-form-input-button-unit` is now `tbds-input-button-unit`\r\n\r\n---\r\n\r\nHere's a sample form built using these classes:\r\n\r\n![localhost_4567_](https://user-images.githubusercontent.com/903327/38154694-76a3db46-3441-11e8-9791-7de329e365f8.png)","created_at":"2018-03-30T21:44:40Z","updated_at":"2018-03-30T22:02:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20213ccb2f7f11bb1bbeb4202944ec04b57864e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/design-system/pulls/19/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/design-system/pulls/19/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/design-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/design-system/issues/19/comments","statuses_url":"https://api.github.com/repos/thoughtbot/design-system/statuses/fc68b8c9beaced6743cbf66ea76c010df813f47a","head":{"label":"thoughtbot:tg-form","ref":"tg-form","sha":"fc68b8c9beaced6743cbf66ea76c010df813f47a","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":114290977,"name":"design-system","full_name":"thoughtbot/design-system","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/design-system","description":"thoughtbot design system","fork":false,"url":"https://api.github.com/repos/thoughtbot/design-system","forks_url":"https://api.github.com/repos/thoughtbot/design-system/forks","keys_url":"https://api.github.com/repos/thoughtbot/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/design-system/teams","hooks_url":"https://api.github.com/repos/thoughtbot/design-system/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/design-system/events","assignees_url":"https://api.github.com/repos/thoughtbot/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/design-system/tags","blobs_url":"https://api.github.com/repos/thoughtbot/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/design-system/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/design-system/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/design-system/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/design-system/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/design-system/subscription","commits_url":"https://api.github.com/repos/thoughtbot/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/design-system/merges","archive_url":"https://api.github.com/repos/thoughtbot/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/design-system/downloads","issues_url":"https://api.github.com/repos/thoughtbot/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/design-system/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/design-system/deployments","created_at":"2017-12-14T19:58:31Z","updated_at":"2018-03-26T21:16:25Z","pushed_at":"2018-03-30T21:50:56Z","git_url":"git://github.com/thoughtbot/design-system.git","ssh_url":"git@github.com:thoughtbot/design-system.git","clone_url":"https://github.com/thoughtbot/design-system.git","svn_url":"https://github.com/thoughtbot/design-system","homepage":"","size":197,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"89aef242982cfe2d0906269943f218b522d9481b","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":114290977,"name":"design-system","full_name":"thoughtbot/design-system","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/design-system","description":"thoughtbot design system","fork":false,"url":"https://api.github.com/repos/thoughtbot/design-system","forks_url":"https://api.github.com/repos/thoughtbot/design-system/forks","keys_url":"https://api.github.com/repos/thoughtbot/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/design-system/teams","hooks_url":"https://api.github.com/repos/thoughtbot/design-system/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/design-system/events","assignees_url":"https://api.github.com/repos/thoughtbot/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/design-system/tags","blobs_url":"https://api.github.com/repos/thoughtbot/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/design-system/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/design-system/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/design-system/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/design-system/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/design-system/subscription","commits_url":"https://api.github.com/repos/thoughtbot/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/design-system/merges","archive_url":"https://api.github.com/repos/thoughtbot/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/design-system/downloads","issues_url":"https://api.github.com/repos/thoughtbot/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/design-system/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/design-system/deployments","created_at":"2017-12-14T19:58:31Z","updated_at":"2018-03-26T21:16:25Z","pushed_at":"2018-03-30T21:50:56Z","git_url":"git://github.com/thoughtbot/design-system.git","ssh_url":"git@github.com:thoughtbot/design-system.git","clone_url":"https://github.com/thoughtbot/design-system.git","svn_url":"https://github.com/thoughtbot/design-system","homepage":"","size":197,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/design-system/pulls/19"},"html":{"href":"https://github.com/thoughtbot/design-system/pull/19"},"issue":{"href":"https://api.github.com/repos/thoughtbot/design-system/issues/19"},"comments":{"href":"https://api.github.com/repos/thoughtbot/design-system/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/design-system/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/design-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/design-system/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/design-system/statuses/fc68b8c9beaced6743cbf66ea76c010df813f47a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"wardpenney"}}