{"push_id":2920883369,"size":21,"distinct_size":3,"ref":"refs/heads/in_clause_length_at_database_yml","head":"3e11bc4e2a481c1b18648aadd649a3657e6605d5","before":"e3c19550cf8c3b777b844b601ed5f1d7ee5a4809","commits":[{"sha":"e385e4678fc64be6e176c3bdac6641db9fe48d85","author":{"name":"Ilkka Oksanen","email":"d41be4f616b5f89e38122e6d2d52cd7074f22e3a@iki.fi"},"message":"Don't handle params option in a special way in url_for helper","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/e385e4678fc64be6e176c3bdac6641db9fe48d85"},{"sha":"5e4c22dfbb6dad676f74ded50b8c2536834a46a7","author":{"name":"Mehmet Emin INAC","email":"e6fe9b428cbd844027679efe8ffd169eb501ceab@gmail.com"},"message":"Index option added for change_table migrations\n\nIn case if we want to add a column into the existing table\nwith index on it, we have to add column and index in two\nseperate lines.\nWith this feature we don't need to write an extra line to\nadd index for column. We can just use `index` option.\n\nOld behaviour in action:\n```\n  change_table(:languages) do |t|\n    t.string :country_code\n    t.index: :country_code\n  end\n```\n\nNew behaviour in action:\n```\n  change_table(:languages) do |t|\n    t.string :country_code, index: true\n  end\n```\n\nExactly same behaviour is already exist for `create_table` migrations.","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/5e4c22dfbb6dad676f74ded50b8c2536834a46a7"},{"sha":"aa3dcabd874a3e82e455e85a1c94a7abaac2900a","author":{"name":"Yasuo Honda","email":"815806a5fcba2cb411d0f70b662adf0091c5dee5@gmail.com"},"message":"Add `Style/RedundantFreeze` to remove redudant `.freeze`\n\nSince Rails 6.0 will support Ruby 2.4.1 or higher\n`# frozen_string_literal: true` magic comment is enough to make string object frozen.\nThis magic comment is enabled by `Style/FrozenStringLiteralComment` cop.\n\n* Exclude these files not to auto correct false positive `Regexp#freeze`\n - 'actionpack/lib/action_dispatch/journey/router/utils.rb'\n - 'activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb'\n\nIt has been fixed by https://github.com/rubocop-hq/rubocop/pull/6333\nOnce the newer version of RuboCop released and available at Code Climate these exclude entries should be removed.\n\n* Replace `String#freeze` with `String#-@` manually if explicit frozen string objects are required\n\n - 'actionpack/test/controller/test_case_test.rb'\n - 'activemodel/test/cases/type/string_test.rb'\n - 'activesupport/lib/active_support/core_ext/string/strip.rb'\n - 'activesupport/test/core_ext/string_ext_test.rb'\n - 'railties/test/generators/actions_test.rb'","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/aa3dcabd874a3e82e455e85a1c94a7abaac2900a"},{"sha":"7ea546b5c661b18067ebec9d0badbd3c393964d2","author":{"name":"yuuji.yaginuma","email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com"},"message":"Make `test_initialize_with_invalid_attribute` work correctly\n\nOriginally specified attributes were only normal values, and\n`ActiveRecord::MultiparameterAssignmentErrors` did not occur.\n\nIn addition, an assertion is performed only on rescue, even if an\nexception does not occur, the test passes. To avoid this use `assert_raise`.","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/7ea546b5c661b18067ebec9d0badbd3c393964d2"},{"sha":"8bc0a43a2471f353f957bd422bffafa510a44282","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Remove `visit_Fixnum` and `visit_Bignum`\n\nFollow up ae406cd633dab2cafbc0d1bb5922d1ca40056ea0.","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/8bc0a43a2471f353f957bd422bffafa510a44282"},{"sha":"09de7c91707b83a6c6ff8ab1a176cc1bf92ebb4d","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Use private attr_reader in Arel\n\nNo longer needed workaround for Ruby 2.2 \"private attribute?\" warning.\n\nRelated 6d63b5e49a399fe246afcebad45c3c962de268fa.","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/09de7c91707b83a6c6ff8ab1a176cc1bf92ebb4d"},{"sha":"683a0b5042262d841bfed687a4c56125364cf7a7","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"`visitor.accept` doesn't handle `&block`","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/683a0b5042262d841bfed687a4c56125364cf7a7"},{"sha":"298629cefd845caf2cea28eb9cee2b538accc4ee","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"`SQLString#compile` is no longer used since 53521a9e39b9d8af4165d7703c36dc905f1f8f67","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/298629cefd845caf2cea28eb9cee2b538accc4ee"},{"sha":"859fba7c4bf7d33b4f9655914ed4bdc85380552e","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Handle DELETE with LIMIT in Arel\n\nMySQL supports DELETE with LIMIT and ORDER BY.\n\nhttps://dev.mysql.com/doc/refman/8.0/en/delete.html\n\nBefore:\n\n```\n  Post Destroy (1.0ms)  DELETE FROM `posts` WHERE `posts`.`id` IN (SELECT `id` FROM (SELECT `posts`.`id` FROM `posts` WHERE `posts`.`author_id` = ? ORDER BY `posts`.`id` ASC LIMIT ?) __active_record_temp)  [[\"author_id\", 1], [\"LIMIT\", 1]]\n```\n\nAfter:\n\n```\n  Post Destroy (0.4ms)  DELETE FROM `posts` WHERE `posts`.`author_id` = ? ORDER BY `posts`.`id` ASC LIMIT ?  [[\"author_id\", 1], [\"LIMIT\", 1]]\n```","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/859fba7c4bf7d33b4f9655914ed4bdc85380552e"},{"sha":"df9c972afe88e3c9c65bfcd96eddca927a42b5e3","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Place `PartialQuery` and `PartialQueryCollector` in the same file","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/df9c972afe88e3c9c65bfcd96eddca927a42b5e3"},{"sha":"5f6a906094641a8830d35dcc5e79cafa8c1db872","author":{"name":"Lachlan Sylvester","email":"ef4261e56dd60f493eb2aacead578dc6cf4232df@hypothetical.com.au"},"message":"Require the except hash extension before trying to alias it","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/5f6a906094641a8830d35dcc5e79cafa8c1db872"},{"sha":"09f92a1b9883927dbeda23a0cc145a2a62a9df60","author":{"name":"Yuji Yaginuma","email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com"},"message":"Merge pull request #34031 from lsylvester/require-except-before-aliasing-it\n\nRequire the except hash extension before trying to alias it","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/09f92a1b9883927dbeda23a0cc145a2a62a9df60"},{"sha":"9d7d6336d79149c9932854517a777c3b304d7fdf","author":{"name":"lsylvester","email":"ef4261e56dd60f493eb2aacead578dc6cf4232df@hypothetical.com.au"},"message":"make actionview templates marshalable so that they can be serialized during the parallel tests (#34030)","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/9d7d6336d79149c9932854517a777c3b304d7fdf"},{"sha":"b707a6d0eb7a694595152c5ca18f1e72e0bc2f7e","author":{"name":"David Heinemeier Hansson","email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@loudthinking.com"},"message":"Explain why we have explicit marshaling methods","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/b707a6d0eb7a694595152c5ca18f1e72e0bc2f7e"},{"sha":"b13a5cb83ea00d6a3d71320fd276ca21049c2544","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Merge pull request #32031 from yahonda/remove_redundant_freeze\n\nAdd `Style/RedundantFreeze` to remove redudant `.freeze`","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/b13a5cb83ea00d6a3d71320fd276ca21049c2544"},{"sha":"28ac0b30f24ce4d4da8a21da06d2f84ad4fce3bf","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Merge pull request #33256 from ilkkao/ilkkao/remove-unused-params-option\n\nDon't handle params option in a special way in url_for helper","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/28ac0b30f24ce4d4da8a21da06d2f84ad4fce3bf"},{"sha":"322c5704e5ab8cc9bc3cfffecd3b06641d95f2b4","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Merge pull request #23593 from meinac/add_index_option_for_change_table\n\nindex option added for change_table migrations","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/322c5704e5ab8cc9bc3cfffecd3b06641d95f2b4"},{"sha":"6d40d2d3d1f3766551e74607a718a5ec97963bbf","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Handle UPDATE/DELETE with OFFSET in Arel","distinct":false,"url":"https://api.github.com/repos/yahonda/rails/commits/6d40d2d3d1f3766551e74607a718a5ec97963bbf"},{"sha":"4838c1716a0340137d858fab49bf460e23be5a4b","author":{"name":"David Heinemeier Hansson","email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@loudthinking.com"},"message":"Make Webpacker the default JavaScript compiler for Rails 6 (#33079)\n\n* Use Webpacker by default on new apps\r\n\r\n* Stop including coffee-rails by default\r\n\r\n* Drop using a js_compressor by default\r\n\r\n* Drop extra test for coffeescript inclusion by default\r\n\r\n* Stick with skip_javascript to signify skipping webpack\r\n\r\n* Don't install a JS runtime by default any more\r\n\r\n* app/javascript will be the new default directory for JS\r\n\r\n* Make it clear that this is just for configuring the default Webpack framework setup now\r\n\r\n* Start using the Webpack tag in the default layout\r\n\r\n* Irrelevant test\r\n\r\n* jQuery is long gone\r\n\r\n* Stop having asset pipeline compile default application.js\r\n\r\n* Add rails-ujs by default to the Webpack setup\r\n\r\n* Add Active Storage JavaScript to application.js pack by default\r\n\r\n* Consistent quoting\r\n\r\n* Add Turbolinks to default pack\r\n\r\n* Add Action Cable to default pack\r\n\r\nNeed some work on how to set the global consumer that channels will\r\nwork with. @javan?\r\n\r\n* Require all channels by default and use a separate consumer stub\r\n\r\n* Channel generator now targets Webpack style\r\n\r\n* Update task docs to match new generator style\r\n\r\n* Use uniform import style\r\n\r\n* Drop the JS assets generator\r\n\r\nIt was barely helpful as it was. It’s no longer helpful in a Webpacked\r\nworld. Sayonara!\r\n\r\n* Add app/javascript to the stats directories\r\n\r\n* Simpler import style\r\n\r\nWhich match the other imports.\r\n\r\n* Address test failures from dropping JS compilation (and compression)\r\n\r\n* webpacker-default: Modify `AssetsGeneratorTest`\r\n\r\nBefore:\r\n\r\n```\r\n$ bin/test test/generators/assets_generator_test.rb\r\nRun options: --seed 46201\r\n\r\nF\r\n\r\nFailure:\r\nAssetsGeneratorTest#test_assets [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/assets_generator_test.rb:12]:\r\nExpected file \"app/assets/javascripts/posts.js\" to exist, but does not\r\n\r\nbin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/assets_generator_test.rb:10\r\n\r\n.\r\n\r\nFinished in 0.031343s, 63.8101 runs/s, 95.7152 assertions/s.\r\n2 runs, 3 assertions, 1 failures, 0 errors, 0 skips\r\n```\r\n\r\nAfter:\r\n\r\n```\r\n$ bin/test test/generators/assets_generator_test.rb\r\nRun options: --seed 43571\r\n\r\n..\r\n\r\nFinished in 0.030370s, 65.8545 runs/s, 65.8545 assertions/s.\r\n2 runs, 2 assertions, 0 failures, 0 errors, 0 skips\r\n```\r\n\r\n* webpacker-default: Modify `ChannelGeneratorTest`\r\n\r\nBefore:\r\n\r\n```\r\n$ bin/test test/generators/channel_generator_test.rb\r\nRun options: --seed 8986\r\n\r\n.F\r\n\r\nFailure:\r\nChannelGeneratorTest#test_channel_with_multiple_actions_is_created [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:43]:\r\nExpected file \"app/assets/javascripts/channels/chat.js\" to exist, but does not\r\n\r\nbin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:34\r\n\r\n.F\r\n\r\nFailure:\r\nChannelGeneratorTest#test_channel_is_created [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:29]:\r\nExpected file \"app/assets/javascripts/channels/chat.js\" to exist, but does not\r\n\r\nbin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:22\r\n\r\nE\r\n\r\nError:\r\nChannelGeneratorTest#test_cable_js_is_created_if_not_present_already:\r\nErrno::ENOENT: No such file or directory @ apply2files - /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/fixtures/tmp/app/assets/javascripts/cable.js\r\n\r\nbin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:60\r\n\r\nF\r\n\r\nFailure:\r\nChannelGeneratorTest#test_channel_suffix_is_not_duplicated [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:87]:\r\nExpected file \"app/assets/javascripts/channels/chat.js\" to exist, but does not\r\n\r\nbin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:80\r\n\r\nF\r\n\r\nFailure:\r\nChannelGeneratorTest#test_channel_on_revoke [/Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:77]:\r\nExpected file \"app/assets/javascripts/cable.js\" to exist, but does not\r\n\r\nbin/test /Users/ttanimichi/ghq/github.com/ttanimichi/rails/railties/test/generators/channel_generator_test.rb:68\r\n\r\nFinished in 0.064384s, 108.7227 runs/s, 481.4861 assertions/s.\r\n7 runs, 31 assertions, 4 failures, 1 errors, 0 skips\r\n```\r\n\r\nAfter:\r\n\r\n```\r\n$ bin/test test/generators/channel_generator_test.rb\r\nRun options: --seed 44857\r\n\r\n.......\r\n\r\nFinished in 0.060243s, 116.1961 runs/s, 697.1764 assertions/s.\r\n7 runs, 42 assertions, 0 failures, 0 errors, 0 skips\r\n```\r\n\r\n* Fix shared generator tests.\r\n\r\n* webpacker-default: Modify `ControllerGeneratorTest`\r\n\r\nThe JS assets generator was dropped. ref. https://github.com/rails/rails/commit/46215b179483d3e4d264555f5a4952f43eb8142a\r\n\r\n* Revert \"Simpler import style\". It's currently failing with an error of \"TypeError: undefined is not an object (evaluating '__WEBPACK_IMPORTED_MODULE_2_activestorage___default.a.start')\". Waiting for @javan to have a look.\r\n\r\nThis reverts commit 5d3ebb71059f635d3756cbda4ab9752027e09256.\r\n\r\n* require webpacker in test app\r\n\r\n* Add webpacker without making the build hang/timeout. (#33640)\r\n\r\n* use yarn workspaces to allow for installing unreleased packages and only generate js/bootsnap when required\r\n\r\n* no longer need to have webpacker in env templates as webpacker moved this config to yml file\r\n\r\n* Fix rubocop violation\r\n\r\n* Got the test passing for the running scaffold\r\n\r\n* update expected lines of code\r\n\r\n* update middleware tests to account for webpacker\r\n\r\n* disable js in plugins be default to get the tests passing (#34009)\r\n\r\n* clear codeclimate report issues\r\n\r\n* Anything newer than currently released is good\r\n\r\n* Use Webpacker development version during development of Rails\r\n\r\n* Edge should get development webpacker as well\r\n\r\n* Add changelog entry for Webpacker change","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/4838c1716a0340137d858fab49bf460e23be5a4b"},{"sha":"2334fe8ffab7aa67504ae4a6b483f1a914b415bb","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Remove duplicated before_install entries in .travis.yml\n\nIt has incorrectly been re-added at #33079.\n\nRelated #33861.","distinct":true,"url":"https://api.github.com/repos/yahonda/rails/commits/2334fe8ffab7aa67504ae4a6b483f1a914b415bb"}]}
{"actor":{"display_login":"yahonda"}}