{"action":"closed","number":139,"pull_request":{"url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/pulls/139","id":168338777,"html_url":"https://github.com/Islandora/islandora_solution_pack_compound/pull/139","diff_url":"https://github.com/Islandora/islandora_solution_pack_compound/pull/139.diff","patch_url":"https://github.com/Islandora/islandora_solution_pack_compound/pull/139.patch","issue_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/issues/139","number":139,"state":"closed","locked":false,"title":"Fix double escaping","user":{"login":"jonathangreen","id":569437,"avatar_url":"https://avatars3.githubusercontent.com/u/569437?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathangreen","html_url":"https://github.com/jonathangreen","followers_url":"https://api.github.com/users/jonathangreen/followers","following_url":"https://api.github.com/users/jonathangreen/following{/other_user}","gists_url":"https://api.github.com/users/jonathangreen/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathangreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathangreen/subscriptions","organizations_url":"https://api.github.com/users/jonathangreen/orgs","repos_url":"https://api.github.com/users/jonathangreen/repos","events_url":"https://api.github.com/users/jonathangreen/events{/privacy}","received_events_url":"https://api.github.com/users/jonathangreen/received_events","type":"User","site_admin":false},"body":"## JIRA Ticket: \r\nhttps://dev-islandora.lyrasistechnology.org/islandora/object/lyrasis:3675\r\n\r\n## What does this Pull Request do?\r\n\r\nThis was double escaping the title of compound objects with a needless `t()` function, remove the `t()` function and use the variable directly. \r\n\r\n![screen shot 2018-02-09 at 4 40 40 pm](https://user-images.githubusercontent.com/569437/36049174-3e9eafaa-0db8-11e8-969e-c0165d94b508.png)\r\n\r\n## What's new?\r\n\r\nBoth `t` and `link` sanitize the text resulting in double escaping. Remove the `t()` function. Could be a problem if someone is actually using this `t()` but I don't see how that would be possible, since it only contains a variable...\r\n\r\n## How should this be tested?\r\n\r\n1. Add a compound to an object with a ` in it. See its double escaped (using jail block). \r\n2. Apply patch, check its no longer double escaped.\r\n\r\n## Interested parties\r\n@whikloj @Islandora/7-x-1-x-committers","created_at":"2018-02-09T20:48:11Z","updated_at":"2018-02-12T14:12:25Z","closed_at":"2018-02-12T14:12:25Z","merged_at":"2018-02-12T14:12:25Z","merge_commit_sha":"50a2d8599ca1c47f135fbeed9b2b589416c8d343","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/pulls/139/commits","review_comments_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/pulls/139/comments","review_comment_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/issues/139/comments","statuses_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/statuses/7a7a66653929b75f32798051bab9f853377cfd2c","head":{"label":"jonathangreen:escaping","ref":"escaping","sha":"7a7a66653929b75f32798051bab9f853377cfd2c","user":{"login":"jonathangreen","id":569437,"avatar_url":"https://avatars3.githubusercontent.com/u/569437?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathangreen","html_url":"https://github.com/jonathangreen","followers_url":"https://api.github.com/users/jonathangreen/followers","following_url":"https://api.github.com/users/jonathangreen/following{/other_user}","gists_url":"https://api.github.com/users/jonathangreen/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathangreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathangreen/subscriptions","organizations_url":"https://api.github.com/users/jonathangreen/orgs","repos_url":"https://api.github.com/users/jonathangreen/repos","events_url":"https://api.github.com/users/jonathangreen/events{/privacy}","received_events_url":"https://api.github.com/users/jonathangreen/received_events","type":"User","site_admin":false},"repo":{"id":74395974,"name":"islandora_solution_pack_compound","full_name":"jonathangreen/islandora_solution_pack_compound","owner":{"login":"jonathangreen","id":569437,"avatar_url":"https://avatars3.githubusercontent.com/u/569437?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathangreen","html_url":"https://github.com/jonathangreen","followers_url":"https://api.github.com/users/jonathangreen/followers","following_url":"https://api.github.com/users/jonathangreen/following{/other_user}","gists_url":"https://api.github.com/users/jonathangreen/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathangreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathangreen/subscriptions","organizations_url":"https://api.github.com/users/jonathangreen/orgs","repos_url":"https://api.github.com/users/jonathangreen/repos","events_url":"https://api.github.com/users/jonathangreen/events{/privacy}","received_events_url":"https://api.github.com/users/jonathangreen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonathangreen/islandora_solution_pack_compound","description":"Adds the ability to to create compound objects using objects created with any other Islandora solution pack by enabling a generic parent-child relationships between objects.","fork":true,"url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound","forks_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/forks","keys_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/teams","hooks_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/hooks","issue_events_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/issues/events{/number}","events_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/events","assignees_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/assignees{/user}","branches_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/branches{/branch}","tags_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/tags","blobs_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/statuses/{sha}","languages_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/languages","stargazers_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/stargazers","contributors_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/contributors","subscribers_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/subscribers","subscription_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/subscription","commits_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/contents/{+path}","compare_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/merges","archive_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/downloads","issues_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/issues{/number}","pulls_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/pulls{/number}","milestones_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/milestones{/number}","notifications_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/labels{/name}","releases_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/releases{/id}","deployments_url":"https://api.github.com/repos/jonathangreen/islandora_solution_pack_compound/deployments","created_at":"2016-11-21T19:00:28Z","updated_at":"2016-11-21T19:00:29Z","pushed_at":"2018-02-09T20:49:34Z","git_url":"git://github.com/jonathangreen/islandora_solution_pack_compound.git","ssh_url":"git@github.com:jonathangreen/islandora_solution_pack_compound.git","clone_url":"https://github.com/jonathangreen/islandora_solution_pack_compound.git","svn_url":"https://github.com/jonathangreen/islandora_solution_pack_compound","homepage":"","size":309,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"7.x"}},"base":{"label":"Islandora:7.x","ref":"7.x","sha":"3031445d6bac1e3b8afd91066143075b70eb6fe9","user":{"login":"Islandora","id":494054,"avatar_url":"https://avatars3.githubusercontent.com/u/494054?v=4","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"repo":{"id":8293780,"name":"islandora_solution_pack_compound","full_name":"Islandora/islandora_solution_pack_compound","owner":{"login":"Islandora","id":494054,"avatar_url":"https://avatars3.githubusercontent.com/u/494054?v=4","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Islandora/islandora_solution_pack_compound","description":"Adds the ability to to create compound objects using objects created with any other Islandora solution pack by enabling a generic parent-child relationships between objects.","fork":true,"url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound","forks_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/forks","keys_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/teams","hooks_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/hooks","issue_events_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/issues/events{/number}","events_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/events","assignees_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/assignees{/user}","branches_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/branches{/branch}","tags_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/tags","blobs_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/git/refs{/sha}","trees_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/statuses/{sha}","languages_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/languages","stargazers_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/stargazers","contributors_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/contributors","subscribers_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/subscribers","subscription_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/subscription","commits_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/commits{/sha}","git_commits_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/git/commits{/sha}","comments_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/comments{/number}","issue_comment_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/issues/comments{/number}","contents_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/contents/{+path}","compare_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/merges","archive_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/downloads","issues_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/issues{/number}","pulls_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/pulls{/number}","milestones_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/milestones{/number}","notifications_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/labels{/name}","releases_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/releases{/id}","deployments_url":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/deployments","created_at":"2013-02-19T16:03:30Z","updated_at":"2016-11-17T19:23:49Z","pushed_at":"2018-02-12T14:12:25Z","git_url":"git://github.com/Islandora/islandora_solution_pack_compound.git","ssh_url":"git@github.com:Islandora/islandora_solution_pack_compound.git","clone_url":"https://github.com/Islandora/islandora_solution_pack_compound.git","svn_url":"https://github.com/Islandora/islandora_solution_pack_compound","homepage":"","size":315,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":40,"open_issues":1,"watchers":1,"default_branch":"7.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/pulls/139"},"html":{"href":"https://github.com/Islandora/islandora_solution_pack_compound/pull/139"},"issue":{"href":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/issues/139"},"comments":{"href":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/Islandora/islandora_solution_pack_compound/statuses/7a7a66653929b75f32798051bab9f853377cfd2c"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"DiegoPino","id":6946023,"avatar_url":"https://avatars2.githubusercontent.com/u/6946023?v=4","gravatar_id":"","url":"https://api.github.com/users/DiegoPino","html_url":"https://github.com/DiegoPino","followers_url":"https://api.github.com/users/DiegoPino/followers","following_url":"https://api.github.com/users/DiegoPino/following{/other_user}","gists_url":"https://api.github.com/users/DiegoPino/gists{/gist_id}","starred_url":"https://api.github.com/users/DiegoPino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DiegoPino/subscriptions","organizations_url":"https://api.github.com/users/DiegoPino/orgs","repos_url":"https://api.github.com/users/DiegoPino/repos","events_url":"https://api.github.com/users/DiegoPino/events{/privacy}","received_events_url":"https://api.github.com/users/DiegoPino/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"DiegoPino"}}