{"action":"closed","number":5808,"pull_request":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/5808","id":174207325,"html_url":"https://github.com/crystal-lang/crystal/pull/5808","diff_url":"https://github.com/crystal-lang/crystal/pull/5808.diff","patch_url":"https://github.com/crystal-lang/crystal/pull/5808.patch","issue_url":"https://api.github.com/repos/crystal-lang/crystal/issues/5808","number":5808,"state":"closed","locked":false,"title":"Semantic: Allow macro overload on named args","user":{"login":"bew","id":9730330,"avatar_url":"https://avatars1.githubusercontent.com/u/9730330?v=4","gravatar_id":"","url":"https://api.github.com/users/bew","html_url":"https://github.com/bew","followers_url":"https://api.github.com/users/bew/followers","following_url":"https://api.github.com/users/bew/following{/other_user}","gists_url":"https://api.github.com/users/bew/gists{/gist_id}","starred_url":"https://api.github.com/users/bew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bew/subscriptions","organizations_url":"https://api.github.com/users/bew/orgs","repos_url":"https://api.github.com/users/bew/repos","events_url":"https://api.github.com/users/bew/events{/privacy}","received_events_url":"https://api.github.com/users/bew/received_events","type":"User","site_admin":false},"body":"I think this is my first PR in the compiler, deep into the semantic pass :tada: \r\n\r\nFixes #5769 \r\n\r\nI added a few comments here and there to help me understand what some parts does, I can remove them if needed. I also fixed a bad argument name (`a_def` => `a_macro`) in 2 macro-related methods.\r\n\r\nI'll add more specs later if you think what I did is correct.\r\nThank you!","created_at":"2018-03-11T06:47:33Z","updated_at":"2018-04-14T08:13:26Z","closed_at":"2018-04-14T08:13:26Z","merged_at":"2018-04-14T08:13:26Z","merge_commit_sha":"a3279079a68fae9cb2057ee3ba8c3b32e328e4dc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asterite","id":209371,"avatar_url":"https://avatars0.githubusercontent.com/u/209371?v=4","gravatar_id":"","url":"https://api.github.com/users/asterite","html_url":"https://github.com/asterite","followers_url":"https://api.github.com/users/asterite/followers","following_url":"https://api.github.com/users/asterite/following{/other_user}","gists_url":"https://api.github.com/users/asterite/gists{/gist_id}","starred_url":"https://api.github.com/users/asterite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterite/subscriptions","organizations_url":"https://api.github.com/users/asterite/orgs","repos_url":"https://api.github.com/users/asterite/repos","events_url":"https://api.github.com/users/asterite/events{/privacy}","received_events_url":"https://api.github.com/users/asterite/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":20487867,"url":"https://api.github.com/repos/crystal-lang/crystal/labels/kind:bug","name":"kind:bug","color":"fc2929","default":false},{"id":253019637,"url":"https://api.github.com/repos/crystal-lang/crystal/labels/topic:compiler","name":"topic:compiler","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/5808/commits","review_comments_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/5808/comments","review_comment_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/issues/5808/comments","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/da0ce05854c7aa4001e6199b6eda597d091cabdc","head":{"label":"bew:allow-macro-overload-on-named-args","ref":"allow-macro-overload-on-named-args","sha":"da0ce05854c7aa4001e6199b6eda597d091cabdc","user":{"login":"bew","id":9730330,"avatar_url":"https://avatars1.githubusercontent.com/u/9730330?v=4","gravatar_id":"","url":"https://api.github.com/users/bew","html_url":"https://github.com/bew","followers_url":"https://api.github.com/users/bew/followers","following_url":"https://api.github.com/users/bew/following{/other_user}","gists_url":"https://api.github.com/users/bew/gists{/gist_id}","starred_url":"https://api.github.com/users/bew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bew/subscriptions","organizations_url":"https://api.github.com/users/bew/orgs","repos_url":"https://api.github.com/users/bew/repos","events_url":"https://api.github.com/users/bew/events{/privacy}","received_events_url":"https://api.github.com/users/bew/received_events","type":"User","site_admin":false},"repo":{"id":76088300,"name":"crystal","full_name":"bew/crystal","owner":{"login":"bew","id":9730330,"avatar_url":"https://avatars1.githubusercontent.com/u/9730330?v=4","gravatar_id":"","url":"https://api.github.com/users/bew","html_url":"https://github.com/bew","followers_url":"https://api.github.com/users/bew/followers","following_url":"https://api.github.com/users/bew/following{/other_user}","gists_url":"https://api.github.com/users/bew/gists{/gist_id}","starred_url":"https://api.github.com/users/bew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bew/subscriptions","organizations_url":"https://api.github.com/users/bew/orgs","repos_url":"https://api.github.com/users/bew/repos","events_url":"https://api.github.com/users/bew/events{/privacy}","received_events_url":"https://api.github.com/users/bew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bew/crystal","description":"The Crystal Programming Language","fork":true,"url":"https://api.github.com/repos/bew/crystal","forks_url":"https://api.github.com/repos/bew/crystal/forks","keys_url":"https://api.github.com/repos/bew/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bew/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bew/crystal/teams","hooks_url":"https://api.github.com/repos/bew/crystal/hooks","issue_events_url":"https://api.github.com/repos/bew/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/bew/crystal/events","assignees_url":"https://api.github.com/repos/bew/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/bew/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/bew/crystal/tags","blobs_url":"https://api.github.com/repos/bew/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bew/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bew/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/bew/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bew/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/bew/crystal/languages","stargazers_url":"https://api.github.com/repos/bew/crystal/stargazers","contributors_url":"https://api.github.com/repos/bew/crystal/contributors","subscribers_url":"https://api.github.com/repos/bew/crystal/subscribers","subscription_url":"https://api.github.com/repos/bew/crystal/subscription","commits_url":"https://api.github.com/repos/bew/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/bew/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/bew/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/bew/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/bew/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/bew/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bew/crystal/merges","archive_url":"https://api.github.com/repos/bew/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bew/crystal/downloads","issues_url":"https://api.github.com/repos/bew/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/bew/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/bew/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/bew/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bew/crystal/labels{/name}","releases_url":"https://api.github.com/repos/bew/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/bew/crystal/deployments","created_at":"2016-12-10T03:36:13Z","updated_at":"2018-04-13T04:14:06Z","pushed_at":"2018-04-13T22:15:20Z","git_url":"git://github.com/bew/crystal.git","ssh_url":"git@github.com:bew/crystal.git","clone_url":"https://github.com/bew/crystal.git","svn_url":"https://github.com/bew/crystal","homepage":"http://crystal-lang.org","size":36300,"stargazers_count":0,"watchers_count":0,"language":"Crystal","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crystal-lang:master","ref":"master","sha":"ed0aad89ed476b58fc444e975881b2356b37541e","user":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":6887813,"name":"crystal","full_name":"crystal-lang/crystal","owner":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crystal-lang/crystal","description":"The Crystal Programming Language","fork":false,"url":"https://api.github.com/repos/crystal-lang/crystal","forks_url":"https://api.github.com/repos/crystal-lang/crystal/forks","keys_url":"https://api.github.com/repos/crystal-lang/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crystal-lang/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crystal-lang/crystal/teams","hooks_url":"https://api.github.com/repos/crystal-lang/crystal/hooks","issue_events_url":"https://api.github.com/repos/crystal-lang/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/crystal-lang/crystal/events","assignees_url":"https://api.github.com/repos/crystal-lang/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/crystal-lang/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/crystal-lang/crystal/tags","blobs_url":"https://api.github.com/repos/crystal-lang/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crystal-lang/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crystal-lang/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/crystal-lang/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/crystal-lang/crystal/languages","stargazers_url":"https://api.github.com/repos/crystal-lang/crystal/stargazers","contributors_url":"https://api.github.com/repos/crystal-lang/crystal/contributors","subscribers_url":"https://api.github.com/repos/crystal-lang/crystal/subscribers","subscription_url":"https://api.github.com/repos/crystal-lang/crystal/subscription","commits_url":"https://api.github.com/repos/crystal-lang/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/crystal-lang/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/crystal-lang/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/crystal-lang/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/crystal-lang/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crystal-lang/crystal/merges","archive_url":"https://api.github.com/repos/crystal-lang/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crystal-lang/crystal/downloads","issues_url":"https://api.github.com/repos/crystal-lang/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/crystal-lang/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/crystal-lang/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/crystal-lang/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crystal-lang/crystal/labels{/name}","releases_url":"https://api.github.com/repos/crystal-lang/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/crystal-lang/crystal/deployments","created_at":"2012-11-27T17:32:32Z","updated_at":"2018-04-14T07:33:07Z","pushed_at":"2018-04-14T08:13:26Z","git_url":"git://github.com/crystal-lang/crystal.git","ssh_url":"git@github.com:crystal-lang/crystal.git","clone_url":"https://github.com/crystal-lang/crystal.git","svn_url":"https://github.com/crystal-lang/crystal","homepage":"https://crystal-lang.org","size":36490,"stargazers_count":10519,"watchers_count":10519,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":846,"mirror_url":null,"archived":false,"open_issues_count":653,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":846,"open_issues":653,"watchers":10519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/5808"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/5808"},"issue":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/5808"},"comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/5808/comments"},"review_comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/5808/comments"},"review_comment":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/5808/commits"},"statuses":{"href":"https://api.github.com/repos/crystal-lang/crystal/statuses/da0ce05854c7aa4001e6199b6eda597d091cabdc"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sdogruyol","id":990485,"avatar_url":"https://avatars0.githubusercontent.com/u/990485?v=4","gravatar_id":"","url":"https://api.github.com/users/sdogruyol","html_url":"https://github.com/sdogruyol","followers_url":"https://api.github.com/users/sdogruyol/followers","following_url":"https://api.github.com/users/sdogruyol/following{/other_user}","gists_url":"https://api.github.com/users/sdogruyol/gists{/gist_id}","starred_url":"https://api.github.com/users/sdogruyol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdogruyol/subscriptions","organizations_url":"https://api.github.com/users/sdogruyol/orgs","repos_url":"https://api.github.com/users/sdogruyol/repos","events_url":"https://api.github.com/users/sdogruyol/events{/privacy}","received_events_url":"https://api.github.com/users/sdogruyol/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"maintainer_can_modify":false,"commits":7,"additions":84,"deletions":21,"changed_files":3}}
{"actor":{"display_login":"sdogruyol"}}