{"action":"created","comment":{"url":"https://api.github.com/repos/ConsenSys/ethql/pulls/comments/196844097","pull_request_review_id":130473769,"id":196844097,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Njg0NDA5Nw==","diff_hunk":"@@ -89,6 +89,78 @@ describe('transactionFilter on Block->transactions', async () => {\n     expect(result.errors).toHaveLength(1);\n     expect(result.errors[0].message).toMatch(/^Expected type TransactionFilter/);\n   });\n+\n+  test('contractCreation: true value, returns only transactions with contract creations', async () => {\n+    const query = `\n+      {\n+        block(number: 4180981) {\n+          transactions(filter: { contractCreation: true }) {\n+            hash\n+          }\n+        }\n+      }\n+    `;\n+\n+    const expected = { data: { block: { transactions: [\n+      {\n+        'hash': '0xab8565481d5edcd162da315bf194b349451b37efbe10e068c601a8cfa84728ca'\n+      }\n+    ] } } };\n+    const result = await execQuery(query);\n+    expect(result).toEqual(expected);\n+  });\n+\n+  test('contractCreation: false value, returns only transactions without contract creations', async () => {\n+    const query = `\n+      {\n+        block(number: 5818471) {\n+          transactions(filter: { contractCreation: false }) {\n+            hash","path":"src/__tests__/core/block.transactionFilter.test.ts","position":30,"original_position":30,"commit_id":"9b3cd0824e78912cac825a36016c7b5bd160d907","original_commit_id":"9b3cd0824e78912cac825a36016c7b5bd160d907","user":{"login":"akhila-raju","id":5432198,"node_id":"MDQ6VXNlcjU0MzIxOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5432198?v=4","gravatar_id":"","url":"https://api.github.com/users/akhila-raju","html_url":"https://github.com/akhila-raju","followers_url":"https://api.github.com/users/akhila-raju/followers","following_url":"https://api.github.com/users/akhila-raju/following{/other_user}","gists_url":"https://api.github.com/users/akhila-raju/gists{/gist_id}","starred_url":"https://api.github.com/users/akhila-raju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhila-raju/subscriptions","organizations_url":"https://api.github.com/users/akhila-raju/orgs","repos_url":"https://api.github.com/users/akhila-raju/repos","events_url":"https://api.github.com/users/akhila-raju/events{/privacy}","received_events_url":"https://api.github.com/users/akhila-raju/received_events","type":"User","site_admin":false},"body":"SGTM","created_at":"2018-06-20T16:10:43Z","updated_at":"2018-06-20T16:10:43Z","html_url":"https://github.com/ConsenSys/ethql/pull/23#discussion_r196844097","pull_request_url":"https://api.github.com/repos/ConsenSys/ethql/pulls/23","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/comments/196844097"},"html":{"href":"https://github.com/ConsenSys/ethql/pull/23#discussion_r196844097"},"pull_request":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/23"}},"in_reply_to_id":196602002},"pull_request":{"url":"https://api.github.com/repos/ConsenSys/ethql/pulls/23","id":195960581,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTYwNTgx","html_url":"https://github.com/ConsenSys/ethql/pull/23","diff_url":"https://github.com/ConsenSys/ethql/pull/23.diff","patch_url":"https://github.com/ConsenSys/ethql/pull/23.patch","issue_url":"https://api.github.com/repos/ConsenSys/ethql/issues/23","number":23,"state":"open","locked":false,"title":"Implements TransactionFilter: contractCreation filter with tests.","user":{"login":"akhila-raju","id":5432198,"node_id":"MDQ6VXNlcjU0MzIxOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5432198?v=4","gravatar_id":"","url":"https://api.github.com/users/akhila-raju","html_url":"https://github.com/akhila-raju","followers_url":"https://api.github.com/users/akhila-raju/followers","following_url":"https://api.github.com/users/akhila-raju/following{/other_user}","gists_url":"https://api.github.com/users/akhila-raju/gists{/gist_id}","starred_url":"https://api.github.com/users/akhila-raju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhila-raju/subscriptions","organizations_url":"https://api.github.com/users/akhila-raju/orgs","repos_url":"https://api.github.com/users/akhila-raju/repos","events_url":"https://api.github.com/users/akhila-raju/events{/privacy}","received_events_url":"https://api.github.com/users/akhila-raju/received_events","type":"User","site_admin":false},"body":"Contract creations can be identified by an empty `to` address in the TX.\r\n\r\nThis PR adds a `contractCreation` field of type boolean to the TransactionFilter type, with this behaviour: \r\n\r\n* When the value is true, return only contract creations (by filtering all transactions to keep only those whose `to` address is null).\r\n* When the value is false, return only transactions that are not contract creations (i.e. `to` address is populated).\r\n\r\n[ch155]","created_at":"2018-06-19T21:16:46Z","updated_at":"2018-06-20T16:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"035e43aaadb352e7ae1c6e49c2eb36375fee26ce","assignee":{"login":"akhila-raju","id":5432198,"node_id":"MDQ6VXNlcjU0MzIxOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5432198?v=4","gravatar_id":"","url":"https://api.github.com/users/akhila-raju","html_url":"https://github.com/akhila-raju","followers_url":"https://api.github.com/users/akhila-raju/followers","following_url":"https://api.github.com/users/akhila-raju/following{/other_user}","gists_url":"https://api.github.com/users/akhila-raju/gists{/gist_id}","starred_url":"https://api.github.com/users/akhila-raju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhila-raju/subscriptions","organizations_url":"https://api.github.com/users/akhila-raju/orgs","repos_url":"https://api.github.com/users/akhila-raju/repos","events_url":"https://api.github.com/users/akhila-raju/events{/privacy}","received_events_url":"https://api.github.com/users/akhila-raju/received_events","type":"User","site_admin":false},"assignees":[{"login":"akhila-raju","id":5432198,"node_id":"MDQ6VXNlcjU0MzIxOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5432198?v=4","gravatar_id":"","url":"https://api.github.com/users/akhila-raju","html_url":"https://github.com/akhila-raju","followers_url":"https://api.github.com/users/akhila-raju/followers","following_url":"https://api.github.com/users/akhila-raju/following{/other_user}","gists_url":"https://api.github.com/users/akhila-raju/gists{/gist_id}","starred_url":"https://api.github.com/users/akhila-raju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhila-raju/subscriptions","organizations_url":"https://api.github.com/users/akhila-raju/orgs","repos_url":"https://api.github.com/users/akhila-raju/repos","events_url":"https://api.github.com/users/akhila-raju/events{/privacy}","received_events_url":"https://api.github.com/users/akhila-raju/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ConsenSys/ethql/pulls/23/commits","review_comments_url":"https://api.github.com/repos/ConsenSys/ethql/pulls/23/comments","review_comment_url":"https://api.github.com/repos/ConsenSys/ethql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ConsenSys/ethql/issues/23/comments","statuses_url":"https://api.github.com/repos/ConsenSys/ethql/statuses/9b3cd0824e78912cac825a36016c7b5bd160d907","head":{"label":"akhila-raju:ccfilter","ref":"ccfilter","sha":"9b3cd0824e78912cac825a36016c7b5bd160d907","user":{"login":"akhila-raju","id":5432198,"node_id":"MDQ6VXNlcjU0MzIxOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5432198?v=4","gravatar_id":"","url":"https://api.github.com/users/akhila-raju","html_url":"https://github.com/akhila-raju","followers_url":"https://api.github.com/users/akhila-raju/followers","following_url":"https://api.github.com/users/akhila-raju/following{/other_user}","gists_url":"https://api.github.com/users/akhila-raju/gists{/gist_id}","starred_url":"https://api.github.com/users/akhila-raju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhila-raju/subscriptions","organizations_url":"https://api.github.com/users/akhila-raju/orgs","repos_url":"https://api.github.com/users/akhila-raju/repos","events_url":"https://api.github.com/users/akhila-raju/events{/privacy}","received_events_url":"https://api.github.com/users/akhila-raju/received_events","type":"User","site_admin":false},"repo":{"id":133989645,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5ODk2NDU=","name":"ethql","full_name":"akhila-raju/ethql","owner":{"login":"akhila-raju","id":5432198,"node_id":"MDQ6VXNlcjU0MzIxOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5432198?v=4","gravatar_id":"","url":"https://api.github.com/users/akhila-raju","html_url":"https://github.com/akhila-raju","followers_url":"https://api.github.com/users/akhila-raju/followers","following_url":"https://api.github.com/users/akhila-raju/following{/other_user}","gists_url":"https://api.github.com/users/akhila-raju/gists{/gist_id}","starred_url":"https://api.github.com/users/akhila-raju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhila-raju/subscriptions","organizations_url":"https://api.github.com/users/akhila-raju/orgs","repos_url":"https://api.github.com/users/akhila-raju/repos","events_url":"https://api.github.com/users/akhila-raju/events{/privacy}","received_events_url":"https://api.github.com/users/akhila-raju/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akhila-raju/ethql","description":"A GraphQL interface to Ethereum :fire:","fork":true,"url":"https://api.github.com/repos/akhila-raju/ethql","forks_url":"https://api.github.com/repos/akhila-raju/ethql/forks","keys_url":"https://api.github.com/repos/akhila-raju/ethql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akhila-raju/ethql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akhila-raju/ethql/teams","hooks_url":"https://api.github.com/repos/akhila-raju/ethql/hooks","issue_events_url":"https://api.github.com/repos/akhila-raju/ethql/issues/events{/number}","events_url":"https://api.github.com/repos/akhila-raju/ethql/events","assignees_url":"https://api.github.com/repos/akhila-raju/ethql/assignees{/user}","branches_url":"https://api.github.com/repos/akhila-raju/ethql/branches{/branch}","tags_url":"https://api.github.com/repos/akhila-raju/ethql/tags","blobs_url":"https://api.github.com/repos/akhila-raju/ethql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akhila-raju/ethql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akhila-raju/ethql/git/refs{/sha}","trees_url":"https://api.github.com/repos/akhila-raju/ethql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akhila-raju/ethql/statuses/{sha}","languages_url":"https://api.github.com/repos/akhila-raju/ethql/languages","stargazers_url":"https://api.github.com/repos/akhila-raju/ethql/stargazers","contributors_url":"https://api.github.com/repos/akhila-raju/ethql/contributors","subscribers_url":"https://api.github.com/repos/akhila-raju/ethql/subscribers","subscription_url":"https://api.github.com/repos/akhila-raju/ethql/subscription","commits_url":"https://api.github.com/repos/akhila-raju/ethql/commits{/sha}","git_commits_url":"https://api.github.com/repos/akhila-raju/ethql/git/commits{/sha}","comments_url":"https://api.github.com/repos/akhila-raju/ethql/comments{/number}","issue_comment_url":"https://api.github.com/repos/akhila-raju/ethql/issues/comments{/number}","contents_url":"https://api.github.com/repos/akhila-raju/ethql/contents/{+path}","compare_url":"https://api.github.com/repos/akhila-raju/ethql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akhila-raju/ethql/merges","archive_url":"https://api.github.com/repos/akhila-raju/ethql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akhila-raju/ethql/downloads","issues_url":"https://api.github.com/repos/akhila-raju/ethql/issues{/number}","pulls_url":"https://api.github.com/repos/akhila-raju/ethql/pulls{/number}","milestones_url":"https://api.github.com/repos/akhila-raju/ethql/milestones{/number}","notifications_url":"https://api.github.com/repos/akhila-raju/ethql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akhila-raju/ethql/labels{/name}","releases_url":"https://api.github.com/repos/akhila-raju/ethql/releases{/id}","deployments_url":"https://api.github.com/repos/akhila-raju/ethql/deployments","created_at":"2018-05-18T18:19:22Z","updated_at":"2018-06-08T20:30:23Z","pushed_at":"2018-06-19T22:53:34Z","git_url":"git://github.com/akhila-raju/ethql.git","ssh_url":"git@github.com:akhila-raju/ethql.git","clone_url":"https://github.com/akhila-raju/ethql.git","svn_url":"https://github.com/akhila-raju/ethql","homepage":"","size":234,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ConsenSys:master","ref":"master","sha":"d22b187eb55f6aaac5aa942f6a88bba6279f5ce1","user":{"login":"ConsenSys","id":10818037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODE4MDM3","avatar_url":"https://avatars3.githubusercontent.com/u/10818037?v=4","gravatar_id":"","url":"https://api.github.com/users/ConsenSys","html_url":"https://github.com/ConsenSys","followers_url":"https://api.github.com/users/ConsenSys/followers","following_url":"https://api.github.com/users/ConsenSys/following{/other_user}","gists_url":"https://api.github.com/users/ConsenSys/gists{/gist_id}","starred_url":"https://api.github.com/users/ConsenSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConsenSys/subscriptions","organizations_url":"https://api.github.com/users/ConsenSys/orgs","repos_url":"https://api.github.com/users/ConsenSys/repos","events_url":"https://api.github.com/users/ConsenSys/events{/privacy}","received_events_url":"https://api.github.com/users/ConsenSys/received_events","type":"Organization","site_admin":false},"repo":{"id":121815589,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4MTU1ODk=","name":"ethql","full_name":"ConsenSys/ethql","owner":{"login":"ConsenSys","id":10818037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODE4MDM3","avatar_url":"https://avatars3.githubusercontent.com/u/10818037?v=4","gravatar_id":"","url":"https://api.github.com/users/ConsenSys","html_url":"https://github.com/ConsenSys","followers_url":"https://api.github.com/users/ConsenSys/followers","following_url":"https://api.github.com/users/ConsenSys/following{/other_user}","gists_url":"https://api.github.com/users/ConsenSys/gists{/gist_id}","starred_url":"https://api.github.com/users/ConsenSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConsenSys/subscriptions","organizations_url":"https://api.github.com/users/ConsenSys/orgs","repos_url":"https://api.github.com/users/ConsenSys/repos","events_url":"https://api.github.com/users/ConsenSys/events{/privacy}","received_events_url":"https://api.github.com/users/ConsenSys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ConsenSys/ethql","description":"A GraphQL interface to Ethereum :fire:","fork":false,"url":"https://api.github.com/repos/ConsenSys/ethql","forks_url":"https://api.github.com/repos/ConsenSys/ethql/forks","keys_url":"https://api.github.com/repos/ConsenSys/ethql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConsenSys/ethql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConsenSys/ethql/teams","hooks_url":"https://api.github.com/repos/ConsenSys/ethql/hooks","issue_events_url":"https://api.github.com/repos/ConsenSys/ethql/issues/events{/number}","events_url":"https://api.github.com/repos/ConsenSys/ethql/events","assignees_url":"https://api.github.com/repos/ConsenSys/ethql/assignees{/user}","branches_url":"https://api.github.com/repos/ConsenSys/ethql/branches{/branch}","tags_url":"https://api.github.com/repos/ConsenSys/ethql/tags","blobs_url":"https://api.github.com/repos/ConsenSys/ethql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConsenSys/ethql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConsenSys/ethql/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConsenSys/ethql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConsenSys/ethql/statuses/{sha}","languages_url":"https://api.github.com/repos/ConsenSys/ethql/languages","stargazers_url":"https://api.github.com/repos/ConsenSys/ethql/stargazers","contributors_url":"https://api.github.com/repos/ConsenSys/ethql/contributors","subscribers_url":"https://api.github.com/repos/ConsenSys/ethql/subscribers","subscription_url":"https://api.github.com/repos/ConsenSys/ethql/subscription","commits_url":"https://api.github.com/repos/ConsenSys/ethql/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConsenSys/ethql/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConsenSys/ethql/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConsenSys/ethql/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConsenSys/ethql/contents/{+path}","compare_url":"https://api.github.com/repos/ConsenSys/ethql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConsenSys/ethql/merges","archive_url":"https://api.github.com/repos/ConsenSys/ethql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConsenSys/ethql/downloads","issues_url":"https://api.github.com/repos/ConsenSys/ethql/issues{/number}","pulls_url":"https://api.github.com/repos/ConsenSys/ethql/pulls{/number}","milestones_url":"https://api.github.com/repos/ConsenSys/ethql/milestones{/number}","notifications_url":"https://api.github.com/repos/ConsenSys/ethql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConsenSys/ethql/labels{/name}","releases_url":"https://api.github.com/repos/ConsenSys/ethql/releases{/id}","deployments_url":"https://api.github.com/repos/ConsenSys/ethql/deployments","created_at":"2018-02-17T00:34:40Z","updated_at":"2018-06-20T11:06:03Z","pushed_at":"2018-06-19T22:55:50Z","git_url":"git://github.com/ConsenSys/ethql.git","ssh_url":"git@github.com:ConsenSys/ethql.git","clone_url":"https://github.com/ConsenSys/ethql.git","svn_url":"https://github.com/ConsenSys/ethql","homepage":"","size":225,"stargazers_count":70,"watchers_count":70,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":1,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/23"},"html":{"href":"https://github.com/ConsenSys/ethql/pull/23"},"issue":{"href":"https://api.github.com/repos/ConsenSys/ethql/issues/23"},"comments":{"href":"https://api.github.com/repos/ConsenSys/ethql/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/ConsenSys/ethql/statuses/9b3cd0824e78912cac825a36016c7b5bd160d907"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"akhila-raju"}}