{"action":"created","comment":{"url":"https://api.github.com/repos/toggl/mobileapp/pulls/comments/205749002","pull_request_review_id":141082289,"id":205749002,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTc0OTAwMg==","diff_hunk":"@@ -0,0 +1,107 @@\n+using System;\n+using System.Reactive.Disposables;\n+using System.Reactive.Linq;\n+using System.Reactive.Subjects;\n+\n+namespace Toggl.Multivac.Extensions\n+{\n+    public class RxActionNotEnabledException : Exception","path":"Toggl.Multivac/Extensions/RxAction.cs","position":8,"original_position":8,"commit_id":"cb618e40bc0c930e28872bf3651ee4cb8437bc6e","original_commit_id":"cb618e40bc0c930e28872bf3651ee4cb8437bc6e","user":{"login":"Odrakir","id":724743,"node_id":"MDQ6VXNlcjcyNDc0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/724743?v=4","gravatar_id":"","url":"https://api.github.com/users/Odrakir","html_url":"https://github.com/Odrakir","followers_url":"https://api.github.com/users/Odrakir/followers","following_url":"https://api.github.com/users/Odrakir/following{/other_user}","gists_url":"https://api.github.com/users/Odrakir/gists{/gist_id}","starred_url":"https://api.github.com/users/Odrakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Odrakir/subscriptions","organizations_url":"https://api.github.com/users/Odrakir/orgs","repos_url":"https://api.github.com/users/Odrakir/repos","events_url":"https://api.github.com/users/Odrakir/events{/privacy}","received_events_url":"https://api.github.com/users/Odrakir/received_events","type":"User","site_admin":false},"body":"I'm a very open guy.","created_at":"2018-07-27T11:51:58Z","updated_at":"2018-07-27T11:51:58Z","html_url":"https://github.com/toggl/mobileapp/pull/2751#discussion_r205749002","pull_request_url":"https://api.github.com/repos/toggl/mobileapp/pulls/2751","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/comments/205749002"},"html":{"href":"https://github.com/toggl/mobileapp/pull/2751#discussion_r205749002"},"pull_request":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/2751"}},"in_reply_to_id":205743904},"pull_request":{"url":"https://api.github.com/repos/toggl/mobileapp/pulls/2751","id":204398455,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Mzk4NDU1","html_url":"https://github.com/toggl/mobileapp/pull/2751","diff_url":"https://github.com/toggl/mobileapp/pull/2751.diff","patch_url":"https://github.com/toggl/mobileapp/pull/2751.patch","issue_url":"https://api.github.com/repos/toggl/mobileapp/issues/2751","number":2751,"state":"open","locked":false,"title":"Rx action","user":{"login":"Odrakir","id":724743,"node_id":"MDQ6VXNlcjcyNDc0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/724743?v=4","gravatar_id":"","url":"https://api.github.com/users/Odrakir","html_url":"https://github.com/Odrakir","followers_url":"https://api.github.com/users/Odrakir/followers","following_url":"https://api.github.com/users/Odrakir/following{/other_user}","gists_url":"https://api.github.com/users/Odrakir/gists{/gist_id}","starred_url":"https://api.github.com/users/Odrakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Odrakir/subscriptions","organizations_url":"https://api.github.com/users/Odrakir/orgs","repos_url":"https://api.github.com/users/Odrakir/repos","events_url":"https://api.github.com/users/Odrakir/events{/privacy}","received_events_url":"https://api.github.com/users/Odrakir/received_events","type":"User","site_admin":false},"body":"## What's this?\r\nThis is sort of the replacement for `MvxAsyncCommand`, only simpler, better, nicer and taller.\r\n\r\nIt's based on: https://github.com/RxSwiftCommunity/Action\r\n\r\n## Why do we want this?\r\nThis enables an easy way to bind the UI to methods on the view mode, and more specifically methods that execute interactors (or anything that returns an Observable)\r\n\r\nWe would expose this from the view model\r\n```c#\r\npublic RxAction<TimeEntryViewModel, bool> ContinueTimeEntryAction { get; }\r\n...\r\nContinueTimeEntryAction = new RxAction<TimeEntryViewModel, bool>( timeEntryViewModel => \r\n      interactorFactory\r\n           .ContinueTimeEntry(timeEntryViewModel)\r\n           .Execute()\r\n           .Do(/*whatever*/);\r\n);\r\n```\r\nAnd then from the ViewController we can just do:\r\n```c#\r\ncontinueButton.BindToAction(ViewModel. ContinueTimeEntryAction, timeEntryViewModel);\r\n```\r\n\r\nAnd that would disable the button while executing and take care of possible errors. \r\n\r\nWe could listen to the errors in the VM too.\r\n```c#\r\nContinueTimeEntryAction.Errors.Subscribe(/*...*/)\r\n```\r\nOr the result(s), though that is returned from `Execute` as well.\r\n```c#\r\nContinueTimeEntryAction.Elements.Subscribe(/*...*/)\r\n```\r\n\r\n## What's missing\r\n\r\nI want to add some overrides to make paramterless actions easier to declare. Also, the extensions on Daneel have no tests.\r\n\r\n## :squid: Permissions\r\nNot ready to be squashed","created_at":"2018-07-27T10:55:38Z","updated_at":"2018-07-27T11:51:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"caafa95aa0baa7aafb78947fce72a876a16f1275","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/toggl/mobileapp/pulls/2751/commits","review_comments_url":"https://api.github.com/repos/toggl/mobileapp/pulls/2751/comments","review_comment_url":"https://api.github.com/repos/toggl/mobileapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toggl/mobileapp/issues/2751/comments","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/cb618e40bc0c930e28872bf3651ee4cb8437bc6e","head":{"label":"toggl:rx-action","ref":"rx-action","sha":"cb618e40bc0c930e28872bf3651ee4cb8437bc6e","user":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"repo":{"id":87079363,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3OTM2Mw==","name":"mobileapp","full_name":"toggl/mobileapp","owner":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toggl/mobileapp","description":"Toggl's mobile apps","fork":false,"url":"https://api.github.com/repos/toggl/mobileapp","forks_url":"https://api.github.com/repos/toggl/mobileapp/forks","keys_url":"https://api.github.com/repos/toggl/mobileapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toggl/mobileapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toggl/mobileapp/teams","hooks_url":"https://api.github.com/repos/toggl/mobileapp/hooks","issue_events_url":"https://api.github.com/repos/toggl/mobileapp/issues/events{/number}","events_url":"https://api.github.com/repos/toggl/mobileapp/events","assignees_url":"https://api.github.com/repos/toggl/mobileapp/assignees{/user}","branches_url":"https://api.github.com/repos/toggl/mobileapp/branches{/branch}","tags_url":"https://api.github.com/repos/toggl/mobileapp/tags","blobs_url":"https://api.github.com/repos/toggl/mobileapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toggl/mobileapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toggl/mobileapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/toggl/mobileapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/{sha}","languages_url":"https://api.github.com/repos/toggl/mobileapp/languages","stargazers_url":"https://api.github.com/repos/toggl/mobileapp/stargazers","contributors_url":"https://api.github.com/repos/toggl/mobileapp/contributors","subscribers_url":"https://api.github.com/repos/toggl/mobileapp/subscribers","subscription_url":"https://api.github.com/repos/toggl/mobileapp/subscription","commits_url":"https://api.github.com/repos/toggl/mobileapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/toggl/mobileapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/toggl/mobileapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/toggl/mobileapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/toggl/mobileapp/contents/{+path}","compare_url":"https://api.github.com/repos/toggl/mobileapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toggl/mobileapp/merges","archive_url":"https://api.github.com/repos/toggl/mobileapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toggl/mobileapp/downloads","issues_url":"https://api.github.com/repos/toggl/mobileapp/issues{/number}","pulls_url":"https://api.github.com/repos/toggl/mobileapp/pulls{/number}","milestones_url":"https://api.github.com/repos/toggl/mobileapp/milestones{/number}","notifications_url":"https://api.github.com/repos/toggl/mobileapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toggl/mobileapp/labels{/name}","releases_url":"https://api.github.com/repos/toggl/mobileapp/releases{/id}","deployments_url":"https://api.github.com/repos/toggl/mobileapp/deployments","created_at":"2017-04-03T13:48:06Z","updated_at":"2018-07-26T16:50:26Z","pushed_at":"2018-07-27T11:44:18Z","git_url":"git://github.com/toggl/mobileapp.git","ssh_url":"git@github.com:toggl/mobileapp.git","clone_url":"https://github.com/toggl/mobileapp.git","svn_url":"https://github.com/toggl/mobileapp","homepage":"","size":23767,"stargazers_count":80,"watchers_count":80,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":160,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":160,"watchers":80,"default_branch":"develop"}},"base":{"label":"toggl:develop","ref":"develop","sha":"fdc93e401c86930fed92cef398be8b1d98b19372","user":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"repo":{"id":87079363,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3OTM2Mw==","name":"mobileapp","full_name":"toggl/mobileapp","owner":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toggl/mobileapp","description":"Toggl's mobile apps","fork":false,"url":"https://api.github.com/repos/toggl/mobileapp","forks_url":"https://api.github.com/repos/toggl/mobileapp/forks","keys_url":"https://api.github.com/repos/toggl/mobileapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toggl/mobileapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toggl/mobileapp/teams","hooks_url":"https://api.github.com/repos/toggl/mobileapp/hooks","issue_events_url":"https://api.github.com/repos/toggl/mobileapp/issues/events{/number}","events_url":"https://api.github.com/repos/toggl/mobileapp/events","assignees_url":"https://api.github.com/repos/toggl/mobileapp/assignees{/user}","branches_url":"https://api.github.com/repos/toggl/mobileapp/branches{/branch}","tags_url":"https://api.github.com/repos/toggl/mobileapp/tags","blobs_url":"https://api.github.com/repos/toggl/mobileapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toggl/mobileapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toggl/mobileapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/toggl/mobileapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/{sha}","languages_url":"https://api.github.com/repos/toggl/mobileapp/languages","stargazers_url":"https://api.github.com/repos/toggl/mobileapp/stargazers","contributors_url":"https://api.github.com/repos/toggl/mobileapp/contributors","subscribers_url":"https://api.github.com/repos/toggl/mobileapp/subscribers","subscription_url":"https://api.github.com/repos/toggl/mobileapp/subscription","commits_url":"https://api.github.com/repos/toggl/mobileapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/toggl/mobileapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/toggl/mobileapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/toggl/mobileapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/toggl/mobileapp/contents/{+path}","compare_url":"https://api.github.com/repos/toggl/mobileapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toggl/mobileapp/merges","archive_url":"https://api.github.com/repos/toggl/mobileapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toggl/mobileapp/downloads","issues_url":"https://api.github.com/repos/toggl/mobileapp/issues{/number}","pulls_url":"https://api.github.com/repos/toggl/mobileapp/pulls{/number}","milestones_url":"https://api.github.com/repos/toggl/mobileapp/milestones{/number}","notifications_url":"https://api.github.com/repos/toggl/mobileapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toggl/mobileapp/labels{/name}","releases_url":"https://api.github.com/repos/toggl/mobileapp/releases{/id}","deployments_url":"https://api.github.com/repos/toggl/mobileapp/deployments","created_at":"2017-04-03T13:48:06Z","updated_at":"2018-07-26T16:50:26Z","pushed_at":"2018-07-27T11:44:18Z","git_url":"git://github.com/toggl/mobileapp.git","ssh_url":"git@github.com:toggl/mobileapp.git","clone_url":"https://github.com/toggl/mobileapp.git","svn_url":"https://github.com/toggl/mobileapp","homepage":"","size":23767,"stargazers_count":80,"watchers_count":80,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":160,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":160,"watchers":80,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/2751"},"html":{"href":"https://github.com/toggl/mobileapp/pull/2751"},"issue":{"href":"https://api.github.com/repos/toggl/mobileapp/issues/2751"},"comments":{"href":"https://api.github.com/repos/toggl/mobileapp/issues/2751/comments"},"review_comments":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/2751/comments"},"review_comment":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/2751/commits"},"statuses":{"href":"https://api.github.com/repos/toggl/mobileapp/statuses/cb618e40bc0c930e28872bf3651ee4cb8437bc6e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Odrakir"}}