{"action":"created","comment":{"url":"https://api.github.com/repos/diffplug/spotless/pulls/comments/170176577","pull_request_review_id":98823071,"id":170176577,"diff_hunk":"@@ -0,0 +1,18 @@\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+         xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n+    <modelVersion>4.0.0</modelVersion>\n+\n+    <parent>\n+        <groupId>com.diffplug.spotless</groupId>\n+        <artifactId>spotless-maven-plugin-tests-parent</artifactId>\n+        <version>1.0.0-SNAPSHOT</version>\n+        <relativePath>..</relativePath>","path":"plugin-maven/src/test/resources/multi-module/pom-config.xml.mustache","position":9,"original_position":9,"commit_id":"60099efa24fc5e0a66a311fc11b5597d9e4c454b","original_commit_id":"60099efa24fc5e0a66a311fc11b5597d9e4c454b","user":{"login":"matthiasbalke","id":91990,"avatar_url":"https://avatars0.githubusercontent.com/u/91990?v=4","gravatar_id":"","url":"https://api.github.com/users/matthiasbalke","html_url":"https://github.com/matthiasbalke","followers_url":"https://api.github.com/users/matthiasbalke/followers","following_url":"https://api.github.com/users/matthiasbalke/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbalke/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbalke/subscriptions","organizations_url":"https://api.github.com/users/matthiasbalke/orgs","repos_url":"https://api.github.com/users/matthiasbalke/repos","events_url":"https://api.github.com/users/matthiasbalke/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbalke/received_events","type":"User","site_admin":false},"body":"This is the default anyway. No need to specify it.","created_at":"2018-02-23T06:41:46Z","updated_at":"2018-02-23T06:41:46Z","html_url":"https://github.com/diffplug/spotless/pull/210#discussion_r170176577","pull_request_url":"https://api.github.com/repos/diffplug/spotless/pulls/210","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/comments/170176577"},"html":{"href":"https://github.com/diffplug/spotless/pull/210#discussion_r170176577"},"pull_request":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/diffplug/spotless/pulls/210","id":170889781,"html_url":"https://github.com/diffplug/spotless/pull/210","diff_url":"https://github.com/diffplug/spotless/pull/210.diff","patch_url":"https://github.com/diffplug/spotless/pull/210.patch","issue_url":"https://api.github.com/repos/diffplug/spotless/issues/210","number":210,"state":"open","locked":false,"title":"Improved support for multi-module maven projects","user":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars2.githubusercontent.com/u/1638145?v=4","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"body":"Some steps in the maven plugin require paths to configuration files. For example eclipse formatter and scalafmt. In multi-module maven projects it is desirable to specify paths only once and not duplicate configs in multiple modules. Each sub-project should not assume anything about the general project structure and should not refer to files in parent modules using relative paths. It is recommended to create a separate module with configuration files and depend on it in the plugin. This approach is taken by the Checkstyle and PMD plugins:\r\n\r\nhttp://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html\r\nhttps://maven.apache.org/plugins/maven-pmd-plugin/examples/multi-module-config.html\r\n\r\nSuch approach means configuration files no longer live within the project and might be inside a JAR. Thus specified value of `<file>` require special resolution.\r\n\r\nBoth Checkstyle and PMD use builtin plexus `ResourceManager` which is able to locate files from regular file system, URL or JAR. Located file is then copied to the output directory (usually `./target/`) and used as a regular file.\r\n\r\nThis commit makes spotless plugin also use `ResourceManager` in order to support multi-module configuration with config files in a dedicated module. Every step that contains `<file>` is updated to perform the resolution. It is also possible to specify configuration file URLs, though this feature is not tested.","created_at":"2018-02-22T22:57:03Z","updated_at":"2018-02-23T06:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55514518cfa218452f5570873c23e953584b5850","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nedtwigg","id":2924992,"avatar_url":"https://avatars3.githubusercontent.com/u/2924992?v=4","gravatar_id":"","url":"https://api.github.com/users/nedtwigg","html_url":"https://github.com/nedtwigg","followers_url":"https://api.github.com/users/nedtwigg/followers","following_url":"https://api.github.com/users/nedtwigg/following{/other_user}","gists_url":"https://api.github.com/users/nedtwigg/gists{/gist_id}","starred_url":"https://api.github.com/users/nedtwigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nedtwigg/subscriptions","organizations_url":"https://api.github.com/users/nedtwigg/orgs","repos_url":"https://api.github.com/users/nedtwigg/repos","events_url":"https://api.github.com/users/nedtwigg/events{/privacy}","received_events_url":"https://api.github.com/users/nedtwigg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/diffplug/spotless/pulls/210/commits","review_comments_url":"https://api.github.com/repos/diffplug/spotless/pulls/210/comments","review_comment_url":"https://api.github.com/repos/diffplug/spotless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffplug/spotless/issues/210/comments","statuses_url":"https://api.github.com/repos/diffplug/spotless/statuses/60099efa24fc5e0a66a311fc11b5597d9e4c454b","head":{"label":"lutovich:maven-multi-module","ref":"maven-multi-module","sha":"60099efa24fc5e0a66a311fc11b5597d9e4c454b","user":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars2.githubusercontent.com/u/1638145?v=4","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"repo":{"id":117473548,"name":"spotless","full_name":"lutovich/spotless","owner":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars2.githubusercontent.com/u/1638145?v=4","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lutovich/spotless","description":"Keep your code spotless","fork":true,"url":"https://api.github.com/repos/lutovich/spotless","forks_url":"https://api.github.com/repos/lutovich/spotless/forks","keys_url":"https://api.github.com/repos/lutovich/spotless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lutovich/spotless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lutovich/spotless/teams","hooks_url":"https://api.github.com/repos/lutovich/spotless/hooks","issue_events_url":"https://api.github.com/repos/lutovich/spotless/issues/events{/number}","events_url":"https://api.github.com/repos/lutovich/spotless/events","assignees_url":"https://api.github.com/repos/lutovich/spotless/assignees{/user}","branches_url":"https://api.github.com/repos/lutovich/spotless/branches{/branch}","tags_url":"https://api.github.com/repos/lutovich/spotless/tags","blobs_url":"https://api.github.com/repos/lutovich/spotless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lutovich/spotless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lutovich/spotless/git/refs{/sha}","trees_url":"https://api.github.com/repos/lutovich/spotless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lutovich/spotless/statuses/{sha}","languages_url":"https://api.github.com/repos/lutovich/spotless/languages","stargazers_url":"https://api.github.com/repos/lutovich/spotless/stargazers","contributors_url":"https://api.github.com/repos/lutovich/spotless/contributors","subscribers_url":"https://api.github.com/repos/lutovich/spotless/subscribers","subscription_url":"https://api.github.com/repos/lutovich/spotless/subscription","commits_url":"https://api.github.com/repos/lutovich/spotless/commits{/sha}","git_commits_url":"https://api.github.com/repos/lutovich/spotless/git/commits{/sha}","comments_url":"https://api.github.com/repos/lutovich/spotless/comments{/number}","issue_comment_url":"https://api.github.com/repos/lutovich/spotless/issues/comments{/number}","contents_url":"https://api.github.com/repos/lutovich/spotless/contents/{+path}","compare_url":"https://api.github.com/repos/lutovich/spotless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lutovich/spotless/merges","archive_url":"https://api.github.com/repos/lutovich/spotless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lutovich/spotless/downloads","issues_url":"https://api.github.com/repos/lutovich/spotless/issues{/number}","pulls_url":"https://api.github.com/repos/lutovich/spotless/pulls{/number}","milestones_url":"https://api.github.com/repos/lutovich/spotless/milestones{/number}","notifications_url":"https://api.github.com/repos/lutovich/spotless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lutovich/spotless/labels{/name}","releases_url":"https://api.github.com/repos/lutovich/spotless/releases{/id}","deployments_url":"https://api.github.com/repos/lutovich/spotless/deployments","created_at":"2018-01-14T22:49:24Z","updated_at":"2018-01-14T22:49:26Z","pushed_at":"2018-02-22T22:58:24Z","git_url":"git://github.com/lutovich/spotless.git","ssh_url":"git@github.com:lutovich/spotless.git","clone_url":"https://github.com/lutovich/spotless.git","svn_url":"https://github.com/lutovich/spotless","homepage":"","size":8849,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diffplug:master","ref":"master","sha":"4d28488b9848974c20f0723905bdc2d44fb2c627","user":{"login":"diffplug","id":6572898,"avatar_url":"https://avatars2.githubusercontent.com/u/6572898?v=4","gravatar_id":"","url":"https://api.github.com/users/diffplug","html_url":"https://github.com/diffplug","followers_url":"https://api.github.com/users/diffplug/followers","following_url":"https://api.github.com/users/diffplug/following{/other_user}","gists_url":"https://api.github.com/users/diffplug/gists{/gist_id}","starred_url":"https://api.github.com/users/diffplug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffplug/subscriptions","organizations_url":"https://api.github.com/users/diffplug/orgs","repos_url":"https://api.github.com/users/diffplug/repos","events_url":"https://api.github.com/users/diffplug/events{/privacy}","received_events_url":"https://api.github.com/users/diffplug/received_events","type":"Organization","site_admin":false},"repo":{"id":34685800,"name":"spotless","full_name":"diffplug/spotless","owner":{"login":"diffplug","id":6572898,"avatar_url":"https://avatars2.githubusercontent.com/u/6572898?v=4","gravatar_id":"","url":"https://api.github.com/users/diffplug","html_url":"https://github.com/diffplug","followers_url":"https://api.github.com/users/diffplug/followers","following_url":"https://api.github.com/users/diffplug/following{/other_user}","gists_url":"https://api.github.com/users/diffplug/gists{/gist_id}","starred_url":"https://api.github.com/users/diffplug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffplug/subscriptions","organizations_url":"https://api.github.com/users/diffplug/orgs","repos_url":"https://api.github.com/users/diffplug/repos","events_url":"https://api.github.com/users/diffplug/events{/privacy}","received_events_url":"https://api.github.com/users/diffplug/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffplug/spotless","description":"Keep your code spotless","fork":false,"url":"https://api.github.com/repos/diffplug/spotless","forks_url":"https://api.github.com/repos/diffplug/spotless/forks","keys_url":"https://api.github.com/repos/diffplug/spotless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffplug/spotless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffplug/spotless/teams","hooks_url":"https://api.github.com/repos/diffplug/spotless/hooks","issue_events_url":"https://api.github.com/repos/diffplug/spotless/issues/events{/number}","events_url":"https://api.github.com/repos/diffplug/spotless/events","assignees_url":"https://api.github.com/repos/diffplug/spotless/assignees{/user}","branches_url":"https://api.github.com/repos/diffplug/spotless/branches{/branch}","tags_url":"https://api.github.com/repos/diffplug/spotless/tags","blobs_url":"https://api.github.com/repos/diffplug/spotless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffplug/spotless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffplug/spotless/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffplug/spotless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffplug/spotless/statuses/{sha}","languages_url":"https://api.github.com/repos/diffplug/spotless/languages","stargazers_url":"https://api.github.com/repos/diffplug/spotless/stargazers","contributors_url":"https://api.github.com/repos/diffplug/spotless/contributors","subscribers_url":"https://api.github.com/repos/diffplug/spotless/subscribers","subscription_url":"https://api.github.com/repos/diffplug/spotless/subscription","commits_url":"https://api.github.com/repos/diffplug/spotless/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffplug/spotless/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffplug/spotless/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffplug/spotless/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffplug/spotless/contents/{+path}","compare_url":"https://api.github.com/repos/diffplug/spotless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffplug/spotless/merges","archive_url":"https://api.github.com/repos/diffplug/spotless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffplug/spotless/downloads","issues_url":"https://api.github.com/repos/diffplug/spotless/issues{/number}","pulls_url":"https://api.github.com/repos/diffplug/spotless/pulls{/number}","milestones_url":"https://api.github.com/repos/diffplug/spotless/milestones{/number}","notifications_url":"https://api.github.com/repos/diffplug/spotless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffplug/spotless/labels{/name}","releases_url":"https://api.github.com/repos/diffplug/spotless/releases{/id}","deployments_url":"https://api.github.com/repos/diffplug/spotless/deployments","created_at":"2015-04-27T19:10:58Z","updated_at":"2018-02-21T09:58:56Z","pushed_at":"2018-02-23T06:35:44Z","git_url":"git://github.com/diffplug/spotless.git","ssh_url":"git@github.com:diffplug/spotless.git","clone_url":"https://github.com/diffplug/spotless.git","svn_url":"https://github.com/diffplug/spotless","homepage":"","size":11600,"stargazers_count":265,"watchers_count":265,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":44,"open_issues":27,"watchers":265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/210"},"html":{"href":"https://github.com/diffplug/spotless/pull/210"},"issue":{"href":"https://api.github.com/repos/diffplug/spotless/issues/210"},"comments":{"href":"https://api.github.com/repos/diffplug/spotless/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/diffplug/spotless/statuses/60099efa24fc5e0a66a311fc11b5597d9e4c454b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"matthiasbalke"}}