{"action":"created","comment":{"url":"https://api.github.com/repos/poanetwork/hbbft/pulls/comments/203449177","pull_request_review_id":138340694,"id":203449177,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQ0OTE3Nw==","diff_hunk":"@@ -10,7 +10,89 @@\n //! signatures and encryption. The secret master key is not known by anyone. The protocol succeeds\n //! if up to `threshold` nodes are faulty.\n //!\n-//! # How it works\n+//! ## Usage example\n+//!\n+//! ```","path":"src/sync_key_gen.rs","position":7,"original_position":7,"commit_id":"52a684eb7f40322dbdc4d314325a33b102b387dd","original_commit_id":"52a684eb7f40322dbdc4d314325a33b102b387dd","user":{"login":"c0gent","id":2916797,"node_id":"MDQ6VXNlcjI5MTY3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2916797?v=4","gravatar_id":"","url":"https://api.github.com/users/c0gent","html_url":"https://github.com/c0gent","followers_url":"https://api.github.com/users/c0gent/followers","following_url":"https://api.github.com/users/c0gent/following{/other_user}","gists_url":"https://api.github.com/users/c0gent/gists{/gist_id}","starred_url":"https://api.github.com/users/c0gent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0gent/subscriptions","organizations_url":"https://api.github.com/users/c0gent/orgs","repos_url":"https://api.github.com/users/c0gent/repos","events_url":"https://api.github.com/users/c0gent/events{/privacy}","received_events_url":"https://api.github.com/users/c0gent/received_events","type":"User","site_admin":false},"body":"Doc code should be prefixed with ` ```rust,ignore ` or ` ` ```rust,no_run ` (to compile only). Ideally though it's better to let it run it that way it stays up to date.","created_at":"2018-07-18T16:38:49Z","updated_at":"2018-07-18T16:51:24Z","html_url":"https://github.com/poanetwork/hbbft/pull/146#discussion_r203449177","pull_request_url":"https://api.github.com/repos/poanetwork/hbbft/pulls/146","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/comments/203449177"},"html":{"href":"https://github.com/poanetwork/hbbft/pull/146#discussion_r203449177"},"pull_request":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/poanetwork/hbbft/pulls/146","id":202206842,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjA2ODQy","html_url":"https://github.com/poanetwork/hbbft/pull/146","diff_url":"https://github.com/poanetwork/hbbft/pull/146.diff","patch_url":"https://github.com/poanetwork/hbbft/pull/146.patch","issue_url":"https://api.github.com/repos/poanetwork/hbbft/issues/146","number":146,"state":"open","locked":false,"title":"Separate keys and key shares.","user":{"login":"afck","id":7894725,"node_id":"MDQ6VXNlcjc4OTQ3MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/7894725?v=4","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"body":"This adds another map of public keys to `NetworkInfo`: It is unsafe to use key _shares_ as keys.\r\n\r\nSince creating a new `NetworkInfo` is even more complicated now, `NetworkInfo::generate_map` creates a set of matching instances for testing.\r\n\r\n(I also noticed that Clippy wasn't applied to the example, so I added it and fixed the lints.)\r\n\r\nCloses #131 ","created_at":"2018-07-18T10:26:54Z","updated_at":"2018-07-18T16:51:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e43f894ee40ca494b664b3059e05a25b2697855","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vkomenda","id":5529505,"node_id":"MDQ6VXNlcjU1Mjk1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5529505?v=4","gravatar_id":"","url":"https://api.github.com/users/vkomenda","html_url":"https://github.com/vkomenda","followers_url":"https://api.github.com/users/vkomenda/followers","following_url":"https://api.github.com/users/vkomenda/following{/other_user}","gists_url":"https://api.github.com/users/vkomenda/gists{/gist_id}","starred_url":"https://api.github.com/users/vkomenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkomenda/subscriptions","organizations_url":"https://api.github.com/users/vkomenda/orgs","repos_url":"https://api.github.com/users/vkomenda/repos","events_url":"https://api.github.com/users/vkomenda/events{/privacy}","received_events_url":"https://api.github.com/users/vkomenda/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/poanetwork/hbbft/pulls/146/commits","review_comments_url":"https://api.github.com/repos/poanetwork/hbbft/pulls/146/comments","review_comment_url":"https://api.github.com/repos/poanetwork/hbbft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poanetwork/hbbft/issues/146/comments","statuses_url":"https://api.github.com/repos/poanetwork/hbbft/statuses/52a684eb7f40322dbdc4d314325a33b102b387dd","head":{"label":"poanetwork:afck-key-shares","ref":"afck-key-shares","sha":"52a684eb7f40322dbdc4d314325a33b102b387dd","user":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":125307734,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzMDc3MzQ=","name":"hbbft","full_name":"poanetwork/hbbft","owner":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poanetwork/hbbft","description":" An implementation of the paper \"Honey Badger of BFT Protocols\" in Rust. This is a modular library of consensus.","fork":false,"url":"https://api.github.com/repos/poanetwork/hbbft","forks_url":"https://api.github.com/repos/poanetwork/hbbft/forks","keys_url":"https://api.github.com/repos/poanetwork/hbbft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poanetwork/hbbft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poanetwork/hbbft/teams","hooks_url":"https://api.github.com/repos/poanetwork/hbbft/hooks","issue_events_url":"https://api.github.com/repos/poanetwork/hbbft/issues/events{/number}","events_url":"https://api.github.com/repos/poanetwork/hbbft/events","assignees_url":"https://api.github.com/repos/poanetwork/hbbft/assignees{/user}","branches_url":"https://api.github.com/repos/poanetwork/hbbft/branches{/branch}","tags_url":"https://api.github.com/repos/poanetwork/hbbft/tags","blobs_url":"https://api.github.com/repos/poanetwork/hbbft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poanetwork/hbbft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poanetwork/hbbft/git/refs{/sha}","trees_url":"https://api.github.com/repos/poanetwork/hbbft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poanetwork/hbbft/statuses/{sha}","languages_url":"https://api.github.com/repos/poanetwork/hbbft/languages","stargazers_url":"https://api.github.com/repos/poanetwork/hbbft/stargazers","contributors_url":"https://api.github.com/repos/poanetwork/hbbft/contributors","subscribers_url":"https://api.github.com/repos/poanetwork/hbbft/subscribers","subscription_url":"https://api.github.com/repos/poanetwork/hbbft/subscription","commits_url":"https://api.github.com/repos/poanetwork/hbbft/commits{/sha}","git_commits_url":"https://api.github.com/repos/poanetwork/hbbft/git/commits{/sha}","comments_url":"https://api.github.com/repos/poanetwork/hbbft/comments{/number}","issue_comment_url":"https://api.github.com/repos/poanetwork/hbbft/issues/comments{/number}","contents_url":"https://api.github.com/repos/poanetwork/hbbft/contents/{+path}","compare_url":"https://api.github.com/repos/poanetwork/hbbft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poanetwork/hbbft/merges","archive_url":"https://api.github.com/repos/poanetwork/hbbft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poanetwork/hbbft/downloads","issues_url":"https://api.github.com/repos/poanetwork/hbbft/issues{/number}","pulls_url":"https://api.github.com/repos/poanetwork/hbbft/pulls{/number}","milestones_url":"https://api.github.com/repos/poanetwork/hbbft/milestones{/number}","notifications_url":"https://api.github.com/repos/poanetwork/hbbft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poanetwork/hbbft/labels{/name}","releases_url":"https://api.github.com/repos/poanetwork/hbbft/releases{/id}","deployments_url":"https://api.github.com/repos/poanetwork/hbbft/deployments","created_at":"2018-03-15T03:32:34Z","updated_at":"2018-07-18T16:28:08Z","pushed_at":"2018-07-18T16:28:06Z","git_url":"git://github.com/poanetwork/hbbft.git","ssh_url":"git@github.com:poanetwork/hbbft.git","clone_url":"https://github.com/poanetwork/hbbft.git","svn_url":"https://github.com/poanetwork/hbbft","homepage":"","size":1070,"stargazers_count":59,"watchers_count":59,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":10,"open_issues":27,"watchers":59,"default_branch":"master"}},"base":{"label":"poanetwork:master","ref":"master","sha":"2d9b872484f858f67637f8802bd0edafe242f195","user":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":125307734,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzMDc3MzQ=","name":"hbbft","full_name":"poanetwork/hbbft","owner":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poanetwork/hbbft","description":" An implementation of the paper \"Honey Badger of BFT Protocols\" in Rust. This is a modular library of consensus.","fork":false,"url":"https://api.github.com/repos/poanetwork/hbbft","forks_url":"https://api.github.com/repos/poanetwork/hbbft/forks","keys_url":"https://api.github.com/repos/poanetwork/hbbft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poanetwork/hbbft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poanetwork/hbbft/teams","hooks_url":"https://api.github.com/repos/poanetwork/hbbft/hooks","issue_events_url":"https://api.github.com/repos/poanetwork/hbbft/issues/events{/number}","events_url":"https://api.github.com/repos/poanetwork/hbbft/events","assignees_url":"https://api.github.com/repos/poanetwork/hbbft/assignees{/user}","branches_url":"https://api.github.com/repos/poanetwork/hbbft/branches{/branch}","tags_url":"https://api.github.com/repos/poanetwork/hbbft/tags","blobs_url":"https://api.github.com/repos/poanetwork/hbbft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poanetwork/hbbft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poanetwork/hbbft/git/refs{/sha}","trees_url":"https://api.github.com/repos/poanetwork/hbbft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poanetwork/hbbft/statuses/{sha}","languages_url":"https://api.github.com/repos/poanetwork/hbbft/languages","stargazers_url":"https://api.github.com/repos/poanetwork/hbbft/stargazers","contributors_url":"https://api.github.com/repos/poanetwork/hbbft/contributors","subscribers_url":"https://api.github.com/repos/poanetwork/hbbft/subscribers","subscription_url":"https://api.github.com/repos/poanetwork/hbbft/subscription","commits_url":"https://api.github.com/repos/poanetwork/hbbft/commits{/sha}","git_commits_url":"https://api.github.com/repos/poanetwork/hbbft/git/commits{/sha}","comments_url":"https://api.github.com/repos/poanetwork/hbbft/comments{/number}","issue_comment_url":"https://api.github.com/repos/poanetwork/hbbft/issues/comments{/number}","contents_url":"https://api.github.com/repos/poanetwork/hbbft/contents/{+path}","compare_url":"https://api.github.com/repos/poanetwork/hbbft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poanetwork/hbbft/merges","archive_url":"https://api.github.com/repos/poanetwork/hbbft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poanetwork/hbbft/downloads","issues_url":"https://api.github.com/repos/poanetwork/hbbft/issues{/number}","pulls_url":"https://api.github.com/repos/poanetwork/hbbft/pulls{/number}","milestones_url":"https://api.github.com/repos/poanetwork/hbbft/milestones{/number}","notifications_url":"https://api.github.com/repos/poanetwork/hbbft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poanetwork/hbbft/labels{/name}","releases_url":"https://api.github.com/repos/poanetwork/hbbft/releases{/id}","deployments_url":"https://api.github.com/repos/poanetwork/hbbft/deployments","created_at":"2018-03-15T03:32:34Z","updated_at":"2018-07-18T16:28:08Z","pushed_at":"2018-07-18T16:28:06Z","git_url":"git://github.com/poanetwork/hbbft.git","ssh_url":"git@github.com:poanetwork/hbbft.git","clone_url":"https://github.com/poanetwork/hbbft.git","svn_url":"https://github.com/poanetwork/hbbft","homepage":"","size":1070,"stargazers_count":59,"watchers_count":59,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":10,"open_issues":27,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/146"},"html":{"href":"https://github.com/poanetwork/hbbft/pull/146"},"issue":{"href":"https://api.github.com/repos/poanetwork/hbbft/issues/146"},"comments":{"href":"https://api.github.com/repos/poanetwork/hbbft/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/poanetwork/hbbft/statuses/52a684eb7f40322dbdc4d314325a33b102b387dd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"c0gent"}}