{"action":"created","comment":{"url":"https://api.github.com/repos/Remitly/sso/pulls/comments/245155696","pull_request_review_id":189206824,"id":245155696,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTE1NTY5Ng==","diff_hunk":"@@ -0,0 +1,143 @@\n+package devproxy\n+\n+import (\n+\t// \"encoding/base64\"\n+\t// \"errors\"\n+\t\"fmt\"\n+\t\"io/ioutil\"\n+\n+\t// \"net/http\"\n+\t\"net/url\"\n+\t\"os\"\n+\t\"strings\"\n+\t\"time\"\n+\t// \"github.com/datadog/datadog-go/statsd\"\n+)\n+\n+// Options are configuration options that can be set by Environment Variables\n+// Port - int -  port to listen on for HTTP clients\n+// ProviderURLString - the URL for the provider in this environment: \"https://sso-auth.example.com\"\n+// UpstreamConfigsFile - the path to upstream configs file\n+// Cluster - the cluster in which this is running, used for upstream configs\n+// Scheme - the default scheme, used for upstream configs\n+// DefaultUpstreamTimeout - the default time period to wait for a response from an upstream\n+// TCPWriteTimeout - http server tcp write timeout\n+// TCPReadTimeout - http server tcp read timeout\n+// SessionLifetimeTTL - time to live for a session lifetime\n+// SessionValidTTL - time to live for a valid session\n+// GracePeriodTTL - time to reuse session data when provider unavailable\n+// RequestLoging - boolean whether or not to log requests\n+// StatsdHost - host addr for statsd client to listen on\n+// StatsdPort - port for statsdclient to listen on\n+type Options struct {\n+\tPort int `envconfig:\"PORT\" default:\"4180\"`\n+\n+\tUpstreamConfigsFile string `envconfig:\"UPSTREAM_CONFIGS\"`\n+\tCluster             string `envconfig:\"CLUSTER\"`\n+\tScheme              string `envconfig:\"SCHEME\" default:\"https\"`\n+\n+\tHost string `envconfig:\"HOST\"`\n+\n+\tDefaultUpstreamTimeout time.Duration `envconfig:\"DEFAULT_UPSTREAM_TIMEOUT\" default:\"10s\"`\n+\n+\tTCPWriteTimeout time.Duration `envconfig:\"TCP_WRITE_TIMEOUT\" default:\"30s\"`\n+\tTCPReadTimeout  time.Duration `envconfig:\"TCP_READ_TIMEOUT\" default:\"30s\"`\n+\n+\tRequestLogging bool `envconfig:\"REQUEST_LOGGING\" default:\"true\"`\n+\n+\t// StatsdHost string `envconfig:\"STATSD_HOST\"`\n+\t// StatsdPort int    `envconfig:\"STATSD_PORT\"`","path":"internal/devproxy/options.go","position":49,"original_position":49,"commit_id":"49a1808f7bb042d8287735ae673fd866ed53b582","original_commit_id":"49a1808f7bb042d8287735ae673fd866ed53b582","user":{"login":"sporkmonger","id":1778,"node_id":"MDQ6VXNlcjE3Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1778?v=4","gravatar_id":"","url":"https://api.github.com/users/sporkmonger","html_url":"https://github.com/sporkmonger","followers_url":"https://api.github.com/users/sporkmonger/followers","following_url":"https://api.github.com/users/sporkmonger/following{/other_user}","gists_url":"https://api.github.com/users/sporkmonger/gists{/gist_id}","starred_url":"https://api.github.com/users/sporkmonger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sporkmonger/subscriptions","organizations_url":"https://api.github.com/users/sporkmonger/orgs","repos_url":"https://api.github.com/users/sporkmonger/repos","events_url":"https://api.github.com/users/sporkmonger/events{/privacy}","received_events_url":"https://api.github.com/users/sporkmonger/received_events","type":"User","site_admin":false},"body":"Drop.","created_at":"2019-01-03T22:35:26Z","updated_at":"2019-01-03T22:38:05Z","html_url":"https://github.com/Remitly/sso/pull/1#discussion_r245155696","pull_request_url":"https://api.github.com/repos/Remitly/sso/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Remitly/sso/pulls/comments/245155696"},"html":{"href":"https://github.com/Remitly/sso/pull/1#discussion_r245155696"},"pull_request":{"href":"https://api.github.com/repos/Remitly/sso/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Remitly/sso/pulls/1","id":239275624,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5Mjc1NjI0","html_url":"https://github.com/Remitly/sso/pull/1","diff_url":"https://github.com/Remitly/sso/pull/1.diff","patch_url":"https://github.com/Remitly/sso/pull/1.patch","issue_url":"https://api.github.com/repos/Remitly/sso/issues/1","number":1,"state":"open","locked":false,"title":"Proxy shim for simplifying development environment workflow","user":{"login":"malizz","id":44799162,"node_id":"MDQ6VXNlcjQ0Nzk5MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/44799162?v=4","gravatar_id":"","url":"https://api.github.com/users/malizz","html_url":"https://github.com/malizz","followers_url":"https://api.github.com/users/malizz/followers","following_url":"https://api.github.com/users/malizz/following{/other_user}","gists_url":"https://api.github.com/users/malizz/gists{/gist_id}","starred_url":"https://api.github.com/users/malizz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malizz/subscriptions","organizations_url":"https://api.github.com/users/malizz/orgs","repos_url":"https://api.github.com/users/malizz/repos","events_url":"https://api.github.com/users/malizz/events{/privacy}","received_events_url":"https://api.github.com/users/malizz/received_events","type":"User","site_admin":false},"body":"## Problem\r\nA production deployment does not allow failing verification, test permissions (that may not necessarily exist for them in prod). \r\n\r\n## Solution\r\n\r\nSimplifying development environment workflow by replacing the production proxy with a shim that reads its settings from a config file. \r\n\r\n","created_at":"2018-12-17T20:35:58Z","updated_at":"2019-01-03T22:38:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ff2b8c0457488bc1af65cf99e61082d14f127ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Remitly/sso/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Remitly/sso/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Remitly/sso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Remitly/sso/issues/1/comments","statuses_url":"https://api.github.com/repos/Remitly/sso/statuses/49a1808f7bb042d8287735ae673fd866ed53b582","head":{"label":"Remitly:dev-proxy","ref":"dev-proxy","sha":"49a1808f7bb042d8287735ae673fd866ed53b582","user":{"login":"Remitly","id":2490045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTAwNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2490045?v=4","gravatar_id":"","url":"https://api.github.com/users/Remitly","html_url":"https://github.com/Remitly","followers_url":"https://api.github.com/users/Remitly/followers","following_url":"https://api.github.com/users/Remitly/following{/other_user}","gists_url":"https://api.github.com/users/Remitly/gists{/gist_id}","starred_url":"https://api.github.com/users/Remitly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remitly/subscriptions","organizations_url":"https://api.github.com/users/Remitly/orgs","repos_url":"https://api.github.com/users/Remitly/repos","events_url":"https://api.github.com/users/Remitly/events{/privacy}","received_events_url":"https://api.github.com/users/Remitly/received_events","type":"Organization","site_admin":false},"repo":{"id":147749826,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3NDk4MjY=","name":"sso","full_name":"Remitly/sso","private":false,"owner":{"login":"Remitly","id":2490045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTAwNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2490045?v=4","gravatar_id":"","url":"https://api.github.com/users/Remitly","html_url":"https://github.com/Remitly","followers_url":"https://api.github.com/users/Remitly/followers","following_url":"https://api.github.com/users/Remitly/following{/other_user}","gists_url":"https://api.github.com/users/Remitly/gists{/gist_id}","starred_url":"https://api.github.com/users/Remitly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remitly/subscriptions","organizations_url":"https://api.github.com/users/Remitly/orgs","repos_url":"https://api.github.com/users/Remitly/repos","events_url":"https://api.github.com/users/Remitly/events{/privacy}","received_events_url":"https://api.github.com/users/Remitly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Remitly/sso","description":"sso, aka S.S.Octopus, aka octoboi, is a single sign-on solution for securing internal services","fork":true,"url":"https://api.github.com/repos/Remitly/sso","forks_url":"https://api.github.com/repos/Remitly/sso/forks","keys_url":"https://api.github.com/repos/Remitly/sso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Remitly/sso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Remitly/sso/teams","hooks_url":"https://api.github.com/repos/Remitly/sso/hooks","issue_events_url":"https://api.github.com/repos/Remitly/sso/issues/events{/number}","events_url":"https://api.github.com/repos/Remitly/sso/events","assignees_url":"https://api.github.com/repos/Remitly/sso/assignees{/user}","branches_url":"https://api.github.com/repos/Remitly/sso/branches{/branch}","tags_url":"https://api.github.com/repos/Remitly/sso/tags","blobs_url":"https://api.github.com/repos/Remitly/sso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Remitly/sso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Remitly/sso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Remitly/sso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Remitly/sso/statuses/{sha}","languages_url":"https://api.github.com/repos/Remitly/sso/languages","stargazers_url":"https://api.github.com/repos/Remitly/sso/stargazers","contributors_url":"https://api.github.com/repos/Remitly/sso/contributors","subscribers_url":"https://api.github.com/repos/Remitly/sso/subscribers","subscription_url":"https://api.github.com/repos/Remitly/sso/subscription","commits_url":"https://api.github.com/repos/Remitly/sso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Remitly/sso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Remitly/sso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Remitly/sso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Remitly/sso/contents/{+path}","compare_url":"https://api.github.com/repos/Remitly/sso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Remitly/sso/merges","archive_url":"https://api.github.com/repos/Remitly/sso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Remitly/sso/downloads","issues_url":"https://api.github.com/repos/Remitly/sso/issues{/number}","pulls_url":"https://api.github.com/repos/Remitly/sso/pulls{/number}","milestones_url":"https://api.github.com/repos/Remitly/sso/milestones{/number}","notifications_url":"https://api.github.com/repos/Remitly/sso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Remitly/sso/labels{/name}","releases_url":"https://api.github.com/repos/Remitly/sso/releases{/id}","deployments_url":"https://api.github.com/repos/Remitly/sso/deployments","created_at":"2018-09-07T00:42:23Z","updated_at":"2018-11-16T01:21:22Z","pushed_at":"2018-12-17T20:35:59Z","git_url":"git://github.com/Remitly/sso.git","ssh_url":"git@github.com:Remitly/sso.git","clone_url":"https://github.com/Remitly/sso.git","svn_url":"https://github.com/Remitly/sso","homepage":"","size":1419,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Remitly:production","ref":"production","sha":"19dfe2dacbb24ba693d5bd7670e0d112c134d0e5","user":{"login":"Remitly","id":2490045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTAwNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2490045?v=4","gravatar_id":"","url":"https://api.github.com/users/Remitly","html_url":"https://github.com/Remitly","followers_url":"https://api.github.com/users/Remitly/followers","following_url":"https://api.github.com/users/Remitly/following{/other_user}","gists_url":"https://api.github.com/users/Remitly/gists{/gist_id}","starred_url":"https://api.github.com/users/Remitly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remitly/subscriptions","organizations_url":"https://api.github.com/users/Remitly/orgs","repos_url":"https://api.github.com/users/Remitly/repos","events_url":"https://api.github.com/users/Remitly/events{/privacy}","received_events_url":"https://api.github.com/users/Remitly/received_events","type":"Organization","site_admin":false},"repo":{"id":147749826,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3NDk4MjY=","name":"sso","full_name":"Remitly/sso","private":false,"owner":{"login":"Remitly","id":2490045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTAwNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2490045?v=4","gravatar_id":"","url":"https://api.github.com/users/Remitly","html_url":"https://github.com/Remitly","followers_url":"https://api.github.com/users/Remitly/followers","following_url":"https://api.github.com/users/Remitly/following{/other_user}","gists_url":"https://api.github.com/users/Remitly/gists{/gist_id}","starred_url":"https://api.github.com/users/Remitly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remitly/subscriptions","organizations_url":"https://api.github.com/users/Remitly/orgs","repos_url":"https://api.github.com/users/Remitly/repos","events_url":"https://api.github.com/users/Remitly/events{/privacy}","received_events_url":"https://api.github.com/users/Remitly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Remitly/sso","description":"sso, aka S.S.Octopus, aka octoboi, is a single sign-on solution for securing internal services","fork":true,"url":"https://api.github.com/repos/Remitly/sso","forks_url":"https://api.github.com/repos/Remitly/sso/forks","keys_url":"https://api.github.com/repos/Remitly/sso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Remitly/sso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Remitly/sso/teams","hooks_url":"https://api.github.com/repos/Remitly/sso/hooks","issue_events_url":"https://api.github.com/repos/Remitly/sso/issues/events{/number}","events_url":"https://api.github.com/repos/Remitly/sso/events","assignees_url":"https://api.github.com/repos/Remitly/sso/assignees{/user}","branches_url":"https://api.github.com/repos/Remitly/sso/branches{/branch}","tags_url":"https://api.github.com/repos/Remitly/sso/tags","blobs_url":"https://api.github.com/repos/Remitly/sso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Remitly/sso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Remitly/sso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Remitly/sso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Remitly/sso/statuses/{sha}","languages_url":"https://api.github.com/repos/Remitly/sso/languages","stargazers_url":"https://api.github.com/repos/Remitly/sso/stargazers","contributors_url":"https://api.github.com/repos/Remitly/sso/contributors","subscribers_url":"https://api.github.com/repos/Remitly/sso/subscribers","subscription_url":"https://api.github.com/repos/Remitly/sso/subscription","commits_url":"https://api.github.com/repos/Remitly/sso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Remitly/sso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Remitly/sso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Remitly/sso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Remitly/sso/contents/{+path}","compare_url":"https://api.github.com/repos/Remitly/sso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Remitly/sso/merges","archive_url":"https://api.github.com/repos/Remitly/sso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Remitly/sso/downloads","issues_url":"https://api.github.com/repos/Remitly/sso/issues{/number}","pulls_url":"https://api.github.com/repos/Remitly/sso/pulls{/number}","milestones_url":"https://api.github.com/repos/Remitly/sso/milestones{/number}","notifications_url":"https://api.github.com/repos/Remitly/sso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Remitly/sso/labels{/name}","releases_url":"https://api.github.com/repos/Remitly/sso/releases{/id}","deployments_url":"https://api.github.com/repos/Remitly/sso/deployments","created_at":"2018-09-07T00:42:23Z","updated_at":"2018-11-16T01:21:22Z","pushed_at":"2018-12-17T20:35:59Z","git_url":"git://github.com/Remitly/sso.git","ssh_url":"git@github.com:Remitly/sso.git","clone_url":"https://github.com/Remitly/sso.git","svn_url":"https://github.com/Remitly/sso","homepage":"","size":1419,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Remitly/sso/pulls/1"},"html":{"href":"https://github.com/Remitly/sso/pull/1"},"issue":{"href":"https://api.github.com/repos/Remitly/sso/issues/1"},"comments":{"href":"https://api.github.com/repos/Remitly/sso/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Remitly/sso/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Remitly/sso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Remitly/sso/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Remitly/sso/statuses/49a1808f7bb042d8287735ae673fd866ed53b582"}},"author_association":"NONE"}}
{"actor":{"display_login":"sporkmonger"}}