{"action":"reopened","number":32,"pull_request":{"url":"https://api.github.com/repos/chef-cookbooks/resolver/pulls/32","id":162335269,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYyMzM1MjY5","html_url":"https://github.com/chef-cookbooks/resolver/pull/32","diff_url":"https://github.com/chef-cookbooks/resolver/pull/32.diff","patch_url":"https://github.com/chef-cookbooks/resolver/pull/32.patch","issue_url":"https://api.github.com/repos/chef-cookbooks/resolver/issues/32","number":32,"state":"open","locked":false,"title":"Template add handling of empty values","user":{"login":"tambetliiv","id":35329231,"node_id":"MDQ6VXNlcjM1MzI5MjMx","avatar_url":"https://avatars3.githubusercontent.com/u/35329231?v=4","gravatar_id":"","url":"https://api.github.com/users/tambetliiv","html_url":"https://github.com/tambetliiv","followers_url":"https://api.github.com/users/tambetliiv/followers","following_url":"https://api.github.com/users/tambetliiv/following{/other_user}","gists_url":"https://api.github.com/users/tambetliiv/gists{/gist_id}","starred_url":"https://api.github.com/users/tambetliiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tambetliiv/subscriptions","organizations_url":"https://api.github.com/users/tambetliiv/orgs","repos_url":"https://api.github.com/users/tambetliiv/repos","events_url":"https://api.github.com/users/tambetliiv/events{/privacy}","received_events_url":"https://api.github.com/users/tambetliiv/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nSometimes `search` or `domain` attribute can be empty string and `.nil?` check is not handling those values. \r\n\r\nRewrite to `if` statement was because having `unless` with `||` makes it hard to read and understand. Also rewrote other `unless` statements to keep the template code uniform.\r\n\r\n### Issues Resolved\r\n\r\nWhen `search` attribute was empty, `.nil?` check failed and inserted `search ` (with whitespace), which broke nslookup. \r\n```\r\n# /usr/bin/nslookup google.com\r\n/usr/bin/nslookup: parse of /etc/resolv.conf failed\r\n```\r\n\r\n### Check List\r\n\r\n- [x] All tests pass. See <https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD>\r\n- [x] New functionality includes testing.\r\n- [x] New functionality has been documented in the README if applicable\r\n- [x] All commits have been signed for the Developer Certificate of Origin. See <https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD>\r\n","created_at":"2018-01-11T09:49:03Z","updated_at":"2018-07-27T08:07:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad39188933b49e88028e5be4fe3b6c2712f4e911","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":418411785,"node_id":"MDU6TGFiZWw0MTg0MTE3ODU=","url":"https://api.github.com/repos/chef-cookbooks/resolver/labels/Status:%20Pending%20Contributor%20Response","name":"Status: Pending Contributor Response","color":"cc00cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/chef-cookbooks/resolver/pulls/32/commits","review_comments_url":"https://api.github.com/repos/chef-cookbooks/resolver/pulls/32/comments","review_comment_url":"https://api.github.com/repos/chef-cookbooks/resolver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef-cookbooks/resolver/issues/32/comments","statuses_url":"https://api.github.com/repos/chef-cookbooks/resolver/statuses/ee0ae072223fbc4e38c65117b8e995764a733f87","head":{"label":"tambetliiv:add-empty-value-handling","ref":"add-empty-value-handling","sha":"ee0ae072223fbc4e38c65117b8e995764a733f87","user":{"login":"tambetliiv","id":35329231,"node_id":"MDQ6VXNlcjM1MzI5MjMx","avatar_url":"https://avatars3.githubusercontent.com/u/35329231?v=4","gravatar_id":"","url":"https://api.github.com/users/tambetliiv","html_url":"https://github.com/tambetliiv","followers_url":"https://api.github.com/users/tambetliiv/followers","following_url":"https://api.github.com/users/tambetliiv/following{/other_user}","gists_url":"https://api.github.com/users/tambetliiv/gists{/gist_id}","starred_url":"https://api.github.com/users/tambetliiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tambetliiv/subscriptions","organizations_url":"https://api.github.com/users/tambetliiv/orgs","repos_url":"https://api.github.com/users/tambetliiv/repos","events_url":"https://api.github.com/users/tambetliiv/events{/privacy}","received_events_url":"https://api.github.com/users/tambetliiv/received_events","type":"User","site_admin":false},"repo":{"id":117075772,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcwNzU3NzI=","name":"resolver","full_name":"tambetliiv/resolver","owner":{"login":"tambetliiv","id":35329231,"node_id":"MDQ6VXNlcjM1MzI5MjMx","avatar_url":"https://avatars3.githubusercontent.com/u/35329231?v=4","gravatar_id":"","url":"https://api.github.com/users/tambetliiv","html_url":"https://github.com/tambetliiv","followers_url":"https://api.github.com/users/tambetliiv/followers","following_url":"https://api.github.com/users/tambetliiv/following{/other_user}","gists_url":"https://api.github.com/users/tambetliiv/gists{/gist_id}","starred_url":"https://api.github.com/users/tambetliiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tambetliiv/subscriptions","organizations_url":"https://api.github.com/users/tambetliiv/orgs","repos_url":"https://api.github.com/users/tambetliiv/repos","events_url":"https://api.github.com/users/tambetliiv/events{/privacy}","received_events_url":"https://api.github.com/users/tambetliiv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tambetliiv/resolver","description":"Development repository for Chef Cookbook resolver","fork":true,"url":"https://api.github.com/repos/tambetliiv/resolver","forks_url":"https://api.github.com/repos/tambetliiv/resolver/forks","keys_url":"https://api.github.com/repos/tambetliiv/resolver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tambetliiv/resolver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tambetliiv/resolver/teams","hooks_url":"https://api.github.com/repos/tambetliiv/resolver/hooks","issue_events_url":"https://api.github.com/repos/tambetliiv/resolver/issues/events{/number}","events_url":"https://api.github.com/repos/tambetliiv/resolver/events","assignees_url":"https://api.github.com/repos/tambetliiv/resolver/assignees{/user}","branches_url":"https://api.github.com/repos/tambetliiv/resolver/branches{/branch}","tags_url":"https://api.github.com/repos/tambetliiv/resolver/tags","blobs_url":"https://api.github.com/repos/tambetliiv/resolver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tambetliiv/resolver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tambetliiv/resolver/git/refs{/sha}","trees_url":"https://api.github.com/repos/tambetliiv/resolver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tambetliiv/resolver/statuses/{sha}","languages_url":"https://api.github.com/repos/tambetliiv/resolver/languages","stargazers_url":"https://api.github.com/repos/tambetliiv/resolver/stargazers","contributors_url":"https://api.github.com/repos/tambetliiv/resolver/contributors","subscribers_url":"https://api.github.com/repos/tambetliiv/resolver/subscribers","subscription_url":"https://api.github.com/repos/tambetliiv/resolver/subscription","commits_url":"https://api.github.com/repos/tambetliiv/resolver/commits{/sha}","git_commits_url":"https://api.github.com/repos/tambetliiv/resolver/git/commits{/sha}","comments_url":"https://api.github.com/repos/tambetliiv/resolver/comments{/number}","issue_comment_url":"https://api.github.com/repos/tambetliiv/resolver/issues/comments{/number}","contents_url":"https://api.github.com/repos/tambetliiv/resolver/contents/{+path}","compare_url":"https://api.github.com/repos/tambetliiv/resolver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tambetliiv/resolver/merges","archive_url":"https://api.github.com/repos/tambetliiv/resolver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tambetliiv/resolver/downloads","issues_url":"https://api.github.com/repos/tambetliiv/resolver/issues{/number}","pulls_url":"https://api.github.com/repos/tambetliiv/resolver/pulls{/number}","milestones_url":"https://api.github.com/repos/tambetliiv/resolver/milestones{/number}","notifications_url":"https://api.github.com/repos/tambetliiv/resolver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tambetliiv/resolver/labels{/name}","releases_url":"https://api.github.com/repos/tambetliiv/resolver/releases{/id}","deployments_url":"https://api.github.com/repos/tambetliiv/resolver/deployments","created_at":"2018-01-11T09:02:56Z","updated_at":"2018-07-27T07:49:06Z","pushed_at":"2018-07-27T08:07:33Z","git_url":"git://github.com/tambetliiv/resolver.git","ssh_url":"git@github.com:tambetliiv/resolver.git","clone_url":"https://github.com/tambetliiv/resolver.git","svn_url":"https://github.com/tambetliiv/resolver","homepage":"https://supermarket.chef.io/cookbooks/resolver","size":108,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef-cookbooks:master","ref":"master","sha":"aaf788f118ba76ff4550ab8bc4316b1a002c5538","user":{"login":"chef-cookbooks","id":3617830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MTc4MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/3617830?v=4","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":3720658,"node_id":"MDEwOlJlcG9zaXRvcnkzNzIwNjU4","name":"resolver","full_name":"chef-cookbooks/resolver","owner":{"login":"chef-cookbooks","id":3617830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MTc4MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/3617830?v=4","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-cookbooks/resolver","description":"Development repository for Chef Cookbook resolver","fork":false,"url":"https://api.github.com/repos/chef-cookbooks/resolver","forks_url":"https://api.github.com/repos/chef-cookbooks/resolver/forks","keys_url":"https://api.github.com/repos/chef-cookbooks/resolver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-cookbooks/resolver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-cookbooks/resolver/teams","hooks_url":"https://api.github.com/repos/chef-cookbooks/resolver/hooks","issue_events_url":"https://api.github.com/repos/chef-cookbooks/resolver/issues/events{/number}","events_url":"https://api.github.com/repos/chef-cookbooks/resolver/events","assignees_url":"https://api.github.com/repos/chef-cookbooks/resolver/assignees{/user}","branches_url":"https://api.github.com/repos/chef-cookbooks/resolver/branches{/branch}","tags_url":"https://api.github.com/repos/chef-cookbooks/resolver/tags","blobs_url":"https://api.github.com/repos/chef-cookbooks/resolver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-cookbooks/resolver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-cookbooks/resolver/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-cookbooks/resolver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-cookbooks/resolver/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-cookbooks/resolver/languages","stargazers_url":"https://api.github.com/repos/chef-cookbooks/resolver/stargazers","contributors_url":"https://api.github.com/repos/chef-cookbooks/resolver/contributors","subscribers_url":"https://api.github.com/repos/chef-cookbooks/resolver/subscribers","subscription_url":"https://api.github.com/repos/chef-cookbooks/resolver/subscription","commits_url":"https://api.github.com/repos/chef-cookbooks/resolver/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-cookbooks/resolver/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-cookbooks/resolver/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-cookbooks/resolver/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-cookbooks/resolver/contents/{+path}","compare_url":"https://api.github.com/repos/chef-cookbooks/resolver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-cookbooks/resolver/merges","archive_url":"https://api.github.com/repos/chef-cookbooks/resolver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-cookbooks/resolver/downloads","issues_url":"https://api.github.com/repos/chef-cookbooks/resolver/issues{/number}","pulls_url":"https://api.github.com/repos/chef-cookbooks/resolver/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-cookbooks/resolver/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-cookbooks/resolver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-cookbooks/resolver/labels{/name}","releases_url":"https://api.github.com/repos/chef-cookbooks/resolver/releases{/id}","deployments_url":"https://api.github.com/repos/chef-cookbooks/resolver/deployments","created_at":"2012-03-14T18:19:12Z","updated_at":"2018-07-26T22:37:31Z","pushed_at":"2018-07-27T07:37:57Z","git_url":"git://github.com/chef-cookbooks/resolver.git","ssh_url":"git@github.com:chef-cookbooks/resolver.git","clone_url":"https://github.com/chef-cookbooks/resolver.git","svn_url":"https://github.com/chef-cookbooks/resolver","homepage":"https://supermarket.chef.io/cookbooks/resolver","size":116,"stargazers_count":28,"watchers_count":28,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":44,"open_issues":5,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/resolver/pulls/32"},"html":{"href":"https://github.com/chef-cookbooks/resolver/pull/32"},"issue":{"href":"https://api.github.com/repos/chef-cookbooks/resolver/issues/32"},"comments":{"href":"https://api.github.com/repos/chef-cookbooks/resolver/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/chef-cookbooks/resolver/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/chef-cookbooks/resolver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef-cookbooks/resolver/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/chef-cookbooks/resolver/statuses/ee0ae072223fbc4e38c65117b8e995764a733f87"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"tambetliiv"}}