{"action":"closed","number":5782,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/5782","id":207475787,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDc1Nzg3","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/5782","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/5782.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/5782.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/5782","number":5782,"state":"closed","locked":false,"title":"Bigtable: app_profile_object","user":{"login":"AVaksman","id":7764119,"node_id":"MDQ6VXNlcjc3NjQxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7764119?v=4","gravatar_id":"","url":"https://api.github.com/users/AVaksman","html_url":"https://github.com/AVaksman","followers_url":"https://api.github.com/users/AVaksman/followers","following_url":"https://api.github.com/users/AVaksman/following{/other_user}","gists_url":"https://api.github.com/users/AVaksman/gists{/gist_id}","starred_url":"https://api.github.com/users/AVaksman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVaksman/subscriptions","organizations_url":"https://api.github.com/users/AVaksman/orgs","repos_url":"https://api.github.com/users/AVaksman/repos","events_url":"https://api.github.com/users/AVaksman/events{/privacy}","received_events_url":"https://api.github.com/users/AVaksman/received_events","type":"User","site_admin":false},"body":"Wrap app_profile operations in an AppProfile object rather than returning protobuf objects.\r\n\r\n- [x] New app_profile object CRUD implementation complete\r\n- [x] Added factory `app_profile` to `instance.py`\r\n- [x] `instance.list_app_profiles()` now returns a list of new app_profile objects\r\n- [x] system tests\r\n- [x] partial unit tests\r\nTODO:\r\n- [x] finish unit tests\r\n- [x] move system tests to `def _test_app_profile_helper` and call it inside the \r\n    `test_create_instance_w_two_clusters`\r\n","created_at":"2018-08-10T00:07:09Z","updated_at":"2018-08-16T18:43:56Z","closed_at":"2018-08-16T18:43:56Z","merged_at":"2018-08-16T18:43:56Z","merge_commit_sha":"d1cda15bcbbbbef15970af8f262059843f3b64cb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tseaver","id":242750,"node_id":"MDQ6VXNlcjI0Mjc1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/242750?v=4","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":210703442,"node_id":"MDU6TGFiZWwyMTA3MDM0NDI=","url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels/api:%20bigtable","name":"api: bigtable","color":"f8f8f8","default":false},{"id":131682747,"node_id":"MDU6TGFiZWwxMzE2ODI3NDc=","url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/5782/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/5782/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/5782/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/0db7ff5390ada4f7e7f1420740ce35267bc4b6f1","head":{"label":"AVaksman:bigtable-AppProfile-object","ref":"bigtable-AppProfile-object","sha":"0db7ff5390ada4f7e7f1420740ce35267bc4b6f1","user":{"login":"AVaksman","id":7764119,"node_id":"MDQ6VXNlcjc3NjQxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7764119?v=4","gravatar_id":"","url":"https://api.github.com/users/AVaksman","html_url":"https://github.com/AVaksman","followers_url":"https://api.github.com/users/AVaksman/followers","following_url":"https://api.github.com/users/AVaksman/following{/other_user}","gists_url":"https://api.github.com/users/AVaksman/gists{/gist_id}","starred_url":"https://api.github.com/users/AVaksman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVaksman/subscriptions","organizations_url":"https://api.github.com/users/AVaksman/orgs","repos_url":"https://api.github.com/users/AVaksman/repos","events_url":"https://api.github.com/users/AVaksman/events{/privacy}","received_events_url":"https://api.github.com/users/AVaksman/received_events","type":"User","site_admin":false},"repo":{"id":140303555,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMDM1NTU=","name":"google-cloud-python","full_name":"AVaksman/google-cloud-python","owner":{"login":"AVaksman","id":7764119,"node_id":"MDQ6VXNlcjc3NjQxMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7764119?v=4","gravatar_id":"","url":"https://api.github.com/users/AVaksman","html_url":"https://github.com/AVaksman","followers_url":"https://api.github.com/users/AVaksman/followers","following_url":"https://api.github.com/users/AVaksman/following{/other_user}","gists_url":"https://api.github.com/users/AVaksman/gists{/gist_id}","starred_url":"https://api.github.com/users/AVaksman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVaksman/subscriptions","organizations_url":"https://api.github.com/users/AVaksman/orgs","repos_url":"https://api.github.com/users/AVaksman/repos","events_url":"https://api.github.com/users/AVaksman/events{/privacy}","received_events_url":"https://api.github.com/users/AVaksman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AVaksman/google-cloud-python","description":"Google Cloud Client Library for Python","fork":true,"url":"https://api.github.com/repos/AVaksman/google-cloud-python","forks_url":"https://api.github.com/repos/AVaksman/google-cloud-python/forks","keys_url":"https://api.github.com/repos/AVaksman/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AVaksman/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AVaksman/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/AVaksman/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/AVaksman/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/AVaksman/google-cloud-python/events","assignees_url":"https://api.github.com/repos/AVaksman/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/AVaksman/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/AVaksman/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/AVaksman/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AVaksman/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AVaksman/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/AVaksman/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AVaksman/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/AVaksman/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/AVaksman/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/AVaksman/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/AVaksman/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/AVaksman/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/AVaksman/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/AVaksman/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/AVaksman/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/AVaksman/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/AVaksman/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/AVaksman/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AVaksman/google-cloud-python/merges","archive_url":"https://api.github.com/repos/AVaksman/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AVaksman/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/AVaksman/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/AVaksman/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/AVaksman/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/AVaksman/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AVaksman/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/AVaksman/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/AVaksman/google-cloud-python/deployments","created_at":"2018-07-09T15:14:49Z","updated_at":"2018-08-16T03:18:44Z","pushed_at":"2018-08-16T17:54:21Z","git_url":"git://github.com/AVaksman/google-cloud-python.git","ssh_url":"git@github.com:AVaksman/google-cloud-python.git","clone_url":"https://github.com/AVaksman/google-cloud-python.git","svn_url":"https://github.com/AVaksman/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":181355,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"b2261bd2cbd5220a1cea08521196ce672f415f44","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMxNjQ1MQ==","name":"google-cloud-python","full_name":"GoogleCloudPlatform/google-cloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2018-08-16T17:35:06Z","pushed_at":"2018-08-16T18:43:56Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":240822,"stargazers_count":1675,"watchers_count":1675,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":722,"mirror_url":null,"archived":false,"open_issues_count":124,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":722,"open_issues":124,"watchers":1675,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/5782"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/5782"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/5782"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/5782/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/5782/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/5782/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/0db7ff5390ada4f7e7f1420740ce35267bc4b6f1"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sduskis","id":99305,"node_id":"MDQ6VXNlcjk5MzA1","avatar_url":"https://avatars3.githubusercontent.com/u/99305?v=4","gravatar_id":"","url":"https://api.github.com/users/sduskis","html_url":"https://github.com/sduskis","followers_url":"https://api.github.com/users/sduskis/followers","following_url":"https://api.github.com/users/sduskis/following{/other_user}","gists_url":"https://api.github.com/users/sduskis/gists{/gist_id}","starred_url":"https://api.github.com/users/sduskis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sduskis/subscriptions","organizations_url":"https://api.github.com/users/sduskis/orgs","repos_url":"https://api.github.com/users/sduskis/repos","events_url":"https://api.github.com/users/sduskis/events{/privacy}","received_events_url":"https://api.github.com/users/sduskis/received_events","type":"User","site_admin":false},"comments":8,"review_comments":27,"maintainer_can_modify":false,"commits":11,"additions":1205,"deletions":635,"changed_files":5}}
{"actor":{"display_login":"sduskis"}}