{"action":"closed","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go/issues/1067","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go/issues/1067/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go/issues/1067/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go/issues/1067/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-go/issues/1067","id":341947127,"node_id":"MDU6SXNzdWUzNDE5NDcxMjc=","number":1067,"title":"google.golang.org/api dependency revision not stated in this repo, causes breaking changes upgrading 0.18.0 to 0.24.0","user":{"login":"henrahmagix","id":1429026,"node_id":"MDQ6VXNlcjE0MjkwMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1429026?v=4","gravatar_id":"","url":"https://api.github.com/users/henrahmagix","html_url":"https://github.com/henrahmagix","followers_url":"https://api.github.com/users/henrahmagix/followers","following_url":"https://api.github.com/users/henrahmagix/following{/other_user}","gists_url":"https://api.github.com/users/henrahmagix/gists{/gist_id}","starred_url":"https://api.github.com/users/henrahmagix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrahmagix/subscriptions","organizations_url":"https://api.github.com/users/henrahmagix/orgs","repos_url":"https://api.github.com/users/henrahmagix/repos","events_url":"https://api.github.com/users/henrahmagix/events{/privacy}","received_events_url":"https://api.github.com/users/henrahmagix/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-17T14:34:25Z","updated_at":"2018-07-17T15:00:45Z","closed_at":"2018-07-17T15:00:44Z","author_association":"NONE","body":"## Client\r\n\r\nPubSub\r\n\r\n## Describe Your Environment\r\n\r\nmacOS + go1.10.3 darwin/amd64 + dep v0.4.1\r\n\r\n## Expected Behavior\r\n\r\nUpgrading from 0.18.0 to 0.24.0 should upgrade required dependencies.\r\n\r\n## Actual Behavior\r\n\r\nDependencies of this package were not upgrade.\r\n\r\nReceived errors when building:\r\n```\r\n$ go build -v\r\ngithub.com/myuser/myrepo/vendor/cloud.google.com/go/monitoring/apiv3\r\ngithub.com/myuser/myrepo/vendor/cloud.google.com/go/pubsub\r\n# github.com/myuser/myrepo/vendor/cloud.google.com/go/monitoring/apiv3\r\nvendor/cloud.google.com/go/monitoring/apiv3/alert_policy_client.go:83:20: undefined: monitoring.AlertPolicyServiceClient\r\n# github.com/myuser/myrepo/vendor/cloud.google.com/go/pubsub\r\nvendor/cloud.google.com/go/pubsub/topic.go:351:12: t.bundler.HandlerLimit undefined (type *bundler.Bundler has no field or method HandlerLimit)\r\nvendor/cloud.google.com/go/pubsub/topic.go:353:12: t.bundler.HandlerLimit undefined (type *bundler.Bundler has no field or method HandlerLimit)\r\n```\r\n\r\n### `t.bundler.HandlerLimit`\r\n\r\nThis is using `google.golang.org/api/support/bundler`, which came as [revision 65b0d8655182691ad23b4fac11e6f7b897d9b634](https://github.com/google/google-api-go-client/tree/65b0d8655182691ad23b4fac11e6f7b897d9b634) when this package was installed at v0.18.0 on 2018-01-23.\r\n\r\nToday I upgraded this package to v0.24.0 but the dependency `google.golang.org/api` was not upgraded, and so produced the above errors.\r\n\r\nWould it be possible to include dep's `Gopkg.toml` and `Gopkg.lock` files in this repo so dependencies can be tracked and breaking changes don't occur? Because I don't know what revision of `google.golang.org/api` I need to match this package's v0.24.0 release."}}
{"actor":{"display_login":"jadekler"}}