{"action":"created","comment":{"url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/comments/208885092","pull_request_review_id":144784947,"id":208885092,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODg4NTA5Mg==","diff_hunk":"@@ -282,16 +282,47 @@ function configure_cache() {\n        </encoding>\"\n   fi\n \n-  if [ -n \"$(find_env \"${prefix}_CACHE_EVICTION_STRATEGY\")$(find_env \"${prefix}_CACHE_EVICTION_MAX_ENTRIES\")\" ]; then\n-    if [ -n \"$(find_env \"${prefix}_CACHE_EVICTION_STRATEGY\")\" ]; then\n-      local CACHE_EVICTION_STRATEGY=\"strategy=\\\"$(find_env \"${prefix}_CACHE_EVICTION_STRATEGY\")\\\"\"\n-    fi\n+  if [ -n \"$(find_env \"${prefix}_CACHE_MEMORY_EVICTION_SIZE\")$(find_env \"${prefix}_CACHE_EVICTION_MAX_ENTRIES\")\" ]; then\n+\n+    local evictionSize=\"$(find_env \"${prefix}_CACHE_MEMORY_EVICTION_SIZE\")\"\n     if [ -n \"$(find_env \"${prefix}_CACHE_EVICTION_MAX_ENTRIES\")\" ]; then\n-      local CACHE_EVICTION_MAX_ENTRIES=\"size=\\\"$(find_env \"${prefix}_CACHE_EVICTION_MAX_ENTRIES\")\\\"\"\n+      log_warning \"Environment variable {$prefix}_CACHE_EVICTION_MAX_ENTRIES has been deprecated. Use {$prefix}_CACHE_MEMORY_EVICTION_SIZE instead.\"","path":"modules/datagrid/72/launch/added/launch/infinispan-config.sh","position":13,"original_position":13,"commit_id":"a58a3eff81e7f0a8fd80279652e7422baeab89c7","original_commit_id":"a58a3eff81e7f0a8fd80279652e7422baeab89c7","user":{"login":"Crumby","id":9006466,"node_id":"MDQ6VXNlcjkwMDY0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/9006466?v=4","gravatar_id":"","url":"https://api.github.com/users/Crumby","html_url":"https://github.com/Crumby","followers_url":"https://api.github.com/users/Crumby/followers","following_url":"https://api.github.com/users/Crumby/following{/other_user}","gists_url":"https://api.github.com/users/Crumby/gists{/gist_id}","starred_url":"https://api.github.com/users/Crumby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crumby/subscriptions","organizations_url":"https://api.github.com/users/Crumby/orgs","repos_url":"https://api.github.com/users/Crumby/repos","events_url":"https://api.github.com/users/Crumby/events{/privacy}","received_events_url":"https://api.github.com/users/Crumby/received_events","type":"User","site_admin":false},"body":"'Use {$prefix}_CACH...' -> 'Use ${prefix}_CACH...'","created_at":"2018-08-09T10:46:41Z","updated_at":"2018-08-09T10:46:41Z","html_url":"https://github.com/jboss-container-images/jboss-datagrid-7-openshift-image/pull/76#discussion_r208885092","pull_request_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/76","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/comments/208885092"},"html":{"href":"https://github.com/jboss-container-images/jboss-datagrid-7-openshift-image/pull/76#discussion_r208885092"},"pull_request":{"href":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/76","id":205960065,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTYwMDY1","html_url":"https://github.com/jboss-container-images/jboss-datagrid-7-openshift-image/pull/76","diff_url":"https://github.com/jboss-container-images/jboss-datagrid-7-openshift-image/pull/76.diff","patch_url":"https://github.com/jboss-container-images/jboss-datagrid-7-openshift-image/pull/76.patch","issue_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/issues/76","number":76,"state":"open","locked":false,"title":"[CLOUD-2769] [JDG72] Enable new memory eviction configuration","user":{"login":"vblagoje","id":458335,"node_id":"MDQ6VXNlcjQ1ODMzNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/458335?v=4","gravatar_id":"","url":"https://api.github.com/users/vblagoje","html_url":"https://github.com/vblagoje","followers_url":"https://api.github.com/users/vblagoje/followers","following_url":"https://api.github.com/users/vblagoje/following{/other_user}","gists_url":"https://api.github.com/users/vblagoje/gists{/gist_id}","starred_url":"https://api.github.com/users/vblagoje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vblagoje/subscriptions","organizations_url":"https://api.github.com/users/vblagoje/orgs","repos_url":"https://api.github.com/users/vblagoje/repos","events_url":"https://api.github.com/users/vblagoje/events{/privacy}","received_events_url":"https://api.github.com/users/vblagoje/received_events","type":"User","site_admin":false},"body":"Introduces new <memory> eviction configuration and accompanying per cache environmental variables. More details at https://issues.jboss.org/browse/CLOUD-2769","created_at":"2018-08-03T08:28:52Z","updated_at":"2018-08-09T10:46:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41bb4cffe7d9ca608b921db226e24c93f9576b32","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/76/commits","review_comments_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/76/comments","review_comment_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/issues/76/comments","statuses_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/statuses/a58a3eff81e7f0a8fd80279652e7422baeab89c7","head":{"label":"vblagoje:t_2769","ref":"t_2769","sha":"a58a3eff81e7f0a8fd80279652e7422baeab89c7","user":{"login":"vblagoje","id":458335,"node_id":"MDQ6VXNlcjQ1ODMzNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/458335?v=4","gravatar_id":"","url":"https://api.github.com/users/vblagoje","html_url":"https://github.com/vblagoje","followers_url":"https://api.github.com/users/vblagoje/followers","following_url":"https://api.github.com/users/vblagoje/following{/other_user}","gists_url":"https://api.github.com/users/vblagoje/gists{/gist_id}","starred_url":"https://api.github.com/users/vblagoje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vblagoje/subscriptions","organizations_url":"https://api.github.com/users/vblagoje/orgs","repos_url":"https://api.github.com/users/vblagoje/repos","events_url":"https://api.github.com/users/vblagoje/events{/privacy}","received_events_url":"https://api.github.com/users/vblagoje/received_events","type":"User","site_admin":false},"repo":{"id":138731064,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3MzEwNjQ=","name":"jboss-datagrid-7-openshift-image","full_name":"vblagoje/jboss-datagrid-7-openshift-image","owner":{"login":"vblagoje","id":458335,"node_id":"MDQ6VXNlcjQ1ODMzNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/458335?v=4","gravatar_id":"","url":"https://api.github.com/users/vblagoje","html_url":"https://github.com/vblagoje","followers_url":"https://api.github.com/users/vblagoje/followers","following_url":"https://api.github.com/users/vblagoje/following{/other_user}","gists_url":"https://api.github.com/users/vblagoje/gists{/gist_id}","starred_url":"https://api.github.com/users/vblagoje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vblagoje/subscriptions","organizations_url":"https://api.github.com/users/vblagoje/orgs","repos_url":"https://api.github.com/users/vblagoje/repos","events_url":"https://api.github.com/users/vblagoje/events{/privacy}","received_events_url":"https://api.github.com/users/vblagoje/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vblagoje/jboss-datagrid-7-openshift-image","description":"Red Hat JBoss Data Grid 7 OpenShift container images","fork":true,"url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image","forks_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/forks","keys_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/teams","hooks_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/hooks","issue_events_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/issues/events{/number}","events_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/events","assignees_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/assignees{/user}","branches_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/branches{/branch}","tags_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/tags","blobs_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/statuses/{sha}","languages_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/languages","stargazers_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/stargazers","contributors_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/contributors","subscribers_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/subscribers","subscription_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/subscription","commits_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/contents/{+path}","compare_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/merges","archive_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/downloads","issues_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/issues{/number}","pulls_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/pulls{/number}","milestones_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/milestones{/number}","notifications_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/labels{/name}","releases_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/releases{/id}","deployments_url":"https://api.github.com/repos/vblagoje/jboss-datagrid-7-openshift-image/deployments","created_at":"2018-06-26T11:53:53Z","updated_at":"2018-06-26T11:53:54Z","pushed_at":"2018-08-06T09:03:19Z","git_url":"git://github.com/vblagoje/jboss-datagrid-7-openshift-image.git","ssh_url":"git@github.com:vblagoje/jboss-datagrid-7-openshift-image.git","clone_url":"https://github.com/vblagoje/jboss-datagrid-7-openshift-image.git","svn_url":"https://github.com/vblagoje/jboss-datagrid-7-openshift-image","homepage":null,"size":119,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"datagrid71-dev"}},"base":{"label":"jboss-container-images:datagrid72-dev","ref":"datagrid72-dev","sha":"ab23554ffb31e026c63e0954917b3ed3dc85c465","user":{"login":"jboss-container-images","id":28777643,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Nzc3NjQz","avatar_url":"https://avatars3.githubusercontent.com/u/28777643?v=4","gravatar_id":"","url":"https://api.github.com/users/jboss-container-images","html_url":"https://github.com/jboss-container-images","followers_url":"https://api.github.com/users/jboss-container-images/followers","following_url":"https://api.github.com/users/jboss-container-images/following{/other_user}","gists_url":"https://api.github.com/users/jboss-container-images/gists{/gist_id}","starred_url":"https://api.github.com/users/jboss-container-images/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboss-container-images/subscriptions","organizations_url":"https://api.github.com/users/jboss-container-images/orgs","repos_url":"https://api.github.com/users/jboss-container-images/repos","events_url":"https://api.github.com/users/jboss-container-images/events{/privacy}","received_events_url":"https://api.github.com/users/jboss-container-images/received_events","type":"Organization","site_admin":false},"repo":{"id":96088598,"node_id":"MDEwOlJlcG9zaXRvcnk5NjA4ODU5OA==","name":"jboss-datagrid-7-openshift-image","full_name":"jboss-container-images/jboss-datagrid-7-openshift-image","owner":{"login":"jboss-container-images","id":28777643,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Nzc3NjQz","avatar_url":"https://avatars3.githubusercontent.com/u/28777643?v=4","gravatar_id":"","url":"https://api.github.com/users/jboss-container-images","html_url":"https://github.com/jboss-container-images","followers_url":"https://api.github.com/users/jboss-container-images/followers","following_url":"https://api.github.com/users/jboss-container-images/following{/other_user}","gists_url":"https://api.github.com/users/jboss-container-images/gists{/gist_id}","starred_url":"https://api.github.com/users/jboss-container-images/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboss-container-images/subscriptions","organizations_url":"https://api.github.com/users/jboss-container-images/orgs","repos_url":"https://api.github.com/users/jboss-container-images/repos","events_url":"https://api.github.com/users/jboss-container-images/events{/privacy}","received_events_url":"https://api.github.com/users/jboss-container-images/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jboss-container-images/jboss-datagrid-7-openshift-image","description":"Red Hat JBoss Data Grid 7 OpenShift container images","fork":false,"url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image","forks_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/forks","keys_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/teams","hooks_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/hooks","issue_events_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/issues/events{/number}","events_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/events","assignees_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/assignees{/user}","branches_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/branches{/branch}","tags_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/tags","blobs_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/statuses/{sha}","languages_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/languages","stargazers_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/stargazers","contributors_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/contributors","subscribers_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/subscribers","subscription_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/subscription","commits_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/contents/{+path}","compare_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/merges","archive_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/downloads","issues_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/issues{/number}","pulls_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls{/number}","milestones_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/milestones{/number}","notifications_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/labels{/name}","releases_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/releases{/id}","deployments_url":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/deployments","created_at":"2017-07-03T08:33:09Z","updated_at":"2018-06-26T14:51:09Z","pushed_at":"2018-08-08T15:16:12Z","git_url":"git://github.com/jboss-container-images/jboss-datagrid-7-openshift-image.git","ssh_url":"git@github.com:jboss-container-images/jboss-datagrid-7-openshift-image.git","clone_url":"https://github.com/jboss-container-images/jboss-datagrid-7-openshift-image.git","svn_url":"https://github.com/jboss-container-images/jboss-datagrid-7-openshift-image","homepage":null,"size":113,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":4,"watchers":0,"default_branch":"datagrid71-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/76"},"html":{"href":"https://github.com/jboss-container-images/jboss-datagrid-7-openshift-image/pull/76"},"issue":{"href":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/issues/76"},"comments":{"href":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/jboss-container-images/jboss-datagrid-7-openshift-image/statuses/a58a3eff81e7f0a8fd80279652e7422baeab89c7"}},"author_association":"NONE"}}
{"actor":{"display_login":"Crumby"}}