{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/211","repository_url":"https://api.github.com/repos/guardian/zuora-auto-cancel","labels_url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/211/labels{/name}","comments_url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/211/comments","events_url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/211/events","html_url":"https://github.com/guardian/zuora-auto-cancel/pull/211","id":377478565,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDEyMDgx","number":211,"title":"Send payment failure emails via SQS","user":{"login":"QuarpT","id":29203769,"node_id":"MDQ6VXNlcjI5MjAzNzY5","avatar_url":"https://avatars2.githubusercontent.com/u/29203769?v=4","gravatar_id":"","url":"https://api.github.com/users/QuarpT","html_url":"https://github.com/QuarpT","followers_url":"https://api.github.com/users/QuarpT/followers","following_url":"https://api.github.com/users/QuarpT/following{/other_user}","gists_url":"https://api.github.com/users/QuarpT/gists{/gist_id}","starred_url":"https://api.github.com/users/QuarpT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuarpT/subscriptions","organizations_url":"https://api.github.com/users/QuarpT/orgs","repos_url":"https://api.github.com/users/QuarpT/repos","events_url":"https://api.github.com/users/QuarpT/events{/privacy}","received_events_url":"https://api.github.com/users/QuarpT/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-05T16:29:18Z","updated_at":"2018-11-05T20:08:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/guardian/zuora-auto-cancel/pulls/211","html_url":"https://github.com/guardian/zuora-auto-cancel/pull/211","diff_url":"https://github.com/guardian/zuora-auto-cancel/pull/211.diff","patch_url":"https://github.com/guardian/zuora-auto-cancel/pull/211.patch"},"body":"Work done:\r\n\r\nSend payment failure emails via SQS to be sent by membership-workflow. We no longer use the ET trigger ID. Instead we use a campaign ID (DataExtensionName) recognised by membership-workflow.\r\n\r\nWhy are we doing this?\r\n\r\nWe are migrating email service providers. We don't want to add Braze as a third party dependency of the zuora-auto-cancel lambda. Instead we publish to SQS and rely on membership-workflow to send emails.\r\n\r\nBefore merge:\r\n\r\nA membership workflow PR needs to created to support sending these 5 emails\r\nNeed to figure out how to get an sfContactId or identityId to send on the sqs queue"},"comment":{"url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/comments/436017389","html_url":"https://github.com/guardian/zuora-auto-cancel/pull/211#issuecomment-436017389","issue_url":"https://api.github.com/repos/guardian/zuora-auto-cancel/issues/211","id":436017389,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjAxNzM4OQ==","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T20:08:34Z","updated_at":"2018-11-05T20:08:34Z","author_association":"NONE","body":"\n![Codacy](https://app.codacy.com/assets/images/favicon.png) Here is an overview of what got changed by this pull request:\n\n\n```diff\n\nIssues\n======\n+ Solved 2\n- Added 3\n           \n\nCoverage decreased per file\n===========================\n- lib/handler/src/main/scala/com/gu/util/config/ConfigModels.scala  -21\n- src/main/scala/com/gu/paymentFailure/Lambda.scala  -6\n- src/main/scala/com/gu/paymentFailure/ToMessage.scala  -1\n- src/main/scala/com/gu/paymentFailure/PaymentFailureSteps.scala  -1\n         \n\nClones added\n============\n- lib/effects-sqs/src/main/scala/com/gu/effects/sqs/AwsSQSSend.scala  2\n         \n```\n\n\nSee the complete overview on [Codacy](https://app.codacy.com/app/Guardian-Reader-Revenue/zuora-auto-cancel/pullRequest?prid=2498270&bid=9584428)\n        "}}
{"actor":{"display_login":"codacy-bot"}}