{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/210061066","pull_request_review_id":146199092,"id":210061066,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDA2MTA2Ng==","diff_hunk":"@@ -499,15 +499,15 @@ public void TestPow ()\n \t\t\tAssert.IsTrue (double.IsNaN (Math.Pow (             double.NaN, double.NegativeInfinity)), \"#2\");\n \t\t\tAssert.IsTrue (double.IsNaN (Math.Pow (             double.NaN,                      -2)), \"#2\");\n \t\t\tAssert.IsTrue (double.IsNaN (Math.Pow (             double.NaN,                      -1)), \"#3\");\n-\t\t\tAssert.IsTrue (double.IsNaN (Math.Pow (             double.NaN,                       0)), \"#4\");\n+\t\t\tAssert.IsFalse (double.IsNaN (Math.Pow (             double.NaN,                       0)), \"#4\");","path":"mcs/class/corlib/Test/System/MathTest.cs","position":5,"original_position":5,"commit_id":"0ecdd37e186392efdb63e5568afa3f002ca24aef","original_commit_id":"0ecdd37e186392efdb63e5568afa3f002ca24aef","user":{"login":"EgorBo","id":523221,"node_id":"MDQ6VXNlcjUyMzIyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/523221?v=4","gravatar_id":"","url":"https://api.github.com/users/EgorBo","html_url":"https://github.com/EgorBo","followers_url":"https://api.github.com/users/EgorBo/followers","following_url":"https://api.github.com/users/EgorBo/following{/other_user}","gists_url":"https://api.github.com/users/EgorBo/gists{/gist_id}","starred_url":"https://api.github.com/users/EgorBo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EgorBo/subscriptions","organizations_url":"https://api.github.com/users/EgorBo/orgs","repos_url":"https://api.github.com/users/EgorBo/repos","events_url":"https://api.github.com/users/EgorBo/events{/privacy}","received_events_url":"https://api.github.com/users/EgorBo/received_events","type":"User","site_admin":false},"body":"or did you mean the case where we could run our tests on top of .NET Framework on Windows? AFAIR nobody maintains it and it doesn't work.","created_at":"2018-08-14T18:41:11Z","updated_at":"2018-08-14T18:41:12Z","html_url":"https://github.com/mono/mono/pull/10033#discussion_r210061066","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/10033","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/210061066"},"html":{"href":"https://github.com/mono/mono/pull/10033#discussion_r210061066"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/10033"}},"in_reply_to_id":210057184},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/10033","id":207731342,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzMxMzQy","html_url":"https://github.com/mono/mono/pull/10033","diff_url":"https://github.com/mono/mono/pull/10033.diff","patch_url":"https://github.com/mono/mono/pull/10033.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/10033","number":10033,"state":"open","locked":false,"title":"[corlib] Math from CoreFX","user":{"login":"EgorBo","id":523221,"node_id":"MDQ6VXNlcjUyMzIyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/523221?v=4","gravatar_id":"","url":"https://api.github.com/users/EgorBo","html_url":"https://github.com/EgorBo","followers_url":"https://api.github.com/users/EgorBo/followers","following_url":"https://api.github.com/users/EgorBo/following{/other_user}","gists_url":"https://api.github.com/users/EgorBo/gists{/gist_id}","starred_url":"https://api.github.com/users/EgorBo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EgorBo/subscriptions","organizations_url":"https://api.github.com/users/EgorBo/orgs","repos_url":"https://api.github.com/users/EgorBo/repos","events_url":"https://api.github.com/users/EgorBo/events{/privacy}","received_events_url":"https://api.github.com/users/EgorBo/received_events","type":"User","site_admin":false},"body":"Replaces reference source implementation with CoreFX\r\n(Math.CoreCLR is copied from coreclr repo).\r\nAlso +2k math tests from CoreFX.\r\nThere are a couple of differences, e.g.:\r\n```csharp\r\nConsole.WriteLine(Math.Pow(double.NaN, 0));\r\nConsole.WriteLine(Math.Pow(1, double.NaN));\r\nConsole.WriteLine(Math.Pow(-1, double.PositiveInfinity));\r\nConsole.WriteLine(Math.Pow(-1, double.NegativeInfinity));\r\n```\r\nAll print `1` on .NET Core but `NaN` on .NET 4.7 and old mono (before these changes).\r\nBut @tannergooding proved it's correct behavior https://gitter.im/dotnet/corefx?at=5b6e072d5762ee4fe55bc313 (IEEE 754:2008 spec - 9.2.1: Special Values)\r\n\r\n`Math.Round` is now managed, but it has `[Intrinsics]` so I guess it's implemented using SSE41.\r\nAlso, fixes https://github.com/mono/mono/issues/9989\r\n\r\nPart of #7737","created_at":"2018-08-10T21:57:10Z","updated_at":"2018-08-14T18:41:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6d50d5621dddde0cd9a8e02112902288fe12d18","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vargaz","id":186301,"node_id":"MDQ6VXNlcjE4NjMwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/186301?v=4","gravatar_id":"","url":"https://api.github.com/users/vargaz","html_url":"https://github.com/vargaz","followers_url":"https://api.github.com/users/vargaz/followers","following_url":"https://api.github.com/users/vargaz/following{/other_user}","gists_url":"https://api.github.com/users/vargaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vargaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vargaz/subscriptions","organizations_url":"https://api.github.com/users/vargaz/orgs","repos_url":"https://api.github.com/users/vargaz/repos","events_url":"https://api.github.com/users/vargaz/events{/privacy}","received_events_url":"https://api.github.com/users/vargaz/received_events","type":"User","site_admin":false},{"login":"marek-safar","id":250852,"node_id":"MDQ6VXNlcjI1MDg1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/250852?v=4","gravatar_id":"","url":"https://api.github.com/users/marek-safar","html_url":"https://github.com/marek-safar","followers_url":"https://api.github.com/users/marek-safar/followers","following_url":"https://api.github.com/users/marek-safar/following{/other_user}","gists_url":"https://api.github.com/users/marek-safar/gists{/gist_id}","starred_url":"https://api.github.com/users/marek-safar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marek-safar/subscriptions","organizations_url":"https://api.github.com/users/marek-safar/orgs","repos_url":"https://api.github.com/users/marek-safar/repos","events_url":"https://api.github.com/users/marek-safar/events{/privacy}","received_events_url":"https://api.github.com/users/marek-safar/received_events","type":"User","site_admin":false},{"login":"akoeplinger","id":1376924,"node_id":"MDQ6VXNlcjEzNzY5MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1376924?v=4","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/10033/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/10033/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/10033/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/0ecdd37e186392efdb63e5568afa3f002ca24aef","head":{"label":"EgorBo:corefx-math","ref":"corefx-math","sha":"0ecdd37e186392efdb63e5568afa3f002ca24aef","user":{"login":"EgorBo","id":523221,"node_id":"MDQ6VXNlcjUyMzIyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/523221?v=4","gravatar_id":"","url":"https://api.github.com/users/EgorBo","html_url":"https://github.com/EgorBo","followers_url":"https://api.github.com/users/EgorBo/followers","following_url":"https://api.github.com/users/EgorBo/following{/other_user}","gists_url":"https://api.github.com/users/EgorBo/gists{/gist_id}","starred_url":"https://api.github.com/users/EgorBo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EgorBo/subscriptions","organizations_url":"https://api.github.com/users/EgorBo/orgs","repos_url":"https://api.github.com/users/EgorBo/repos","events_url":"https://api.github.com/users/EgorBo/events{/privacy}","received_events_url":"https://api.github.com/users/EgorBo/received_events","type":"User","site_admin":false},"repo":{"id":90860803,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDgwMw==","name":"mono","full_name":"EgorBo/mono","owner":{"login":"EgorBo","id":523221,"node_id":"MDQ6VXNlcjUyMzIyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/523221?v=4","gravatar_id":"","url":"https://api.github.com/users/EgorBo","html_url":"https://github.com/EgorBo","followers_url":"https://api.github.com/users/EgorBo/followers","following_url":"https://api.github.com/users/EgorBo/following{/other_user}","gists_url":"https://api.github.com/users/EgorBo/gists{/gist_id}","starred_url":"https://api.github.com/users/EgorBo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EgorBo/subscriptions","organizations_url":"https://api.github.com/users/EgorBo/orgs","repos_url":"https://api.github.com/users/EgorBo/repos","events_url":"https://api.github.com/users/EgorBo/events{/privacy}","received_events_url":"https://api.github.com/users/EgorBo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EgorBo/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/EgorBo/mono","forks_url":"https://api.github.com/repos/EgorBo/mono/forks","keys_url":"https://api.github.com/repos/EgorBo/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EgorBo/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EgorBo/mono/teams","hooks_url":"https://api.github.com/repos/EgorBo/mono/hooks","issue_events_url":"https://api.github.com/repos/EgorBo/mono/issues/events{/number}","events_url":"https://api.github.com/repos/EgorBo/mono/events","assignees_url":"https://api.github.com/repos/EgorBo/mono/assignees{/user}","branches_url":"https://api.github.com/repos/EgorBo/mono/branches{/branch}","tags_url":"https://api.github.com/repos/EgorBo/mono/tags","blobs_url":"https://api.github.com/repos/EgorBo/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EgorBo/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EgorBo/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/EgorBo/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EgorBo/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/EgorBo/mono/languages","stargazers_url":"https://api.github.com/repos/EgorBo/mono/stargazers","contributors_url":"https://api.github.com/repos/EgorBo/mono/contributors","subscribers_url":"https://api.github.com/repos/EgorBo/mono/subscribers","subscription_url":"https://api.github.com/repos/EgorBo/mono/subscription","commits_url":"https://api.github.com/repos/EgorBo/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/EgorBo/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/EgorBo/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/EgorBo/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/EgorBo/mono/contents/{+path}","compare_url":"https://api.github.com/repos/EgorBo/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EgorBo/mono/merges","archive_url":"https://api.github.com/repos/EgorBo/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EgorBo/mono/downloads","issues_url":"https://api.github.com/repos/EgorBo/mono/issues{/number}","pulls_url":"https://api.github.com/repos/EgorBo/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/EgorBo/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/EgorBo/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EgorBo/mono/labels{/name}","releases_url":"https://api.github.com/repos/EgorBo/mono/releases{/id}","deployments_url":"https://api.github.com/repos/EgorBo/mono/deployments","created_at":"2017-05-10T12:18:11Z","updated_at":"2018-07-16T12:38:28Z","pushed_at":"2018-08-13T17:42:24Z","git_url":"git://github.com/EgorBo/mono.git","ssh_url":"git@github.com:EgorBo/mono.git","clone_url":"https://github.com/EgorBo/mono.git","svn_url":"https://github.com/EgorBo/mono","homepage":"http://www.mono-project.com/","size":486313,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"3d4ba670f1fd81952596097054e2163a7d4167e0","user":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"node_id":"MDEwOlJlcG9zaXRvcnk3OTE2MTE=","name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2018-08-14T18:18:13Z","pushed_at":"2018-08-14T18:17:31Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":488921,"stargazers_count":6832,"watchers_count":6832,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2936,"mirror_url":null,"archived":false,"open_issues_count":862,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2936,"open_issues":862,"watchers":6832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/10033"},"html":{"href":"https://github.com/mono/mono/pull/10033"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/10033"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/10033/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/10033/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/10033/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/0ecdd37e186392efdb63e5568afa3f002ca24aef"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"EgorBo"}}