{"action":"created","issue":{"url":"https://api.github.com/repos/diesel-rs/diesel/issues/1576","repository_url":"https://api.github.com/repos/diesel-rs/diesel","labels_url":"https://api.github.com/repos/diesel-rs/diesel/issues/1576/labels{/name}","comments_url":"https://api.github.com/repos/diesel-rs/diesel/issues/1576/comments","events_url":"https://api.github.com/repos/diesel-rs/diesel/issues/1576/events","html_url":"https://github.com/diesel-rs/diesel/issues/1576","id":300422986,"number":1576,"title":"Document our policy for minimum supported Rust versions and when they can be bumped","user":{"login":"sgrif","id":1529387,"avatar_url":"https://avatars2.githubusercontent.com/u/1529387?v=4","gravatar_id":"","url":"https://api.github.com/users/sgrif","html_url":"https://github.com/sgrif","followers_url":"https://api.github.com/users/sgrif/followers","following_url":"https://api.github.com/users/sgrif/following{/other_user}","gists_url":"https://api.github.com/users/sgrif/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrif/subscriptions","organizations_url":"https://api.github.com/users/sgrif/orgs","repos_url":"https://api.github.com/users/sgrif/repos","events_url":"https://api.github.com/users/sgrif/events{/privacy}","received_events_url":"https://api.github.com/users/sgrif/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-26T22:36:13Z","updated_at":"2018-04-23T17:05:01Z","closed_at":null,"author_association":"OWNER","body":"This has been discussed internally some, but we should figure out the right place to document it. Last time we discussed it, we decided the following:\r\n\r\n- Bumping the minimum Rust version is not considered a major breaking change.\r\n- The minimum version should only be bumped if we have a good reason\r\n  - Convenience/cleaning up code is not a good reason\r\n\r\nI think we should also add to the policy that we will not bump the minimum Rust version in a patch version of Diesel.\r\n\r\n/cc @diesel-rs/core Does that sound about right?\r\n\r\nI think we should probably document this in two places. One for users, and one for contributors. For the user-facing docs, perhaps the top of the changelog is a good place to document it? Right after where we specify our semver policy, we could add: \"Increasing the minimum supported version of Rust is not considered a breaking change, but it will only be done in major or minor versions.\".\r\n\r\nFor contributors I think we need to say something like \"It is ok to increase the minimum supported version of Rust, but only if it is *required* to implement your feature. If it is possible to implement without relying on more recent features, you should do so\". I have no clue where we'd document that.\r\n\r\nWe should also probably figure out what our current minimum supported version is and add it to the test matrix (maybe only check that things compile, don't need another full run)"},"comment":{"url":"https://api.github.com/repos/diesel-rs/diesel/issues/comments/383649235","html_url":"https://github.com/diesel-rs/diesel/issues/1576#issuecomment-383649235","issue_url":"https://api.github.com/repos/diesel-rs/diesel/issues/1576","id":383649235,"user":{"login":"sgrif","id":1529387,"avatar_url":"https://avatars2.githubusercontent.com/u/1529387?v=4","gravatar_id":"","url":"https://api.github.com/users/sgrif","html_url":"https://github.com/sgrif","followers_url":"https://api.github.com/users/sgrif/followers","following_url":"https://api.github.com/users/sgrif/following{/other_user}","gists_url":"https://api.github.com/users/sgrif/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrif/subscriptions","organizations_url":"https://api.github.com/users/sgrif/orgs","repos_url":"https://api.github.com/users/sgrif/repos","events_url":"https://api.github.com/users/sgrif/events{/privacy}","received_events_url":"https://api.github.com/users/sgrif/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T17:05:01Z","updated_at":"2018-04-23T17:05:01Z","author_association":"OWNER","body":"That's an irrelevant error, the version of clippy we use is tied to a specific nightly, and isn't expected to work with other versions."}}
{"actor":{"display_login":"sgrif"}}