{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/comments/222773901","pull_request_review_id":161740244,"id":222773901,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjc3MzkwMQ==","diff_hunk":"@@ -226,20 +236,25 @@ def log.trace?\n         rescue KubeException => kube_error\n           raise Fluent::ConfigError, \"Invalid Kubernetes API #{@apiVersion} endpoint #{@kubernetes_url}: #{kube_error.message}\"\n         end\n+        if @checkpoint_enabled\n+          @checkpoint_thread_running = true","path":"lib/fluent/plugin/filter_kubernetes_metadata.rb","position":91,"original_position":91,"commit_id":"99096cd0935926d8a4c9e60193e30437e206249a","original_commit_id":"99096cd0935926d8a4c9e60193e30437e206249a","user":{"login":"jcantrill","id":4548408,"node_id":"MDQ6VXNlcjQ1NDg0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/4548408?v=4","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"body":"Shouldnt this come after the the thread initialization in the following lines? maybe need some sort of mutex to ensure it happens only once?","created_at":"2018-10-04T18:09:24Z","updated_at":"2018-10-04T18:10:30Z","html_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/157#discussion_r222773901","pull_request_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/157","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/comments/222773901"},"html":{"href":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/157#discussion_r222773901"},"pull_request":{"href":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/157"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/157","id":220295563,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMjk1NTYz","html_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/157","diff_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/157.diff","patch_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/157.patch","issue_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/157","number":157,"state":"open","locked":false,"title":"[WIP] Feature add checkpoint cache","user":{"login":"HackToHell","id":692171,"node_id":"MDQ6VXNlcjY5MjE3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/692171?v=4","gravatar_id":"","url":"https://api.github.com/users/HackToHell","html_url":"https://github.com/HackToHell","followers_url":"https://api.github.com/users/HackToHell/followers","following_url":"https://api.github.com/users/HackToHell/following{/other_user}","gists_url":"https://api.github.com/users/HackToHell/gists{/gist_id}","starred_url":"https://api.github.com/users/HackToHell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackToHell/subscriptions","organizations_url":"https://api.github.com/users/HackToHell/orgs","repos_url":"https://api.github.com/users/HackToHell/repos","events_url":"https://api.github.com/users/HackToHell/events{/privacy}","received_events_url":"https://api.github.com/users/HackToHell/received_events","type":"User","site_admin":false},"body":"Attempts to fix the problem detailed in #149,I have added in a sqlite db to persist the entries, with a checkpoint thread. \r\nUnit tests have to be added.","created_at":"2018-10-04T08:48:16Z","updated_at":"2018-10-04T18:10:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/157/commits","review_comments_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/157/comments","review_comment_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/157/comments","statuses_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/statuses/99096cd0935926d8a4c9e60193e30437e206249a","head":{"label":"HackToHell:feature/add_checkpoint_cache","ref":"feature/add_checkpoint_cache","sha":"99096cd0935926d8a4c9e60193e30437e206249a","user":{"login":"HackToHell","id":692171,"node_id":"MDQ6VXNlcjY5MjE3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/692171?v=4","gravatar_id":"","url":"https://api.github.com/users/HackToHell","html_url":"https://github.com/HackToHell","followers_url":"https://api.github.com/users/HackToHell/followers","following_url":"https://api.github.com/users/HackToHell/following{/other_user}","gists_url":"https://api.github.com/users/HackToHell/gists{/gist_id}","starred_url":"https://api.github.com/users/HackToHell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackToHell/subscriptions","organizations_url":"https://api.github.com/users/HackToHell/orgs","repos_url":"https://api.github.com/users/HackToHell/repos","events_url":"https://api.github.com/users/HackToHell/events{/privacy}","received_events_url":"https://api.github.com/users/HackToHell/received_events","type":"User","site_admin":false},"repo":{"id":150130942,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMzA5NDI=","name":"fluent-plugin-kubernetes_metadata_filter","full_name":"HackToHell/fluent-plugin-kubernetes_metadata_filter","private":false,"owner":{"login":"HackToHell","id":692171,"node_id":"MDQ6VXNlcjY5MjE3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/692171?v=4","gravatar_id":"","url":"https://api.github.com/users/HackToHell","html_url":"https://github.com/HackToHell","followers_url":"https://api.github.com/users/HackToHell/followers","following_url":"https://api.github.com/users/HackToHell/following{/other_user}","gists_url":"https://api.github.com/users/HackToHell/gists{/gist_id}","starred_url":"https://api.github.com/users/HackToHell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackToHell/subscriptions","organizations_url":"https://api.github.com/users/HackToHell/orgs","repos_url":"https://api.github.com/users/HackToHell/repos","events_url":"https://api.github.com/users/HackToHell/events{/privacy}","received_events_url":"https://api.github.com/users/HackToHell/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HackToHell/fluent-plugin-kubernetes_metadata_filter","description":"Enrich your fluentd events with Kubernetes metadata","fork":true,"url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter","forks_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/forks","keys_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/teams","hooks_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/hooks","issue_events_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/issues/events{/number}","events_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/events","assignees_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/assignees{/user}","branches_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/branches{/branch}","tags_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/tags","blobs_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/statuses/{sha}","languages_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/languages","stargazers_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/stargazers","contributors_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/contributors","subscribers_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/subscribers","subscription_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/subscription","commits_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/contents/{+path}","compare_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/merges","archive_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/downloads","issues_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/issues{/number}","pulls_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/pulls{/number}","milestones_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/milestones{/number}","notifications_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/labels{/name}","releases_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/releases{/id}","deployments_url":"https://api.github.com/repos/HackToHell/fluent-plugin-kubernetes_metadata_filter/deployments","created_at":"2018-09-24T16:09:22Z","updated_at":"2018-09-24T16:09:24Z","pushed_at":"2018-10-04T08:46:53Z","git_url":"git://github.com/HackToHell/fluent-plugin-kubernetes_metadata_filter.git","ssh_url":"git@github.com:HackToHell/fluent-plugin-kubernetes_metadata_filter.git","clone_url":"https://github.com/HackToHell/fluent-plugin-kubernetes_metadata_filter.git","svn_url":"https://github.com/HackToHell/fluent-plugin-kubernetes_metadata_filter","homepage":"","size":239,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8io:v0.12","ref":"v0.12","sha":"2da318a03d8c3d9d9d5c6841b4ac8c0ff97f57f3","user":{"login":"fabric8io","id":6074349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzQzNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6074349?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"repo":{"id":35276845,"node_id":"MDEwOlJlcG9zaXRvcnkzNTI3Njg0NQ==","name":"fluent-plugin-kubernetes_metadata_filter","full_name":"fabric8io/fluent-plugin-kubernetes_metadata_filter","private":false,"owner":{"login":"fabric8io","id":6074349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzQzNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6074349?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter","description":"Enrich your fluentd events with Kubernetes metadata","fork":false,"url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter","forks_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/forks","keys_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/teams","hooks_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/hooks","issue_events_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/events","assignees_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/tags","blobs_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/languages","stargazers_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/stargazers","contributors_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/contributors","subscribers_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/subscribers","subscription_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/subscription","commits_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/merges","archive_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/downloads","issues_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/deployments","created_at":"2015-05-08T11:56:38Z","updated_at":"2018-10-02T17:49:15Z","pushed_at":"2018-10-04T08:48:17Z","git_url":"git://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter.git","ssh_url":"git@github.com:fabric8io/fluent-plugin-kubernetes_metadata_filter.git","clone_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter.git","svn_url":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter","homepage":"","size":252,"stargazers_count":151,"watchers_count":151,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":83,"open_issues":22,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/157"},"html":{"href":"https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/157"},"issue":{"href":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/157"},"comments":{"href":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8io/fluent-plugin-kubernetes_metadata_filter/statuses/99096cd0935926d8a4c9e60193e30437e206249a"}},"author_association":"NONE"}}
{"actor":{"display_login":"jcantrill"}}