{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/comments/178278303","pull_request_review_id":108316692,"id":178278303,"diff_hunk":"@@ -263,7 +272,6 @@ void cmd_init(cmd_print_t *outf)\n         ns_list_init(&cmd.cmd_buffer);\n         cmd.init = true;\n     }\n-    mbed_trace_exclude_filters_set(TRACE_GROUP);","path":"source/ns_cmdline.c","position":50,"original_position":35,"commit_id":"adbbe2cdc66343f0d107f666352f26b2b879ebae","original_commit_id":"e766b46d4c486a9ef9b3cbae75974aee14b6c2a0","user":{"login":"jupe","id":3822425,"avatar_url":"https://avatars1.githubusercontent.com/u/3822425?v=4","gravatar_id":"","url":"https://api.github.com/users/jupe","html_url":"https://github.com/jupe","followers_url":"https://api.github.com/users/jupe/followers","following_url":"https://api.github.com/users/jupe/following{/other_user}","gists_url":"https://api.github.com/users/jupe/gists{/gist_id}","starred_url":"https://api.github.com/users/jupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupe/subscriptions","organizations_url":"https://api.github.com/users/jupe/orgs","repos_url":"https://api.github.com/users/jupe/repos","events_url":"https://api.github.com/users/jupe/events{/privacy}","received_events_url":"https://api.github.com/users/jupe/received_events","type":"User","site_admin":false},"body":"this is a bit problematic from client point of view because client supports multiple OS and mbed-OS is just one of them. As long as mbed-trace is only one which support all of client used OS’s they probably wont use anything else, unless there is very good reason for it.","created_at":"2018-03-30T11:52:30Z","updated_at":"2018-03-30T11:52:30Z","html_url":"https://github.com/ARMmbed/mbed-client-cli/pull/68#discussion_r178278303","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/68","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/comments/178278303"},"html":{"href":"https://github.com/ARMmbed/mbed-client-cli/pull/68#discussion_r178278303"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/68"}},"in_reply_to_id":178137738},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/68","id":178140621,"html_url":"https://github.com/ARMmbed/mbed-client-cli/pull/68","diff_url":"https://github.com/ARMmbed/mbed-client-cli/pull/68.diff","patch_url":"https://github.com/ARMmbed/mbed-client-cli/pull/68.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/68","number":68,"state":"open","locked":false,"title":"Update CLI to be comptabile with mbed-os logging","user":{"login":"deepikabhavnani","id":28542450,"avatar_url":"https://avatars3.githubusercontent.com/u/28542450?v=4","gravatar_id":"","url":"https://api.github.com/users/deepikabhavnani","html_url":"https://github.com/deepikabhavnani","followers_url":"https://api.github.com/users/deepikabhavnani/followers","following_url":"https://api.github.com/users/deepikabhavnani/following{/other_user}","gists_url":"https://api.github.com/users/deepikabhavnani/gists{/gist_id}","starred_url":"https://api.github.com/users/deepikabhavnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepikabhavnani/subscriptions","organizations_url":"https://api.github.com/users/deepikabhavnani/orgs","repos_url":"https://api.github.com/users/deepikabhavnani/repos","events_url":"https://api.github.com/users/deepikabhavnani/events{/privacy}","received_events_url":"https://api.github.com/users/deepikabhavnani/received_events","type":"User","site_admin":false},"body":"Unified logging in mbed-os provides logging API;s compatible with mbed_trace library. But features like filtering is not supported in similar manner as runtime option.\r\n\r\nChanges in this PR are to disable trace logging at compile time, which was earlier done runtime at https://github.com/ARMmbed/mbed-client-cli/blob/master/source/ns_cmdline.c#L266\r\n\r\nThis fix is required for CI success in https://github.com/ARMmbed/mbed-os/pull/5965 \r\n\r\nCC @sg- @SenRamakri @SeppoTakalo ","created_at":"2018-03-28T19:33:53Z","updated_at":"2018-03-30T11:52:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2492da3990670bc42c59189ac4ce49b9b8d595d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SeppoTakalo","id":3104794,"avatar_url":"https://avatars0.githubusercontent.com/u/3104794?v=4","gravatar_id":"","url":"https://api.github.com/users/SeppoTakalo","html_url":"https://github.com/SeppoTakalo","followers_url":"https://api.github.com/users/SeppoTakalo/followers","following_url":"https://api.github.com/users/SeppoTakalo/following{/other_user}","gists_url":"https://api.github.com/users/SeppoTakalo/gists{/gist_id}","starred_url":"https://api.github.com/users/SeppoTakalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeppoTakalo/subscriptions","organizations_url":"https://api.github.com/users/SeppoTakalo/orgs","repos_url":"https://api.github.com/users/SeppoTakalo/repos","events_url":"https://api.github.com/users/SeppoTakalo/events{/privacy}","received_events_url":"https://api.github.com/users/SeppoTakalo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/68/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/68/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/68/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/statuses/adbbe2cdc66343f0d107f666352f26b2b879ebae","head":{"label":"deepikabhavnani:logging_support","ref":"logging_support","sha":"adbbe2cdc66343f0d107f666352f26b2b879ebae","user":{"login":"deepikabhavnani","id":28542450,"avatar_url":"https://avatars3.githubusercontent.com/u/28542450?v=4","gravatar_id":"","url":"https://api.github.com/users/deepikabhavnani","html_url":"https://github.com/deepikabhavnani","followers_url":"https://api.github.com/users/deepikabhavnani/followers","following_url":"https://api.github.com/users/deepikabhavnani/following{/other_user}","gists_url":"https://api.github.com/users/deepikabhavnani/gists{/gist_id}","starred_url":"https://api.github.com/users/deepikabhavnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepikabhavnani/subscriptions","organizations_url":"https://api.github.com/users/deepikabhavnani/orgs","repos_url":"https://api.github.com/users/deepikabhavnani/repos","events_url":"https://api.github.com/users/deepikabhavnani/events{/privacy}","received_events_url":"https://api.github.com/users/deepikabhavnani/received_events","type":"User","site_admin":false},"repo":{"id":127187979,"name":"mbed-client-cli","full_name":"deepikabhavnani/mbed-client-cli","owner":{"login":"deepikabhavnani","id":28542450,"avatar_url":"https://avatars3.githubusercontent.com/u/28542450?v=4","gravatar_id":"","url":"https://api.github.com/users/deepikabhavnani","html_url":"https://github.com/deepikabhavnani","followers_url":"https://api.github.com/users/deepikabhavnani/followers","following_url":"https://api.github.com/users/deepikabhavnani/following{/other_user}","gists_url":"https://api.github.com/users/deepikabhavnani/gists{/gist_id}","starred_url":"https://api.github.com/users/deepikabhavnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepikabhavnani/subscriptions","organizations_url":"https://api.github.com/users/deepikabhavnani/orgs","repos_url":"https://api.github.com/users/deepikabhavnani/repos","events_url":"https://api.github.com/users/deepikabhavnani/events{/privacy}","received_events_url":"https://api.github.com/users/deepikabhavnani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deepikabhavnani/mbed-client-cli","description":"Command Line Interface library for device","fork":true,"url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli","forks_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/forks","keys_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/teams","hooks_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/hooks","issue_events_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/issues/events{/number}","events_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/events","assignees_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/assignees{/user}","branches_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/branches{/branch}","tags_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/tags","blobs_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/languages","stargazers_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/stargazers","contributors_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/contributors","subscribers_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/subscribers","subscription_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/subscription","commits_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/contents/{+path}","compare_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/merges","archive_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/downloads","issues_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/issues{/number}","pulls_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/labels{/name}","releases_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/releases{/id}","deployments_url":"https://api.github.com/repos/deepikabhavnani/mbed-client-cli/deployments","created_at":"2018-03-28T19:25:58Z","updated_at":"2018-03-29T15:13:59Z","pushed_at":"2018-03-29T20:39:52Z","git_url":"git://github.com/deepikabhavnani/mbed-client-cli.git","ssh_url":"git@github.com:deepikabhavnani/mbed-client-cli.git","clone_url":"https://github.com/deepikabhavnani/mbed-client-cli.git","svn_url":"https://github.com/deepikabhavnani/mbed-client-cli","homepage":"","size":174,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"18018aaaa98b22d06f64e1704419e53f3b5f63e0","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":41283271,"name":"mbed-client-cli","full_name":"ARMmbed/mbed-client-cli","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-client-cli","description":"Command Line Interface library for device","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-client-cli","forks_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-client-cli/deployments","created_at":"2015-08-24T05:10:00Z","updated_at":"2018-03-29T17:58:07Z","pushed_at":"2018-03-29T20:39:53Z","git_url":"git://github.com/ARMmbed/mbed-client-cli.git","ssh_url":"git@github.com:ARMmbed/mbed-client-cli.git","clone_url":"https://github.com/ARMmbed/mbed-client-cli.git","svn_url":"https://github.com/ARMmbed/mbed-client-cli","homepage":"","size":172,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/68"},"html":{"href":"https://github.com/ARMmbed/mbed-client-cli/pull/68"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/68"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-cli/statuses/adbbe2cdc66343f0d107f666352f26b2b879ebae"}},"author_association":"NONE"}}
{"actor":{"display_login":"jupe"}}