{"action":"created","comment":{"url":"https://api.github.com/repos/xiph/rav1e/pulls/comments/168705920","pull_request_review_id":97117669,"id":168705920,"diff_hunk":"@@ -24,3 +24,13 @@ bencher = \"0.1.5\"\n [[bench]]\n name = \"bench\"\n harness = false\n+\n+[profile.release]\n+codegen-units = 1  # if > 1 enables parallel code generation which improves\n+                   # compile times, but prevents some optimizations.\n+                   # Passes `-C codegen-units`. Ignored when `lto = true`.\n+[profile.test]\n+codegen-units = 1","path":"Cargo.toml","position":10,"original_position":10,"commit_id":"c0bfc1f94a0261bb3e6df70196aba04adf998623","original_commit_id":"c0bfc1f94a0261bb3e6df70196aba04adf998623","user":{"login":"Ryman","id":994978,"avatar_url":"https://avatars2.githubusercontent.com/u/994978?v=4","gravatar_id":"","url":"https://api.github.com/users/Ryman","html_url":"https://github.com/Ryman","followers_url":"https://api.github.com/users/Ryman/followers","following_url":"https://api.github.com/users/Ryman/following{/other_user}","gists_url":"https://api.github.com/users/Ryman/gists{/gist_id}","starred_url":"https://api.github.com/users/Ryman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ryman/subscriptions","organizations_url":"https://api.github.com/users/Ryman/orgs","repos_url":"https://api.github.com/users/Ryman/repos","events_url":"https://api.github.com/users/Ryman/events{/privacy}","received_events_url":"https://api.github.com/users/Ryman/received_events","type":"User","site_admin":false},"body":"Does the test profile need to be optimized as much?","created_at":"2018-02-16T09:21:57Z","updated_at":"2018-02-16T09:21:57Z","html_url":"https://github.com/xiph/rav1e/pull/86#discussion_r168705920","pull_request_url":"https://api.github.com/repos/xiph/rav1e/pulls/86","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/comments/168705920"},"html":{"href":"https://github.com/xiph/rav1e/pull/86#discussion_r168705920"},"pull_request":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/xiph/rav1e/pulls/86","id":169561531,"html_url":"https://github.com/xiph/rav1e/pull/86","diff_url":"https://github.com/xiph/rav1e/pull/86.diff","patch_url":"https://github.com/xiph/rav1e/pull/86.patch","issue_url":"https://api.github.com/repos/xiph/rav1e/issues/86","number":86,"state":"open","locked":false,"title":"Set codegen-units = 1","user":{"login":"ycho","id":10123259,"avatar_url":"https://avatars3.githubusercontent.com/u/10123259?v=4","gravatar_id":"","url":"https://api.github.com/users/ycho","html_url":"https://github.com/ycho","followers_url":"https://api.github.com/users/ycho/followers","following_url":"https://api.github.com/users/ycho/following{/other_user}","gists_url":"https://api.github.com/users/ycho/gists{/gist_id}","starred_url":"https://api.github.com/users/ycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycho/subscriptions","organizations_url":"https://api.github.com/users/ycho/orgs","repos_url":"https://api.github.com/users/ycho/repos","events_url":"https://api.github.com/users/ycho/events{/privacy}","received_events_url":"https://api.github.com/users/ycho/received_events","type":"User","site_admin":false},"body":"So that upgraded rustc 1.25.0 version does not slow down\r\nthe release/test/bench binary by setting the default value of\r\ncodegen-units = 16.","created_at":"2018-02-16T07:24:08Z","updated_at":"2018-02-16T09:21:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"675f456aeb257ffedba292938323b19c28c35a66","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xiph/rav1e/pulls/86/commits","review_comments_url":"https://api.github.com/repos/xiph/rav1e/pulls/86/comments","review_comment_url":"https://api.github.com/repos/xiph/rav1e/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xiph/rav1e/issues/86/comments","statuses_url":"https://api.github.com/repos/xiph/rav1e/statuses/c0bfc1f94a0261bb3e6df70196aba04adf998623","head":{"label":"ycho:codegen-units1","ref":"codegen-units1","sha":"c0bfc1f94a0261bb3e6df70196aba04adf998623","user":{"login":"ycho","id":10123259,"avatar_url":"https://avatars3.githubusercontent.com/u/10123259?v=4","gravatar_id":"","url":"https://api.github.com/users/ycho","html_url":"https://github.com/ycho","followers_url":"https://api.github.com/users/ycho/followers","following_url":"https://api.github.com/users/ycho/following{/other_user}","gists_url":"https://api.github.com/users/ycho/gists{/gist_id}","starred_url":"https://api.github.com/users/ycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycho/subscriptions","organizations_url":"https://api.github.com/users/ycho/orgs","repos_url":"https://api.github.com/users/ycho/repos","events_url":"https://api.github.com/users/ycho/events{/privacy}","received_events_url":"https://api.github.com/users/ycho/received_events","type":"User","site_admin":false},"repo":{"id":121545598,"name":"rav1e","full_name":"ycho/rav1e","owner":{"login":"ycho","id":10123259,"avatar_url":"https://avatars3.githubusercontent.com/u/10123259?v=4","gravatar_id":"","url":"https://api.github.com/users/ycho","html_url":"https://github.com/ycho","followers_url":"https://api.github.com/users/ycho/followers","following_url":"https://api.github.com/users/ycho/following{/other_user}","gists_url":"https://api.github.com/users/ycho/gists{/gist_id}","starred_url":"https://api.github.com/users/ycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycho/subscriptions","organizations_url":"https://api.github.com/users/ycho/orgs","repos_url":"https://api.github.com/users/ycho/repos","events_url":"https://api.github.com/users/ycho/events{/privacy}","received_events_url":"https://api.github.com/users/ycho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ycho/rav1e","description":"The fastest and safest AV1 encoder.","fork":true,"url":"https://api.github.com/repos/ycho/rav1e","forks_url":"https://api.github.com/repos/ycho/rav1e/forks","keys_url":"https://api.github.com/repos/ycho/rav1e/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ycho/rav1e/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ycho/rav1e/teams","hooks_url":"https://api.github.com/repos/ycho/rav1e/hooks","issue_events_url":"https://api.github.com/repos/ycho/rav1e/issues/events{/number}","events_url":"https://api.github.com/repos/ycho/rav1e/events","assignees_url":"https://api.github.com/repos/ycho/rav1e/assignees{/user}","branches_url":"https://api.github.com/repos/ycho/rav1e/branches{/branch}","tags_url":"https://api.github.com/repos/ycho/rav1e/tags","blobs_url":"https://api.github.com/repos/ycho/rav1e/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ycho/rav1e/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ycho/rav1e/git/refs{/sha}","trees_url":"https://api.github.com/repos/ycho/rav1e/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ycho/rav1e/statuses/{sha}","languages_url":"https://api.github.com/repos/ycho/rav1e/languages","stargazers_url":"https://api.github.com/repos/ycho/rav1e/stargazers","contributors_url":"https://api.github.com/repos/ycho/rav1e/contributors","subscribers_url":"https://api.github.com/repos/ycho/rav1e/subscribers","subscription_url":"https://api.github.com/repos/ycho/rav1e/subscription","commits_url":"https://api.github.com/repos/ycho/rav1e/commits{/sha}","git_commits_url":"https://api.github.com/repos/ycho/rav1e/git/commits{/sha}","comments_url":"https://api.github.com/repos/ycho/rav1e/comments{/number}","issue_comment_url":"https://api.github.com/repos/ycho/rav1e/issues/comments{/number}","contents_url":"https://api.github.com/repos/ycho/rav1e/contents/{+path}","compare_url":"https://api.github.com/repos/ycho/rav1e/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ycho/rav1e/merges","archive_url":"https://api.github.com/repos/ycho/rav1e/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ycho/rav1e/downloads","issues_url":"https://api.github.com/repos/ycho/rav1e/issues{/number}","pulls_url":"https://api.github.com/repos/ycho/rav1e/pulls{/number}","milestones_url":"https://api.github.com/repos/ycho/rav1e/milestones{/number}","notifications_url":"https://api.github.com/repos/ycho/rav1e/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ycho/rav1e/labels{/name}","releases_url":"https://api.github.com/repos/ycho/rav1e/releases{/id}","deployments_url":"https://api.github.com/repos/ycho/rav1e/deployments","created_at":"2018-02-14T18:26:19Z","updated_at":"2018-02-14T18:26:21Z","pushed_at":"2018-02-16T07:23:50Z","git_url":"git://github.com/ycho/rav1e.git","ssh_url":"git@github.com:ycho/rav1e.git","clone_url":"https://github.com/ycho/rav1e.git","svn_url":"https://github.com/ycho/rav1e","homepage":"","size":654,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xiph:master","ref":"master","sha":"79ecb110521fe08178ef8bc7dd35a30d90401c9f","user":{"login":"xiph","id":8365509,"avatar_url":"https://avatars1.githubusercontent.com/u/8365509?v=4","gravatar_id":"","url":"https://api.github.com/users/xiph","html_url":"https://github.com/xiph","followers_url":"https://api.github.com/users/xiph/followers","following_url":"https://api.github.com/users/xiph/following{/other_user}","gists_url":"https://api.github.com/users/xiph/gists{/gist_id}","starred_url":"https://api.github.com/users/xiph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiph/subscriptions","organizations_url":"https://api.github.com/users/xiph/orgs","repos_url":"https://api.github.com/users/xiph/repos","events_url":"https://api.github.com/users/xiph/events{/privacy}","received_events_url":"https://api.github.com/users/xiph/received_events","type":"Organization","site_admin":false},"repo":{"id":104629023,"name":"rav1e","full_name":"xiph/rav1e","owner":{"login":"xiph","id":8365509,"avatar_url":"https://avatars1.githubusercontent.com/u/8365509?v=4","gravatar_id":"","url":"https://api.github.com/users/xiph","html_url":"https://github.com/xiph","followers_url":"https://api.github.com/users/xiph/followers","following_url":"https://api.github.com/users/xiph/following{/other_user}","gists_url":"https://api.github.com/users/xiph/gists{/gist_id}","starred_url":"https://api.github.com/users/xiph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiph/subscriptions","organizations_url":"https://api.github.com/users/xiph/orgs","repos_url":"https://api.github.com/users/xiph/repos","events_url":"https://api.github.com/users/xiph/events{/privacy}","received_events_url":"https://api.github.com/users/xiph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xiph/rav1e","description":"The fastest and safest AV1 encoder.","fork":false,"url":"https://api.github.com/repos/xiph/rav1e","forks_url":"https://api.github.com/repos/xiph/rav1e/forks","keys_url":"https://api.github.com/repos/xiph/rav1e/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiph/rav1e/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiph/rav1e/teams","hooks_url":"https://api.github.com/repos/xiph/rav1e/hooks","issue_events_url":"https://api.github.com/repos/xiph/rav1e/issues/events{/number}","events_url":"https://api.github.com/repos/xiph/rav1e/events","assignees_url":"https://api.github.com/repos/xiph/rav1e/assignees{/user}","branches_url":"https://api.github.com/repos/xiph/rav1e/branches{/branch}","tags_url":"https://api.github.com/repos/xiph/rav1e/tags","blobs_url":"https://api.github.com/repos/xiph/rav1e/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiph/rav1e/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiph/rav1e/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiph/rav1e/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiph/rav1e/statuses/{sha}","languages_url":"https://api.github.com/repos/xiph/rav1e/languages","stargazers_url":"https://api.github.com/repos/xiph/rav1e/stargazers","contributors_url":"https://api.github.com/repos/xiph/rav1e/contributors","subscribers_url":"https://api.github.com/repos/xiph/rav1e/subscribers","subscription_url":"https://api.github.com/repos/xiph/rav1e/subscription","commits_url":"https://api.github.com/repos/xiph/rav1e/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiph/rav1e/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiph/rav1e/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiph/rav1e/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiph/rav1e/contents/{+path}","compare_url":"https://api.github.com/repos/xiph/rav1e/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiph/rav1e/merges","archive_url":"https://api.github.com/repos/xiph/rav1e/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiph/rav1e/downloads","issues_url":"https://api.github.com/repos/xiph/rav1e/issues{/number}","pulls_url":"https://api.github.com/repos/xiph/rav1e/pulls{/number}","milestones_url":"https://api.github.com/repos/xiph/rav1e/milestones{/number}","notifications_url":"https://api.github.com/repos/xiph/rav1e/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiph/rav1e/labels{/name}","releases_url":"https://api.github.com/repos/xiph/rav1e/releases{/id}","deployments_url":"https://api.github.com/repos/xiph/rav1e/deployments","created_at":"2017-09-24T08:12:55Z","updated_at":"2018-02-16T01:02:07Z","pushed_at":"2018-02-16T07:24:08Z","git_url":"git://github.com/xiph/rav1e.git","ssh_url":"git@github.com:xiph/rav1e.git","clone_url":"https://github.com/xiph/rav1e.git","svn_url":"https://github.com/xiph/rav1e","homepage":"","size":651,"stargazers_count":25,"watchers_count":25,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":10,"open_issues":16,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/86"},"html":{"href":"https://github.com/xiph/rav1e/pull/86"},"issue":{"href":"https://api.github.com/repos/xiph/rav1e/issues/86"},"comments":{"href":"https://api.github.com/repos/xiph/rav1e/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xiph/rav1e/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/xiph/rav1e/statuses/c0bfc1f94a0261bb3e6df70196aba04adf998623"}},"author_association":"NONE"}}
{"actor":{"display_login":"Ryman"}}