{"push_id":3065407424,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"a2a5793e1324f97e495ccb835a8fd5003354ec29","before":"7651b857822b2f47750c4ecce066472024e20f8e","commits":[{"sha":"362464463015fa4e6690e5733fa3ee0be11fa32f","author":{"name":"Alexandru Croitor","email":"06a42fcfadebc7a6b981a45ec78f1c34d1f98890@gmail.com"},"message":"Pass -isysroot to compiler / linker when doing a macOS build\n\nPreviously the compiler would use system headers located at\n/System/Library/Frameworks, which could result in compilation failures\ndue to the headers not always being up-to-date in regards to the\nlatest installed macOS SDK headers that come with Xcode.\n\nFix the issue by passing the SDK path via the -isysroot option to the\ncompiler and linker invocations.\n\nIf no custom SDK path is given, the build system queries the SDK path\nvia xcrun --show-sdk-path, which returns something similar to\n\n/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/\n /Developer/SDKs/MacOSX.sdk/\n\nQuerying via xcrun is now also done for iphone (and simulator)\nplatforms as well.\n\nHere is an example of a compilation failure message due to outdated\nheaders:\n\nplatform/osx/os_osx.mm:1421:41: error: use of undeclared identifier 'NSAppKitVersionNumber10_12'; did you mean 'NSAppKitVersionNumber'?\n                                if (floor(NSAppKitVersionNumber) >= NSAppKitVersionNumber10_12) {\n                                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~\n                                                                    NSAppKitVersionNumber\n/System/Library/Frameworks/AppKit.framework/Headers/NSApplication.h:26:28: note: 'NSAppKitVersionNumber' declared here","distinct":true,"url":"https://api.github.com/repos/godotengine/godot/commits/362464463015fa4e6690e5733fa3ee0be11fa32f"},{"sha":"a2a5793e1324f97e495ccb835a8fd5003354ec29","author":{"name":"Rémi Verschelde","email":"4a7fb8776e4352f674590468e6fa4ef4f32789c1@gmail.com"},"message":"Merge pull request #21339 from Placinta/master\n\nFix regular macOS build by passing -isysroot to compiler so correct system headers are found","distinct":true,"url":"https://api.github.com/repos/godotengine/godot/commits/a2a5793e1324f97e495ccb835a8fd5003354ec29"}]}
{"actor":{"display_login":"akien-mga"}}