{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/229905307","pull_request_review_id":170516773,"id":229905307,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTkwNTMwNw==","diff_hunk":"@@ -180,12 +194,23 @@ def __new__(cls, data=None, unit=None, freq=None, start=None, end=None,\n         return subarr\n \n     @classmethod\n-    def _simple_new(cls, values, name=None, freq=None, **kwargs):\n-        result = super(TimedeltaIndex, cls)._simple_new(values, freq, **kwargs)\n+    def _simple_new(cls, values, name=None, freq=None, dtype=_TD_DTYPE):\n+        # `dtype` is passed by _shallow_copy in corner cases, should always\n+        #  be timedelta64[ns] if present\n+        assert dtype == _TD_DTYPE\n+\n+        assert isinstance(values, np.ndarray), type(values)\n+        if values.dtype == 'i8':\n+            values = values.view('m8[ns]')\n+        assert values.dtype == 'm8[ns]', values.dtype\n+\n+        result = super(TimedeltaIndex, cls)._simple_new(values, freq)\n         result.name = name\n         result._reset_identity()\n         return result\n \n+    _shallow_copy = Index._shallow_copy","path":"pandas/core/indexes/timedeltas.py","position":49,"original_position":49,"commit_id":"5edf59a2aa6cce0b450b2830eb360b0c49152931","original_commit_id":"5edf59a2aa6cce0b450b2830eb360b0c49152931","user":{"login":"jreback","id":953992,"node_id":"MDQ6VXNlcjk1Mzk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"why is this needed?","created_at":"2018-10-31T23:59:30Z","updated_at":"2018-10-31T23:59:59Z","html_url":"https://github.com/pandas-dev/pandas/pull/23433#discussion_r229905307","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23433","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/229905307"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23433#discussion_r229905307"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23433"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23433","id":227417018,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDE3MDE4","html_url":"https://github.com/pandas-dev/pandas/pull/23433","diff_url":"https://github.com/pandas-dev/pandas/pull/23433.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/23433.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23433","number":23433,"state":"open","locked":false,"title":"REF: strictness and checks for Timedelta _simple_new","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"body":"Broken off from #23426.\r\n\r\n- [x] closes #9462\r\n- [ ] tests added / passed\r\n- [ ] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry\r\n","created_at":"2018-10-31T19:38:17Z","updated_at":"2018-10-31T23:59:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c75af17cbf394ed7a8b808f3a126dd40a63f6a3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":31404521,"node_id":"MDU6TGFiZWwzMTQwNDUyMQ==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Dtypes","name":"Dtypes","color":"e102d8","default":false},{"id":49094459,"node_id":"MDU6TGFiZWw0OTA5NDQ1OQ==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Internals","name":"Internals","color":"fbca04","default":false},{"id":49597148,"node_id":"MDU6TGFiZWw0OTU5NzE0OA==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Timedelta","name":"Timedelta","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23433/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/23433/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/23433/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/5edf59a2aa6cce0b450b2830eb360b0c49152931","head":{"label":"jbrockmendel:simple4","ref":"simple4","sha":"5edf59a2aa6cce0b450b2830eb360b0c49152931","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"repo":{"id":96820953,"node_id":"MDEwOlJlcG9zaXRvcnk5NjgyMDk1Mw==","name":"pandas","full_name":"jbrockmendel/pandas","private":false,"owner":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jbrockmendel/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/jbrockmendel/pandas","forks_url":"https://api.github.com/repos/jbrockmendel/pandas/forks","keys_url":"https://api.github.com/repos/jbrockmendel/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbrockmendel/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbrockmendel/pandas/teams","hooks_url":"https://api.github.com/repos/jbrockmendel/pandas/hooks","issue_events_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/jbrockmendel/pandas/events","assignees_url":"https://api.github.com/repos/jbrockmendel/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/jbrockmendel/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/jbrockmendel/pandas/tags","blobs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbrockmendel/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbrockmendel/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbrockmendel/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/jbrockmendel/pandas/languages","stargazers_url":"https://api.github.com/repos/jbrockmendel/pandas/stargazers","contributors_url":"https://api.github.com/repos/jbrockmendel/pandas/contributors","subscribers_url":"https://api.github.com/repos/jbrockmendel/pandas/subscribers","subscription_url":"https://api.github.com/repos/jbrockmendel/pandas/subscription","commits_url":"https://api.github.com/repos/jbrockmendel/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbrockmendel/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbrockmendel/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbrockmendel/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/jbrockmendel/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbrockmendel/pandas/merges","archive_url":"https://api.github.com/repos/jbrockmendel/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbrockmendel/pandas/downloads","issues_url":"https://api.github.com/repos/jbrockmendel/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/jbrockmendel/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/jbrockmendel/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/jbrockmendel/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbrockmendel/pandas/labels{/name}","releases_url":"https://api.github.com/repos/jbrockmendel/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/jbrockmendel/pandas/deployments","created_at":"2017-07-10T21:01:07Z","updated_at":"2017-07-10T21:01:15Z","pushed_at":"2018-10-31T19:39:05Z","git_url":"git://github.com/jbrockmendel/pandas.git","ssh_url":"git@github.com:jbrockmendel/pandas.git","clone_url":"https://github.com/jbrockmendel/pandas.git","svn_url":"https://github.com/jbrockmendel/pandas","homepage":"http://pandas.pydata.org","size":133452,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"de39bfc5e5c6483cb2669773fa10ddc2e32ca111","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-10-31T23:55:54Z","pushed_at":"2018-10-31T23:54:48Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":133450,"stargazers_count":16641,"watchers_count":16641,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6741,"mirror_url":null,"archived":false,"open_issues_count":2900,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6741,"open_issues":2900,"watchers":16641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23433"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/23433"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23433"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/23433/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23433/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/23433/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/5edf59a2aa6cce0b450b2830eb360b0c49152931"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jreback"}}