{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/173538375","pull_request_review_id":102753504,"id":173538375,"diff_hunk":"@@ -178,6 +171,39 @@ func (k *KubeInfo) Setup() error {\n \treturn nil\n }\n \n+// IngressOrFail lazily initialize ingress and fail test if not found.\n+func (k *KubeInfo) IngressOrFail(t *testing.T) string {\n+\tgw, err := k.Ingress()\n+\tif err != nil {\n+\t\tt.Fatalf(\"Unable to get ingress: %v\", err)","path":"tests/e2e/framework/kubernetes.go","position":46,"original_position":46,"commit_id":"519e2caa686398d51d0c8a210cfa1f8ab8f3f596","original_commit_id":"519e2caa686398d51d0c8a210cfa1f8ab8f3f596","user":{"login":"ldemailly","id":3664595,"avatar_url":"https://avatars2.githubusercontent.com/u/3664595?v=4","gravatar_id":"","url":"https://api.github.com/users/ldemailly","html_url":"https://github.com/ldemailly","followers_url":"https://api.github.com/users/ldemailly/followers","following_url":"https://api.github.com/users/ldemailly/following{/other_user}","gists_url":"https://api.github.com/users/ldemailly/gists{/gist_id}","starred_url":"https://api.github.com/users/ldemailly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldemailly/subscriptions","organizations_url":"https://api.github.com/users/ldemailly/orgs","repos_url":"https://api.github.com/users/ldemailly/repos","events_url":"https://api.github.com/users/ldemailly/events{/privacy}","received_events_url":"https://api.github.com/users/ldemailly/received_events","type":"User","site_admin":false},"body":"does it dump the ingress logs and/or pod status when that happens?","created_at":"2018-03-09T19:02:41Z","updated_at":"2018-03-09T19:02:41Z","html_url":"https://github.com/istio/istio/pull/4118#discussion_r173538375","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/4118","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/173538375"},"html":{"href":"https://github.com/istio/istio/pull/4118#discussion_r173538375"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/4118"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/4118","id":173882682,"html_url":"https://github.com/istio/istio/pull/4118","diff_url":"https://github.com/istio/istio/pull/4118.diff","patch_url":"https://github.com/istio/istio/pull/4118.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/4118","number":4118,"state":"open","locked":false,"title":"Lazily evaluate Ingress address","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"body":"Ingress takes up to 2 minutes to get an address.\r\nWe could be doing other work during that time.\r\n\r\nThis PR updates code to wait for ingress address only when the code is about to use that address.","created_at":"2018-03-08T23:42:59Z","updated_at":"2018-03-09T19:02:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1407def20b37046d8fc541a671af9a1787ecf3e6","assignee":{"login":"douglas-reid","id":21148125,"avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},"assignees":[{"login":"douglas-reid","id":21148125,"avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ayj","id":116378,"avatar_url":"https://avatars1.githubusercontent.com/u/116378?v=4","gravatar_id":"","url":"https://api.github.com/users/ayj","html_url":"https://github.com/ayj","followers_url":"https://api.github.com/users/ayj/followers","following_url":"https://api.github.com/users/ayj/following{/other_user}","gists_url":"https://api.github.com/users/ayj/gists{/gist_id}","starred_url":"https://api.github.com/users/ayj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayj/subscriptions","organizations_url":"https://api.github.com/users/ayj/orgs","repos_url":"https://api.github.com/users/ayj/repos","events_url":"https://api.github.com/users/ayj/events{/privacy}","received_events_url":"https://api.github.com/users/ayj/received_events","type":"User","site_admin":false},{"login":"douglas-reid","id":21148125,"avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":659652351,"url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":780123031,"url":"https://api.github.com/repos/istio/istio/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"bfdadc","default":false},{"id":851816600,"url":"https://api.github.com/repos/istio/istio/labels/kind/fixit","name":"kind/fixit","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/4118/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/4118/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/4118/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/519e2caa686398d51d0c8a210cfa1f8ab8f3f596","head":{"label":"mandarjog:faster_test","ref":"faster_test","sha":"519e2caa686398d51d0c8a210cfa1f8ab8f3f596","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"repo":{"id":76583321,"name":"istio","full_name":"mandarjog/istio","owner":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mandarjog/istio","description":"A Service Fabric for Polyglot Microservices","fork":true,"url":"https://api.github.com/repos/mandarjog/istio","forks_url":"https://api.github.com/repos/mandarjog/istio/forks","keys_url":"https://api.github.com/repos/mandarjog/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mandarjog/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mandarjog/istio/teams","hooks_url":"https://api.github.com/repos/mandarjog/istio/hooks","issue_events_url":"https://api.github.com/repos/mandarjog/istio/issues/events{/number}","events_url":"https://api.github.com/repos/mandarjog/istio/events","assignees_url":"https://api.github.com/repos/mandarjog/istio/assignees{/user}","branches_url":"https://api.github.com/repos/mandarjog/istio/branches{/branch}","tags_url":"https://api.github.com/repos/mandarjog/istio/tags","blobs_url":"https://api.github.com/repos/mandarjog/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mandarjog/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mandarjog/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/mandarjog/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mandarjog/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/mandarjog/istio/languages","stargazers_url":"https://api.github.com/repos/mandarjog/istio/stargazers","contributors_url":"https://api.github.com/repos/mandarjog/istio/contributors","subscribers_url":"https://api.github.com/repos/mandarjog/istio/subscribers","subscription_url":"https://api.github.com/repos/mandarjog/istio/subscription","commits_url":"https://api.github.com/repos/mandarjog/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/mandarjog/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/mandarjog/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/mandarjog/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/mandarjog/istio/contents/{+path}","compare_url":"https://api.github.com/repos/mandarjog/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mandarjog/istio/merges","archive_url":"https://api.github.com/repos/mandarjog/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mandarjog/istio/downloads","issues_url":"https://api.github.com/repos/mandarjog/istio/issues{/number}","pulls_url":"https://api.github.com/repos/mandarjog/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/mandarjog/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/mandarjog/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mandarjog/istio/labels{/name}","releases_url":"https://api.github.com/repos/mandarjog/istio/releases{/id}","deployments_url":"https://api.github.com/repos/mandarjog/istio/deployments","created_at":"2016-12-15T18:01:34Z","updated_at":"2017-10-30T13:15:26Z","pushed_at":"2018-03-09T18:56:14Z","git_url":"git://github.com/mandarjog/istio.git","ssh_url":"git@github.com:mandarjog/istio.git","clone_url":"https://github.com/mandarjog/istio.git","svn_url":"https://github.com/mandarjog/istio","homepage":null,"size":118007,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"053300fbf0846016ff24823970e19435c256a6b8","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-03-09T17:48:37Z","pushed_at":"2018-03-09T19:01:19Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":17305,"stargazers_count":6390,"watchers_count":6390,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":822,"mirror_url":null,"archived":false,"open_issues_count":711,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":822,"open_issues":711,"watchers":6390,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/4118"},"html":{"href":"https://github.com/istio/istio/pull/4118"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/4118"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/4118/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/4118/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/4118/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/519e2caa686398d51d0c8a210cfa1f8ab8f3f596"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ldemailly"}}