{"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/181760675","pull_request_review_id":112449553,"id":181760675,"diff_hunk":"@@ -256,7 +293,8 @@ inline void QMCSamplingContext<RNG>::split_in_place(\n     const size_t        dimension,\n     const size_t        sample_count)\n {\n-    assert(m_sample_count == 0 || m_instance == m_sample_count);    // can't split in the middle of a sequence\n+    // can't split in the middle of a sequence\n+    assert(m_sample_count == 0 || m_instance == m_sample_count || m_cmj_params.m_enabled);","path":"src/appleseed/foundation/math/sampling/qmcsamplingcontext.h","position":132,"original_position":132,"commit_id":"40aed88058c78580f05be59e143e2d7bee58e07b","original_commit_id":"40aed88058c78580f05be59e143e2d7bee58e07b","user":{"login":"oktomus","id":4656466,"avatar_url":"https://avatars0.githubusercontent.com/u/4656466?v=4","gravatar_id":"","url":"https://api.github.com/users/oktomus","html_url":"https://github.com/oktomus","followers_url":"https://api.github.com/users/oktomus/followers","following_url":"https://api.github.com/users/oktomus/following{/other_user}","gists_url":"https://api.github.com/users/oktomus/gists{/gist_id}","starred_url":"https://api.github.com/users/oktomus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktomus/subscriptions","organizations_url":"https://api.github.com/users/oktomus/orgs","repos_url":"https://api.github.com/users/oktomus/repos","events_url":"https://api.github.com/users/oktomus/events{/privacy}","received_events_url":"https://api.github.com/users/oktomus/received_events","type":"User","site_admin":false},"body":"I agree with you. But in `uniformpixelrenderer`, a large number is given to the context as long as a sample count. Since their are not compatible together, should I set the instance to 0 ? ","created_at":"2018-04-16T14:49:02Z","updated_at":"2018-04-16T14:49:03Z","html_url":"https://github.com/appleseedhq/appleseed/pull/1975#discussion_r181760675","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1975","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/181760675"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/1975#discussion_r181760675"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1975"}},"in_reply_to_id":181586690},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1975","id":181687070,"html_url":"https://github.com/appleseedhq/appleseed/pull/1975","diff_url":"https://github.com/appleseedhq/appleseed/pull/1975.diff","patch_url":"https://github.com/appleseedhq/appleseed/pull/1975.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/1975","number":1975,"state":"open","locked":false,"title":"Implement Correlated Multi-Jittered Sampling","user":{"login":"oktomus","id":4656466,"avatar_url":"https://avatars0.githubusercontent.com/u/4656466?v=4","gravatar_id":"","url":"https://api.github.com/users/oktomus","html_url":"https://github.com/oktomus","followers_url":"https://api.github.com/users/oktomus/followers","following_url":"https://api.github.com/users/oktomus/following{/other_user}","gists_url":"https://api.github.com/users/oktomus/gists{/gist_id}","starred_url":"https://api.github.com/users/oktomus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktomus/subscriptions","organizations_url":"https://api.github.com/users/oktomus/orgs","repos_url":"https://api.github.com/users/oktomus/repos","events_url":"https://api.github.com/users/oktomus/events{/privacy}","received_events_url":"https://api.github.com/users/oktomus/received_events","type":"User","site_admin":false},"body":"Sorry for the new PR, it was getting really dirty\r\n#1937 \r\n\r\n![cmj_comp](https://user-images.githubusercontent.com/4656466/38772925-18896794-4042-11e8-9072-c9d09b3ff952.png)\r\n\r\n[Paper](https://graphics.pixar.com/library/MultiJitteredSampling/paper.pdf)\r\n","created_at":"2018-04-15T08:21:48Z","updated_at":"2018-04-16T14:49:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf1a25431ab908193951607c227b082a482bb54a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1975/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1975/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/1975/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/40aed88058c78580f05be59e143e2d7bee58e07b","head":{"label":"oktomus:cmj","ref":"cmj","sha":"40aed88058c78580f05be59e143e2d7bee58e07b","user":{"login":"oktomus","id":4656466,"avatar_url":"https://avatars0.githubusercontent.com/u/4656466?v=4","gravatar_id":"","url":"https://api.github.com/users/oktomus","html_url":"https://github.com/oktomus","followers_url":"https://api.github.com/users/oktomus/followers","following_url":"https://api.github.com/users/oktomus/following{/other_user}","gists_url":"https://api.github.com/users/oktomus/gists{/gist_id}","starred_url":"https://api.github.com/users/oktomus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktomus/subscriptions","organizations_url":"https://api.github.com/users/oktomus/orgs","repos_url":"https://api.github.com/users/oktomus/repos","events_url":"https://api.github.com/users/oktomus/events{/privacy}","received_events_url":"https://api.github.com/users/oktomus/received_events","type":"User","site_admin":false},"repo":{"id":122386792,"name":"appleseed","full_name":"oktomus/appleseed","owner":{"login":"oktomus","id":4656466,"avatar_url":"https://avatars0.githubusercontent.com/u/4656466?v=4","gravatar_id":"","url":"https://api.github.com/users/oktomus","html_url":"https://github.com/oktomus","followers_url":"https://api.github.com/users/oktomus/followers","following_url":"https://api.github.com/users/oktomus/following{/other_user}","gists_url":"https://api.github.com/users/oktomus/gists{/gist_id}","starred_url":"https://api.github.com/users/oktomus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktomus/subscriptions","organizations_url":"https://api.github.com/users/oktomus/orgs","repos_url":"https://api.github.com/users/oktomus/repos","events_url":"https://api.github.com/users/oktomus/events{/privacy}","received_events_url":"https://api.github.com/users/oktomus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oktomus/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":true,"url":"https://api.github.com/repos/oktomus/appleseed","forks_url":"https://api.github.com/repos/oktomus/appleseed/forks","keys_url":"https://api.github.com/repos/oktomus/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oktomus/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oktomus/appleseed/teams","hooks_url":"https://api.github.com/repos/oktomus/appleseed/hooks","issue_events_url":"https://api.github.com/repos/oktomus/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/oktomus/appleseed/events","assignees_url":"https://api.github.com/repos/oktomus/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/oktomus/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/oktomus/appleseed/tags","blobs_url":"https://api.github.com/repos/oktomus/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oktomus/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oktomus/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/oktomus/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oktomus/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/oktomus/appleseed/languages","stargazers_url":"https://api.github.com/repos/oktomus/appleseed/stargazers","contributors_url":"https://api.github.com/repos/oktomus/appleseed/contributors","subscribers_url":"https://api.github.com/repos/oktomus/appleseed/subscribers","subscription_url":"https://api.github.com/repos/oktomus/appleseed/subscription","commits_url":"https://api.github.com/repos/oktomus/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/oktomus/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/oktomus/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/oktomus/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/oktomus/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/oktomus/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oktomus/appleseed/merges","archive_url":"https://api.github.com/repos/oktomus/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oktomus/appleseed/downloads","issues_url":"https://api.github.com/repos/oktomus/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/oktomus/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/oktomus/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/oktomus/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oktomus/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/oktomus/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/oktomus/appleseed/deployments","created_at":"2018-02-21T20:02:17Z","updated_at":"2018-02-21T20:02:29Z","pushed_at":"2018-04-15T08:20:18Z","git_url":"git://github.com/oktomus/appleseed.git","ssh_url":"git@github.com:oktomus/appleseed.git","clone_url":"https://github.com/oktomus/appleseed.git","svn_url":"https://github.com/oktomus/appleseed","homepage":"http://appleseedhq.net/","size":1223378,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"c1fb39244d874318a1356c50d8df03bc17316c4c","user":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":753784,"name":"appleseed","full_name":"appleseedhq/appleseed","owner":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed","forks_url":"https://api.github.com/repos/appleseedhq/appleseed/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed/deployments","created_at":"2010-07-02T16:33:51Z","updated_at":"2018-04-16T10:08:59Z","pushed_at":"2018-04-16T13:35:14Z","git_url":"git://github.com/appleseedhq/appleseed.git","ssh_url":"git@github.com:appleseedhq/appleseed.git","clone_url":"https://github.com/appleseedhq/appleseed.git","svn_url":"https://github.com/appleseedhq/appleseed","homepage":"https://appleseedhq.net/","size":1223344,"stargazers_count":933,"watchers_count":933,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"archived":false,"open_issues_count":323,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":185,"open_issues":323,"watchers":933,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1975"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/1975"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/1975"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/1975/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1975/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1975/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed/statuses/40aed88058c78580f05be59e143e2d7bee58e07b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"oktomus"}}