{"action":"created","issue":{"url":"https://api.github.com/repos/cowboyd/funcadelic.js/issues/20","repository_url":"https://api.github.com/repos/cowboyd/funcadelic.js","labels_url":"https://api.github.com/repos/cowboyd/funcadelic.js/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/cowboyd/funcadelic.js/issues/20/comments","events_url":"https://api.github.com/repos/cowboyd/funcadelic.js/issues/20/events","html_url":"https://github.com/cowboyd/funcadelic.js/pull/20","id":307235494,"number":20,"title":"Wrapping getters in thunk in append","user":{"login":"taras","id":74687,"avatar_url":"https://avatars2.githubusercontent.com/u/74687?v=4","gravatar_id":"","url":"https://api.github.com/users/taras","html_url":"https://github.com/taras","followers_url":"https://api.github.com/users/taras/followers","following_url":"https://api.github.com/users/taras/following{/other_user}","gists_url":"https://api.github.com/users/taras/gists{/gist_id}","starred_url":"https://api.github.com/users/taras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taras/subscriptions","organizations_url":"https://api.github.com/users/taras/orgs","repos_url":"https://api.github.com/users/taras/repos","events_url":"https://api.github.com/users/taras/events{/privacy}","received_events_url":"https://api.github.com/users/taras/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-21T13:03:04Z","updated_at":"2018-03-22T03:50:59Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/cowboyd/funcadelic.js/pulls/20","html_url":"https://github.com/cowboyd/funcadelic.js/pull/20","diff_url":"https://github.com/cowboyd/funcadelic.js/pull/20.diff","patch_url":"https://github.com/cowboyd/funcadelic.js/pull/20.patch"},"body":"This PR introduces caching to getters that are added to objects using `append`. \r\n\r\n```js\r\nlet combined = append({ two: 2, three: 3 }, {\r\n  get sum() {\r\n    return this.two + this.three;\r\n  }\r\n});\r\n\r\ncombined.sum // => 5;\r\n```\r\n\r\nThe sum calculation will only ever be performed once for any instance. All future invocations will produce previously computed value.\r\n\r\nNote: this PR only caches the getters from the second argument.\r\n\r\nRelated to https://github.com/microstates/microstates.js/pull/81"},"comment":{"url":"https://api.github.com/repos/cowboyd/funcadelic.js/issues/comments/375171124","html_url":"https://github.com/cowboyd/funcadelic.js/pull/20#issuecomment-375171124","issue_url":"https://api.github.com/repos/cowboyd/funcadelic.js/issues/20","id":375171124,"user":{"login":"taras","id":74687,"avatar_url":"https://avatars2.githubusercontent.com/u/74687?v=4","gravatar_id":"","url":"https://api.github.com/users/taras","html_url":"https://github.com/taras","followers_url":"https://api.github.com/users/taras/followers","following_url":"https://api.github.com/users/taras/following{/other_user}","gists_url":"https://api.github.com/users/taras/gists{/gist_id}","starred_url":"https://api.github.com/users/taras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taras/subscriptions","organizations_url":"https://api.github.com/users/taras/orgs","repos_url":"https://api.github.com/users/taras/repos","events_url":"https://api.github.com/users/taras/events{/privacy}","received_events_url":"https://api.github.com/users/taras/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T03:50:59Z","updated_at":"2018-03-22T03:50:59Z","author_association":"COLLABORATOR","body":"@cowboyd I made the changes, but I'm not sure how to test for getters not being wrapped twice."}}
{"actor":{"display_login":"taras"}}