{"action":"created","comment":{"url":"https://api.github.com/repos/TerriaJS/magda/pulls/comments/185143418","pull_request_review_id":116476078,"id":185143418,"diff_hunk":"@@ -1,6 +1,6 @@\n import sleuther from \"@magda/sleuther-framework/dist/index\";\n import linkedDataAspectDef from \"./linkedDataAspectDef\";\n-import datasetQualityAspectDef from \"./linkedDataAspectDef\";\n+import datasetQualityAspectDef from \"@magda/sleuther-framework/dist/common-aspect-defs/datasetQualityAspectDef\";\n import onRecordFound from \"./onRecordFound\";\n import commonYargs from \"@magda/sleuther-framework/dist/commonYargs\";\n ","path":"magda-sleuther-linked-data-rating/src/index.ts","position":7,"original_position":7,"commit_id":"b8b1d939ebc8868b452a1c4e3de7e075bb6a281a","original_commit_id":"e7ababe982fc132441631425d696c209d47016b6","user":{"login":"t83714","id":674387,"avatar_url":"https://avatars3.githubusercontent.com/u/674387?v=4","gravatar_id":"","url":"https://api.github.com/users/t83714","html_url":"https://github.com/t83714","followers_url":"https://api.github.com/users/t83714/followers","following_url":"https://api.github.com/users/t83714/following{/other_user}","gists_url":"https://api.github.com/users/t83714/gists{/gist_id}","starred_url":"https://api.github.com/users/t83714/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t83714/subscriptions","organizations_url":"https://api.github.com/users/t83714/orgs","repos_url":"https://api.github.com/users/t83714/repos","events_url":"https://api.github.com/users/t83714/events{/privacy}","received_events_url":"https://api.github.com/users/t83714/received_events","type":"User","site_admin":false},"body":"@adamzerella Sorry for the late reply --- missed your comment.\r\nI can't find the new commit from this PR. Maybe you haven't pushed the changes yet?\r\nOnce you start to listen dataset-format changes, `magda-sleuther-linked-data-rating/src/onRecordFound.ts` line 48, you probably want to have the logic to use the format info from `dataset-format` when it's available.\r\nBy looking at the content of the JSON schema file & original requirements, I think `linked-data-rating` sleuther  should only update `linkedDataAspect` (without touching `datasetQualityAspect`)?  We can confirm this with @AlexGilleran .  You don't need to create a new file for `linkedDataAspectDef`. It's here `magda-sleuther-linked-data-rating/src/linkedDataAspectDef.ts`. However, it doesn't hurt to move it to  `common-aspect-defs` --- as long as we update all the reference.\r\n","created_at":"2018-05-01T00:07:31Z","updated_at":"2018-05-01T00:07:31Z","html_url":"https://github.com/TerriaJS/magda/pull/819#discussion_r185143418","pull_request_url":"https://api.github.com/repos/TerriaJS/magda/pulls/819","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TerriaJS/magda/pulls/comments/185143418"},"html":{"href":"https://github.com/TerriaJS/magda/pull/819#discussion_r185143418"},"pull_request":{"href":"https://api.github.com/repos/TerriaJS/magda/pulls/819"}},"in_reply_to_id":183257933},"pull_request":{"url":"https://api.github.com/repos/TerriaJS/magda/pulls/819","id":182954324,"html_url":"https://github.com/TerriaJS/magda/pull/819","diff_url":"https://github.com/TerriaJS/magda/pull/819.diff","patch_url":"https://github.com/TerriaJS/magda/pull/819.patch","issue_url":"https://api.github.com/repos/TerriaJS/magda/issues/819","number":819,"state":"open","locked":false,"title":"Issue/395 change linked data rating broken status","user":{"login":"adamzerella","id":1501560,"avatar_url":"https://avatars3.githubusercontent.com/u/1501560?v=4","gravatar_id":"","url":"https://api.github.com/users/adamzerella","html_url":"https://github.com/adamzerella","followers_url":"https://api.github.com/users/adamzerella/followers","following_url":"https://api.github.com/users/adamzerella/following{/other_user}","gists_url":"https://api.github.com/users/adamzerella/gists{/gist_id}","starred_url":"https://api.github.com/users/adamzerella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamzerella/subscriptions","organizations_url":"https://api.github.com/users/adamzerella/orgs","repos_url":"https://api.github.com/users/adamzerella/repos","events_url":"https://api.github.com/users/adamzerella/events{/privacy}","received_events_url":"https://api.github.com/users/adamzerella/received_events","type":"User","site_admin":false},"body":"### What this PR does\r\nLinked data rating sleuther now uses `PUT` instead of `PATCH` when writing to registry.\r\nRemoved linked data rating takes output from broken link sleuther\r\n\r\n### Checklist\r\n- [x] There are unit tests to verify my changes are correct\r\n- [x] I've updated CHANGES.md with what I changed.\r\n- [x] I've linked this PR to an issue in ZenHub (or there is no issue) and dragged it to the _Pull Request_ column","created_at":"2018-04-20T03:58:25Z","updated_at":"2018-05-01T00:07:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2d0e48b519ea18fe4d1404e02c4ed4eb843b288","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TerriaJS/magda/pulls/819/commits","review_comments_url":"https://api.github.com/repos/TerriaJS/magda/pulls/819/comments","review_comment_url":"https://api.github.com/repos/TerriaJS/magda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TerriaJS/magda/issues/819/comments","statuses_url":"https://api.github.com/repos/TerriaJS/magda/statuses/b8b1d939ebc8868b452a1c4e3de7e075bb6a281a","head":{"label":"TerriaJS:issue/395-Change-linked-data-rating-broken-status","ref":"issue/395-Change-linked-data-rating-broken-status","sha":"b8b1d939ebc8868b452a1c4e3de7e075bb6a281a","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars3.githubusercontent.com/u/12078432?v=4","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":66343967,"name":"magda","full_name":"TerriaJS/magda","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars3.githubusercontent.com/u/12078432?v=4","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/magda","description":"A modern data platform for a new generation of data portals","fork":false,"url":"https://api.github.com/repos/TerriaJS/magda","forks_url":"https://api.github.com/repos/TerriaJS/magda/forks","keys_url":"https://api.github.com/repos/TerriaJS/magda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/magda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/magda/teams","hooks_url":"https://api.github.com/repos/TerriaJS/magda/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/magda/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/magda/events","assignees_url":"https://api.github.com/repos/TerriaJS/magda/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/magda/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/magda/tags","blobs_url":"https://api.github.com/repos/TerriaJS/magda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/magda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/magda/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/magda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/magda/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/magda/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/magda/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/magda/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/magda/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/magda/subscription","commits_url":"https://api.github.com/repos/TerriaJS/magda/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/magda/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/magda/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/magda/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/magda/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/magda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/magda/merges","archive_url":"https://api.github.com/repos/TerriaJS/magda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/magda/downloads","issues_url":"https://api.github.com/repos/TerriaJS/magda/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/magda/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/magda/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/magda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/magda/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/magda/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/magda/deployments","created_at":"2016-08-23T07:27:25Z","updated_at":"2018-04-30T02:30:10Z","pushed_at":"2018-04-30T08:12:33Z","git_url":"git://github.com/TerriaJS/magda.git","ssh_url":"git@github.com:TerriaJS/magda.git","clone_url":"https://github.com/TerriaJS/magda.git","svn_url":"https://github.com/TerriaJS/magda","homepage":"","size":165612,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":177,"watchers":27,"default_branch":"master"}},"base":{"label":"TerriaJS:master","ref":"master","sha":"f23e2d39731a54f7af0c6df81774763f62aa5cb9","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars3.githubusercontent.com/u/12078432?v=4","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":66343967,"name":"magda","full_name":"TerriaJS/magda","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars3.githubusercontent.com/u/12078432?v=4","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/magda","description":"A modern data platform for a new generation of data portals","fork":false,"url":"https://api.github.com/repos/TerriaJS/magda","forks_url":"https://api.github.com/repos/TerriaJS/magda/forks","keys_url":"https://api.github.com/repos/TerriaJS/magda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/magda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/magda/teams","hooks_url":"https://api.github.com/repos/TerriaJS/magda/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/magda/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/magda/events","assignees_url":"https://api.github.com/repos/TerriaJS/magda/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/magda/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/magda/tags","blobs_url":"https://api.github.com/repos/TerriaJS/magda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/magda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/magda/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/magda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/magda/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/magda/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/magda/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/magda/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/magda/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/magda/subscription","commits_url":"https://api.github.com/repos/TerriaJS/magda/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/magda/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/magda/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/magda/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/magda/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/magda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/magda/merges","archive_url":"https://api.github.com/repos/TerriaJS/magda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/magda/downloads","issues_url":"https://api.github.com/repos/TerriaJS/magda/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/magda/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/magda/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/magda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/magda/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/magda/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/magda/deployments","created_at":"2016-08-23T07:27:25Z","updated_at":"2018-04-30T02:30:10Z","pushed_at":"2018-04-30T08:12:33Z","git_url":"git://github.com/TerriaJS/magda.git","ssh_url":"git@github.com:TerriaJS/magda.git","clone_url":"https://github.com/TerriaJS/magda.git","svn_url":"https://github.com/TerriaJS/magda","homepage":"","size":165612,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":177,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TerriaJS/magda/pulls/819"},"html":{"href":"https://github.com/TerriaJS/magda/pull/819"},"issue":{"href":"https://api.github.com/repos/TerriaJS/magda/issues/819"},"comments":{"href":"https://api.github.com/repos/TerriaJS/magda/issues/819/comments"},"review_comments":{"href":"https://api.github.com/repos/TerriaJS/magda/pulls/819/comments"},"review_comment":{"href":"https://api.github.com/repos/TerriaJS/magda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TerriaJS/magda/pulls/819/commits"},"statuses":{"href":"https://api.github.com/repos/TerriaJS/magda/statuses/b8b1d939ebc8868b452a1c4e3de7e075bb6a281a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"t83714"}}