{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/241399910","pull_request_review_id":184617513,"id":241399910,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTM5OTkxMA==","diff_hunk":"@@ -87,34 +87,34 @@ export const MetricDetail = withTheme(\n           );\n         }\n         const layouts = layoutCreator(this.props.theme);\n-        const breadcrumbs = [{ text: nodeName }];\n \n         return (\n-          <ColumnarPage>\n-            <Header\n-              appendSections={<InfrastructureBetaBadgeHeaderSection />}\n-              breadcrumbs={breadcrumbs}\n-            />\n-            <WithMetricsTimeUrlState />\n-            <DetailPageContent>\n-              <WithOptions>\n-                {({ sourceId }) => (\n-                  <WithMetricsTime resetOnUnmount>\n-                    {({\n-                      currentTimeRange,\n-                      isAutoReloading,\n-                      setRangeTime,\n-                      startMetricsAutoReload,\n-                      stopMetricsAutoReload,\n-                    }) => (\n-                      <WithMetadata\n-                        layouts={layouts}\n-                        sourceId={sourceId}\n-                        nodeType={nodeType}\n-                        nodeId={nodeName}\n-                      >\n-                        {({ filteredLayouts }) => {\n-                          return (\n+          <WithOptions>\n+            {({ sourceId }) => (\n+              <WithMetricsTime resetOnUnmount>\n+                {({\n+                  currentTimeRange,\n+                  isAutoReloading,\n+                  setRangeTime,\n+                  startMetricsAutoReload,\n+                  stopMetricsAutoReload,\n+                }) => (\n+                  <WithMetadata\n+                    layouts={layouts}\n+                    sourceId={sourceId}\n+                    nodeType={nodeType}\n+                    nodeId={nodeName}\n+                  >\n+                    {({ displayName, filteredLayouts }) => {","path":"x-pack/plugins/infra/public/pages/metrics/index.tsx","position":48,"original_position":48,"commit_id":"4e07e699f8787a36277c7c29c200a86ceff47194","original_commit_id":"4e07e699f8787a36277c7c29c200a86ceff47194","user":{"login":"weltenwort","id":973741,"node_id":"MDQ6VXNlcjk3Mzc0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/973741?v=4","gravatar_id":"","url":"https://api.github.com/users/weltenwort","html_url":"https://github.com/weltenwort","followers_url":"https://api.github.com/users/weltenwort/followers","following_url":"https://api.github.com/users/weltenwort/following{/other_user}","gists_url":"https://api.github.com/users/weltenwort/gists{/gist_id}","starred_url":"https://api.github.com/users/weltenwort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weltenwort/subscriptions","organizations_url":"https://api.github.com/users/weltenwort/orgs","repos_url":"https://api.github.com/users/weltenwort/repos","events_url":"https://api.github.com/users/weltenwort/events{/privacy}","received_events_url":"https://api.github.com/users/weltenwort/received_events","type":"User","site_admin":false},"body":"The loading state for the metadata is not handled, so we have intermediate views showing incomplete breadcrumbs and loading dialogs:\r\n\r\n![image](https://user-images.githubusercontent.com/973741/49941800-d470e580-fee3-11e8-86d5-6da926b4bf7d.png)\r\n\r\n![image](https://user-images.githubusercontent.com/973741/49941843-ee122d00-fee3-11e8-85b9-6d91f8f0afa6.png)\r\n\r\nWe could fall back to the `id` until the name is loaded?","created_at":"2018-12-13T13:33:17Z","updated_at":"2018-12-13T13:58:17Z","html_url":"https://github.com/elastic/kibana/pull/27088#discussion_r241399910","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/27088","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/241399910"},"html":{"href":"https://github.com/elastic/kibana/pull/27088#discussion_r241399910"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/27088"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/27088","id":238202871,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjAyODcx","html_url":"https://github.com/elastic/kibana/pull/27088","diff_url":"https://github.com/elastic/kibana/pull/27088.diff","patch_url":"https://github.com/elastic/kibana/pull/27088.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/27088","number":27088,"state":"open","locked":false,"title":"[Infra UI] Update links for containers to use ID instead of name","user":{"login":"simianhacker","id":41702,"node_id":"MDQ6VXNlcjQxNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/41702?v=4","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"body":"This PR changes the fields used to identify Kubernetes pods and Docker containers. This PR also modifies both the map endpoint and the metadata endpoint to add a display name for each node type. That way instead of displaying the ID it displays the human readable string. To the user everything should appear the same.\r\n\r\nFixes #26359 ","created_at":"2018-12-12T22:23:39Z","updated_at":"2018-12-13T13:58:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cff61ff95106c2a19882915cbe7d4f173f99eb8e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"skh","id":189073,"node_id":"MDQ6VXNlcjE4OTA3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/189073?v=4","gravatar_id":"","url":"https://api.github.com/users/skh","html_url":"https://github.com/skh","followers_url":"https://api.github.com/users/skh/followers","following_url":"https://api.github.com/users/skh/following{/other_user}","gists_url":"https://api.github.com/users/skh/gists{/gist_id}","starred_url":"https://api.github.com/users/skh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skh/subscriptions","organizations_url":"https://api.github.com/users/skh/orgs","repos_url":"https://api.github.com/users/skh/repos","events_url":"https://api.github.com/users/skh/events{/privacy}","received_events_url":"https://api.github.com/users/skh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":983061515,"node_id":"MDU6TGFiZWw5ODMwNjE1MTU=","url":"https://api.github.com/repos/elastic/kibana/labels/:Infra%20UI","name":":Infra UI","color":"fef2c0","default":false},{"id":135307740,"node_id":"MDU6TGFiZWwxMzUzMDc3NDA=","url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false},{"id":1062169267,"node_id":"MDU6TGFiZWwxMDYyMTY5MjY3","url":"https://api.github.com/repos/elastic/kibana/labels/v6.6.0","name":"v6.6.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/27088/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/27088/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/27088/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/4e07e699f8787a36277c7c29c200a86ceff47194","head":{"label":"simianhacker:fixes-26359","ref":"fixes-26359","sha":"4e07e699f8787a36277c7c29c200a86ceff47194","user":{"login":"simianhacker","id":41702,"node_id":"MDQ6VXNlcjQxNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/41702?v=4","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"repo":{"id":14648766,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0ODc2Ng==","name":"kibana","full_name":"simianhacker/kibana","private":false,"owner":{"login":"simianhacker","id":41702,"node_id":"MDQ6VXNlcjQxNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/41702?v=4","gravatar_id":"","url":"https://api.github.com/users/simianhacker","html_url":"https://github.com/simianhacker","followers_url":"https://api.github.com/users/simianhacker/followers","following_url":"https://api.github.com/users/simianhacker/following{/other_user}","gists_url":"https://api.github.com/users/simianhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/simianhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simianhacker/subscriptions","organizations_url":"https://api.github.com/users/simianhacker/orgs","repos_url":"https://api.github.com/users/simianhacker/repos","events_url":"https://api.github.com/users/simianhacker/events{/privacy}","received_events_url":"https://api.github.com/users/simianhacker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/simianhacker/kibana","description":"Kibana 3","fork":true,"url":"https://api.github.com/repos/simianhacker/kibana","forks_url":"https://api.github.com/repos/simianhacker/kibana/forks","keys_url":"https://api.github.com/repos/simianhacker/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simianhacker/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simianhacker/kibana/teams","hooks_url":"https://api.github.com/repos/simianhacker/kibana/hooks","issue_events_url":"https://api.github.com/repos/simianhacker/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/simianhacker/kibana/events","assignees_url":"https://api.github.com/repos/simianhacker/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/simianhacker/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/simianhacker/kibana/tags","blobs_url":"https://api.github.com/repos/simianhacker/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simianhacker/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simianhacker/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/simianhacker/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simianhacker/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/simianhacker/kibana/languages","stargazers_url":"https://api.github.com/repos/simianhacker/kibana/stargazers","contributors_url":"https://api.github.com/repos/simianhacker/kibana/contributors","subscribers_url":"https://api.github.com/repos/simianhacker/kibana/subscribers","subscription_url":"https://api.github.com/repos/simianhacker/kibana/subscription","commits_url":"https://api.github.com/repos/simianhacker/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/simianhacker/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/simianhacker/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/simianhacker/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/simianhacker/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/simianhacker/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simianhacker/kibana/merges","archive_url":"https://api.github.com/repos/simianhacker/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simianhacker/kibana/downloads","issues_url":"https://api.github.com/repos/simianhacker/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/simianhacker/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/simianhacker/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/simianhacker/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simianhacker/kibana/labels{/name}","releases_url":"https://api.github.com/repos/simianhacker/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/simianhacker/kibana/deployments","created_at":"2013-11-23T19:19:22Z","updated_at":"2018-08-30T16:19:37Z","pushed_at":"2018-12-12T22:30:41Z","git_url":"git://github.com/simianhacker/kibana.git","ssh_url":"git@github.com:simianhacker/kibana.git","clone_url":"https://github.com/simianhacker/kibana.git","svn_url":"https://github.com/simianhacker/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":502974,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"93e3a4c7c8da899cb748b4903ec1a65c61517777","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-12-13T13:48:28Z","pushed_at":"2018-12-13T13:40:46Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":519663,"stargazers_count":10653,"watchers_count":10653,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4159,"mirror_url":null,"archived":false,"open_issues_count":3855,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4159,"open_issues":3855,"watchers":10653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/27088"},"html":{"href":"https://github.com/elastic/kibana/pull/27088"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/27088"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/27088/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/27088/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/27088/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/4e07e699f8787a36277c7c29c200a86ceff47194"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"weltenwort"}}