{"action":"created","issue":{"url":"https://api.github.com/repos/hmailserver/hmailserver/issues/229","repository_url":"https://api.github.com/repos/hmailserver/hmailserver","labels_url":"https://api.github.com/repos/hmailserver/hmailserver/issues/229/labels{/name}","comments_url":"https://api.github.com/repos/hmailserver/hmailserver/issues/229/comments","events_url":"https://api.github.com/repos/hmailserver/hmailserver/issues/229/events","html_url":"https://github.com/hmailserver/hmailserver/issues/229","id":248340618,"node_id":"MDU6SXNzdWUyNDgzNDA2MTg=","number":229,"title":"Code: Adding Constring param: TLS 1.2 Support for SQL Server ","user":{"login":"Dravion","id":15117429,"node_id":"MDQ6VXNlcjE1MTE3NDI5","avatar_url":"https://avatars0.githubusercontent.com/u/15117429?v=4","gravatar_id":"","url":"https://api.github.com/users/Dravion","html_url":"https://github.com/Dravion","followers_url":"https://api.github.com/users/Dravion/followers","following_url":"https://api.github.com/users/Dravion/following{/other_user}","gists_url":"https://api.github.com/users/Dravion/gists{/gist_id}","starred_url":"https://api.github.com/users/Dravion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dravion/subscriptions","organizations_url":"https://api.github.com/users/Dravion/orgs","repos_url":"https://api.github.com/users/Dravion/repos","events_url":"https://api.github.com/users/Dravion/events{/privacy}","received_events_url":"https://api.github.com/users/Dravion/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-08-07T08:26:53Z","updated_at":"2018-07-26T15:02:47Z","closed_at":null,"author_association":"NONE","body":"Hi Martin,\r\nIs it possible to add the following TLS Connection security attribute to the MSSQL-Server (not CE) Connectionstring in ADOConnection.cpp Line 102 ?\r\n\r\nFrom:\r\nString sConnectionString = \"Provider=\" + sProvider + \";\";\r\nsConnectionString.append(\"Server=\" + sServer + \";\");\r\nsConnectionString.append(\"Initial Catalog=\" + sDatabase + \";\");\r\n\r\nTo:\r\nString sConnectionString = \"Provider=\" + sProvider + \";\";\r\nsConnectionString.append(\"Server=\" + sServer + \";\");\r\nsConnectionString.append(\"Initial Catalog=\" + sDatabase + \";\");\r\n**sConnectionString.append(\"Trusted_Connection=yes;Encrypt=yes;\";\");**   \r\n\r\nOr have at least a hMailServer.ini switch which enables/disables MSSQL TLS Connection\r\nsecurity?\r\n\r\n[Forum Discussion](https://www.hmailserver.com/forum/viewtopic.php?f=2&t=31457&p=197785#p197785)\r\n"},"comment":{"url":"https://api.github.com/repos/hmailserver/hmailserver/issues/comments/408127899","html_url":"https://github.com/hmailserver/hmailserver/issues/229#issuecomment-408127899","issue_url":"https://api.github.com/repos/hmailserver/hmailserver/issues/229","id":408127899,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODEyNzg5OQ==","user":{"login":"martinknafve","id":71842,"node_id":"MDQ6VXNlcjcxODQy","avatar_url":"https://avatars0.githubusercontent.com/u/71842?v=4","gravatar_id":"","url":"https://api.github.com/users/martinknafve","html_url":"https://github.com/martinknafve","followers_url":"https://api.github.com/users/martinknafve/followers","following_url":"https://api.github.com/users/martinknafve/following{/other_user}","gists_url":"https://api.github.com/users/martinknafve/gists{/gist_id}","starred_url":"https://api.github.com/users/martinknafve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinknafve/subscriptions","organizations_url":"https://api.github.com/users/martinknafve/orgs","repos_url":"https://api.github.com/users/martinknafve/repos","events_url":"https://api.github.com/users/martinknafve/events{/privacy}","received_events_url":"https://api.github.com/users/martinknafve/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T15:02:47Z","updated_at":"2018-07-26T15:02:47Z","author_association":"COLLABORATOR","body":"The suggestion given on implementation here would not have the intended effect. The OLE DB Provider used by hMailServer does not support TLS 1.2, so simply stating that the connection should be encrypted won't work since the connection to a TLS 1.2 server will fail anyway.\r\n\r\nI have added an ini-file-setting which lets you override the provider to be used. Specifically, the provider MSOLEDBSQL supports TLS 1.2, so by setting Provider=MSOLEDBSQL under Database section in hMailServer.ini, TLS 1.2 will be used. For this to work, the provider must also be installed on the machine. I believe the following installs it:\r\n\r\nhttps://www.microsoft.com/en-us/download/details.aspx?id=56730"}}
{"actor":{"display_login":"martinknafve"}}