{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/comments/236278573","pull_request_review_id":178318606,"id":236278573,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjI3ODU3Mw==","diff_hunk":"@@ -0,0 +1,206 @@\n+/*\n+ * This file is part of the KubeVirt project\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ *\n+ * Copyright 2018 Red Hat, Inc.\n+ *\n+ */\n+\n+package tests_test\n+\n+import (\n+\t\"flag\"\n+\t\"os/exec\"\n+\t\"time\"\n+\t\"encoding/xml\"\n+\t\"strings\"\n+\n+\t. \"github.com/onsi/ginkgo\"\n+\t. \"github.com/onsi/gomega\"\n+\tk8sv1 \"k8s.io/api/core/v1\"\n+\t\"k8s.io/apimachinery/pkg/api/resource\"\n+\tmetav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n+\n+\t\"kubevirt.io/kubevirt/pkg/virt-launcher/virtwrap/api\"\n+\t\"kubevirt.io/kubevirt/pkg/api/v1\"\n+\t\"kubevirt.io/kubevirt/pkg/kubecli\"\n+\t\"kubevirt.io/kubevirt/tests\"","path":"tests/iothreads_test.go","position":38,"original_position":38,"commit_id":"151d2571c3cab1fa0889870f02d35bfdfc3693e4","original_commit_id":"151d2571c3cab1fa0889870f02d35bfdfc3693e4","user":{"login":"petrkotas","id":8687113,"node_id":"MDQ6VXNlcjg2ODcxMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/8687113?v=4","gravatar_id":"","url":"https://api.github.com/users/petrkotas","html_url":"https://github.com/petrkotas","followers_url":"https://api.github.com/users/petrkotas/followers","following_url":"https://api.github.com/users/petrkotas/following{/other_user}","gists_url":"https://api.github.com/users/petrkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/petrkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrkotas/subscriptions","organizations_url":"https://api.github.com/users/petrkotas/orgs","repos_url":"https://api.github.com/users/petrkotas/repos","events_url":"https://api.github.com/users/petrkotas/events{/privacy}","received_events_url":"https://api.github.com/users/petrkotas/received_events","type":"User","site_admin":false},"body":"I personally do not like the idea, you are importing our tests. These can change and will break your code.","created_at":"2018-11-26T14:38:00Z","updated_at":"2018-11-26T14:53:14Z","html_url":"https://github.com/kubevirt/kubevirt-ansible/pull/484#discussion_r236278573","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/484","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/comments/236278573"},"html":{"href":"https://github.com/kubevirt/kubevirt-ansible/pull/484#discussion_r236278573"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/484"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/484","id":233489553,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDg5NTUz","html_url":"https://github.com/kubevirt/kubevirt-ansible/pull/484","diff_url":"https://github.com/kubevirt/kubevirt-ansible/pull/484.diff","patch_url":"https://github.com/kubevirt/kubevirt-ansible/pull/484.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/484","number":484,"state":"open","locked":false,"title":"add IOthread - first test case","user":{"login":"sHaggYcaT","id":5021404,"node_id":"MDQ6VXNlcjUwMjE0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5021404?v=4","gravatar_id":"","url":"https://api.github.com/users/sHaggYcaT","html_url":"https://github.com/sHaggYcaT","followers_url":"https://api.github.com/users/sHaggYcaT/followers","following_url":"https://api.github.com/users/sHaggYcaT/following{/other_user}","gists_url":"https://api.github.com/users/sHaggYcaT/gists{/gist_id}","starred_url":"https://api.github.com/users/sHaggYcaT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sHaggYcaT/subscriptions","organizations_url":"https://api.github.com/users/sHaggYcaT/orgs","repos_url":"https://api.github.com/users/sHaggYcaT/repos","events_url":"https://api.github.com/users/sHaggYcaT/events{/privacy}","received_events_url":"https://api.github.com/users/sHaggYcaT/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nImplements first test case for IOthread feature (check shared IOthread policy) \r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```Other test cases for IOthread feature comming soon  \r\n```\r\n","created_at":"2018-11-26T09:32:49Z","updated_at":"2018-11-26T14:53:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b6a468d852d8f1ca6906fad63bf8fe64f6badad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1080239013,"node_id":"MDU6TGFiZWwxMDgwMjM5MDEz","url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":1080239536,"node_id":"MDU6TGFiZWwxMDgwMjM5NTM2","url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/484/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/484/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/484/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/statuses/151d2571c3cab1fa0889870f02d35bfdfc3693e4","head":{"label":"sHaggYcaT:IOThreads","ref":"IOThreads","sha":"151d2571c3cab1fa0889870f02d35bfdfc3693e4","user":{"login":"sHaggYcaT","id":5021404,"node_id":"MDQ6VXNlcjUwMjE0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5021404?v=4","gravatar_id":"","url":"https://api.github.com/users/sHaggYcaT","html_url":"https://github.com/sHaggYcaT","followers_url":"https://api.github.com/users/sHaggYcaT/followers","following_url":"https://api.github.com/users/sHaggYcaT/following{/other_user}","gists_url":"https://api.github.com/users/sHaggYcaT/gists{/gist_id}","starred_url":"https://api.github.com/users/sHaggYcaT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sHaggYcaT/subscriptions","organizations_url":"https://api.github.com/users/sHaggYcaT/orgs","repos_url":"https://api.github.com/users/sHaggYcaT/repos","events_url":"https://api.github.com/users/sHaggYcaT/events{/privacy}","received_events_url":"https://api.github.com/users/sHaggYcaT/received_events","type":"User","site_admin":false},"repo":{"id":159143028,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkxNDMwMjg=","name":"kubevirt-ansible","full_name":"sHaggYcaT/kubevirt-ansible","private":false,"owner":{"login":"sHaggYcaT","id":5021404,"node_id":"MDQ6VXNlcjUwMjE0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5021404?v=4","gravatar_id":"","url":"https://api.github.com/users/sHaggYcaT","html_url":"https://github.com/sHaggYcaT","followers_url":"https://api.github.com/users/sHaggYcaT/followers","following_url":"https://api.github.com/users/sHaggYcaT/following{/other_user}","gists_url":"https://api.github.com/users/sHaggYcaT/gists{/gist_id}","starred_url":"https://api.github.com/users/sHaggYcaT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sHaggYcaT/subscriptions","organizations_url":"https://api.github.com/users/sHaggYcaT/orgs","repos_url":"https://api.github.com/users/sHaggYcaT/repos","events_url":"https://api.github.com/users/sHaggYcaT/events{/privacy}","received_events_url":"https://api.github.com/users/sHaggYcaT/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sHaggYcaT/kubevirt-ansible","description":"Set of Ansible roles & playbooks for KubeVirt deployment","fork":true,"url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible","forks_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/forks","keys_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/teams","hooks_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/hooks","issue_events_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/events","assignees_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/tags","blobs_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/languages","stargazers_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/stargazers","contributors_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/contributors","subscribers_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/subscribers","subscription_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/subscription","commits_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/merges","archive_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/downloads","issues_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/labels{/name}","releases_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/sHaggYcaT/kubevirt-ansible/deployments","created_at":"2018-11-26T09:24:46Z","updated_at":"2018-11-26T09:24:49Z","pushed_at":"2018-11-26T09:30:39Z","git_url":"git://github.com/sHaggYcaT/kubevirt-ansible.git","ssh_url":"git@github.com:sHaggYcaT/kubevirt-ansible.git","clone_url":"https://github.com/sHaggYcaT/kubevirt-ansible.git","svn_url":"https://github.com/sHaggYcaT/kubevirt-ansible","homepage":"","size":79861,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"840b1abb0315fb8808d20a0ac6268e0c5805c36a","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":103531813,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM1MzE4MTM=","name":"kubevirt-ansible","full_name":"kubevirt/kubevirt-ansible","private":false,"owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubevirt/kubevirt-ansible","description":"Set of Ansible roles & playbooks for KubeVirt deployment","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt-ansible","forks_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/deployments","created_at":"2017-09-14T12:52:28Z","updated_at":"2018-11-20T09:22:59Z","pushed_at":"2018-11-26T14:27:11Z","git_url":"git://github.com/kubevirt/kubevirt-ansible.git","ssh_url":"git@github.com:kubevirt/kubevirt-ansible.git","clone_url":"https://github.com/kubevirt/kubevirt-ansible.git","svn_url":"https://github.com/kubevirt/kubevirt-ansible","homepage":"","size":79859,"stargazers_count":35,"watchers_count":35,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":54,"open_issues":61,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/484"},"html":{"href":"https://github.com/kubevirt/kubevirt-ansible/pull/484"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/484"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/484/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/484/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/484/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/statuses/151d2571c3cab1fa0889870f02d35bfdfc3693e4"}},"author_association":"NONE"}}
{"actor":{"display_login":"petrkotas"}}