{"action":"created","issue":{"url":"https://api.github.com/repos/ChrisKian/liferay-portal/issues/29","repository_url":"https://api.github.com/repos/ChrisKian/liferay-portal","labels_url":"https://api.github.com/repos/ChrisKian/liferay-portal/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/ChrisKian/liferay-portal/issues/29/comments","events_url":"https://api.github.com/repos/ChrisKian/liferay-portal/issues/29/events","html_url":"https://github.com/ChrisKian/liferay-portal/pull/29","id":302534581,"number":29,"title":"LPS-78476 - Web content search does not visually differentiate between different files with the same name.","user":{"login":"wanderlast","id":1923745,"avatar_url":"https://avatars0.githubusercontent.com/u/1923745?v=4","gravatar_id":"","url":"https://api.github.com/users/wanderlast","html_url":"https://github.com/wanderlast","followers_url":"https://api.github.com/users/wanderlast/followers","following_url":"https://api.github.com/users/wanderlast/following{/other_user}","gists_url":"https://api.github.com/users/wanderlast/gists{/gist_id}","starred_url":"https://api.github.com/users/wanderlast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanderlast/subscriptions","organizations_url":"https://api.github.com/users/wanderlast/orgs","repos_url":"https://api.github.com/users/wanderlast/repos","events_url":"https://api.github.com/users/wanderlast/events{/privacy}","received_events_url":"https://api.github.com/users/wanderlast/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-06T02:01:53Z","updated_at":"2018-03-06T03:51:11Z","closed_at":"2018-03-06T03:51:10Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ChrisKian/liferay-portal/pulls/29","html_url":"https://github.com/ChrisKian/liferay-portal/pull/29","diff_url":"https://github.com/ChrisKian/liferay-portal/pull/29.diff","patch_url":"https://github.com/ChrisKian/liferay-portal/pull/29.patch"},"body":"Hi Chris!\r\n\r\nLPP: https://issues.liferay.com/browse/LPP-29068\r\nLPS: https://issues.liferay.com/browse/LPS-78476\r\n\r\nThe issue being addressed in this PR is that content with identical titles, but different folder locations/content are indistinguishable in web content search. The solution was to re-add the breadcrumbs back to the search results which was done in accordance with the suggestions made by the Lexicon team in https://issues.liferay.com/browse/PTR-276. Breadcrumb 1 already exists, so only breadcrumb 2 was added.\r\n\r\nPlease let me know if you have any questions or concerns. Thanks!"},"comment":{"url":"https://api.github.com/repos/ChrisKian/liferay-portal/issues/comments/370653616","html_url":"https://github.com/ChrisKian/liferay-portal/pull/29#issuecomment-370653616","issue_url":"https://api.github.com/repos/ChrisKian/liferay-portal/issues/29","id":370653616,"user":{"login":"liferay-continuous-integration","id":4502793,"avatar_url":"https://avatars2.githubusercontent.com/u/4502793?v=4","gravatar_id":"","url":"https://api.github.com/users/liferay-continuous-integration","html_url":"https://github.com/liferay-continuous-integration","followers_url":"https://api.github.com/users/liferay-continuous-integration/followers","following_url":"https://api.github.com/users/liferay-continuous-integration/following{/other_user}","gists_url":"https://api.github.com/users/liferay-continuous-integration/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-continuous-integration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-continuous-integration/subscriptions","organizations_url":"https://api.github.com/users/liferay-continuous-integration/orgs","repos_url":"https://api.github.com/users/liferay-continuous-integration/repos","events_url":"https://api.github.com/users/liferay-continuous-integration/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-continuous-integration/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T03:51:11Z","updated_at":"2018-03-06T03:51:11Z","author_association":"COLLABORATOR","body":"<h1>The pull request tester is still running.</h1><p>Please wait until you get the <i><b>final report</b></i> before running 'ci:retest'.</p><p>See this link to check on the status of your test:</p><ul><li><a href=\"https://test-1-22.liferay.com/job/test-portal-acceptance-pullrequest(master)/789/\">test-portal-acceptance-pullrequest(master)</a></li></ul><p>@wanderlast</p><hr /><h1>However, the pull request was closed.</h1><p>The pull request was closed because the following critical batches had failed:</p><ul><li><a href=\"https://test-1-14.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/212890/\">source-format-jdk8</a></li></ul><p>For information as to why we automatically close out certain pull requests see this <a href=\"https://in.liferay.com/web/global.engineering/wiki/-/wiki/Quality+Assurance+Main/Test+Batch+Automatic+Close+List\">article</a>.</p><p auto-close=\"false\"><strong><em>*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.</em></strong></p><pre>ci&#58;reopen</pre><hr /><h3>Critical Failure Details:</h3><div><h5><a href=\"https://test-1-14.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/212890/\">test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8</a></h5><div><h6>Job Results:</h6><p>0 Tests Passed.<br/>1 Test Failed.</p></div><ol><li><div><a href=\"https://test-1-14.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/212890//consoleText\">AXIS_VARIABLE=0,label_exp=!master #212890</a><pre><code>     [exec] :util:source-formatter:compileJavaNote: Recompile with -Xlint:deprecation for details.\n     [exec] :util:source-formatter:buildCSS UP-TO-DATE\n     [exec] \n     [exec] Note: Some input files use unchecked or unsafe operations.\n     [exec] Note: Recompile with -Xlint:unchecked for details.\n     [exec] :util:source-formatter:processResources\n     [exec] :util:source-formatter:transpileJS SKIPPED\n     [exec] :util:source-formatter:configJSModules SKIPPED\n     [exec] :util:source-formatter:copyLibs SKIPPED\n     [exec] :util:source-formatter:replaceSoyTranslation UP-TO-DATE\n     [exec] :util:source-formatter:wrapSoyAlloyTemplate SKIPPED\n     [exec] :util:source-formatter:classes\n     [exec] :util:source-formatter:jar\n     [exec] :util:source-formatter:deploy\n     [exec] Files of project ':util:source-formatter' deployed to /opt/dev/projects/github/liferay-portal/tools/sdk/dependencies/com.liferay.source.formatter/lib\n     [exec] :util:source-formatter:deployDependencies UP-TO-DATE\n     [exec] \n     [exec] BUILD SUCCESSFUL\n     [exec] \n     [exec] Total time: 12.118 secs\n     [exec] Gradle build finished at 2018-03-06 03:46:58.361.\n     [exec] \n     [echo] Running com.liferay.source.formatter.jar 1.0.560.\n\nformat-source-all:\n     [java] Loading file:/opt/dev/projects/github/liferay-portal/portal-impl/classes/system.properties\n     [java] SLF4J: Class path contains multiple SLF4J bindings.\n     [java] SLF4J: Found binding in [file:/opt/dev/projects/github/liferay-portal/util-slf4j/classes/org/slf4j/impl/StaticLoggerBinder.class]\n     [java] SLF4J: Found binding in [jar:file:/opt/dev/projects/github/liferay-portal/lib/development/slf4j-simple.jar!/org/slf4j/impl/StaticLoggerBinder.class]\n     [java] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.\n     [java] SLF4J: Actual binding is of type [com.liferay.util.sl4fj.LiferayLoggerFactory]\n     [java] Exception in thread \"main\" java.lang.Exception: Found 1 formatting issues:\n     [java] 1: ./modules/apps/web-experience/journal/journal-web/src/main/resources/META-INF/resources/view_entries.jsp expected:&lt;...ayContext.isSearch()[ ]%&gt;\"&gt;\n     [java] \t\t\t\t\t\t\t\t&lt;h5&gt;\n     [java] \t\t...&gt; but was:&lt;...ayContext.isSearch()[]%&gt;\"&gt;\n     [java] \t\t\t\t\t\t\t\t&lt;h5&gt;\n     [java] \t\t...&gt;\n     [java] \n     [java] \tat com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:374)\n     [java] \tat com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:216)</code></pre></div></li></ol></div>"}}
{"actor":{"display_login":"liferay-continuous-integration"}}