{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/37869","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/37869/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/37869/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/37869/events","html_url":"https://github.com/ansible/ansible/pull/37869","id":308241785,"number":37869,"title":"add vmware_guest support for multiple cdroms","user":{"login":"phemmer","id":1826947,"avatar_url":"https://avatars3.githubusercontent.com/u/1826947?v=4","gravatar_id":"","url":"https://api.github.com/users/phemmer","html_url":"https://github.com/phemmer","followers_url":"https://api.github.com/users/phemmer/followers","following_url":"https://api.github.com/users/phemmer/following{/other_user}","gists_url":"https://api.github.com/users/phemmer/gists{/gist_id}","starred_url":"https://api.github.com/users/phemmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phemmer/subscriptions","organizations_url":"https://api.github.com/users/phemmer/orgs","repos_url":"https://api.github.com/users/phemmer/repos","events_url":"https://api.github.com/users/phemmer/events{/privacy}","received_events_url":"https://api.github.com/users/phemmer/received_events","type":"User","site_admin":false},"labels":[{"id":61528803,"url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":852590921,"url":"https://api.github.com/repos/ansible/ansible/labels/feature","name":"feature","color":"006b75","default":false},{"id":496359346,"url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":61436281,"url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":723150340,"url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"ededed","default":false},{"id":581543918,"url":"https://api.github.com/repos/ansible/ansible/labels/stale_ci","name":"stale_ci","color":"fef2c0","default":false},{"id":638933140,"url":"https://api.github.com/repos/ansible/ansible/labels/stale_review","name":"stale_review","color":"ededed","default":false},{"id":636327968,"url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":468273802,"url":"https://api.github.com/repos/ansible/ansible/labels/test","name":"test","color":"0e8a16","default":false},{"id":427121291,"url":"https://api.github.com/repos/ansible/ansible/labels/vmware","name":"vmware","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-24T09:06:26Z","updated_at":"2018-05-01T18:37:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/37869","html_url":"https://github.com/ansible/ansible/pull/37869","diff_url":"https://github.com/ansible/ansible/pull/37869.diff","patch_url":"https://github.com/ansible/ansible/pull/37869.patch"},"body":"##### SUMMARY\r\nThis adds support for multiple cdrom devices with the vmware_guest module.\r\n\r\nMy use case is to be able to automatically kickstart CentOS VMs. I stumbled across someone else using the exact same method I am [documented here](https://medium.com/@jackprice/pushing-kickstarts-with-ansible-122b2cd9c1e) where your first CDROM drive is the installer ISO, and your second CDROM drive is an ISO with a special label that the installer pulls the `ks.cfg` from.\r\n\r\nGiven that someone wrote an article on exactly what I'm doing, as well as #35665 also trying to do the same thing, It seems this is a common use case.\r\n\r\nThe PR also adds support for removing CD-ROMs.\r\n\r\nAssuming the VM has 2 CD-ROMs, the following will...\r\n* ... do nothing to the CD-ROMs:\r\n```\r\nvmware_guest:\r\n  cdrom:\r\n```\r\n* ... remove all CD-ROMs:\r\n```\r\nvmware_guest:\r\n  cdrom: []\r\n```\r\n* ... ignore the first CD-ROM and re-configure the second one:\r\n```\r\nvmware_guest:\r\n  cdrom:\r\n  - {}\r\n  - type: iso\r\n    iso_path: 'foo'\r\n```\r\n* ... ignore the first CD-ROM and delete the second one:\r\n```\r\nvmware_guest:\r\n  cdrom:\r\n  - {}\r\n```\r\n\r\n&nbsp;\r\n\r\nThis PR also adds 2 bug fixes:\r\n* One to fix an issue when adding multiple controllers. This was originally #37868 but I merged into this PR since this PR depends on it. More details on [the commit](https://github.com/ansible/ansible/pull/37869/commits/d21a53a4c2d830c970060563b9862e36ec667d1a).\r\n* Another issue adding a CD-ROM to an existing ide controller. More details on [the commit](https://github.com/ansible/ansible/pull/37869/commits/0525392f43a426f55fe3d7f699436d85ccdfc532).\r\n\r\n&nbsp;\r\n\r\n[This view](https://github.com/ansible/ansible/pull/37869/files?w=1) will make the PR easier to review.\r\n\r\n##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\nvmware_guest\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\nansible 2.5.0\r\n  config file = None\r\n  configured module search path = [u'/Users/phemmer/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /Users/phemmer/ansible-2.5/lib/python2.7/site-packages/ansible\r\n  executable location = /Users/phemmer/ansible-2.5/bin/ansible\r\n  python version = 2.7.10 (default, Feb  7 2017, 00:08:15) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)]\r\n```"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/385751514","html_url":"https://github.com/ansible/ansible/pull/37869#issuecomment-385751514","issue_url":"https://api.github.com/repos/ansible/ansible/issues/37869","id":385751514,"user":{"login":"ansibot","id":6585283,"avatar_url":"https://avatars0.githubusercontent.com/u/6585283?v=4","gravatar_id":"","url":"https://api.github.com/users/ansibot","html_url":"https://github.com/ansibot","followers_url":"https://api.github.com/users/ansibot/followers","following_url":"https://api.github.com/users/ansibot/following{/other_user}","gists_url":"https://api.github.com/users/ansibot/gists{/gist_id}","starred_url":"https://api.github.com/users/ansibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansibot/subscriptions","organizations_url":"https://api.github.com/users/ansibot/orgs","repos_url":"https://api.github.com/users/ansibot/repos","events_url":"https://api.github.com/users/ansibot/events{/privacy}","received_events_url":"https://api.github.com/users/ansibot/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T18:37:26Z","updated_at":"2018-05-01T18:37:26Z","author_association":"CONTRIBUTOR","body":"cc @warthog9\n[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)\n<!--- boilerplate: notify --->"}}
{"actor":{"display_login":"ansibot"}}