{"action":"created","comment":{"url":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/comments/233008651","pull_request_review_id":174326433,"id":233008651,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzAwODY1MQ==","diff_hunk":"@@ -20,9 +21,19 @@ LowerModulationBoundLabel::~LowerModulationBoundLabel()\n void LowerModulationBoundLabel::updateText(MacroControlParameter *mcParam, ModulateableParameter *modulatedParam)\n {\n   auto rangeDisplayValues = modulatedParam->getModRangeAsDisplayValues();\n+  const auto fine = isHighlight() && Application::get().getHWUI()->isModifierSet(ButtonModifier::FINE);\n+  auto displayValue = rangeDisplayValues.first + (fine ? \" F\" : \"\");\n \n-  if(isHighlight() && Application::get().getHWUI()->isModifierSet(ButtonModifier::FINE))\n-    setText({ rangeDisplayValues.first, \" F\" });\n+  auto textClipped = false;\n+\n+  if(getFont()->getStringWidth(displayValue) >= 55)","path":"playground/src/proxies/hwui/panel-unit/boled/parameter-screens/controls/LowerModulationBoundLabel.cpp","position":19,"original_position":19,"commit_id":"26d6d220bc3f3edf17aba45ec39f391cebf16ef4","original_commit_id":"26d6d220bc3f3edf17aba45ec39f391cebf16ef4","user":{"login":"hhoegelo","id":4928992,"node_id":"MDQ6VXNlcjQ5Mjg5OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4928992?v=4","gravatar_id":"","url":"https://api.github.com/users/hhoegelo","html_url":"https://github.com/hhoegelo","followers_url":"https://api.github.com/users/hhoegelo/followers","following_url":"https://api.github.com/users/hhoegelo/following{/other_user}","gists_url":"https://api.github.com/users/hhoegelo/gists{/gist_id}","starred_url":"https://api.github.com/users/hhoegelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhoegelo/subscriptions","organizations_url":"https://api.github.com/users/hhoegelo/orgs","repos_url":"https://api.github.com/users/hhoegelo/repos","events_url":"https://api.github.com/users/hhoegelo/events{/privacy}","received_events_url":"https://api.github.com/users/hhoegelo/received_events","type":"User","site_admin":false},"body":"55? really?","created_at":"2018-11-13T11:59:50Z","updated_at":"2018-11-13T11:59:51Z","html_url":"https://github.com/nonlinear-labs-dev/C15/pull/540#discussion_r233008651","pull_request_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/540","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/comments/233008651"},"html":{"href":"https://github.com/nonlinear-labs-dev/C15/pull/540#discussion_r233008651"},"pull_request":{"href":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/540"}}},"pull_request":{"url":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/540","id":230127297,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTI3Mjk3","html_url":"https://github.com/nonlinear-labs-dev/C15/pull/540","diff_url":"https://github.com/nonlinear-labs-dev/C15/pull/540.diff","patch_url":"https://github.com/nonlinear-labs-dev/C15/pull/540.patch","issue_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/issues/540","number":540,"state":"open","locked":false,"title":"reintroduced remove spaces and added more specific cropping logic in …","user":{"login":"schlenkibus","id":15381257,"node_id":"MDQ6VXNlcjE1MzgxMjU3","avatar_url":"https://avatars2.githubusercontent.com/u/15381257?v=4","gravatar_id":"","url":"https://api.github.com/users/schlenkibus","html_url":"https://github.com/schlenkibus","followers_url":"https://api.github.com/users/schlenkibus/followers","following_url":"https://api.github.com/users/schlenkibus/following{/other_user}","gists_url":"https://api.github.com/users/schlenkibus/gists{/gist_id}","starred_url":"https://api.github.com/users/schlenkibus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlenkibus/subscriptions","organizations_url":"https://api.github.com/users/schlenkibus/orgs","repos_url":"https://api.github.com/users/schlenkibus/repos","events_url":"https://api.github.com/users/schlenkibus/events{/privacy}","received_events_url":"https://api.github.com/users/schlenkibus/received_events","type":"User","site_admin":false},"body":"#539 ","created_at":"2018-11-12T13:03:52Z","updated_at":"2018-11-13T11:59:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18b8385798b558d5fa83e9c6dc7247bed96d775d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/540/commits","review_comments_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/540/comments","review_comment_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/issues/540/comments","statuses_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/statuses/26d6d220bc3f3edf17aba45ec39f391cebf16ef4","head":{"label":"nonlinear-labs-dev:539","ref":"539","sha":"26d6d220bc3f3edf17aba45ec39f391cebf16ef4","user":{"login":"nonlinear-labs-dev","id":35134926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTM0OTI2","avatar_url":"https://avatars3.githubusercontent.com/u/35134926?v=4","gravatar_id":"","url":"https://api.github.com/users/nonlinear-labs-dev","html_url":"https://github.com/nonlinear-labs-dev","followers_url":"https://api.github.com/users/nonlinear-labs-dev/followers","following_url":"https://api.github.com/users/nonlinear-labs-dev/following{/other_user}","gists_url":"https://api.github.com/users/nonlinear-labs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/nonlinear-labs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonlinear-labs-dev/subscriptions","organizations_url":"https://api.github.com/users/nonlinear-labs-dev/orgs","repos_url":"https://api.github.com/users/nonlinear-labs-dev/repos","events_url":"https://api.github.com/users/nonlinear-labs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/nonlinear-labs-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":116378035,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYzNzgwMzU=","name":"C15","full_name":"nonlinear-labs-dev/C15","private":false,"owner":{"login":"nonlinear-labs-dev","id":35134926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTM0OTI2","avatar_url":"https://avatars3.githubusercontent.com/u/35134926?v=4","gravatar_id":"","url":"https://api.github.com/users/nonlinear-labs-dev","html_url":"https://github.com/nonlinear-labs-dev","followers_url":"https://api.github.com/users/nonlinear-labs-dev/followers","following_url":"https://api.github.com/users/nonlinear-labs-dev/following{/other_user}","gists_url":"https://api.github.com/users/nonlinear-labs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/nonlinear-labs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonlinear-labs-dev/subscriptions","organizations_url":"https://api.github.com/users/nonlinear-labs-dev/orgs","repos_url":"https://api.github.com/users/nonlinear-labs-dev/repos","events_url":"https://api.github.com/users/nonlinear-labs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/nonlinear-labs-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nonlinear-labs-dev/C15","description":null,"fork":false,"url":"https://api.github.com/repos/nonlinear-labs-dev/C15","forks_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/forks","keys_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/teams","hooks_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/hooks","issue_events_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/issues/events{/number}","events_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/events","assignees_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/assignees{/user}","branches_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/branches{/branch}","tags_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/tags","blobs_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/git/refs{/sha}","trees_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/statuses/{sha}","languages_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/languages","stargazers_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/stargazers","contributors_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/contributors","subscribers_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/subscribers","subscription_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/subscription","commits_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/commits{/sha}","git_commits_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/git/commits{/sha}","comments_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/comments{/number}","issue_comment_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/issues/comments{/number}","contents_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/contents/{+path}","compare_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/merges","archive_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/downloads","issues_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/issues{/number}","pulls_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls{/number}","milestones_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/milestones{/number}","notifications_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/labels{/name}","releases_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/releases{/id}","deployments_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/deployments","created_at":"2018-01-05T11:27:48Z","updated_at":"2018-10-25T10:28:13Z","pushed_at":"2018-11-13T11:58:58Z","git_url":"git://github.com/nonlinear-labs-dev/C15.git","ssh_url":"git@github.com:nonlinear-labs-dev/C15.git","clone_url":"https://github.com/nonlinear-labs-dev/C15.git","svn_url":"https://github.com/nonlinear-labs-dev/C15","homepage":"http://www.nonlinearlabs.com/","size":60614,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":34,"license":null,"forks":1,"open_issues":34,"watchers":2,"default_branch":"master"}},"base":{"label":"nonlinear-labs-dev:RELEASE-2018-08","ref":"RELEASE-2018-08","sha":"1a8699a9f96703b3aff3c2639b54e9582a765e70","user":{"login":"nonlinear-labs-dev","id":35134926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTM0OTI2","avatar_url":"https://avatars3.githubusercontent.com/u/35134926?v=4","gravatar_id":"","url":"https://api.github.com/users/nonlinear-labs-dev","html_url":"https://github.com/nonlinear-labs-dev","followers_url":"https://api.github.com/users/nonlinear-labs-dev/followers","following_url":"https://api.github.com/users/nonlinear-labs-dev/following{/other_user}","gists_url":"https://api.github.com/users/nonlinear-labs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/nonlinear-labs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonlinear-labs-dev/subscriptions","organizations_url":"https://api.github.com/users/nonlinear-labs-dev/orgs","repos_url":"https://api.github.com/users/nonlinear-labs-dev/repos","events_url":"https://api.github.com/users/nonlinear-labs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/nonlinear-labs-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":116378035,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYzNzgwMzU=","name":"C15","full_name":"nonlinear-labs-dev/C15","private":false,"owner":{"login":"nonlinear-labs-dev","id":35134926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTM0OTI2","avatar_url":"https://avatars3.githubusercontent.com/u/35134926?v=4","gravatar_id":"","url":"https://api.github.com/users/nonlinear-labs-dev","html_url":"https://github.com/nonlinear-labs-dev","followers_url":"https://api.github.com/users/nonlinear-labs-dev/followers","following_url":"https://api.github.com/users/nonlinear-labs-dev/following{/other_user}","gists_url":"https://api.github.com/users/nonlinear-labs-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/nonlinear-labs-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonlinear-labs-dev/subscriptions","organizations_url":"https://api.github.com/users/nonlinear-labs-dev/orgs","repos_url":"https://api.github.com/users/nonlinear-labs-dev/repos","events_url":"https://api.github.com/users/nonlinear-labs-dev/events{/privacy}","received_events_url":"https://api.github.com/users/nonlinear-labs-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nonlinear-labs-dev/C15","description":null,"fork":false,"url":"https://api.github.com/repos/nonlinear-labs-dev/C15","forks_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/forks","keys_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/teams","hooks_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/hooks","issue_events_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/issues/events{/number}","events_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/events","assignees_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/assignees{/user}","branches_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/branches{/branch}","tags_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/tags","blobs_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/git/refs{/sha}","trees_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/statuses/{sha}","languages_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/languages","stargazers_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/stargazers","contributors_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/contributors","subscribers_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/subscribers","subscription_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/subscription","commits_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/commits{/sha}","git_commits_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/git/commits{/sha}","comments_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/comments{/number}","issue_comment_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/issues/comments{/number}","contents_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/contents/{+path}","compare_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/merges","archive_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/downloads","issues_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/issues{/number}","pulls_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls{/number}","milestones_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/milestones{/number}","notifications_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/labels{/name}","releases_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/releases{/id}","deployments_url":"https://api.github.com/repos/nonlinear-labs-dev/C15/deployments","created_at":"2018-01-05T11:27:48Z","updated_at":"2018-10-25T10:28:13Z","pushed_at":"2018-11-13T11:58:58Z","git_url":"git://github.com/nonlinear-labs-dev/C15.git","ssh_url":"git@github.com:nonlinear-labs-dev/C15.git","clone_url":"https://github.com/nonlinear-labs-dev/C15.git","svn_url":"https://github.com/nonlinear-labs-dev/C15","homepage":"http://www.nonlinearlabs.com/","size":60614,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":34,"license":null,"forks":1,"open_issues":34,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/540"},"html":{"href":"https://github.com/nonlinear-labs-dev/C15/pull/540"},"issue":{"href":"https://api.github.com/repos/nonlinear-labs-dev/C15/issues/540"},"comments":{"href":"https://api.github.com/repos/nonlinear-labs-dev/C15/issues/540/comments"},"review_comments":{"href":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/540/comments"},"review_comment":{"href":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nonlinear-labs-dev/C15/pulls/540/commits"},"statuses":{"href":"https://api.github.com/repos/nonlinear-labs-dev/C15/statuses/26d6d220bc3f3edf17aba45ec39f391cebf16ef4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hhoegelo"}}