{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/196576165","pull_request_review_id":130156993,"id":196576165,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjU3NjE2NQ==","diff_hunk":"@@ -322,13 +322,12 @@ func ensureSandboxImageExists(client libdocker.Interface, image string) error {\n \t\treturn fmt.Errorf(\"failed to inspect sandbox image %q: %v\", image, err)\n \t}\n \n-\trepoToPull, _, _, err := parsers.ParseImageName(image)\n-\tif err != nil {\n+\tif _, _, _, err := parsers.ParseImageName(image); err != nil {\n \t\treturn err\n \t}\n \n \tkeyring := credentialprovider.NewDockerKeyring()\n-\tcreds, withCredentials := keyring.Lookup(repoToPull)\n+\tcreds, withCredentials := keyring.Lookup(image)","path":"vendor/k8s.io/kubernetes/pkg/kubelet/dockershim/helpers.go","position":12,"original_position":12,"commit_id":"474acaae2557040e744d90b6f096ac8f72c6dafa","original_commit_id":"474acaae2557040e744d90b6f096ac8f72c6dafa","user":{"login":"derekwaynecarr","id":6233452,"node_id":"MDQ6VXNlcjYyMzM0NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"body":"also need to know what credentials are used in this case by docker daemon.","created_at":"2018-06-19T20:58:20Z","updated_at":"2018-06-19T20:58:20Z","html_url":"https://github.com/openshift/origin/pull/20028#discussion_r196576165","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/20028","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/196576165"},"html":{"href":"https://github.com/openshift/origin/pull/20028#discussion_r196576165"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/20028"}},"in_reply_to_id":196575333},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/20028","id":195529691,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NTI5Njkx","html_url":"https://github.com/openshift/origin/pull/20028","diff_url":"https://github.com/openshift/origin/pull/20028.diff","patch_url":"https://github.com/openshift/origin/pull/20028.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/20028","number":20028,"state":"open","locked":false,"title":"[WIP] UPSTREAM: docker/client: <carry>: disable image ref normalisation","user":{"login":"frobware","id":943903,"node_id":"MDQ6VXNlcjk0MzkwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/943903?v=4","gravatar_id":"","url":"https://api.github.com/users/frobware","html_url":"https://github.com/frobware","followers_url":"https://api.github.com/users/frobware/followers","following_url":"https://api.github.com/users/frobware/following{/other_user}","gists_url":"https://api.github.com/users/frobware/gists{/gist_id}","starred_url":"https://api.github.com/users/frobware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frobware/subscriptions","organizations_url":"https://api.github.com/users/frobware/orgs","repos_url":"https://api.github.com/users/frobware/repos","events_url":"https://api.github.com/users/frobware/events{/privacy}","received_events_url":"https://api.github.com/users/frobware/received_events","type":"User","site_admin":false},"body":"Remove normalisation of image refs in calls to ImagePull.\r\n\r\nCalls to k8s.io/kubernetes/pkg/util/parsers.ParseImage() or\r\ndocker/reference.ParseNormalizedNamed() will automatically qualify\r\nunqualified image references with \"docker.io\". This commit continues\r\nto use ParseNormalizedNamed() but only for a validity check. If the\r\nimage reference is valid it will use the original unqualified name\r\nwhen making queries against the docker client API ensuring that calls\r\nlike:\r\n\r\n  $ oc run test --image=openshift3/metrics-heapster\r\n\r\ndon't automatically turn into:\r\n\r\n  $ oc run test --image=docker.io/openshift3/metrics-heapster\r\n\r\nFixes: https://bugzilla.redhat.com/show_bug.cgi?id=1583500","created_at":"2018-06-18T13:42:46Z","updated_at":"2018-06-19T20:58:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"923e9c787b198dc1ea4dd61592d2dbf190eef038","assignee":null,"assignees":[],"requested_reviewers":[{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":686389978,"node_id":"MDU6TGFiZWw2ODYzODk5Nzg=","url":"https://api.github.com/repos/openshift/origin/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":640547984,"node_id":"MDU6TGFiZWw2NDA1NDc5ODQ=","url":"https://api.github.com/repos/openshift/origin/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/20028/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/20028/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/20028/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/474acaae2557040e744d90b6f096ac8f72c6dafa","head":{"label":"frobware:remove-image-normalisation-in-pullimage-bz1583500-v0","ref":"remove-image-normalisation-in-pullimage-bz1583500-v0","sha":"474acaae2557040e744d90b6f096ac8f72c6dafa","user":{"login":"frobware","id":943903,"node_id":"MDQ6VXNlcjk0MzkwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/943903?v=4","gravatar_id":"","url":"https://api.github.com/users/frobware","html_url":"https://github.com/frobware","followers_url":"https://api.github.com/users/frobware/followers","following_url":"https://api.github.com/users/frobware/following{/other_user}","gists_url":"https://api.github.com/users/frobware/gists{/gist_id}","starred_url":"https://api.github.com/users/frobware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frobware/subscriptions","organizations_url":"https://api.github.com/users/frobware/orgs","repos_url":"https://api.github.com/users/frobware/repos","events_url":"https://api.github.com/users/frobware/events{/privacy}","received_events_url":"https://api.github.com/users/frobware/received_events","type":"User","site_admin":false},"repo":{"id":98121063,"node_id":"MDEwOlJlcG9zaXRvcnk5ODEyMTA2Mw==","name":"origin","full_name":"frobware/origin","owner":{"login":"frobware","id":943903,"node_id":"MDQ6VXNlcjk0MzkwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/943903?v=4","gravatar_id":"","url":"https://api.github.com/users/frobware","html_url":"https://github.com/frobware","followers_url":"https://api.github.com/users/frobware/followers","following_url":"https://api.github.com/users/frobware/following{/other_user}","gists_url":"https://api.github.com/users/frobware/gists{/gist_id}","starred_url":"https://api.github.com/users/frobware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frobware/subscriptions","organizations_url":"https://api.github.com/users/frobware/orgs","repos_url":"https://api.github.com/users/frobware/repos","events_url":"https://api.github.com/users/frobware/events{/privacy}","received_events_url":"https://api.github.com/users/frobware/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frobware/origin","description":"Enterprise Kubernetes for Developers","fork":true,"url":"https://api.github.com/repos/frobware/origin","forks_url":"https://api.github.com/repos/frobware/origin/forks","keys_url":"https://api.github.com/repos/frobware/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frobware/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frobware/origin/teams","hooks_url":"https://api.github.com/repos/frobware/origin/hooks","issue_events_url":"https://api.github.com/repos/frobware/origin/issues/events{/number}","events_url":"https://api.github.com/repos/frobware/origin/events","assignees_url":"https://api.github.com/repos/frobware/origin/assignees{/user}","branches_url":"https://api.github.com/repos/frobware/origin/branches{/branch}","tags_url":"https://api.github.com/repos/frobware/origin/tags","blobs_url":"https://api.github.com/repos/frobware/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frobware/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frobware/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/frobware/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frobware/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/frobware/origin/languages","stargazers_url":"https://api.github.com/repos/frobware/origin/stargazers","contributors_url":"https://api.github.com/repos/frobware/origin/contributors","subscribers_url":"https://api.github.com/repos/frobware/origin/subscribers","subscription_url":"https://api.github.com/repos/frobware/origin/subscription","commits_url":"https://api.github.com/repos/frobware/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/frobware/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/frobware/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/frobware/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/frobware/origin/contents/{+path}","compare_url":"https://api.github.com/repos/frobware/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frobware/origin/merges","archive_url":"https://api.github.com/repos/frobware/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frobware/origin/downloads","issues_url":"https://api.github.com/repos/frobware/origin/issues{/number}","pulls_url":"https://api.github.com/repos/frobware/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/frobware/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/frobware/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frobware/origin/labels{/name}","releases_url":"https://api.github.com/repos/frobware/origin/releases{/id}","deployments_url":"https://api.github.com/repos/frobware/origin/deployments","created_at":"2017-07-23T19:40:30Z","updated_at":"2017-07-23T19:40:58Z","pushed_at":"2018-06-19T09:40:51Z","git_url":"git://github.com/frobware/origin.git","ssh_url":"git@github.com:frobware/origin.git","clone_url":"https://github.com/frobware/origin.git","svn_url":"https://github.com/frobware/origin","homepage":"http://www.openshift.org","size":904193,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"8bf827481ff4137304c9da20fb14bfde3d34d441","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ0MjY2OA==","name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2018-06-19T19:48:57Z","pushed_at":"2018-06-19T20:32:56Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":908976,"stargazers_count":4682,"watchers_count":4682,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2907,"mirror_url":null,"archived":false,"open_issues_count":730,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2907,"open_issues":730,"watchers":4682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/20028"},"html":{"href":"https://github.com/openshift/origin/pull/20028"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/20028"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/20028/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/20028/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/20028/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/474acaae2557040e744d90b6f096ac8f72c6dafa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"derekwaynecarr"}}