{"action":"created","comment":{"url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/comments/189512045","pull_request_review_id":121700890,"id":189512045,"diff_hunk":"@@ -154,14 +154,14 @@ def test_add_text_index(self):\n                           index_factory=OkapiIndex, lexicon_id='lexicon')\n         catalog.addIndex('id', idx)\n         i = catalog.indexes['id']\n-        self.assert_(isinstance(i, ZCTextIndex))\n+        self.assertTrue(isinstance(i, ZCTextIndex))\n \n     def test_add_keyword_index(self):\n         catalog = self._make_one()\n         idx = KeywordIndex('id')\n         catalog.addIndex('id', idx)\n         i = catalog.indexes['id']\n-        self.assert_(isinstance(i, KeywordIndex))\n+        self.assertTrue(isinstance(i, KeywordIndex))","path":"src/Products/ZCatalog/tests/test_catalog.py","position":58,"original_position":58,"commit_id":"530180db3b9bf5397f087f2415c29c987cbcce91","original_commit_id":"4d3d01da1f1739d9927d0daf1ec429d833b2aaa7","user":{"login":"sallner","id":17002572,"avatar_url":"https://avatars2.githubusercontent.com/u/17002572?v=4","gravatar_id":"","url":"https://api.github.com/users/sallner","html_url":"https://github.com/sallner","followers_url":"https://api.github.com/users/sallner/followers","following_url":"https://api.github.com/users/sallner/following{/other_user}","gists_url":"https://api.github.com/users/sallner/gists{/gist_id}","starred_url":"https://api.github.com/users/sallner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sallner/subscriptions","organizations_url":"https://api.github.com/users/sallner/orgs","repos_url":"https://api.github.com/users/sallner/repos","events_url":"https://api.github.com/users/sallner/events{/privacy}","received_events_url":"https://api.github.com/users/sallner/received_events","type":"User","site_admin":false},"body":"This line could also use `assertIsInstance`.","created_at":"2018-05-21T07:22:53Z","updated_at":"2018-05-21T08:02:26Z","html_url":"https://github.com/zopefoundation/Products.ZCatalog/pull/38#discussion_r189512045","pull_request_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/38","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/comments/189512045"},"html":{"href":"https://github.com/zopefoundation/Products.ZCatalog/pull/38#discussion_r189512045"},"pull_request":{"href":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/38","id":188788786,"html_url":"https://github.com/zopefoundation/Products.ZCatalog/pull/38","diff_url":"https://github.com/zopefoundation/Products.ZCatalog/pull/38.diff","patch_url":"https://github.com/zopefoundation/Products.ZCatalog/pull/38.patch","issue_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/issues/38","number":38,"state":"open","locked":false,"title":"Fix deprecation warnings","user":{"login":"andbag","id":2902094,"avatar_url":"https://avatars1.githubusercontent.com/u/2902094?v=4","gravatar_id":"","url":"https://api.github.com/users/andbag","html_url":"https://github.com/andbag","followers_url":"https://api.github.com/users/andbag/followers","following_url":"https://api.github.com/users/andbag/following{/other_user}","gists_url":"https://api.github.com/users/andbag/gists{/gist_id}","starred_url":"https://api.github.com/users/andbag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andbag/subscriptions","organizations_url":"https://api.github.com/users/andbag/orgs","repos_url":"https://api.github.com/users/andbag/repos","events_url":"https://api.github.com/users/andbag/events{/privacy}","received_events_url":"https://api.github.com/users/andbag/received_events","type":"User","site_admin":false},"body":"Unfortunately I have currently no time to increase the code coverage of the tests.","created_at":"2018-05-17T16:09:54Z","updated_at":"2018-05-21T08:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cfbfcac2af70a229352a88b2e51dbf997220546","assignee":null,"assignees":[],"requested_reviewers":[{"login":"icemac","id":386619,"avatar_url":"https://avatars1.githubusercontent.com/u/386619?v=4","gravatar_id":"","url":"https://api.github.com/users/icemac","html_url":"https://github.com/icemac","followers_url":"https://api.github.com/users/icemac/followers","following_url":"https://api.github.com/users/icemac/following{/other_user}","gists_url":"https://api.github.com/users/icemac/gists{/gist_id}","starred_url":"https://api.github.com/users/icemac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icemac/subscriptions","organizations_url":"https://api.github.com/users/icemac/orgs","repos_url":"https://api.github.com/users/icemac/repos","events_url":"https://api.github.com/users/icemac/events{/privacy}","received_events_url":"https://api.github.com/users/icemac/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/38/commits","review_comments_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/38/comments","review_comment_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/issues/38/comments","statuses_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/statuses/530180db3b9bf5397f087f2415c29c987cbcce91","head":{"label":"zopefoundation:andbag-fix-deprecation","ref":"andbag-fix-deprecation","sha":"530180db3b9bf5397f087f2415c29c987cbcce91","user":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars1.githubusercontent.com/u/1163184?v=4","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":8435559,"name":"Products.ZCatalog","full_name":"zopefoundation/Products.ZCatalog","owner":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars1.githubusercontent.com/u/1163184?v=4","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zopefoundation/Products.ZCatalog","description":"Zope's indexing and search solution.","fork":false,"url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog","forks_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/forks","keys_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/teams","hooks_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/hooks","issue_events_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/issues/events{/number}","events_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/events","assignees_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/assignees{/user}","branches_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/branches{/branch}","tags_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/tags","blobs_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/statuses/{sha}","languages_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/languages","stargazers_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/stargazers","contributors_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/contributors","subscribers_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/subscribers","subscription_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/subscription","commits_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/contents/{+path}","compare_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/merges","archive_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/downloads","issues_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/issues{/number}","pulls_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls{/number}","milestones_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/milestones{/number}","notifications_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/labels{/name}","releases_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/releases{/id}","deployments_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/deployments","created_at":"2013-02-26T15:33:20Z","updated_at":"2018-04-29T07:45:50Z","pushed_at":"2018-05-17T21:33:04Z","git_url":"git://github.com/zopefoundation/Products.ZCatalog.git","ssh_url":"git@github.com:zopefoundation/Products.ZCatalog.git","clone_url":"https://github.com/zopefoundation/Products.ZCatalog.git","svn_url":"https://github.com/zopefoundation/Products.ZCatalog","homepage":"","size":1375,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":18,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"zopefoundation:master","ref":"master","sha":"12813b86f32785eec5d08ee673ae363d879f2b4b","user":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars1.githubusercontent.com/u/1163184?v=4","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":8435559,"name":"Products.ZCatalog","full_name":"zopefoundation/Products.ZCatalog","owner":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars1.githubusercontent.com/u/1163184?v=4","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zopefoundation/Products.ZCatalog","description":"Zope's indexing and search solution.","fork":false,"url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog","forks_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/forks","keys_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/teams","hooks_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/hooks","issue_events_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/issues/events{/number}","events_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/events","assignees_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/assignees{/user}","branches_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/branches{/branch}","tags_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/tags","blobs_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/statuses/{sha}","languages_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/languages","stargazers_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/stargazers","contributors_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/contributors","subscribers_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/subscribers","subscription_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/subscription","commits_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/contents/{+path}","compare_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/merges","archive_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/downloads","issues_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/issues{/number}","pulls_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls{/number}","milestones_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/milestones{/number}","notifications_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/labels{/name}","releases_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/releases{/id}","deployments_url":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/deployments","created_at":"2013-02-26T15:33:20Z","updated_at":"2018-04-29T07:45:50Z","pushed_at":"2018-05-17T21:33:04Z","git_url":"git://github.com/zopefoundation/Products.ZCatalog.git","ssh_url":"git@github.com:zopefoundation/Products.ZCatalog.git","clone_url":"https://github.com/zopefoundation/Products.ZCatalog.git","svn_url":"https://github.com/zopefoundation/Products.ZCatalog","homepage":"","size":1375,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":18,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/38"},"html":{"href":"https://github.com/zopefoundation/Products.ZCatalog/pull/38"},"issue":{"href":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/issues/38"},"comments":{"href":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/zopefoundation/Products.ZCatalog/statuses/530180db3b9bf5397f087f2415c29c987cbcce91"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sallner"}}