{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/202405724","pull_request_review_id":137105379,"id":202405724,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQwNTcyNA==","diff_hunk":"@@ -66,7 +67,7 @@ func NewBuilder() resolver.Builder {\n }\n \n type dnsBuilder struct {\n-\t// frequency of polling the DNS server.\n+\t// minimum frequency of polling the DNS server.","path":"resolver/dns/dns_resolver.go","position":13,"original_position":13,"commit_id":"200a09748e352a68929fb9e86d3e19d7b32110ff","original_commit_id":"6611bc51ec0997c55f675dc7dc4035e8358fbd55","user":{"login":"dfawley","id":26072277,"node_id":"MDQ6VXNlcjI2MDcyMjc3","avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false},"body":"Yes, you're right.  The variable is not actually the frequency, it's the interval, hence my confusion.\r\n\r\nI also think we should rename the variable to something to indicate it's a limit now, e.g. \"maxDelay\" or \"minFreq\".","created_at":"2018-07-13T16:29:06Z","updated_at":"2018-07-13T16:29:07Z","html_url":"https://github.com/grpc/grpc-go/pull/2201#discussion_r202405724","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2201","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/202405724"},"html":{"href":"https://github.com/grpc/grpc-go/pull/2201#discussion_r202405724"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2201"}},"in_reply_to_id":200734579},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/2201","id":199104355,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTA0MzU1","html_url":"https://github.com/grpc/grpc-go/pull/2201","diff_url":"https://github.com/grpc/grpc-go/pull/2201.diff","patch_url":"https://github.com/grpc/grpc-go/pull/2201.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/2201","number":2201,"state":"open","locked":false,"title":"dns resolver: exponential retry when getting empty address list","user":{"login":"lyuxuan","id":426013,"node_id":"MDQ6VXNlcjQyNjAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/426013?v=4","gravatar_id":"","url":"https://api.github.com/users/lyuxuan","html_url":"https://github.com/lyuxuan","followers_url":"https://api.github.com/users/lyuxuan/followers","following_url":"https://api.github.com/users/lyuxuan/following{/other_user}","gists_url":"https://api.github.com/users/lyuxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/lyuxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyuxuan/subscriptions","organizations_url":"https://api.github.com/users/lyuxuan/orgs","repos_url":"https://api.github.com/users/lyuxuan/repos","events_url":"https://api.github.com/users/lyuxuan/events{/privacy}","received_events_url":"https://api.github.com/users/lyuxuan/received_events","type":"User","site_admin":false},"body":"fix #1795","created_at":"2018-07-03T23:12:11Z","updated_at":"2018-07-13T16:29:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f066fee46ec1103c64fc5680037c76f6c30f1e8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2201/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2201/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/2201/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/200a09748e352a68929fb9e86d3e19d7b32110ff","head":{"label":"lyuxuan:dnsconfig","ref":"dnsconfig","sha":"200a09748e352a68929fb9e86d3e19d7b32110ff","user":{"login":"lyuxuan","id":426013,"node_id":"MDQ6VXNlcjQyNjAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/426013?v=4","gravatar_id":"","url":"https://api.github.com/users/lyuxuan","html_url":"https://github.com/lyuxuan","followers_url":"https://api.github.com/users/lyuxuan/followers","following_url":"https://api.github.com/users/lyuxuan/following{/other_user}","gists_url":"https://api.github.com/users/lyuxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/lyuxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyuxuan/subscriptions","organizations_url":"https://api.github.com/users/lyuxuan/orgs","repos_url":"https://api.github.com/users/lyuxuan/repos","events_url":"https://api.github.com/users/lyuxuan/events{/privacy}","received_events_url":"https://api.github.com/users/lyuxuan/received_events","type":"User","site_admin":false},"repo":{"id":80772337,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc3MjMzNw==","name":"grpc-go","full_name":"lyuxuan/grpc-go","owner":{"login":"lyuxuan","id":426013,"node_id":"MDQ6VXNlcjQyNjAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/426013?v=4","gravatar_id":"","url":"https://api.github.com/users/lyuxuan","html_url":"https://github.com/lyuxuan","followers_url":"https://api.github.com/users/lyuxuan/followers","following_url":"https://api.github.com/users/lyuxuan/following{/other_user}","gists_url":"https://api.github.com/users/lyuxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/lyuxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyuxuan/subscriptions","organizations_url":"https://api.github.com/users/lyuxuan/orgs","repos_url":"https://api.github.com/users/lyuxuan/repos","events_url":"https://api.github.com/users/lyuxuan/events{/privacy}","received_events_url":"https://api.github.com/users/lyuxuan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lyuxuan/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/lyuxuan/grpc-go","forks_url":"https://api.github.com/repos/lyuxuan/grpc-go/forks","keys_url":"https://api.github.com/repos/lyuxuan/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyuxuan/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyuxuan/grpc-go/teams","hooks_url":"https://api.github.com/repos/lyuxuan/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/lyuxuan/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/lyuxuan/grpc-go/events","assignees_url":"https://api.github.com/repos/lyuxuan/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/lyuxuan/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/lyuxuan/grpc-go/tags","blobs_url":"https://api.github.com/repos/lyuxuan/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyuxuan/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyuxuan/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyuxuan/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyuxuan/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/lyuxuan/grpc-go/languages","stargazers_url":"https://api.github.com/repos/lyuxuan/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/lyuxuan/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/lyuxuan/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/lyuxuan/grpc-go/subscription","commits_url":"https://api.github.com/repos/lyuxuan/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyuxuan/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyuxuan/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyuxuan/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyuxuan/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/lyuxuan/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyuxuan/grpc-go/merges","archive_url":"https://api.github.com/repos/lyuxuan/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyuxuan/grpc-go/downloads","issues_url":"https://api.github.com/repos/lyuxuan/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/lyuxuan/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/lyuxuan/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/lyuxuan/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyuxuan/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/lyuxuan/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/lyuxuan/grpc-go/deployments","created_at":"2017-02-02T21:53:58Z","updated_at":"2018-07-13T00:53:32Z","pushed_at":"2018-07-13T01:23:34Z","git_url":"git://github.com/lyuxuan/grpc-go.git","ssh_url":"git@github.com:lyuxuan/grpc-go.git","clone_url":"https://github.com/lyuxuan/grpc-go.git","svn_url":"https://github.com/lyuxuan/grpc-go","homepage":"","size":7350,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"40cd6b15e2880b88deb091b0fcb091694285fcb0","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTkwNw==","name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2018-07-13T14:39:27Z","pushed_at":"2018-07-13T01:24:23Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":6649,"stargazers_count":5958,"watchers_count":5958,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1146,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1146,"open_issues":92,"watchers":5958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2201"},"html":{"href":"https://github.com/grpc/grpc-go/pull/2201"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/2201"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/2201/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2201/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2201/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/200a09748e352a68929fb9e86d3e19d7b32110ff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dfawley"}}