{"action":"created","comment":{"url":"https://api.github.com/repos/jaywink/socialhome/pulls/comments/170459215","pull_request_review_id":99148951,"id":170459215,"diff_hunk":"@@ -0,0 +1,35 @@\n+import VueRouter from \"vue-router\"\n+import Stream from \"frontend/components/streams/Stream.vue\"\n+\n+\n+function $$(props) {\n+    return route => Object.assign({}, route.params, props)\n+}\n+\n+const routes = [","path":"socialhome/frontend/routes.js","position":9,"original_position":9,"commit_id":"b4bd7625bcfbfe3764f97037aae40cc0dad636e8","original_commit_id":"b4bd7625bcfbfe3764f97037aae40cc0dad636e8","user":{"login":"jaywink","id":1174866,"avatar_url":"https://avatars0.githubusercontent.com/u/1174866?v=4","gravatar_id":"","url":"https://api.github.com/users/jaywink","html_url":"https://github.com/jaywink","followers_url":"https://api.github.com/users/jaywink/followers","following_url":"https://api.github.com/users/jaywink/following{/other_user}","gists_url":"https://api.github.com/users/jaywink/gists{/gist_id}","starred_url":"https://api.github.com/users/jaywink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaywink/subscriptions","organizations_url":"https://api.github.com/users/jaywink/orgs","repos_url":"https://api.github.com/users/jaywink/repos","events_url":"https://api.github.com/users/jaywink/events{/privacy}","received_events_url":"https://api.github.com/users/jaywink/received_events","type":"User","site_admin":false},"body":"This is missing profile pinned (ie default profile view `/u/username/` and also profile `/p/guid/` and also single content `/content/id/shorttext/` - at least, tested locally they produce empty pages.\r\n\r\nThis is why we must have a basic test for each router is covering them. I guess higher level browser tests would be nice at some point. But for now some vue-router tests to replace the ones removed by this PR.","created_at":"2018-02-25T17:02:56Z","updated_at":"2018-02-25T17:05:31Z","html_url":"https://github.com/jaywink/socialhome/pull/441#discussion_r170459215","pull_request_url":"https://api.github.com/repos/jaywink/socialhome/pulls/441","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jaywink/socialhome/pulls/comments/170459215"},"html":{"href":"https://github.com/jaywink/socialhome/pull/441#discussion_r170459215"},"pull_request":{"href":"https://api.github.com/repos/jaywink/socialhome/pulls/441"}}},"pull_request":{"url":"https://api.github.com/repos/jaywink/socialhome/pulls/441","id":171178790,"html_url":"https://github.com/jaywink/socialhome/pull/441","diff_url":"https://github.com/jaywink/socialhome/pull/441.diff","patch_url":"https://github.com/jaywink/socialhome/pull/441.patch","issue_url":"https://api.github.com/repos/jaywink/socialhome/issues/441","number":441,"state":"open","locked":false,"title":"Add Vue router","user":{"login":"christophehenry","id":22097904,"avatar_url":"https://avatars3.githubusercontent.com/u/22097904?v=4","gravatar_id":"","url":"https://api.github.com/users/christophehenry","html_url":"https://github.com/christophehenry","followers_url":"https://api.github.com/users/christophehenry/followers","following_url":"https://api.github.com/users/christophehenry/following{/other_user}","gists_url":"https://api.github.com/users/christophehenry/gists{/gist_id}","starred_url":"https://api.github.com/users/christophehenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophehenry/subscriptions","organizations_url":"https://api.github.com/users/christophehenry/orgs","repos_url":"https://api.github.com/users/christophehenry/repos","events_url":"https://api.github.com/users/christophehenry/events{/privacy}","received_events_url":"https://api.github.com/users/christophehenry/received_events","type":"User","site_admin":false},"body":"Simple mockup of what can be done with VueRouter.\r\nNeeds tests, I guess. But first, I need to eat something.","created_at":"2018-02-24T13:29:17Z","updated_at":"2018-02-25T17:05:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed29749cdb7b35cbdef57e0d1b5539bd5d15ba32","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":358812832,"url":"https://api.github.com/repos/jaywink/socialhome/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jaywink/socialhome/pulls/441/commits","review_comments_url":"https://api.github.com/repos/jaywink/socialhome/pulls/441/comments","review_comment_url":"https://api.github.com/repos/jaywink/socialhome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaywink/socialhome/issues/441/comments","statuses_url":"https://api.github.com/repos/jaywink/socialhome/statuses/b4bd7625bcfbfe3764f97037aae40cc0dad636e8","head":{"label":"christophehenry:vuejs","ref":"vuejs","sha":"b4bd7625bcfbfe3764f97037aae40cc0dad636e8","user":{"login":"christophehenry","id":22097904,"avatar_url":"https://avatars3.githubusercontent.com/u/22097904?v=4","gravatar_id":"","url":"https://api.github.com/users/christophehenry","html_url":"https://github.com/christophehenry","followers_url":"https://api.github.com/users/christophehenry/followers","following_url":"https://api.github.com/users/christophehenry/following{/other_user}","gists_url":"https://api.github.com/users/christophehenry/gists{/gist_id}","starred_url":"https://api.github.com/users/christophehenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophehenry/subscriptions","organizations_url":"https://api.github.com/users/christophehenry/orgs","repos_url":"https://api.github.com/users/christophehenry/repos","events_url":"https://api.github.com/users/christophehenry/events{/privacy}","received_events_url":"https://api.github.com/users/christophehenry/received_events","type":"User","site_admin":false},"repo":{"id":67941772,"name":"socialhome","full_name":"christophehenry/socialhome","owner":{"login":"christophehenry","id":22097904,"avatar_url":"https://avatars3.githubusercontent.com/u/22097904?v=4","gravatar_id":"","url":"https://api.github.com/users/christophehenry","html_url":"https://github.com/christophehenry","followers_url":"https://api.github.com/users/christophehenry/followers","following_url":"https://api.github.com/users/christophehenry/following{/other_user}","gists_url":"https://api.github.com/users/christophehenry/gists{/gist_id}","starred_url":"https://api.github.com/users/christophehenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophehenry/subscriptions","organizations_url":"https://api.github.com/users/christophehenry/orgs","repos_url":"https://api.github.com/users/christophehenry/repos","events_url":"https://api.github.com/users/christophehenry/events{/privacy}","received_events_url":"https://api.github.com/users/christophehenry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christophehenry/socialhome","description":"A federated social home.","fork":true,"url":"https://api.github.com/repos/christophehenry/socialhome","forks_url":"https://api.github.com/repos/christophehenry/socialhome/forks","keys_url":"https://api.github.com/repos/christophehenry/socialhome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christophehenry/socialhome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christophehenry/socialhome/teams","hooks_url":"https://api.github.com/repos/christophehenry/socialhome/hooks","issue_events_url":"https://api.github.com/repos/christophehenry/socialhome/issues/events{/number}","events_url":"https://api.github.com/repos/christophehenry/socialhome/events","assignees_url":"https://api.github.com/repos/christophehenry/socialhome/assignees{/user}","branches_url":"https://api.github.com/repos/christophehenry/socialhome/branches{/branch}","tags_url":"https://api.github.com/repos/christophehenry/socialhome/tags","blobs_url":"https://api.github.com/repos/christophehenry/socialhome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christophehenry/socialhome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christophehenry/socialhome/git/refs{/sha}","trees_url":"https://api.github.com/repos/christophehenry/socialhome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christophehenry/socialhome/statuses/{sha}","languages_url":"https://api.github.com/repos/christophehenry/socialhome/languages","stargazers_url":"https://api.github.com/repos/christophehenry/socialhome/stargazers","contributors_url":"https://api.github.com/repos/christophehenry/socialhome/contributors","subscribers_url":"https://api.github.com/repos/christophehenry/socialhome/subscribers","subscription_url":"https://api.github.com/repos/christophehenry/socialhome/subscription","commits_url":"https://api.github.com/repos/christophehenry/socialhome/commits{/sha}","git_commits_url":"https://api.github.com/repos/christophehenry/socialhome/git/commits{/sha}","comments_url":"https://api.github.com/repos/christophehenry/socialhome/comments{/number}","issue_comment_url":"https://api.github.com/repos/christophehenry/socialhome/issues/comments{/number}","contents_url":"https://api.github.com/repos/christophehenry/socialhome/contents/{+path}","compare_url":"https://api.github.com/repos/christophehenry/socialhome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christophehenry/socialhome/merges","archive_url":"https://api.github.com/repos/christophehenry/socialhome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christophehenry/socialhome/downloads","issues_url":"https://api.github.com/repos/christophehenry/socialhome/issues{/number}","pulls_url":"https://api.github.com/repos/christophehenry/socialhome/pulls{/number}","milestones_url":"https://api.github.com/repos/christophehenry/socialhome/milestones{/number}","notifications_url":"https://api.github.com/repos/christophehenry/socialhome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christophehenry/socialhome/labels{/name}","releases_url":"https://api.github.com/repos/christophehenry/socialhome/releases{/id}","deployments_url":"https://api.github.com/repos/christophehenry/socialhome/deployments","created_at":"2016-09-11T16:45:27Z","updated_at":"2017-12-14T20:52:44Z","pushed_at":"2018-02-24T19:03:50Z","git_url":"git://github.com/christophehenry/socialhome.git","ssh_url":"git@github.com:christophehenry/socialhome.git","clone_url":"https://github.com/christophehenry/socialhome.git","svn_url":"https://github.com/christophehenry/socialhome","homepage":null,"size":5040,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaywink:master","ref":"master","sha":"6d6d5e2c4e2ef5605fd598631934340f406a3130","user":{"login":"jaywink","id":1174866,"avatar_url":"https://avatars0.githubusercontent.com/u/1174866?v=4","gravatar_id":"","url":"https://api.github.com/users/jaywink","html_url":"https://github.com/jaywink","followers_url":"https://api.github.com/users/jaywink/followers","following_url":"https://api.github.com/users/jaywink/following{/other_user}","gists_url":"https://api.github.com/users/jaywink/gists{/gist_id}","starred_url":"https://api.github.com/users/jaywink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaywink/subscriptions","organizations_url":"https://api.github.com/users/jaywink/orgs","repos_url":"https://api.github.com/users/jaywink/repos","events_url":"https://api.github.com/users/jaywink/events{/privacy}","received_events_url":"https://api.github.com/users/jaywink/received_events","type":"User","site_admin":false},"repo":{"id":55836470,"name":"socialhome","full_name":"jaywink/socialhome","owner":{"login":"jaywink","id":1174866,"avatar_url":"https://avatars0.githubusercontent.com/u/1174866?v=4","gravatar_id":"","url":"https://api.github.com/users/jaywink","html_url":"https://github.com/jaywink","followers_url":"https://api.github.com/users/jaywink/followers","following_url":"https://api.github.com/users/jaywink/following{/other_user}","gists_url":"https://api.github.com/users/jaywink/gists{/gist_id}","starred_url":"https://api.github.com/users/jaywink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaywink/subscriptions","organizations_url":"https://api.github.com/users/jaywink/orgs","repos_url":"https://api.github.com/users/jaywink/repos","events_url":"https://api.github.com/users/jaywink/events{/privacy}","received_events_url":"https://api.github.com/users/jaywink/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaywink/socialhome","description":"A federated social home.","fork":false,"url":"https://api.github.com/repos/jaywink/socialhome","forks_url":"https://api.github.com/repos/jaywink/socialhome/forks","keys_url":"https://api.github.com/repos/jaywink/socialhome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaywink/socialhome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaywink/socialhome/teams","hooks_url":"https://api.github.com/repos/jaywink/socialhome/hooks","issue_events_url":"https://api.github.com/repos/jaywink/socialhome/issues/events{/number}","events_url":"https://api.github.com/repos/jaywink/socialhome/events","assignees_url":"https://api.github.com/repos/jaywink/socialhome/assignees{/user}","branches_url":"https://api.github.com/repos/jaywink/socialhome/branches{/branch}","tags_url":"https://api.github.com/repos/jaywink/socialhome/tags","blobs_url":"https://api.github.com/repos/jaywink/socialhome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaywink/socialhome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaywink/socialhome/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaywink/socialhome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaywink/socialhome/statuses/{sha}","languages_url":"https://api.github.com/repos/jaywink/socialhome/languages","stargazers_url":"https://api.github.com/repos/jaywink/socialhome/stargazers","contributors_url":"https://api.github.com/repos/jaywink/socialhome/contributors","subscribers_url":"https://api.github.com/repos/jaywink/socialhome/subscribers","subscription_url":"https://api.github.com/repos/jaywink/socialhome/subscription","commits_url":"https://api.github.com/repos/jaywink/socialhome/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaywink/socialhome/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaywink/socialhome/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaywink/socialhome/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaywink/socialhome/contents/{+path}","compare_url":"https://api.github.com/repos/jaywink/socialhome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaywink/socialhome/merges","archive_url":"https://api.github.com/repos/jaywink/socialhome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaywink/socialhome/downloads","issues_url":"https://api.github.com/repos/jaywink/socialhome/issues{/number}","pulls_url":"https://api.github.com/repos/jaywink/socialhome/pulls{/number}","milestones_url":"https://api.github.com/repos/jaywink/socialhome/milestones{/number}","notifications_url":"https://api.github.com/repos/jaywink/socialhome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaywink/socialhome/labels{/name}","releases_url":"https://api.github.com/repos/jaywink/socialhome/releases{/id}","deployments_url":"https://api.github.com/repos/jaywink/socialhome/deployments","created_at":"2016-04-09T09:35:46Z","updated_at":"2018-02-19T18:07:38Z","pushed_at":"2018-02-25T16:51:45Z","git_url":"git://github.com/jaywink/socialhome.git","ssh_url":"git@github.com:jaywink/socialhome.git","clone_url":"https://github.com/jaywink/socialhome.git","svn_url":"https://github.com/jaywink/socialhome","homepage":"https://socialhome.network","size":5055,"stargazers_count":74,"watchers_count":74,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":21,"open_issues":113,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaywink/socialhome/pulls/441"},"html":{"href":"https://github.com/jaywink/socialhome/pull/441"},"issue":{"href":"https://api.github.com/repos/jaywink/socialhome/issues/441"},"comments":{"href":"https://api.github.com/repos/jaywink/socialhome/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/jaywink/socialhome/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/jaywink/socialhome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaywink/socialhome/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/jaywink/socialhome/statuses/b4bd7625bcfbfe3764f97037aae40cc0dad636e8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jaywink"}}