{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/comments/222022992","pull_request_review_id":160812075,"id":222022992,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjAyMjk5Mg==","diff_hunk":"@@ -31,18 +32,46 @@ type Var struct {\n \t// purview of this kustomization. ObjRef should use the\n \t// raw name of the object (the name specified in its YAML,\n \t// before addition of a namePrefix).\n-\tObjRef corev1.ObjectReference `json:\"objref\" yaml:\"objref\"`\n+\tObjRef Target `json:\"objref\" yaml:\"objref\"`\n \n \t// FieldRef refers to the field of the object referred to by\n \t// ObjRef whose value will be extracted for use in\n \t// replacing $(FOO).\n-\t// If unspecified, this defaults to fieldpath: metadata.name\n-\tFieldRef corev1.ObjectFieldSelector `json:\"fieldref,omitempty\" yaml:\"objref,omitempty\"`\n+\t// If unspecified, this defaults to fieldPath: metadata.name\n+\tFieldRef FieldSelector `json:\"fieldref,omitempty\" yaml:\"fieldref,omitempty\"`\n+}\n+\n+// Target refers to a kubernetes object by Group, Version, Kind and Name\n+type Target struct {\n+\tAPIVersion string `json:\"apiVersion,omitempty\" yaml:\"apiVersion,omitempty\"`\n+\tgvk.Gvk\n+\tName string `json:\"name\" yaml:\"name\"`\n+}\n+\n+// FieldSelector contains the fieldPath to an object field, such as metadata.name","path":"pkg/types/var.go","position":33,"original_position":33,"commit_id":"36f8d96fe73962fff2732b6d7368942bba87fd0b","original_commit_id":"36f8d96fe73962fff2732b6d7368942bba87fd0b","user":{"login":"monopole","id":2928188,"node_id":"MDQ6VXNlcjI5MjgxODg=","avatar_url":"https://avatars3.githubusercontent.com/u/2928188?v=4","gravatar_id":"","url":"https://api.github.com/users/monopole","html_url":"https://github.com/monopole","followers_url":"https://api.github.com/users/monopole/followers","following_url":"https://api.github.com/users/monopole/following{/other_user}","gists_url":"https://api.github.com/users/monopole/gists{/gist_id}","starred_url":"https://api.github.com/users/monopole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monopole/subscriptions","organizations_url":"https://api.github.com/users/monopole/orgs","repos_url":"https://api.github.com/users/monopole/repos","events_url":"https://api.github.com/users/monopole/events{/privacy}","received_events_url":"https://api.github.com/users/monopole/received_events","type":"User","site_admin":false},"body":"A struct with one field looks odd (could do `type FieldSelector string` instead).\r\nNeeds a comment explaining it.\r\n\r\n","created_at":"2018-10-02T16:31:01Z","updated_at":"2018-10-02T16:33:02Z","html_url":"https://github.com/kubernetes-sigs/kustomize/pull/394#discussion_r222022992","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/394","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/comments/222022992"},"html":{"href":"https://github.com/kubernetes-sigs/kustomize/pull/394#discussion_r222022992"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/394","id":219538895,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTM4ODk1","html_url":"https://github.com/kubernetes-sigs/kustomize/pull/394","diff_url":"https://github.com/kubernetes-sigs/kustomize/pull/394.diff","patch_url":"https://github.com/kubernetes-sigs/kustomize/pull/394.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/394","number":394,"state":"open","locked":false,"title":"use local types in var reference","user":{"login":"Liujingfang1","id":8498608,"node_id":"MDQ6VXNlcjg0OTg2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8498608?v=4","gravatar_id":"","url":"https://api.github.com/users/Liujingfang1","html_url":"https://github.com/Liujingfang1","followers_url":"https://api.github.com/users/Liujingfang1/followers","following_url":"https://api.github.com/users/Liujingfang1/following{/other_user}","gists_url":"https://api.github.com/users/Liujingfang1/gists{/gist_id}","starred_url":"https://api.github.com/users/Liujingfang1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liujingfang1/subscriptions","organizations_url":"https://api.github.com/users/Liujingfang1/orgs","repos_url":"https://api.github.com/users/Liujingfang1/repos","events_url":"https://api.github.com/users/Liujingfang1/events{/privacy}","received_events_url":"https://api.github.com/users/Liujingfang1/received_events","type":"User","site_admin":false},"body":"remove dependency on `sigs.k8s.io/core/v1` from var","created_at":"2018-10-01T22:49:07Z","updated_at":"2018-10-02T16:33:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24553f065b00fc4a2b6e6214f37b642603e07a94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":952071101,"node_id":"MDU6TGFiZWw5NTIwNzExMDE=","url":"https://api.github.com/repos/kubernetes-sigs/kustomize/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":930398993,"node_id":"MDU6TGFiZWw5MzAzOTg5OTM=","url":"https://api.github.com/repos/kubernetes-sigs/kustomize/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":934259944,"node_id":"MDU6TGFiZWw5MzQyNTk5NDQ=","url":"https://api.github.com/repos/kubernetes-sigs/kustomize/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/394/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/394/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/394/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/statuses/36f8d96fe73962fff2732b6d7368942bba87fd0b","head":{"label":"Liujingfang1:var","ref":"var","sha":"36f8d96fe73962fff2732b6d7368942bba87fd0b","user":{"login":"Liujingfang1","id":8498608,"node_id":"MDQ6VXNlcjg0OTg2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8498608?v=4","gravatar_id":"","url":"https://api.github.com/users/Liujingfang1","html_url":"https://github.com/Liujingfang1","followers_url":"https://api.github.com/users/Liujingfang1/followers","following_url":"https://api.github.com/users/Liujingfang1/following{/other_user}","gists_url":"https://api.github.com/users/Liujingfang1/gists{/gist_id}","starred_url":"https://api.github.com/users/Liujingfang1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liujingfang1/subscriptions","organizations_url":"https://api.github.com/users/Liujingfang1/orgs","repos_url":"https://api.github.com/users/Liujingfang1/repos","events_url":"https://api.github.com/users/Liujingfang1/events{/privacy}","received_events_url":"https://api.github.com/users/Liujingfang1/received_events","type":"User","site_admin":false},"repo":{"id":134768545,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3Njg1NDU=","name":"kustomize","full_name":"Liujingfang1/kustomize","private":false,"owner":{"login":"Liujingfang1","id":8498608,"node_id":"MDQ6VXNlcjg0OTg2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8498608?v=4","gravatar_id":"","url":"https://api.github.com/users/Liujingfang1","html_url":"https://github.com/Liujingfang1","followers_url":"https://api.github.com/users/Liujingfang1/followers","following_url":"https://api.github.com/users/Liujingfang1/following{/other_user}","gists_url":"https://api.github.com/users/Liujingfang1/gists{/gist_id}","starred_url":"https://api.github.com/users/Liujingfang1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liujingfang1/subscriptions","organizations_url":"https://api.github.com/users/Liujingfang1/orgs","repos_url":"https://api.github.com/users/Liujingfang1/repos","events_url":"https://api.github.com/users/Liujingfang1/events{/privacy}","received_events_url":"https://api.github.com/users/Liujingfang1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Liujingfang1/kustomize","description":"Customization of kubernetes YAML configurations","fork":true,"url":"https://api.github.com/repos/Liujingfang1/kustomize","forks_url":"https://api.github.com/repos/Liujingfang1/kustomize/forks","keys_url":"https://api.github.com/repos/Liujingfang1/kustomize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Liujingfang1/kustomize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Liujingfang1/kustomize/teams","hooks_url":"https://api.github.com/repos/Liujingfang1/kustomize/hooks","issue_events_url":"https://api.github.com/repos/Liujingfang1/kustomize/issues/events{/number}","events_url":"https://api.github.com/repos/Liujingfang1/kustomize/events","assignees_url":"https://api.github.com/repos/Liujingfang1/kustomize/assignees{/user}","branches_url":"https://api.github.com/repos/Liujingfang1/kustomize/branches{/branch}","tags_url":"https://api.github.com/repos/Liujingfang1/kustomize/tags","blobs_url":"https://api.github.com/repos/Liujingfang1/kustomize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Liujingfang1/kustomize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Liujingfang1/kustomize/git/refs{/sha}","trees_url":"https://api.github.com/repos/Liujingfang1/kustomize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Liujingfang1/kustomize/statuses/{sha}","languages_url":"https://api.github.com/repos/Liujingfang1/kustomize/languages","stargazers_url":"https://api.github.com/repos/Liujingfang1/kustomize/stargazers","contributors_url":"https://api.github.com/repos/Liujingfang1/kustomize/contributors","subscribers_url":"https://api.github.com/repos/Liujingfang1/kustomize/subscribers","subscription_url":"https://api.github.com/repos/Liujingfang1/kustomize/subscription","commits_url":"https://api.github.com/repos/Liujingfang1/kustomize/commits{/sha}","git_commits_url":"https://api.github.com/repos/Liujingfang1/kustomize/git/commits{/sha}","comments_url":"https://api.github.com/repos/Liujingfang1/kustomize/comments{/number}","issue_comment_url":"https://api.github.com/repos/Liujingfang1/kustomize/issues/comments{/number}","contents_url":"https://api.github.com/repos/Liujingfang1/kustomize/contents/{+path}","compare_url":"https://api.github.com/repos/Liujingfang1/kustomize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Liujingfang1/kustomize/merges","archive_url":"https://api.github.com/repos/Liujingfang1/kustomize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Liujingfang1/kustomize/downloads","issues_url":"https://api.github.com/repos/Liujingfang1/kustomize/issues{/number}","pulls_url":"https://api.github.com/repos/Liujingfang1/kustomize/pulls{/number}","milestones_url":"https://api.github.com/repos/Liujingfang1/kustomize/milestones{/number}","notifications_url":"https://api.github.com/repos/Liujingfang1/kustomize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Liujingfang1/kustomize/labels{/name}","releases_url":"https://api.github.com/repos/Liujingfang1/kustomize/releases{/id}","deployments_url":"https://api.github.com/repos/Liujingfang1/kustomize/deployments","created_at":"2018-05-24T21:02:30Z","updated_at":"2018-09-14T23:20:13Z","pushed_at":"2018-10-01T22:53:09Z","git_url":"git://github.com/Liujingfang1/kustomize.git","ssh_url":"git@github.com:Liujingfang1/kustomize.git","clone_url":"https://github.com/Liujingfang1/kustomize.git","svn_url":"https://github.com/Liujingfang1/kustomize","homepage":"","size":22649,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"b95423285fcbeed089da674a421b911e1737d6d0","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":133067498,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwNjc0OTg=","name":"kustomize","full_name":"kubernetes-sigs/kustomize","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/kustomize","description":"Customization of kubernetes YAML configurations","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/kustomize","forks_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/deployments","created_at":"2018-05-11T17:09:33Z","updated_at":"2018-10-01T21:47:54Z","pushed_at":"2018-10-01T22:53:10Z","git_url":"git://github.com/kubernetes-sigs/kustomize.git","ssh_url":"git@github.com:kubernetes-sigs/kustomize.git","clone_url":"https://github.com/kubernetes-sigs/kustomize.git","svn_url":"https://github.com/kubernetes-sigs/kustomize","homepage":"","size":22226,"stargazers_count":1120,"watchers_count":1120,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":104,"open_issues":47,"watchers":1120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/394"},"html":{"href":"https://github.com/kubernetes-sigs/kustomize/pull/394"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/394"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/kustomize/statuses/36f8d96fe73962fff2732b6d7368942bba87fd0b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"monopole"}}