{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/170260048","pull_request_review_id":98913228,"id":170260048,"diff_hunk":"@@ -1518,11 +1469,27 @@ void clear() {\n \t\t\t\tCollection<TaskManagerLocation> preferredLocations) {\n \n \t\t\tfinal SlotRequestId requestId = new SlotRequestId();\n+\t\t\tCollection<AllocationID> previousAllocationIDs = Collections.emptyList();\n+\n+\t\t\t// try to extract previous allocation ids, if applicable, so that we can reschedule to the same slot\n+\t\t\tExecution execution = task.getTaskToExecute();","path":"flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java","position":291,"original_position":291,"commit_id":"4dd57b17f24e7611ba0b68f90a6c1593cd496225","original_commit_id":"4dd57b17f24e7611ba0b68f90a6c1593cd496225","user":{"login":"tillrohrmann","id":5756858,"avatar_url":"https://avatars1.githubusercontent.com/u/5756858?v=4","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"body":"Don't let us couple the Execution with the `SlotPool`. Let's give the `SlotProfile` to this method instead.","created_at":"2018-02-23T14:11:45Z","updated_at":"2018-02-23T14:29:05Z","html_url":"https://github.com/apache/flink/pull/5403#discussion_r170260048","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/5403","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/170260048"},"html":{"href":"https://github.com/apache/flink/pull/5403#discussion_r170260048"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/5403"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/5403","id":166788642,"html_url":"https://github.com/apache/flink/pull/5403","diff_url":"https://github.com/apache/flink/pull/5403.diff","patch_url":"https://github.com/apache/flink/pull/5403.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/5403","number":5403,"state":"open","locked":false,"title":"[WIP] Reschedule failed tasks to previous allocation (if possible).","user":{"login":"StefanRRichter","id":2128543,"avatar_url":"https://avatars2.githubusercontent.com/u/2128543?v=4","gravatar_id":"","url":"https://api.github.com/users/StefanRRichter","html_url":"https://github.com/StefanRRichter","followers_url":"https://api.github.com/users/StefanRRichter/followers","following_url":"https://api.github.com/users/StefanRRichter/following{/other_user}","gists_url":"https://api.github.com/users/StefanRRichter/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanRRichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanRRichter/subscriptions","organizations_url":"https://api.github.com/users/StefanRRichter/orgs","repos_url":"https://api.github.com/users/StefanRRichter/repos","events_url":"https://api.github.com/users/StefanRRichter/events{/privacy}","received_events_url":"https://api.github.com/users/StefanRRichter/received_events","type":"User","site_admin":false},"body":"This PR is a preview for early feedback on scheduler changes that make allocations sticky under failures for local recovery.\r\n\r\nCore idea is that we consider previous allocations in our scheduling and all tasks obey to the following rule:\r\n\r\nIf there was a previous allocation, try to find the same slot again or request a new slot, that cannot be owned by another task. We do this to prevent task that cannot find their previous slot (e.g. machine failure) from stealing the previous slot from another failed task, that could otherwise recover locally.\r\n\r\n`SlotProfile` specifies now all requirements for a slot and a matcher is used to identify the right candidate.\r\n\r\nCC @tillrohrmann ","created_at":"2018-02-02T12:17:53Z","updated_at":"2018-02-23T14:29:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45a0eaa7a896816e1fe4a2cad929ad09281f283d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/5403/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/5403/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/5403/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/4dd57b17f24e7611ba0b68f90a6c1593cd496225","head":{"label":"StefanRRichter:task-local-recovery-scheduler-wip","ref":"task-local-recovery-scheduler-wip","sha":"4dd57b17f24e7611ba0b68f90a6c1593cd496225","user":{"login":"StefanRRichter","id":2128543,"avatar_url":"https://avatars2.githubusercontent.com/u/2128543?v=4","gravatar_id":"","url":"https://api.github.com/users/StefanRRichter","html_url":"https://github.com/StefanRRichter","followers_url":"https://api.github.com/users/StefanRRichter/followers","following_url":"https://api.github.com/users/StefanRRichter/following{/other_user}","gists_url":"https://api.github.com/users/StefanRRichter/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanRRichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanRRichter/subscriptions","organizations_url":"https://api.github.com/users/StefanRRichter/orgs","repos_url":"https://api.github.com/users/StefanRRichter/repos","events_url":"https://api.github.com/users/StefanRRichter/events{/privacy}","received_events_url":"https://api.github.com/users/StefanRRichter/received_events","type":"User","site_admin":false},"repo":{"id":56500020,"name":"flink","full_name":"StefanRRichter/flink","owner":{"login":"StefanRRichter","id":2128543,"avatar_url":"https://avatars2.githubusercontent.com/u/2128543?v=4","gravatar_id":"","url":"https://api.github.com/users/StefanRRichter","html_url":"https://github.com/StefanRRichter","followers_url":"https://api.github.com/users/StefanRRichter/followers","following_url":"https://api.github.com/users/StefanRRichter/following{/other_user}","gists_url":"https://api.github.com/users/StefanRRichter/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanRRichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanRRichter/subscriptions","organizations_url":"https://api.github.com/users/StefanRRichter/orgs","repos_url":"https://api.github.com/users/StefanRRichter/repos","events_url":"https://api.github.com/users/StefanRRichter/events{/privacy}","received_events_url":"https://api.github.com/users/StefanRRichter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StefanRRichter/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/StefanRRichter/flink","forks_url":"https://api.github.com/repos/StefanRRichter/flink/forks","keys_url":"https://api.github.com/repos/StefanRRichter/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StefanRRichter/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StefanRRichter/flink/teams","hooks_url":"https://api.github.com/repos/StefanRRichter/flink/hooks","issue_events_url":"https://api.github.com/repos/StefanRRichter/flink/issues/events{/number}","events_url":"https://api.github.com/repos/StefanRRichter/flink/events","assignees_url":"https://api.github.com/repos/StefanRRichter/flink/assignees{/user}","branches_url":"https://api.github.com/repos/StefanRRichter/flink/branches{/branch}","tags_url":"https://api.github.com/repos/StefanRRichter/flink/tags","blobs_url":"https://api.github.com/repos/StefanRRichter/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StefanRRichter/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StefanRRichter/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/StefanRRichter/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StefanRRichter/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/StefanRRichter/flink/languages","stargazers_url":"https://api.github.com/repos/StefanRRichter/flink/stargazers","contributors_url":"https://api.github.com/repos/StefanRRichter/flink/contributors","subscribers_url":"https://api.github.com/repos/StefanRRichter/flink/subscribers","subscription_url":"https://api.github.com/repos/StefanRRichter/flink/subscription","commits_url":"https://api.github.com/repos/StefanRRichter/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/StefanRRichter/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/StefanRRichter/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/StefanRRichter/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/StefanRRichter/flink/contents/{+path}","compare_url":"https://api.github.com/repos/StefanRRichter/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StefanRRichter/flink/merges","archive_url":"https://api.github.com/repos/StefanRRichter/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StefanRRichter/flink/downloads","issues_url":"https://api.github.com/repos/StefanRRichter/flink/issues{/number}","pulls_url":"https://api.github.com/repos/StefanRRichter/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/StefanRRichter/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/StefanRRichter/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StefanRRichter/flink/labels{/name}","releases_url":"https://api.github.com/repos/StefanRRichter/flink/releases{/id}","deployments_url":"https://api.github.com/repos/StefanRRichter/flink/deployments","created_at":"2016-04-18T10:50:40Z","updated_at":"2016-04-18T10:50:56Z","pushed_at":"2018-02-23T11:36:14Z","git_url":"git://github.com/StefanRRichter/flink.git","ssh_url":"git@github.com:StefanRRichter/flink.git","clone_url":"https://github.com/StefanRRichter/flink.git","svn_url":"https://github.com/StefanRRichter/flink","homepage":null,"size":148964,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"fad60bea22ec58dc56f4dfd26f8be1033bfd7985","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-02-23T12:41:31Z","pushed_at":"2018-02-23T14:19:53Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":147649,"stargazers_count":3307,"watchers_count":3307,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2268,"mirror_url":null,"archived":false,"open_issues_count":313,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2268,"open_issues":313,"watchers":3307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/5403"},"html":{"href":"https://github.com/apache/flink/pull/5403"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/5403"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/5403/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/5403/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/5403/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/4dd57b17f24e7611ba0b68f90a6c1593cd496225"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tillrohrmann"}}