{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/233983308","pull_request_review_id":175524921,"id":233983308,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzk4MzMwOA==","diff_hunk":"@@ -65,7 +65,7 @@ public static bool TryFormat(float value, Span<byte> destination, out int bytesW\n         // be preferable not to have another version of that lying around. Until we really hit a scenario where floating point formatting needs the perf, we'll\n         // make do with this.\n         //\n-        private static bool TryFormatFloatingPoint<T>(T value, Span<byte> destination, out int bytesWritten, StandardFormat format) where T : IFormattable\n+        private static bool TryFormatFloatingPoint<T>(T value, Span<byte> destination, out int bytesWritten, StandardFormat format) where T : ISpanFormattable","path":"src/System.Private.CoreLib/shared/System/Buffers/Text/Utf8Formatter/Utf8Formatter.Float.cs","position":5,"original_position":5,"commit_id":"802950b8a06c2a287e498316745f461708839d0a","original_commit_id":"802950b8a06c2a287e498316745f461708839d0a","user":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"body":"Now that the `Utf8Formatter` lives in `S.P.Corelib`, the comment on this method isn't really applicable anymore.\r\n\r\nWe should just be able to call the existing `DoubleToNumber()` directly and then call the UTF8 `NumberToString` (now that the code is shared, `NumberBuffer` always has a `Span<byte>`, so we shouldn't need any conversion, etc).","created_at":"2018-11-15T19:44:37Z","updated_at":"2018-11-15T19:44:37Z","html_url":"https://github.com/dotnet/coreclr/pull/21030#discussion_r233983308","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21030","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/233983308"},"html":{"href":"https://github.com/dotnet/coreclr/pull/21030#discussion_r233983308"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21030"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/21030","id":231305771,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzA1Nzcx","html_url":"https://github.com/dotnet/coreclr/pull/21030","diff_url":"https://github.com/dotnet/coreclr/pull/21030.diff","patch_url":"https://github.com/dotnet/coreclr/pull/21030.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/21030","number":21030,"state":"open","locked":false,"title":"Utf8Formatter: Reduce allocations for floating point","user":{"login":"Tornhoof","id":7989549,"node_id":"MDQ6VXNlcjc5ODk1NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/7989549?v=4","gravatar_id":"","url":"https://api.github.com/users/Tornhoof","html_url":"https://github.com/Tornhoof","followers_url":"https://api.github.com/users/Tornhoof/followers","following_url":"https://api.github.com/users/Tornhoof/following{/other_user}","gists_url":"https://api.github.com/users/Tornhoof/gists{/gist_id}","starred_url":"https://api.github.com/users/Tornhoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tornhoof/subscriptions","organizations_url":"https://api.github.com/users/Tornhoof/orgs","repos_url":"https://api.github.com/users/Tornhoof/repos","events_url":"https://api.github.com/users/Tornhoof/events{/privacy}","received_events_url":"https://api.github.com/users/Tornhoof/received_events","type":"User","site_admin":false},"body":"As discussed in https://github.com/dotnet/corefx/issues/25077#issuecomment-439082212\r\n\r\nCan anybody help me how to run the tests for this locally?\r\nIn CoreClr there are no tests for the Utf8Formatter.\r\nIn CoreFx they are still in the System.Memory.Tests project, I tried to copy both changed files into the related corefx directories and build/run tests. But I'm not really convinced my changed code is actually executed, I tried to throw an exception in the code below and still all the tests were successful.","created_at":"2018-11-15T19:20:05Z","updated_at":"2018-11-15T19:44:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94913a17e886ea37c16805cfce75bb0829cf2e03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21030/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21030/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/21030/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/802950b8a06c2a287e498316745f461708839d0a","head":{"label":"Tornhoof:StackAllocFormatFloatingPoint","ref":"StackAllocFormatFloatingPoint","sha":"802950b8a06c2a287e498316745f461708839d0a","user":{"login":"Tornhoof","id":7989549,"node_id":"MDQ6VXNlcjc5ODk1NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/7989549?v=4","gravatar_id":"","url":"https://api.github.com/users/Tornhoof","html_url":"https://github.com/Tornhoof","followers_url":"https://api.github.com/users/Tornhoof/followers","following_url":"https://api.github.com/users/Tornhoof/following{/other_user}","gists_url":"https://api.github.com/users/Tornhoof/gists{/gist_id}","starred_url":"https://api.github.com/users/Tornhoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tornhoof/subscriptions","organizations_url":"https://api.github.com/users/Tornhoof/orgs","repos_url":"https://api.github.com/users/Tornhoof/repos","events_url":"https://api.github.com/users/Tornhoof/events{/privacy}","received_events_url":"https://api.github.com/users/Tornhoof/received_events","type":"User","site_admin":false},"repo":{"id":157747813,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3NDc4MTM=","name":"coreclr","full_name":"Tornhoof/coreclr","private":false,"owner":{"login":"Tornhoof","id":7989549,"node_id":"MDQ6VXNlcjc5ODk1NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/7989549?v=4","gravatar_id":"","url":"https://api.github.com/users/Tornhoof","html_url":"https://github.com/Tornhoof","followers_url":"https://api.github.com/users/Tornhoof/followers","following_url":"https://api.github.com/users/Tornhoof/following{/other_user}","gists_url":"https://api.github.com/users/Tornhoof/gists{/gist_id}","starred_url":"https://api.github.com/users/Tornhoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tornhoof/subscriptions","organizations_url":"https://api.github.com/users/Tornhoof/orgs","repos_url":"https://api.github.com/users/Tornhoof/repos","events_url":"https://api.github.com/users/Tornhoof/events{/privacy}","received_events_url":"https://api.github.com/users/Tornhoof/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Tornhoof/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/Tornhoof/coreclr","forks_url":"https://api.github.com/repos/Tornhoof/coreclr/forks","keys_url":"https://api.github.com/repos/Tornhoof/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tornhoof/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tornhoof/coreclr/teams","hooks_url":"https://api.github.com/repos/Tornhoof/coreclr/hooks","issue_events_url":"https://api.github.com/repos/Tornhoof/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/Tornhoof/coreclr/events","assignees_url":"https://api.github.com/repos/Tornhoof/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/Tornhoof/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/Tornhoof/coreclr/tags","blobs_url":"https://api.github.com/repos/Tornhoof/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tornhoof/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tornhoof/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tornhoof/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tornhoof/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/Tornhoof/coreclr/languages","stargazers_url":"https://api.github.com/repos/Tornhoof/coreclr/stargazers","contributors_url":"https://api.github.com/repos/Tornhoof/coreclr/contributors","subscribers_url":"https://api.github.com/repos/Tornhoof/coreclr/subscribers","subscription_url":"https://api.github.com/repos/Tornhoof/coreclr/subscription","commits_url":"https://api.github.com/repos/Tornhoof/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tornhoof/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tornhoof/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tornhoof/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tornhoof/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/Tornhoof/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tornhoof/coreclr/merges","archive_url":"https://api.github.com/repos/Tornhoof/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tornhoof/coreclr/downloads","issues_url":"https://api.github.com/repos/Tornhoof/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/Tornhoof/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/Tornhoof/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/Tornhoof/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tornhoof/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/Tornhoof/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/Tornhoof/coreclr/deployments","created_at":"2018-11-15T17:26:52Z","updated_at":"2018-11-15T17:28:06Z","pushed_at":"2018-11-15T18:06:03Z","git_url":"git://github.com/Tornhoof/coreclr.git","ssh_url":"git@github.com:Tornhoof/coreclr.git","clone_url":"https://github.com/Tornhoof/coreclr.git","svn_url":"https://github.com/Tornhoof/coreclr","homepage":"https://github.com/dotnet/core","size":253933,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"356a08f7e90113b31005c02abb14662bc40bed70","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-11-15T18:43:27Z","pushed_at":"2018-11-15T19:33:07Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":253954,"stargazers_count":10502,"watchers_count":10502,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2503,"mirror_url":null,"archived":false,"open_issues_count":2018,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2503,"open_issues":2018,"watchers":10502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21030"},"html":{"href":"https://github.com/dotnet/coreclr/pull/21030"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/21030"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/21030/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21030/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21030/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/802950b8a06c2a287e498316745f461708839d0a"}},"author_association":"NONE"}}
{"actor":{"display_login":"tannergooding"}}