{"action":"created","comment":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/167359785","pull_request_review_id":95579355,"id":167359785,"diff_hunk":"@@ -97,32 +80,20 @@ var readBundlePlugins = function(base_dir) {\n     logging.warn('You have more than one coreAPISpec modification specified.');\n   }\n \n-  // One bundle is special - that is the one for the core bundle.\n-  var core_bundle = _.find(bundles, function(bundle) {\n-    return bundle.core_name && bundle.core_name !== null;\n-  });\n-\n-  // Check that there is only one core bundle and throw an error if there is more than one.\n-  if (\n-    _.filter(bundles, function(bundle) {\n-      return bundle.core_name && bundle.core_name !== null;\n-    }).length > 1\n-  ) {\n-    throw new RangeError('You have more than one core bundle specified.');\n-  }\n-\n-  // For that bundle, we replace all references to library modules (like Backbone) that we bundle into the core app\n-  // with references to the core app itself, so if someone does `var Backbone = require('backbone');` webpack\n-  // will replace it with a reference to Bacbkone bundled into the core Kolibri app.\n-  var core_externals = core_bundle ? coreExternals(core_bundle.output.library) : {};\n+  // For that bundle, we replace all references to library modules (like Vue) that we bundle into\n+  // the core app with references to the core app itself, so if someone does\n+  // `import Vue from 'vue';` webpack will replace it with a reference to Vue bundled into the\n+  // core Kolibri app.","path":"frontend_build/src/read_bundle_plugins.js","position":97,"original_position":97,"commit_id":"efd95b4af8622755c6cdd3b14e34aef47bf090dc","original_commit_id":"efd95b4af8622755c6cdd3b14e34aef47bf090dc","user":{"login":"rtibbles","id":1680573,"avatar_url":"https://avatars3.githubusercontent.com/u/1680573?v=4","gravatar_id":"","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User","site_admin":false},"body":"Ah, yep.","created_at":"2018-02-09T22:13:26Z","updated_at":"2018-02-09T22:13:26Z","html_url":"https://github.com/learningequality/kolibri/pull/3167#discussion_r167359785","pull_request_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3167","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments/167359785"},"html":{"href":"https://github.com/learningequality/kolibri/pull/3167#discussion_r167359785"},"pull_request":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3167"}},"in_reply_to_id":167359442},"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/3167","id":168080490,"html_url":"https://github.com/learningequality/kolibri/pull/3167","diff_url":"https://github.com/learningequality/kolibri/pull/3167.diff","patch_url":"https://github.com/learningequality/kolibri/pull/3167.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/3167","number":3167,"state":"open","locked":false,"title":"Build system simplification","user":{"login":"rtibbles","id":1680573,"avatar_url":"https://avatars3.githubusercontent.com/u/1680573?v=4","gravatar_id":"","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User","site_admin":false},"body":"### Summary\r\n * Removes lots of flexibility from the frontend build pipeline, in an attempt to simplify the logic and process.\r\n * Ran the build, Kolibri still built, app still loaded properly in the browser.\r\n\r\n### Reviewer guidance\r\nCheck that Kolibri still builds and runs.\r\nLook through the new files and see if it is easier to follow the build flow.\r\n\r\n----\r\n\r\n### Contributor Checklist\r\n\r\n- [x] PR has the correct target branch and milestone\r\n- [x] PR has 'needs review' or 'work-in-progress' label\r\n- [x] Contributor has fully tested the PR manually\r\n- [x] Screenshots of any front-end changes are in the PR description\r\n- [x] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')\r\n\r\n### Reviewer Checklist\r\n\r\n- [ ] Automated test coverage is satisfactory\r\n- [ ] Reviewer has fully tested the PR manually\r\n- [ ] PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)\r\n- [ ] External dependencies files were updated (`yarn` and `pip`)\r\n- [ ] Documentation is updated\r\n- [ ] Link to diff of internal dependency change is included\r\n- [ ] CHANGELOG.rst is updated for high-level changes\r\n- [ ] Contributor is in AUTHORS.rst\r\n","created_at":"2018-02-08T20:36:49Z","updated_at":"2018-02-09T22:13:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd9663b48085999252e8fa6250d2122be8aaf93d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benjaoming","id":374612,"avatar_url":"https://avatars0.githubusercontent.com/u/374612?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":410338552,"url":"https://api.github.com/repos/learningequality/kolibri/labels/PR:%20needs%20review","name":"PR: needs review","color":"1f6ad6","default":false}],"milestone":{"url":"https://api.github.com/repos/learningequality/kolibri/milestones/12","html_url":"https://github.com/learningequality/kolibri/milestone/12","labels_url":"https://api.github.com/repos/learningequality/kolibri/milestones/12/labels","id":2868758,"number":12,"title":"0.8.0","description":"primary feature: content assignment","creator":{"login":"indirectlylit","id":2367265,"avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":77,"state":"open","created_at":"2017-10-27T02:37:39Z","updated_at":"2018-02-09T18:22:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3167/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3167/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/3167/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/efd95b4af8622755c6cdd3b14e34aef47bf090dc","head":{"label":"rtibbles:build_system_simplification","ref":"build_system_simplification","sha":"efd95b4af8622755c6cdd3b14e34aef47bf090dc","user":{"login":"rtibbles","id":1680573,"avatar_url":"https://avatars3.githubusercontent.com/u/1680573?v=4","gravatar_id":"","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User","site_admin":false},"repo":{"id":50074818,"name":"kolibri","full_name":"rtibbles/kolibri","owner":{"login":"rtibbles","id":1680573,"avatar_url":"https://avatars3.githubusercontent.com/u/1680573?v=4","gravatar_id":"","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rtibbles/kolibri","description":"This is where Kolibri shall be born, watch and participate!","fork":true,"url":"https://api.github.com/repos/rtibbles/kolibri","forks_url":"https://api.github.com/repos/rtibbles/kolibri/forks","keys_url":"https://api.github.com/repos/rtibbles/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtibbles/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtibbles/kolibri/teams","hooks_url":"https://api.github.com/repos/rtibbles/kolibri/hooks","issue_events_url":"https://api.github.com/repos/rtibbles/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/rtibbles/kolibri/events","assignees_url":"https://api.github.com/repos/rtibbles/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/rtibbles/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/rtibbles/kolibri/tags","blobs_url":"https://api.github.com/repos/rtibbles/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtibbles/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtibbles/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtibbles/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtibbles/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/rtibbles/kolibri/languages","stargazers_url":"https://api.github.com/repos/rtibbles/kolibri/stargazers","contributors_url":"https://api.github.com/repos/rtibbles/kolibri/contributors","subscribers_url":"https://api.github.com/repos/rtibbles/kolibri/subscribers","subscription_url":"https://api.github.com/repos/rtibbles/kolibri/subscription","commits_url":"https://api.github.com/repos/rtibbles/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtibbles/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtibbles/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtibbles/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtibbles/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/rtibbles/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtibbles/kolibri/merges","archive_url":"https://api.github.com/repos/rtibbles/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtibbles/kolibri/downloads","issues_url":"https://api.github.com/repos/rtibbles/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/rtibbles/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/rtibbles/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/rtibbles/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtibbles/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/rtibbles/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/rtibbles/kolibri/deployments","created_at":"2016-01-21T02:03:42Z","updated_at":"2016-01-31T03:57:29Z","pushed_at":"2018-02-09T21:37:22Z","git_url":"git://github.com/rtibbles/kolibri.git","ssh_url":"git@github.com:rtibbles/kolibri.git","clone_url":"https://github.com/rtibbles/kolibri.git","svn_url":"https://github.com/rtibbles/kolibri","homepage":"http://learningequality.org/kolibri/","size":34760,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"learningequality:develop","ref":"develop","sha":"c67bc45ad5f284f3e8a35cfaba01fea6909523ad","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"name":"kolibri","full_name":"learningequality/kolibri","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/kolibri","description":"Kolibri: the offline app for universal education","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2018-02-06T18:45:13Z","pushed_at":"2018-02-09T21:46:01Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"http://learningequality.org/kolibri/","size":35386,"stargazers_count":145,"watchers_count":145,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":241,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":109,"open_issues":241,"watchers":145,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3167"},"html":{"href":"https://github.com/learningequality/kolibri/pull/3167"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/3167"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/3167/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3167/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3167/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/efd95b4af8622755c6cdd3b14e34aef47bf090dc"}},"author_association":"OWNER"}}
{"actor":{"display_login":"rtibbles"}}