{"action":"created","issue":{"url":"https://api.github.com/repos/tarantool/tarantool/issues/3358","repository_url":"https://api.github.com/repos/tarantool/tarantool","labels_url":"https://api.github.com/repos/tarantool/tarantool/issues/3358/labels{/name}","comments_url":"https://api.github.com/repos/tarantool/tarantool/issues/3358/comments","events_url":"https://api.github.com/repos/tarantool/tarantool/issues/3358/events","html_url":"https://github.com/tarantool/tarantool/issues/3358","id":315494347,"number":3358,"title":"base64_encode nearly always urlsafe","user":{"login":"SWSAmor","id":5707529,"avatar_url":"https://avatars0.githubusercontent.com/u/5707529?v=4","gravatar_id":"","url":"https://api.github.com/users/SWSAmor","html_url":"https://github.com/SWSAmor","followers_url":"https://api.github.com/users/SWSAmor/followers","following_url":"https://api.github.com/users/SWSAmor/following{/other_user}","gists_url":"https://api.github.com/users/SWSAmor/gists{/gist_id}","starred_url":"https://api.github.com/users/SWSAmor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SWSAmor/subscriptions","organizations_url":"https://api.github.com/users/SWSAmor/orgs","repos_url":"https://api.github.com/users/SWSAmor/repos","events_url":"https://api.github.com/users/SWSAmor/events{/privacy}","received_events_url":"https://api.github.com/users/SWSAmor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-18T14:04:05Z","updated_at":"2018-04-26T15:37:03Z","closed_at":null,"author_association":"NONE","body":"For me the base64_encode make urlsafe in these cases:\r\n`{nopad=true}`\r\n`{nowrap=true}`\r\n`{nopad=true, urlsafe=false}`\r\n`{nowrap=true, urlsafe=false}`\r\n\r\nI use tarantool 1.9.0.71\r\n"},"comment":{"url":"https://api.github.com/repos/tarantool/tarantool/issues/comments/384687291","html_url":"https://github.com/tarantool/tarantool/issues/3358#issuecomment-384687291","issue_url":"https://api.github.com/repos/tarantool/tarantool/issues/3358","id":384687291,"user":{"login":"Gerold103","id":5232171,"avatar_url":"https://avatars0.githubusercontent.com/u/5232171?v=4","gravatar_id":"","url":"https://api.github.com/users/Gerold103","html_url":"https://github.com/Gerold103","followers_url":"https://api.github.com/users/Gerold103/followers","following_url":"https://api.github.com/users/Gerold103/following{/other_user}","gists_url":"https://api.github.com/users/Gerold103/gists{/gist_id}","starred_url":"https://api.github.com/users/Gerold103/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gerold103/subscriptions","organizations_url":"https://api.github.com/users/Gerold103/orgs","repos_url":"https://api.github.com/users/Gerold103/repos","events_url":"https://api.github.com/users/Gerold103/events{/privacy}","received_events_url":"https://api.github.com/users/Gerold103/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T15:37:03Z","updated_at":"2018-04-26T15:37:03Z","author_association":"COLLABORATOR","body":"I found I bug in base64.c:\r\n```C\r\nif ((options & BASE64_URLSAFE) != 0)\r\n\t\tencoding = urlsafe_encoding;\r\n\telse\r\n\t\tencoding = default_encoding;\r\n```\r\nHere must be another check: `if ((options & BASE64_URLSAFE) == BASE64_URLSAFE)`, because `BASE64_URLSAFE` consists of several bits."}}
{"actor":{"display_login":"Gerold103"}}