{"action":"created","issue":{"url":"https://api.github.com/repos/3drepo/3drepo.io/issues/1260","repository_url":"https://api.github.com/repos/3drepo/3drepo.io","labels_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/1260/labels{/name}","comments_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/1260/comments","events_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/1260/events","html_url":"https://github.com/3drepo/3drepo.io/pull/1260","id":386134994,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0OTQ1OTMw","number":1260,"title":"Issue 1249: Migration - GIS","user":{"login":"dleszcz","id":17221890,"node_id":"MDQ6VXNlcjE3MjIxODkw","avatar_url":"https://avatars2.githubusercontent.com/u/17221890?v=4","gravatar_id":"","url":"https://api.github.com/users/dleszcz","html_url":"https://github.com/dleszcz","followers_url":"https://api.github.com/users/dleszcz/followers","following_url":"https://api.github.com/users/dleszcz/following{/other_user}","gists_url":"https://api.github.com/users/dleszcz/gists{/gist_id}","starred_url":"https://api.github.com/users/dleszcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dleszcz/subscriptions","organizations_url":"https://api.github.com/users/dleszcz/orgs","repos_url":"https://api.github.com/users/dleszcz/repos","events_url":"https://api.github.com/users/dleszcz/events{/privacy}","received_events_url":"https://api.github.com/users/dleszcz/received_events","type":"User","site_admin":false},"labels":[{"id":714749956,"node_id":"MDU6TGFiZWw3MTQ3NDk5NTY=","url":"https://api.github.com/repos/3drepo/3drepo.io/labels/feature","name":"feature","color":"006600","default":false}],"state":"open","locked":false,"assignee":{"login":"dleszcz","id":17221890,"node_id":"MDQ6VXNlcjE3MjIxODkw","avatar_url":"https://avatars2.githubusercontent.com/u/17221890?v=4","gravatar_id":"","url":"https://api.github.com/users/dleszcz","html_url":"https://github.com/dleszcz","followers_url":"https://api.github.com/users/dleszcz/followers","following_url":"https://api.github.com/users/dleszcz/following{/other_user}","gists_url":"https://api.github.com/users/dleszcz/gists{/gist_id}","starred_url":"https://api.github.com/users/dleszcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dleszcz/subscriptions","organizations_url":"https://api.github.com/users/dleszcz/orgs","repos_url":"https://api.github.com/users/dleszcz/repos","events_url":"https://api.github.com/users/dleszcz/events{/privacy}","received_events_url":"https://api.github.com/users/dleszcz/received_events","type":"User","site_admin":false},"assignees":[{"login":"dleszcz","id":17221890,"node_id":"MDQ6VXNlcjE3MjIxODkw","avatar_url":"https://avatars2.githubusercontent.com/u/17221890?v=4","gravatar_id":"","url":"https://api.github.com/users/dleszcz","html_url":"https://github.com/dleszcz","followers_url":"https://api.github.com/users/dleszcz/followers","following_url":"https://api.github.com/users/dleszcz/following{/other_user}","gists_url":"https://api.github.com/users/dleszcz/gists{/gist_id}","starred_url":"https://api.github.com/users/dleszcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dleszcz/subscriptions","organizations_url":"https://api.github.com/users/dleszcz/orgs","repos_url":"https://api.github.com/users/dleszcz/repos","events_url":"https://api.github.com/users/dleszcz/events{/privacy}","received_events_url":"https://api.github.com/users/dleszcz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-11-30T10:47:37Z","updated_at":"2019-01-02T09:59:06Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/3drepo/3drepo.io/pulls/1260","html_url":"https://github.com/3drepo/3drepo.io/pull/1260","diff_url":"https://github.com/3drepo/3drepo.io/pull/1260.diff","patch_url":"https://github.com/3drepo/3drepo.io/pull/1260.patch"},"body":"#1249 \r\n\r\n### Description\r\n\r\n- Created a new panel component\r\n- Created a new GIS component\r\n- Created a GIS module to use ViewerService\r\n- Removed Angular GIS component\r\n- Implement styles with styled-components\r\n\r\n**Bugs**\r\n\r\n- [x] Technically the Drop down menu is like a heading and the Map Tiles etc list are within that heading. So it looks a bit weird how the text on the drop down menu is a lot more insignificant to the Map Tiles etc. Can we format this a bit better? maybe bigger font on the drop down with black text and make the list text smaller + a dark grey? (whatever you feel appropriate)\r\n\r\n- [x] Capitalise Base here:\r\n\r\n- [x] The settings page is still showing \"mm\" even though my model is in \"m\"\r\n\r\n- [x] Coordinates needs swapping. Due to us working in openGL coordinates and CAD users use direct x + they want z to have a negated meaning... [X Y Z] on the UI needs to be sent as [X -Z -Y] to the backend.\r\n\r\n- [x] This is GIS branch (can we make sure the settings page also has this logic please :) ):\r\n\r\n- [x] Save button needs inverting (should be a round green button with white floppy disk):\r\n"},"comment":{"url":"https://api.github.com/repos/3drepo/3drepo.io/issues/comments/450824016","html_url":"https://github.com/3drepo/3drepo.io/pull/1260#issuecomment-450824016","issue_url":"https://api.github.com/repos/3drepo/3drepo.io/issues/1260","id":450824016,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDgyNDAxNg==","user":{"login":"carmenfan","id":11945337,"node_id":"MDQ6VXNlcjExOTQ1MzM3","avatar_url":"https://avatars2.githubusercontent.com/u/11945337?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenfan","html_url":"https://github.com/carmenfan","followers_url":"https://api.github.com/users/carmenfan/followers","following_url":"https://api.github.com/users/carmenfan/following{/other_user}","gists_url":"https://api.github.com/users/carmenfan/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenfan/subscriptions","organizations_url":"https://api.github.com/users/carmenfan/orgs","repos_url":"https://api.github.com/users/carmenfan/repos","events_url":"https://api.github.com/users/carmenfan/events{/privacy}","received_events_url":"https://api.github.com/users/carmenfan/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T09:59:06Z","updated_at":"2019-01-02T09:59:06Z","author_association":"MEMBER","body":"> > > @simplypixi it seems to reload everytime I open/close the panel? I think we're ok with it not fetching the data everytime we show/hide and just keep the last state, if that's what it's doing.\r\n> > > ![before](https://user-images.githubusercontent.com/11945337/50342803-829c1100-051c-11e9-8559-10d6dc172020.gif)\r\n> > > Everything seems to work otherwise! :)\r\n> > \r\n> > \r\n> > Yes, it reloads every time. We've implemented this behavior before the discussion about saving panel state.\r\n> > I'll change that ;)\r\n> \r\n> @carmenfan I almost finished this one, but I have a few questions.\r\n> What should happen, if the user sets \"Map Tile\" as visible and then closes GIS panel? Should be this layer still visible?\r\n\r\nYes. It should still be visible :)"}}
{"actor":{"display_login":"carmenfan"}}