{"action":"created","comment":{"url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/comments/165632081","pull_request_review_id":93605259,"id":165632081,"diff_hunk":"@@ -0,0 +1,21 @@\n+package com.aaron.mastermindgame.client;\n+\n+import com.aaron.mastermindgame.model.Player;\n+import com.aaron.mastermindgame.model.request.PlayerRequest;\n+import com.aaron.mastermindgame.service.BasePlayerService;\n+import org.springframework.web.client.RestTemplate;\n+\n+public class PlayerClient implements BasePlayerService {\n+\n+    private static final String URL = \"https://rust-mastermind.herokuapp.com/players\";\n+    private RestTemplate restTemplate;\n+\n+    public PlayerClient(RestTemplate restTemplate) {\n+        this.restTemplate = restTemplate;\n+    }\n+\n+    @Override\n+    public Player registerPlayer(PlayerRequest playerRequest) {\n+        return restTemplate.postForObject(URL, playerRequest, Player.class);","path":"src/main/java/com/aaron/mastermindgame/client/PlayerClient.java","position":19,"original_position":19,"commit_id":"ac4f060df1155d4dec3041b8f760bbb9d2e6b452","original_commit_id":"ac4f060df1155d4dec3041b8f760bbb9d2e6b452","user":{"login":"dawsonfi","id":5369412,"avatar_url":"https://avatars1.githubusercontent.com/u/5369412?v=4","gravatar_id":"","url":"https://api.github.com/users/dawsonfi","html_url":"https://github.com/dawsonfi","followers_url":"https://api.github.com/users/dawsonfi/followers","following_url":"https://api.github.com/users/dawsonfi/following{/other_user}","gists_url":"https://api.github.com/users/dawsonfi/gists{/gist_id}","starred_url":"https://api.github.com/users/dawsonfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawsonfi/subscriptions","organizations_url":"https://api.github.com/users/dawsonfi/orgs","repos_url":"https://api.github.com/users/dawsonfi/repos","events_url":"https://api.github.com/users/dawsonfi/events{/privacy}","received_events_url":"https://api.github.com/users/dawsonfi/received_events","type":"User","site_admin":false},"body":"What if the endpoint returns a 404? or a 400? how will the application behave?","created_at":"2018-02-02T12:27:33Z","updated_at":"2018-02-02T12:27:33Z","html_url":"https://github.com/mastermind-mentorship/aaron-mastermind-game/pull/13#discussion_r165632081","pull_request_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/13","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/comments/165632081"},"html":{"href":"https://github.com/mastermind-mentorship/aaron-mastermind-game/pull/13#discussion_r165632081"},"pull_request":{"href":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/13","id":166573834,"html_url":"https://github.com/mastermind-mentorship/aaron-mastermind-game/pull/13","diff_url":"https://github.com/mastermind-mentorship/aaron-mastermind-game/pull/13.diff","patch_url":"https://github.com/mastermind-mentorship/aaron-mastermind-game/pull/13.patch","issue_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/issues/13","number":13,"state":"open","locked":false,"title":"External player endpoint","user":{"login":"aaronpenido","id":16400421,"avatar_url":"https://avatars2.githubusercontent.com/u/16400421?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronpenido","html_url":"https://github.com/aaronpenido","followers_url":"https://api.github.com/users/aaronpenido/followers","following_url":"https://api.github.com/users/aaronpenido/following{/other_user}","gists_url":"https://api.github.com/users/aaronpenido/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronpenido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronpenido/subscriptions","organizations_url":"https://api.github.com/users/aaronpenido/orgs","repos_url":"https://api.github.com/users/aaronpenido/repos","events_url":"https://api.github.com/users/aaronpenido/events{/privacy}","received_events_url":"https://api.github.com/users/aaronpenido/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-01T15:46:32Z","updated_at":"2018-02-02T12:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"131379099172fc350c0f022db2d6a6ae8d40567d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/13/commits","review_comments_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/13/comments","review_comment_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/issues/13/comments","statuses_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/statuses/ac4f060df1155d4dec3041b8f760bbb9d2e6b452","head":{"label":"mastermind-mentorship:external-player-endpoint","ref":"external-player-endpoint","sha":"ac4f060df1155d4dec3041b8f760bbb9d2e6b452","user":{"login":"mastermind-mentorship","id":35528793,"avatar_url":"https://avatars3.githubusercontent.com/u/35528793?v=4","gravatar_id":"","url":"https://api.github.com/users/mastermind-mentorship","html_url":"https://github.com/mastermind-mentorship","followers_url":"https://api.github.com/users/mastermind-mentorship/followers","following_url":"https://api.github.com/users/mastermind-mentorship/following{/other_user}","gists_url":"https://api.github.com/users/mastermind-mentorship/gists{/gist_id}","starred_url":"https://api.github.com/users/mastermind-mentorship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mastermind-mentorship/subscriptions","organizations_url":"https://api.github.com/users/mastermind-mentorship/orgs","repos_url":"https://api.github.com/users/mastermind-mentorship/repos","events_url":"https://api.github.com/users/mastermind-mentorship/events{/privacy}","received_events_url":"https://api.github.com/users/mastermind-mentorship/received_events","type":"Organization","site_admin":false},"repo":{"id":117832791,"name":"aaron-mastermind-game","full_name":"mastermind-mentorship/aaron-mastermind-game","owner":{"login":"mastermind-mentorship","id":35528793,"avatar_url":"https://avatars3.githubusercontent.com/u/35528793?v=4","gravatar_id":"","url":"https://api.github.com/users/mastermind-mentorship","html_url":"https://github.com/mastermind-mentorship","followers_url":"https://api.github.com/users/mastermind-mentorship/followers","following_url":"https://api.github.com/users/mastermind-mentorship/following{/other_user}","gists_url":"https://api.github.com/users/mastermind-mentorship/gists{/gist_id}","starred_url":"https://api.github.com/users/mastermind-mentorship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mastermind-mentorship/subscriptions","organizations_url":"https://api.github.com/users/mastermind-mentorship/orgs","repos_url":"https://api.github.com/users/mastermind-mentorship/repos","events_url":"https://api.github.com/users/mastermind-mentorship/events{/privacy}","received_events_url":"https://api.github.com/users/mastermind-mentorship/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mastermind-mentorship/aaron-mastermind-game","description":null,"fork":false,"url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game","forks_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/forks","keys_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/teams","hooks_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/hooks","issue_events_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/issues/events{/number}","events_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/events","assignees_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/assignees{/user}","branches_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/branches{/branch}","tags_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/tags","blobs_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/statuses/{sha}","languages_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/languages","stargazers_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/stargazers","contributors_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/contributors","subscribers_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/subscribers","subscription_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/subscription","commits_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/issues/comments{/number}","contents_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/contents/{+path}","compare_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/merges","archive_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/downloads","issues_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/issues{/number}","pulls_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls{/number}","milestones_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/milestones{/number}","notifications_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/labels{/name}","releases_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/releases{/id}","deployments_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/deployments","created_at":"2018-01-17T12:25:11Z","updated_at":"2018-01-18T18:21:36Z","pushed_at":"2018-02-01T16:05:40Z","git_url":"git://github.com/mastermind-mentorship/aaron-mastermind-game.git","ssh_url":"git@github.com:mastermind-mentorship/aaron-mastermind-game.git","clone_url":"https://github.com/mastermind-mentorship/aaron-mastermind-game.git","svn_url":"https://github.com/mastermind-mentorship/aaron-mastermind-game","homepage":null,"size":151,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"mastermind-mentorship:master","ref":"master","sha":"20024eceebf1cb235a7f3d63290894f3224aa3fc","user":{"login":"mastermind-mentorship","id":35528793,"avatar_url":"https://avatars3.githubusercontent.com/u/35528793?v=4","gravatar_id":"","url":"https://api.github.com/users/mastermind-mentorship","html_url":"https://github.com/mastermind-mentorship","followers_url":"https://api.github.com/users/mastermind-mentorship/followers","following_url":"https://api.github.com/users/mastermind-mentorship/following{/other_user}","gists_url":"https://api.github.com/users/mastermind-mentorship/gists{/gist_id}","starred_url":"https://api.github.com/users/mastermind-mentorship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mastermind-mentorship/subscriptions","organizations_url":"https://api.github.com/users/mastermind-mentorship/orgs","repos_url":"https://api.github.com/users/mastermind-mentorship/repos","events_url":"https://api.github.com/users/mastermind-mentorship/events{/privacy}","received_events_url":"https://api.github.com/users/mastermind-mentorship/received_events","type":"Organization","site_admin":false},"repo":{"id":117832791,"name":"aaron-mastermind-game","full_name":"mastermind-mentorship/aaron-mastermind-game","owner":{"login":"mastermind-mentorship","id":35528793,"avatar_url":"https://avatars3.githubusercontent.com/u/35528793?v=4","gravatar_id":"","url":"https://api.github.com/users/mastermind-mentorship","html_url":"https://github.com/mastermind-mentorship","followers_url":"https://api.github.com/users/mastermind-mentorship/followers","following_url":"https://api.github.com/users/mastermind-mentorship/following{/other_user}","gists_url":"https://api.github.com/users/mastermind-mentorship/gists{/gist_id}","starred_url":"https://api.github.com/users/mastermind-mentorship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mastermind-mentorship/subscriptions","organizations_url":"https://api.github.com/users/mastermind-mentorship/orgs","repos_url":"https://api.github.com/users/mastermind-mentorship/repos","events_url":"https://api.github.com/users/mastermind-mentorship/events{/privacy}","received_events_url":"https://api.github.com/users/mastermind-mentorship/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mastermind-mentorship/aaron-mastermind-game","description":null,"fork":false,"url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game","forks_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/forks","keys_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/teams","hooks_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/hooks","issue_events_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/issues/events{/number}","events_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/events","assignees_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/assignees{/user}","branches_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/branches{/branch}","tags_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/tags","blobs_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/statuses/{sha}","languages_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/languages","stargazers_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/stargazers","contributors_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/contributors","subscribers_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/subscribers","subscription_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/subscription","commits_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/issues/comments{/number}","contents_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/contents/{+path}","compare_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/merges","archive_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/downloads","issues_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/issues{/number}","pulls_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls{/number}","milestones_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/milestones{/number}","notifications_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/labels{/name}","releases_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/releases{/id}","deployments_url":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/deployments","created_at":"2018-01-17T12:25:11Z","updated_at":"2018-01-18T18:21:36Z","pushed_at":"2018-02-01T16:05:40Z","git_url":"git://github.com/mastermind-mentorship/aaron-mastermind-game.git","ssh_url":"git@github.com:mastermind-mentorship/aaron-mastermind-game.git","clone_url":"https://github.com/mastermind-mentorship/aaron-mastermind-game.git","svn_url":"https://github.com/mastermind-mentorship/aaron-mastermind-game","homepage":null,"size":151,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/13"},"html":{"href":"https://github.com/mastermind-mentorship/aaron-mastermind-game/pull/13"},"issue":{"href":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/issues/13"},"comments":{"href":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/mastermind-mentorship/aaron-mastermind-game/statuses/ac4f060df1155d4dec3041b8f760bbb9d2e6b452"}},"author_association":"OWNER"}}
{"actor":{"display_login":"dawsonfi"}}