{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-superset/issues/5693","repository_url":"https://api.github.com/repos/apache/incubator-superset","labels_url":"https://api.github.com/repos/apache/incubator-superset/issues/5693/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-superset/issues/5693/comments","events_url":"https://api.github.com/repos/apache/incubator-superset/issues/5693/events","html_url":"https://github.com/apache/incubator-superset/pull/5693","id":352762561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTk0NTgy","number":5693,"title":"Adding simple Cypress tests","user":{"login":"michellethomas","id":817955,"node_id":"MDQ6VXNlcjgxNzk1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/817955?v=4","gravatar_id":"","url":"https://api.github.com/users/michellethomas","html_url":"https://github.com/michellethomas","followers_url":"https://api.github.com/users/michellethomas/followers","following_url":"https://api.github.com/users/michellethomas/following{/other_user}","gists_url":"https://api.github.com/users/michellethomas/gists{/gist_id}","starred_url":"https://api.github.com/users/michellethomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michellethomas/subscriptions","organizations_url":"https://api.github.com/users/michellethomas/orgs","repos_url":"https://api.github.com/users/michellethomas/repos","events_url":"https://api.github.com/users/michellethomas/events{/privacy}","received_events_url":"https://api.github.com/users/michellethomas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-22T00:59:41Z","updated_at":"2018-08-30T18:54:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-superset/pulls/5693","html_url":"https://github.com/apache/incubator-superset/pull/5693","diff_url":"https://github.com/apache/incubator-superset/pull/5693.diff","patch_url":"https://github.com/apache/incubator-superset/pull/5693.patch"},"body":"I've started to create a few cypress tests and want to get some eyes on it and get the code out so that others can add tests if they'd like. I haven't added it to tox yet but I've run through the steps we'd need to take to run it from the cli.\r\n\r\nThe general structure for tests that I've included is:\r\n**Explore**\r\n- Controls - setting controls in the UI and confirm that they are getting applied correctly\r\n- Links - test all links on explore pages\r\n- Visualizations - test functionality for different chart types, use form_data to test various combinations of control values and validate that the data is displaying correctly for the viz type.\r\n\r\n**Dashboard** - testing dashboard loading and editing ability\r\n\r\nThe difference between control tests and visualization tests seems really minor, but I think it would be useful in thinking about testing in isolation. Removing/setting controls for a single viz type, as well as, validating complex controls like metrics and filters would be useful to separate from testing the parameters for each visualization types. Let me know if anyone has thoughts on this!\r\n\r\nI needed to add `load_test_users` as a cli command so we can run it in backend and frontend tests. I'd want to check that we are in test mode before creating admin users, but it doesn't seem like there's an easy flag to test for test mode. Anyone know of a way to check this? I can add something if not.\r\n\r\nHere are the rough steps for running from cli\r\n```\r\nexport SUPERSET_CONFIG=tests.superset_test_config\r\nsuperset load_test_users\r\nsuperset db upgrade\r\nsuperset init\r\nsuperset load_examples\r\nsuperset runserver\r\nnpm run build\r\nnpm run cypress run\r\n```"},"comment":{"url":"https://api.github.com/repos/apache/incubator-superset/issues/comments/417429190","html_url":"https://github.com/apache/incubator-superset/pull/5693#issuecomment-417429190","issue_url":"https://api.github.com/repos/apache/incubator-superset/issues/5693","id":417429190,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzQyOTE5MA==","user":{"login":"michellethomas","id":817955,"node_id":"MDQ6VXNlcjgxNzk1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/817955?v=4","gravatar_id":"","url":"https://api.github.com/users/michellethomas","html_url":"https://github.com/michellethomas","followers_url":"https://api.github.com/users/michellethomas/followers","following_url":"https://api.github.com/users/michellethomas/following{/other_user}","gists_url":"https://api.github.com/users/michellethomas/gists{/gist_id}","starred_url":"https://api.github.com/users/michellethomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michellethomas/subscriptions","organizations_url":"https://api.github.com/users/michellethomas/orgs","repos_url":"https://api.github.com/users/michellethomas/repos","events_url":"https://api.github.com/users/michellethomas/events{/privacy}","received_events_url":"https://api.github.com/users/michellethomas/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T18:54:51Z","updated_at":"2018-08-30T18:54:51Z","author_association":"CONTRIBUTOR","body":"@mistercrunch @graceguo-supercat let me know if you have any thoughts about cypress integration tests"}}
{"actor":{"display_login":"michellethomas"}}