{"action":"created","comment":{"url":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/comments/183114373","pull_request_review_id":114056784,"id":183114373,"diff_hunk":"@@ -25,7 +25,9 @@ def test__cli_vars_longform(self):\n             }\n         }\n         self.run_dbt([\"run\", \"--vars\", yaml.dump(cli_vars)])\n-        self.run_dbt([\"test\"])\n+\n+        # TODO : This change in sensible, but why did it not fail before??","path":"test/integration/028_cli_vars/test_cli_vars.py","position":6,"original_position":6,"commit_id":"50774b386af463c41a7921727137cf7c180bd6de","original_commit_id":"50774b386af463c41a7921727137cf7c180bd6de","user":{"login":"cmcarthur","id":846979,"avatar_url":"https://avatars2.githubusercontent.com/u/846979?v=4","gravatar_id":"","url":"https://api.github.com/users/cmcarthur","html_url":"https://github.com/cmcarthur","followers_url":"https://api.github.com/users/cmcarthur/followers","following_url":"https://api.github.com/users/cmcarthur/following{/other_user}","gists_url":"https://api.github.com/users/cmcarthur/gists{/gist_id}","starred_url":"https://api.github.com/users/cmcarthur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmcarthur/subscriptions","organizations_url":"https://api.github.com/users/cmcarthur/orgs","repos_url":"https://api.github.com/users/cmcarthur/repos","events_url":"https://api.github.com/users/cmcarthur/events{/privacy}","received_events_url":"https://api.github.com/users/cmcarthur/received_events","type":"User","site_admin":false},"body":"did you figure it out? you should probably figure it out and remove this comment, or just remove it hah","created_at":"2018-04-20T17:09:58Z","updated_at":"2018-04-20T17:13:55Z","html_url":"https://github.com/fishtown-analytics/dbt/pull/739#discussion_r183114373","pull_request_url":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/739","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/comments/183114373"},"html":{"href":"https://github.com/fishtown-analytics/dbt/pull/739#discussion_r183114373"},"pull_request":{"href":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/739"}}},"pull_request":{"url":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/739","id":181655035,"html_url":"https://github.com/fishtown-analytics/dbt/pull/739","diff_url":"https://github.com/fishtown-analytics/dbt/pull/739.diff","patch_url":"https://github.com/fishtown-analytics/dbt/pull/739.patch","issue_url":"https://api.github.com/repos/fishtown-analytics/dbt/issues/739","number":739,"state":"open","locked":false,"title":"fix var precedence from cli, add tests","user":{"login":"drewbanin","id":1541139,"avatar_url":"https://avatars2.githubusercontent.com/u/1541139?v=4","gravatar_id":"","url":"https://api.github.com/users/drewbanin","html_url":"https://github.com/drewbanin","followers_url":"https://api.github.com/users/drewbanin/followers","following_url":"https://api.github.com/users/drewbanin/following{/other_user}","gists_url":"https://api.github.com/users/drewbanin/gists{/gist_id}","starred_url":"https://api.github.com/users/drewbanin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewbanin/subscriptions","organizations_url":"https://api.github.com/users/drewbanin/orgs","repos_url":"https://api.github.com/users/drewbanin/repos","events_url":"https://api.github.com/users/drewbanin/events{/privacy}","received_events_url":"https://api.github.com/users/drewbanin/received_events","type":"User","site_admin":false},"body":"fixes https://github.com/fishtown-analytics/dbt/issues/710\r\n\r\nBig TODO here -- why didn't these tests fail previously? Does this PR change behavior beyond the precedence fix?","created_at":"2018-04-14T16:17:12Z","updated_at":"2018-04-20T17:13:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9af74933751a5604fdaec484256e71b5535e1b69","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/739/commits","review_comments_url":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/739/comments","review_comment_url":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fishtown-analytics/dbt/issues/739/comments","statuses_url":"https://api.github.com/repos/fishtown-analytics/dbt/statuses/50774b386af463c41a7921727137cf7c180bd6de","head":{"label":"fishtown-analytics:fix/var-precedence","ref":"fix/var-precedence","sha":"50774b386af463c41a7921727137cf7c180bd6de","user":{"login":"fishtown-analytics","id":18339788,"avatar_url":"https://avatars1.githubusercontent.com/u/18339788?v=4","gravatar_id":"","url":"https://api.github.com/users/fishtown-analytics","html_url":"https://github.com/fishtown-analytics","followers_url":"https://api.github.com/users/fishtown-analytics/followers","following_url":"https://api.github.com/users/fishtown-analytics/following{/other_user}","gists_url":"https://api.github.com/users/fishtown-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/fishtown-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fishtown-analytics/subscriptions","organizations_url":"https://api.github.com/users/fishtown-analytics/orgs","repos_url":"https://api.github.com/users/fishtown-analytics/repos","events_url":"https://api.github.com/users/fishtown-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/fishtown-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":53548867,"name":"dbt","full_name":"fishtown-analytics/dbt","owner":{"login":"fishtown-analytics","id":18339788,"avatar_url":"https://avatars1.githubusercontent.com/u/18339788?v=4","gravatar_id":"","url":"https://api.github.com/users/fishtown-analytics","html_url":"https://github.com/fishtown-analytics","followers_url":"https://api.github.com/users/fishtown-analytics/followers","following_url":"https://api.github.com/users/fishtown-analytics/following{/other_user}","gists_url":"https://api.github.com/users/fishtown-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/fishtown-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fishtown-analytics/subscriptions","organizations_url":"https://api.github.com/users/fishtown-analytics/orgs","repos_url":"https://api.github.com/users/fishtown-analytics/repos","events_url":"https://api.github.com/users/fishtown-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/fishtown-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fishtown-analytics/dbt","description":"dbt (data build tool) is a command line tool that enables data analysts and engineers to transform data in their warehouse more effectively.","fork":false,"url":"https://api.github.com/repos/fishtown-analytics/dbt","forks_url":"https://api.github.com/repos/fishtown-analytics/dbt/forks","keys_url":"https://api.github.com/repos/fishtown-analytics/dbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fishtown-analytics/dbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fishtown-analytics/dbt/teams","hooks_url":"https://api.github.com/repos/fishtown-analytics/dbt/hooks","issue_events_url":"https://api.github.com/repos/fishtown-analytics/dbt/issues/events{/number}","events_url":"https://api.github.com/repos/fishtown-analytics/dbt/events","assignees_url":"https://api.github.com/repos/fishtown-analytics/dbt/assignees{/user}","branches_url":"https://api.github.com/repos/fishtown-analytics/dbt/branches{/branch}","tags_url":"https://api.github.com/repos/fishtown-analytics/dbt/tags","blobs_url":"https://api.github.com/repos/fishtown-analytics/dbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fishtown-analytics/dbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fishtown-analytics/dbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/fishtown-analytics/dbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fishtown-analytics/dbt/statuses/{sha}","languages_url":"https://api.github.com/repos/fishtown-analytics/dbt/languages","stargazers_url":"https://api.github.com/repos/fishtown-analytics/dbt/stargazers","contributors_url":"https://api.github.com/repos/fishtown-analytics/dbt/contributors","subscribers_url":"https://api.github.com/repos/fishtown-analytics/dbt/subscribers","subscription_url":"https://api.github.com/repos/fishtown-analytics/dbt/subscription","commits_url":"https://api.github.com/repos/fishtown-analytics/dbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/fishtown-analytics/dbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/fishtown-analytics/dbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/fishtown-analytics/dbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/fishtown-analytics/dbt/contents/{+path}","compare_url":"https://api.github.com/repos/fishtown-analytics/dbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fishtown-analytics/dbt/merges","archive_url":"https://api.github.com/repos/fishtown-analytics/dbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fishtown-analytics/dbt/downloads","issues_url":"https://api.github.com/repos/fishtown-analytics/dbt/issues{/number}","pulls_url":"https://api.github.com/repos/fishtown-analytics/dbt/pulls{/number}","milestones_url":"https://api.github.com/repos/fishtown-analytics/dbt/milestones{/number}","notifications_url":"https://api.github.com/repos/fishtown-analytics/dbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fishtown-analytics/dbt/labels{/name}","releases_url":"https://api.github.com/repos/fishtown-analytics/dbt/releases{/id}","deployments_url":"https://api.github.com/repos/fishtown-analytics/dbt/deployments","created_at":"2016-03-10T02:38:00Z","updated_at":"2018-04-18T19:23:37Z","pushed_at":"2018-04-16T19:42:31Z","git_url":"git://github.com/fishtown-analytics/dbt.git","ssh_url":"git@github.com:fishtown-analytics/dbt.git","clone_url":"https://github.com/fishtown-analytics/dbt.git","svn_url":"https://github.com/fishtown-analytics/dbt","homepage":"https://www.getdbt.com/","size":2207,"stargazers_count":210,"watchers_count":210,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":41,"open_issues":109,"watchers":210,"default_branch":"development"}},"base":{"label":"fishtown-analytics:development","ref":"development","sha":"d966ec28aae4cc70b7da409ae708cf29ff3d52cd","user":{"login":"fishtown-analytics","id":18339788,"avatar_url":"https://avatars1.githubusercontent.com/u/18339788?v=4","gravatar_id":"","url":"https://api.github.com/users/fishtown-analytics","html_url":"https://github.com/fishtown-analytics","followers_url":"https://api.github.com/users/fishtown-analytics/followers","following_url":"https://api.github.com/users/fishtown-analytics/following{/other_user}","gists_url":"https://api.github.com/users/fishtown-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/fishtown-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fishtown-analytics/subscriptions","organizations_url":"https://api.github.com/users/fishtown-analytics/orgs","repos_url":"https://api.github.com/users/fishtown-analytics/repos","events_url":"https://api.github.com/users/fishtown-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/fishtown-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":53548867,"name":"dbt","full_name":"fishtown-analytics/dbt","owner":{"login":"fishtown-analytics","id":18339788,"avatar_url":"https://avatars1.githubusercontent.com/u/18339788?v=4","gravatar_id":"","url":"https://api.github.com/users/fishtown-analytics","html_url":"https://github.com/fishtown-analytics","followers_url":"https://api.github.com/users/fishtown-analytics/followers","following_url":"https://api.github.com/users/fishtown-analytics/following{/other_user}","gists_url":"https://api.github.com/users/fishtown-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/fishtown-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fishtown-analytics/subscriptions","organizations_url":"https://api.github.com/users/fishtown-analytics/orgs","repos_url":"https://api.github.com/users/fishtown-analytics/repos","events_url":"https://api.github.com/users/fishtown-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/fishtown-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fishtown-analytics/dbt","description":"dbt (data build tool) is a command line tool that enables data analysts and engineers to transform data in their warehouse more effectively.","fork":false,"url":"https://api.github.com/repos/fishtown-analytics/dbt","forks_url":"https://api.github.com/repos/fishtown-analytics/dbt/forks","keys_url":"https://api.github.com/repos/fishtown-analytics/dbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fishtown-analytics/dbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fishtown-analytics/dbt/teams","hooks_url":"https://api.github.com/repos/fishtown-analytics/dbt/hooks","issue_events_url":"https://api.github.com/repos/fishtown-analytics/dbt/issues/events{/number}","events_url":"https://api.github.com/repos/fishtown-analytics/dbt/events","assignees_url":"https://api.github.com/repos/fishtown-analytics/dbt/assignees{/user}","branches_url":"https://api.github.com/repos/fishtown-analytics/dbt/branches{/branch}","tags_url":"https://api.github.com/repos/fishtown-analytics/dbt/tags","blobs_url":"https://api.github.com/repos/fishtown-analytics/dbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fishtown-analytics/dbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fishtown-analytics/dbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/fishtown-analytics/dbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fishtown-analytics/dbt/statuses/{sha}","languages_url":"https://api.github.com/repos/fishtown-analytics/dbt/languages","stargazers_url":"https://api.github.com/repos/fishtown-analytics/dbt/stargazers","contributors_url":"https://api.github.com/repos/fishtown-analytics/dbt/contributors","subscribers_url":"https://api.github.com/repos/fishtown-analytics/dbt/subscribers","subscription_url":"https://api.github.com/repos/fishtown-analytics/dbt/subscription","commits_url":"https://api.github.com/repos/fishtown-analytics/dbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/fishtown-analytics/dbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/fishtown-analytics/dbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/fishtown-analytics/dbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/fishtown-analytics/dbt/contents/{+path}","compare_url":"https://api.github.com/repos/fishtown-analytics/dbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fishtown-analytics/dbt/merges","archive_url":"https://api.github.com/repos/fishtown-analytics/dbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fishtown-analytics/dbt/downloads","issues_url":"https://api.github.com/repos/fishtown-analytics/dbt/issues{/number}","pulls_url":"https://api.github.com/repos/fishtown-analytics/dbt/pulls{/number}","milestones_url":"https://api.github.com/repos/fishtown-analytics/dbt/milestones{/number}","notifications_url":"https://api.github.com/repos/fishtown-analytics/dbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fishtown-analytics/dbt/labels{/name}","releases_url":"https://api.github.com/repos/fishtown-analytics/dbt/releases{/id}","deployments_url":"https://api.github.com/repos/fishtown-analytics/dbt/deployments","created_at":"2016-03-10T02:38:00Z","updated_at":"2018-04-18T19:23:37Z","pushed_at":"2018-04-16T19:42:31Z","git_url":"git://github.com/fishtown-analytics/dbt.git","ssh_url":"git@github.com:fishtown-analytics/dbt.git","clone_url":"https://github.com/fishtown-analytics/dbt.git","svn_url":"https://github.com/fishtown-analytics/dbt","homepage":"https://www.getdbt.com/","size":2207,"stargazers_count":210,"watchers_count":210,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":41,"open_issues":109,"watchers":210,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/739"},"html":{"href":"https://github.com/fishtown-analytics/dbt/pull/739"},"issue":{"href":"https://api.github.com/repos/fishtown-analytics/dbt/issues/739"},"comments":{"href":"https://api.github.com/repos/fishtown-analytics/dbt/issues/739/comments"},"review_comments":{"href":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/739/comments"},"review_comment":{"href":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fishtown-analytics/dbt/pulls/739/commits"},"statuses":{"href":"https://api.github.com/repos/fishtown-analytics/dbt/statuses/50774b386af463c41a7921727137cf7c180bd6de"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cmcarthur"}}