{"action":"created","issue":{"url":"https://api.github.com/repos/ucsdlib/damspas/issues/533","repository_url":"https://api.github.com/repos/ucsdlib/damspas","labels_url":"https://api.github.com/repos/ucsdlib/damspas/issues/533/labels{/name}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/issues/533/comments","events_url":"https://api.github.com/repos/ucsdlib/damspas/issues/533/events","html_url":"https://github.com/ucsdlib/damspas/pull/533","id":361934398,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NzgxODkx","number":533,"title":"docker: enable debugging with byebug and friends","user":{"login":"mcritchlow","id":67506,"node_id":"MDQ6VXNlcjY3NTA2","avatar_url":"https://avatars2.githubusercontent.com/u/67506?v=4","gravatar_id":"","url":"https://api.github.com/users/mcritchlow","html_url":"https://github.com/mcritchlow","followers_url":"https://api.github.com/users/mcritchlow/followers","following_url":"https://api.github.com/users/mcritchlow/following{/other_user}","gists_url":"https://api.github.com/users/mcritchlow/gists{/gist_id}","starred_url":"https://api.github.com/users/mcritchlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcritchlow/subscriptions","organizations_url":"https://api.github.com/users/mcritchlow/orgs","repos_url":"https://api.github.com/users/mcritchlow/repos","events_url":"https://api.github.com/users/mcritchlow/events{/privacy}","received_events_url":"https://api.github.com/users/mcritchlow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-19T21:27:20Z","updated_at":"2018-09-20T21:30:42Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ucsdlib/damspas/pulls/533","html_url":"https://github.com/ucsdlib/damspas/pull/533","diff_url":"https://github.com/ucsdlib/damspas/pull/533.diff","patch_url":"https://github.com/ucsdlib/damspas/pull/533.patch"},"body":"Fixes #issuenumber\r\n\r\n#### Local Checklist\r\n- [x] QA-ed locally?\r\n- [x] Configuration updated (if needed)?\r\n- [x] Documentation updated (if needed)?\r\n\r\n#### What does this PR do?\r\nAdds support and documentation for use debuggers like byebug with the docker/compose development environment\r\n\r\n##### Why are we doing this? Any context of related work?\r\nThis is still new territory for us, and I ran across this issue working on a different project last week. So I thought I would document and add the solution that I found here.\r\n\r\n#### Where should a reviewer start?\r\nSee [`docker/README.md`](https://github.com/ucsdlib/damspas/blob/c2aeaef13faaaa1aa4137122dd119c89e0b63db5/docker/README.md#debugging-w-byebug) for how this would be used in practice\r\n\r\n#### Manual testing steps?\r\n- Run a fresh build using the `docker/dev/docker-compose.yml` file.\r\n- Add a `byebug` statement somewhere. Controller, wherever.\r\n- Run the app and get it to trigger the breakpoint\r\n- Follow the instructions for using `docker attach <container>` and try interacting with byebug\r\n\r\n@ucsdlib/developers and @orangewolf - please review\r\n"},"comment":{"url":"https://api.github.com/repos/ucsdlib/damspas/issues/comments/423340263","html_url":"https://github.com/ucsdlib/damspas/pull/533#issuecomment-423340263","issue_url":"https://api.github.com/repos/ucsdlib/damspas/issues/533","id":423340263,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzM0MDI2Mw==","user":{"login":"mcritchlow","id":67506,"node_id":"MDQ6VXNlcjY3NTA2","avatar_url":"https://avatars2.githubusercontent.com/u/67506?v=4","gravatar_id":"","url":"https://api.github.com/users/mcritchlow","html_url":"https://github.com/mcritchlow","followers_url":"https://api.github.com/users/mcritchlow/followers","following_url":"https://api.github.com/users/mcritchlow/following{/other_user}","gists_url":"https://api.github.com/users/mcritchlow/gists{/gist_id}","starred_url":"https://api.github.com/users/mcritchlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcritchlow/subscriptions","organizations_url":"https://api.github.com/users/mcritchlow/orgs","repos_url":"https://api.github.com/users/mcritchlow/repos","events_url":"https://api.github.com/users/mcritchlow/events{/privacy}","received_events_url":"https://api.github.com/users/mcritchlow/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T21:30:42Z","updated_at":"2018-09-20T21:30:42Z","author_association":"MEMBER","body":"@lsitu - that's a good point. this is more on the assumption that one might use byebug, or another debugger that requires a terminal to interact with, like pry. So the error you're seeing makes sense, byebug isn't actually in our Gemfile in the test/dev group. I can add it as part of this PR if folks would like, but I was admittedly writing this as something that _could_ support it. Thoughts?"}}
{"actor":{"display_login":"mcritchlow"}}