{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/47276","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/47276/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47276/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/47276/events","html_url":"https://github.com/saltstack/salt/pull/47276","id":317288078,"number":47276,"title":"fix vpc_peering_connection_name option for create_route in boto_vpc module","user":{"login":"baniobloom","id":12503102,"avatar_url":"https://avatars1.githubusercontent.com/u/12503102?v=4","gravatar_id":"","url":"https://api.github.com/users/baniobloom","html_url":"https://github.com/baniobloom","followers_url":"https://api.github.com/users/baniobloom/followers","following_url":"https://api.github.com/users/baniobloom/following{/other_user}","gists_url":"https://api.github.com/users/baniobloom/gists{/gist_id}","starred_url":"https://api.github.com/users/baniobloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baniobloom/subscriptions","organizations_url":"https://api.github.com/users/baniobloom/orgs","repos_url":"https://api.github.com/users/baniobloom/repos","events_url":"https://api.github.com/users/baniobloom/events{/privacy}","received_events_url":"https://api.github.com/users/baniobloom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-24T15:49:32Z","updated_at":"2018-04-24T19:49:47Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/47276","html_url":"https://github.com/saltstack/salt/pull/47276","diff_url":"https://github.com/saltstack/salt/pull/47276.diff","patch_url":"https://github.com/saltstack/salt/pull/47276.patch"},"body":"All logic was there for use of vpc_peering_connection_name but it was missing from the _exactly_one conditional statement and the exception message\r\n\r\n### What does this PR do?\r\nMakes it possible to use vpc_peering_connection_name in the create_route function of the module boto_vpc\r\n\r\n### What issues does this PR fix or reference?\r\nMakes it possible to use vpc_peering_connection_name in the create_route function of the module boto_vpc\r\n\r\n### Previous Behavior\r\nIf you tried to use vpc_peering_connection_name you would get the _exactly_one error\r\n\r\n### New Behavior\r\nLooks up the vpc based on name\r\n\r\n### Tests written?\r\n\r\nNo\r\n\r\n### Commits signed with GPG?\r\n\r\nNo\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nSee GitHub's [page on GPG signing](https://help.github.com/articles/signing-commits-using-gpg/) for more information about signing commits with GPG.\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/384057537","html_url":"https://github.com/saltstack/salt/pull/47276#issuecomment-384057537","issue_url":"https://api.github.com/repos/saltstack/salt/issues/47276","id":384057537,"user":{"login":"baniobloom","id":12503102,"avatar_url":"https://avatars1.githubusercontent.com/u/12503102?v=4","gravatar_id":"","url":"https://api.github.com/users/baniobloom","html_url":"https://github.com/baniobloom","followers_url":"https://api.github.com/users/baniobloom/followers","following_url":"https://api.github.com/users/baniobloom/following{/other_user}","gists_url":"https://api.github.com/users/baniobloom/gists{/gist_id}","starred_url":"https://api.github.com/users/baniobloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baniobloom/subscriptions","organizations_url":"https://api.github.com/users/baniobloom/orgs","repos_url":"https://api.github.com/users/baniobloom/repos","events_url":"https://api.github.com/users/baniobloom/events{/privacy}","received_events_url":"https://api.github.com/users/baniobloom/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T19:49:47Z","updated_at":"2018-04-24T19:49:47Z","author_association":"NONE","body":"Yes I can do that.  Consider improving the documentation/guide (https://docs.saltstack.com/en/latest/topics/development/contributing.html) specifically how to figure out what branch to base bug fixes against.  That would go a long way toward making contributions easier. Two ideas:\r\n1. A dashboard that tells people which versions are accepting bug fixes \r\n2. How to pinpoint the oldest branch with the bug."}}
{"actor":{"display_login":"baniobloom"}}