{"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/235171601","pull_request_review_id":176977061,"id":235171601,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTE3MTYwMQ==","diff_hunk":"@@ -118,12 +117,10 @@ void convert_bl_mesh(\n         }\n     }\n \n-    int uv_index = 0;\n-\n     // Push triangles\n-    for (size_t tri_index = 0; tri_index < triangle_length; ++tri_index)\n+    for (size_t tri_index = 0; tri_index < bl_faces_count; ++tri_index)","path":"src/appleseed.python/bindblendermeshconverter.cpp","position":144,"original_position":144,"commit_id":"2eca8de1f1700a50c747ce0fab7454f1f8866ee9","original_commit_id":"2eca8de1f1700a50c747ce0fab7454f1f8866ee9","user":{"login":"dictoon","id":321290,"node_id":"MDQ6VXNlcjMyMTI5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/321290?v=4","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"For consistency's sake, rename `tri_index` to `face_index` (like you've done in other places).","created_at":"2018-11-20T21:15:39Z","updated_at":"2018-11-20T21:16:41Z","html_url":"https://github.com/appleseedhq/appleseed/pull/2301#discussion_r235171601","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2301","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/235171601"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/2301#discussion_r235171601"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2301"}}},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2301","id":231333793,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzMzNzkz","html_url":"https://github.com/appleseedhq/appleseed/pull/2301","diff_url":"https://github.com/appleseedhq/appleseed/pull/2301.diff","patch_url":"https://github.com/appleseedhq/appleseed/pull/2301.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/2301","number":2301,"state":"open","locked":false,"title":"Add triangulation stage to C++ blenderseed exporter","user":{"login":"jdent02","id":13521172,"node_id":"MDQ6VXNlcjEzNTIxMTcy","avatar_url":"https://avatars2.githubusercontent.com/u/13521172?v=4","gravatar_id":"","url":"https://api.github.com/users/jdent02","html_url":"https://github.com/jdent02","followers_url":"https://api.github.com/users/jdent02/followers","following_url":"https://api.github.com/users/jdent02/following{/other_user}","gists_url":"https://api.github.com/users/jdent02/gists{/gist_id}","starred_url":"https://api.github.com/users/jdent02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdent02/subscriptions","organizations_url":"https://api.github.com/users/jdent02/orgs","repos_url":"https://api.github.com/users/jdent02/repos","events_url":"https://api.github.com/users/jdent02/events{/privacy}","received_events_url":"https://api.github.com/users/jdent02/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-15T21:05:23Z","updated_at":"2018-11-20T21:16:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd7ab97e523c5d2b2e1b4a37616eb5f23fa890bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2301/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2301/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/2301/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/2eca8de1f1700a50c747ce0fab7454f1f8866ee9","head":{"label":"jdent02:blenderseed_cpp_export","ref":"blenderseed_cpp_export","sha":"2eca8de1f1700a50c747ce0fab7454f1f8866ee9","user":{"login":"jdent02","id":13521172,"node_id":"MDQ6VXNlcjEzNTIxMTcy","avatar_url":"https://avatars2.githubusercontent.com/u/13521172?v=4","gravatar_id":"","url":"https://api.github.com/users/jdent02","html_url":"https://github.com/jdent02","followers_url":"https://api.github.com/users/jdent02/followers","following_url":"https://api.github.com/users/jdent02/following{/other_user}","gists_url":"https://api.github.com/users/jdent02/gists{/gist_id}","starred_url":"https://api.github.com/users/jdent02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdent02/subscriptions","organizations_url":"https://api.github.com/users/jdent02/orgs","repos_url":"https://api.github.com/users/jdent02/repos","events_url":"https://api.github.com/users/jdent02/events{/privacy}","received_events_url":"https://api.github.com/users/jdent02/received_events","type":"User","site_admin":false},"repo":{"id":119104414,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkxMDQ0MTQ=","name":"appleseed","full_name":"jdent02/appleseed","private":false,"owner":{"login":"jdent02","id":13521172,"node_id":"MDQ6VXNlcjEzNTIxMTcy","avatar_url":"https://avatars2.githubusercontent.com/u/13521172?v=4","gravatar_id":"","url":"https://api.github.com/users/jdent02","html_url":"https://github.com/jdent02","followers_url":"https://api.github.com/users/jdent02/followers","following_url":"https://api.github.com/users/jdent02/following{/other_user}","gists_url":"https://api.github.com/users/jdent02/gists{/gist_id}","starred_url":"https://api.github.com/users/jdent02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdent02/subscriptions","organizations_url":"https://api.github.com/users/jdent02/orgs","repos_url":"https://api.github.com/users/jdent02/repos","events_url":"https://api.github.com/users/jdent02/events{/privacy}","received_events_url":"https://api.github.com/users/jdent02/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jdent02/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":true,"url":"https://api.github.com/repos/jdent02/appleseed","forks_url":"https://api.github.com/repos/jdent02/appleseed/forks","keys_url":"https://api.github.com/repos/jdent02/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdent02/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdent02/appleseed/teams","hooks_url":"https://api.github.com/repos/jdent02/appleseed/hooks","issue_events_url":"https://api.github.com/repos/jdent02/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/jdent02/appleseed/events","assignees_url":"https://api.github.com/repos/jdent02/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/jdent02/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/jdent02/appleseed/tags","blobs_url":"https://api.github.com/repos/jdent02/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdent02/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdent02/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdent02/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdent02/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/jdent02/appleseed/languages","stargazers_url":"https://api.github.com/repos/jdent02/appleseed/stargazers","contributors_url":"https://api.github.com/repos/jdent02/appleseed/contributors","subscribers_url":"https://api.github.com/repos/jdent02/appleseed/subscribers","subscription_url":"https://api.github.com/repos/jdent02/appleseed/subscription","commits_url":"https://api.github.com/repos/jdent02/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdent02/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdent02/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdent02/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdent02/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/jdent02/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdent02/appleseed/merges","archive_url":"https://api.github.com/repos/jdent02/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdent02/appleseed/downloads","issues_url":"https://api.github.com/repos/jdent02/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/jdent02/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/jdent02/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/jdent02/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdent02/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/jdent02/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/jdent02/appleseed/deployments","created_at":"2018-01-26T21:19:49Z","updated_at":"2018-11-15T20:20:31Z","pushed_at":"2018-11-20T16:56:28Z","git_url":"git://github.com/jdent02/appleseed.git","ssh_url":"git@github.com:jdent02/appleseed.git","clone_url":"https://github.com/jdent02/appleseed.git","svn_url":"https://github.com/jdent02/appleseed","homepage":"http://appleseedhq.net/","size":1316765,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"a1e7800c05fd2678dd4edbc28c1cab5d72fd36a7","user":{"login":"appleseedhq","id":6373510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNzM1MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":753784,"node_id":"MDEwOlJlcG9zaXRvcnk3NTM3ODQ=","name":"appleseed","full_name":"appleseedhq/appleseed","private":false,"owner":{"login":"appleseedhq","id":6373510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNzM1MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/appleseedhq/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed","forks_url":"https://api.github.com/repos/appleseedhq/appleseed/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed/deployments","created_at":"2010-07-02T16:33:51Z","updated_at":"2018-11-20T20:52:03Z","pushed_at":"2018-11-20T20:51:58Z","git_url":"git://github.com/appleseedhq/appleseed.git","ssh_url":"git@github.com:appleseedhq/appleseed.git","clone_url":"https://github.com/appleseedhq/appleseed.git","svn_url":"https://github.com/appleseedhq/appleseed","homepage":"https://appleseedhq.net/","size":1316817,"stargazers_count":1155,"watchers_count":1155,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":201,"mirror_url":null,"archived":false,"open_issues_count":380,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":201,"open_issues":380,"watchers":1155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2301"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/2301"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/2301"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/2301/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2301/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2301/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed/statuses/2eca8de1f1700a50c747ce0fab7454f1f8866ee9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dictoon"}}