{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/26632","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/26632/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/26632/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/26632/events","html_url":"https://github.com/symfony/symfony/pull/26632","id":307561861,"number":26632,"title":"[AMQP] Add AMQP adapter for Messenger component","user":{"login":"sroze","id":804625,"avatar_url":"https://avatars0.githubusercontent.com/u/804625?v=4","gravatar_id":"","url":"https://api.github.com/users/sroze","html_url":"https://github.com/sroze","followers_url":"https://api.github.com/users/sroze/followers","following_url":"https://api.github.com/users/sroze/following{/other_user}","gists_url":"https://api.github.com/users/sroze/gists{/gist_id}","starred_url":"https://api.github.com/users/sroze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sroze/subscriptions","organizations_url":"https://api.github.com/users/sroze/orgs","repos_url":"https://api.github.com/users/sroze/repos","events_url":"https://api.github.com/users/sroze/events{/privacy}","received_events_url":"https://api.github.com/users/sroze/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-03-22T09:21:10Z","updated_at":"2018-03-22T11:02:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/26632","html_url":"https://github.com/symfony/symfony/pull/26632","diff_url":"https://github.com/symfony/symfony/pull/26632.diff","patch_url":"https://github.com/symfony/symfony/pull/26632.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | ø\r\n| License       | MIT\r\n\r\n- [ ] Depends on the Messenger component #24411\r\n- [ ] Add tests once we are all happy about the structure\r\n\r\n---\r\n\r\nIn order to give a great DX for simple needs such as sending messages through an AMQP broker such as RabbitMq, we should ship an AMQP adapter for the Messenger component within Symfony Core. It should be as simple as this proposal. We don't need to handle more specific use-cases nor brokers as other adapters such as the [enqueue adapter](https://github.com/sroze/enqueue-bridge) can also be used. \r\n\r\nThis PR creates a bridge (in `Symfony\\Bridge\\PhpAmqp`) for the Messenger component, using PHP's AMQP extension. It also creates a `Symfony\\Bundle\\PhpAmqpBundle` in order to have [a recipe](https://github.com/symfony/recipes/compare/master...sroze:add-amqp-bundle-recipe) that adds the environment variable when necessary."},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/375264822","html_url":"https://github.com/symfony/symfony/pull/26632#issuecomment-375264822","issue_url":"https://api.github.com/repos/symfony/symfony/issues/26632","id":375264822,"user":{"login":"sroze","id":804625,"avatar_url":"https://avatars0.githubusercontent.com/u/804625?v=4","gravatar_id":"","url":"https://api.github.com/users/sroze","html_url":"https://github.com/sroze","followers_url":"https://api.github.com/users/sroze/followers","following_url":"https://api.github.com/users/sroze/following{/other_user}","gists_url":"https://api.github.com/users/sroze/gists{/gist_id}","starred_url":"https://api.github.com/users/sroze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sroze/subscriptions","organizations_url":"https://api.github.com/users/sroze/orgs","repos_url":"https://api.github.com/users/sroze/repos","events_url":"https://api.github.com/users/sroze/events{/privacy}","received_events_url":"https://api.github.com/users/sroze/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T11:02:36Z","updated_at":"2018-03-22T11:02:36Z","author_association":"CONTRIBUTOR","body":"> we'll just ship with a default config based on e.g. PDO\r\n\r\nWhat do you mean? Where would you see this configuration to be tweaked by the developer? Could you give me a bullet-list example compared to what I described above as I don't get how it could be simple for the developer?"}}
{"actor":{"display_login":"sroze"}}