{"action":"created","issue":{"url":"https://api.github.com/repos/minio/minio/issues/6523","repository_url":"https://api.github.com/repos/minio/minio","labels_url":"https://api.github.com/repos/minio/minio/issues/6523/labels{/name}","comments_url":"https://api.github.com/repos/minio/minio/issues/6523/comments","events_url":"https://api.github.com/repos/minio/minio/issues/6523/events","html_url":"https://github.com/minio/minio/pull/6523","id":363926136,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MjM5MDc5","number":6523,"title":"add auto-encryption for SSE-S3 using a KMS","user":{"login":"aead","id":20368805,"node_id":"MDQ6VXNlcjIwMzY4ODA1","avatar_url":"https://avatars0.githubusercontent.com/u/20368805?v=4","gravatar_id":"","url":"https://api.github.com/users/aead","html_url":"https://github.com/aead","followers_url":"https://api.github.com/users/aead/followers","following_url":"https://api.github.com/users/aead/following{/other_user}","gists_url":"https://api.github.com/users/aead/gists{/gist_id}","starred_url":"https://api.github.com/users/aead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aead/subscriptions","organizations_url":"https://api.github.com/users/aead/orgs","repos_url":"https://api.github.com/users/aead/repos","events_url":"https://api.github.com/users/aead/events{/privacy}","received_events_url":"https://api.github.com/users/aead/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-26T09:05:15Z","updated_at":"2018-10-04T21:43:13Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/6523","html_url":"https://github.com/minio/minio/pull/6523","diff_url":"https://github.com/minio/minio/pull/6523.diff","patch_url":"https://github.com/minio/minio/pull/6523.patch"},"body":"**Note:** PR is based on #6488 \r\n\r\n## Description\r\nThis commit adds an auto-encryption feature which allows\r\nthe Minio operator to ensure that uploaded objects are\r\nalways encrypted.\r\n\r\nThis change adds the `autoEncryption` configuration option\r\nas part of the KMS conifguration and the ENV. variable\r\n`MINIO_SSE_AUTO_ENCRYPTION:{on,off}`.\r\n\r\nSince the configuration file has now an additional field\r\nthe config version is upgraded to 30.\r\n\r\nIt also updates the KMS documentation according to the\r\nchanges.\r\n\r\n## Motivation and Context\r\nFixes #6502\r\n\r\n## Regression\r\nNo\r\n\r\n## How Has This Been Tested?\r\nmanually\r\n For reviewers:\r\n 1. `export MINIO_SSE_AUTO_ENCRYPTION=on` should cause server to fail during startup (same for config file)\r\n 2. After `export MINIO_SSE_MASTER_KEY=my-minio-key:6368616e676520746869732070617373776f726420746f206120736563726574` server should start for (fs / xl but not for e.g. azure b/c no encryption support) and any uploaded objects should be encrypted.\r\n \r\n## Types of changes\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/minio/minio/issues/comments/427179693","html_url":"https://github.com/minio/minio/pull/6523#issuecomment-427179693","issue_url":"https://api.github.com/repos/minio/minio/issues/6523","id":427179693,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzE3OTY5Mw==","user":{"login":"poornas","id":791968,"node_id":"MDQ6VXNlcjc5MTk2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/791968?v=4","gravatar_id":"","url":"https://api.github.com/users/poornas","html_url":"https://github.com/poornas","followers_url":"https://api.github.com/users/poornas/followers","following_url":"https://api.github.com/users/poornas/following{/other_user}","gists_url":"https://api.github.com/users/poornas/gists{/gist_id}","starred_url":"https://api.github.com/users/poornas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poornas/subscriptions","organizations_url":"https://api.github.com/users/poornas/orgs","repos_url":"https://api.github.com/users/poornas/repos","events_url":"https://api.github.com/users/poornas/events{/privacy}","received_events_url":"https://api.github.com/users/poornas/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T21:43:13Z","updated_at":"2018-10-04T21:43:13Z","author_association":"CONTRIBUTOR","body":"@aead, can you fix conflicts and rebase this?"}}
{"actor":{"display_login":"poornas"}}