{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/comments/231673215","pull_request_review_id":172694579,"id":231673215,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTY3MzIxNQ==","diff_hunk":"@@ -81,6 +83,17 @@ objects:\n           The time that this resource was created on the server.\n           This is in RFC3339 text format.\n         output: true\n+      - !ruby/object:Api::Type::KeyValuePairs\n+        name: 'labels'\n+        description: |\n+          A set of key/value label pairs to assign to this ManagedZone.\n+        update_verb: :PATCH","path":"products/dns/api.yaml","position":17,"original_position":17,"commit_id":"76b8c49f592edd2edb451038bee5e2149ef00c26","original_commit_id":"76b8c49f592edd2edb451038bee5e2149ef00c26","user":{"login":"danawillow","id":1130694,"node_id":"MDQ6VXNlcjExMzA2OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1130694?v=4","gravatar_id":"","url":"https://api.github.com/users/danawillow","html_url":"https://github.com/danawillow","followers_url":"https://api.github.com/users/danawillow/followers","following_url":"https://api.github.com/users/danawillow/following{/other_user}","gists_url":"https://api.github.com/users/danawillow/gists{/gist_id}","starred_url":"https://api.github.com/users/danawillow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danawillow/subscriptions","organizations_url":"https://api.github.com/users/danawillow/orgs","repos_url":"https://api.github.com/users/danawillow/repos","events_url":"https://api.github.com/users/danawillow/events{/privacy}","received_events_url":"https://api.github.com/users/danawillow/received_events","type":"User","site_admin":false},"body":"This and the next line can be removed, since it's the same as the rest of the resource","created_at":"2018-11-07T20:55:28Z","updated_at":"2018-11-07T20:57:19Z","html_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/697#discussion_r231673215","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/697","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/comments/231673215"},"html":{"href":"https://github.com/GoogleCloudPlatform/magic-modules/pull/697#discussion_r231673215"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/697"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/697","id":228886672,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODg2Njcy","html_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/697","diff_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/697.diff","patch_url":"https://github.com/GoogleCloudPlatform/magic-modules/pull/697.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/697","number":697,"state":"open","locked":false,"title":"[Terraform] [WIP] autogenerate resource_dns_managed_zone","user":{"login":"drebes","id":868150,"node_id":"MDQ6VXNlcjg2ODE1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/868150?v=4","gravatar_id":"","url":"https://api.github.com/users/drebes","html_url":"https://github.com/drebes","followers_url":"https://api.github.com/users/drebes/followers","following_url":"https://api.github.com/users/drebes/following{/other_user}","gists_url":"https://api.github.com/users/drebes/gists{/gist_id}","starred_url":"https://api.github.com/users/drebes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drebes/subscriptions","organizations_url":"https://api.github.com/users/drebes/orgs","repos_url":"https://api.github.com/users/drebes/repos","events_url":"https://api.github.com/users/drebes/events{/privacy}","received_events_url":"https://api.github.com/users/drebes/received_events","type":"User","site_admin":false},"body":"This is my first attempt on generating resource_dns_managed_zone using magic-modules. \r\n\r\nAs the module is generating only against the v1 version of the API for now, which [does not support update/patch](https://cloud.google.com/dns/docs/reference/v1/managedZones) on the resource, the autogenerated tests are not testing update. I also didn't include support for RecordSets yet, as that will be more complex and I wanted to start simple.\r\n\r\nI'm still trying to figure out how testing works, for example, how can my autogenerated tests be against a zone like \"tf-acctest-%s.hashicorptest.com.\", but not have that domain showing up in the generated docs.\r\n\r\n<!-- A summary of the changes in this commit goes here -->\r\n\r\n<!--\r\nChanges per downstream repository.  For each repository that you\r\nexpect to have changed, find the [tag] and write your commit\r\nmessage beneath it.  More-specific tags replace less-specific tags.\r\nFor example, if you provide a message under [all], a message under\r\n[puppet], and a message under [puppet-dns], the Terraform repository\r\nwill have the resulting commit made using the [all] message, the\r\nPuppet Compute repository will have its commit made using [puppet],\r\nand the Puppet DNS repository will have its commit made using\r\n[puppet-dns].  You can delete unused tags, but you don't need to.\r\n\r\nThe structure of the PR body is important to our CI system!\r\nThe comments can be deleted, but if you want to make the downstream\r\ncommits sensible, you'll need to leave the dashed line separating\r\nthis PR's changes from the commit messages for downstream commits.\r\n-->\r\n\r\n<!-- \r\nNote: You may see \"This branch is out-of-date with the base branch\"\r\nwhen you submit a pull request. This is fine! We don't use the GitHub\r\nmerge button to merge PRs, and you can safely ignore that message.\r\n-->\r\n\r\n-----------------------------------------------------------------\r\n# [all]\r\n## [terraform]\r\nStart autogenerating resource_dns_managed_zone\r\n### [terraform-beta]\r\n## [ansible]\r\n## [inspec]","created_at":"2018-11-07T01:09:32Z","updated_at":"2018-11-07T20:57:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89701e8a85f71dd193767bc9dad172eac5d75b40","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":995484256,"node_id":"MDU6TGFiZWw5OTU0ODQyNTY=","url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/697/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/697/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/697/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/statuses/76b8c49f592edd2edb451038bee5e2149ef00c26","head":{"label":"drebes:terraform-dns","ref":"terraform-dns","sha":"76b8c49f592edd2edb451038bee5e2149ef00c26","user":{"login":"drebes","id":868150,"node_id":"MDQ6VXNlcjg2ODE1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/868150?v=4","gravatar_id":"","url":"https://api.github.com/users/drebes","html_url":"https://github.com/drebes","followers_url":"https://api.github.com/users/drebes/followers","following_url":"https://api.github.com/users/drebes/following{/other_user}","gists_url":"https://api.github.com/users/drebes/gists{/gist_id}","starred_url":"https://api.github.com/users/drebes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drebes/subscriptions","organizations_url":"https://api.github.com/users/drebes/orgs","repos_url":"https://api.github.com/users/drebes/repos","events_url":"https://api.github.com/users/drebes/events{/privacy}","received_events_url":"https://api.github.com/users/drebes/received_events","type":"User","site_admin":false},"repo":{"id":155780588,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3ODA1ODg=","name":"magic-modules","full_name":"drebes/magic-modules","private":false,"owner":{"login":"drebes","id":868150,"node_id":"MDQ6VXNlcjg2ODE1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/868150?v=4","gravatar_id":"","url":"https://api.github.com/users/drebes","html_url":"https://github.com/drebes","followers_url":"https://api.github.com/users/drebes/followers","following_url":"https://api.github.com/users/drebes/following{/other_user}","gists_url":"https://api.github.com/users/drebes/gists{/gist_id}","starred_url":"https://api.github.com/users/drebes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drebes/subscriptions","organizations_url":"https://api.github.com/users/drebes/orgs","repos_url":"https://api.github.com/users/drebes/repos","events_url":"https://api.github.com/users/drebes/events{/privacy}","received_events_url":"https://api.github.com/users/drebes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/drebes/magic-modules","description":"Magic Modules: Automagically generate Google Cloud Platform support for OSS","fork":true,"url":"https://api.github.com/repos/drebes/magic-modules","forks_url":"https://api.github.com/repos/drebes/magic-modules/forks","keys_url":"https://api.github.com/repos/drebes/magic-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drebes/magic-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drebes/magic-modules/teams","hooks_url":"https://api.github.com/repos/drebes/magic-modules/hooks","issue_events_url":"https://api.github.com/repos/drebes/magic-modules/issues/events{/number}","events_url":"https://api.github.com/repos/drebes/magic-modules/events","assignees_url":"https://api.github.com/repos/drebes/magic-modules/assignees{/user}","branches_url":"https://api.github.com/repos/drebes/magic-modules/branches{/branch}","tags_url":"https://api.github.com/repos/drebes/magic-modules/tags","blobs_url":"https://api.github.com/repos/drebes/magic-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drebes/magic-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drebes/magic-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/drebes/magic-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drebes/magic-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/drebes/magic-modules/languages","stargazers_url":"https://api.github.com/repos/drebes/magic-modules/stargazers","contributors_url":"https://api.github.com/repos/drebes/magic-modules/contributors","subscribers_url":"https://api.github.com/repos/drebes/magic-modules/subscribers","subscription_url":"https://api.github.com/repos/drebes/magic-modules/subscription","commits_url":"https://api.github.com/repos/drebes/magic-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/drebes/magic-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/drebes/magic-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/drebes/magic-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/drebes/magic-modules/contents/{+path}","compare_url":"https://api.github.com/repos/drebes/magic-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drebes/magic-modules/merges","archive_url":"https://api.github.com/repos/drebes/magic-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drebes/magic-modules/downloads","issues_url":"https://api.github.com/repos/drebes/magic-modules/issues{/number}","pulls_url":"https://api.github.com/repos/drebes/magic-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/drebes/magic-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/drebes/magic-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drebes/magic-modules/labels{/name}","releases_url":"https://api.github.com/repos/drebes/magic-modules/releases{/id}","deployments_url":"https://api.github.com/repos/drebes/magic-modules/deployments","created_at":"2018-11-01T21:55:21Z","updated_at":"2018-11-07T13:53:15Z","pushed_at":"2018-11-07T20:09:28Z","git_url":"git://github.com/drebes/magic-modules.git","ssh_url":"git@github.com:drebes/magic-modules.git","clone_url":"https://github.com/drebes/magic-modules.git","svn_url":"https://github.com/drebes/magic-modules","homepage":"","size":6024,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"c60d4b9f857e623c6fe0af899d764b54de78d393","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":114834469,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4MzQ0Njk=","name":"magic-modules","full_name":"GoogleCloudPlatform/magic-modules","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/magic-modules","description":"Magic Modules: Automagically generate Google Cloud Platform support for OSS","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/deployments","created_at":"2017-12-20T02:39:56Z","updated_at":"2018-11-07T19:00:33Z","pushed_at":"2018-11-07T20:09:30Z","git_url":"git://github.com/GoogleCloudPlatform/magic-modules.git","ssh_url":"git@github.com:GoogleCloudPlatform/magic-modules.git","clone_url":"https://github.com/GoogleCloudPlatform/magic-modules.git","svn_url":"https://github.com/GoogleCloudPlatform/magic-modules","homepage":"","size":6055,"stargazers_count":93,"watchers_count":93,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":37,"open_issues":89,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/697"},"html":{"href":"https://github.com/GoogleCloudPlatform/magic-modules/pull/697"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/697"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/697/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/697/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/pulls/697/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/statuses/76b8c49f592edd2edb451038bee5e2149ef00c26"}},"author_association":"NONE"}}
{"actor":{"display_login":"danawillow"}}