{"action":"created","comment":{"url":"https://api.github.com/repos/tikv/tikv/pulls/comments/212627685","pull_request_review_id":149302806,"id":212627685,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjYyNzY4NQ==","diff_hunk":"@@ -306,33 +307,30 @@\n \n # Allows OS to incrementally sync files to disk while they are being\n # written, asynchronously, in the background.\n-# bytes-per-sync = \"0MB\"\n+# bytes-per-sync = \"1MB\"","path":"etc/config-template.toml","position":13,"original_position":13,"commit_id":"f168f5c51ecd5193cae1f54b65e62e2cafa3dfaf","original_commit_id":"f168f5c51ecd5193cae1f54b65e62e2cafa3dfaf","user":{"login":"BusyJay","id":1701473,"node_id":"MDQ6VXNlcjE3MDE0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1701473?v=4","gravatar_id":"","url":"https://api.github.com/users/BusyJay","html_url":"https://github.com/BusyJay","followers_url":"https://api.github.com/users/BusyJay/followers","following_url":"https://api.github.com/users/BusyJay/following{/other_user}","gists_url":"https://api.github.com/users/BusyJay/gists{/gist_id}","starred_url":"https://api.github.com/users/BusyJay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BusyJay/subscriptions","organizations_url":"https://api.github.com/users/BusyJay/orgs","repos_url":"https://api.github.com/users/BusyJay/repos","events_url":"https://api.github.com/users/BusyJay/events{/privacy}","received_events_url":"https://api.github.com/users/BusyJay/received_events","type":"User","site_admin":false},"body":"Why change a commented out entry?","created_at":"2018-08-24T13:27:35Z","updated_at":"2018-08-24T13:37:21Z","html_url":"https://github.com/tikv/tikv/pull/3507#discussion_r212627685","pull_request_url":"https://api.github.com/repos/tikv/tikv/pulls/3507","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tikv/tikv/pulls/comments/212627685"},"html":{"href":"https://github.com/tikv/tikv/pull/3507#discussion_r212627685"},"pull_request":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3507"}}},"pull_request":{"url":"https://api.github.com/repos/tikv/tikv/pulls/3507","id":210448750,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDQ4NzUw","html_url":"https://github.com/tikv/tikv/pull/3507","diff_url":"https://github.com/tikv/tikv/pull/3507.diff","patch_url":"https://github.com/tikv/tikv/pull/3507.patch","issue_url":"https://api.github.com/repos/tikv/tikv/issues/3507","number":3507,"state":"open","locked":false,"title":"Allow configuring leader transfer max allowed log lag","user":{"login":"breeswish","id":1916485,"node_id":"MDQ6VXNlcjE5MTY0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Breezewish <breezewish@pingcap.com>\r\n\r\n<!--\r\nThank you for contributing to TiKV! Please read TiKV's [CONTRIBUTING](https://github.com/pingcap/tikv/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n## What have you changed? (mandatory)\r\n\r\nWhen user's disk is very fast, current hard-coded value 10 might not be sufficient. This is a hot fix for a client's problem to make it configurable. However we need better solutions in future.\r\n\r\nI also by hand changed some outdated default values appear in config files.\r\n\r\n## What are the type of the changes? (mandatory)\r\n\r\n- Bug fix (non-breaking change which fixes an issue)\r\n\r\n## How has this PR been tested? (mandatory)\r\n\r\nManually.\r\n\r\n## Does this PR affect documentation (docs/docs-cn) update? (mandatory)\r\n\r\nNo.\r\n\r\n## Does this PR affect tidb-ansible update? (mandatory)\r\n\r\nhttps://github.com/pingcap/tidb-ansible/pull/510\r\n\r\n## Refer to a related PR or issue link (optional)\r\n\r\n## Benchmark result if necessary (optional)\r\n\r\n## Add a few positive/negative examples (optional)\r\n\r\n","created_at":"2018-08-23T13:30:09Z","updated_at":"2018-08-24T13:37:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6234922be2eaa07a68accbe6a2f341a345b4e66","assignee":null,"assignees":[],"requested_reviewers":[{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":429262718,"node_id":"MDU6TGFiZWw0MjkyNjI3MTg=","url":"https://api.github.com/repos/tikv/tikv/labels/C:%20Raft","name":"C: Raft","color":"9df9d7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tikv/tikv/pulls/3507/commits","review_comments_url":"https://api.github.com/repos/tikv/tikv/pulls/3507/comments","review_comment_url":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tikv/tikv/issues/3507/comments","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/f168f5c51ecd5193cae1f54b65e62e2cafa3dfaf","head":{"label":"breeswish:wenxuan/log-lag-config","ref":"wenxuan/log-lag-config","sha":"f168f5c51ecd5193cae1f54b65e62e2cafa3dfaf","user":{"login":"breeswish","id":1916485,"node_id":"MDQ6VXNlcjE5MTY0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"repo":{"id":113962357,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM5NjIzNTc=","name":"tikv","full_name":"breeswish/tikv","owner":{"login":"breeswish","id":1916485,"node_id":"MDQ6VXNlcjE5MTY0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/breeswish/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":true,"url":"https://api.github.com/repos/breeswish/tikv","forks_url":"https://api.github.com/repos/breeswish/tikv/forks","keys_url":"https://api.github.com/repos/breeswish/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/breeswish/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/breeswish/tikv/teams","hooks_url":"https://api.github.com/repos/breeswish/tikv/hooks","issue_events_url":"https://api.github.com/repos/breeswish/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/breeswish/tikv/events","assignees_url":"https://api.github.com/repos/breeswish/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/breeswish/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/breeswish/tikv/tags","blobs_url":"https://api.github.com/repos/breeswish/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/breeswish/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/breeswish/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/breeswish/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/breeswish/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/breeswish/tikv/languages","stargazers_url":"https://api.github.com/repos/breeswish/tikv/stargazers","contributors_url":"https://api.github.com/repos/breeswish/tikv/contributors","subscribers_url":"https://api.github.com/repos/breeswish/tikv/subscribers","subscription_url":"https://api.github.com/repos/breeswish/tikv/subscription","commits_url":"https://api.github.com/repos/breeswish/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/breeswish/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/breeswish/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/breeswish/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/breeswish/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/breeswish/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/breeswish/tikv/merges","archive_url":"https://api.github.com/repos/breeswish/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/breeswish/tikv/downloads","issues_url":"https://api.github.com/repos/breeswish/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/breeswish/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/breeswish/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/breeswish/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/breeswish/tikv/labels{/name}","releases_url":"https://api.github.com/repos/breeswish/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/breeswish/tikv/deployments","created_at":"2017-12-12T08:14:53Z","updated_at":"2018-08-07T00:45:16Z","pushed_at":"2018-08-24T11:36:54Z","git_url":"git://github.com/breeswish/tikv.git","ssh_url":"git@github.com:breeswish/tikv.git","clone_url":"https://github.com/breeswish/tikv.git","svn_url":"https://github.com/breeswish/tikv","homepage":"https://pingcap.com","size":15980,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tikv:master","ref":"master","sha":"bc2641bbca47c99bd043290f7755f94511324138","user":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgzMzkxMA==","name":"tikv","full_name":"tikv/tikv","owner":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tikv/tikv","description":"Distributed transactional key-value database, originally created to complement TiDB","fork":false,"url":"https://api.github.com/repos/tikv/tikv","forks_url":"https://api.github.com/repos/tikv/tikv/forks","keys_url":"https://api.github.com/repos/tikv/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tikv/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tikv/tikv/teams","hooks_url":"https://api.github.com/repos/tikv/tikv/hooks","issue_events_url":"https://api.github.com/repos/tikv/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/tikv/tikv/events","assignees_url":"https://api.github.com/repos/tikv/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/tikv/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/tikv/tikv/tags","blobs_url":"https://api.github.com/repos/tikv/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tikv/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tikv/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/tikv/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tikv/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/tikv/tikv/languages","stargazers_url":"https://api.github.com/repos/tikv/tikv/stargazers","contributors_url":"https://api.github.com/repos/tikv/tikv/contributors","subscribers_url":"https://api.github.com/repos/tikv/tikv/subscribers","subscription_url":"https://api.github.com/repos/tikv/tikv/subscription","commits_url":"https://api.github.com/repos/tikv/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/tikv/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/tikv/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/tikv/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/tikv/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/tikv/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tikv/tikv/merges","archive_url":"https://api.github.com/repos/tikv/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tikv/tikv/downloads","issues_url":"https://api.github.com/repos/tikv/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/tikv/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/tikv/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/tikv/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tikv/tikv/labels{/name}","releases_url":"https://api.github.com/repos/tikv/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/tikv/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-08-24T13:10:40Z","pushed_at":"2018-08-24T13:12:54Z","git_url":"git://github.com/tikv/tikv.git","ssh_url":"git@github.com:tikv/tikv.git","clone_url":"https://github.com/tikv/tikv.git","svn_url":"https://github.com/tikv/tikv","homepage":"","size":15722,"stargazers_count":3532,"watchers_count":3532,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":472,"mirror_url":null,"archived":false,"open_issues_count":254,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":472,"open_issues":254,"watchers":3532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3507"},"html":{"href":"https://github.com/tikv/tikv/pull/3507"},"issue":{"href":"https://api.github.com/repos/tikv/tikv/issues/3507"},"comments":{"href":"https://api.github.com/repos/tikv/tikv/issues/3507/comments"},"review_comments":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3507/comments"},"review_comment":{"href":"https://api.github.com/repos/tikv/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tikv/tikv/pulls/3507/commits"},"statuses":{"href":"https://api.github.com/repos/tikv/tikv/statuses/f168f5c51ecd5193cae1f54b65e62e2cafa3dfaf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"BusyJay"}}