{"action":"created","issue":{"url":"https://api.github.com/repos/dlang/dmd/issues/8795","repository_url":"https://api.github.com/repos/dlang/dmd","labels_url":"https://api.github.com/repos/dlang/dmd/issues/8795/labels{/name}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/8795/comments","events_url":"https://api.github.com/repos/dlang/dmd/issues/8795/events","html_url":"https://github.com/dlang/dmd/pull/8795","id":366867077,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDM3MTk3","number":8795,"title":"dmd/root/stringtable.h: Remove header and all references","user":{"login":"ibuclaw","id":397929,"node_id":"MDQ6VXNlcjM5NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-04T16:15:53Z","updated_at":"2018-10-04T16:15:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/8795","html_url":"https://github.com/dlang/dmd/pull/8795","diff_url":"https://github.com/dlang/dmd/pull/8795.diff","patch_url":"https://github.com/dlang/dmd/pull/8795.patch"},"body":"Remove extern(C++) linkage from all members on the D side.\r\n\r\nRecent refactoring of headers means that stringtable.h is no longer `#include`'d by any other file.\r\n\r\nPing @kinke - I hope you don't use this type anywhere in your codegen passes (I would be surprised if llvm didn't provide you with a hash set type)."},"comment":{"url":"https://api.github.com/repos/dlang/dmd/issues/comments/427079652","html_url":"https://github.com/dlang/dmd/pull/8795#issuecomment-427079652","issue_url":"https://api.github.com/repos/dlang/dmd/issues/8795","id":427079652,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzA3OTY1Mg==","user":{"login":"dlang-bot","id":15698993,"node_id":"MDQ6VXNlcjE1Njk4OTkz","avatar_url":"https://avatars3.githubusercontent.com/u/15698993?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang-bot","html_url":"https://github.com/dlang-bot","followers_url":"https://api.github.com/users/dlang-bot/followers","following_url":"https://api.github.com/users/dlang-bot/following{/other_user}","gists_url":"https://api.github.com/users/dlang-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang-bot/subscriptions","organizations_url":"https://api.github.com/users/dlang-bot/orgs","repos_url":"https://api.github.com/users/dlang-bot/repos","events_url":"https://api.github.com/users/dlang-bot/events{/privacy}","received_events_url":"https://api.github.com/users/dlang-bot/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T16:15:54Z","updated_at":"2018-10-04T16:15:54Z","author_association":"CONTRIBUTOR","body":"Thanks for your pull request, @ibuclaw!\n\n### Bugzilla references\n\nYour PR doesn't reference any Bugzilla issue.\n\nIf your PR contains non-trivial changes, please [reference a Bugzilla issue](https://github.com/dlang-bots/dlang-bot#automated-references) or create a [manual changelog](https://github.com/dlang/dmd/blob/master/changelog).\n\n### Testing this PR locally\n\nIf you don't have a [local development environment setup](https://wiki.dlang.org/Starting_as_a_Contributor), you can use [Digger](https://github.com/CyberShadow/Digger) to test this PR:\n\n```sh\ndub fetch digger\ndub run digger -- build \"master + dmd#8795\"\n```\n"}}
{"actor":{"display_login":"dlang-bot"}}