{"action":"created","comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/188624748","pull_request_review_id":120639430,"id":188624748,"diff_hunk":"@@ -62,6 +62,11 @@ error_code sys_vm_append_memory(u32 addr, u32 size)\n {\n \tsys_vm.warning(\"sys_vm_append_memory(addr=0x%x, size=0x%x)\", addr, size);\n \n+\tif (vm::get(vm::memory_location_t::any, addr)->size + size > 0x10000000)","path":"rpcs3/Emu/Cell/lv2/sys_vm.cpp","position":4,"original_position":4,"commit_id":"5ffe6bba3d71a60e2f472143da4ac50b93f33dd4","original_commit_id":"5ffe6bba3d71a60e2f472143da4ac50b93f33dd4","user":{"login":"elad335","id":18193363,"avatar_url":"https://avatars0.githubusercontent.com/u/18193363?v=4","gravatar_id":"","url":"https://api.github.com/users/elad335","html_url":"https://github.com/elad335","followers_url":"https://api.github.com/users/elad335/followers","following_url":"https://api.github.com/users/elad335/following{/other_user}","gists_url":"https://api.github.com/users/elad335/gists{/gist_id}","starred_url":"https://api.github.com/users/elad335/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elad335/subscriptions","organizations_url":"https://api.github.com/users/elad335/orgs","repos_url":"https://api.github.com/users/elad335/repos","events_url":"https://api.github.com/users/elad335/events{/privacy}","received_events_url":"https://api.github.com/users/elad335/received_events","type":"User","site_admin":false},"body":"vm::memory_location_t::any can also be written as vm::any","created_at":"2018-05-16T13:30:33Z","updated_at":"2018-05-16T13:30:34Z","html_url":"https://github.com/RPCS3/rpcs3/pull/4592#discussion_r188624748","pull_request_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4592","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/188624748"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/4592#discussion_r188624748"},"pull_request":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4592"}}},"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4592","id":188415407,"html_url":"https://github.com/RPCS3/rpcs3/pull/4592","diff_url":"https://github.com/RPCS3/rpcs3/pull/4592.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/4592.patch","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/4592","number":4592,"state":"open","locked":false,"title":"Add size check to sys_vm_append_memory","user":{"login":"isJuhn","id":26828095,"avatar_url":"https://avatars3.githubusercontent.com/u/26828095?v=4","gravatar_id":"","url":"https://api.github.com/users/isJuhn","html_url":"https://github.com/isJuhn","followers_url":"https://api.github.com/users/isJuhn/followers","following_url":"https://api.github.com/users/isJuhn/following{/other_user}","gists_url":"https://api.github.com/users/isJuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/isJuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isJuhn/subscriptions","organizations_url":"https://api.github.com/users/isJuhn/orgs","repos_url":"https://api.github.com/users/isJuhn/repos","events_url":"https://api.github.com/users/isJuhn/events{/privacy}","received_events_url":"https://api.github.com/users/isJuhn/received_events","type":"User","site_admin":false},"body":"Fixes Doom 3: BFG Edition [BLES01679], [BLUS31024] and [NPUB30889]\r\nNothing -> Ingame\r\n<img width=\"641\" alt=\"rpcs3_2018-05-16_02-15-24\" src=\"https://user-images.githubusercontent.com/26828095/40116775-032c3e30-5915-11e8-8d96-f0ea21976c19.png\">\r\nThanks to Deminating for the testing and the screenshot.","created_at":"2018-05-16T12:27:39Z","updated_at":"2018-05-16T13:30:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9e63376f92fd03495f269d6933c8994043fc76d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Nekotekina","id":6028184,"avatar_url":"https://avatars2.githubusercontent.com/u/6028184?v=4","gravatar_id":"","url":"https://api.github.com/users/Nekotekina","html_url":"https://github.com/Nekotekina","followers_url":"https://api.github.com/users/Nekotekina/followers","following_url":"https://api.github.com/users/Nekotekina/following{/other_user}","gists_url":"https://api.github.com/users/Nekotekina/gists{/gist_id}","starred_url":"https://api.github.com/users/Nekotekina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nekotekina/subscriptions","organizations_url":"https://api.github.com/users/Nekotekina/orgs","repos_url":"https://api.github.com/users/Nekotekina/repos","events_url":"https://api.github.com/users/Nekotekina/events{/privacy}","received_events_url":"https://api.github.com/users/Nekotekina/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":18270162,"url":"https://api.github.com/repos/RPCS3/rpcs3/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false},{"id":91080460,"url":"https://api.github.com/repos/RPCS3/rpcs3/labels/HLE","name":"HLE","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4592/commits","review_comments_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4592/comments","review_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/4592/comments","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/5ffe6bba3d71a60e2f472143da4ac50b93f33dd4","head":{"label":"isJuhn:doom","ref":"doom","sha":"5ffe6bba3d71a60e2f472143da4ac50b93f33dd4","user":{"login":"isJuhn","id":26828095,"avatar_url":"https://avatars3.githubusercontent.com/u/26828095?v=4","gravatar_id":"","url":"https://api.github.com/users/isJuhn","html_url":"https://github.com/isJuhn","followers_url":"https://api.github.com/users/isJuhn/followers","following_url":"https://api.github.com/users/isJuhn/following{/other_user}","gists_url":"https://api.github.com/users/isJuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/isJuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isJuhn/subscriptions","organizations_url":"https://api.github.com/users/isJuhn/orgs","repos_url":"https://api.github.com/users/isJuhn/repos","events_url":"https://api.github.com/users/isJuhn/events{/privacy}","received_events_url":"https://api.github.com/users/isJuhn/received_events","type":"User","site_admin":false},"repo":{"id":87601027,"name":"rpcs3","full_name":"isJuhn/rpcs3","owner":{"login":"isJuhn","id":26828095,"avatar_url":"https://avatars3.githubusercontent.com/u/26828095?v=4","gravatar_id":"","url":"https://api.github.com/users/isJuhn","html_url":"https://github.com/isJuhn","followers_url":"https://api.github.com/users/isJuhn/followers","following_url":"https://api.github.com/users/isJuhn/following{/other_user}","gists_url":"https://api.github.com/users/isJuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/isJuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isJuhn/subscriptions","organizations_url":"https://api.github.com/users/isJuhn/orgs","repos_url":"https://api.github.com/users/isJuhn/repos","events_url":"https://api.github.com/users/isJuhn/events{/privacy}","received_events_url":"https://api.github.com/users/isJuhn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isJuhn/rpcs3","description":"PS3 emulator/debugger","fork":true,"url":"https://api.github.com/repos/isJuhn/rpcs3","forks_url":"https://api.github.com/repos/isJuhn/rpcs3/forks","keys_url":"https://api.github.com/repos/isJuhn/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isJuhn/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isJuhn/rpcs3/teams","hooks_url":"https://api.github.com/repos/isJuhn/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/isJuhn/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/isJuhn/rpcs3/events","assignees_url":"https://api.github.com/repos/isJuhn/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/isJuhn/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/isJuhn/rpcs3/tags","blobs_url":"https://api.github.com/repos/isJuhn/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isJuhn/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isJuhn/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/isJuhn/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isJuhn/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/isJuhn/rpcs3/languages","stargazers_url":"https://api.github.com/repos/isJuhn/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/isJuhn/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/isJuhn/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/isJuhn/rpcs3/subscription","commits_url":"https://api.github.com/repos/isJuhn/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/isJuhn/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/isJuhn/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/isJuhn/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/isJuhn/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/isJuhn/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isJuhn/rpcs3/merges","archive_url":"https://api.github.com/repos/isJuhn/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isJuhn/rpcs3/downloads","issues_url":"https://api.github.com/repos/isJuhn/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/isJuhn/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/isJuhn/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/isJuhn/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isJuhn/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/isJuhn/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/isJuhn/rpcs3/deployments","created_at":"2017-04-08T02:08:38Z","updated_at":"2018-05-16T11:50:28Z","pushed_at":"2018-05-16T12:22:40Z","git_url":"git://github.com/isJuhn/rpcs3.git","ssh_url":"git@github.com:isJuhn/rpcs3.git","clone_url":"https://github.com/isJuhn/rpcs3.git","svn_url":"https://github.com/isJuhn/rpcs3","homepage":"https://rpcs3.net/","size":49587,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"RPCS3:master","ref":"master","sha":"fd8aae5725e55163ab0685f767eefaaa4a0b2c0a","user":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars3.githubusercontent.com/u/8070735?v=4","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"repo":{"id":6520784,"name":"rpcs3","full_name":"RPCS3/rpcs3","owner":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars3.githubusercontent.com/u/8070735?v=4","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RPCS3/rpcs3","description":"PS3 emulator/debugger","fork":false,"url":"https://api.github.com/repos/RPCS3/rpcs3","forks_url":"https://api.github.com/repos/RPCS3/rpcs3/forks","keys_url":"https://api.github.com/repos/RPCS3/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RPCS3/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RPCS3/rpcs3/teams","hooks_url":"https://api.github.com/repos/RPCS3/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/RPCS3/rpcs3/events","assignees_url":"https://api.github.com/repos/RPCS3/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/RPCS3/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/RPCS3/rpcs3/tags","blobs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RPCS3/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/RPCS3/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/RPCS3/rpcs3/languages","stargazers_url":"https://api.github.com/repos/RPCS3/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/RPCS3/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/RPCS3/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/RPCS3/rpcs3/subscription","commits_url":"https://api.github.com/repos/RPCS3/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/RPCS3/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/RPCS3/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/RPCS3/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RPCS3/rpcs3/merges","archive_url":"https://api.github.com/repos/RPCS3/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RPCS3/rpcs3/downloads","issues_url":"https://api.github.com/repos/RPCS3/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/RPCS3/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/RPCS3/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/RPCS3/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/RPCS3/rpcs3/deployments","created_at":"2012-11-03T15:16:18Z","updated_at":"2018-05-16T10:47:32Z","pushed_at":"2018-05-16T12:56:54Z","git_url":"git://github.com/RPCS3/rpcs3.git","ssh_url":"git@github.com:RPCS3/rpcs3.git","clone_url":"https://github.com/RPCS3/rpcs3.git","svn_url":"https://github.com/RPCS3/rpcs3","homepage":"https://rpcs3.net/","size":49461,"stargazers_count":4939,"watchers_count":4939,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":914,"mirror_url":null,"archived":false,"open_issues_count":359,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":914,"open_issues":359,"watchers":4939,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4592"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/4592"},"issue":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/4592"},"comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/4592/comments"},"review_comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4592/comments"},"review_comment":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4592/commits"},"statuses":{"href":"https://api.github.com/repos/RPCS3/rpcs3/statuses/5ffe6bba3d71a60e2f472143da4ac50b93f33dd4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"elad335"}}