{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/230951418","pull_request_review_id":171807211,"id":230951418,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDk1MTQxOA==","diff_hunk":"@@ -1,9 +1,4 @@\n <Project>\n-  <ItemGroup>\n-    <!-- List of container files that will be opened and checked for files that need to be signed. -->\n-    <ItemsToSign Include=\"$(RepoRoot)bin\\packages\\$(Configuration)\\**\\*.nupkg\" />\n-  </ItemGroup>\n-\n   <Target Name=\"ValidateSignFileListIsNotEmpty\" BeforeTargets=\"Sign\">","path":"eng/Signing.props","position":7,"original_position":7,"commit_id":"994f06c659f5111e06836648f6ad0c31ce787e3d","original_commit_id":"994f06c659f5111e06836648f6ad0c31ce787e3d","user":{"login":"safern","id":22899328,"node_id":"MDQ6VXNlcjIyODk5MzI4","avatar_url":"https://avatars1.githubusercontent.com/u/22899328?v=4","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"body":"Should this target be moved to arcade directly?","created_at":"2018-11-05T23:22:13Z","updated_at":"2018-11-05T23:22:13Z","html_url":"https://github.com/dotnet/corefx/pull/33256#discussion_r230951418","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/33256","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/230951418"},"html":{"href":"https://github.com/dotnet/corefx/pull/33256#discussion_r230951418"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33256"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/33256","id":228515446,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTE1NDQ2","html_url":"https://github.com/dotnet/corefx/pull/33256","diff_url":"https://github.com/dotnet/corefx/pull/33256.diff","patch_url":"https://github.com/dotnet/corefx/pull/33256.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/33256","number":33256,"state":"open","locked":false,"title":"Fix package output and signing to find the packages","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"@safern @ericstj package output wasn't correct so my official build test failed to find packages and sign them, this should fix that.","created_at":"2018-11-05T22:38:34Z","updated_at":"2018-11-05T23:22:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b83d202becce8621a544d834f496f537bd81435","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/33256/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/33256/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/33256/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/994f06c659f5111e06836648f6ad0c31ce787e3d","head":{"label":"weshaggard:FixSigningAndPackageOutput","ref":"FixSigningAndPackageOutput","sha":"994f06c659f5111e06836648f6ad0c31ce787e3d","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"repo":{"id":26735900,"node_id":"MDEwOlJlcG9zaXRvcnkyNjczNTkwMA==","name":"corefx","full_name":"weshaggard/corefx","private":false,"owner":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/weshaggard/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/weshaggard/corefx","forks_url":"https://api.github.com/repos/weshaggard/corefx/forks","keys_url":"https://api.github.com/repos/weshaggard/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weshaggard/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weshaggard/corefx/teams","hooks_url":"https://api.github.com/repos/weshaggard/corefx/hooks","issue_events_url":"https://api.github.com/repos/weshaggard/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/weshaggard/corefx/events","assignees_url":"https://api.github.com/repos/weshaggard/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/weshaggard/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/weshaggard/corefx/tags","blobs_url":"https://api.github.com/repos/weshaggard/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weshaggard/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weshaggard/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/weshaggard/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weshaggard/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/weshaggard/corefx/languages","stargazers_url":"https://api.github.com/repos/weshaggard/corefx/stargazers","contributors_url":"https://api.github.com/repos/weshaggard/corefx/contributors","subscribers_url":"https://api.github.com/repos/weshaggard/corefx/subscribers","subscription_url":"https://api.github.com/repos/weshaggard/corefx/subscription","commits_url":"https://api.github.com/repos/weshaggard/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/weshaggard/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/weshaggard/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/weshaggard/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/weshaggard/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/weshaggard/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weshaggard/corefx/merges","archive_url":"https://api.github.com/repos/weshaggard/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weshaggard/corefx/downloads","issues_url":"https://api.github.com/repos/weshaggard/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/weshaggard/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/weshaggard/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/weshaggard/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weshaggard/corefx/labels{/name}","releases_url":"https://api.github.com/repos/weshaggard/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/weshaggard/corefx/deployments","created_at":"2014-11-17T02:05:52Z","updated_at":"2018-11-05T21:11:34Z","pushed_at":"2018-11-05T22:37:47Z","git_url":"git://github.com/weshaggard/corefx.git","ssh_url":"git@github.com:weshaggard/corefx.git","clone_url":"https://github.com/weshaggard/corefx.git","svn_url":"https://github.com/weshaggard/corefx","homepage":"","size":190178,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b22ece11d4e7d57791633f6226ae9fbebcc9e387","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-11-05T22:36:51Z","pushed_at":"2018-11-05T23:22:10Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":190782,"stargazers_count":15086,"watchers_count":15086,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4467,"mirror_url":null,"archived":false,"open_issues_count":2581,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4467,"open_issues":2581,"watchers":15086,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33256"},"html":{"href":"https://github.com/dotnet/corefx/pull/33256"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33256"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33256/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33256/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33256/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/994f06c659f5111e06836648f6ad0c31ce787e3d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"safern"}}