{"action":"created","comment":{"url":"https://api.github.com/repos/MDAnalysis/pmda/pulls/comments/215865715","pull_request_review_id":153225696,"id":215865715,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTg2NTcxNQ==","diff_hunk":"@@ -315,16 +315,24 @@ def _dask_helper(self, start, stop, step, indices, top, traj):\n             u = mda.Universe(top, traj)\n             agroups = [u.atoms[idx] for idx in indices]\n \n-        res = []\n+        t_ser = []\n+        accum = []\n         times_io = []\n         times_compute = []\n         for i in range(start, stop, step):\n             with timeit() as b_io:\n                 ts = u.trajectory[i]\n             with timeit() as b_compute:\n-                res.append(self._single_frame(ts, agroups))\n+                res_sf = self._single_frame(ts, agroups)\n+                if 'accumulator' in res_sf:\n+                    if accum == []:\n+                        accum = res_sf['accumulator']\n+                    else:\n+                        accum += res_sf['accumulator']","path":"pmda/parallel.py","position":38,"original_position":38,"commit_id":"7fbf882dc374f9de0c9dfd9e7f5d2d6c253fea86","original_commit_id":"7fbf882dc374f9de0c9dfd9e7f5d2d6c253fea86","user":{"login":"VOD555","id":27674287,"node_id":"MDQ6VXNlcjI3Njc0Mjg3","avatar_url":"https://avatars0.githubusercontent.com/u/27674287?v=4","gravatar_id":"","url":"https://api.github.com/users/VOD555","html_url":"https://github.com/VOD555","followers_url":"https://api.github.com/users/VOD555/followers","following_url":"https://api.github.com/users/VOD555/following{/other_user}","gists_url":"https://api.github.com/users/VOD555/gists{/gist_id}","starred_url":"https://api.github.com/users/VOD555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VOD555/subscriptions","organizations_url":"https://api.github.com/users/VOD555/orgs","repos_url":"https://api.github.com/users/VOD555/repos","events_url":"https://api.github.com/users/VOD555/events{/privacy}","received_events_url":"https://api.github.com/users/VOD555/received_events","type":"User","site_admin":false},"body":"Yes, that's correct.","created_at":"2018-09-07T07:12:29Z","updated_at":"2018-09-07T07:12:29Z","html_url":"https://github.com/MDAnalysis/pmda/pull/55#discussion_r215865715","pull_request_url":"https://api.github.com/repos/MDAnalysis/pmda/pulls/55","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/MDAnalysis/pmda/pulls/comments/215865715"},"html":{"href":"https://github.com/MDAnalysis/pmda/pull/55#discussion_r215865715"},"pull_request":{"href":"https://api.github.com/repos/MDAnalysis/pmda/pulls/55"}},"in_reply_to_id":215622792},"pull_request":{"url":"https://api.github.com/repos/MDAnalysis/pmda/pulls/55","id":213488983,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDg4OTgz","html_url":"https://github.com/MDAnalysis/pmda/pull/55","diff_url":"https://github.com/MDAnalysis/pmda/pull/55.diff","patch_url":"https://github.com/MDAnalysis/pmda/pull/55.patch","issue_url":"https://api.github.com/repos/MDAnalysis/pmda/issues/55","number":55,"state":"open","locked":false,"title":"replace res with two kinds of output, accumulator and timeseries","user":{"login":"VOD555","id":27674287,"node_id":"MDQ6VXNlcjI3Njc0Mjg3","avatar_url":"https://avatars0.githubusercontent.com/u/27674287?v=4","gravatar_id":"","url":"https://api.github.com/users/VOD555","html_url":"https://github.com/VOD555","followers_url":"https://api.github.com/users/VOD555/followers","following_url":"https://api.github.com/users/VOD555/following{/other_user}","gists_url":"https://api.github.com/users/VOD555/gists{/gist_id}","starred_url":"https://api.github.com/users/VOD555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VOD555/subscriptions","organizations_url":"https://api.github.com/users/VOD555/orgs","repos_url":"https://api.github.com/users/VOD555/repos","events_url":"https://api.github.com/users/VOD555/events{/privacy}","received_events_url":"https://api.github.com/users/VOD555/received_events","type":"User","site_admin":false},"body":"Changes made in this Pull Request:\r\n - Replace res with two kinds of output: accumulator and timeseries.\r\ntimeseries is the same as the old res, which just appends the result from each step. \r\nThe other one, accumulator, accumulates the results so that we can reduce the size of the results of each parallelled task for function such as rdf.\r\n\r\nThe example for timeseries is contact.py, and the one for accumulator is rdf. \r\n\r\n\r\nPR Checklist\r\n------------\r\n - [ ] Tests?\r\n - [ ] Docs?\r\n - [ ] CHANGELOG updated?\r\n - [ ] Issue raised/referenced?\r\n","created_at":"2018-09-06T03:59:22Z","updated_at":"2018-09-07T07:12:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36fe3e95f35aa96ed404d9072fa21748f4f486d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MDAnalysis/pmda/pulls/55/commits","review_comments_url":"https://api.github.com/repos/MDAnalysis/pmda/pulls/55/comments","review_comment_url":"https://api.github.com/repos/MDAnalysis/pmda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MDAnalysis/pmda/issues/55/comments","statuses_url":"https://api.github.com/repos/MDAnalysis/pmda/statuses/7fbf882dc374f9de0c9dfd9e7f5d2d6c253fea86","head":{"label":"VOD555:enh_prdf","ref":"enh_prdf","sha":"7fbf882dc374f9de0c9dfd9e7f5d2d6c253fea86","user":{"login":"VOD555","id":27674287,"node_id":"MDQ6VXNlcjI3Njc0Mjg3","avatar_url":"https://avatars0.githubusercontent.com/u/27674287?v=4","gravatar_id":"","url":"https://api.github.com/users/VOD555","html_url":"https://github.com/VOD555","followers_url":"https://api.github.com/users/VOD555/followers","following_url":"https://api.github.com/users/VOD555/following{/other_user}","gists_url":"https://api.github.com/users/VOD555/gists{/gist_id}","starred_url":"https://api.github.com/users/VOD555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VOD555/subscriptions","organizations_url":"https://api.github.com/users/VOD555/orgs","repos_url":"https://api.github.com/users/VOD555/repos","events_url":"https://api.github.com/users/VOD555/events{/privacy}","received_events_url":"https://api.github.com/users/VOD555/received_events","type":"User","site_admin":false},"repo":{"id":135336299,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzMzYyOTk=","name":"pmda","full_name":"VOD555/pmda","owner":{"login":"VOD555","id":27674287,"node_id":"MDQ6VXNlcjI3Njc0Mjg3","avatar_url":"https://avatars0.githubusercontent.com/u/27674287?v=4","gravatar_id":"","url":"https://api.github.com/users/VOD555","html_url":"https://github.com/VOD555","followers_url":"https://api.github.com/users/VOD555/followers","following_url":"https://api.github.com/users/VOD555/following{/other_user}","gists_url":"https://api.github.com/users/VOD555/gists{/gist_id}","starred_url":"https://api.github.com/users/VOD555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VOD555/subscriptions","organizations_url":"https://api.github.com/users/VOD555/orgs","repos_url":"https://api.github.com/users/VOD555/repos","events_url":"https://api.github.com/users/VOD555/events{/privacy}","received_events_url":"https://api.github.com/users/VOD555/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VOD555/pmda","description":"Parallel algorithms for MDAnalysis","fork":true,"url":"https://api.github.com/repos/VOD555/pmda","forks_url":"https://api.github.com/repos/VOD555/pmda/forks","keys_url":"https://api.github.com/repos/VOD555/pmda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VOD555/pmda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VOD555/pmda/teams","hooks_url":"https://api.github.com/repos/VOD555/pmda/hooks","issue_events_url":"https://api.github.com/repos/VOD555/pmda/issues/events{/number}","events_url":"https://api.github.com/repos/VOD555/pmda/events","assignees_url":"https://api.github.com/repos/VOD555/pmda/assignees{/user}","branches_url":"https://api.github.com/repos/VOD555/pmda/branches{/branch}","tags_url":"https://api.github.com/repos/VOD555/pmda/tags","blobs_url":"https://api.github.com/repos/VOD555/pmda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VOD555/pmda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VOD555/pmda/git/refs{/sha}","trees_url":"https://api.github.com/repos/VOD555/pmda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VOD555/pmda/statuses/{sha}","languages_url":"https://api.github.com/repos/VOD555/pmda/languages","stargazers_url":"https://api.github.com/repos/VOD555/pmda/stargazers","contributors_url":"https://api.github.com/repos/VOD555/pmda/contributors","subscribers_url":"https://api.github.com/repos/VOD555/pmda/subscribers","subscription_url":"https://api.github.com/repos/VOD555/pmda/subscription","commits_url":"https://api.github.com/repos/VOD555/pmda/commits{/sha}","git_commits_url":"https://api.github.com/repos/VOD555/pmda/git/commits{/sha}","comments_url":"https://api.github.com/repos/VOD555/pmda/comments{/number}","issue_comment_url":"https://api.github.com/repos/VOD555/pmda/issues/comments{/number}","contents_url":"https://api.github.com/repos/VOD555/pmda/contents/{+path}","compare_url":"https://api.github.com/repos/VOD555/pmda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VOD555/pmda/merges","archive_url":"https://api.github.com/repos/VOD555/pmda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VOD555/pmda/downloads","issues_url":"https://api.github.com/repos/VOD555/pmda/issues{/number}","pulls_url":"https://api.github.com/repos/VOD555/pmda/pulls{/number}","milestones_url":"https://api.github.com/repos/VOD555/pmda/milestones{/number}","notifications_url":"https://api.github.com/repos/VOD555/pmda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VOD555/pmda/labels{/name}","releases_url":"https://api.github.com/repos/VOD555/pmda/releases{/id}","deployments_url":"https://api.github.com/repos/VOD555/pmda/deployments","created_at":"2018-05-29T18:20:32Z","updated_at":"2018-08-27T21:28:43Z","pushed_at":"2018-09-06T03:41:20Z","git_url":"git://github.com/VOD555/pmda.git","ssh_url":"git@github.com:VOD555/pmda.git","clone_url":"https://github.com/VOD555/pmda.git","svn_url":"https://github.com/VOD555/pmda","homepage":"https://www.mdanalysis.org/pmda/","size":585,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MDAnalysis:master","ref":"master","sha":"a5aa57607bc413496322d97bbc22e8eb64884cba","user":{"login":"MDAnalysis","id":11445951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDQ1OTUx","avatar_url":"https://avatars1.githubusercontent.com/u/11445951?v=4","gravatar_id":"","url":"https://api.github.com/users/MDAnalysis","html_url":"https://github.com/MDAnalysis","followers_url":"https://api.github.com/users/MDAnalysis/followers","following_url":"https://api.github.com/users/MDAnalysis/following{/other_user}","gists_url":"https://api.github.com/users/MDAnalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/MDAnalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDAnalysis/subscriptions","organizations_url":"https://api.github.com/users/MDAnalysis/orgs","repos_url":"https://api.github.com/users/MDAnalysis/repos","events_url":"https://api.github.com/users/MDAnalysis/events{/privacy}","received_events_url":"https://api.github.com/users/MDAnalysis/received_events","type":"Organization","site_admin":false},"repo":{"id":106346721,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzNDY3MjE=","name":"pmda","full_name":"MDAnalysis/pmda","owner":{"login":"MDAnalysis","id":11445951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDQ1OTUx","avatar_url":"https://avatars1.githubusercontent.com/u/11445951?v=4","gravatar_id":"","url":"https://api.github.com/users/MDAnalysis","html_url":"https://github.com/MDAnalysis","followers_url":"https://api.github.com/users/MDAnalysis/followers","following_url":"https://api.github.com/users/MDAnalysis/following{/other_user}","gists_url":"https://api.github.com/users/MDAnalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/MDAnalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDAnalysis/subscriptions","organizations_url":"https://api.github.com/users/MDAnalysis/orgs","repos_url":"https://api.github.com/users/MDAnalysis/repos","events_url":"https://api.github.com/users/MDAnalysis/events{/privacy}","received_events_url":"https://api.github.com/users/MDAnalysis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MDAnalysis/pmda","description":"Parallel algorithms for MDAnalysis","fork":false,"url":"https://api.github.com/repos/MDAnalysis/pmda","forks_url":"https://api.github.com/repos/MDAnalysis/pmda/forks","keys_url":"https://api.github.com/repos/MDAnalysis/pmda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MDAnalysis/pmda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MDAnalysis/pmda/teams","hooks_url":"https://api.github.com/repos/MDAnalysis/pmda/hooks","issue_events_url":"https://api.github.com/repos/MDAnalysis/pmda/issues/events{/number}","events_url":"https://api.github.com/repos/MDAnalysis/pmda/events","assignees_url":"https://api.github.com/repos/MDAnalysis/pmda/assignees{/user}","branches_url":"https://api.github.com/repos/MDAnalysis/pmda/branches{/branch}","tags_url":"https://api.github.com/repos/MDAnalysis/pmda/tags","blobs_url":"https://api.github.com/repos/MDAnalysis/pmda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MDAnalysis/pmda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MDAnalysis/pmda/git/refs{/sha}","trees_url":"https://api.github.com/repos/MDAnalysis/pmda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MDAnalysis/pmda/statuses/{sha}","languages_url":"https://api.github.com/repos/MDAnalysis/pmda/languages","stargazers_url":"https://api.github.com/repos/MDAnalysis/pmda/stargazers","contributors_url":"https://api.github.com/repos/MDAnalysis/pmda/contributors","subscribers_url":"https://api.github.com/repos/MDAnalysis/pmda/subscribers","subscription_url":"https://api.github.com/repos/MDAnalysis/pmda/subscription","commits_url":"https://api.github.com/repos/MDAnalysis/pmda/commits{/sha}","git_commits_url":"https://api.github.com/repos/MDAnalysis/pmda/git/commits{/sha}","comments_url":"https://api.github.com/repos/MDAnalysis/pmda/comments{/number}","issue_comment_url":"https://api.github.com/repos/MDAnalysis/pmda/issues/comments{/number}","contents_url":"https://api.github.com/repos/MDAnalysis/pmda/contents/{+path}","compare_url":"https://api.github.com/repos/MDAnalysis/pmda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MDAnalysis/pmda/merges","archive_url":"https://api.github.com/repos/MDAnalysis/pmda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MDAnalysis/pmda/downloads","issues_url":"https://api.github.com/repos/MDAnalysis/pmda/issues{/number}","pulls_url":"https://api.github.com/repos/MDAnalysis/pmda/pulls{/number}","milestones_url":"https://api.github.com/repos/MDAnalysis/pmda/milestones{/number}","notifications_url":"https://api.github.com/repos/MDAnalysis/pmda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MDAnalysis/pmda/labels{/name}","releases_url":"https://api.github.com/repos/MDAnalysis/pmda/releases{/id}","deployments_url":"https://api.github.com/repos/MDAnalysis/pmda/deployments","created_at":"2017-10-09T23:46:26Z","updated_at":"2018-07-19T18:47:41Z","pushed_at":"2018-09-06T03:59:22Z","git_url":"git://github.com/MDAnalysis/pmda.git","ssh_url":"git@github.com:MDAnalysis/pmda.git","clone_url":"https://github.com/MDAnalysis/pmda.git","svn_url":"https://github.com/MDAnalysis/pmda","homepage":"https://www.mdanalysis.org/pmda/","size":607,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":6,"open_issues":11,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MDAnalysis/pmda/pulls/55"},"html":{"href":"https://github.com/MDAnalysis/pmda/pull/55"},"issue":{"href":"https://api.github.com/repos/MDAnalysis/pmda/issues/55"},"comments":{"href":"https://api.github.com/repos/MDAnalysis/pmda/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/MDAnalysis/pmda/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/MDAnalysis/pmda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MDAnalysis/pmda/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/MDAnalysis/pmda/statuses/7fbf882dc374f9de0c9dfd9e7f5d2d6c253fea86"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"VOD555"}}