{"action":"created","comment":{"url":"https://api.github.com/repos/crdschurch/crds-net/pulls/comments/237256389","pull_request_review_id":179509654,"id":237256389,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzI1NjM4OQ==","diff_hunk":"@@ -37,11 +37,15 @@ export class SeriesModel {\n     }\n \n     get startDate(){\n-        return this.starts_at.split(\"T\")[0]; //Remove time zone\n+        if(this.starts_at !== undefined)","path":"cypress/support/Contentful/Models/SeriesModel.js","position":5,"original_position":5,"commit_id":"f99a43aa807fd9a58a6cbe15c9482a4905a1a093","original_commit_id":"f99a43aa807fd9a58a6cbe15c9482a4905a1a093","user":{"login":"lukemoderwell","id":2180358,"node_id":"MDQ6VXNlcjIxODAzNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2180358?v=4","gravatar_id":"","url":"https://api.github.com/users/lukemoderwell","html_url":"https://github.com/lukemoderwell","followers_url":"https://api.github.com/users/lukemoderwell/followers","following_url":"https://api.github.com/users/lukemoderwell/following{/other_user}","gists_url":"https://api.github.com/users/lukemoderwell/gists{/gist_id}","starred_url":"https://api.github.com/users/lukemoderwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukemoderwell/subscriptions","organizations_url":"https://api.github.com/users/lukemoderwell/orgs","repos_url":"https://api.github.com/users/lukemoderwell/repos","events_url":"https://api.github.com/users/lukemoderwell/events{/privacy}","received_events_url":"https://api.github.com/users/lukemoderwell/received_events","type":"User","site_admin":false},"body":"could you use a ternary here?\r\n```suggestion\r\nreturn this.starts_at !== undefined ? this.starts_at.split(\"T\")[0] : this.starts_at\r\n```","created_at":"2018-11-28T20:54:32Z","updated_at":"2018-11-28T20:54:44Z","html_url":"https://github.com/crdschurch/crds-net/pull/287#discussion_r237256389","pull_request_url":"https://api.github.com/repos/crdschurch/crds-net/pulls/287","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/crdschurch/crds-net/pulls/comments/237256389"},"html":{"href":"https://github.com/crdschurch/crds-net/pull/287#discussion_r237256389"},"pull_request":{"href":"https://api.github.com/repos/crdschurch/crds-net/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/crdschurch/crds-net/pulls/287","id":234308948,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzA4OTQ4","html_url":"https://github.com/crdschurch/crds-net/pull/287","diff_url":"https://github.com/crdschurch/crds-net/pull/287.diff","patch_url":"https://github.com/crdschurch/crds-net/pull/287.patch","issue_url":"https://api.github.com/repos/crdschurch/crds-net/issues/287","number":287,"state":"open","locked":false,"title":"shenney/DE_CYP - Split undefined fix","user":{"login":"s-henney","id":25440620,"node_id":"MDQ6VXNlcjI1NDQwNjIw","avatar_url":"https://avatars2.githubusercontent.com/u/25440620?v=4","gravatar_id":"","url":"https://api.github.com/users/s-henney","html_url":"https://github.com/s-henney","followers_url":"https://api.github.com/users/s-henney/followers","following_url":"https://api.github.com/users/s-henney/following{/other_user}","gists_url":"https://api.github.com/users/s-henney/gists{/gist_id}","starred_url":"https://api.github.com/users/s-henney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-henney/subscriptions","organizations_url":"https://api.github.com/users/s-henney/orgs","repos_url":"https://api.github.com/users/s-henney/repos","events_url":"https://api.github.com/users/s-henney/events{/privacy}","received_events_url":"https://api.github.com/users/s-henney/received_events","type":"User","site_admin":false},"body":"- Fixed a bug to avoid calling .split on a potentially undefined value","created_at":"2018-11-28T15:02:19Z","updated_at":"2018-11-28T20:54:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cf299fd73edaaa4f4a2efd128f4f279bcf666f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crdschurch/crds-net/pulls/287/commits","review_comments_url":"https://api.github.com/repos/crdschurch/crds-net/pulls/287/comments","review_comment_url":"https://api.github.com/repos/crdschurch/crds-net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crdschurch/crds-net/issues/287/comments","statuses_url":"https://api.github.com/repos/crdschurch/crds-net/statuses/f99a43aa807fd9a58a6cbe15c9482a4905a1a093","head":{"label":"crdschurch:shenney/CYP_DE_splitIssue","ref":"shenney/CYP_DE_splitIssue","sha":"f99a43aa807fd9a58a6cbe15c9482a4905a1a093","user":{"login":"crdschurch","id":1843144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDMxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1843144?v=4","gravatar_id":"","url":"https://api.github.com/users/crdschurch","html_url":"https://github.com/crdschurch","followers_url":"https://api.github.com/users/crdschurch/followers","following_url":"https://api.github.com/users/crdschurch/following{/other_user}","gists_url":"https://api.github.com/users/crdschurch/gists{/gist_id}","starred_url":"https://api.github.com/users/crdschurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crdschurch/subscriptions","organizations_url":"https://api.github.com/users/crdschurch/orgs","repos_url":"https://api.github.com/users/crdschurch/repos","events_url":"https://api.github.com/users/crdschurch/events{/privacy}","received_events_url":"https://api.github.com/users/crdschurch/received_events","type":"Organization","site_admin":false},"repo":{"id":137115076,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMTUwNzY=","name":"crds-net","full_name":"crdschurch/crds-net","private":false,"owner":{"login":"crdschurch","id":1843144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDMxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1843144?v=4","gravatar_id":"","url":"https://api.github.com/users/crdschurch","html_url":"https://github.com/crdschurch","followers_url":"https://api.github.com/users/crdschurch/followers","following_url":"https://api.github.com/users/crdschurch/following{/other_user}","gists_url":"https://api.github.com/users/crdschurch/gists{/gist_id}","starred_url":"https://api.github.com/users/crdschurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crdschurch/subscriptions","organizations_url":"https://api.github.com/users/crdschurch/orgs","repos_url":"https://api.github.com/users/crdschurch/repos","events_url":"https://api.github.com/users/crdschurch/events{/privacy}","received_events_url":"https://api.github.com/users/crdschurch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crdschurch/crds-net","description":"Crossroads Website (SSG)","fork":false,"url":"https://api.github.com/repos/crdschurch/crds-net","forks_url":"https://api.github.com/repos/crdschurch/crds-net/forks","keys_url":"https://api.github.com/repos/crdschurch/crds-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crdschurch/crds-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crdschurch/crds-net/teams","hooks_url":"https://api.github.com/repos/crdschurch/crds-net/hooks","issue_events_url":"https://api.github.com/repos/crdschurch/crds-net/issues/events{/number}","events_url":"https://api.github.com/repos/crdschurch/crds-net/events","assignees_url":"https://api.github.com/repos/crdschurch/crds-net/assignees{/user}","branches_url":"https://api.github.com/repos/crdschurch/crds-net/branches{/branch}","tags_url":"https://api.github.com/repos/crdschurch/crds-net/tags","blobs_url":"https://api.github.com/repos/crdschurch/crds-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crdschurch/crds-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crdschurch/crds-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/crdschurch/crds-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crdschurch/crds-net/statuses/{sha}","languages_url":"https://api.github.com/repos/crdschurch/crds-net/languages","stargazers_url":"https://api.github.com/repos/crdschurch/crds-net/stargazers","contributors_url":"https://api.github.com/repos/crdschurch/crds-net/contributors","subscribers_url":"https://api.github.com/repos/crdschurch/crds-net/subscribers","subscription_url":"https://api.github.com/repos/crdschurch/crds-net/subscription","commits_url":"https://api.github.com/repos/crdschurch/crds-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/crdschurch/crds-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/crdschurch/crds-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/crdschurch/crds-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/crdschurch/crds-net/contents/{+path}","compare_url":"https://api.github.com/repos/crdschurch/crds-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crdschurch/crds-net/merges","archive_url":"https://api.github.com/repos/crdschurch/crds-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crdschurch/crds-net/downloads","issues_url":"https://api.github.com/repos/crdschurch/crds-net/issues{/number}","pulls_url":"https://api.github.com/repos/crdschurch/crds-net/pulls{/number}","milestones_url":"https://api.github.com/repos/crdschurch/crds-net/milestones{/number}","notifications_url":"https://api.github.com/repos/crdschurch/crds-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crdschurch/crds-net/labels{/name}","releases_url":"https://api.github.com/repos/crdschurch/crds-net/releases{/id}","deployments_url":"https://api.github.com/repos/crdschurch/crds-net/deployments","created_at":"2018-06-12T18:56:48Z","updated_at":"2018-11-28T19:33:10Z","pushed_at":"2018-11-28T19:52:16Z","git_url":"git://github.com/crdschurch/crds-net.git","ssh_url":"git@github.com:crdschurch/crds-net.git","clone_url":"https://github.com/crdschurch/crds-net.git","svn_url":"https://github.com/crdschurch/crds-net","homepage":"https://crossroads.net","size":3326,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":2,"default_branch":"development"}},"base":{"label":"crdschurch:development","ref":"development","sha":"a0366091378dc5b5b5f384759a17c6436c123179","user":{"login":"crdschurch","id":1843144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDMxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1843144?v=4","gravatar_id":"","url":"https://api.github.com/users/crdschurch","html_url":"https://github.com/crdschurch","followers_url":"https://api.github.com/users/crdschurch/followers","following_url":"https://api.github.com/users/crdschurch/following{/other_user}","gists_url":"https://api.github.com/users/crdschurch/gists{/gist_id}","starred_url":"https://api.github.com/users/crdschurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crdschurch/subscriptions","organizations_url":"https://api.github.com/users/crdschurch/orgs","repos_url":"https://api.github.com/users/crdschurch/repos","events_url":"https://api.github.com/users/crdschurch/events{/privacy}","received_events_url":"https://api.github.com/users/crdschurch/received_events","type":"Organization","site_admin":false},"repo":{"id":137115076,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMTUwNzY=","name":"crds-net","full_name":"crdschurch/crds-net","private":false,"owner":{"login":"crdschurch","id":1843144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDMxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1843144?v=4","gravatar_id":"","url":"https://api.github.com/users/crdschurch","html_url":"https://github.com/crdschurch","followers_url":"https://api.github.com/users/crdschurch/followers","following_url":"https://api.github.com/users/crdschurch/following{/other_user}","gists_url":"https://api.github.com/users/crdschurch/gists{/gist_id}","starred_url":"https://api.github.com/users/crdschurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crdschurch/subscriptions","organizations_url":"https://api.github.com/users/crdschurch/orgs","repos_url":"https://api.github.com/users/crdschurch/repos","events_url":"https://api.github.com/users/crdschurch/events{/privacy}","received_events_url":"https://api.github.com/users/crdschurch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crdschurch/crds-net","description":"Crossroads Website (SSG)","fork":false,"url":"https://api.github.com/repos/crdschurch/crds-net","forks_url":"https://api.github.com/repos/crdschurch/crds-net/forks","keys_url":"https://api.github.com/repos/crdschurch/crds-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crdschurch/crds-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crdschurch/crds-net/teams","hooks_url":"https://api.github.com/repos/crdschurch/crds-net/hooks","issue_events_url":"https://api.github.com/repos/crdschurch/crds-net/issues/events{/number}","events_url":"https://api.github.com/repos/crdschurch/crds-net/events","assignees_url":"https://api.github.com/repos/crdschurch/crds-net/assignees{/user}","branches_url":"https://api.github.com/repos/crdschurch/crds-net/branches{/branch}","tags_url":"https://api.github.com/repos/crdschurch/crds-net/tags","blobs_url":"https://api.github.com/repos/crdschurch/crds-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crdschurch/crds-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crdschurch/crds-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/crdschurch/crds-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crdschurch/crds-net/statuses/{sha}","languages_url":"https://api.github.com/repos/crdschurch/crds-net/languages","stargazers_url":"https://api.github.com/repos/crdschurch/crds-net/stargazers","contributors_url":"https://api.github.com/repos/crdschurch/crds-net/contributors","subscribers_url":"https://api.github.com/repos/crdschurch/crds-net/subscribers","subscription_url":"https://api.github.com/repos/crdschurch/crds-net/subscription","commits_url":"https://api.github.com/repos/crdschurch/crds-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/crdschurch/crds-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/crdschurch/crds-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/crdschurch/crds-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/crdschurch/crds-net/contents/{+path}","compare_url":"https://api.github.com/repos/crdschurch/crds-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crdschurch/crds-net/merges","archive_url":"https://api.github.com/repos/crdschurch/crds-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crdschurch/crds-net/downloads","issues_url":"https://api.github.com/repos/crdschurch/crds-net/issues{/number}","pulls_url":"https://api.github.com/repos/crdschurch/crds-net/pulls{/number}","milestones_url":"https://api.github.com/repos/crdschurch/crds-net/milestones{/number}","notifications_url":"https://api.github.com/repos/crdschurch/crds-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crdschurch/crds-net/labels{/name}","releases_url":"https://api.github.com/repos/crdschurch/crds-net/releases{/id}","deployments_url":"https://api.github.com/repos/crdschurch/crds-net/deployments","created_at":"2018-06-12T18:56:48Z","updated_at":"2018-11-28T19:33:10Z","pushed_at":"2018-11-28T19:52:16Z","git_url":"git://github.com/crdschurch/crds-net.git","ssh_url":"git@github.com:crdschurch/crds-net.git","clone_url":"https://github.com/crdschurch/crds-net.git","svn_url":"https://github.com/crdschurch/crds-net","homepage":"https://crossroads.net","size":3326,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":2,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/crdschurch/crds-net/pulls/287"},"html":{"href":"https://github.com/crdschurch/crds-net/pull/287"},"issue":{"href":"https://api.github.com/repos/crdschurch/crds-net/issues/287"},"comments":{"href":"https://api.github.com/repos/crdschurch/crds-net/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/crdschurch/crds-net/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/crdschurch/crds-net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crdschurch/crds-net/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/crdschurch/crds-net/statuses/f99a43aa807fd9a58a6cbe15c9482a4905a1a093"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lukemoderwell"}}