{"action":"created","comment":{"url":"https://api.github.com/repos/open-io/oio-sds/pulls/comments/242563702","pull_request_review_id":186102062,"id":242563702,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjU2MzcwMg==","diff_hunk":"@@ -1623,19 +1634,27 @@ meta2_backend_check_content(struct meta2_backend_s *m2b, struct oio_url_s *url,\n \t\t\tGSList *chunk_meta = NULL;\n \t\t\t*beans = gslist_extract(*beans, &chunk_meta,\n \t\t\t\t\t(GCompareFunc)_prop_is_not_prefixed, OIO_CHUNK_SYSMETA_PREFIX);\n-\t\t\tGSList *messages = NULL;\n-\t\t\tm2db_check_content_quality(sorted, chunk_meta, &messages);\n-\t\t\tfor (GSList *msgs = messages; msgs != NULL; msgs = msgs->next) {\n-\t\t\t\tgchar *msg = msgs->data;\n-\t\t\t\tGString *gs = oio_event__create_with_id(\n-\t\t\t\t\t\t\"storage.content.perfectible\",\n-\t\t\t\t\t\turl, oio_ext_get_reqid());\n-\t\t\t\tg_string_append(gs, \",\\\"data\\\":\");\n-\t\t\t\tg_string_append(gs, msg);\n-\t\t\t\tg_string_append(gs, \"}\");\n-\t\t\t\tsend_event(g_string_free(gs, FALSE), NULL);\n+\t\t\tGSList *flaws = NULL;\n+\t\t\tm2db_check_content_quality(sorted, chunk_meta, &flaws);\n+\t\t\tif (flaws) {\n+\t\t\t\t/* Ensure there is a version in the URL used to create the\n+\t\t\t\t * event. We cannot patch the input URL because m2db_put_alias\n+\t\t\t\t * checks there is NO version in the URL. */","path":"meta2v2/meta2_backend.c","position":38,"original_position":38,"commit_id":"482a0e1689b915a2adeb9550ab6b2c7e2b9e5aeb","original_commit_id":"482a0e1689b915a2adeb9550ab6b2c7e2b9e5aeb","user":{"login":"fvennetier","id":1398191,"node_id":"MDQ6VXNlcjEzOTgxOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1398191?v=4","gravatar_id":"","url":"https://api.github.com/users/fvennetier","html_url":"https://github.com/fvennetier","followers_url":"https://api.github.com/users/fvennetier/followers","following_url":"https://api.github.com/users/fvennetier/following{/other_user}","gists_url":"https://api.github.com/users/fvennetier/gists{/gist_id}","starred_url":"https://api.github.com/users/fvennetier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvennetier/subscriptions","organizations_url":"https://api.github.com/users/fvennetier/orgs","repos_url":"https://api.github.com/users/fvennetier/repos","events_url":"https://api.github.com/users/fvennetier/events{/privacy}","received_events_url":"https://api.github.com/users/fvennetier/received_events","type":"User","site_admin":false},"body":"Actually I loosened this constraint, and now we can patch `url`.","created_at":"2018-12-18T14:44:14Z","updated_at":"2018-12-18T14:44:14Z","html_url":"https://github.com/open-io/oio-sds/pull/1616#discussion_r242563702","pull_request_url":"https://api.github.com/repos/open-io/oio-sds/pulls/1616","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/comments/242563702"},"html":{"href":"https://github.com/open-io/oio-sds/pull/1616#discussion_r242563702"},"pull_request":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/1616"}}},"pull_request":{"url":"https://api.github.com/repos/open-io/oio-sds/pulls/1616","id":233993183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTkzMTgz","html_url":"https://github.com/open-io/oio-sds/pull/1616","diff_url":"https://github.com/open-io/oio-sds/pull/1616.diff","patch_url":"https://github.com/open-io/oio-sds/pull/1616.patch","issue_url":"https://api.github.com/repos/open-io/oio-sds/issues/1616","number":1616,"state":"open","locked":false,"title":"Redistribute degraded chunks in an optimized way","user":{"login":"fvennetier","id":1398191,"node_id":"MDQ6VXNlcjEzOTgxOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1398191?v=4","gravatar_id":"","url":"https://api.github.com/users/fvennetier","html_url":"https://github.com/fvennetier","followers_url":"https://api.github.com/users/fvennetier/followers","following_url":"https://api.github.com/users/fvennetier/following{/other_user}","gists_url":"https://api.github.com/users/fvennetier/gists{/gist_id}","starred_url":"https://api.github.com/users/fvennetier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvennetier/subscriptions","organizations_url":"https://api.github.com/users/fvennetier/orgs","repos_url":"https://api.github.com/users/fvennetier/repos","events_url":"https://api.github.com/users/fvennetier/events{/privacy}","received_events_url":"https://api.github.com/users/fvennetier/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\n\r\n- [x] Modify meta2's `get_conditioned_spare_chunks()` function to also return the quality of generated chunk addresses.\r\n- [x] Modify Python API's `Content._get_spare_chunk()` method to compare this quality to the expected one, and retry the request a limited number of times in case of failure.\r\n- [x] Move the \"perfectible\" chunk to its new place.\r\n\r\n##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\n- meta2\r\n- oio-proxy\r\n- Python API\r\n- oio-blob-rebuilder\r\n\r\n##### SDS VERSION\r\n```\r\nopenio 4.3.1.dev80\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\nJira: R1810-28","created_at":"2018-11-27T17:12:18Z","updated_at":"2018-12-18T14:44:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f0433cf241a6bcc97c5e6dc2a62288a6eea0910","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":186798208,"node_id":"MDU6TGFiZWwxODY3OTgyMDg=","url":"https://api.github.com/repos/open-io/oio-sds/labels/enhancement%20:sparkles:","name":"enhancement :sparkles:","color":"84b6eb","default":false},{"id":597237519,"node_id":"MDU6TGFiZWw1OTcyMzc1MTk=","url":"https://api.github.com/repos/open-io/oio-sds/labels/language:C","name":"language:C","color":"555555","default":false},{"id":597232777,"node_id":"MDU6TGFiZWw1OTcyMzI3Nzc=","url":"https://api.github.com/repos/open-io/oio-sds/labels/language:python%20:snake:","name":"language:python :snake:","color":"3572a5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/open-io/oio-sds/pulls/1616/commits","review_comments_url":"https://api.github.com/repos/open-io/oio-sds/pulls/1616/comments","review_comment_url":"https://api.github.com/repos/open-io/oio-sds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-io/oio-sds/issues/1616/comments","statuses_url":"https://api.github.com/repos/open-io/oio-sds/statuses/482a0e1689b915a2adeb9550ab6b2c7e2b9e5aeb","head":{"label":"fvennetier:redistribute-degraded-chunks","ref":"redistribute-degraded-chunks","sha":"482a0e1689b915a2adeb9550ab6b2c7e2b9e5aeb","user":{"login":"fvennetier","id":1398191,"node_id":"MDQ6VXNlcjEzOTgxOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1398191?v=4","gravatar_id":"","url":"https://api.github.com/users/fvennetier","html_url":"https://github.com/fvennetier","followers_url":"https://api.github.com/users/fvennetier/followers","following_url":"https://api.github.com/users/fvennetier/following{/other_user}","gists_url":"https://api.github.com/users/fvennetier/gists{/gist_id}","starred_url":"https://api.github.com/users/fvennetier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvennetier/subscriptions","organizations_url":"https://api.github.com/users/fvennetier/orgs","repos_url":"https://api.github.com/users/fvennetier/repos","events_url":"https://api.github.com/users/fvennetier/events{/privacy}","received_events_url":"https://api.github.com/users/fvennetier/received_events","type":"User","site_admin":false},"repo":{"id":49139579,"node_id":"MDEwOlJlcG9zaXRvcnk0OTEzOTU3OQ==","name":"oio-sds","full_name":"fvennetier/oio-sds","private":false,"owner":{"login":"fvennetier","id":1398191,"node_id":"MDQ6VXNlcjEzOTgxOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1398191?v=4","gravatar_id":"","url":"https://api.github.com/users/fvennetier","html_url":"https://github.com/fvennetier","followers_url":"https://api.github.com/users/fvennetier/followers","following_url":"https://api.github.com/users/fvennetier/following{/other_user}","gists_url":"https://api.github.com/users/fvennetier/gists{/gist_id}","starred_url":"https://api.github.com/users/fvennetier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvennetier/subscriptions","organizations_url":"https://api.github.com/users/fvennetier/orgs","repos_url":"https://api.github.com/users/fvennetier/repos","events_url":"https://api.github.com/users/fvennetier/events{/privacy}","received_events_url":"https://api.github.com/users/fvennetier/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fvennetier/oio-sds","description":"OpenIO Software Defined Storage","fork":true,"url":"https://api.github.com/repos/fvennetier/oio-sds","forks_url":"https://api.github.com/repos/fvennetier/oio-sds/forks","keys_url":"https://api.github.com/repos/fvennetier/oio-sds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fvennetier/oio-sds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fvennetier/oio-sds/teams","hooks_url":"https://api.github.com/repos/fvennetier/oio-sds/hooks","issue_events_url":"https://api.github.com/repos/fvennetier/oio-sds/issues/events{/number}","events_url":"https://api.github.com/repos/fvennetier/oio-sds/events","assignees_url":"https://api.github.com/repos/fvennetier/oio-sds/assignees{/user}","branches_url":"https://api.github.com/repos/fvennetier/oio-sds/branches{/branch}","tags_url":"https://api.github.com/repos/fvennetier/oio-sds/tags","blobs_url":"https://api.github.com/repos/fvennetier/oio-sds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fvennetier/oio-sds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fvennetier/oio-sds/git/refs{/sha}","trees_url":"https://api.github.com/repos/fvennetier/oio-sds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fvennetier/oio-sds/statuses/{sha}","languages_url":"https://api.github.com/repos/fvennetier/oio-sds/languages","stargazers_url":"https://api.github.com/repos/fvennetier/oio-sds/stargazers","contributors_url":"https://api.github.com/repos/fvennetier/oio-sds/contributors","subscribers_url":"https://api.github.com/repos/fvennetier/oio-sds/subscribers","subscription_url":"https://api.github.com/repos/fvennetier/oio-sds/subscription","commits_url":"https://api.github.com/repos/fvennetier/oio-sds/commits{/sha}","git_commits_url":"https://api.github.com/repos/fvennetier/oio-sds/git/commits{/sha}","comments_url":"https://api.github.com/repos/fvennetier/oio-sds/comments{/number}","issue_comment_url":"https://api.github.com/repos/fvennetier/oio-sds/issues/comments{/number}","contents_url":"https://api.github.com/repos/fvennetier/oio-sds/contents/{+path}","compare_url":"https://api.github.com/repos/fvennetier/oio-sds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fvennetier/oio-sds/merges","archive_url":"https://api.github.com/repos/fvennetier/oio-sds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fvennetier/oio-sds/downloads","issues_url":"https://api.github.com/repos/fvennetier/oio-sds/issues{/number}","pulls_url":"https://api.github.com/repos/fvennetier/oio-sds/pulls{/number}","milestones_url":"https://api.github.com/repos/fvennetier/oio-sds/milestones{/number}","notifications_url":"https://api.github.com/repos/fvennetier/oio-sds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fvennetier/oio-sds/labels{/name}","releases_url":"https://api.github.com/repos/fvennetier/oio-sds/releases{/id}","deployments_url":"https://api.github.com/repos/fvennetier/oio-sds/deployments","created_at":"2016-01-06T14:21:10Z","updated_at":"2018-12-07T13:47:31Z","pushed_at":"2018-12-14T15:15:32Z","git_url":"git://github.com/fvennetier/oio-sds.git","ssh_url":"git@github.com:fvennetier/oio-sds.git","clone_url":"https://github.com/fvennetier/oio-sds.git","svn_url":"https://github.com/fvennetier/oio-sds","homepage":null,"size":17493,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"open-io:master","ref":"master","sha":"d9ad9a50bed8206009a7bbb461f0819e88f4bef3","user":{"login":"open-io","id":11300184,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzAwMTg0","avatar_url":"https://avatars1.githubusercontent.com/u/11300184?v=4","gravatar_id":"","url":"https://api.github.com/users/open-io","html_url":"https://github.com/open-io","followers_url":"https://api.github.com/users/open-io/followers","following_url":"https://api.github.com/users/open-io/following{/other_user}","gists_url":"https://api.github.com/users/open-io/gists{/gist_id}","starred_url":"https://api.github.com/users/open-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-io/subscriptions","organizations_url":"https://api.github.com/users/open-io/orgs","repos_url":"https://api.github.com/users/open-io/repos","events_url":"https://api.github.com/users/open-io/events{/privacy}","received_events_url":"https://api.github.com/users/open-io/received_events","type":"Organization","site_admin":false},"repo":{"id":32169193,"node_id":"MDEwOlJlcG9zaXRvcnkzMjE2OTE5Mw==","name":"oio-sds","full_name":"open-io/oio-sds","private":false,"owner":{"login":"open-io","id":11300184,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzAwMTg0","avatar_url":"https://avatars1.githubusercontent.com/u/11300184?v=4","gravatar_id":"","url":"https://api.github.com/users/open-io","html_url":"https://github.com/open-io","followers_url":"https://api.github.com/users/open-io/followers","following_url":"https://api.github.com/users/open-io/following{/other_user}","gists_url":"https://api.github.com/users/open-io/gists{/gist_id}","starred_url":"https://api.github.com/users/open-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-io/subscriptions","organizations_url":"https://api.github.com/users/open-io/orgs","repos_url":"https://api.github.com/users/open-io/repos","events_url":"https://api.github.com/users/open-io/events{/privacy}","received_events_url":"https://api.github.com/users/open-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-io/oio-sds","description":"OpenIO Software Defined Storage, Flexible + Smart + Fast","fork":false,"url":"https://api.github.com/repos/open-io/oio-sds","forks_url":"https://api.github.com/repos/open-io/oio-sds/forks","keys_url":"https://api.github.com/repos/open-io/oio-sds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-io/oio-sds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-io/oio-sds/teams","hooks_url":"https://api.github.com/repos/open-io/oio-sds/hooks","issue_events_url":"https://api.github.com/repos/open-io/oio-sds/issues/events{/number}","events_url":"https://api.github.com/repos/open-io/oio-sds/events","assignees_url":"https://api.github.com/repos/open-io/oio-sds/assignees{/user}","branches_url":"https://api.github.com/repos/open-io/oio-sds/branches{/branch}","tags_url":"https://api.github.com/repos/open-io/oio-sds/tags","blobs_url":"https://api.github.com/repos/open-io/oio-sds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-io/oio-sds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-io/oio-sds/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-io/oio-sds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-io/oio-sds/statuses/{sha}","languages_url":"https://api.github.com/repos/open-io/oio-sds/languages","stargazers_url":"https://api.github.com/repos/open-io/oio-sds/stargazers","contributors_url":"https://api.github.com/repos/open-io/oio-sds/contributors","subscribers_url":"https://api.github.com/repos/open-io/oio-sds/subscribers","subscription_url":"https://api.github.com/repos/open-io/oio-sds/subscription","commits_url":"https://api.github.com/repos/open-io/oio-sds/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-io/oio-sds/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-io/oio-sds/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-io/oio-sds/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-io/oio-sds/contents/{+path}","compare_url":"https://api.github.com/repos/open-io/oio-sds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-io/oio-sds/merges","archive_url":"https://api.github.com/repos/open-io/oio-sds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-io/oio-sds/downloads","issues_url":"https://api.github.com/repos/open-io/oio-sds/issues{/number}","pulls_url":"https://api.github.com/repos/open-io/oio-sds/pulls{/number}","milestones_url":"https://api.github.com/repos/open-io/oio-sds/milestones{/number}","notifications_url":"https://api.github.com/repos/open-io/oio-sds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-io/oio-sds/labels{/name}","releases_url":"https://api.github.com/repos/open-io/oio-sds/releases{/id}","deployments_url":"https://api.github.com/repos/open-io/oio-sds/deployments","created_at":"2015-03-13T17:06:25Z","updated_at":"2018-12-18T11:25:28Z","pushed_at":"2018-12-18T09:13:28Z","git_url":"git://github.com/open-io/oio-sds.git","ssh_url":"git@github.com:open-io/oio-sds.git","clone_url":"https://github.com/open-io/oio-sds.git","svn_url":"https://github.com/open-io/oio-sds","homepage":"http://openio.io","size":17677,"stargazers_count":304,"watchers_count":304,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":66,"open_issues":33,"watchers":304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/1616"},"html":{"href":"https://github.com/open-io/oio-sds/pull/1616"},"issue":{"href":"https://api.github.com/repos/open-io/oio-sds/issues/1616"},"comments":{"href":"https://api.github.com/repos/open-io/oio-sds/issues/1616/comments"},"review_comments":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/1616/comments"},"review_comment":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-io/oio-sds/pulls/1616/commits"},"statuses":{"href":"https://api.github.com/repos/open-io/oio-sds/statuses/482a0e1689b915a2adeb9550ab6b2c7e2b9e5aeb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fvennetier"}}