{"action":"created","issue":{"url":"https://api.github.com/repos/Enet4/nifti-rs/issues/17","repository_url":"https://api.github.com/repos/Enet4/nifti-rs","labels_url":"https://api.github.com/repos/Enet4/nifti-rs/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/Enet4/nifti-rs/issues/17/comments","events_url":"https://api.github.com/repos/Enet4/nifti-rs/issues/17/events","html_url":"https://github.com/Enet4/nifti-rs/pull/17","id":370195599,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTMwOTc1","number":17,"title":"Improve function naming in volume-related functions","user":{"login":"Enet4","id":4738426,"node_id":"MDQ6VXNlcjQ3Mzg0MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/4738426?v=4","gravatar_id":"","url":"https://api.github.com/users/Enet4","html_url":"https://github.com/Enet4","followers_url":"https://api.github.com/users/Enet4/followers","following_url":"https://api.github.com/users/Enet4/following{/other_user}","gists_url":"https://api.github.com/users/Enet4/gists{/gist_id}","starred_url":"https://api.github.com/users/Enet4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Enet4/subscriptions","organizations_url":"https://api.github.com/users/Enet4/orgs","repos_url":"https://api.github.com/users/Enet4/repos","events_url":"https://api.github.com/users/Enet4/events{/privacy}","received_events_url":"https://api.github.com/users/Enet4/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-15T14:40:03Z","updated_at":"2018-10-15T15:44:42Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/Enet4/nifti-rs/pulls/17","html_url":"https://github.com/Enet4/nifti-rs/pull/17","diff_url":"https://github.com/Enet4/nifti-rs/pull/17.diff","patch_url":"https://github.com/Enet4/nifti-rs/pull/17.patch"},"body":"The [naming guidelines](https://rust-lang-nursery.github.io/api-guidelines/naming.html) established in the Rust API guidelines help us create interfaces that are generally intuitive and non-confusing for the usual Rust programmer. During the development of `nifti`, I accidentally gave some methods and functions unconventional names, which I believe should be corrected before the crate enters a mature state. To make the migration process smoother, I deprecated the old methods for removal, starting from 0.6.0, and will only remove them in 0.7.0.\r\n\r\n- deprecate `InMemNiftiVolume::to_raw_data` into `into_raw_data`\r\n- deprecate `InMemNiftiVolume::get_raw_data` and `InMemNiftiVolume::get_raw_data_mut` into `InMemNiftiVolume::raw_data` and `InMemNiftiVolume::raw_data_mut`\r\n- deprecate `IntoNdarray::to_ndarray` into `into_ndarray`\r\n- rename util function `to_img_file_gz` to `into_img_file_gz`"},"comment":{"url":"https://api.github.com/repos/Enet4/nifti-rs/issues/comments/429907039","html_url":"https://github.com/Enet4/nifti-rs/pull/17#issuecomment-429907039","issue_url":"https://api.github.com/repos/Enet4/nifti-rs/issues/17","id":429907039,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTkwNzAzOQ==","user":{"login":"nilgoyette","id":2658640,"node_id":"MDQ6VXNlcjI2NTg2NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2658640?v=4","gravatar_id":"","url":"https://api.github.com/users/nilgoyette","html_url":"https://github.com/nilgoyette","followers_url":"https://api.github.com/users/nilgoyette/followers","following_url":"https://api.github.com/users/nilgoyette/following{/other_user}","gists_url":"https://api.github.com/users/nilgoyette/gists{/gist_id}","starred_url":"https://api.github.com/users/nilgoyette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilgoyette/subscriptions","organizations_url":"https://api.github.com/users/nilgoyette/orgs","repos_url":"https://api.github.com/users/nilgoyette/repos","events_url":"https://api.github.com/users/nilgoyette/events{/privacy}","received_events_url":"https://api.github.com/users/nilgoyette/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T15:44:42Z","updated_at":"2018-10-15T15:44:42Z","author_association":"COLLABORATOR","body":"It's always a good idea to be consistant! LGTM."}}
{"actor":{"display_login":"nilgoyette"}}