{"action":"opened","number":84,"pull_request":{"url":"https://api.github.com/repos/vitelabs/go-vite/pulls/84","id":232206002,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMjA2MDAy","html_url":"https://github.com/vitelabs/go-vite/pull/84","diff_url":"https://github.com/vitelabs/go-vite/pull/84.diff","patch_url":"https://github.com/vitelabs/go-vite/pull/84.patch","issue_url":"https://api.github.com/repos/vitelabs/go-vite/issues/84","number":84,"state":"open","locked":false,"title":"[optimization] p2p.Config.PrivateKey","user":{"login":"jerry-vite","id":41624063,"node_id":"MDQ6VXNlcjQxNjI0MDYz","avatar_url":"https://avatars1.githubusercontent.com/u/41624063?v=4","gravatar_id":"","url":"https://api.github.com/users/jerry-vite","html_url":"https://github.com/jerry-vite","followers_url":"https://api.github.com/users/jerry-vite/followers","following_url":"https://api.github.com/users/jerry-vite/following{/other_user}","gists_url":"https://api.github.com/users/jerry-vite/gists{/gist_id}","starred_url":"https://api.github.com/users/jerry-vite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerry-vite/subscriptions","organizations_url":"https://api.github.com/users/jerry-vite/orgs","repos_url":"https://api.github.com/users/jerry-vite/repos","events_url":"https://api.github.com/users/jerry-vite/events{/privacy}","received_events_url":"https://api.github.com/users/jerry-vite/received_events","type":"User","site_admin":false},"body":"optimize two points:\r\n1. rename field `PrivateKey` of node_config.json to `P2Pkey` to reduce the misunderstanding.\r\n2. if there is no `P2Pkey` in node_config.json, but got `Coinbase` and `EntropyStorePath`, then will extract privateKey from coinbase as the P2P.Config.PrivateKey.\r\n","created_at":"2018-11-20T06:32:04Z","updated_at":"2018-11-20T06:32:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vitelabs/go-vite/pulls/84/commits","review_comments_url":"https://api.github.com/repos/vitelabs/go-vite/pulls/84/comments","review_comment_url":"https://api.github.com/repos/vitelabs/go-vite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vitelabs/go-vite/issues/84/comments","statuses_url":"https://api.github.com/repos/vitelabs/go-vite/statuses/46e1b66e7025a0ffc5ca163ba18bb4b67e12ca45","head":{"label":"jerry-vite:v0.0.3-p2p-privateKey","ref":"v0.0.3-p2p-privateKey","sha":"46e1b66e7025a0ffc5ca163ba18bb4b67e12ca45","user":{"login":"jerry-vite","id":41624063,"node_id":"MDQ6VXNlcjQxNjI0MDYz","avatar_url":"https://avatars1.githubusercontent.com/u/41624063?v=4","gravatar_id":"","url":"https://api.github.com/users/jerry-vite","html_url":"https://github.com/jerry-vite","followers_url":"https://api.github.com/users/jerry-vite/followers","following_url":"https://api.github.com/users/jerry-vite/following{/other_user}","gists_url":"https://api.github.com/users/jerry-vite/gists{/gist_id}","starred_url":"https://api.github.com/users/jerry-vite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerry-vite/subscriptions","organizations_url":"https://api.github.com/users/jerry-vite/orgs","repos_url":"https://api.github.com/users/jerry-vite/repos","events_url":"https://api.github.com/users/jerry-vite/events{/privacy}","received_events_url":"https://api.github.com/users/jerry-vite/received_events","type":"User","site_admin":false},"repo":{"id":157547709,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc1NDc3MDk=","name":"go-vite","full_name":"jerry-vite/go-vite","private":false,"owner":{"login":"jerry-vite","id":41624063,"node_id":"MDQ6VXNlcjQxNjI0MDYz","avatar_url":"https://avatars1.githubusercontent.com/u/41624063?v=4","gravatar_id":"","url":"https://api.github.com/users/jerry-vite","html_url":"https://github.com/jerry-vite","followers_url":"https://api.github.com/users/jerry-vite/followers","following_url":"https://api.github.com/users/jerry-vite/following{/other_user}","gists_url":"https://api.github.com/users/jerry-vite/gists{/gist_id}","starred_url":"https://api.github.com/users/jerry-vite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerry-vite/subscriptions","organizations_url":"https://api.github.com/users/jerry-vite/orgs","repos_url":"https://api.github.com/users/jerry-vite/repos","events_url":"https://api.github.com/users/jerry-vite/events{/privacy}","received_events_url":"https://api.github.com/users/jerry-vite/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jerry-vite/go-vite","description":"Official Go implementation of the Vite protocol","fork":true,"url":"https://api.github.com/repos/jerry-vite/go-vite","forks_url":"https://api.github.com/repos/jerry-vite/go-vite/forks","keys_url":"https://api.github.com/repos/jerry-vite/go-vite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerry-vite/go-vite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerry-vite/go-vite/teams","hooks_url":"https://api.github.com/repos/jerry-vite/go-vite/hooks","issue_events_url":"https://api.github.com/repos/jerry-vite/go-vite/issues/events{/number}","events_url":"https://api.github.com/repos/jerry-vite/go-vite/events","assignees_url":"https://api.github.com/repos/jerry-vite/go-vite/assignees{/user}","branches_url":"https://api.github.com/repos/jerry-vite/go-vite/branches{/branch}","tags_url":"https://api.github.com/repos/jerry-vite/go-vite/tags","blobs_url":"https://api.github.com/repos/jerry-vite/go-vite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerry-vite/go-vite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerry-vite/go-vite/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerry-vite/go-vite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerry-vite/go-vite/statuses/{sha}","languages_url":"https://api.github.com/repos/jerry-vite/go-vite/languages","stargazers_url":"https://api.github.com/repos/jerry-vite/go-vite/stargazers","contributors_url":"https://api.github.com/repos/jerry-vite/go-vite/contributors","subscribers_url":"https://api.github.com/repos/jerry-vite/go-vite/subscribers","subscription_url":"https://api.github.com/repos/jerry-vite/go-vite/subscription","commits_url":"https://api.github.com/repos/jerry-vite/go-vite/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerry-vite/go-vite/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerry-vite/go-vite/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerry-vite/go-vite/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerry-vite/go-vite/contents/{+path}","compare_url":"https://api.github.com/repos/jerry-vite/go-vite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerry-vite/go-vite/merges","archive_url":"https://api.github.com/repos/jerry-vite/go-vite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerry-vite/go-vite/downloads","issues_url":"https://api.github.com/repos/jerry-vite/go-vite/issues{/number}","pulls_url":"https://api.github.com/repos/jerry-vite/go-vite/pulls{/number}","milestones_url":"https://api.github.com/repos/jerry-vite/go-vite/milestones{/number}","notifications_url":"https://api.github.com/repos/jerry-vite/go-vite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerry-vite/go-vite/labels{/name}","releases_url":"https://api.github.com/repos/jerry-vite/go-vite/releases{/id}","deployments_url":"https://api.github.com/repos/jerry-vite/go-vite/deployments","created_at":"2018-11-14T12:47:05Z","updated_at":"2018-11-14T12:47:08Z","pushed_at":"2018-11-20T06:25:29Z","git_url":"git://github.com/jerry-vite/go-vite.git","ssh_url":"git@github.com:jerry-vite/go-vite.git","clone_url":"https://github.com/jerry-vite/go-vite.git","svn_url":"https://github.com/jerry-vite/go-vite","homepage":"https://vite.org/","size":71093,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vitelabs:master","ref":"master","sha":"64749546bd588300c45570a14c06e09c1abcd2c0","user":{"login":"vitelabs","id":36895023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODk1MDIz","avatar_url":"https://avatars3.githubusercontent.com/u/36895023?v=4","gravatar_id":"","url":"https://api.github.com/users/vitelabs","html_url":"https://github.com/vitelabs","followers_url":"https://api.github.com/users/vitelabs/followers","following_url":"https://api.github.com/users/vitelabs/following{/other_user}","gists_url":"https://api.github.com/users/vitelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vitelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitelabs/subscriptions","organizations_url":"https://api.github.com/users/vitelabs/orgs","repos_url":"https://api.github.com/users/vitelabs/repos","events_url":"https://api.github.com/users/vitelabs/events{/privacy}","received_events_url":"https://api.github.com/users/vitelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":133392857,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzOTI4NTc=","name":"go-vite","full_name":"vitelabs/go-vite","private":false,"owner":{"login":"vitelabs","id":36895023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODk1MDIz","avatar_url":"https://avatars3.githubusercontent.com/u/36895023?v=4","gravatar_id":"","url":"https://api.github.com/users/vitelabs","html_url":"https://github.com/vitelabs","followers_url":"https://api.github.com/users/vitelabs/followers","following_url":"https://api.github.com/users/vitelabs/following{/other_user}","gists_url":"https://api.github.com/users/vitelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vitelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitelabs/subscriptions","organizations_url":"https://api.github.com/users/vitelabs/orgs","repos_url":"https://api.github.com/users/vitelabs/repos","events_url":"https://api.github.com/users/vitelabs/events{/privacy}","received_events_url":"https://api.github.com/users/vitelabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vitelabs/go-vite","description":"Official Go implementation of the Vite protocol","fork":false,"url":"https://api.github.com/repos/vitelabs/go-vite","forks_url":"https://api.github.com/repos/vitelabs/go-vite/forks","keys_url":"https://api.github.com/repos/vitelabs/go-vite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitelabs/go-vite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitelabs/go-vite/teams","hooks_url":"https://api.github.com/repos/vitelabs/go-vite/hooks","issue_events_url":"https://api.github.com/repos/vitelabs/go-vite/issues/events{/number}","events_url":"https://api.github.com/repos/vitelabs/go-vite/events","assignees_url":"https://api.github.com/repos/vitelabs/go-vite/assignees{/user}","branches_url":"https://api.github.com/repos/vitelabs/go-vite/branches{/branch}","tags_url":"https://api.github.com/repos/vitelabs/go-vite/tags","blobs_url":"https://api.github.com/repos/vitelabs/go-vite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitelabs/go-vite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitelabs/go-vite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitelabs/go-vite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitelabs/go-vite/statuses/{sha}","languages_url":"https://api.github.com/repos/vitelabs/go-vite/languages","stargazers_url":"https://api.github.com/repos/vitelabs/go-vite/stargazers","contributors_url":"https://api.github.com/repos/vitelabs/go-vite/contributors","subscribers_url":"https://api.github.com/repos/vitelabs/go-vite/subscribers","subscription_url":"https://api.github.com/repos/vitelabs/go-vite/subscription","commits_url":"https://api.github.com/repos/vitelabs/go-vite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitelabs/go-vite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitelabs/go-vite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitelabs/go-vite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitelabs/go-vite/contents/{+path}","compare_url":"https://api.github.com/repos/vitelabs/go-vite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitelabs/go-vite/merges","archive_url":"https://api.github.com/repos/vitelabs/go-vite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitelabs/go-vite/downloads","issues_url":"https://api.github.com/repos/vitelabs/go-vite/issues{/number}","pulls_url":"https://api.github.com/repos/vitelabs/go-vite/pulls{/number}","milestones_url":"https://api.github.com/repos/vitelabs/go-vite/milestones{/number}","notifications_url":"https://api.github.com/repos/vitelabs/go-vite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitelabs/go-vite/labels{/name}","releases_url":"https://api.github.com/repos/vitelabs/go-vite/releases{/id}","deployments_url":"https://api.github.com/repos/vitelabs/go-vite/deployments","created_at":"2018-05-14T16:43:43Z","updated_at":"2018-11-19T12:46:49Z","pushed_at":"2018-11-20T04:11:23Z","git_url":"git://github.com/vitelabs/go-vite.git","ssh_url":"git@github.com:vitelabs/go-vite.git","clone_url":"https://github.com/vitelabs/go-vite.git","svn_url":"https://github.com/vitelabs/go-vite","homepage":"https://vite.org/","size":71170,"stargazers_count":125,"watchers_count":125,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":26,"open_issues":3,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vitelabs/go-vite/pulls/84"},"html":{"href":"https://github.com/vitelabs/go-vite/pull/84"},"issue":{"href":"https://api.github.com/repos/vitelabs/go-vite/issues/84"},"comments":{"href":"https://api.github.com/repos/vitelabs/go-vite/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/vitelabs/go-vite/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/vitelabs/go-vite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vitelabs/go-vite/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/vitelabs/go-vite/statuses/46e1b66e7025a0ffc5ca163ba18bb4b67e12ca45"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":71,"deletions":39,"changed_files":4}}
{"actor":{"display_login":"jerry-vite"}}