{"action":"created","issue":{"url":"https://api.github.com/repos/chaostoolkit-incubator/chaostoolkit-cloud-foundry/issues/12","repository_url":"https://api.github.com/repos/chaostoolkit-incubator/chaostoolkit-cloud-foundry","labels_url":"https://api.github.com/repos/chaostoolkit-incubator/chaostoolkit-cloud-foundry/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/chaostoolkit-incubator/chaostoolkit-cloud-foundry/issues/12/comments","events_url":"https://api.github.com/repos/chaostoolkit-incubator/chaostoolkit-cloud-foundry/issues/12/events","html_url":"https://github.com/chaostoolkit-incubator/chaostoolkit-cloud-foundry/pull/12","id":349354605,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDkxNjky","number":12,"title":"Feature: Add stop application action","user":{"login":"singhgarima","id":169889,"node_id":"MDQ6VXNlcjE2OTg4OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/169889?v=4","gravatar_id":"","url":"https://api.github.com/users/singhgarima","html_url":"https://github.com/singhgarima","followers_url":"https://api.github.com/users/singhgarima/followers","following_url":"https://api.github.com/users/singhgarima/following{/other_user}","gists_url":"https://api.github.com/users/singhgarima/gists{/gist_id}","starred_url":"https://api.github.com/users/singhgarima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singhgarima/subscriptions","organizations_url":"https://api.github.com/users/singhgarima/orgs","repos_url":"https://api.github.com/users/singhgarima/repos","events_url":"https://api.github.com/users/singhgarima/events{/privacy}","received_events_url":"https://api.github.com/users/singhgarima/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"russmiles","id":104529,"node_id":"MDQ6VXNlcjEwNDUyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/104529?v=4","gravatar_id":"","url":"https://api.github.com/users/russmiles","html_url":"https://github.com/russmiles","followers_url":"https://api.github.com/users/russmiles/followers","following_url":"https://api.github.com/users/russmiles/following{/other_user}","gists_url":"https://api.github.com/users/russmiles/gists{/gist_id}","starred_url":"https://api.github.com/users/russmiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russmiles/subscriptions","organizations_url":"https://api.github.com/users/russmiles/orgs","repos_url":"https://api.github.com/users/russmiles/repos","events_url":"https://api.github.com/users/russmiles/events{/privacy}","received_events_url":"https://api.github.com/users/russmiles/received_events","type":"User","site_admin":false},"assignees":[{"login":"russmiles","id":104529,"node_id":"MDQ6VXNlcjEwNDUyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/104529?v=4","gravatar_id":"","url":"https://api.github.com/users/russmiles","html_url":"https://github.com/russmiles","followers_url":"https://api.github.com/users/russmiles/followers","following_url":"https://api.github.com/users/russmiles/following{/other_user}","gists_url":"https://api.github.com/users/russmiles/gists{/gist_id}","starred_url":"https://api.github.com/users/russmiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russmiles/subscriptions","organizations_url":"https://api.github.com/users/russmiles/orgs","repos_url":"https://api.github.com/users/russmiles/repos","events_url":"https://api.github.com/users/russmiles/events{/privacy}","received_events_url":"https://api.github.com/users/russmiles/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-08-10T02:30:58Z","updated_at":"2018-08-10T09:30:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/chaostoolkit-incubator/chaostoolkit-cloud-foundry/pulls/12","html_url":"https://github.com/chaostoolkit-incubator/chaostoolkit-cloud-foundry/pull/12","diff_url":"https://github.com/chaostoolkit-incubator/chaostoolkit-cloud-foundry/pull/12.diff","patch_url":"https://github.com/chaostoolkit-incubator/chaostoolkit-cloud-foundry/pull/12.patch"},"body":"The pull request adds stop_app action to the existing actions.\r\n\r\nI have two additional changes:\r\n* The `test_fail_to_delete_unknown_app` test was failing and I made a minor tweak to fix it\r\n* I have changes `call_api` parameter `data` to `body` as `data` in requests assumes content type to be `application/x-www-form-urlencoded` whereas cf api supports `application/json`"},"comment":{"url":"https://api.github.com/repos/chaostoolkit-incubator/chaostoolkit-cloud-foundry/issues/comments/412030229","html_url":"https://github.com/chaostoolkit-incubator/chaostoolkit-cloud-foundry/pull/12#issuecomment-412030229","issue_url":"https://api.github.com/repos/chaostoolkit-incubator/chaostoolkit-cloud-foundry/issues/12","id":412030229,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjAzMDIyOQ==","user":{"login":"russmiles","id":104529,"node_id":"MDQ6VXNlcjEwNDUyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/104529?v=4","gravatar_id":"","url":"https://api.github.com/users/russmiles","html_url":"https://github.com/russmiles","followers_url":"https://api.github.com/users/russmiles/followers","following_url":"https://api.github.com/users/russmiles/following{/other_user}","gists_url":"https://api.github.com/users/russmiles/gists{/gist_id}","starred_url":"https://api.github.com/users/russmiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russmiles/subscriptions","organizations_url":"https://api.github.com/users/russmiles/orgs","repos_url":"https://api.github.com/users/russmiles/repos","events_url":"https://api.github.com/users/russmiles/events{/privacy}","received_events_url":"https://api.github.com/users/russmiles/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T09:30:09Z","updated_at":"2018-08-10T09:30:09Z","author_association":"CONTRIBUTOR","body":"@singhgarima that should absolutely cover the case, nice call! In my quick scan of the commits I'd missed that you were using the `get_app_by_name` as this type of protection. No further test is needed I think.\r\n\r\nThe way I do this sort of squashing is through the `git rebase` command. Something like the following in your branch:\r\n\r\n```\r\ngit rebase -i HEAD~6\r\n```\r\n\r\nIt's worth doing a `git log` in your branch first to make sure that the number of commits to be squashed, six in my above example, is right and takes all your branch's commits into consideration.\r\n\r\nThat will open up the usual rebase workflow, where I usually switch all the commits except the first one to `s` rather than `pick` and then once that's done select the single most meaningful commit message to use for the squashed commits in the next activity, and add the signature to comply with dco.\r\n\r\nDoes that all make sense?"}}
{"actor":{"display_login":"russmiles"}}