{"action":"created","comment":{"url":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/comments/206483453","pull_request_review_id":141902380,"id":206483453,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjQ4MzQ1Mw==","diff_hunk":"@@ -27,6 +27,6 @@ fi\n \n # if you've executed sbt assembly previously it will use that instead.\n export JAVA_OPTS=\"${JAVA_OPTS} -XX:MaxPermSize=256M -Xmx1024M -DloggerPath=conf/log4j.properties\"\n-ags=\"generate -i modules/openapi-generator/src/test/resources/2_0/petstore.yaml -g elm -o samples/client/petstore/elm $@\"\n+ags=\"generate -i modules/openapi-generator/src/test/resources/2_0/petstore.yaml -g elm -t modules/openapi-generator/src/main/resources/elm -o samples/client/petstore/elm $@\"","path":"bin/elm-petstore.sh","position":5,"original_position":5,"commit_id":"e4fa4329a71a7538fed5dbfc67c38fe937fd5a1f","original_commit_id":"e4fa4329a71a7538fed5dbfc67c38fe937fd5a1f","user":{"login":"trenneman","id":2738701,"node_id":"MDQ6VXNlcjI3Mzg3MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/2738701?v=4","gravatar_id":"","url":"https://api.github.com/users/trenneman","html_url":"https://github.com/trenneman","followers_url":"https://api.github.com/users/trenneman/followers","following_url":"https://api.github.com/users/trenneman/following{/other_user}","gists_url":"https://api.github.com/users/trenneman/gists{/gist_id}","starred_url":"https://api.github.com/users/trenneman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trenneman/subscriptions","organizations_url":"https://api.github.com/users/trenneman/orgs","repos_url":"https://api.github.com/users/trenneman/repos","events_url":"https://api.github.com/users/trenneman/events{/privacy}","received_events_url":"https://api.github.com/users/trenneman/received_events","type":"User","site_admin":false},"body":"do we need this?","created_at":"2018-07-31T11:02:57Z","updated_at":"2018-07-31T11:09:17Z","html_url":"https://github.com/OpenAPITools/openapi-generator/pull/661#discussion_r206483453","pull_request_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/661","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/comments/206483453"},"html":{"href":"https://github.com/OpenAPITools/openapi-generator/pull/661#discussion_r206483453"},"pull_request":{"href":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/661"}}},"pull_request":{"url":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/661","id":204279863,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Mjc5ODYz","html_url":"https://github.com/OpenAPITools/openapi-generator/pull/661","diff_url":"https://github.com/OpenAPITools/openapi-generator/pull/661.diff","patch_url":"https://github.com/OpenAPITools/openapi-generator/pull/661.patch","issue_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/issues/661","number":661,"state":"open","locked":false,"title":"[Elm] Template improvements","user":{"login":"laughedelic","id":766656,"node_id":"MDQ6VXNlcjc2NjY1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/766656?v=4","gravatar_id":"","url":"https://api.github.com/users/laughedelic","html_url":"https://github.com/laughedelic","followers_url":"https://api.github.com/users/laughedelic/followers","following_url":"https://api.github.com/users/laughedelic/following{/other_user}","gists_url":"https://api.github.com/users/laughedelic/gists{/gist_id}","starred_url":"https://api.github.com/users/laughedelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laughedelic/subscriptions","organizations_url":"https://api.github.com/users/laughedelic/orgs","repos_url":"https://api.github.com/users/laughedelic/repos","events_url":"https://api.github.com/users/laughedelic/events{/privacy}","received_events_url":"https://api.github.com/users/laughedelic/received_events","type":"User","site_admin":false},"body":"### PR checklist\r\n\r\n- [x] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/master/CONTRIBUTING.md).\r\n- [x] Ran the shell script under `./bin/` to update Petstore sample so that CIs can verify the change. (For instance, only need to run `./bin/{LANG}-petstore.sh` and `./bin/security/{LANG}-petstore.sh` if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in `.\\bin\\windows\\`.\r\n- [x] Filed the PR against the [correct branch](https://github.com/OpenAPITools/openapi-generator/wiki/Git-Branches): `master`, `4.0.x`. Default: `master`.\r\n- [x] Copied the [technical committee](https://github.com/openapitools/openapi-generator/#62---openapi-generator-technical-committee) to review the pull request if your PR is targeting a particular programming language.\r\n\r\n### Description of the PR\r\n\r\nThis PR fixes #458 and improves doc comments and line spacing in the Elm template. (see also https://github.com/swagger-api/swagger-codegen/issues/8152 for the context).\r\n\r\nThere are still some extra newlines that are hard to get rid of. They appear because the `{{>blah}}` includes bring the last newline in the parent template. I don't know if this can be somehow improved on the Mustache side, but in general it's quite hard to produce some code that immediately complies with the formatting guideline (elm-format).\r\n","created_at":"2018-07-26T22:05:31Z","updated_at":"2018-07-31T11:09:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d1b84b68a5008b92c26abcba009fbf10912abbf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":931402812,"node_id":"MDU6TGFiZWw5MzE0MDI4MTI=","url":"https://api.github.com/repos/OpenAPITools/openapi-generator/labels/Client:%20Elm","name":"Client: Elm","color":"fad8c7","default":false},{"id":931403198,"node_id":"MDU6TGFiZWw5MzE0MDMxOTg=","url":"https://api.github.com/repos/OpenAPITools/openapi-generator/labels/Enhancement:%20General","name":"Enhancement: General","color":"e5ffe5","default":false}],"milestone":{"url":"https://api.github.com/repos/OpenAPITools/openapi-generator/milestones/8","html_url":"https://github.com/OpenAPITools/openapi-generator/milestone/8","labels_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/milestones/8/labels","id":3477329,"node_id":"MDk6TWlsZXN0b25lMzQ3NzMyOQ==","number":8,"title":"3.2.0","description":"","creator":{"login":"wing328","id":934260,"node_id":"MDQ6VXNlcjkzNDI2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/934260?v=4","gravatar_id":"","url":"https://api.github.com/users/wing328","html_url":"https://github.com/wing328","followers_url":"https://api.github.com/users/wing328/followers","following_url":"https://api.github.com/users/wing328/following{/other_user}","gists_url":"https://api.github.com/users/wing328/gists{/gist_id}","starred_url":"https://api.github.com/users/wing328/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wing328/subscriptions","organizations_url":"https://api.github.com/users/wing328/orgs","repos_url":"https://api.github.com/users/wing328/repos","events_url":"https://api.github.com/users/wing328/events{/privacy}","received_events_url":"https://api.github.com/users/wing328/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":38,"state":"open","created_at":"2018-07-06T05:32:09Z","updated_at":"2018-07-31T11:09:01Z","due_on":"2018-08-03T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/661/commits","review_comments_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/661/comments","review_comment_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/issues/661/comments","statuses_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/statuses/e4fa4329a71a7538fed5dbfc67c38fe937fd5a1f","head":{"label":"laughedelic:elm-improvs","ref":"elm-improvs","sha":"e4fa4329a71a7538fed5dbfc67c38fe937fd5a1f","user":{"login":"laughedelic","id":766656,"node_id":"MDQ6VXNlcjc2NjY1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/766656?v=4","gravatar_id":"","url":"https://api.github.com/users/laughedelic","html_url":"https://github.com/laughedelic","followers_url":"https://api.github.com/users/laughedelic/followers","following_url":"https://api.github.com/users/laughedelic/following{/other_user}","gists_url":"https://api.github.com/users/laughedelic/gists{/gist_id}","starred_url":"https://api.github.com/users/laughedelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laughedelic/subscriptions","organizations_url":"https://api.github.com/users/laughedelic/orgs","repos_url":"https://api.github.com/users/laughedelic/repos","events_url":"https://api.github.com/users/laughedelic/events{/privacy}","received_events_url":"https://api.github.com/users/laughedelic/received_events","type":"User","site_admin":false},"repo":{"id":142462057,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0NjIwNTc=","name":"openapi-generator","full_name":"laughedelic/openapi-generator","owner":{"login":"laughedelic","id":766656,"node_id":"MDQ6VXNlcjc2NjY1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/766656?v=4","gravatar_id":"","url":"https://api.github.com/users/laughedelic","html_url":"https://github.com/laughedelic","followers_url":"https://api.github.com/users/laughedelic/followers","following_url":"https://api.github.com/users/laughedelic/following{/other_user}","gists_url":"https://api.github.com/users/laughedelic/gists{/gist_id}","starred_url":"https://api.github.com/users/laughedelic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laughedelic/subscriptions","organizations_url":"https://api.github.com/users/laughedelic/orgs","repos_url":"https://api.github.com/users/laughedelic/repos","events_url":"https://api.github.com/users/laughedelic/events{/privacy}","received_events_url":"https://api.github.com/users/laughedelic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laughedelic/openapi-generator","description":"OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)","fork":true,"url":"https://api.github.com/repos/laughedelic/openapi-generator","forks_url":"https://api.github.com/repos/laughedelic/openapi-generator/forks","keys_url":"https://api.github.com/repos/laughedelic/openapi-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laughedelic/openapi-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laughedelic/openapi-generator/teams","hooks_url":"https://api.github.com/repos/laughedelic/openapi-generator/hooks","issue_events_url":"https://api.github.com/repos/laughedelic/openapi-generator/issues/events{/number}","events_url":"https://api.github.com/repos/laughedelic/openapi-generator/events","assignees_url":"https://api.github.com/repos/laughedelic/openapi-generator/assignees{/user}","branches_url":"https://api.github.com/repos/laughedelic/openapi-generator/branches{/branch}","tags_url":"https://api.github.com/repos/laughedelic/openapi-generator/tags","blobs_url":"https://api.github.com/repos/laughedelic/openapi-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laughedelic/openapi-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laughedelic/openapi-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/laughedelic/openapi-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laughedelic/openapi-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/laughedelic/openapi-generator/languages","stargazers_url":"https://api.github.com/repos/laughedelic/openapi-generator/stargazers","contributors_url":"https://api.github.com/repos/laughedelic/openapi-generator/contributors","subscribers_url":"https://api.github.com/repos/laughedelic/openapi-generator/subscribers","subscription_url":"https://api.github.com/repos/laughedelic/openapi-generator/subscription","commits_url":"https://api.github.com/repos/laughedelic/openapi-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/laughedelic/openapi-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/laughedelic/openapi-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/laughedelic/openapi-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/laughedelic/openapi-generator/contents/{+path}","compare_url":"https://api.github.com/repos/laughedelic/openapi-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laughedelic/openapi-generator/merges","archive_url":"https://api.github.com/repos/laughedelic/openapi-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laughedelic/openapi-generator/downloads","issues_url":"https://api.github.com/repos/laughedelic/openapi-generator/issues{/number}","pulls_url":"https://api.github.com/repos/laughedelic/openapi-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/laughedelic/openapi-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/laughedelic/openapi-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laughedelic/openapi-generator/labels{/name}","releases_url":"https://api.github.com/repos/laughedelic/openapi-generator/releases{/id}","deployments_url":"https://api.github.com/repos/laughedelic/openapi-generator/deployments","created_at":"2018-07-26T15:47:20Z","updated_at":"2018-07-26T15:47:32Z","pushed_at":"2018-07-26T22:10:25Z","git_url":"git://github.com/laughedelic/openapi-generator.git","ssh_url":"git@github.com:laughedelic/openapi-generator.git","clone_url":"https://github.com/laughedelic/openapi-generator.git","svn_url":"https://github.com/laughedelic/openapi-generator","homepage":"https://openapi-generator.tech","size":54642,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenAPITools:master","ref":"master","sha":"534b6b597859997bd06ea2feacafc1a6b97023fc","user":{"login":"OpenAPITools","id":37325267,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzI1MjY3","avatar_url":"https://avatars2.githubusercontent.com/u/37325267?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenAPITools","html_url":"https://github.com/OpenAPITools","followers_url":"https://api.github.com/users/OpenAPITools/followers","following_url":"https://api.github.com/users/OpenAPITools/following{/other_user}","gists_url":"https://api.github.com/users/OpenAPITools/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenAPITools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenAPITools/subscriptions","organizations_url":"https://api.github.com/users/OpenAPITools/orgs","repos_url":"https://api.github.com/users/OpenAPITools/repos","events_url":"https://api.github.com/users/OpenAPITools/events{/privacy}","received_events_url":"https://api.github.com/users/OpenAPITools/received_events","type":"Organization","site_admin":false},"repo":{"id":133134007,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxMzQwMDc=","name":"openapi-generator","full_name":"OpenAPITools/openapi-generator","owner":{"login":"OpenAPITools","id":37325267,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzI1MjY3","avatar_url":"https://avatars2.githubusercontent.com/u/37325267?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenAPITools","html_url":"https://github.com/OpenAPITools","followers_url":"https://api.github.com/users/OpenAPITools/followers","following_url":"https://api.github.com/users/OpenAPITools/following{/other_user}","gists_url":"https://api.github.com/users/OpenAPITools/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenAPITools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenAPITools/subscriptions","organizations_url":"https://api.github.com/users/OpenAPITools/orgs","repos_url":"https://api.github.com/users/OpenAPITools/repos","events_url":"https://api.github.com/users/OpenAPITools/events{/privacy}","received_events_url":"https://api.github.com/users/OpenAPITools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenAPITools/openapi-generator","description":"OpenAPI Generator allows generation of API client libraries (SDK generation), server stubs, documentation and configuration automatically given an OpenAPI Spec (v2, v3)","fork":false,"url":"https://api.github.com/repos/OpenAPITools/openapi-generator","forks_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/forks","keys_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/teams","hooks_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/hooks","issue_events_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/issues/events{/number}","events_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/events","assignees_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/assignees{/user}","branches_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/branches{/branch}","tags_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/tags","blobs_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/languages","stargazers_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/stargazers","contributors_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/contributors","subscribers_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/subscribers","subscription_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/subscription","commits_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/contents/{+path}","compare_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/merges","archive_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/downloads","issues_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/issues{/number}","pulls_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/labels{/name}","releases_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/releases{/id}","deployments_url":"https://api.github.com/repos/OpenAPITools/openapi-generator/deployments","created_at":"2018-05-12T09:57:56Z","updated_at":"2018-07-31T07:56:24Z","pushed_at":"2018-07-31T11:01:55Z","git_url":"git://github.com/OpenAPITools/openapi-generator.git","ssh_url":"git@github.com:OpenAPITools/openapi-generator.git","clone_url":"https://github.com/OpenAPITools/openapi-generator.git","svn_url":"https://github.com/OpenAPITools/openapi-generator","homepage":"https://openapi-generator.tech","size":54825,"stargazers_count":528,"watchers_count":528,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":221,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":139,"open_issues":221,"watchers":528,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/661"},"html":{"href":"https://github.com/OpenAPITools/openapi-generator/pull/661"},"issue":{"href":"https://api.github.com/repos/OpenAPITools/openapi-generator/issues/661"},"comments":{"href":"https://api.github.com/repos/OpenAPITools/openapi-generator/issues/661/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/661/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenAPITools/openapi-generator/pulls/661/commits"},"statuses":{"href":"https://api.github.com/repos/OpenAPITools/openapi-generator/statuses/e4fa4329a71a7538fed5dbfc67c38fe937fd5a1f"}},"author_association":"NONE"}}
{"actor":{"display_login":"trenneman"}}