{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/236290622","pull_request_review_id":178333022,"id":236290622,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjI5MDYyMg==","diff_hunk":"@@ -0,0 +1,97 @@\n+const $ = require('jquery');\n+const _ = require('underscore');\n+\n+/**\n+ * Network Interceptors\n+ *\n+ * Tool to easily intercept network responses in order\n+ * to override or add behaviours on top of the usual ones\n+ */\n+\n+function NetworkResponseInterceptor () {\n+  this._originalAjax = $.ajax;","path":"lib/assets/javascripts/builder/data/backbone/network-interceptors/interceptor.js","position":12,"original_position":12,"commit_id":"71e40e77de46ed86e15982598d189a6fcbc97987","original_commit_id":"71e40e77de46ed86e15982598d189a6fcbc97987","user":{"login":"ivanmalagon","id":1078228,"node_id":"MDQ6VXNlcjEwNzgyMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1078228?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanmalagon","html_url":"https://github.com/ivanmalagon","followers_url":"https://api.github.com/users/ivanmalagon/followers","following_url":"https://api.github.com/users/ivanmalagon/following{/other_user}","gists_url":"https://api.github.com/users/ivanmalagon/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanmalagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanmalagon/subscriptions","organizations_url":"https://api.github.com/users/ivanmalagon/orgs","repos_url":"https://api.github.com/users/ivanmalagon/repos","events_url":"https://api.github.com/users/ivanmalagon/events{/privacy}","received_events_url":"https://api.github.com/users/ivanmalagon/received_events","type":"User","site_admin":false},"body":"Does `$.ajax` points to `XmlHttpRequest` object or is it a wrapper on jQuery?\r\n\r\nI ask this because in the new dashboard we don't use jQuery so we must take it into account to not cause a regression on the new dashboard.","created_at":"2018-11-26T15:07:17Z","updated_at":"2018-11-26T15:14:35Z","html_url":"https://github.com/CartoDB/cartodb/pull/13988#discussion_r236290622","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13988","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/236290622"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/13988#discussion_r236290622"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13988"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13988","id":189722016,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5NzIyMDE2","html_url":"https://github.com/CartoDB/cartodb/pull/13988","diff_url":"https://github.com/CartoDB/cartodb/pull/13988.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/13988.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13988","number":13988,"state":"closed","locked":false,"title":"403 redirections (formerly \"Redirect to change password page when session is expired\")","user":{"login":"jesusbotella","id":4319728,"node_id":"MDQ6VXNlcjQzMTk3Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4319728?v=4","gravatar_id":"","url":"https://api.github.com/users/jesusbotella","html_url":"https://github.com/jesusbotella","followers_url":"https://api.github.com/users/jesusbotella/followers","following_url":"https://api.github.com/users/jesusbotella/following{/other_user}","gists_url":"https://api.github.com/users/jesusbotella/gists{/gist_id}","starred_url":"https://api.github.com/users/jesusbotella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesusbotella/subscriptions","organizations_url":"https://api.github.com/users/jesusbotella/orgs","repos_url":"https://api.github.com/users/jesusbotella/repos","events_url":"https://api.github.com/users/jesusbotella/events{/privacy}","received_events_url":"https://api.github.com/users/jesusbotella/received_events","type":"User","site_admin":false},"body":"This PR adds the ability to redirect users (belonging to an organization or not) to the password change page when their session has expired.\r\n\r\nThe PR implements a general approach to the problem using a network request interceptor, that allows the developer to add any behaviours on top of the request-defined ones. It defines success and error interceptors for all the filtered requests.\r\n\r\nRelated to #13794 \r\nCloses #14435\r\n\r\n","created_at":"2018-05-22T16:27:49Z","updated_at":"2018-11-26T15:14:35Z","closed_at":"2018-11-26T14:48:32Z","merged_at":"2018-11-26T14:48:32Z","merge_commit_sha":"934152d3a4388ee6b245722179a99cdf899be30f","assignee":{"login":"jesusbotella","id":4319728,"node_id":"MDQ6VXNlcjQzMTk3Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4319728?v=4","gravatar_id":"","url":"https://api.github.com/users/jesusbotella","html_url":"https://github.com/jesusbotella","followers_url":"https://api.github.com/users/jesusbotella/followers","following_url":"https://api.github.com/users/jesusbotella/following{/other_user}","gists_url":"https://api.github.com/users/jesusbotella/gists{/gist_id}","starred_url":"https://api.github.com/users/jesusbotella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesusbotella/subscriptions","organizations_url":"https://api.github.com/users/jesusbotella/orgs","repos_url":"https://api.github.com/users/jesusbotella/repos","events_url":"https://api.github.com/users/jesusbotella/events{/privacy}","received_events_url":"https://api.github.com/users/jesusbotella/received_events","type":"User","site_admin":false},"assignees":[{"login":"jesusbotella","id":4319728,"node_id":"MDQ6VXNlcjQzMTk3Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4319728?v=4","gravatar_id":"","url":"https://api.github.com/users/jesusbotella","html_url":"https://github.com/jesusbotella","followers_url":"https://api.github.com/users/jesusbotella/followers","following_url":"https://api.github.com/users/jesusbotella/following{/other_user}","gists_url":"https://api.github.com/users/jesusbotella/gists{/gist_id}","starred_url":"https://api.github.com/users/jesusbotella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesusbotella/subscriptions","organizations_url":"https://api.github.com/users/jesusbotella/orgs","repos_url":"https://api.github.com/users/jesusbotella/repos","events_url":"https://api.github.com/users/jesusbotella/events{/privacy}","received_events_url":"https://api.github.com/users/jesusbotella/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13988/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13988/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13988/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/71e40e77de46ed86e15982598d189a6fcbc97987","head":{"label":"CartoDB:gdpr-network-interceptor","ref":"gdpr-network-interceptor","sha":"71e40e77de46ed86e15982598d189a6fcbc97987","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA5MzU1","name":"cartodb","full_name":"CartoDB/cartodb","private":false,"owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-11-26T14:49:25Z","pushed_at":"2018-11-26T15:11:07Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":384747,"stargazers_count":2003,"watchers_count":2003,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":552,"mirror_url":null,"archived":false,"open_issues_count":370,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":552,"open_issues":370,"watchers":2003,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"2181b09d2a439c0025e61b85f064808bc9094214","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA5MzU1","name":"cartodb","full_name":"CartoDB/cartodb","private":false,"owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-11-26T14:49:25Z","pushed_at":"2018-11-26T15:11:07Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":384747,"stargazers_count":2003,"watchers_count":2003,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":552,"mirror_url":null,"archived":false,"open_issues_count":370,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":552,"open_issues":370,"watchers":2003,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13988"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/13988"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13988"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13988/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13988/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13988/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/71e40e77de46ed86e15982598d189a6fcbc97987"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ivanmalagon"}}