{"action":"created","issue":{"url":"https://api.github.com/repos/miyakogi/pyppeteer/issues/74","repository_url":"https://api.github.com/repos/miyakogi/pyppeteer","labels_url":"https://api.github.com/repos/miyakogi/pyppeteer/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/miyakogi/pyppeteer/issues/74/comments","events_url":"https://api.github.com/repos/miyakogi/pyppeteer/issues/74/events","html_url":"https://github.com/miyakogi/pyppeteer/issues/74","id":320160511,"number":74,"title":"Can we put chromium download into the install process?","user":{"login":"neekey","id":499870,"avatar_url":"https://avatars2.githubusercontent.com/u/499870?v=4","gravatar_id":"","url":"https://api.github.com/users/neekey","html_url":"https://github.com/neekey","followers_url":"https://api.github.com/users/neekey/followers","following_url":"https://api.github.com/users/neekey/following{/other_user}","gists_url":"https://api.github.com/users/neekey/gists{/gist_id}","starred_url":"https://api.github.com/users/neekey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neekey/subscriptions","organizations_url":"https://api.github.com/users/neekey/orgs","repos_url":"https://api.github.com/users/neekey/repos","events_url":"https://api.github.com/users/neekey/events{/privacy}","received_events_url":"https://api.github.com/users/neekey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-04T05:53:21Z","updated_at":"2018-05-04T10:03:42Z","closed_at":null,"author_association":"NONE","body":"Hi thanks for this puppeteer port, works pretty well expect one thing that it downloads the essential chromium during the first launch of the browser.\r\n\r\nThis can be a potential breakpoint for every production service since if the resource is (somehow) not available, the service will break and you will only be able to find out once the service is online.\r\n\r\nI'm currently using pyppeteer in a docker container, and I think if anything is going to break, it better breaks during the build process instead of after deployment."},"comment":{"url":"https://api.github.com/repos/miyakogi/pyppeteer/issues/comments/386556901","html_url":"https://github.com/miyakogi/pyppeteer/issues/74#issuecomment-386556901","issue_url":"https://api.github.com/repos/miyakogi/pyppeteer/issues/74","id":386556901,"user":{"login":"hartym","id":30586,"avatar_url":"https://avatars1.githubusercontent.com/u/30586?v=4","gravatar_id":"","url":"https://api.github.com/users/hartym","html_url":"https://github.com/hartym","followers_url":"https://api.github.com/users/hartym/followers","following_url":"https://api.github.com/users/hartym/following{/other_user}","gists_url":"https://api.github.com/users/hartym/gists{/gist_id}","starred_url":"https://api.github.com/users/hartym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartym/subscriptions","organizations_url":"https://api.github.com/users/hartym/orgs","repos_url":"https://api.github.com/users/hartym/repos","events_url":"https://api.github.com/users/hartym/events{/privacy}","received_events_url":"https://api.github.com/users/hartym/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T10:03:42Z","updated_at":"2018-05-04T10:03:42Z","author_association":"CONTRIBUTOR","body":"As long as we can disable it :D (this is what puppeteer does btw, and the first thing I did after installing it first time was looking for how to disable that).\r\n\r\nBe aware that this feature would require you to redownload chromium while docker-building each time you change even a small dependency. Not sure that's a side effect you'd want.\r\n\r\nI do the explicit download in my dockerfile same way as you suggested (well, not really. I also install pyppeteer separately), because it allows to leverage docker layer cache separately for chromium and python dependencies, which is better imho."}}
{"actor":{"display_login":"hartym"}}