{"action":"created","issue":{"url":"https://api.github.com/repos/mitodl/open-discussions/issues/942","repository_url":"https://api.github.com/repos/mitodl/open-discussions","labels_url":"https://api.github.com/repos/mitodl/open-discussions/issues/942/labels{/name}","comments_url":"https://api.github.com/repos/mitodl/open-discussions/issues/942/comments","events_url":"https://api.github.com/repos/mitodl/open-discussions/issues/942/events","html_url":"https://github.com/mitodl/open-discussions/pull/942","id":342050658,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDQzMDYy","number":942,"title":"make post body optional (frontend)","user":{"login":"aliceriot","id":6207644,"node_id":"MDQ6VXNlcjYyMDc2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6207644?v=4","gravatar_id":"","url":"https://api.github.com/users/aliceriot","html_url":"https://github.com/aliceriot","followers_url":"https://api.github.com/users/aliceriot/followers","following_url":"https://api.github.com/users/aliceriot/following{/other_user}","gists_url":"https://api.github.com/users/aliceriot/gists{/gist_id}","starred_url":"https://api.github.com/users/aliceriot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliceriot/subscriptions","organizations_url":"https://api.github.com/users/aliceriot/orgs","repos_url":"https://api.github.com/users/aliceriot/repos","events_url":"https://api.github.com/users/aliceriot/events{/privacy}","received_events_url":"https://api.github.com/users/aliceriot/received_events","type":"User","site_admin":false},"labels":[{"id":627437808,"node_id":"MDU6TGFiZWw2Mjc0Mzc4MDg=","url":"https://api.github.com/repos/mitodl/open-discussions/labels/Needs%20Review","name":"Needs Review","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":{"login":"noisecapella","id":863262,"node_id":"MDQ6VXNlcjg2MzI2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/863262?v=4","gravatar_id":"","url":"https://api.github.com/users/noisecapella","html_url":"https://github.com/noisecapella","followers_url":"https://api.github.com/users/noisecapella/followers","following_url":"https://api.github.com/users/noisecapella/following{/other_user}","gists_url":"https://api.github.com/users/noisecapella/gists{/gist_id}","starred_url":"https://api.github.com/users/noisecapella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noisecapella/subscriptions","organizations_url":"https://api.github.com/users/noisecapella/orgs","repos_url":"https://api.github.com/users/noisecapella/repos","events_url":"https://api.github.com/users/noisecapella/events{/privacy}","received_events_url":"https://api.github.com/users/noisecapella/received_events","type":"User","site_admin":false},"assignees":[{"login":"noisecapella","id":863262,"node_id":"MDQ6VXNlcjg2MzI2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/863262?v=4","gravatar_id":"","url":"https://api.github.com/users/noisecapella","html_url":"https://github.com/noisecapella","followers_url":"https://api.github.com/users/noisecapella/followers","following_url":"https://api.github.com/users/noisecapella/following{/other_user}","gists_url":"https://api.github.com/users/noisecapella/gists{/gist_id}","starred_url":"https://api.github.com/users/noisecapella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noisecapella/subscriptions","organizations_url":"https://api.github.com/users/noisecapella/orgs","repos_url":"https://api.github.com/users/noisecapella/repos","events_url":"https://api.github.com/users/noisecapella/events{/privacy}","received_events_url":"https://api.github.com/users/noisecapella/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-07-17T19:20:57Z","updated_at":"2018-07-18T16:10:25Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mitodl/open-discussions/pulls/942","html_url":"https://github.com/mitodl/open-discussions/pull/942","diff_url":"https://github.com/mitodl/open-discussions/pull/942.diff","patch_url":"https://github.com/mitodl/open-discussions/pull/942.patch"},"body":"#### What are the relevant tickets?\r\n\r\ncloses #923 \r\ncloses #909 \r\n\r\n#### What's this PR do?\r\n\r\nThis makes the changes necessary on the frontend to allow for empty text posts to go through, and also makes the change to only show the inputs for the allowed post type on channels which are not `LINK_TYPE_ANY`.\r\n\r\n#### How should this be manually tested?\r\n\r\nOn channels which allow all types (or text posts) you should be able to submit an empty post (i.e. just a title) and you should be able to submit a link or text post as normal.\r\n\r\nOn channels which only allow one or the other type of post you should see just the input for the corresponding post type when you go to submit a post. You should not be allowed to submit an 'empty' post (without url) on a link-only subreddit.\r\n\r\nalso, if on a link or text only subreddit, you shouldn't see the little 'x' button that normally appears on the upper right of the post content input.\r\n\r\nIt should handle switching between different subreddits in the create post page relatively well."},"comment":{"url":"https://api.github.com/repos/mitodl/open-discussions/issues/comments/405987344","html_url":"https://github.com/mitodl/open-discussions/pull/942#issuecomment-405987344","issue_url":"https://api.github.com/repos/mitodl/open-discussions/issues/942","id":405987344,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTk4NzM0NA==","user":{"login":"aliceriot","id":6207644,"node_id":"MDQ6VXNlcjYyMDc2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6207644?v=4","gravatar_id":"","url":"https://api.github.com/users/aliceriot","html_url":"https://github.com/aliceriot","followers_url":"https://api.github.com/users/aliceriot/followers","following_url":"https://api.github.com/users/aliceriot/following{/other_user}","gists_url":"https://api.github.com/users/aliceriot/gists{/gist_id}","starred_url":"https://api.github.com/users/aliceriot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliceriot/subscriptions","organizations_url":"https://api.github.com/users/aliceriot/orgs","repos_url":"https://api.github.com/users/aliceriot/repos","events_url":"https://api.github.com/users/aliceriot/events{/privacy}","received_events_url":"https://api.github.com/users/aliceriot/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T16:10:25Z","updated_at":"2018-07-18T16:10:25Z","author_association":"MEMBER","body":"sorry, wrong branch! what i see is this:\r\n\r\n![fasdfff](https://user-images.githubusercontent.com/6207644/42893907-8c9f668e-8a83-11e8-8bdb-0155019f3183.png)\r\n"}}
{"actor":{"display_login":"aliceriot"}}