{"action":"created","issue":{"url":"https://api.github.com/repos/simpleman19/eagleEvents/issues/36","repository_url":"https://api.github.com/repos/simpleman19/eagleEvents","labels_url":"https://api.github.com/repos/simpleman19/eagleEvents/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/simpleman19/eagleEvents/issues/36/comments","events_url":"https://api.github.com/repos/simpleman19/eagleEvents/issues/36/events","html_url":"https://github.com/simpleman19/eagleEvents/pull/36","id":349743968,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzgwNjIx","number":36,"title":"MAY NOT ACTUALLY MERGE IN - Converted evaluate into cython code","user":{"login":"simpleman19","id":14263741,"node_id":"MDQ6VXNlcjE0MjYzNzQx","avatar_url":"https://avatars1.githubusercontent.com/u/14263741?v=4","gravatar_id":"","url":"https://api.github.com/users/simpleman19","html_url":"https://github.com/simpleman19","followers_url":"https://api.github.com/users/simpleman19/followers","following_url":"https://api.github.com/users/simpleman19/following{/other_user}","gists_url":"https://api.github.com/users/simpleman19/gists{/gist_id}","starred_url":"https://api.github.com/users/simpleman19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simpleman19/subscriptions","organizations_url":"https://api.github.com/users/simpleman19/orgs","repos_url":"https://api.github.com/users/simpleman19/repos","events_url":"https://api.github.com/users/simpleman19/events{/privacy}","received_events_url":"https://api.github.com/users/simpleman19/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-11T15:56:08Z","updated_at":"2018-08-11T22:35:36Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/simpleman19/eagleEvents/pulls/36","html_url":"https://github.com/simpleman19/eagleEvents/pull/36","diff_url":"https://github.com/simpleman19/eagleEvents/pull/36.diff","patch_url":"https://github.com/simpleman19/eagleEvents/pull/36.patch"},"body":"We may not actually merge this in but I spent a little time converting the evaluate algo into a Cython algo, appears to speed up 3000 guests by an average of 10-15 seconds.  With this change I am maxing out at like 80ish percent of each of the 2 cores, meaning we are probably bumping up against a memory speed issue at this point.\r\n\r\nThere are more places that could be converted to cython but I am definitely trying to not spend 20 hours converting the algos to cython.\r\n\r\nThis PR is more of an example for everyone, unless we all decide that we should use the extra little performance\r\n\r\n**Not cython is basically C compiled python, compilation happens at import due to the pyximport.install() call.  Can be precompiled but for this project there is no need to precompile the code.\r\n\r\nIf you have problems running this code then you may not have a c compiler installed on your machine"},"comment":{"url":"https://api.github.com/repos/simpleman19/eagleEvents/issues/comments/412305809","html_url":"https://github.com/simpleman19/eagleEvents/pull/36#issuecomment-412305809","issue_url":"https://api.github.com/repos/simpleman19/eagleEvents/issues/36","id":412305809,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjMwNTgwOQ==","user":{"login":"epielemeier","id":18337623,"node_id":"MDQ6VXNlcjE4MzM3NjIz","avatar_url":"https://avatars0.githubusercontent.com/u/18337623?v=4","gravatar_id":"","url":"https://api.github.com/users/epielemeier","html_url":"https://github.com/epielemeier","followers_url":"https://api.github.com/users/epielemeier/followers","following_url":"https://api.github.com/users/epielemeier/following{/other_user}","gists_url":"https://api.github.com/users/epielemeier/gists{/gist_id}","starred_url":"https://api.github.com/users/epielemeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epielemeier/subscriptions","organizations_url":"https://api.github.com/users/epielemeier/orgs","repos_url":"https://api.github.com/users/epielemeier/repos","events_url":"https://api.github.com/users/epielemeier/events{/privacy}","received_events_url":"https://api.github.com/users/epielemeier/received_events","type":"User","site_admin":false},"created_at":"2018-08-11T22:35:36Z","updated_at":"2018-08-11T22:35:36Z","author_association":"COLLABORATOR","body":"So... do you want this reviewed and merged in or not?"}}
{"actor":{"display_login":"epielemeier"}}