{"action":"created","comment":{"url":"https://api.github.com/repos/ekylibre/ekylibre/pulls/comments/241127760","pull_request_review_id":184322114,"id":241127760,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTEyNzc2MA==","diff_hunk":"@@ -175,7 +175,7 @@ class Entity < Ekylibre::Record::Base\n   validates :activity_code, length: { allow_nil: true, maximum: 30 }\n   validates :deliveries_conditions, :number, length: { allow_nil: true, maximum: 60 }\n   validates :iban, iban: true, allow_blank: true\n-  validates :siret_number, siret_format: true, allow_blank: true\n+  validates :siret_number, siret_format: {if: country == 'fr'}, allow_blank: true","path":"app/models/entity.rb","position":5,"original_position":5,"commit_id":"d485ed273a6dace31aafb1050f108a5cca57197a","original_commit_id":"d485ed273a6dace31aafb1050f108a5cca57197a","user":{"login":"Aquaj","id":2871879,"node_id":"MDQ6VXNlcjI4NzE4Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2871879?v=4","gravatar_id":"","url":"https://api.github.com/users/Aquaj","html_url":"https://github.com/Aquaj","followers_url":"https://api.github.com/users/Aquaj/followers","following_url":"https://api.github.com/users/Aquaj/following{/other_user}","gists_url":"https://api.github.com/users/Aquaj/gists{/gist_id}","starred_url":"https://api.github.com/users/Aquaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aquaj/subscriptions","organizations_url":"https://api.github.com/users/Aquaj/orgs","repos_url":"https://api.github.com/users/Aquaj/repos","events_url":"https://api.github.com/users/Aquaj/events{/privacy}","received_events_url":"https://api.github.com/users/Aquaj/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n   validates :siret_number, siret_format: { if: -> (record) { record.country == 'fr' } }, allow_blank: true \r\n```","created_at":"2018-12-12T18:15:58Z","updated_at":"2018-12-12T18:16:03Z","html_url":"https://github.com/ekylibre/ekylibre/pull/2369#discussion_r241127760","pull_request_url":"https://api.github.com/repos/ekylibre/ekylibre/pulls/2369","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ekylibre/ekylibre/pulls/comments/241127760"},"html":{"href":"https://github.com/ekylibre/ekylibre/pull/2369#discussion_r241127760"},"pull_request":{"href":"https://api.github.com/repos/ekylibre/ekylibre/pulls/2369"}}},"pull_request":{"url":"https://api.github.com/repos/ekylibre/ekylibre/pulls/2369","id":238129869,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTI5ODY5","html_url":"https://github.com/ekylibre/ekylibre/pull/2369","diff_url":"https://github.com/ekylibre/ekylibre/pull/2369.diff","patch_url":"https://github.com/ekylibre/ekylibre/pull/2369.patch","issue_url":"https://api.github.com/repos/ekylibre/ekylibre/issues/2369","number":2369,"state":"open","locked":false,"title":"Don't validate siret if company is not french","user":{"login":"piotaixr","id":3706237,"node_id":"MDQ6VXNlcjM3MDYyMzc=","avatar_url":"https://avatars3.githubusercontent.com/u/3706237?v=4","gravatar_id":"","url":"https://api.github.com/users/piotaixr","html_url":"https://github.com/piotaixr","followers_url":"https://api.github.com/users/piotaixr/followers","following_url":"https://api.github.com/users/piotaixr/following{/other_user}","gists_url":"https://api.github.com/users/piotaixr/gists{/gist_id}","starred_url":"https://api.github.com/users/piotaixr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotaixr/subscriptions","organizations_url":"https://api.github.com/users/piotaixr/orgs","repos_url":"https://api.github.com/users/piotaixr/repos","events_url":"https://api.github.com/users/piotaixr/events{/privacy}","received_events_url":"https://api.github.com/users/piotaixr/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-12T18:00:01Z","updated_at":"2018-12-12T18:16:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78715bb6361d540052c61b0b3a1788f2c2f49c98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ekylibre/ekylibre/pulls/2369/commits","review_comments_url":"https://api.github.com/repos/ekylibre/ekylibre/pulls/2369/comments","review_comment_url":"https://api.github.com/repos/ekylibre/ekylibre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ekylibre/ekylibre/issues/2369/comments","statuses_url":"https://api.github.com/repos/ekylibre/ekylibre/statuses/d485ed273a6dace31aafb1050f108a5cca57197a","head":{"label":"ekylibre:debug/dont-validate-siret-if-not-french-company","ref":"debug/dont-validate-siret-if-not-french-company","sha":"d485ed273a6dace31aafb1050f108a5cca57197a","user":{"login":"ekylibre","id":779136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3OTEzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/779136?v=4","gravatar_id":"","url":"https://api.github.com/users/ekylibre","html_url":"https://github.com/ekylibre","followers_url":"https://api.github.com/users/ekylibre/followers","following_url":"https://api.github.com/users/ekylibre/following{/other_user}","gists_url":"https://api.github.com/users/ekylibre/gists{/gist_id}","starred_url":"https://api.github.com/users/ekylibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekylibre/subscriptions","organizations_url":"https://api.github.com/users/ekylibre/orgs","repos_url":"https://api.github.com/users/ekylibre/repos","events_url":"https://api.github.com/users/ekylibre/events{/privacy}","received_events_url":"https://api.github.com/users/ekylibre/received_events","type":"Organization","site_admin":false},"repo":{"id":2196186,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk2MTg2","name":"ekylibre","full_name":"ekylibre/ekylibre","private":false,"owner":{"login":"ekylibre","id":779136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3OTEzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/779136?v=4","gravatar_id":"","url":"https://api.github.com/users/ekylibre","html_url":"https://github.com/ekylibre","followers_url":"https://api.github.com/users/ekylibre/followers","following_url":"https://api.github.com/users/ekylibre/following{/other_user}","gists_url":"https://api.github.com/users/ekylibre/gists{/gist_id}","starred_url":"https://api.github.com/users/ekylibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekylibre/subscriptions","organizations_url":"https://api.github.com/users/ekylibre/orgs","repos_url":"https://api.github.com/users/ekylibre/repos","events_url":"https://api.github.com/users/ekylibre/events{/privacy}","received_events_url":"https://api.github.com/users/ekylibre/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ekylibre/ekylibre","description":"Farm management Information System - Connecting farms to the world","fork":false,"url":"https://api.github.com/repos/ekylibre/ekylibre","forks_url":"https://api.github.com/repos/ekylibre/ekylibre/forks","keys_url":"https://api.github.com/repos/ekylibre/ekylibre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekylibre/ekylibre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekylibre/ekylibre/teams","hooks_url":"https://api.github.com/repos/ekylibre/ekylibre/hooks","issue_events_url":"https://api.github.com/repos/ekylibre/ekylibre/issues/events{/number}","events_url":"https://api.github.com/repos/ekylibre/ekylibre/events","assignees_url":"https://api.github.com/repos/ekylibre/ekylibre/assignees{/user}","branches_url":"https://api.github.com/repos/ekylibre/ekylibre/branches{/branch}","tags_url":"https://api.github.com/repos/ekylibre/ekylibre/tags","blobs_url":"https://api.github.com/repos/ekylibre/ekylibre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekylibre/ekylibre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekylibre/ekylibre/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekylibre/ekylibre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekylibre/ekylibre/statuses/{sha}","languages_url":"https://api.github.com/repos/ekylibre/ekylibre/languages","stargazers_url":"https://api.github.com/repos/ekylibre/ekylibre/stargazers","contributors_url":"https://api.github.com/repos/ekylibre/ekylibre/contributors","subscribers_url":"https://api.github.com/repos/ekylibre/ekylibre/subscribers","subscription_url":"https://api.github.com/repos/ekylibre/ekylibre/subscription","commits_url":"https://api.github.com/repos/ekylibre/ekylibre/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekylibre/ekylibre/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekylibre/ekylibre/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekylibre/ekylibre/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekylibre/ekylibre/contents/{+path}","compare_url":"https://api.github.com/repos/ekylibre/ekylibre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekylibre/ekylibre/merges","archive_url":"https://api.github.com/repos/ekylibre/ekylibre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekylibre/ekylibre/downloads","issues_url":"https://api.github.com/repos/ekylibre/ekylibre/issues{/number}","pulls_url":"https://api.github.com/repos/ekylibre/ekylibre/pulls{/number}","milestones_url":"https://api.github.com/repos/ekylibre/ekylibre/milestones{/number}","notifications_url":"https://api.github.com/repos/ekylibre/ekylibre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekylibre/ekylibre/labels{/name}","releases_url":"https://api.github.com/repos/ekylibre/ekylibre/releases{/id}","deployments_url":"https://api.github.com/repos/ekylibre/ekylibre/deployments","created_at":"2011-08-12T09:03:48Z","updated_at":"2018-12-05T08:54:07Z","pushed_at":"2018-12-12T18:02:23Z","git_url":"git://github.com/ekylibre/ekylibre.git","ssh_url":"git@github.com:ekylibre/ekylibre.git","clone_url":"https://github.com/ekylibre/ekylibre.git","svn_url":"https://github.com/ekylibre/ekylibre","homepage":"https://ekylibre.com","size":235263,"stargazers_count":169,"watchers_count":169,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":330,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":89,"open_issues":330,"watchers":169,"default_branch":"master"}},"base":{"label":"ekylibre:develop/accountancy-2018","ref":"develop/accountancy-2018","sha":"7e69a16a0e402f3ea4b7397997a75a2e9672f62b","user":{"login":"ekylibre","id":779136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3OTEzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/779136?v=4","gravatar_id":"","url":"https://api.github.com/users/ekylibre","html_url":"https://github.com/ekylibre","followers_url":"https://api.github.com/users/ekylibre/followers","following_url":"https://api.github.com/users/ekylibre/following{/other_user}","gists_url":"https://api.github.com/users/ekylibre/gists{/gist_id}","starred_url":"https://api.github.com/users/ekylibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekylibre/subscriptions","organizations_url":"https://api.github.com/users/ekylibre/orgs","repos_url":"https://api.github.com/users/ekylibre/repos","events_url":"https://api.github.com/users/ekylibre/events{/privacy}","received_events_url":"https://api.github.com/users/ekylibre/received_events","type":"Organization","site_admin":false},"repo":{"id":2196186,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk2MTg2","name":"ekylibre","full_name":"ekylibre/ekylibre","private":false,"owner":{"login":"ekylibre","id":779136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3OTEzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/779136?v=4","gravatar_id":"","url":"https://api.github.com/users/ekylibre","html_url":"https://github.com/ekylibre","followers_url":"https://api.github.com/users/ekylibre/followers","following_url":"https://api.github.com/users/ekylibre/following{/other_user}","gists_url":"https://api.github.com/users/ekylibre/gists{/gist_id}","starred_url":"https://api.github.com/users/ekylibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekylibre/subscriptions","organizations_url":"https://api.github.com/users/ekylibre/orgs","repos_url":"https://api.github.com/users/ekylibre/repos","events_url":"https://api.github.com/users/ekylibre/events{/privacy}","received_events_url":"https://api.github.com/users/ekylibre/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ekylibre/ekylibre","description":"Farm management Information System - Connecting farms to the world","fork":false,"url":"https://api.github.com/repos/ekylibre/ekylibre","forks_url":"https://api.github.com/repos/ekylibre/ekylibre/forks","keys_url":"https://api.github.com/repos/ekylibre/ekylibre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekylibre/ekylibre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekylibre/ekylibre/teams","hooks_url":"https://api.github.com/repos/ekylibre/ekylibre/hooks","issue_events_url":"https://api.github.com/repos/ekylibre/ekylibre/issues/events{/number}","events_url":"https://api.github.com/repos/ekylibre/ekylibre/events","assignees_url":"https://api.github.com/repos/ekylibre/ekylibre/assignees{/user}","branches_url":"https://api.github.com/repos/ekylibre/ekylibre/branches{/branch}","tags_url":"https://api.github.com/repos/ekylibre/ekylibre/tags","blobs_url":"https://api.github.com/repos/ekylibre/ekylibre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekylibre/ekylibre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekylibre/ekylibre/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekylibre/ekylibre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekylibre/ekylibre/statuses/{sha}","languages_url":"https://api.github.com/repos/ekylibre/ekylibre/languages","stargazers_url":"https://api.github.com/repos/ekylibre/ekylibre/stargazers","contributors_url":"https://api.github.com/repos/ekylibre/ekylibre/contributors","subscribers_url":"https://api.github.com/repos/ekylibre/ekylibre/subscribers","subscription_url":"https://api.github.com/repos/ekylibre/ekylibre/subscription","commits_url":"https://api.github.com/repos/ekylibre/ekylibre/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekylibre/ekylibre/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekylibre/ekylibre/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekylibre/ekylibre/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekylibre/ekylibre/contents/{+path}","compare_url":"https://api.github.com/repos/ekylibre/ekylibre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekylibre/ekylibre/merges","archive_url":"https://api.github.com/repos/ekylibre/ekylibre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekylibre/ekylibre/downloads","issues_url":"https://api.github.com/repos/ekylibre/ekylibre/issues{/number}","pulls_url":"https://api.github.com/repos/ekylibre/ekylibre/pulls{/number}","milestones_url":"https://api.github.com/repos/ekylibre/ekylibre/milestones{/number}","notifications_url":"https://api.github.com/repos/ekylibre/ekylibre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekylibre/ekylibre/labels{/name}","releases_url":"https://api.github.com/repos/ekylibre/ekylibre/releases{/id}","deployments_url":"https://api.github.com/repos/ekylibre/ekylibre/deployments","created_at":"2011-08-12T09:03:48Z","updated_at":"2018-12-05T08:54:07Z","pushed_at":"2018-12-12T18:02:23Z","git_url":"git://github.com/ekylibre/ekylibre.git","ssh_url":"git@github.com:ekylibre/ekylibre.git","clone_url":"https://github.com/ekylibre/ekylibre.git","svn_url":"https://github.com/ekylibre/ekylibre","homepage":"https://ekylibre.com","size":235263,"stargazers_count":169,"watchers_count":169,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":330,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":89,"open_issues":330,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ekylibre/ekylibre/pulls/2369"},"html":{"href":"https://github.com/ekylibre/ekylibre/pull/2369"},"issue":{"href":"https://api.github.com/repos/ekylibre/ekylibre/issues/2369"},"comments":{"href":"https://api.github.com/repos/ekylibre/ekylibre/issues/2369/comments"},"review_comments":{"href":"https://api.github.com/repos/ekylibre/ekylibre/pulls/2369/comments"},"review_comment":{"href":"https://api.github.com/repos/ekylibre/ekylibre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ekylibre/ekylibre/pulls/2369/commits"},"statuses":{"href":"https://api.github.com/repos/ekylibre/ekylibre/statuses/d485ed273a6dace31aafb1050f108a5cca57197a"}},"author_association":"NONE"}}
{"actor":{"display_login":"Aquaj"}}