{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments/210781232","pull_request_review_id":147070854,"id":210781232,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDc4MTIzMg==","diff_hunk":"@@ -453,18 +453,26 @@ import sys\n             try {\n                 using (var dumpWriter = new MiniDumpWriter(p)) {\n                     Thread.Sleep(1500);\n+                    Assert.IsFalse(p.HasExited);\n \n-                    var attached = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);\n-                    var bpHit = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);\n+                    var attached = new TaskCompletionSource<bool>();","path":"Python/Tests/DebuggerTests/AttachTests.cs","position":26,"original_position":26,"commit_id":"7d1fd077713df518c7f209948fe4ae09ce7cee15","original_commit_id":"7d1fd077713df518c7f209948fe4ae09ce7cee15","user":{"login":"AlexanderSher","id":8933858,"node_id":"MDQ6VXNlcjg5MzM4NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/8933858?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexanderSher","html_url":"https://github.com/AlexanderSher","followers_url":"https://api.github.com/users/AlexanderSher/followers","following_url":"https://api.github.com/users/AlexanderSher/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderSher/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderSher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderSher/subscriptions","organizations_url":"https://api.github.com/users/AlexanderSher/orgs","repos_url":"https://api.github.com/users/AlexanderSher/repos","events_url":"https://api.github.com/users/AlexanderSher/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderSher/received_events","type":"User","site_admin":false},"body":"We have a thing called `EventTaskSource`. It is in tests now, but can be moved here. Its purpose is to safely await for the event to fire once after subscription with continuation on the thread the event has fired. ","created_at":"2018-08-17T00:54:56Z","updated_at":"2018-08-17T00:54:56Z","html_url":"https://github.com/Microsoft/PTVS/pull/4657#discussion_r210781232","pull_request_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/4657","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments/210781232"},"html":{"href":"https://github.com/Microsoft/PTVS/pull/4657#discussion_r210781232"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/4657"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/PTVS/pulls/4657","id":209012272,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDEyMjcy","html_url":"https://github.com/Microsoft/PTVS/pull/4657","diff_url":"https://github.com/Microsoft/PTVS/pull/4657.diff","patch_url":"https://github.com/Microsoft/PTVS/pull/4657.patch","issue_url":"https://api.github.com/repos/Microsoft/PTVS/issues/4657","number":4657,"state":"open","locked":false,"title":"Fixes for debug-attach tests","user":{"login":"zooba","id":1693688,"node_id":"MDQ6VXNlcjE2OTM2ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1693688?v=4","gravatar_id":"","url":"https://api.github.com/users/zooba","html_url":"https://github.com/zooba","followers_url":"https://api.github.com/users/zooba/followers","following_url":"https://api.github.com/users/zooba/following{/other_user}","gists_url":"https://api.github.com/users/zooba/gists{/gist_id}","starred_url":"https://api.github.com/users/zooba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooba/subscriptions","organizations_url":"https://api.github.com/users/zooba/orgs","repos_url":"https://api.github.com/users/zooba/repos","events_url":"https://api.github.com/users/zooba/events{/privacy}","received_events_url":"https://api.github.com/users/zooba/received_events","type":"User","site_admin":false},"body":"Potentially fixes tests expecting 16.0 compiler.\r\nFixes debug messages not marshalling to correct thread.\r\nImproves logging for debug tests.","created_at":"2018-08-16T23:41:35Z","updated_at":"2018-08-17T00:54:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6474e19c6985e6c8d89ccbca4ca30b99b3baa6b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/4657/commits","review_comments_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/4657/comments","review_comment_url":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/PTVS/issues/4657/comments","statuses_url":"https://api.github.com/repos/Microsoft/PTVS/statuses/7d1fd077713df518c7f209948fe4ae09ce7cee15","head":{"label":"zooba:debug-test-fix","ref":"debug-test-fix","sha":"7d1fd077713df518c7f209948fe4ae09ce7cee15","user":{"login":"zooba","id":1693688,"node_id":"MDQ6VXNlcjE2OTM2ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1693688?v=4","gravatar_id":"","url":"https://api.github.com/users/zooba","html_url":"https://github.com/zooba","followers_url":"https://api.github.com/users/zooba/followers","following_url":"https://api.github.com/users/zooba/following{/other_user}","gists_url":"https://api.github.com/users/zooba/gists{/gist_id}","starred_url":"https://api.github.com/users/zooba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooba/subscriptions","organizations_url":"https://api.github.com/users/zooba/orgs","repos_url":"https://api.github.com/users/zooba/repos","events_url":"https://api.github.com/users/zooba/events{/privacy}","received_events_url":"https://api.github.com/users/zooba/received_events","type":"User","site_admin":false},"repo":{"id":42481352,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQ4MTM1Mg==","name":"PTVS","full_name":"zooba/PTVS","owner":{"login":"zooba","id":1693688,"node_id":"MDQ6VXNlcjE2OTM2ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1693688?v=4","gravatar_id":"","url":"https://api.github.com/users/zooba","html_url":"https://github.com/zooba","followers_url":"https://api.github.com/users/zooba/followers","following_url":"https://api.github.com/users/zooba/following{/other_user}","gists_url":"https://api.github.com/users/zooba/gists{/gist_id}","starred_url":"https://api.github.com/users/zooba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooba/subscriptions","organizations_url":"https://api.github.com/users/zooba/orgs","repos_url":"https://api.github.com/users/zooba/repos","events_url":"https://api.github.com/users/zooba/events{/privacy}","received_events_url":"https://api.github.com/users/zooba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zooba/PTVS","description":"Python Tools for Visual Studio","fork":true,"url":"https://api.github.com/repos/zooba/PTVS","forks_url":"https://api.github.com/repos/zooba/PTVS/forks","keys_url":"https://api.github.com/repos/zooba/PTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zooba/PTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zooba/PTVS/teams","hooks_url":"https://api.github.com/repos/zooba/PTVS/hooks","issue_events_url":"https://api.github.com/repos/zooba/PTVS/issues/events{/number}","events_url":"https://api.github.com/repos/zooba/PTVS/events","assignees_url":"https://api.github.com/repos/zooba/PTVS/assignees{/user}","branches_url":"https://api.github.com/repos/zooba/PTVS/branches{/branch}","tags_url":"https://api.github.com/repos/zooba/PTVS/tags","blobs_url":"https://api.github.com/repos/zooba/PTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zooba/PTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zooba/PTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/zooba/PTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zooba/PTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/zooba/PTVS/languages","stargazers_url":"https://api.github.com/repos/zooba/PTVS/stargazers","contributors_url":"https://api.github.com/repos/zooba/PTVS/contributors","subscribers_url":"https://api.github.com/repos/zooba/PTVS/subscribers","subscription_url":"https://api.github.com/repos/zooba/PTVS/subscription","commits_url":"https://api.github.com/repos/zooba/PTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/zooba/PTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/zooba/PTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/zooba/PTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/zooba/PTVS/contents/{+path}","compare_url":"https://api.github.com/repos/zooba/PTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zooba/PTVS/merges","archive_url":"https://api.github.com/repos/zooba/PTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zooba/PTVS/downloads","issues_url":"https://api.github.com/repos/zooba/PTVS/issues{/number}","pulls_url":"https://api.github.com/repos/zooba/PTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/zooba/PTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/zooba/PTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zooba/PTVS/labels{/name}","releases_url":"https://api.github.com/repos/zooba/PTVS/releases{/id}","deployments_url":"https://api.github.com/repos/zooba/PTVS/deployments","created_at":"2015-09-14T22:47:51Z","updated_at":"2018-08-16T23:41:00Z","pushed_at":"2018-08-16T23:40:55Z","git_url":"git://github.com/zooba/PTVS.git","ssh_url":"git@github.com:zooba/PTVS.git","clone_url":"https://github.com/zooba/PTVS.git","svn_url":"https://github.com/zooba/PTVS","homepage":"https://microsoft.github.io/PTVS","size":205984,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"08b251edd1e353f100d2e85fdaa979d6132a7fea","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32487763,"node_id":"MDEwOlJlcG9zaXRvcnkzMjQ4Nzc2Mw==","name":"PTVS","full_name":"Microsoft/PTVS","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/PTVS","description":"Python Tools for Visual Studio","fork":false,"url":"https://api.github.com/repos/Microsoft/PTVS","forks_url":"https://api.github.com/repos/Microsoft/PTVS/forks","keys_url":"https://api.github.com/repos/Microsoft/PTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/PTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/PTVS/teams","hooks_url":"https://api.github.com/repos/Microsoft/PTVS/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/PTVS/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/PTVS/events","assignees_url":"https://api.github.com/repos/Microsoft/PTVS/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/PTVS/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/PTVS/tags","blobs_url":"https://api.github.com/repos/Microsoft/PTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/PTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/PTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/PTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/PTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/PTVS/languages","stargazers_url":"https://api.github.com/repos/Microsoft/PTVS/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/PTVS/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/PTVS/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/PTVS/subscription","commits_url":"https://api.github.com/repos/Microsoft/PTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/PTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/PTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/PTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/PTVS/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/PTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/PTVS/merges","archive_url":"https://api.github.com/repos/Microsoft/PTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/PTVS/downloads","issues_url":"https://api.github.com/repos/Microsoft/PTVS/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/PTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/PTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/PTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/PTVS/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/PTVS/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/PTVS/deployments","created_at":"2015-03-18T22:30:53Z","updated_at":"2018-08-16T16:34:09Z","pushed_at":"2018-08-16T23:41:36Z","git_url":"git://github.com/Microsoft/PTVS.git","ssh_url":"git@github.com:Microsoft/PTVS.git","clone_url":"https://github.com/Microsoft/PTVS.git","svn_url":"https://github.com/Microsoft/PTVS","homepage":"https://aka.ms/PTVS","size":204406,"stargazers_count":2022,"watchers_count":2022,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":535,"mirror_url":null,"archived":false,"open_issues_count":601,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":535,"open_issues":601,"watchers":2022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/4657"},"html":{"href":"https://github.com/Microsoft/PTVS/pull/4657"},"issue":{"href":"https://api.github.com/repos/Microsoft/PTVS/issues/4657"},"comments":{"href":"https://api.github.com/repos/Microsoft/PTVS/issues/4657/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/4657/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/PTVS/pulls/4657/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/PTVS/statuses/7d1fd077713df518c7f209948fe4ae09ce7cee15"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AlexanderSher"}}