{"action":"created","comment":{"url":"https://api.github.com/repos/pravega/pravega/pulls/comments/209671657","pull_request_review_id":145729932,"id":209671657,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTY3MTY1Nw==","diff_hunk":"@@ -20,6 +20,7 @@ PRAVEGA_PATH=${PRAVEGA_PATH:-\"pravega\"}\n PRAVEGA_CLUSTER_NAME=${PRAVEGA_CLUSTER_NAME:-\"pravega-cluster\"}\n BK_CLUSTER_NAME=${BK_CLUSTER_NAME:-\"bookkeeper\"}\n BK_AUTORECOVERY=${BK_AUTORECOVERY:-\"false\"}\n+BK_useHostNameAsBookieID=${BK_useHostNameAsBookieID:-\"false\"}","path":"docker/bookkeeper/entrypoint.sh","position":4,"original_position":4,"commit_id":"4f00ffb5809f33e6ce3e411f5d98c04e6a839a3f","original_commit_id":"4f00ffb5809f33e6ce3e411f5d98c04e6a839a3f","user":{"login":"arvindkandhare","id":2305381,"node_id":"MDQ6VXNlcjIzMDUzODE=","avatar_url":"https://avatars1.githubusercontent.com/u/2305381?v=4","gravatar_id":"","url":"https://api.github.com/users/arvindkandhare","html_url":"https://github.com/arvindkandhare","followers_url":"https://api.github.com/users/arvindkandhare/followers","following_url":"https://api.github.com/users/arvindkandhare/following{/other_user}","gists_url":"https://api.github.com/users/arvindkandhare/gists{/gist_id}","starred_url":"https://api.github.com/users/arvindkandhare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvindkandhare/subscriptions","organizations_url":"https://api.github.com/users/arvindkandhare/orgs","repos_url":"https://api.github.com/users/arvindkandhare/repos","events_url":"https://api.github.com/users/arvindkandhare/events{/privacy}","received_events_url":"https://api.github.com/users/arvindkandhare/received_events","type":"User","site_admin":false},"body":"This is set to false by default where as the PR says. Please update the PR/the default value here:\r\n> Add useHostNameAsBookieID=true to bk_server.conf to replace hostname with IP address so that bookie pods can process failover properly.","created_at":"2018-08-13T16:18:30Z","updated_at":"2018-08-13T16:19:50Z","html_url":"https://github.com/pravega/pravega/pull/2833#discussion_r209671657","pull_request_url":"https://api.github.com/repos/pravega/pravega/pulls/2833","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments/209671657"},"html":{"href":"https://github.com/pravega/pravega/pull/2833#discussion_r209671657"},"pull_request":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2833"}}},"pull_request":{"url":"https://api.github.com/repos/pravega/pravega/pulls/2833","id":208003411,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDAzNDEx","html_url":"https://github.com/pravega/pravega/pull/2833","diff_url":"https://github.com/pravega/pravega/pull/2833.diff","patch_url":"https://github.com/pravega/pravega/pull/2833.patch","issue_url":"https://api.github.com/repos/pravega/pravega/issues/2833","number":2833,"state":"open","locked":false,"title":"Issue 2832: Add useHostNameAsBookieID to bk_server.conf","user":{"login":"mcgG","id":5621528,"node_id":"MDQ6VXNlcjU2MjE1Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/5621528?v=4","gravatar_id":"","url":"https://api.github.com/users/mcgG","html_url":"https://github.com/mcgG","followers_url":"https://api.github.com/users/mcgG/followers","following_url":"https://api.github.com/users/mcgG/following{/other_user}","gists_url":"https://api.github.com/users/mcgG/gists{/gist_id}","starred_url":"https://api.github.com/users/mcgG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcgG/subscriptions","organizations_url":"https://api.github.com/users/mcgG/orgs","repos_url":"https://api.github.com/users/mcgG/repos","events_url":"https://api.github.com/users/mcgG/events{/privacy}","received_events_url":"https://api.github.com/users/mcgG/received_events","type":"User","site_admin":false},"body":"**Change log description**  \r\n* Stable BookieID is needed when running `sts` bookies.\r\n* Modified bookkeeper's entrypoint\r\n\r\n**Purpose of the change**  \r\nFix #2832 \r\n\r\n**What the code does**  \r\n* Add useHostNameAsBookieID=true to `bk_server.conf` to replace hostname with IP address so that bookie pods can process failover properly.\r\n\r\n**How to verify it**  \r\nDeployment passed\r\n","created_at":"2018-08-13T14:50:06Z","updated_at":"2018-08-13T16:19:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52239d125a91583d313da13de5d3a6f93ff6a9be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pravega/pravega/pulls/2833/commits","review_comments_url":"https://api.github.com/repos/pravega/pravega/pulls/2833/comments","review_comment_url":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pravega/pravega/issues/2833/comments","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/4f00ffb5809f33e6ce3e411f5d98c04e6a839a3f","head":{"label":"mcgG:master","ref":"master","sha":"4f00ffb5809f33e6ce3e411f5d98c04e6a839a3f","user":{"login":"mcgG","id":5621528,"node_id":"MDQ6VXNlcjU2MjE1Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/5621528?v=4","gravatar_id":"","url":"https://api.github.com/users/mcgG","html_url":"https://github.com/mcgG","followers_url":"https://api.github.com/users/mcgG/followers","following_url":"https://api.github.com/users/mcgG/following{/other_user}","gists_url":"https://api.github.com/users/mcgG/gists{/gist_id}","starred_url":"https://api.github.com/users/mcgG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcgG/subscriptions","organizations_url":"https://api.github.com/users/mcgG/orgs","repos_url":"https://api.github.com/users/mcgG/repos","events_url":"https://api.github.com/users/mcgG/events{/privacy}","received_events_url":"https://api.github.com/users/mcgG/received_events","type":"User","site_admin":false},"repo":{"id":138127151,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxMjcxNTE=","name":"pravega","full_name":"mcgG/pravega","owner":{"login":"mcgG","id":5621528,"node_id":"MDQ6VXNlcjU2MjE1Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/5621528?v=4","gravatar_id":"","url":"https://api.github.com/users/mcgG","html_url":"https://github.com/mcgG","followers_url":"https://api.github.com/users/mcgG/followers","following_url":"https://api.github.com/users/mcgG/following{/other_user}","gists_url":"https://api.github.com/users/mcgG/gists{/gist_id}","starred_url":"https://api.github.com/users/mcgG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcgG/subscriptions","organizations_url":"https://api.github.com/users/mcgG/orgs","repos_url":"https://api.github.com/users/mcgG/repos","events_url":"https://api.github.com/users/mcgG/events{/privacy}","received_events_url":"https://api.github.com/users/mcgG/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcgG/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":true,"url":"https://api.github.com/repos/mcgG/pravega","forks_url":"https://api.github.com/repos/mcgG/pravega/forks","keys_url":"https://api.github.com/repos/mcgG/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcgG/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcgG/pravega/teams","hooks_url":"https://api.github.com/repos/mcgG/pravega/hooks","issue_events_url":"https://api.github.com/repos/mcgG/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/mcgG/pravega/events","assignees_url":"https://api.github.com/repos/mcgG/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/mcgG/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/mcgG/pravega/tags","blobs_url":"https://api.github.com/repos/mcgG/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcgG/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcgG/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcgG/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcgG/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/mcgG/pravega/languages","stargazers_url":"https://api.github.com/repos/mcgG/pravega/stargazers","contributors_url":"https://api.github.com/repos/mcgG/pravega/contributors","subscribers_url":"https://api.github.com/repos/mcgG/pravega/subscribers","subscription_url":"https://api.github.com/repos/mcgG/pravega/subscription","commits_url":"https://api.github.com/repos/mcgG/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcgG/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcgG/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcgG/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcgG/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/mcgG/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcgG/pravega/merges","archive_url":"https://api.github.com/repos/mcgG/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcgG/pravega/downloads","issues_url":"https://api.github.com/repos/mcgG/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/mcgG/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/mcgG/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/mcgG/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcgG/pravega/labels{/name}","releases_url":"https://api.github.com/repos/mcgG/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/mcgG/pravega/deployments","created_at":"2018-06-21T06:13:36Z","updated_at":"2018-08-13T14:51:44Z","pushed_at":"2018-08-13T14:51:42Z","git_url":"git://github.com/mcgG/pravega.git","ssh_url":"git@github.com:mcgG/pravega.git","clone_url":"https://github.com/mcgG/pravega.git","svn_url":"https://github.com/mcgG/pravega","homepage":"http://pravega.io","size":26153,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pravega:master","ref":"master","sha":"27de3eda7178feaf7a6678816f54dbfa72ae939f","user":{"login":"pravega","id":25698199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njk4MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"repo":{"id":63096822,"node_id":"MDEwOlJlcG9zaXRvcnk2MzA5NjgyMg==","name":"pravega","full_name":"pravega/pravega","owner":{"login":"pravega","id":25698199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njk4MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pravega/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":false,"url":"https://api.github.com/repos/pravega/pravega","forks_url":"https://api.github.com/repos/pravega/pravega/forks","keys_url":"https://api.github.com/repos/pravega/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pravega/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pravega/pravega/teams","hooks_url":"https://api.github.com/repos/pravega/pravega/hooks","issue_events_url":"https://api.github.com/repos/pravega/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/pravega/pravega/events","assignees_url":"https://api.github.com/repos/pravega/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/pravega/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/pravega/pravega/tags","blobs_url":"https://api.github.com/repos/pravega/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pravega/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pravega/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/pravega/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/pravega/pravega/languages","stargazers_url":"https://api.github.com/repos/pravega/pravega/stargazers","contributors_url":"https://api.github.com/repos/pravega/pravega/contributors","subscribers_url":"https://api.github.com/repos/pravega/pravega/subscribers","subscription_url":"https://api.github.com/repos/pravega/pravega/subscription","commits_url":"https://api.github.com/repos/pravega/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/pravega/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/pravega/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/pravega/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/pravega/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/pravega/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pravega/pravega/merges","archive_url":"https://api.github.com/repos/pravega/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pravega/pravega/downloads","issues_url":"https://api.github.com/repos/pravega/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/pravega/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/pravega/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/pravega/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pravega/pravega/labels{/name}","releases_url":"https://api.github.com/repos/pravega/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/pravega/pravega/deployments","created_at":"2016-07-11T19:41:03Z","updated_at":"2018-08-10T07:23:02Z","pushed_at":"2018-08-13T14:51:43Z","git_url":"git://github.com/pravega/pravega.git","ssh_url":"git@github.com:pravega/pravega.git","clone_url":"https://github.com/pravega/pravega.git","svn_url":"https://github.com/pravega/pravega","homepage":"http://pravega.io","size":26312,"stargazers_count":235,"watchers_count":235,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":351,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":83,"open_issues":351,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2833"},"html":{"href":"https://github.com/pravega/pravega/pull/2833"},"issue":{"href":"https://api.github.com/repos/pravega/pravega/issues/2833"},"comments":{"href":"https://api.github.com/repos/pravega/pravega/issues/2833/comments"},"review_comments":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2833/comments"},"review_comment":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2833/commits"},"statuses":{"href":"https://api.github.com/repos/pravega/pravega/statuses/4f00ffb5809f33e6ce3e411f5d98c04e6a839a3f"}},"author_association":"NONE"}}
{"actor":{"display_login":"arvindkandhare"}}