{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20945","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20945/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20945/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20945/events","html_url":"https://github.com/nodejs/node/pull/20945","id":326224682,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMzY5MDc2","number":20945,"title":"test: add test cases for setUnrefTimeout.","user":{"login":"kakts","id":11757354,"node_id":"MDQ6VXNlcjExNzU3MzU0","avatar_url":"https://avatars2.githubusercontent.com/u/11757354?v=4","gravatar_id":"","url":"https://api.github.com/users/kakts","html_url":"https://github.com/kakts","followers_url":"https://api.github.com/users/kakts/followers","following_url":"https://api.github.com/users/kakts/following{/other_user}","gists_url":"https://api.github.com/users/kakts/gists{/gist_id}","starred_url":"https://api.github.com/users/kakts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kakts/subscriptions","organizations_url":"https://api.github.com/users/kakts/orgs","repos_url":"https://api.github.com/users/kakts/repos","events_url":"https://api.github.com/users/kakts/events{/privacy}","received_events_url":"https://api.github.com/users/kakts/received_events","type":"User","site_admin":false},"labels":[{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false},{"id":155435976,"node_id":"MDU6TGFiZWwxNTU0MzU5NzY=","url":"https://api.github.com/repos/nodejs/node/labels/timers","name":"timers","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-05-24T17:45:44Z","updated_at":"2018-11-18T12:06:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20945","html_url":"https://github.com/nodejs/node/pull/20945","diff_url":"https://github.com/nodejs/node/pull/20945.diff","patch_url":"https://github.com/nodejs/node/pull/20945.patch"},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n## Summary\r\nAdded some test cases for setUnrefTimeout in lib/internal/timers.js\r\n\r\nThis PR improves the test coverage of it.\r\nhttps://coverage.nodejs.org/coverage-9a02de7084e3f3c9/root/internal/timers.js.html#L92\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/439687885","html_url":"https://github.com/nodejs/node/pull/20945#issuecomment-439687885","issue_url":"https://api.github.com/repos/nodejs/node/issues/20945","id":439687885,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTY4Nzg4NQ==","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"created_at":"2018-11-18T12:06:14Z","updated_at":"2018-11-18T12:06:14Z","author_association":"MEMBER","body":"@kakts no need. It's easily fixable while landing the commit."}}
{"actor":{"display_login":"refack"}}