{"action":"opened","issue":{"url":"https://api.github.com/repos/andrea-magni/MARS/issues/33","repository_url":"https://api.github.com/repos/andrea-magni/MARS","labels_url":"https://api.github.com/repos/andrea-magni/MARS/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/andrea-magni/MARS/issues/33/comments","events_url":"https://api.github.com/repos/andrea-magni/MARS/issues/33/events","html_url":"https://github.com/andrea-magni/MARS/issues/33","id":378662070,"node_id":"MDU6SXNzdWUzNzg2NjIwNzA=","number":33,"title":"Discussion about README.md","user":{"login":"bogdanpolak","id":20039485,"node_id":"MDQ6VXNlcjIwMDM5NDg1","avatar_url":"https://avatars3.githubusercontent.com/u/20039485?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdanpolak","html_url":"https://github.com/bogdanpolak","followers_url":"https://api.github.com/users/bogdanpolak/followers","following_url":"https://api.github.com/users/bogdanpolak/following{/other_user}","gists_url":"https://api.github.com/users/bogdanpolak/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanpolak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanpolak/subscriptions","organizations_url":"https://api.github.com/users/bogdanpolak/orgs","repos_url":"https://api.github.com/users/bogdanpolak/repos","events_url":"https://api.github.com/users/bogdanpolak/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanpolak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-08T10:12:19Z","updated_at":"2018-11-08T10:12:19Z","closed_at":null,"author_association":"NONE","body":"1) There are two copies of the README.md - should be synchronized\r\n2) Map of the functionalities and concepts is totally unreadable - especially in the PNG format, but with PDF is still difficult to read, you have to zoom in a lot. Maybe change it into the hierarchical list will be better\r\n3) MARS image is beautiful, but it uses so much place important for ket message. Maybe you can consider to move it to the bottom of the file\r\n4) In the JavaScript libraries are important source code examples in the README. Something like that:\r\n```pascal\r\ntype\r\n  [Path('helloworld')]\r\n  TSampleResource = class\r\n  public\r\n    [GET, Produces(TMediaType.TEXT_PLAIN)]\r\n    function SayHelloWorld: string;\r\n  end;\r\n\r\nfunction TSampleResource.SayHelloWorld: string;\r\nbegin\r\n  Result := 'Hello World!';\r\nend;\r\n\r\nprocedure Button1Click(Sender: TObject);\r\nbegin\r\n  TMARSResourceRegistry.Instance.RegisterResource<TSampleResource>;\r\n  FEngine := TMARSEngine.Create;\r\n  FEngine.BasePath := '/rest';\r\n  FEngine.Port := 8080;\r\n  FEngine.AddApplication('DefaultApp', '/default', ['ServerResources. TSampleResource']);\r\n  FServer := TMARShttpServerIndy.Create(FEngine);\r\n  FServer.Active := True;\r\nend;\r\n\r\nprocedure TMainForm.FormClose(Sender: TObject; var Action: TCloseAction);\r\nbegin\r\n  if Assigned(FServer) then\r\n  begin\r\n    FServer.Active := False;\r\n    FreeAndNil(FServer);\r\n    FreeAndNil(FEngine);\r\n  end;\r\nend;\r\n\r\n```"}}
{"actor":{"display_login":"bogdanpolak"}}