{"push_id":2618469611,"size":8,"distinct_size":8,"ref":"refs/heads/fix-csi-interlaced.3","head":"57f4e29c35938545a8240f78b7cb63cd184b0bad","before":"37426e4e8dac3043bce3c5ebd7454021fdc59fb1","commits":[{"sha":"25b694e66e908053bf5663ad0ac101f1b557fd05","author":{"name":"Steve Longerbeam","email":"8c188e05ba274fa98ae533cac185ab207938eb34@mentor.com"},"message":"media: videodev2.h: Add more field helper macros\n\nAdds three helper macros:\n\nV4L2_FIELD_IS_SEQUENTIAL: returns true if the given field type is\n'sequential', that is a full frame is transmitted, or exists in\nmemory, as all top field lines followed by all bottom field lines,\nor vice-versa.\n\nV4L2_FIELD_IS_INTERLACED: returns true if the given field type is\n'interlaced', that is a full frame is transmitted, or exists in\nmemory, as top field lines interlaced with bottom field lines.\n\nV4L2_FIELD_ORDER: returns the field order, using a new enum\nv4l2_field_order.\n\nSigned-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>\n---\nChanges since v2:\n- add macro V4L2_FIELD_ORDER\nChanges since v1:\n- add the complement macro V4L2_FIELD_IS_INTERLACED\n- remove V4L2_FIELD_ALTERNATE from V4L2_FIELD_IS_SEQUENTIAL macro.\n- moved new macros past end of existing V4L2_FIELD_HAS_* macros.","distinct":true,"url":"https://api.github.com/repos/slongerbeam/mediatree/commits/25b694e66e908053bf5663ad0ac101f1b557fd05"},{"sha":"c4be30afb3174d236a2134c57192f425ca674b0c","author":{"name":"Steve Longerbeam","email":"8c188e05ba274fa98ae533cac185ab207938eb34@mentor.com"},"message":"media: imx: interweave only for sequential input/interlaced output fields\n\nIDMAC interlaced scan, a.k.a. interweave, should be enabled at the\nIDMAC output pads only if the input field type is 'seq-bt' or 'seq-tb',\nand the IDMAC output pad field type is 'interlaced*'. Move this\ndetermination to a new macro idmac_interweave().\n\nV4L2_FIELD_HAS_BOTH() macro should not be used on the input to determine\nenabling interlaced/interweave scan. That macro includes the 'interlaced'\nfield types, and in those cases the data is already interweaved with\ntop/bottom field lines.\n\nThe CSI will capture whole frames when the source specifies alternate\nfield mode. So the CSI also enables interweave at the IDMAC output pad\nfor alternate input field type.\n\nSigned-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>","distinct":true,"url":"https://api.github.com/repos/slongerbeam/mediatree/commits/c4be30afb3174d236a2134c57192f425ca674b0c"},{"sha":"390623127167ae54b8cc8e6fe7003dbd3dc30c75","author":{"name":"Steve Longerbeam","email":"8c188e05ba274fa98ae533cac185ab207938eb34@mentor.com"},"message":"media: imx: interweave and odd-chroma-row skip are incompatible\n\nIf IDMAC interweaving is enabled in a write channel, the channel must\nwrite the odd chroma rows for 4:2:0 formats. Skipping writing the odd\nchroma rows produces corrupted captured 4:2:0 images when interweave\nis enabled.\n\nReported-by: Krzysztof Hałasa <khalasa@piap.pl>\nSigned-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>","distinct":true,"url":"https://api.github.com/repos/slongerbeam/mediatree/commits/390623127167ae54b8cc8e6fe7003dbd3dc30c75"},{"sha":"31df5bde0986a728153a393de4eb43d86e3963d2","author":{"name":"Steve Longerbeam","email":"8c188e05ba274fa98ae533cac185ab207938eb34@mentor.com"},"message":"media: imx: Fix field setting logic in try_fmt\n\nThe logic for setting field type in try_fmt at CSI and PRPENCVF\nentities wasn't quite right. The behavior should be:\n\n- No restrictions on field type at sink pads (except ANY, which is filled\n  with current sink pad field by imx_media_fill_default_mbus_fields()).\n\n- At IDMAC output pads, if the caller asks for an interlaced output, and\n  the input is sequential fields, the IDMAC output channel can accommodate\n  by interweaving. The CSI can also interweave if input is alternate\n  fields.\n\n- If final source pad field type is alternate, translate to seq_bt or\n  seq_tb. But the field order translation was backwards, SD NTSC is BT\n  order, SD PAL is TB.\n\nMove this logic to new functions csi_try_field() and prp_try_field().\n\nSigned-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>\n---\nChanges since v2:\n- enforce output field order for interweave, if input order is provided.","distinct":true,"url":"https://api.github.com/repos/slongerbeam/mediatree/commits/31df5bde0986a728153a393de4eb43d86e3963d2"},{"sha":"92777554a67a597943769f79a46a423a0922cb5f","author":{"name":"Steve Longerbeam","email":"8c188e05ba274fa98ae533cac185ab207938eb34@mentor.com"},"message":"media: imx-csi: Allow skipping odd chroma rows for YVU420\n\nSkip writing U/V components to odd rows for YVU420 in addition to\nYUV420 and NV12.\n\nSigned-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>\nReviewed-by: Philipp Zabel <p.zabel@pengutronix.de>","distinct":true,"url":"https://api.github.com/repos/slongerbeam/mediatree/commits/92777554a67a597943769f79a46a423a0922cb5f"},{"sha":"eb54169fc12a20b3fecff59cd20e6894da886191","author":{"name":"Steve Longerbeam","email":"8c188e05ba274fa98ae533cac185ab207938eb34@mentor.com"},"message":"media: imx: vdic: rely on VDIC for correct field order\n\nprepare_vdi_in_buffers() was setting up the dma pointers as if the\nVDIC is always programmed to receive the fields in bottom-top order,\ni.e. as if ipu_vdi_set_field_order() only programs BT order in the VDIC.\nBut that's not true, ipu_vdi_set_field_order() is working correctly.\n\nSo fix prepare_vdi_in_buffers() to give the VDIC the fields in whatever\norder they were received by the video source, and rely on the VDIC to\nsort out which is top and which is bottom.\n\nSigned-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>","distinct":true,"url":"https://api.github.com/repos/slongerbeam/mediatree/commits/eb54169fc12a20b3fecff59cd20e6894da886191"},{"sha":"633bb2da97d526b218f02221603b0a31e8e74c1d","author":{"name":"Steve Longerbeam","email":"8c188e05ba274fa98ae533cac185ab207938eb34@mentor.com"},"message":"media: imx-csi: Move crop/compose reset after filling default mbus fields\n\nIf caller passes un-initialized field type V4L2_FIELD_ANY to CSI\nsink pad, the reset CSI crop window would not be correct, because\nthe crop window depends on the current input field type. To fix move\nthe reset of crop and compose windows to after the call to\nimx_media_fill_default_mbus_fields().\n\nSigned-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>","distinct":true,"url":"https://api.github.com/repos/slongerbeam/mediatree/commits/633bb2da97d526b218f02221603b0a31e8e74c1d"},{"sha":"57f4e29c35938545a8240f78b7cb63cd184b0bad","author":{"name":"Steve Longerbeam","email":"8c188e05ba274fa98ae533cac185ab207938eb34@mentor.com"},"message":"media: imx.rst: Update doc to reflect fixes to interlaced capture\n\nAlso add an example pipeline for unconverted capture with interweave\non SabreAuto.\n\nSigned-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>\n---\nChanges since v2:\n- expand on idmac interweave behavior in CSI subdev.\n- switch second SabreAuto pipeline example to PAL to give\n  both NTSC and PAL examples.","distinct":true,"url":"https://api.github.com/repos/slongerbeam/mediatree/commits/57f4e29c35938545a8240f78b7cb63cd184b0bad"}]}
{"actor":{"display_login":"slongerbeam"}}