{"action":"created","comment":{"url":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/comments/169048209","pull_request_review_id":97510913,"id":169048209,"diff_hunk":"@@ -34,11 +34,13 @@\n  */\n @BallerinaFunction(\n         packageName = \"ballerina.io\",\n-        functionName = \"closeTextRecordChannel\",\n-        receiver = @Receiver(type = TypeKind.STRUCT, structType = \"TextRecordChannel\", structPackage = \"ballerina.io\"),\n+        functionName = \"closeDelimitedRecordChannel\",\n+        receiver = @Receiver(type = TypeKind.STRUCT,\n+                structType = \"DelimitedRecordChannel\",\n+                structPackage = \"ballerina.io\"),\n         isPublic = true\n )\n-public class CloseTextRecordChannel extends AbstractNativeFunction {\n+public class CloseDelimitedRecordChannel extends AbstractNativeFunction {\n \n     /**\n      * The index of the TextRecordChannel in ballerina.io#closeTextRecordChannel().","path":"stdlib/ballerina-builtin/src/main/java/org/ballerinalang/nativeimpl/io/CloseDelimitedRecordChannel.java","position":null,"original_position":25,"commit_id":"c65b5580d110f274fb2a630c136996a31c17d89e","original_commit_id":"3e6399baa4d6dfa9abd913f067378b6888868683","user":{"login":"pamod","id":3785198,"avatar_url":"https://avatars2.githubusercontent.com/u/3785198?v=4","gravatar_id":"","url":"https://api.github.com/users/pamod","html_url":"https://github.com/pamod","followers_url":"https://api.github.com/users/pamod/followers","following_url":"https://api.github.com/users/pamod/following{/other_user}","gists_url":"https://api.github.com/users/pamod/gists{/gist_id}","starred_url":"https://api.github.com/users/pamod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamod/subscriptions","organizations_url":"https://api.github.com/users/pamod/orgs","repos_url":"https://api.github.com/users/pamod/repos","events_url":"https://api.github.com/users/pamod/events{/privacy}","received_events_url":"https://api.github.com/users/pamod/received_events","type":"User","site_admin":false},"body":"c65b5580d110f274fb2a630c136996a31c17d89e","created_at":"2018-02-19T11:22:53Z","updated_at":"2018-02-19T11:22:53Z","html_url":"https://github.com/ballerina-lang/ballerina/pull/4735#discussion_r169048209","pull_request_url":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/4735","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/comments/169048209"},"html":{"href":"https://github.com/ballerina-lang/ballerina/pull/4735#discussion_r169048209"},"pull_request":{"href":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/4735"}},"in_reply_to_id":169043859},"pull_request":{"url":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/4735","id":169924529,"html_url":"https://github.com/ballerina-lang/ballerina/pull/4735","diff_url":"https://github.com/ballerina-lang/ballerina/pull/4735.diff","patch_url":"https://github.com/ballerina-lang/ballerina/pull/4735.patch","issue_url":"https://api.github.com/repos/ballerina-lang/ballerina/issues/4735","number":4735,"state":"open","locked":false,"title":"Fix issue #4715","user":{"login":"pamod","id":3785198,"avatar_url":"https://avatars2.githubusercontent.com/u/3785198?v=4","gravatar_id":"","url":"https://api.github.com/users/pamod","html_url":"https://github.com/pamod","followers_url":"https://api.github.com/users/pamod/followers","following_url":"https://api.github.com/users/pamod/following{/other_user}","gists_url":"https://api.github.com/users/pamod/gists{/gist_id}","starred_url":"https://api.github.com/users/pamod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamod/subscriptions","organizations_url":"https://api.github.com/users/pamod/orgs","repos_url":"https://api.github.com/users/pamod/repos","events_url":"https://api.github.com/users/pamod/events{/privacy}","received_events_url":"https://api.github.com/users/pamod/received_events","type":"User","site_admin":false},"body":"## Purpose\r\nFixes the issue described in #4715. TextRecordChannel conveys a generic meaning, there will be other channels i.e CSVProcessingChannel which will also be processing content as text. Hence the name will be changed to bring out a better meaning.  \r\n\r\n## Goals\r\n- Rename, the existing TextRecordChannel to DelimitedRecordChannel.\r\n- Changed the relevant test cases\r\n- Changed the relevant samples\r\n\r\n## Approach\r\n\r\nIntroduced the following native function,\r\n\r\n```\r\npublic native function <DelimitedRecordChannel channel> nextTextRecord () (string[]);\r\n\r\npublic native function <DelimitedRecordChannel channel> writeTextRecord (string[] records);\r\n\r\npublic native function <DelimitedRecordChannel channel> closeDelimitedRecordChannel();\r\n```\r\n\r\n## User stories\r\nN/A\r\n\r\n## Release note\r\nChanges the TextRecordChannel to DelimitedRecordChannel\r\n\r\n## Documentation\r\nhttps://ballerinalang.org/docs/api/0.961.0/ballerina.io.html#TextRecordChannel\r\nThe function will be renamed to DelimitedRecordChannel\r\n\r\n## Training\r\nN/A\r\n\r\n## Certification\r\nN/A\r\n\r\n## Marketing\r\nN/A\r\n\r\n## Automation tests\r\nThe relevant test cases which were there previously were changed to use DelimitedRecordChannel  \r\n\r\n## Security checks\r\n - Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes\r\n - Ran FindSecurityBugs plugin and verified report? yes\r\n - Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes\r\n\r\n## Samples\r\nThe relevant samples which used the TextRecordChannel were changed to use DelimitedRecordChannel \r\n\r\n## Related PRs\r\nN/A\r\n\r\n## Migrations (if applicable)\r\nN/A\r\n\r\n## Test environment\r\nJDK 1.8\r\n \r\n## Learning\r\nN/A","created_at":"2018-02-19T10:29:36Z","updated_at":"2018-02-19T11:22:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49c4385edb4878f2a4b7dcc34e789e7f9520ec78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/4735/commits","review_comments_url":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/4735/comments","review_comment_url":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ballerina-lang/ballerina/issues/4735/comments","statuses_url":"https://api.github.com/repos/ballerina-lang/ballerina/statuses/c65b5580d110f274fb2a630c136996a31c17d89e","head":{"label":"pamod:record-channel-revamp","ref":"record-channel-revamp","sha":"c65b5580d110f274fb2a630c136996a31c17d89e","user":{"login":"pamod","id":3785198,"avatar_url":"https://avatars2.githubusercontent.com/u/3785198?v=4","gravatar_id":"","url":"https://api.github.com/users/pamod","html_url":"https://github.com/pamod","followers_url":"https://api.github.com/users/pamod/followers","following_url":"https://api.github.com/users/pamod/following{/other_user}","gists_url":"https://api.github.com/users/pamod/gists{/gist_id}","starred_url":"https://api.github.com/users/pamod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamod/subscriptions","organizations_url":"https://api.github.com/users/pamod/orgs","repos_url":"https://api.github.com/users/pamod/repos","events_url":"https://api.github.com/users/pamod/events{/privacy}","received_events_url":"https://api.github.com/users/pamod/received_events","type":"User","site_admin":false},"repo":{"id":104025523,"name":"ballerina","full_name":"pamod/ballerina","owner":{"login":"pamod","id":3785198,"avatar_url":"https://avatars2.githubusercontent.com/u/3785198?v=4","gravatar_id":"","url":"https://api.github.com/users/pamod","html_url":"https://github.com/pamod","followers_url":"https://api.github.com/users/pamod/followers","following_url":"https://api.github.com/users/pamod/following{/other_user}","gists_url":"https://api.github.com/users/pamod/gists{/gist_id}","starred_url":"https://api.github.com/users/pamod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamod/subscriptions","organizations_url":"https://api.github.com/users/pamod/orgs","repos_url":"https://api.github.com/users/pamod/repos","events_url":"https://api.github.com/users/pamod/events{/privacy}","received_events_url":"https://api.github.com/users/pamod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pamod/ballerina","description":"Ballerina is a new programming language for integration built on a sequence diagram metaphor.","fork":true,"url":"https://api.github.com/repos/pamod/ballerina","forks_url":"https://api.github.com/repos/pamod/ballerina/forks","keys_url":"https://api.github.com/repos/pamod/ballerina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pamod/ballerina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pamod/ballerina/teams","hooks_url":"https://api.github.com/repos/pamod/ballerina/hooks","issue_events_url":"https://api.github.com/repos/pamod/ballerina/issues/events{/number}","events_url":"https://api.github.com/repos/pamod/ballerina/events","assignees_url":"https://api.github.com/repos/pamod/ballerina/assignees{/user}","branches_url":"https://api.github.com/repos/pamod/ballerina/branches{/branch}","tags_url":"https://api.github.com/repos/pamod/ballerina/tags","blobs_url":"https://api.github.com/repos/pamod/ballerina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pamod/ballerina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pamod/ballerina/git/refs{/sha}","trees_url":"https://api.github.com/repos/pamod/ballerina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pamod/ballerina/statuses/{sha}","languages_url":"https://api.github.com/repos/pamod/ballerina/languages","stargazers_url":"https://api.github.com/repos/pamod/ballerina/stargazers","contributors_url":"https://api.github.com/repos/pamod/ballerina/contributors","subscribers_url":"https://api.github.com/repos/pamod/ballerina/subscribers","subscription_url":"https://api.github.com/repos/pamod/ballerina/subscription","commits_url":"https://api.github.com/repos/pamod/ballerina/commits{/sha}","git_commits_url":"https://api.github.com/repos/pamod/ballerina/git/commits{/sha}","comments_url":"https://api.github.com/repos/pamod/ballerina/comments{/number}","issue_comment_url":"https://api.github.com/repos/pamod/ballerina/issues/comments{/number}","contents_url":"https://api.github.com/repos/pamod/ballerina/contents/{+path}","compare_url":"https://api.github.com/repos/pamod/ballerina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pamod/ballerina/merges","archive_url":"https://api.github.com/repos/pamod/ballerina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pamod/ballerina/downloads","issues_url":"https://api.github.com/repos/pamod/ballerina/issues{/number}","pulls_url":"https://api.github.com/repos/pamod/ballerina/pulls{/number}","milestones_url":"https://api.github.com/repos/pamod/ballerina/milestones{/number}","notifications_url":"https://api.github.com/repos/pamod/ballerina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pamod/ballerina/labels{/name}","releases_url":"https://api.github.com/repos/pamod/ballerina/releases{/id}","deployments_url":"https://api.github.com/repos/pamod/ballerina/deployments","created_at":"2017-09-19T04:14:03Z","updated_at":"2017-09-19T04:14:08Z","pushed_at":"2018-02-19T11:18:28Z","git_url":"git://github.com/pamod/ballerina.git","ssh_url":"git@github.com:pamod/ballerina.git","clone_url":"https://github.com/pamod/ballerina.git","svn_url":"https://github.com/pamod/ballerina","homepage":"","size":153253,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ballerina-lang:master","ref":"master","sha":"668f4af2b196c89fcd83bcc45cd01d4e4ac7f26f","user":{"login":"ballerina-lang","id":24777199,"avatar_url":"https://avatars1.githubusercontent.com/u/24777199?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-lang","html_url":"https://github.com/ballerina-lang","followers_url":"https://api.github.com/users/ballerina-lang/followers","following_url":"https://api.github.com/users/ballerina-lang/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-lang/subscriptions","organizations_url":"https://api.github.com/users/ballerina-lang/orgs","repos_url":"https://api.github.com/users/ballerina-lang/repos","events_url":"https://api.github.com/users/ballerina-lang/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":73930305,"name":"ballerina","full_name":"ballerina-lang/ballerina","owner":{"login":"ballerina-lang","id":24777199,"avatar_url":"https://avatars1.githubusercontent.com/u/24777199?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-lang","html_url":"https://github.com/ballerina-lang","followers_url":"https://api.github.com/users/ballerina-lang/followers","following_url":"https://api.github.com/users/ballerina-lang/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-lang/subscriptions","organizations_url":"https://api.github.com/users/ballerina-lang/orgs","repos_url":"https://api.github.com/users/ballerina-lang/repos","events_url":"https://api.github.com/users/ballerina-lang/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ballerina-lang/ballerina","description":"Ballerina is a new programming language for integration built on a sequence diagram metaphor.","fork":false,"url":"https://api.github.com/repos/ballerina-lang/ballerina","forks_url":"https://api.github.com/repos/ballerina-lang/ballerina/forks","keys_url":"https://api.github.com/repos/ballerina-lang/ballerina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ballerina-lang/ballerina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ballerina-lang/ballerina/teams","hooks_url":"https://api.github.com/repos/ballerina-lang/ballerina/hooks","issue_events_url":"https://api.github.com/repos/ballerina-lang/ballerina/issues/events{/number}","events_url":"https://api.github.com/repos/ballerina-lang/ballerina/events","assignees_url":"https://api.github.com/repos/ballerina-lang/ballerina/assignees{/user}","branches_url":"https://api.github.com/repos/ballerina-lang/ballerina/branches{/branch}","tags_url":"https://api.github.com/repos/ballerina-lang/ballerina/tags","blobs_url":"https://api.github.com/repos/ballerina-lang/ballerina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ballerina-lang/ballerina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ballerina-lang/ballerina/git/refs{/sha}","trees_url":"https://api.github.com/repos/ballerina-lang/ballerina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ballerina-lang/ballerina/statuses/{sha}","languages_url":"https://api.github.com/repos/ballerina-lang/ballerina/languages","stargazers_url":"https://api.github.com/repos/ballerina-lang/ballerina/stargazers","contributors_url":"https://api.github.com/repos/ballerina-lang/ballerina/contributors","subscribers_url":"https://api.github.com/repos/ballerina-lang/ballerina/subscribers","subscription_url":"https://api.github.com/repos/ballerina-lang/ballerina/subscription","commits_url":"https://api.github.com/repos/ballerina-lang/ballerina/commits{/sha}","git_commits_url":"https://api.github.com/repos/ballerina-lang/ballerina/git/commits{/sha}","comments_url":"https://api.github.com/repos/ballerina-lang/ballerina/comments{/number}","issue_comment_url":"https://api.github.com/repos/ballerina-lang/ballerina/issues/comments{/number}","contents_url":"https://api.github.com/repos/ballerina-lang/ballerina/contents/{+path}","compare_url":"https://api.github.com/repos/ballerina-lang/ballerina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ballerina-lang/ballerina/merges","archive_url":"https://api.github.com/repos/ballerina-lang/ballerina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ballerina-lang/ballerina/downloads","issues_url":"https://api.github.com/repos/ballerina-lang/ballerina/issues{/number}","pulls_url":"https://api.github.com/repos/ballerina-lang/ballerina/pulls{/number}","milestones_url":"https://api.github.com/repos/ballerina-lang/ballerina/milestones{/number}","notifications_url":"https://api.github.com/repos/ballerina-lang/ballerina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ballerina-lang/ballerina/labels{/name}","releases_url":"https://api.github.com/repos/ballerina-lang/ballerina/releases{/id}","deployments_url":"https://api.github.com/repos/ballerina-lang/ballerina/deployments","created_at":"2016-11-16T14:58:44Z","updated_at":"2018-02-14T12:09:29Z","pushed_at":"2018-02-19T11:18:30Z","git_url":"git://github.com/ballerina-lang/ballerina.git","ssh_url":"git@github.com:ballerina-lang/ballerina.git","clone_url":"https://github.com/ballerina-lang/ballerina.git","svn_url":"https://github.com/ballerina-lang/ballerina","homepage":"","size":153164,"stargazers_count":232,"watchers_count":232,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"open_issues_count":446,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":219,"open_issues":446,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/4735"},"html":{"href":"https://github.com/ballerina-lang/ballerina/pull/4735"},"issue":{"href":"https://api.github.com/repos/ballerina-lang/ballerina/issues/4735"},"comments":{"href":"https://api.github.com/repos/ballerina-lang/ballerina/issues/4735/comments"},"review_comments":{"href":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/4735/comments"},"review_comment":{"href":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ballerina-lang/ballerina/pulls/4735/commits"},"statuses":{"href":"https://api.github.com/repos/ballerina-lang/ballerina/statuses/c65b5580d110f274fb2a630c136996a31c17d89e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pamod"}}