{"action":"created","comment":{"url":"https://api.github.com/repos/suavecode/SUAVE/pulls/comments/183130112","pull_request_review_id":114075281,"id":183130112,"diff_hunk":"@@ -0,0 +1,244 @@\n+# sramjet_network.py\n+# \n+# Created:  April 2018, W. Maier\n+# Modified: \n+#        \n+\n+\"\"\" create and evaluate a sramjet network\n+\"\"\"\n+\n+# ----------------------------------------------------------------------\n+#   Imports\n+# ----------------------------------------------------------------------\n+\n+import SUAVE\n+from SUAVE.Core import Units, Data\n+\n+import numpy as np\n+\n+from SUAVE.Components.Energy.Networks.Scramjet import Scramjet\n+from SUAVE.Methods.Propulsion.scramjet_sizing import scramjet_sizing\n+\n+# ----------------------------------------------------------------------\n+#   Main\n+# ----------------------------------------------------------------------\n+def main():\n+    \n+    # call the network function\n+    energy_network()    \n+\n+    return\n+\n+# ----------------------------------------------------------------------\n+#   Energy Network\n+# ----------------------------------------------------------------------\n+def energy_network():\n+    \n+    # ------------------------------------------------------------------\n+    #   Evaluation Conditions\n+    # ------------------------------------------------------------------    \n+    \n+    # --- Conditions        \n+    ones_1col = np.ones([1,1])    \n+    \n+    # setup conditions\n+    conditions = SUAVE.Analyses.Mission.Segments.Conditions.Aerodynamics()\n+    \n+    # freestream conditions\n+    EVAL                             = conditions.freestream","path":"regression/scripts/scramjet_network/scramjet_network.py","position":48,"original_position":48,"commit_id":"cc15daefe774e444d1c679f77bc46749f0e2896e","original_commit_id":"cc15daefe774e444d1c679f77bc46749f0e2896e","user":{"login":"timdmacdo","id":7028139,"avatar_url":"https://avatars0.githubusercontent.com/u/7028139?v=4","gravatar_id":"","url":"https://api.github.com/users/timdmacdo","html_url":"https://github.com/timdmacdo","followers_url":"https://api.github.com/users/timdmacdo/followers","following_url":"https://api.github.com/users/timdmacdo/following{/other_user}","gists_url":"https://api.github.com/users/timdmacdo/gists{/gist_id}","starred_url":"https://api.github.com/users/timdmacdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timdmacdo/subscriptions","organizations_url":"https://api.github.com/users/timdmacdo/orgs","repos_url":"https://api.github.com/users/timdmacdo/repos","events_url":"https://api.github.com/users/timdmacdo/events{/privacy}","received_events_url":"https://api.github.com/users/timdmacdo/received_events","type":"User","site_admin":false},"body":"variables should be lower case","created_at":"2018-04-20T18:11:14Z","updated_at":"2018-04-20T18:34:05Z","html_url":"https://github.com/suavecode/SUAVE/pull/235#discussion_r183130112","pull_request_url":"https://api.github.com/repos/suavecode/SUAVE/pulls/235","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/suavecode/SUAVE/pulls/comments/183130112"},"html":{"href":"https://github.com/suavecode/SUAVE/pull/235#discussion_r183130112"},"pull_request":{"href":"https://api.github.com/repos/suavecode/SUAVE/pulls/235"}}},"pull_request":{"url":"https://api.github.com/repos/suavecode/SUAVE/pulls/235","id":182379523,"html_url":"https://github.com/suavecode/SUAVE/pull/235","diff_url":"https://github.com/suavecode/SUAVE/pull/235.diff","patch_url":"https://github.com/suavecode/SUAVE/pull/235.patch","issue_url":"https://api.github.com/repos/suavecode/SUAVE/issues/235","number":235,"state":"open","locked":false,"title":"Feature scramjet","user":{"login":"WalterMaier","id":17651188,"avatar_url":"https://avatars2.githubusercontent.com/u/17651188?v=4","gravatar_id":"","url":"https://api.github.com/users/WalterMaier","html_url":"https://github.com/WalterMaier","followers_url":"https://api.github.com/users/WalterMaier/followers","following_url":"https://api.github.com/users/WalterMaier/following{/other_user}","gists_url":"https://api.github.com/users/WalterMaier/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterMaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterMaier/subscriptions","organizations_url":"https://api.github.com/users/WalterMaier/orgs","repos_url":"https://api.github.com/users/WalterMaier/repos","events_url":"https://api.github.com/users/WalterMaier/events{/privacy}","received_events_url":"https://api.github.com/users/WalterMaier/received_events","type":"User","site_admin":false},"body":"# Pull Request Checklist\r\n * Merge in the latest Develop branch changes to your branch\r\n * Remove .pyc files from your repository:\r\n   * Linux/Mac\r\n     * find . -name *.pyc -delete\r\n   * Windows\r\n     * del /S *.pyc\r\n * Run automatic regression and makes sure everything is passing\r\n * Did you make a new regression test that covers your new code?\r\n * Did you update your docstrings?\r\n * Did you update your headers to include your name and date?\r\n * Do a final compare with the Develop branch to be sure what you're changing\r\n","created_at":"2018-04-18T06:31:39Z","updated_at":"2018-04-20T18:34:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1af9bbb49cf3d91b6d25c06a5f4c7b71df592b25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/suavecode/SUAVE/pulls/235/commits","review_comments_url":"https://api.github.com/repos/suavecode/SUAVE/pulls/235/comments","review_comment_url":"https://api.github.com/repos/suavecode/SUAVE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/suavecode/SUAVE/issues/235/comments","statuses_url":"https://api.github.com/repos/suavecode/SUAVE/statuses/cc15daefe774e444d1c679f77bc46749f0e2896e","head":{"label":"suavecode:feature-scramjet","ref":"feature-scramjet","sha":"cc15daefe774e444d1c679f77bc46749f0e2896e","user":{"login":"suavecode","id":7026233,"avatar_url":"https://avatars2.githubusercontent.com/u/7026233?v=4","gravatar_id":"","url":"https://api.github.com/users/suavecode","html_url":"https://github.com/suavecode","followers_url":"https://api.github.com/users/suavecode/followers","following_url":"https://api.github.com/users/suavecode/following{/other_user}","gists_url":"https://api.github.com/users/suavecode/gists{/gist_id}","starred_url":"https://api.github.com/users/suavecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suavecode/subscriptions","organizations_url":"https://api.github.com/users/suavecode/orgs","repos_url":"https://api.github.com/users/suavecode/repos","events_url":"https://api.github.com/users/suavecode/events{/privacy}","received_events_url":"https://api.github.com/users/suavecode/received_events","type":"Organization","site_admin":false},"repo":{"id":17993614,"name":"SUAVE","full_name":"suavecode/SUAVE","owner":{"login":"suavecode","id":7026233,"avatar_url":"https://avatars2.githubusercontent.com/u/7026233?v=4","gravatar_id":"","url":"https://api.github.com/users/suavecode","html_url":"https://github.com/suavecode","followers_url":"https://api.github.com/users/suavecode/followers","following_url":"https://api.github.com/users/suavecode/following{/other_user}","gists_url":"https://api.github.com/users/suavecode/gists{/gist_id}","starred_url":"https://api.github.com/users/suavecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suavecode/subscriptions","organizations_url":"https://api.github.com/users/suavecode/orgs","repos_url":"https://api.github.com/users/suavecode/repos","events_url":"https://api.github.com/users/suavecode/events{/privacy}","received_events_url":"https://api.github.com/users/suavecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/suavecode/SUAVE","description":"An Aircraft Design Toolbox","fork":false,"url":"https://api.github.com/repos/suavecode/SUAVE","forks_url":"https://api.github.com/repos/suavecode/SUAVE/forks","keys_url":"https://api.github.com/repos/suavecode/SUAVE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suavecode/SUAVE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suavecode/SUAVE/teams","hooks_url":"https://api.github.com/repos/suavecode/SUAVE/hooks","issue_events_url":"https://api.github.com/repos/suavecode/SUAVE/issues/events{/number}","events_url":"https://api.github.com/repos/suavecode/SUAVE/events","assignees_url":"https://api.github.com/repos/suavecode/SUAVE/assignees{/user}","branches_url":"https://api.github.com/repos/suavecode/SUAVE/branches{/branch}","tags_url":"https://api.github.com/repos/suavecode/SUAVE/tags","blobs_url":"https://api.github.com/repos/suavecode/SUAVE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suavecode/SUAVE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suavecode/SUAVE/git/refs{/sha}","trees_url":"https://api.github.com/repos/suavecode/SUAVE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suavecode/SUAVE/statuses/{sha}","languages_url":"https://api.github.com/repos/suavecode/SUAVE/languages","stargazers_url":"https://api.github.com/repos/suavecode/SUAVE/stargazers","contributors_url":"https://api.github.com/repos/suavecode/SUAVE/contributors","subscribers_url":"https://api.github.com/repos/suavecode/SUAVE/subscribers","subscription_url":"https://api.github.com/repos/suavecode/SUAVE/subscription","commits_url":"https://api.github.com/repos/suavecode/SUAVE/commits{/sha}","git_commits_url":"https://api.github.com/repos/suavecode/SUAVE/git/commits{/sha}","comments_url":"https://api.github.com/repos/suavecode/SUAVE/comments{/number}","issue_comment_url":"https://api.github.com/repos/suavecode/SUAVE/issues/comments{/number}","contents_url":"https://api.github.com/repos/suavecode/SUAVE/contents/{+path}","compare_url":"https://api.github.com/repos/suavecode/SUAVE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suavecode/SUAVE/merges","archive_url":"https://api.github.com/repos/suavecode/SUAVE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suavecode/SUAVE/downloads","issues_url":"https://api.github.com/repos/suavecode/SUAVE/issues{/number}","pulls_url":"https://api.github.com/repos/suavecode/SUAVE/pulls{/number}","milestones_url":"https://api.github.com/repos/suavecode/SUAVE/milestones{/number}","notifications_url":"https://api.github.com/repos/suavecode/SUAVE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suavecode/SUAVE/labels{/name}","releases_url":"https://api.github.com/repos/suavecode/SUAVE/releases{/id}","deployments_url":"https://api.github.com/repos/suavecode/SUAVE/deployments","created_at":"2014-03-21T20:37:01Z","updated_at":"2018-04-19T20:09:21Z","pushed_at":"2018-04-20T18:03:25Z","git_url":"git://github.com/suavecode/SUAVE.git","ssh_url":"git@github.com:suavecode/SUAVE.git","clone_url":"https://github.com/suavecode/SUAVE.git","svn_url":"https://github.com/suavecode/SUAVE","homepage":"suave.stanford.edu","size":162830,"stargazers_count":67,"watchers_count":67,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":71,"open_issues":27,"watchers":67,"default_branch":"develop"}},"base":{"label":"suavecode:develop","ref":"develop","sha":"c56ba5c4b4ca24ff7d18214d9f20ac69c3ca9559","user":{"login":"suavecode","id":7026233,"avatar_url":"https://avatars2.githubusercontent.com/u/7026233?v=4","gravatar_id":"","url":"https://api.github.com/users/suavecode","html_url":"https://github.com/suavecode","followers_url":"https://api.github.com/users/suavecode/followers","following_url":"https://api.github.com/users/suavecode/following{/other_user}","gists_url":"https://api.github.com/users/suavecode/gists{/gist_id}","starred_url":"https://api.github.com/users/suavecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suavecode/subscriptions","organizations_url":"https://api.github.com/users/suavecode/orgs","repos_url":"https://api.github.com/users/suavecode/repos","events_url":"https://api.github.com/users/suavecode/events{/privacy}","received_events_url":"https://api.github.com/users/suavecode/received_events","type":"Organization","site_admin":false},"repo":{"id":17993614,"name":"SUAVE","full_name":"suavecode/SUAVE","owner":{"login":"suavecode","id":7026233,"avatar_url":"https://avatars2.githubusercontent.com/u/7026233?v=4","gravatar_id":"","url":"https://api.github.com/users/suavecode","html_url":"https://github.com/suavecode","followers_url":"https://api.github.com/users/suavecode/followers","following_url":"https://api.github.com/users/suavecode/following{/other_user}","gists_url":"https://api.github.com/users/suavecode/gists{/gist_id}","starred_url":"https://api.github.com/users/suavecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suavecode/subscriptions","organizations_url":"https://api.github.com/users/suavecode/orgs","repos_url":"https://api.github.com/users/suavecode/repos","events_url":"https://api.github.com/users/suavecode/events{/privacy}","received_events_url":"https://api.github.com/users/suavecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/suavecode/SUAVE","description":"An Aircraft Design Toolbox","fork":false,"url":"https://api.github.com/repos/suavecode/SUAVE","forks_url":"https://api.github.com/repos/suavecode/SUAVE/forks","keys_url":"https://api.github.com/repos/suavecode/SUAVE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suavecode/SUAVE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suavecode/SUAVE/teams","hooks_url":"https://api.github.com/repos/suavecode/SUAVE/hooks","issue_events_url":"https://api.github.com/repos/suavecode/SUAVE/issues/events{/number}","events_url":"https://api.github.com/repos/suavecode/SUAVE/events","assignees_url":"https://api.github.com/repos/suavecode/SUAVE/assignees{/user}","branches_url":"https://api.github.com/repos/suavecode/SUAVE/branches{/branch}","tags_url":"https://api.github.com/repos/suavecode/SUAVE/tags","blobs_url":"https://api.github.com/repos/suavecode/SUAVE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suavecode/SUAVE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suavecode/SUAVE/git/refs{/sha}","trees_url":"https://api.github.com/repos/suavecode/SUAVE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suavecode/SUAVE/statuses/{sha}","languages_url":"https://api.github.com/repos/suavecode/SUAVE/languages","stargazers_url":"https://api.github.com/repos/suavecode/SUAVE/stargazers","contributors_url":"https://api.github.com/repos/suavecode/SUAVE/contributors","subscribers_url":"https://api.github.com/repos/suavecode/SUAVE/subscribers","subscription_url":"https://api.github.com/repos/suavecode/SUAVE/subscription","commits_url":"https://api.github.com/repos/suavecode/SUAVE/commits{/sha}","git_commits_url":"https://api.github.com/repos/suavecode/SUAVE/git/commits{/sha}","comments_url":"https://api.github.com/repos/suavecode/SUAVE/comments{/number}","issue_comment_url":"https://api.github.com/repos/suavecode/SUAVE/issues/comments{/number}","contents_url":"https://api.github.com/repos/suavecode/SUAVE/contents/{+path}","compare_url":"https://api.github.com/repos/suavecode/SUAVE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suavecode/SUAVE/merges","archive_url":"https://api.github.com/repos/suavecode/SUAVE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suavecode/SUAVE/downloads","issues_url":"https://api.github.com/repos/suavecode/SUAVE/issues{/number}","pulls_url":"https://api.github.com/repos/suavecode/SUAVE/pulls{/number}","milestones_url":"https://api.github.com/repos/suavecode/SUAVE/milestones{/number}","notifications_url":"https://api.github.com/repos/suavecode/SUAVE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suavecode/SUAVE/labels{/name}","releases_url":"https://api.github.com/repos/suavecode/SUAVE/releases{/id}","deployments_url":"https://api.github.com/repos/suavecode/SUAVE/deployments","created_at":"2014-03-21T20:37:01Z","updated_at":"2018-04-19T20:09:21Z","pushed_at":"2018-04-20T18:03:25Z","git_url":"git://github.com/suavecode/SUAVE.git","ssh_url":"git@github.com:suavecode/SUAVE.git","clone_url":"https://github.com/suavecode/SUAVE.git","svn_url":"https://github.com/suavecode/SUAVE","homepage":"suave.stanford.edu","size":162830,"stargazers_count":67,"watchers_count":67,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":71,"open_issues":27,"watchers":67,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/suavecode/SUAVE/pulls/235"},"html":{"href":"https://github.com/suavecode/SUAVE/pull/235"},"issue":{"href":"https://api.github.com/repos/suavecode/SUAVE/issues/235"},"comments":{"href":"https://api.github.com/repos/suavecode/SUAVE/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/suavecode/SUAVE/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/suavecode/SUAVE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/suavecode/SUAVE/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/suavecode/SUAVE/statuses/cc15daefe774e444d1c679f77bc46749f0e2896e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timdmacdo"}}