{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/pulls/22","id":203503859,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTAzODU5","html_url":"https://github.com/LBHackney-IT/LBHTenancyAPI/pull/22","diff_url":"https://github.com/LBHackney-IT/LBHTenancyAPI/pull/22.diff","patch_url":"https://github.com/LBHackney-IT/LBHTenancyAPI/pull/22.patch","issue_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/issues/22","number":22,"state":"closed","locked":false,"title":"Add healthcheck route","user":{"login":"zuren","id":34348,"node_id":"MDQ6VXNlcjM0MzQ4","avatar_url":"https://avatars3.githubusercontent.com/u/34348?v=4","gravatar_id":"","url":"https://api.github.com/users/zuren","html_url":"https://github.com/zuren","followers_url":"https://api.github.com/users/zuren/followers","following_url":"https://api.github.com/users/zuren/following{/other_user}","gists_url":"https://api.github.com/users/zuren/gists{/gist_id}","starred_url":"https://api.github.com/users/zuren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuren/subscriptions","organizations_url":"https://api.github.com/users/zuren/orgs","repos_url":"https://api.github.com/users/zuren/repos","events_url":"https://api.github.com/users/zuren/events{/privacy}","received_events_url":"https://api.github.com/users/zuren/received_events","type":"User","site_admin":false},"body":"To ensure running containers in production are able to receive requests, and to monitor the uptime of them continuously, we need to have a route which can be hit frequently and respond quickly without side effects. At the least a /healthcheck route like this should respond, ideally in time we'll be able to improve it to check external dependencies too (e.g. that it has database access.)\r\n\r\nIn this case, we need this route now because AWS load balancers need to be able to ensure uptime of running application containers, or the containers will be restarted by ECS.\r\n\r\nRunning correctly locally:\r\n\r\n![image](https://user-images.githubusercontent.com/34348/43136957-3ffda41c-8f42-11e8-8b17-040a2200671e.png)\r\n","created_at":"2018-07-24T12:05:20Z","updated_at":"2018-07-25T10:42:29Z","closed_at":"2018-07-25T10:42:29Z","merged_at":"2018-07-25T10:42:29Z","merge_commit_sha":"c521ea3284843b326df42867655d4d63ce4d92d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/pulls/22/commits","review_comments_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/pulls/22/comments","review_comment_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/issues/22/comments","statuses_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/statuses/2a44a1077ce5610bd49e5135b3115e5666d8c217","head":{"label":"LBHackney-IT:healthcheck","ref":"healthcheck","sha":"2a44a1077ce5610bd49e5135b3115e5666d8c217","user":{"login":"LBHackney-IT","id":29410061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDEwMDYx","avatar_url":"https://avatars2.githubusercontent.com/u/29410061?v=4","gravatar_id":"","url":"https://api.github.com/users/LBHackney-IT","html_url":"https://github.com/LBHackney-IT","followers_url":"https://api.github.com/users/LBHackney-IT/followers","following_url":"https://api.github.com/users/LBHackney-IT/following{/other_user}","gists_url":"https://api.github.com/users/LBHackney-IT/gists{/gist_id}","starred_url":"https://api.github.com/users/LBHackney-IT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBHackney-IT/subscriptions","organizations_url":"https://api.github.com/users/LBHackney-IT/orgs","repos_url":"https://api.github.com/users/LBHackney-IT/repos","events_url":"https://api.github.com/users/LBHackney-IT/events{/privacy}","received_events_url":"https://api.github.com/users/LBHackney-IT/received_events","type":"Organization","site_admin":false},"repo":{"id":138157232,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxNTcyMzI=","name":"LBHTenancyAPI","full_name":"LBHackney-IT/LBHTenancyAPI","owner":{"login":"LBHackney-IT","id":29410061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDEwMDYx","avatar_url":"https://avatars2.githubusercontent.com/u/29410061?v=4","gravatar_id":"","url":"https://api.github.com/users/LBHackney-IT","html_url":"https://github.com/LBHackney-IT","followers_url":"https://api.github.com/users/LBHackney-IT/followers","following_url":"https://api.github.com/users/LBHackney-IT/following{/other_user}","gists_url":"https://api.github.com/users/LBHackney-IT/gists{/gist_id}","starred_url":"https://api.github.com/users/LBHackney-IT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBHackney-IT/subscriptions","organizations_url":"https://api.github.com/users/LBHackney-IT/orgs","repos_url":"https://api.github.com/users/LBHackney-IT/repos","events_url":"https://api.github.com/users/LBHackney-IT/events{/privacy}","received_events_url":"https://api.github.com/users/LBHackney-IT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LBHackney-IT/LBHTenancyAPI","description":null,"fork":false,"url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI","forks_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/forks","keys_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/teams","hooks_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/hooks","issue_events_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/issues/events{/number}","events_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/events","assignees_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/assignees{/user}","branches_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/branches{/branch}","tags_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/tags","blobs_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/languages","stargazers_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/stargazers","contributors_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/contributors","subscribers_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/subscribers","subscription_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/subscription","commits_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/contents/{+path}","compare_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/merges","archive_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/downloads","issues_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/issues{/number}","pulls_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/labels{/name}","releases_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/releases{/id}","deployments_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/deployments","created_at":"2018-06-21T10:43:51Z","updated_at":"2018-07-23T14:36:40Z","pushed_at":"2018-07-25T10:42:29Z","git_url":"git://github.com/LBHackney-IT/LBHTenancyAPI.git","ssh_url":"git@github.com:LBHackney-IT/LBHTenancyAPI.git","clone_url":"https://github.com/LBHackney-IT/LBHTenancyAPI.git","svn_url":"https://github.com/LBHackney-IT/LBHTenancyAPI","homepage":null,"size":165,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"LBHackney-IT:master","ref":"master","sha":"a30161cee6b54ce9c282aac72dffa563ae0c38f3","user":{"login":"LBHackney-IT","id":29410061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDEwMDYx","avatar_url":"https://avatars2.githubusercontent.com/u/29410061?v=4","gravatar_id":"","url":"https://api.github.com/users/LBHackney-IT","html_url":"https://github.com/LBHackney-IT","followers_url":"https://api.github.com/users/LBHackney-IT/followers","following_url":"https://api.github.com/users/LBHackney-IT/following{/other_user}","gists_url":"https://api.github.com/users/LBHackney-IT/gists{/gist_id}","starred_url":"https://api.github.com/users/LBHackney-IT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBHackney-IT/subscriptions","organizations_url":"https://api.github.com/users/LBHackney-IT/orgs","repos_url":"https://api.github.com/users/LBHackney-IT/repos","events_url":"https://api.github.com/users/LBHackney-IT/events{/privacy}","received_events_url":"https://api.github.com/users/LBHackney-IT/received_events","type":"Organization","site_admin":false},"repo":{"id":138157232,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxNTcyMzI=","name":"LBHTenancyAPI","full_name":"LBHackney-IT/LBHTenancyAPI","owner":{"login":"LBHackney-IT","id":29410061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDEwMDYx","avatar_url":"https://avatars2.githubusercontent.com/u/29410061?v=4","gravatar_id":"","url":"https://api.github.com/users/LBHackney-IT","html_url":"https://github.com/LBHackney-IT","followers_url":"https://api.github.com/users/LBHackney-IT/followers","following_url":"https://api.github.com/users/LBHackney-IT/following{/other_user}","gists_url":"https://api.github.com/users/LBHackney-IT/gists{/gist_id}","starred_url":"https://api.github.com/users/LBHackney-IT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBHackney-IT/subscriptions","organizations_url":"https://api.github.com/users/LBHackney-IT/orgs","repos_url":"https://api.github.com/users/LBHackney-IT/repos","events_url":"https://api.github.com/users/LBHackney-IT/events{/privacy}","received_events_url":"https://api.github.com/users/LBHackney-IT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LBHackney-IT/LBHTenancyAPI","description":null,"fork":false,"url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI","forks_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/forks","keys_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/teams","hooks_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/hooks","issue_events_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/issues/events{/number}","events_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/events","assignees_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/assignees{/user}","branches_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/branches{/branch}","tags_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/tags","blobs_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/languages","stargazers_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/stargazers","contributors_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/contributors","subscribers_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/subscribers","subscription_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/subscription","commits_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/contents/{+path}","compare_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/merges","archive_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/downloads","issues_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/issues{/number}","pulls_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/labels{/name}","releases_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/releases{/id}","deployments_url":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/deployments","created_at":"2018-06-21T10:43:51Z","updated_at":"2018-07-23T14:36:40Z","pushed_at":"2018-07-25T10:42:29Z","git_url":"git://github.com/LBHackney-IT/LBHTenancyAPI.git","ssh_url":"git@github.com:LBHackney-IT/LBHTenancyAPI.git","clone_url":"https://github.com/LBHackney-IT/LBHTenancyAPI.git","svn_url":"https://github.com/LBHackney-IT/LBHTenancyAPI","homepage":null,"size":165,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/pulls/22"},"html":{"href":"https://github.com/LBHackney-IT/LBHTenancyAPI/pull/22"},"issue":{"href":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/issues/22"},"comments":{"href":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/LBHackney-IT/LBHTenancyAPI/statuses/2a44a1077ce5610bd49e5135b3115e5666d8c217"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zuren","id":34348,"node_id":"MDQ6VXNlcjM0MzQ4","avatar_url":"https://avatars3.githubusercontent.com/u/34348?v=4","gravatar_id":"","url":"https://api.github.com/users/zuren","html_url":"https://github.com/zuren","followers_url":"https://api.github.com/users/zuren/followers","following_url":"https://api.github.com/users/zuren/following{/other_user}","gists_url":"https://api.github.com/users/zuren/gists{/gist_id}","starred_url":"https://api.github.com/users/zuren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuren/subscriptions","organizations_url":"https://api.github.com/users/zuren/orgs","repos_url":"https://api.github.com/users/zuren/repos","events_url":"https://api.github.com/users/zuren/events{/privacy}","received_events_url":"https://api.github.com/users/zuren/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":46,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"zuren"}}