{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/22458","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22458/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22458/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22458/events","html_url":"https://github.com/cms-sw/cmssw/pull/22458","id":302296115,"number":22458,"title":"Pixel 3d reco with cluster repair 10 1 x","user":{"login":"pmaksim1","id":4876625,"avatar_url":"https://avatars2.githubusercontent.com/u/4876625?v=4","gravatar_id":"","url":"https://api.github.com/users/pmaksim1","html_url":"https://github.com/pmaksim1","followers_url":"https://api.github.com/users/pmaksim1/followers","following_url":"https://api.github.com/users/pmaksim1/following{/other_user}","gists_url":"https://api.github.com/users/pmaksim1/gists{/gist_id}","starred_url":"https://api.github.com/users/pmaksim1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmaksim1/subscriptions","organizations_url":"https://api.github.com/users/pmaksim1/orgs","repos_url":"https://api.github.com/users/pmaksim1/repos","events_url":"https://api.github.com/users/pmaksim1/events{/privacy}","received_events_url":"https://api.github.com/users/pmaksim1/received_events","type":"User","site_admin":false},"labels":[{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"009800","default":false},{"id":334305616,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-notrun","name":"comparison-notrun","color":"bfe5bf","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131220,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/73","html_url":"https://github.com/cms-sw/cmssw/milestone/73","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/73/labels","id":3060828,"number":73,"title":"CMSSW_10_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":90,"closed_issues":356,"state":"open","created_at":"2018-01-24T11:24:59Z","updated_at":"2018-03-05T17:25:08Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2018-03-05T13:17:25Z","updated_at":"2018-03-05T18:03:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22458","html_url":"https://github.com/cms-sw/cmssw/pull/22458","diff_url":"https://github.com/cms-sw/cmssw/pull/22458.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22458.patch"},"body":"The 2D pixel cluster reconstruction.  For normal undamaged clusters, the 2D fit is as good or better as the usual combination of two 1D fits of cluster projections onto the local x and y axes.  However, the 2D fit is able to fit even clusters that are damaged by (a) edge of sensor, or (b) dead double-column or ROC next door.  The 2D pixel reco is done within a new CPE, called PixelCPEClusterRepair (since it can \"repair\" damaged clusters), which subsumes the default reconstruction, and can perform it as well, and then optionally (if the 2* 1D reco recommends based on its fit outputs) do the 2D fit.  \r\n\r\nAll this code is by default TURNED OFF.  We want it in the release though to simplify testing and enable future development in the near term."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/370508013","html_url":"https://github.com/cms-sw/cmssw/pull/22458#issuecomment-370508013","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22458","id":370508013,"user":{"login":"pmaksim1","id":4876625,"avatar_url":"https://avatars2.githubusercontent.com/u/4876625?v=4","gravatar_id":"","url":"https://api.github.com/users/pmaksim1","html_url":"https://github.com/pmaksim1","followers_url":"https://api.github.com/users/pmaksim1/followers","following_url":"https://api.github.com/users/pmaksim1/following{/other_user}","gists_url":"https://api.github.com/users/pmaksim1/gists{/gist_id}","starred_url":"https://api.github.com/users/pmaksim1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmaksim1/subscriptions","organizations_url":"https://api.github.com/users/pmaksim1/orgs","repos_url":"https://api.github.com/users/pmaksim1/repos","events_url":"https://api.github.com/users/pmaksim1/events{/privacy}","received_events_url":"https://api.github.com/users/pmaksim1/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T18:03:11Z","updated_at":"2018-03-05T18:03:11Z","author_association":"CONTRIBUTOR","body":"I may be naive, but I thought FastSim didn't work for Phase 1 yet.  At least I am *sure* it doesn't work for pixels.\r\n\r\nAnyway, I will need to run this in gdb and see what happens in the pixel code."}}
{"actor":{"display_login":"pmaksim1"}}