{"action":"opened","number":1089,"pull_request":{"url":"https://api.github.com/repos/embark-framework/embark/pulls/1089","id":231312397,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzEyMzk3","html_url":"https://github.com/embark-framework/embark/pull/1089","diff_url":"https://github.com/embark-framework/embark/pull/1089.diff","patch_url":"https://github.com/embark-framework/embark/pull/1089.patch","issue_url":"https://api.github.com/repos/embark-framework/embark/issues/1089","number":1089,"state":"open","locked":false,"title":"Fix using an object as arguments","user":{"login":"jrainville","id":11926403,"node_id":"MDQ6VXNlcjExOTI2NDAz","avatar_url":"https://avatars3.githubusercontent.com/u/11926403?v=4","gravatar_id":"","url":"https://api.github.com/users/jrainville","html_url":"https://github.com/jrainville","followers_url":"https://api.github.com/users/jrainville/followers","following_url":"https://api.github.com/users/jrainville/following{/other_user}","gists_url":"https://api.github.com/users/jrainville/gists{/gist_id}","starred_url":"https://api.github.com/users/jrainville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrainville/subscriptions","organizations_url":"https://api.github.com/users/jrainville/orgs","repos_url":"https://api.github.com/users/jrainville/repos","events_url":"https://api.github.com/users/jrainville/events{/privacy}","received_events_url":"https://api.github.com/users/jrainville/received_events","type":"User","site_admin":false},"body":"Fixes part of https://github.com/embark-framework/embark/issues/1028\r\nIt at least now enables to deploy completely using RPC.\r\nProblem was that somehow, we didn't parse contract args correctly if it was an object. So `_lpBase: '$LiquidPledgingMock'` returned a void address.\r\n\r\nI also added a better message for bad inputs, just in case.","created_at":"2018-11-15T19:44:41Z","updated_at":"2018-11-15T19:44:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/embark-framework/embark/pulls/1089/commits","review_comments_url":"https://api.github.com/repos/embark-framework/embark/pulls/1089/comments","review_comment_url":"https://api.github.com/repos/embark-framework/embark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/embark-framework/embark/issues/1089/comments","statuses_url":"https://api.github.com/repos/embark-framework/embark/statuses/1bb083c86ea8287eb4ce45a6db0881e7b0121041","head":{"label":"embark-framework:bug_fix/deploy-error","ref":"bug_fix/deploy-error","sha":"1bb083c86ea8287eb4ce45a6db0881e7b0121041","user":{"login":"embark-framework","id":12584440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTg0NDQw","avatar_url":"https://avatars1.githubusercontent.com/u/12584440?v=4","gravatar_id":"","url":"https://api.github.com/users/embark-framework","html_url":"https://github.com/embark-framework","followers_url":"https://api.github.com/users/embark-framework/followers","following_url":"https://api.github.com/users/embark-framework/following{/other_user}","gists_url":"https://api.github.com/users/embark-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/embark-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embark-framework/subscriptions","organizations_url":"https://api.github.com/users/embark-framework/orgs","repos_url":"https://api.github.com/users/embark-framework/repos","events_url":"https://api.github.com/users/embark-framework/events{/privacy}","received_events_url":"https://api.github.com/users/embark-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":36172821,"node_id":"MDEwOlJlcG9zaXRvcnkzNjE3MjgyMQ==","name":"embark","full_name":"embark-framework/embark","private":false,"owner":{"login":"embark-framework","id":12584440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTg0NDQw","avatar_url":"https://avatars1.githubusercontent.com/u/12584440?v=4","gravatar_id":"","url":"https://api.github.com/users/embark-framework","html_url":"https://github.com/embark-framework","followers_url":"https://api.github.com/users/embark-framework/followers","following_url":"https://api.github.com/users/embark-framework/following{/other_user}","gists_url":"https://api.github.com/users/embark-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/embark-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embark-framework/subscriptions","organizations_url":"https://api.github.com/users/embark-framework/orgs","repos_url":"https://api.github.com/users/embark-framework/repos","events_url":"https://api.github.com/users/embark-framework/events{/privacy}","received_events_url":"https://api.github.com/users/embark-framework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/embark-framework/embark","description":"Framework for serverless Decentralized Applications using Ethereum, IPFS and other platforms","fork":false,"url":"https://api.github.com/repos/embark-framework/embark","forks_url":"https://api.github.com/repos/embark-framework/embark/forks","keys_url":"https://api.github.com/repos/embark-framework/embark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embark-framework/embark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embark-framework/embark/teams","hooks_url":"https://api.github.com/repos/embark-framework/embark/hooks","issue_events_url":"https://api.github.com/repos/embark-framework/embark/issues/events{/number}","events_url":"https://api.github.com/repos/embark-framework/embark/events","assignees_url":"https://api.github.com/repos/embark-framework/embark/assignees{/user}","branches_url":"https://api.github.com/repos/embark-framework/embark/branches{/branch}","tags_url":"https://api.github.com/repos/embark-framework/embark/tags","blobs_url":"https://api.github.com/repos/embark-framework/embark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embark-framework/embark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embark-framework/embark/git/refs{/sha}","trees_url":"https://api.github.com/repos/embark-framework/embark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embark-framework/embark/statuses/{sha}","languages_url":"https://api.github.com/repos/embark-framework/embark/languages","stargazers_url":"https://api.github.com/repos/embark-framework/embark/stargazers","contributors_url":"https://api.github.com/repos/embark-framework/embark/contributors","subscribers_url":"https://api.github.com/repos/embark-framework/embark/subscribers","subscription_url":"https://api.github.com/repos/embark-framework/embark/subscription","commits_url":"https://api.github.com/repos/embark-framework/embark/commits{/sha}","git_commits_url":"https://api.github.com/repos/embark-framework/embark/git/commits{/sha}","comments_url":"https://api.github.com/repos/embark-framework/embark/comments{/number}","issue_comment_url":"https://api.github.com/repos/embark-framework/embark/issues/comments{/number}","contents_url":"https://api.github.com/repos/embark-framework/embark/contents/{+path}","compare_url":"https://api.github.com/repos/embark-framework/embark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embark-framework/embark/merges","archive_url":"https://api.github.com/repos/embark-framework/embark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embark-framework/embark/downloads","issues_url":"https://api.github.com/repos/embark-framework/embark/issues{/number}","pulls_url":"https://api.github.com/repos/embark-framework/embark/pulls{/number}","milestones_url":"https://api.github.com/repos/embark-framework/embark/milestones{/number}","notifications_url":"https://api.github.com/repos/embark-framework/embark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embark-framework/embark/labels{/name}","releases_url":"https://api.github.com/repos/embark-framework/embark/releases{/id}","deployments_url":"https://api.github.com/repos/embark-framework/embark/deployments","created_at":"2015-05-24T13:10:10Z","updated_at":"2018-11-15T19:13:00Z","pushed_at":"2018-11-15T19:41:09Z","git_url":"git://github.com/embark-framework/embark.git","ssh_url":"git@github.com:embark-framework/embark.git","clone_url":"https://github.com/embark-framework/embark.git","svn_url":"https://github.com/embark-framework/embark","homepage":"https://embark.status.im/","size":20224,"stargazers_count":2514,"watchers_count":2514,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":366,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":366,"open_issues":50,"watchers":2514,"default_branch":"master"}},"base":{"label":"embark-framework:master","ref":"master","sha":"21dff441d1440a2cac6eb791e3c921da248f741d","user":{"login":"embark-framework","id":12584440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTg0NDQw","avatar_url":"https://avatars1.githubusercontent.com/u/12584440?v=4","gravatar_id":"","url":"https://api.github.com/users/embark-framework","html_url":"https://github.com/embark-framework","followers_url":"https://api.github.com/users/embark-framework/followers","following_url":"https://api.github.com/users/embark-framework/following{/other_user}","gists_url":"https://api.github.com/users/embark-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/embark-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embark-framework/subscriptions","organizations_url":"https://api.github.com/users/embark-framework/orgs","repos_url":"https://api.github.com/users/embark-framework/repos","events_url":"https://api.github.com/users/embark-framework/events{/privacy}","received_events_url":"https://api.github.com/users/embark-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":36172821,"node_id":"MDEwOlJlcG9zaXRvcnkzNjE3MjgyMQ==","name":"embark","full_name":"embark-framework/embark","private":false,"owner":{"login":"embark-framework","id":12584440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTg0NDQw","avatar_url":"https://avatars1.githubusercontent.com/u/12584440?v=4","gravatar_id":"","url":"https://api.github.com/users/embark-framework","html_url":"https://github.com/embark-framework","followers_url":"https://api.github.com/users/embark-framework/followers","following_url":"https://api.github.com/users/embark-framework/following{/other_user}","gists_url":"https://api.github.com/users/embark-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/embark-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embark-framework/subscriptions","organizations_url":"https://api.github.com/users/embark-framework/orgs","repos_url":"https://api.github.com/users/embark-framework/repos","events_url":"https://api.github.com/users/embark-framework/events{/privacy}","received_events_url":"https://api.github.com/users/embark-framework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/embark-framework/embark","description":"Framework for serverless Decentralized Applications using Ethereum, IPFS and other platforms","fork":false,"url":"https://api.github.com/repos/embark-framework/embark","forks_url":"https://api.github.com/repos/embark-framework/embark/forks","keys_url":"https://api.github.com/repos/embark-framework/embark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embark-framework/embark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embark-framework/embark/teams","hooks_url":"https://api.github.com/repos/embark-framework/embark/hooks","issue_events_url":"https://api.github.com/repos/embark-framework/embark/issues/events{/number}","events_url":"https://api.github.com/repos/embark-framework/embark/events","assignees_url":"https://api.github.com/repos/embark-framework/embark/assignees{/user}","branches_url":"https://api.github.com/repos/embark-framework/embark/branches{/branch}","tags_url":"https://api.github.com/repos/embark-framework/embark/tags","blobs_url":"https://api.github.com/repos/embark-framework/embark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embark-framework/embark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embark-framework/embark/git/refs{/sha}","trees_url":"https://api.github.com/repos/embark-framework/embark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embark-framework/embark/statuses/{sha}","languages_url":"https://api.github.com/repos/embark-framework/embark/languages","stargazers_url":"https://api.github.com/repos/embark-framework/embark/stargazers","contributors_url":"https://api.github.com/repos/embark-framework/embark/contributors","subscribers_url":"https://api.github.com/repos/embark-framework/embark/subscribers","subscription_url":"https://api.github.com/repos/embark-framework/embark/subscription","commits_url":"https://api.github.com/repos/embark-framework/embark/commits{/sha}","git_commits_url":"https://api.github.com/repos/embark-framework/embark/git/commits{/sha}","comments_url":"https://api.github.com/repos/embark-framework/embark/comments{/number}","issue_comment_url":"https://api.github.com/repos/embark-framework/embark/issues/comments{/number}","contents_url":"https://api.github.com/repos/embark-framework/embark/contents/{+path}","compare_url":"https://api.github.com/repos/embark-framework/embark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embark-framework/embark/merges","archive_url":"https://api.github.com/repos/embark-framework/embark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embark-framework/embark/downloads","issues_url":"https://api.github.com/repos/embark-framework/embark/issues{/number}","pulls_url":"https://api.github.com/repos/embark-framework/embark/pulls{/number}","milestones_url":"https://api.github.com/repos/embark-framework/embark/milestones{/number}","notifications_url":"https://api.github.com/repos/embark-framework/embark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embark-framework/embark/labels{/name}","releases_url":"https://api.github.com/repos/embark-framework/embark/releases{/id}","deployments_url":"https://api.github.com/repos/embark-framework/embark/deployments","created_at":"2015-05-24T13:10:10Z","updated_at":"2018-11-15T19:13:00Z","pushed_at":"2018-11-15T19:41:09Z","git_url":"git://github.com/embark-framework/embark.git","ssh_url":"git@github.com:embark-framework/embark.git","clone_url":"https://github.com/embark-framework/embark.git","svn_url":"https://github.com/embark-framework/embark","homepage":"https://embark.status.im/","size":20224,"stargazers_count":2514,"watchers_count":2514,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":366,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":366,"open_issues":50,"watchers":2514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/embark-framework/embark/pulls/1089"},"html":{"href":"https://github.com/embark-framework/embark/pull/1089"},"issue":{"href":"https://api.github.com/repos/embark-framework/embark/issues/1089"},"comments":{"href":"https://api.github.com/repos/embark-framework/embark/issues/1089/comments"},"review_comments":{"href":"https://api.github.com/repos/embark-framework/embark/pulls/1089/comments"},"review_comment":{"href":"https://api.github.com/repos/embark-framework/embark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/embark-framework/embark/pulls/1089/commits"},"statuses":{"href":"https://api.github.com/repos/embark-framework/embark/statuses/1bb083c86ea8287eb4ce45a6db0881e7b0121041"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":11,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"jrainville"}}