{"action":"created","comment":{"url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/comments/197714979","pull_request_review_id":131509864,"id":197714979,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzcxNDk3OQ==","diff_hunk":"@@ -132,8 +136,12 @@ Customizable assets can be found in [the Assets repo](https://github.com/gini/gi\n \t - Image &#8594; <span style=\"color:#009EDF\">*navigationAnalysisBack*</span> image asset\n \t - Title &#8594; <span style=\"color:#009EDF\">*ginivision.navigationbar.analysis.back*</span> localized string\n \n-##### 2. Loading view\n-- Indicator color &#8594; `GiniConfiguration.analysisLoadingIndicatorColor`\n+##### 3. PDF Information view\n+- Text color &#8594; `GiniConfiguration.analysisPDFInformationTextColor`\n+- Text color &#8594; `GiniConfiguration.analysisPDFInformationBackgroundColor`\n+\n+##### 3. Loading view","path":"Documentation/source/Customization guide.md","position":35,"original_position":35,"commit_id":"e79858aa966dd20d58da5d9dcc9c4caffb3424ae","original_commit_id":"e79858aa966dd20d58da5d9dcc9c4caffb3424ae","user":{"login":"nsobadjiev","id":23211010,"node_id":"MDQ6VXNlcjIzMjExMDEw","avatar_url":"https://avatars3.githubusercontent.com/u/23211010?v=4","gravatar_id":"","url":"https://api.github.com/users/nsobadjiev","html_url":"https://github.com/nsobadjiev","followers_url":"https://api.github.com/users/nsobadjiev/followers","following_url":"https://api.github.com/users/nsobadjiev/following{/other_user}","gists_url":"https://api.github.com/users/nsobadjiev/gists{/gist_id}","starred_url":"https://api.github.com/users/nsobadjiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsobadjiev/subscriptions","organizations_url":"https://api.github.com/users/nsobadjiev/orgs","repos_url":"https://api.github.com/users/nsobadjiev/repos","events_url":"https://api.github.com/users/nsobadjiev/events{/privacy}","received_events_url":"https://api.github.com/users/nsobadjiev/received_events","type":"User","site_admin":false},"body":"After 3 comes...?\r\n1. 4\r\n2. another 3","created_at":"2018-06-25T08:26:48Z","updated_at":"2018-06-25T08:31:03Z","html_url":"https://github.com/gini/gini-vision-lib-ios/pull/255#discussion_r197714979","pull_request_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/255","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/comments/197714979"},"html":{"href":"https://github.com/gini/gini-vision-lib-ios/pull/255#discussion_r197714979"},"pull_request":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/255"}}},"pull_request":{"url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/255","id":196761670,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NzYxNjcw","html_url":"https://github.com/gini/gini-vision-lib-ios/pull/255","diff_url":"https://github.com/gini/gini-vision-lib-ios/pull/255.diff","patch_url":"https://github.com/gini/gini-vision-lib-ios/pull/255.patch","issue_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/255","number":255,"state":"open","locked":false,"title":"Last tweaks and fixes","user":{"login":"kikettas","id":9082270,"node_id":"MDQ6VXNlcjkwODIyNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/9082270?v=4","gravatar_id":"","url":"https://api.github.com/users/kikettas","html_url":"https://github.com/kikettas","followers_url":"https://api.github.com/users/kikettas/followers","following_url":"https://api.github.com/users/kikettas/following{/other_user}","gists_url":"https://api.github.com/users/kikettas/gists{/gist_id}","starred_url":"https://api.github.com/users/kikettas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikettas/subscriptions","organizations_url":"https://api.github.com/users/kikettas/orgs","repos_url":"https://api.github.com/users/kikettas/repos","events_url":"https://api.github.com/users/kikettas/events{/privacy}","received_events_url":"https://api.github.com/users/kikettas/received_events","type":"User","site_admin":false},"body":"### Description\r\nFollowing issues have been fixed:\r\n\r\n- Delete button wasn't disabled when a deletion was being performed.\r\n- Cancelled analysis was shown as an error\r\n- Mixed collections weren't taken into account when using QR codes.\r\n- Old `CameraViewController` initializers should be marked as `unavailable` and not as `deprecated` since there is a breaking change after taking the DocumentPickerCoordinator out of this screen.\r\n- The cancellation token wasn't passed to the `getExtractions` method, which made the analysis not cancellable.\r\n- `DocumentService` was used in the `GiniScreenAPICoordinator` class when it shouldn't. (networking must be always handled outside of the `Core` module)\r\n\r\nAnd also this minor additions where integrated:\r\n\r\n- Missing views styling in customization guide.\r\n- Improved performance in `MultipageReviewViewController` when it appears (collections are now reloaded in parallel and without animations)\r\n\r\n### How to test\r\n\r\n\r\n### Merging\r\nAutomatic\r\n\r\n### Issues\r\n\r\n","created_at":"2018-06-22T14:52:46Z","updated_at":"2018-06-25T08:31:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3efaa1ce3a891d95bbca18083f377ed2cd0a5640","assignee":{"login":"kikettas","id":9082270,"node_id":"MDQ6VXNlcjkwODIyNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/9082270?v=4","gravatar_id":"","url":"https://api.github.com/users/kikettas","html_url":"https://github.com/kikettas","followers_url":"https://api.github.com/users/kikettas/followers","following_url":"https://api.github.com/users/kikettas/following{/other_user}","gists_url":"https://api.github.com/users/kikettas/gists{/gist_id}","starred_url":"https://api.github.com/users/kikettas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikettas/subscriptions","organizations_url":"https://api.github.com/users/kikettas/orgs","repos_url":"https://api.github.com/users/kikettas/repos","events_url":"https://api.github.com/users/kikettas/events{/privacy}","received_events_url":"https://api.github.com/users/kikettas/received_events","type":"User","site_admin":false},"assignees":[{"login":"kikettas","id":9082270,"node_id":"MDQ6VXNlcjkwODIyNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/9082270?v=4","gravatar_id":"","url":"https://api.github.com/users/kikettas","html_url":"https://github.com/kikettas","followers_url":"https://api.github.com/users/kikettas/followers","following_url":"https://api.github.com/users/kikettas/following{/other_user}","gists_url":"https://api.github.com/users/kikettas/gists{/gist_id}","starred_url":"https://api.github.com/users/kikettas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikettas/subscriptions","organizations_url":"https://api.github.com/users/kikettas/orgs","repos_url":"https://api.github.com/users/kikettas/repos","events_url":"https://api.github.com/users/kikettas/events{/privacy}","received_events_url":"https://api.github.com/users/kikettas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":388446259,"node_id":"MDU6TGFiZWwzODg0NDYyNTk=","url":"https://api.github.com/repos/gini/gini-vision-lib-ios/labels/enhancement","name":"enhancement","color":"9effcc","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/255/commits","review_comments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/255/comments","review_comment_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/255/comments","statuses_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/statuses/e79858aa966dd20d58da5d9dcc9c4caffb3424ae","head":{"label":"gini:feature-last-fixes","ref":"feature-last-fixes","sha":"e79858aa966dd20d58da5d9dcc9c4caffb3424ae","user":{"login":"gini","id":701646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMTY0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/701646?v=4","gravatar_id":"","url":"https://api.github.com/users/gini","html_url":"https://github.com/gini","followers_url":"https://api.github.com/users/gini/followers","following_url":"https://api.github.com/users/gini/following{/other_user}","gists_url":"https://api.github.com/users/gini/gists{/gist_id}","starred_url":"https://api.github.com/users/gini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gini/subscriptions","organizations_url":"https://api.github.com/users/gini/orgs","repos_url":"https://api.github.com/users/gini/repos","events_url":"https://api.github.com/users/gini/events{/privacy}","received_events_url":"https://api.github.com/users/gini/received_events","type":"Organization","site_admin":false},"repo":{"id":60536520,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUzNjUyMA==","name":"gini-vision-lib-ios","full_name":"gini/gini-vision-lib-ios","owner":{"login":"gini","id":701646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMTY0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/701646?v=4","gravatar_id":"","url":"https://api.github.com/users/gini","html_url":"https://github.com/gini","followers_url":"https://api.github.com/users/gini/followers","following_url":"https://api.github.com/users/gini/following{/other_user}","gists_url":"https://api.github.com/users/gini/gists{/gist_id}","starred_url":"https://api.github.com/users/gini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gini/subscriptions","organizations_url":"https://api.github.com/users/gini/orgs","repos_url":"https://api.github.com/users/gini/repos","events_url":"https://api.github.com/users/gini/events{/privacy}","received_events_url":"https://api.github.com/users/gini/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gini/gini-vision-lib-ios","description":"Swift library providing components for capturing, reviewing and analyzing photos of invoices and remittance slips.","fork":false,"url":"https://api.github.com/repos/gini/gini-vision-lib-ios","forks_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/forks","keys_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/teams","hooks_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/hooks","issue_events_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/events{/number}","events_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/events","assignees_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/assignees{/user}","branches_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/branches{/branch}","tags_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/tags","blobs_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/languages","stargazers_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/stargazers","contributors_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/contributors","subscribers_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/subscribers","subscription_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/subscription","commits_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/contents/{+path}","compare_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/merges","archive_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/downloads","issues_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues{/number}","pulls_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/labels{/name}","releases_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/releases{/id}","deployments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/deployments","created_at":"2016-06-06T14:55:22Z","updated_at":"2018-06-13T15:40:18Z","pushed_at":"2018-06-22T14:52:46Z","git_url":"git://github.com/gini/gini-vision-lib-ios.git","ssh_url":"git@github.com:gini/gini-vision-lib-ios.git","clone_url":"https://github.com/gini/gini-vision-lib-ios.git","svn_url":"https://github.com/gini/gini-vision-lib-ios","homepage":"https://gini.net/en/developer/","size":15582,"stargazers_count":7,"watchers_count":7,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":14,"watchers":7,"default_branch":"master"}},"base":{"label":"gini:multipage","ref":"multipage","sha":"621df34709e7eea8fe6fe2da5c1462f27b436b35","user":{"login":"gini","id":701646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMTY0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/701646?v=4","gravatar_id":"","url":"https://api.github.com/users/gini","html_url":"https://github.com/gini","followers_url":"https://api.github.com/users/gini/followers","following_url":"https://api.github.com/users/gini/following{/other_user}","gists_url":"https://api.github.com/users/gini/gists{/gist_id}","starred_url":"https://api.github.com/users/gini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gini/subscriptions","organizations_url":"https://api.github.com/users/gini/orgs","repos_url":"https://api.github.com/users/gini/repos","events_url":"https://api.github.com/users/gini/events{/privacy}","received_events_url":"https://api.github.com/users/gini/received_events","type":"Organization","site_admin":false},"repo":{"id":60536520,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUzNjUyMA==","name":"gini-vision-lib-ios","full_name":"gini/gini-vision-lib-ios","owner":{"login":"gini","id":701646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwMTY0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/701646?v=4","gravatar_id":"","url":"https://api.github.com/users/gini","html_url":"https://github.com/gini","followers_url":"https://api.github.com/users/gini/followers","following_url":"https://api.github.com/users/gini/following{/other_user}","gists_url":"https://api.github.com/users/gini/gists{/gist_id}","starred_url":"https://api.github.com/users/gini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gini/subscriptions","organizations_url":"https://api.github.com/users/gini/orgs","repos_url":"https://api.github.com/users/gini/repos","events_url":"https://api.github.com/users/gini/events{/privacy}","received_events_url":"https://api.github.com/users/gini/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gini/gini-vision-lib-ios","description":"Swift library providing components for capturing, reviewing and analyzing photos of invoices and remittance slips.","fork":false,"url":"https://api.github.com/repos/gini/gini-vision-lib-ios","forks_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/forks","keys_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/teams","hooks_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/hooks","issue_events_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/events{/number}","events_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/events","assignees_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/assignees{/user}","branches_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/branches{/branch}","tags_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/tags","blobs_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/languages","stargazers_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/stargazers","contributors_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/contributors","subscribers_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/subscribers","subscription_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/subscription","commits_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/contents/{+path}","compare_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/merges","archive_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/downloads","issues_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues{/number}","pulls_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/labels{/name}","releases_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/releases{/id}","deployments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/deployments","created_at":"2016-06-06T14:55:22Z","updated_at":"2018-06-13T15:40:18Z","pushed_at":"2018-06-22T14:52:46Z","git_url":"git://github.com/gini/gini-vision-lib-ios.git","ssh_url":"git@github.com:gini/gini-vision-lib-ios.git","clone_url":"https://github.com/gini/gini-vision-lib-ios.git","svn_url":"https://github.com/gini/gini-vision-lib-ios","homepage":"https://gini.net/en/developer/","size":15582,"stargazers_count":7,"watchers_count":7,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":14,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/255"},"html":{"href":"https://github.com/gini/gini-vision-lib-ios/pull/255"},"issue":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/255"},"comments":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/statuses/e79858aa966dd20d58da5d9dcc9c4caffb3424ae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nsobadjiev"}}