{"action":"created","comment":{"url":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/comments/221620508","pull_request_review_id":160311124,"id":221620508,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTYyMDUwOA==","diff_hunk":"@@ -515,13 +515,15 @@ class network_message_visitor : public rai::message_visitor\n \t\t}\n \t\tnode.stats.inc (rai::stat::type::message, rai::stat::detail::confirm_req, rai::stat::dir::in);\n \t\tnode.peers.contacted (sender, message_a.header.version_using);\n-\t\tnode.process_active (message_a.block);\n-\t\tnode.active.publish (message_a.block);","path":"rai/node/node.cpp","position":5,"original_position":5,"commit_id":"3411d73b90fbbfa6d665a80b5aa52a747c1b7b2c","original_commit_id":"3411d73b90fbbfa6d665a80b5aa52a747c1b7b2c","user":{"login":"PlasmaPower","id":6006498,"node_id":"MDQ6VXNlcjYwMDY0OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6006498?v=4","gravatar_id":"","url":"https://api.github.com/users/PlasmaPower","html_url":"https://github.com/PlasmaPower","followers_url":"https://api.github.com/users/PlasmaPower/followers","following_url":"https://api.github.com/users/PlasmaPower/following{/other_user}","gists_url":"https://api.github.com/users/PlasmaPower/gists{/gist_id}","starred_url":"https://api.github.com/users/PlasmaPower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlasmaPower/subscriptions","organizations_url":"https://api.github.com/users/PlasmaPower/orgs","repos_url":"https://api.github.com/users/PlasmaPower/repos","events_url":"https://api.github.com/users/PlasmaPower/events{/privacy}","received_events_url":"https://api.github.com/users/PlasmaPower/received_events","type":"User","site_admin":false},"body":"Yeah I agree that if we're not processing the block, we don't need to call .publish","created_at":"2018-10-01T14:03:34Z","updated_at":"2018-10-01T14:03:34Z","html_url":"https://github.com/nanocurrency/raiblocks/pull/1246#discussion_r221620508","pull_request_url":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/1246","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/comments/221620508"},"html":{"href":"https://github.com/nanocurrency/raiblocks/pull/1246#discussion_r221620508"},"pull_request":{"href":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/1246"}},"in_reply_to_id":221613850},"pull_request":{"url":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/1246","id":219240410,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjQwNDEw","html_url":"https://github.com/nanocurrency/raiblocks/pull/1246","diff_url":"https://github.com/nanocurrency/raiblocks/pull/1246.diff","patch_url":"https://github.com/nanocurrency/raiblocks/pull/1246.patch","issue_url":"https://api.github.com/repos/nanocurrency/raiblocks/issues/1246","number":1246,"state":"open","locked":false,"title":" Remove processing blocks from confirm_req","user":{"login":"SergiySW","id":18710136,"node_id":"MDQ6VXNlcjE4NzEwMTM2","avatar_url":"https://avatars2.githubusercontent.com/u/18710136?v=4","gravatar_id":"","url":"https://api.github.com/users/SergiySW","html_url":"https://github.com/SergiySW","followers_url":"https://api.github.com/users/SergiySW/followers","following_url":"https://api.github.com/users/SergiySW/following{/other_user}","gists_url":"https://api.github.com/users/SergiySW/gists{/gist_id}","starred_url":"https://api.github.com/users/SergiySW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergiySW/subscriptions","organizations_url":"https://api.github.com/users/SergiySW/orgs","repos_url":"https://api.github.com/users/SergiySW/repos","events_url":"https://api.github.com/users/SergiySW/events{/privacy}","received_events_url":"https://api.github.com/users/SergiySW/received_events","type":"User","site_admin":false},"body":"To reduce unnecessary average nodes load.\r\n\r\n- addditional disable successor confirmation for nodes with disabled voting in config","created_at":"2018-10-01T01:20:18Z","updated_at":"2018-10-01T14:03:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c93aa89233bd147132097a8f009bace67816daaa","assignee":{"login":"SergiySW","id":18710136,"node_id":"MDQ6VXNlcjE4NzEwMTM2","avatar_url":"https://avatars2.githubusercontent.com/u/18710136?v=4","gravatar_id":"","url":"https://api.github.com/users/SergiySW","html_url":"https://github.com/SergiySW","followers_url":"https://api.github.com/users/SergiySW/followers","following_url":"https://api.github.com/users/SergiySW/following{/other_user}","gists_url":"https://api.github.com/users/SergiySW/gists{/gist_id}","starred_url":"https://api.github.com/users/SergiySW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergiySW/subscriptions","organizations_url":"https://api.github.com/users/SergiySW/orgs","repos_url":"https://api.github.com/users/SergiySW/repos","events_url":"https://api.github.com/users/SergiySW/events{/privacy}","received_events_url":"https://api.github.com/users/SergiySW/received_events","type":"User","site_admin":false},"assignees":[{"login":"SergiySW","id":18710136,"node_id":"MDQ6VXNlcjE4NzEwMTM2","avatar_url":"https://avatars2.githubusercontent.com/u/18710136?v=4","gravatar_id":"","url":"https://api.github.com/users/SergiySW","html_url":"https://github.com/SergiySW","followers_url":"https://api.github.com/users/SergiySW/followers","following_url":"https://api.github.com/users/SergiySW/following{/other_user}","gists_url":"https://api.github.com/users/SergiySW/gists{/gist_id}","starred_url":"https://api.github.com/users/SergiySW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergiySW/subscriptions","organizations_url":"https://api.github.com/users/SergiySW/orgs","repos_url":"https://api.github.com/users/SergiySW/repos","events_url":"https://api.github.com/users/SergiySW/events{/privacy}","received_events_url":"https://api.github.com/users/SergiySW/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":96478539,"node_id":"MDU6TGFiZWw5NjQ3ODUzOQ==","url":"https://api.github.com/repos/nanocurrency/raiblocks/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/nanocurrency/raiblocks/milestones/6","html_url":"https://github.com/nanocurrency/raiblocks/milestone/6","labels_url":"https://api.github.com/repos/nanocurrency/raiblocks/milestones/6/labels","id":3590950,"node_id":"MDk6TWlsZXN0b25lMzU5MDk1MA==","number":6,"title":"V17.0","description":"Release V17.0\r\n\r\nMajor change is lazy bootstrapping.\r\n\r\nAttempt to get an RC out 1 week prior to release date.\r\n\r\nMoving this back now 2 weeks due to on-going work with getting a stable release out.","creator":{"login":"rkeene","id":5068442,"node_id":"MDQ6VXNlcjUwNjg0NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5068442?v=4","gravatar_id":"","url":"https://api.github.com/users/rkeene","html_url":"https://github.com/rkeene","followers_url":"https://api.github.com/users/rkeene/followers","following_url":"https://api.github.com/users/rkeene/following{/other_user}","gists_url":"https://api.github.com/users/rkeene/gists{/gist_id}","starred_url":"https://api.github.com/users/rkeene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkeene/subscriptions","organizations_url":"https://api.github.com/users/rkeene/orgs","repos_url":"https://api.github.com/users/rkeene/repos","events_url":"https://api.github.com/users/rkeene/events{/privacy}","received_events_url":"https://api.github.com/users/rkeene/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":29,"state":"open","created_at":"2018-08-22T14:05:43Z","updated_at":"2018-10-01T13:48:31Z","due_on":"2018-10-05T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/1246/commits","review_comments_url":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/1246/comments","review_comment_url":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nanocurrency/raiblocks/issues/1246/comments","statuses_url":"https://api.github.com/repos/nanocurrency/raiblocks/statuses/3411d73b90fbbfa6d665a80b5aa52a747c1b7b2c","head":{"label":"SergiySW:confirm_req_processing","ref":"confirm_req_processing","sha":"3411d73b90fbbfa6d665a80b5aa52a747c1b7b2c","user":{"login":"SergiySW","id":18710136,"node_id":"MDQ6VXNlcjE4NzEwMTM2","avatar_url":"https://avatars2.githubusercontent.com/u/18710136?v=4","gravatar_id":"","url":"https://api.github.com/users/SergiySW","html_url":"https://github.com/SergiySW","followers_url":"https://api.github.com/users/SergiySW/followers","following_url":"https://api.github.com/users/SergiySW/following{/other_user}","gists_url":"https://api.github.com/users/SergiySW/gists{/gist_id}","starred_url":"https://api.github.com/users/SergiySW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergiySW/subscriptions","organizations_url":"https://api.github.com/users/SergiySW/orgs","repos_url":"https://api.github.com/users/SergiySW/repos","events_url":"https://api.github.com/users/SergiySW/events{/privacy}","received_events_url":"https://api.github.com/users/SergiySW/received_events","type":"User","site_admin":false},"repo":{"id":81691183,"node_id":"MDEwOlJlcG9zaXRvcnk4MTY5MTE4Mw==","name":"raiblocks","full_name":"SergiySW/raiblocks","private":false,"owner":{"login":"SergiySW","id":18710136,"node_id":"MDQ6VXNlcjE4NzEwMTM2","avatar_url":"https://avatars2.githubusercontent.com/u/18710136?v=4","gravatar_id":"","url":"https://api.github.com/users/SergiySW","html_url":"https://github.com/SergiySW","followers_url":"https://api.github.com/users/SergiySW/followers","following_url":"https://api.github.com/users/SergiySW/following{/other_user}","gists_url":"https://api.github.com/users/SergiySW/gists{/gist_id}","starred_url":"https://api.github.com/users/SergiySW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergiySW/subscriptions","organizations_url":"https://api.github.com/users/SergiySW/orgs","repos_url":"https://api.github.com/users/SergiySW/repos","events_url":"https://api.github.com/users/SergiySW/events{/privacy}","received_events_url":"https://api.github.com/users/SergiySW/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SergiySW/raiblocks","description":"RaiBlocks is a cryptocurrency","fork":true,"url":"https://api.github.com/repos/SergiySW/raiblocks","forks_url":"https://api.github.com/repos/SergiySW/raiblocks/forks","keys_url":"https://api.github.com/repos/SergiySW/raiblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SergiySW/raiblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SergiySW/raiblocks/teams","hooks_url":"https://api.github.com/repos/SergiySW/raiblocks/hooks","issue_events_url":"https://api.github.com/repos/SergiySW/raiblocks/issues/events{/number}","events_url":"https://api.github.com/repos/SergiySW/raiblocks/events","assignees_url":"https://api.github.com/repos/SergiySW/raiblocks/assignees{/user}","branches_url":"https://api.github.com/repos/SergiySW/raiblocks/branches{/branch}","tags_url":"https://api.github.com/repos/SergiySW/raiblocks/tags","blobs_url":"https://api.github.com/repos/SergiySW/raiblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SergiySW/raiblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SergiySW/raiblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/SergiySW/raiblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SergiySW/raiblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/SergiySW/raiblocks/languages","stargazers_url":"https://api.github.com/repos/SergiySW/raiblocks/stargazers","contributors_url":"https://api.github.com/repos/SergiySW/raiblocks/contributors","subscribers_url":"https://api.github.com/repos/SergiySW/raiblocks/subscribers","subscription_url":"https://api.github.com/repos/SergiySW/raiblocks/subscription","commits_url":"https://api.github.com/repos/SergiySW/raiblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/SergiySW/raiblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/SergiySW/raiblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/SergiySW/raiblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/SergiySW/raiblocks/contents/{+path}","compare_url":"https://api.github.com/repos/SergiySW/raiblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SergiySW/raiblocks/merges","archive_url":"https://api.github.com/repos/SergiySW/raiblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SergiySW/raiblocks/downloads","issues_url":"https://api.github.com/repos/SergiySW/raiblocks/issues{/number}","pulls_url":"https://api.github.com/repos/SergiySW/raiblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/SergiySW/raiblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/SergiySW/raiblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SergiySW/raiblocks/labels{/name}","releases_url":"https://api.github.com/repos/SergiySW/raiblocks/releases{/id}","deployments_url":"https://api.github.com/repos/SergiySW/raiblocks/deployments","created_at":"2017-02-11T23:58:27Z","updated_at":"2018-09-30T18:11:17Z","pushed_at":"2018-10-01T11:26:14Z","git_url":"git://github.com/SergiySW/raiblocks.git","ssh_url":"git@github.com:SergiySW/raiblocks.git","clone_url":"https://github.com/SergiySW/raiblocks.git","svn_url":"https://github.com/SergiySW/raiblocks","homepage":"http://raiblocks.net","size":15860,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nanocurrency:master","ref":"master","sha":"42b2a0ff8c7fa9211d187d826230bf799de381e7","user":{"login":"nanocurrency","id":34106716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTA2NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/34106716?v=4","gravatar_id":"","url":"https://api.github.com/users/nanocurrency","html_url":"https://github.com/nanocurrency","followers_url":"https://api.github.com/users/nanocurrency/followers","following_url":"https://api.github.com/users/nanocurrency/following{/other_user}","gists_url":"https://api.github.com/users/nanocurrency/gists{/gist_id}","starred_url":"https://api.github.com/users/nanocurrency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanocurrency/subscriptions","organizations_url":"https://api.github.com/users/nanocurrency/orgs","repos_url":"https://api.github.com/users/nanocurrency/repos","events_url":"https://api.github.com/users/nanocurrency/events{/privacy}","received_events_url":"https://api.github.com/users/nanocurrency/received_events","type":"Organization","site_admin":false},"repo":{"id":19347340,"node_id":"MDEwOlJlcG9zaXRvcnkxOTM0NzM0MA==","name":"raiblocks","full_name":"nanocurrency/raiblocks","private":false,"owner":{"login":"nanocurrency","id":34106716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTA2NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/34106716?v=4","gravatar_id":"","url":"https://api.github.com/users/nanocurrency","html_url":"https://github.com/nanocurrency","followers_url":"https://api.github.com/users/nanocurrency/followers","following_url":"https://api.github.com/users/nanocurrency/following{/other_user}","gists_url":"https://api.github.com/users/nanocurrency/gists{/gist_id}","starred_url":"https://api.github.com/users/nanocurrency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanocurrency/subscriptions","organizations_url":"https://api.github.com/users/nanocurrency/orgs","repos_url":"https://api.github.com/users/nanocurrency/repos","events_url":"https://api.github.com/users/nanocurrency/events{/privacy}","received_events_url":"https://api.github.com/users/nanocurrency/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nanocurrency/raiblocks","description":"Nano is a cryptocurrency","fork":false,"url":"https://api.github.com/repos/nanocurrency/raiblocks","forks_url":"https://api.github.com/repos/nanocurrency/raiblocks/forks","keys_url":"https://api.github.com/repos/nanocurrency/raiblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nanocurrency/raiblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nanocurrency/raiblocks/teams","hooks_url":"https://api.github.com/repos/nanocurrency/raiblocks/hooks","issue_events_url":"https://api.github.com/repos/nanocurrency/raiblocks/issues/events{/number}","events_url":"https://api.github.com/repos/nanocurrency/raiblocks/events","assignees_url":"https://api.github.com/repos/nanocurrency/raiblocks/assignees{/user}","branches_url":"https://api.github.com/repos/nanocurrency/raiblocks/branches{/branch}","tags_url":"https://api.github.com/repos/nanocurrency/raiblocks/tags","blobs_url":"https://api.github.com/repos/nanocurrency/raiblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nanocurrency/raiblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nanocurrency/raiblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/nanocurrency/raiblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nanocurrency/raiblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/nanocurrency/raiblocks/languages","stargazers_url":"https://api.github.com/repos/nanocurrency/raiblocks/stargazers","contributors_url":"https://api.github.com/repos/nanocurrency/raiblocks/contributors","subscribers_url":"https://api.github.com/repos/nanocurrency/raiblocks/subscribers","subscription_url":"https://api.github.com/repos/nanocurrency/raiblocks/subscription","commits_url":"https://api.github.com/repos/nanocurrency/raiblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/nanocurrency/raiblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/nanocurrency/raiblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/nanocurrency/raiblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/nanocurrency/raiblocks/contents/{+path}","compare_url":"https://api.github.com/repos/nanocurrency/raiblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nanocurrency/raiblocks/merges","archive_url":"https://api.github.com/repos/nanocurrency/raiblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nanocurrency/raiblocks/downloads","issues_url":"https://api.github.com/repos/nanocurrency/raiblocks/issues{/number}","pulls_url":"https://api.github.com/repos/nanocurrency/raiblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/nanocurrency/raiblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/nanocurrency/raiblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nanocurrency/raiblocks/labels{/name}","releases_url":"https://api.github.com/repos/nanocurrency/raiblocks/releases{/id}","deployments_url":"https://api.github.com/repos/nanocurrency/raiblocks/deployments","created_at":"2014-05-01T14:49:25Z","updated_at":"2018-10-01T14:01:44Z","pushed_at":"2018-10-01T14:02:11Z","git_url":"git://github.com/nanocurrency/raiblocks.git","ssh_url":"git@github.com:nanocurrency/raiblocks.git","clone_url":"https://github.com/nanocurrency/raiblocks.git","svn_url":"https://github.com/nanocurrency/raiblocks","homepage":"https://nano.org","size":15362,"stargazers_count":2227,"watchers_count":2227,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":492,"mirror_url":null,"archived":false,"open_issues_count":204,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":492,"open_issues":204,"watchers":2227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/1246"},"html":{"href":"https://github.com/nanocurrency/raiblocks/pull/1246"},"issue":{"href":"https://api.github.com/repos/nanocurrency/raiblocks/issues/1246"},"comments":{"href":"https://api.github.com/repos/nanocurrency/raiblocks/issues/1246/comments"},"review_comments":{"href":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/1246/comments"},"review_comment":{"href":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nanocurrency/raiblocks/pulls/1246/commits"},"statuses":{"href":"https://api.github.com/repos/nanocurrency/raiblocks/statuses/3411d73b90fbbfa6d665a80b5aa52a747c1b7b2c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"PlasmaPower"}}