{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/189450463","pull_request_review_id":121635146,"id":189450463,"diff_hunk":"@@ -337,6 +339,11 @@ class CBlockIndex\n         return ((nStatus & BLOCK_VALID_MASK) >= nUpTo);\n     }\n \n+    //! Check whether the block associated with this index entry is pruned or not.\n+    inline bool IsPruned() const {","path":"src/chain.h","position":null,"original_position":14,"commit_id":"5d6f03da92c4573a2cfcf8d0e32ca533fa151b35","original_commit_id":"a0e2648534baa338989a628ff29d2937098f5be1","user":{"login":"kallewoof","id":250224,"avatar_url":"https://avatars3.githubusercontent.com/u/250224?v=4","gravatar_id":"","url":"https://api.github.com/users/kallewoof","html_url":"https://github.com/kallewoof","followers_url":"https://api.github.com/users/kallewoof/followers","following_url":"https://api.github.com/users/kallewoof/following{/other_user}","gists_url":"https://api.github.com/users/kallewoof/gists{/gist_id}","starred_url":"https://api.github.com/users/kallewoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kallewoof/subscriptions","organizations_url":"https://api.github.com/users/kallewoof/orgs","repos_url":"https://api.github.com/users/kallewoof/repos","events_url":"https://api.github.com/users/kallewoof/events{/privacy}","received_events_url":"https://api.github.com/users/kallewoof/received_events","type":"User","site_admin":false},"body":"Good point. I moved it (back) to `validation.h`.","created_at":"2018-05-20T03:48:55Z","updated_at":"2018-05-20T03:48:55Z","html_url":"https://github.com/bitcoin/bitcoin/pull/13259#discussion_r189450463","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13259","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/189450463"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/13259#discussion_r189450463"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13259"}},"in_reply_to_id":189442183},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13259","id":188646228,"html_url":"https://github.com/bitcoin/bitcoin/pull/13259","diff_url":"https://github.com/bitcoin/bitcoin/pull/13259.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/13259.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13259","number":13259,"state":"open","locked":false,"title":"refactoring: add a method for determining if a block is pruned or not","user":{"login":"kallewoof","id":250224,"avatar_url":"https://avatars3.githubusercontent.com/u/250224?v=4","gravatar_id":"","url":"https://api.github.com/users/kallewoof","html_url":"https://github.com/kallewoof","followers_url":"https://api.github.com/users/kallewoof/followers","following_url":"https://api.github.com/users/kallewoof/following{/other_user}","gists_url":"https://api.github.com/users/kallewoof/gists{/gist_id}","starred_url":"https://api.github.com/users/kallewoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kallewoof/subscriptions","organizations_url":"https://api.github.com/users/kallewoof/orgs","repos_url":"https://api.github.com/users/kallewoof/repos","events_url":"https://api.github.com/users/kallewoof/events{/privacy}","received_events_url":"https://api.github.com/users/kallewoof/received_events","type":"User","site_admin":false},"body":"The check for whether a block is pruned or not is sufficiently obscure that it deserves a macro. It is also used in 2 places, ~~with more coming, e.g. #10757~~ (turns out it was a move, not an addition). ","created_at":"2018-05-17T07:31:38Z","updated_at":"2018-05-20T03:48:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6196e4409e789c41423379b739d7c9ddc97dd3b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135961,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13259/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13259/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13259/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/5d6f03da92c4573a2cfcf8d0e32ca533fa151b35","head":{"label":"kallewoof:block-pruned-macro","ref":"block-pruned-macro","sha":"5d6f03da92c4573a2cfcf8d0e32ca533fa151b35","user":{"login":"kallewoof","id":250224,"avatar_url":"https://avatars3.githubusercontent.com/u/250224?v=4","gravatar_id":"","url":"https://api.github.com/users/kallewoof","html_url":"https://github.com/kallewoof","followers_url":"https://api.github.com/users/kallewoof/followers","following_url":"https://api.github.com/users/kallewoof/following{/other_user}","gists_url":"https://api.github.com/users/kallewoof/gists{/gist_id}","starred_url":"https://api.github.com/users/kallewoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kallewoof/subscriptions","organizations_url":"https://api.github.com/users/kallewoof/orgs","repos_url":"https://api.github.com/users/kallewoof/repos","events_url":"https://api.github.com/users/kallewoof/events{/privacy}","received_events_url":"https://api.github.com/users/kallewoof/received_events","type":"User","site_admin":false},"repo":{"id":74733553,"name":"bitcoin","full_name":"kallewoof/bitcoin","owner":{"login":"kallewoof","id":250224,"avatar_url":"https://avatars3.githubusercontent.com/u/250224?v=4","gravatar_id":"","url":"https://api.github.com/users/kallewoof","html_url":"https://github.com/kallewoof","followers_url":"https://api.github.com/users/kallewoof/followers","following_url":"https://api.github.com/users/kallewoof/following{/other_user}","gists_url":"https://api.github.com/users/kallewoof/gists{/gist_id}","starred_url":"https://api.github.com/users/kallewoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kallewoof/subscriptions","organizations_url":"https://api.github.com/users/kallewoof/orgs","repos_url":"https://api.github.com/users/kallewoof/repos","events_url":"https://api.github.com/users/kallewoof/events{/privacy}","received_events_url":"https://api.github.com/users/kallewoof/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kallewoof/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/kallewoof/bitcoin","forks_url":"https://api.github.com/repos/kallewoof/bitcoin/forks","keys_url":"https://api.github.com/repos/kallewoof/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kallewoof/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kallewoof/bitcoin/teams","hooks_url":"https://api.github.com/repos/kallewoof/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/kallewoof/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/kallewoof/bitcoin/events","assignees_url":"https://api.github.com/repos/kallewoof/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/kallewoof/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/kallewoof/bitcoin/tags","blobs_url":"https://api.github.com/repos/kallewoof/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kallewoof/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kallewoof/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kallewoof/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kallewoof/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/kallewoof/bitcoin/languages","stargazers_url":"https://api.github.com/repos/kallewoof/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/kallewoof/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/kallewoof/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/kallewoof/bitcoin/subscription","commits_url":"https://api.github.com/repos/kallewoof/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kallewoof/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kallewoof/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kallewoof/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kallewoof/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/kallewoof/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kallewoof/bitcoin/merges","archive_url":"https://api.github.com/repos/kallewoof/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kallewoof/bitcoin/downloads","issues_url":"https://api.github.com/repos/kallewoof/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/kallewoof/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/kallewoof/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/kallewoof/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kallewoof/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/kallewoof/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/kallewoof/bitcoin/deployments","created_at":"2016-11-25T06:59:31Z","updated_at":"2018-05-17T03:52:36Z","pushed_at":"2018-05-20T03:46:29Z","git_url":"git://github.com/kallewoof/bitcoin.git","ssh_url":"git@github.com:kallewoof/bitcoin.git","clone_url":"https://github.com/kallewoof/bitcoin.git","svn_url":"https://github.com/kallewoof/bitcoin","homepage":"https://bitcoin.org/en/download","size":104732,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"d792e47421fcb9ce3b381c1e6d8902777ae3f9f3","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-05-20T03:14:22Z","pushed_at":"2018-05-20T03:46:54Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":105805,"stargazers_count":31635,"watchers_count":31635,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":19025,"mirror_url":null,"archived":false,"open_issues_count":788,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":19025,"open_issues":788,"watchers":31635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13259"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/13259"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/13259"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/13259/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13259/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13259/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/5d6f03da92c4573a2cfcf8d0e32ca533fa151b35"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kallewoof"}}