{"action":"closed","number":14453,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/14453","id":178416461,"html_url":"https://github.com/magento/magento2/pull/14453","diff_url":"https://github.com/magento/magento2/pull/14453.diff","patch_url":"https://github.com/magento/magento2/pull/14453.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/14453","number":14453,"state":"closed","locked":false,"title":"[ForwardPort 2.3-develop] Remove else statements from \\Magento\\Framework\\Session\\SessionManager","user":{"login":"adrian-martinez-interactiv4","id":17545750,"avatar_url":"https://avatars1.githubusercontent.com/u/17545750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-martinez-interactiv4","html_url":"https://github.com/adrian-martinez-interactiv4","followers_url":"https://api.github.com/users/adrian-martinez-interactiv4/followers","following_url":"https://api.github.com/users/adrian-martinez-interactiv4/following{/other_user}","gists_url":"https://api.github.com/users/adrian-martinez-interactiv4/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-martinez-interactiv4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-martinez-interactiv4/subscriptions","organizations_url":"https://api.github.com/users/adrian-martinez-interactiv4/orgs","repos_url":"https://api.github.com/users/adrian-martinez-interactiv4/repos","events_url":"https://api.github.com/users/adrian-martinez-interactiv4/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-martinez-interactiv4/received_events","type":"User","site_admin":false},"body":"Related with PR https://github.com/magento/magento2/pull/14452\r\n\r\n### Description\r\nRemove else statements from \\Magento\\Framework\\Session\\SessionManager\r\n\r\n### Fixed Issues (if relevant)\r\n<!--- Provide a list of fixed issues in the format magento/magento2#<issue_number>, if relevant  -->\r\nNone, improvement\r\n\r\n### Manual testing scenarios\r\nNone, improvement\r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [x] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [x] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-03-29T19:13:07Z","updated_at":"2018-04-02T11:17:37Z","closed_at":"2018-04-02T11:17:37Z","merged_at":"2018-04-02T11:17:37Z","merge_commit_sha":"21bf482f698b585e7a1e4b96fabc3e9320bec11a","assignee":{"login":"sidolov","id":11355520,"avatar_url":"https://avatars3.githubusercontent.com/u/11355520?v=4","gravatar_id":"","url":"https://api.github.com/users/sidolov","html_url":"https://github.com/sidolov","followers_url":"https://api.github.com/users/sidolov/followers","following_url":"https://api.github.com/users/sidolov/following{/other_user}","gists_url":"https://api.github.com/users/sidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/sidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidolov/subscriptions","organizations_url":"https://api.github.com/users/sidolov/orgs","repos_url":"https://api.github.com/users/sidolov/repos","events_url":"https://api.github.com/users/sidolov/events{/privacy}","received_events_url":"https://api.github.com/users/sidolov/received_events","type":"User","site_admin":false},"assignees":[{"login":"sidolov","id":11355520,"avatar_url":"https://avatars3.githubusercontent.com/u/11355520?v=4","gravatar_id":"","url":"https://api.github.com/users/sidolov","html_url":"https://github.com/sidolov","followers_url":"https://api.github.com/users/sidolov/followers","following_url":"https://api.github.com/users/sidolov/following{/other_user}","gists_url":"https://api.github.com/users/sidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/sidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidolov/subscriptions","organizations_url":"https://api.github.com/users/sidolov/orgs","repos_url":"https://api.github.com/users/sidolov/repos","events_url":"https://api.github.com/users/sidolov/events{/privacy}","received_events_url":"https://api.github.com/users/sidolov/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":721429227,"url":"https://api.github.com/repos/magento/magento2/labels/2.3-develop","name":"2.3-develop","color":"fbca04","default":false},{"id":883455843,"url":"https://api.github.com/repos/magento/magento2/labels/Partner:%20Interactiv4","name":"Partner: Interactiv4","color":"ededed","default":false},{"id":164491159,"url":"https://api.github.com/repos/magento/magento2/labels/accept","name":"accept","color":"009800","default":false},{"id":882948356,"url":"https://api.github.com/repos/magento/magento2/labels/partners-contribution","name":"partners-contribution","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/magento/magento2/milestones/14","html_url":"https://github.com/magento/magento2/milestone/14","labels_url":"https://api.github.com/repos/magento/magento2/milestones/14/labels","id":3152085,"number":14,"title":"March 2018","description":"Pull Requests processed in March 2018","creator":{"login":"okorshenko","id":7325075,"avatar_url":"https://avatars1.githubusercontent.com/u/7325075?v=4","gravatar_id":"","url":"https://api.github.com/users/okorshenko","html_url":"https://github.com/okorshenko","followers_url":"https://api.github.com/users/okorshenko/followers","following_url":"https://api.github.com/users/okorshenko/following{/other_user}","gists_url":"https://api.github.com/users/okorshenko/gists{/gist_id}","starred_url":"https://api.github.com/users/okorshenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okorshenko/subscriptions","organizations_url":"https://api.github.com/users/okorshenko/orgs","repos_url":"https://api.github.com/users/okorshenko/repos","events_url":"https://api.github.com/users/okorshenko/events{/privacy}","received_events_url":"https://api.github.com/users/okorshenko/received_events","type":"User","site_admin":false},"open_issues":91,"closed_issues":234,"state":"open","created_at":"2018-03-01T00:46:51Z","updated_at":"2018-04-02T11:17:37Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/magento/magento2/pulls/14453/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/14453/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/14453/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/21bf482f698b585e7a1e4b96fabc3e9320bec11a","head":{"label":"adrian-martinez-interactiv4:FR23#REMOVE-ELSE-FRAMEWORK-SESSION-MANAGER","ref":"FR23#REMOVE-ELSE-FRAMEWORK-SESSION-MANAGER","sha":"21bf482f698b585e7a1e4b96fabc3e9320bec11a","user":{"login":"adrian-martinez-interactiv4","id":17545750,"avatar_url":"https://avatars1.githubusercontent.com/u/17545750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-martinez-interactiv4","html_url":"https://github.com/adrian-martinez-interactiv4","followers_url":"https://api.github.com/users/adrian-martinez-interactiv4/followers","following_url":"https://api.github.com/users/adrian-martinez-interactiv4/following{/other_user}","gists_url":"https://api.github.com/users/adrian-martinez-interactiv4/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-martinez-interactiv4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-martinez-interactiv4/subscriptions","organizations_url":"https://api.github.com/users/adrian-martinez-interactiv4/orgs","repos_url":"https://api.github.com/users/adrian-martinez-interactiv4/repos","events_url":"https://api.github.com/users/adrian-martinez-interactiv4/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-martinez-interactiv4/received_events","type":"User","site_admin":false},"repo":{"id":89414464,"name":"magento2","full_name":"adrian-martinez-interactiv4/magento2","owner":{"login":"adrian-martinez-interactiv4","id":17545750,"avatar_url":"https://avatars1.githubusercontent.com/u/17545750?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-martinez-interactiv4","html_url":"https://github.com/adrian-martinez-interactiv4","followers_url":"https://api.github.com/users/adrian-martinez-interactiv4/followers","following_url":"https://api.github.com/users/adrian-martinez-interactiv4/following{/other_user}","gists_url":"https://api.github.com/users/adrian-martinez-interactiv4/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-martinez-interactiv4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-martinez-interactiv4/subscriptions","organizations_url":"https://api.github.com/users/adrian-martinez-interactiv4/orgs","repos_url":"https://api.github.com/users/adrian-martinez-interactiv4/repos","events_url":"https://api.github.com/users/adrian-martinez-interactiv4/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-martinez-interactiv4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrian-martinez-interactiv4/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2","forks_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/forks","keys_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/teams","hooks_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/hooks","issue_events_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/events","assignees_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/tags","blobs_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/languages","stargazers_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/stargazers","contributors_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/contributors","subscribers_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/subscribers","subscription_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/subscription","commits_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/merges","archive_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/downloads","issues_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/labels{/name}","releases_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/adrian-martinez-interactiv4/magento2/deployments","created_at":"2017-04-25T23:01:10Z","updated_at":"2018-02-06T01:27:06Z","pushed_at":"2018-03-29T19:10:50Z","git_url":"git://github.com/adrian-martinez-interactiv4/magento2.git","ssh_url":"git@github.com:adrian-martinez-interactiv4/magento2.git","clone_url":"https://github.com/adrian-martinez-interactiv4/magento2.git","svn_url":"https://github.com/adrian-martinez-interactiv4/magento2","homepage":"http://www.magento.com","size":431374,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"0a24e128a0624069b154890b17b5945ca88358ed","user":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"name":"magento2","full_name":"magento/magento2","owner":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-04-02T10:02:56Z","pushed_at":"2018-04-02T11:17:19Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":431471,"stargazers_count":5422,"watchers_count":5422,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4508,"mirror_url":null,"archived":false,"open_issues_count":1268,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4508,"open_issues":1268,"watchers":5422,"default_branch":"2.2-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/14453"},"html":{"href":"https://github.com/magento/magento2/pull/14453"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/14453"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/14453/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/14453/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/14453/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/21bf482f698b585e7a1e4b96fabc3e9320bec11a"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"magento-engcom-team","id":31669971,"avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"magento-engcom-team"}}