{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/comments/205800130","pull_request_review_id":141144909,"id":205800130,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTgwMDEzMA==","diff_hunk":"@@ -0,0 +1,70 @@\n+require 'util/mount/miq_generic_mount_session'\n+\n+class MiqS3Session < MiqGenericMountSession\n+  def initialize(log_settings)\n+    log_header = \"MIQ(#{self.class.name}-initialize)\"\n+    logger.debug(\"#{log_header} initialize: log_settings are #{log_settings}\")\n+    super(log_settings)\n+    logger.debug(\"#{log_header} initialize: @settings are #{@settings}\")\n+    # NOTE: This line to be removed once manageiq-ui-class region change implemented.\n+    @settings[:region] = \"us-east-1\" if @settings[:region].nil?\n+    raise \"username, password, and region are required values!\" if @settings[:username].nil? || @settings[:password].nil? || @settings[:region].nil?\n+    @host       = URI(@settings[:uri]).host\n+    @mount_path = URI(@settings[:uri]).path\n+  end\n+\n+  def connect","path":"lib/gems/pending/util/mount/miq_s3_session.rb","position":16,"original_position":16,"commit_id":"b716e29b58699419e8a5951128495034af12820e","original_commit_id":"b716e29b58699419e8a5951128495034af12820e","user":{"login":"jerryk55","id":6118503,"node_id":"MDQ6VXNlcjYxMTg1MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/6118503?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryk55","html_url":"https://github.com/jerryk55","followers_url":"https://api.github.com/users/jerryk55/followers","following_url":"https://api.github.com/users/jerryk55/following{/other_user}","gists_url":"https://api.github.com/users/jerryk55/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryk55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryk55/subscriptions","organizations_url":"https://api.github.com/users/jerryk55/orgs","repos_url":"https://api.github.com/users/jerryk55/repos","events_url":"https://api.github.com/users/jerryk55/events{/privacy}","received_events_url":"https://api.github.com/users/jerryk55/received_events","type":"User","site_admin":false},"body":"Here's your comment from 11 days ago (below) - \"Why even bother having content here? I think it would be more clear to set @host and @mount_path on initialize and leave this method with no content with a comment that explains that you don't really have to \"connect\" to the object store.\"  ","created_at":"2018-07-27T14:49:40Z","updated_at":"2018-07-27T14:49:40Z","html_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/355#discussion_r205800130","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/355","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/comments/205800130"},"html":{"href":"https://github.com/ManageIQ/manageiq-gems-pending/pull/355#discussion_r205800130"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/355"}},"in_reply_to_id":205785459},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/355","id":197440511,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDQwNTEx","html_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/355","diff_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/355.diff","patch_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/355.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/355","number":355,"state":"open","locked":false,"title":"Support S3 for DB Backups","user":{"login":"jerryk55","id":6118503,"node_id":"MDQ6VXNlcjYxMTg1MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/6118503?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryk55","html_url":"https://github.com/jerryk55","followers_url":"https://api.github.com/users/jerryk55/followers","following_url":"https://api.github.com/users/jerryk55/following{/other_user}","gists_url":"https://api.github.com/users/jerryk55/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryk55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryk55/subscriptions","organizations_url":"https://api.github.com/users/jerryk55/orgs","repos_url":"https://api.github.com/users/jerryk55/repos","events_url":"https://api.github.com/users/jerryk55/events{/privacy}","received_events_url":"https://api.github.com/users/jerryk55/received_events","type":"User","site_admin":false},"body":"Initial commit to support DB backups to S3.\r\n\r\nFor RFE in https://bugzilla.redhat.com/show_bug.cgi?id=1513520\r\n\r\n@roliveri please review.\r\n\r\nCoincides with PRs\r\nhttps://github.com/ManageIQ/manageiq-ui-classic/pull/4300\r\nhttps://github.com/ManageIQ/manageiq-schema/pull/227\r\nhttps://github.com/ManageIQ/manageiq/pull/17689","created_at":"2018-06-26T14:21:25Z","updated_at":"2018-07-27T14:49:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ac441963965efa7738753fec5fc61c860a8dab5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/355/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/355/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/355/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/statuses/b716e29b58699419e8a5951128495034af12820e","head":{"label":"jerryk55:s3_db_backup","ref":"s3_db_backup","sha":"b716e29b58699419e8a5951128495034af12820e","user":{"login":"jerryk55","id":6118503,"node_id":"MDQ6VXNlcjYxMTg1MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/6118503?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryk55","html_url":"https://github.com/jerryk55","followers_url":"https://api.github.com/users/jerryk55/followers","following_url":"https://api.github.com/users/jerryk55/following{/other_user}","gists_url":"https://api.github.com/users/jerryk55/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryk55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryk55/subscriptions","organizations_url":"https://api.github.com/users/jerryk55/orgs","repos_url":"https://api.github.com/users/jerryk55/repos","events_url":"https://api.github.com/users/jerryk55/events{/privacy}","received_events_url":"https://api.github.com/users/jerryk55/received_events","type":"User","site_admin":false},"repo":{"id":74053392,"node_id":"MDEwOlJlcG9zaXRvcnk3NDA1MzM5Mg==","name":"manageiq-gems-pending","full_name":"jerryk55/manageiq-gems-pending","owner":{"login":"jerryk55","id":6118503,"node_id":"MDQ6VXNlcjYxMTg1MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/6118503?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryk55","html_url":"https://github.com/jerryk55","followers_url":"https://api.github.com/users/jerryk55/followers","following_url":"https://api.github.com/users/jerryk55/following{/other_user}","gists_url":"https://api.github.com/users/jerryk55/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryk55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryk55/subscriptions","organizations_url":"https://api.github.com/users/jerryk55/orgs","repos_url":"https://api.github.com/users/jerryk55/repos","events_url":"https://api.github.com/users/jerryk55/events{/privacy}","received_events_url":"https://api.github.com/users/jerryk55/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerryk55/manageiq-gems-pending","description":"Gems Pending to be extracted for ManageIQ project.","fork":true,"url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending","forks_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/forks","keys_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/teams","hooks_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/hooks","issue_events_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/issues/events{/number}","events_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/events","assignees_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/assignees{/user}","branches_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/branches{/branch}","tags_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/tags","blobs_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/languages","stargazers_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/stargazers","contributors_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/contributors","subscribers_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/subscribers","subscription_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/subscription","commits_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/contents/{+path}","compare_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/merges","archive_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/downloads","issues_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/issues{/number}","pulls_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/labels{/name}","releases_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/releases{/id}","deployments_url":"https://api.github.com/repos/jerryk55/manageiq-gems-pending/deployments","created_at":"2016-11-17T18:00:45Z","updated_at":"2016-11-17T18:00:56Z","pushed_at":"2018-07-26T14:53:46Z","git_url":"git://github.com/jerryk55/manageiq-gems-pending.git","ssh_url":"git@github.com:jerryk55/manageiq-gems-pending.git","clone_url":"https://github.com/jerryk55/manageiq-gems-pending.git","svn_url":"https://github.com/jerryk55/manageiq-gems-pending","homepage":"","size":32896,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"e92faf72a1d1d9110bdb2fbd785710bf14ce927f","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":72789777,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjc4OTc3Nw==","name":"manageiq-gems-pending","full_name":"ManageIQ/manageiq-gems-pending","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-gems-pending","description":"Gems Pending to be extracted for ManageIQ project.","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/deployments","created_at":"2016-11-03T21:46:14Z","updated_at":"2018-06-06T13:27:08Z","pushed_at":"2018-07-26T14:56:43Z","git_url":"git://github.com/ManageIQ/manageiq-gems-pending.git","ssh_url":"git@github.com:ManageIQ/manageiq-gems-pending.git","clone_url":"https://github.com/ManageIQ/manageiq-gems-pending.git","svn_url":"https://github.com/ManageIQ/manageiq-gems-pending","homepage":"","size":32905,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":62,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/355"},"html":{"href":"https://github.com/ManageIQ/manageiq-gems-pending/pull/355"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/355"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/355/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/355/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/355/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/statuses/b716e29b58699419e8a5951128495034af12820e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jerryk55"}}