{"action":"created","comment":{"url":"https://api.github.com/repos/BBC-News/simorgh/pulls/comments/237157991","pull_request_review_id":179388425,"id":237157991,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzE1Nzk5MQ==","diff_hunk":"@@ -65,7 +65,7 @@ exports[`Text should render a <figcaption> as per the Caption component override\n   <span\n     className=\"c1\"\n   >\n-    Image caption, \n+    ","path":"src/app/components/Text/__snapshots__/index.test.jsx.snap","position":5,"original_position":5,"commit_id":"3088698eb92fcd46d859733484370594256ab0d3","original_commit_id":"3088698eb92fcd46d859733484370594256ab0d3","user":{"login":"pjlee11","id":7791726,"node_id":"MDQ6VXNlcjc3OTE3MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/7791726?v=4","gravatar_id":"","url":"https://api.github.com/users/pjlee11","html_url":"https://github.com/pjlee11","followers_url":"https://api.github.com/users/pjlee11/followers","following_url":"https://api.github.com/users/pjlee11/following{/other_user}","gists_url":"https://api.github.com/users/pjlee11/gists{/gist_id}","starred_url":"https://api.github.com/users/pjlee11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjlee11/subscriptions","organizations_url":"https://api.github.com/users/pjlee11/orgs","repos_url":"https://api.github.com/users/pjlee11/repos","events_url":"https://api.github.com/users/pjlee11/events{/privacy}","received_events_url":"https://api.github.com/users/pjlee11/received_events","type":"User","site_admin":false},"body":"If the higher order component was exported could it not be reused by the test (and story if a caption story is needed in text - probably shouldn't have one)? That said, I do get your point that the Text component shouldn't really be aware of the caption. ","created_at":"2018-11-28T16:23:10Z","updated_at":"2018-11-28T16:23:11Z","html_url":"https://github.com/BBC-News/simorgh/pull/1019#discussion_r237157991","pull_request_url":"https://api.github.com/repos/BBC-News/simorgh/pulls/1019","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/BBC-News/simorgh/pulls/comments/237157991"},"html":{"href":"https://github.com/BBC-News/simorgh/pull/1019#discussion_r237157991"},"pull_request":{"href":"https://api.github.com/repos/BBC-News/simorgh/pulls/1019"}},"in_reply_to_id":237153406},"pull_request":{"url":"https://api.github.com/repos/BBC-News/simorgh/pulls/1019","id":234326025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzI2MDI1","html_url":"https://github.com/BBC-News/simorgh/pull/1019","diff_url":"https://github.com/BBC-News/simorgh/pull/1019.diff","patch_url":"https://github.com/BBC-News/simorgh/pull/1019.patch","issue_url":"https://api.github.com/repos/BBC-News/simorgh/issues/1019","number":1019,"state":"open","locked":false,"title":"Remove usages of ServiceContext from Caption component","user":{"login":"bcmn","id":11646957,"node_id":"MDQ6VXNlcjExNjQ2OTU3","avatar_url":"https://avatars3.githubusercontent.com/u/11646957?v=4","gravatar_id":"","url":"https://api.github.com/users/bcmn","html_url":"https://github.com/bcmn","followers_url":"https://api.github.com/users/bcmn/followers","following_url":"https://api.github.com/users/bcmn/following{/other_user}","gists_url":"https://api.github.com/users/bcmn/gists{/gist_id}","starred_url":"https://api.github.com/users/bcmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcmn/subscriptions","organizations_url":"https://api.github.com/users/bcmn/orgs","repos_url":"https://api.github.com/users/bcmn/repos","events_url":"https://api.github.com/users/bcmn/events{/privacy}","received_events_url":"https://api.github.com/users/bcmn/received_events","type":"User","site_admin":false},"body":"Resolves #995. \r\n\r\nA small change which ended up pulling in quite a bit more... 😅 This PR:\r\n\r\n**Component Layer**\r\n* Changes the Figure Caption component to simply receive any VisuallyHiddenText from a prop, instead of the ServiceContext\r\n* Updates the Figure Caption component tests to remove all references to ServiceContext, & simply test this new behaviour.\r\n* Similarly, updates Text component tests to remove references to ServiceContext\r\n\r\n**Container Layer**\r\n* Logic for determining the offscreen text for Caption was moved to the container layer. In doing so, this increased the amount of container logic specifically for the Caption, so it was pulled out into a new Caption container.\r\n* Adds snapshot tests for the new Caption container, testing under the usage of ServiceContextProvider.\r\n\r\n- [x] Tests added for new features\r\n- [ ] Test engineer approval","created_at":"2018-11-28T15:46:15Z","updated_at":"2018-11-28T16:23:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f20880f67c0b0100a29d0657ca359b1fca3544cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BBC-News/simorgh/pulls/1019/commits","review_comments_url":"https://api.github.com/repos/BBC-News/simorgh/pulls/1019/comments","review_comment_url":"https://api.github.com/repos/BBC-News/simorgh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BBC-News/simorgh/issues/1019/comments","statuses_url":"https://api.github.com/repos/BBC-News/simorgh/statuses/3088698eb92fcd46d859733484370594256ab0d3","head":{"label":"BBC-News:caption-refactor","ref":"caption-refactor","sha":"3088698eb92fcd46d859733484370594256ab0d3","user":{"login":"BBC-News","id":1401475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE0NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1401475?v=4","gravatar_id":"","url":"https://api.github.com/users/BBC-News","html_url":"https://github.com/BBC-News","followers_url":"https://api.github.com/users/BBC-News/followers","following_url":"https://api.github.com/users/BBC-News/following{/other_user}","gists_url":"https://api.github.com/users/BBC-News/gists{/gist_id}","starred_url":"https://api.github.com/users/BBC-News/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBC-News/subscriptions","organizations_url":"https://api.github.com/users/BBC-News/orgs","repos_url":"https://api.github.com/users/BBC-News/repos","events_url":"https://api.github.com/users/BBC-News/events{/privacy}","received_events_url":"https://api.github.com/users/BBC-News/received_events","type":"Organization","site_admin":false},"repo":{"id":133968906,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Njg5MDY=","name":"simorgh","full_name":"BBC-News/simorgh","private":false,"owner":{"login":"BBC-News","id":1401475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE0NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1401475?v=4","gravatar_id":"","url":"https://api.github.com/users/BBC-News","html_url":"https://github.com/BBC-News","followers_url":"https://api.github.com/users/BBC-News/followers","following_url":"https://api.github.com/users/BBC-News/following{/other_user}","gists_url":"https://api.github.com/users/BBC-News/gists{/gist_id}","starred_url":"https://api.github.com/users/BBC-News/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBC-News/subscriptions","organizations_url":"https://api.github.com/users/BBC-News/orgs","repos_url":"https://api.github.com/users/BBC-News/repos","events_url":"https://api.github.com/users/BBC-News/events{/privacy}","received_events_url":"https://api.github.com/users/BBC-News/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BBC-News/simorgh","description":"The BBC's new article (soon... we hope)","fork":false,"url":"https://api.github.com/repos/BBC-News/simorgh","forks_url":"https://api.github.com/repos/BBC-News/simorgh/forks","keys_url":"https://api.github.com/repos/BBC-News/simorgh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BBC-News/simorgh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BBC-News/simorgh/teams","hooks_url":"https://api.github.com/repos/BBC-News/simorgh/hooks","issue_events_url":"https://api.github.com/repos/BBC-News/simorgh/issues/events{/number}","events_url":"https://api.github.com/repos/BBC-News/simorgh/events","assignees_url":"https://api.github.com/repos/BBC-News/simorgh/assignees{/user}","branches_url":"https://api.github.com/repos/BBC-News/simorgh/branches{/branch}","tags_url":"https://api.github.com/repos/BBC-News/simorgh/tags","blobs_url":"https://api.github.com/repos/BBC-News/simorgh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BBC-News/simorgh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BBC-News/simorgh/git/refs{/sha}","trees_url":"https://api.github.com/repos/BBC-News/simorgh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BBC-News/simorgh/statuses/{sha}","languages_url":"https://api.github.com/repos/BBC-News/simorgh/languages","stargazers_url":"https://api.github.com/repos/BBC-News/simorgh/stargazers","contributors_url":"https://api.github.com/repos/BBC-News/simorgh/contributors","subscribers_url":"https://api.github.com/repos/BBC-News/simorgh/subscribers","subscription_url":"https://api.github.com/repos/BBC-News/simorgh/subscription","commits_url":"https://api.github.com/repos/BBC-News/simorgh/commits{/sha}","git_commits_url":"https://api.github.com/repos/BBC-News/simorgh/git/commits{/sha}","comments_url":"https://api.github.com/repos/BBC-News/simorgh/comments{/number}","issue_comment_url":"https://api.github.com/repos/BBC-News/simorgh/issues/comments{/number}","contents_url":"https://api.github.com/repos/BBC-News/simorgh/contents/{+path}","compare_url":"https://api.github.com/repos/BBC-News/simorgh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BBC-News/simorgh/merges","archive_url":"https://api.github.com/repos/BBC-News/simorgh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BBC-News/simorgh/downloads","issues_url":"https://api.github.com/repos/BBC-News/simorgh/issues{/number}","pulls_url":"https://api.github.com/repos/BBC-News/simorgh/pulls{/number}","milestones_url":"https://api.github.com/repos/BBC-News/simorgh/milestones{/number}","notifications_url":"https://api.github.com/repos/BBC-News/simorgh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BBC-News/simorgh/labels{/name}","releases_url":"https://api.github.com/repos/BBC-News/simorgh/releases{/id}","deployments_url":"https://api.github.com/repos/BBC-News/simorgh/deployments","created_at":"2018-05-18T14:59:42Z","updated_at":"2018-11-28T15:08:52Z","pushed_at":"2018-11-28T15:46:16Z","git_url":"git://github.com/BBC-News/simorgh.git","ssh_url":"git@github.com:BBC-News/simorgh.git","clone_url":"https://github.com/BBC-News/simorgh.git","svn_url":"https://github.com/BBC-News/simorgh","homepage":"https://www.bbc.com","size":26452,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":136,"watchers":32,"default_branch":"latest"}},"base":{"label":"BBC-News:latest","ref":"latest","sha":"36cf3f9cbce676fd76d96a8783b84ab33d86ded0","user":{"login":"BBC-News","id":1401475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE0NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1401475?v=4","gravatar_id":"","url":"https://api.github.com/users/BBC-News","html_url":"https://github.com/BBC-News","followers_url":"https://api.github.com/users/BBC-News/followers","following_url":"https://api.github.com/users/BBC-News/following{/other_user}","gists_url":"https://api.github.com/users/BBC-News/gists{/gist_id}","starred_url":"https://api.github.com/users/BBC-News/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBC-News/subscriptions","organizations_url":"https://api.github.com/users/BBC-News/orgs","repos_url":"https://api.github.com/users/BBC-News/repos","events_url":"https://api.github.com/users/BBC-News/events{/privacy}","received_events_url":"https://api.github.com/users/BBC-News/received_events","type":"Organization","site_admin":false},"repo":{"id":133968906,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5Njg5MDY=","name":"simorgh","full_name":"BBC-News/simorgh","private":false,"owner":{"login":"BBC-News","id":1401475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDE0NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1401475?v=4","gravatar_id":"","url":"https://api.github.com/users/BBC-News","html_url":"https://github.com/BBC-News","followers_url":"https://api.github.com/users/BBC-News/followers","following_url":"https://api.github.com/users/BBC-News/following{/other_user}","gists_url":"https://api.github.com/users/BBC-News/gists{/gist_id}","starred_url":"https://api.github.com/users/BBC-News/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBC-News/subscriptions","organizations_url":"https://api.github.com/users/BBC-News/orgs","repos_url":"https://api.github.com/users/BBC-News/repos","events_url":"https://api.github.com/users/BBC-News/events{/privacy}","received_events_url":"https://api.github.com/users/BBC-News/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BBC-News/simorgh","description":"The BBC's new article (soon... we hope)","fork":false,"url":"https://api.github.com/repos/BBC-News/simorgh","forks_url":"https://api.github.com/repos/BBC-News/simorgh/forks","keys_url":"https://api.github.com/repos/BBC-News/simorgh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BBC-News/simorgh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BBC-News/simorgh/teams","hooks_url":"https://api.github.com/repos/BBC-News/simorgh/hooks","issue_events_url":"https://api.github.com/repos/BBC-News/simorgh/issues/events{/number}","events_url":"https://api.github.com/repos/BBC-News/simorgh/events","assignees_url":"https://api.github.com/repos/BBC-News/simorgh/assignees{/user}","branches_url":"https://api.github.com/repos/BBC-News/simorgh/branches{/branch}","tags_url":"https://api.github.com/repos/BBC-News/simorgh/tags","blobs_url":"https://api.github.com/repos/BBC-News/simorgh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BBC-News/simorgh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BBC-News/simorgh/git/refs{/sha}","trees_url":"https://api.github.com/repos/BBC-News/simorgh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BBC-News/simorgh/statuses/{sha}","languages_url":"https://api.github.com/repos/BBC-News/simorgh/languages","stargazers_url":"https://api.github.com/repos/BBC-News/simorgh/stargazers","contributors_url":"https://api.github.com/repos/BBC-News/simorgh/contributors","subscribers_url":"https://api.github.com/repos/BBC-News/simorgh/subscribers","subscription_url":"https://api.github.com/repos/BBC-News/simorgh/subscription","commits_url":"https://api.github.com/repos/BBC-News/simorgh/commits{/sha}","git_commits_url":"https://api.github.com/repos/BBC-News/simorgh/git/commits{/sha}","comments_url":"https://api.github.com/repos/BBC-News/simorgh/comments{/number}","issue_comment_url":"https://api.github.com/repos/BBC-News/simorgh/issues/comments{/number}","contents_url":"https://api.github.com/repos/BBC-News/simorgh/contents/{+path}","compare_url":"https://api.github.com/repos/BBC-News/simorgh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BBC-News/simorgh/merges","archive_url":"https://api.github.com/repos/BBC-News/simorgh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BBC-News/simorgh/downloads","issues_url":"https://api.github.com/repos/BBC-News/simorgh/issues{/number}","pulls_url":"https://api.github.com/repos/BBC-News/simorgh/pulls{/number}","milestones_url":"https://api.github.com/repos/BBC-News/simorgh/milestones{/number}","notifications_url":"https://api.github.com/repos/BBC-News/simorgh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BBC-News/simorgh/labels{/name}","releases_url":"https://api.github.com/repos/BBC-News/simorgh/releases{/id}","deployments_url":"https://api.github.com/repos/BBC-News/simorgh/deployments","created_at":"2018-05-18T14:59:42Z","updated_at":"2018-11-28T15:08:52Z","pushed_at":"2018-11-28T15:46:16Z","git_url":"git://github.com/BBC-News/simorgh.git","ssh_url":"git@github.com:BBC-News/simorgh.git","clone_url":"https://github.com/BBC-News/simorgh.git","svn_url":"https://github.com/BBC-News/simorgh","homepage":"https://www.bbc.com","size":26452,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":136,"watchers":32,"default_branch":"latest"}},"_links":{"self":{"href":"https://api.github.com/repos/BBC-News/simorgh/pulls/1019"},"html":{"href":"https://github.com/BBC-News/simorgh/pull/1019"},"issue":{"href":"https://api.github.com/repos/BBC-News/simorgh/issues/1019"},"comments":{"href":"https://api.github.com/repos/BBC-News/simorgh/issues/1019/comments"},"review_comments":{"href":"https://api.github.com/repos/BBC-News/simorgh/pulls/1019/comments"},"review_comment":{"href":"https://api.github.com/repos/BBC-News/simorgh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BBC-News/simorgh/pulls/1019/commits"},"statuses":{"href":"https://api.github.com/repos/BBC-News/simorgh/statuses/3088698eb92fcd46d859733484370594256ab0d3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pjlee11"}}