{"action":"opened","number":297,"pull_request":{"url":"https://api.github.com/repos/carp-lang/Carp/pulls/297","id":217497447,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDk3NDQ3","html_url":"https://github.com/carp-lang/Carp/pull/297","diff_url":"https://github.com/carp-lang/Carp/pull/297.diff","patch_url":"https://github.com/carp-lang/Carp/pull/297.patch","issue_url":"https://api.github.com/repos/carp-lang/Carp/issues/297","number":297,"state":"open","locked":false,"title":"Proposal: make and and or macros","user":{"login":"hellerve","id":7725188,"node_id":"MDQ6VXNlcjc3MjUxODg=","avatar_url":"https://avatars3.githubusercontent.com/u/7725188?v=4","gravatar_id":"","url":"https://api.github.com/users/hellerve","html_url":"https://github.com/hellerve","followers_url":"https://api.github.com/users/hellerve/followers","following_url":"https://api.github.com/users/hellerve/following{/other_user}","gists_url":"https://api.github.com/users/hellerve/gists{/gist_id}","starred_url":"https://api.github.com/users/hellerve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellerve/subscriptions","organizations_url":"https://api.github.com/users/hellerve/orgs","repos_url":"https://api.github.com/users/hellerve/repos","events_url":"https://api.github.com/users/hellerve/events{/privacy}","received_events_url":"https://api.github.com/users/hellerve/received_events","type":"User","site_admin":false},"body":"This PR removes the special case of `or` and `and` in the compiler and instead makes them macros. The code generated is more or less equivalent.\r\n\r\nAn annoying side-effect of this is that `and` and `or` within `Eval.hs` have to be renamed. At the moment I renamed them to `mand` and `mor`, but that’s not particularly great naming. I’m open for any suggestions!\r\n\r\nCheers","created_at":"2018-09-23T07:38:16Z","updated_at":"2018-09-23T07:38:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/carp-lang/Carp/pulls/297/commits","review_comments_url":"https://api.github.com/repos/carp-lang/Carp/pulls/297/comments","review_comment_url":"https://api.github.com/repos/carp-lang/Carp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/carp-lang/Carp/issues/297/comments","statuses_url":"https://api.github.com/repos/carp-lang/Carp/statuses/023dfa1ae366cb79903da8e41320d78067b59f37","head":{"label":"hellerve:bool-macros","ref":"bool-macros","sha":"023dfa1ae366cb79903da8e41320d78067b59f37","user":{"login":"hellerve","id":7725188,"node_id":"MDQ6VXNlcjc3MjUxODg=","avatar_url":"https://avatars3.githubusercontent.com/u/7725188?v=4","gravatar_id":"","url":"https://api.github.com/users/hellerve","html_url":"https://github.com/hellerve","followers_url":"https://api.github.com/users/hellerve/followers","following_url":"https://api.github.com/users/hellerve/following{/other_user}","gists_url":"https://api.github.com/users/hellerve/gists{/gist_id}","starred_url":"https://api.github.com/users/hellerve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellerve/subscriptions","organizations_url":"https://api.github.com/users/hellerve/orgs","repos_url":"https://api.github.com/users/hellerve/repos","events_url":"https://api.github.com/users/hellerve/events{/privacy}","received_events_url":"https://api.github.com/users/hellerve/received_events","type":"User","site_admin":false},"repo":{"id":107543659,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc1NDM2NTk=","name":"Carp","full_name":"hellerve/Carp","private":false,"owner":{"login":"hellerve","id":7725188,"node_id":"MDQ6VXNlcjc3MjUxODg=","avatar_url":"https://avatars3.githubusercontent.com/u/7725188?v=4","gravatar_id":"","url":"https://api.github.com/users/hellerve","html_url":"https://github.com/hellerve","followers_url":"https://api.github.com/users/hellerve/followers","following_url":"https://api.github.com/users/hellerve/following{/other_user}","gists_url":"https://api.github.com/users/hellerve/gists{/gist_id}","starred_url":"https://api.github.com/users/hellerve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellerve/subscriptions","organizations_url":"https://api.github.com/users/hellerve/orgs","repos_url":"https://api.github.com/users/hellerve/repos","events_url":"https://api.github.com/users/hellerve/events{/privacy}","received_events_url":"https://api.github.com/users/hellerve/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hellerve/Carp","description":"A statically typed lisp, without a GC, for high performance applications","fork":true,"url":"https://api.github.com/repos/hellerve/Carp","forks_url":"https://api.github.com/repos/hellerve/Carp/forks","keys_url":"https://api.github.com/repos/hellerve/Carp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hellerve/Carp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hellerve/Carp/teams","hooks_url":"https://api.github.com/repos/hellerve/Carp/hooks","issue_events_url":"https://api.github.com/repos/hellerve/Carp/issues/events{/number}","events_url":"https://api.github.com/repos/hellerve/Carp/events","assignees_url":"https://api.github.com/repos/hellerve/Carp/assignees{/user}","branches_url":"https://api.github.com/repos/hellerve/Carp/branches{/branch}","tags_url":"https://api.github.com/repos/hellerve/Carp/tags","blobs_url":"https://api.github.com/repos/hellerve/Carp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hellerve/Carp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hellerve/Carp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hellerve/Carp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hellerve/Carp/statuses/{sha}","languages_url":"https://api.github.com/repos/hellerve/Carp/languages","stargazers_url":"https://api.github.com/repos/hellerve/Carp/stargazers","contributors_url":"https://api.github.com/repos/hellerve/Carp/contributors","subscribers_url":"https://api.github.com/repos/hellerve/Carp/subscribers","subscription_url":"https://api.github.com/repos/hellerve/Carp/subscription","commits_url":"https://api.github.com/repos/hellerve/Carp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hellerve/Carp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hellerve/Carp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hellerve/Carp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hellerve/Carp/contents/{+path}","compare_url":"https://api.github.com/repos/hellerve/Carp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hellerve/Carp/merges","archive_url":"https://api.github.com/repos/hellerve/Carp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hellerve/Carp/downloads","issues_url":"https://api.github.com/repos/hellerve/Carp/issues{/number}","pulls_url":"https://api.github.com/repos/hellerve/Carp/pulls{/number}","milestones_url":"https://api.github.com/repos/hellerve/Carp/milestones{/number}","notifications_url":"https://api.github.com/repos/hellerve/Carp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hellerve/Carp/labels{/name}","releases_url":"https://api.github.com/repos/hellerve/Carp/releases{/id}","deployments_url":"https://api.github.com/repos/hellerve/Carp/deployments","created_at":"2017-10-19T12:32:47Z","updated_at":"2018-09-21T14:59:25Z","pushed_at":"2018-09-23T07:34:49Z","git_url":"git://github.com/hellerve/Carp.git","ssh_url":"git@github.com:hellerve/Carp.git","clone_url":"https://github.com/hellerve/Carp.git","svn_url":"https://github.com/hellerve/Carp","homepage":"","size":6969,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"carp-lang:master","ref":"master","sha":"58a51af7fddcfdb52e43da6702146b44cffc32dd","user":{"login":"carp-lang","id":20434801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDM0ODAx","avatar_url":"https://avatars1.githubusercontent.com/u/20434801?v=4","gravatar_id":"","url":"https://api.github.com/users/carp-lang","html_url":"https://github.com/carp-lang","followers_url":"https://api.github.com/users/carp-lang/followers","following_url":"https://api.github.com/users/carp-lang/following{/other_user}","gists_url":"https://api.github.com/users/carp-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/carp-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carp-lang/subscriptions","organizations_url":"https://api.github.com/users/carp-lang/orgs","repos_url":"https://api.github.com/users/carp-lang/repos","events_url":"https://api.github.com/users/carp-lang/events{/privacy}","received_events_url":"https://api.github.com/users/carp-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":49426320,"node_id":"MDEwOlJlcG9zaXRvcnk0OTQyNjMyMA==","name":"Carp","full_name":"carp-lang/Carp","private":false,"owner":{"login":"carp-lang","id":20434801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDM0ODAx","avatar_url":"https://avatars1.githubusercontent.com/u/20434801?v=4","gravatar_id":"","url":"https://api.github.com/users/carp-lang","html_url":"https://github.com/carp-lang","followers_url":"https://api.github.com/users/carp-lang/followers","following_url":"https://api.github.com/users/carp-lang/following{/other_user}","gists_url":"https://api.github.com/users/carp-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/carp-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carp-lang/subscriptions","organizations_url":"https://api.github.com/users/carp-lang/orgs","repos_url":"https://api.github.com/users/carp-lang/repos","events_url":"https://api.github.com/users/carp-lang/events{/privacy}","received_events_url":"https://api.github.com/users/carp-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/carp-lang/Carp","description":"A statically typed lisp, without a GC, for real-time applications.","fork":false,"url":"https://api.github.com/repos/carp-lang/Carp","forks_url":"https://api.github.com/repos/carp-lang/Carp/forks","keys_url":"https://api.github.com/repos/carp-lang/Carp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carp-lang/Carp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carp-lang/Carp/teams","hooks_url":"https://api.github.com/repos/carp-lang/Carp/hooks","issue_events_url":"https://api.github.com/repos/carp-lang/Carp/issues/events{/number}","events_url":"https://api.github.com/repos/carp-lang/Carp/events","assignees_url":"https://api.github.com/repos/carp-lang/Carp/assignees{/user}","branches_url":"https://api.github.com/repos/carp-lang/Carp/branches{/branch}","tags_url":"https://api.github.com/repos/carp-lang/Carp/tags","blobs_url":"https://api.github.com/repos/carp-lang/Carp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carp-lang/Carp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carp-lang/Carp/git/refs{/sha}","trees_url":"https://api.github.com/repos/carp-lang/Carp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carp-lang/Carp/statuses/{sha}","languages_url":"https://api.github.com/repos/carp-lang/Carp/languages","stargazers_url":"https://api.github.com/repos/carp-lang/Carp/stargazers","contributors_url":"https://api.github.com/repos/carp-lang/Carp/contributors","subscribers_url":"https://api.github.com/repos/carp-lang/Carp/subscribers","subscription_url":"https://api.github.com/repos/carp-lang/Carp/subscription","commits_url":"https://api.github.com/repos/carp-lang/Carp/commits{/sha}","git_commits_url":"https://api.github.com/repos/carp-lang/Carp/git/commits{/sha}","comments_url":"https://api.github.com/repos/carp-lang/Carp/comments{/number}","issue_comment_url":"https://api.github.com/repos/carp-lang/Carp/issues/comments{/number}","contents_url":"https://api.github.com/repos/carp-lang/Carp/contents/{+path}","compare_url":"https://api.github.com/repos/carp-lang/Carp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carp-lang/Carp/merges","archive_url":"https://api.github.com/repos/carp-lang/Carp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carp-lang/Carp/downloads","issues_url":"https://api.github.com/repos/carp-lang/Carp/issues{/number}","pulls_url":"https://api.github.com/repos/carp-lang/Carp/pulls{/number}","milestones_url":"https://api.github.com/repos/carp-lang/Carp/milestones{/number}","notifications_url":"https://api.github.com/repos/carp-lang/Carp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carp-lang/Carp/labels{/name}","releases_url":"https://api.github.com/repos/carp-lang/Carp/releases{/id}","deployments_url":"https://api.github.com/repos/carp-lang/Carp/deployments","created_at":"2016-01-11T12:54:09Z","updated_at":"2018-09-22T22:11:38Z","pushed_at":"2018-09-21T21:32:24Z","git_url":"git://github.com/carp-lang/Carp.git","ssh_url":"git@github.com:carp-lang/Carp.git","clone_url":"https://github.com/carp-lang/Carp.git","svn_url":"https://github.com/carp-lang/Carp","homepage":"","size":6987,"stargazers_count":2332,"watchers_count":2332,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":80,"open_issues":15,"watchers":2332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/carp-lang/Carp/pulls/297"},"html":{"href":"https://github.com/carp-lang/Carp/pull/297"},"issue":{"href":"https://api.github.com/repos/carp-lang/Carp/issues/297"},"comments":{"href":"https://api.github.com/repos/carp-lang/Carp/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/carp-lang/Carp/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/carp-lang/Carp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/carp-lang/Carp/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/carp-lang/Carp/statuses/023dfa1ae366cb79903da8e41320d78067b59f37"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":13,"deletions":103,"changed_files":10}}
{"actor":{"display_login":"hellerve"}}