{"push_id":3114977789,"size":1,"distinct_size":1,"ref":"refs/heads/fix/bazel-unrelevant-bazel-out-definitions-ng-package","head":"b3c60ac57fe87c1d4c9e16171708f680b248e656","before":"0b6ef91f29d6428a332c27176471fda6630e4ff2","commits":[{"sha":"b3c60ac57fe87c1d4c9e16171708f680b248e656","author":{"name":"Paul Gschwendtner","email":"40b47fccafb6f4d234e5a3c340c0b9bfb53bd039@gmail.com"},"message":"fix(bazel): ng_package writes unrelevant definitions to bazel out\n\nIn order to keep the bazel bin directory as clean as possible, we should not write definition files that are not relevant to a `ng_package` to an undesired location in the bazel bin directory. This currently just happens because we only filter out external definition files while we also should filter out definitions that aren't just in the current package.\n\nThe `packager.ts` file currently tries to write these files to the package, but fails because those are not inside of the current package. So the logic to create a relative path for the file fails, and the definition will be copied to a location like:\n\n```js\n// Notice the double \"bazel-out\" here.\nC:\\Users\\Paul\\_bazel_Paul\\kn4tsvyh\\execroot\\angular_material\\bazel-out\\x64_windows-fastbuild\\bin\\src\\bazel-out\\x64_windows-fastbuild\\bin\\src\\cdk\n```\n\n[See logic that causes this](https://github.com/angular/angular/blob/4f9374951d67c75f67a31c110bd61ab72563db7d/packages/bazel/src/ng_package/packager.ts#L105-L124) (nothing wrong with that logic because it assumes that only paths from within the package are passed to it)","distinct":true,"url":"https://api.github.com/repos/DevVersion/angular/commits/b3c60ac57fe87c1d4c9e16171708f680b248e656"}]}
{"actor":{"display_login":"DevVersion"}}