{"action":"closed","number":776,"pull_request":{"url":"https://api.github.com/repos/web3j/web3j/pulls/776","id":229053801,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDUzODAx","html_url":"https://github.com/web3j/web3j/pull/776","diff_url":"https://github.com/web3j/web3j/pull/776.diff","patch_url":"https://github.com/web3j/web3j/pull/776.patch","issue_url":"https://api.github.com/repos/web3j/web3j/issues/776","number":776,"state":"closed","locked":false,"title":"Allow using java keywords as solidity function names","user":{"login":"iikirilov","id":9802500,"node_id":"MDQ6VXNlcjk4MDI1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9802500?v=4","gravatar_id":"","url":"https://api.github.com/users/iikirilov","html_url":"https://github.com/iikirilov","followers_url":"https://api.github.com/users/iikirilov/followers","following_url":"https://api.github.com/users/iikirilov/following{/other_user}","gists_url":"https://api.github.com/users/iikirilov/gists{/gist_id}","starred_url":"https://api.github.com/users/iikirilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iikirilov/subscriptions","organizations_url":"https://api.github.com/users/iikirilov/orgs","repos_url":"https://api.github.com/users/iikirilov/repos","events_url":"https://api.github.com/users/iikirilov/events{/privacy}","received_events_url":"https://api.github.com/users/iikirilov/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nPrepend the violating function name with \"_\" such that a solidity function called `double` will generate a java method called `_double`. This fixes #658 \r\n\r\nI am open to making this more extensible if required. For example, one could configure their own sanitizing string and specify whether it should be appended or prepended. An issue was opened on the JavaPoet github https://github.com/square/javapoet/issues/690 - looks like we will have to implement ourselves in the future.\r\n\r\n### Where should the reviewer start?\r\nSolidityFunctionWrapper\r\n\r\n### Why is it needed?\r\nBecause Solidity contract writers should not need to worry about Java keywords.\r\n\r\n","created_at":"2018-11-07T14:52:56Z","updated_at":"2018-11-14T20:18:59Z","closed_at":"2018-11-14T20:18:59Z","merged_at":"2018-11-14T20:18:59Z","merge_commit_sha":"8b459a5c205a2250de321107a2daeeac84a5f828","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":846087631,"node_id":"MDU6TGFiZWw4NDYwODc2MzE=","url":"https://api.github.com/repos/web3j/web3j/labels/needs-review","name":"needs-review","color":"1bace5","default":false}],"milestone":{"url":"https://api.github.com/repos/web3j/web3j/milestones/9","html_url":"https://github.com/web3j/web3j/milestone/9","labels_url":"https://api.github.com/repos/web3j/web3j/milestones/9/labels","id":3774298,"node_id":"MDk6TWlsZXN0b25lMzc3NDI5OA==","number":9,"title":"4.0.0-alpha-2","description":null,"creator":{"login":"snazha-blkio","id":43588122,"node_id":"MDQ6VXNlcjQzNTg4MTIy","avatar_url":"https://avatars0.githubusercontent.com/u/43588122?v=4","gravatar_id":"","url":"https://api.github.com/users/snazha-blkio","html_url":"https://github.com/snazha-blkio","followers_url":"https://api.github.com/users/snazha-blkio/followers","following_url":"https://api.github.com/users/snazha-blkio/following{/other_user}","gists_url":"https://api.github.com/users/snazha-blkio/gists{/gist_id}","starred_url":"https://api.github.com/users/snazha-blkio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snazha-blkio/subscriptions","organizations_url":"https://api.github.com/users/snazha-blkio/orgs","repos_url":"https://api.github.com/users/snazha-blkio/repos","events_url":"https://api.github.com/users/snazha-blkio/events{/privacy}","received_events_url":"https://api.github.com/users/snazha-blkio/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":13,"state":"open","created_at":"2018-10-27T23:50:32Z","updated_at":"2018-11-14T20:18:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/web3j/web3j/pulls/776/commits","review_comments_url":"https://api.github.com/repos/web3j/web3j/pulls/776/comments","review_comment_url":"https://api.github.com/repos/web3j/web3j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/web3j/web3j/issues/776/comments","statuses_url":"https://api.github.com/repos/web3j/web3j/statuses/e35745a4043da0103e2a94b0e89027c938427711","head":{"label":"iikirilov:keyword","ref":"keyword","sha":"e35745a4043da0103e2a94b0e89027c938427711","user":{"login":"iikirilov","id":9802500,"node_id":"MDQ6VXNlcjk4MDI1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9802500?v=4","gravatar_id":"","url":"https://api.github.com/users/iikirilov","html_url":"https://github.com/iikirilov","followers_url":"https://api.github.com/users/iikirilov/followers","following_url":"https://api.github.com/users/iikirilov/following{/other_user}","gists_url":"https://api.github.com/users/iikirilov/gists{/gist_id}","starred_url":"https://api.github.com/users/iikirilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iikirilov/subscriptions","organizations_url":"https://api.github.com/users/iikirilov/orgs","repos_url":"https://api.github.com/users/iikirilov/repos","events_url":"https://api.github.com/users/iikirilov/events{/privacy}","received_events_url":"https://api.github.com/users/iikirilov/received_events","type":"User","site_admin":false},"repo":{"id":148124496,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxMjQ0OTY=","name":"web3j","full_name":"iikirilov/web3j","private":false,"owner":{"login":"iikirilov","id":9802500,"node_id":"MDQ6VXNlcjk4MDI1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9802500?v=4","gravatar_id":"","url":"https://api.github.com/users/iikirilov","html_url":"https://github.com/iikirilov","followers_url":"https://api.github.com/users/iikirilov/followers","following_url":"https://api.github.com/users/iikirilov/following{/other_user}","gists_url":"https://api.github.com/users/iikirilov/gists{/gist_id}","starred_url":"https://api.github.com/users/iikirilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iikirilov/subscriptions","organizations_url":"https://api.github.com/users/iikirilov/orgs","repos_url":"https://api.github.com/users/iikirilov/repos","events_url":"https://api.github.com/users/iikirilov/events{/privacy}","received_events_url":"https://api.github.com/users/iikirilov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/iikirilov/web3j","description":"Lightweight Java and Android library for integration with Ethereum clients","fork":true,"url":"https://api.github.com/repos/iikirilov/web3j","forks_url":"https://api.github.com/repos/iikirilov/web3j/forks","keys_url":"https://api.github.com/repos/iikirilov/web3j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iikirilov/web3j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iikirilov/web3j/teams","hooks_url":"https://api.github.com/repos/iikirilov/web3j/hooks","issue_events_url":"https://api.github.com/repos/iikirilov/web3j/issues/events{/number}","events_url":"https://api.github.com/repos/iikirilov/web3j/events","assignees_url":"https://api.github.com/repos/iikirilov/web3j/assignees{/user}","branches_url":"https://api.github.com/repos/iikirilov/web3j/branches{/branch}","tags_url":"https://api.github.com/repos/iikirilov/web3j/tags","blobs_url":"https://api.github.com/repos/iikirilov/web3j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iikirilov/web3j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iikirilov/web3j/git/refs{/sha}","trees_url":"https://api.github.com/repos/iikirilov/web3j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iikirilov/web3j/statuses/{sha}","languages_url":"https://api.github.com/repos/iikirilov/web3j/languages","stargazers_url":"https://api.github.com/repos/iikirilov/web3j/stargazers","contributors_url":"https://api.github.com/repos/iikirilov/web3j/contributors","subscribers_url":"https://api.github.com/repos/iikirilov/web3j/subscribers","subscription_url":"https://api.github.com/repos/iikirilov/web3j/subscription","commits_url":"https://api.github.com/repos/iikirilov/web3j/commits{/sha}","git_commits_url":"https://api.github.com/repos/iikirilov/web3j/git/commits{/sha}","comments_url":"https://api.github.com/repos/iikirilov/web3j/comments{/number}","issue_comment_url":"https://api.github.com/repos/iikirilov/web3j/issues/comments{/number}","contents_url":"https://api.github.com/repos/iikirilov/web3j/contents/{+path}","compare_url":"https://api.github.com/repos/iikirilov/web3j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iikirilov/web3j/merges","archive_url":"https://api.github.com/repos/iikirilov/web3j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iikirilov/web3j/downloads","issues_url":"https://api.github.com/repos/iikirilov/web3j/issues{/number}","pulls_url":"https://api.github.com/repos/iikirilov/web3j/pulls{/number}","milestones_url":"https://api.github.com/repos/iikirilov/web3j/milestones{/number}","notifications_url":"https://api.github.com/repos/iikirilov/web3j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iikirilov/web3j/labels{/name}","releases_url":"https://api.github.com/repos/iikirilov/web3j/releases{/id}","deployments_url":"https://api.github.com/repos/iikirilov/web3j/deployments","created_at":"2018-09-10T08:36:36Z","updated_at":"2018-11-07T09:25:01Z","pushed_at":"2018-11-08T11:55:38Z","git_url":"git://github.com/iikirilov/web3j.git","ssh_url":"git@github.com:iikirilov/web3j.git","clone_url":"https://github.com/iikirilov/web3j.git","svn_url":"https://github.com/iikirilov/web3j","homepage":"https://web3j.io/","size":5800,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"web3j:release/4.0","ref":"release/4.0","sha":"001b3623d322f61bacf3356c7475cf4b780d7f87","user":{"login":"web3j","id":22208471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjA4NDcx","avatar_url":"https://avatars1.githubusercontent.com/u/22208471?v=4","gravatar_id":"","url":"https://api.github.com/users/web3j","html_url":"https://github.com/web3j","followers_url":"https://api.github.com/users/web3j/followers","following_url":"https://api.github.com/users/web3j/following{/other_user}","gists_url":"https://api.github.com/users/web3j/gists{/gist_id}","starred_url":"https://api.github.com/users/web3j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web3j/subscriptions","organizations_url":"https://api.github.com/users/web3j/orgs","repos_url":"https://api.github.com/users/web3j/repos","events_url":"https://api.github.com/users/web3j/events{/privacy}","received_events_url":"https://api.github.com/users/web3j/received_events","type":"Organization","site_admin":false},"repo":{"id":67328052,"node_id":"MDEwOlJlcG9zaXRvcnk2NzMyODA1Mg==","name":"web3j","full_name":"web3j/web3j","private":false,"owner":{"login":"web3j","id":22208471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjA4NDcx","avatar_url":"https://avatars1.githubusercontent.com/u/22208471?v=4","gravatar_id":"","url":"https://api.github.com/users/web3j","html_url":"https://github.com/web3j","followers_url":"https://api.github.com/users/web3j/followers","following_url":"https://api.github.com/users/web3j/following{/other_user}","gists_url":"https://api.github.com/users/web3j/gists{/gist_id}","starred_url":"https://api.github.com/users/web3j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web3j/subscriptions","organizations_url":"https://api.github.com/users/web3j/orgs","repos_url":"https://api.github.com/users/web3j/repos","events_url":"https://api.github.com/users/web3j/events{/privacy}","received_events_url":"https://api.github.com/users/web3j/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/web3j/web3j","description":"Lightweight Java and Android library for integration with Ethereum clients","fork":false,"url":"https://api.github.com/repos/web3j/web3j","forks_url":"https://api.github.com/repos/web3j/web3j/forks","keys_url":"https://api.github.com/repos/web3j/web3j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/web3j/web3j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/web3j/web3j/teams","hooks_url":"https://api.github.com/repos/web3j/web3j/hooks","issue_events_url":"https://api.github.com/repos/web3j/web3j/issues/events{/number}","events_url":"https://api.github.com/repos/web3j/web3j/events","assignees_url":"https://api.github.com/repos/web3j/web3j/assignees{/user}","branches_url":"https://api.github.com/repos/web3j/web3j/branches{/branch}","tags_url":"https://api.github.com/repos/web3j/web3j/tags","blobs_url":"https://api.github.com/repos/web3j/web3j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/web3j/web3j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/web3j/web3j/git/refs{/sha}","trees_url":"https://api.github.com/repos/web3j/web3j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/web3j/web3j/statuses/{sha}","languages_url":"https://api.github.com/repos/web3j/web3j/languages","stargazers_url":"https://api.github.com/repos/web3j/web3j/stargazers","contributors_url":"https://api.github.com/repos/web3j/web3j/contributors","subscribers_url":"https://api.github.com/repos/web3j/web3j/subscribers","subscription_url":"https://api.github.com/repos/web3j/web3j/subscription","commits_url":"https://api.github.com/repos/web3j/web3j/commits{/sha}","git_commits_url":"https://api.github.com/repos/web3j/web3j/git/commits{/sha}","comments_url":"https://api.github.com/repos/web3j/web3j/comments{/number}","issue_comment_url":"https://api.github.com/repos/web3j/web3j/issues/comments{/number}","contents_url":"https://api.github.com/repos/web3j/web3j/contents/{+path}","compare_url":"https://api.github.com/repos/web3j/web3j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/web3j/web3j/merges","archive_url":"https://api.github.com/repos/web3j/web3j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/web3j/web3j/downloads","issues_url":"https://api.github.com/repos/web3j/web3j/issues{/number}","pulls_url":"https://api.github.com/repos/web3j/web3j/pulls{/number}","milestones_url":"https://api.github.com/repos/web3j/web3j/milestones{/number}","notifications_url":"https://api.github.com/repos/web3j/web3j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/web3j/web3j/labels{/name}","releases_url":"https://api.github.com/repos/web3j/web3j/releases{/id}","deployments_url":"https://api.github.com/repos/web3j/web3j/deployments","created_at":"2016-09-04T05:48:49Z","updated_at":"2018-11-14T10:32:07Z","pushed_at":"2018-11-14T20:18:59Z","git_url":"git://github.com/web3j/web3j.git","ssh_url":"git@github.com:web3j/web3j.git","clone_url":"https://github.com/web3j/web3j.git","svn_url":"https://github.com/web3j/web3j","homepage":"https://web3j.io/","size":5989,"stargazers_count":2119,"watchers_count":2119,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":746,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":746,"open_issues":210,"watchers":2119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/web3j/web3j/pulls/776"},"html":{"href":"https://github.com/web3j/web3j/pull/776"},"issue":{"href":"https://api.github.com/repos/web3j/web3j/issues/776"},"comments":{"href":"https://api.github.com/repos/web3j/web3j/issues/776/comments"},"review_comments":{"href":"https://api.github.com/repos/web3j/web3j/pulls/776/comments"},"review_comment":{"href":"https://api.github.com/repos/web3j/web3j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/web3j/web3j/pulls/776/commits"},"statuses":{"href":"https://api.github.com/repos/web3j/web3j/statuses/e35745a4043da0103e2a94b0e89027c938427711"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"snazha-blkio","id":43588122,"node_id":"MDQ6VXNlcjQzNTg4MTIy","avatar_url":"https://avatars0.githubusercontent.com/u/43588122?v=4","gravatar_id":"","url":"https://api.github.com/users/snazha-blkio","html_url":"https://github.com/snazha-blkio","followers_url":"https://api.github.com/users/snazha-blkio/followers","following_url":"https://api.github.com/users/snazha-blkio/following{/other_user}","gists_url":"https://api.github.com/users/snazha-blkio/gists{/gist_id}","starred_url":"https://api.github.com/users/snazha-blkio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snazha-blkio/subscriptions","organizations_url":"https://api.github.com/users/snazha-blkio/orgs","repos_url":"https://api.github.com/users/snazha-blkio/repos","events_url":"https://api.github.com/users/snazha-blkio/events{/privacy}","received_events_url":"https://api.github.com/users/snazha-blkio/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":28,"deletions":1,"changed_files":6}}
{"actor":{"display_login":"snazha-blkio"}}