{"action":"created","issue":{"url":"https://api.github.com/repos/nana-4/materia-theme/issues/222","repository_url":"https://api.github.com/repos/nana-4/materia-theme","labels_url":"https://api.github.com/repos/nana-4/materia-theme/issues/222/labels{/name}","comments_url":"https://api.github.com/repos/nana-4/materia-theme/issues/222/comments","events_url":"https://api.github.com/repos/nana-4/materia-theme/issues/222/events","html_url":"https://github.com/nana-4/materia-theme/pull/222","id":307810185,"number":222,"title":"Improving change_color.sh and _color.scss.template for darker themes","user":{"login":"svnset","id":16908310,"avatar_url":"https://avatars3.githubusercontent.com/u/16908310?v=4","gravatar_id":"","url":"https://api.github.com/users/svnset","html_url":"https://github.com/svnset","followers_url":"https://api.github.com/users/svnset/followers","following_url":"https://api.github.com/users/svnset/following{/other_user}","gists_url":"https://api.github.com/users/svnset/gists{/gist_id}","starred_url":"https://api.github.com/users/svnset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svnset/subscriptions","organizations_url":"https://api.github.com/users/svnset/orgs","repos_url":"https://api.github.com/users/svnset/repos","events_url":"https://api.github.com/users/svnset/events{/privacy}","received_events_url":"https://api.github.com/users/svnset/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":43,"created_at":"2018-03-22T20:51:50Z","updated_at":"2018-03-24T00:26:35Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nana-4/materia-theme/pulls/222","html_url":"https://github.com/nana-4/materia-theme/pull/222","diff_url":"https://github.com/nana-4/materia-theme/pull/222.diff","patch_url":"https://github.com/nana-4/materia-theme/pull/222.patch"},"body":"Hey here is my little attempt to improve coloring of dark materia themes.\r\n@actionless would be nice if you could review this. Dark themes look now better in my opinion if the new value is set to dark. IMPORTANT Until we implement `is_dark`nothing should change on the user side if the new variable is not set or set to light/standard.\r\n\r\n### change_color.sh\r\n* Created new value MATERIA_COLOR_VARIANT which should be light/dark/standard, default is set to light, so that nothing changes for oomox users or if the value is not set.\r\n* Created new seds for recoloring gtkrc-dark only used if MATERIA_COLOR_VARIANT=dark\r\n* Removed GTK3_GENERATE_DARK (experimental, could leave a placeholder)\r\n* Removed MATERIA_MENUBAR_STYLE (experimental, could leave a placeholder)\r\n* Adapted the if clauses for every case light/dark/standard\r\n* Removed navigating in sourcetree, removing asset pngs and manual render-assets.sh's because the render-assets.sh at project root provides all that \r\n* if MATERIA_COLOR_VARIANT=dark not set render only the light assets and the other way around\r\n* Implemented autodetection for dark/light backgrounds on what color variant to use if the value is not set\r\n\r\n### _colors.scss.template\r\n* provided dark colors for the dark color variant like in materia's _colors.scss whereever necessary and removed/simplified rendundant statements where the result is the same no matter if MATERIA_COLOR_VARIANT set to dark or light\r\n* MENU_BG2 is nice for light themes because of darken, but way too dark (almost black) for dark themes, so I choose MENU_BG for now which should be a different shade than TXT_BG/BTN_BG and looks consistent\r\n* I tried to not touch the light colors, so pls check if that's true and everything (coloring if MATERIA_COLOR_VARIANT is not set or set to light/standard) will work as before after this pr\r\n\r\n### What has changed now for dark themes?\r\n* when MATERIA_COLOR_VARIANT is set to dark now, we can make use of materia's rgba()'s and a few issues like too bright border colors are solved:\r\n* There were a few cases in gnome-shell with dark fg on dark bg like the gnome-workspaces extention. Fixed now.\r\n* in gtk2 there was a bug with dark themes where item previews were unreadable due to dark fg, dark bg. Fixed now\r\n * dark gtk2 themes have now a fg color as selection fg like the light theme variant and materia itself which makes it more consistent\r\n* Border colors are intentionally very dark now (like the dark materia theme) and could be changed to BG, TXT_BG or BTN_BG. I personally like it like this the most but tastes differ as we know.\r\n\r\nHere is a little [example](https://ptpb.pw/QH85) of a dark materia theme with the nord color palette."},"comment":{"url":"https://api.github.com/repos/nana-4/materia-theme/issues/comments/375831376","html_url":"https://github.com/nana-4/materia-theme/pull/222#issuecomment-375831376","issue_url":"https://api.github.com/repos/nana-4/materia-theme/issues/222","id":375831376,"user":{"login":"svnset","id":16908310,"avatar_url":"https://avatars3.githubusercontent.com/u/16908310?v=4","gravatar_id":"","url":"https://api.github.com/users/svnset","html_url":"https://github.com/svnset","followers_url":"https://api.github.com/users/svnset/followers","following_url":"https://api.github.com/users/svnset/following{/other_user}","gists_url":"https://api.github.com/users/svnset/gists{/gist_id}","starred_url":"https://api.github.com/users/svnset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svnset/subscriptions","organizations_url":"https://api.github.com/users/svnset/orgs","repos_url":"https://api.github.com/users/svnset/repos","events_url":"https://api.github.com/users/svnset/events{/privacy}","received_events_url":"https://api.github.com/users/svnset/received_events","type":"User","site_admin":false},"created_at":"2018-03-24T00:26:35Z","updated_at":"2018-03-24T00:26:35Z","author_association":"NONE","body":"Nope it looks just like materia: https://ptpb.pw/2qCV\r\nSo this look is actually intended and was wrong before. If you remember @nana-4 posted this fix for dropdowns for i3/awesome etc:\r\n~~~\r\n$opaque_fg_color:           %FG%;\r\n$opaque_secondary_fg_color: mix(%FG%, $base_color, percentage(0.7));\r\n$opaque_disabled_fg_color:  mix(%FG%, $base_color, percentage(0.5));\r\n$opaque_divider_color:      mix(%FG%, $base_color, percentage(0.12));\r\n~~~\r\n\r\nAnd I simply implemented it. If you like the appearance from before more we can propably change the colors."}}
{"actor":{"display_login":"svnset"}}