{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/189159032","pull_request_review_id":121284756,"id":189159032,"diff_hunk":"@@ -0,0 +1,137 @@\n+/*\n+ * The Alluxio Open Foundation licenses this work under the Apache License, version 2.0\n+ * (the \"License\"). You may not use this work except in compliance with the License, which is\n+ * available at www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * This software is distributed on an \"AS IS\" basis, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,\n+ * either express or implied, as more fully set forth in the License.\n+ *\n+ * See the NOTICE file distributed with this work for information regarding copyright ownership.\n+ */\n+\n+package alluxio.cli.fsadmin.command;\n+\n+import alluxio.cli.Command;\n+import alluxio.cli.CommandUtils;\n+\n+import alluxio.cli.fsadmin.FileSystemAdminShellUtils;\n+import alluxio.cli.fsadmin.command.doctor.ConfigurationCommand;\n+import alluxio.client.MetaMasterClient;\n+import alluxio.client.RetryHandlingMetaMasterClient;\n+import alluxio.exception.status.InvalidArgumentException;\n+import alluxio.master.MasterClientConfig;\n+\n+import com.google.common.io.Closer;\n+import org.apache.commons.cli.CommandLine;\n+import org.apache.commons.cli.Option;\n+import org.apache.commons.cli.Options;\n+\n+import java.io.IOException;\n+import java.io.PrintStream;\n+\n+/**\n+ * Shows errors or warnings that users should pay attention to.\n+ */\n+public final class DoctorCommand implements Command {\n+  public static final String HELP_OPTION_NAME = \"h\";\n+  private final Closer mCloser;\n+  private final MetaMasterClient mMetaMasterClient;\n+  private final PrintStream mPrintStream;\n+\n+  private static final Option HELP_OPTION =\n+      Option.builder(HELP_OPTION_NAME)\n+          .required(false)\n+          .hasArg(false)\n+          .desc(\"print help information.\")\n+          .build();\n+\n+  enum Command {\n+    ALL, // Show all errors/warnings\n+    CONFIGURATION, // Show server-side configuration errors/warnings\n+  }\n+\n+  /**\n+   * Creates a new instance of {@link DoctorCommand}.\n+   */\n+  public DoctorCommand() {\n+    MasterClientConfig config = MasterClientConfig.defaults();\n+    mCloser = Closer.create();\n+    mMetaMasterClient = mCloser.register(new RetryHandlingMetaMasterClient(config));\n+    mPrintStream = System.out;\n+  }\n+\n+  @Override\n+  public String getCommandName() {\n+    return \"doctor\";\n+  }\n+\n+  @Override\n+  public int run(CommandLine cl) throws IOException {\n+    try {\n+      String[] args = cl.getArgs();\n+\n+      if (cl.hasOption(HELP_OPTION_NAME)) {\n+        System.out.println(getUsage());\n+        System.out.println(getDescription());\n+        return 0;\n+      }\n+\n+      if (!FileSystemAdminShellUtils.masterClientServiceIsRunning()) {\n+        return 1;\n+      }\n+\n+      // Get the report category\n+      Command command = Command.ALL;\n+      if (args.length == 1) {\n+        switch (args[0]) {\n+          case \"configuration\":\n+            command = Command.CONFIGURATION;\n+            break;\n+          default:\n+            System.out.println(getUsage());\n+            System.out.println(getDescription());\n+            throw new InvalidArgumentException(\"doctor category is invalid.\");\n+        }\n+      }\n+\n+      switch (command) {\n+        case ALL:","path":"shell/src/main/java/alluxio/cli/fsadmin/command/DoctorCommand.java","position":92,"original_position":98,"commit_id":"f24fec8c6e0e0437252a0a65f37abced11114f86","original_commit_id":"e377d422d16cac89d13a22fab0cf75d2ead35bb8","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars3.githubusercontent.com/u/3455177?v=4","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"ok, lets leave it as-is","created_at":"2018-05-18T04:08:13Z","updated_at":"2018-05-18T04:08:13Z","html_url":"https://github.com/Alluxio/alluxio/pull/7299#discussion_r189159032","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7299","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/189159032"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7299#discussion_r189159032"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7299"}},"in_reply_to_id":189113718},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7299","id":188584483,"html_url":"https://github.com/Alluxio/alluxio/pull/7299","diff_url":"https://github.com/Alluxio/alluxio/pull/7299.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/7299.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7299","number":7299,"state":"open","locked":false,"title":"[ALLUXIO-3202] Fsadmin doctor with server configuration report","user":{"login":"LuQQiu","id":25273483,"avatar_url":"https://avatars0.githubusercontent.com/u/25273483?v=4","gravatar_id":"","url":"https://api.github.com/users/LuQQiu","html_url":"https://github.com/LuQQiu","followers_url":"https://api.github.com/users/LuQQiu/followers","following_url":"https://api.github.com/users/LuQQiu/following{/other_user}","gists_url":"https://api.github.com/users/LuQQiu/gists{/gist_id}","starred_url":"https://api.github.com/users/LuQQiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuQQiu/subscriptions","organizations_url":"https://api.github.com/users/LuQQiu/orgs","repos_url":"https://api.github.com/users/LuQQiu/repos","events_url":"https://api.github.com/users/LuQQiu/events{/privacy}","received_events_url":"https://api.github.com/users/LuQQiu/received_events","type":"User","site_admin":false},"body":"https://alluxio.atlassian.net/browse/ALLUXIO-3202\r\n<img width=\"613\" alt=\"screen shot 2018-05-17 at 11 18 25 pm\" src=\"https://user-images.githubusercontent.com/25273483/40214517-3a22b97c-5a29-11e8-88c9-8ab1a257ff25.png\">\r\n\r\n","created_at":"2018-05-16T23:06:42Z","updated_at":"2018-05-18T04:08:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"369125b852df12b7d6a57235fefe405c5a5eebcf","assignee":{"login":"apc999","id":1413748,"avatar_url":"https://avatars0.githubusercontent.com/u/1413748?v=4","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"assignees":[{"login":"apc999","id":1413748,"avatar_url":"https://avatars0.githubusercontent.com/u/1413748?v=4","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7299/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7299/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7299/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/f24fec8c6e0e0437252a0a65f37abced11114f86","head":{"label":"LuQQiu:fsadminDoctor","ref":"fsadminDoctor","sha":"f24fec8c6e0e0437252a0a65f37abced11114f86","user":{"login":"LuQQiu","id":25273483,"avatar_url":"https://avatars0.githubusercontent.com/u/25273483?v=4","gravatar_id":"","url":"https://api.github.com/users/LuQQiu","html_url":"https://github.com/LuQQiu","followers_url":"https://api.github.com/users/LuQQiu/followers","following_url":"https://api.github.com/users/LuQQiu/following{/other_user}","gists_url":"https://api.github.com/users/LuQQiu/gists{/gist_id}","starred_url":"https://api.github.com/users/LuQQiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuQQiu/subscriptions","organizations_url":"https://api.github.com/users/LuQQiu/orgs","repos_url":"https://api.github.com/users/LuQQiu/repos","events_url":"https://api.github.com/users/LuQQiu/events{/privacy}","received_events_url":"https://api.github.com/users/LuQQiu/received_events","type":"User","site_admin":false},"repo":{"id":131058240,"name":"alluxio","full_name":"LuQQiu/alluxio","owner":{"login":"LuQQiu","id":25273483,"avatar_url":"https://avatars0.githubusercontent.com/u/25273483?v=4","gravatar_id":"","url":"https://api.github.com/users/LuQQiu","html_url":"https://github.com/LuQQiu","followers_url":"https://api.github.com/users/LuQQiu/followers","following_url":"https://api.github.com/users/LuQQiu/following{/other_user}","gists_url":"https://api.github.com/users/LuQQiu/gists{/gist_id}","starred_url":"https://api.github.com/users/LuQQiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuQQiu/subscriptions","organizations_url":"https://api.github.com/users/LuQQiu/orgs","repos_url":"https://api.github.com/users/LuQQiu/repos","events_url":"https://api.github.com/users/LuQQiu/events{/privacy}","received_events_url":"https://api.github.com/users/LuQQiu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LuQQiu/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":true,"url":"https://api.github.com/repos/LuQQiu/alluxio","forks_url":"https://api.github.com/repos/LuQQiu/alluxio/forks","keys_url":"https://api.github.com/repos/LuQQiu/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuQQiu/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuQQiu/alluxio/teams","hooks_url":"https://api.github.com/repos/LuQQiu/alluxio/hooks","issue_events_url":"https://api.github.com/repos/LuQQiu/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/LuQQiu/alluxio/events","assignees_url":"https://api.github.com/repos/LuQQiu/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/LuQQiu/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/LuQQiu/alluxio/tags","blobs_url":"https://api.github.com/repos/LuQQiu/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuQQiu/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuQQiu/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuQQiu/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuQQiu/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/LuQQiu/alluxio/languages","stargazers_url":"https://api.github.com/repos/LuQQiu/alluxio/stargazers","contributors_url":"https://api.github.com/repos/LuQQiu/alluxio/contributors","subscribers_url":"https://api.github.com/repos/LuQQiu/alluxio/subscribers","subscription_url":"https://api.github.com/repos/LuQQiu/alluxio/subscription","commits_url":"https://api.github.com/repos/LuQQiu/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuQQiu/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuQQiu/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuQQiu/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuQQiu/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/LuQQiu/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuQQiu/alluxio/merges","archive_url":"https://api.github.com/repos/LuQQiu/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuQQiu/alluxio/downloads","issues_url":"https://api.github.com/repos/LuQQiu/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/LuQQiu/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/LuQQiu/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/LuQQiu/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuQQiu/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/LuQQiu/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/LuQQiu/alluxio/deployments","created_at":"2018-04-25T20:11:47Z","updated_at":"2018-04-25T20:11:55Z","pushed_at":"2018-05-18T03:22:10Z","git_url":"git://github.com/LuQQiu/alluxio.git","ssh_url":"git@github.com:LuQQiu/alluxio.git","clone_url":"https://github.com/LuQQiu/alluxio.git","svn_url":"https://github.com/LuQQiu/alluxio","homepage":"http://www.alluxio.org/","size":88277,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:config-checker","ref":"config-checker","sha":"9f5277aa9fbf5b59ea755de5edb22b746ad755de","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2018-05-17T23:59:03Z","pushed_at":"2018-05-18T03:46:31Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":88205,"stargazers_count":3487,"watchers_count":3487,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1895,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1895,"open_issues":46,"watchers":3487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7299"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7299"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7299"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7299/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7299/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7299/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/f24fec8c6e0e0437252a0a65f37abced11114f86"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"aaudiber"}}