{"action":"created","issue":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8723","repository_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8723/labels{/name}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8723/comments","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8723/events","html_url":"https://github.com/zephyrproject-rtos/zephyr/issues/8723","id":338173104,"node_id":"MDU6SXNzdWUzMzgxNzMxMDQ=","number":8723,"title":"Network stack cleanup","user":{"login":"tbursztyka","id":1608406,"node_id":"MDQ6VXNlcjE2MDg0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1608406?v=4","gravatar_id":"","url":"https://api.github.com/users/tbursztyka","html_url":"https://github.com/tbursztyka","followers_url":"https://api.github.com/users/tbursztyka/followers","following_url":"https://api.github.com/users/tbursztyka/following{/other_user}","gists_url":"https://api.github.com/users/tbursztyka/gists{/gist_id}","starred_url":"https://api.github.com/users/tbursztyka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbursztyka/subscriptions","organizations_url":"https://api.github.com/users/tbursztyka/orgs","repos_url":"https://api.github.com/users/tbursztyka/repos","events_url":"https://api.github.com/users/tbursztyka/events{/privacy}","received_events_url":"https://api.github.com/users/tbursztyka/received_events","type":"User","site_admin":false},"labels":[{"id":700751655,"node_id":"MDU6TGFiZWw3MDA3NTE2NTU=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Networking","name":"area: Networking","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones/28","html_url":"https://github.com/zephyrproject-rtos/zephyr/milestone/28","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones/28/labels","id":3176487,"node_id":"MDk6TWlsZXN0b25lMzE3NjQ4Nw==","number":28,"title":"v1.13.0","description":"","creator":{"login":"nashif","id":180017,"node_id":"MDQ6VXNlcjE4MDAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},"open_issues":65,"closed_issues":43,"state":"open","created_at":"2018-03-11T02:40:53Z","updated_at":"2018-07-04T08:27:46Z","due_on":"2018-08-31T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-07-04T08:12:07Z","updated_at":"2018-07-04T08:29:33Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Current code base would need serious cleanup/optimization. Current status shows duplicates, un-proper modularization, under optimized data storage/lookup, naming issues etc...\r\n\r\nWhat should be done:\r\n\r\n- Keep each specific part into their own C file (i.e.: ipv4, ipv6, etc...).\r\n  . For instance, icmpv4 redo in its code what ipv4 does already. \r\n- Factorize as much as possible\r\n- Reduce #ifdefs usage inside functions\r\n  . Use IS_ENABLED()\r\n  . Move CONFIG_* conditioned code to own function\r\n- Naming convention\r\n  .When it is a public function net_\\<domain\\>_<...>()\r\n  .When it is a private function \\<domain\\>_<...>()\r\n- de-clutter if/for/while... imbrication. (The Linux rule of 3 maximum is nice)\r\n\r\nAreas:\r\n\r\n- ipv4.c/icmpv4.c : #8720\r\n- ipv6.c/icmpv6.c : #8721\r\n- connection.c : #8722\r\n- rpl.c : #8724\r\n- net_context.c : #8725\r\n- tcp.c : #8726"},"comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments/402404938","html_url":"https://github.com/zephyrproject-rtos/zephyr/issues/8723#issuecomment-402404938","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8723","id":402404938,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjQwNDkzOA==","user":{"login":"tbursztyka","id":1608406,"node_id":"MDQ6VXNlcjE2MDg0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1608406?v=4","gravatar_id":"","url":"https://api.github.com/users/tbursztyka","html_url":"https://github.com/tbursztyka","followers_url":"https://api.github.com/users/tbursztyka/followers","following_url":"https://api.github.com/users/tbursztyka/following{/other_user}","gists_url":"https://api.github.com/users/tbursztyka/gists{/gist_id}","starred_url":"https://api.github.com/users/tbursztyka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbursztyka/subscriptions","organizations_url":"https://api.github.com/users/tbursztyka/orgs","repos_url":"https://api.github.com/users/tbursztyka/repos","events_url":"https://api.github.com/users/tbursztyka/events{/privacy}","received_events_url":"https://api.github.com/users/tbursztyka/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T08:29:32Z","updated_at":"2018-07-04T08:29:32Z","author_association":"CONTRIBUTOR","body":"@jukkar, @rveerama1, @ozhuraki, @pfalcon, whoever else is interested."}}
{"actor":{"display_login":"tbursztyka"}}