{"action":"created","issue":{"url":"https://api.github.com/repos/handsontable/handsontable/issues/4710","repository_url":"https://api.github.com/repos/handsontable/handsontable","labels_url":"https://api.github.com/repos/handsontable/handsontable/issues/4710/labels{/name}","comments_url":"https://api.github.com/repos/handsontable/handsontable/issues/4710/comments","events_url":"https://api.github.com/repos/handsontable/handsontable/issues/4710/events","html_url":"https://github.com/handsontable/handsontable/pull/4710","id":287669989,"number":4710,"title":"Issue #4400 Fixed ObserveChanges plugin memory leak","user":{"login":"jeremy-smith-maco","id":27179132,"avatar_url":"https://avatars2.githubusercontent.com/u/27179132?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremy-smith-maco","html_url":"https://github.com/jeremy-smith-maco","followers_url":"https://api.github.com/users/jeremy-smith-maco/followers","following_url":"https://api.github.com/users/jeremy-smith-maco/following{/other_user}","gists_url":"https://api.github.com/users/jeremy-smith-maco/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy-smith-maco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy-smith-maco/subscriptions","organizations_url":"https://api.github.com/users/jeremy-smith-maco/orgs","repos_url":"https://api.github.com/users/jeremy-smith-maco/repos","events_url":"https://api.github.com/users/jeremy-smith-maco/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy-smith-maco/received_events","type":"User","site_admin":false},"labels":[{"id":943184493,"url":"https://api.github.com/repos/handsontable/handsontable/labels/CLA%20signed","name":"CLA signed","color":"f7ff8c","default":false},{"id":138470593,"url":"https://api.github.com/repos/handsontable/handsontable/labels/Plugin:%20observe%20changes","name":"Plugin: observe changes","color":"0e8a16","default":false},{"id":113279919,"url":"https://api.github.com/repos/handsontable/handsontable/labels/Status:%20Developed%20(ready%20for%20review)","name":"Status: Developed (ready for review)","color":"006b75","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-01-11T05:40:27Z","updated_at":"2018-05-27T22:19:42Z","closed_at":"2018-05-25T12:31:23Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/handsontable/handsontable/pulls/4710","html_url":"https://github.com/handsontable/handsontable/pull/4710","diff_url":"https://github.com/handsontable/handsontable/pull/4710.diff","patch_url":"https://github.com/handsontable/handsontable/pull/4710.patch"},"body":"### Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nFixes #4400 - ObserveChanges plugin causing a memory leak (which as actually caused by the JSON patch library)\r\n\r\n### How has this been tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\nTested it locally in our own project and ensured all Handsontable tests still pass.\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature or improvement (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n### Related issue(s):\r\n1. #4400 \r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project,\r\n- [ ] My change requires a change to the documentation.\r\n"},"comment":{"url":"https://api.github.com/repos/handsontable/handsontable/issues/comments/392381297","html_url":"https://github.com/handsontable/handsontable/pull/4710#issuecomment-392381297","issue_url":"https://api.github.com/repos/handsontable/handsontable/issues/4710","id":392381297,"user":{"login":"jeremy-smith-maco","id":27179132,"avatar_url":"https://avatars2.githubusercontent.com/u/27179132?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremy-smith-maco","html_url":"https://github.com/jeremy-smith-maco","followers_url":"https://api.github.com/users/jeremy-smith-maco/followers","following_url":"https://api.github.com/users/jeremy-smith-maco/following{/other_user}","gists_url":"https://api.github.com/users/jeremy-smith-maco/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy-smith-maco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy-smith-maco/subscriptions","organizations_url":"https://api.github.com/users/jeremy-smith-maco/orgs","repos_url":"https://api.github.com/users/jeremy-smith-maco/repos","events_url":"https://api.github.com/users/jeremy-smith-maco/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy-smith-maco/received_events","type":"User","site_admin":false},"created_at":"2018-05-27T22:19:42Z","updated_at":"2018-05-27T22:19:42Z","author_association":"CONTRIBUTOR","body":"Looking at their latest code it seems like this still might be an issue. I'm not sure if it's an issue with their library or its' purpose does not fit with how handsontable uses it but I think it is worth testing against my test case in the original GitHub issue: https://github.com/handsontable/handsontable/issues/4400"}}
{"actor":{"display_login":"jeremy-smith-maco"}}