{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/installer/pulls/comments/225648551","pull_request_review_id":165293827,"id":225648551,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTY0ODU1MQ==","diff_hunk":"@@ -0,0 +1,93 @@\n+// Package aws generates Machine objects for aws.\n+package aws\n+\n+import (\n+\t\"text/template\"\n+\n+\t\"github.com/openshift/installer/pkg/types\"\n+)\n+\n+// Config is used to generate the machine.\n+type Config struct {\n+\tClusterName string\n+\tReplicas    int64\n+\tTags        map[string]string\n+\tRegion      string\n+\tMachine     types.AWSMachinePoolPlatform\n+}\n+\n+// WorkerMachineSetTmpl is template for worker machineset.\n+var WorkerMachineSetTmpl = template.Must(template.New(\"aws-worker-machineset\").Parse(`\n+apiVersion: cluster.k8s.io/v1alpha1\n+kind: MachineSet\n+metadata:\n+  name: {{.ClusterName}}-worker-0\n+  namespace: openshift-cluster-api\n+  labels:\n+    sigs.k8s.io/cluster-api-cluster: {{.ClusterName}}\n+    sigs.k8s.io/cluster-api-machine-role: worker\n+    sigs.k8s.io/cluster-api-machine-type: worker\n+spec:\n+  replicas: {{.Replicas}}\n+  selector:\n+    matchLabels:\n+      sigs.k8s.io/cluster-api-machineset: worker\n+      sigs.k8s.io/cluster-api-cluster: {{.ClusterName}}\n+  template:\n+    metadata:\n+      labels:\n+        sigs.k8s.io/cluster-api-machineset: worker\n+        sigs.k8s.io/cluster-api-cluster: {{.ClusterName}}\n+        sigs.k8s.io/cluster-api-machine-role: worker\n+        sigs.k8s.io/cluster-api-machine-type: worker\n+    spec:\n+      providerConfig:\n+        value:\n+          apiVersion: aws.cluster.k8s.io/v1alpha1\n+          kind: AWSMachineProviderConfig\n+          ami:\n+            filters:\n+              - name: \"name\"\n+                values:\n+                - rhcos*","path":"pkg/asset/machines/aws/aws.go","position":52,"original_position":52,"commit_id":"a4e70fb7c75a921e3581ab310250ac17798b4771","original_commit_id":"16e86c941fdd9c620a64506ce500eaf8da948a6a","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"body":">  Isn't that what the machine-config operator is going to handle? Can't it update the machine-sets when it decides to bump to a new AMI?\r\n\r\nit doesn't control machine characteristics. So no.\r\n\r\n>  I thought we'd want to punt on all of this and just pin to the creation-time AMI for both masters and workers.\r\n\r\nI would still want installer to not choose the ami for worker.","created_at":"2018-10-16T18:03:09Z","updated_at":"2018-10-16T18:03:10Z","html_url":"https://github.com/openshift/installer/pull/468#discussion_r225648551","pull_request_url":"https://api.github.com/repos/openshift/installer/pulls/468","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments/225648551"},"html":{"href":"https://github.com/openshift/installer/pull/468#discussion_r225648551"},"pull_request":{"href":"https://api.github.com/repos/openshift/installer/pulls/468"}},"in_reply_to_id":225626305},"pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/468","id":223065696,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDY1Njk2","html_url":"https://github.com/openshift/installer/pull/468","diff_url":"https://github.com/openshift/installer/pull/468.diff","patch_url":"https://github.com/openshift/installer/pull/468.patch","issue_url":"https://api.github.com/repos/openshift/installer/issues/468","number":468,"state":"open","locked":false,"title":"pkg/asset: Add asset for Worker machinesets","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"body":"/cc @wking ","created_at":"2018-10-15T22:47:03Z","updated_at":"2018-10-16T18:03:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e68627ee26c6a36bf91fb1f77896e6a7c1501f35","assignee":null,"assignees":[],"requested_reviewers":[{"login":"crawford","id":368848,"node_id":"MDQ6VXNlcjM2ODg0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/368848?v=4","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},{"login":"trawler","id":8340149,"node_id":"MDQ6VXNlcjgzNDAxNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/8340149?v=4","gravatar_id":"","url":"https://api.github.com/users/trawler","html_url":"https://github.com/trawler","followers_url":"https://api.github.com/users/trawler/followers","following_url":"https://api.github.com/users/trawler/following{/other_user}","gists_url":"https://api.github.com/users/trawler/gists{/gist_id}","starred_url":"https://api.github.com/users/trawler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trawler/subscriptions","organizations_url":"https://api.github.com/users/trawler/orgs","repos_url":"https://api.github.com/users/trawler/repos","events_url":"https://api.github.com/users/trawler/events{/privacy}","received_events_url":"https://api.github.com/users/trawler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":959732229,"node_id":"MDU6TGFiZWw5NTk3MzIyMjk=","url":"https://api.github.com/repos/openshift/installer/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":959732835,"node_id":"MDU6TGFiZWw5NTk3MzI4MzU=","url":"https://api.github.com/repos/openshift/installer/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/installer/pulls/468/commits","review_comments_url":"https://api.github.com/repos/openshift/installer/pulls/468/comments","review_comment_url":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/installer/issues/468/comments","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/a4e70fb7c75a921e3581ab310250ac17798b4771","head":{"label":"abhinavdahiya:worker_machinesets","ref":"worker_machinesets","sha":"a4e70fb7c75a921e3581ab310250ac17798b4771","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"repo":{"id":140032335,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMzIzMzU=","name":"installer","full_name":"abhinavdahiya/installer","private":false,"owner":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"html_url":"https://github.com/abhinavdahiya/installer","description":"Install an OpenShift cluster","fork":true,"url":"https://api.github.com/repos/abhinavdahiya/installer","forks_url":"https://api.github.com/repos/abhinavdahiya/installer/forks","keys_url":"https://api.github.com/repos/abhinavdahiya/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhinavdahiya/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhinavdahiya/installer/teams","hooks_url":"https://api.github.com/repos/abhinavdahiya/installer/hooks","issue_events_url":"https://api.github.com/repos/abhinavdahiya/installer/issues/events{/number}","events_url":"https://api.github.com/repos/abhinavdahiya/installer/events","assignees_url":"https://api.github.com/repos/abhinavdahiya/installer/assignees{/user}","branches_url":"https://api.github.com/repos/abhinavdahiya/installer/branches{/branch}","tags_url":"https://api.github.com/repos/abhinavdahiya/installer/tags","blobs_url":"https://api.github.com/repos/abhinavdahiya/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhinavdahiya/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhinavdahiya/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhinavdahiya/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhinavdahiya/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/abhinavdahiya/installer/languages","stargazers_url":"https://api.github.com/repos/abhinavdahiya/installer/stargazers","contributors_url":"https://api.github.com/repos/abhinavdahiya/installer/contributors","subscribers_url":"https://api.github.com/repos/abhinavdahiya/installer/subscribers","subscription_url":"https://api.github.com/repos/abhinavdahiya/installer/subscription","commits_url":"https://api.github.com/repos/abhinavdahiya/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhinavdahiya/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhinavdahiya/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhinavdahiya/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhinavdahiya/installer/contents/{+path}","compare_url":"https://api.github.com/repos/abhinavdahiya/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhinavdahiya/installer/merges","archive_url":"https://api.github.com/repos/abhinavdahiya/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhinavdahiya/installer/downloads","issues_url":"https://api.github.com/repos/abhinavdahiya/installer/issues{/number}","pulls_url":"https://api.github.com/repos/abhinavdahiya/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/abhinavdahiya/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/abhinavdahiya/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhinavdahiya/installer/labels{/name}","releases_url":"https://api.github.com/repos/abhinavdahiya/installer/releases{/id}","deployments_url":"https://api.github.com/repos/abhinavdahiya/installer/deployments","created_at":"2018-07-06T21:44:39Z","updated_at":"2018-10-08T15:57:26Z","pushed_at":"2018-10-16T18:00:27Z","git_url":"git://github.com/abhinavdahiya/installer.git","ssh_url":"git@github.com:abhinavdahiya/installer.git","clone_url":"https://github.com/abhinavdahiya/installer.git","svn_url":"https://github.com/abhinavdahiya/installer","homepage":"","size":40745,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"840428443f7879ee0437ba2b30a9e4bd1048c587","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":136633680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzM2ODA=","name":"installer","full_name":"openshift/installer","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/installer","description":"Install an OpenShift cluster","fork":false,"url":"https://api.github.com/repos/openshift/installer","forks_url":"https://api.github.com/repos/openshift/installer/forks","keys_url":"https://api.github.com/repos/openshift/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/installer/teams","hooks_url":"https://api.github.com/repos/openshift/installer/hooks","issue_events_url":"https://api.github.com/repos/openshift/installer/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/installer/events","assignees_url":"https://api.github.com/repos/openshift/installer/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/installer/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/installer/tags","blobs_url":"https://api.github.com/repos/openshift/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/installer/languages","stargazers_url":"https://api.github.com/repos/openshift/installer/stargazers","contributors_url":"https://api.github.com/repos/openshift/installer/contributors","subscribers_url":"https://api.github.com/repos/openshift/installer/subscribers","subscription_url":"https://api.github.com/repos/openshift/installer/subscription","commits_url":"https://api.github.com/repos/openshift/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/installer/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/installer/merges","archive_url":"https://api.github.com/repos/openshift/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/installer/downloads","issues_url":"https://api.github.com/repos/openshift/installer/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/installer/labels{/name}","releases_url":"https://api.github.com/repos/openshift/installer/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/installer/deployments","created_at":"2018-06-08T15:04:41Z","updated_at":"2018-10-16T15:16:00Z","pushed_at":"2018-10-16T18:00:28Z","git_url":"git://github.com/openshift/installer.git","ssh_url":"git@github.com:openshift/installer.git","clone_url":"https://github.com/openshift/installer.git","svn_url":"https://github.com/openshift/installer","homepage":"","size":40754,"stargazers_count":67,"watchers_count":67,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":77,"open_issues":39,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/468"},"html":{"href":"https://github.com/openshift/installer/pull/468"},"issue":{"href":"https://api.github.com/repos/openshift/installer/issues/468"},"comments":{"href":"https://api.github.com/repos/openshift/installer/issues/468/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/installer/pulls/468/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/installer/pulls/468/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/installer/statuses/a4e70fb7c75a921e3581ab310250ac17798b4771"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"abhinavdahiya"}}