{"action":"created","comment":{"url":"https://api.github.com/repos/keybase/client/pulls/comments/184217673","pull_request_review_id":115368954,"id":184217673,"diff_hunk":"@@ -0,0 +1,9 @@\n+// @flow\n+import {isIOS} from '../constants/platform'\n+import {WebView} from 'react-native'\n+// $FlowFixMe\n+import WKWebView from 'react-native-wkwebview-reborn'\n+\n+const wv = isIOS ? WKWebView : WebView","path":"shared/common-adapters/web-view.native.js","position":7,"original_position":7,"commit_id":"416e4bab5220f4134a4080223949096722363421","original_commit_id":"416e4bab5220f4134a4080223949096722363421","user":{"login":"songgao","id":255797,"avatar_url":"https://avatars3.githubusercontent.com/u/255797?v=4","gravatar_id":"","url":"https://api.github.com/users/songgao","html_url":"https://github.com/songgao","followers_url":"https://api.github.com/users/songgao/followers","following_url":"https://api.github.com/users/songgao/following{/other_user}","gists_url":"https://api.github.com/users/songgao/gists{/gist_id}","starred_url":"https://api.github.com/users/songgao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songgao/subscriptions","organizations_url":"https://api.github.com/users/songgao/orgs","repos_url":"https://api.github.com/users/songgao/repos","events_url":"https://api.github.com/users/songgao/events{/privacy}","received_events_url":"https://api.github.com/users/songgao/received_events","type":"User","site_admin":false},"body":"Yes it has empty imports for Android. I tried .ios and android but couldn't make flow work. I'll tweak more and see what's going on ...","created_at":"2018-04-25T21:55:07Z","updated_at":"2018-04-25T21:55:07Z","html_url":"https://github.com/keybase/client/pull/11485#discussion_r184217673","pull_request_url":"https://api.github.com/repos/keybase/client/pulls/11485","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/comments/184217673"},"html":{"href":"https://github.com/keybase/client/pull/11485#discussion_r184217673"},"pull_request":{"href":"https://api.github.com/repos/keybase/client/pulls/11485"}},"in_reply_to_id":184217316},"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/11485","id":183001851,"html_url":"https://github.com/keybase/client/pull/11485","diff_url":"https://github.com/keybase/client/pull/11485.diff","patch_url":"https://github.com/keybase/client/pull/11485.patch","issue_url":"https://api.github.com/repos/keybase/client/issues/11485","number":11485,"state":"open","locked":false,"title":"implement TextView using WebView; split FilePreview up","user":{"login":"songgao","id":255797,"avatar_url":"https://avatars3.githubusercontent.com/u/255797?v=4","gravatar_id":"","url":"https://api.github.com/users/songgao","html_url":"https://github.com/songgao","followers_url":"https://api.github.com/users/songgao/followers","following_url":"https://api.github.com/users/songgao/following{/other_user}","gists_url":"https://api.github.com/users/songgao/gists{/gist_id}","starred_url":"https://api.github.com/users/songgao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songgao/subscriptions","organizations_url":"https://api.github.com/users/songgao/orgs","repos_url":"https://api.github.com/users/songgao/repos","events_url":"https://api.github.com/users/songgao/events{/privacy}","received_events_url":"https://api.github.com/users/songgao/received_events","type":"User","site_admin":false},"body":"This PR integrates Taru's findings on WebView to implement a TextView component. Just the component here; I still haven't hooked up actual content yet. I think actions are mostly ready; we just need to change a few places to handle the new `web-view` and `web-view-text` intent, and perhaps add a loading screen while we copy files to local.\r\n\r\nScreenshots:\r\n\r\n<img width=\"815\" alt=\"screen shot 2018-04-20 at 4 39 39 pm\" src=\"https://user-images.githubusercontent.com/255797/39042301-0de6ddce-44bd-11e8-9a0a-915edfefe707.png\">\r\n\r\n<img width=\"815\" alt=\"screen shot 2018-04-20 at 4 39 42 pm\" src=\"https://user-images.githubusercontent.com/255797/39042308-1222c4ca-44bd-11e8-8622-044e30eb29f1.png\">\r\n\r\n<img width=\"591\" alt=\"screen shot 2018-04-20 at 4 32 45 pm\" src=\"https://user-images.githubusercontent.com/255797/39042314-15e8ac50-44bd-11e8-897b-f06e792af22f.png\">\r\n\r\n<img width=\"591\" alt=\"screen shot 2018-04-20 at 4 33 49 pm\" src=\"https://user-images.githubusercontent.com/255797/39042323-1879fe1a-44bd-11e8-8cbd-2488f96517db.png\">\r\n","created_at":"2018-04-20T09:07:34Z","updated_at":"2018-04-25T21:55:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07e0b65a39d0b7f8ae4fda11ad52dfa9574bed3a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"taruti","id":42174,"avatar_url":"https://avatars3.githubusercontent.com/u/42174?v=4","gravatar_id":"","url":"https://api.github.com/users/taruti","html_url":"https://github.com/taruti","followers_url":"https://api.github.com/users/taruti/followers","following_url":"https://api.github.com/users/taruti/following{/other_user}","gists_url":"https://api.github.com/users/taruti/gists{/gist_id}","starred_url":"https://api.github.com/users/taruti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taruti/subscriptions","organizations_url":"https://api.github.com/users/taruti/orgs","repos_url":"https://api.github.com/users/taruti/repos","events_url":"https://api.github.com/users/taruti/events{/privacy}","received_events_url":"https://api.github.com/users/taruti/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/client/pulls/11485/commits","review_comments_url":"https://api.github.com/repos/keybase/client/pulls/11485/comments","review_comment_url":"https://api.github.com/repos/keybase/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/client/issues/11485/comments","statuses_url":"https://api.github.com/repos/keybase/client/statuses/416e4bab5220f4134a4080223949096722363421","head":{"label":"keybase:songgao/KBFS-2879","ref":"songgao/KBFS-2879","sha":"416e4bab5220f4134a4080223949096722363421","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2018-04-25T21:52:25Z","pushed_at":"2018-04-25T21:54:39Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":232429,"stargazers_count":3538,"watchers_count":3538,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":341,"mirror_url":null,"archived":false,"open_issues_count":2022,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":341,"open_issues":2022,"watchers":3538,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"112b9a13f92e6ab43b1c50e327955b182b1d85ed","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2018-04-25T21:52:25Z","pushed_at":"2018-04-25T21:54:39Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":232429,"stargazers_count":3538,"watchers_count":3538,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":341,"mirror_url":null,"archived":false,"open_issues_count":2022,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":341,"open_issues":2022,"watchers":3538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/11485"},"html":{"href":"https://github.com/keybase/client/pull/11485"},"issue":{"href":"https://api.github.com/repos/keybase/client/issues/11485"},"comments":{"href":"https://api.github.com/repos/keybase/client/issues/11485/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/client/pulls/11485/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/client/pulls/11485/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/client/statuses/416e4bab5220f4134a4080223949096722363421"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"songgao"}}