{"action":"opened","number":10067,"pull_request":{"url":"https://api.github.com/repos/ElemeFE/element/pulls/10067","id":173662672,"html_url":"https://github.com/ElemeFE/element/pull/10067","diff_url":"https://github.com/ElemeFE/element/pull/10067.diff","patch_url":"https://github.com/ElemeFE/element/pull/10067.patch","issue_url":"https://api.github.com/repos/ElemeFE/element/issues/10067","number":10067,"state":"open","locked":false,"title":"lazy rendering for popover (#9814)","user":{"login":"worudso","id":23253874,"avatar_url":"https://avatars0.githubusercontent.com/u/23253874?v=4","gravatar_id":"","url":"https://api.github.com/users/worudso","html_url":"https://github.com/worudso","followers_url":"https://api.github.com/users/worudso/followers","following_url":"https://api.github.com/users/worudso/following{/other_user}","gists_url":"https://api.github.com/users/worudso/gists{/gist_id}","starred_url":"https://api.github.com/users/worudso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worudso/subscriptions","organizations_url":"https://api.github.com/users/worudso/orgs","repos_url":"https://api.github.com/users/worudso/repos","events_url":"https://api.github.com/users/worudso/events{/privacy}","received_events_url":"https://api.github.com/users/worudso/received_events","type":"User","site_admin":false},"body":"Please make sure these boxes are checked before submitting your PR, thank you!\r\n\r\n* [x] Make sure you follow Element's contributing guide ([中文](https://github.com/ElemeFE/element/blob/master/.github/CONTRIBUTING.zh-CN.md) | [English](https://github.com/ElemeFE/element/blob/master/.github/CONTRIBUTING.en-US.md) | [Español](https://github.com/ElemeFE/element/blob/master/.github/CONTRIBUTING.es.md)).\r\n* [x] Make sure you are merging your commits to `dev` branch.\r\n* [x] Add some descriptions and refer relative issues for you PR.\r\n\r\n#9814 \r\nCurrent implementation of `Popover` component renders contents before it is activated.\r\nI added `lazy` prop to enable lazy rendering of contents. When no `lazy` prop, it worked as before.\r\nIt'll allow us to use popover components with heavy contents and rare display(I'm using it for popovers inside `Table` now).\r\nAnd I think there are some components that can be improved with this design, e.g. `MessageBox`.\r\n","created_at":"2018-03-08T07:20:05Z","updated_at":"2018-03-08T07:20:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ElemeFE/element/pulls/10067/commits","review_comments_url":"https://api.github.com/repos/ElemeFE/element/pulls/10067/comments","review_comment_url":"https://api.github.com/repos/ElemeFE/element/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElemeFE/element/issues/10067/comments","statuses_url":"https://api.github.com/repos/ElemeFE/element/statuses/cb8364a52773fcccac0a4440f5eeeed9d679414a","head":{"label":"ownerclan:dev","ref":"dev","sha":"cb8364a52773fcccac0a4440f5eeeed9d679414a","user":{"login":"ownerclan","id":36292224,"avatar_url":"https://avatars2.githubusercontent.com/u/36292224?v=4","gravatar_id":"","url":"https://api.github.com/users/ownerclan","html_url":"https://github.com/ownerclan","followers_url":"https://api.github.com/users/ownerclan/followers","following_url":"https://api.github.com/users/ownerclan/following{/other_user}","gists_url":"https://api.github.com/users/ownerclan/gists{/gist_id}","starred_url":"https://api.github.com/users/ownerclan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ownerclan/subscriptions","organizations_url":"https://api.github.com/users/ownerclan/orgs","repos_url":"https://api.github.com/users/ownerclan/repos","events_url":"https://api.github.com/users/ownerclan/events{/privacy}","received_events_url":"https://api.github.com/users/ownerclan/received_events","type":"Organization","site_admin":false},"repo":{"id":121460250,"name":"element","full_name":"ownerclan/element","owner":{"login":"ownerclan","id":36292224,"avatar_url":"https://avatars2.githubusercontent.com/u/36292224?v=4","gravatar_id":"","url":"https://api.github.com/users/ownerclan","html_url":"https://github.com/ownerclan","followers_url":"https://api.github.com/users/ownerclan/followers","following_url":"https://api.github.com/users/ownerclan/following{/other_user}","gists_url":"https://api.github.com/users/ownerclan/gists{/gist_id}","starred_url":"https://api.github.com/users/ownerclan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ownerclan/subscriptions","organizations_url":"https://api.github.com/users/ownerclan/orgs","repos_url":"https://api.github.com/users/ownerclan/repos","events_url":"https://api.github.com/users/ownerclan/events{/privacy}","received_events_url":"https://api.github.com/users/ownerclan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ownerclan/element","description":"A Vue.js 2.0 UI Toolkit for Web","fork":true,"url":"https://api.github.com/repos/ownerclan/element","forks_url":"https://api.github.com/repos/ownerclan/element/forks","keys_url":"https://api.github.com/repos/ownerclan/element/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ownerclan/element/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ownerclan/element/teams","hooks_url":"https://api.github.com/repos/ownerclan/element/hooks","issue_events_url":"https://api.github.com/repos/ownerclan/element/issues/events{/number}","events_url":"https://api.github.com/repos/ownerclan/element/events","assignees_url":"https://api.github.com/repos/ownerclan/element/assignees{/user}","branches_url":"https://api.github.com/repos/ownerclan/element/branches{/branch}","tags_url":"https://api.github.com/repos/ownerclan/element/tags","blobs_url":"https://api.github.com/repos/ownerclan/element/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ownerclan/element/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ownerclan/element/git/refs{/sha}","trees_url":"https://api.github.com/repos/ownerclan/element/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ownerclan/element/statuses/{sha}","languages_url":"https://api.github.com/repos/ownerclan/element/languages","stargazers_url":"https://api.github.com/repos/ownerclan/element/stargazers","contributors_url":"https://api.github.com/repos/ownerclan/element/contributors","subscribers_url":"https://api.github.com/repos/ownerclan/element/subscribers","subscription_url":"https://api.github.com/repos/ownerclan/element/subscription","commits_url":"https://api.github.com/repos/ownerclan/element/commits{/sha}","git_commits_url":"https://api.github.com/repos/ownerclan/element/git/commits{/sha}","comments_url":"https://api.github.com/repos/ownerclan/element/comments{/number}","issue_comment_url":"https://api.github.com/repos/ownerclan/element/issues/comments{/number}","contents_url":"https://api.github.com/repos/ownerclan/element/contents/{+path}","compare_url":"https://api.github.com/repos/ownerclan/element/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ownerclan/element/merges","archive_url":"https://api.github.com/repos/ownerclan/element/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ownerclan/element/downloads","issues_url":"https://api.github.com/repos/ownerclan/element/issues{/number}","pulls_url":"https://api.github.com/repos/ownerclan/element/pulls{/number}","milestones_url":"https://api.github.com/repos/ownerclan/element/milestones{/number}","notifications_url":"https://api.github.com/repos/ownerclan/element/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ownerclan/element/labels{/name}","releases_url":"https://api.github.com/repos/ownerclan/element/releases{/id}","deployments_url":"https://api.github.com/repos/ownerclan/element/deployments","created_at":"2018-02-14T02:04:37Z","updated_at":"2018-02-14T02:04:40Z","pushed_at":"2018-03-08T07:08:04Z","git_url":"git://github.com/ownerclan/element.git","ssh_url":"git@github.com:ownerclan/element.git","clone_url":"https://github.com/ownerclan/element.git","svn_url":"https://github.com/ownerclan/element","homepage":"http://element.eleme.io/","size":34414,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"ElemeFE:dev","ref":"dev","sha":"99e5a6b4babe25f0e163f4eff12981e6cd6a0901","user":{"login":"ElemeFE","id":12810740,"avatar_url":"https://avatars1.githubusercontent.com/u/12810740?v=4","gravatar_id":"","url":"https://api.github.com/users/ElemeFE","html_url":"https://github.com/ElemeFE","followers_url":"https://api.github.com/users/ElemeFE/followers","following_url":"https://api.github.com/users/ElemeFE/following{/other_user}","gists_url":"https://api.github.com/users/ElemeFE/gists{/gist_id}","starred_url":"https://api.github.com/users/ElemeFE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElemeFE/subscriptions","organizations_url":"https://api.github.com/users/ElemeFE/orgs","repos_url":"https://api.github.com/users/ElemeFE/repos","events_url":"https://api.github.com/users/ElemeFE/events{/privacy}","received_events_url":"https://api.github.com/users/ElemeFE/received_events","type":"Organization","site_admin":false},"repo":{"id":67274736,"name":"element","full_name":"ElemeFE/element","owner":{"login":"ElemeFE","id":12810740,"avatar_url":"https://avatars1.githubusercontent.com/u/12810740?v=4","gravatar_id":"","url":"https://api.github.com/users/ElemeFE","html_url":"https://github.com/ElemeFE","followers_url":"https://api.github.com/users/ElemeFE/followers","following_url":"https://api.github.com/users/ElemeFE/following{/other_user}","gists_url":"https://api.github.com/users/ElemeFE/gists{/gist_id}","starred_url":"https://api.github.com/users/ElemeFE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElemeFE/subscriptions","organizations_url":"https://api.github.com/users/ElemeFE/orgs","repos_url":"https://api.github.com/users/ElemeFE/repos","events_url":"https://api.github.com/users/ElemeFE/events{/privacy}","received_events_url":"https://api.github.com/users/ElemeFE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ElemeFE/element","description":"A Vue.js 2.0 UI Toolkit for Web","fork":false,"url":"https://api.github.com/repos/ElemeFE/element","forks_url":"https://api.github.com/repos/ElemeFE/element/forks","keys_url":"https://api.github.com/repos/ElemeFE/element/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElemeFE/element/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElemeFE/element/teams","hooks_url":"https://api.github.com/repos/ElemeFE/element/hooks","issue_events_url":"https://api.github.com/repos/ElemeFE/element/issues/events{/number}","events_url":"https://api.github.com/repos/ElemeFE/element/events","assignees_url":"https://api.github.com/repos/ElemeFE/element/assignees{/user}","branches_url":"https://api.github.com/repos/ElemeFE/element/branches{/branch}","tags_url":"https://api.github.com/repos/ElemeFE/element/tags","blobs_url":"https://api.github.com/repos/ElemeFE/element/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElemeFE/element/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElemeFE/element/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElemeFE/element/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElemeFE/element/statuses/{sha}","languages_url":"https://api.github.com/repos/ElemeFE/element/languages","stargazers_url":"https://api.github.com/repos/ElemeFE/element/stargazers","contributors_url":"https://api.github.com/repos/ElemeFE/element/contributors","subscribers_url":"https://api.github.com/repos/ElemeFE/element/subscribers","subscription_url":"https://api.github.com/repos/ElemeFE/element/subscription","commits_url":"https://api.github.com/repos/ElemeFE/element/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElemeFE/element/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElemeFE/element/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElemeFE/element/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElemeFE/element/contents/{+path}","compare_url":"https://api.github.com/repos/ElemeFE/element/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElemeFE/element/merges","archive_url":"https://api.github.com/repos/ElemeFE/element/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElemeFE/element/downloads","issues_url":"https://api.github.com/repos/ElemeFE/element/issues{/number}","pulls_url":"https://api.github.com/repos/ElemeFE/element/pulls{/number}","milestones_url":"https://api.github.com/repos/ElemeFE/element/milestones{/number}","notifications_url":"https://api.github.com/repos/ElemeFE/element/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElemeFE/element/labels{/name}","releases_url":"https://api.github.com/repos/ElemeFE/element/releases{/id}","deployments_url":"https://api.github.com/repos/ElemeFE/element/deployments","created_at":"2016-09-03T06:19:26Z","updated_at":"2018-03-08T07:13:16Z","pushed_at":"2018-03-08T06:01:49Z","git_url":"git://github.com/ElemeFE/element.git","ssh_url":"git@github.com:ElemeFE/element.git","clone_url":"https://github.com/ElemeFE/element.git","svn_url":"https://github.com/ElemeFE/element","homepage":"http://element.eleme.io/","size":35400,"stargazers_count":23951,"watchers_count":23951,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4419,"mirror_url":null,"archived":false,"open_issues_count":300,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4419,"open_issues":300,"watchers":23951,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/ElemeFE/element/pulls/10067"},"html":{"href":"https://github.com/ElemeFE/element/pull/10067"},"issue":{"href":"https://api.github.com/repos/ElemeFE/element/issues/10067"},"comments":{"href":"https://api.github.com/repos/ElemeFE/element/issues/10067/comments"},"review_comments":{"href":"https://api.github.com/repos/ElemeFE/element/pulls/10067/comments"},"review_comment":{"href":"https://api.github.com/repos/ElemeFE/element/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElemeFE/element/pulls/10067/commits"},"statuses":{"href":"https://api.github.com/repos/ElemeFE/element/statuses/cb8364a52773fcccac0a4440f5eeeed9d679414a"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":4,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"worudso"}}